Quote from: chocomus on 2009-12-29 12:07:33

It seems that lyric does not change when song in the same cue sheet changes...

It doesn't search for new song lyrics until you tell it to reload. AFAIR previous versions didn't have that problem.

There are problem with foo_uie_lyrics2 0.4.5 and foobar 1.0: didn`t changes lyrics if playing ape\flac+cue file on next song, only with "Reload lyrics"

I like the original foo_uie_lyrics much more. I don't know what the author intends to do with the plugin, but I don't like what had already been done. "highline" doesn't work, saving lyrics file doesn't work, in addition to that when you manually search it downloads all the results even before you ask it (traffic) and keeps it somewhere (where?), most of the results are the same, what does L. M Y B. means??? sometimes the lyrics stops scrolling... I dont like, I want everything back, just more stable!

Suggestions:

1) Rollback all the changes and make the plugin F2000 1.0 compatible

->> if someone could send me  a .cue music file, that would be great

Quote from: Michael87 on 2010-01-20 21:36:42

->> if someone could send me  a .cue music file, that would be great

Select any album you have, convert to WAV with "Generate multi-track files", you end up with .wav & .cue.

Please check for callback->is_edit_mode_enabled() in your WM_CONTEXTMENU handler, the LEM context menu is currently unavailable.
Also I hope the configuration (the part related to presentation) will be handled per-instance instead of the global configuration in Preferences, allowing it to be serialized into the monolith theme file for distribution, and that the defaults will be based on the current global color scheme (maybe access them using some new custom formatting function like $color(text)?).

- possible fix for cue files (can someone please verify this?)

Quote from: Michael87 on 2010-01-20 21:36:42

- possible fix for cue files (can someone please verify this?)

I'm still having the same issue with embeded cue sheets: The lyrics don't change when the song changes, unless I click on "Reload lyric".

bool ReadLyricFromTag(const metadb_handle_ptr & track, tstring & out)
{
	//if (strnicmp("file://", path, _countof("file://") - 1)) /* Removed: Permits Query Tags From UPnP Component (http) */
	//	return false;

	if (wildcard_helper::test_path( track->get_path(), t2u(cfg_skipbyfiletype.get_value()),true) )
		return false;

	pfc::string8 tag_list = pfc::stringcvt::string_utf8_from_wide( cfg_lyric_tag.get_string_ref().c_str() ); /* Suggestion: Change Config Variables To cfg_string */
	tag_list.replace_char( ';', '\0' );

	track->metadb_lock();

	service_ptr_t<titleformat_object> script_tag;
	pfc::string8 tag, raw_tag, out_tmp;
	for( unsigned int length = 0; length < tag_list.get_length(); length += raw_tag.get_length()+1 )
	{
		raw_tag.set_string( tag_list.get_ptr()+length );
		if( !raw_tag.get_length() ) /* Empty Tag */
			continue;

		tag.set_string( "[%" );
		tag.add_string( raw_tag );
		tag.add_string( "%]" );

		static_api_ptr_t<titleformat_compiler>()->compile_safe( script_tag, tag );
		track->format_title( NULL, out_tmp, script_tag, NULL ); /* Query For Tag Content */

		if( out_tmp.get_length() > 0 ) /* Tag Content Found */
		{
			out = u2t( out_tmp.get_ptr()  );
			track->metadb_unlock();
			return true;
		}
	}

	track->metadb_unlock();
	return false;
}

- I really don't see the point of allowing a multi instance element.

For example someone might want to see lyrics both on their "playing" and "managing" layouts, switchable by tabs. Or just prepare a new theme in Scratchbox, that would be another instance too. Not speaking about having a proper paste/replace functionality, where both the element being replaced and the new replacing one coexist momentarily, IIRC, which might be a little tricky.