Quote from: Blueinferno on 2007-09-16 15:21:37

Hey, I was thinking. If you don't know how to help me with this downloading-only-10-lyrics problem, maybe you can give me a site you take lyrics from, and I'll download 'em manually. That'll be, I guess, more convenient than restarting the app after every 10 lyrics are downloaded.

Have your tried right click on the panel - > Online search?

Illegal operation:
Code: C0000005h, flags: 00000000h, address: 00DE44C8h
Access violation, operation: read, address: 011E5000h
Call path:
entry
This is the first crash logged by this instance.
Code bytes (00DE44C8h):
00DE4488h:  F7 8B 44 24 10 8B 4C 24 24 03 C8 3B D9 73 37 8B
00DE4498h:  C3 8D 57 1C 8D 70 02 90 66 8B 08 83 C0 02 66 85
00DE44A8h:  C9 75 F5 2B C6 D1 F8 50 53 8B F2 E8 88 F7 00 00
00DE44B8h:  8B 7F 30 66 83 3C 7B 00 8D 1C 7B 75 09 83 C3 02
00DE44C8h:  66 83 3B 00 74 F7 8B 7C 24 20 8D 44 24 18 E8 65
00DE44D8h:  E4 00 00 C6 44 24 38 00 8B 44 24 1C 33 F6 39 30
00DE44E8h:  75 58 50 E8 7F 8A 02 00 8B 7C 24 18 83 C4 04 83
00DE44F8h:  7F 34 08 72 0C 8B 57 20 52 E8 69 8A 02 00 83 C4
Stack (0012EF1Ch):
0012EEFCh:  023EE62C 7D5993C0 77F443DD 7D5993C0
0012EF0Ch:  00000004 00000000 023EDB38 00000000
0012EF1Ch:  0E771637 0012F024 0012F048 294A41AA
0012EF2Ch:  00000202 011E3FD0 011E3FD0 011E40B0
0012EF3Ch:  00E3606C 011E4DF0 00000202 0012F024
0012EF4Ch:  0012EFAC 00E21A00 00000001 0012EFB8
0012EF5Ch:  00E04259 0012EF84 00000206 0012F024
0012EF6Ch:  0E7716AF 0012F0E8 009F67F8 000009CB
0012EF7Ch:  0012F048 0012F024 00E29428 0012F048
0012EF8Ch:  00000000 00000206 C01D9769 490F6830
0012EF9Ch:  294A41AA 84A9FC32 0E7716AF 0012EF6C
0012EFACh:  0012F080 00E20E10 00000000 0012F08C
0012EFBCh:  00E0B87D 0040D1C2 0012F048 0012F024
0012EFCCh:  0012F114 00000003 0000016B 00000000
0012EFDCh:  0049437D 0E6DD034 00000000 0012F07C
0012EFECh:  013E02F0 00000004 0012EFE0 00000004
0012EFFCh:  009F0000 00497440 0E335A20 FFFFFFFE
0012F00Ch:  0049437D 0045CE10 000102F0 00000009
0012F01Ch:  0012EF78 013E02F0 004BE934 7C92EE00
0012F02Ch:  000000C0 FFFFFFFF 7C93056D 0049435E
Registers:
EAX: 011E3FEC, EBX: 011E5000, ECX: 00000000, EDX: 00000002
ESI: 011E3FEC, EDI: 00000049, EBP: 0012EF58, ESP: 0012EF1C
[color=#FF0000]Crash location: "foo_uie_lyrics", [/color] loaded at 00DE0000h - 00E41000h

Loaded modules:
foobar2000                       loaded at 00400000h - 004F3000h
ntdll                            loaded at 7C920000h - 7C9B4000h
kernel32                         loaded at 7C800000h - 7C91D000h
COMCTL32                         loaded at 77180000h - 77283000h
msvcrt                           loaded at 77BE0000h - 77C38000h
ADVAPI32                         loaded at 77DA0000h - 77E49000h
RPCRT4                           loaded at 77E50000h - 77EE1000h
GDI32                            loaded at 77EF0000h - 77F37000h
USER32                           loaded at 77D10000h - 77D9F000h
SHLWAPI                          loaded at 77F40000h - 77FB6000h
SHELL32                          loaded at 7D590000h - 7DD82000h
ole32                            loaded at 76990000h - 76ACD000h
shared                           loaded at 10000000h - 10029000h
comdlg32                         loaded at 76320000h - 76367000h
IMM32                            loaded at 76300000h - 7631D000h
LPK                              loaded at 62C20000h - 62C29000h
USP10                            loaded at 73FA0000h - 7400B000h
MSCTF                            loaded at 74680000h - 746CB000h
msctfime                         loaded at 73640000h - 7366E000h
foo_cdda                         loaded at 00A60000h - 00A95000h
foo_converter                    loaded at 00AC0000h - 00B29000h
foo_dsp_std                      loaded at 00B50000h - 00B91000h
foo_input_monkey                 loaded at 00BC0000h - 00C0A000h
foo_input_std                    loaded at 00C30000h - 00D42000h
foo_rgscan                       loaded at 00D70000h - 00DB8000h
foo_uie_lyrics                   loaded at 00DE0000h - 00E41000h
gdiplus                          loaded at 4AE90000h - 4B033000h
WININET                          loaded at 00E60000h - 00F2E000h
Normaliz                         loaded at 00F30000h - 00F39000h
iertutil                         loaded at 5DCA0000h - 5DCE5000h
WINMM                            loaded at 76B10000h - 76B3A000h
foo_ui_columns                   loaded at 011F0000h - 01296000h
foo_ui_std                       loaded at 012C0000h - 01317000h
foo_unpack                       loaded at 01340000h - 0136E000h
imagehlp                         loaded at 76C60000h - 76C88000h
DBGHELP                          loaded at 68D60000h - 68E01000h
VERSION                          loaded at 77BD0000h - 77BD8000h

Stack dump analysis:
Address: 00E21A00h, location: "foo_uie_lyrics", loaded at 00DE0000h - 00E41000h
Address: 00E04259h, location: "foo_uie_lyrics", loaded at 00DE0000h - 00E41000h
Address: 00E29428h, location: "foo_uie_lyrics", loaded at 00DE0000h - 00E41000h
Address: 00E20E10h, location: "foo_uie_lyrics", loaded at 00DE0000h - 00E41000h
Address: 00E0B87Dh, location: "foo_uie_lyrics", loaded at 00DE0000h - 00E41000h
Address: 0040D1C2h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0049437Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00497440h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0049437Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0045CE10h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004BE934h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C92EE00h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "strchr" (+000000FFh)
Address: 7C93056Dh, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlFreeHeap" (+00000130h)
Address: 0049435Eh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0049437Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004BE93Ch, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004AC659h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004BE934h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0040A711h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0040A71Eh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004A6392h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0048CD80h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00DE0000h, location: "foo_uie_lyrics", loaded at 00DE0000h - 00E41000h
Address: 00E348DCh, location: "foo_uie_lyrics", loaded at 00DE0000h - 00E41000h
Address: 00481422h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C6804h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004DE494h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004A6508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0040AF92h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004BC416h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 77DD7BAEh, location: "ADVAPI32", loaded at 77DA0000h - 77E49000h
Symbol: "IsTextUnicode" (+0000A5B1h)
Address: 7DB22846h, location: "SHELL32", loaded at 7D590000h - 7DD82000h
Address: 004DE474h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C0084h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E1B74h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004BC416h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004AC6F0h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004308CFh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C930732h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C9306EBh, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+00000117h)
Address: 7C9305D4h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+00000000h)
Address: 7C930738h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+00000164h)
Address: 7C930732h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 7C930732h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 7C931538h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "wcsncpy" (+00000AA9h)
Address: 7C931596h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "wcsncpy" (+00000B07h)
Address: 7C9306EBh, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+00000117h)
Address: 004E41B8h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C93056Dh, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlFreeHeap" (+00000130h)
Address: 1000C021h, location: "shared", loaded at 10000000h - 10029000h
Address: 7C92EE18h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "strchr" (+00000117h)
Address: 7C9306F0h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+0000011Ch)
Address: 7C92EE18h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "strchr" (+00000117h)
Address: 7C9306F0h, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+0000011Ch)
Address: 7C9306EBh, location: "ntdll", loaded at 7C920000h - 7C9B4000h
Symbol: "RtlAllocateHeap" (+00000117h)
Address: 00492BFDh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E4238h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00447B71h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0045CE23h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0049976Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00497440h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 10002D87h, location: "shared", loaded at 10000000h - 10029000h
Symbol: "uPrintCrashInfo_SetDumpPath" (+000000A7h)
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004AF584h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00430CAAh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E09B0h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0049712Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00492502h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004924FCh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004B49E0h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004B3450h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E4230h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00497440h, location: "foobar2000", loaded at 00400000h - 004F3000h

Version info: 
foobar2000 v0.9.4.4
UNICODE

Artist: H.I.M
Album: 
Title: gone with the sin (Radio Edit)
By: 
Offset: -40500

[00:-38.-21]ohh... my Baby, 
[00:-34.-43]how beautiful you are
[00:-28.-76]ohh...my Darling, 
[00:-23.-79]completely torn apart
[00:-19.-21]
[00:-18.-53]You're gone with the sin my Baby
[00:-13.-50]and beautiful you are
[00:-8.-17]so gone with the sin my Darling
[00:00.-95]
[00:02.39]I love your skin oh so white
[00:12.15]I love your touch cold as ice
[00:23.15]And I love every single tear you cry
[00:32.46]I just love the way you're losing your life
[00:40.48]

[ar:HIM]
[ti:gone with the sin]
[offset:-40499]

[00:02.39]I love your skin oh so white
[00:12.15]I love your touch cold as ice
[00:23.15]And I love every single tear you cry
[00:32.46]I just love the way you're losing your life
[00:40.47][01:23.95][02:05.93][02:46.43][02:52.21][02:59.09][03:07.52][04:11.39] 
[00:43.73][02:07.45][03:31.36]ohh... my Baby,
[00:48.37][02:12.03][03:35.99]how beautiful you are
[00:53.87]ohh...my Darling,
[00:59.01][02:22.63][03:46.67]completely torn apart

There's a bug in the latest DEV version, the plugin will create empty lrc files inside my download directory and associate them with the file despite the fact that my settings are:

- Do not download from the Internet
- When Lyric Found from directory: Do nothing.

By the way, can you make the latest DEV version's source code available?

Would it be possible to implement hot keys, especially for "embed lyric" and "online search"? Furthermore it would be great if the window "Online Search" could be active right after calling it, so that you can just hit the enter key to start the search. Or even better, if the search would start right after hitting a hot key. Thank you in advance for considering.

Thanx again for your great work and the improvement of the original component.

Greetings from Berlin, Germany

at first: Thanks T.P Wang for the great mod of Lyrics Show!
I don't know if the fellowing bug is ever mentioned...
If i switch from an windows which overlap the lyrics panel to foobar2000, the panel render the part of the window which have overlapped foobar. its the same with context elements...

i've seen this with the latest DEV-version. both, in PanelsUI and ColumnsUI and there even if you switch between Tabs in your columns layout.
Display settings are: enabled Transparency, scroll, fading and scoll without timestamp

bye

I'm still experiencing problem with downloading lyrics. I can download only 10 lyrics and then it stops downloading. Since T.P Wang isn't able to help, maybe someone else is having the same problem, and can help me? It kinda freaks me out, when I have to restart foobar after every 10 lyrics are downloaded.

I just don't know what's wrong, T.P Wang says it's working for him perfectly. I am using Windows XP Pro, foobar2000 v0.9.4.4 and am polish, if it can help.

The proxy thing aint working ..  .. Even when I try Right Click > Online search and click on Search, the message comes Search Failed ..

The same proxy settings are working fine in Audioscrobler plugin settings ..

I am having an HTTP proxy with authentication enabled .. So cant use IE Proxy settings ..

I've created LyricsCreator. You can use it with conjuction of Lyrics Show Panel, as there isn't feature of creating/editing lyrics.

one bug for this panel. When I double clicks a song named start to open it in foobar, this error will be showd. You can rename a song's name as 'start' to try.
file location: E:\LocalUser\Gongqing\File\Personal\??\??flash8?\start.mp3
When I move the song to another folder, there isn't this error. Maybe the error is not about song's name.

How do I get it so that it will only load a .LRC or .TXT if it has the same filename as the current track, and so that it will also save the downloaded track with the same filename?

edit: Actually, thinking about it, that will stuff up all the .flac and .cue album rips. Is it possible to get it to append a track number in those cases only?

One more edit:

Doesnt seem to handle negative timestamps like you get when you have moved the offset then sync some lines at the start of the song in minilyrics...

Code: [Select]

Artist: H.I.M
Album: 
Title: gone with the sin (Radio Edit)
By: 
Offset: -40500

[00:-38.-21]ohh... my Baby, 
[00:-34.-43]how beautiful you are
[00:-28.-76]ohh...my Darling, 
[00:-23.-79]completely torn apart
[00:-19.-21]
[00:-18.-53]You're gone with the sin my Baby
[00:-13.-50]and beautiful you are
[00:-8.-17]so gone with the sin my Darling
[00:00.-95]
[00:02.39]I love your skin oh so white
[00:12.15]I love your touch cold as ice
[00:23.15]And I love every single tear you cry
[00:32.46]I just love the way you're losing your life
[00:40.48]

becomes

Code: [Select]

[ar:HIM]
[ti:gone with the sin]
[offset:-40499]

[00:02.39]I love your skin oh so white
[00:12.15]I love your touch cold as ice
[00:23.15]And I love every single tear you cry
[00:32.46]I just love the way you're losing your life
[00:40.47][01:23.95][02:05.93][02:46.43][02:52.21][02:59.09][03:07.52][04:11.39] 
[00:43.73][02:07.45][03:31.36]ohh... my Baby,
[00:48.37][02:12.03][03:35.99]how beautiful you are
[00:53.87]ohh...my Darling,
[00:59.01][02:22.63][03:46.67]completely torn apart

when I copy it back out (trimmed for shortness here) and the starting lines dont show in the panel

Where does lyrics come from ? Is it possible to upload quickly modified lyrics ?

There is one more feauture, that I'm missing right now.

Imagine this situation: mp3 tagged with a non timestamped lyric

Could you add an option, so that your plugin automatically searches for a timestamped lyric and replaces the non timestamped lyric if one is found and otherwise continues to show the non timestamped one?

I hope my english is understandable.

I save lyrics in files.
When there's a bracket '(' in file name (i.e. in title tag for example), content of file is deleted !

ps: this bug occurs only when file is .txt !
Edit: in fact it seems to be only when 'download automatically' option is UNcheck...
Edit2: in fact, when 'download automatically' option is UNcheck, an empty file in .txt is created and then it's impossible to keep lyrics... Boring bug.

Feature Request:

Would it be possible to add either (or both) of the following:

1. Before the next line is highlighted in a stamped set of lyrics, would it be possible to flash the currently highlighted lyrics another color a user set time before going to the next set of lyrics?
For example:

[01:39:17]LINE 1
[01:42:12]LINE 2 <-- Currently playing line will flash GREEN 1 second before going to "LINE 3"
[01:53:67]LINE 3
[01:57:03]LINE 4

2. Having the option to ONLY flash another color if the distance between LINE 1 and LINE 2 is greater than 5 seconds (of course, having this time span definable would be nice).

I think this would be great for people who want to sing along to their songs. Especially when there are lyrics, then an instrument break, then more lyrics. Sometimes you don't quite know when the next set of lyrics are going to start until they actually do.

This is different than highlighting because highlighting lights them up AS they are playing, while this flashing will light up a user set time limit BEFORE the lyrics are sung. It will get the flash time based on the current stamp. It will subtract the user inputted time from the stamp and flash.

Hopefully this makes sense  .

Big crash when I've selected "Adjust offset" on context menu. I've chosen delay, press OK and... crash. 

Latest dev version.

Hum, in fact, I have a lot of crashes. I just have to change song and there's a crash. :/

now:
|     This is the 1'st extremely long lyr|
|     This is the 2'nd extremely long lyr|

proposed:
|     This is the 1'st extremely long    |
|     lyrics line.                                    |
|     This is the 2'nd extremely long   |
|     lyrics line.                                    |

First, I want to admit that it's one of the best (and extremely useful for me) plugins for Foobar. And I want to say "Thank you a lot!" to its author.

And I want to ask 2 questions which (maybe) help making it better - who knows?

1) The most preferrable text align for me is "Center Left". But in some cases when lyrics consists of LONG lines of text, the endings of each line are cut off completely and I can't see them at all. Wouldn't it be better to do some word wrap in this case? Example:

Code: [Select]

now:
|     This is the 1'st extremely long lyr|
|     This is the 2'nd extremely long lyr|

proposed:
|     This is the 1'st extremely long    |
|     lyrics line.                                    |
|     This is the 2'nd extremely long   |
|     lyrics line.                                    |

2) I can't understand why simple lyrics displaying "eats" such a huge amount of processor resources. If I look in Process Explorer (or Task Manager, it doesn't matter), I see that foobar2000.exe process uses about 1.96 ... 3.4 percent of CPU. If I turn Lyrics Show Panel off completely (for example, use exactly the same ColumnsUI layout, but without this panel), I can't see CPU using at all (and it's true cause foobar itself "eats" extremely low CPU rescources)!

"Fading" is turned off in settings. Is it normal that simple "show lyrics" plugin uses at least 3 times more CPU time than complete foobar player itself with some additional plugins (album art, track info etc)?

The lyrics panel is creating lots and lots of empty 0kb files for songs that I don't have a lyric for.

My settings for the panel on the internet page is all the boxes unchecked, save scheme: Save to my own directory.

Using Version:
Build on: Sep 16 2007 08:44:03
With Panel API version: 6.1