on_size() {
		this.debounce = $.debounce(() => {
			if (ppt.text_only) {
				this.clearCovCache();
				this.getFbImg();
			}
			if (ppt.text_only && !ui.style.isBlur && !ppt.showFilmStrip) return this.init = false;
			filmStrip.logScrollPos();
			this.clearCache();
			if (ppt.artistView) {
				if (this.init) this.artistReset();
				this.getArtImg();
			} else {
				this.getFbImg();
				if (this.init) {
					this.id.albCyc = '';
					this.id.curAlbCyc = '';
				}
			}
			this.init = false;
			if (ppt.img_only) panel.getList(true, true);
			but.refresh(true);
		}, 500);
		this.debounce();
	}

About the image resizing, there are some factors to keep in mind when it comes to performance.

01. JavaScript is single-threaded and can not process various code in multi-tasking ( let's not start discussion with the web workers )
     That means, the better your single-threaded CPU performs, the faster the code execution with its task will finish.
     Here is the list: https://www.cpubenchmark.net/singleThread.html
     I would still buy AMD CPU's though because multi-threading is more important.

02. You need to keep in mind that there are a lot of heavy CPU intensive tasks going on in the background.
      For example drawing various UI elements ( in your video EOLE has two blended background images, with filmstrip images, with
      continuous lyrics refresh update and playlist, Georgia-ReBORN has beveled bars, styled buttons, rounded progress bar,
      blended background image in biography, filmstrip and playlist ). Also GDI+ is a slow and old graphics renderer.
      @TheQwertiest, has planned to implement Direct2D which would help and have better performance.

03. Performance hit also occurs depending on image size/resolution. If your CPU is old and slow, you can test and try open large
      images in Windows Photo Viewer, e.g 5 mb -10 mb images versus small images, e.g 100 kb - 500 kb images. Then cycle through
      those images and you will see the difference. So this also applies to Biography image resizing, keep in mind it also needs to
      process and finish all tasks illustrated in point 02.

---

Image resizing happens in the on_size callback. When you resize the player, numerous calls need to be executed and finished which are stacked in the queue.
For better performance, you could debounce the on_size method in images.js, like this:

Code: [Select]

	on_size() {
		this.debounce = $.debounce(() => {
			if (ppt.text_only) {
				this.clearCovCache();
				this.getFbImg();
			}
			if (ppt.text_only && !ui.style.isBlur && !ppt.showFilmStrip) return this.init = false;
			filmStrip.logScrollPos();
			this.clearCache();
			if (ppt.artistView) {
				if (this.init) this.artistReset();
				this.getArtImg();
			} else {
				this.getFbImg();
				if (this.init) {
					this.id.albCyc = '';
					this.id.curAlbCyc = '';
				}
			}
			this.init = false;
			if (ppt.img_only) panel.getList(true, true);
			but.refresh(true);
		}, 500);
		this.debounce();
	}

Try playing with various refresh rates, e.g 25, 50, 100, 250, 500, 750, 1000 ( the higher, the better performance ).
When using slow refresh rates, it will have ugly image resizing delays when resizing the player.

The best of course would be to just buy a faster CPU

-TT

class Images {
	constructor() {
       // Put the debounce code at the end of the constructor
	}
}

on_size() {
	this.debounce();
}

Fortunately, Biography runs fine on your theme because your left side never changes size.

I've forgot to tell you that you can put the whole debounce method in the Image's constructor to be sure to call it only once in on_size to improve performance:

Code: [Select]

class Images {
	constructor() {
       // Put the debounce code at the end of the constructor
	}
}

Code: [Select]

on_size() {
	this.debounce();
}

Quote from: Majestyk on 2023-11-11 21:55:56

Fortunately, Biography runs fine on your theme because your left side never changes size.

What do you exactly mean by that? You can change width or height or both at the same time so all the sizes change.

P.S So yeah, I've read the kahel's posts you pointed out and it confirms that it very well may be the slow old GDI+ ( that SMP is using )
I've mentioned at the end in point 02. JSP uses Direct2D which should have better performance of course...

-Tom

The video comparison is not really fair, try to disable filmstrip and use the Biography's default theme "User Interface", i.e no blending.
( The blending, bio themes "Dark", "Blend", "Light", "Random" are complex and CPU intensive ).
You will see the resizing performance is much better when you're using the default settings, because it does not need to calculate
the large blended background image, the filmstrip thumbnails and the large image itself.

Drawing blended backgrounds/images ( basically blends the large image in the background ), gradients, fast refresh rates, etc
hits on the performance. It also depends how many UI elements have these styles that need to be constantly drawn.
I know this from experience when I've created the many theme presets in Georgia-ReBORN, the performance will become even
worse when the window size becomes larger and larger. 4K res hits even harder.
But if you have a decent CPU, even a 4K res player size with different styles should not be a problem because you listen to music
and do not constantly resize your player all the time...

You can also check and test for yourself, I have implemented various Georgia-ReBORN performance presets depending
on CPU speed. If you want to stress test your CPU, try top menu Options > Settings > Theme performance > Highest quality.
This preset was intended only for benchmark on very high end CPUs, it hits really hard if additionally using a blended
preset, for example top menu Options > Preset > Reborn > Blended and now also go to the Details panel.
When using slow and decent CPUs, foobar will become unresponsive. To make it responsive again, click the foobar pause button
when mouse hovering on your desktop taskbar.
Then you can right click on the progress bar and change refresh rate to 60 or 100 ms, disable disc art opacity etc.
Or just change to high/balanced performance preset. As you see, it all depends on various operations how complex drawing is...

So all in all, I still blame the poor performance of GDI+ when drawing complex elements and large images.

-Tom

let's not start discussion with the web workers

What is the best/easiest way to disable the filmstrip in WilB's biography script?

Hi everyone

I have problem with dowloading picture from last.fm on bioghrapy 1.4.1. I don't know why.

I using DarkOne4Mod v1.0 (SMP). Before picture was downloading.

Maybe you have idea what i should to do or what check on settings?

In attachement few screenshot from my settings.

Thx for help.

https://last.fm/music/+noredirect/ARTIST_NAME/+images

The issue is probably related to the redirect (see last.fm web site screenshot).

I guess the url could be formed like this...

Code: [Select]

https://last.fm/music/+noredirect/ARTIST_NAME/+images

Allmusic hasn't worked in a few weeks now. Inspecting the website html in the browser doesn't show the review text at all so scripts like this can't scrape it. Pretty sure nothing can be done about that.

...
  if (!0 === t.scroll && (window.location.hash = "userReviews"), !i.next().hasClass("tabContent")) {
...

var url = "https://www.allmusic.com/album/nowhere-to-go-but-up-mw0004132140#review";

// second arg 0 means GET request
utils.HTTPRequestAsync(window.ID, 0, url); // returns a task_id but we don't need it here

function on_http_request_done(task_id, success, response) {
   if (success) utils.ShowPopupMessage(response);
   else utils.ShowPopupMessage("FAIL :/");
}