Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Georgia-ReBORN - A Clean foobar2000 Theme (Read 173649 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #700
This is not a recommendation for general use but you can disable the auto-update check on startup via top Menu
Help > Theme > Updates > Auto-check for theme updates. When it's disabled, the user won't know when a new update on
was released. The "phone home" on foobar startup does not have any performance impact, it just makes one web request to
https://github.com/TT-ReBORN/Georgia-ReBORN/releases and checks if there was a new update published.

-Tom

 

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #701
Is there an option in Biography to display the artist images when in album view, as opposed to the cover art?

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #702
Is there an option in Biography to display the artist images when in album view, as opposed to the cover art?

Yes there is an option, in the Biography right click for context menu > Sources > Cover > Cycle from folder.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #703
Awesome, thanks!

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #704
Good Evening Guys.

I am experiencing an issue ever since trying to upgrade to Foobar2000 2.x.

Spider Monkey Panel crashes with this exception:
--------------------
Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC2 by TT)
CreateImage failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: gr-helpers.js
Line: 1293, Column: 26
Stack trace:
  RotateImg@gr-helpers.js:1293:26
  setDiscArtRotationTimer/discArtRotationTimer<@gr-main-functions.js:2534:42
--------------------


Environment:
  • foobar2000_v2.1_preview_2023-10-30 (Although this has happened since version 2.0, does not happen in version 1.6.16)
  • Georgia-ReBORN_v3.0-RC2
  • 3 different PC's, different hardware all running Windows 11 22H2 (All machines are quite fast one being an i9-13900kf)
  • Resolution 4k - 3840*2160

Conditions:
  • ONLY when in full screen mode (Is fine when in a windowed state)
  • ONLY crashes when a custom CD.png is loaded. (Will not crash when the CD placeholders are spinning)
  • The crash will occur whenever I turn on "Spin Disk Art When Songs Play"  (It does not matter what the Spin speed, degree settings, or CD visibility settings are, and crashes after about 3 or 4 seconds)
  • An example CD.png that does crash has the following parameters:  File size: 1.43Mb, Dimensions: 1000x1000 32bit (I have attached the CD.png image)

Some CD.png images i created earlier go beyond 1000x1000 but it was pretty laggy loading/spinning when the images were huge.

Seems the error is occurring during the "setWindowSizeLimitsForLayouts" functions but I have no idea what i'm looking at in the script.

As of now if I leave the spin off, everything works fine.  Any help would be greatly appreciated as I would like to turn it back on.   ;D

Thanks,
Jerry.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #705
Hi @Jjkbuysell,

never had this issue and you are the first one to report this. Download the latest master version and give it a try:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip
Actually you only need to replace the gr-helpers.js from the zip file with your existing one.

Thanks for reporting the issue.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #706
Thanks for the quick reply much appreciated.  I replaced the  gr-helpers.js, it still crashes but the message is a bit different:

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC2 by TT)
CreateImage failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: gr-helpers.js
Line: 1294, Column: 26
Stack trace:
  RotateImg@gr-helpers.js:1294:26
  setDiscArtRotationTimer/discArtRotationTimer<@gr-main-functions.js:2534:42
  execute@Control_ContextMenu.js:471:23
  handleContextMenu@gr-callbacks.js:1010:7
  on_mouse_rbtn_up@gr-callbacks.js:1023:3


Also seems like when i switch albums with 'next track' when on the details page with the cd spinning, i get a different error, not sure if it is related.

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC2 by TT)
InvertColours failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: gr-main-functions.js
Line: 2602, Column: 45
Stack trace:
  getBandLogo@gr-main-functions.js:2602:45
  on_playback_new_track@gr-callbacks.js:236:2


 

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #707
Can you please tell me step by step how to reproduce? You're using 4K mode?
The more information I have, the better. Because I can not reproduce this even with your disc art image...
From the crash log, you are using the right click context menu, you are using CD-custom placeholder?
The second crash seems also weird, can be related, there seems to be some issues with the image that can not be processed
correctly...

Can you put:
console.log(`Img: ${img}, Width: ${w}, Height: ${h}`);
in gr-helpers.js , line 1290 like this:
Code: [Select]
function RotateImg(img, w, h, degrees) {
if (w <= 0 || h <= 0) return img;
else if (degrees !== 0) {
console.log(`Img: ${img}, Width: ${w}, Height: ${h}`);
/** @type {GdiBitmap} */
const rotatedImg = gdi.CreateImage(w, h);
const gotGraphics = rotatedImg.GetGraphics();
gotGraphics.DrawImage(img, 0, 0, w, h, 0, 0, img.Width, img.Height, degrees);
rotatedImg.ReleaseGraphics(gotGraphics);
return rotatedImg;
}
return img.Clone(0, 0, img.Width, img.Height).Resize(w, h);
}

Then open top menu > View > Console and let the crash happen, copy and paste the width and height from the console here.

P.S Do you have enough ram available?

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #708
1. open foobar2000 in fullscreen mode (4k desktop, and 4k setting under display in theme)
2. Go to my playlist
3. Play any song in the list that has a custom CD.png.  (Now even the placeholder crashes as well)
4. Switch to Details view.
5. Crash.

Update1 :now it crashes with the placeholders in fullscreen as well.  Same error as below.
Update2 :since i'm learning how this kinda works with the logs when i change the cd degrees from 2 to 5 (Default) it does not crash.

When the crash happened below I had 56Gb of memory free of 64Gb.  So no issue there.
Looks like it created 91/180 images then crashed.

I have added the line you requested here is the output:

creating 180 rotated disc images, shown every 30ms
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
Img: [object GdiBitmap], Width: 1832, Height: 1832
foo_spider_monkey_panel:
Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC2 by TT)
CreateImage failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: gr-helpers.js
Line: 1295, Column: 26
Stack trace:
  RotateImg@gr-helpers.js:1295:26
  setDiscArtRotationTimer/discArtRotationTimer<@gr-main-functions.js:2534:42

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #709
Thanks for the additional info, I can reproduce it now.
As you figured it out, it is indeed the disc art rotation images '180 (2 degrees)' when in 4K mode.
This eats a LOT of ram on such high disc art image resolution, especially on 2 degrees.
It seems with foobar 32-bit ( can handle only max 4 gigs ) it fills and reaches its limit and then crashes.

I've done some test and for me it crashes when using 1600x1600px res:

Code: [Select]
function RotateImg(img, w, h, degrees) {
w = 1600;
h = 1600;
console.log(`Img: ${img}, Width: ${w}, Height: ${h}`);
if (degrees !== 0) {
/** @type {GdiBitmap} */
const rotatedImg = gdi.CreateImage(w, h);
const gotGraphics = rotatedImg.GetGraphics();
gotGraphics.DrawImage(img, 0, 0, w, h, 0, 0, img.Width, img.Height, degrees);
rotatedImg.ReleaseGraphics(gotGraphics);
return rotatedImg;
}
return img.Clone(0, 0, img.Width, img.Height).Resize(w, h);
}

when changing to 1500x1500px it is OK with the 2 degrees rotation.
Can you confirm this yourself? Just copy and paste the code above and replace it in the same helper function
where you previously pasted the console.log. The rotation creates images from the disc art and fills the memory until it has spun 360°
 for the very first time. Then the rotation performance is much better because it reads those images directly from memory.

If confirmed, try the proper fix with a set max resolution:
Code: [Select]
function RotateImg(img, w, h, degrees) {
const maxImgRes = 1500;
w = Math.min(w, maxImgRes);
h = Math.min(h, maxImgRes);
if (degrees !== 0) {
/** @type {GdiBitmap} */
const rotatedImg = gdi.CreateImage(w, h);
const gotGraphics = rotatedImg.GetGraphics();
gotGraphics.DrawImage(img, 0, 0, w, h, 0, 0, img.Width, img.Height, degrees);
rotatedImg.ReleaseGraphics(gotGraphics);
return rotatedImg;
}
return img.Clone(0, 0, img.Width, img.Height).Resize(w, h);
}

Thanks!

-Tom

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #710
Confirmed working.  Thanks!   I'm looking to be safe at the 1000px area.  @1500px if I am switching tracks (with different cd art) too fast I will see that 2nd crash.  I assume this is due to foobar2000 breaking the 4gb memory limitation again. 

If there is anything else you ever want me to test just let me know.

Thank you for the support, much appreciated.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #711
Confirmed working.  Thanks!   I'm looking to be safe at the 1000px area.  @1500px if I am switching tracks (with different cd art) too fast I will see that 2nd crash.  I assume this is due to foobar2000 breaking the 4gb memory limitation again. 

If there is anything else you ever want me to test just let me know.

Thank you for the support, much appreciated.

OK, I did not take into consideration the fast track switching and the artist and band logos.
If the memory is full, it can not draw any images ( including the artist and band logos ) and will crash.
I thought that 1400x1400 is the acceptable res for 4K ( it did not crash for me ), the placeholders were also created in that resolution.

My CPU is too slow ( in 4K with these rotation degrees ) when changing really fast between different albums.
Can you do some more testing for me as you own a fast CPU? I need to have the perfect res numbers for each rotating images setting:
-   90 (4 degrees)
- 120 (3 degrees)
- 180 (2 degrees)

It would be great to have numbers for these 3 rotating image settings and have best quality without crashing.
Use this code here again with the width and height res value placeholder and test which resolution is best for each rotating image setting:
Code: [Select]
function RotateImg(img, w, h, degrees) {
w = 1400;
h = 1400;
console.log(`Img: ${img}, Width: ${w}, Height: ${h}`);
if (degrees !== 0) {
/** @type {GdiBitmap} */
const rotatedImg = gdi.CreateImage(w, h);
const gotGraphics = rotatedImg.GetGraphics();
gotGraphics.DrawImage(img, 0, 0, w, h, 0, 0, img.Width, img.Height, degrees);
rotatedImg.ReleaseGraphics(gotGraphics);
return rotatedImg;
}
return img.Clone(0, 0, img.Width, img.Height).Resize(w, h);
}

Keep in mind when lowering the resolution, the disc art image quality will suffer and degrade.
P.S 120 (3 degrees) and 180 (2 degrees) are very high and high settings for 4K.

P.P.S If other users have also a fast CPU and 4K, they can also do these test and post their results here, I would appreciate it!

Thanks a lot!

-Tom

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #712
Sorry for the delayed response.  I will test the above on the weekend and reply back.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #713
I'm having two issues with your theme regarding ESLyrics.

1) I can never see the lyrics of the first track played. I only get Searching For Lyrics Please Wait. Also when the lyrics are displayed, they will disappear when I minimize or maximize the theme and they will be replaced by Searching For Lyrics Please Wait.

2) This issue extends to my Darkone tweak theme as well. Minilyrics doesn't seem to be working anymore. If I deselect everything except Minilyrics nothing is found. But when I replace your minilyrics.js file (the one you came out with in September) with an older one by ohyeah, it will work just fine.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #714
Confirmed working.  Thanks!   I'm looking to be safe at the 1000px area.  @1500px if I am switching tracks (with different cd art) too fast I will see that 2nd crash.  I assume this is due to foobar2000 breaking the 4gb memory limitation again. 

If there is anything else you ever want me to test just let me know.

Thank you for the support, much appreciated.

OK, I did not take into consideration the fast track switching and the artist and band logos.
If the memory is full, it can not draw any images ( including the artist and band logos ) and will crash.
I thought that 1400x1400 is the acceptable res for 4K ( it did not crash for me ), the placeholders were also created in that resolution.

My CPU is too slow ( in 4K with these rotation degrees ) when changing really fast between different albums.
Can you do some more testing for me as you own a fast CPU? I need to have the perfect res numbers for each rotating images setting:
-   90 (4 degrees)
- 120 (3 degrees)
- 180 (2 degrees)

It would be great to have numbers for these 3 rotating image settings and have best quality without crashing.
Use this code here again with the width and height res value placeholder and test which resolution is best for each rotating image setting:
Code: [Select]
function RotateImg(img, w, h, degrees) {
w = 1400;
h = 1400;
console.log(`Img: ${img}, Width: ${w}, Height: ${h}`);
if (degrees !== 0) {
/** @type {GdiBitmap} */
const rotatedImg = gdi.CreateImage(w, h);
const gotGraphics = rotatedImg.GetGraphics();
gotGraphics.DrawImage(img, 0, 0, w, h, 0, 0, img.Width, img.Height, degrees);
rotatedImg.ReleaseGraphics(gotGraphics);
return rotatedImg;
}
return img.Clone(0, 0, img.Width, img.Height).Resize(w, h);
}

Keep in mind when lowering the resolution, the disc art image quality will suffer and degrade.
P.S 120 (3 degrees) and 180 (2 degrees) are very high and high settings for 4K.

P.P.S If other users have also a fast CPU and 4K, they can also do these test and post their results here, I would appreciate it!

Thanks a lot!

-Tom

So for me on an i9-13900KF with plenty of system ram these are the maximums I could go to (with fast switching) before crashing:

I only tested -50px increments after experiencing the 1st crash at every level.

-   90 (4 degrees) 1450x1450
- 120 (3 degrees) 1300x1300
- 180 (2 degrees) 1000x1000

I also have very high quality artwork for the Artist/Label not sure what that impact is.  I quickly learned before that anything over 1500x 1500 for label art makes foobar2000 sluggish to load while switching tracks.  Not sure if you do resizing work on the other artwork or just the animation artwork.  I have attached some image dimension examples for Artist and Label.  I like to work in High Quality Artwork, but looks like this is biting me in the ass.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #715
@Majestyk,

thanks for the reporting!
I will take a look once I finished some stuff.

---

@Jjkbuysell,

thanks a lot for your time and testing!
I will then use these resolutions to be on the safe side:
-   90 (4 degrees) 1400x1400
- 120 (3 degrees) 1200x1200
- 180 (2 degrees) 1000x1000

When doing really fast album switches, it takes a few seconds to free some memory space and it is
quite demanding for the CPU, loading all images, caching, rotation and other calculations...

For 4K, the max image resolution in Georgia-ReBORN is 1832x1832 ( fullscreen ) as you posted above.
So people who are storing their images in 3000x3000 are future proof and these would look great on 8K displays.
The higher the image resolution, the more memory space ( ram ) it will need.

I'm really excited when SMP 64-bit will be released, then most likely there won't be any of such issues and limitations...

-Tom

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #716
Minilyrics doesn't seem to be working anymore. If I deselect everything except Minilyrics nothing is found. But when I replace your minilyrics.js file (the one you came out with in September) with an older one by ohyeah, it will work just fine.
What is the version number of the working Minilyrics.js as it appears in Lyric Sources?  The new .4 stopped working here too, although site is active.

Edit:  .3 not working also;  can you please post the working version as an attachment?  Thanks!


Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #718
Thanks for version .5, works fine now!

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #719
@Majestyk,

1) I can never see the lyrics of the first track played. I only get Searching For Lyrics Please Wait. Also when the lyrics are displayed, they will disappear when I minimize or maximize the theme and they will be replaced by Searching For Lyrics Please Wait.

I can not see any of these issues nor reproduce. Maybe you are using old ESLyric config files, please download from master or
RC-2 and update the config files ( foobar2000\profile\configuration ). In the past I have made some ESLyric config setting changes regarding fetching lyrics.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #720
@Majestyk,

1) I can never see the lyrics of the first track played. I only get Searching For Lyrics Please Wait. Also when the lyrics are displayed, they will disappear when I minimize or maximize the theme and they will be replaced by Searching For Lyrics Please Wait.

I can not see any of these issues nor reproduce. Maybe you are using old ESLyric config files, please download from master or
RC-2 and update the config files ( foobar2000\profile\configuration ). In the past I have made some ESLyric config setting changes regarding fetching lyrics.

-TT

I'm using a fresh RC2 install downloaded directory from Github.

UPDATE... I just discovered the below issue I'm having is with portable use only. With full install it works 100% and I don't have to make those so-called fixes below.

Just to elaborate... If I click on Lyrics first and then play a track, I can see the Lyrics. But if I'm on the default panel or any other panel and then click Lyrics, it won't show the lyrics of the first track played. If I play subsequent tracks it will show, but if I stop and play the cycle repeats.

As for the minimize and maximize issue (lyrics disappearing), I was able to 'fix' this issue by removing, if (pref.displayLyrics {initLyrics();}, in gr-callbacks on_size.

And lastly, I have noticed a new issue. :) The lyrics disappear after exactly 60 seconds. It didn't take me long to find a 'fix' for this (just did a search for 60000) and I removed the following from the searchLyrics() function in gr-lyrics:

Code: [Select]
/*this.searchTimeout = setTimeout(() => {
if (!this.findLyrics()) {
this.loadLyrics(this.stringNotFound);
this.on_size(albumArtSize.x, albumArtSize.y, albumArtSize.w, albumArtSize.h);
}
clearInterval(this.lyricsSearchTimer);
}, 60000);*/


Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #721
@Majestyk,

Edit: By coincidence and luck I encountered an issue when a new album starts playing and that album has no album cover
( the big album art on the left side ) and thus it will not display any lyrics while lyrics panel is active.
When toggling the lyrics top menu button, it will draw the lyrics and when going into fullscreen, the lyrics will disappear.
This sounds like the issue you are describing, right? But this issue only happens on albums that have no cover,
otherwise all is working fine. Can you confirm this is the same issue?

Quick fix:
Open gr-main-functions.js and go to line ~ 3335 and replace the initLyrics function with a setTimeout:
Code: [Select]
function initLyrics() {
setTimeout(() => {
lyrics = new Lyrics();
lyrics.on_size(albumArtSize.x, albumArtSize.y, albumArtSize.w, albumArtSize.h);
lyrics.initLyrics();
}, 1);
}

Tell me how it goes.

---

I have tried every possible combinations and I just can't reproduce the issues you are describing.
If that would be common issues, I would already get a lot of reports from other users.
It also does not make sense that these issues are present in the portable installation but not in the standard installation.
The code is the same after all and if there would be some directory issues with special chars ( like the previous Biography issue ),
it would not fetch lyrics for other tracks.

The lyric search timer you are commenting out is the lyric search display string on the album artwork.
It is only displayed when no lyrics are available after one minute, i.e no lyrics where found on HDD nor from lyric source servers.

This is all very confusing, there MAY be a very rare case something went wrong but you would need to help me to reproduce this.
- Please tell me step by step how to reproduce both issues.
- Are you using the original Georgia-ReBORN files with original user-components and not other additional user-components?
  Maybe some other user-component like OpenLyrics or Lyric Show 3 are in conflict with ESLyric when both are active and used at the same time?
- Did you change any ESLyric option settings in foobar?
- Did you try with all default Georgia-ReBORN settings?

Thanks for the help.

-Tom


Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #723
Just out of curiosity, how does the Spider Monkey mod panel differ from the previous official release? I can't find any info about it.