Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Playlist-Tools-SMP (Read 70171 times) previous topic - next topic
0 Members and 4 Guests are viewing this topic.

Re: Playlist-Tools-SMP

Reply #250
I'm having small freezes in foobar every time I modified tags.

In the console there is message that say:
Code: [Select]
cacheTags: got ["$ascii($lower($trim(%TITLE%)))","$year(%DATE%)","%ARTIST%","%BPM%","%GENRE%","%KEY%","%MOOD%","%STYLE%","%TITLE%"] tags from X items
before the freezes.

Also, I have a panel crash followed by a player crash with a short message saying something about "out of memory". (too fast to saw more)

The crash dump and log are empty and console log last record is a "cacheTags"

Re: Playlist-Tools-SMP

Reply #251
I'm having small freezes in foobar every time I modified tags.

In the console there is message that say:
Code: [Select]
cacheTags: got ["$ascii($lower($trim(%TITLE%)))","$year(%DATE%)","%ARTIST%","%BPM%","%GENRE%","%KEY%","%MOOD%","%STYLE%","%TITLE%"] tags from X items
before the freezes.

Also, I have a panel crash followed by a player crash with a short message saying something about "out of memory". (too fast to saw more)

The crash dump and log are empty and console log last record is a "cacheTags"
You are using V2. And tags cache must be disabled now. That behavior was intended on old betas.

About the memory usage, once the cache is off, there should be no problems. There is no magic here, either we had speed or free ram. Can't have both.

This is the price you pay using beta  V2 ;)

I will upload a new version with it disabled by default, since new betas don't needed it unless people revert the native foobar caching. And then I will not support that anymore.

EDIT: For existing installations, set on your properties panel (on every panel with a Search by distance button):
"SBD_13.Read tags from cache instead of files?'" to false.

Also go to:
FOOBAR PROFILE FOLDER]\js_data\tagsCache\

And delete all json files.

Re: Playlist-Tools-SMP

Reply #252
The strange thing is that I had a lot of free RAM in the system when the panel pops up the message and crashed

Re: Playlist-Tools-SMP

Reply #253
The strange thing is that I had a lot of free RAM in the system when the panel pops up the message and crashed

That doesn't really work that way. Foobar v2 in 32 bits only uses 2 - 3 GB of ram. Maybe +3 (but less than 4) with some "hacks".

You may have 20 GB, only 2-3 will be used anyway. So whenever it reaches the max... it crashes. It's the same for any x32 software.
Then you also have an additional limit of ram per panel imposed by SMP.

Just follow the last steps and it will be fixed.

Re: Playlist-Tools-SMP

Reply #254
The strange thing is that I had a lot of free RAM in the system when the panel pops up the message and crashed

That doesn't really work that way. Foobar v2 in 32 bits only uses 2 GB of ram. Maybe 3 with some "hacks".

You may have 20 GB, only 2 will be used anyway. So whenever it reaches the max... it crashes. It's the same for any x32 software.
Then you also have an additional limit of ram per panel imposed by SMP.

Just follow the last steps and it will be fixed.

And that could be the reason why it crashes silently when I tried to tag, applied replaygain or essentia to a few thousands files at once?

 

Re: Playlist-Tools-SMP

Reply #255
The strange thing is that I had a lot of free RAM in the system when the panel pops up the message and crashed

That doesn't really work that way. Foobar v2 in 32 bits only uses 2 GB of ram. Maybe 3 with some "hacks".

You may have 20 GB, only 2 will be used anyway. So whenever it reaches the max... it crashes. It's the same for any x32 software.
Then you also have an additional limit of ram per panel imposed by SMP.

Just follow the last steps and it will be fixed.

And that could be the reason why it crashes silently when I tried to tag, applied replaygain or essentia to a few thousands files at once?
Dont' really think so, since a thousand of files should not use so much RAM.

I designed it to only re-analyze the tracks you changed, and other users have been testing it with me privately without problems. But who knows... it was meant to be used on V2 before tags were cached natively on beta 19. It's technically possible you were one of those already on the RAM limits, so on newer versions it would crash since it was effectively duplicating the amount of ram used at some points.

Told u I love V2 hahaha... it has been an error to make users to switch it without proper testing and warnings.

Re: Playlist-Tools-SMP

Reply #256

Dont' really think so, since a thousand of files should not use so much RAM.

I designed it to only re-analyze the tracks you changed, and other users have been testing it with me privately without problems. But who knows... it was meant to be used on V2 before tags were cached natively on beta 19. It's technically possible you were one of those already on the RAM limits, so on newer versions it would crash since it was effectively duplicating the amount of ram used at some points.

Told u I love V2 hahaha... it has been an error to make users to switch it without proper testing and warnings.

No idea, but every time I tried to make an operation in the whole library never finished. In the morning always find foobar crashed. (about 80.000 files). But it is not a new problem, so i learn to do things in batchs.

Anyway, the panel seems to work fine now.

thanks


Re: Playlist-Tools-SMP

Reply #257
Btw, totally missed it. The configuration for it is at the tag remapping submenu. Both at the Playlist Tools button and the search by distance customizable button, as 'Read tags from cache...'

Added this warning now:
Quote
This feature should only be enabled on Foobar2000 versions >= 2.0 32 bit.'

Previous versions already cached tags values, thus not requiring it. Only enable it in case low memory mode is used, if better performance is desired. See:
https://wiki.hydrogenaud.io/index.php?title=Foobar2000:Version_2.0_Beta_Change_Log#Beta_20' +

Warning: it may behave badly on really big libraries (+100K tracks) or if thousands of tracks are tagged/edited at the same time.
If you experience crashes or RAM allocation failures, disable it.

Re: Playlist-Tools-SMP

Reply #258
New release:
https://github.com/regorxxx/Playlist-Tools-SMP/releases/tag/v3.0.0-beta.16

Please read the instructions carefully.

As a bonus:
ListenBrainz tools (wip)
https://github.com/regorxxx/ListenBrainz-SMP

Re: Playlist-Tools-SMP

Reply #259
New release:
https://github.com/regorxxx/Playlist-Tools-SMP/releases/tag/v3.0.0-beta.16

Please read the instructions carefully.
Thank you!

I installed all three of your recent updates (not ListenBrainz tools yet). (I deleted old SMP panels and all scripts in foobar2000\profile\scripts\SMP\xxx-scripts first.)

Every time I start fb2k I get these popups.

Spoiler (click to show/hide)

Spoiler (click to show/hide)

They used to go away after the first run.

And I'm also getting this quite frequently (I press Continue rather than Stop script).

Spoiler (click to show/hide)

And lots of "Aww, crashed".  Once when I tried to rename a playlist. It was locked at the time, I realised later, so maybe that was it. I'll get screenshots of the crashes next time they happen.

Another time was when I created a new empty playlist. But I've just done that again without a problem.

There's nothing that's a big deal to me. Just reporting in case you'd like to know.

Re: Playlist-Tools-SMP

Reply #260
Quote
Every time I start fb2k I get these popups.
I also have this with Search-by-Distance 4.0.0

Re: Playlist-Tools-SMP

Reply #261
Quote
Every time I start fb2k I get these popups.
I also have this with Search-by-Distance 4.0.0
You are not supposed to have them on every startup, just the first time you install the script. It has always been that way as you say.

So that points to a bugged install. I will test it on a blank install, because I am not able to replicate your problems. But please give me more details of which buttons are you loading and your current setup.

The unresponsive script is a "feature" of SMP. Ask its developer for a way to fully deactivate it (*) . Btw read this...
https://github.com/regorxxx/Playlist-Tools-SMP/wiki/Known-problems-or-limitations

Quote
And lots of "Aww, crashed".  Once when I tried to rename a playlist. It was locked at the time, I realised later, so maybe that was it. I'll get screenshots of the crashes next time they happen.
Don't really understand that problem or how it's related to the scripts (?).
Are you saying the panel crashes when renaming a locked playlist or entire foobar?
Although there is a bug on SMP with locked playlists, I doubt it's the same you are talking about.
Foobar v1 or v2=

Quote
Another time was when I created a new empty playlist. But I've just done that again without a problem.
Same, that doesn't seem to have nothing to do with Playlist Tools (?)

Are you using a bugged playlist manager or something?
https://github.com/TheQwertiest/foo_spider_monkey_panel/issues/198

(*) Really, please do it. I keep getting complains about this from every user which use some of my scripts, and I'm really tired of it since it's not my fault if something takes 4 secs to complete on big libraries.

Re: Playlist-Tools-SMP

Reply #262
Quote
But please give me more details of which buttons are you loading and your current setup.
I just tried with a new portable installation foobar 2.0 beta 24 x86 DUI + Spider Monkey Panel v1.6.1 + Search-by-Distance v4.0.0 (from the releases page). The first time was with my main installation.
  • load buttons_toolbar.js (the one in the root folder)
  • right click > Add buttons > Search by Distance > search_by_distance_customizable.js
  • "check your current library tags" popup : No. Close other readmes.
  • wait for the cache calculation in the console and rename the button.
  • close and restart foobar. The "check your library tags" and the 2 readme popups reappear. At each restart. It's like the first two InchPerfect screenshots.

* right click > Readmes... > Toolbar does not load any file, "Called: Readmes...\Toolbar" appears in the console.

* right click > Restore default buttons crashes. Same configuration as above, I only have Search-by-Distance v4.0.0.
Spoiler (click to show/hide)

Sorry this is not the right topic and I'm interfering with your message InchPerfect.

Re: Playlist-Tools-SMP

Reply #263
Quote
* right click > Readmes... > Toolbar does not load any file, "Called: Readmes...\Toolbar" appears in the console.
Confirmed. I added it to Playlist tools but not to Search by distance, so if you only download the second, it's missing.

In this case, please report things in the appropriate thread, since this would not belong to this thread then!

Quote
* right click > Restore default buttons crashes. Same configuration as above, I only have Search-by-Distance v4.0.0.
Confirmed too. This entry is not needed anymore since there are no default buttons now, I forgot to remove it. Will substitute it with an entry to reset all buttons' config.

Quote
close and restart foobar. The "check your library tags" and the 2 readme popups reappear. At each restart. It's like the first two InchPerfect screenshots.
Ok, this setting should be saved when closing foobar. That means that something is wrong at closing. Have to test it more, but looks like a SMP bug. The callback fires fine on panel reloading but it doesn't work when closing foobar.

In other words, if that's true, I can't do anything about it until SMP gets an update. Will try a workaround meanwhile

Re: Playlist-Tools-SMP

Reply #264
So... confirmed. It's a SMP bug.
https://github.com/TheQwertiest/foo_spider_monkey_panel/issues/205


Until I add a workaround, manually set the property to true and done.
X

EDIT: Will upload a hotfix asap, and until SMP gets a much needed update I will simply force the property to be switched 60 secs after installing the script for the first time.

Re: Playlist-Tools-SMP

Reply #265
https://github.com/regorxxx/Playlist-Tools-SMP/releases/tag/v3.0.0-beta.17
Quote
### Added
- UI: added settings for buttons color (the border and filling).
- UI: added settings for buttons transparency (the filling).
### Changed
- Quicksearch: entries are now configurable. New ones may be added and existing ones edited. 'Partial match' and 'Begins with' entries are automatically created.
- UI: enhanced colors and shading for buttons on mouse over/down when using custom toolbar color modes, etc.
- UI: pressing Ctrl resets selected setting on buttons bar colors submenu.
- Helpers: updated helpers
### Removed
### Fixed
- Pools: duplicated 'Current genre/style and instrumentals' pool entry removed.
- Buttons: fixed 'Restore default buttons' entry crash (not needed anymore since there are no more 'default buttons'), now replaced with 'Restore all buttons' (which simply restores back default settings for every button).

@ InchPerfect that should solve the problems, the slow script is a SMP thing as noted above. Let me know about the playlists bugs, which don't seem related to my scripts.. but anyway.

Re: Playlist-Tools-SMP

Reply #266
Thanks Regor. I tried the new Search by Distance 4.0.1 release and the three issues seem to be fixed, or with a workaround.

Re: Playlist-Tools-SMP

Reply #267
The unresponsive script is a "feature" of SMP. Ask its developer for a way to fully deactivate it (*) . Btw read this...
https://github.com/regorxxx/Playlist-Tools-SMP/wiki/Known-problems-or-limitations

(*) Really, please do it. I keep getting complains about this from every user which use some of my scripts, and I'm really tired of it since it's not my fault if something takes 4 secs to complete on big libraries.
Done.

And thanks for letting us know about changing the warning threshold at Preferences/Advanced/Tools/Spider Monkey Panel. I've set it to 10 seconds. Let's see if that helps.

Re: Playlist-Tools-SMP

Reply #268
Quote
And lots of "Aww, crashed".  Once when I tried to rename a playlist. It was locked at the time, I realised later, so maybe that was it. I'll get screenshots of the crashes next time they happen.
Don't really understand that problem or how it's related to the scripts (?).
Are you saying the panel crashes when renaming a locked playlist or entire foobar?
Renaming a locked playlist. I don't know how to rename an enitre foobar or even what an entire foobar is XD.

But don't worry about it. It seems to be OK now.

Foobar v1 or v2=
Always v2.

Re: Playlist-Tools-SMP

Reply #269
I delete old files and install new versions.
In a panel I added a customizable SBD, playlist tools and search by distance predefines ones.
I made the changes in the customizable to mimic previous personal settings and change the name to SBD. The button was named sbd0 in the tooltip.
Then I reorder the buttons and sbd0 vanished and a new sbd1 was created (in default state).

After that, I got a panel crash.

Code: [Select]
Error: Spider Monkey Panel v1.6.2-dev+7c0928bf (Playlist Tools: Playlist Tools: Buttons Bar v3.0.0-beta.17 by XXX)
parent.buttonsProperties.bSortRandom is undefined

File: buttons_search_by_distance.js
Line: 121, Column: 1
Stack trace:
  buttonTooltipSbd@buttons_search_by_distance.js:121:1
  themedButton/this.descriptionWithID<@buttons_xxx.js:118:135
  themedButton/this.draw@buttons_xxx.js:271:15
  drawAllButtons@buttons_xxx.js:474:12
  @buttons_xxx.js:508:2
  fireEvents/</<@callbacks_xxx.js:148:37
  fireEvents/<@callbacks_xxx.js:145:30
It comes back every time I reload the panel




Re: Playlist-Tools-SMP

Reply #270
Some artifacts in the menus





Re: Playlist-Tools-SMP

Reply #271
Quote
And lots of "Aww, crashed".  Once when I tried to rename a playlist. It was locked at the time, I realised later, so maybe that was it. I'll get screenshots of the crashes next time they happen.
Don't really understand that problem or how it's related to the scripts (?).
Are you saying the panel crashes when renaming a locked playlist or entire foobar?
Renaming a locked playlist. I don't know how to rename an enitre foobar or even what an entire foobar is XD.

But don't worry about it. It seems to be OK now.

Foobar v1 or v2=
Always v2.

XD yeah, that phrase didn't make any sense.
I wanted to say "if it was just the panel crashing or entire foobar crashing when doing X",

@paregistrase
As you could imagine, that's obviously not happening on windows XD So a Wine thing...

Now, as far as I know you didn't have such problems before (?) Nothing has changed on menus on my side since eons (so you should have experience the same problems on previous versions).
Did you changed the font or something? Those chars are supposed to be invisible. And they work fine on windows.

I know why it happens, but there is no workaround unless I simply discard all my menus framework.

Re: Playlist-Tools-SMP

Reply #272
After that, I got a panel crash.
It only comes back when putting the mouse over the button, on tooltip creation. It's my fault. And will be fixed now. Not related to the other problem (it simply appeared for u after the properties were mixed).

The button loosing its config... can't reproduce it. I would need you to be able to reproduce it with specific steps in a blank panel (without properties from previous installations).
I think I misunderstood that part.

Re: Playlist-Tools-SMP

Reply #273
@paregistrase
As you could imagine, that's obviously not happening on windows XD So a Wine thing...

Now, as far as I know you didn't have such problems before (?) Nothing has changed on menus on my side since eons (so you should have experience the same problems on previous versions).
Did you changed the font or something? Those chars are supposed to be invisible. And they work fine on windows.

I know why it happens, but there is no workaround unless I simply discard all my menus framework.

It been around for a while but I supposed that there will be a wine specific and didn't report it before. I did now because starting fresh the first time I open the menu is clean. The second time the readme have squares but not the add button and before adding a button the add buttons have squares too. Then I start to pay attention and the squares also appeared in others menus and I decided to comment it.

The button loosing its config... can't reproduce it. I would need you to be able to reproduce it with specific steps in a blank panel (without properties from previous installations). I think I misunderstood that part.

Delete all panels. Close foobar. Delete js_data related. Open foobar. Add buttons bar. Add playlist tools. Add sbd custom. Modify some weights. Add search by distance predefined buttons.

Move playlist tools to 3. Move custom to 2.

The SBD custom sbd0 disappeared and it is replaced with a sbd1 in default state

Edit:

With the fix didn't crash so far, but the custom button still disappeared, changing position (by menu)

Edit two:

I speak too fast.

The pop-up of search by distance cache keep appearing after click yes and after 3 or 4 times crashes the panel. Now every reload gives the pop-up and crash after.

Code: [Select]
Error: Spider Monkey Panel v1.6.2-dev+7c0928bf (Playlist Tools: Playlist Tools: Buttons Bar v3.0.0-beta.17 by XXX)
properties.bAscii is undefined

File: search_by_distance.js
Line: 1894, Column: 4
Stack trace:
  findStyleGenresMissingGraphCheck@search_by_distance.js:1894:4


Re: Playlist-Tools-SMP

Reply #274
The popup is meant to appear. It's stated on the changelog. It will be saved as "fired once" after 60 secs of installing a script. If it crashes before, then it is not saved. I did it on purpose in case the script crashes. So it's working. If you reload or crash the panel before 60 secs, then it's reset.

Will check your other problems. I played yesterday moving buttons without problems...