Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Windows Classic theme and foobar2000 v1.6.9 (Read 2042 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Windows Classic theme and foobar2000 v1.6.9

As far as I can see, some rendering issues related to the Windows Classic theme were fixed in the latest v1.6.9 beta. It means that it is still officially supported, so I decided to report a few more cosmetic issues.

There is another regression which makes some controls to look inconsistent with other controls. This grid control everywhere has too thing border now. In old versions it seemed normal. Most of other controls in other places have normal borders.

v1.3.20:


v1.6.9 beta 1:


These checkboxes look weird:


And these checkboxes look better, but they are a bit bigger than the standard checkboxes which are used everywhere else in the program:


It is definitely not critical, I don't look into settings often. But since some similar issues with the Classic were already fixed, probably there is still a chance for other improvements for consistency =)

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #1 –
The absence of scroll bars in pic 2 should be alleviated When the need for a up / down scroll exists. Try expanding > Display and > DUI drill downs to v, and the scroll bar should appear. 
Neither an audiophile, nor album snob. Why do ratings threads always have someone saying they don't believe in rating music?
Record Label Icons: 600x600 pngs appropriate for any color background:
freeimage.host/johnbuck/?list=images&sort=name_asc&page=1

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #2 –
I'm not talking about the scrollbar. It's OK that it is not visible when it is not needed. I'm talking about border of the grid control. It is twice thinner than standard border in Windows Classic theme. Standard border is 2px, and most of controls still have 2px border, but all the grids in the program have 1px border in latest versions. In older versions of the player it was 2px, consistent with other controls and Windows Classic theme.

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #3 –
You have a typo in your OP, "too thing border", and other than the scrollbar being in photo 1, there is no visible difference between it and the window in photo 2.
Neither an audiophile, nor album snob. Why do ratings threads always have someone saying they don't believe in rating music?
Record Label Icons: 600x600 pngs appropriate for any color background:
freeimage.host/johnbuck/?list=images&sort=name_asc&page=1

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #4 –
Just a typo. As for me, the difference in border size is obvious. Probably, noticeability depends on a monitor? Made a comparison GIF for you:



The thicker one is from v1.3.20 and it is the standard Windows Classic border for all controls. The thinner one is from 1.6.9, and it is non-standard and looks inconsistent with other controls which still use standard thick border.

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #5 –
The changes to list view controls come from the libPPUI component of the fb2k SDK which was released years ago. I guess Peter chose to have a one style for all rather than doing windows version/theme detection. For the vast majority of people using windows 10, a flat style with no borders is preferable.

Inconsistencies across all Preference pages will come from different developers using the windows APIs direct, using old/new versions of the SDK or applying their own styles independent of what foobar does itself. Pretty much nothing can be done about that.

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #6 –
Quote from: marc2k3 on
Inconsistencies across all Preference pages will come from different developers using the windows APIs direct
In case of v1.6.9, I have no any non-standard plugins. It's just a fresh installation of the foobar2000 v1.6.9. It is not consistent with itself on the Windows Classic theme.

Quote from: marc2k3 on
old/new versions of the SDK or applying their own styles independent of what foobar does itself. Pretty much nothing can be done about that.
If it is fixed in the latest libPPUI, it will be consistent at least in all standard components which are installed by default.

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #7 –
Changed checkbox rendering in 1.6.9 beta 2 somewhat, unsure about the borders.

Note that new SDK will be out with 1.6.9 final, with various list control fixes.
Microsoft Windows: We can't script here, this is bat country.

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #8 –
Yeah, checkboxes are much better now. They are still a bit bigger than standard checkboxes, but at least rendered properly. Thanks =)

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #9 –
More fixes included in beta 3 (smaller checkboxes again, thinner borders).
Microsoft Windows: We can't script here, this is bat country.
 

Re: Windows Classic theme and foobar2000 v1.6.9

Reply #10 –
These checkboxes look perfect now:



These are still a bit bigger than standard checkboxes:



But now the tree component on the latter screenshot also has non-standard thin border.