Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_openlyrics (not my release) (Read 39595 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: foo_openlyrics (not my release)

Reply #125 –
Thank you for catching that error, and reporting it here, too, @sveakul .

For those who are curious, and don't follow the Github stuff, the dev. answered: "Inspired by your and Paaufo's comments and taking a look at the code, I see it was actually just not doing the correct checks when handling track metadata for internet radio. Thanks for the help!"

He has released v1.10.2, that I can confirm fixes the problem mentioned above.

Re: foo_openlyrics (not my release)

Reply #126 –
Quote from: Paaufo on
He has released v1.10.2, that I can confirm fixes the problem mentioned above.
Well, it "pretty much" fixes it.  With the "autosearch even when not visible" NOT checked, it will no longer start an autosearch if another panel tab is open.  When a search is started with its panel open, it does start an autosearch. So far all like 1.9.  However if a song is playing and its tab is suddenly opened, no autosearch is started until "Search for Lyrics" is invoked from the context menu, or a new song is started.  This is NOT like 1.9, which while never having the unwanted background search issue, would also START an autosearch on its own when tabbed to, saving two clicks.

However, I can definitely live with the 1.10.2 behavior, where the "starting search with a closed panel even when that option is disabled" problem is indeed FIXED.  BTW all of this nit-picking involves radio stream usage;  I put a couple of GIFs up on the GitHub site illustrating this for the extremely bored.

Re: foo_openlyrics (not my release)

Reply #127 –
Quote from: Koakuma on
Okay I was using the quick reply function before, so I didn't know this reply box existed. But uhhh, there's no "source" option here.

Quote from: sveakul on
If as your first image showed, "Metal Archives" is NOT in your left "Search order" box of chosen sources, then the option "Search for options (manually)" must be ignoring the chosen sources and by default doing a search using ALL sources.  I agree that is not expected behavior, and should be considered a bug.

I was told by the dev., on Github, that this is expected behaviour. He showed me he's received reports about this since 2022. Yeah, in my case OL prioritizes empty lyrics from NetEase and relegates other services that I find more useful.

Re: foo_openlyrics (not my release)

Reply #128 –
Foo_openlyrics 1.11 released.  Bandcamp added as a source, a fix for SongLyrics sometimes stalling a search with its "we don't have the lyrics yet" message.  https://github.com/jacquesh/foo_openlyrics/releases/latest

I did a fresh install of this version after completely removing the previous one.  Tests fine, FAST, and search behavior follows all options.  Works great on streams or files.

It's a shame that Foobar's shortcuts don't include a path to the "About current lyrics" context menu choice present since 1.10, which includes the source of the found lyrics as had been requested.  Anyone know what is required to make it to the Prefs/Keyboard Shortcuts list in Foobar?  There are other OpenLyrics context menu choices there, just not "About current lyrics."