Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: WSH Panel Mod script discussion/help (Read 1507073 times) previous topic - next topic
0 Members and 14 Guests are viewing this topic.

WSH Panel Mod script discussion/help

Reply #3675 –
Falstaff, thank you for great playlist script. It looks very cool and highly customizable. I will definitely use it with my DUI setup.

Some minor problems and feature requests:

How can I use custom background color? I want background image to blend with black color without changing main background colour in DUI settings. I tried to enter value "0,0,0" to "CUSTOM COLOR BACKGROUND NORMAL" field in window Properties. It didn't work: background image became clean without any alpha blending. What exactly should I enter in that field?

Crash after click on Title column in header toolbar to sort (10k+ tracks in playlist). (doesn't matter for me since I always turn header off).

Strange white line on top of playlist after turning off both Active Playlist Information and Toolbar Header.

feature request: Custom font colors for each column would be nice.
Or better something like support of $rgb(xxx,xxx,xxx) in title format field (like in esplaylist) to be able to have different font colors even in single column or in group header.

feature request: for those who have multiple artist images for each artist: option to randomly choose one of them every time, not the same one every time.

WSH Panel Mod script discussion/help

Reply #3676 –
Falstaff,

I found a little bug:
If I specify the default path  ".\wsh_br3tt\jsplaylist\images\default.jpg" wallpaper is not displayed.
When I specify an absolute path "c:\Users\name\AppData\Roaming\foobar2000\wsh_br3tt\jsplaylist\images\default.jpg"  - it's all right.

WSH Panel Mod script discussion/help

Reply #3677 –
Quote from: maxim7191 on
How can I use custom background color? I want background image to blend with black color without changing main background colour in DUI settings. I tried to enter value "0,0,0" to "CUSTOM COLOR BACKGROUND NORMAL" field in window Properties. It didn't work: background image became clean without any alpha blending. What exactly should I enter in that field?

in Properties like you found it but you have to enter:  RGB(0,0,0);  if you wnt black

Quote from: maxim7191 on
Crash after click on Title column in header toolbar to sort (10k+ tracks in playlist). (doesn't matter for me since I always turn header off).

please check the console on crash to gimme the error informations to help me to fix the bug ! i count on you, thanx

Quote from: maxim7191 on
Strange white line on top of playlist after turning off both Active Playlist Information and Toolbar Header.

i need a screenshot to see what you mean because Yes, ther is a thin line when columns headerbar is hidden but it's not white normaly.

Quote from: maxim7191 on
feature request: Custom font colors for each column would be nice.
Or better something like support of $rgb(xxx,xxx,xxx) in title format field (like in esplaylist) to be able to have different font colors even in single column or in group header.

already on my todo liste  will take place in settings, tab 'Columns' asap

Quote from: maxim7191 on
feature request: for those who have multiple artist images for each artist: option to randomly choose one of them every time, not the same one every time.

i don't think i'll add this feature because artist images are set in foobar2000 preferences and if a random is to set, this should be there and not coded in a wsh script.

Quote from: pIv on
If I specify the default path  ".\wsh_br3tt\jsplaylist\images\default.jpg" wallpaper is not displayed.
When I specify an absolute path "c:\Users\name\AppData\Roaming\foobar2000\wsh_br3tt\jsplaylist\images\default.jpg"  - it's all right.


i will check that asap and fix it indeed, thanx for reporting bugs, with 11600 line of code, i may have some mistakes

WSH Panel Mod script discussion/help

Reply #3678 –
Quote from: marc2003 on
if you don't want to upgrade scripts, you'll have to download this theme from deviantart to get a fixed file....

http://www.deviantart.com/art/yuck-foo-upd...-2015-466739797

with foobar closed, browse inside the zip\marc2003 folder and copy the file named common7.js. put this file inside your own marc2003 folder.

Shouldn't the first line of the changelog on DA be 19/01/2015?

WSH Panel Mod script discussion/help

Reply #3679 –
Quote from: pIv on
Falstaff,

I found a little bug:
If I specify the default path  ".\wsh_br3tt\jsplaylist\images\default.jpg" wallpaper is not displayed.
When I specify an absolute path "c:\Users\name\AppData\Roaming\foobar2000\wsh_br3tt\jsplaylist\images\default.jpg"  - it's all right.


nope, both works, check your path again. Be careful of that wallpaper only display on track's playing.

WSH Panel Mod script discussion/help

Reply #3680 –
Quote from: Falstaff on
Quote from: maxim7191 on
Strange white line on top of playlist after turning off both Active Playlist Information and Toolbar Header.

i need a screenshot to see what you mean because Yes, ther is a thin line when columns headerbar is hidden but it's not white normaly.


i see the same issue....

https://drive.google.com/file/d/0B6f0H8likO...iew?usp=sharing

but i can hide it by using a negative y value with panel stack splitter.

Quote from: Reith on
Shouldn't the first line of the changelog on DA be 19/01/2015?


erm.... yes. thanks for spotting.

WSH Panel Mod script discussion/help

Reply #3681 –
Quote from: Falstaff on
Quote from: pIv on
Falstaff,

I found a little bug:
If I specify the default path  ".\wsh_br3tt\jsplaylist\images\default.jpg" wallpaper is not displayed.
When I specify an absolute path "c:\Users\name\AppData\Roaming\foobar2000\wsh_br3tt\jsplaylist\images\default.jpg"  - it's all right.


nope, both works, check your path again. Be careful of that wallpaper only display on track's playing.


When folder wsh_br3tt located only in "c:\Users\name\AppData\Roaming\foobar2000" default path  ".\wsh_br3tt\jsplaylist\images\default.jpg" not working.
Now I copy (not move) folder wsh_br3tt and all subfolders to "c:\Program Files (x86)\foobar2000\" -  it's all right.

WSH Panel Mod script discussion/help

Reply #3682 –
@pIv

sorry my bad, i am on a portable installation so relative path is fine for me, but on a standard install, the profile folder is not the same as the program folder, so .\wsh_br3tt\... doesn't exist there, it's normal and not a bug, the reference folder when you use relative path is the program folder.

use full path to fix it
 

WSH Panel Mod script discussion/help

Reply #3684 –
@firewater, this is the script you can use for 10 rating stars - obviously it writes to file tags as it cannot use foo_playcount.

https://dl.dropboxusercontent.com/u/2280132...om%20rating.txt

you may want to edit the image paths right at the end. also, can change the background colour on the first line of the on_paint function. in place of utils.GetSysColor(15), you can use any RGB() function you like - or if you enable psuedo-transparency, you can delete the line entirely.

WSH Panel Mod script discussion/help

Reply #3685 –
Quote from: Falstaff on
Quote from: maxim7191 on
How can I use custom background color? I want background image to blend with black color without changing main background colour in DUI settings. I tried to enter value "0,0,0" to "CUSTOM COLOR BACKGROUND NORMAL" field in window Properties. It didn't work: background image became clean without any alpha blending. What exactly should I enter in that field?

in Properties like you found it but you have to enter:  RGB(0,0,0);  if you wnt black

Thank you. It works now 

Quote from: Falstaff on
Quote from: maxim7191 on
Crash after click on Title column in header toolbar to sort (10k+ tracks in playlist). (doesn't matter for me since I always turn header off).

please check the console on crash to gimme the error informations to help me to fix the bug ! i count on you, thanx


Error: WSH Panel Mod (JSPlaylist v1.0.5 by Br3tt aka Falstaff >> http://br3tt.deviantart.com): JavaScript runtime error:
Unable to get property 'w' of undefined or null reference
File: C:\foobar2000\wsh_br3tt\jsplaylist\js\WSHheaderbar.js
Ln: 293, Col: 13
<source text only available at compile time>

Edit: crashes with same error after click on any sorting column, not just Title

WSH Panel Mod script discussion/help

Reply #3686 –
@falstaff, i have another feature request and that's for the DELETE key to work on the active playlist when the playlist manager is open. currently, pressing that key removes the selected item from the playlist.

thanks for the updates so far. 

WSH Panel Mod script discussion/help

Reply #3687 –
possible bug report...when changing the grouping settings in the preferences, the playlist doesn't refresh with the changes. i actually had to reload the panel for the change to take effect.

edit: if you want a quick example, add an album with multiple discs. now change the group pattern between %album% and %album%|%discnumber%. i think the changes should apply when you close the settings but they don't.

WSH Panel Mod script discussion/help

Reply #3689 –
Quote from: maxim7191 on
Edit: only happens with autoplaylists, no matter how much tracks


that's an important information ! but i've just uploaded v1.0.6 with some little mods that i expect it fixes your problem, but nothing revelant with autoplaylist  so, test v1.0.6 but problem should always be there, but tell me please

is this autoplaylist has 'force sorted' option ticked ?? because trying to sort an autoplaylist with a forced sort is non sense but i'm not sure i've tested something around that ...

*waits for feedback*

WSH Panel Mod script discussion/help

Reply #3690 –
Quote from: marc2003 on
possible bug report...when changing the grouping settings in the preferences, the playlist doesn't refresh with the changes. i actually had to reload the panel for the change to take effect.

edit: if you want a quick example, add an album with multiple discs. now change the group pattern between %album% and %album%|%discnumber%. i think the changes should apply when you close the settings but they don't.


it's not a bug. It doesn't work like you think.
The Groups tab in settings allow just to define groups pattern and TF fields linked to, but it doesn't affect the pattern selected in the listbox. listbox is just present to navigate between the different patterns
To use a group by pattern, you have to go back to the playlist and use the context menu on the headerbar and select the pattern you want to.

that's how it's work for now.

NOW, maybe using the settings groups tab to select the active pattern (listbox index) is better ... i'have to think about it. If other people have an opinion, i hope they will give it

WSH Panel Mod script discussion/help

Reply #3691 –
ok, thanks for the explanation. as i have column headers turned off, it's a bit clumsy to get there.

edit: i'll just look at your menu code and implement something myself. you can forget i mentioned it.

another edit: this is a feature suggestion for your grouping menu - currently you have to go down 2 sub menus to get to the group presets. i'd get rid of the group by menu and put them a level up with an off option.

before:

Code: [Select]
enabled
group by
            preset 1
            preset 2
--------------
show cover
etc


after

Code: [Select]
preset 1
preset 2
off
---------------
show cover
etc

WSH Panel Mod script discussion/help

Reply #3692 –
marc2003: I use a couple of "last.fm similar artists" scripts that I modified a long time ago, they are actually still using common4.js.

I just migrated and use the new version of "now playing". It would be nice to have the json files also appear with the images in the wsh_data folder instead of in the wsh_lastfm with strange names.

I imagine it's not just to copy/paste something in order to get them named in the way?

I still want to use my old modified scripts as I like having a couple of extra links for every entry in the list.

WSH Panel Mod script discussion/help

Reply #3693 –
Quote from: Falstaff on
Quote from: maxim7191 on
Edit: only happens with autoplaylists, no matter how much tracks


that's an important information ! but i've just uploaded v1.0.6 with some little mods that i expect it fixes your problem, but nothing revelant with autoplaylist  so, test v1.0.6 but problem should always be there, but tell me please

is this autoplaylist has 'force sorted' option ticked ?? because trying to sort an autoplaylist with a forced sort is non sense but i'm not sure i've tested something around that ...

*waits for feedback*


yeah. You absolutely right. All my autoplaylists have force-sorted option enabled.  My bad for not thinking of it right away.
btw, in the new version it doesn't crash - nothing changes when I try to sort it 

WSH Panel Mod script discussion/help

Reply #3694 –
@sylla, if you post your mods, i can probably show you how to port them over to the new scripts. if you make the changes in your panel script, none of the changes i make to my common file will change things in future.

my current internet is heavily restricted but if you use google drive, i can look at it today. all other file hosts are blocked so you'd have to wait a day or 2 until i can access those.

WSH Panel Mod script discussion/help

Reply #3695 –
Quote from: marc2003 on
@sylla, if you post your mods, i can probably show you how to port them over to the new scripts. if you make the changes in your panel script, none of the changes i make to my common file will change things in future.

my current internet is heavily restricted but if you use google drive, i can look at it today. all other file hosts are blocked so you'd have to wait a day or 2 until i can access those.

I don't use google drive... But it's just ~300 lines, can't I just PM it in a codebox? I haven't changed anything in the old common4 as far as I remember.

It's probably done real ugly, and I don't remember exactly what I changed in the code. But I added an extra icon to the left and changed the links so that a click in the list entry makes an autoplaylist, and then I have two links, one to lastfm and one to a torrent site.

WSH Panel Mod script discussion/help

Reply #3696 –
ok, send a PM. i usually have them turned off but i'll make a temporary exception.

WSH Panel Mod script discussion/help

Reply #3697 –
Quote from: marc2003 on
another edit: this is a feature suggestion for your grouping menu - currently you have to go down 2 sub menus to get to the group presets. i'd get rid of the group by menu and put them a level up with an off option.

before:

Code: [Select]
enabled
group by
            preset 1
            preset 2
--------------
show cover
etc


after

Code: [Select]
preset 1
preset 2
off
---------------
show cover
etc


i prefer the default one

WSH Panel Mod script discussion/help

Reply #3698 –
Falstaff, some more issues and suggestions:

Typing search only works for artists, it doesn't find tracks by title or albums (feature itself looks brilliant tho)

suggestion: middle mouse button for queuing maybe?

suggestion: hotkey for "Show Now Playing Track" feature?

suggestion: option to show default wallpaper even when nothing is playing

just question: TAB, ALT hotkeys and typing search only work after selecting any track inside playlist. Is it possible for them to always work? (DUI)

WSH Panel Mod script discussion/help

Reply #3699 –
Quote from: Falstaff on
i prefer the default one


oh well, it was worth a try.

any response to this earlier post?

Quote from: marc2003 on
@falstaff, i have another feature request and that's for the DELETE key to work on the active playlist when the playlist manager is open. currently, pressing that key removes the selected item from the playlist.


@sylla, import the new common8 version of the last.fm similar artists script into your panel.

add this as the first line of code....

Code: [Select]
var img = gdi.Image(fb.ProfilePath + "marc2003\\images\\auto.ico");


then replace the whole on_paint function with this...

Code: [Select]
function on_paint(gr) {
    p.draw_background(gr);
    p.left_text(gr, li.header_text(), p.title_font, p.textcolour_hl, 6, 6, p.w - 12, 24);
    gr.DrawLine(5, 29, p.w - 5, 29, 1, p.textcolour_hl & 0x45ffffff);
    li.text_x = li.lastfm_mode == 0 ? 20 : 0;
    for (var i = 0; i < Math.min(li.items, li.rows); i++) {
        if (li.lastfm_mode == 0) p.draw_image(gr, img, li.x, li.y + 16 + (i * li.row_height), 16, 16)
        p.left_text(gr, li.names[i + li.offset], p.list_font, p.textcolour, li.x + li.text_x, li.y + 15 + (i * li.row_height), li.text_width, li.row_height);
    }
}


lastly, replace the whole on_mouse_lbtn_up function with this..

Code: [Select]
function on_mouse_lbtn_up(x, y) {
    if (li.in_range && x > li.x && x < li.x + 20) p.browser("https://www.google.co.uk/search?q=" + encodeURIComponent(li.names[li.index]));
    else li.lbtn_up(x, y);
}


you can replace the URL with your own naughty code. the button is clickable and you can change what happens when you click on the text by using the right click menu. the options are to open Last.fm or create an autoplaylist.