Skip to main content
Topic: LAME v3.98 Beta 7 (Read 24321 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

LAME v3.98 Beta 7

Reply #25
Sadly there is something wrong with compiling on PPC. I often compiled Lame on my iMac G5 with

./configure
make
sudo make install

and this also works with Beta7 without compiling errors, but when I encode music with Beta7 then the resulting file is just noise (no matter if I use wav or aiff as input files).

Is there any hidden option for us PPC users that we have to activate?
WavPack 4.50.1 -hhx6 | LAME 3.98.2 -V 0

LAME v3.98 Beta 7

Reply #26
Is there any hidden option for us PPC users that we have to activate?

Current version of lame frontend is broken on big-endian environments. Apply this diff:
Code: [Select]
--- frontend/get_audio_orig.c   2008-04-13 20:38:15.000000000 +0900
+++ frontend/get_audio.c        2008-04-13 20:38:49.000000000 +0900
@@ -1007,7 +1007,7 @@
             int const machine_byte_order = order_bigEndian;
#endif
             if (in_endian != order_unknown) {
-                hi_lo_order = in_endian != machine_byte_order;
+                hi_lo_order = in_endian;
             }
             else {
                 /* assume only recognized wav files are */

LAME v3.98 Beta 7

Reply #27
Thanks a lot Nao, the patch works perfectly 
WavPack 4.50.1 -hhx6 | LAME 3.98.2 -V 0

LAME v3.98 Beta 7

Reply #28
The latest CVS changes in get_audio.c do not fix the problem because
1) variable in_endian is always zero unless --big-endian option is used
2) variable hi_lo_order passed to function unpack_read_samples should contain the endianness of the input file regardless of the machine byte order

So, the machine byte order detection in function read_samples_pcm is not required and simply the change above fixes the problem.

P.S. Compile time detection works correctly on ppc machine.

LAME v3.98 Beta 7

Reply #29
What about the new v3.98 Beta 8 at ComputerBase?
Is it official?


 
SimplePortal 1.0.0 RC1 © 2008-2020