If you use my latest release of Tag, which has been compiled with libFLAC 1.1.3, on a pre-1.1.3 file, it will change the vendor string to 1.1.3.

I don't really understand the vendor string, but it seems odd to me that simply tagging a file can change the perceived version of FLAC used to encode the file.

Which is incorrect also, since Tag only changes tags, right ? When checking my flacs I'd get the impression all or many seperately tagged ones are v.113

For me it's the reason to avoid Tag and Tag&Rename, because they get the credits while only adding/changing the tags. Those credits, imho, should go to the encoding flacversion smile.gif Maybe the taggers could be mentioned in a comment string. But that's for Josh to decide.

Well, not 'incorrect' (see below), but confusing and/or illogical.

Edit2: I've just looked at the Tag code (tagwrite.cpp, WriteFLACTag()) and, although I have no idea what is going on, I can't see anywhere where the vendor string is being specified.  There may be some method to stop the default behaviour of updating the vendor string that has not been implemented.

There are programs that have the 'honour' to be mentioned in the vendor string. Tag and Tag&Rename are some of them. As part of the flac-packet it seems logical to me that metaflac is doing its job allright.

but there may be a bug about that; if you can give me specific info about how it is calling libFLAC I can take a look.

int WriteFLACTag ( const char* filename, FileInfo* Info )
{
    const char* Items_OggApe[] = {
        "TITLE=",           APE_TAG_FIELD_TITLE,
        "VERSION=",         APE_TAG_FIELD_SUBTITLE,
        "ARTIST=",          APE_TAG_FIELD_ARTIST,
        "ALBUM=",           APE_TAG_FIELD_ALBUM,
        "TRACKNUMBER=",     APE_TAG_FIELD_TRACK,
        //"ORGANIZATION=",    APE_TAG_FIELD_PUBLISHER,
        //"DESCRIPTION=",     APE_TAG_FIELD_COMMENT,
        "GENRE=",           APE_TAG_FIELD_GENRE,
        "DATE=",            APE_TAG_FIELD_YEAR,
        //"LOCATION=",        APE_TAG_FIELD_RECORDLOCATION,
        //"COPYRIGHT=",       APE_TAG_FIELD_COPYRIGHT,
        //"ISRC=",            APE_TAG_FIELD_ISRC
    };

    char*               item;
    char*               value;
    char*               p;
    size_t              item_len;
    size_t              i, j;
    int                 tag_written = 0;
    int                 needs_new_block = 1;

    struct FLAC__Metadata_SimpleIterator*       si;

    si = FLAC__metadata_simple_iterator_new ();
    if ( !FLAC__metadata_simple_iterator_init ( si, filename, 0, 0 ) ) {
        FLAC__metadata_simple_iterator_delete ( si );
        return 1;
    }
    if ( !FLAC__metadata_simple_iterator_is_writable ( si ) ) {
        FLAC__metadata_simple_iterator_delete ( si );
        return 1;
    }

    do {
        FLAC__MetadataType  type = FLAC__metadata_simple_iterator_get_block_type ( si );

        if ( type == FLAC__METADATA_TYPE_VORBIS_COMMENT || type == FLAC__METADATA_TYPE_PADDING ) {
            needs_new_block = 0;
            break;
        }
    } while ( FLAC__metadata_simple_iterator_next ( si ) );

    if ( !needs_new_block ) {
        FLAC__metadata_simple_iterator_delete ( si );

        si = FLAC__metadata_simple_iterator_new ();
        if ( !FLAC__metadata_simple_iterator_init ( si, filename, 0, 0 ) ) {
            FLAC__metadata_simple_iterator_delete ( si );
            return 1;
        }
        if ( !FLAC__metadata_simple_iterator_is_writable ( si ) ) {
            FLAC__metadata_simple_iterator_delete ( si );
            return 1;
        }
    }

    do {
        FLAC__MetadataType  type = FLAC__metadata_simple_iterator_get_block_type ( si );

        // Vorbis comment block or padding block
        if ( needs_new_block || (type == FLAC__METADATA_TYPE_VORBIS_COMMENT || type == FLAC__METADATA_TYPE_PADDING) ) {
            if ( !tag_written ) {
                FLAC__StreamMetadata*                       data;
                FLAC__StreamMetadata_VorbisComment_Entry    entry;
                size_t  comments = 0;

                if ( (data = FLAC__metadata_object_new ( FLAC__METADATA_TYPE_VORBIS_COMMENT )) == NULL ) {
                    fprintf ( Options.output, "Failed to create FLAC metadata block.\n" );
                    FLAC__metadata_simple_iterator_delete ( si );
                    return 1;
                }

                for ( i = 0; i < Info->TagItemCount; i++ ) {
                    if ( Info->TagItems[i].Item[0] != '\0' && Info->TagItems[i].ValueU[0] != '\0' )
                        comments++;
                }

                if ( !FLAC__metadata_object_vorbiscomment_resize_comments ( data, comments ) ) {
                    fprintf ( Options.output, "Failed to create FLAC metadata block.\n" );
                    FLAC__metadata_object_delete ( data );
                    FLAC__metadata_simple_iterator_delete ( si );
                    return 1;
                }

                comments = 0;

                for ( i = 0; i < Info->TagItemCount; i++ ) {
                    int replaced_item = 0;
                    if ( Info->TagItems[i].Item[0] == '\0' || Info->TagItems[i].ValueU[0] == '\0' )
                        continue;

                    for ( j = 0; j < (sizeof (Items_OggApe) / sizeof (*Items_OggApe)) / 2; j++ ) {
                        if ( stricmp ( (char *)Info->TagItems[i].Item, (char *)Items_OggApe[j*2+1] ) == 0 ) {
                            replaced_item = 1;
                            item_len = strlen ((char *)Items_OggApe[j*2]) - 1;
                            if ( (item  = (char *)malloc ( item_len + 1 )) == NULL ) {
                                fprintf ( Options.output, "WriteFLACTag: Memory allocation failed.\n" );
                                exit (1);
                            }
                            strncpy ( item, Items_OggApe[j*2], item_len );
                            item[item_len] = '\0';
                            break;
                        }
                    }

                    if ( !replaced_item ) {
                        item_len = Info->TagItems[i].ItemSize;
                        if ( (item  = (char *)malloc ( item_len + 1 )) == NULL ) {
                            fprintf ( Options.output, "WriteFLACTag: Memory allocation failed.\n" );
                            exit (1);
                        }
                        strcpy ( (char *)item, (char *)Info->TagItems[i].Item );
                    }

                    p = item;
                    while ( *p != '\0' ) {
                        int ch = *p;
                        if ( ch == '=' || ch < 0x20 || ch > 0x7D ) ch = '_';
                        *p++ = ch;
                    }

                    entry.length = strlen (item) + 1 + Info->TagItems[i].ValueUSize;
                    if ( (value = (char *)malloc ( entry.length + 1 )) == NULL ) {
                        fprintf ( Options.output, "WriteFLACTag: Memory allocation failed.\n" );
                        exit (1);
                    }
                    sprintf ( value, "%s=%s", item, Info->TagItems[i].ValueU );
                    entry.entry = (unsigned char *)value;

                    if ( !FLAC__metadata_object_vorbiscomment_set_comment ( data, comments++, entry, 1 ) ) {
                        fprintf ( Options.output, "Failed to create FLAC metadata block.\n" );
                        FLAC__metadata_object_delete ( data );
                        FLAC__metadata_simple_iterator_delete ( si );
                        return 1;
                    }

                    free ( item );
                    free ( value );
                }

                //FLAC__metadata_object_vorbiscomment_set_vendor_string ( data, entry, 1 );
                /*
                FLAC__metadata_object_vorbiscomment_resize_comments ( FLAC__StreamMetadata *object, unsigned new_num_comments);
                FLAC__metadata_object_vorbiscomment_set_comment ( FLAC__StreamMetadata *object, unsigned comment_num, FLAC__StreamMetadata_VorbisComment_Entry entry, FLAC__bool copy);
                FLAC__metadata_object_vorbiscomment_insert_comment (FLAC__StreamMetadata *object, unsigned comment_num, FLAC__StreamMetadata_VorbisComment_Entry entry, FLAC__bool copy);
                FLAC__metadata_object_vorbiscomment_delete_comment (FLAC__StreamMetadata *object, unsigned comment_num);
                */

                if ( !needs_new_block ) {
                    if ( !FLAC__metadata_simple_iterator_set_block ( si, data, 1 ) ) {  // 1 = use padding
                        fprintf ( Options.output, "Failed to write FLAC metadata block.\n" );
                        FLAC__metadata_object_delete ( data );
                        FLAC__metadata_simple_iterator_delete ( si );
                        return 1;
                    }
                } else {
                    if ( !FLAC__metadata_simple_iterator_insert_block_after ( si, data, 1 ) ) {  // 1 = use padding
                        fprintf ( Options.output, "Failed to write FLAC metadata block.\n" );
                        FLAC__metadata_object_delete ( data );
                        FLAC__metadata_simple_iterator_delete ( si );
                        return 1;
                    }
                }

                FLAC__metadata_object_delete ( data );

                tag_written = 1;
            } else if ( type == FLAC__METADATA_TYPE_VORBIS_COMMENT ) {
                if ( !FLAC__metadata_simple_iterator_delete_block ( si, 0 ) ) {     // 0 = no padding
                    fprintf ( Options.output, "Failed to remove FLAC metadata block.\n" );
                    FLAC__metadata_simple_iterator_delete ( si );
                    return 1;
                }
            }
        }
    } while ( FLAC__metadata_simple_iterator_next ( si ) );

    FLAC__metadata_simple_iterator_delete ( si );

    fprintf ( Options.output, "FLAC tag written.\n" );

    return 0;
}

REM ######################################################
SET pathToFLAC="FLAC.EXE"
SET flacOptions=-8
SET retainListOfFailedFiles=0
SET retainListOfProcessedFiles=0
SET flacVersion=113
REM ######################################################

C:\temp\test>flac -f test.flac

flac 1.1.3, Copyright (C) 2000,2001,2002,2003,2004,2005,2006  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

WARNING: test.flac is not a WAVE file; treating as a raw file
ERROR: for encoding a raw file you must specify a value for --endian, --sign, --channels, --bps, and --sample-rate
Type "flac" for a usage summary or "flac --help" for all options

C:\temp\test>flac -t test.flac

flac 1.1.3, Copyright (C) 2000,2001,2002,2003,2004,2005,2006  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

test.flac: ok

I'm running into problems re-encoding a set of Flac files that were encoded using Flac 1.1.1.  I can run Flac 1.1.3 using -d and it decodes the file to wav without a problem.  Is this a known issue?

My only question is - Why is Flac able to decode this file without a hitch, but it not _re_encode it?  That doesn't really make sene to me.

but, in order to support pipes properly it has to buffer all that lookahead because it can't seek the input back to the beginning after figuring out the file.  but with id3v2 that could be a lot and you can't really know how long except with multiple reads, so I punt in this case.

@echo off
pause
for /r %%i in (*.flac) do start /low /wait flac -f -8 -A "tukey(0,5)" "%%i"

FOR /R %%G IN (*.flac) DO ECHO "%%G">>list.txt
FOR /F "tokens=* delims=" %%H IN (list.txt) DO START /LOW /WAIT FLAC.EXE -f -8 -A "tukey(0,5)" %%H
DEL list.txt

I use the following batch file to convert my old flac files to 1.1.3

Code: [Select]

@echo off
pause
for /r %%i in (*.flac) do start /low /wait flac -f -8 -A "tukey(0,5)" "%%i"

But unfortunately, the batch never stops. If for example I run it in a directory with 2 flac files named 1.flac and 2.flac, it will keep alternating between the two. It seems the FOR somehow recognizes that a file has changed and therefor adds it to the list of files to be processed...?

Any way to stop this? If I encode to another file with -o "%%i.new" or something it works perfect, but I see no easy way to delete the old files afterwards and rename all the .flac.new to .flac

SET flacOptions=-8 -A "tukey(0,5)"

You could also just use the flac.exe version from http://www.rarewares.org/lossless.html.
This is new compile of the official release + the comma bugfix.

The file has ID3v2 tags at the beginning, as suspected.  It looks like EAC added them
FLAC will accommodate ID3v1 at the end of the file, but ID3v2 are totally non-standard.