Skip to main content
Topic: foo_discogs (Read 884246 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: foo_discogs

Reply #2850
^I've got a similar issue with the following release:
https://www.discogs.com/Silver-Bullet-Bring-Down-The-Walls-No-Limit-Squad-Returns/release/2775423

Except mine says:
(FATAL) Error: Error loading release 2775423: JSON Parser ExceptionError parsing release credits.

Any ideas? Thanks
That error means release credits on the release are not entered in a valid way as per the guidelines. So you would need to fix the release credits, then wait for the API to serve the updated version, then try again.

Re: foo_discogs

Reply #2851
Just tried the latest 2.21,

Quote
Failed to load DLL: foo_discogs.dll, reason: Not a valid Win32 application.

foobar2000 v1.5.3, Windows 10 1909


Re: foo_discogs

Reply #2853
Thanks.

The album art embedding can be improved by using file_lock_manager from the SDK which lets you update the playing track. Currently, you get an exception dialog.

Re: foo_discogs

Reply #2854
Hi

I'm trying to have Album Art work for CDs. For some reason discogs_foo can show track names of the CD so it's storing that info somewhere, but not the album art. It complains it can't write to the folder when I attempt to Update Album Art which seems to default to the CD directory.

So I tried the following:

Went to discogs_foo configuration (Right click a track and go to Tagging > Discogs > Configuration... > Artwork tab) and set a path for the Album Art to:
C:\Temp\%ARTISTS_NAME% - %RELEASE_TITLE%
and set prefix to:
cover
So far so good. It creates the folder and downloads a cover.jpg when I use the Update Album/Artist Art option.

But then I try setting the path for Columns UI in the Artwork tab of FooBars Preferences to:
C:\temp\%album artist% - %album%
Also tried C:\temp\%album artist% - %album%\cover.*
But nothing shows.

Built-in foobar2000 artwork reader mode is set for Embedded and external artwork. And the "Provide artwork to other artwork viewers" is ticked under Biography Server Misc tab.

What gives?

Would be much easier if the discogs_foo could save the album art where the track details are kept if it can't write to the albums directory such as a CD or write only drive.

Help appreciated.

Fixed by adding:
c:\Temp\%artist% - %album%\cover.jpg
To the Preferences > Display then Album art Front cover search patterns.

Re: foo_discogs

Reply #2855
Thanks.

The album art embedding can be improved by using file_lock_manager from the SDK which lets you update the playing track. Currently, you get an exception dialog.
Thanks for the recommendation. The next version of foo_discogs will use this.

People who embed artwork are welcome to provide feedback if this feature needs more work. foobar2000 seems to support front/back/artist/disc/icon embedded images. Discogs can have many images for a release but we can only guess the front cover (first image). It could be possible to embed more images outside of those 5 that foobar2000 supports, as well, if desired.

Re: foo_discogs

Reply #2856
People who embed artwork are welcome to provide feedback if this feature needs more work. foobar2000 seems to support front/back/artist/disc/icon embedded images. Discogs can have many images for a release but we can only guess the front cover (first image). It could be possible to embed more images outside of those 5 that foobar2000 supports, as well, if desired.
Thank you,
in the meantime, it would be very helpful to add two options only available in the prefs window to the "update art" feature (see screenshot).
that'll save some time looking for the right images. Not always going to the prefs when you want to only download a single image or vice versa  :-D


Re: foo_discogs

Reply #2857
there must be something new within the artwork fetching process.
before the componets update, it saved only 1 image for a release, now it is fetching an image for each selected file.

how can I set up the old behaviour, only save 1 image, regardless of how much files (of a release, aka discogs_id) are selected?

(downgrading the component is a workaround to archieve the old behaviour.)

Re: foo_discogs

Reply #2858
also, when writting filenames which contain like "Надежда" it does not write but skips foreign chars
filename:
Code: [Select]
01. «Эй, моряк» (из кф «Человек-а.mp3
will be
Code: [Select]
01. ,  (  -_cover1.jpg
where _cover1.jpg is my suffix.

I would expect the same filename for the image :
01. «Эй, моряк» (из кф «Человек-а.mp3
will be
01. «Эй, моряк» (из кф «Человек-а _cover1.jpg

 

Re: foo_discogs

Reply #2859
foo_discogs 2.22:
* Fix embedding artwork in active playing file
* Fix unicode characters being removed from file names
* Fix writing duplicate images for every track (if path+file name is the same, it will now be skipped)

Re: foo_discogs

Reply #2860
is it intended that only the first file of a release get a picture embedded? would be nice  if all files would be included. thank you very much for your work, i'm using your plugin since forever!

Re: foo_discogs

Reply #2861
is it intended that only the first file of a release get a picture embedded? would be nice  if all files would be included. thank you very much for your work, i'm using your plugin since forever!
The intent is to embed in all files. Currently there is a bug where, if you are also saving images to directory, it only embeds in the first file. This will be fixed in the next release. Thanks.

Re: foo_discogs

Reply #2862
Hello,

I'm now using:
Version: 2.22
Compiled: Apr  7 2020
(my settings are in the screenshot)

is it intended that only the first file of a release get a picture embedded? would be nice  if all files would be included. thank you very much for your work, i'm using your plugin since forever!
The intent is to embed in all files.
I really would have the fine component to save ONLY ONE single file for each album (bound with %discogs_id%) as it was the behaviour in the first place and I have not to delete 30 fetched images files on a 31 track album.

Typicly, I embedd those single image as a front cover, but as you can never be sure, those images are of good/bad/sad quality, I save those images to the albums directory and check the image file manually.

Now, I have to delete a lot of duplicates and this is a lot of unnecessary work to do. (Imagine 200 albums to tag with the fine component a day, which have 30 tracks each and the fine component is now saving 30*200 files instead of 1*200 files...
take into consideration the amount of time to delete those space/time consuming files.

And thats only, if the settings for the current album are to fetch only the first image. if you select to fetch all images, what amount of files would it be?
With the new version of the fine component, I noticed a remarkable lag (1-3secs) before finishing an album. That seems to be the case, because of the fetchhing and writting 30 imagefiles to my harddrive instead of just a single imagefile.

It would be great, (because other users prefer to save images for each file and not just a single one) to make this choice (1 image or 30 images) optional in the settings anywhere.




Re: foo_discogs

Reply #2863
When updating images (via the screenshotted dialogue-popup), the fine component also fetches redundant images.

When selecting 4 files of an album (same %discogs_id%) 4 identical images are fetched, but for my usecase it should only be 1 image.

how can I set up the component to only fetch a single image?

I don't have enabled "save  all images" in configuration->artwork.

Re: foo_discogs

Reply #2864
I can't get the plugin to pull artist images. Album art works.

Its not recognising the tags I put in the directory settings. Its putting "/? - ?" in the file path.

https://ibb.co/S6RL5Q7

The configuration is set as:

https://ibb.co/xMx4j2v

The directory is set as:

C:\Temp\Album Art\%ARTISTS_NAME% - %RELEASE_TITLE%

It's exactly the same as the Album Art directory which works fine so not sure what's going on or if it's a bug.

Edit:
Versions:
Windows 10
Foobar v1.5.3
discogs_foo v2.22

Re: foo_discogs

Reply #2865
I'm getting this when f2k starts:
Code: [Select]
Failed to load DLL: foo_discogs.dll
Reason: This component is missing a required dependency, or was made for different version of foobar2000.
As suggested by lvqcl, I have tried to install the update-for-visual-c-2013-redistributable-package, but I cannot.  The installer complains that this update cannot be installed on my system.  If I understand correctly, it applies to Visual Studio, that is not installed on my system.

Note that the previous version of foo_discogs did not trigger that error.  I'm using Win10 Pro with all official updates installed, and f2k v1.5.3.

Re: foo_discogs

Reply #2866
OK, I've found the problem.  I was just missing Visual C++ Redistributable Package 2013 x86, found here: https://www.microsoft.com/en-us/download/details.aspx?id=40784
There is no need (for me) to install the update.

Not sure it's possible with a f2k component, but when a dependency is missing, the program should offer to install it.  Currently, installing the tagger is the obstacle course.

Re: foo_discogs

Reply #2867
When updating images (via the screenshotted dialogue-popup), the fine component also fetches redundant images.

When selecting 4 files of an album (same %discogs_id%) 4 identical images are fetched, but for my usecase it should only be 1 image.

how can I set up the component to only fetch a single image?

I don't have enabled "save  all images" in configuration->artwork.

Could you remove %filename% from the name? That will result in a different path for each file, resulting in saving the same image to multiple files.

Re: foo_discogs

Reply #2868
I can't get the plugin to pull artist images. Album art works.

Its not recognising the tags I put in the directory settings. Its putting "/? - ?" in the file path.

https://ibb.co/S6RL5Q7

The configuration is set as:

https://ibb.co/xMx4j2v

The directory is set as:

C:\Temp\Album Art\%ARTISTS_NAME% - %RELEASE_TITLE%

It's exactly the same as the Album Art directory which works fine so not sure what's going on or if it's a bug.
Currently, ARTISTS (shortcut for RELEASE_ARTISTS) isn't available in the album art formatting string as RELEASE isn't available, only ARTIST is available. This will be changed in the next release so it will work.

Re: foo_discogs

Reply #2869
OK, I've found the problem.  I was just missing Visual C++ Redistributable Package 2013 x86, found here: https://www.microsoft.com/en-us/download/details.aspx?id=40784
There is no need (for me) to install the update.

Not sure it's possible with a f2k component, but when a dependency is missing, the program should offer to install it.  Currently, installing the tagger is the obstacle course.
I suspect that is due to the latest foobar2000 SDK which is now being used by the plugin, but I am not sure about that. Maybe another developer more familiar with Windows could chime in.

Re: foo_discogs

Reply #2870
The SDK defaults to dynamic C runtime linking. Since foobar2000 v1.4 the Visual C++ 2015-2019 runtimes have been bundled by the player. But they only help if you use Visual Studio 2015 or newer. If you use older Visual Studio it's recommended you change the C/C++ -> Code Generation -> Runtime Library setting to "Multi-threaded (/MT)" to statically link the required libraries to the component.

Re: foo_discogs

Reply #2871
When updating images (via the screenshotted dialogue-popup), the fine component also fetches redundant images.

When selecting 4 files of an album (same %discogs_id%) 4 identical images are fetched, but for my usecase it should only be 1 image.

how can I set up the component to only fetch a single image?

I don't have enabled "save  all images" in configuration->artwork.

Could you remove %filename% from the name? That will result in a different path for each file, resulting in saving the same image to multiple files.
Thank you, I had tried this, but, it seems to break my other scripts, relaying to *_cover.jp*g when adding artwork to the files. (i.e. Screenshot BatchAttachPicture) (The script is meant to search for an imagefilename, with the same name as the musicfile, if found, it takes that imagefile to embed it into all selected files. If no imagefile with the same name is found, it searches for more generic filenames to use for embedding)

Saving an image to, say, cover.jpg will overwrite all existing cover.jpg in the same directory, which should not be overwritten. Thats why I choosed a pattern like %filename%*_cover.jp*g to have only the images overwritten, which are precisely for those DISCOGS_IDs, I have selected in f2k. (Unfortunately, not all files with different DISCOGS_IDs are in different folders, which would help with using a generic image-filename like cover.jpg.

I'm not 100% sure, how I can benefit from the new handling of the fine component, but I'm willing to change my workflow, if needed. If I could only realize how 8-)

Also, if there would be an option in the components settings which allow the user to choose to either save a single imagefile for each DISCOGS_ID (as it was before the components update) or to save multiple imagefiles, that could help :)

Re: foo_discogs

Reply #2872
When updating images (via the screenshotted dialogue-popup), the fine component also fetches redundant images.

When selecting 4 files of an album (same %discogs_id%) 4 identical images are fetched, but for my usecase it should only be 1 image.

how can I set up the component to only fetch a single image?

I don't have enabled "save  all images" in configuration->artwork.

Could you remove %filename% from the name? That will result in a different path for each file, resulting in saving the same image to multiple files.
Thank you, I had tried this, but, it seems to break my other scripts, relaying to *_cover.jp*g when adding artwork to the files. (i.e. Screenshot BatchAttachPicture) (The script is meant to search for an imagefilename, with the same name as the musicfile, if found, it takes that imagefile to embed it into all selected files. If no imagefile with the same name is found, it searches for more generic filenames to use for embedding)

Saving an image to, say, cover.jpg will overwrite all existing cover.jpg in the same directory, which should not be overwritten. Thats why I choosed a pattern like %filename%*_cover.jp*g to have only the images overwritten, which are precisely for those DISCOGS_IDs, I have selected in f2k. (Unfortunately, not all files with different DISCOGS_IDs are in different folders, which would help with using a generic image-filename like cover.jpg.

I'm not 100% sure, how I can benefit from the new handling of the fine component, but I'm willing to change my workflow, if needed. If I could only realize how 8-)

Also, if there would be an option in the components settings which allow the user to choose to either save a single imagefile for each DISCOGS_ID (as it was before the components update) or to save multiple imagefiles, that could help :)
Could you save the image as %DISCOGS_RELEASE_ID%.jpg, then look up $directory_path(%path%)\%DISCOGS_RELEASE_ID%.jpg in your attach script?

Of course having foo_discogs directly embed your artwork would simplify the process the most unless it's not sufficient for your needs.

Re: foo_discogs

Reply #2873
The SDK defaults to dynamic C runtime linking. Since foobar2000 v1.4 the Visual C++ 2015-2019 runtimes have been bundled by the player. But they only help if you use Visual Studio 2015 or newer. If you use older Visual Studio it's recommended you change the C/C++ -> Code Generation -> Runtime Library setting to "Multi-threaded (/MT)" to statically link the required libraries to the component.
Ah, thank you. That had inadvertently been changed when upgrading to the latest SDK. I'll have to look into upgrading to a newer visual studio.

foo_discogs version 2.23 is now released which fixes this and the 2 other issues recently mentioned in here.

Re: foo_discogs

Reply #2874
Quote
foo_discogs version 2.23 is now released which fixes this and the 2 other issues recently mentioned in here.

Cool. Artists images working now, thanks.

 
SimplePortal 1.0.0 RC1 © 2008-2020