Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1494223 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

foo_discogs

Reply #1050 –
Quote from: Sandrine on
Just tried calling tags for "10CC - Deceptive Bends": Works with the 1.26 hexedited version, but with 1.28 I get weird results.



fixed in 1.29 to which you can update. There was indeed a problem handling master releases (which are returned by the new api).
For now, only the main release of a master release will be listed in the find dialog.
For your particular example case this will be http://www.discogs.com/release/1615490, although there are 12 versions listed under the master release

If you find other weird stuff happening, let me know

foo_discogs

Reply #1051 –
Quote from: thorazine on
Searching for Artist does not work for me, no artist or album names appear.
Fetching a specific release by its id or URL works though...
Edit: tried both 1.28 and 1.22 and none of them work


Update to 1.29

foo_discogs

Reply #1052 –
Quote from: bubbleguuum on
Quote from: Sandrine on
Just tried calling tags for "10CC - Deceptive Bends": Works with the 1.26 hexedited version, but with 1.28 I get weird results.

fixed in 1.29 to which you can update. There was indeed a problem handling master releases (which are returned by the new api).
For now, only the main release of a master release will be listed in the find dialog.


Will there be a way to fetch the complete list in the future? In this particular case the master release doesn't match my tracks from the CD 100% because it shows a track from the LP with sub-indices and is thus of limited use. For the moment, I'm going back to hex-edited version (as long as the old API still works).

foo_discogs

Reply #1054 –
Great Tagger, thanks!

foo_discogs

Reply #1055 –
Just updated to 1.29 and now some labels and formats are not appearing in the possible matches window after searching.  e.g. I searched for Kool Moe Dee  Greatest Hits.  Here are some of the results.

Greatest Hits, , , 1991
Greatest Hits, Jive, CD, Comp, 1993 
Greatest Hits, , , 1993
Greatest Hits, , , 2002

The second one is fine but what's going on with the ", , , " ?

Thanks for the great plugin!!!

foo_discogs

Reply #1056 –
Quote from: silkcut on
Just updated to 1.29 and now some labels and formats are not appearing in the possible matches window after searching.  e.g. I searched for Kool Moe Dee  Greatest Hits.  Here are some of the results.

Greatest Hits, , , 1991
Greatest Hits, Jive, CD, Comp, 1993 
Greatest Hits, , , 1993
Greatest Hits, , , 2002

The second one is fine but what's going on with the ", , , " ?

Thanks for the great plugin!!!


the ,,, indicate that this entry is a Master release and that the main release of this master release will be used for tagging.
Until I implement a way to expand all versions of a master release.

If you need a finer list of releases just use the hexedited 1.26 version for now, that was posted a few posts up.

foo_discogs

Reply #1057 –
Why the fix has been created only for foo2k in 1.0 version? Great job, but are the peoples who still using foo2k in older version.

foo_discogs

Reply #1058 –
Quote from: ~HQ on
Why the fix has been created only for foo2k in 1.0 version? Great job, but are the peoples who still using foo2k in older version.


If you insist to use an outdated version, you'll have to use outdated components.

foo_discogs

Reply #1059 –
In 1.29 I'm having issues downloading art work, where it'll create a file but it's empty/corrupt.

Thanks for your good work.

foo_discogs

Reply #1061 –
Strongly recommended that those having trouble with 1.29 revert to this version:

Quote from: traxy on
You can use a hex editor to change the user-agent in foo_discogs.dll.

I uploaded a fixed dll here:
http://www.multiupload.com/UH22MN91GC

Please note, that this is a temporary fix only, until the original component gets updated.


It works with the Discogs API changes, and doesn't have the new issues with master releases. I'm sure bubbleguuum will update soon - meanwhile, this version is the go.

foo_discogs

Reply #1062 –
Quote from: frogworth on
Strongly recommended that those having trouble with 1.29 revert to this version:

Quote from: traxy on


I uploaded a fixed dll here:
http://www.multiupload.com/UH22MN91GC


It works with the Discogs API changes, and doesn't have the new issues with master releases. I'm sure bubbleguuum will update soon - meanwhile, this version is the go.


That doesn't help in my case. I appear to be unable to connect to Discogs, regardless of 1.29 or modified 1.26. :-(

Is it just me or are others confronted with the same problem?

Thanks a lot for this great plugin, bubbleguuum!

foo_discogs

Reply #1063 –
Quote from: muderseb on
That doesn't help in my case. I appear to be unable to connect to Discogs, regardless of 1.29 or modified 1.26. :-(

Is it just me or are others confronted with the same problem?


Hm, I'm on modified 1.26 and it's working for me. I've had issues with firewalls and stuff before - any chance it's a networking problem at your end?
 

foo_discogs

Reply #1064 –
Hello bubbleguuum,

thanks for the update 1.29. It works good here.

I have the same issues with those
Quote
Greatest Hits, , , 1991
Greatest Hits, Jive, CD, Comp, 1993
Greatest Hits, , , 1993
Greatest Hits, , , 2002
and read the relates postes, but do not know, if my experience of the last days has the same reason as you explained.

i'm searching for "dom fackeln im sturm" on the discogs website, and get this results:


if i'm searching inside your wonderful plugin, i only get one result.


why is this?

i only encountered this, because i needed those tags and only got those.

foo_discogs

Reply #1065 –
Quote from: frogworth on
Hm, I'm on modified 1.26 and it's working for me. I've had issues with firewalls and stuff before - any chance it's a networking problem at your end?


No, I tried it on different networks, I always get the same result. All my other software (Skype, webbrowsing etc.) is working properly.

Don't know what's wrong.

foo_discogs

Reply #1066 –
Quote from: muderseb on
No, I tried it on different networks, I always get the same result. All my other software (Skype, webbrowsing etc.) is working properly.

Don't know what's wrong.


UPDATE: I just switched from foobar 1.1.5 to foobar 1.1.7. Now it works again, although the problems already mentioned above by other users (no artwork downloaded, release list seems incomplete) remain.

foo_discogs

Reply #1067 –
Quote from: bubbleguuum on
Quote from: thorazine on
Searching for Artist does not work for me, no artist or album names appear.
Fetching a specific release by its id or URL works though...
Edit: tried both 1.28 and 1.22 and none of them work

Update to 1.29

I got the same problem with 1.29 and 1.1.7.
Searching for an artist (http://api.discogs.com/search?type=artists&q=%artist% )does not actually get me a release list, only artist info:

Code: [Select]
GET /search?type=artists&q=Manu%20Chao HTTP/1.1
Host: api.discogs.com
Connection: close
Accept-Encoding: gzip
Accept: application/xml
User-Agent: foobar2000/1.1.7



HTTP/1.1 200 OK
Content-Length: 3785     
Reproxy-Status: yes
Content-Type: text/xml; charset=utf-8
Set-Cookie: sid=397ac6e874b97af7e7c8a11b9dfd8828; path=/; domain=.discogs.com; expires=Thu, 24-Jun-2021 19:12:44 GMT
Date: Mon, 27 Jun 2011 19:12:44 GMT
Server: lighttpd
Connection: close

<resp stat="ok" version="2.0"><exactresults><result num="1" type="artist"><title>Manu Chao</title><uri>http://www.discogs.com/artist/Manu+Chao</uri><thumb>http://s.dsimg.com/image/A-50-30773-1224747393.jpeg</thumb></result></exactresults><searchresults end="20" numResults="10" start="1"><result num="1" type="artist"><title>Antoine Chao</title><uri>http://www.discogs.com/artist/Antoine+Chao</uri><summary>Antoine Chao Antoine Chao French musician, producer and radio reporter, born in 1963. Brother of [a=Manu ...  Chao] and founding member of Mano Negra. </summary></result><result num="2" type="artist"><title>Manu Chao</title><uri>http://www.discogs.com/artist/Manu+Chao</uri><summary>Manu Chao José-Manuel Thomas Arthur Chao Ortega French singer/songwriter, born June 21st 1961 in</summary><thumb>http://s.dsimg.com/image/A-50-30773-1224747393.jpeg</thumb></result><result num="3" type="artist"><title>Santiago Casariego</title><uri>http://www.discogs.com/artist/Santiago+Casariego</uri><summary>Santiago Casariego Santiago "Santi" Casariego French drum player, cousin of [a=Manu Chao]. Since</summary></result><result num="4" type="artist"><title>Angelo Mancini</title><uri>http://www.discogs.com/artist/Angelo+Mancini</uri><summary> musician [a=Manu Chao]. Also used to play the trumpet in band [i]Desechos[/i] (Madrid, Spain). </summary></result><result num="5" type="artist"><title>Lyricson</title><uri>http://www.discogs.com/artist/Lyricson</uri><summary>") with Manu Chao's "Radio Bemba Sound System". </summary><thumb>http://s.dsimg.com/image/A-50-374617-1153828644.jpeg</thumb></result><result num="6" type="artist"><title>Fermin Muguruza</title><uri>http://www.discogs.com/artist/Fermin+Muguruza</uri><summary> international artists such as [url=http://www.discogs.com/artist/Manu+Chao]Manu Chao[/url], [url=http://www.discogs.com/artist%20...%20%20%5burl=http://www.discogs.com/artist/I%C3%B1igo+Muguruza]Iñigo Muguruza[/url] and [url=http://www.discogs.com/artist ... . He began his musical career by founding, along with his brother Iñigo and [url=http://www.discogs.com/artist</summary><thumb>http://s.dsimg.com/image/A-50-169849-1126734064.jpeg</thumb></result><result num="7" type="artist"><title>Tony "Face" Bacciocchi</title><uri>http://www.discogs.com/artist/Tony+%22Face%22+Bacciocchi</uri><summary> many gigs all over Italy and Europe , London included , supporting James Taylor Quartet , Manu Chao ...  international artists like Manu Chao, Marc Ribot, Koop, Ivano Fossati, Kocani Orchestra, Solarflares, Moment</summary><thumb>http://s.dsimg.com/image/A-50-633716-1238228572.jpeg</thumb></result><result num="8" type="artist"><title>Peppe Barra</title><uri>http://www.discogs.com/artist/Peppe+Barra</uri><summary>’. Within his countless famous fans we can mention Manu Chao and Roberto Benigni (‘Oscar Prize’ in 2001 for</summary><thumb>http://s.dsimg.com/image/A-50-130112-1307982302.jpeg</thumb></result><result num="9" type="artist"><title>Jane Birkin</title><uri>http://www.discogs.com/artist/Jane+Birkin</uri><summary> collaborations with artists as diverse as [a=Bryan Ferry], [a=Caetano Veloso], [a=Feist], [a=Brian Molko], [a=Manu ...  Chao] or [a=Mickey 3D] on 2004 "Rendez-Vous", followed by further collaborations with [a=Gonzales], [a</summary><thumb>http://s.dsimg.com/image/A-50-90539-1239635620.jpeg</thumb></result><result num="10" type="artist"><title>Demon</title><uri>http://www.discogs.com/artist/Demon</uri><summary> Europe Awards for the "Best French Act", next to artists such as [a=Manu Chao] and [a=Daft Punk]. The ...  considered as one of the best artist of the "french touch" movement. Filled with melodic, groundbreaking</summary><thumb>http://s.dsimg.com/image/A-50-1091-1227978882.jpeg</thumb></result></searchresults></resp>

From there there should be a second request for the first artist I think (http://api.discogs.com/artist/Manu+Chao?releases=1) but for me it just stops there.
If I put a local proxy (Fiddler) between foobar and api.discogs.com the second request gets sent. Could it be a local problem?

foo_discogs

Reply #1068 –
Quote from: krayon on
In 1.29 I'm having issues downloading art work, where it'll create a file but it's empty/corrupt.

Thanks for your good work.

Album art downloading seems forbidden too now:

Code: [Select]
GET [url=http://s.dsimg.com/image/R-150-1117525-1193409747.jpeg]http://s.dsimg.com/image/R-150-1117525-1193409747.jpeg[/url] HTTP/1.1
Host: s.dsimg.com
Connection: close
Accept-Encoding: gzip
Accept: application/xml
User-Agent: foobar2000/1.1.7

HTTP/1.1 200 OK
Date: Mon, 27 Jun 2011 19:25:00 GMT
X-Cache: MISS from cdce-lon004-018.lon004.internap.com
X-Cache: MISS from cdce-lon004-018.lon004.internap.com
Via: 0.9 cdce-lon004-018.lon004.internap.com:1080 (squid/2.7.STABLE7), 1.0 cdce-lon004-018.lon004.internap.com:80 (squid/2.7.STABLE7)
Connection: close

500 Client Refused


foo_discogs

Reply #1069 –
Are you planning expand this fix to older foo2k version? I'm using foo2k in version 0.9.5.2., 'cause is better than newest version, in my opinion of course. I don't idea how to change User-Agent...

foo_discogs

Reply #1070 –
Quote from: ~HQ on
Are you planning expand this fix to older foo2k version? I'm using foo2k in version 0.9.5.2., 'cause is better than newest version, in my opinion of course. I don't idea how to change User-Agent...

No.

foo_discogs

Reply #1071 –
please fix find_release_dialog::filter_releases().
transform(..., tolower) doesn't work with non-latin characters.

that's how i've fixed it:
Code: [Select]
void find_release_dialog::filter_releases(const std::string &text)
{
    size_t i, j;

    CStringW text_lowercase = pfc::stringcvt::string_wide_from_utf8(text.c_str());
    CharLowerBuffW(text_lowercase.GetBuffer(), text_lowercase.GetLength());
    text_lowercase.ReleaseBuffer();
[skipped]
        bool insert_item = true;
        if(text != "")
        {
            CStringW item_lowercase = pfc::stringcvt::string_wide_from_utf8(item.c_str());
            CharLowerBuffW(item_lowercase.GetBuffer(), item_lowercase.GetLength());
            item_lowercase.ReleaseBuffer();
            insert_item = wcsstr( item_lowercase, text_lowercase) != NULL;
        }

foo_discogs

Reply #1072 –
Please fix that memory leak.

foo_discogs

Reply #1074 –
edit: seems like discogs problem, sorry
Sharing delusions since 1991.