Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1489441 times) previous topic - next topic
0 Members and 19 Guests are viewing this topic.

foo_discogs

Reply #400
hi. some not serious bug or somethik like this... but this is dont need to release new version i think:

it is about VINYLTRACK again...
when taging CD releases foo_discogs anyway create VINYLTRACK tag and write to it tracks numbers...

for example it happens with this usual releases:
http://www.discogs.com/release/1015158
http://www.discogs.com/release/118605

but i dont think that releases have any importance here...

foo_discogs

Reply #401
Just found that artist id is not written using the XML parser.


Though so, as i had the script looking for that field.

Just updated seems to be better, had one parse error tho:
foo_discogs: error: release 239279: XML parse error

Out of interest, say you ammended it to add the artist id is there a way to do batch updates for all my albums instead of doing 1 album at a time?

foo_discogs

Reply #402

Just found that artist id is not written using the XML parser.


Though so, as i had the script looking for that field.

Just updated seems to be better, had one parse error tho:
foo_discogs: error: release 239279: XML parse error


Found it: the "+" in "C+C Music factory" was producing a wrong URL.

Quote
Out of interest, say you ammended it to add the artist id is there a way to do batch updates for all my albums instead of doing 1 album at a time?


That's what update album/artist art if for, you can select as many files as you want. I usually never write art at tag time but use unpdate instead in batch processing because it can be very very long especially for compilations. Btw looking at the code, update art should write %discogs_artist_id% (while fetching artist art at tag time does not), I've not rechecked it that it works though.


@ Dave_Scream: fixed!


foo_discogs

Reply #404
for some reason the album art for this release wont download automatically: 1078022

foo_discogs

Reply #405
@ Dave_Scream: fixed!


Is the fixed version (without vinyltrack problem) already online? or does it still have to come?

Great update by the way I noticed that the tagging goes a lot quicker then before 

foo_discogs

Reply #406


@ Dave_Scream: fixed!


Is the fixed version (without vinyltrack problem) already online? or does it still have to come?

Great update by the way I noticed that the tagging goes a lot quicker then before 


Will release a new version  tonight, with a fix for a bug in the tag mapping dialog when you set the tag name, it's modifing another tag. Say you change DISCOGS_FORMAT to FORMAT, it would write the format in the genre tag or something.

foo_discogs

Reply #407
Bug:
So, I'm having problems with how Discogs tags subsongs on CD releases.

Example:
http://www.discogs.com/release/717241
There are only 9 tracks on this CD. However, foo_discogs wants to number them 1-14:


So, it's not a huge deal, but it is an inaccuracy.
elevatorladylevitateme

foo_discogs

Reply #408
bubbleguuum, could be implemented Featuring/Remix with the new xml API?
Thinking Outside The Box

foo_discogs

Reply #409
Киря, а эти не работают?:

Edit tag mappings/Featuring track credit
Edit tag mappings/Vocals track credit
Edit tag mappings/Remix track credit

foo_discogs

Reply #410
Oops.. but I mean write it into the %title% in brackets after actual track title
Thinking Outside The Box

foo_discogs

Reply #411
try somethink like this:

%title% [' ('[Remixed by %DISCOGS_CREDIT_REMIX%][ Vocals by %DISCOGS_CREDIT_VOCALS%][ feat. %DISCOGS_CREDIT_FEATURING%]')']

but there is a problem:
the thing that without API was good now (with api) is bad:

for example this release http://www.discogs.com/release/244132
track 2-07  looks like

2-07 Abattoir (Razormaid Mix) (5:46)
Remix - Razormaid

so if u make previous scheme ull get "Abattoir (Razormaid Mix) (Remixed by Razormaid)" lol

maybe some strstr script will help in this situation... it will look like this %title% $if($strstr(%title%,%DISCOGS_CREDIT_REMIX%),,%DISCOGS_CREDIT_REMIX%)

so if %title% already have %DISCOGS_CREDIT_REMIX% it will not be shown...
---
UPD. ok it was not bad idea: so i started to test this string:

%title% ['('[$if($strstr(%title%,%DISCOGS_CREDIT_REMIX%),,Remixed by %DISCOGS_CREDIT_REMIX%)][$if($strstr(%title%,%DISCOGS_CREDIT_FEATURING%),,feat. %DISCOGS_CREDIT_FEATURING%)][$if($strstr(%title%,%DISCOGS_CREDIT_VOCALS%),,vocals by %DISCOGS_CREDIT_VOCALS%)]')']
---
oh. %DISCOGS_TRACK_CREDITS% do this work...

foo_discogs

Reply #412
Dave_Scream

I know, thanks  But I don't want only display feat/remix info, so I will use masstager to update %title% and then remove "temporary" fields. I think it's a good idea to embed this actions to the foo_discogs.

sorry for my english
Thinking Outside The Box

foo_discogs

Reply #413
Related to this release:  When there are two performers credited in one track, as in track 11's vocalist, it only retrieves one (TTC in this instance.)

foo_discogs

Reply #414
Hey, bubbleguuum thx for the great all new api support. I upgraded from 1.02 to 1.11 and I am really pleased by the speedy access. However I came across one possible bug:

I have artist art download enabled but I get an error message "I/O error (win32 #123)"

The files go to the path:

E:\Music\Special Interest\Artist pictures

when I add the path to

"E:\Music\Special Interest\Artist pictures"

I get the message "Object not found"

I tried to download for a couple of releases and it seems to work nowhere.

Any idea?

Cheers,

Chris

foo_discogs

Reply #415
 thank you for yet another very fine release!

foo_discogs

Reply #416
Hej, thanks for this great tagger plugin!

I wondered if combining informations in the mapping is possible.
I mean, you can input any field name to map certain infos to, which is the best thing of all, but specifying the same field name multiple times eventually ends up with only either (perhaps the last one in the list) info getting added to the certain field.
For instance there is the "VINYLTRACK" for the nice vinyl number adding feature, but i'd like it to be added in front of (some might want it at the end in brackets etc) the title data in the same field, is doing that possible with the addition of some symbols or some way? If not yet, i'd be very grateful for such a feature, since it'd take me an other step closer to fully automatized tagging =)

Thanks for the great work with this handy component!
Cheers

foo_discogs

Reply #417
I wondered if combining informations in the mapping is possible.
I mean, you can input any field name to map certain infos to, which is the best thing of all, but specifying the same field name multiple times eventually ends up with only either (perhaps the last one in the list) info getting added to the certain field.
For instance there is the "VINYLTRACK" for the nice vinyl number adding feature, but i'd like it to be added in front of (some might want it at the end in brackets etc) the title data in the same field, is doing that possible with the addition of some symbols or some way? If not yet, i'd be very grateful for such a feature, since it'd take me an other step closer to fully automatized tagging =)


Masstagger -> ADD -> format values from other fields ->
Destination field name -> VINYLTRACK
Formatting pattern -> '('%vinyltrack%')'

r u talking about this thing? if yes, i think this is not foo_discogs job...

maybe...... foo_discogs needs some "after tag job" automation-abilities... for example: after tagging - start for these tagged files some mass tagger scripts.. like: "write 'added date' stamp" and some other scripts...  or maybe after tag just press some hotkeys.. and these hotkeys will do some job...

for example, in my profile, hotkey R is assigned to mass tagger script wich add "date stamp" to %ADDED%...

but this is not hard for me to just click this hotkey everytime i tag my files =)

foo_discogs

Reply #418
I'll release a new version that fixes the reported bugs soon

@DaveScream:  as you say it's the masstagger job to eventually retag/reformat stuff using discogs info afterwards. Running custom scripts is a single hotkey away...
I'm running foo_cwb_hook to set %ADDED% when the new files that enter the library instead of invoking the script manually.

@Chris Norman: you have this error because the artist art directory does not exist. Just create it and it should work. In next version the directory is created if it does not exists

 

foo_discogs

Reply #419
Thanks bubbleguuum!
elevatorladylevitateme

foo_discogs

Reply #420
I'm running foo_cwb_hook to set %ADDED% when the new files that enter the library instead of invoking the script manually.


hm i saw this feature, but i dont used it because i thinked that it will tag any files, wich i will drag in list... even dont fully downloaded releases  but after ur words i tested it and it really works only when i move files in path wich is in media library...

i have a question...

when i move/rename already downloaded releases from download folder to the right path, i do 2 steps.

first: i click W hotkey, to open mass file renamer, and load "by artist" or "by label" preset  and  make "move entire parent directory..." - for moving all NFO,SFV,and jpg files to new release path

second: and then im again press W hotkey, and select  "rename files"

so firstly i move entire folder to new path, and then i rename files in this new path.

and i want to ask how u make this job? can i do "move" and then "rename" with only one step??

foo_discogs

Reply #421
Thanks a lot guys , it really works as i desired! feeling a bit noober than guilty, but your answers were a lot faster than i'd have found the one reading all the tagging threads.
This vinyltrack thingie is still a bit complicated tho, since the field collects the general tracknumber datas too, regardless it's first char is a letter, or just plain numbers which is not too vinylish (or is there a regexp to do this "copy value only with first character alphabet" trick?) .

Thanks again & Cheers!

foo_discogs

Reply #422
This vinyltrack thingie is still a bit complicated tho, since the field collects the general tracknumber datas too, regardless it's first char is a letter, or just plain numbers which is not too vinylish (or is there a regexp to do this "copy value only with first character alphabet" trick?) .
Thanks again & Cheers!


There's a bug with last released version with VINYLTRACK where for some release it has a numeric value while it should have not. Correctex in next release: now VINYLTRACK has a value only if format is "Vinyl" or "Acetate"


Quote
i have a question...

when i move/rename already downloaded releases from download folder to the right path, i do 2 steps.

first: i click W hotkey, to open mass file renamer, and load "by artist" or "by label" preset  and  make "move entire parent directory..." - for moving all NFO,SFV,and jpg files to new release path

second: and then im again press W hotkey, and select  "rename files"

so firstly i move entire folder to new path, and then i rename files in this new path.

and i want to ask how u make this job? can i do "move" and then "rename" with only one step??


I use "rename or move files " in the "Do what" section of the mass file renamer.
The only problem is that it won't move non-audio files to the destination (such an option would be really useful to have). As in a release directory I only have album art, I always bacth fetch art when files are in their definitive location, not at tag time. So I  understand why you must do it in 2 pass in your case


foo_discogs

Reply #424
v1.12 released!

+ fix: editing a tag mapping could attribute it to the wrong discogs info
+ fix: incomplete url escaping was producing XML parse error (release 239279)
+ fix: %DISCOGS_ARTIST_ID% is now fetched and written with the XML API
+ chg: retrieve art using XML API urls instead of old HTML method (faster)
+ fix: small art preview is now displayed when using the XML API
+ fix: artist art directory is created if it does not exist
+ chg: subtracks are now part of the discogs track listing if they have some length (that mean they are real tracks, instead of separators)
(ex: release 891540, subtracks are skipped)
+ fix: %DISCOGS_CREDIT_FEATURING%, %DISCOGS_CREDIT_VOCALS%, %DISCOGS_CREDIT_REMIX% now handle multiples credits (ex: release 1085782, track 11)
+ add: value written for %ALBUM_ARTIST% when release is a compilation is now configurable (default: "Various Artist")