Please do not mix files from different foobar2000 releases

Topic: Please do not mix files from different foobar2000 releases (Read 2428 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Please do not mix files from different foobar2000 releases

2021-01-12 11:00:52

I have noticed from crash report data that some users run new foobar2000 exe with old DLLs, presumably because they update foobar2000 by copying just the exe manually extracted from the installer.
Please stop doing this.
For one thing, it means that DLL bugs fixed long ago live forever on your system - including any potential security issues with the decoders.
Additionally, some new core features specifically require new DLLs, such as interop between Properties dialog and ReplayGain scanner. Running mismatching versions is likely to break these features creating obscure issues.

Starting with foobar2000 v1.6.3, people who mix DLL versions will get a warning prompt on each startup. The prompt cannot be disabled.

Would you also expect Windows OS to run correctly if you replaced random system files with ones from a different major release?

Re: Please do not mix files from different foobar2000 releases

Reply #1 – 2021-01-12 12:02:16

That's right,it would be good to decide on an update algorithm that will be clear even to a novice user.

Re: Please do not mix files from different foobar2000 releases

Reply #2 – 2021-01-12 14:54:43

Quote from: SergPuh.68 on 2021-01-12 12:02:16

it would be good to decide on an update algorithm that will be clear even to a novice user

Run installer and update. Isn't this algorithm clear enough?

Re: Please do not mix files from different foobar2000 releases

Reply #3 – 2021-01-12 16:08:17

I suspect that people copy folders when setting up fb2k on a "new" computer (like at work), in order to get config and everything copied over. (1) Install new version, (2) copy folders from old version, and therefore end up with this.

In the very least, the warning should tell people to re-run their installer (assuming the installer actually fixes it).

Re: Please do not mix files from different foobar2000 releases

Reply #4 – 2021-01-12 16:41:00

Rollin,if installing the latest portable version of the player in the root folder of any author's build is the correct method, then this is very good.Personally, I used a different method until the last moment, for fear of violating the user settings of the outdated version of the player.

Re: Please do not mix files from different foobar2000 releases

Reply #5 – 2021-01-12 16:52:56

Installer doesn't change user settings.

Re: Please do not mix files from different foobar2000 releases

Reply #6 – 2021-01-12 20:58:06

The startup prompt says:

Quote

Corrupted foobar2000 installation - component(s) come from a different version of foobar2000:
<list of DLLs>

Please reinstall foobar2000 to correct this.

Why would the installer change any settings?
And then if you don't trust the installer, why do you trust the software that it installs?

Re: Please do not mix files from different foobar2000 releases

Reply #7 – 2021-01-13 08:27:47

You're overthinking this one, Peter. You can only idiot-proof things so much...

Re: Please do not mix files from different foobar2000 releases

Reply #8 – 2021-01-13 09:21:13

Quote from: Peter on 2021-01-12 20:58:06

And then if you don't trust the installer, why do you trust the software that it installs?

As @NateHigs says, you are overthinking. fb2k appeals to people who want their own customization. "I don't want defaults back" is not the same as "I don't trust the software".

There have been lots of questions raised on how to copy the config from one fb2k install to another. I'm sure that plenty of users have copied their entire folder to foobar2000_bup, upgraded and then copied "something" back until it works and looks like it did. Next time they might have found out that hell, can't I just pull the exe out? Next upgrade ... do what worked.

None of this need to be "distrust". Only good ol'fashioned laziness.

Re: Please do not mix files from different foobar2000 releases

Reply #9 – 2021-01-13 11:06:14

Quote from: NateHigs on 2021-01-13 08:27:47

You're overthinking this one, Peter. You can only idiot-proof things so much...

With all due respect, it's useful info, people should be aware of potential issues. Besides, this is clearly an effort to correct a practice that leads to instability and wasted development. I'm sure it's hard enough debugging a normal crash report without having to worry about 'frankenstein' installs. Indeed, anything that streamlines the process, aids overall progress. Furthermore, anything that creates even an impression of instability reflects upon the software and its author. This is a responsible move that protects Foobar's reputation and Peter's time, both of which are highly important. I see this as both a practical and necessary thing to do. After all, this isn't a fashion show with 'accessories' this is an engine with parts. Unless anyone has a better idea for fixing this situation? Just saying. ;~)

Re: Please do not mix files from different foobar2000 releases

Reply #10 – 2021-01-13 12:21:29

Quote from: Porcus on 2021-01-13 09:21:13

As @NateHigs says, you are overthinking.

But I think I misread the rest.

This move won't "idiot proof", it will just tell "idiots" (or lazies) how to easily fix. Good. Works better than than shouting "stop" in a forum.

Re: Please do not mix files from different foobar2000 releases

Reply #11 – 2021-01-13 13:52:20

Quote from: NateHigs on 2021-01-13 08:27:47

You're overthinking this one, Peter. You can only idiot-proof things so much...

I hope this is a translation problem

Re: Please do not mix files from different foobar2000 releases

Reply #12 – 2021-01-13 20:50:35

Quote from: NateHigs on 2021-01-13 08:27:47

You're overthinking this one, Peter. You can only idiot-proof things so much...

I see repeating crash reports - tagged as coming from the latest version - that are actually old bugs resurfacing because of the scenario described above.
Even if I didn't really care about users who do weird things, I still have to get these reports out of the way when hunting for valid bugs.

Re: Please do not mix files from different foobar2000 releases

Reply #13 – 2021-01-19 18:10:02

I don't love the idea of this warning message. In my case I'm intentionally using an old version of the ReplayGain component so I can scan my music with the original (non-EBU R128) algorithm.

Would there be any possibility of adding the "classic" RG algorithm back into the RG component as a user-selectable option? Then I could always use the current version of the RG component going forward.

(I suggested this a while back. Maybe you could bury it deep in advanced settings, if there's any concern about it confusing people?)

Notice