For now though I just have a minor, issue / question / request. (An issquesest?) If one (me) did not want to see the SMP Playback Statistics in track properties, how could one (I) turn display of them off? Might it please be possible? (We looked for options)

The thing is with 'Selection Properties' (DUI) element, all stats are lumped / jumbled together under 'Other' along with official Playback Statistics (foo_playcount) component. So I guess that is limitation of the element. However the original PS 'Rating' (displayed as stars) is gone altogether, replaced by SMP 'Rating' (with no stars, because not using it) - not very complementary. I'd prefer to see my original ratings.

I just noticed the stats show up twice in the properties tab. I still have JScript panel installed of course. It's not a problem, I just wonder why this happens:

I've seen a previous request by @loz for custom tags, but I did not understand if they're planned to be implemented. Anyway I definitely second that request.

Eventually I ran into a problem. I use some text files to share layout settings between jscript panels and panel stack splitter. I have a script which deletes a specific file when triggered, using the FileSystemObject DeleteFile method. It's a very simple script and it always worked with JScript Panel, but since migrating to Spider Monkey Panel the delete action is denied because the file is in use by foobar2000. I cannot even delete the file manually.

Quote from: davideleo on 2019-02-08 21:02:31

Eventually I ran into a problem. I use some text files to share layout settings between jscript panels and panel stack splitter. I have a script which deletes a specific file when triggered, using the FileSystemObject DeleteFile method. It's a very simple script and it always worked with JScript Panel, but since migrating to Spider Monkey Panel the delete action is denied because the file is in use by foobar2000. I cannot even delete the file manually.

Could you provide the script (or it's relevant parts)?

function on_size(){
    switch (window.Height){
        case 0:
        if (fso.FileExists(SettingsPath + "PlaylistVisible")) fso.DeleteFile(SettingsPath + "PlaylistVisible");
        RefreshPSS();
        break;
        case 1:
        if (!fso.FileExists(SettingsPath + "PlaylistVisible")) fso.CreateTextFile(SettingsPath + "PlaylistVisible");
        RefreshPSS();
        break;   
        case 2:
        if (fso.FileExists(SettingsPath + "PlaylistVisible")) fso.DeleteFile(SettingsPath + "PlaylistVisible");
        RefreshPSS();
        break; 
    }
}  

var fso = new ActiveXObject("Scripting.FileSystemObject"); 
var SettingsPath = fb.ProfilePath + "settings\\";

function RefreshPSS() {
var Refresh_sys = window.GetProperty("Refresh_sys",true);
 if (Refresh_sys < true) {
	if (fb.IsPlaying || fb.IsPaused) {  
		fb.RunMainMenuCommand("View/Show status bar");
		fb.RunMainMenuCommand("View/Show status bar");
	} else {
		fb.RunMainMenuCommand("View/Show status bar");
		fb.RunMainMenuCommand("View/Show status bar");
	}
} else {
	if (fb.IsPlaying || fb.IsPaused) {  
		fb.RunMainMenuCommand("Playback/Play or Pause");
		fb.RunMainMenuCommand("Playback/Play or Pause");
	} else {
		fb.RunMainMenuCommand("Playback/Play");
		fb.RunMainMenuCommand("Playback/Stop");
	}
	}
}

Quote from: davideleo on 2019-02-08 10:54:29

I just noticed the stats show up twice in the properties tab. I still have JScript panel installed of course. It's not a problem, I just wonder why this happens:

That is the intended behaviour: SMP and JSP use different (internal) tags to avoid potential compatibility issues.

The script seems to work for a few times right after foobar2000 start up, but eventually something happens which blocks the file, and I can't figure out what it could even be.

TLDR: Use the following code fso.CreateTextFile(path).Close(); or let file = fso.CreateTextFile(path); file.Close();

Full story: the problem is caused by your usage of fso.CreateTextFile: CreateTextFile returns a file object, which contains an open handle to the file, which will be closed only in two cases - when object is destroyed and when it's closed manually. The lifetime of JS objects is variable, i.e. objects might not be immediately destroyed when there are no references to them, so in your case: object is alive & not closed > handle remains open > file remains locked.

Thanks, that was it. So, the real question is: why did it work with JScript panel?

I'm not sure if it's a system specific, user  , script or Spider Monkey Panel problem but:
- mouse-on and double click functions of "album art" sample stopped working. They used to work with SMP and work fine with JScript Panel.

In the mean time you can apply the fix manually - https://github.com/marc2k3/smp_2003/commit/c12b44f25fb5b810a7c92366e324191a2a0ce5bf

I was wondering if anyone else was having this problem with the SMP thumbs panel.  It works fine except when displaying the thumbs in a grid.  They display fine initially, but when clicking on a specific thumb to display it I get the following error.  Any ideas?

Error: Spider Monkey Panel v1.1.5 (Thumbs by marc2003)
_.drawOverlay is not a function

File: thumbs.js
Line: 100, Column: 5

Stack trace:
  _thumbs/this.paint@thumbs.js:100:5
  on_paint@<main>:58:2

Anybody knows if somebody already did a JS better than the default Album List DUI component?

// ==PREPROCESSOR==
// @name "Last.fm Album Art Downloader"
// @author "marc2003"
// @import "%fb2k_component_path%samples\complete\js\lodash.min.js"
// @import "%fb2k_component_path%samples\complete\js\helpers.js"
// @import "%fb2k_component_path%samples\complete\js\panel.js"
// ==/PREPROCESSOR==


var SettingsPath = fb.ProfilePath + "settings\\";
var library_tracks_only = false;
var folder_tf = fb.TitleFormat("$puts(folder,$trim($replace($lower($directory(%path%)),disc,,cd,)))$replace($directory_path(%path%),$ifequal($strstr($get(folder),$num($get(folder),$len($get(folder)))),1,\\%directoryname%,),)\\");
var filename_tf = fb.TitleFormat("front.jpg");

var panel = new _.panel("Last.fm Album Art Downloader", ["metadb", "custom_background"]);
var x = new ActiveXObject("Microsoft.XMLHTTP");
var ini = SettingsPath + "album-art.ini";
_.createFolder(SettingsPath);

panel.item_focus_change();

function on_metadb_changed() {
	var np = fb.GetNowPlaying();
	if (panel.metadb && np && np.Compare(panel.metadb) && np.RawPath.indexOf("file://") == 0 && (!library_tracks_only || fb.IsMetadbInMediaLibrary(np))) {
		var ar = panel.tf("%album artist%");
		var al = panel.tf("%album%");
		var f = folder_tf.EvalWithMetadb(panel.metadb) + _.fbSanitise(filename_tf.EvalWithMetadb(panel.metadb));
		var tmp = _.q(_.fbSanitise(ar + al));
		var n = _.round(_.now() / 1000);
		var t = utils.ReadINI(ini, "Timestamps", tmp, 0);
		
		switch (true) {
		case !_.tagged(ar):
		case !_.tagged(al):
		case _.isFile(f):
		case n - t < ONE_DAY:
			break;
		default:
			utils.WriteINI(ini, "Timestamps", tmp, n);
			x.open("GET", "https://www.last.fm/music/" + encodeURIComponent(ar) + "/" + encodeURIComponent(al) + "/+images", true);
			x.setRequestHeader("If-Modified-Since", "Thu, 01 Jan 1970 00:00:00 GMT");
			x.send();
			x.onreadystatechange = function () {
				if (x.readyState == 4) {
					if (x.status == 200) {
						var o = _.first(_.filter(_.getElementsByTagName(x.responsetext, "img"), {"className" : "image-list-image"}));
						if (o) {
							var u = o.src.replace("avatar170s", "ar0");
							_.runCmd("cscript //nologo " + _.q(fb.ProfilePath + "scripts\\JSP\\download.vbs") + " " + _.q(u) + " " + _.q(f), false);
							window.SetTimeout(function () {
								panel.item_focus_change();
							}, 3000);
						}
					} else {
						console.log("HTTP error: " + x.status);
					}
				}
			}            
			break;
		}
	}
	RefreshPSS();
}

function RefreshPSS() {
var Refresh_sys = window.GetProperty("Refresh_sys",true);
 if (Refresh_sys < true) {
	if (fb.IsPlaying || fb.IsPaused) {  
		fb.RunMainMenuCommand("View/Show status bar");
		fb.RunMainMenuCommand("View/Show status bar");
	} else {
		fb.RunMainMenuCommand("View/Show status bar");
		fb.RunMainMenuCommand("View/Show status bar");
	}
} else {
	if (fb.IsPlaying || fb.IsPaused) {  
		fb.RunMainMenuCommand("Playback/Play or Pause");
		fb.RunMainMenuCommand("Playback/Play or Pause");
	} else {
		fb.RunMainMenuCommand("Playback/Play");
		fb.RunMainMenuCommand("Playback/Stop");
	}
	}

}

'use strict';

window.DefinePanel('Last.fm Album Art Downloader', {author:'marc2003'});
include(fb.ComponentPath + 'samples\\complete\\js\\lodash.min.js');
include(fb.ComponentPath + 'samples\\complete\\js\\helpers.js')
include(fb.ComponentPath + 'samples\\complete\\js\\panel.js');


var SettingsPath = fb.ProfilePath + "settings\\";
var library_tracks_only = false;
var folder_tf = fb.TitleFormat("$puts(folder,$trim($replace($lower($directory(%path%)),disc,,cd,)))$replace($directory_path(%path%),$ifequal($strstr($get(folder),$num($get(folder),$len($get(folder)))),1,\\%directoryname%,),)\\");
var filename_tf = fb.TitleFormat("front.jpg");

let panel = new _panel("Last.fm Album Art Downloader", ["metadb", "custom_background"]);
var x = new ActiveXObject("Microsoft.XMLHTTP");
var ini = SettingsPath + "album-art.ini";
_createFolder(SettingsPath);

panel.item_focus_change();

function on_metadb_changed() {
	var np = fb.GetNowPlaying();
	if (panel.metadb && np && np.Compare(panel.metadb) && np.RawPath.indexOf("file://") == 0 && (!library_tracks_only || fb.IsMetadbInMediaLibrary(np))) {
		var ar = panel.tf("%album artist%");
		var al = panel.tf("%album%");
		var f = folder_tf.EvalWithMetadb(panel.metadb) + _fbSanitise(filename_tf.EvalWithMetadb(panel.metadb));
		var tmp = _q(_fbSanitise(ar + al));
		var n = _.round(_.now() / 1000);
		var t = utils.ReadINI(ini, "Timestamps", tmp, 0);

		switch (true) {
		case !_tagged(ar):
		case !_tagged(al):
		case _isFile(f):
		case n - t < ONE_DAY:
			break;
		default:
			utils.WriteINI(ini, "Timestamps", tmp, n);
			x.open("GET", "https://www.last.fm/music/" + encodeURIComponent(ar) + "/" + encodeURIComponent(al) + "/+images", true);
			x.setRequestHeader("If-Modified-Since", "Thu, 01 Jan 1970 00:00:00 GMT");
			x.send();
			x.onreadystatechange = function () {
				if (x.readyState == 4) {
					if (x.status == 200) {
						var o = _first(_filter(_getElementsByTagName(x.responsetext, "img"), {"className" : "image-list-image"}));
						if (o) {
							var u = o.src.replace("avatar170s", "ar0");
							_runCmd("cscript //nologo " + _q(fb.ProfilePath + "scripts\\SMP\\download.vbs") + " " + _q(u) + " " + _q(f), false);
							window.SetTimeout(function () {
								panel.item_focus_change();
							}, 3000);
						}
					} else {
						console.log("HTTP error: " + x.status);
					}
				}
			}
			break;
		}
	}
	RefreshPSS();
}

function RefreshPSS() {
var Refresh_sys = window.GetProperty("Refresh_sys",true);
 if (Refresh_sys < true) {
	if (fb.IsPlaying || fb.IsPaused) {  
		fb.RunMainMenuCommand("View/Show status bar");
		fb.RunMainMenuCommand("View/Show status bar");
	} else {
		fb.RunMainMenuCommand("View/Show status bar");
		fb.RunMainMenuCommand("View/Show status bar");
	}
} else {
	if (fb.IsPlaying || fb.IsPaused) {  
		fb.RunMainMenuCommand("Playback/Play or Pause");
		fb.RunMainMenuCommand("Playback/Play or Pause");
	} else {
		fb.RunMainMenuCommand("Playback/Play");
		fb.RunMainMenuCommand("Playback/Stop");
	}
	}

}

var o = _.first(_.filter(_getElementsByTagName(x.responseText, "img"), {"className" : "image-list-image"}));