Skip to main content
Topic: Biography Text, Album Info, Picture. www.last.fm (Read 12108 times) previous topic - next topic - Topic derived from Re: WSH Panel Mod scr...
0 Members and 1 Guest are viewing this topic.

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #50
hello kgena_ua

thank you very much
all works perfect
you're great

thx a lot

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #51
lender1257,
glad to be useful
I.m. UR5EQF


Re: Biography Text, Album Info, Picture. www.last.fm

Reply #53
hello kgena_ua

thank you very much
all works perfect
you're great

thx a lot

I work fine with foo_uie_wsh_panel_mod 1.56
good!

 

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #54
hi kgena_ua

bio: searching for THE V.I.P.'s (availabe in english last.fm) but script founds: THE VIP's (= false artist)
can you please make a correction.

thx

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #55
bio: searching for THE V.I.P.'s (availabe in english last.fm) but script founds: THE VIP's (= false artist)

Hi.
Is it? If no give me a LastFM link
I.m. UR5EQF






Re: Biography Text, Album Info, Picture. www.last.fm

Reply #61
Hi kgena_ua!
I gladly tested your component (for jscript panel), there are positive improvements.
It is making a good alternative.
Keep it up!

Regards.

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #62
Sergey77, thanks, I like it myself
I.m. UR5EQF


Re: Biography Text, Album Info, Picture. www.last.fm

Reply #64
would you bring these options back ?
?
displayed menu items from another of my scripts - "Get Covers (Artwork) radio logos".
I.m. UR5EQF


Re: Biography Text, Album Info, Picture. www.last.fm

Reply #66
Thank you for all of your hard work, kgena_ua. This component is one of my favorites! Also, I'm not sure where to post bug reports but I hope its alright to post the fix here. If there is no active internet connection and the biography is not cached, then a crash occurs. Here is a screenshot of the error:

The fix was to replace this line (around line 549, use control+f to search):
Code: [Select]
if (this.xmlhttp != null && this.func != null) {if (this.xmlhttp.readyState == 4) {if (this.xmlhttp.status == 200) this.func(); else {this.on_search_done_callback(artist, list, done, handles);}}}
with this line:
Code: [Select]
    
this.on_state_change = function() {
if (this.xmlhttp != null && this.func != null) {
if (this.xmlhttp.readyState == 4) {
if (this.xmlhttp.status == 200) {
this.func();
} else {
if (this.on_search_done_callback != null) {
this.on_search_done_callback(artist, list, done, handles);
}
}
}
}
}
Now, the null check prevents the script from crashing and instead displays placeholder text. Attached are images of each event. Also, GetColour() works on the current version of JScript Panel. That error only affects older versions.

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #67
It seems that this report concerns JScript Biography 0.9.0.2, and would have been best put in the discussion thread dedicated to that. Not to worry, I'll try and fix it for the next version. However, it's not actually currently obvious to me why your fix worked, since the callback is defined (line 542) as it's sent to the master function (line 541). I couldn't seem to reproduce the issue. Anyway I'll think about it further. Line 549 in the release version is also just a "}" and not an object and so I would like to be sure that the issue occurs with the script in a completely unmodified state. Please post any further discussion here.

Thanks for the report.


Re: Biography Text, Album Info, Picture. www.last.fm

Reply #69
Well, this is embarrassing. I'm sorry for the inconvenience.


Re: Biography Text, Album Info, Picture. www.last.fm

Reply #71
what's new in this version?
please always post your changes
thanks

- optimization;
- added lyrics for the selected track;
- changes in the main menu (see "Menu setting");
- added external links for artists and related artists.
I.m. UR5EQF

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #72
what's new in this version?
please always post your changes
thanks

- optimization;
- added lyrics for the selected track;
- changes in the main menu (see "Menu setting");
- added external links for artists and related artists.

@kgena_ua

additional question:
is this script for wsh_panel_mod or
for jscript 1.3.2.2 or
for jscript 2.1.6

please also provide this information in the future if you change your script

thank you

Re: Biography Text, Album Info, Picture. www.last.fm

Reply #73
"Biography, Albums, Similar and title artist info. www.last.fm"
version "14092018"


Minor corrections and optimization .

Added:
- when viewing information about the artist, the meaning of the lines "popular this week" and "the latest releases" are clickable (double click).

The saved data (if saved) must be deleted, or use the menu item Refresh.
The Properties menu must be updated.

The script is compatible with:
- wsh_panel_mod ;
- jscript_panel (all version).
I.m. UR5EQF

 
SimplePortal 1.0.0 RC1 © 2008-2018