JScript Panel - Page 15

Topic: JScript Panel (Read 81111 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Re: JScript Panel

Reply #350 – 2017-11-17 03:42:27

I've been checking the docs and there is some inconsistency where some methods return 4294967295 (or Math.pow(2, 32) -1) for things that aren't found and others are returning -1. I shall be making this consistent in the next update by using -1 for all because it's what people are used to when using Javascript.

edit: I've updated the Breaking Changes page on the wiki with the upcoming changes...

https://github.com/19379/foo-jscript-panel/wiki/Breaking-Changes#v131

Re: JScript Panel

Reply #351 – 2017-11-17 12:31:06

v1.3.1 Beta1 (final release notes a few posts down)

Unfortunately, nothing new but fixes a few things and updates the docs to be more consistent. It's a beta because it has a few internal changes and I might not have caught everything.

https://github.com/19379/foo-jscript-panel/releases

My own "status bar.txt" sample in the "complete" folder was broken by this update so anyone else using it will need to re-import.

Re: JScript Panel

Reply #352 – 2017-11-18 19:25:03

Out of curiosity, is there a reason why to remove the IStyleTextRender interface?

Also, do you know if it possible, in a JS Smooth Playlist panel to reorder the tracks within playlist withdrag n' drop ? I can't do it. Too bad because it's possible with JSPlaylist (which is... not smooth sadly).
Maybe only Falstaff could tell...

Thanks anyway for your great component!

Re: JScript Panel

Reply #353 – 2017-11-19 05:14:34

The styletextrender thingy required an entire 3rd party project to be part of the Visual Studio solution and I selfishly got rid of it because I never use it. I know I should try and be more considerate of others but I'm mean!!

WSH panel mod still works and there is WSH panel mod plus which shares many of the newer features with JScript Panel.

As for the playlist, you know the answer. They both use the same component!

Re: JScript Panel

Reply #354 – 2017-11-20 09:03:03

Any chance of a non SSE2 build?

I thought maybe version 1.1.0 might work, but sadly, the author has removed all binaries on Github earlier than version 1.2.4.

Edit - I'm trying to run this on a XP machine. Saw in the changelog that 1.3.0 drops IE8/IE7/WINE support. So I tried 1.2.4 and got the same error. It's SSE2 related. Wish I knew how to compile it so I could try to do so with SSE2 requirement disabled.

Re: JScript Panel

Reply #355 – 2017-11-20 09:45:48

This component has never ran on XP. Older versions with support for IE7/IE8 still required Vista or above.

The component it was based on (WSH panel mod) still runs on XP because it hasn't been updated since 2012...

https://code.google.com/archive/p/foo-wsh-panel-mod/downloads

Re: JScript Panel

Reply #356 – 2017-11-20 09:52:04

OK, that makes sense, thanks!

Re: JScript Panel

Reply #357 – 2017-11-23 08:43:30

Code: [Select]

v1.3.1
- FIX: Fixed a bug where plman.IsPlaylistItemSelected didn't return a proper boolean
       value. Thanks to TheQwertiest for reporting.
- FIX: Fixed a bug where plman.ShowAutoPlaylistUI didn't always return the correct
       boolean value.
- CHG: plman.MovePlaylistSelection now returns a boolean value to indicate success
       or failure.
- CHG: Update docs for consistency with actual component behaviour. Some methods
       which returned useless values have been updated to return nothing.
- CHG: On failure, these now return -1
       IFbFileInfo InfoFind
       IFbFileInfo MetaFind
       IFbMetadbHandleList BSearch
       IFbMetadbHandleList Find
       plman.ActivePlaylist
       plman.CreateAutoPlaylist
       plman.PlayingPlaylist
       This could potentially break some existing scripts. See
       https://github.com/19379/foo-jscript-panel/wiki/Breaking-Changes#v131
- CHG: Remove the whole IStyleTextRender interface. Anything that uses
       gdi.CreateStyleTextRender or was based on "glow text sample.txt"
       will no longer work
- CHG: Remove these IFbPlaylistRecyclerManager properties/methods:
       Id
       FindById
       RestoreById

No changes since beta.

https://github.com/19379/foo-jscript-panel/releases

Re: JScript Panel

Reply #358 – 2017-11-23 13:00:49

With 1.3.1 and DarkOne4Mod, I now get the following error:

JScript Panel (DarkOne4Mod - Cover Panel v1.0 build20160929 by tedGo, includes partial code by T.P Wang)
Laufzeitfehler in JavaScript:
Das Objekt unterstützt die Eigenschaft oder Methode "CreateStyleTextRender" nicht
File: <main>
Line: 10, Col: 1
<source text only available at compile time>

Ist there a chance to correct this error?

Re: JScript Panel

Reply #359 – 2017-11-23 13:06:31

Quote from: carp on 2017-11-23 13:00:49

With 1.3.1 and DarkOne4Mod, I now get the following error:

JScript Panel (DarkOne4Mod - Cover Panel v1.0 build20160929 by tedGo, includes partial code by T.P Wang)
Laufzeitfehler in JavaScript:
Das Objekt unterstützt die Eigenschaft oder Methode "CreateStyleTextRender" nicht
File: <main>
Line: 10, Col: 1
<source text only available at compile time>

Ist there a chance to correct this error?

See post above you:

Quote

- CHG: Remove the whole IStyleTextRender interface. Anything that uses
gdi.CreateStyleTextRender or was based on "glow text sample.txt"
will no longer work

Re: JScript Panel

Reply #360 – 2017-11-23 13:44:14

Thanks! So I have to wait for Tedgo to update his DarkOne4Mod. Is the previous version 1.3.0 of JScript Panel still available as a foobar2000 component?

Re: JScript Panel

Reply #361 – 2017-11-23 13:56:22

Replace the code in the panel with this...

https://pastebin.com/tLqCXvH3

Re: JScript Panel

Reply #362 – 2017-11-23 14:17:45

Thank you marc2003! This works!

Re: JScript Panel

Reply #363 – 2017-11-24 10:15:48

Encountered a small bug in panel properties:
If you select an entry and then scroll, the entry's value will remain at the same (but wrong) place. For example:

Re: JScript Panel

Reply #364 – 2017-11-24 11:30:05

I find that pretty hard to reproduce but I do get the occasional flicker.

FWIW, it looks like 3rd party PropertyList library is to blame but I have no idea how to fix it.

Re: JScript Panel

Reply #365 – 2017-11-24 13:41:43

Quote from: marc2003 on 2017-11-23 08:43:30

- CHG: Remove the whole IStyleTextRender interface. Anything that uses
gdi.CreateStyleTextRender or was based on "glow text sample.txt"
will no longer work

Is there anything to replace " gdi.CreateStyleTextRender" thing?

Re: JScript Panel

Reply #366 – 2017-11-24 20:30:11

Quote from: marc2003 on 2017-11-24 11:30:05

I find that pretty hard to reproduce but I do get the occasional flicker.

I can consistently reproduce it though. The easiest way:
1. Open property list that is big enough to have scrollbar.
2. Click on top item to make it 'blue'.
3. Click on 'arrow down' button on scrollbar.
Result: value of first item is wrong now and matches the selected 'blue' item.

Quote from: marc2003 on 2017-11-24 11:30:05

FWIW, it looks like 3rd party PropertyList library is to blame but I have no idea how to fix it.

I've tried debugging a bit (lib is back from 2003, lol), but couldn't find the exact source of the problem. I've managed to prevent the bug from happening by removing "bHandled = FALSE" from OnLButtonUp method (PropertyList.h:605). But that's just brute-force programming -_-. This lib should be probably replaced some day with the more robust one (and may be a bit younger than 14 years old).

Re: JScript Panel

Reply #367 – 2017-11-24 21:34:37

Quote from: TheQwertiest on 2017-11-24 20:30:11

I've managed to prevent the bug from happening by removing "bHandled = FALSE" from OnLButtonUp method (PropertyList.h:605).

Doing that results in crazy buggy behaviour.

Re: JScript Panel

Reply #368 – 2017-11-25 04:32:43

Code: [Select]

v1.3.2
- FIX: Improved handling of utf8 files without BOM. This affects files loaded
       via the PREPROCESSOR section and the Configuration window>Tools>Import button.
       They should now be treated the same as files with BOM.

https://github.com/19379/foo-jscript-panel/releases

Re: JScript Panel

Reply #369 – 2017-11-27 20:15:23

Quote from: widerock on 2017-11-24 13:41:43

Is there anything to replace " gdi.CreateStyleTextRender" thing?

I have the same question. My theme is using a bunch of TextRender stuff (GlowText, Shadow, RenderStringRect, etc.) and that's broken now. I had to roll back to 1.2.4 because I'm not sure what, if any, alternatives I've got.

Re: JScript Panel

Reply #370 – 2017-11-29 13:26:05

Since I can't help myself breaking things, I've removed the component from the official repository. At least now people can't blindly update using the components updater.

If people want to update, they should check the changelog and download manually from github.

Re: JScript Panel

Reply #371 – 2017-12-01 10:33:08

Yay for fb.AlwaysOnTop!
Btw, do you know if it's possible to make on_main_menu_command_status_changed callback with fb2k api?

Re: JScript Panel

Reply #372 – 2017-12-01 15:31:11

Recently, I've got this message.

JScript Panel (JS Smooth Browser v20151114-1630-340 by Br3tt aka Falstaff >> http://br3tt.deviantart.com)
JavaScript Runtime error:
Overflow
foo_jscript_panel\samples\js-smooth\js\jssb.js
Line: 1090, Col: 3
<source text only available at compile time>

I've looked into that line.

Code: [Select]

this.cursorImage_normal = gdi.CreateImage(this.cursorw, this.cursorh);

Could anyone let me know how I can fix it?

Re: JScript Panel

Reply #373 – 2017-12-01 15:33:24

Quote from: TheQwertiest on 2017-12-01 10:33:08

Yay for fb.AlwaysOnTop!
Btw, do you know if it's possible to make on_main_menu_command_status_changed callback with fb2k api?

I can't give a definitive answer but I'm pretty sure it's not possible.

However, it looks like other components may use the config_object API and that would give other components (like JScript Panel) the option to read/write/get notified of their settings changes. Of course they'd have to make this public knowledge if it's already implemented.

Re: JScript Panel

Reply #374 – 2017-12-02 11:29:30

ok, just forget it...