Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: ReplayGain scan silently skips files containing ReplayGain data (Read 1490 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

ReplayGain scan silently skips files containing ReplayGain data

Maybe it's always worked this way and I haven't noticed (although I'm fairly sure there was once a warning message), but when selecting multiple files and running a ReplayGain scan, files already containing ReplayGain data are silently skipped.

The "silently skipped" part seems like undesirable behaviour to me, and it prevents files containing ReplayGain data from being re-scanned, unless all the selected files contain RelayGain data, as that's the only time the user is asked if they should be re-scanned.

I've only tested this behaviour when scanning MP3s, so I don't know if it applies to all file types, but to my way of thinking the default behaviour should be to scan every file selected, otherwise the end result is the user is telling fb2k to do one thing with the expectation that's what it'll do, yet it does something else.

Thanks.

Re: ReplayGain scan silently skips files containing ReplayGain data

Reply #1 –
I can confirm it but I have no idea if it is not something that was here for a long time...

Re: ReplayGain scan silently skips files containing ReplayGain data

Reply #2 –
By and large, I would rather have it this way, especially if the alternative is to "overwrite files with unchanged information". But certainly, it has happened that some "Free sampler" has had RG tags from the album the track in question was taken from, and that is annoying sometimes.

Brainstorming possible changes for @Peter to consider:
* A checkbox under  Preferences -> Tools. I mean, there is a checkbox for Quiet mode ...
* Upon scannning, start off doing what it does now, but with a text saying "Omitted files that already have RG info. To rescan, Remove ReplayGain information first." That text could be put above the [Update File Tags] / [Cancel] buttons in the end dialogue.
* Same as previous, except a checkbox and "Omitted files that already have RG info. Check box to rescan the rest [_]."



Quote from: yetanotherid on
when selecting multiple files and running a ReplayGain scan, files already containing ReplayGain data are silently skipped.

It does depend on whether it needs it. For album gain, it will only skip entire albums that are already done. If you delete Album Gain from one of the tracks, it will need to scan all in the album in order to find (and write) Album Gain.
But I just tried to delete "album peak" from one track in an album.  Then fb2k assumes all are tagged.

Re: ReplayGain scan silently skips files containing ReplayGain data

Reply #3 –
Thanks for the replies.
Currently there's a message popup when you attempt to rescan files containing ReplayGain data and all the files contain ReplayGain info (I'm referring to existing track gain volume as I haven't tested anything else), but the more I think about it, the more I'm sure in the not too distant past there was a similar popup message when "some" of the files already contained ReplayGain data.

If I'm remembering correctly, I'd prefer that. I think it's better to be asked if you want to re-scan files than to skip them without warning.

PS. I really, really wish the popup warning before losslessly adjusting the volume of files included a checkbox labelled something like:
"I've read this warning message at least 300 times and I'm confident I understand. Please don't warn me again"
Life was just a tiny bit less irritating when you could disable that warning. :)

Cheers.

Re: ReplayGain scan silently skips files containing ReplayGain data

Reply #4 –
Quote from: EpicForever on
I can confirm it but I have no idea if it is not something that was here for a long time...
This has been as long as i can remember. I always use Remove ReplayGain Information from files first before scan when adding new files to my music archive.
 

Re: ReplayGain scan silently skips files containing ReplayGain data

Reply #5 –
Yes, if the behaviour was different at some stage, it must have been a while ago, as I installed a portable flavour of fb2k 1.1.11 and it behaves the same way. Files already containing ReplayGain track gain info are silently skipped when running a track scan.

I guess I'll be doing the same from now on, and removing any existing ReplayGain info when I want to re-scan files. My memory must be bad, although it does make me wonder how often I've scanned files and assumed they were all being scanned and their ReplayGain info was being updated, when they weren't being scanned at all.

Cheers.