Skip to main content
Topic: foo_discogs (Read 832316 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: foo_discogs

Reply #2375
^Thanks a lot for the update, zoomorph! A short test on some of the problematic double CDs confirms that the problem has gone.
You are doing an amazing job on this invaluable component.

Re: foo_discogs

Reply #2376
Heya.
Thinking out loud for now... there's a few user account specific things from my discogs collection I might be interested in embedding into the files I tag; is this possible as is ?
i.e. IF there is user-notes on items in collections (I have a few organizational, custom 'folders' on discogs my collection is split into as well as some Notes) - is there a way to get these (i.e. Media Condition, Sleeve Condition, Notes, Folder) as a field/tag through the discogs tagger ? The former 2 I have no use for personally, but Notes & Folder user data could be interesting...

I'm asking as I can not see user data centric fields in the mapping dialogue...
Cheers.
c.

Re: foo_discogs

Reply #2377
Heya.
A week of silence probably means that the above isn't possible as is and there's no plans to add it either...?
Just wondering if I should put this out of my mind, or if adding custom user data from discogs releases in user connction is something possible/planned (but might be there's a can of worms with this as well when it comes to the discogs API... who knows... ).
Churs.
c.

Re: foo_discogs

Reply #2378
Hi zoomorph,

I found a big bug ;-) (or, at least something strange to me...)

I wanted to only tag 1 file (11 karma chameleon) and did not deleted -out of lazyness- all the useless tracks from the tracklist.
The fine component was loading all lots of artist infos (left in the tracklist) and so it took very long.


With deleting all unnessecary artists, the generating process was done in less than a second, the above took about 20 seconds.


Could you update your component, to ignore everything in the tracklist for writting, which has no matching "physical" file?


Kind of a EDIT:
Well, after testing a little bit,
I found, that also writting tags like this, will load a lot of artists too.


That seems odd to me, but because the fine component is only showing artist IDs instead of real names, I cannot say, what was loaded.

Why is the component loading a lot of informations, when it only needs to load a single one?

tested with this release

Re: foo_discogs

Reply #2379
I personally don't use my discoGS accounts for anything but updating some minor glitches on releases, but that idea sounds useful to me.
To put some release-specific information into the files of yours could be great for some scripting purposes, like, when you automaticly want to generate an (autoplay)list of whatever... :-)

A week of silence probably means that the above isn't possible as is and there's no plans to add it either...?

Re: foo_discogs

Reply #2380
Hi zoomorph,

I found a big bug ;-) (or, at least something strange to me...)

I wanted to only tag 1 file (11 karma chameleon) and did not deleted -out of lazyness- all the useless tracks from the tracklist.
The fine component was loading all lots of artist infos (left in the tracklist) and so it took very long
Most likely one of your tag formatting strings is using this information. Example, a field starting with RELEASE_ARISTS_. Check the ALBUM ARTIST tag.

When tagging a full release there's no extra cost to using this, but if tagging a single file then yes it will load extra info.

Re: foo_discogs

Reply #2381
@zoomorph

I'm having a problem with the text color on the final "Preview Tags" dialog box when fetching tags from Discogs. My Windows theme uses a dark background for the text area (very dark grey), so black text is very hard to see unless I have my face right up close to the screen. The light grey text color for the highlighted tags (DISCOGS_BLAHBLAH_ID) is fine, just the black is problematic. Would it be possible to get it to use the default system text color dynamically rather than fixing it as black the way the dialog boxes prior to "Preview Tags" ("Find Release" and "Match Tracks") do?

Re: foo_discogs

Reply #2382
@zoomorph

I'm having a problem with the text color on the final "Preview Tags" dialog box when fetching tags from Discogs. My Windows theme uses a dark background for the text area (very dark grey), so black text is very hard to see unless I have my face right up close to the screen. The light grey text color for the highlighted tags (DISCOGS_BLAHBLAH_ID) is fine, just the black is problematic. Would it be possible to get it to use the default system text color dynamically rather than fixing it as black the way the dialog boxes prior to "Preview Tags" ("Find Release" and "Match Tracks") do?
Shall fix that for the next release. Thanks.

Re: foo_discogs

Reply #2383
Hm... might anyone have an idea why this:
https://www.discogs.com/Various-Future-Reggae/release/2650220
does resolve to:
1-1    –The Black Seeds    Come To Me
2-1    –Winston Mcanuff    Mix Up Mood    [+13 HIDDEN]
2-2    –Takana Zion    Ithiopia    [+14 HIDDEN]

And this:
https://www.discogs.com/Various-Hyperdub-101/release/5693593
resolves to all single tracks as it should...

They have the same disc - track separator, and I can not see why the first would fail / match badly.
Any hints would be muchly appreciated as I can neither see a way to fix this on discogs, as it looks the same as a release that works flawlessly, nor on foo_discogs, which does not have capabilities to alter mapping for hidden tracks (or does it somewhere...?)

Cheers.
c.

Re: foo_discogs

Reply #2384
Hm. More fun on the new machine (where I copied old .cfg files, so mass tagger syntax, shortcut keys, etc are all intact on new foobar version (I did go from 1.3.9 to 1.3.13 - which coul play into the below oddity))...
After testing EAC, flac decoder & foobar/discogs tagging, the last bit caused some issues. Foo discogs all worked, shortcut, gui pop up, release ID enter GUI, but on 'retrieving tags' it just froze. Foobar was still responsive & kept playing, but the 2 foo_discogs windows just stood there for 20+ minutes. The only thing I could think of that it could be a discogs key/oauth issue, but upon checking foobar console, this looks as usual ish to my eyes...

foo_discogs: https://api.discogs.com/releases/2310820?oauth_consumer_key=kQFLKuHXrEsVfZTDvOdz&oauth_nonce=148109708744aa&oauth_signature=5XFG4v0AV%2BwW8Nn0GNfXQyiYNXw%3D&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1481097087&oauth_token=bNciUoFlyyVumjpLWXtcAUOeBlHWTLGCLHmWkQqg&oauth_version=1.0
foo_discogs: https://api.discogs.com/artists/1843718?oauth_consumer_key=kQFLKuHXrEsVfZTDvOdz&oauth_nonce=148109709829&oauth_signature=zK2BiE%2FcYDPQoiW6iGpFsLR%2B4Vo%3D&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1481097098&oauth_token=bNciUoFlyyVumjpLWXtcAUOeBlHWTLGCLHmWkQqg&oauth_version=1.0
foo_discogs: https://api.discogs.com/artists/1665958?oauth_consumer_key=kQFLKuHXrEsVfZTDvOdz&oauth_nonce=14810971004823&oauth_signature=gAXuaMEnweIVlZfG06cZ1ZW9HEs%3D&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1481097100&oauth_token=bNciUoFlyyVumjpLWXtcAUOeBlHWTLGCLHmWkQqg&oauth_version=1.0
foo_discogs: https://api.discogs.com/artists/1843722?oauth_consumer_key=kQFLKuHXrEsVfZTDvOdz&oauth_nonce=148109710118be&oauth_signature=60Pf4okK9Ibjb%2BCKrSnZwT4nEQo%3D&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1481097101&oauth_token=bNciUoFlyyVumjpLWXtcAUOeBlHWTLGCLHmWkQqg&oauth_version=1.0


To get rid of the frozen windows, I then had to force-close foobar... which then got stuck, and needed to be force-closed again in task-manager.
Before I attempt this again - does anyone know where the discogs aoth key/token is stored ? I might start with deleting that first and retry tagging again with that.
This was what I wanted to tag btw:
https://www.discogs.com/Various-Next-Stop-Soweto-Vol-2-Soultown-RB-Funk-Psych-Sounds-From-The-Townships-1969-1976/release/2310820

Cheers.
c.

Re: foo_discogs

Reply #2385
Hm... might anyone have an idea why this:
https://www.discogs.com/Various-Future-Reggae/release/2650220
does resolve to:
1-1    –The Black Seeds    Come To Me
2-1    –Winston Mcanuff    Mix Up Mood    [+13 HIDDEN]
2-2    –Takana Zion    Ithiopia    [+14 HIDDEN]
I'm guessing because the format is incorrectly entered as 1 CD (it should be 2). This throws off the algorithm which parses the tracks & disc numbers.

Re: foo_discogs

Reply #2386
Thanks for the hint (any chance for a statement re the user discogs user data I asked about above ? I'd be rather curious to know if this is something you already are/would be considering, or might be you looked at this already in the past and there's too many hurdles for this to be viable...?).

As for the Cd in question, I changed on discogs:
- corrected CDs to 2, no change unfortunately
- the next difference to the Hyperdub compilation with the same numbering was that there were no Track run times, so I added those as well to see if it would fix it, but no dice either.

Very odd.
c.

ps. Also, what would be great would be some sort of trouble-shooting mode, where it fetches all tracks, hidden/subtracks/whatnot and gives the full list to the user to clean up, so one could alter that by hand at least to have a way out on issues like the above ?

Re: foo_discogs

Reply #2387
Try clearing your Releases cache (or restarting foobar2000). It parses properly for me now. Discogs API also caches for some time.

Re: foo_discogs

Reply #2388
Will do, don't have the album here atm.

One other thing, which I couldn't find an answer for:
- foo_discogs, for $joinnames(%<ARTISTS_NAME>%,%<ARTISTS_JOIN>%) - seems to always resolve to the 'master' artist name.
- IF these are in japanese/kyrillic/thai/etc on discogs, this will be the artist name written to tag.
- Since I can not read some of these, I would prefer to use the english spelling equivalent in some cases
i.e. this has a 'westernized' artist-name / tracklist combo:
https://www.discogs.com/Various-Thai-Dai-The-Heavier-Side-Of-The-Lukthung-Underground/release/2844256
Is there a possible formatting to either use the releases' artist spelling, or an explicit ANV for cases where the user would prefer to do so ? Or a combination of explicit ANVs ?
eg, for the first track in the above:
สรวง สันติ (Sroeng Santi)

Cheers.
c.

Re: foo_discogs

Reply #2389
One other thing, which I couldn't find an answer for:
- foo_discogs, for $joinnames(%<ARTISTS_NAME>%,%<ARTISTS_JOIN>%) - seems to always resolve to the 'master' artist name
That is controlled by the setting "Replace ANVs".

Re: foo_discogs

Reply #2390
Version 2.12 released:
* Fix $multi_meta_files() returning an extra empty array as first value.
* Don't force black color on preview tags list, so default will be used.


Re: foo_discogs

Reply #2392
I wanted to only tag 1 file (11 karma chameleon) and did not deleted -out of lazyness- all the useless tracks from the tracklist.
The fine component was loading all lots of artist infos (left in the tracklist) and so it took very long
Most likely one of your tag formatting strings is using this information. Example, a field starting with RELEASE_ARISTS_. Check the ALBUM ARTIST tag.

When tagging a full release there's no extra cost to using this, but if tagging a single file then yes it will load extra info.
You're right. I didn't found the tag formatting string (because I have too many...) but I defaulted them all (exported all settings first to import again after testing) and the tagging was done very quick w/o downloading additional artists....

So I guess, its up to me to optimize my formatting strings (in the next years....)

Thanks!

Re: foo_discogs

Reply #2393
@zoomorph

I'm having a problem with the text color on the final "Preview Tags" dialog box when fetching tags from Discogs. My Windows theme uses a dark background for the text area (very dark grey), so black text is very hard to see unless I have my face right up close to the screen. The light grey text color for the highlighted tags (DISCOGS_BLAHBLAH_ID) is fine, just the black is problematic. Would it be possible to get it to use the default system text color dynamically rather than fixing it as black the way the dialog boxes prior to "Preview Tags" ("Find Release" and "Match Tracks") do?
Shall fix that for the next release. Thanks.

New release fixes the problem, thanks! Now, if I had only checked and noticed before you fixed it that the "Edit Tag Mappings" dialog box suffers from the same problem...  O:)

Re: foo_discogs

Reply #2394
Hello zoomorph,
when I want to update the tags for a bunch of albums, unfortunately, sometimes an error like this one comes up and stops the whole process.
Quote
(FATAL) Error: Page Deleted or Missing (404) Release 4501368 is deleted.

[ESCAPE to close]
could you enhance the fine component to just *skip* everything, which is not parsable or does not exist, if updating a bunch of albums via the Update Tags dialogue? Error messages are fine, but interrupting is not. Maybe put the errormessages at the end of the dialog, when everything is finally updated?


Re: foo_discogs

Reply #2395
Sorry, any way we can add it to rip setup dialog, so we can pull tags while ripping CD'S?

Re: foo_discogs

Reply #2396
Sorry, any way we can add it to rip setup dialog, so we can pull tags while ripping CD'S?
I don't think, this will ever be possible with this fine component....

But...you can first tag the files from a ripped CD with that freedb component and after that, you can use this fine component, we all love!

Unfortunately, thats not the automated thing you've asked...

Re: foo_discogs

Reply #2397
hi zoomorph,

I got en error:
Quote
(FATAL) Error: Error loading release 2753442: JSON Parser ExceptionError parsing release credits.

[ESCAPE to close]
on this release

Re: foo_discogs

Reply #2398
One obvious error in the credits is "to to".

Re: foo_discogs

Reply #2399
I am a bit new to using arrays and such but does anyone know how to extract parts of the track title and then add it to a new tag? As an example this release - https://www.discogs.com/Armin-van-Buuren-Shivers-Remixes/release/470534 - has the a remix by Christian Weber, and I want to parse the track name and grab only the part between the ( ), in this case "Christian Weber Remix" then add that to a mix tag.

 
SimplePortal 1.0.0 RC1 © 2008-2019