Hydrogenaudio Forums

Hydrogenaudio Forum => Site Related Discussion => Topic started by: polemon on 2018-02-17 02:49:37

Title: Am I the only one seeing these errors in the narrow version?
Post by: polemon on 2018-02-17 02:49:37
As you can see in the attached picture, there seem to be some issues with the narrow version of the site.

The Logo for the forum is next to an empty box. The empty box highlights, the logo doesn't when hovering over it.
Same thing with the scale, it doesn't highlight, but it seems to be next to just a wider white space?
The logo / button for the Wiki is missing entirely.
The icons that don't highlight, are still clickable, though.

Since nobody has seem to have mentioned this, I wonder if I'm the only one seeing these errors.
They Appear in the following Browsers:


I've included Midori, as it is a browser using the Webkit engine, while almost all browsers that used to use Webkit moved on to Blink. I have no access to a modern Microsoft browser like Edge, but in all three aforementioned browsers, the error is basically the same.

Although I doubt it, is it down to my settings? The error appears no matter of the theme, whether it's the lite theme or the regular theme, it's the same sort of error, just with slightly different colors.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Case on 2018-02-17 06:02:03
You're not.
But IMO worse problems are the very limited portal that can't show topic starter or number of posts. Keeping track of new posts requires either memorizing the timestamps for last activity or just rechecking the same topics and posts over and over.
And front page proudly shows "Time Format" instead of a proper timestamp for all posts under the news.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: kode54 on 2018-02-17 10:15:30
The portal settings are hard coded, and obviously, the developer had no idea what he was doing there, because I find myself using the "New Posts" button at the top of the forum to read all topics that have been updated.

As for the Time Format, that's up to your profile settings, which allow you to change the formatting of all forum timestamps to whatever you want.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Case on 2018-02-17 10:26:07
That literal "Time Format" string is shown for anyone who isn't logged in.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Franky666 on 2018-02-17 13:57:41
I think "ouch" and could punch a fist in that empty button everytime I see that. That button bar looks indeed a bit shady. ;D   On my Android device, the buttons are not on the same level and not of one size. The last balance-thingy is much bigger than the left neighbour (and I have no clue, where the last three leads to. I should try them.) ;D

Because I'm a developer, that empty menu button was the first thing I saw after the change from the old green theme to this one. The empty square is caused by a developer who didn't understand the CSS rules there and would be pretty easy to fix. Took one minute to "fix" it using the google developer tool (but it doesn't survive site reloads. ;D )
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: zeremy on 2018-02-17 18:45:38


Because I'm a developer, that empty menu button was the first thing I saw after the change from the old green theme to this one. The empty square is caused by a developer who didn't understand the CSS rules there and would be pretty easy to fix. Took one minute to "fix" it using the google developer tool (but it doesn't survive site reloads. ;D )

You can contribute here.
https://hydrogenaud.io/index.php/topic,115438.msg952186.html#msg952186
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: polemon on 2018-02-17 20:39:52
Hmm, OK. Well, if that's not an important issue, I guess you can disregard my inquiry, then.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Franky666 on 2018-02-17 21:11:04
Quote
You can contribute here.
https://hydrogenaud.io/index.php/topic,115438.msg952186.html#msg952186
Challenge accepted^^.

I set up a fresh copy of ElkArte 1.1.1 and cloned that theme repository to my testing server.

But the default installation of ElkArte 1.1.1 does not have the problematic buttons so it is looking good here. To me, it is pointless to do any improvements on a testing environment that differs from the real thing in an unknown way. :-D

(https://thumb.ibb.co/gBZko7/bla.jpg) (https://ibb.co/gBZko7)

As you see, a nice looking row of menu buttons. Without knowing any configuration or what changes were made to the parts of the community-software that are not part of the repository, it is impossible to me^^. The only thing: profile-button is a bit off-centered. (The gear item is the admin control that is only seen by an administrator)
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: zeremy on 2018-02-17 21:26:30
My point exactly.
Without access to the HA web server it is impossible to know what is going wrong.
I have mentioned the problems is the other thread with no response from the admins.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Franky666 on 2018-02-17 21:28:42
Sorry, I didn't read the complete thread. I just picked the GitHub link from that and read the posting that contained it  :))

You don't need access to the live system. Having a development environment that is exactly equal to the live system would be already enough ;-).
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: kode54 on 2018-02-18 01:17:22
The problematic buttons are configured through the Ultimate Menu addon. Naturally, if you add your own menu buttons, they will have different hashes than the ones I added to our forum.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Franky666 on 2018-02-18 12:00:27
I think it would be easier to me to tell, how it can be fixed:

HTML-related:
1. Dig down to the "li"-element of the broken forum button (it's the one with the id "#forum_button")
2. There is an "a" element in it. In that a element, there is a "i" element.
3. That i elements contains a bad unicode character in the class name. Remove that and add the classname "i-home" instead (needs to be changed once more later). If you can do that in the backend, avoid hard-coding it.
4. Shrink the window and see that it is behaving good now. And that both, desktop and mobile layout, have good looking forum button.

Next, edit the CSS:
1. Remove this ruleset completely:  "#button_forum .linklevel1::before". But attention, it is very likely that it exists multiple times inside media queries. Be sure to remove all of them. This ruleset is, where the developer of the original theme actually didn't understand the system and which disturbs the system, because he tried to recreate the entire button in that on the wrong HTML element.
2. Find the ruleset "i-home" and duplicate it to "i-forumlink" (ensure before, that i-forumlink isn't given already).
3. In that duplicate, change the icon
4. Replace "i-home" in the HTML to "i-forumlink".
5. Reload and check if the problem is gone now.

Repeat all these steps with the ballance-button. That button has basically the same issue, but it doesn't look that bad because it is the last button.



Then the menu bar should behave correct and nice now.  ;)
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: polemon on 2018-02-19 01:45:30
Well, it would be nice if things would be more polished, but I can manage using it as it is.

I'd like other things like Markdown and LaTeX rendering, but if you can't do that - well, it's just not gonna happen.

I thought the thing with the buttons was just an oversight, that I thought I'd point out.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Case on 2018-02-19 06:55:02
Everything should be fixed. My comment was just about prioritizing what to fix first. Narrow view is only visible for mobile users and mobile usability was broken when the mobile version was introduced.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: kode54 on 2018-02-19 09:20:10
True. Hitting microscopic click targets with your finger on a desktop web page is way better.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: zeremy on 2018-02-19 09:24:04
@kode54
Can you delete and recreate the forum button from the Ultimate menu, so it creates a new hash.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: kode54 on 2018-02-19 22:35:10
Which forum button? The foobar2000 forum?
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: zeremy on 2018-02-20 00:11:25
The HA forum button that is displaying the extra box in mobile view.
It is labeled "button_forum" which seems odd to me. It should have the label "button_hash#"  like the other ultimate buttons do.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: kode54 on 2018-02-20 00:50:45
It's not an ultimate button. It's a SimplePortal button, replacing the Community button, whose action it overrides with the portal.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: zeremy on 2018-02-20 05:40:13
Can you locate the code and replace the icon's classname with a valid one?
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: polemon on 2018-02-20 08:56:51
Oh, I can see you guys have added a couple Icons. They are clickable in both versions, the narrow and the regular width. I guess that works for now?

In case you *ever* decide to port this forum to another forum engine, check out NodeBB. I've ported one forum from phpBB to Woltlab Burning board once, it was horrible, and I'd never do it again.

But should you ever want to do it, NodeBB, it's my favorite forum software right now.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: TheQwertiest on 2018-02-20 10:17:39
Oh, nice! The width no longer has a fixed size! Good job =)
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: kode54 on 2018-02-21 01:39:22
What should I change it to, i-forum?

Regarding NodeBB, I think I tried migration of our data to that, and it absolutely choked on the sheer amount of data present in our database.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: zeremy on 2018-02-21 06:35:50
Yes , i-forum will be fine.
I will create a separate entry in icons_svg,css for i-forum since it shares the same icon with i-home.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: Case on 2018-02-21 07:00:04
I took a look at nodeBB powered forums yesterday. It's a perfect example how modern web tech is nothing but nonsense. Browsing the forums is slow but they added a progress bar so users can see that things are still running. Mobile versions seem to have so huge text and spacing that almost no content fits on the screen. Main point seemed to be that a lot of white around everything is modern and good.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: polemon on 2018-02-23 22:24:54
I took a look at nodeBB powered forums yesterday. It's a perfect example how modern web tech is nothing but nonsense. Browsing the forums is slow but they added a progress bar so users can see that things are still running. Mobile versions seem to have so huge text and spacing that almost no content fits on the screen. Main point seemed to be that a lot of white around everything is modern and good.
Not sure I agree. The Opera forum, actually works faster than HA, on my end with a number of posts which is in the same comparative realm.

DailyWTF uses is, and it also feels quite a bit faster than HA, and I don't meen progress bars, I mean actual page loading. DailyWTF Has a pretty large db of posts and topics.

When using NodeBB with my phone, I don't really notice any wasted whitespace as such. The text is about as widely spaced as on HA, the difference is in HA's case, there are more colors and shades of gray used to break things apart, while in NodeBB's case it is more minimal. However, this is surely adjustable with themes. The decision to have large areas of whitespace, is a decision made by the users of the forum software, not necessarily by the forum developer themselves.

Aesthetics aside, I rather like things like the improved editor, the Markdown comprehension, etc.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: kode54 on 2018-02-25 04:06:23
Maybe this forum would "feel" faster if I added fading transitions to every page load/unload event. They don't appear to disclose how much server power they have behind that forum, either. I tried running NodeBB on a VPS with 2 VCPUs and 2GB of RAM, and it was a lot slower with the same data as this forum. It also took several days of unsuccessful migration attempts to even get any of our data into it, and that was from the original Invision board data, which had to be migrated to Invision board 4 before I could migrate it out to NodeBB, because NodeBB will likely never support this particular forum script's data format without me getting down and dirty and writing my own importer from scratch.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: polemon on 2018-02-25 15:09:30
I wouldn't bother changing the forum software, tbh. Only as a last resort, should this become unusable or unserviceable.

As a user, as it is right now, it works - even though the editor isn't all that nice. But the question is, if you want to put up with the problems that every time the forum software rolls out an update or the theme gets updated or obsoleted.
Title: Re: Am I the only one seeing these errors in the narrow version?
Post by: TheQwertiest on 2018-02-26 09:02:08
@kode54 @zeremy
FYI: HA forum icon is still bugged (both in desktop and mobile views), when topic page is open (such as this one).
Also some buttons could use fixes to icon alignment\padding (such as TOS, Wiki and fb2k forums buttons).

Other than that, great job guys!
SimplePortal 1.0.0 RC1 © 2008-2019