Hydrogenaudio Forums

Hydrogenaudio Forum => General Audio => Topic started by: AlexVallat on 09 September, 2007, 04:06:17 AM

Title: Album Art Downloader XUI
Post by: AlexVallat on 09 September, 2007, 04:06:17 AM
(https://hydrogenaud.io/imgcache.php?id=872231c7611265148decb5e922f36f8d" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Splashscreen.gif)
[blockquote]
(https://hydrogenaud.io/imgcache.php?id=732ef6a525570955f73988866a42475c" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/SavePathAndSort.gif) (https://hydrogenaud.io/imgcache.php?id=af77c98b8fab0dcc39542fd3eaeb9989" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Tooltip.gif) (https://hydrogenaud.io/imgcache.php?id=6becc45b3365687184b9984aef7fa8a8" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/DownloadingFullSize.gif)

(https://hydrogenaud.io/imgcache.php?id=5001831032e6c6895ce0c6a635acff0b" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Sources.gif) (https://hydrogenaud.io/imgcache.php?id=5250174601b789d0385b9191f7ae6ce2" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FullArtPanel.gif)

(https://hydrogenaud.io/imgcache.php?id=8fe20a8e6c334130210b6358f86a500a" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FileBrowserClip.gif) (https://hydrogenaud.io/imgcache.php?id=bdbeaf25960b66c4ea48e34987e36062" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Preview.gif)
[/blockquote]
AlbumArtDownloader XUI - You know you want it...

This project is a rewrite of the Album Art Downloader code, using .NET Framework 3.5.

Features:For the graphically-minded out there, although this app isn't skinnable, the UI is all created in XAML, so if you want to grab the source and start editing the UI, please feel free. It is under the XUI folder in the SVN Repository (https://sourceforge.net/svn/?group_id=187008)

Links:
SourceForge project page (http://sourceforge.net/projects/album-art/)
Wiki and reference guide (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Main_Page) (incomplete)
Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)

Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: TheTravis on 09 September, 2007, 05:25:36 AM
First! Finally I got .NET Framework succesfully installed. This program is awesome, thanks!
Title: Album Art Downloader XUI
Post by: Max Spicer on 09 September, 2007, 01:02:24 PM
Does Album Art Downloader XUI only work with mp3s?  I tried pointing the file browser at my collection of flac files and it didn't find any albums.

Thanks,

Max
Title: Album Art Downloader XUI
Post by: AlexVallat on 09 September, 2007, 01:39:44 PM
Does Album Art Downloader XUI only work with mp3s?  I tried pointing the file browser at my collection of flac files and it didn't find any albums.

Thanks,

Max

The file browser uses MediaInfo (http://mediainfo.sourceforge.net/) to read file tags. I don't think it supports album and artist information in flac (in fact I didn't think flac supported those sorts of tag at all), but if you want to request support for reading a file format, that's the project to ask. If the stand-alone MediaInfo app can read the tags, but Album Art Downloader doesn't, then that's a bug of mine - if you give me a sample file I can try and fix it.

Alex
Title: Album Art Downloader XUI
Post by: SmilerSmiles on 09 September, 2007, 03:42:37 PM
Does it handle more than 50 albums at a time yet?
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 September, 2007, 03:36:52 AM
Does it handle more than 50 albums at a time yet?

I've still got the warning to enqueue only 50 searches at a time in there, but it is handling them much better now. I tried enqueueing all 250-odd albums I have and it was only unresponsive for about 4-5 seconds while they were being queued up, and fine after that. Cancel All took another 5 seconds or so. Of course, it will depend on your PC, but I'd suggest giving it another go and seeing if you find it acceptable.

Alex
Title: Album Art Downloader XUI
Post by: fooruncle on 10 September, 2007, 04:47:40 AM
Hi,

I still use the old version on my old notebook for performance reasons. I hadn't used it for some weeks, and yesterday the discogs script failed with the following warning:

Retrieving Art Failed
Capacity must be positive
parameter name: capacity

I thought that the script was outdated, so i copied the discogs-script from the .zip of the XUI-version. It compiled without problems, but I still get the same error message.

Can anyone help me?

Thanks,
frncle
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 September, 2007, 05:47:26 AM
Hi,

I still use the old version on my old notebook for performance reasons. I hadn't used it for some weeks, and yesterday the discogs script failed with the following warning:

Retrieving Art Failed
Capacity must be positive
parameter name: capacity

I thought that the script was outdated, so i copied the discogs-script from the .zip of the XUI-version. It compiled without problems, but I still get the same error message.

Can anyone help me?

Thanks,
frncle

Discogs script seems to be working fine for me. Can you post the artist and album you searched for?

Alex
Title: Album Art Downloader XUI
Post by: fooruncle on 10 September, 2007, 07:34:00 AM
Discogs script seems to be working fine for me. Can you post the artist and album you searched for?

Alex


I tried it with several CDs and records I ripped last week. Some examples are:

Company Flow - End to End Burners
D'Nell - 1st Magic
Peeping Tom - Peeping Tom

The preview pictures do appear, but as soon as I try to preview or save them, I get the error message (or a connection time out in some cases...). Amazon works perfectly...

frncle
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 September, 2007, 09:29:18 AM
The preview pictures do appear, but as soon as I try to preview or save them, I get the error message (or a connection time out in some cases...). Amazon works perfectly...

frncle


I tried the searches you mentioned, and they seem to be working fine for me too. As you say that the results are actually returned, it is just the full size downloads which don't, I suspect that the problem is a bug with the old Album Art Downloader you are using. The discogs script doesn't actually have smaller thumbnails available, it uses the same image for both thumbnail and full size, so if it can show the thumbnail, then it should have the full size one available too.

You could try using the XUI one and seeing if the same problem occurs with that. I'm afraid I'm not going to be investigating or fixing bugs in the old version, though.

Alex
Title: Album Art Downloader XUI
Post by: fooruncle on 10 September, 2007, 02:09:17 PM
You could try using the XUI one and seeing if the same problem occurs with that. I'm afraid I'm not going to be investigating or fixing bugs in the old version, though.


Hmmm, the script definitly worked several weeks before... However, I completely reinstalled the old version and it works now... Whatever happened, I can't explain it. The only possibility I see is that I returned to an old version of the old version when I had to reinstall my pc with an old backup of the system partition last month. I can't verify that now. Thanks for your help! I really love your program!

frncle
Title: Album Art Downloader XUI
Post by: Jojo on 11 September, 2007, 12:43:49 AM
can this be used with iTunes? http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/)
Title: Album Art Downloader XUI
Post by: david_dl on 11 September, 2007, 01:22:40 AM
can this be used with iTunes? http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/)

Hmm, it looks like unencrypted iTMS art is available, wonderful. There's a script included with my original 'CoverDownloader' for iTMS, i'll try and convert it. I don't know if it will still work with the XUI version, i haven't been keeping up with the changes.

Edit: Arggh, this 'josh' guy hasn't provided updated source code (that I can see). But from his description the changes necessary shouldn't be too difficult. Here's the original code if anyone wants to try.

Note: THIS CODE DOESN'T WORK, ONLY USE IT IF YOU INTEND TO FIX IT. Also the script itself's probably not compatible with Alex's modifications, any changes necessary should be slight.

Code: [Select]
# refs: ICSharpCode.SharpZipLib.dll System.Windows.Forms
namespace CoverSources
import System.Xml
import System.Drawing
import util
import ICSharpCode.SharpZipLib

class iTMS:
static def GetPageSecret(url as string):
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
request.UserAgent="iTunes/7.0 (Macintosh; U; PPC Mac OS X 10.4.7)"
request.Headers.Add("X-Apple-Tz","7200")
request.Headers.Add("X-Apple-Store-Front","143457")
request.Headers.Add("Accept-Language","en-us, en;q=0.50")
request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
response = request.GetResponse()
return response.GetResponseStream()
static SourceName as string:
get: return "iTunes Music Store"
static SourceVersion as decimal:
get: return 0.1
static def GetThumbs(coverart,artist,album):
x=System.Xml.XmlDocument()
t=GetPageSecret("http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an="+EncodeUrl(artist)+"&pn="+EncodeUrl(album))
x.Load(ICSharpCode.SharpZipLib.GZip.GZipInputStream(t))
tags=x.GetElementsByTagName("dict")
if tags.Count==0:
return
url=""
albumname=album
for tag in tags[0].ChildNodes:
if tag.InnerText=="cover-art-url":
url=tag.NextSibling.InnerText
if tag.InnerText=="playlistName":
albumname=tag.NextSibling.InnerText
if url.Length>0:
coverart.SetCountEstimate(1)
coverart.AddThumb(GetPageSecret(url),albumname,600,600,null)
static def GetResult(param):
return null
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 September, 2007, 03:16:23 AM
Also the script itself's probably not compatible with Alex's modifications, any changes necessary should be slight.
XUI should be backwards compatible with old scripts. Looking at this one, the only difficulty with it I see is that it needs a reference to ICSharpCode.SharpZipLib.dll, which is not included with Album Art Downloader. If you download (http://www.icsharpcode.net/OpenSource/SharpZipLib/Download.aspx) that dll and stick it (the net-20 version) in your Album Art Downloader XUI folder, it will compile and run just fine.

It won't actually download any art, though, unfortunately. However, trying a few searches on http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/), including his example (http://www.thejosher.net/iTunes/index.php?artist=eisley&album=combinations), shows that he can't download any art either:
Quote
Warning: gzinflate() [function.gzinflate]: data error in /home/josh/public_html/iTunes/index.php on line 122
Oh well.

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 11 September, 2007, 05:12:54 AM
It won't actually download any art, though, unfortunately. However, trying a few searches on http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/), including his example (http://www.thejosher.net/iTunes/index.php?artist=eisley&album=combinations), shows that he can't download any art either:
Quote
Warning: gzinflate() [function.gzinflate]: data error in /home/josh/public_html/iTunes/index.php on line 122
Oh well.

Alex


That's rather odd, his script works fine for me. What country are you in? Is there an iTMS in your country? Maybe that's the problem, we recently got iTMS here in New Zealand. Does this link work for you?  http://a1.phobos.apple.com/r10/Music/32/a3...zi.dbjwyonx.jpg (http://a1.phobos.apple.com/r10/Music/32/a3/53/mzi.dbjwyonx.jpg)
For me it only works in firefox, for some reason. BTW the quality is amazing, better than I've seen from any other source, it's definately not a scan.

Edit: Noticed that the problem you quoted occurred on his webserver, so country shouldn't affect it, still, odd that it's working perfectly here.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 September, 2007, 06:30:01 AM
That's rather odd, his script works fine for me. What country are you in? Is there an iTMS in your country? Maybe that's the problem, we recently got iTMS here in New Zealand. Does this link work for you?  http://a1.phobos.apple.com/r10/Music/32/a3...zi.dbjwyonx.jpg (http://a1.phobos.apple.com/r10/Music/32/a3/53/mzi.dbjwyonx.jpg)
For me it only works in firefox, for some reason. BTW the quality is amazing, better than I've seen from any other source, it's definately not a scan.

Edit: Noticed that the problem you quoted occurred on his webserver, so country shouldn't affect it, still, odd that it's working perfectly here.
Well, his webserver script is up and running again for me, so must have been some sort of temporary glitch. The problem is that the boo script is still downloading the encrypted version. I can't see any source code for what Josh has done at all, but a guess at just removing the .enc.jpg?... bit by adding the line:
Code: [Select]
url = System.Text.RegularExpressions.Regex("\\.enc\\.jpg\\?.*").Replace(url, ".jpg")
seems to do the job:

Code: [Select]
# refs: ICSharpCode.SharpZipLib.dll System.Windows.Forms
namespace CoverSources
import System.Xml
import System.Drawing
import util

class iTMS:
static def GetPageSecret(url as string):
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
request.UserAgent="iTunes/7.0 (Macintosh; U; PPC Mac OS X 10.4.7)"
request.Headers.Add("X-Apple-Tz","7200")
request.Headers.Add("X-Apple-Store-Front","143457")
request.Headers.Add("Accept-Language","en-us, en;q=0.50")
request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
response = request.GetResponse()
return response.GetResponseStream()
static SourceName as string:
get: return "iTunes Music Store"
static SourceVersion as decimal:
get: return 0.2
static def GetThumbs(coverart,artist,album):
x=System.Xml.XmlDocument()
t=GetPageSecret("http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an="+EncodeUrl(artist)+"&pn="+EncodeUrl(album))
x.Load(ICSharpCode.SharpZipLib.GZip.GZipInputStream(t))
tags=x.GetElementsByTagName("dict")
if tags.Count==0:
return
url=""
albumname=album
for tag in tags[0].ChildNodes:
if tag.InnerText=="cover-art-url":
url=tag.NextSibling.InnerText
if tag.InnerText=="playlistName":
albumname=tag.NextSibling.InnerText
if url.Length>0:
url = System.Text.RegularExpressions.Regex("\\.enc\\.jpg\\?.*").Replace(url, ".jpg")
coverart.SetCountEstimate(1)
coverart.AddThumb(url,albumname,-1,-1,null)
static def GetResult(param):
return null
Title: Album Art Downloader XUI
Post by: fooruncle on 11 September, 2007, 07:37:31 AM
Hmmm, using it with the old version (again...), I get the following message in the iTMS column:
Error GZIP header, first magic byte doesn't match...

Too bad...
frncle
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 September, 2007, 08:16:37 AM
Hmmm, using it with the old version (again...), I get the following message in the iTMS column:
Error GZIP header, first magic byte doesn't match...

Too bad...
frncle

Again, you've got to post the thing you're searching for to make any meaningful error report! Some quick testing shows that this error will be reported by the old Album Art Downloader if the album art can't be found on iTMS. If you get a result where searching on Josh's site returns a result, but the boo script doesn't, then I can look into that.

As a more general improvement, the script should probably handle the "no result" case in a more graceful way. Also, worth noting that the script as stands does not do thumbnails, although Josh's site does. Room for improvement here. If I get round to it, I might try writing a new iTMS script based off the information in this script, but until then, this one does mostly work.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 September, 2007, 09:57:20 AM
Turns out, adding thumbnail support only needs a small tweak after all:

Code: [Select]
# refs: ICSharpCode.SharpZipLib.dll
namespace CoverSources
import System.Xml
import System.Drawing
import util

class iTMS:
static def GetPageSecret(url as string):
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
request.UserAgent="iTunes/7.0 (Macintosh; U; PPC Mac OS X 10.4.7)"
request.Headers.Add("X-Apple-Tz","7200")
request.Headers.Add("X-Apple-Store-Front","143457")
request.Headers.Add("Accept-Language","en-us, en;q=0.50")
request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
response = request.GetResponse()
return response.GetResponseStream()
static SourceName as string:
get: return "iTunes Music Store"
static SourceVersion as string:
get: return "0.3"
static SourceCreator as string:
get: return "david_dl, Alex Vallat"
static def GetThumbs(coverart,artist,album):
x=System.Xml.XmlDocument()
t=GetPageSecret("http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an="+EncodeUrl(artist)+"&pn="+EncodeUrl(album))
try:
x.Load(ICSharpCode.SharpZipLib.GZip.GZipInputStream(t))
except e as ICSharpCode.SharpZipLib.GZip.GZipException:
return //Wasn't a zip, so art wasn't found

tags=x.GetElementsByTagName("dict")
if tags.Count==0:
return
url=""
albumname=album
for tag in tags[0].ChildNodes:
if tag.InnerText=="cover-art-url":
url=tag.NextSibling.InnerText
if tag.InnerText=="playlistName":
albumname=tag.NextSibling.InnerText
if url.Length>0:
url = System.Text.RegularExpressions.Regex("\\.enc\\.jpg\\?.*").Replace(url, "")
coverart.SetCountEstimate(1)
coverart.AddThumb(url + ".170x170-75.jpg", albumname, -1, -1, url + ".jpg")
static def GetResult(param):
return param

I'll add this to the XUI installer along with the SharpZipLib dll and bump the version to 0.9.1

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 11 September, 2007, 08:34:35 PM
Thanks, it seems to work for most albums, however if I search artist: Menomena, album: Friend and foe, it saves the thumbnail version, not the full-sized art. The same search works correctly on thejosher.net.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 September, 2007, 03:26:22 AM
Thanks, it seems to work for most albums, however if I search artist: Menomena, album: Friend and foe, it saves the thumbnail version, not the full-sized art. The same search works correctly on thejosher.net.

Strange, thanks for pointing it out. The result returned from http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?... gives a url of http://a1.phobos.apple.com/r40/Music/1d/68/3f/mzi.xoairpuj.enc.jpg.... This seems to have a thumbnail available, but no full size, at least not at http://a1.phobos.apple.com/r40/Music/1d/68/3f/mzi.xoairpuj.jpg.

Josh's site returns a result of http://a1.phobos.apple.com/r10/Music/32/a3/53/mzi.dbjwyonx.enc.jpg... for exactly the same "Menomena / Friend and foe" search. Without being able to see his source code (in particular the original query he uses), I have no idea why he receives a different result.

I suppose we could always use him as a middle-man, and do the searches through his site and grab the images off that, although I'd prefer not to.

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 12 September, 2007, 04:42:13 AM
I suppose we could always use him as a middle-man, and do the searches through his site and grab the images off that, although I'd prefer not to.
Alex


I've emailed him requesting his source code/how he obtains the URL.
Title: Album Art Downloader XUI
Post by: david_dl on 12 September, 2007, 08:19:32 PM
A few changes to the headers sent in the initial request seem to make all the difference:

Code: [Select]
        request.UserAgent="iTunes/7.4 (Macintosh; U; PPC Mac OS X 10.4.7)"
        request.Headers.Add("X-Apple-Tz","-21600")
        request.Headers.Add("X-Apple-Store-Front","143441")
        request.Headers.Add("Accept-Language","en-us, en;q=0.50")
        request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
Title: Album Art Downloader XUI
Post by: phunkydizco on 13 September, 2007, 02:17:15 PM
Performance of the new version is really great. Good work.

What do you think about a context menu item for windows explorer? I organize my library with windows explorer and use the following structure: Artist/(Year) Album. It would be great to start aad with the right parameters by clicking on the album folder.
Title: Album Art Downloader XUI
Post by: masterrossi on 13 September, 2007, 02:25:22 PM
I have the album art in the folders of my albums. How can I search those for artwork with the foobar browser and how can I save them in those folders?
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 September, 2007, 03:11:28 AM
A few changes to the headers sent in the initial request seem to make all the difference:

Yes, that does fix the search you mentioned, and doesn't appear to break others. Here's an updated itunes.boo (http://www.byalexv.co.uk/foobar/itunes.boo) script with them in.

Performance of the new version is really great. Good work.

What do you think about a context menu item for windows explorer? I organize my library with windows explorer and use the following structure: Artist/(Year) Album. It would be great to start aad with the right parameters by clicking on the album folder.

Thanks! It took some doing, but I'm pleased with the results. If I've understood you right, what you want to be able to do is right click on a folder and choose "Browse for Album Art..." or similar, and have AAD launch with the file browser window searching that folder? AAD has a command line parameter you can use for that, /fileBrowser "path". Here's a little .reg file that will add that command line to the context menu for folders for you: AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg)

Of course, if you've installed AAD somewhere other than "C:\Program Files\AlbumArtDownloader", or you want the command called something other than "Browse for Album Art...", then edit the file before merging it.

I have the album art in the folders of my albums. How can I search those for artwork with the foobar browser and how can I save them in those folders?

If you run the foobar browser it will search your foobar library for artist and albums. For each one it finds, it will try to find art for it. By default, it will look for "Folder.jpg" in the same folder as the album. If that's not where you are storing your art, then click the Options link in the Foobar Browser window, and change it to the right filename. The search is done relative to the media file that the artist/album information was read from.

To save art in the album folder from the Foobar Browser, just double click on the album in the Foobar Browser results list, or select several and click "Get Artwork for Selection...". Each art search window launched from the foobar browser will be set to save the art into the place where the Foobar Browser was searching for art for that album. So, if it was looking for Folder.jpg in the album folder, that's where the search window will save it by default when you click the Save button.

I hope this answers your question.
Title: Album Art Downloader XUI
Post by: phunkydizco on 14 September, 2007, 03:49:30 AM
Thanks! It took some doing, but I'm pleased with the results. If I've understood you right, what you want to be able to do is right click on a folder and choose "Browse for Album Art..." or similar, and have AAD launch with the file browser window searching that folder? AAD has a command line parameter you can use for that, /fileBrowser "path". Here's a little .reg file that will add that command line to the context menu for folders for you: AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg)

Of course, if you've installed AAD somewhere other than "C:\Program Files\AlbumArtDownloader", or you want the command called something other than "Browse for Album Art...", then edit the file before merging it.


I don't want to launch AAD with file browser window. I want to launch the album art search with right parameters for artist, album and JPG path. I think this is not possible with a reg file. ADD should extract the parameters from the passed path. The algorithm for the extraction should be configurable. I hope you understand what I mean.
Title: Album Art Downloader XUI
Post by: masterrossi on 14 September, 2007, 04:07:00 AM
To save art in the album folder from the Foobar Browser, just double click on the album in the Foobar Browser results list, or select several and click "Get Artwork for Selection...". Each art search window launched from the foobar browser will be set to save the art into the place where the Foobar Browser was searching for art for that album. So, if it was looking for Folder.jpg in the album folder, that's where the search window will save it by default when you click the Save button.

I hope this answers your question.

A great, now I see how it works.

Great job. Thanks a lot
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 September, 2007, 04:32:04 AM
I don't want to launch AAD with file browser window. I want to launch the album art search with right parameters for artist, album and JPG path. I think this is not possible with a reg file. ADD should extract the parameters from the passed path. The algorithm for the extraction should be configurable. I hope you understand what I mean.

Ah, OK, I misunderstood. AAD will not attempt to extract artist/album information from a filepath. I don't see this changing any time soon. It can read the artist/album information from most media files, though, so if you pass it a media file from the album you want to search for, or a folder containing media files from the album you want to search for, it will read the information from that. This is what the File Browser is for.

I realise that this is one additional step than what you were hoping for, you have to first see the result in the browser, then double click on it to search, rather than going directly to the search window, but I can't think of a good way around that at the moment.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 15 September, 2007, 02:50:57 AM
I just had the following crash:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programmi\AlbumArtDownloader\errorlog.txt

App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ArgumentException: Caratteri non validi nel percorso.
   in System.IO.Path.CheckInvalidPathChars(String path)
   in System.IO.Path.GetFileName(String path)
   in AlbumArtDownloader.AlbumArt.Save()
   in AlbumArtDownloader.ArtSearchWindow.SaveExec(Object sender, ExecutedRoutedEventArgs e)
   in System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   in System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   in System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   in System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   in System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   in System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
   in System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
   in System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   in System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   in System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   in System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   in System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   in System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   in System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
   in MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   in System.Windows.Controls.Button.OnClick()
   in System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
   in System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
   in System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   in System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   in System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   in System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   in System.Windows.UIElement.ReRaiseEventAs(RoutedEventArgs args, RoutedEvent newEvent)
   in System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
   in System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   in System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   in System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   in System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   in System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   in System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   in System.Windows.Input.InputManager.ProcessStagingArea()
   in System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   in System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   in System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   in System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   in System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   in MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   in MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   in System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   in System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   in MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   in MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   in System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   in System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   in System.Windows.Threading.Dispatcher.Run()
   in System.Windows.Application.RunInternal(Window window)
   in System.Windows.Application.Run(Window window)
   in System.Windows.Application.Run()
   in AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   in AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   in AlbumArtDownloader.App.Main(String[] args)
It happened when I clicked on the save icon because, I think, foo_run was not properly configured and I was trying to save with a file name containing a double quote.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 15 September, 2007, 04:06:21 AM
I just had the following crash:

<snip/>

It happened when I clicked on the save icon because, I think, foo_run was not properly configured and I was trying to save with a file name containing a double quote.

Alessandro

Thank you for the report. Yes, it does seem likely that it was caused by a filename with a double quote in it. I will make sure that invalid filenames are handled better for the next version.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 16 September, 2007, 03:18:55 PM
I get error when processing 157 files in queue:

http://cl1p.net/downloadartalbum/ (http://cl1p.net/downloadartalbum/)

Thanks for the error report. Unfortunately it does not give me much of a clue as to what the problem is, only that it occurred when trying to download the full size image for one of the results. Do you recall what the artist/album that was being currently searched for when it crashed was? If you weren't using all sources, then knowing which ones were in use would be helpful too.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 16 September, 2007, 06:26:38 PM
hi, i were looking after artist "Joe Bataan" and a album of him. opened a second search (a new window opens) saved a picture, saved a second picture (not sure in which window, first, or second, both were open) and denied the question if i want to overwrite the existing file and gave the file an other name. after some clicking and checking some pictures i wanted to close the album art downloader XUI with clicking on X and then this came up :-)

 Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: E:\Programme\foobar2000\components\AlbumArtDownloaderXUI\errorlog.txt

Code: [Select]
App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.UnauthorizedAccessException: Der Zugriff auf den Pfad C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config wurde verweigert.
   bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   bei System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
   bei System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
   bei System.Configuration.Internal.WriteFileContext.FileIsWriteLocked(String FileName)
   bei System.Configuration.Internal.WriteFileContext.ReplaceFile(String Source, String Target)
   bei System.Configuration.Internal.WriteFileContext.Complete(String filename, Boolean success)
   bei System.Configuration.Internal.InternalConfigHost.StaticWriteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
   bei System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.W
riteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
   bei System.Configuration.Internal.DelegatingConfigHost.WriteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
   bei System.Configuration.ClientSettingsStore.ClientSettingsConfigurationHost.WriteCompleted(String streamName, Boolean success, Object writeContext)
   bei System.Configuration.UpdateConfigHost.WriteCompleted(String streamName, Boolean success, Object writeContext)
   bei System.Configuration.MgmtConfigurationRecord.SaveAs(String filename, ConfigurationSaveMode saveMode, Boolean forceUpdateAll)
   bei System.Configuration.Configuration.SaveAsImpl(String filename, ConfigurationSaveMode saveMode, Boolean forceSaveAll)
   bei System.Configuration.Configuration.Save()
   bei System.Configuration.ClientSettingsStore.WriteSettings(String sectionName, Boolean isRoaming, IDictionary newSettings)
   bei System.Configuration.LocalFileSettingsProvider.SetPropertyValues(SettingsContext context, SettingsPropertyValueCollection values)
   bei System.Configuration.SettingsBase.SaveCore()
   bei System.Configuration.SettingsBase.Save()
   bei System.Configuration.ApplicationSettingsBase.Save()
   bei AlbumArtDownloader.Properties.WindowSettings.SaveWindowState()
   bei AlbumArtDownloader.Properties.WindowSettings.window_Closing(Object sender, CancelEventArgs e)
   bei System.Windows.Window.OnClosing(CancelEventArgs e)
   bei AlbumArtDownloader.ArtSearchWindow.OnClosing(CancelEventArgs e)
   bei System.Windows.Window.WmClose()
   bei System.Windows.Window.WindowFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: iElectric on 16 September, 2007, 06:54:16 PM
Sorry, I wasn't careful about that info. I will be next time. Cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 17 September, 2007, 03:22:24 AM
hi, i were looking after artist "Joe Bataan" and a album of him. opened a second search (a new window opens) saved a picture, saved a second picture (not sure in which window, first, or second, both were open) and denied the question if i want to overwrite the existing file and gave the file an other name. after some clicking and checking some pictures i wanted to close the album art downloader XUI with clicking on X and then this came up :-)

Hello, thank you for the error report. It occurred because for some reason AAD was denied permission to save to its settings file, at "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config"

Does that error come up every time you close AAD, or did it only happen once? I don't know why it would happen, but what I will do is for the next version make sure that if it can't save its settings, it will just not save them, and not crash.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 17 September, 2007, 02:26:17 PM
hi, another *small* issue :-)

my settings:

"e:\Programme\foobar2000\components\AlbumArtDownloaderXUI\AlbumArt.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%album%.jpg"

will produce this in the log:
[20:20:08] Successful execution of "shell32.dll,ShellExec_RunDLL "e:\Programme\foobar2000\components\AlbumArtDownloaderXUI\AlbumArt.exe" "?" "?" "D:\music\?.jpg""

it a song without any tags.

i know, that what AAD is doing here is right, because the commandline told him to do, but i know too, he cant write such a filename "?.jpg" to the disk, so he shouldnt try ;-) because it gives an error.

suggestion:
better to replace illegal chars
or, if illegal chars found, ask the user to rename it by hand.
Title: Album Art Downloader XUI
Post by: fuffi on 17 September, 2007, 02:46:06 PM
hi, i were looking after artist "Joe Bataan" and a album of him. opened a second search (a new window opens) saved a picture, saved a second picture (not sure in which window, first, or second, both were open) and denied the question if i want to overwrite the existing file and gave the file an other name. after some clicking and checking some pictures i wanted to close the album art downloader XUI with clicking on X and then this came up :-)
Hello, thank you for the error report. It occurred because for some reason AAD was denied permission to save to its settings file, at "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config"

Does that error come up every time you close AAD, or did it only happen once? I don't know why it would happen, but what I will do is for the next version make sure that if it can't save its settings, it will just not save them, and not crash.

it crashes all the time, if i close AAD.

funny, because earlier he does not crash at all.

i could test a scenario to see if he crashes if i close it. he did.
but now, it crashes even, if i start it. strange. (and a pitty, because i cannot use it anymore. maybe rebooting XP will do the trick...)

Code: [Select]
App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Configuration.ConfigurationErrorsException: Das Konfigurationssystem konnte nicht initialisiert werden. ---> System.Configuration.ConfigurationErrorsException: Beim Laden einer Konfigurationsdatei ist ein Fehler aufgetreten.: Der Zugriff auf den Pfad C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config wurde verweigert. (C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config) ---> System.UnauthorizedAccessException: Der Zugriff auf den Pfad C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config wurde verweigert.
   bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   bei System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
   bei System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
   bei System.Configuration.Internal.InternalConfigHost.StaticOpenStreamForRead(String streamName)
   bei System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.O
penStreamForRead(String streamName, Boolean assertPermissions)
   bei System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.O
penStreamForRead(String streamName)
   bei System.Configuration.ClientConfigurationHost.OpenStreamForRead(String streamName)
   bei System.Configuration.BaseConfigurationRecord.InitConfigFromFile()
   --- Ende der internen Ausnahmestapelüberwachung ---
   bei System.Configuration.ConfigurationSchemaErrors.ThrowIfErrors(Boolean ignoreLocal)
   bei System.Configuration.BaseConfigurationRecord.ThrowIfParseErrors(ConfigurationSchemaErrors schemaErrors)
   bei System.Configuration.BaseConfigurationRecord.ThrowIfInitErrors()
   bei System.Configuration.ClientConfigurationSystem.OnConfigRemoved(Object sender, InternalConfigEventArgs e)
   --- Ende der internen Ausnahmestapelüberwachung ---
   bei System.Configuration.ClientConfigurationSystem.OnConfigRemoved(Object sender, InternalConfigEventArgs e)
   bei System.Configuration.Internal.InternalConfigRoot.OnConfigRemoved(InternalConfigEventArgs e)
   bei System.Configuration.Internal.InternalConfigRoot.RemoveConfigImpl(String configPath, BaseConfigurationRecord configRecord)
   bei System.Configuration.BaseConfigurationRecord.Remove()
   bei System.Configuration.BaseConfigurationRecord.GetSectionRecursive(String configKey, Boolean getLkg, Boolean checkPermission, Boolean getRuntimeObject, Boolean requestIsHere, Object& result, Object& resultRuntimeObject)
   bei System.Configuration.BaseConfigurationRecord.GetSection(String configKey, Boolean getLkg, Boolean checkPermission)
   bei System.Configuration.BaseConfigurationRecord.GetSection(String configKey)
   bei System.Configuration.ClientConfigurationSystem.System.Configuration.Internal.IInternalConfigSystem.G
etSection(String sectionName)
   bei System.Configuration.ConfigurationManager.GetSection(String sectionName)
   bei System.Configuration.ClientSettingsStore.ReadSettings(String sectionName, Boolean isUserScoped)
   bei System.Configuration.LocalFileSettingsProvider.GetPropertyValues(SettingsContext context, SettingsPropertyCollection properties)
   bei System.Configuration.SettingsBase.GetPropertiesFromProvider(SettingsProvider provider)
   bei System.Configuration.SettingsBase.GetPropertyValueByName(String propertyName)
   bei System.Configuration.SettingsBase.get_Item(String propertyName)
   bei System.Configuration.ApplicationSettingsBase.GetPropertyValue(String propertyName)
   bei System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
   bei AlbumArtDownloader.Properties.Settings.get_ApplicationVersion()
   bei AlbumArtDownloader.App.UpgradeSettings()
   bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   bei System.Windows.Application.<.ctor>b__0(Object unused)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)


even foobar crashed. (this is failure.txt)

Code: [Select]
Illegal operation:
Code: C0000005h, flags: 00000000h, address: 028E4961h
Access violation, operation: read, address: 00000000h
Call path:
entry=>app_mainloop=>menu_helpers::run_command(), by GUID
This is the first crash logged by this instance.
Code bytes (028E4961h):
028E4921h:  5D C4 8D 45 EC 50 C6 45 FC 01 E8 18 1A 00 00 59
028E4931h:  89 5D F0 39 5E 24 C6 45 FC 03 BF A9 FB 8F 02 76
028E4941h:  05 8B 46 18 EB 02 8B C7 8B 4D EC 8B 11 50 8D 45
028E4951h:  F0 50 FF 52 0C 84 C0 0F 84 5A 01 00 00 8B 4D 08
028E4961h:  8B 01 53 8D 55 F0 52 8D 55 B4 52 53 FF 50 10 84
028E4971h:  C0 0F 84 40 01 00 00 8A 46 28 F6 D8 68 98 D2 8F
028E4981h:  02 8D 4D C8 1B C0 83 E0 06 40 89 45 E8 E8 4D FE
028E4991h:  FF FF 39 5D C4 8B 45 B8 C6 45 FC 04 77 02 8B C7
Stack (0012F5BCh):
0012F59Ch:  00000000 0012F8D8 0012F8B0 00000000
0012F5ACh:  ABFE2DD8 ABFE2AB0 00000000 ABFE2B70
0012F5BCh:  D2CDEAB8 00000000 02924D50 0012F738
0012F5CCh:  00000000 67452301 EFCDAB89 98BADCFE
0012F5DCh:  10325476 028FFBB4 00000000 00000000
0012F5ECh:  00000000 00000000 00000000 028E624A
0012F5FCh:  0012F634 028E6251 D2CDEAB0 00000000
0012F60Ch:  02924D50 0012F738 00000001 004DF5AC
0012F61Ch:  05021FD8 0012F680 028FB5ED 00000003
0012F62Ch:  0012F648 028E6333 00000000 00000006
0012F63Ch:  028FD710 08860658 0012F634 0012F68C
0012F64Ch:  028E6872 00000001 03632FBC D2CDEA18
0012F65Ch:  00000000 02904748 08860658 8148260C
0012F66Ch:  FEDE6332 6F0D9531 0FE5D13B 028FD710
0012F67Ch:  00000006 0012F6DC 028FBD09 00000000
0012F68Ch:  0012F6E8 035CB869 00000000 08860668
0012F69Ch:  0012F738 03632FBC 2FD814CB 00390A84
0012F6ACh:  0367DD38 00000000 005CB2CF 02904748
0012F6BCh:  00000013 00000005 003BA490 75D1DD87
0012F6CCh:  4AAC9E48 25AAA98A BD5AC0D6 035F682B
Registers:
EAX: 00153501, EBX: 00000000, ECX: 00000000, EDX: 00153558
ESI: 029240F0, EDI: 028FFBA9, EBP: 0012F62C, ESP: 0012F5BC
Crash location: "foo_run", loaded at 028E0000h - 0290B000h

Loaded modules:
foobar2000   loaded at 00400000h - 004F3000h
ntdll loaded at 7C910000h - 7C9C7000h
kernel32 loaded at 7C800000h - 7C907000h
COMCTL32 loaded at 773A0000h - 774A3000h
msvcrt   loaded at 77BE0000h - 77C38000h
ADVAPI32 loaded at 77DA0000h - 77E4A000h
RPCRT4   loaded at 77E50000h - 77EE1000h
GDI32 loaded at 77EF0000h - 77F37000h
USER32   loaded at 7E360000h - 7E3F0000h
SHLWAPI   loaded at 77F40000h - 77FB6000h
SHELL32   loaded at 7C9D0000h - 7D1EF000h
ole32 loaded at 774B0000h - 775ED000h
shared   loaded at 10000000h - 10029000h
comdlg32 loaded at 76350000h - 7639A000h
SplashKiller loaded at 003C0000h - 003CC000h
foo_abx   loaded at 009E0000h - 00A13000h
foo_ac3   loaded at 00A30000h - 00A5F000h
foo_adpcm loaded at 00A80000h - 00AD2000h
foo_AdvancedControls loaded at 00B00000h - 00B44000h
foo_albumlist loaded at 00B60000h - 00BA7000h
OLEAUT32 loaded at 770F0000h - 7717B000h
foo_audioscrobbler   loaded at 00BD0000h - 00C07000h
WS2_32   loaded at 71A10000h - 71A27000h
WS2HELP   loaded at 71A00000h - 71A08000h
foo_bitcompare   loaded at 00C30000h - 00C57000h
foo_burninate loaded at 00C80000h - 00CB7000h
VERSION   loaded at 77BD0000h - 77BD8000h
foo_cdda loaded at 00CE0000h - 00D15000h
foo_channel_mixer loaded at 00D40000h - 00D7B000h
foo_common   loaded at 00D90000h - 00DC3000h
foo_converter loaded at 00DF0000h - 00E59000h
foo_convolve loaded at 00E80000h - 00ED1000h
foo_dbsearch loaded at 00F00000h - 00F70000h
foo_discogs   loaded at 00F90000h - 0100E000h
gdiplus   loaded at 4EBA0000h - 4ED43000h
WINMM loaded at 76AF0000h - 76B1E000h
foo_dsp_centercut loaded at 010B0000h - 010D5000h
foo_dsp_crossfader   loaded at 01100000h - 0115F000h
libmmd   loaded at 01170000h - 0141A000h
MSVCR80   loaded at 78130000h - 781CB000h
foo_dsp_silence   loaded at 01440000h - 01469000h
foo_dsp_skip_silence loaded at 01490000h - 014A3000h
foo_dsp_soundtouch   loaded at 014C0000h - 014E3000h
MSVCP80   loaded at 7C420000h - 7C4A7000h
foo_dsp_src9 loaded at 01500000h - 0153B000h
foo_dsp_std   loaded at 01550000h - 01591000h
foo_dsp_vlevel   loaded at 015C0000h - 015E4000h
foo_dsp_vst   loaded at 01610000h - 01632000h
foo_dsp_winamp   loaded at 01660000h - 01683000h
foo_dts   loaded at 016B0000h - 016E7000h
foo_dumb loaded at 01700000h - 01789000h
foo_freedb2   loaded at 017B0000h - 017F1000h
foo_freedb2_fix   loaded at 01820000h - 01835000h
foo_g15lcd   loaded at 01860000h - 01890000h
foo_game loaded at 6C810000h - 6C843000h
foo_gep   loaded at 018C0000h - 0195C000h
MSIMG32   loaded at 76320000h - 76325000h
foo_infobox   loaded at 01980000h - 019C0000h
foo_input_alac   loaded at 019E0000h - 019FD000h
foo_input_awma   loaded at 01A20000h - 01A5D000h
WMVCore   loaded at 15110000h - 1536A000h
WMASF loaded at 11C70000h - 11CA9000h
foo_input_dts loaded at 01A70000h - 01AD5000h
foo_input_matroska   loaded at 01B00000h - 01B88000h
foo_input_monkey loaded at 01BB0000h - 01BFA000h
foo_input_mslive loaded at 01C20000h - 01C97000h
foo_input_reverse loaded at 01CB0000h - 01CDE000h
foo_input_shorten loaded at 01CF0000h - 01D1D000h
foo_input_std loaded at 01D40000h - 01E52000h
foo_input_tak loaded at 01E80000h - 01EC7000h
tak_deco_lib loaded at 01EE0000h - 01F11000h
foo_input_tta loaded at 02040000h - 0206D000h
foo_lirc loaded at 02090000h - 020B8000h
foo_lnk   loaded at 020E0000h - 020F9000h
foo_lock_ex   loaded at 02120000h - 02139000h
foo_lunar2   loaded at 02150000h - 02171000h
foo_lyricsdb loaded at 021A0000h - 021CF000h
WININET   loaded at 77180000h - 77227000h
CRYPT32   loaded at 77A50000h - 77AE5000h
MSASN1   loaded at 77AF0000h - 77B02000h
foo_masstag   loaded at 021F0000h - 02240000h
foo_masstag_addons   loaded at 02260000h - 0227D000h
foo_menu_addons   loaded at 022A0000h - 022F1000h
foo_midi loaded at 02310000h - 023BA000h
foo_navigator loaded at 023E0000h - 02414000h
foo_osd   loaded at 02440000h - 02474000h
foo_out_asio loaded at 024A0000h - 024CF000h
foo_packet_decoder_ac3   loaded at 024F0000h - 02517000h
foo_packet_decoder_wavpack   loaded at 02540000h - 02565000h
foo_playlist_bind loaded at 02590000h - 025B5000h
foo_playlist_manager loaded at 025D0000h - 02614000h
foo_pqview   loaded at 02640000h - 0265B000h
foo_preview   loaded at 02680000h - 026A1000h
foo_psf   loaded at 026C0000h - 027A1000h
foo_random   loaded at 027D0000h - 0280D000h
foo_removeplayed loaded at 02830000h - 02848000h
foo_rgscan   loaded at 02870000h - 028B8000h
foo_run   loaded at 028E0000h - 0290B000h
foo_scheduler loaded at 02930000h - 0299F000h
POWRPROF loaded at 74A50000h - 74A58000h
foo_sendtodevice loaded at 029C0000h - 029FD000h
foo_shutdown loaded at 02A20000h - 02A39000h
foo_sic   loaded at 02A60000h - 02AB9000h
foo_sid   loaded at 02BE0000h - 02C68000h
foo_trackpos loaded at 02C90000h - 02CAF000h
foo_tradersfriend loaded at 02CD0000h - 02D0A000h
foo_uie_albumart loaded at 02D30000h - 02D6C000h
foo_uie_albumlist loaded at 02D90000h - 02DCF000h
foo_uie_bookmarks loaded at 02DF0000h - 02E45000h
foo_uie_console   loaded at 02E60000h - 02E7B000h
foo_uie_lyrics_panel loaded at 02EA0000h - 02F09000h
foo_uie_quicksearch   loaded at 02F30000h - 02F77000h
foo_uie_tabs loaded at 02FA0000h - 02FCA000h
foo_uie_trackinfo_mod loaded at 02FF0000h - 03047000h
foo_uie_vis_projectm loaded at 03060000h - 030AA000h
OPENGL32 loaded at 5F0D0000h - 5F19C000h
GLU32 loaded at 68FC0000h - 68FE0000h
DDRAW loaded at 736D0000h - 73719000h
DCIMAN32 loaded at 73B30000h - 73B36000h
foo_ui_columns   loaded at 035C0000h - 03657000h
foo_ui_std   loaded at 03680000h - 036D7000h
foo_unpack   loaded at 03700000h - 0372E000h
foo_unpack_jma   loaded at 03750000h - 03771000h
foo_unpack_lha   loaded at 037A0000h - 037C0000h
foo_utils loaded at 037E0000h - 03818000h
foo_utils_matroska   loaded at 03840000h - 0385A000h
foo_utils_playback   loaded at 03880000h - 03899000h
foo_verifier loaded at 038C0000h - 038F0000h
foo_version   loaded at 03910000h - 03936000h
dbghelp   loaded at 59DD0000h - 59E71000h
foo_vis_projectM loaded at 03A60000h - 03AD1000h
foo_whatsnew loaded at 03B00000h - 03B30000h
foo_winamp_spam   loaded at 03B50000h - 03B7A000h
sizer loaded at 040A0000h - 040A8000h
uxtheme   loaded at 5B0F0000h - 5B128000h
nvoglnt   loaded at 69500000h - 69A35000h
wtsapi32 loaded at 76F10000h - 76F18000h
WINSTA   loaded at 76300000h - 76310000h
NETAPI32 loaded at 597D0000h - 59824000h
mswsock   loaded at 719B0000h - 719F0000h
DNSAPI   loaded at 76EE0000h - 76F07000h
LgLcdApi loaded at 089B0000h - 089C5000h
dsp_audiostocker loaded at 08B20000h - 08BE7000h
DSOUND   loaded at 73E70000h - 73ECC000h
WINTRUST loaded at 76BF0000h - 76C1E000h
IMAGEHLP loaded at 76C50000h - 76C78000h
wdmaud   loaded at 72C90000h - 72C99000h
msacm32   loaded at 72C80000h - 72C88000h
MSACM32   loaded at 77BB0000h - 77BC5000h
midimap   loaded at 77BA0000h - 77BA7000h
KsUser   loaded at 73E40000h - 73E44000h
rasadhlp loaded at 76F80000h - 76F86000h
hnetcfg   loaded at 66710000h - 66769000h
wshtcpip loaded at 719F0000h - 719F8000h
appHelp   loaded at 77B10000h - 77B32000h
CLBCATQ   loaded at 76F90000h - 7700F000h
COMRes   loaded at 77010000h - 770E3000h
shdocvw   loaded at 77730000h - 7789F000h
CRYPTUI   loaded at 76880000h - 76905000h
WLDAP32   loaded at 76F20000h - 76F4D000h
urlmon   loaded at 77230000h - 772CD000h
Secur32   loaded at 77FC0000h - 77FD1000h
SETUPAPI loaded at 778F0000h - 779E4000h
browseui loaded at 75F20000h - 7601C000h

Stack dump analysis:
Address: 028FFBB4h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E624Ah, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E6251h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 004DF5ACh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 028FB5EDh, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E6333h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028FD710h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E6872h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 02904748h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028FD710h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028FBD09h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 035CB869h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 02904748h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 035F682Bh, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 03622911h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035CB8B3h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035FC046h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E368B26h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowThreadProcessId" (+000000A6h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 03627AA4h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E3688DAh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongW" (+00000034h)
Address: 004DEE08h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 03621770h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035C6828h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E36B50Ch, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+000001D0h)
Address: 7E36B51Ch, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+000001E0h)
Address: 7E368734h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000006Dh)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E368816h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000014Fh)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E368830h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+00000169h)
Address: 7E36B4C0h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+00000184h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E36B4D0h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+00000194h)
Address: 7E36B50Ch, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+000001D0h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7C91EAE3h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "KiUserCallbackDispatcher" (+00000013h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E36B473h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+00000137h)
Address: 7E3694BEh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongA" (+00000061h)
Address: 7E36D4E4h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "SetPropW" (+000000BBh)
Address: 7E36B933h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "IsWindow" (+00000000h)
Address: 7E36B903h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "SendMessageW" (+00000049h)
Address: 7741489Ah, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "Ordinal384" (+000589FAh)
Address: 7741570Bh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000B67h)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E36F95Bh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "CallNextHookEx" (+00000100h)
Address: 7C91EAE3h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "KiUserCallbackDispatcher" (+00000013h)
Address: 040A175Ch, location: "sizer", loaded at 040A0000h - 040A8000h
Symbol: "ReleaseResizeInfo" (+000003D3h)
Address: 7E38E175h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "User32InitializeImmEntryTable" (+00000E18h)
Address: 7E38E152h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "User32InitializeImmEntryTable" (+00000DF5h)
Address: 7E368734h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000006Dh)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E368816h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000014Fh)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E368830h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+00000169h)
Address: 7E3689CDh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongW" (+00000127h)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E36DAEAh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DestroyWindow" (+00000000h)
Address: 7E37D950h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "IsDialogMessageW" (+0000008Eh)
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E3689F0h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongW" (+0000014Ah)
Address: 7E368A10h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DispatchMessageW" (+0000000Fh)
Address: 0042FF5Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 10002DD2h, location: "shared", loaded at 10000000h - 10029000h
Symbol: "uCallStackTracker::uCallStackTracker" (+00000032h)
Address: 004C04F8h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00430AA3h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C07B4h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C920732h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7634h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C920732h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 7C920732h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 7C921538h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "wcsncpy" (+00000AA9h)
Address: 7C921596h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "wcsncpy" (+00000B07h)
Address: 7C9206EBh, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+00000117h)
Address: 004E41B8h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C92056Dh, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlFreeHeap" (+00000130h)
Address: 1000C021h, location: "shared", loaded at 10000000h - 10029000h
Address: 7C91EE18h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "strchr" (+00000117h)
Address: 7C9206F0h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000011Ch)
Address: 7C91EE18h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "strchr" (+00000117h)
Address: 7C9206F0h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000011Ch)
Address: 7C9206EBh, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+00000117h)
Address: 00492BFDh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E4238h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00447B71h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0045CE23h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0044E9CAh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004970A3h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 10002D87h, location: "shared", loaded at 10000000h - 10029000h
Symbol: "uPrintCrashInfo_SetDumpPath" (+000000A7h)
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004AF584h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00430CAAh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E09B0h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0049712Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00492502h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004924FCh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004B49E0h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004B3450h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E4230h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00497440h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004AF978h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00496804h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0120DC08h, location: "libmmd", loaded at 01170000h - 0141A000h
Symbol: "_csqrtq_f90" (+0009B2CCh)
Address: 0120DC08h, location: "libmmd", loaded at 01170000h - 0141A000h
Symbol: "_csqrtq_f90" (+0009B2CCh)
Address: 00497440h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C816FD7h, location: "kernel32", loaded at 7C800000h - 7C907000h
Symbol: "RegisterWaitForInputIdle" (+00000049h)
Address: 0120DC08h, location: "libmmd", loaded at 01170000h - 0141A000h
Symbol: "_csqrtq_f90" (+0009B2CCh)
Address: 7C839AA8h, location: "kernel32", loaded at 7C800000h - 7C907000h
Symbol: "ValidateLocale" (+000002B0h)
Address: 7C816FE0h, location: "kernel32", loaded at 7C800000h - 7C907000h
Symbol: "RegisterWaitForInputIdle" (+00000052h)
Address: 0049686Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E0049h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004F0044h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 01C61B6Ch, location: "foo_input_mslive", loaded at 01C20000h - 01C97000h
Address: 004B0063h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 01C61B6Ch, location: "foo_input_mslive", loaded at 01C20000h - 01C97000h
Address: 00410072h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E0049h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004F0044h, location: "foobar2000", loaded at 00400000h - 004F3000h

Version info:
foobar2000 v0.9.4.4
UNICODE

Additional info:
Logitech G15 LCD Display 0.3a  (foo_g15lcd)
VLevel 20060324.0  (foo_dsp_vlevel)
Winamp API Emulator 0.95  (foo_winamp_spam)
Components versions viewer 0.3  (foo_version)
Album Art Panel 0.2.6  (foo_uie_albumart)
GCN DSP decoder 1.3  (foo_adpcm)
Acro WMA decoder 0.1.6.5 (Intel SSE)  (foo_input_awma)
Matroska Plugin 0.9.2.1  (foo_input_matroska)
Quick Search Toolbar 2.8j  (foo_uie_quicksearch)
Track info panel mod 0.8.0 beta [Dec  6 2006 - 14:21:24]  (foo_uie_trackinfo_mod)
foosic music database 1.0 beta 12  (foo_sic)
Lunar 2 PCM decoder 0.5  (foo_lunar2)
Default User Interface 0.9acc  (foo_ui_std)
sidplay2 1.13  (foo_sid)
WMA Decoder 1.1  (foo_input_std)
Audio CD Writer 2.0.1  (foo_burninate)
Console panel 0.2.1  (foo_uie_console)
Playlist Manager 1.0.2  (foo_playlist_manager)
OKI-ADPCM decoder 0.14  (foo_adpcm)
Highly Experimental 2.0.6  (foo_psf)
MIDI synthesizer host 1.7  (foo_midi)
ADX decoder 1.6  (foo_adpcm)
Resampler (Secret Rabbit Code) 1.03  (foo_dsp_src9)
Gapless Crossfader 0.3.3.1 (Intel SSE)  (foo_dsp_crossfader)
Standard Input Array 1.0  (foo_input_std)
Matroska Utility Plugin 1.0.2  (foo_utils_matroska)
FLAC Decoder 1.1.0  (foo_input_std)
Tabbed panel modified 0.2.6  (foo_uie_tabs)
Audioscrobbler 1.3.6  (foo_audioscrobbler)
ASIO support 1.2.5  (foo_out_asio)
SoundTouch DSP 0.1 (Intel SSE)  (foo_dsp_soundtouch)
BRR decoder and converter 0.7  (foo_adpcm)
Remove played Files 1.4.0  (foo_removeplayed)
Send to Device 1.1.1 [Sep  7 2007 - 10:34:03]  (foo_sendtodevice)
TTA Audio Decoder (unofficial) 2.4.2  (foo_input_tta)
Shell Link Resolver 1.2  (foo_lnk)
Bookmarks 0.2.5.2  (foo_uie_bookmarks)
Winamp DSP Bridge 1.4.1  (foo_dsp_winamp)
Masstagger Addons 0.3.4 (Intel SSE)  (foo_masstag_addons)
AC3 decoder 0.9  (foo_ac3)
Common services 0.1  (foo_common)
Columns UI 0.1.3 beta 1v6 TEST  (foo_ui_columns)
Database Search 1.4  (foo_dbsearch)
Navigator 0.63  (foo_navigator)
projectM visualization 1.97.6.2  (foo_vis_projectM)
CD Audio Decoder 2.1.1  (foo_cdda)
Channel Mixer 0.9.6.2  (foo_channel_mixer)
Playlist Bind 3.2  (foo_playlist_bind)
Game Emu Player 1.5  (foo_gep)
Menu Addons 0.3.9.5 (Intel SSE)  (foo_menu_addons)
Scheduler 3.53  (foo_scheduler)
Shorten decoder 0.4.2.1  (foo_input_shorten)
ATSC A/52 (AC3) Packet Decoder 0.9  (foo_packet_decoder_ac3)
Preview 1.2  (foo_preview)
Run services 0.3.2  (foo_run)
Album List 3.2.0  (foo_albumlist)
ALAC Decoder 1.0  (foo_input_alac)
DUMB module decoder 0.9.8.4  (foo_dumb)
Binary Comparator 1.1  (foo_bitcompare)
JMA unpacker 1.0  (foo_unpack_jma)
projectM visualization (Panel) 0.4  (foo_uie_vis_projectm)
freedb Tagger 0.5.2.1  (foo_freedb2)
Feature Watcher 1.0.2  (foo_whatsnew)
ZIP/GZIP reader 1.0  (foo_unpack)
Randomized Playlist Entry 1.2.3  (foo_random)
Skip silence 0.1 (Intel SSE)  (foo_dsp_skip_silence)
WavPack Packet Decoder 0.9.1  (foo_packet_decoder_wavpack)
DTS decoder 0.1.7  (foo_input_dts)
File Integrity Verifier 1.0.1  (foo_verifier)
Center Cut 1.0.1  (foo_dsp_centercut)
Reverse Playback 0.1.3 (Intel SSE)  (foo_input_reverse)
RAR reader 1.1  (foo_unpack)
Freedb2 characters fixer (masstagger addon) 0.02  (foo_freedb2_fix)
mslive 0.3.9 (Intel SSE)  (foo_input_mslive)
ABX Comparator 1.3.1  (foo_abx)
Standard DSP array 1.0  (foo_dsp_std)
DTS decoder 0.1.1  (foo_dts)
Converter 1.0.1  (foo_converter)
Pause on Lock (extended) 1.0  (foo_lock_ex)
TAK Decoder 0.3.2  (foo_input_tak)
Convolver 0.3  (foo_convolve)
Game Audio Decoder 1.08  (foo_game)
On-Screen Display GDI+ 1.52  (foo_osd)
Masstagger 1.6  (foo_masstag)
Live Show Tagger 0.6.1  (foo_tradersfriend)
Interplay ACM decoder 1.0  (foo_adpcm)
XA ADPCM decoder 1.2  (foo_adpcm)
Foo Shutdown 0.9.3  (foo_shutdown)
RAC decoder 1.0  (foo_adpcm)
VST bridge 0.60 Beta  (foo_dsp_vst)
Title: Album Art Downloader XUI
Post by: AlexVallat on 17 September, 2007, 03:46:31 PM
cant write such a filename "?.jpg" to the disk, so he shouldnt try ;-) because it gives an error.

This "Illegal Characters in Filename" crash is already fixed for the next version, as mobyduck [a href="index.php?act=findpost&pid=516671"][{POST_SNAPBACK}][/a] reported it.

For your settings bug, please try deleting the folder "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader" and running Album Art Downloader again. That will reset all your settings for it, but it should run again. If you used the Installer, then uninstalling and re-installing will do this automatically.

Also, could I suggest you wrap long crash reports in codebox tags in your posts, so that they don't take up so much space? It makes the thread easier to read for everyone.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 17 September, 2007, 05:29:22 PM
hi,
an addition to my/your last post:
i use foobar2000 on my portable usb stick to play some songs i like, if i'm not on my home computer.
now i see, that AAD will save data on every computer i visited and play songs (and download some covers)

do you mind to save data in the AAD-programs folder? (relative path, without a fixed harddrive-letter)?
Title: Album Art Downloader XUI
Post by: fuffi on 17 September, 2007, 05:43:36 PM
For your settings bug, please try deleting the folder "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader" and running Album Art Downloader again. That will reset all your settings for it, but it should run again. If you used the Installer, then uninstalling and re-installing will do this automatically.
i deleted the folder and AAD did not crash again. thank you.
Title: Album Art Downloader XUI
Post by: Jojo on 17 September, 2007, 10:07:16 PM
Hmm, it looks like unencrypted iTMS art is available, wonderful. There's a script included with my original 'CoverDownloader' for iTMS, i'll try and convert it. I don't know if it will still work with the XUI version, i haven't been keeping up with the changes.

I'm losing track of all the topics here, can you post once you got it to work. thank you
Title: Album Art Downloader XUI
Post by: fuffi on 17 September, 2007, 11:02:56 PM
hi,
you could add an icon file (AlbumArt.ico/bmp/png) to your provided zip-file/installation, because users who want to assign AAD to a button/icon, cannot use the .exe file for the implemented icon in AlbumArt.exe
so i had to extract the icon manually and convert it to a png, which is a lot or work :-) and assigned it to a button which i can now press instead of using the context-menu
cheers,
Title: Album Art Downloader XUI
Post by: fuffi on 17 September, 2007, 11:27:30 PM
ok, it crashed again. did not done alot with AAD meanwhile.
changed the sorting from default-direction to reverse direction. and then sorted by size. while AAD was loading covers. saved a cover. closed AAD. crash.
i'm wainting now till the new version :-) no errorreport necsessary, i think.

Code: [Select]
App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Ein Aufrufziel hat einen Ausnahmefehler verursacht. ---> System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei AlbumArtDownloader.AlbumArt.<>c__DisplayClass1.<RetrieveFullSizeImageWorker>b__0()
   --- Ende der internen Ausnahmestapelüberwachung ---
   bei System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   bei System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   bei System.Delegate.DynamicInvokeImpl(Object[] args)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: david_dl on 18 September, 2007, 02:41:09 AM

Hmm, it looks like unencrypted iTMS art is available, wonderful. There's a script included with my original 'CoverDownloader' for iTMS, i'll try and convert it. I don't know if it will still work with the XUI version, i haven't been keeping up with the changes.

I'm losing track of all the topics here, can you post once you got it to work. thank you


It's already included in the latest release which you can download in the first post in this thread.


hi,
an addition to my/your last post:
i use foobar2000 on my portable usb stick to play some songs i like, if i'm not on my home computer.
now i see, that AAD will save data on every computer i visited and play songs (and download some covers)

do you mind to save data in the AAD-programs folder? (relative path, without a fixed harddrive-letter)?


Probably not a good idea in general because of Vista and limited account compatibilty. If I'm not mistaken it allows the .net framework to choose the best place to store the config. However if you want to take your settings with you on your usb stick, you could try creating a file called AlbumArt.exe.config and copying the user.config file mentioned above into this file. I don't think the program will create a user.config file on other machines if the user doesn't change any settings, however I haven't looked at the internals of the XUI version, so you'll have to test it for yourself.
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 September, 2007, 03:36:27 AM
do you mind to save data in the AAD-programs folder? (relative path, without a fixed harddrive-letter)?

Probably not a good idea in general because of Vista and limited account compatibilty. If I'm not mistaken it allows the .net framework to choose the best place to store the config. However if you want to take your settings with you on your usb stick, you could try creating a file called AlbumArt.exe.config and copying the user.config file mentioned above into this file. I don't think the program will create a user.config file on other machines if the user doesn't change any settings, however I haven't looked at the internals of the XUI version, so you'll have to test it for yourself.
david_dl is correct in that you can copy your user.config file to AlbumArt.exe.config to have local settings. I think, technically, if no settings were changed then no user.config would be created, but in practice the settings include window sizes and positions, so are almost certain to change.

I won't be changing AAD to store its settings in its own folder, as david_dl points out, this breaks Vista compatibility, and is generally not recommended anyway. What I could do, if it were helpful, would be to add some command line parameter that would cause AAD to ensure it does not save any settings.

you could add an icon file (AlbumArt.ico/bmp/png) to your provided zip-file/installation
Sure, no problem, I'll stick the .ico in there. You say you already extracted one now, though, so I won't send it to you now.

ok, it crashed again. did not done alot with AAD meanwhile.
This is the same bug as iElectric [a href="index.php?act=findpost&pid=516956"][{POST_SNAPBACK}][/a] reported - something is going wrong when trying to download a full size image. I still haven't been able to figure out what, and without knowing which artist/album result it was trying to download, I'm not sure how I can test it.

Alex
Title: Album Art Downloader XUI
Post by: Blueinferno on 18 September, 2007, 10:38:56 AM
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.
Title: Album Art Downloader XUI
Post by: kockroach on 18 September, 2007, 10:43:13 AM
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.

The options section should allow you to set a minimum, or even maximum, size.
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 September, 2007, 10:45:52 AM
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.

Thanks, glad you liked it! To show images of only 500x500, click the Options link (just below the Album search box), and in the Filter by Image Size area, check both Maximum and Minimum and enter a value of 500 for each. Or, to allow values that are close to, but not exactly 500, use 495 for minimum and 505 for maximum, for example. For non-square images, it is the smaller dimension that must match the criteria specified here.

Hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: Blueinferno on 18 September, 2007, 05:48:57 PM
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.

Thanks, glad you liked it! To show images of only 500x500, click the Options link (just below the Album search box), and in the Filter by Image Size area, check both Maximum and Minimum and enter a value of 500 for each. Or, to allow values that are close to, but not exactly 500, use 495 for minimum and 505 for maximum, for example. For non-square images, it is the smaller dimension that must match the criteria specified here.

Hope this helps,

Alex

Many thanks, for both the help, and a quick answer.
Title: Album Art Downloader XUI
Post by: fuffi on 18 September, 2007, 05:57:31 PM
Quote
david_dl is correct in that you can copy your user.config file to AlbumArt.exe.config to have local settings


thank you both, portability of programs will be the most important thing in the next years. a long time ago (before win95, hehe) there were no problems with storing program settings in program folder. now, as you both say, vista doesnt like it, i'm very amused. :-) i'm still using XP
anyway. AAD isnt not a very important application for me (although i dont wanna miss it, so dont get me wrong!!) so it it stores security-based information on computers which i dont own, its my fault anyway. now, that i know it, it is no problem. thank you again, your program is a really help!
Title: Album Art Downloader XUI
Post by: david_dl on 19 September, 2007, 01:49:42 AM
Here is an updated version of the iTMS script that can get fullsized art for even more albums. However sometimes the fullsized art will be large, and in TIFF format. I don't know if it's possible to report the filetype from the GetResult function (as it cannot be determined before GetResult is called), so you may end up with AlbumArtDownloader saving a TIFF as .jpg. The resultant file still works in foobar and windows picture gallery though, at least on vista.
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 September, 2007, 02:57:00 AM
you may end up with AlbumArtDownloader saving a TIFF as .jpg.

If you have this problem, make sure that the filename pattern to save as doesn't end in .jpg, but ends in .%extension% instead. That way AlbumArtDownloader will determine the extension automatically from the image format, and correctly use .tif instead of .jpg.

Just one question, David, is there any reason you've chosen to use the older headers again, rather than the ones you suggested in your post [a href='index.php?act=findpost&pid=516175']here[/a]?

Also, could you give an example of a search that returns a tiff, for testing?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 19 September, 2007, 03:34:39 AM
you may end up with AlbumArtDownloader saving a TIFF as .jpg.

Just one question, David, is there any reason you've chosen to use the older headers again, rather than the ones you suggested in your post [a href='index.php?act=findpost&pid=516175']here[/a]?

No, sorry, I thought I had modified the latest version, my mistake.
Quote
Also, could you give an example of a search that returns a tiff, for testing?

Menomena - I am the Fun Blame Monster
Title: Album Art Downloader XUI
Post by: Mercachifle on 19 September, 2007, 06:59:28 PM
I can't load the program. It crashes on start:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Archivos de programa\AlbumArtDownloader\errorlog.txt

App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Windows.Markup.XamlParseException: No se puede convertir la cadena 'AlbumArtDownloader.ico' del atributo 'Icon' en un objeto de tipo 'System.Windows.Media.ImageSource'. No se encontró ningún componente de procesamiento de imágenes apto para completar esta operación.  Error en el objeto 'AlbumArtDownloader.Splashscreen' en el archivo de marcado 'AlbumArt;component/splashscreen.xaml'. ---> System.NotSupportedException: No se encontró ningún componente de procesamiento de imágenes apto para completar esta operación. ---> System.Runtime.InteropServices.COMException (0x88982F50): Excepción de HRESULT: 0x88982F50
   --- Fin del seguimiento de la pila de la excepción interna ---
   en MS.Internal.HRESULT.Check(Int32 hr)
   en System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
   en System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, Boolean insertInDecoderCache)
   en System.Windows.Media.Imaging.BitmapFrame.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption)
   en System.Windows.Media.ImageSourceConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
   en System.ComponentModel.TypeConverter.ConvertFromString(ITypeDescriptorContext context, CultureInfo culture, String text)
   en System.Windows.Markup.XamlTypeMapper.ParseProperty(Object targetObject, Type propType, String propName, Object dpOrPiOrFi, ITypeDescriptorContext typeContext, ParserContext parserContext, String value, Int16 converterTypeId)
   --- Fin del seguimiento de la pila de la excepción interna ---
   en System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
   en System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
   en System.Windows.Markup.XamlTypeMapper.ParseProperty(Object targetObject, Type propType, String propName, Object dpOrPiOrFi, ITypeDescriptorContext typeContext, ParserContext parserContext, String value, Int16 converterTypeId)
   en System.Windows.Markup.BamlRecordReader.ParseProperty(Object element, Type propertyType, String propertyName, Object dpOrPi, String attribValue, Int16 converterTypeId)
   en System.Windows.Markup.BamlRecordReader.ReadPropertyRecordBase(String attribValue, Int16 attributeId, Int16 converterTypeId)
   en System.Windows.Markup.BamlRecordReader.ReadPropertyConverterRecord(BamlPropertyWithConverterRecord bamlPropertyRecord)
   en System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   en System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   en System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
   en System.Windows.Markup.TreeBuilder.Parse()
   en System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
   en System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
   en AlbumArtDownloader.Splashscreen.InitializeComponent()
   en AlbumArtDownloader.Splashscreen..ctor()
   en AlbumArtDownloader.Splashscreen.ShowIfRequired()
   en AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   en System.Windows.Application.<.ctor>b__0(Object unused)
   en System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   en System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   en System.Windows.Threading.DispatcherOperation.InvokeImpl()
   en System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   en System.Threading.ExecutionContext.runTryCode(Object userData)
   en System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   en System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   en System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   en System.Windows.Threading.DispatcherOperation.Invoke()
   en System.Windows.Threading.Dispatcher.ProcessQueue()
   en System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   en MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   en MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   en System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   en System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   en System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   en System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   en MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   en MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   en System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   en System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   en System.Windows.Threading.Dispatcher.Run()
   en System.Windows.Application.RunInternal(Window window)
   en System.Windows.Application.Run(Window window)
   en System.Windows.Application.Run()
   en AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   en AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   en AlbumArtDownloader.App.Main(String[] args)


What is the problem?
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 September, 2007, 03:02:01 AM
I can't load the program. It crashes on start:

What is the problem?


I'm sorry, I haven't a clue. The error report is saying that it can't display the program icon, which it needs to do in order to show a window, in this case the splash screen window, as that is the first to be shown.

As to why it can't display the program icon, I have no idea. You could try making sure you have the latest .net framework installed, but other than that, I have nothing to suggest, sorry.

Alex
Title: Album Art Downloader XUI
Post by: Jojo on 20 September, 2007, 03:15:55 PM
ok, I'm trying to figure this out. Is it possible to search for album art based on ID3 tags? If so, how would I do that? In addition, I don't like adding Album names for my Singles (I just leave it blank). Therefore, iTunes can't find the album art for the songs, since it only searches for "Artist - Album". It would be nice if I could use the title of a song as the Album title to solve this problem.

thank you
Title: Album Art Downloader XUI
Post by: entrecour on 20 September, 2007, 04:14:14 PM
Does Album Art Downloader XUI only work with mp3s?  I tried pointing the file browser at my collection of flac files and it didn't find any albums.
Thanks,
Max

The file browser uses MediaInfo (http://mediainfo.sourceforge.net/) to read file tags. I don't think it supports album and artist information in flac (in fact I didn't think flac supported those sorts of tag at all), but if you want to request support for reading a file format, that's the project to ask. If the stand-alone MediaInfo app can read the tags, but Album Art Downloader doesn't, then that's a bug of mine - if you give me a sample file I can try and fix it.

Alex,

I haven't seen any further posts on this but I am also interested in the same issue.

I also encountered problems with flac and Album Art Downloader - it downloaded album art for 5 of my albums out of 100+. I can see no difference in the file information in MediaInfo for those particular 5 albums compared to the others. I am very keen to get a fix for this - what info or files can I send you to help you?

Thanks, David.
Title: Album Art Downloader XUI
Post by: mobyduck on 21 September, 2007, 03:03:34 AM
Is it possible to search for album art based on ID3 tags? If so, how would I do that?
If I understand correctly what you're asking, you can do that using foobar + foo_run (http://foosion.foobar2000.org/0.9/foo_runcmd-1.0_beta_2-20070125.zip).

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 September, 2007, 03:20:17 AM
ok, I'm trying to figure this out. Is it possible to search for album art based on ID3 tags? If so, how would I do that? In addition, I don't like adding Album names for my Singles (I just leave it blank). Therefore, iTunes can't find the album art for the songs, since it only searches for "Artist - Album". It would be nice if I could use the title of a song as the Album title to solve this problem.

If you mean from within foobar, then as mobyduck points out, foo_run is used for this, and you can pass whatever info you like to the Artist and Album command line args. If you mean within Album Art Downloader itself, then to search for album art based on ID3 tags, you use the File Browser. This can be pointed at a folder to scan, or you can just drag and drop files on to it.

It will not read the track title though, just Artist and Album. As you point out, some sources won't search for just an artist without an album. The way I see it, the Album is the CD that the track is on, even if there is only one track on that CD, and it is the Album that has art, not the track.

I also encountered problems with flac and Album Art Downloader - it downloaded album art for 5 of my albums out of 100+. I can see no difference in the file information in MediaInfo for those particular 5 albums compared to the others. I am very keen to get a fix for this - what info or files can I send you to help you?

If you have a file that, in MediaInfo, displays "Album" and "Performer" correctly, but in Album Art Downloader File Browser does not show the correct Album and Artist values in the columns, or does not appear in the file browser at all (please verify by dragging and dropping that particular file on to it), then it would be very helpful if you were able to send me that file.

You could try just sending me the text report from MediaInfo, but all that would let me do is verify that Album and Performer are correctly reported there, something I'm sure you're able to do just as well yourself!
Title: Album Art Downloader XUI
Post by: entrecour on 21 September, 2007, 08:43:42 AM
I have sent you a PM with text output. Let me know how I should send the file to you.

Thanks, David.
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 21 September, 2007, 07:40:54 PM
Thanks david_dl and AlexVallat for providing base code for fetching iTMS artwork.  GREAT Work.

I noticed that the GetResponse method can take up to 100 seconds if an album art is found. So I added

Code: [Select]
        request.Timeout = TIME_OUT ' where TIME_OUT  = 5000 milliseconds by default


Any objections to that you think?

Code: [Select]
      Dim request As HttpWebRequest = CType(HttpWebRequest.Create(url), HttpWebRequest)
        request.UserAgent = "iTunes/7.4 (Macintosh; U; PPC Mac OS X 10.4.7)"
        request.Headers.Add("X-Apple-Tz", "-21600")
        request.Headers.Add("X-Apple-Store-Front", "143441")
        request.Headers.Add("Accept-Language", "en-us, en;q=0.50")
        request.Headers.Add("Accept-Encoding", "gzip, x-aes-cbc")
        Dim response As WebResponse = request.GetResponse
        request.Timeout = 5000
        Return response.GetResponseStream
Title: Album Art Downloader XUI
Post by: pirlouy on 22 September, 2007, 10:56:46 AM
Hello Alex,

AlbumArtDownloader XUI has well progressed since first versions. Even if it does time, I've just wanted to say I don't have freeze anymore when I click on thumbnails ! Thanks.

Else I don't know if it's scripts or software, but it uses a huge number of RAM (I can easily be at 400Mo).
Title: Album Art Downloader XUI
Post by: AlexVallat on 22 September, 2007, 12:52:48 PM
I noticed that the GetResponse method can take up to 100 seconds if an album art is found. So I added
Code: [Select]
        request.Timeout = TIME_OUT ' where TIME_OUT  = 5000 milliseconds by default

Any objections to that you think?

5 seconds seems a bit short to me, I've had art come back slower than that. As long as the cancel button works, I don't think there is any need to add a shorter hard limit to the timeout - if you don't want to wait any longer for it, you don't have to. Feel free to add it to your local copy of the script, though, just remember to take a backup of it before installing a new version over it.

AlbumArtDownloader XUI has well progressed since first versions. Even if it does time, I've just wanted to say I don't have freeze anymore when I click on thumbnails ! Thanks.

Else I don't know if it's scripts or software, but it uses a huge number of RAM (I can easily be at 400Mo).

Thanks, I've tried hard to improve the performance, and I'm glad its noticeable. Measuring RAM usage can be tricky with .net applications, particularly if you are just using the task manager to do it. They tend to grab all the RAM they like, and only release it when something else wants it. One trick I've seen is if you minimise and restore the Album Art Downloader window, that can get it to show a lower number in the task manager.

On the other hand, if you have a search window open with lots of results in, and have set it to download full size images, then 400Mb is not unreasonable at all. Large images take up lots of memory. If you are finding that memory usage keeps going up significantly, and doesn't go back down even after closing open windows, then there may be a leak I haven't found. Unfortunately these can be very tricky to track down, but if you think you've found one, PM me and I can try and work with you to resolve it.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 22 September, 2007, 02:31:02 PM
AlbumArt Downloader XUI v0.10 Released

Some of you may have been hoping that the version after 0.9 would be 1.0, but it just doesn't work like that! I'm not waiting on anything specific to jump to a 1.0 release, but I think quite a bit of work around the website/wiki and documentation for it would be at least one requirement. So, this is 0.10.

This version is a stability release, which fixes some bugs that were reported:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.0 (http://www.microsoft.com/downloads/details.aspx?familyid=10CC340B-F857-4A14-83F5-25634C3BF043&displaylang=en) (required)
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 23 September, 2007, 01:48:28 AM
Great stuff Alex.

I noticed that the 0.10 has

Code: [Select]
request.Headers.Add("X-Apple-Store-Front","143457")


but it won't work for me unless I have

Code: [Select]
request.Headers.Add("X-Apple-Store-Front", "143441")


I begin to wonder if this is dependent on the Country for iTunes Music Store.
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 September, 2007, 03:19:35 AM
Great stuff Alex.

I noticed that the 0.10 has

Code: [Select]
request.Headers.Add("X-Apple-Store-Front","143457")


but it won't work for me unless I have

Code: [Select]
request.Headers.Add("X-Apple-Store-Front", "143441")


I begin to wonder if this is dependent on the Country for iTunes Music Store.

Thanks!

The header might be country dependant, that seems at least reasonable. I thought the 143441 value was the latest one, as suggested [a href='index.php?act=findpost&pid=516175']here[/a], but checking the file as shipped, it does seem to have gone back to 143457. Both values work just fine for me, strangely.

So, if iTunes isn't working for you, try this alternative itunes.boo (http://www.byalexv.co.uk/foobar/itunes.boo), which has the 143441 value. I'd also be interested to hear if this version doesn't work for anyone, when the version in the 0.10 release does. Otherwise, I'll use this version for future releases.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 23 September, 2007, 04:13:45 AM
Alex!

Have a go with and I wonder if you will be pulling hair off just like me!

50 Cent
Curtis

I was also wondering where do you use this code

Code: [Select]
    static def GetResult(url):
        try:
            return GetPageSecret(url + ".jpg");
        except e:
            return GetPageSecret(url + ".tif");


More in particular, to debug this thing more, I'd like to see an example string that passes as "url" to the GetResult method.

This is getting mighty exciting.

Thanks,
McoreD
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 September, 2007, 05:00:05 AM
50 Cent
Curtis
Yep, no results for that. Neither does thejosher.net (http://www.thejosher.net/iTunes/index.php?artist=50+Cent&album=Curtis), it seems.

I was also wondering where do you use this code

Code: [Select]
    static def GetResult(url):
        try:
            return GetPageSecret(url + ".jpg");
        except e:
            return GetPageSecret(url + ".tif");


More in particular, to debug this thing more, I'd like to see an example string that passes as "url" to the GetResult method.
That nice bit of work was from david_dl - it checks to see if the full album art is available either as a .jpg or as a .tif. Previously, only jpgs would be returned. An example of one of these partial url strings would be: "http://a1.phobos.apple.com/r10/Music/y2004/m03/d17/h17/s02.wlcqjasf".

The way that these scripts based on static methods with magic names works is as follows: First, the GetThumbs method is called. The first parameter to that method is an object with a method on it called AddThumb (since renamed to just Add, but the old name still works). AddThumb takes several parameters, the last of which is an arbitrary object that can be set to anything you like.

When (and if) a full size image is required for a result, the GetResult method is called, whose single parameter will be whatever object was passed in as the last parameter for the AddThumb method of that result. Quite often, the GetResult method just returns the parameter directly, as no further processing on it is needed.

The return value from GetResult, like the value passed for the first parameter of AddThumb, can be any of:
In the iTunes case, the last parameter to the AddThumb method is a partial URL string that is extracted from the results XML returned from the initial query. When a full sized image is requested, the GetResult method first tries to complete that partial URL with ".jpg", then if that fails, tries it with ".tif" instead.

Although no scripts use it yet, because, lets face it, copying and pasting an existing one and modifying it is so much easier, I've added a more type-safe object-orientated way of implementing scripts, which does not rely on methods with magic names. If you add a reference to AlbumArtDownloader.Scripts.dll, then there is an interface: IScript. Implementing this makes your class a script. Also in that assembly there is an IScriptResults interface, which is what the object passed to GetThumbs (or IScript.Search) implements, so you can see what methods and properties are available on it.

If this is all too much information, I apologise, but it looked like you were interested in what was going on under the hood.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 23 September, 2007, 05:12:48 AM
Alex, but did you try his alternative method using Album URL?

Code: [Select]
http://phobos.apple.com/WebObjects/MZStore.woa/wa/viewAlbum?id=262406609&s=143460


That's great info, I'd luv to have a dev chat with you online if you don't mind.. 

Currently I am working on trying to get 50 Cent - Curtis searchable.

Passed the TIF challenge.

Code here is an example to search the artwork from all the iTunes Stores around the world.

Code: [Select]
    Public Function GetArtworkPath() As String

        ' Usage :
        'Dim itms As New cITMSArt("4 Strings", "Turn It Around")
        'Process.Start(itms.GetArtworkPath)

        Try
            Dim iTMSdir As String = My.Settings.ArtworkDir + Me.artist + Path.DirectorySeparatorChar + Me.album
            Dim iTMSpath As String = iTMSdir + Path.DirectorySeparatorChar + "iTMS.jpg"

            If Directory.Exists(iTMSdir) = False Then
                Directory.CreateDirectory(iTMSdir)
            End If

            If File.Exists(iTMSpath) Then
                sWriteDebugLog("Found saved iTMS Artwork: " & iTMSpath)
                Return iTMSpath
            Else
                Dim wc As New WebClient
                For Each storeID As String In My.Settings.ListStoresID
                    Dim url As String = GetArtworkURL(storeID.Trim)
                    If url <> String.Empty Then
                        ' now we konw the url is valid
                        Try
                            wc.DownloadFile(url, iTMSpath)
                        Catch ex As System.Net.WebException
                            ' see if tif is availble
                            url = Path.ChangeExtension(url, ".tif")
                            iTMSpath = Path.ChangeExtension(iTMSpath, ".tif")
                            wc.DownloadFile(url, iTMSpath)
                            Try
                                Dim img As Image = Image.FromFile(iTMSpath)
                                ' save the jpg convert
                                Dim iTMSpathJPG As String = Path.ChangeExtension(iTMSpath, ".jpg")
                                img.Save(iTMSpathJPG, System.Drawing.Imaging.ImageFormat.Jpeg)
                                sWriteDebugLog(String.Format("Successfully converted {0} to JPG", iTMSpath))
                                iTMSpath = iTMSpathJPG
                            Catch errSave As Exception
                                ' Error converting
                            End Try
                        End Try
                        sWriteDebugLog("Fetched " & url)
                        Return iTMSpath
                    End If
                Next
                sWriteDebugLog("Could not get iTMS Artwork Path")
                Return String.Empty

            End If
        Catch ex As Exception
            sWriteDebugLog("Error getting iTMS Artwork Path")
            Return String.Empty
        End Try

    End Function


Code: [Select]
   Public Function GetArtworkURL(ByVal id As String) As String

        Dim x As New XmlDocument

        Dim search As String = "http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an=" + artist + "&pn=" + album
        Console.WriteLine(search + " with " + id)
        Dim t As Stream = GetPageSecret(search, id)
        Try
            Dim gzi As New GZip.GZipInputStream(t)
            x.Load(gzi)
            sWriteDebugLog("Accessed iTMS ID: " & id)
        Catch ex As Exception
            sWriteDebugLog(String.Format("Error getting iTMS Artwork URL with Store ID: {0}. {1}", id, ex.Message))
            Return String.Empty
        End Try

        Dim tags As XmlNodeList = x.GetElementsByTagName("dict")
        If tags.Count = 0 Then
            Return Nothing
        Else
            Dim url As String = String.Empty
            Dim albumname As String = String.Empty
            Dim whichTag As Integer = 0

            For Each tag As Xml.XmlNode In tags(0).ChildNodes
                If tag.InnerText = "cover-art-url" Then
                    url = tag.NextSibling.InnerText
                ElseIf tag.InnerText = "playlistName" Then
                    albumname = tag.NextSibling.InnerText
                    Exit For
                End If
            Next

            If url.Length > 0 Then
                ' url is ' http://a1.phobos.apple.com/r10/Music/y2004/m08/d02/h11/s05.egorzxul.enc.jpg?downloadKey2=1190559591_ff0a61272432c71f489474b1a5712f97
                ' now just have to remove ".enc" and everything after the question make so you get
                ' http://a1.phobos.apple.com/r10/Music/y2004/m08/d02/h11/s05.egorzxul.jpg
                ' which is a valid artwork file!
                Return url.Substring(0, url.IndexOf("?")).Replace(".enc", "")
            Else
                sWriteDebugLog("iTMS artwork was not found")
            End If

        End If

        Return String.Empty

    End Function


Insight to how the scripts work was really great. Thank you for that!
Title: Album Art Downloader XUI
Post by: pirlouy on 23 September, 2007, 06:17:09 AM
Just a little little bug: when you launch a new search (I use the same window), there is a thumbnail of the previous search !
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 September, 2007, 08:45:37 AM
Just a little little bug: when you launch a new search (I use the same window), there is a thumbnail of the previous search !

Could you be a little more specific about what you are doing here? If I do a search, I get some results in the window. If I change the artist or album and press the Search button again, then the previous results are removed, and new ones start coming in. What is it you are seeing, are the new results added to the existing results? Or are no new results coming in at all? What did you change between one search and the next?

Alex
Title: Album Art Downloader XUI
Post by: pirlouy on 23 September, 2007, 02:17:09 PM
After some search, in fact, I think it's the local script which show the wrong thumbnail:
(https://hydrogenaud.io/imgcache.php?id=2b9ce49f9e315755ac04020a6fa9bb25" rel="cached" data-warn="External image, click to view at original size" data-url="http://img526.imageshack.us/img526/2490/aad070923sq0.th.png) (http://img526.imageshack.us/my.php?image=aad070923sq0.png)

Another thing: I have not searched for now, but is it possible to automatically add a'1' or '2' at file end, when we save and the file already exists ? (I hope I'm clear)
For example (based on my screenshot, file "Madonna - Die Another Day.jpg" already exists: is it possible to automatically change name by Madonna - Die Another Day2.jpg for next files ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 September, 2007, 02:49:34 PM
After some search, in fact, I think it's the local script which show the wrong thumbnail:
(https://hydrogenaud.io/imgcache.php?id=2b9ce49f9e315755ac04020a6fa9bb25" rel="cached" data-warn="External image, click to view at original size" data-url="http://img526.imageshack.us/img526/2490/aad070923sq0.th.png) (http://img526.imageshack.us/my.php?image=aad070923sq0.png)

Another thing: I have not searched for now, but is it possible to automatically add a'1' or '2' at file end, when we save and the file already exists ? (I hope I'm clear)
For example (based on my screenshot, file "Madonna - Die Another Day.jpg" already exists: is it possible to automatically change name by Madonna - Die Another Day2.jpg for next files ?
Ah, OK, the Local Files search is special. I can't see exactly what file save path you are using, so I can't give you a complete answer, but the Local Files search tries to find existing files on your hard disk based on the save path and album/artist you are searching for.

To change what pattern it is using to look for files, click the ... button to the bottom of the Local Files source, and it has an option to specify where to look. Or, you can just uncheck the local files source and not use it at all, if you prefer.

I don't think automatically renaming second copies of files fits in very well with Album Art Downloader functionality. The idea is that you are downloading the art for an album, so once chances are if it already exists, you either want to keep it, or replace it with a better version, not save another copy.

Alex
Title: Album Art Downloader XUI
Post by: pirlouy on 23 September, 2007, 03:12:45 PM
Ah, OK, the Local Files search is special. I can't see exactly what file save path you are using, so I can't give you a complete answer, but the Local Files search tries to find existing files on your hard disk based on the save path and album/artist you are searching for.
Oops: D:\Mes documents\Ma musique\[07]pochettes\Madonna - Die Another Day.jpg (%artist% - %title%.jpg)

I have the jacket of Massive Attack and another called "Madonna - Die Another Day.jpg", so it should have shown me this file and not Massive Attack one.

Quote
I don't think automatically renaming second copies of files fits in very well with Album Art Downloader functionality. The idea is that you are downloading the art for an album, so once chances are if it already exists, you either want to keep it, or replace it with a better version, not save another copy.


That's what I thought until now, but since I've been using foo_uie_albumart, it could cycle between several images, so I can save several images if I want. Of course, I can change path manually, but it would have been easier if... But I can understand you don't want to add a lot of options...

Thanks for your answer.
Title: Album Art Downloader XUI
Post by: iElectric on 24 September, 2007, 07:08:08 AM
AlexVallat, this has grown into a very nice app! Thanks.

I have only one "note".. Have you considered using tabs instead of new windows?
Title: Album Art Downloader XUI
Post by: AlexVallat on 25 September, 2007, 07:47:16 AM
AlexVallat, this has grown into a very nice app! Thanks.

I have only one "note".. Have you considered using tabs instead of new windows?

Thanks, I'm glad you like it! I'm not sure how well tabs would work for this application, really. The original decision at design-time was to make this an SDI rather than MDI app. This means that there is no overall application window to have child 'document' windows, which could be shown as tabs or any other UI to taste.

The design was chosen to mesh well with its intended usage of being called from a command from another application (like foobar), rather than typically being the starting-point application for a task. Running a command opens a window as a result of that command, it does not generally open another tab in the window of the previous command's results.

Thanks for the suggestion, though.

Alex
Title: Album Art Downloader XUI
Post by: 2Pacalypse on 26 September, 2007, 03:41:40 PM
does version 0.10 contain everything needed for downloading from iTunes or do i need to get a seperate script?
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 September, 2007, 04:29:58 PM
does version 0.10 contain everything needed for downloading from iTunes or do i need to get a seperate script?

It contains everything you need, but only searches iTunes storefront 143457. I put up an alternative script to search storefront 143441 instead, which some users have been reporting has having better results. If you want to use that instead, you need to download it: itunes.boo (http://www.byalexv.co.uk/foobar/itunes.boo), and replace the existing script with it.

If I have time, I hope to create a script that searches all storefronts until it finds a match, as suggested by McoreD.

Alex
Title: Album Art Downloader XUI
Post by: mwfuss on 28 September, 2007, 12:15:32 PM
This seems to be an excellent program. There are several features mentioned in the opening post that I have been unable to figure out how to implement. The features in question are:

# Analyse files to find Artists and Albums from tags, and check if album art is already present.
# Read your foobar2000 media library to find Artists and Albums, and check for album art.

I have been able to search for album art one album at a time by imputing the necessary information in the search fields, but I have not been able to figure out how to do the above.

One other matter, when I go to File>New>File Browser or File>New>Foobar Browser the only thing that happens is that a blank window opens. Am I missing some necessary Foobar components. I have the foo_browser component installed.

Any help would be greatly appreciated.

Nevermind. I must have been using an older version of the program. After installing the latest, everything works just fine.
Title: Album Art Downloader XUI
Post by: Scidd0w on 28 September, 2007, 04:19:09 PM
It contains everything you need, but only searches iTunes storefront 143457. I put up an alternative script to search storefront 143441 instead, which some users have been reporting has having better results.
...
With almost every search i do the itunes script gives me 1 result back. That is at first unknown by size and after clicking for a preview its 177x177. This is also happens with albums that i allready downloaded via the itunes script with  a very old version (coverart) a long time ago.
Is the above also related to my problem with the itunes script. Or is it normal for this script to output such small files?
The rest if the scripts worked way fine. Thank you for this tool!
Title: Album Art Downloader XUI
Post by: mobyduck on 28 September, 2007, 06:51:42 PM
With almost every search i do the itunes script gives me 1 result back. That is at first unknown by size and after clicking for a preview its 177x177.
Yeah, same here since yesterday. I'm afraid it's related to this (http://www.hydrogenaudio.org/forums/index.php?act=findpost&pid=519391).

Alessandro
Title: Album Art Downloader XUI
Post by: xamphear on 05 October, 2007, 09:20:19 PM
I reaaaaaaaaly like this program. It's just missing one feature that would save me so much time. Could you possibly include some built-in image resizing feature?

ie: I specify that my target size is 500x500, so when i save a 800x800 cover it resizes it down to 500x500, but leaves a 300x300 cover alone (because resizing up is ugly!)

I often times find covers in 200x200 and 1000x1000 size with nothing really good in-between.

At any rate, thanks for this great and useful application.
Title: Album Art Downloader XUI
Post by: TedFromAccounting on 06 October, 2007, 02:58:12 AM
Has anyone written a script for buy.com?
Title: Album Art Downloader XUI
Post by: Hamilcar on 07 October, 2007, 09:54:57 AM
Hey excellent app but I was scanning my foobar library when I got this message:

Error occured while reading media library: The specified path, file name, or both are too long...

anyway I can check a log to change the file or directory name?
or is that a bug that will be fixed ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 07 October, 2007, 12:11:36 PM
I reaaaaaaaaly like this program. It's just missing one feature that would save me so much time. Could you possibly include some built-in image resizing feature?
Thanks for the suggestion. I'm not sure whether I want to be doing post-processing on the images after downloading or not. If I do, then resizing will certainly be one of the options offered, as would conversion to .jpg, and possibly aspect ratio correcting.

Hey excellent app but I was scanning my foobar library when I got this message:

Error occured while reading media library: The specified path, file name, or both are too long...

anyway I can check a log to change the file or directory name?
or is that a bug that will be fixed ?
There is a way to get a log file - create a file called AlbumArt.exe.config in the program folder (or edit your user.config for Album Art Downloader, but that's trickier to find!), and put this in it:
Code: [Select]
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
  <system.diagnostics>
   <trace autoflush="true">
     <listeners>
       <add name="debugListener"
                 type="System.Diagnostics.TextWriterTraceListener"
                 initializeData="tracelog.txt" />
     </listeners>
   </trace>
  </system.diagnostics>
</configuration>
For any .net app, that causes the trace log output to be written to a file called tracelog.txt in the program folder.

Unfortunately, reviewing the source for 0.10, I don't think you will see anything useful enough to tell you which file it is that is too long. I've stuck up a version 0.10.1 (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.10.1.exe) which if you update to will provide more useful information, and also not abandon scanning the rest of the library just because one file failed. The only other change to 0.10.1 is to remove the iTunes script from the installer, since Apple have blocked access again.

Alex
Title: Album Art Downloader XUI
Post by: Hamilcar on 07 October, 2007, 12:48:10 PM
thank you very much for your fast reply!
Title: Album Art Downloader XUI
Post by: francesco on 16 October, 2007, 09:18:53 AM
AMAZING
this program is amzing
thanks really for your job!

but how can i save the thumbs in covers.jpg?
Title: Album Art Downloader XUI
Post by: pirlouy on 16 October, 2007, 11:42:40 AM
If you click on 'options', you will see a field in which you can choose the name.
Else, if you want to save it automatically in a specific path, you have to use command line options:
http://album-art.sourceforge.net/index.php..._Line_Reference (http://album-art.sourceforge.net/index.php/Command_Line_Reference)
Title: Album Art Downloader XUI
Post by: hugo25 on 16 October, 2007, 11:54:57 AM
I think it miss an option to show size in kb for each cover.

Thanks for this amazing software !
Title: Album Art Downloader XUI
Post by: francesco on 18 October, 2007, 04:27:45 AM
i would love to download automatically  the best match
Title: Album Art Downloader XUI
Post by: francesco on 28 October, 2007, 12:18:54 PM
 
do u plan to add a lyrics support ,to download lyrics ?
Title: Album Art Downloader XUI
Post by: Chaser on 28 October, 2007, 02:11:45 PM
This component is not designed for downloading lyrics. franesco, you get quite some plugins for acquiring lyrics here in the forum - just do a search.
Title: Album Art Downloader XUI
Post by: francesco on 30 October, 2007, 10:38:48 AM
This component is not designed for downloading lyrics. franesco, you get quite some plugins for acquiring lyrics here in the forum - just do a search.

yes i know
the lyrics downloader doesn't work

it's could be a great new feature for album art downloader
Title: Album Art Downloader XUI
Post by: FavioD on 30 October, 2007, 11:56:22 AM

This component is not designed for downloading lyrics. franesco, you get quite some plugins for acquiring lyrics here in the forum - just do a search.

yes i know
the lyrics downloader doesn't work

it's could be a great new feature for album art downloader

but then it wouldn't be called album art downloader 
Title: Album Art Downloader XUI
Post by: Chaser on 30 October, 2007, 04:11:11 PM
Though beeing off-topic, take a look at foo_uie_lyrics. It does it's job quite well!
Title: Album Art Downloader XUI
Post by: Tich on 02 November, 2007, 12:12:40 PM
Is the Cover-Paradies script working for anybody?
Seems like I'm not getting any results from it anymore (been like this for weeks, if not more than a month) while I get nice results when using the web-search.

Example: Porcupine Tree - In Absentia
http://www.cover-paradies.to/?Module=ViewEntry&ID=282622 (http://www.cover-paradies.to/?Module=ViewEntry&ID=282622)

I would appreciate it if somebody could take a look at it and possibly provide an updated version of the script, since this is the best source for high-quality Albumart scans imo.
Title: Album Art Downloader XUI
Post by: AlexVallat on 02 November, 2007, 01:22:58 PM
Is the Cover-Paradies script working for anybody?
Seems like I'm not getting any results from it anymore (been like this for weeks, if not more than a month) while I get nice results when using the web-search.

Example: Porcupine Tree - In Absentia
http://www.cover-paradies.to/?Module=ViewEntry&ID=282622 (http://www.cover-paradies.to/?Module=ViewEntry&ID=282622)

I would appreciate it if somebody could take a look at it and possibly provide an updated version of the script, since this is the best source for high-quality Albumart scans imo.

Fixed: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)

While I'm here:
Alex
Title: Album Art Downloader XUI
Post by: Tich on 02 November, 2007, 02:45:09 PM
Fixed: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)

You Sir, are a Legend!
Thank you very much Alex!
Title: Album Art Downloader XUI
Post by: joen on 02 November, 2007, 02:51:46 PM
Fixed: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)


Excellent, I really missed using this script, it's by far the best. Thanks a lot, it's much appreciated
Title: Album Art Downloader XUI
Post by: Melomane on 02 November, 2007, 04:07:48 PM
i have a bug with "local files" display.

image is sometimes wrong but path is correct.



i use this string with foo run and foobar 0.95 b2

C:\Program Files\AlbumArtDownloader\AlbumArt.exe "%artist%" "%album%" "$replace(%path%,%filename_ext%,folder.jpg)"
Title: Album Art Downloader XUI
Post by: AlexVallat on 03 November, 2007, 03:58:31 AM
i have a bug with "local files" display.

image is sometimes wrong but path is correct.



i use this string with foo run and foobar 0.95 b2

C:\Program Files\AlbumArtDownloader\AlbumArt.exe "%artist%" "%album%" "$replace(%path%,%filename_ext%,folder.jpg)"

Could you check what path the Local Files source is searching? To do this, click the ... button on the bottom right of the Local Files source in the list, and see if the "Specify path to find images" checkbox is checked. If it is, then check what the path in the combo box underneath it says - that will be where it looks for images.

If it is not checked, then it will be looking for images in the default path to save to, but with the placeholders %name%, %extension%, %source% and %size% replaced by wildcards (*).

Alex
Title: Album Art Downloader XUI
Post by: Melomane on 03 November, 2007, 07:39:03 PM
no, isn't checked

if i check it, folder displayed isn't the "path to save art "

i have add this in foo run :
/localImagesPath "$replace(%path%,%filename_ext%,folder.jpg)"

and now work alltimes

also i have problems with somes albums where artist and album are the same: edit box for album is empty.

no problems if i use this:
C:\Program Files\AlbumArtDownloader\AlbumArt.exe
/ar "%artist%"
/al "%album%" 
/p "$replace(%path%,%filename_ext%,folder.jpg)"
/localImagesPath "$replace(%path%,%filename_ext%,folder.jpg)"

thank you for your answer Alex
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 05 November, 2007, 06:11:38 PM
Can somebody tell me if the Cover-Paradies script works correct?
If I just use it then I get no results although there are covers on cover-paradise.to.

If someone could make this script work again I would be grateful.

Okay I found the fixed version thanks.
I have had some crashes. But as far as I can tell I works like a charm.
Title: Album Art Downloader XUI
Post by: shlomomofo on 09 November, 2007, 02:14:34 PM
this program looks pretty sweet, but i'm having trouble getting it work right.  if search for some artist, it looks like only three of the scripts are actually working (artists.trivialbeing, coverisland, yes24). these are the only ones where the progress bars show any action.  i get very few results, even for very popular releases.  also, it seems that yes24 is the only script that actually results at all.

any hints?  i'm using vista, and the newest albumartdownloader version....


edit:  oops, i'm an idiot.  all the scripts work, but only if i enter artist AND album.  sorry.

edit 2: after spending a bit of time with this software, i must say that it is incredible.  powerful and usable!  the the only thing i find myself wishing for is a quicker way to save separate front, back, and disc images.  my idea is to have maybe three text fields with radio button selectors.  you can put a different file name in each text box (e.g. "back.jpg").  select that radio button, and then hitting the little save icons saves the image as "back.jpg" in whatever folder is already selected.  then click the "folder.jpg" radio button... now hit save on a front cover to save a "folder.jpg" to the same folder.  if you were to put this in the "options..." section, i would leave options open by default... that way you don't have to open options every album if you are going through a long queue.  anyway, just an idea to make things easier when grapping multiple images for each album, especially if you are wading through a long queue.  thanks again!!!
Title: Album Art Downloader XUI
Post by: fuffi on 10 November, 2007, 06:34:09 AM
hi,
i like the program very much. it does, what it should :-)
but in some cases, i'm not completly satisfied, i whish it could be a little improved.
so here's a wish, right bevore xmans *<:-)

the "save as" is a wonderful feature, but a lot of times, i'd like to save more than only one file from the list of found pictures, because there are "front" "back" "inlay" "artist picture" etc. available.
typing all the names for all the different files to be saved it is very unhandy. (and useles for me, because i really dont care about the filenames)

so i'd wished, i had a button "save with original filename" which opens the "save as"-dialogue and has the original filename from the origin website already shown, so that i only have to press enter (or change a little bit, instead of personally whiches oder duplicates)

is this possible?
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 November, 2007, 07:05:25 AM
edit 2: after spending a bit of time with this software, i must say that it is incredible.  powerful and usable!  the the only thing i find myself wishing for is a quicker way to save separate front, back, and disc images.
Thanks, glad you liked it! For your suggestion, my idea for solving this problem would be a Preset system. I described it in the old thread, but here it is again:

Presets
1. Addition of a new placeholder for the Save Images path, available from the dropper menu: %preset%
2. Addition of a dropper arrows just to the right of the Save buttons, when clicked pops up a menu with: "Save As...", <list of presets>, "More...". List of presets is initially blank, but "More" pops up:
3. "Save with Preset" dialog. Dialog with two column list of Name and Value preset entries, with Add and Delete buttons, and Save and Close buttons. Adding a Name/Value preset entry shows it as it's name on the list of presets in the menu, to avoid having to go through this dialog again. When an entry is selected, the Save button is enabled. Clicking that has the same effect of choosing the entry from the menu, which is to save, but with:
4. %preset% replaced in the path by the value of the preset, with any placeholders in that entry value also processed.

I may even get round to actually writing it sometime, but it probably won't be any time soon, sorry.

so i'd wished, i had a button "save with original filename" which opens the "save as"-dialogue and has the original filename from the origin website already shown, so that i only have to press enter (or change a little bit, instead of personally whiches oder duplicates)
This would probably also be addressed by the presets idea presented above, but in fact what you are asking for, to use the name of the image in the filename to save as, is already possible.

Open the Options area, then in the Save Images To box, use the placeholder %name% somewhere in the path. For example, C:\AlbumArt\%artist%\%album%\%name%.%extension%. The placeholder will be replaced by the name as displayed in the results list.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 10 November, 2007, 08:34:08 AM
alex, thanks for the fast reply.

i've read the "presets"-thing and it sounds quite cool.

i use your program from within foobar run_services (did not mentioned it above, sorry)
with
"x:\foobar2000\components\AlbumArtDownloaderXUI\AlbumArt.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%name%.%extension%"

then, the filemname is "?.?" which is understandable for me, but not solving my problem :-)

i fooled around with single and double quotes ' "
but did not succeed.

i'm not writing all the images into a single directory, but in the directory the music is in. so the directory changes with every album or title.
Title: Album Art Downloader XUI
Post by: Purple Monkey on 10 November, 2007, 09:08:00 AM
You need to escape the %s otherwise foobar will try to parse them, use %%name%% and %%extension%%.
Title: Album Art Downloader XUI
Post by: fuffi on 10 November, 2007, 10:57:33 AM
You need to escape the %s otherwise foobar will try to parse them, use %%name%% and %%extension%%.
thank you very much!
now i only have to change the filenames if they have special characters like in this filename

X:\foo\bar\CAMP, Bob \x26amp; Bob GIBSON --\x26gt; V.A.: ....jpg

anyway,
i was not sure, if for this case there is a help, so i clicked the help-menu in album-art-downloader XUI and was redirected to the souceforge website.
after that (i had to say YES to zonealarm for letting it open my firefox browser)
album-art-downloader XUI crashed.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: E:\Programme\foobar2000\components\AlbumArtDownloaderXUI\errorlog.txt

App version: 0.10.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ComponentModel.Win32Exception: Das System kann die angegebene Datei nicht finden
   bei System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)
   bei System.Diagnostics.Process.Start()
   bei System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
   bei System.Diagnostics.Process.Start(String fileName)
   bei AlbumArtDownloader.Menu.GoToPageExec(Object sender, ExecutedRoutedEventArgs e)
   bei System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   bei System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   bei System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   bei System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   bei System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   bei System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
   bei System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
   bei System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   bei System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   bei System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   bei System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
   bei System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
   bei System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   bei System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
   bei System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
   bei System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   bei System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   bei System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   bei System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
   bei MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   bei System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 November, 2007, 02:56:11 PM
i was not sure, if for this case there is a help, so i clicked the help-menu in album-art-downloader XUI and was redirected to the souceforge website.
after that (i had to say YES to zonealarm for letting it open my firefox browser)
album-art-downloader XUI crashed.
Yeah, looks like it wasn't happy about being intercepted by ZoneAlarm there. Thanks for reporting it, it will be fixed in the next version.

As I'm sure you've probably realised by now, there isn't really a help either, sorry! There's a Command Line Reference (http://album-art.sourceforge.net/index.php/Command_Line_Reference), and a Wiki page (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Components_0.9/AlbumArtDownloader_XUI), but not much else.

Alex
Title: Album Art Downloader XUI
Post by: shlomomofo on 10 November, 2007, 05:49:10 PM
I may even get round to actually writing it sometime, but it probably won't be any time soon, sorry.

word.  i like your idea better than mine. hopefully it makes it into the next version, whenever that may be.
Title: Album Art Downloader XUI
Post by: Killmaster on 24 November, 2007, 03:56:36 PM
Could someone step me through on how to use this program?

I open it up, and none of the sources show. I finally figure out that I need to run it under administrator (I'm using Vista), so now it works. But how do I get it to scan my files? It looks like you can save it to folders according to artist/album; is there a way to add date to the mix? My entire collection is sorted %album artist%/['('%date%')' ]%album%/

The File browser gives me a blank window with "file browser goes here..." and the foobar browser gives me the same. I installed the COM automation plugin for foobar like the OP said. I can't find any documentation and I'm confused

edit: I just realized that I didn't have the latest version. It still doesn't work with Foobar though, even though the COM server is installed. Is there anything I have to do to get it working? Oh and the file browser crashes the program..
Title: Album Art Downloader XUI
Post by: daniel/L on 26 November, 2007, 09:35:43 AM
After clicking the "Get Artwork" button AlbumArt (started using a "AlbumArt.exe /foobarBrowser" shortcut) immediately crashes, no matter how much songs have been selected.

This is the resulting error log:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\Foobar2000AlbumArtDownloader\errorlog.txt

App version: 0.10.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Windows.Markup.XamlParseException:  Stack empty.  Error at object 'System.Windows.Controls.ControlTemplate', Line 40 Position 9. ---> System.InvalidOperationException: Stack empty.
   at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
   at System.Collections.Generic.Stack`1.Pop()
   at System.Windows.Markup.OptimizedTemplateContent.CheckElementStartForOptimization(BamlRecord bamlRecord)
   at System.Windows.Markup.OptimizedTemplateContent.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.OptimizedTemplateContent.AddContentRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.TemplateBamlRecordReader.AddContentRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.TemplateBamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
   at System.Windows.Markup.TemplateBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   at System.Windows.Markup.TemplateTreeBuilderBamlTranslator.ParseFragment()
   at System.Windows.Markup.TreeBuilder.Parse()
   at System.Windows.Markup.XamlTemplateSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
   at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
   at System.Windows.Markup.StyleBamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
   at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   --- End of inner exception stack trace ---
   at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
   at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
   at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.StyleBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   at System.Windows.Markup.StyleTreeBuilderBamlTranslator.ParseFragment()
   at System.Windows.Markup.TreeBuilder.Parse()
   at System.Windows.Markup.XamlStyleSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
   at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
   at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.BamlRecordReader.ReadElement(Int64 startPosition, XamlObjectIds contextXamlObjectIds, Object dictionaryKey)
   at System.Windows.ResourceDictionary.CreateObject(Int32 valuePosition, Object key)
   at System.Windows.ResourceDictionary.RealizeDeferContent(Object key, Object& value, Boolean& canCache)
   at System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
   at System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
   at System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
   at System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
   at System.Windows.ResourceDictionary.FetchResource(Object resourceKey, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
   at System.Windows.SystemResources.LookupResourceInDictionary(ResourceDictionary dictionary, Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
   at System.Windows.SystemResources.FindDictionaryResource(Object key, Type typeKey, ResourceKey resourceKey, Boolean isTraceEnabled, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
   at System.Windows.SystemResources.FindResourceInternal(Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference)
   at System.Windows.StyleHelper.GetThemeStyle(FrameworkElement fe, FrameworkContentElement fce)
   at System.Windows.FrameworkElement.UpdateThemeStyleProperty()
   at System.Windows.FrameworkElement.OnInitialized(EventArgs e)
   at System.Windows.FrameworkElement.TryFireInitialized()
   at System.Windows.FrameworkElement.EndInit()
   at System.Windows.Markup.BamlRecordReader.ElementEndInit(Object& element)
   at System.Windows.Markup.BamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
   at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
   at System.Windows.Markup.TreeBuilder.Parse()
   at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
   at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
   at AlbumArtDownloader.ArtSearchWindow.InitializeComponent()
   at AlbumArtDownloader.ArtSearchWindow..ctor()
   at AlbumArtDownloader.Common.NewSearchWindow(IAppWindow existingWindow, Boolean forceShown)
   at AlbumArtDownloader.BrowserResults.GetArtworkExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.Button.OnClick()
   at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
   at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.ReRaiseEventAs(RoutedEventArgs args, RoutedEvent newEvent)
   at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)


And here's the tracelog:
Code: [Select]
AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.10.1.0
Path not found for file search: X:\Musik\!neues\20070415\Evocation--Tales_from_the_Tomb-Promo-2007-UBE\Folder.jpg
Path not found for file search: X:\Musik\Excrementory Grindfuckers\Bitte nicht vor den Gästen\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070305\Emil_Bulls-The_Life_Acoustic-2007-SnS\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Disbelief - 2004 - Spreading The Rage\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Excrementory Grindfuckers - [2002] - Gesammelte Werke\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\My_Dying_Bride_-_A_Line_Of_Deathless_Kings-Promo-2006-CMG\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\The Accidents\Poison Chalice\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Raised Fist\Sound Of The Republic\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061008\The Turbo A.C.'s - Fuel for Life\Fuel for life\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Logistics-Now_More_than_Ever-NHS112LP-Vinyl-2006-uC\Logistics-Now_More_than_Ever-NHS112LP-Vinyl-2006-uC\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Ltj.Bukem.Presents.Some.Blue.Notes.Of.Drum.N.Bass-2004-0mni\LTJ Bukem Presents Some Blue Notes of Drum N Bass-2004-0MNi\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\_einzelne\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061019\Nekromantix\Curse Of The Coffin\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061129\Jazzkantine\Heiss & Fettig\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Jamie.Cullum.-.Catching.Tales.192kbs\Jamie Cullum\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Kataklysm--In_the_Arms_of_Devastation-Promo-2006-UBE\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Miles Davis - Cookin With The Miles Davis Quintet\(JAZZ)Miles Davis - Cookin' With The Miles Davis Quintet - 320kbps - Lame-3.93.1\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Terrorizer-Darker_Days_Ahead-(Advance)-2006-RNS\Folder.jpg
Path not found for file search: X:\Incoming\Das Silmarillion\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Billy_Talent-Billy_Talent_II-2006-RST\Billy_Talent-Billy_Talent_II-2006-RST\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070218\Keen Of The Crow\Hyborea\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070509\LAK_-_Verdammtes_Leben-DE-2007-YSP\LAK_-_Verdammtes_Leben-DE-2007-YSP\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070214\Leng Tch'e\Marasmus\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\Neaera-Armamentarium-2007\Neaera-Armamentarium-2007\armium07\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\Age__2007_\pro-pain_-_age_of_tyranny_the_tenth_crusade_2007\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\The Pyske Project - Apnea\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\Witchcraft.-.The.Alchemist-2007-Cmg\Witchcraft_-_The_Alchemist-Promo-2007-CMG\Folder.jpg
AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.10.1.0
How can I solve this problem?

Thanks in advance!
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 November, 2007, 12:45:52 PM
After clicking the "Get Artwork" button AlbumArt (started using a "AlbumArt.exe /foobarBrowser" shortcut) immediately crashes, no matter how much songs have been selected.

Thanks for reporting this error. Could you tell me, does it work if you don't start from the foobar browser, or does it crash anyway? Does it crash if, instead of clicking the Get Artwork button, you click the File menu and click New, Search Window? Reading the stack trace, another interesting thing to know would be what theme you are using.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 26 November, 2007, 01:02:42 PM
First, awesome program!

Second, could you please highlight the Album name when tabbing from Artist?  That way you can just start typing in the album name without erasing the previous one first.  I'm pretty sure it used to work like that (back when it was much less developed overall).

Thanks! 
Title: Album Art Downloader XUI
Post by: daniel/L on 27 November, 2007, 07:02:10 AM
Thanks for reporting this error. Could you tell me, does it work if you don't start from the foobar browser, or does it crash anyway? Does it crash if, instead of clicking the Get Artwork button, you click the File menu and click New, Search Window? Reading the stack trace, another interesting thing to know would be what theme you are using.



Thanks for your reply!

When starting in /FileBrowser mode I'm getting the same result. Opening a new search windows also crashes AlbumArt immediately.
I'm using a completely "naked" Foobar 0.9.5 beta 5 (forgot to mention that) with no themes or stuff.
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 November, 2007, 07:10:28 AM
When starting in /FileBrowser mode I'm getting the same result. Opening a new search windows also crashes AlbumArt immediately.
I'm using a completely "naked" Foobar 0.9.5 beta 5 (forgot to mention that) with no themes or stuff.

Sorry, I should have been more specific - I meant Windows theme, not any sort of Foobar customisation (which should not affect it at all). For example, Vista Aero, Vista Windows Classic, XP Luna, XP Royale, etc...
Title: Album Art Downloader XUI
Post by: daniel/L on 28 November, 2007, 06:22:52 AM
Sorry, I should have been more specific - I meant Windows theme, not any sort of Foobar customisation (which should not affect it at all). For example, Vista Aero, Vista Windows Classic, XP Luna, XP Royale, etc...

Opps. I'm running WinXP SP2 with the default XP theme in silver. Nothing special.
Title: Album Art Downloader XUI
Post by: Snowsfall on 01 December, 2007, 07:52:58 PM
two quick requests, a last.fm artist photo .boo to replace the broken trivialbeing one and maybe one that searches flickr for artist photos. Not to sure how doable the flickr one would be but i might as well throw it out there.
thanks for the great program
Title: Album Art Downloader XUI
Post by: Ross1 on 09 December, 2007, 02:02:32 PM
Sadly, this program seems to crash all the time for me.

When I was writing the default directory to save to while it was searching (twice)
When I clicked 'stop all'
When I clicked 'search'
Title: Album Art Downloader XUI
Post by: AlexVallat on 09 December, 2007, 02:17:45 PM
Opps. I'm running WinXP SP2 with the default XP theme in silver. Nothing special.

I'm out of ideas then, sorry. I don't know why this is happening, and therefore can't fix it.

Sadly, this program seems to crash all the time for me.

When I was writing the default directory to save to while it was searching (twice)
When I clicked 'stop all'
When I clicked 'search'

Can you send me the errorlog.txt file created when it crashes? It might let me know what the problem is, usually worth a try anyway.

Oh, and Snowsfall, thanks for the suggestions about the artist searching scripts. I don't think I'll have a chance to try writing one any time soon, and artist image searching isn't really the focus of this app anyway! Perhaps someone else might want to have a go at scripts for these?

Alex
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 10 December, 2007, 12:55:47 PM
artist image searching isn't really the focus of this app anyway



well well its not but AADXUI is marvelously successfull in it with correct script  even google script can return some artist pictures but specialized sites are always better. just face the truth that this pgm doesnt have one purpose and that its idea is just usefull for many others
Title: Album Art Downloader XUI
Post by: Dave_K on 10 December, 2007, 06:29:59 PM
Is there any way to get this to search a local directory?

I use REACT with EAC and its ability to embed album art when creating a FLAC image is very useful. Unfortunately there are a fair few album covers that can't be found online by the included search scripts. For those I'd like to be able to download the images manually, yet still be able to select them in the Art Downloader during the REACT ripping process.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 December, 2007, 03:25:45 AM
Is there any way to get this to search a local directory?

Yes. The "Local Files" source does this. By default it will search in the "save to" folder, but you can change this using the /localImagesPath command line parameter, or by expanding the Local Files source in the UI (click ... in the bottom right of it) and entering the path to search there.

The following variables can be used in paths:
Code: [Select]
%artist%     Artist searched for
%album%      Album searched for
*            Wildcard, matches any characters
\**\         Subfolder search. Any folders will match at this point in the path. For example
             "\Art\Unsorted\**\*.jpg" will match:
              \Art\Unsorted\image.jpg
              \Art\Unsorted\misc\image.jpg
              \Art\Unsorted\misc\old\image.jpg
            
             "\Art\Unsorted\*\*.jpg" will match only:
              \Art\Unsorted\misc\image.jpg
Title: Album Art Downloader XUI
Post by: dd_wizard on 04 January, 2008, 05:09:26 AM
1. I'm using AAD in an AutoIt script on a Windows Vista system, and I've found an annoying bug.  It is easily replicated from the command line.  I am using the default of three searches active at a time.  Do the following from a command window:

cd "c:\program files\albumartdownloader"
albumart "eric clapton" blues
albumart "Joe Satriani" "Live In San Francisco"
albumart "eric clapton" blues
albumart "Joe Satriani" "Live In San Francisco"

The fourth invocation of AAD causes the Queue Manager window to open. If I double click the search, everything is fine.  ( Artist and album can be anything, I just happen to like those two CDs.  )

However, if I close the Queue Manager with the search pending, I can't start a new AAD search from the command line or from my script.  When I close one of the active AAD search windows, a new one pops up!  In fact, the number of windows that pop up equals the number of searches I tried to start after I closed the Queue Manager with the pending search. Plus the one that was pending.

It looks like the Queue Manager isn't closing properly if a search is queued when the window is closed.  It's still queueing searches, but it doesn't show up on the task bar and it doesn't open a Queue Manager window. Is this an easy fix?

2. I like how you run all the windows from one process, but it's a trick to find the window handle if AAD is running before my script starts.  It appears that the PID for the AAD window I start in my script, AND the PID for the original AAD process both change when the original AAD process inherits the window my script started.  This breaks AutoIt's RunWait() function, but it was fun finding a way to know which window handle belongs to my script.  Oh, and don't expect the command interpreter to hang around after the PID changes, either.  LOL  Have I analyzed the PID behavior correctly?

P.S.  Queueing is the unique word in the English language with 5 or more consecutive vowels. I got that from one of my CS professors.   

Thanks,
dd_wizard
Title: Album Art Downloader XUI
Post by: AlexVallat on 04 January, 2008, 05:34:27 AM
1. OK, odd as it may be in the circumstances you are describing, this is in fact the correct behaviour of the Queue system. It is there to prevent more than a specified number of simultaneous searches, so after that limit is reached, further searches are held in the queue. They can either be manually triggered by double clicking on them (as you have found), or will automatically run once an existing search is closed.

So, what's happening here is that your fourth search goes on the queue. If you close the Queue Manager window, that doesn't affect the queue at all, just stops showing it to you. (You can see it again by selecting "Queue Manager" from the "Window" menu.) Subsequent searches are also queued up, even though you can't see them if the manager window is closed. As you close existing windows, searches from the queue are popped off the queue and executed.

The important thing is that the Queue Manager window is just the thing that lets see and manipulate the queue, it is not the queue itself.

To avoid queueing behaviour altogether, just set the Simultaneous Windows number in the Queue Manager to a high number (10000 or something).

2. There is no specific PID changing behaviour or anything (I'm not even sure such a thing is possible!). The single-instance behaviour is that if AAD is already running, then any new instance of it started will send its command line parameters to the existing instance (through the named pipe net.pipe://localhost/AlbumArtDownloader/SingleInstance, if that's of any interest), then immediately exit. I can't see any way the PID of the original process would change as a result of this.

There is currently no option to avoid the single instance behaviour and run multiple instances of AAD, sorry. Without this, I can't think of any good way to wait for a specific search to be complete either, as no process will end, only a window will probably close (unless re-used for another search), and it is not programatically obvious which window, either.

Alex
Title: Album Art Downloader XUI
Post by: Zoominee on 04 January, 2008, 09:27:45 AM
Hi! I just discovered this program, I have installed it (and NET 3.0) because it looks very promising! But on my computer (Windows XP) it does not start. The error message is "This program must be closed, do you want to send the error report to Microsoft?"

According to that window, the error report contains the following information - maybe this is useful to the program developers:

Quote
EventType : clr20r3    P1 : albumart.exe    P2 : 0.10.1.0    P3 : 47090190
P4 : mscorlib    P5 : 2.0.0.0    P6 : 471ebc5b    P7 : 1c4c    P8 : 0   
P9 : system.typeloadexception


The error occurs when I start the program, before anything else happens. I cannot see any program windows. I have tried both installing the program as an administrator and installing it as a normal user, the error message is the same both times.

If there is something else I can do to help identify this error, let me know. With best wishes for 2008!
Title: Album Art Downloader XUI
Post by: AlexVallat on 04 January, 2008, 11:06:59 AM
Hi! I just discovered this program, I have installed it (and NET 3.0) because it looks very promising! But on my computer (Windows XP) it does not start...

Hi, thanks for reporting the error. Unfortunately the information that the error report window contained doesn't say much to me. There is a custom error reporting feature in AAD that should write out any errors to errorlog.txt (in the AAD program folder) then display that file in notepad, should a crash occur, but it looks like the program is failing to even load at all, so this isn't happening.

The only thing I can suggest is installing the latest version of the .net framework (3.5) (http://www.microsoft.com/downloads/details.aspx?FamilyID=333325fd-ae52-4e35-b531-508d977d32a6&displaylang=en) and hoping for the best.

Alex
Title: Album Art Downloader XUI
Post by: Zoominee on 04 January, 2008, 11:41:47 AM
Hi AlexVallat, ok, I'll try this! For now I'm using the small tool from this thread to retrieve some album art. http://www.hydrogenaudio.org/forums/index....st&p=529261 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=58952&view=findpost&p=529261)
Title: Album Art Downloader XUI
Post by: dd_wizard on 04 January, 2008, 04:05:01 PM
1. OK, odd as it may be in the circumstances you are describing, this is in fact the correct behaviour of the Queue system....

That makes perfect sense now that I know I can reopen the queue manager window.
2. There is no specific PID changing behaviour or anything (I'm not even sure such a thing is possible!)...

There is currently no option to avoid the single instance behaviour and run multiple instances of AAD, sorry. Without this, I can't think of any good way to wait for a specific search to be complete either, as no process will end, only a window will probably close (unless re-used for another search), and it is not programatically obvious which window, either.

I like the single instance a lot!  It minimizes AAD's system resource usage. I did a lot of testing, and at least on Vista, the PID for the AAD process started by my script changes when the original process takes it over. The change for the script spawned process makes sense, because that process dies once the single instance takes over.  I am about 50% confident the PID for the original process changed, too. This change seems odd, so I may have been sleepy while I was testing.

The easiest way I can think of to identify a script invoked window would be to add a command line argument to AAD along the lines of:

/WinTitle "Whatever you like here"

The script is a back end for EAC, so I'd probably use "Album Art Downloader - EACcompressor - %artist% - %album%" for the window title.  Then my script could find the correct window easily.

EDIT: For now, I'm using a temporary file in the destination directory to control AAD's behavior in my script. So the /WinTitle option would be nice, but not urgent.

Thanks,
dd_wizard
Title: Album Art Downloader XUI
Post by: Zoominee on 08 January, 2008, 12:06:49 PM
Hi! I just discovered this program, I have installed it (and NET 3.0) because it looks very promising! But on my computer (Windows XP) it does not start...

Hi, thanks for reporting the error. Unfortunately the information that the error report window contained doesn't say much to me.The only thing I can suggest is installing the latest version of the .net framework (3.5) (http://www.microsoft.com/downloads/details.aspx?FamilyID=333325fd-ae52-4e35-b531-508d977d32a6&displaylang=en) and hoping for the best.

Follow-up: The Microsoft installer for 3.5 failed with an unspecified error message, so the blame must have been with the .NET setup in my computer. I tried to "repair" it with the .NET 3.0 installer, which failed also. The only option I had was to erase the whole .NET stuff with this tool: http://blogs.msdn.com/astebner/archive/200...04/6659905.aspx (http://blogs.msdn.com/astebner/archive/2007/12/04/6659905.aspx) . Then I reinstalled .NET version 3.5.
Now the Album Art Downloader works! Looking forward to trying it out.
Title: Album Art Downloader XUI
Post by: AlexVallat on 08 January, 2008, 01:59:18 PM
... I reinstalled .NET version 3.5.
Now the Album Art Downloader works! Looking forward to trying it out.
Great! Thanks for letting me know.

dd_wizard: I'll consider a /WinTitle parameter but it feels a bit ugly. I might try thinking up something more elegant, perhaps a /wait parameter instead...

Alex
Title: Album Art Downloader XUI
Post by: poisonborz on 13 January, 2008, 01:13:57 PM
Hola,

I've been using the new album art downloader for a few weeks now (another reason to love foobar: great tools on its forum! ) . Let me say that this is the first such program I've been settled, and which worked as it promised... also, you're a quite responsive developer, which is sadly rare, especially in foobar territory... I've encountered several problems along the way, so here's the blacklist (using version 0.10.1.0):


- There's a huge memory leak bug - sometimes (quite randomly, in fact) after dropping files in the File browser, AlbumArt instantly starts to consume several hundred megs of ram (eventually, all) *instantly*. I wish I could give a log file, but when I include the config file to create that, the program doesn't start. log for that attached.
- File browser sometimes doesn't recognize dropped folders/files, even if it has tags.
- Tag guessing could be better, and should be mixed with tag info. An album, which has several artist included (eg. mix cd, features etc) shouldn't show up as a different album when searching for art. A simple check whether the files originate from the same folder should help.
- I think the GUI is a bit confusing at first...couldn't you somehow integrate it more into one window? It's a bit awkward to have at least 3-4 windows open while searching for an art... especially since the default open search window count is set to 3... At least file browser/album search should be integrated into one (along with a file browser, perhaps), so user could make a quick browsing/downloading session without the need to drag&drop, which slows down this process considerably.
- In search window, user should be able to turn the sorting off (or include an option to show new results on the bottom). It happened to me several times that the first few matches were allright, wanted to click on the save button, but in that milisecond a new result appeared, and so I've clicked on the wrong pic...
- On the File Browser, there should be a button to clear the contents of the window. It's a bit of a pain to always open new window/close the previous each time the previous one gets too crowded.
Title: Album Art Downloader XUI
Post by: AlexVallat on 13 January, 2008, 02:26:31 PM

Hello, thank you for your kind comments. Let me reply to your points in order:

Memory Leak Oh dear, that's bad news. I've spent a lot of time trying to track down leaks, and thought I'd got all of them. Unfortunately, to track a leak, I need a loop that returns to the same point, but with less memory. Consuming lots of memory after lots of files have been added to the file browser, while undesirable, doesn't necessarily mean it is leaked, it might just be being used to process those files. It would only be leaked if the memory was not recovered once the files were removed from the list, or the file browser closed. I'll have a look around to see if there is any glaring memory inefficiency in the way that files are added to the browser, though.

If it only happens for certain files, or files added in a certain way, then that would indicate a bug and be a starting point to investigate.

Log file The error log you sent me indicates that the config file was not well formed XML. If you send me the AlbumArt.exe.Config file I can let you know why.

Unrecognized tags Is there a specific file you have that has tags which aren't recognized? If so, please try looking at it with MediaInfo (http://mediainfo.sourceforge.net/), which is what AAD uses internally to read the tags. If that can read Artist and Album tags, but AAD can't, then I will investigate further. In that case it might be helpful if you could send me the file in question.

"Tag guessing could be better, and should be mixed with tag info Sorry, I'm not sure I really understand what you are getting at here. The tags that are read are Artist and Album (as reported by MediaInfo), there is no guessing or other info used.

"A simple check whether the files originate from the same folder should help" That's assuming that each folder contains one album, and there should be only one album image per folder. This is not an assumption I want to limit AAD to making. Various Artists albums are always going to be a bit tricky, as there isn't an easy way to distinguish between that, and a folder full of random singles.

There might be something to be done in this area with Album Artist and Track Artist, but I'm not sure how often a distinction between those fields is actually made.

Multi-window GUI The design to have one window per search is pretty much set in stone now. It would need a pretty fundamental change in architecture to change that, and I don't intend to. Given that constraint, having a separate window for file browser seems the only natural place to put one, given that it could result in several searches.

I'm not sure what you mean about the need to drag and drop - the only time you might use drag and drop would be to drop files on to the browser, and surely that would be the same regardless of whether it was in the same window as the search results or not? Perhaps I'm missing something.

Turning off sorting That makes sense, yes. There would be a performance improvement for not having to sort, too. I'll put it in the next version.

Clearing I'll hook up the Del key to remove selected albums from the list for the next version. Alternatively, if you use the Search button, it will clear the current contents and replace them with what it finds searching the path specified. A quick Search, Esc combination would therefore result in a cleared list :-)

Thanks again for your comments and suggestions,

Alex
Title: Album Art Downloader XUI
Post by: emfletcher on 13 January, 2008, 03:35:30 PM
Hey, thanks for this program.  It works great.  I have a couple suggestions for the next relase.

1.  In the file browser I would love to have the dimensions of the album art.  This way I can sort by dimensions and be able to replace small album art.  If that isn't possible file size might do.
2.When searching an album that already has album art it would be nice to have a picture of the album art you already have with the size underneath it.  Maybe in the source column, above or below the sources.
3.As previously suggested, it would be great to be in one window with tabs.
4.As previously suggested, various artist albums are a pain.  Maybe there could be an option to select 'one album per folder' so it won't search for art for every song of the various artist album.
Title: Album Art Downloader XUI
Post by: poisonborz on 13 January, 2008, 04:39:25 PM


Memory leak For the config file, I've suspected that there's an xml error, but I couldn't do much, since, I've copied the exact code from your post: http://www.hydrogenaudio.org/forums/index....st&p=521325 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=521325)
(For future releases, couldn't you just implement a simple config switch in the file application data/albumart/config?) Anyway, here's the file: http://poisonborz.extra.hu/aaconfig (http://poisonborz.extra.hu/aaconfig)

Unrecognized tags I've been experimenting with tags, here's all I can suspect: since mediainfo reads the tags properly, at first I've suspected that AAD encountered unexpected values. But as it turned out, a simple overwriting/re-saving of (these kind of) tags is enough. Don't know if it's a good idea, but here's a link of an unedited file that did not get recognized (It's a Taj Mahal track):
http://poisonborz.extra.hu/temp.mp3 (http://poisonborz.extra.hu/temp.mp3)
If I download, open it in a tag editor, and save it again, it gets recognized. I hope this helps somehow.

Multi-window GUI  emfletcher's idea about tabs is also great - if multiple windows are necessary, at least they could be enclosed in a multiple tabbed window...

Various Artist albums Maybe the user could set the pattern of the folder structure of his collection... Don't know if I'm right, but there's already something like this in the [albumart_recognizer_path] section of the config file. Maybe a text field in the options of the File Browser, with a simple "scripting language" assisted with buttons.
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 January, 2008, 03:29:39 AM

1: That would slow things down considerably, as it would have to open and read each art file. File size could work, though, it should be fast enough to query the filesystem for that.

2: Existing album art is returned by the Local Files source (as long as you have it checked), and appears in the main search area. There seems to be a bug with the path it searches under when launched from the file browser, though, so I'll try to fix that for the next version.

3: Not going to happen. Writing a container window to hold all the other windows inside it would be a pain to do, and would mean that you couldn't see them side by side, and they'd all have to be the same size. I just don't see the advantage of it.

4: The File Browser is exclusively tag based, not file system based. It would be possible to write another browser which got artist and album information from a path pattern that you could specify, and that's a useful idea for the future. There's no reason that you should be forced to use tags when filenames can contain the same info, so long as a pattern for it can be specified. I'll keep it as a nice-to-have idea, but it won't be coming any time soon.


Config File There was a blank line at the start of that config file, where there shouldn't have been. I've fixed the post you linked so that it doesn't start with a blank line, sorry about that. The very first character in the file should be a <. The reason it is a config file rather than a switch, is that this is functionality built in to the .net CLR, not something specific to AAD. A config file like that works for any .net app.

Unrecognized tags Updating to the latest version of MediaInfo allows me to read that test file, so the next version of AAD (which will use the latest available MediaInfo) should read it too. If you don't want to wait, grab the latest MediaInfo DLL (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.5.7_DLL_Win32.7z), and extract MediaInfo.dll into the AAD program folder, overwriting the existing one.

Alex
Title: Album Art Downloader XUI
Post by: plinni on 15 January, 2008, 06:03:27 AM
This little tool is simply amazing! Thanks for this! But I got one question anyhow. When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 15 January, 2008, 07:25:38 PM
This little tool is simply amazing! Thanks for this! But I got one question anyhow. When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?

Put the band name in both fields.  You'll get a lot of false positives, probably, but you should find your album cover.  Leaving the album name blank is not the way to go.
Title: Album Art Downloader XUI
Post by: plinni on 15 January, 2008, 07:49:25 PM
Yeah I know but what I don't understand is why it's not filled in automatically. It's workin when the album title is different from the band name but otherwise it's not workin when both names are equal.
Title: Album Art Downloader XUI
Post by: TedFromAccounting on 15 January, 2008, 08:24:56 PM
Can anyone write a script for buy.com?  They have a lot of 500x500 images that are often better quality than amazon's.  If i knew anything about scripting i would try myself.
Title: Album Art Downloader XUI
Post by: poisonborz on 19 January, 2008, 03:32:43 PM
Just some additional ideas:

the file browser not refreshing itself (artwork status field) if the Search window option 'close after
saving' is turned on (if that was not working like that before, it should  - in every file browser
window instance, if that is possible)

please re-do somehow the row selection mechanism in the file browser. It's very annoying that eg.
you select 6 row, and a sloppy click somewhere besides the checkbox clears all those selections.
User should be able to click anywhere in a row to check/uncheck that row. There's many occassions when I don't use 'select all albums with missing artwork', and individually selecting multiple rows with only a tiny checkbox is stressful.

Also, rows where album art is found should be highlighted somehow (a slightly different background color perhaps), since in a crowded file browser window it's a bit harder to pay attention to a simple icon/field value.

In the 'specify path to find images' field in file browser, are multiple expressions allowed? I don't quite get the mechanism: does AAD uses the same value to look for an album art, and to name a file on save? (the label on the field is confusing) Since filling in 'Folder.jpg' won't detect 'folder.jpg', nor any other file types...

Also, when can we expect the next version?
Title: Album Art Downloader XUI
Post by: hendo on 20 January, 2008, 02:30:42 AM
FIRST UP GREAT PROGRAM !!! 

Now for my question.... the layout is really intuitive to use.... but

I have no idea HOW i can make it just search ONCE for each album which has no album art, not for each song of the album... ???

I know i can go through and a individually select one song from each album... BUT is there a EASIER way?




I have a little free time now and would love to smash through the art in the next couple of hours.


Cheers for your help guys. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 January, 2008, 03:38:11 AM
When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?

I haven't been able to reproduce this. Could you be more specific about what you are doing? Are you starting from the file browser, or the foobar browser, or the command line?


I'll look into the file browser refreshing issue, that sounds like a bug.

If you want to click anywhere in a row to select, hold down Ctrl to select individual rows, or Shift to select all rows in a range. This is standard selection behaviour. The problem with making click automatically extend the selection is that there is no obvious way of getting the alternative behaviour of clicking to select just what is clicked on. Keeping the normal click to select behaviour means that the alternative click to extend behaviour can still be accessed either through standard keyboard modifiers, or through the checkboxes.

I like the row colour idea, and will see if some subtle shading would look good. Alternatively, you could always sort by the art status.

For the 'specify path to find images' field in file browser, what do you mean by multiple expressions?
Filling in "Folder.jpg" should certainly detect "folder.jpg" as the search is case-insensitive. For other filetypes, try "folder.*" instead. The path (if not absolute) is relative to the audio file the tags were read from, so "folder.jpg" means "folder.jpg in the same folder as the audio file". The placeholder "/**/" can be used to search arbitrary sub-folders, so "./**/folder.jpg" means "folder.jpg in the same folder as the audio file, or any sub-folder of that folder".

When launching a search for an album from the file browser, the default path to save to is automatically filled in as the path to find images for that file browser, on the grounds that if that's where you were expecting to find images, that's where you would like them to go. There's currently a bug that this will include wildcards, but I'll have that fixed for the next version.

You can expect the next version soon. It was going to be today, as I've finished everything that I had planned, but given the above additional changes to make too, it might not be.


Thanks, I'm glad you like it! I'm afraid if each song on your album has a different artist or album title tag, then there is no way to get it to just choose one of those to display in the file browser and ignore the others. If they all have the same artist and album, then only one entry should appear.

There has been a proposal for a filename based browser rather than tag based, which would mean you could define your album and artist by the path to folder rather than the tags in the files, but that won't be in the next release.

Alex
Title: Album Art Downloader XUI
Post by: hendo on 20 January, 2008, 05:46:48 AM
Cheers Alex....

Now that i understand why
.... is there a way where you could search and aggregate all the files which have the same (ALBUM) title and then only display one instance of the duplicate (in the search window).

Not that i know anything about writing code for program.... surely this would be a (relatively) simple task....

I may have even overcomplicated the process...?

Just an idea and i would love to see other peoples opinions on a solution.

Thanks again.   
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 January, 2008, 06:12:25 AM

You are right, this would be a relatively simple task. The question, though, is whether it is the right thing to do.

Album name alone is not enough to uniquely identify an album. For a trivial example, how many albums called "Greatest Hits" do you think there are? If you found it impossible to add both your "Greatest Hits" (Spice Girls) and "Greatest Hits" (The Cure) to the file browser without removing one first, with no indication of why the second one wasn't appearing, you'd probably be pretty upset.

Various Artists albums are always going to be a problem, as I mentioned in a previous post. The only solutions I can think of are insisting on a separate Album Artist tag, or doing a filename/folder-based approach. To be honest, this problem is aggravated by my not owning any Various Artists albums, and my being the only developer on this project at present.

Alex
Title: Album Art Downloader XUI
Post by: poisonborz on 20 January, 2008, 06:18:15 AM
Quote
For other filetypes, try "folder.*"


Besides the already mentioned wildcard bug, how would this work if I set it to folder.jpg, and the file I want to save from search window is a png? Without conversion, it would get an incorrect extension... (it would be a nice feature in a future version, if user would have the ability to set saving extension, with automatic conversion afterwards)
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 January, 2008, 07:15:12 AM
Quote
For other filetypes, try "folder.*"
Besides the already mentioned wildcard bug, how would this work if I set it to folder.jpg, and the file I want to save from search window is a png? Without conversion, it would get an incorrect extension...

Worry not! This case is already handled by the wildcard bug fix, and would appear in the search window as "folder.%extension%", causing the extension used to save the file to be determined by the type of the file being saved.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 January, 2008, 07:51:00 AM
AlbumArt Downloader XUI v0.11 Released

As promised, here is the new version of Album Art Downloader XUI. This version includes various suggested improvements that were requested on this thread:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.0 (http://www.microsoft.com/downloads/details.aspx?familyid=10CC340B-F857-4A14-83F5-25634C3BF043&displaylang=en) (required)
Title: Album Art Downloader XUI
Post by: poisonborz on 20 January, 2008, 12:09:44 PM
The changes are great!
However, I couldn't stop to add some additional notes

In the search window, it would be a nice addition if there would be some sort of progress meter, or at least a download notification area. Sometimes images take way too long to download (I mainly use google images) and  esp. for an average user, watching  a little clock icon for 1 min is not the best indication of stability.

In the queue window, there should be a queue count, displaying the number of items in queue.
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 January, 2008, 12:43:42 PM

Thanks, I'm glad you liked the changes. In answer to your additional notes:

All the progress information that is available to me is displayed in the sources list to the right. Each source which is capable of determining the number of images available before actually downloading them will display a progress bar as they are being downloaded. Until a source responds with this information (usually as a result of parsing the search results it retrieves) there is no progress information to be reported.

I'll probably add a queue count to the next release, but it might not be for a while. The number of windows should be being saved. If it is not, there might be a bug. I'll look into it.

Alex
Title: Album Art Downloader XUI
Post by: Heliologue on 20 January, 2008, 06:11:35 PM
I used this tool successfully last month (0.10.1) to download a bunch of album art.  I just came back to it today and suddenly started getting this error whenever I load the File Browser.  The error occurs in both 0.10.1 and 0.11.0.  I'm running Vista x64, up to date, and .NET 3.5.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: G:\Utilities\album art xui 0.11.0\errorlog.txt

App version: 0.11.0.0, running on Microsoft Windows NT 6.0.6000.0

System.BadImageFormatException: An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B)
   at MediaInfoLib.MediaInfo.MediaInfo_New()
   at MediaInfoLib.MediaInfo..ctor()
   at AlbumArtDownloader.FileBrowser.OnIsVisibleChanged(Object sender, DependencyPropertyChangedEventArgs e)
   at System.Windows.UIElement.RaiseDependencyPropertyChanged(EventPrivateKey key, DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.OnIsVisibleChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.UpdateIsVisibleCache()
   at System.Windows.PresentationSource.RootChanged(Visual oldRoot, Visual newRoot)
   at System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
   at System.Windows.Window.SetRootVisual()
   at System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
   at System.Windows.Window.CreateSourceWindowImpl()
   at System.Windows.Window.ShowHelper(Object booleanBox)
   at System.Windows.Window.Show()
   at AlbumArtDownloader.FileBrowser.AlbumArtDownloader.IAppWindow.Show()
   at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: thuan on 20 January, 2008, 10:45:21 PM
Thank you, your program works fine on my computer. Just that, on first run, the start up time is very slow, and it appears with no theme when I use custom theme on Windows. Other than those, usability this program is great, better than any others I have tried.
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 January, 2008, 02:52:08 AM

From the error log you posted, it looks like MediaInfo can't be loaded on x64. Looking at the MediaInfo site, they have an x64 version available too. Please download MediaInfo_0.7.5.7_DLL_Windows_x64.7z (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.5.7_DLL_Windows_x64.7z) and extract MediaInfo.dll into the Album Art Downloader program folder.



On first run, the program must compile all the .boo scripts for downloading art. It will only do this again if you add, remove, or change any of the scripts.

Custom themes are not supported by WPF. I suspect this is because WPF is a vector-based system, and the old Win32 themes are a bitmap-based system.

Thanks for your comments!

Alex
Title: Album Art Downloader XUI
Post by: Heliologue on 21 January, 2008, 04:25:28 AM
From the error log you posted, it looks like MediaInfo can't be loaded on x64. Looking at the MediaInfo site, they have an x64 version available too. Please download MediaInfo_0.7.5.7_DLL_Windows_x64.7z (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.5.7_DLL_Windows_x64.7z) and extract MediaInfo.dll into the Album Art Downloader program folder.


Alex


I could have sworn I ran it successfully on Vista x64 before, but I've been switching operating systems a lot lately, so I guess my memory failed me.  In any case, it all seems to work ok with the x64 version of MediaInfo.  Much obliged;  also, wonderful little program you have here.
Title: Album Art Downloader XUI
Post by: radi0n on 21 January, 2008, 09:26:14 AM
Great program!

It is possible to select album in foobar then in context menu IN foo download the album art via Album Art Downloader?
Title: Album Art Downloader XUI
Post by: mobyduck on 21 January, 2008, 11:52:15 AM
@radi0n: try searching for foo_run inside this thread.

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: Wirrunna on 21 January, 2008, 10:33:06 PM
Great work - thank you AlexVallat !

(I use Album Art Aggregator to list the albums without art work and Album Art Downloader to find the missing coves)
Title: Album Art Downloader XUI
Post by: plinni on 22 January, 2008, 02:18:57 PM
When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?

I haven't been able to reproduce this. Could you be more specific about what you are doing? Are you starting from the file browser, or the foobar browser, or the command line?



Hi,

I'll show you what I mean. I'm using the foo flow design and this path:
Quote
"C:\Programme\foobar2000\AlbumArtDownloader\AlbumArt.exe" "%artist%" "%album%"


1. Push the button:
(https://hydrogenaud.io/imgcache.php?id=bd9c96a312184052dfadd7049747def5" rel="cached" data-warn="External image, click to view at original size" data-url="http://trabifant.dirker.org/Sammelplatz/cover_1.jpg)

2. AlbumArtDownloader opens:
(https://hydrogenaud.io/imgcache.php?id=dd1bc3502bf6c2fd7f69d77a90e07d74" rel="cached" data-warn="External image, click to view at original size" data-url="http://trabifant.dirker.org/Sammelplatz/cover_2.jpg)

I don't know what to do with that.
Title: Album Art Downloader XUI
Post by: AlexVallat on 22 January, 2008, 02:56:35 PM
I'll show you what I mean. I'm using the foo flow design and this path: "C:\Programme\foobar2000\AlbumArtDownloader\AlbumArt.exe" "%artist%" "%album%"

Thank you for reporting this bug, plinni. I can confirm it, and it will be fixed for the next version.

Until then, you can work around it by changing your path to:
"C:\Programme\foobar2000\AlbumArtDownloader\AlbumArt.exe" /artist "%artist%" /album "%album%"

Alex
Title: Album Art Downloader XUI
Post by: plinni on 22 January, 2008, 08:17:47 PM
Thx for the quick help. Amazing!
Title: Album Art Downloader XUI
Post by: phunkydizco on 26 January, 2008, 06:02:11 AM
I have updated from 0.9 to 0.11 and the first thing I disliked is that the font is very blurred instead of the default windows font. In the screenshot the font of foobar2000 is very clear and album art downloader totally blurred.

(https://hydrogenaud.io/imgcache.php?id=2f084aab85ddfa78d2ecbad8ea2e0dce" rel="cached" data-warn="External image, click to view at original size" data-url="http://img175.imageshack.us/img175/6381/ablumartdownloaderxj5.th.jpg) (http://img175.imageshack.us/my.php?image=ablumartdownloaderxj5.jpg)

I suppose that album art downloader now is a WPF application and that causes this effect. I haven't developed with WPF yet, but I think that there is a possibility to fix that.
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 January, 2008, 11:09:32 AM
I suppose that album art downloader now is a WPF application and that causes this effect. I haven't developed with WPF yet, but I think that there is a possibility to fix that.

It's called anti-aliasing, is part of how the WPF framework draws itself, and as far as I can tell, there is no way to turn it off (http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=319013&SiteID=1), sorry. The best I can offer is that it doesn't look so bad if you have ClearType turned on for the system, which isn't really a solution, I know.

Anti-aliasing and clear-type seems to be in fashion at the moment, although I've got to say I'm more in agreement with you that font-fuzzing is not the great step forwards it is made out to be.

Alex
Title: Album Art Downloader XUI
Post by: Nii2 on 26 January, 2008, 11:18:21 AM
Hi,

I hace a little issue with scrolling, it's very very slow. I don't understand why, any help would be appreciate.
Thanks in advance
Title: Album Art Downloader XUI
Post by: phunkydizco on 26 January, 2008, 12:31:53 PM
The best I can offer is that it doesn't look so bad if you have ClearType turned on for the system, which isn't really a solution, I know.

I have already turned ClearType on. Also the screenshot was made with activated ClearType. I think this anti-aliasing thing is very strange. Perhaps WPF should not be used for a classic window based application. For a theme based application like the new Yahoo! Messenger it could make sense.
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 January, 2008, 01:38:29 PM
AlbumArt Downloader XUI v0.12 Released

Another new version of Album Art Downloader XUI, coming sooner than usual on the heels of the last release. I've added a couple more suggested improvements that were requested on this thread, plus a new feature I've been thinking about for a while, a pure command line interface.

As proud as I am of the UI I've created for Album Art Downloader XUI, I appreciate that sometimes it just gets in the way. That's why, as of version 0.12, I've included a command-line only interface, called aad.exe. This is an optional part of the install, but if you choose to use it then it supports mostly the same parameters as the full AlbumArt.exe. It will download a single result and save it without any further interaction. A /sequence parameter can be used to tell it to download a result other than the first. This can be used to implement "try again" type behaviour, in case the first result was no good.

I'd recommend using it with the /sources parameter to specify the sources to search (and the order to search them), as if the first source searched returns a result, that's the one that will be used.

A couple of additional parameters to help get that first result right have been added, /minSize and /maxSize allow the restriction of results by image (pixel) size.

As it is an initial release of the command line UI, I hope you give it a try and let me know if you find it useful, or how it might be improved to be more useful.

Also, note that I've upgraded to .NET Framework 3.5. If you still only have 3.0 installed, now's the time to download the update from the link provided below.

Ful llist of changes:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
Title: Album Art Downloader XUI
Post by: Jonas Nyrup on 27 January, 2008, 04:56:51 PM
Can Album Art Downloader XUI automatically search a folder for artists and download album art to the respective album folders?
I haven't found a function so far.
Title: Album Art Downloader XUI
Post by: Heliologue on 27 January, 2008, 09:08:16 PM
Can Album Art Downloader XUI automatically search a folder for artists and download album art to the respective album folders?
I haven't found a function so far.



I don't think it downloads the art automatically because it searches many different sources.  You can, however, launch the "File Browser," point it to a folder, and it will search all the subfolders a return a list of artists/albums, and you can select them for searching.  If you "save" a picture in this manner, it should be saved to the appropriate folder.
Title: Album Art Downloader XUI
Post by: IAmSoBald on 27 January, 2008, 11:01:49 PM
After downloading the cover, exactly what do I do to make it show up in my playlist? Also, how do I get it to work with AAC files? Sorry, but I'm a total noob at this and I don't want to go through 7 pages at 11:00.
Title: Album Art Downloader XUI
Post by: AlexVallat on 28 January, 2008, 03:00:25 AM
After downloading the cover, exactly what do I do to make it show up in my playlist? Also, how do I get it to work with AAC files? Sorry, but I'm a total noob at this and I don't want to go through 7 pages at 11:00.

It depends on which UI you are using for foobar. The following threads might help:

[a href='index.php?showtopic=58322']Album art support in 0.9.5 (thread split)[/a]
[a href='index.php?showtopic=39924']updated foo_uie_albumart[/a]
PanelsUI and the Single Column Playlist can also make use of album art.

There shouldn't be any specific issue with AAC files, unless you mean you want to embed the image within them. If so, then that is not supported, sorry.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 28 January, 2008, 03:01:21 AM
You should be able to show album art if you use Default UI of foobar 0.9.5 (there's an album art UI element provided) or with foo_uie_albumart that provides Album art panel if you use Column UI or a few lines of code if you use Panel UI. For specifically how to do it in each way, please use search. There're threads for them already.

EDIT: WOW, Alex was faster.
Title: Album Art Downloader XUI
Post by: IAmSoBald on 28 January, 2008, 09:50:59 PM
I use Radecke with Panel UI, but I don't know how to add album art after downloading. Right-clicking the columns doesn't give me any options regarding the album art besides downloading it with Coverdownload. It doesn't load automatically. I really can't find anything related to this, the search tool is poor. Here's the URL for the skin I'm using.

http://www.neugablonz.de/index.php?seite=foobar1 (http://www.neugablonz.de/index.php?seite=foobar1)
Title: Album Art Downloader XUI
Post by: teNtiOn on 29 January, 2008, 04:15:57 AM
Is this plugin only works for amazon.com? Do it works for other country's amazon like amazon.co.jp?
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 January, 2008, 04:36:26 AM
Is this plugin only works for amazon.com? Do it works for other country's amazon like amazon.co.jp?
Scripts for amazon web services (US based, I think) and amazon.de are included. [a href='index.php?showtopic=57212']This guy[/a] wrote an interesting multi-threaded amazon.co.jp one, you might like to try out.

IAmSoBald: Are you sure you've put the path in correctly in the foo_run command, modifying it to where you have foobar 2000 installed? For example, if you have it at c:\program files\foobar2000, then according to http://www.neugablonz.de/foobar2000/foo_run.jpg (http://www.neugablonz.de/foobar2000/foo_run.jpg) it should end in: "c:\program files\foobar2000\albumart\%artist%.%album%.folder.jpg"

Alex
Title: Album Art Downloader XUI
Post by: Useless Warrior on 02 February, 2008, 10:48:57 PM
Sorry if this has already been posted, but since I don't see it mentioned anywhere I noticed that Clamwin is reporting adware when I scan the installer of 0.12, is this a known issue?
Title: Album Art Downloader XUI
Post by: AlexVallat on 03 February, 2008, 04:04:47 AM
Sorry if this has already been posted, but since I don't see it mentioned anywhere I noticed that Clamwin is reporting adware when I scan the installer of 0.12, is this a known issue?

No, not a known issue. I can assure you that I have not put any adware in it, if that's any help. I think it's a false positive with ClamWin, and have submitted it to them for analysis. Meanwhile, I've uploaded a repackaging of the installer (which also includes a minor uninstall bugfix) and ClamWin seems happy with it.

Thanks for reporting it,

Alex
Title: Album Art Downloader XUI
Post by: vader897 on 03 February, 2008, 09:54:07 PM
I have run into a little problem with using album art downloader and foo run.  I have set up my run command to be. 
Code: [Select]
P:\Program Files '('x86')'\foobar2000\AlbumArtDownloaderXUI-0.12\AlbumArt.exe "%artist%" "%album%" "$replace(%path%,%filename_ext%,folder.jpg)"

The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.
Can you guess what the problem is?  For example a song with

album : Wishes In The Night "Part Two: Of Passion and Serenity"

When i run the script the Album Art Command Line Parameters window opens up and says
Quote
>"P:\Program Files (x86)\foobar2000\AlbumArtDownloaderXUI-0.12\AlbumArt.exe" "Nightwish" "Wishes In The Night "Part Two: Of Passion and Serenity"" "U:\Audiopholder\Metal, Rock, Alternative etc\__Metal\_Symphonic Power Metal\Nightwish\Of Passion and Serenity\folder.jpg"

Album Art Downloader XUI version 0.12.0.0

**** Only the first three parameters may be un-named ****


The problem is that albumart.exe thinks part of the album is a paremeter.

Any ideas on how I can solve this to make my albumart.exe handle these cases properly?
Title: Album Art Downloader XUI
Post by: AlexVallat on 04 February, 2008, 03:50:32 AM
The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.

If parameters have " marks in them, then those marks must be escaped. I think this can be done by using $replace(%artist%,",\"), but someone with better titleformatting skills might be able to give you a better answer. In any case, you are looking to add a \ before every " in the artist and album.

Alex
Title: Album Art Downloader XUI
Post by: kanak on 04 February, 2008, 11:01:44 PM
Alex,

thank you very much for this wonderful utility... it's very useful and it's saved me countless hours. The integration with foobar through COM Automation is fantastic (I can't believe I just discovered it), but i have a couple of suggestions which would make it even better:

1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

2. Would it be possible for you to cache the results so that the next time the foobar browser is run, it doesn't recheck all the albums for which art exists?


Thanks again for this wonderful utility.
Title: Album Art Downloader XUI
Post by: AlexVallat on 05 February, 2008, 03:50:54 AM
Alex,

thank you very much for this wonderful utility... it's very useful and it's saved me countless hours. The integration with foobar through COM Automation is fantastic (I can't believe I just discovered it), but i have a couple of suggestions which would make it even better:

1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

2. Would it be possible for you to cache the results so that the next time the foobar browser is run, it doesn't recheck all the albums for which art exists?


Thanks again for this wonderful utility.

Good suggestions. I'm not sure how well populated Album Artist is, but if I can get it in a way that will fall back to Artist if it isn't, it's probably safe to use that instead. I can't think of a good reason to prefer Artist over Album Artist if both are populated.

I'll look into caching, but it would probably not make a huge amount of difference if you have a strict image path format, as it would still have to check for the existence of the last known image file (to see if it had been moved or deleted since caching), and that would take just as long as checking for 'folder.jpg', for example. It would help a lot for fuzzy image path formats, like c:\art\unsorted\**\*.jpg, though...

Alex
Title: Album Art Downloader XUI
Post by: thuan on 05 February, 2008, 05:19:18 AM
The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.

If parameters have " marks in them, then those marks must be escaped. I think this can be done by using $replace(%artist%,",\"), but someone with better titleformatting skills might be able to give you a better answer. In any case, you are looking to add a \ before every " in the artist and album.

Alex


I have the same problem but with hyphen "-". Using the same trick it passes \- over too, any idea?
Title: Album Art Downloader XUI
Post by: AlexVallat on 05 February, 2008, 05:51:41 AM
I have the same problem but with hyphen "-". Using the same trick it passes \- over too, any idea?

Hyphens should not need any escaping. Could you give me an example of a command line that fails, and I will look into it.

Alex
Title: Album Art Downloader XUI
Post by: alwaysdub on 05 February, 2008, 06:23:34 AM


1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

Good suggestions. I'm not sure how well populated Album Artist is, but if I can get it in a way that will fall back to Artist if it isn't, it's probably safe to use that instead. I can't think of a good reason to prefer Artist over Album Artist if both are populated.



Alex,

By default in titleformatting if %album artist% is not populated it will fall back to %artist%, so I would assume this will be no problem, and would be a useful enhancement.

Thanks for all your work on this component.
Title: Album Art Downloader XUI
Post by: thuan on 05 February, 2008, 07:46:39 AM
Here you are:
Code: [Select]
"D:\Program Files\AlbumArtDownloader\AlbumArt.exe" /artist "-zann-" /album "Samurai from East" /path "D:\Music\Game Music\01\_Touhou_related\-zann-\Samurai from East\front.jpg"


and your program gave this error "**** Unexpected command line parameter: zann- ****"

EDIT: It crashes with this command line
Code: [Select]
D:\Program Files\AlbumArtDownloader\AlbumArt.exe /artist "一青窈" /album "受け入れて" /path "***\front.jpg"
and here's the log in event log
Code: [Select]
EventType clr20r3, P1 albumart.exe, P2 0.12.0.0, P3 479cc933, P4 system, P5 2.0.0.0, P6 471ebf0d, P7 1be, P8 15, P9 system.argumentoutofrange, P10 NIL.

Well this is likely AmazonJPMultithread fault though as it doesn't crash when I disable it.
Title: Album Art Downloader XUI
Post by: AlexVallat on 05 February, 2008, 07:51:49 AM

Thanks. I can confirm this bug as occurring with parameter values starting with a hyphen, or a /. Hyphens elsewhere are not a problem. I will fix this for the next release.
Title: Album Art Downloader XUI
Post by: dubpistol on 08 February, 2008, 01:32:40 PM
Is there a way to handle compilations with different track-artists?

IMO the file-browser should look first if album-artist is present, and if not, than take the artist.

BTW: Great application
Title: Album Art Downloader XUI
Post by: Max Spicer on 08 February, 2008, 03:26:53 PM
Is there a way to handle compilations with different track-artists?

IMO the file-browser should look first if album-artist is present, and if not, than take the artist.

BTW: Great application


I don't think I tag any of my various artist albums to indicate that they are various artists.  I mainly use SlimServer against my music, and it manages to work out that all the tracks belong to one album.  I'm guessing it does this either by the fact that the album name is the same (could easily go wrong) or by the fact that the tracks all live in the same directory.  Could Album Art Downloader employ similar logic?

By the way, would it be possible to add a mode that ran simply from the directory structure, rather than the files within it?  I'm running across a wireless network, so the program is having to pull all my flac files across to examine their tags.  However, the information it needs is mainly in the directory structure.  For example:

Music
- CDs
- - The Beatles
- - - Revolver
- - - - 01.flac
- - - - 02.flac

From the above, you can deduce that I have Revolver by The Beatles without having to examine the flac files themselves.  The presence of flac files in a directory shows that it's an album.  There are obviously situations when the user would want you to look at the tags themselves, but this option would greatly speed things up for me at least, as well as opening up currently unsupported formats a bit.

Max
Title: Album Art Downloader XUI
Post by: AlexVallat on 09 February, 2008, 03:43:02 AM
IMO the file-browser should look first if album-artist is present, and if not, than take the artist.
I've already got this on the list to look into. It seems certainly possible for the foobar browser, but it isn't looking likely for the file browser. There does not appear to be any standard Album Artist tag.

Would it be possible to add a mode that ran simply from the directory structure, rather than the files within it?
I've posted earlier about the possibility of adding a new browser which works on pattern matching the file paths rather than reading the tags from them. You would specify something like "%artist%\%album%\*.flac", for example. It gets trickier if you have paths which include other data, like the year. You might need "%artist%\(*) %album%\*.flac", for example. I'm really hoping not to have to extend it to regular expressions, hopefully wildcards would suffice.

It would be a fairly large piece of work, though, so I probably won't get round to it for a while - I'd rather get all the little things (like the album artist stuff, and hyphen parameter bug) sorted and released before considering a new feature like that.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 February, 2008, 06:24:19 AM
AlbumArt Downloader XUI v0.13 Released

This release is mostly a bug-fixing update. The following issues have been fixed:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 10 February, 2008, 08:10:02 PM
Thanks for the great program Alex. The latest version and also the last few versions have been working beautifully. %AlbumArtist% organization is a nice change. That way it will not scatter for a multi-artist disc. I believe this is how the Folder.jpg is also saved in My Pictures, in Album Art\%AlbumArtist%\%Album% structure? 

In an attempt to show my appreciation of the program, I have added support in iTSfv (http://www.hydrogenaudio.org/forums/index.php?showtopic=51708) to look for AAD saved artwork so iTunes/iTSfv users have another automatic artwork source for adding Artwork to iTunes.

5.40.1.0 iTSfv will look for artwork saved using Album Art Downloader

Code: [Select]
20080211T094900 Job Started: VALIDATE_TRACKS_SELECTED
20080211T095116 Found 1 sources of Artwork
20080211T095121 Artwork from [b]AAD[/b] as G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg with 1620x1579
20080211T095129 Choosing G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg as the best Artwork
20080211T095131 Added Artwork to D:\Music\Da Buzz\Greatest Hits\01 Alive.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095133 Added Artwork to D:\Music\Da Buzz\Greatest Hits\02 Take All My Love.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095135 Added Artwork to D:\Music\Da Buzz\Greatest Hits\03 Dangerous.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095136 Added Artwork to D:\Music\Da Buzz\Greatest Hits\04 Do You Want Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095138 Added Artwork to D:\Music\Da Buzz\Greatest Hits\05 Tonight (Is The Night).mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095139 Added Artwork to D:\Music\Da Buzz\Greatest Hits\06 Wonder Where You Are.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095141 Added Artwork to D:\Music\Da Buzz\Greatest Hits\07 Without Breaking.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095143 Added Artwork to D:\Music\Da Buzz\Greatest Hits\08 Last Goodbye.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095144 Added Artwork to D:\Music\Da Buzz\Greatest Hits\09 Wanna Be With Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095146 Added Artwork to D:\Music\Da Buzz\Greatest Hits\10 How Could You Leave Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095148 Added Artwork to D:\Music\Da Buzz\Greatest Hits\11 Paradise.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095149 Added Artwork to D:\Music\Da Buzz\Greatest Hits\12 Let Me Love You.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095151 Added Artwork to D:\Music\Da Buzz\Greatest Hits\13 Baby Listen To Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095152 Added Artwork to D:\Music\Da Buzz\Greatest Hits\14 Take A Chance.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095154 Added Artwork to D:\Music\Da Buzz\Greatest Hits\15 Don't You Ever Leave Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Added Artwork to D:\Music\Da Buzz\Greatest Hits\16 Da Buzz Club Mix.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Artwork.jpg
20080211T095157 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\AlbumArtSmall.jpg
20080211T095157 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Da Buzz - (2007) Greatest Hits.jpg
20080211T095157 Export Artwork Pass 2 Finished.
20080211T095158 .
20080211T095158 Log saved in G:\Users\McoreD\Documents\iTSfv\Logs\tracks-200802-artwork-added.txt
20080211T095158 Duration: 0 Hours 02 Minutes 58.025715 Seconds
20080211T095158 Cleaning Temporary Files... in G:\Users\McoreD\AppData\Roaming\iTSfv\
20080211T095159 Job Finished: VALIDATE_TRACKS_SELECTED

Keep up the great work!

Cheers,
McoreD
Title: Album Art Downloader XUI
Post by: drbeachboy on 10 February, 2008, 09:49:42 PM
Hi Alex,



If AAD is supposed to work with fb2k, then why are you using "albumartist" instead of "album artist", which is a fb2k tag? Is there any chance of adding it, along with "date"? Thanks for all of your work on AAD, it is much appreciated.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 February, 2008, 03:20:36 AM
Hi McoreD, thanks for your comments, and for adding support to your excellent iTSfv! I should point out that the  syntax for specifying where to save images to hasn't changed, though, it is still just %artist%, meaning the artist that was searched for in Album Art Downloader (which may or may not be an album artist, no distinction is made).

If AAD is supposed to work with fb2k, then why are you using "albumartist" instead of "album artist", which is a fb2k tag? Is there any chance of adding it, along with "date"? Thanks for all of your work on AAD, it is much appreciated.

I'm not. The foobar browser reads the result of titleformatting "%album artist%". Date is not read - what would you want it to do with it, just display it in a column in the browser?

Alex
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 11 February, 2008, 12:52:11 PM
the newst version 0.13 just refuses to start for me  (0.12 worked fine with same settings)

this error msg i get (but there are some localized strings in it so it will be probably hardly readable )

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: c:\Program Files\___mp3\foobar2000\albumart\errorlog.txt

App version: 0.13.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.IO.FileNotFoundException: Nelze načíst soubor nebo sestavení System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 nebo jeden z jejich závislých prvků. Systém nemůže nalézt uvedený soubor.
Název souboru: System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
   v AlbumArtDownloader.Arguments..ctor(String[] args, IEnumerable`1 valuedParameters)
   v AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
   v AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   v System.Windows.Application.<.ctor>b__0(Object unused)
   v System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   v System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   v System.Windows.Threading.DispatcherOperation.InvokeImpl()
   v System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   v System.Threading.ExecutionContext.runTryCode(Object userData)
   v System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   v System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   v System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   v System.Windows.Threading.DispatcherOperation.Invoke()
   v System.Windows.Threading.Dispatcher.ProcessQueue()
   v System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   v MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   v MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   v System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   v System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   v System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   v System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   v MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   v MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   v System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   v System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   v System.Windows.Threading.Dispatcher.Run()
   v System.Windows.Application.RunInternal(Window window)
   v System.Windows.Application.Run(Window window)
   v System.Windows.Application.Run()
   v AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   v AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   v AlbumArtDownloader.App.Main(String[] args)

WRN: Protokolování vazeb sestavení je VYPNUTO.
Chcete-li povolit protokolování chyb vazeb sestavení, nastavte hodnotu registru [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) na hodnotu 1.
Poznámka: Protokolování chyb vazeb sestavení ovlivňuje výkon systému.
Chcete-li tuto funkci vypnout, odeberte z registru hodnotu [HKLM\Software\Microsoft\Fusion!EnableLog].

ive tried windows update but there arent any .net updates i dont have... any help?
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 February, 2008, 01:44:14 PM
ive tried windows update but there arent any .net updates i dont have... any help?

This looks a lot like not having .net framework 3.5 installed - perhaps you have only 3.0? Try installing 3.5 from here (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6).

Alex
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 11 February, 2008, 02:09:49 PM
This looks a lot like not having .net framework 3.5 installed - perhaps you have only 3.0? Try installing 3.5 from here (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6).

Alex


thx for quick help. i was almost sure that i have .net 3.5 installed so i tried to reinstall it and now everything is working thx.
probably i smehow damaged it and didnt even know about it.
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 13 February, 2008, 06:01:08 PM
Hi Alex,

I discovered some unexpected behavior which you can easily fix.

I searched:

Artist: Raff
Album: Self Control / Running Away


The results are fine. I managed to find the artwork!

The folder path where the Folder.jpg is saved is however

Pictures\Album Art\Raff\Self Control\Running Away\Folder.jpg

Expected Output:

Pictures\Album Art\Raff\Self Control _ Running Away\Folder.jpg



So it seems to me the illegal characters in Album Name string are not replaced to File System friendly characters.

Double checked with another test:

---------------------------
Album Art Downloader
---------------------------
Could not save image 'G:\Users\McoreD\Pictures\Album Art\ABBA\Gold: Greatest Hits\Folder.jpg':

The given path's format is not supported.
---------------------------
OK 
---------------------------

Here is a function that you could use for the Album Name, (may be also for Artist Name) just prior to saving the Image to File System.

Code: [Select]
     public string mfGetLegalTextForDirectory(string txt)
{
    
     txt = txt.Replace("/", "_");
     txt = txt.Replace(":", "_");
     txt = txt.Replace("*", "_");
     txt = txt.Replace("?", "_");
     txt = txt.Replace(Strings.Chr(34), "_");
     txt = txt.Replace("<", "_");
     txt = txt.Replace(">", "_");
     txt = txt.Replace("|", "_");
    
     return txt;
    
}


iTunes replaces all the illegal characters to "_" so to maintain interoperability could you also please use underscore to replace illegal characters?

Thanks,
McoreD
Title: Album Art Downloader XUI
Post by: dubpistol on 14 February, 2008, 01:31:43 AM
  • Changed foobar browser to use %album artist% instead of %artist%

Great improvement. Thank you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 February, 2008, 03:27:25 AM
illegal characters in Album Name string are not replaced to File System friendly characters.
<snip/>
iTunes replaces all the illegal characters to "_" so to maintain interoperability could you also please use underscore to replace illegal characters?

Yes. I'll do that this weekend.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: FavioD on 16 February, 2008, 10:19:01 PM
I can't seem to figure out why after updating my album art, my previously working foo_run command doesn't seem to work:

"C:\Program Files '('x86')'\AlbumArtDownloader\AlbumArt.exe" /ar %artist%" /al "%album%" /p "$replace(%_path%,%_filename_ext%,)cover.'%extension%'"


Every time I do that the "Album Art download command parameters" pops up.
Title: Album Art Downloader XUI
Post by: kanak on 16 February, 2008, 10:50:50 PM
Hi Alex,

thanks for adding album artist support .

I have one question regarding COMServer: Can you use it to query the contents of a playlist in foobar (instead of querying the media library)? If this was possible, i could just have it query the contents of the "new albums" playlist and automatically get art for them.

If this is not possible (or is too much work to implement), please disregard the request.
Title: Album Art Downloader XUI
Post by: AlexVallat on 17 February, 2008, 03:04:45 AM
<snip> /ar %artist%" <snip>

Looks like you're missing a " mark there, that should be "%artist%". If that was just a typo copying to the forum, then please copy the first 3 or 4 lines of the error popup which should contain the command line passed to it and the error message.

Can you use it to query the contents of a playlist in foobar (instead of querying the media library)?

Yes, that sounds like a good idea. I'll add that into the next version. The foobar browser will have a drop-down for picking either All Media, or one of the playlists.

Alex
Title: Album Art Downloader XUI
Post by: FavioD on 17 February, 2008, 09:55:54 PM
<snip> /ar %artist%" <snip>

Looks like you're missing a " mark there, that should be "%artist%". If that was just a typo copying to the forum, then please copy the first 3 or 4 lines of the error popup which should contain the command line passed to it and the error message.


Woooooooooooooooooow, I was missing a quotation mark, thanks for proof reading. I feel terrible.

edit:
Great program !
Title: Album Art Downloader XUI
Post by: Tich on 18 February, 2008, 04:45:24 PM
A crash just occured while running from foo_run (latest version) with the following arguments:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /ar "%album artist%" /al "%album%" /p "$replace(%_path%,%_filename_ext%,)'%artist%' - '%album%' - Front.'%extension%'"

The first time this crash appeared.

edit: on album Fresh Cream by artist Cream

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.13.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.FormatException: Input string was not in a correct format.
   at System.Text.StringBuilder.FormatError()
   at System.Text.StringBuilder.AppendFormat(IFormatProvider provider, String format, Object[] args)
   at System.String.Format(IFormatProvider provider, String format, Object[] args)
   at AlbumArtDownloader.ArtSearchWindow.AlbumArtDefaultFilePathPatternSubstitution.Convert(Object value, Type targetType, Object parameter, CultureInfo culture)
   at System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
   at System.Windows.Data.BindingExpression.Activate(Object item)
   at System.Windows.Data.BindingExpression.AttachToContext(AttachAttempt attempt)
   at System.Windows.Data.BindingExpression.AttachOverride(DependencyObject target, DependencyProperty dp)
   at System.Windows.Data.BindingExpressionBase.OnAttach(DependencyObject d, DependencyProperty dp)
   at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
   at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
   at System.Windows.Data.BindingOperations.SetBinding(DependencyObject target, DependencyProperty dp, BindingBase binding)
   at AlbumArtDownloader.ArtSearchWindow.BindAlbumArtDefaultFilePath(AlbumArt art)
   at AlbumArtDownloader.ArtSearchWindow.OnResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   at System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   at System.Collections.ObjectModel.Collection`1.Add(T item)
   at AlbumArtDownloader.Sources.OnSourceResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   at System.Collections.ObjectModel.Collection`1.Add(T item)
   at AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass9.<Add>b__7()
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   at System.Delegate.DynamicInvokeImpl(Object[] args)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)

Title: Album Art Downloader XUI
Post by: AlexVallat on 19 February, 2008, 03:09:09 AM
A crash just occured <snip />

From that error log, I suspect I know what the problem is - could you check if the path to that album includes { or } characters please? If it does, then there is currently a known bug with paths including those characters, a fix for which will be included in the next version. If not, then please let me know the full path to the album so I can figure out if something else has gone wrong.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Tich on 19 February, 2008, 05:25:42 AM
You are right, the path includes { and }:
Code: [Select]
U:\Cream - Fresh Cream (1966) [FLAC] {DCC Gold Steve Hoffman remaster}

Thanks for the quick reply, I was probably too stoned to search the forum thread for the answer if you had given it already.
Title: Album Art Downloader XUI
Post by: thuan on 20 February, 2008, 05:03:11 AM
Crash report: I had one instance of AlbumArtDownloader XUI then I launch another using foobar. Before the new instance show up, I closed the old one and it crashed. Here's the error log:
Code: [Select]
App version: 0.13.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ServiceModel.FaultException: The server was unable to process the request due to an internal error.  For more information about the error, either turn on IncludeExceptionDetailInFaults (either from ServiceBehaviorAttribute or from the <serviceDebug> configuration behavior) on the server in order to send the exception information back to the client, or turn on tracing as per the Microsoft .NET Framework 3.0 SDK documentation and inspect the server trace logs.

Server stack trace:
   at System.ServiceModel.Channels.ServiceChannel.ThrowIfFaultUnderstood(Message reply, MessageFault fault, String action, MessageVersion version, FaultConverter faultConverter)
   at System.ServiceModel.Channels.ServiceChannel.HandleReply(ProxyOperationRuntime operation, ProxyRpc& rpc)
   at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout)
   at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs)
   at System.ServiceModel.Channels.ServiceChannelProxy.InvokeService(IMethodCallMessage methodCall, ProxyOperationRuntime operation)
   at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(IMessage message)

Exception rethrown at [0]:
   at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
   at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
   at AlbumArtDownloader.IPriorInstance.Signal(String[] parameters)
   at AlbumArtDownloader.InstanceMutex.QueryPriorInstance(String[] args, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 February, 2008, 05:30:30 AM
Crash report: I had one instance of AlbumArtDownloader XUI then I launch another using foobar. Before the new instance show up, I closed the old one and it crashed. Here's the error log:

Thanks for reporting this. It seems to be a case of extremely unlucky timing, but I'll see what I can do about mitigating it so it won't crash under those circumstances.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 21 February, 2008, 02:30:08 AM
I am finding more and more use of this excellent app: Album Art Downloader XUI. In iTunes I got iTSfv to pass Artist and Album information to Album Art Downloader XUI to search for Artwork. AAD saves it as Folder.jpg and when you validate the album in iTunes, the artwork is detected and embedded to tracks.

Thanks again Alex!

Looking forward to a release from you with the previous folder name fixes.
Title: Album Art Downloader XUI
Post by: AlexVallat on 22 February, 2008, 02:35:50 PM
AlbumArt Downloader XUI v0.14 Released

Some fairly big new features added this time round. As has been much requested, it is now possible to use a file path pattern to determine Artist and Album information instead of using tags. Another request was to be able to search just a specific playlist from Foobar, rather than the whole library, so I've added a playlist picker to the Foobar browser. Of course, you can still choose Entire Library there.

To use the file path pattern thing, start the File Browser as usual, and click the Options link. There are now two additional options, which you can use to choose between Tags or File Path Pattern Matching. If you choose the pattern matching option, there is also a box where you can enter the pattern your files are named by, for example \%artist%\%album%\* would match against c:\music\muse\showbiz\01. Sunburn.mp3 as Artist = muse, Album = showbiz. Or, to use an example from a few posts earlier, U:\Cream - Fresh Cream (1966) [FLAC] {DCC Gold Steve Hoffman remaster} could be matched by \%artist% - %album% (*\*. If you've got a really freaky naming scheme which can't be covered by just * and ? wildcards, then you can include literal regular expression code in the pattern in between " marks. For example, the previous pattern could be improved as \%artist% - %album% ("\d{4}")*\* to avoid problems with albums with ( characters in. If you don't want to use the built-in %artist% substitutions, any regex capturing group named artist (or album) can be used.

If you have a freaky naming scheme, and you don't know regular expressions, and you really don't want to use tags, then post some examples of your paths here and someone who does know regular expressions can probably help you out.

The file path pattern matching is generally much, much faster than tag matching, but may be less reliable, depending on how well organised your collection is.

I've also fixed the following bugs:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
Title: Album Art Downloader XUI
Post by: kanak on 22 February, 2008, 03:51:21 PM
Wow. Thanks for the excellent release! The playlist browser is a godsend. 
Title: Album Art Downloader XUI
Post by: thuan on 24 February, 2008, 03:13:02 AM
Crash report: when I open up a preview and foobar browser then I turn off the preview window and foobar browser in order, it crashed. Foobar Com Automation component is not installed on my computer. Here's the errorlog:
Code: [Select]
App version: 0.14.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.NullReferenceException: Object reference not set to an instance of an object.
   at AlbumArtDownloader.FoobarBrowser.OnClosed(EventArgs e)
   at System.Windows.Window.WmDestroy()
   at System.Windows.Window.WindowFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)

Also, when I open more than 2 albumartdownloader window and close the older ones sometimes make the currently running one hang. On some occasion it recovers after a while and most of the time not. All albumartdownloader instances I launch are from foobar run service component.
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 03:28:53 AM
Crash report: when I open up a preview and foobar browser then I turn off the preview window and foobar browser in order, it crashed. Foobar Com Automation component is not installed on my computer.

Thanks for that report. I can confirm that with 0.14, closing the foobar browser window when the foobar com automation component is not installed will cause this crash. The preview window and order of closing does not affect this, and of course foobar itself is unaffected. I will have a fix for this in the next release, but until then I'd recommend either installing the com automation component, or not using the foobar browser (which doesn't do much without it installed anyway).

Alex
Title: Album Art Downloader XUI
Post by: thuan on 24 February, 2008, 03:46:50 AM
Well, I was just playing around. After that crash somehow it still crashes with this error a bunch of times until I restart. I didn't use the foobar browser again:
Code: [Select]
App version: 0.14.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ServiceModel.CommunicationObjectFaultedException: The communication object, System.ServiceModel.Channels.ServiceChannel, cannot be used for communication because it is in the Faulted state.

Server stack trace:
   at System.ServiceModel.Channels.CommunicationObject.Close(TimeSpan timeout)
   at System.ServiceModel.Channels.CommunicationObject.Close()

Exception rethrown at [0]:
   at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
   at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
   at System.ServiceModel.ICommunicationObject.Close()
   at AlbumArtDownloader.InstanceMutex.QueryPriorInstance(String[] args, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 04:01:50 AM
Well, I was just playing around.

Yes, fair enough, and it should absolutely not crash under those circumstances, I know. It was my own mistake that crept in while adding the playlist functionality, and I'll fix it as soon as possible.

The other crash you report is related to trying to communicate with an existing instance of the app which is not responding (possibly because of the earlier crash? Only a guess). If it happens again, please check Task Manager to see if there is an AlbumArt.exe entry in the processes list. If there isn't, then please let me know as something else strange is going on and I'll need to investigate. If there is, then you can End Process on AlbumArt.exe and avoid having to restart to clear the error.

In either case, I'll see what I can do about adding some automatic recovery for this situation.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 24 February, 2008, 04:12:55 AM
Before I restarted the computer I did check for AlbumArt.exe ghost process using Process Explorer, but there's none. That's why I had to restart my computer.

EDIT: I encounter the 2nd crash again and this time, indeed there's a ghost AlbumArt.exe in my process list. It makes me doubt my memory.
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 05:06:38 AM
Before I restarted the computer I did check for AlbumArt.exe ghost process using Process Explorer, but there's none. That's why I had to restart my computer.

OK; good to know. I've tried adding some additional robustness to the single instance code, hopefully faced with the same situation now it would automatically recover itself (although potentially having two instances running, if one could not be communicated with).

I've uploaded 0.14.1 which should hopefully resolve these issues - If you could give it a try and let me know if you encounter them again (or any others, of course!), then that would be appreciated. Download links remain the same:

AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe), or AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: thuan on 24 February, 2008, 05:20:54 AM
I can only get 0.14 with your links, please check them again.
Title: Album Art Downloader XUI
Post by: dano on 24 February, 2008, 05:22:35 AM
-Can you update the Amazon.de script with the image dimensions like the .com version?

-When the option Automatically download full sized images (x) Only when size is unkown
is selected, the size is not updated when the image was loaded, only if you preview the image
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 06:03:22 AM
I can only get 0.14 with your links, please check them again.

Just checked, they are downloading 0.14.1 when I try them here. The filename doesn't include the extra .1 part of the version number, perhaps that is the source of confusion?

-Can you update the Amazon.de script with the image dimensions like the .com version?

-When the option Automatically download full sized images (x) Only when size is unkown
is selected, the size is not updated when the image was loaded, only if you preview the image

I didn't write Amazon.de, that's one of Marc's. Looking at it, though, I don't think it can determine the image dimensions without downloading the image. The .com one uses the Amazon web services API, which does give that information. The .de one relies on reading the Amazon html pages, and the information just isn't there.

I'm not sure why you aren't seeing the size being automatically updated. Are you saying that the full size image has loaded, but the size for it is not updated? Or that the full size image is not being downloaded at all?

Alex
Title: Album Art Downloader XUI
Post by: dano on 24 February, 2008, 06:34:30 AM
I didn't write Amazon.de, that's one of Marc's. Looking at it, though, I don't think it can determine the image dimensions without downloading the image. The .com one uses the Amazon web services API, which does give that information. The .de one relies on reading the Amazon html pages, and the information just isn't there.

Oh ok, so the best would be to drop the html version (it also gets images with white borders) and replace it with a web api version. I figured I just have to replace .com with .de in url request but not in the namespace to make me a .de version. It seems to work fine.
Quote
I'm not sure why you aren't seeing the size being automatically updated. Are you saying that the full size image has loaded, but the size for it is not updated?

Yes. Some scripts don't get the image size, so I thought they would show it if I let them download the complete images.
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 06:54:20 AM
Oh ok, so the best would be to drop the html version (it also gets images with white borders) and replace it with a web api version. I figured I just have to replace .com with .de in url request but not in the namespace to make me a .de version. It seems to work fine.
Quote
I'm not sure why you aren't seeing the size being automatically updated. Are you saying that the full size image has loaded, but the size for it is not updated?

Yes. Some scripts don't get the image size, so I thought they would show it if I let them download the complete images.
If that web api version of the .de script works, that's good news, it could replace the html one. Do you know of any test albums to search for that the .de version returns differently from the .com version?

The automatic image downloading thing is a mystery, I can't see why that wouldn't be working for you. To test this, try deselecting all scripts except Coveralia (a slow source that doesn't have sizes). With the automatically download fullsize images option on Never, search for an album. You should get around 3 images back, usually front cover, back cover and CD. The image size should be "Unknown", and the thumbnails fuzzy (make the thumbnails larger if you can't tell). Then, click on the "Only when size unknown" option, and one of the results should show a little browse globe icon in the top left of the thumbnail, indicating it is downloading. After a few seconds, the thumbnail should become sharp and the image size filled in (usually around 1000 x 1000). Another of the results should then get the globe icon indicating it is being downloaded, and so on until all are completed.

Alex
Title: Album Art Downloader XUI
Post by: dano on 24 February, 2008, 07:15:28 AM
Quote
If that web api version of the .de script works, that's good news, it could replace the html one. Do you know of any test albums to search for that the .de version returns differently from the .com version?

I don't think that's an issue, quite some albums return different covers, but the code works for both versions.

The automatic image downloading works now, thanks. Was my fault.

I have a new question:
Can the file browser recognize compilation albums (e.g. a tag like Album Artist) when it scans in ID3 tag mode so that it doesn't return 20 albums instead of one?
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 07:30:44 AM
Can the file browser recognize compilation albums (e.g. a tag like Album Artist) when it scans in ID3 tag mode so that it doesn't return 20 albums instead of one?

No. I did look into this back in version 0.13, but while the Foobar library has the %album artist% titleformatting value for this, there appears to be no standard ID3 tag for compilation albums.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 24 February, 2008, 08:01:46 AM
Thanks, Alex. I can confirm that the foobar COM crash problem is fixed. Here's a bunch of endpoint values that you can change the URL request to, to get your version of Amazon cover search:
Code: [Select]
CA:    http://ecs.amazonaws.ca/onca/xml
DE:    http://ecs.amazonaws.de/onca/xml
FR:    http://ecs.amazonaws.fr/onca/xml
JP:    http://ecs.amazonaws.jp/onca/xml
UK:    http://ecs.amazonaws.co.uk/onca/xml
US:    http://ecs.amazonaws.com/onca/xml


Alex, what is the namespace in your Amazon.boo does anyway. That link is dead I think, it redirects to another page.
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 11:16:56 AM
Alex, what is the namespace in your Amazon.boo does anyway. That link is dead I think, it redirects to another page.

It isn't exactly a link, it is a namespace. They look like links, for uniqueness reasons, but don't actually have to even be resolvable.

The important thing about it is that it must exactly match the namespace of the returned xml data. If you look at the XML data returned from amazon, it starts like this:

<?xml version="1.0" encoding="UTF-8"?><ItemSearchResponse xmlns="http://webservices.amazon.com/AWSECommerceService/2005-10-05">...

The xmlns bit defines the namespace, and it is this that the namespace in the .boo file must match.

Thanks for the list of domain suffixes too. I'm not sure what the best way to deal with this is, whether to bundle a script for each domain, or have one script and come up with some way of setting the domain to use in the UI. I'll do some experimenting, anyway.

Alex
Title: Album Art Downloader XUI
Post by: dano on 24 February, 2008, 11:35:03 AM
Can the file browser recognize compilation albums (e.g. a tag like Album Artist) when it scans in ID3 tag mode so that it doesn't return 20 albums instead of one?

No. I did look into this back in version 0.13, but while the Foobar library has the %album artist% titleformatting value for this, there appears to be no standard ID3 tag for compilation albums.

Alex

You could check for the ALBUM ARTIST tag in the files, it's very common among foobar users. It's also the same name for all tag formats.
I've checked if mediainfo can read it. At least the GUI shows the tag, although on mp3 it cuts the first 3 letters of TXXX frames, but I mailed the author, he has already fixed the issue.
Of course I don't know if the DLL returns all tag fields, but maybe you can give it another look.
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 February, 2008, 01:53:16 PM
You could check for the ALBUM ARTIST tag in the files, it's very common among foobar users.

The TXXX ALBUM ARTIST tag appears to be a foobar specific thing. Other media players use the BAND (TPE2) tag, or a TXXX ALBUMARTIST tag (no space), and I've even heard that WMP 11 stores the Artist as the ID3v1 artist tag and Album Artist as the ID3v2 artist tag. There may be other schemes too. The problem is that there appears to be no standardisation at all, and for the File Browser I can't assume that the tags were written by foobar2000.

Alex
Title: Album Art Downloader XUI
Post by: antares on 27 February, 2008, 08:50:55 AM
Hi Alex,

I have been working with File Broswer and it works like a charm! Thanks for your effort! To improve my results, I would like to know if it is possible, to exclude information which may disturb some search results.

My file-scheme for example is "E:\Musik\mpc\Alice Cooper\[1999] Life And Crimes Of Alice Cooper CD 2"

Is it possible to exclude the Year: "[1999]" and the Volume: "CD 2"? Without these information the results are mostly better. Is this possible and how?

Another question is , how to improve results at albums with various artists? These albums are displayed as "Various" in the "Artist"- naming field of Album Art Downloader. Are there better results if I use other terms than Various?

Thanks for your help


Martin
Title: Album Art Downloader XUI
Post by: _eclectic_ on 27 February, 2008, 10:12:59 AM
I have just now discovered your tool.  It is absolutely, hands-down, the best, most complete tool I have used bar none for covers.  Every aspect of it has been well-thought out, from using tags or dire structure, size of the existing image, etc.etc.etc..  I am so impressed, I can't stop smiling!  You have saved me immeasurable amounts of time in scanning or searching the web for covers!!!!

ThankyouThankyouThankyouThankyouThankyouThankyouThankyouThankyouThankyouThankyou!!!!!!!

So, do you have a paypal link?  There are few programs out there that deserve it more....
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 February, 2008, 01:20:52 PM
My file-scheme for example is "E:\Musik\mpc\Alice Cooper\[1999] Life And Crimes Of Alice Cooper CD 2"

Is it possible to exclude the Year: "[1999]" and the Volume: "CD 2"? Without these information the results are mostly better. Is this possible and how?

Yes, this is possible. Try:
Code: [Select]
\mpc\%artist%\"(\[\d{4}\] )?"%album%"( CD \d+)?"\*

That assumes that both the date the CD number are optional, but that all music is under \mpc\... If either of those assumptions are wrong, it will need tweaking.

Another question is , how to improve results at albums with various artists? These albums are displayed as "Various" in the "Artist"- naming field of Album Art Downloader. Are there better results if I use other terms than Various?

I would guess that would depend on how the source being searched has classified them. You might try just searching for the album name without anything in the Artists field, that will probably work for most sources. The file-scheme can be tweaked to make the Album come out blank when the folder is Various like so:
Code: [Select]
\mpc\"(Various|%artist%)"\"(\[\d{4}\] )?"%album%"( CD \d+)?"\*


So, do you have a paypal link?  There are few programs out there that deserve it more....

Thanks for your kind words! It is really great to know when my work is appreciated, but I've also got to acknowledge my own debt of thanks to the residents of this forum who have suggested many of those features, and helped me track down bugs when they've appeared.

I hadn't set up a paypal link - it was something I was considering if I ever got round to putting together a proper website and documentation for a 1.0 release. But, as you specifically ask, any donation will be gratefully received here: Paypal Donation (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate) 

Alex
Title: Album Art Downloader XUI
Post by: _eclectic_ on 27 February, 2008, 05:13:55 PM
Quote
I hadn't set up a paypal link - it was something I was considering if I ever got round to putting together a proper website and documentation for a 1.0 release. But, as you specifically ask, any donation will be gratefully received here: Paypal Donation (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate) 

Alex

Okiedokie, seeing as how the US Dollar is crap compared with the pound, I had to double my efforts. 

Go have a nice pint on me, truly miss those nice mugs...
Title: Album Art Downloader XUI
Post by: antares on 28 February, 2008, 04:04:13 AM
Hi Alex,

thank you very much for your kind help!


Martin
Title: Album Art Downloader XUI
Post by: Tirade on 04 March, 2008, 08:25:19 PM
Im using a fresh install of Vista x64 SP1 and the latest AAD XUI

Ive not been able to get it to start yet as I get an error every time I click on the File Browser option.

Here is the error

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files (x86)\AlbumArtDownloader\errorlog.txt

App version: 0.14.1.0, running on Microsoft Windows NT 6.0.6001 Service Pack 1

System.BadImageFormatException: An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B)
   at MediaInfoLib.MediaInfo.MediaInfo_New()
   at MediaInfoLib.MediaInfo..ctor()
   at AlbumArtDownloader.FileBrowser.OnIsVisibleChanged(Object sender, DependencyPropertyChangedEventArgs e)
   at System.Windows.UIElement.RaiseDependencyPropertyChanged(EventPrivateKey key, DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.OnIsVisibleChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.UpdateIsVisibleCache()
   at System.Windows.PresentationSource.RootChanged(Visual oldRoot, Visual newRoot)
   at System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
   at System.Windows.Window.SetRootVisual()
   at System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
   at System.Windows.Window.CreateSourceWindowImpl()
   at System.Windows.Window.ShowHelper(Object booleanBox)
   at System.Windows.Window.Show()
   at AlbumArtDownloader.FileBrowser.AlbumArtDownloader.IAppWindow.Show()
   at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
   at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 05 March, 2008, 03:44:20 AM
Im using a fresh install of Vista x64 SP1 and the latest AAD XUI

Could you try downloading the  x64 version of MediaInfo (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.6.0_DLL_Windows_x64.7z?modtime=1204285826&big_mirror=0) and extracting MediaInfo.dll into the Album Art Downloader program folder?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Tirade on 05 March, 2008, 07:16:51 AM
Im using a fresh install of Vista x64 SP1 and the latest AAD XUI

Could you try downloading the  x64 version of MediaInfo (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.6.0_DLL_Windows_x64.7z?modtime=1204285826&big_mirror=0) and extracting MediaInfo.dll into the Album Art Downloader program folder?

Thanks,

Alex



/bow

You are the man.

Fixed!
Title: Album Art Downloader XUI
Post by: entrecour on 05 March, 2008, 02:06:41 PM
Hi Alex,

Album Art Dowloader has grown from strenth to strength -it's definitely the best tool I have found.

As the new owner of a HTPC I wonder wether you have ever looked at adding DVD covers as an additional capability? The concepts involve seem very similar to me.

Thanks, David.
Title: Album Art Downloader XUI
Post by: ryran on 08 March, 2008, 02:04:09 PM
Hey everyone. Hoping to get some guidance here...
I've used the original Album Art Downloader up until now but finally decided to try this out. Got net3.5 all installed and then this (version 0.14) but now when I load the executable I just get a properly titled black window. I can resize it... if I move the mouse around the cursor changes to text input or hyperlinkink cursors.. but... nothing I can do.
HALP plz!
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 March, 2008, 03:22:28 PM
Sorry about the delayed reply here.

As the new owner of a HTPC I wonder wether you have ever looked at adding DVD covers as an additional capability? The concepts involve seem very similar to me.
There's no particular reason why DVD covers can't be found using this tool, it all depends on the source. For something like Google Images, they'll be returned already. Other more specific DVD cover sources could be written too, which in some cases might just be a modification of an existing script.

I don't think there's any equivalent to ID3 Tags for DVD's, but the folder browser using path pattern matching would still work.

I just get a properly titled black window.
Sorry, Ryran, but this is a complete mystery to me. I've searched around and found no likely explanations, so I can't give you any suggestions on what might be causing this or how to fix it.

Alex
Title: Album Art Downloader XUI
Post by: sylla on 18 March, 2008, 08:33:36 AM
An idea is to show the size of existing albumart in pixels instead of in kb in the file browser, that makes more sense to me at least.

Great program this, thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 March, 2008, 08:40:53 AM
An idea is to show the size of existing albumart in pixels instead of in kb in the file browser, that makes more sense to me at least.

Thanks for the suggestion, but this would require each existing image to actually be loaded from disk, resulting in a considerable decrease in performance. The current system does not need to actually load the image files to display the file size.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 18 March, 2008, 02:16:23 PM
A very simple request:  Tab and Shift-Tab highlight the previous entry (as it once did).  That way you don't have to manually delete the old entry, but can simply start typing.

That said, awesome program!
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 March, 2008, 02:43:31 PM
A very simple request:  Tab and Shift-Tab highlight the previous entry (as it once did).  That way you don't have to manually delete the old entry, but can simply start typing.
I'm not sure I understand what you are asking for here, could you be more specific? If you could tell me in what state the program is (including where the focus is, if you can tell) when you click Tab or Shift Tab, what it actually does, and what you expected it to do, I can probably fix this.

Alex
Title: Album Art Downloader XUI
Post by: jasperooni on 23 March, 2008, 01:04:22 PM
Crash:
Quote
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\foobar2000\AlbumArtDownloader\errorlog.txt

App version: 0.14.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3, v.3244

System.Reflection.TargetInvocationException: Ein Aufrufziel hat einen Ausnahmefehler verursacht. ---> System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei AlbumArtDownloader.AlbumArt.get_ImageCodecInfo()
  bei AlbumArtDownloader.AlbumArt.CoerceFilePath(DependencyObject sender, Object value)
  bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  bei System.Windows.DependencyObject.CoerceValue(DependencyProperty dp)
  bei AlbumArtDownloader.AlbumArt.OnDefaultFilePathPatternChanged(DependencyObject sender, DependencyPropertyChangedEventArgs e)
  bei System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  bei System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  bei System.Windows.DependencyObject.InvalidateProperty(DependencyProperty dp)
  bei System.Windows.Data.BindingExpression.Invalidate(Boolean isASubPropertyChange)
  bei System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
  bei System.Windows.Data.BindingExpression.ScheduleTransfer(Boolean isASubPropertyChange)
  bei MS.Internal.Data.ClrBindingWorker.NewValueAvailable(Boolean dependencySourcesChanged, Boolean initialValue, Boolean isASubPropertyChange)
  bei MS.Internal.Data.PropertyPathWorker.UpdateSourceValueState(Int32 k, ICollectionView collectionView, Object newValue, Boolean isASubPropertyChange)
  bei MS.Internal.Data.PropertyPathWorker.OnDependencyPropertyChanged(DependencyObject d, DependencyProperty dp, Boolean isASubPropertyChange)
  bei MS.Internal.Data.ClrBindingWorker.OnSourceInvalidation(DependencyObject d, DependencyProperty dp, Boolean isASubPropertyChange)
  bei System.Windows.Data.BindingExpression.HandlePropertyInvalidation(DependencyObject d, DependencyPropertyChangedEventArgs args)
  bei System.Windows.Data.BindingExpression.OnPropertyInvalidation(DependencyObject d, DependencyPropertyChangedEventArgs args)
  bei System.Windows.DependentList.InvalidateDependents(DependencyObject source, DependencyPropertyChangedEventArgs sourceArgs)
  bei System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  bei System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
  bei System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  bei AlbumArtDownloader.Controls.ArtPathPatternBox.set_PathPattern(String value)
  bei AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  bei AlbumArtDownloader.App.<>c__DisplayClass3.<Signal>b__2()
  --- Ende der internen Ausnahmestapelüberwachung ---
  bei System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  bei System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  bei System.Delegate.DynamicInvokeImpl(Object[] args)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 23 March, 2008, 01:16:56 PM
A very simple request:  Tab and Shift-Tab highlight the previous entry (as it once did).  That way you don't have to manually delete the old entry, but can simply start typing.
I'm not sure I understand what you are asking for here, could you be more specific? If you could tell me in what state the program is (including where the focus is, if you can tell) when you click Tab or Shift Tab, what it actually does, and what you expected it to do, I can probably fix this.

What I mean is if you're in the Artist field and Tab to the Album field, the previous album in that field is already highlighted, so you can simply type over it.  Conversely, if you're in the Album field and Shift-Tab back to the Artist field, the old artist in that field is already highlighted.

I don't know your native language, so if that's not clear, I can provide images to explain better what I mean.

It's not a big deal.  It just saves a little time manually deleting the old info already in the field.  It used to work that way (at my request), but somehow got changed somewhere along the line.

Thanks. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 March, 2008, 03:28:58 PM
Crash: <snip/>
From the error report, it appears that Album Art Downloader was unable to determine the correct file extension for an image format. I can fix it so that it won't crash in this case (and I will do, for the next version), but it would be really useful if you could let me know which album, artist and image source it came from. That way I can figure out what image format it is, and why it wasn't detected correctly.

What I mean is if you're in the Artist field and Tab to the Album field, the previous album in that field is already highlighted, so you can simply type over it.
Oh, I get it! I thought it was Tab not going to the right control - but it is going to the right control, just not selecting all the text in it. I'll make that change for the next version.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 23 March, 2008, 04:27:54 PM
What I mean is if you're in the Artist field and Tab to the Album field, the previous album in that field is already highlighted, so you can simply type over it.
Oh, I get it! I thought it was Tab not going to the right control - but it is going to the right control, just not selecting all the text in it. I'll make that change for the next version.

Alex

Thanks, that would be much appreciated. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 March, 2008, 03:21:52 PM
AlbumArt Downloader XUI v0.15 Released

Mostly bug fixes in this release, and a couple of minor improvements that have been requested. I've also improved the reporting of x64 issues. I don't have a 64 bit copy of Windows, so no testing has been done on that platform, but the default behaviour should no longer be to crash. Instead, you should be requested to install the 64 bit version of the MediaInfo dll. The installer should also automatically detect Win64, and offer to take you to the download page for an installer for the x64 version of MediaInfo.dll that I've put together. The reason I haven't just bundled both the 32 bit and 64 bit versions of the dll in the main installer is that this dll is the largest part of the download already, and the 64 bit version is double the file size.

Also in this release I've refactored the Amazon search scripts into one common script and several optional regional variations. If you are using the installer, the you can just pick any of the regions (.com, .co.uk, .jp, etc...) to install. If you are using the zip file, then make sure amazon-common.boo is present, plus one or more of the other Amazon scripts, like amazon-com.boo, for example.

For those who are interested in scripting, these scripts now demonstrate the XUI object oriented script API of implementing the IScript interface. The amazon-common.boo script implements an abstract class which the other, minimal Amazon scripts inherit from - demonstrating one of the benefits of the object oriented approach.

List of other changes for this version:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 25 March, 2008, 03:10:35 PM
... I've refactored the Amazon search scripts into one common script and several optional regional variations. ... any of the regions (.com, .co.uk, ,.jp, etc...) to install...


i love you! thanks for new scripts. i was hoping you kind of look into them! THX
Title: Album Art Downloader XUI
Post by: bsleeth on 25 March, 2008, 11:51:37 PM
Thank you for a great and very handy tool.

I recently found some quality images at Album Art Exchange (http://www.albumartexchange.com/covers.php)

I thought I might take a crack at writing an albumartexchange.boo script.  I figured I could use the google.boo  as a starting point, but it was not long before I realized that I have no idea what I am doing.

With the acknowledgment that every web page will present the thumbnails and images slightly different, has anyone put together a general guideline for writing a script?

To be honest, although I would like to write the script myself, unfortunately, I think even with some pointers I will not be able to get a working script.  If someone more capable has the time and thinks a new script for the Album Art Exchange site would be a good addition, I would be very interested in seeing a working script.

Thank you again for a great tool,
Brian
Title: Album Art Downloader XUI
Post by: Razzeli on 27 March, 2008, 02:50:51 PM
Hi! The program crashes after I have pressed the search button. I have Vista x64 with SP1 and latest version (0.15) of Album Art XUI and Media Info x64 Upgrade. This is the log I get:


Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files (x86)\AlbumArtDownloader\errorlog.txt

App version: 0.15.0.0, running on Microsoft Windows NT 6.0.6001 Service Pack 1

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at AlbumArtDownloader.Common.MakeSafeForPath(String value)
   at AlbumArtDownloader.ArtSearchWindow.AlbumArtDefaultFilePathPatternSubstitution.Convert(Object value, Type targetType, Object parameter, CultureInfo culture)
   at System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
   at System.Windows.Data.BindingExpression.Activate(Object item)
   at System.Windows.Data.BindingExpression.AttachToContext(AttachAttempt attempt)
   at System.Windows.Data.BindingExpression.AttachOverride(DependencyObject target, DependencyProperty dp)
   at System.Windows.Data.BindingExpressionBase.Attach(DependencyObject target, DependencyProperty dp)
   at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
   at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
   at System.Windows.Data.BindingOperations.SetBinding(DependencyObject target, DependencyProperty dp, BindingBase binding)
   at AlbumArtDownloader.ArtSearchWindow.BindAlbumArtDefaultFilePath(AlbumArt art)
   at AlbumArtDownloader.ArtSearchWindow.OnResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   at System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedAction action, Object item, Int32 index)
   at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   at System.Collections.ObjectModel.Collection`1.Add(T item)
   at AlbumArtDownloader.Sources.OnSourceResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedAction action, Object item, Int32 index)
   at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   at System.Collections.ObjectModel.Collection`1.Add(T item)
   at AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass9.<Add>b__7()
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   at System.Delegate.DynamicInvokeImpl(Object[] args)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 28 March, 2008, 03:49:15 PM
With the acknowledgment that every web page will present the thumbnails and images slightly different, has anyone put together a general guideline for writing a script?

<snip/> a new script for the Album Art Exchange site would be a good addition, I would be very interested in seeing a working script.

As far as I know, no-one has put together any general guideline for writing a script - the idea has mostly been to grab one that works and modify it. A strong knowledge of regular expressions is a requirement, and some knowledge of .net in general is handy. If you are serious about wanting to write scripts, and need a hand with them, send me a PM and I can probably help.

Here's an albumartexchange.boo (http://www.byalexv.co.uk/foobar/albumartexchange.boo) for you, anyway. Not much selection there yet, I found, but hopefully they'll expand in the future.

Hi! The program crashes after I have pressed the search button.

Hi, thanks for reporting the crash. I'll put a guard against this into the next version, but I don't really understand why it occurred. Does it happen every time for you, or is there anything you do that makes it reliably happen?

Alex
Title: Album Art Downloader XUI
Post by: kkamion on 28 March, 2008, 05:13:14 PM
Any chance of making script for this site? 

http://www.allcdcovers.com/ (http://www.allcdcovers.com/)
Title: Album Art Downloader XUI
Post by: Razzeli on 28 March, 2008, 06:41:59 PM
Hi, thanks for reporting the crash. I'll put a guard against this into the next version, but I don't really understand why it occurred. Does it happen every time for you, or is there anything you do that makes it reliably happen?

Yes, it does crash everytime I press the search button, haven't found a way to fix it.
Title: Album Art Downloader XUI
Post by: emfletcher on 31 March, 2008, 03:53:10 PM
This program just keeps getting better.  The file pattern matching is awesome.  The file pattern I am using is \%artist% - %album%\* which works great.  But sometimes I will have something like [1994 Remaster] or (Disc 2) after the album name.  How would I make it remove everything in parenthesis and brackets? 

Also, right now it doesn't detect my various artist albums because the folder name is just the album.  Instead of ignoring the folder when it doesn't find a -, would it be possible to make it assume it is a various artist album?  When there is no - it could just take the whole folder name as the album name and leave the artist field blank.

One more small suggestion.  Could the local files box be a different color so it is easier to find, or maybe an option to pin it always as first result.  It is hard to find the existing art mixed in with the search results, and many times you need it to compare it too.

Thanks for the great program.
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 31 March, 2008, 05:10:22 PM
This program just keeps getting better.  The file pattern matching is awesome.  The file pattern I am using is \%artist% - %album%\* which works great.  But sometimes I will have something like [1994 Remaster] or (Disc 2) after the album name.  How would I make it remove everything in parenthesis and brackets? 

Also, right now it doesn't detect my various artist albums because the folder name is just the album.  Instead of ignoring the folder when it doesn't find a -, would it be possible to make it assume it is a various artist album?  When there is no - it could just take the whole folder name as the album name and leave the artist field blank.

Thanks for the great program.


i dont know if youre reffering to that folder browser in albumart xui (i dont use it at all) (if so probably ignore the rest of my post ) but you should be able to handle these exceptions inside foobar by simply using complex and sometimes a bit hard titleformating.

for deteciton of "-" you could use $strstr in some kind of this trick: $if($strstr(%path%,'-'), normal, various)

for replacing parenthesis try to find some titleformating gimmick for diming them in cui and adapt these to you needs

these exceptinous shouldnt be harcoded in program for there are probably totaly different for every user, and you should be able to handle them yourself.
Title: Album Art Downloader XUI
Post by: AlexVallat on 31 March, 2008, 06:09:00 PM
Any chance of making script for ... http://www.allcdcovers.com/ (http://www.allcdcovers.com/)

They provide an API, which might make it interesting to do a script for. I've asked them for a developer key for it, but had no reply yet. If I get one, I'll do a script for it.

The file pattern I am using is \%artist% - %album%\* which works great.  But sometimes I will have something like [1994 Remaster] or (Disc 2) after the album name.  How would I make it remove everything in parenthesis and brackets?

The pattern matching can be made to use regular expressions by enclosing them between " marks. It does not use title formatting at all (sorry, cartman(2vd), your suggestions don't apply in this case, but thanks all the same!).

To do the match you are describing, you could try:
Code: [Select]
\%artist% - %album%"( \[.+?\])?( \(.+?\))?"\*
This will ignore the end of the album name if it is separated from the album name with a space, and is enclosed in brackets, or parenthesis, or a term in brackets followed by a space, followed by a term in parenthesis. If any of those assumptions are wrong, it may need tweaking.

Also, right now it doesn't detect my various artist albums because the folder name is just the album.  Instead of ignoring the folder when it doesn't find a -, would it be possible to make it assume it is a various artist album?  When there is no - it could just take the whole folder name as the album name and leave the artist field blank.

You could, yes:
Code: [Select]
\"("%artist% - %album%"( \[.+?\])?( \(.+?\))?|%album%)"\*
This adds an alternation that if the first pattern doesn't match, it tries a second, which is just %album%.

One more small suggestion.  Could the local files box be a different color so it is easier to find, or maybe an option to pin it always as first result.  It is hard to find the existing art mixed in with the search results, and many times you need it to compare it too.

Thanks for the suggestion; I'll see how well pinning as the first result works, and it may make it into a future version. I don't like the colouring idea, though.

Thanks for the comments,

Alex
Title: Album Art Downloader XUI
Post by: emfletcher on 31 March, 2008, 07:26:45 PM
Wow.  That pattern works great.  Thanks for the fast reply.   

I just noticed that the program stops searching when it runs into a really long folder or file name.  I got this error:

Quote
Error occurred while searching: The specified path, file name, or both are too long.  The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters.


Is there any way the program could continue searching after giving the error?
Title: Album Art Downloader XUI
Post by: AlexVallat on 01 April, 2008, 02:49:44 AM
Is there any way the program could continue searching after giving the error?

Possibly. Ideally, of course, the error wouldn't occur at all, but I'm not sure whether there will be any way to work around the character limits. I'll look into it.

Alex
Title: Album Art Downloader XUI
Post by: bsleeth on 02 April, 2008, 11:59:08 AM
Here's an albumartexchange.boo (http://www.byalexv.co.uk/foobar/albumartexchange.boo) for you, anyway. Not much selection there yet, I found, but hopefully they'll expand in the future.

Alex,

Wow.  Thank you very much.  Your script works great.  The script is also very clean and would make a great starting point.

Yes, AlbumArtExchange is a hit or miss site.  However if they have the cover you are looking for it is generally a quality image.

Sorry for the late reply, but I have been out of town.  Although I am (was) serious about writing the script myself, I am finding that I just do not have the time to "play".

Thank you again,
Brian
Title: Album Art Downloader XUI
Post by: katoblepa on 05 April, 2008, 03:42:06 PM
Hi!
I dowloaded the program. But It crashes at the first serch. No messages. Only if I wante to send the error to Microsoft.... 

Any idea?

Thanks
Title: Album Art Downloader XUI
Post by: arnymars on 05 April, 2008, 04:53:00 PM
I have MS .Net 3 and 3.5 installed on a Win XP Home SP2 PC. After installation of AlbumArtDownloader it worked well. Now - similar to above Crash every time after trying the first search. Tried to reinstall or use Non-install version, change search terms like Artist & Album - same crash no matter what.
Crash Log - see the attached file.
Title: Album Art Downloader XUI
Post by: katoblepa on 05 April, 2008, 05:00:11 PM
Exatly arnymars.
I first donloaded .net 3.0 and Albumart worked well. Then I found the version based on +net3.5 and  it crashes at the first search....
Title: Album Art Downloader XUI
Post by: NogginJ on 05 April, 2008, 05:07:22 PM
i did like this program. downloaded the new version, and now it crashes as soon as it opens.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.15.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.IO.FileNotFoundException: Could not load file or assembly 'System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. The system cannot find the file specified.
File name: 'System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'
   at AlbumArtDownloader.Arguments..ctor(String[] args, IEnumerable`1 valuedParameters)
   at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
   at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   at System.Windows.Application.<.ctor>b__0(Object unused)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].
Title: Album Art Downloader XUI
Post by: AlexVallat on 05 April, 2008, 05:35:11 PM
Oh dear, what a bunch of crashes. I'll answer them individually:

crashes at the first serch. No messages.
If the error log does not appear, then I may not be able to figure out why the crash is happening. Could you try looking in the Album Art Downloader folder (usually c:\Program Files\AlbumArtDownloader) for a file called errorlog.txt? If there is one there, please send it to me, and I'll see what I can do. If you could let me know what album and artist you were searching for, that might help too.

Crash Log - see the attached file.
Thanks for reporting this crash. You say it always occurs, whatever search terms you use? I don't really understand why this is happening, but could you try replacing your AlbumArt.exe version with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe). It should stop it crashing, or at least make it crash in a different place, which would give me a clue as to why. Please let me know either way, so I can have it fixed for the next version.

downloaded the new version, and now it crashes as soon as it opens.
Code: [Select]
System.IO.FileNotFoundException: Could not load file or assembly 'System.Core
This error means you haven't got .net framework 3.5 installed (you probably have only 3.0). Either use the installer, which automatically detects this, or just download the framework here: .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6)

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 05 April, 2008, 06:16:16 PM
Oh dear, what a bunch of crashes. I'll answer them individually:

Crash Log - see the attached file.
Thanks for reporting this crash. You say it always occurs, whatever search terms you use? I don't really understand why this is happening, but could you try replacing your AlbumArt.exe version with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe). It should stop it crashing, or at least make it crash in a different place, which would give me a clue as to why. Please let me know either way, so I can have it fixed for the next version.

Alex

Hi Alex,

Thanks for the excellent program! I tested the last AlbumArt.exe file of 4/5/08 a bit, and it does work. I also checked again the previous AlbumArt.exe file of 3/24/08 and found:

- when foobar2000 or your latest AlbumArt.exe file of 4/5/08 is running, the previous file version can also be launched and works great;
- when none of these 2 programs is running, the previous AlbumArt.exe crashes after the 1st search;
- when called from foobar2000 via Run Service (I'm using beautiful foo_smooth skin (http://www.neugablonz.de/index.php?seite=foobar3) and foo plugins included with it), it works great and gets the right folder to save the pictures. It would help, if AlbumArt window can close automatically after the user returns to Foobar2000 window & hits Play.

Thanks
Arny
Title: Album Art Downloader XUI
Post by: katoblepa on 05 April, 2008, 07:20:26 PM
Oh dear, what a bunch of crashes. I'll answer them individually:

crashes at the first serch. No messages.
If the error log does not appear, then I may not be able to figure out why the crash is happening. Could you try looking in the Album Art Downloader folder (usually c:\Program Files\AlbumArtDownloader) for a file called errorlog.txt? If there is one there, please send it to me, and I'll see what I can do. If you could let me know what album and artist you were searching for, that might help too.

Crash Log - see the attached file.
Thanks for reporting this crash. You say it always occurs, whatever search terms you use? I don't really understand why this is happening, but could you try replacing your AlbumArt.exe version with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe). It should stop it crashing, or at least make it crash in a different place, which would give me a clue as to why. Please let me know either way, so I can have it fixed for the next version.

downloaded the new version, and now it crashes as soon as it opens.
Code: [Select]
System.IO.FileNotFoundException: Could not load file or assembly 'System.Core
This error means you haven't got .net framework 3.5 installed (you probably have only 3.0). Either use the installer, which automatically detects this, or just download the framework here: .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6)

Alex


Yes I found the error log....
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: E:\Programmi\AlbumArtDownloader\errorlog.txt

App version: 0.15.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Eccezione generata dalla destinazione di una chiamata. ---> System.NullReferenceException: Riferimento a un oggetto non impostato su un'istanza di oggetto.
   in AlbumArtDownloader.Common.MakeSafeForPath(String value)
   in AlbumArtDownloader.ArtSearchWindow.AlbumArtDefaultFilePathPatternSubstitution.Convert(Object value, Type targetType, Object parameter, CultureInfo culture)
   in System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
   in System.Windows.Data.BindingExpression.Activate(Object item)
   in System.Windows.Data.BindingExpression.AttachToContext(AttachAttempt attempt)
   in System.Windows.Data.BindingExpression.AttachOverride(DependencyObject target, DependencyProperty dp)
   in System.Windows.Data.BindingExpressionBase.OnAttach(DependencyObject d, DependencyProperty dp)
   in System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
   in System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
   in System.Windows.Data.BindingOperations.SetBinding(DependencyObject target, DependencyProperty dp, BindingBase binding)
   in AlbumArtDownloader.ArtSearchWindow.BindAlbumArtDefaultFilePath(AlbumArt art)
   in AlbumArtDownloader.ArtSearchWindow.OnResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   in System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   in System.Collections.ObjectModel.Collection`1.Add(T item)
   in AlbumArtDownloader.Sources.OnSourceResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   in System.Collections.ObjectModel.Collection`1.Add(T item)
   in AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass9.<Add>b__7()
   --- Fine dell'analisi dello stack dell'eccezione interna ---
   in System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   in System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   in System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   in System.Delegate.DynamicInvokeImpl(Object[] args)
   in System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   in System.Windows.Threading.DispatcherOperation.InvokeImpl()
   in System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   in System.Threading.ExecutionContext.runTryCode(Object userData)
   in System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   in System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   in System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   in System.Windows.Threading.DispatcherOperation.Invoke()
   in System.Windows.Threading.Dispatcher.ProcessQueue()
   in System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   in MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   in MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   in System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   in System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   in MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   in MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   in System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   in System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   in System.Windows.Threading.Dispatcher.Run()
   in System.Windows.Application.RunInternal(Window window)
   in System.Windows.Application.Run(Window window)
   in System.Windows.Application.Run()
   in AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   in AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   in AlbumArtDownloader.App.Main(String[] args)

I was looking for ABC - Abracadabra cover.With the previous version worked fine. Im starting now to use the program and I have some questions.
1) I imagine that the program can be activated from Foobar. By what menu option?
2) I syncronizing my ipod with foo-dop and it seems to work fine. How are the covers managed by ipod? Are they "loaded" as any mp4 or mp3 file? Any requirements?

Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 06 April, 2008, 03:17:41 AM
Thanks for the excellent program! I tested the last AlbumArt.exe file of 4/5/08 a bit, and it does work. <snip> It would help, if AlbumArt window can close automatically after the user returns to Foobar2000 window & hits Play.
That's great news! I still don't know why it happened, but I'm glad that guard I put in place seems to fix it. It will be included in the next release.

You can't have the window close automatically when you press Play in Foobar, I'm afraid, but what you can do is have it close automatically when you save an album art. The flow then goes something like: click Get Art in foobar, look at results, double click best result. The result is then saved and the search window closes. To get this auto-close behaviour, add /autoclose to your command line, or click the "Automatically close after saving" checkbox in the Options area of the search window.

Yes I found the error log....
<snip>
1) I imagine that the program can be activated from Foobar. By what menu option?
2) I syncronizing my ipod with foo-dop and it seems to work fine. How are the covers managed by ipod? Are they "loaded" as any mp4 or mp3 file? Any requirements?
It looks like you have the same crash as arnymars. Could you verify that replacing your AlbumArt.exe with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe) fixes the problem?

In answer to your other questions, [a href='index.php?showtopic=45223']foo_run[/a] is generally used for launching programs like this from Foobar. For foo_dop, you should probably ask in the [a href='index.php?showtopic=45160']foo_dop thread[/a]. According to the wiki (http://yuo.be/wiki/dop:notes#about_album_art_support), it should support it.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 06 April, 2008, 09:53:33 AM
Click Get Art in foobar, look at results, double click best result. The result is then saved and the search window closes.

Thanks Alex!
In this case, can you modify AAD a bit, so that a single click on the Floppy Icon can Save an Album Cover without closing AAD window (allowing to add more Cover variants for the same album), but a double click  on the Cover in search results will Close AAD? And what are the naming rules for saving several Covers for the same Album to show them all in foobar2000 when the Album is placed in a Playlist?

Also, a few of other things:

-    When an Album Cover is saved by AAD, called from foobar2000 via Run service, why that Cover is not updated right away in the Playlist window, and also other foobar windows - like AlbumArt and Graphical Browser Panels and Row (I'm using Foo_Smooth (http://www.neugablonz.de/gaestebuch/index.html) Skin), and how to synch them without  restarting foobar? Would better integration btw AAD, foobar2000 and its plugins help?
-    Can you add a Prefs Option or a Link next to each Cover in search results to open the Cover source page in a default web browser? It'll help to get mote info about the Album and check the Cover match more accurately when needed;
-    While AAD Interface is clearly designed, some functionality may need clarification for novices. Is there any Help, Readme or FAQ file about AAD anywere?
-    Processor load is very high, when searching for Covers in local PC folders with AAD File Browser. Can it be optimized a bit for that operation?
- Can you add some skinning, or at least Interface color matching options to AAD, f.e. to auto or manually match its window color scheme & element appearance with current foobar2000 skin color scheme?

Thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 06 April, 2008, 11:44:17 AM
In this case, can you modify AAD a bit, so that a single click on the Floppy Icon can Save an Album Cover without closing AAD window (allowing to add more Cover variants for the same album), but a double click  on the Cover in search results will Close AAD?
Interesting idea. I'm not sure how intuitive that would be, but if I can think of a good way of presenting it, it might make it in to a future version.

And what are the naming rules for saving several Covers for the same Album to show them all in foobar2000 when the Album is placed in a Playlist?
There aren't any, really. I've had a long-standing idea of using a preset system so you can click a dropper arrow next to the save button to save as things like "album name - front" and "- back" and so on, but haven't got round to it yet.

When an Album Cover is saved by AAD, called from foobar2000 via Run service, why that Cover is not updated right away in the Playlist window, and also other foobar windows
I guess because they have no way of knowing to look for new art files, and don't constantly refresh themselves. Not much I can do about that, but you shouldn't have to restart foobar, the art panels should have some sort of refresh command. If they don't, try asking them for one. If an art display panel had an integrated "run cover fetching tool" command that could run an external tool, then update itself once that tool exited, then you could use AAD for that. Just pass the /separateInstance command line arg so that it doesn't re-use an existing instance, and only exits when you close it.

Can you add a Prefs Option or a Link next to each Cover in search results to open the Cover source page in a default web browser?
No. That information is not provided by the sources, and I have no intention of re-writing all of them to provide it.

While AAD Interface is clearly designed, some functionality may need clarification for novices. Is there any Help, Readme or FAQ file about AAD anywere?
There's the wiki page (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Components_0.9/AlbumArtDownloader_XUI), I guess. But no, there is no proper documentation for it, and I agree that there should be. That doesn't mean that I intend to write any any time soon, but if anyone else fancies putting some together, I'll certainly integrate it.

Processor load is very high, when searching for Covers in local PC folders with AAD File Browser. Can it be optimized a bit for that operation?
I'll look into it, but could you check if you find the same issue with using pattern matching as ID3 tag matching? It would be useful to know how much of it is due to the MediaInfo tag reading. Mostly, the file browser searching is optimised for speed, so I would expect a high processor load while it is working.

Can you add some skinning, or at least Interface color matching options to AAD, f.e. to auto or manually match its window color scheme & element appearance with current foobar2000 skin color scheme?
Automatic colour matching to foobar is never going to happen. A colour scheme 'skin' file could be a possibility, though. Any actual skin would need to be a xaml file, and would be closer to development than skinning, but if there is any real interest in this, it might be doable. If anyone is interested in designing xaml skins, the best way to start would be to grab the source off the public SVN (https://sourceforge.net/svn/?group_id=187008) and modify the xaml files there.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 06 April, 2008, 01:22:59 PM
Web links information is not provided by the sources, and I have no intention of re-writing all of them to provide it.

It's quite a useful feature though. People may want to look at the found by AAD Album's info on its source page, but - no way... And, I guess, a nice way to make extra money on referals to Amazon etc. to keep AAD development going. Just keep your mind open for it pls.
Quote
It would be useful to know how much of the processor load is due to the MediaInfo tag reading.

About 90% of P4 full load on file path pattern matching for a short time, and feels OK, and 75-85% with ID3 tags matching, but quite lengthy, resulting eventually in overheating & extreme fan noize when searching larger archives. Surprisingly, at idle AAD also uses variable processor power 2 to 6% continuosly. Some tweaking may help here.
Quote
An xaml colour scheme 'skin' file could be a possibility

May be just a simple way for a user to manually change in AAD Options its windows & border & text colors and font to visually match with current foobar2000 color scheme?

Again, thanks for very fast excellent program!
Title: Album Art Downloader XUI
Post by: arnymars on 06 April, 2008, 01:23:14 PM
Can anyone suggest an Album Collection Editor, which can find automatically on the web and offer to the user or auto add as a Prefs Option missing info to Albums like Artist & Title or Album name, and also sort & move such Collection music files to the right Album Folders based on song names & other data.
Title: Album Art Downloader XUI
Post by: AlexVallat on 06 April, 2008, 02:57:34 PM
AlbumArt Downloader XUI v0.16 Released

Small bug fixing issue, but they seemed to be cropping up frequently, so I thought it was worth pushing out a release with the fixes in.

List of changes for this version:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: arnymars on 06 April, 2008, 04:24:33 PM
Alex,

Great news! What's Album Art Exchange Script and how to use it?

Also, would you intertain an AAD version in a form of foobar2000 Plugin - possibly for better UI and appearance integration, and auto update of foobar windows after selecting or saving new Covers found by AAD. A standalone AAD version will still be useful with other players, and may have broader functionality, like finding & adding missing Album description info, sorting & auto moving files btw Album folders, and some money making referal mechanism.
Title: Album Art Downloader XUI
Post by: AlexVallat on 06 April, 2008, 05:39:45 PM
Great news! What's Album Art Exchange Script and how to use it?
Album Art Exchange is a website that has cover art available, and the Script lets Album Art Downloader search it for covers. I'd posted the script a few days ago, after someone requested it - the change here is just to bundle it with the installer and zip file. To use it, just make sure the checkbox for it in the list of sources is checked.

Also, would you intertain an AAD version in a form of foobar2000 Plugin
No. AAD is written in C#, and has a WPF UI. Neither of these are in the least bit compatible with the foobar2000 plug-in system. I don't like C++, and have no intention of writing anything extensive in that language.

I've already outlined the only suggestion I would have for automatically updating after running an external cover fetching tool.

finding & adding missing Album description info, sorting & auto moving files btw Album folders, and some money making referal mechanism.
That's an entirely different sort of application. This is not a music manager, or organiser. This is a tool for getting artwork for albums, and it's not going to creep into becoming a music management tool. At best it could be a plug-in to a music management tool, if that tool had some sort of .net plug-in interface.

As for a money making referral mechanism, I'm not sure that there would be much point to that. Surely you only search for cover art for albums you already have, and would therefore not be buying? If the app ever becomes polished enough to warrant being called a 1.0 release (which would include proper website and documentation, at least), I've been considering adding a donate (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate) link to it, probably under the Help menu is traditional, I think.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 07 April, 2008, 10:19:43 AM
You only search for cover art for albums you already have

Some people may still want to open the linked to a Cover web page to clarify, if that's the exact Cover they need, and find more info about the Album. Some may have incomplete or low quality version of the Album, and may want to purchase the geniune Album upon review. Regardless of outcome, referal is paid per click, and will support AAD development. Users will be glad as well, as clicking on Cover links is a matter of choice, and adds a real convenience.

As to finding missing basic Album descriptions, I thought it may employee similar search mechanism you already have, allowing users to deal with just one application. BTW, do you have any priority system for Album Art found, in which order they are presented to the user? If you add such search accuracy prioritization (which may use Album descriptions and feels quite logical), similar sorting mechanism may possibly be applied to music collections in general. A lot of music collections are not well organized (like some of this Forum posts), so songs from the same Album may be scattered in various HD folders based on download date. Of course, it's up to you, what features to implement.

Could you explain, why AAD consumes 4 to 6% of processor power at idle? Foobar2000 seldom goes that far when playing music.
Title: Album Art Downloader XUI
Post by: AlexVallat on 07 April, 2008, 11:12:58 AM

You can't sort results by accuracy, because there isn't anything generally meaningful to test against for accuracy. The sources just return the results, there is no measure of certainty about the results they return.

I can see that linking to a web page for a cover might come in handy occasionally, but it would need every source to determine and provide an Info url for each result, and I don't think it's worth it. I don't object to the functionality in principle, though.

As for the other idea, I'll re-iterate that this tool is not, and will not become, a music organization or library management tool. I can see that such an application is a useful thing to have, but this is not that application. It could be an external tool or plugin used by one for finding art, though.

I'm not sure why you are getting 5% CPU utilisation when it isn't doing anything. It's pegged at 0 on my machine here, but then my CPU is a bit faster than a P4, so I guess it might just be that the utilisation isn't high enough to register, without actually being 0. Without being able to measure the effect, I can't do much about it. There are no background threads or tasks running (until a search or browse is performed, of course), so there aren't even any specific areas to look at.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 07 April, 2008, 06:27:03 PM
I'm not sure why you are getting 5% CPU utilisation when it isn't doing anything. It's pegged at 0 on my machine here.

After downloading search results AAD uses 15 to 26% P4 capacity continuosly without visibly doing anything - see the attached screenshoot archive. It looks like fixable unnessessary .Net 3.5 WPF related activity.

Is it related to below quote from http://en.wikipedia.org/wiki/Windows_Presentation_Foundation (http://en.wikipedia.org/wiki/Windows_Presentation_Foundation) or something different:
"Periodically, MIL walks the tree and executes the rendering instructions in each node, thus compositing each element on to a DirectX surface, which is then rendered on screen. ..Microsoft recommends that the event handlers only update the properties to reflect new content for application responsiveness; the new content be generated or retrieved in a background thread."
Title: Album Art Downloader XUI
Post by: AlexVallat on 08 April, 2008, 03:26:05 AM
the new content be generated or retrieved in a background thread."
This is already the way Album Art Downloader is architected. You can tell by the way the application UI stays responsive while it is searching and downloading images. The responsiveness talked about in the Microsoft article linked to from the Wikipedia article you mentioned refers to the responsiveness of the UI - making sure that while content is generated or retrieved the buttons and controls still work, and nothing locks up. It has nothing to do with CPU utilisation, other than if it were pegged at 100% that would probably impact responsiveness a bit!

Neither WPF, nor, by extension, Album Art Downloader, have CPU utilisation as a primary concern. If there is a bug or problem that it is doing unnecessary work when it shouldn't be, or stuck in some sort of loop, I will try and fix that, but when there is no non-framework code running (and I have checked that at idle, AAD is running no code), there is nothing to fix.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 09 April, 2008, 10:18:01 AM
There is nothing to fix.

Alex, did you look at the screenshoot files on AAD CPU usage at idle I attached above? How do you explain these results? What are these linked to AAD processes continuosly running in the background using 10% + 15% CPU after 20+ Album Covers were found and the search stoped? Do you still say, after looking at the Sysinternals Process Explorer documented pics, AAD uses 0% CPU at idle? How about 25% of P4 continuosly after an extensive Cover search. And foobar2000 was designed for and works well with minor CPU usage with even P2 PCs.

In addition, when I started AAD yesterday while foobar was playing, intence CPU & power usage resulted in my MS USB Wireless Desktop Receiver been kicked off, and no longer recognized by the PC, so I lost both Keyboard and Mouse. It may well be a bug in .Net 3.5, or just insufficient resulting voltage on the USB port due to a weak (fearly standard) Power Supply, but the worst thing is - there seems to be no XP driver found anywere for the Receiver 3.1, so major Registry cleanups & reinstalls are due now, and there is no guarantee, its not damaged permanently, as its recognized now as Unknown Device, no matter what I do.
Title: Album Art Downloader XUI
Post by: AlexVallat on 09 April, 2008, 11:03:08 AM

Yes, I looked at your screenshots. No, I don't have any specific explanation of them. All I can tell you is that once all the sources have finished searching, and all the images are downloaded (including full sized, if you have that option turned on), and assuming the mouse is outside the window area, then Album Art Downloader is doing absolutely nothing. That is why there is nothing to fix. It isn't doing anything, no code is running. I can't fix code that isn't there.

If the WPF rendering system, or the garbage collector, any other subsytem of the .net framework or anything even further down is doing other work, that's not going to get fixed by me.

I am aware that foobar2000 uses very little CPU, which is is a very useful goal for an application whose purpose is to be continually running in the background without impacting system performance, and the way they have achieved it is to be admired. Album Art Downloader has different goals and priorities. If a primary goal of an application was minimal CPU and resource usage, I wouldn't write it in WPF, for a start!

I'm sorry to hear about your mouse. If your hardware is so unstable that using a high percentage of CPU is enough to break it, then that is a serious problem. It's only be a matter of time before some poorly written application or javascript hits an infinite loop and you get CPU pegged at 100% until you kill the process! It would seem unlikely that anything short of a major mains power spike would damage a USB wireless receiver - and would probably fry the motherboard on its way, so my guess would be you are all right there. Good luck with getting the driver for it.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 09 April, 2008, 11:44:01 PM
my guess would be you are all right there. Good luck with getting the driver for it.

Alex
Just to let you know - the wireless tranceiver is dead, confirmed by MS today. It's under warranty though. Regardless, another guy may not be so lucky. I'd suggest you to investigate thoroughthly with MS help, what exactly is going on at idle with your program instead of a flat denial. There should be a processor usage restriction Option when searching through local ID3 Tags, otherwise the fan circuit may fry and PC end up dead. I just checked - its running up to 25% P4 at idle after a start without search terms.
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 April, 2008, 03:11:46 AM
the wireless tranceiver is dead, confirmed by MS today
Shame, unlucky. As you seem to be implying that this is somehow my fault, let me make one thing absolutely clear. Using CPU is not a fault. If your PC cannot tolerate having the CPU running at high loads without dying, *your PC has a fault*.

While it may be of benefit to all if MS were to optimise and reduce the resource usage of WPF, and I hope they have a team working on exactly that, it is nothing to do with me. I am prepared to investigate and resolve faults in my own code, but draw the line at other people's.

If you want to restrict processor usage, try bringing up Task Manager, click the Processes tab, find AlbumArt.exe in the list of processes, right click on it and choose "Set Priority", then "Low". Although I suspect that if nothing else is wanting to use the CPU at the same time, Windows will still assign it a high load anyway - CPU is there to be used, after all.

If it is constantly running at 24% CPU after starting before doing anything other than showing the main window, something has probably gone wrong. I would suggest removing it and the .net framework, then re-installing both, but suspect that you may prefer to stop at step 1.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 10 April, 2008, 02:02:28 PM
If it is constantly running at 24% CPU after starting before doing anything other than showing the main window, something has probably gone wrong.
Not sure if this is a request for more information, anyway...

I also have a similar problem with AAD XUI.

I use it almost exclusively through foo_run (searching one album for each request - all sources selected except Local files and Trivialbeing) and usually after 2 or 3 searches it hogs my CPU at 100% and I have to stop it.

AAD is still responsive (for example, it works if I run another search) but I obviously can't do much with my PC in these conditions.

Note that the high load is there also when AAD isn't (apparently?) searching; I also just tried to open AAD (currently using v0.15.0.0) from Win Explorer and it's using from 30 to 40% of the CPU (as reported by Win Task Manager).

I didn't bother to mention it before because I thought (and I still think) my setup (Celeron 2.4 with 512MB of RAM) isn't exactly the ideal configuration for the .Net framework; nevertheless, maybe something can be done on your side to at least ease, if not solve, the issue.

Regards and thanks for your time.

Alessandro
Title: Album Art Downloader XUI
Post by: thuan on 10 April, 2008, 02:29:55 PM
I notice this problem, too and it's quite troubling (it might be the fault of WPF) that you said you have checked everything on your side. Here's an image showing AAD XUI 0.16.0.0 when it's just started with no query.
(https://hydrogenaud.io/imgcache.php?id=baf2b47256514f3a0aeea1140ac1cf8d" rel="cached" data-warn="External image, click to view at original size" data-url="http://img357.imageshack.us/img357/8151/26696900kg9.th.jpg) (http://img357.imageshack.us/my.php?image=26696900kg9.jpg)
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 April, 2008, 04:32:24 PM
I use it almost exclusively through foo_run (searching one album for each request - all sources selected except Local files and Trivialbeing) and usually after 2 or 3 searches it hogs my CPU at 100% and I have to stop it.

Now that's interesting - are you saying each time you exit Album Art Downloader and start a new instance of it, it uses more CPU? Very curious... Other than the very first time it is run and compiles the scripts, there shouldn't be any difference whether it has been run before or not.

I don't suppose any of you experiencing this problem have a development environment (Visual Studio 2008) available by any chance?

Some things to try:

1) Make sure AAD is not running. Probably best to restart windows, if some strange memory effect between runs is happening, so it is completely clear. Then, run AAD with the "/separateInstance" command arg, and see if it exhibits the same behaviour, and same memory effect between runs.

2) Enable tracing using this config file: AlbumArt.exe.config (http://www.byalexv.co.uk/temp/AlbumArt.exe.config) - put it in your AAD program folder next to AlbumArt.exe. Without doing any searches, leave AAD running for a bit, then close it, and have a look to see if there is anything in the trace log (which will be called tracelog.txt), or send it to me to look at.

I'm still not convinced there will be anything that can be done about this, though. Thuan, could you let me know what CPU and memory you have? It would be useful to know if this is a problem for anyone on a reasonably high spec machine, say Core2 with 1Gb of RAM or upwards.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 10 April, 2008, 06:20:24 PM
are you saying each time you exit Album Art Downloader and start a new instance of it, it uses more CPU?
Not exactly, sorry for not being clear. Actually after the first search I do NOT close AAD, I simply go back to foobar2000 and launch another search (which displays its results in the already running AAD instance).
Quote
I don't suppose any of you experiencing this problem have a development environment (Visual Studio 2008) available by any chance?
Nope, sorry, but I'm willing to try if you think it may help (provided you give me some guidance and my PC has enough power for that).
Quote
run AAD with the "/separateInstance" command arg, and see if it exhibits the same behaviour, and same memory effect between runs.
1) first run: AAD CPU between 19 and 27
2) run 2nd instance with same command arg without closing the first: both tasks between 27 and 33
3) closed 2nd instance: first instance back to initial values
4) closed first instance and run one more time: no difference
Quote
2) Enable tracing using this config file
It only contains the following line:

AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.15.0.0

Even after a reboot I'm unable to reproduce the high load reported in my previous post: now running AAD without doing any search only consumes 20 - 30% of my CPU.

One more clue perhaps; if I minimize AAD its CPU usage goes down to 5 - 8%.

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: thuan on 10 April, 2008, 10:15:06 PM
Then I guess this computer is suffice, it's a Core 2 4300 1.8GHz, 3GB of RAM, ATI HD2400XT, running Vista SP1 and everything is up to date. I have never noticed this before as I haven't actually taken a look at those monitor software when using AAD and my computer is fast enough to feel nothing. Usability wise I don't really care, but it should indeed be checked IMHO. BTW IIRC, when I reported the freeze problems before, there's no CPU usage with ghost instances.
I don't code on VS so of course I don't have it. I wonder if there's a VS2008 express as of now and if it is sufficient to work on AAD. If so I can install it.

EDIT: atiumdag.dll is ATI directx universal driver (this makes me think it's a redrawn issue). Also this program also load DXVA dll of my graphic card and some other DirectX dlls that normal Windows program doesn't load. Is this because it's a WPF program? I don't know much about .NET desktop application.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 April, 2008, 05:22:28 AM
AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.15.0.0

Hmm... can you confirm you are running version 0.15, not 0.16 then?

The fact that nothing else appears in the log suggests that AAD itself is not doing anything unexpected, which unfortunately doesn't give me a target to fix.

The /separateInstance test indicates that the problem is not with the cross-process communication pipe, but as I'd misunderstood mobyduck's report this was much less likely anyway.

What is interesting is the minimising thing. That would strongly suggest that the CPU usage is coming from WPF rendering.

Thuan's system specs indicate that this is nothing to do with CPU or memory limitations, but do point to this being a WPF rendering issue.

WPF does use hardware acceleration for rendering itself, falling back on software rendering where necessary, which would explain why it is loading the DirectX dlls thuan mentioned.

I think there is no need to look at it in Visual Studio now, as I'm confident we've narrowed down the problem to the WPF rendering. My idea would have been to run under the debugger, then see if any code was actually running while the CPU usage was up, but I'm pretty sure there won't be, as the CPU usage will just be from the WPF rendering. You are, of course, welcome to try anyway, the source can be downloaded from the "XUI" subfolder of the SVN tree (https://sourceforge.net/svn/?group_id=187008).

Thanks for the information,

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 11 April, 2008, 12:11:48 PM
The fact that nothing else appears in the log suggests that AAD itself is not doing anything unexpected, which unfortunately doesn't give me a target to fix.

The point however remains:

- most developers take care of their customers by NOT-IMPLEMENTING MS latest software releases until they are relatively bug free with fixes available. Large pull of foobar2000 fans would be just as happy with AAD based on .Net 2.0 or 3.0, if it doesn't cripple their low end PCs;

- When searching local files with AAD File Browser using ID3 Tags, a "Work in Background" OR "Limit CPU Usage" option in AAD Prefs would prevent a low end PC from being fried or hanged on searching large music archives, and feels like a mandatory option to avoid client liability. So far AAD doesn't even have a proper warning in Readme about this gream reality.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 April, 2008, 12:48:45 PM

OK, a few points to answer here.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 11 April, 2008, 01:19:29 PM
I'm not really that concerned about what other different software people might want.

It's not about new features users may suggest - and normally developers say "Thank you" for those. It's about safety of using your program. Basically you say - use it on a high end PC if you want, or don't use at all. AAD will control user's PC experience, and not the other way around. Stop AAD, when you feel your PC is about to fry when you hear extreme fan noize.

Would it be more reasonable to allow USER to choose still run AAD but at slower pace by adding such option in Prefs?

There is nothing personal here. As I said, I like your program. All foobar plugins & extras are some kind of creativity & experience gain & Resume improvement exersize. But most developers are smart enough to still care about those who are supposed to use their fruit. Otherwise - the outcome may be just opposite.
Title: Album Art Downloader XUI
Post by: thuan on 11 April, 2008, 01:52:33 PM
Stop AAD, when you feel your PC is about to fry when you hear extreme fan noize.

It is your reponsibility to provide your computer with adequate cooling system. You will run into trouble sooner or later anyway if you keep your computer that way.

Would it be more reasonable to allow USER to choose still run AAD but at slower pace by adding such option in Prefs?

Yeah, he might do it, or he might not. If he won't then stop pestering him. But to be honest, if your computer satisfy point above then is this really important.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 April, 2008, 01:56:46 PM

Oh, I'm happy for feature suggestions, bug reports, and other comments, and am grateful for those received. Many feature suggestions that have been made in this thread have been implemented, and all bug reports have been addressed. Where something is not a feature suggestion, but is instead a suggestion for an entirely different piece of software, I have said so.

For the final time, and I won't bother saying it again: using high CPU load to performing a task quickly is not unsafe, or even undesirable. If your PC has extreme fan noise or overheating problems at high CPU loads, then you need to fix your PC.

No software that I am aware of, except some of those designed to run continuously in the background, offers the user the option to have it perform slowly, and I see no reason that this software should be different.

I never said that you have to use AAD on a high end PC, or not at all. Obviously, if you do, it will run better, though. I'm not sure what the minimum specs for running it are. If anyone wants to list here (or PM me) the lowest specced machine they've run it on and, whether they consider it to be usable on it, I'll collate the results and put a minimum recommended spec to the first post and wiki page. CPU, Memory and Graphics Card will be the biggest factors, so if you are going to send me a spec, please include those details.

Alex
Title: Album Art Downloader XUI
Post by: Mondo on 11 April, 2008, 03:29:05 PM
i'm running a 2.17ghz amd athlon with 512MB of ram and the program is almost completely unusable. it opens up at about 30MB of memory and escalates from there until it gets into 400+MB 10 seconds later. interface is almost completely unresponsive, usually i click something and sit there hoping my mouse click went through. i know my computer is pretty outdated, but is the program supposed to be using this much memory? if so, i'd say a minimum at 1gb of memory is pretty safe to put on your site.
Title: Album Art Downloader XUI
Post by: arnymars on 11 April, 2008, 04:20:01 PM
It is your reponsibility to provide your computer with adequate cooling system.

This is NOT a really old Win98 PC, like many foobar2000 users still enjou playing music on. If it were a self-assembled box modded by a clueless teen, I wouldn't even mention this problem.

I am running AAD on a stock non-modified huge production volume Medion PC: P4 2.66 Mgz, NVIDIA Ti4, 512 Mb, Win XP SP2. It's somewhat outdated, but hopefully correctly balance-engineered and still adequate for most home user's tasks except for some HD Video Playback & Editing. It's definitely adequate for Audio Playback, and should be sufficient for related MINOR service tasks like an Album Cover search. Such service programs should be correctly designed to not interfere with the prime task of Music Playback enjoument or become a safety or property loss hazard. In fact, same System Requirements or User adjustment options are expected to harmonize it with foobar2000 and other players.

And to be fully objective, some AAD behaviour may be a result of MS .Net code bugs, but other - resulting from limited developer knowledge of new .Net functions. Communication with MS developer teams - and there are many ways for that, including MS programmers' blogs - can help more in alleviating the issues found in beta testing like this then simply flat denials to improve the program.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 April, 2008, 04:53:21 PM
P4 2.66 Mgz, NVIDIA Ti4, 512 Mb, Win XP SP2
Thanks, arnymars - would you like me to note those down as 'barely usable' or 'unusable'?

2.17ghz amd athlon with 512MB of ram and the program is almost completely unusable.
Thanks, Mondo - could you tell your graphics card too, if you know it?

is the program supposed to be using this much memory?
Memory usage is very hard to measure properly for .net apps, as the framework will tend to only release it when something else needs it. As a very rough guide, my figures are that AAD, with all bundled scripts present, should use up to about 40Mb at startup, and be stable at that figure until a search is performed. Each additional open (empty) search or browse window adds about 2Mb.

After searching, it will use an additional 1Mb or so for each displayed thumbnail, plus a small amount for each result not within view. As a thumbnail is scrolled out of view, the memory used by it is reclaimed, so although memory usage will spike while scrolling, it should settle back down once only the a few thumbnails are visible again.

For each full size image downloaded (of which there may be several if the "download full size images automatically", add on around 10-20Mb, depending on the size of the image. This is reclaimed when the search window is closed, or the results discarded by a new search being performed in that window.

With that in mind, your opening figure of 30Mb is entirely within expectation (better than I see here, in fact). 400Mb is higher than I would expect, but I suppose is possible depending on the number of open search windows, number of thumbnails displayed, and number of full size images downloaded.

If you have only 512Mb of memory, I would recommend deselecting all but your favourite one or two sources, and set those to return only 3 or 4 results each, and turning off any automatic downloading of full size images. Your memory usage should then be far more manageable, and if you don't find a good art result for a search with those settings, you can always select additional sources for that particular search, and just click Search again to search those too.

For anyone who finds their system is not up to the task of running the Album Art Downloader XUI ui (or who finds that the UI is too bloated and takes up too much of their resources, if you prefer), then you might like to consider using the command line interface, aad.exe. You won't be able to pick a cover from a list of thumbnail previews, or scan media files for missing artwork, but it will perform the basic service task of finding and fetching a cover without using much CPU or memory. It is best suited to being called as an external tool by another program, like foobar's foo_run.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 11 April, 2008, 06:31:16 PM
FWIW, the program uses a fair amount of CPU here (~20%) when open, but idle.  However, when minimized, the CPU usage all but disappears.

Memory usage is more than what I would think (~23K), but no big deal on a modern computer.

This is not the type of program to leave running, so I honestly don't see the problem.  Just close it when you're done. 
Title: Album Art Downloader XUI
Post by: thuan on 11 April, 2008, 09:56:47 PM
@Alex: I'm thinking that is it possible to deactivate refresh on certain UI control in WPF?

@arnymars: Likely you have a Prescott CPU, I have seen ppl try to use it to cook omelet so it's not surprising (a better choice at the time you bought your computer is one with Athlon XP or better Athlon 64 single core which beat this CPU hand down). Both the intel fan and heatsink come with this CPU iteration and a lot of brand name computers do not have sufficient cooling systems for it (CPU automatic throttles down and extreme fan noise). You're better off with an after market heatsink and fan if it's possible to install them (certain brand name computer makes it impossible to do this). This is why I always self-assemble my box as I have a freedom to choose good components that last me long with a stable computer. In any case, if you have enough knowledge on computer parts and building your own computer is possible (not in the case building thousand of computers for your office which is impossible to assemble on your own), a self-assembled box is infinitely better than any brand name box whether the invidual is a teen or not IMHO. As far as serious .NET application out there, most of them you will need to have 1GB or above to run them adequately.

EDIT: arnymars, forgot to tell you this, likely this is the last time we should talk about it. No need to beat a dead horse to dead anymore.
Title: Album Art Downloader XUI
Post by: arnymars on 12 April, 2008, 01:33:37 AM
this is the last time we should talk about it. No need to beat a dead horse to dead anymore.

My dear, if you believe Forum Rules were violated, you are free to ask the thread moderator to take action. Otherwise, pls don't tell others what to do. Some people may consider just opposite - continuosly alert users about possible damage to their PCs from using this soft. Whether you consider this program adequate or not to fit mass market PCs, and in harmony with foobar2000 in system resources use - you are free and welcome to express your opinion. Beyond that - usually people give advice when they are asked to.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 April, 2008, 03:37:29 AM
Possible fix for CPU usage while idle: AlbumArtDownloaderXUI-test_cpu_fix.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix.zip).

Could someone who's experiencing CPU usage while idle please try extracting the contents of the above zip over their AAD program folder and letting me know if it has made any difference? My profiling tools say that it theoretically ought to.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 12 April, 2008, 04:18:40 AM
Possible fix for CPU usage while idle: AlbumArtDownloaderXUI-test_cpu_fix.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix.zip).

Could someone who's experiencing CPU usage while idle please try extracting the contents of the above zip over their AAD program folder and letting me know if it has made any difference? My profiling tools say that it theoretically ought to.

Works for me!  It now pretty much stays on 00, occasionally jumping to 01.  That's with it open, but idle.  I said before that caused about ~20% usage, but I tested it again before copying these files over, and it actually was jumping all over the place, sometimes into the 30s.  20% probably was about average, but it was hard to tell, because it was changing so much.

Thanks (again) for your efforts!
Title: Album Art Downloader XUI
Post by: Mondo on 12 April, 2008, 04:19:46 AM
i will give that a test tomorrow. i just wanted to chime in to say that if i run this at low priority level it responds how i imagine it should and memory sits around 100MB.
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 12 April, 2008, 04:38:15 AM
To add to what I reported earlier, after doing a search of a pretty popular album, with all search engines selected, CPU usage again jumps all over the place, as high as into the 30s, even after minimizing.

Just to reiterate, the old version did that even before searching (at least while open - minimizing mostly eliminated it).  The new version uses virtually no CPU even while open, prior to searching.

So it looks like you're on the right track, but in some ways it's worse now (since minimizing no longer helps).

Not complaining;  just reporting.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 April, 2008, 04:59:47 AM
To add to what I reported earlier, after doing a search of a pretty popular album, with all search engines selected, CPU usage again jumps all over the place, as high as into the 30s, even after minimizing.
Sorry, but just to be clear, do you mean while it is actually searching, or that it stays high after the search completes? (the Stop All link will disappear once all sources have finished searching)

During searching, the CPU usage is expected, but if it is then staying there after the search completes, I'll investigate further.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 12 April, 2008, 05:49:42 AM
Hi Alex,

I have been enjoying this amazing development of AAD XUI.

I have a couple of feature suggestions to increase the quality of the artwork that's downloaded using AAD command line.

/minRes
/squareFactor

Note: These option names are for demonstration only.

For example:

/minRes 600

would filter results to artwork with only Width >= 600 or Height >= 600
So either Width or Height should meet minimum dimensions.

/squareFactor 0.9

could make sure Width is almost close to Height.

squareFactor can be described as smaller dimension divided by the bigger dimension.

If the artwork is 600x593 thne the squareFactor for the artwork is 0.98833333 which is higher than 0.9 (almost square) so this can be included

If the artwork is 403x600 then the squareFactor for the artwork is 0.67166 which is less than 0.9 (not close to a square) so this will be excluded from the results.

squareFactor 1.0 is a perfect square: 500x500, 600x600 etc.

My expectation for AAD to have

Code: [Select]
aad.exe /artist "Artist Name" /album "Album Name" /minRes 600 /squareFactor 0.9


so AAD could filter results to artwork with Width or Height at least 600px and Square Factor at least 0.9

Best Regards,
McoreD
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 April, 2008, 06:54:47 AM
I have a couple of feature suggestions to increase the quality of the artwork that's downloaded using AAD command line.

/minRes
/squareFactor

Thanks for the suggestions. /minRes already exists, but I called it /minSize. It behaves the way you described, though.

/squareFactor sounds like a good idea, I'll probably put that in the next version.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 12 April, 2008, 06:57:53 AM
I have the same result as KarnEvil9, virtually no CPU usage when open AAD and do nothing. But after doing a search and finish, it is again has CPU usage like before in the picture in one of my previous post.

I have a bunch of computers beside my main computer over here:
Athlon X2 4200+ 1GB Vista SP1 using onboard nvidia 6100;
a laptop with 1.7GHz Dothan Pentium M with 512 MB running XPSP2 with 945G onboard graphic;
a T7200 laptop with 2GB RAM Vista SP1 and onboard 965G
all of them run this program adequately. I have a P3 550 256MB RAM with XP on it, too. But I guess I don't need to test this program on it.

@arnymars:
What I meant by that is: if I can not convince you to change your point of view then it'll be pointless to continue talking. I was naive thinking that you would understand as you still kept your false assumption on this software and how a computer should work from my point of view. I'm sorry that my kindness and advice was unaccounted for and directed at the wrong person or any inconveniences that my posts directed to you have caused. Anyway, I will stop talking to you on this case, don't worry and peace.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 April, 2008, 08:25:12 AM
I have the same result as KarnEvil9, virtually no CPU usage when open AAD and do nothing. But after doing a search and finish, it is again has CPU usage like before in the picture in one of my previous post.

OK, so I'm on the right track then, but not quite there. Try this one: AlbumArtDownloaderXUI-test_cpu_fix_2.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix_2.zip).

Thanks also for the information on your PCs. The one I find particularly interesting is the Pentium M laptop. The Dothan Pentium M is roughly equivalent in performance to a good P4, I believe (correct me if I'm wrong), and 512Mb would seem to me like a sensible lower limit. I can only assume that if it is running OK on that laptop, but unusable on Mondo's Athlon or anymars' P4 (both also at 512Mb), it's probably down to how much work WPF can offload on to the GPU. I don't really have any experience with the Intel onboard graphics - would you say the 945G was a reasonably good graphics chipset, or more entry-level? anymars is running a GeForce 4, which I don't think support DX9 - which means WPF would have to do most, if not all, of the rendering work in the CPU instead. I can see how that would make a difference.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 12 April, 2008, 08:27:51 AM
Thanks for the suggestions. /minRes already exists, but I called it /minSize. It behaves the way you described, though.

/squareFactor sounds like a good idea, I'll probably put that in the next version.

Alex


Oops.. my bad:

Quote
/minSize    Specifies the minimum size of  (/minSize 300)
              image, in pixels, to use.
              Both horizontal and vertical
              dimensions must conform.
              May be abbreviated to /mn      (/mn 300)


I thought it was fileSize. 

That's GREAT news Alex. Thanks for the fast response! 

Cheers,
McoreD
Title: Album Art Downloader XUI
Post by: arnymars on 12 April, 2008, 09:54:26 AM
Alex,

I tested this fix, and it looks very promizing. First AAD window, when open without search terms from within or outside of foobar, draws no CPU resources continuosly whatsoever. When opened with search terms, it stops drawing the resources soon after the search is completed. However, each additional open AAD instance continues drawing CPU resources at 1.5% periodically indefinitely whether empty or showing Search results, while it's active window on the screen. Once passive (you switch to a different program or AAD window), it appears to stop drawing the resources. If none of AAD instances is active on the screen, they all total to 1.5% but only seldom. It's almost perfect in this aspect now, but I feel can be polished a bit. If you are kind enough to give a user without new or any Graphics Card a bit more control over AAD habits in ID3 Tag local search, it will really solve whole this issue for all (as opposed to attempts of simply shutting up users on the forum).

thuan,

I do tend to assemble my own PCs, but also use stock PCs, depending on purpose. I'm well aware of deficiencies of price designed PCs, and CPUs of various generations, even without overclocking. However, this whole "weak PC" issue is irrelevant here, since in my view programs advertized as foobar plugins or helpers should adhere to foobar System Requirements. As well, any program can be improved, as we all know, and bug reports are merely encouragement for this. And on top of this, AAD is a good program.
Title: Album Art Downloader XUI
Post by: thuan on 12 April, 2008, 10:22:35 AM
Sorry, I was wrong that laptop has a 915G, my main computer is the one that has 945G (but I use a dedicated card now). The 915G and 945G are nearly identical just different in clock speed and different vertex shader versions that they support. 945G supports vertex shader 3.0 (915G supports version 2) and a little more powerful in term of raw power as it has higher core clock. They both do not have support for vertex shader and HW T&L in HW that a GF2/4MX or higher have. Performace wise they are POS to be honest, should be lower than a GF4MX440 a DX7 class card even though they are DX9 capable. As for the CPU, yes you're right it should be as powerful as a good P4.
Performance of AAD on this system is of course not as fast as my main computer and the T7200 laptop but still acceptable IMO. On the Athlon X2, it is not much different from my main computer and the T7200, maybe because I haven't used up all of my RAM yet and the CPU is roughly about the same in power.

Also, I have a long standing problem with your program that I told you some time ago, but it seems like you forgot. If I launch a search then another right after and turn off the first one, the 2nd instance (not really as you only have one process) sometimes freezes. This also happens when there're more than 2 windows, if I close one of old ones the newer ones will randomly freeze. It might unfreeze if there's some change in the UI though.

I have tested your new build it's still the same as the previous test build.

EDIT: somehow I kept getting the old binary however I tried, can you rename the zip?
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 April, 2008, 10:57:35 AM
Also, I have a long standing problem with your program that I told you some time ago, but it seems like you forgot. If I launch a search then another right after and turn off the first one, the 2nd instance (not really as you only have one process) sometimes freezes. This also happens when there're more than 2 windows, if I close one of old ones the newer ones will randomly freeze. It might unfreeze if there's some change in the UI though.
Is [a href='index.php?act=findpost&pid=549182']this[/a] the problem you mean? I thought I'd fixed that in 0.14, but it doesn't seem to match your new description exactly. If it's a different problem you are describing, that you reported to me and I failed to acknowledge, then I apologise for missing it. I'll see if I can reproduce it from the description you've given here, but if there are any other details from the original report, please pass those on again.

EDIT: somehow I kept getting the old binary however I tried, can you rename the zip?
OK, it's now AlbumArtDownloaderXUI-test_cpu_fix_2.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix_2.zip) (AlbumArt.exe inside should have a modified timestamp of 2008-04-12 13:00).

However, each additional open AAD instance continues drawing CPU resources at 1.5% periodically indefinitely whether empty or showing Search results, while it's active window on the screen.
If I've understood right, you run AAD, and it's fine. After completing a search, it's fine. Opening a new search window (through the menu?) results in low, but non-zero CPU usage while the new window has the focus? Does closing the new window return usage to zero? I haven't been able to isolate this case in my profiler tool.

I'll see if I can put together a test build that drops the priority of the file browser search to background when the file browser window is minimised (which will also avoid CPU usage rendering the results as they come in), and you can let me know if it makes enough difference to CPU usage to be worthwhile.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 12 April, 2008, 11:27:39 AM
Great job Alex!

All my problems seem solved with zip #2.

When I launch AAD CPU stays at 0-3%; I also tried 3 or 4 searches through foo_run and CPU usage is back to 0 when the search is over (and I have the impression AAD uses less resources than before also when seeking, though I'm not really sure).

Case closed for me.

Alessandro
Title: Album Art Downloader XUI
Post by: thuan on 12 April, 2008, 11:28:05 AM
I reported the freeze problem in this post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=549175), the last paragraph. There's nothing more I can say about it though.

About the CPU fix, it really is still the same as the previous one for me.

EDIT: update on the CPU usage problem, it's good on the XP Dothan laptop and not on my main Vista machine (the one with ATI card) whether Aero is on or off. I will try to test the other machines when I can. The T7200 laptop is doing something and that AMD machine is currently in used by other.
Title: Album Art Downloader XUI
Post by: Mondo on 12 April, 2008, 01:31:19 PM
update seems to fix the problems. memory usage still sits at about 200M even after doing a few searches and closing all the search windows to just have the file browser open. i suppose running it through foobar would help.. i just need to learn how to do it.
definitely a solid update though!! i've been using it for about an hour now without it really inhibiting my progress at all.
oh yeah, my graphics card is an ati radeon 9600.
Title: Album Art Downloader XUI
Post by: arnymars on 12 April, 2008, 05:33:50 PM
Opening a new search window (through the menu?) results in low, but non-zero CPU usage while the new window has the focus?

It looks, like any AAD Search window in focus or visible on screen (unobstructed), even a single open one, whether with or without search results, whether open from AAD menu, foobar or Win Explorer, draws 1.5% every 2-3 sec indefinitely without mouse over activity. With more AAD windows open, and one still in focus & several (partially) visible, frequency of CPU usage increases, while staying at 1.5% and slowly going to 1.5-3+% with 6 AAD windows open, no mouse over. Once all windows are out of focus and fully covered by another program window (but not minimized), AAD draws 0% CPU total regardless of number of windows with or withour search results. In focus File or Foobar Browser windows don't draw CPU at all. It all looks like standard intelligent WPF routing, but may possibly be further minimized.

Timely memory release may be another issue to look at. If done correctly, it should be covered by .Net 3.5. "As long as there exists a reference to an object, which might be either a direct reference to an object or via a graph of objects, the object is considered to be in use by the CLR. When there is no reference to an object, and thus cannot be reached or used, it becomes garbage. However, it still holds on to the memory allocated to it. .NET Framework includes a garbage collector which runs periodically, on a separate thread than the application's thread, that enumerates all the unusable objects and reclaims the memory allocated to them."

As to opening windows minimized, as done in this test build, this option is traditionally reserved for a user in Prefs, and not everyone likes it, as AAD performs some entertainment function as well, complementing foobar in that, so attractiveness - nice Covers apear from nowhere - and immediate visual access to Covers feel important.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 April, 2008, 06:08:16 PM
I reported the freeze problem in this post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=549175), the last paragraph. There's nothing more I can say about it though.
Can you tell me if the old windows that you close have currently running searches, or if closing idle windows has the same effect? If it is closing currently running searches, I have added a possible fix for it to Test Build 3 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_3.zip).

It looks, like any AAD Search window in focus or visible on screen (unobstructed), even a single open one, whether with or without search results, whether open from AAD menu, foobar or Win Explorer, draws 1.5% every 2-3 sec indefinitely without mouse over activity.
Could you use the tab key to move focus out of the text boxes (for example on to the search button), then leave the mouse outside the window check to see if it is the same? The profiler is telling me that the only area being redrawn on an empty idle AAD search window now is flashing the text-insertion caret in the textbox. I've got to say, it seems unlikely that this will be using 1.5% CPU, but after that, I'm out of ideas.

Timely memory release may be another issue to look at.
Can you be more specific about where? I had a memory leak hunting session at around version 0.7, and while I'm sure the major ones are still plugged (closing a window or clearing search results releases the memory used), there might be minor ones I've missed. I've had a look at the usual suspects, though, and everything seems to be being released when it should be.

As to opening windows minimized, as done in this test build, this option is traditionally reserved for a user in Prefs
I'm not set on using that as a UI mechanism yet. If low-priority file tag scanning goes in at all, there will be some way of indicating that this particular operation should be treated as a background task to run at a low priority (rather than a more general global option). For the moment, minimising the window indicates that it should work in the background. Windows will never be automatically minimised or opened minimised - that will always be a user-initiated action.

Test Build 3 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_3.zip) sets the file scanning thread to low priority while the file browser is minimised. Could you try running it and let me know if that reduces the CPU load significantly for you? It doesn't for me, but then it only runs at about 50-60% CPU here anyway, so there's another 40% or so idle CPU time available for other normal-priority threads before it would take share away from the low priority ones anyway.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 12 April, 2008, 07:37:11 PM
Alex, I think you exactly right about the cursor - removing it from the window in focus lives AAD with 0% CPU usage regardless of the number of visible windows with or without search results. Still it looks like WPF overhead, for a cursor to draw 1.5-3% CPU every 2 sec. But this problem seems to be resolved.

Can this Mondo's RAM & CPU report help: "i'm running a 2.17ghz amd athlon with 512MB of ram and the program is almost completely unusable. it opens up at about 30MB of memory and escalates from there until it gets into 400+MB 10 seconds later. interface is almost completely unresponsive, usually i click something and sit there hoping my mouse click went through. i know my computer is pretty outdated, but is the program supposed to be using this much memory?". "Memory usage still sits at about 200M even after doing a few searches and closing all the search windows to just have the file browser open". " if i run this at low priority level it responds how i imagine it should and memory sits around 100MB" ?
I'll try to do more tests a bit later.

Pointers Wiki (http://en.wikipedia.org/wiki/Data_pointer)
Memory Management Reference (http://www.memorymanagement.org/)
.NET Framework Developer's Guide - Garbage Collection (http://msdn2.microsoft.com/en-us/library/0xy59wtx.aspx)
Garbage Collection FAQ (http://www.iecc.com/gclist/GC-faq.html)

I'm afraid, "low priority" search won't do much (http://xona.com/2004/07/22.html) from heat standpoint, if there are no other programs running (foobar excluded as it draws very little), so some kind of Application (http://msdn2.microsoft.com/en-us/library/ms998530.aspx) & Resource Throttling (http://msdn2.microsoft.com/en-us/library/ms998544.aspx) approach is needed. Low priority will help to use other programs simultaneously, if one is willing to allow extreme fan noize & PC damage consequences. However, a lot of of people would feel easier, if task throttling is implemented. " The general tuning (http://msdn2.microsoft.com/en-us/library/ms998583.aspx) figure for the threshold limit for processors is 85 percent". Some MS Blogs (http://weblogs.asp.net/scottgu/archive/2008/02/19/net-3-5-client-product-roadmap.aspx) & Forums are good places to ask.

See also:
.NET Framework Developer's Guide - Managed Threading (http://msdn2.microsoft.com/en-us/library/0xy59wtx.aspx)

This is great and unusual experience for a plugin type program. Despite newer models dominating sales, P4 replacement at many homes is slow, especially in the 3-d world. And everyone loves music, with P2P sharply increasing availability. Foobar is still considered an easy choise for lossless formats playback, despite "unfinished" feel. Having completed music collections with Lyrics and Covers is a great hobby. As I mentioned earlier, most audiophiles would want to find more info about an Album and its Cover, if easy links are provided with found covers. I can't think of another App with such a good fit for this as AAD.
Title: Album Art Downloader XUI
Post by: thuan on 12 April, 2008, 11:13:03 PM
Alex, the freeze issue happens whether the old window is searching or idle. Your latest build doesn't fix it in either case for me. As for the CPU usage problem, it is still the same for me on any of my Vista machine, CPU usage goes wildly again after a search.

EDIT: CPU usage on XP (Dothan) is fine.
Title: Album Art Downloader XUI
Post by: AlexVallat on 13 April, 2008, 11:59:39 AM
Alex, I think you exactly right about the cursor
OK, thanks for letting me know. It's a little disappointing that showing a flashing text insertion cursor uses a measurable amount of CPU, but at least the mystery is solved.

Mondo: "Memory usage still sits at about 200M even after doing a few searches and closing all the search windows"
Yes, that was helpful. It turns out a leak was introduced in 0.11, which I have now managed to track down and eliminate. Test Build 4 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_4.zip) should now always release a search window's memory when it is closed.

Thanks for your links. AAD is a fully managed-code application, though, so information about pointers doesn't apply in this case. If anyone is curious, I've found SciTech's .NET Memory Profiler (http://memprofiler.com) to be invaluable in tracking down managed object leaks (objects expected to be free for garbage collection, but which are still being held on to due to unexpected references to them).

I'm afraid, "low priority" search won't do much (http://xona.com/2004/07/22.html)
Yeah, I figured it probably wouldn't do much, as it didn't sound like there was anything else competing for CPU at the time, but I thought it might be worth a try, as I was doing a test build anyway. I'll remove it. At least it proves that the file scanning is not taking CPU from anything else that needs it more, just making good use of the CPU resource made available to it.

I appreciate the time you took looking up links on throttling and tuning, but I'm afraid they all seem to relate to server applications, where different priorities apply, and scaling must be taken into account.

This just isn't the case for a single-user desktop application performing a user-initiated foreground task. I'm not going to get into all this again, but suffice it to say, I won't be writing any throttling code.

the freeze issue happens whether the old window is searching or idle. Your latest build doesn't fix it in either case for me. As for the CPU usage problem, it is still the same for me on any of my Vista machine, CPU usage goes wildly again after a search.
Fair enough - if the freeze can occur even when not searching, then the fix I put in to test build 3 wouldn't have had any effect. I'm still trying to find any reason there might be a freeze from closing an idle window, but haven't managed to come up with anything yet, sorry. I'll keep looking, though.

Also, lacking a Vista machine to test on, I'm not sure what I can do about it. If you have the time and patience, you can download WpfPerf (http://wpf.netfx3.com/files/folders/10880/download.aspx) (documentation (http://msdn2.microsoft.com/en-us/library/aa969767.aspx)), then using the Perforator tool check to see if the Dirty Rect Addition Rate is non-zero when idle after completing a search. If it is, check the "Show dirty region update overlay" checkbox. Hopefully this will result in some coloured rectangles over whatever area is being re-rendered - if you send me a screenshot of that, I can see if I can figure out why that area might be being re-rendered when it is supposed to be idle.

Of course, I'd understand if you don't want to bother, but I thought I'd mention it anyway, as it's probably the only way to get anywhere with a Vista-only problem.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 13 April, 2008, 10:51:27 PM
Of course, I'd understand if you don't want to bother, but I thought I'd mention it anyway, as it's probably the only way to get anywhere with a Vista-only problem.

As you're willing to help fix the problem, at least I should be able to do that, shouldn't I. It's to improve the program I use after all. Here it is:
(https://hydrogenaud.io/imgcache.php?id=817ea478a6e73c42f448dc2067cfffca" rel="cached" data-warn="External image, click to view at original size" data-url="http://img399.imageshack.us/img399/1440/aadyn1.th.jpg) (http://img399.imageshack.us/my.php?image=aadyn1.jpg)
The part inside the RED rectangle I drew is the part keep updating after a search. With the rectangle inside the cover sources updates the most, the 2nd in frequency is the search button and the least is the remaining part. When starting up and doing nothing, an inactive AAD window does have Dirty Rect Addition Rate = 0. And here's the data frame inside WpfPerf:
(https://hydrogenaud.io/imgcache.php?id=007741d24f3cfb24ca511d7b4c79f5b5" rel="cached" data-warn="External image, click to view at original size" data-url="http://img339.imageshack.us/img339/5351/wpfperfuw7.th.jpg) (http://img339.imageshack.us/my.php?image=wpfperfuw7.jpg)
Thank you for taking your time looking into my/users' problems. It's hard to find someone, working on a FOSS project such as this, who is willing to help and tolerant as you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 April, 2008, 08:37:57 AM
Wow, 816 dirty rect addition rate! I need a faster pc... :-)

OK, I've had another stab at preventing the sources area from redrawing when it shouldn't. I'm going to assume the Search button redrawing is a side-effect of that, as I can't think of anything that would cause the button to redraw itself. Try Test Build 5 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_5.zip) and see if that resolves the problem after performing a search. If it doesn't, could you let me know if any of the sources have "test: true" written under them? They should all say "test:false", if everything is working the way I am hoping.

For the freezing problem, does it still draw the window at all? Or do you get a black or corrupted display? If it is drawing the window, try moving the mouse over Options link, and see if the cursor changes to the hand pointer, and then hover over the sort triangle, and see if a tooltip pops up. If the tooltip does pop up, does the window then become responsive afterwards? How about minimizing and restoring the window, does that unfreeze it? I just need to know if I'm looking at the right effect or not. Does it ever happen if you open new window within AAD itself, rather than using foo_run to trigger it?

Alex
Title: Album Art Downloader XUI
Post by: thuan on 14 April, 2008, 09:41:29 AM
With this new test build, it seems like it even redraws faster after a search, all sources return test:false though. And yes, you're right about the cover sources part is the main problem as only that part is redrawn when AAD is inactive after a search.

I found some new bugs in this test build:
- Do a search and when the search is still taking place, doing another search with the same search term by either click on the search button or press enter inside the text box completely freeze AAD.

- Launh first search, then launch a 2nd search, close down the 2nd window when the first one still searching will completely freeze AAD.

About the freeze issue:
Quote
For the freezing problem, does it still draw the window at all? Or do you get a black or corrupted display?

Yes it still draws the window.
Quote
If it is drawing the window, try moving the mouse over Options link, and see if the cursor changes to the hand pointer, and then hover over the sort triangle, and see if a tooltip pops up. If the tooltip does pop up, does the window then become responsive afterwards?

No, the cursor doesn't change to the hand pointer at any place.
Quote
How about minimizing and restoring the window, does that unfreeze it?

Doesn't do any good in older versions, the latest test build is reponsive afterward though.
Quote
Does it ever happen if you open new window within AAD itself, rather than using foo_run to trigger it?

It happens in either case.
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 April, 2008, 12:30:23 PM
Hmm... Windows Vista progress bars are continuously animated, aren't they? It would seem that they are being animated by WPF even when they aren't visible too. Hopefully this Test Build 6 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_6.zip) will finally lay them to rest and stop them animating. If it doesn't, I might need some holy water and a silver stake, just to be sure.

I've fixed the second-search freezing bug in this test build too, thanks for pointing it out.

In this test build I've also tried a couple more ideas to help with the freezing bug from the answers you gave me, so let me know if anything improves there too, please.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 14 April, 2008, 01:08:51 PM
Yes, progress bars in Vista are continuously animated.
Fortunately, it seems like you have brought me holy water and a silver stake. This version seems to work fine CPU usage wise and the freeze issue wise. I only did a few searchs though. I will try more tomorrow. It's late night over here already.

EDIT: Ok, in this version you managed to make everything goes to sleep when searching is finished. "Dirty Rect Addition Rate" does equal zero. There's a small CPU usage (well in a RARE case I have seen it goes nearly to 10% on my Core 2, but haven't encountered this behavior again) in AlbumArt.exe thread, as shown in Process Explorer, happens SOMETIMES whether the windows are active, inactive or minimized, though. If you're willing to continue investigating, I'm able to help, too.

Another small problem, when changing the Album search string (mostly delete some unnecessary words, it's not a new search string so most of the time AAD uses the old window) and do a search again during the original search is taking place, the GUI may temporary freeze. It will be reponsive soon though with the same trigger as in previous freeze problem. Other than this, the GUI doesn't freeze now.

EDIT2: It seems like I found out the cause of the freeze issue I talk about above. It only happens either when you stop the search using the stop all button or do another search that satisfies certain criteria making it happen in the current search window. IOW, when user stops a search it causes AAD to freeze.
Title: Album Art Downloader XUI
Post by: AlexVallat on 16 April, 2008, 03:07:26 PM
OK, good news on the redraw after search issue then, I'm going to call that resolved. If there's another separate issue with CPU usage while idle, then we have to go back to the start to figure out what it is actually doing (if anything). Is that just on Vista (I'm not seeing it on XP here)? Does it ever happen before a search is made?

I've made some changes to the Stop All (including when stopping searches ready to perform a new replacement search), so hopefully freezing should be minimised. If a lot of sources are searching, there may still be a brief delay, but hopefully not much now. There may be a significant delay in actually stopping a source to a slow server, as it is unfortunately not possible to interrupt it while it is actually receiving data as part of a download, but the UI should be responsive while waiting though.

Test Build 7 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_7.zip) should be more responsive in the search-stopping area, and also fixes a bug where the Stop All button may remain visible even though all searches have stopped.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 16 April, 2008, 11:58:53 PM
OK, good news on the redraw after search issue then, I'm going to call that resolved.
Yeah, I don't think we can do anything more with this.
 
If there's another separate issue with CPU usage while idle, then we have to go back to the start to figure out what it is actually doing (if anything).

I also think this is a seperate issue, as only AlbumArt.exe thread has CPU usage and dirty frame addition rate is really 0 after a search.
 
Is that just on Vista (I'm not seeing it on XP here)?

Yes, only on Vista.
Does it ever happen before a search is made?

No, as far as I can tell.
Test Build 7 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_7.zip) should be more responsive in the search-stopping area, and also fixes a bug where the Stop All button may remain visible even though all searches have stopped.

Yes, it's as good as I expect it to be.
Title: Album Art Downloader XUI
Post by: AlunAlun on 18 April, 2008, 09:16:47 AM
Can I just say that, as a new foobar2k user, I found and downloaded this program and it worked an absolute treat, I found it a joy to use. Well done and thank you very much!
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 April, 2008, 01:42:02 PM
I also think this is a seperate issue, as only AlbumArt.exe thread has CPU usage and dirty frame addition rate is really 0 after a search.
OK, I've put together some fairly random performance optimisations into Test Build 8 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_8.zip). If none of them hit the mark, I think I'll have to leave this as it is - sorry. If I move to a Vista development environment, I'll take another look at it, though.

I plan to package up what we've got here with McoreD's /squareFactor suggestion, fix up Coveralia and Google search scripts again, and release as 0.17 this weekend. Thanks for all your help with tracking down the performance issues.

Can I just say that, as a new foobar2k user, I found and downloaded this program and it worked an absolute treat, I found it a joy to use. Well done and thank you very much!
Thanks, it's always great to know when people appreciate my work!

Alex
Title: Album Art Downloader XUI
Post by: thuan on 18 April, 2008, 09:49:23 PM
OK, I've put together some fairly random performance optimisations into Test Build 8 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_8.zip). If none of them hit the mark, I think I'll have to leave this as it is - sorry. If I move to a Vista development environment, I'll take another look at it, though.

It doesn't fix it, but it seems to be better. And it seems to only happen when there're a lot of album arts found whether in single or multiple window. No picky, though. I can wait, as I said if there had been no one bringing this up, I wouldn't have noticed it. Thanks for taking your time and fixed my issues with this simple but indispensable program.
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 April, 2008, 09:20:19 AM
AlbumArt Downloader XUI v0.17 Released

This is a performance release, several issues have been fixed relating to CPU usage for rendering the search window, and a memory leak when closing a search window has been plugged. Responsiveness in general has also been improved.

Additionally, the Coveralia script has been fixed and the Google Images script re-written to cope with their changes, and should both now work again.

Finally, a new parameter has been added to the command line interface (aad.exe): /minAspect. This specifies the minimum aspect ratio of the image to use. This is how square the image must be, where a value of 1 represents perfectly square (600 x 600, for example). An image of size 600 x 300 would only be allowed if /minAspect were 0.5 or lower.

Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: arnymars on 19 April, 2008, 11:58:00 AM
Alex,
I also wanted to thank you for your persistant work on this nice utility. Its always a pleasure to deal with intelligent person as well. I checked your website and found, your hardware resources were quite limited for a while. It raises a reasonable question though, why you don't want to help others with limited resources to enjou your program by adding some limited throttling algorithm. And why don't you want to add Cover Weblink Return code to your sources, which doesn't look that hard and time consuming, based on the Cover sources scripts posted on your website.

Another question I have is about your Foobar Configuration File Tool (http://www.byalexv.co.uk/index.html?Personal.html). Is it possible to add the new checksum calculation to it to avoid patching Foobar? Also, with this tool, is there a way to increase Foobar Max Sound Volume? Is there any reason for it to be so low anyway compare to Apollo, WinAmp etc.?
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 April, 2008, 01:16:03 PM

Thank you for your comments. In answer to your questions: I don't regard throttling to be generally helpful, even for low spec machines - it would just make a slow process even slower, with no real benefits. I concede that if your PC has a hardware fault that causes overheating at high CPU loads, you might benefit from throttling, but it's a bit of an edge case.

As I'm feeling helpful, though, I'll point you at WinThrottle (http://www.oldskool.org/pc/throttle), a free tool which will let you throttle your CPU in a flexible and configurable way. If you are unable or unwilling to resolve the overheating problem in hardware, this is probably the best solution to work around it in software.

Adding a information web link to the results is not a bad idea, and may even make it into a future version sometime. All I'm saying is that I disagree with your estimate of how laborious and  time consuming it would be to do, and it's not something that I'm likely to want to work on any time soon. What I might do, though, is add the functionality to display an information web link in the results pane if that data is supplied by the source, then if anyone does want to spend the time modifying the scripts to scrape that information, it would automatically be displayed.

About the Foobar Configuration File Tool, I'm not at liberty to discuss that publicly here.

If you have an issue with Foobar's max sound volume, you might have better luck starting a new thread about that - someone on the forum is bound to know about that, but won't see the question buried here in an unrelated topic.

Alex
Title: Album Art Downloader XUI
Post by: boondie on 20 April, 2008, 01:57:15 AM
Hey guys this is a great plugin first of all. Secondly I just formatted and have forgotten how to get this working with foobar (from the right click menu). If anyone could help me out that would be great. Perhaps this information should be in the first post?

Cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 April, 2008, 03:01:18 AM
I just formatted and have forgotten how to get this working with foobar (from the right click menu). If anyone could help me out that would be great
You need to use the [a href='index.php?showtopic=45223']foo_run[/a] plugin to do this. The usual command line would be something like:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /artist "%album artist%" /album "%album%" /path "$replace(%_path%,%_filename_ext%,)Folder.%%extension%%"

The Command Line Reference (http://album-art.sourceforge.net/index.php/Command_Line_Reference) for Album Art Downloader XUI might be helpful too.

Alex
Title: Album Art Downloader XUI
Post by: tuz on 22 April, 2008, 03:02:47 PM
Hi, first of all, thanks a lot for this software.
i've got problems with the different versions.
It can be described as "crash at startup"
I join to this post my errorlog.txt but it's in french.

here is the first lines :

System.Windows.Markup.XamlParseException: Impossible de convertir la chaîne « AlbumArtDownloader.ico » de l’attribut « Icon » en objet de type « System.Windows.Media.ImageSource ». Impossible de trouver un composant d’image adapté pour terminer l’opération.  Erreur à l’objet « AlbumArtDownloader.Splashscreen » dans le fichier de balisage « AlbumArt;component/splashscreen.xaml ». ---> System.NotSupportedException: Impossible de trouver un composant d’image adapté pour terminer l’opération. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception de HRESULT : 0x88982F50
  --- Fin de la trace de la pile d'exception interne ---


Let me know if you can't understand a thing. I'll try to translate a few if it can help us.

Thanks

Ps: i've already tried to uninstall and reinstall .net framework, even using a special .net cleaner but without success
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 22 April, 2008, 04:00:00 PM
I use AAD with foo_func telling AAD to be started when there is no cover. I works wonderful. Thanks for AAD.
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 April, 2008, 02:51:54 AM
It can be described as "crash at startup"
Hello tuz, I've tried searching around to see if I could find any information on the problem you are describing. The only thing I could find was this thread from the Microsoft forums: "DLL version not correct" when loading an image from the assembly (http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=507038&SiteID=1).

If you want to try the solution they came up with, uninstall .NET Framework 3.5, then uninstall Windows Imaging Components (WIC), then re-install .NET Framework 3.5. To uninstall WIC, you can use the command %windir%\$NtUninstallWIC$\spuninst\spuninst.exe

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 23 April, 2008, 10:50:22 AM
AlbumArt Downloader XUI v0.17 Released

Finally, a new parameter has been added to the command line interface (aad.exe): /minAspect. This specifies the minimum aspect ratio of the image to use. This is how square the image must be, where a value of 1 represents perfectly square (600 x 600, for example). An image of size 600 x 300 would only be allowed if /minAspect were 0.5 or lower.


Alex,

THANK YOU for the feature addition. Now AAD can be used to automate downloading of more reliable artwork. 

Cheers,
McoreD

Edit:

http://itsfv.svn.sourceforge.net/viewvc/it...r1=24&r2=33 (http://itsfv.svn.sourceforge.net/viewvc/itsfv/itsfv5/trunk/iTSfv/Artwork/cArtworkSources.vb?r1=24&r2=33)

20080424T001501 Job Started: VALIDATE_TRACKS_SELECTED
20080424T001504 Validating Disc: Mistaken Identity - Delta Goodrem in D:\Music\Delta Goodrem\Mistaken Identity
20080424T001504 Checks? True, Tracks? True, Library? True, File System? True
20080424T001504 Chosen Most Common Artist: "Delta Goodrem" with 100.00% confidence
20080424T001515 Found 3 sources of Artwork
20080424T001515 Artwork from File as D:\Music\Delta Goodrem\Mistaken Identity\Artwork.jpg with 600x600
20080424T001515 Artwork from Track as G:\Users\Administrator\AppData\Roaming\iTSfv\Delta Goodrem\Mistaken Identity\1482-TrackArtwork.jpg with 600x600
20080424T001515 Artwork from AAD as G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg with 709x709
20080424T001515 Choosing G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as the best Artwork
20080424T001515 Replace 600x600 with 709x709 for D:\Music\Delta Goodrem\Mistaken Identity\Folder.jpg? True
20080424T001515 Saved G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as D:\Music\Delta Goodrem\Mistaken Identity\Folder.jpg
20080424T001515 Replace 600x600 with 709x709 for D:\Music\Delta Goodrem\Mistaken Identity\Artwork.jpg? True
20080424T001515 Saved G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as D:\Music\Delta Goodrem\Mistaken Identity\Artwork.jpg
20080424T001515 Replace 600x600 with 709x709 for D:\Music\Delta Goodrem\Mistaken Identity\AlbumArtSmall.jpg? True
20080424T001515 Saved G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as D:\Music\Delta Goodrem\Mistaken Identity\AlbumArtSmall.jpg
20080424T001515 Export Artwork Pass 1 Finished.
20080424T001516 Compare Artwork Path: G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg
20080424T001516 Cached Artwork dimensions for D:\Music\Delta Goodrem\Mistaken Identity\14 You Are My Rock.mp3
20080424T001516 Cached Track Artwork Path:  G:\Users\Administrator\AppData\Roaming\iTSfv\Delta Goodrem\Mistaken Identity\1482-XmlArtwork.jpg
20080424T001516 Track Artwork Size: 600x600, Compare Artwork Size: 709x709
20080424T001516 Replace Artwork for 14 You Are My Rock.mp3? True

Works GREAT! Thanks again. 
Title: Album Art Downloader XUI
Post by: david_dl on 25 April, 2008, 08:40:24 AM
How about proxy support, ie. using the Internet Explorer proxy settings?
Title: Album Art Downloader XUI
Post by: AlexVallat on 25 April, 2008, 09:54:46 AM
How about proxy support, ie. using the Internet Explorer proxy settings?
It should already be doing that.

If you need to use a proxy other than the one specified by the system Internet Options (Control Panel, Internet Options, Connections, Lan Settings on XP), then it is possible to add or modify the AlbumArt.exe.config file to specify the proxy to use with the standard .net (http://msdn2.microsoft.com/en-us/library/kd3cf2ex.aspx) configuration settings:

Code: [Select]
<configuration>
<system.net>
  <defaultProxy>
    <proxy proxyaddress="your proxy address" />
  </defaultProxy>
</system.net>
</configuration>
Title: Album Art Downloader XUI
Post by: TarkusShakti on 26 April, 2008, 01:13:25 PM
First lets say thanks for Alex's effort. This is a great time saver.

I rebuilt my OS and installed AAD-v17 on my system. I noticed that when I right-click a folder (containing mp3s) in explorer; I no longer see a selection for "Search for Album art." This was a great convenience item, can we get it back?

TS
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 April, 2008, 01:49:00 PM
Thanks, glad Album Art Downloader made it on to your list of software to re-install!

I'll add an option to the installer to put a Search for Album Art command on the context menu for folders in explorer for the next version. Until then, you can use AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg) to add it. If Album Art Downloader is not in C:\Program Files\AlbumArtDownloader, it will need editing first, though.

Alex
Title: Album Art Downloader XUI
Post by: TarkusShakti on 26 April, 2008, 02:03:36 PM
I'll add an option to the installer to put a Search for Album Art command on the context menu for folders in explorer for the next version. Until then, you can use AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg) to add it.


Thank you and thank you!!

TS
Title: Album Art Downloader XUI
Post by: MP3Me on 26 April, 2008, 09:52:01 PM
Anybody know why Album Art Downloader would be unable to write a jpg file into a folder?
I run a search with the File Browser and under the 'Artwork Status' column some albums
are listed as 'Not Present' and others as 'Found:Folder.jpg'.  However, in actuality,  there are no Folder.jpg in
any of my music folders.  When I get artwork for the former case I am able to write the jpg; for the latter case, I first get a dialog claiming file already exists, when I choose to overwrite, a second dialog appears stating access is denied.

I am running XP.  When I examine folder/file permissions, all are listed as 'Read Only'.
When I do a recursive change on the permissions and then reexamine, XP claims they
are still read only.

thanks

Edit -
Solved:
folder.jpg is a protected operating system file!  In folder view disable 'Hide protected operating system files'.
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 April, 2008, 05:27:59 AM
AlbumArt Downloader XUI v0.18 Released

Just a couple of minor new features here. The installer has had a couple of minor cosmetic issues fixed, and now has an option to add a "Browse for Album Art..." entry to the context menu for folders in Explorer. The creation of Start Menu entries is now optional too.

In the search results, if a script provides a url with additional information for a result, a small (https://hydrogenaud.io/imgcache.php?id=28c70adaee44fd9c3b7145d78182c645" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/info.png) is displayed next to the result name, which will launch the default browser to show that page. So far, only Google Image and Amazon searches will provide these links. Other scripts may gain them in the future - if anyone else wants to add this functionality to a script, then the Add method has an additional optional string parameter after the name of the result which is the info url to use.

Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: david_dl on 28 April, 2008, 06:26:36 AM
How about proxy support, ie. using the Internet Explorer proxy settings?
It should already be doing that.

If you need to use a proxy other than the one specified by the system Internet Options (Control Panel, Internet Options, Connections, Lan Settings on XP), then it is possible to add or modify the AlbumArt.exe.config file to specify the proxy to use with the standard .net (http://msdn2.microsoft.com/en-us/library/kd3cf2ex.aspx) configuration settings:

Code: [Select]
<configuration>
<system.net>
  <defaultProxy>
    <proxy proxyaddress="your proxy address" />
  </defaultProxy>
</system.net>
</configuration>


Thanks, it doesn't seem to be automatically using those settings but i'll try the .config method.
On another note, I received an email from amazon the other day that said my 'access key' was being used to request data using an old version of their web protocol, and that they would be cutting off support soon, so could I please upgrade my application, or something to that effect. Since I assume AAD is still using my amazon key, I'd recommend looking into it.
Title: Album Art Downloader XUI
Post by: AlexVallat on 28 April, 2008, 06:37:39 AM
Since I assume AAD is still using my amazon key, I'd recommend looking into it.
Thanks for letting me know! I'm afraid the amazon query URL has just been carried along the copy and paste trail until I had no idea where it originally came from. I'll have a look at what the protocol changes needed are.

Alex
Title: Album Art Downloader XUI
Post by: Bob... Just Bob on 12 May, 2008, 06:41:51 AM
Hate to bump an old topic but, I recently decided to look for a new album art downloading program as my old one hasn't been updated to work with the new amazon.com API, and thus misses a lot of possible covers, I downloaded this one and was really happy with it at first, until I realized I couldn't use a date or year parameter in my save directory, which means it doesn't work with my sorting methods. Is this possible to add?

Sorry if this has been covered before.
Title: Album Art Downloader XUI
Post by: mobyduck on 12 May, 2008, 08:07:10 AM
Not sure what you mean. If you want to store the covers in a path containing your %DATE% tag, it should be feasible... Do you invoke AAD through foo_run?

Alessandro
Title: Album Art Downloader XUI
Post by: EeKuM on 14 May, 2008, 12:20:25 PM
Hey, I have searched through this topic and the previous one, and I really couldn't find my answer, so I would figure I'd just ask.

Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?

Reason being is from downloading, every names files different.  Some of the folders I have contain folder.jpg and some cover.jpg.  So if I could search both of them at the same time it would make my life of sorting through the images a heck of a lot easier.

Hopefully it's just a simple little option in the program that I am overlooking.
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 May, 2008, 12:40:34 PM
Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?

Do you mean for the file or foobar browsers? If so, click the Options link, then use the "Specify path to find images" box. You can't actually specify multiple alternative filenames here, but you can use wildcards, so *.jpg should do the job. The path is relative to the track being checked.

If you meant for the Local Files search, which shows the images as results when you are doing a search, then look for the Local Files entry in the Sources list, and click on the "..." button. Check the "Specify path to find images" checkbox, and in the box below, enter the absolute path pattern to where the images are (using %artist% and %album% placeholders, usually), for example: "c:\music\%artist%\%album%\*.jpg"

Hope that helps,

Alex
Title: Album Art Downloader XUI
Post by: EeKuM on 14 May, 2008, 11:13:06 PM
Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?

Do you mean for the file or foobar browsers? If so, click the Options link, then use the "Specify path to find images" box. You can't actually specify multiple alternative filenames here, but you can use wildcards, so *.jpg should do the job. The path is relative to the track being checked.

If you meant for the Local Files search, which shows the images as results when you are doing a search, then look for the Local Files entry in the Sources list, and click on the "..." button. Check the "Specify path to find images" checkbox, and in the box below, enter the absolute path pattern to where the images are (using %artist% and %album% placeholders, usually), for example: "c:\music\%artist%\%album%\*.jpg"

Hope that helps,

Alex


I should have specified that I was referring to the Foobar Browser, I'm sorry!
Title: Album Art Downloader XUI
Post by: Jimmy_Neuron on 15 May, 2008, 05:12:05 PM
Hello,
Is there some doc on the API of the scripts? I'd like to create a script for downloading covers from Last.fm, but can't figure out the exact semantics of the functions used in the scripts...
Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 16 May, 2008, 03:17:52 AM
Is there some doc on the API of the scripts?

I'm afraid this whole project is shamefully lacking in any sort of proper documentation. The best way to start a script is to copy an existing one and modify it - I'd recommend the AlbumArtExchange.boo as the best one to start from, as it uses the new strongly-typed script API.

In summary, to create a script you need to create a class that inherits from the AlbumArtDownloader.Scripts.IScript interface. This interface defines 3 string members: Author, Name, and Version, for information, and two methods: Search and RetrieveFullSizeImage for performing the actual search.

The Search method is where the main body of work for a script is done, it is here that you should retrieve your results. Apart from the artist and album names to search for, a results object implementing the IScriptResults interface is also provided as a parameter. This is used to communicate the results of the search back to the main application.

Once you know how many results you are likely to return, set the results.EstimatedCount property. This allows the progress bar to show an estimate of progress, rather than the indeterminate state. This property can be updated at any time if your estimate changes, so even if the exact count is not known until further pages have been downloaded and parsed, but a rough estimate can be provided quickly, it's usually best to start with a rough estimate as soon as possible and refine it later.

Apart from that, there is the results.Add method. This should be called for each result that you want to return. The first parameter is the thumbnail image for the result. This can be an actual Bitmap, or a Stream containing image data, or a Uri pointing to an image, or a String containing the image uri. The second parameter is the name of the result.

After that, there are some optional parameters. infoUri (String) may be used to provide a link to a web page with more information on the result (like the Amazon and Google Image scripts do).

A width and height of the full-size image may be provided, if known, as Int32. If at all possible, try to include these, as the size of the image is a really useful thing to know before having to actually download it.

The last parameter is not optional, and may contain whatever data you choose. If the full sized image for this result is requested, then the RetrieveFullSizeImage method will be called on your class, and the parameter passed to it will be that data. You can then use it to obtain a full sized image for the result, and return it. Usually, this data is the uri for the full sized image, and the RetrieveFullSizeImage method just returns it directly.

The return value of RetrieveFullSizeImage can be any of the types that are allowed for the thumbnail image: Bitmap, Stream, Uri, or String.

Scripts are typically written in Boo, and are compiled automatically. Alternatively, any compiled .net dll in the Scripts folder containing classes implementing AlbumArtDownloader.Scripts.IScript will also be loaded. This can be helpful for debugging scripts.

I hope this explains things sufficiently, but if you have any further questions about it, please ask.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 16 May, 2008, 01:27:22 PM
Do you mean for the file or foobar browsers? If so, click the Options link, then use the "Specify path to find images" box. You can't actually specify multiple alternative filenames here, but you can use wildcards, so *.jpg should do the job. The path is relative to the track being checked.


This doesn't work for me. When using the File Browser, I'd like to all local images in the album folder to be displayed among the downloaded thumbnails. But when I use *.jpg in the "Specify path to find images" box, no local images are shown among the thumbnails. If I explicity put Folder.jpg in the "Specify.." box, then that image if correctly found and displayed. Ditto for front.jpg, back.jpg, or whatever, but wildcards don't work.

Also, as a future feature request, I'd like local images displayed separately among the search results, even if sorting by e.g. size. Or perhaps use a different border color for local results.
Title: Album Art Downloader XUI
Post by: AlexVallat on 16 May, 2008, 02:08:32 PM

I think I see the confusion here. The path to find images entered in the file browser is the path it uses to check if there is already an image for that album present or not. If you want to set the path to use for finding local images in the search results, that's a separate setting (which I also described in the earlier post).

However, if you use the file browser to launch a search, it automatically populates the path to save the image to for the search to be the path to find images in from the browser. Currently, if this includes wildcards, they are removed (as you can't save to a path with a wildcard in it). The resulting path, something like c:\music\artist\album\.jpg, is then also used by the local image search (unless a specific path has previously been set for it) which of course it can't find.

For the next version, I'll see if I can do something better about wildcard replacing, probably substituting the %name% placeholder for wildcards instead of just removing them.

Segregating local image results has been requested before, and I'm open to any suggestions on the best way to display this. A different border or background colour would be easy enough, as would any other sort of visual indicator, but having them appear in a different area or order will be tricker. I'll look into it, though.

Alex
Title: Album Art Downloader XUI
Post by: kopf on 16 May, 2008, 02:16:42 PM
just upgraded to the latest version. had to install .net framework 3.5 too.

now, when i try to search something, the program crashes, and the following error report is sent to microsoft:

EventType : clr20r3 P1 : albumart.exe P2 : 0.10.1.0 P3 : 47090190
P4 : mscorlib P5 : 2.0.0.0 P6 : 471ebc5b P7 : 1295 P8 : 25
P9 : system.typeloadexception
Title: Album Art Downloader XUI
Post by: blackspawn on 17 May, 2008, 03:57:02 PM
I don't know if this at all possible but here goes...

I current have the following path scheme for my music collection:

1 CD: \%artist%\[%year%] %album%\
N CD: \%artist%\[%year%] %album%\CDX (where X is the disc number)

I want to save the folder.jpg to \%artist%\[%year%] %album%\folder.jpg independently if it's a single or multiple cd album. However I can't seem to get Album Art's file browser to "understand" this scheme...
If I "use ID3 tags from files" then all multiple cd albums' folder.jpg don't get recognized (and if I manually select them then they get saved to CD2 folder, don't know why...)
I tried using \%artist%\
  • %album%\*[/b] pattern matching (tried using the %year% tag but that didn't work) which resulted in Album Art correctly identifying multiple cd albums which already had a folder.jpg, however those that didn't have a folder.jpg don't even show up on the file browser.

    Basically want I want is for Album Art to check if \%artist%\[%year%] %album%\ has a folder.jpg and if not, retrieve the appropriate artist and album from the path and search for the corresponding cover. Finally I want to save all covers to \%artist%\[%year%] %album%\folder.jpg

    Can this be done? If so how? what is the config I should use in the file browser?


    Thanks in advance!
Title: Album Art Downloader XUI
Post by: gamingexpert13 on 17 May, 2008, 05:28:34 PM
i dont know if nobody's ever done this or if i just had weird settings but i tried searching for an album with the artist blank and i got a bluescreen. (had plenty of normal searches work before trying that)

i dont know how much detail you want but:
windows xp sp2
Album Art Downloader XUI-0.18 Installer version
also installed the extra amazon source plugins through the installer
.net framework 3.5

opened a file browser first, searched for all my albums in my music folder, selected like 5 (same artist) and clicked Get Artwork For Selection, so it opened a few windows and queued the rest, i would save an album image then close its search window and save the next album image, close its window, and it would open the new search windows, i was also switching between different sort options (which sorted every search window by the same option, kinda weird), then i got to an album that was a compilation album (multiple artists) and i only got one result for it which wasn't right so i figured if i removed the entry for artist it would just search for the album by any artist and give me more results, well i did this, clicked search, and windows gave me a blue screen.

if you want to know any other details let me know. i'd like to be able to search without an artist.
Title: Album Art Downloader XUI
Post by: thuan on 17 May, 2008, 09:51:40 PM
Coincident? I have done searches without artist field a lot without any problem. Have you ever had BSOD else where recently?
Title: Album Art Downloader XUI
Post by: jahpal on 18 May, 2008, 01:56:13 AM
Alex Im sorry to bother you with this what happen to the AlbumArt Downloader V 0.6 Alpha 2 , no more updates on that one . only on the XUI . THANK YOU...
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 May, 2008, 04:36:45 AM
Right, a whole bunch of answers here:

the program crashes, and the following error report is sent to microsoft:

EventType : clr20r3 P1 : albumart.exe P2 : 0.10.1.0 P3 : 47090190
P4 : mscorlib P5 : 2.0.0.0 P6 : 471ebc5b P7 : 1295 P8 : 25
P9 : system.typeloadexception
This error indicates that the .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) is not installed properly. I'd recommend removing it and re-installing it.

Can this be done? If so how? what is the config I should use in the file browser?
There isn't a great answer for this at the moment. The file browser currently can only match files, so if your album folder doesn't have any files in it (just CDX folders), there's nothing to match the pattern. When matching against files, then, the problem is that folder.jpg could be in two possible places (relative to the file), either folder.jpg (1 CD), or ..\folder.jpg (N CDs). The current version doesn't support checking multiple places for the image in the file browser either.

For the next version I plan to address both these issues, and I'll have a better answer for you, but for now you will have to run two separate searches.

First, to find art for all your 1 CD albums, have the path to find image as folder.jpg (or folder.* if you might have non-jpg images). To use path pattern matching, \%artist%\
  • %album%\*[/font] that you tried is almost correct, but as you noticed it is picking up folder.jpg from multi-cd albums too, so you could restrict it to just counting music files: \%artist%\
    • %album%\*.mp3[/font] should do the job (or .flac, or whatever format you use). If your files are in multiple formats, you might find it easier to exclude .jpg files instead: \%artist%\
      • %album%\*."(?!jpg)"*[/font]

        For the second pass, to find your multi-CD albums, use ..\folder.jpg (or ..\folder.*) as the path to find images, and \%artist%\
        • %album%\CD?\*.mp3[/font] (or similar) as the pattern.

          i tried searching for an album with the artist blank and i got a bluescreen
          Album Art Downloader doesn't do anything low-level enough to cause a bluescreen, so I'm going to have to agree with thuan's answer. If it does happen every time you try to search without an artist, then you could try a re-install of the .net framework, I suppose. I don't have any other suggestions for this, sorry.

          what happen to the AlbumArt Downloader V 0.6 Alpha 2
          Marc Landis hasn't been seen for a long time now, and when he was, I believe he was thinking of moving to the XUI branch too (although I might be mistaken).

          In any case, I personally will not be doing any work on 0.6 alpha 2, I started the XUI re-write because I considered the old one to be unmaintainable.

          Alex
Title: Album Art Downloader XUI
Post by: Waywisher on 18 May, 2008, 07:13:32 AM
Hi,

Apologies if I've missed this being covered before..
Is it possible to include a script for Amazon.co.uk (or amend another like the .de version)?

I ask because the current versions seem to miss out, especially non-mainstream, images from the .co.uk site- for example the album Bottlenecks and Armbreakers by Session A9 has a 500 x 500 image on the .co.uk site but this doesn't show up in AAD XUI 0.18.

Thanks in advance

EDIT - Sorry, I think I've posted this in the wrong place.. should have been under Album Art Downloader XUI

Moderation: Moved into the appropriate thread.
Title: Album Art Downloader XUI
Post by: Jimmy_Neuron on 18 May, 2008, 03:25:23 PM
Is there some doc on the API of the scripts?

I'm afraid this whole project is shamefully lacking in any sort of proper documentation. The best way to start a script is to copy an existing one and modify it - I'd recommend the AlbumArtExchange.boo as the best one to start from, as it uses the new strongly-typed script API.

(...)

I hope this explains things sufficiently, but if you have any further questions about it, please ask.

Thanks,

Alex


Wow, thanks for the info! I hope I'll be able to make up something usefull with these explanations and the scripts included with the app 

Kind regards,
Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 May, 2008, 03:01:25 AM
Is it possible to include a script for Amazon.co.uk (or amend another like the .de version)?
Amazon.co.uk (and other domains) are already included. If you are using the installer, when you reach the step to select the components to install, expand the "Image Download Script", then expand "Amazon", and choose the countries you want.

Alex
Title: Album Art Downloader XUI
Post by: Waywisher on 19 May, 2008, 08:50:36 AM
Thanks Alex, I clearly missed that on the first install (by the way.. excellent work!).

I've now noticed a slightly strange thing though..
For some images AAD 0.18 'seems to change' the dimensions ever so slightly.. Taking the Session A9 cover in my earlier post example (Bottlenecks and Armbreakers) .. If you look at the properties for the image on Amazon.co.uk (the enlarged version) Firefox says it's 500 x 500 (if you save this and open in Irfanview or whatever that application also says it's 500 x 500).. the version pulled in to AAD 0.18 however is reported to be 500 x 499..

I assume AAD doesn't do anything about 'editing' images.. Do you whether this is something AAD is doing, or why this difference is occurring?

Cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 May, 2008, 09:57:58 AM
For some images AAD 0.18 'seems to change' the dimensions ever so slightly..
Strange. No, AAD, doesn't do any editing, re-encoding, reformatting or other processing of the image, it just uses the image data directly provided. A script may modify an image before returning it as a result, but none of the bundled ones (including Amazon) do.

For some reason it would appear that Amazon is providing a slightly different image through its web service than through the HTML site - I don't know why.

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 19 May, 2008, 12:30:03 PM
Thanks Alex for your response to my query above (posts 356 and 357). I incorrectly assumed that wildcards were intended to give me the behavior I wanted. What I want is this:

I currently have my album art stored in the same folder as the album MP3s, but the images are inconsistently named. I want AAD to show *all* images in the local album folder as results, no matter what filename I enter in "Specify path to find images" (e.g. Folder.jpg).

This would give me a convenient semi-automatic way of selecting a main album art image among the ones I already have, and simultaneously comparing image quality to that available online. Another reason is that many of my albums are rare and produce no online results - but I may already have images in the local folders, so AAD should show them!

Local results should also be clearly marked as such, ideally by being separated somehow. But if this is too complicated to implement, marking them with "Source: LOCAL" and changing the thumbnail background color would be acceptable.

I hope you see what I mean now. Is this something we can hope for in v0.19?
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 May, 2008, 12:41:43 PM
Is this something we can hope for in v0.19?

0.19 is on the way, being held up mostly by my attempts to get grouping of results to work!

In 0.19, if you put *.jpg in as the path to find images in the browser, then when you do a Get Artwork from the browser, all .jpg images in the folder will be shown as local results. The default name to save to will be %name%.jpg, though, so you might want to use a Save As to save it as Folder.jpg instead.

Alternatively, if you want the browser to only show artwork present if it is Folder.jpg, then put Folder.jpg in as the path to find images in the browser, but in the Search window you will have to expand the Local Files source, check the "Specify path to find images" checkbox, and in the box below, enter the absolute path pattern to where the images are (using %artist% and %album% placeholders, usually), for example: "c:\music\%artist%\%album%\*.jpg". That way all the images will be displayed. This can be done now, there is no need to wait for 0.19 for that.

Alex
Title: Album Art Downloader XUI
Post by: blackspawn on 19 May, 2008, 12:46:24 PM
For the next version I plan to address both these issues, and I'll have a better answer for you, but for now you will have to run two separate searches.

First, to find art for all your 1 CD albums, have the path to find image as folder.jpg (or folder.* if you might have non-jpg images). To use path pattern matching, \%artist%\
  • %album%\*[/font] that you tried is almost correct, but as you noticed it is picking up folder.jpg from multi-cd albums too, so you could restrict it to just counting music files: \%artist%\
    • %album%\*.mp3[/font] should do the job (or .flac, or whatever format you use). If your files are in multiple formats, you might find it easier to exclude .jpg files instead: \%artist%\
      • %album%\*."(?!jpg)"*[/font]

        For the second pass, to find your multi-CD albums, use ..\folder.jpg (or ..\folder.*) as the path to find images, and \%artist%\
        • %album%\CD?\*.mp3[/font] (or similar) as the pattern.

          Alex


Thanks for the reply  looking forward to the "OR" option in pattern matching .

Just a minor pet peeve of mine... eheh, the drop down entry for the "Specify path to find images:" remembers the previous entries (by the way is it possible to delete some of these? are they stored in some config file?) but the one for "Use file path pattern matching" is always blank.

Anyway this IS a GREAT app thank you for all your hard work!
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 May, 2008, 12:59:07 PM
Just a minor pet peeve of mine... eheh, the drop down entry for the "Specify path to find images:" remembers the previous entries (by the way is it possible to delete some of these? are they stored in some config file?) but the one for "Use file path pattern matching" is always blank.

Anyway this IS a GREAT app thank you for all your hard work!
Thanks, I'm glad it's appreciated :-)

I'll look into why the "Use file path pattern matching" box isn't remembering previous entries, and see if I can't hook up the delete key to remove entries too.

Until then, all settings are stored in: C:\Documents and Settings\[user]\Local Settings\Application Data\AlbumArtDownloader\AlbumArt.exe_Url_[random junk]\0.18.0.0\user.config, which is an xml file and can be hand edited if you need to. Under Vista, this starts as \Users rather than \Documents and Settings, I think.

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 19 May, 2008, 02:36:23 PM
Excellent news, looking forward to 0.19! Thanks for a great app Alex - and even better support!
Title: Album Art Downloader XUI
Post by: jahpal on 19 May, 2008, 10:47:55 PM
Right, a whole bunch of answers here:

the program crashes, and the following error report is sent to microsoft:

EventType : clr20r3 P1 : albumart.exe P2 : 0.10.1.0 P3 : 47090190
P4 : mscorlib P5 : 2.0.0.0 P6 : 471ebc5b P7 : 1295 P8 : 25
P9 : system.typeloadexception
This error indicates that the .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) is not installed properly. I'd recommend removing it and re-installing it.

Can this be done? If so how? what is the config I should use in the file browser?
There isn't a great answer for this at the moment. The file browser currently can only match files, so if your album folder doesn't have any files in it (just CDX folders), there's nothing to match the pattern. When matching against files, then, the problem is that folder.jpg could be in two possible places (relative to the file), either folder.jpg (1 CD), or ..\folder.jpg (N CDs). The current version doesn't support checking multiple places for the image in the file browser either.

For the next version I plan to address both these issues, and I'll have a better answer for you, but for now you will have to run two separate searches.

First, to find art for all your 1 CD albums, have the path to find image as folder.jpg (or folder.* if you might have non-jpg images). To use path pattern matching, \%artist%\
  • %album%\*[/font] that you tried is almost correct, but as you noticed it is picking up folder.jpg from multi-cd albums too, so you could restrict it to just counting music files: \%artist%\
    • %album%\*.mp3[/font] should do the job (or .flac, or whatever format you use). If your files are in multiple formats, you might find it easier to exclude .jpg files instead: \%artist%\
      • %album%\*."(?!jpg)"*[/font]

        For the second pass, to find your multi-CD albums, use ..\folder.jpg (or ..\folder.*) as the path to find images, and \%artist%\
        • %album%\CD?\*.mp3[/font] (or similar) as the pattern.

          i tried searching for an album with the artist blank and i got a bluescreen
          Album Art Downloader doesn't do anything low-level enough to cause a bluescreen, so I'm going to have to agree with thuan's answer. If it does happen every time you try to search without an artist, then you could try a re-install of the .net framework, I suppose. I don't have any other suggestions for this, sorry.

          what happen to the AlbumArt Downloader V 0.6 Alpha 2
          Marc Landis hasn't been seen for a long time now, and when he was, I believe he was thinking of moving to the XUI branch too (although I might be mistaken).

          In any case, I personally will not be doing any work on 0.6 alpha 2, I started the XUI re-write because I considered the old one to be unmaintainable.

          Alex

THANK YOU ALEX
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 May, 2008, 02:05:17 PM
AlbumArt Downloader XUI v0.19 Released

This release includes several minor new features that were requested:Some bugs were fixed too:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)



0.19 also allows me to make some better replies to issues previously raised:
Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?
Yes. Use the | symbol between the alternatives you want.

I'd like local images displayed separately among the search results, even if sorting by e.g. size.
Done. Click the Group By drop down above the results and select "Local".

I current have the following path scheme for my music collection:

1 CD: \%artist%\[%year%] %album%\
N CD: \%artist%\[%year%] %album%\CDX (where X is the disc number)

I want to save the folder.jpg to \%artist%\[%year%] %album%\folder.jpg independently if it's a single or multiple cd album.
To use pattern matching to match against a folder rather than a file, end the pattern in \. so:  \%artist%\
  • %album%\.[/font] should do the job. If not, then you can restrict it further by making sure that the artist and album folders are where you expect them to be, so something like: \music\%artist%\
    • %album%\.[/font] , or whatever your parent folder is called.

      I currently have my album art stored in the same folder as the album MP3s, but the images are inconsistently named. I want AAD to show *all* images in the local album folder as results, no matter what filename I enter in "Specify path to find images" (e.g. Folder.jpg).
      To do this, expand the Local Files source (click the ... to the bottom right of it) and change the "Path to find images" box to: %folder%\*.jpg (or *.* if you have images other than jpg, but this will be slower as it has to check every file to see if it is a valid image).

      the drop down entry for the "Specify path to find images:" remembers the previous entries (by the way is it possible to delete some of these? are they stored in some config file?) but the one for "Use file path pattern matching" is always blank.
      To delete an entry, highlight it (move the mouse over it) and click the Delete key on the keyboard.
Title: Album Art Downloader XUI
Post by: m-z on 24 May, 2008, 06:03:01 AM
  • Search results grouping (by source, or by local / online results). There is a new Group By option, next to the Sort By option, which allows grouping of the results either by source, or by whether they are local results or not.

That's very nice. It'd be even cooler if all of the Amazon scripts would group together.

Anyway, excellent release, AlexVallat. Keep up the good work.
Title: Album Art Downloader XUI
Post by: nicke2323 on 25 May, 2008, 07:02:54 PM
Brilliant Alex, thanks!

If you're still hungry for ideas for even more improvement, here's one:

Suppose I use the file browser to find art for an album in a certain folder. If I don't get good hits using the artist and album names from the MP3 tags, I edit these fields in AAD and hit search again. I then find some images and click the save icon. However, these images are no longer placed in the original folder, but in My Pictures somewhere, so I have to find them and move them manually. No big problem, but it would be nice if AAD had an option to search again using the same folder settings. Also, perhaps it could perform this second search immediately instead of placing it at the end of the queue.

I need to edit the search fields in about 33% of my albums, so this feature would be useful.
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 May, 2008, 03:17:40 AM
I edit these fields in AAD and hit search again.
I can't think of any reliable way of automatically determining whether someone has edited the fields to refine their search, or is starting a new search for a different album and artist.

What you can do, though, is uncheck the "Open search results in new window" checkbox (under Options). That way, your edited search will be performed immediately, replacing the existing results, and without changing the default path to save to - which should address the concerns you've raised, I think.

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 26 May, 2008, 10:28:44 AM
I edit these fields in AAD and hit search again.
I can't think of any reliable way of automatically determining whether someone has edited the fields to refine their search, or is starting a new search for a different album and artist.

What you can do, though, is uncheck the "Open search results in new window" checkbox (under Options). That way, your edited search will be performed immediately, replacing the existing results, and without changing the default path to save to - which should address the concerns you've raised, I think.

Alex


That checkbox was exactly what I wanted - I have no idea how I managed to miss it. I'm really running out of suggestions for you now. Hmmm ... how about an option to automatically add a number suffix when saving an image to a name that already exists (instead of asking to overwrite and/or prompting for a new name)?

Or is that functionality already in the current version too?
Title: Album Art Downloader XUI
Post by: blackspawn on 26 May, 2008, 06:31:51 PM
AlbumArt Downloader XUI v0.19 Released

This release includes several minor new features that were requested:
  • Search results grouping (by source, or by local / online results). There is a new Group By option, next to the Sort By option, which allows grouping of the results either by source, or by whether they are local results or not.
  • Added the ability to the File Browser path pattern matching function to specify the path should match folders rather than files. This can be used to speed up scanning by avoiding needlessly scanning files when all the relevant information is in the folder names. To specify that a pattern should match folders, end it with \.

    For example, if your music is stored as c:\music\%artist%\%album%\*.mp3, then using the pattern \music\%artist%\%album%\. will avoid having to scan every .mp3 file in the folder, and will also match folders which have no files in them.

  • Delete key now removes items from history lists.


Thanks a bunch! This is awesome. Can't think of anything more I would like

Edit: I think I found a bug eheh I'm getting a consistent crash when using the "Group By Source" option. I have all images script selected and after searching for a single album through the file browser, and after all images have been downloaded, when I select "Group By Source" AAD crashes with the messages "Album Art has stopped working / Option: Close program" (yes I'm using Vista x32). Happens every time (tried with different albums and all).
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 26 May, 2008, 06:41:36 PM
One question/request.....
With the 9.5.2 it was possible to check if a cover exists and if not to start AAD automatically.
It would be cool to have such a feature in the newer versions. Is there a way to do this in the newer versions?
I like when AAD automatically opens if a cover is missing.
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 May, 2008, 03:16:47 AM
how about an option to automatically add a number suffix when saving an image to a name that already exists (instead of asking to overwrite and/or prompting for a new name)?
This might become part of the Presets system, if I ever get round to actually writing it. The idea would be that as well as being able to select a fixed suffix (like front, back, inlay, etc.) you could define a sequential numeric suffix too.

when I select "Group By Source" AAD crashes
Is an errorlog.txt file created? It's going to be hard for me to narrow down without one. Perhaps you could check to see if it is any particular source that is causing it? (Try turning half of them off, and if no longer occurs, turn that half back on, and the other half off. If it does still occur, halve the remaining sources again until the minimum set of sources that cause the bug has been isolated)

With the 9.5.2 it was possible to check if a cover exists and if not to start AAD automatically.
I don't know anything about this, but that functionality was never part of AAD, and has certainly never been removed. There has never been a version 9.5.2 of AAD.

Alex
Title: Album Art Downloader XUI
Post by: blackspawn on 27 May, 2008, 09:47:17 AM
when I select "Group By Source" AAD crashes
Is an errorlog.txt file created? It's going to be hard for me to narrow down without one. Perhaps you could check to see if it is any particular source that is causing it? (Try turning half of them off, and if no longer occurs, turn that half back on, and the other half off. If it does still occur, halve the remaining sources again until the minimum set of sources that cause the bug has been isolated)

Alex


No errorlog.txt created, I tried doing what you said (disabling all scripts then activating them one by one) too see if the crash was related to any of them.. lo and behold the crash is gone lol... must have been some quirk of updating to version 0.19 from 0.17 (deactivating and re-activating the scripts seemed to have worked).

Thanks for everything Alex, you rock!
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 28 May, 2008, 05:27:20 PM
With the 9.5.2 it was possible to check if a cover exists and if not to start AAD automatically.
I don't know anything about this, but that functionality was never part of AAD, and has certainly never been removed. There has never been a version 9.5.2 of AAD.

Alex

Since this is a Foobar discussion board I thought i was clear that I was talking about Foobar in relation with AAD (using foo_func and foo_comserver). Foo_func is deprecated. So this won't work anymore in 0.9.5.3. I wanted to tell that it would be cool to have something implemeted that checks if the albumart of the current exists and if not start a AAD search.

I can understand if that isn't possible.

I like AAD very much good work.
Title: Album Art Downloader XUI
Post by: jahpal on 29 May, 2008, 02:37:54 AM
Can Anybody help with this command line ,i can get it to work its not opening the art downloader this is what im using :  "C:\Program Files (x86)\foobar2000\AlbumArtDownloader\AlbumArt.exe" -ae -ar "%artist%" -al "%album%" -p "$replace(%_path%,%_filename_ext%,)folder.jpg" i can make it work please Thank you . by the way im using windows xp professional 64 edition . i also updated xui to the 64 bit and installed the 3.5 runtime, i just dont know what else to do . THANK YOU...
My Music its in individual folders each one by the name of the band or artist with cover inside and i keep it on another drive .      H:\Music    just in case anybody needs the info. THANKS...
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 May, 2008, 03:03:01 AM
Foo_func is deprecated. So this won't work anymore in 0.9.5.3.
Ah, OK, sorry for the misunderstanding. You might have better luck asking in the foo_func thread, though, as it is this that you need a replacement for.

Can Anybody help with this command line...
Are you sure that's where you've installed AAD to? The default would be "C:\Program Files (x86)\AlbumArtDownloader\AlbumArt.exe" (not under the foobar2000 folder), but if you changed that during installation, then the command line you wrote might be OK.

Alex
Title: Album Art Downloader XUI
Post by: jahpal on 29 May, 2008, 03:32:01 AM
Foo_func is deprecated. So this won't work anymore in 0.9.5.3.
Ah, OK, sorry for the misunderstanding. You might have better luck asking in the foo_func thread, though, as it is this that you need a replacement for.

Can Anybody help with this command line...
Are you sure that's where you've installed AAD to? The default would be "C:\Program Files (x86)\AlbumArtDownloader\AlbumArt.exe" (not under the foobar2000 folder), but if you changed that during installation, then the command line you wrote might be OK.

Alex

you are right this is the default "C:\Program Files (x86)\AlbumArtDownloader\AlbumArt.exe" but  i change it to the foo directory cos that is where i have it  and its opening C:\program files instead of xui ,dont know why .
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 May, 2008, 03:51:11 AM
its opening C:\program files instead of xui
Ah, I think I know this one. For foo_run you need to escape the ( and ) characters, so you should use:  "C:\Program Files '('x86')'\foobar2000\AlbumArtDownloader\AlbumArt.exe"

Alex
Title: Album Art Downloader XUI
Post by: jahpal on 29 May, 2008, 04:18:32 AM
its opening C:\program files instead of xui
Ah, I think I know this one. For foo_run you need to escape the ( and ) characters, so you should use:  "C:\Program Files '('x86')'\foobar2000\AlbumArtDownloader\AlbumArt.exe"

Alex

Beautiful Alex it Work ,i was going out of my mind i try just about everything in the book nothing work. i would never figure that one out. THANK YOU... another happy customer .
Title: Album Art Downloader XUI
Post by: poisonborz on 02 June, 2008, 03:43:33 PM
Hola again, AAD became an even more awesome tool since I've updated it...

---I have a feature idea: with AAD it was always a bit tricky to manage albums that had more than one Artist (VA albums) Path pattern is one way to overcome this, but here is another idea: in the browser, there could be a new sorting column: Path - this would show the file path of the element. Elements from the same folder would have no thin white margin on top/bottom as they have by default (= or other non highly visible marking)

I know you don't like methods that assume a certain path structure, but this would have little to no impact on the general feel, and is a great help to everyone who stores files in album folders (95% of users )

---And I don't know if it's only me, but the size of the Search window is not saved on simple exit from a window instance - so, if there are 10 items queued, I resize a search window, and the next item in the queue pops up in the old size Search. It only saves in the case of a single Search/last queue item's Search... this is a bit annoying.

---There could be an option for AAD to - if there is one - also check the size/resolution of a folder image. So the user could set that eg. anything under 100x100px would count as missing (of course this could be marked differently in the file browser results - eg. a slightly brighter background color). Since the new image will propably overwrite the old small one, there should be a warning message before turning this on. This might make the search to last a bit longer, but AAD would gain a nice new feature, to replace low resolution folder images.

---There should be an option in the search window to search for only specific file types (eg. only jpg results). This would propably not work for all search engines (or...?), but at least for google, it would. In the distant future, it would be mega-awesome to have some sort of auto-converting ability.

---(And please, even if multi-windowed gui is hardcoded, couldn't you make one parent window to hold all the others? 3-4 open windows of the same app is not a good sight even on high resolution)
Title: Album Art Downloader XUI
Post by: blackspawn on 02 June, 2008, 05:42:13 PM
---(And please, even if multi-windowed gui is hardcoded, couldn't you make one parent window to hold all the others? 3-4 open windows of the same app is not a good sight even on high resolution)


I second this request, a unified, tab-based interface would be very nice indeed.
Title: Album Art Downloader XUI
Post by: AlexVallat on 03 June, 2008, 03:23:15 AM
Thanks for all the suggestions, poisonboroz:

Path column in file browser:
This is a possibility - I'd need to make columns optional/hideable, then this could be a column that could be turned on and sorted by. Visible marking of items from the same path is less likely to happen, though.

Resized search window does not apply to queued searches:
That's a bug, I'll fix that.

Read pixel size of folder image in file browser:
I don't want to open and read every image during a scan, so a pixel size can't be shown. A file size is already shown, though, which should give some indication of the pixel size of the image. They don't count as missing, but the file size column can be sorted by, so you can just select all the albums with images under a certain (file)size and search for replacements if you want.

Search for specific file types:
None of the sources, with the possible exception of google images, would support this, so it isn't worth adding any sort of dedicated UI for it.

Auto-converting:
One possible future feature for AAD would be to add an image processing pipeline (crop, resize, add watermark/border, change format). So far I've been of the opinion that this is better left to a dedicated image manipulation tool rather than trying to bring it into scope for an image downloading tool, but I'm not totally against the idea, so it might eventually happen.

Tabbed UI:
Not going to happen. Not by me, anyway. I don't think a tabbed interface is right for this utility, and won't be writing one. If someone else wants to write one, I'd accept it, but only if optional and not the default.

Alex
Title: Album Art Downloader XUI
Post by: poisonborz on 03 June, 2008, 09:17:51 AM
Some sort of management for file formats is a must (even if not conversion for now), because right now AAD saves the files with the pre-set file names (eg. png files are saved with .jpg extension).
Title: Album Art Downloader XUI
Post by: thuan on 03 June, 2008, 11:17:12 AM
You can save to the right extension using %extension% variable in the save path in AAD.
Title: Album Art Downloader XUI
Post by: poisonborz on 05 June, 2008, 06:44:56 AM
Another bug to report: in the search window, image dimensions are often reported incorrectly. If I single click on one thumbnail, the image appears to be upscaled to the reported false dimensions, only after the image downloads, is the preview image/size indicator "corrected". Can this be fixed?

Also, it would be nice in the File browser if there would be an option to open the directory of the results (perhaps trough a context menu, or this could be the default action for double right-click) - this way AAD would provide a quick way to check the presence of album art manually.
Title: Album Art Downloader XUI
Post by: FavioD on 05 June, 2008, 08:42:01 AM
is anyone else getting this?

(https://hydrogenaud.io/imgcache.php?id=183ab89f327b1669f80f2858f7e59ea4" rel="cached" data-warn="External image, click to view at original size" data-url="http://i31.tinypic.com/sym2de.jpg)
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 05 June, 2008, 02:05:29 PM
is anyone else getting this?


yeah it looks like they change something with referer on thumbnails. but when i click these, full size images are downloaded correctly.
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 05 June, 2008, 02:26:12 PM
is anyone else getting this?

Yes, I've been getting that for the last several days.
Title: Album Art Downloader XUI
Post by: AlexVallat on 05 June, 2008, 05:00:46 PM
Another bug to report: in the search window, image dimensions are often reported incorrectly.
Which script? If the image dimensions reported by a script are always wrong, then I'll remove them, but if they are at least usually right, or almost right, it's worth leaving them in as a rough guide.

Also, it would be nice in the File browser if there would be an option to open the directory of the results
Once Path becomes a column, the value will be a hyperlink like the folder image is now (when present), which will open that path in explorer.

is anyone else getting this?
I'll have a go at a workaround for this in the cover paradies script. At worst, I'll have it just always download the full sized image, as that still seems to work.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 07 June, 2008, 05:41:09 AM
is anyone else getting this?

Updated Cover-Paradies script: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)
Requires updated common utilities script: util.boo (http://www.byalexv.co.uk/foobar/util.boo)

Just stick them both in your Scripts folder, overwriting the existing ones.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 07 June, 2008, 04:31:06 PM
Updated Cover-Paradies script: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)
Requires updated common utilities script: util.boo (http://www.byalexv.co.uk/foobar/util.boo)

Just stick them both in your Scripts folder, overwriting the existing ones.

Thanks for the update.  Seems to be working just fine again! 
Title: Album Art Downloader XUI
Post by: Fractal_Mortality on 17 June, 2008, 05:18:14 PM
Would it be possible to create a .boo script for the amazon mp3 store? They consistently have 500x500 artwork, and it's one of the best resources I know of.

http://www.amazon.com/s/ref=nb_ss_dmusic?u...amp;x=0&y=0 (http://www.amazon.com/s/ref=nb_ss_dmusic?url=search-alias%3Ddigital-music&field-keywords=&x=0&y=0)
Title: Album Art Downloader XUI
Post by: blueboybob on 18 June, 2008, 12:21:39 PM
will there be an option to add album art to id3tags?

that would only make this program taht much better
Title: Album Art Downloader XUI
Post by: rme on 22 June, 2008, 11:51:35 AM
Is there a way to get iTunes v 7 to use the folder.jpg in the artist\album directory where I stored it from searching in AAD?  iTunes has it's own album art directory structure and doesn't recognize my folder.jps's when I load my itunes library with new discs.

Is there an automatic way to accomplish this with AAD and have it save itunes artwork directory structure as well as folder.jpg?  I suppose one way to make this universal would be if AAD saved artwork in the mp3 tags (let's not debate if that is a good idea or not please).  Trying to save some steps here.

I currently rip using either eac+mareo or foobar+mareo into flac and mp3.  Then have to foobrowse through AAD and lookup artwork, then load itunes library then can't access artwork?  I am trying to avoid using foo_dop as the rest of my family has to sync their ipdos as well and foo_dop doesn't have calendar syncing for iphone.

Thanks in advance for your help
Title: Album Art Downloader XUI
Post by: Light on 23 June, 2008, 10:21:09 AM
I too am waiting for someone to update the amazon.boo script so it can search amazon again...
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 June, 2008, 02:22:10 PM
Sorry, I haven't had a chance to reply for a while.

First, AAD won't be storing images embedded in tags, sorry. If you want to work with iTunes, can I recommend the very fine [a href='index.php?showtopic=51708']iTunes Store file validator[/a]?

I've just tested the amazon scripts, and they seem to be working fine for me. Could anyone else confirm whether the amazon scripts work for them or not? If you aren't using version 0.6 of the amazon scripts, then you could try updating to the latest version of AAD which includes them.

Alex
Title: Album Art Downloader XUI
Post by: Light on 23 June, 2008, 04:23:58 PM
damn, i see mine is 0.3... thought i had the latest aad, but i guess not... will try now

:UPDATE:

yeah, that was it, thank you  ... now it all works with more results... and faster as well!
Title: Album Art Downloader XUI
Post by: AlbumArtExchange on 06 July, 2008, 09:18:38 PM
edit: removed by request.
Title: Album Art Downloader XUI
Post by: AlexVallat on 07 July, 2008, 02:57:04 AM
I've just added a new XML search interface
Excellent, that's appreciated. I'll include an updated script for AlbumArtExchange in the next release.

(Which is coming along soon now, honestly! Sorry it's taken so long.)

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 08 July, 2008, 06:31:00 PM
if i start albumart via command line, it works great:
Code: [Select]
D:\Program Files\AlbumArtDownloader>albumart.exe /ar "madonna" /p "d:\test.jpg"

(https://hydrogenaud.io/imgcache.php?id=4ec17a8fae11b7142c209deac5af496b" rel="cached" data-warn="External image, click to view at original size" data-url="http://img3.imagebanana.com/img/9i0brwxw/thumb/Zwischenablage01.jpg) (http://img3.imagebanana.com/view/9i0brwxw/Zwischenablage01.jpg)

aad i get this error:
Code: [Select]
D:\Program Files\AlbumArtDownloader>aad.exe /ar "madonna" /p "d:\test.jpg"
Album Art Downloader XUI Command Line Interface version 0.19.0.0

Unexpected faliure: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.

this means something like: the object reference was not set to a object instance.

edit:
ahh ok for the cmd version the album isnt optional. so how to only get some pics of the artists? a wildcard for the album?
Title: Album Art Downloader XUI
Post by: AlexVallat on 09 July, 2008, 03:02:10 AM
ahh ok for the cmd version the album isnt optional. so how to only get some pics of the artists? a wildcard for the album?

I'll fix that for the next version, there's no reason the album shouldn't be allowed to be optional here.

Until then, to work around it, just pass " " for the album, so:

aad.exe /ar "madonna" /p "d:\test.jpg" /al " "

should do the job.

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 09 July, 2008, 05:38:52 AM
thank you! i figured out the same yesterday late at night. the result with a space char is the same as in albumart.
Title: Album Art Downloader XUI
Post by: AlexVallat on 09 July, 2008, 08:14:39 AM
I'll include an updated script for AlbumArtExchange in the next release.
Here's the new script that uses the new AlbumArtExchange XML API: albumartexchange.boo (http://www.byalexv.co.uk/foobar/albumartexchange.boo)

It will be included in the next release (this weekend, hopefully), but until then, if anyone would like to start using it and let me know if there are any problems with it, that would be appreciated.

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 09 July, 2008, 03:42:46 PM
lol net framework is realy interesting:
i tried /ma 0.6 but in germany i have to use 0,6 cause
in germany 1,500 means one and a half and 1.500 means fifteen hundred.

that's localization ^^

is it possible to filter such pictures:

GoogleImage: 112 ft. Puff Daddy & Notorious B.I.G (http://images.google.de/images?q=112+ft.+Puff+Daddy+%26+Notorious+B.I.G).

(https://hydrogenaud.io/imgcache.php?id=4bcba5f72b8cb947dd16ddde99519a73" rel="cached" data-warn="External image, click to view at original size" data-url="http://img3.imagebanana.com/img/nklxsoh/thumb/112ft.PuffDaddyNotoriousB.I.G..jpg) (http://img3.imagebanana.com/view/nklxsoh/112ft.PuffDaddyNotoriousB.I.G..jpg)
Title: Album Art Downloader XUI
Post by: TheChipstar on 10 July, 2008, 12:07:05 AM
Thanks for the cool application - just updating to the newer version.
I am just busy installing this...

Just a quick question: Is there any way of filtering results with the aspect ratio of 1:1??
Title: Album Art Downloader XUI
Post by: krabapple on 10 July, 2008, 02:18:27 AM
I have local album art in two places -- as folder.xxx files in individual album folders, e.g.

F:/music/Pink Floyd/1971 - Meddle/folder.png

and a bunch of uniquely-named art files (artist_album.xxx) in a separate folder called 'covers'.

F:/covers/The Beatles_Revolver.jpg

I'm able to get AAD to list local album art -- using alternation to find jpgs, pngs, or gifs --  from one place but so far not  both.  Can someone tell me the alternation syntax for this?
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 July, 2008, 03:23:29 AM
is it possible to filter such pictures:
No, I don't think so. The only thing wrong with the picture is that it is useless, which is a pretty subjective judgement to make. For all the software knows, the cover might actually be supposed to be pure black with a number grey 56 on it.

Just a quick question: Is there any way of filtering results with the aspect ratio of 1:1??
Not in the normal (interactive) application, no. I hadn't considered it necessary, as the thumbnails give a good indication of aspect ratio. For the command line version (aad.exe), as you can't preview the images, I did add this feature. To limit results to only 1:1 aspect ratio images, use /minAspect 1 in the command line.

I'm able to get AAD to list local album art -- using alternation to find jpgs, pngs, or gifs --  from one place but so far not  both.  Can someone tell me the alternation syntax for this?
How about folder.png|folder.jpg|folder.gif|/covers/%artist%_%album%.*

There's no way of grouping alternations, so you can't have (folder|cover).(png|jpg), for example. Each alternation has to stand alone. So, if .* doesn't cut it for the /covers/ folder, and you need to restrict to .png, .jpg, .gif, you have to add alternations for each of those too!

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 10 July, 2008, 06:30:52 AM
No, I don't think so. The only thing wrong with the picture is that it is useless, which is a pretty subjective judgement to make. For all the software knows, the cover might actually be supposed to be pure black with a number grey 56 on it.
no dont filter black pictures with a dark gray 56, but pictures that have the same RGB value for 90% of the whole image - this cant be a valid picture or do you know such a album cover?

edit:
except the beatles's white album 

maybe it could be implemented as an optional feature?
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 July, 2008, 06:47:14 AM
or do you know such a album cover?
"It's like, 'how much more black could this be?' and the answer is none. None more black."

Also, The Black Album (http://en.wikipedia.org/wiki/The_Black_Album_(Prince_album)) 

In any case, I'm not going to add a feature to make a judgement on the usefulness of a cover based on its appearance. That's what the search result thumbnails are there for. If you just avoid using the google image search, you'll eliminate the vast majority of incorrect results at a single stroke anyway.

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 10 July, 2008, 08:02:08 AM
google image is the best source for rare or less known artists but ok. i try to handle this on another way
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 July, 2008, 04:05:52 AM
AlbumArt Downloader XUI v0.20 Released

New features and fixes:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: ladiko on 12 July, 2008, 06:23:55 AM
works great! do you think you could add a script for last.fm? or another website with a lot of artist images? cause i prefer artist images instead of album covers.
Title: Album Art Downloader XUI
Post by: AlexVallat on 13 July, 2008, 04:17:56 AM
It's not designed for artist images, really. There is a script for http://artists.trivialbeing.org (http://artists.trivialbeing.org), but that seems to have been "Temporarily Offline" for long enough that it's return now seems unlikely.

To replace it, here's a script for Last FM artist images: lastfm-artist.boo (http://www.byalexv.co.uk/foobar/lastfm-artist.boo).

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 13 July, 2008, 05:00:47 AM
ohh thank you
while it's not designed for artist images, it's working as good as for album covers!

one aditional question: the aspect ratio is between 0 and 1.
so this means 640x480 has the same ratio as 480x640? do you think it's possible to add an aditional option like /aspect "{horizontal|vertical}" that means that an ratio of 0.75 and horizontal allow all images f.e. 480 high and 480 to 640 wide but not vice versa?
Title: Album Art Downloader XUI
Post by: Squeller on 19 July, 2008, 04:27:04 AM
Because of ColumnsUI NGplaylist I'm now also one of those AlbumArt hunting folks. Haven't tested your component yet, but anyway: Thank you.

OMG, the .Net framework 3.5 redist package is 195 MB.
Title: Album Art Downloader XUI
Post by: Squeller on 19 July, 2008, 04:50:17 AM
Wow, your program is the bomb. Many thanks. I have some suggestions, because I download "front", "back" and "disc", and I guess this is what many people do: Would you add two additional buttons besides the save button, which save to a userdefined name? This would make the workflow faster. Currently I use "save as...".

Also, a quick preview when hovering images would also be nice.

A minor thing: I start it with foo_run, but it doesn't come to top. Can you make your program come to foreground, when called?
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 July, 2008, 05:12:28 AM
do you think it's possible to add an aditional option like /aspect "{horizontal|vertical}" that means that an ratio of 0.75 and horizontal allow all images f.e. 480 high and 480 to 640 wide but not vice versa?
I'll see if I can think of a good way of doing this. Possibly /requireOrientation portrait|landscape, but I'm not set on that yet.

Wow, your program is the bomb. Many thanks. I have some suggestions, because I download "front", "back" and "disc", and I guess this is what many people do: Would you add two additional buttons besides the save button, which save to a userdefined name? This would make the workflow faster. Currently I use "save as...".

Also, a quick preview when hovering images would also be nice.

A minor thing: I start it with foo_run, but it doesn't come to top. Can you make your program come to foreground, when called?
Thanks for your comments! I've had plans for a system of name [a href='index.php?act=findpost&pid=528906']Presets[/a], which would cover the behaviour you wanted for front/back/disc, for quite a long time now, but have still never actually got round to coding it. It may still happen, if I end up with a lot of time to work on this app, but I can't say when.

The problem with previewing on Hover is that previewing causes the full sized image to be downloaded, which is an action I'd rather be more explicit than just a hover. Also, having tested it out, it ends up being more irritating than anything else, as the question of when to dismiss the popup becomes a problem. Moving the mouse outside the popup (the usual way of dismissing one) can be a big annoying move if it is a large image, and it is easy to accidentally popup a preview when you didn't want one. So, on balance, no, hovering will not pop up previews, sorry.

I'm not sure why you are seeing the application not come to the front when it is started with foo_run - it always has for me. Do other programs you start with foo_run come to the front?

Alex
Title: Album Art Downloader XUI
Post by: Squeller on 19 July, 2008, 06:03:03 AM
Just realized clicking on the image shows a preview, this is enough. Yes, front/back/disc would be nice.
OK, at first start it comes to front. But when I uncheck the "Search in new window" option, in order to have only one instance, additional calls via foo_run do not bring the window to front, this is what I mean.
Title: Album Art Downloader XUI
Post by: tuxman on 19 July, 2008, 08:09:50 AM
Great tool, I use it with Winamp though...
Is there a way to make it run through Winamp's Media Library automatically?



edit:
Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 July, 2008, 02:04:37 PM
when I uncheck the "Search in new window" option, in order to have only one instance, additional calls via foo_run do not bring the window to front, this is what I mean.
Ah, OK, yes I see this now. I'll fix that for the next version.

Great tool, I use it with Winamp though...
Is there a way to make it run through Winamp's Media Library automatically?
I suppose, if Winamp exposes its media library to external applications through an API, a Winamp Browser could be written. It's not a priority though, I'm afraid, as I'd have to learn the Winamp API first!

Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?
Could you be more specific about the steps that cause this problem? The only thing I can think of that might be related is that if you start a search from an item in the File Browser, then the path to save to in the Search Window is automatically set from the path to the item in the file the search was launched from. If that's not it, could you try opening a new window (using the menu), entering the value you want for the save path, then closing the window. Open a new one again, and it should show the changed value.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 19 July, 2008, 02:13:56 PM
Ah, yes... after a restart the problem is gone, thanks.

Another suggestion:
When I resize the cover previews, could the whole item be resized, too, so the text is not truncated?
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 July, 2008, 02:30:27 PM
When I resize the cover previews, could the whole item be resized, too, so the text is not truncated?
I did look into this, but when I tried both possibilities, I found having the size of the preview and the size of the whole item being independent to be easier to use.

Just to check - you are aware you can resize the whole item by grabbing the dragger on the right hand edge of it? Also, you can also choose to have the text underneath the item, so it is less truncated, by clicking the little curved arrow thing on the bottom right of the item. In that mode, the whole item is resized when the image is resized too. There's a slight cosmetic bug with this mode in that the information link icon and the curved arrow to switch back to the original mode get in each others way, but I should have that fixed for the next version too.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 19 July, 2008, 04:38:50 PM
I' aware of the separate resizing possibilities indeed, but I didn't know if this was by design. Thanks.
Title: Album Art Downloader XUI
Post by: tuxman on 19 July, 2008, 04:54:00 PM
Ah... another suggestion:
I would appreciate a possibility to specify special character replacements.

The AAD replaces : by _, but Winamp requires - instead...

edit:
Why do the saved pictures always have a great quality, while the preview images have a lot of visible artefacts?
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 July, 2008, 05:49:46 PM
I would appreciate a possibility to specify special character replacements.
I'll consider it. I'm not sure how generally useful it would be (why does Winamp even care if _'s are in the filename?), and there's no room to add that to the Options area without making it take up considerably more space. Anyone else here want to say if they'd find this a useful feature or not?

Why do the saved pictures always have a great quality, while the preview images have a lot of visible artefacts?
Possibly because the full size images haven't downloaded yet? AAD shows a thumbnail for the results it finds. If you preview one, it starts to download the full sized image to display, but until it's downloaded the preview will show a scaled-up version of the thumbnail. It says "Full sized image downloading..." at the top of the image while this is happening. If you keep the preview visible for long enough, it should replace itself with the high quality image soon enough.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 19 July, 2008, 05:52:53 PM
It's quite hard to decide which image to download without having the "full quality" thumbnail... is it possible to increase their quality a very, very tiny bit?
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 July, 2008, 02:50:20 AM
It's quite hard to decide which image to download without having the "full quality" thumbnail... is it possible to increase their quality a very, very tiny bit?
Unfortunately, no. The thumbnail is as provided by the source website providing the cover art, so the size and quality of it is not under my control. If you need to see full size images before you choose which one to save, you can either just click on a few of the most likely candidates and wait for them to download, or use the option to always automatically download full sized images.

Alex
Title: Album Art Downloader XUI
Post by: phibercrack on 20 July, 2008, 04:38:13 AM
Quote
Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?


Quote
Could you be more specific about the steps that cause this problem? The only thing I can think of that might be related is that if you start a search from an item in the File Browser, then the path to save to in the Search Window is automatically set from the path to the item in the file the search was launched from. If that's not it, could you try opening a new window (using the menu), entering the value you want for the save path, then closing the window. Open a new one again, and it should show the changed value.


Hi, I tried the same, and I think it is realy a bug in this version, with version 0.19 erverthing works fine...

Thanks for this nice programm 

phiber
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 July, 2008, 04:50:41 AM
Quote
Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?
Hi, I tried the same, and I think it is realy a bug in this version, with version 0.19 erverthing works fine...
OK, let me get this straight. You run AAD, then click File, New, File Browser. You then click the Options link, and in the "Specify path to find images" box, enter "%album%.*". You then close the file browser window. You then open a new file browser window (again), click the Options link, and the "Specify path to find images" does not show the "%album%.*" that you had entered?

The above works just fine for me, but if that's not what you are doing, or not the result you are seeing, then please give me detailed steps like those to explain what you do, and the result you get.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: phibercrack on 20 July, 2008, 05:34:46 AM
I use the explorer extension to select an artist with e.g. 5 cds
- "Specify path to find images" is e.g. folder.jpg
- then i select all 5 cds and press "get artwork for selection"
- the 1st cd is O.K.
- but all other cds have a wron "save image to" path (alway's %artist%%extension%oldfilepahtof.folder.jpg

phiber
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 July, 2008, 07:08:03 AM
- the 1st cd is O.K.
- but all other cds have a wron "save image to" path (alway's %artist%%extension%oldfilepahtof.folder.jpg
Thanks for the extra info. I think I might have tracked down the problem - are the other searches being held in the queue? That could have been a bug introduced between 0.19 and 0.20, as I changed how settings applied to windows as they are dequeued. If that's the case, I'll have it fixed for the next version.

Alex
Title: Album Art Downloader XUI
Post by: phibercrack on 20 July, 2008, 07:19:39 AM
yes, all other searches being held in the queue.

phiber
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 July, 2008, 03:26:13 AM
AlbumArt Downloader XUI v0.21 Released

This is a bug fixing release, to address the issues that were raised over the last few days:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: tuxman on 21 July, 2008, 06:42:53 AM
Updating immediately, thanks for the quick fixes. 
Title: Album Art Downloader XUI
Post by: tuxman on 21 July, 2008, 08:47:15 AM
Is it planned to add sth like Multi-Language Support?
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 July, 2008, 09:59:05 AM
Is it planned to add sth like Multi-Language Support?
No. Internationalisation is an absolute pain to do, and even more so to retro fit to a project that wasn't built to support it from the start.
Title: Album Art Downloader XUI
Post by: tuxman on 21 July, 2008, 10:23:25 AM
OK, no problem then. 
Title: Album Art Downloader XUI
Post by: Squeller on 22 July, 2008, 03:43:25 AM
it are teh roxxorz
Title: Album Art Downloader XUI
Post by: locutus on 23 July, 2008, 08:38:37 AM
I use only embedded arts. Is this with the toll possible?
Title: Album Art Downloader XUI
Post by: teh roxxors on 23 July, 2008, 10:29:48 AM
I use Amazon or Wikipedia. Why run MP3s through yet another app?

Does this offer high resolution inserts and CD labels?
Title: Album Art Downloader XUI
Post by: tuxman on 23 July, 2008, 01:23:20 PM
AFAIK it mainly finds front covers.
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 July, 2008, 01:44:03 PM
I use only embedded arts. Is this with the toll possible?
No, sorry. This tool has no support for embedded artwork.

I use Amazon or Wikipedia. Why run MP3s through yet another app?

Does this offer high resolution inserts and CD labels?
Scripts to search Amazon are included. Wikipedia is not, as it does not have any standardised way of presenting cover art, it can't be automated.

Some of the included sources have high resolution CD labels and back covers, but I haven't seen any that offer inserts. If you know of a website offering them, let me know and I might be able to make a script to search it too.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 23 July, 2008, 01:54:39 PM
Wikipedia is not, as it does not have any standardised way of presenting cover art, it can't be automated.

Uhm, it actually has. It should be enough to cover the English Wikipedia, as it is the largest one, where cover art is usually presented this way:

Quote
{{Infobox Album | <!-- See Wikipedia:WikiProject_Albums (THIS NOTE IS OPTIONAL!) -->
|  Name        = Misplaced Childhood
|  Type        = [[Album]]
|  Artist      = [[Marillion]]
|  Cover      = Marillion-Misplaced_Childhood(gatefold).jpg
|  Released    = June 1985<br/>October 1998 (two-disc edition)
|  Recorded    = Hansa Ton Studios, [[West Berlin]], March - May 1985
|  Genre      = [[Progressive rock]]
...
}}


(Source (http://en.wikipedia.org/wiki/Misplaced_Childhood))
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 July, 2008, 02:09:33 PM
Looks like they've done some work on it since I last looked at it. If the majority of albums now use that standard, then they could be picked up by a script. Unfortunately there doesn't seem to be any good way of searching for albums, but if I think of one, I might do a Wikipedia script.
Title: Album Art Downloader XUI
Post by: tuxman on 23 July, 2008, 02:20:47 PM
You might try to search for the particular Infobox template...

I don't think that all albums use this template, but it nevertheless exists.
Title: Album Art Downloader XUI
Post by: dewey1973 on 28 July, 2008, 01:31:12 PM
I searched the thread and did not see anything on this.  Has anyone been able to rework the Walmart script?
Title: Album Art Downloader XUI
Post by: Ritchie Califoreigner on 02 August, 2008, 07:14:40 AM
Hey everybody.
I have a little problem wuth this program.
I tried all of possible versions of program, but only in 1.1 - 1.3 i can read symbols, and in 1.3 - 1.6.5 i can't read and set up this prog because of troubles with strange symbols instead of normal english. Here is sreen.
(https://hydrogenaud.io/imgcache.php?id=bf746546b18344a33d0aadc99de7bde5" rel="cached" data-warn="External image, click to view at original size" data-url="http://img53.imageshack.us/img53/1306/albumartrg1.jpg)
(https://hydrogenaud.io/imgcache.php?id=bf015e2cc5d88e1dfd3bee265311bebc" rel="cached" data-warn="External image, click to view at original size" data-url="http://img365.imageshack.us/img365/4509/albumart2ql8.jpg)
I have Russian-interface version of Windows XP, maybe i should change something in system settings, using "regedit" for example. What should i do to make it work? Sorry for my english, thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 02 August, 2008, 08:22:14 AM

I'm not sure what version of which ancient predecessor of Album Art Downloader you are using there, but if you'd like to try downloading the latest version: AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe), you will probably find it works just fine.

Alex
Title: Album Art Downloader XUI
Post by: Ritchie Califoreigner on 02 August, 2008, 09:48:54 AM

I'm not sure what version of which ancient predecessor of Album Art Downloader you are using there, but if you'd like to try downloading the latest version: AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe), you will probably find it works just fine.

Alex


Yeah, thats great!    It works. You know, i had AlbumArtDownloaderXUI-0.21.exe file, but i didnt know what it was. I tried to install and it created folder in Program Files with just one exe file - aad.exe with command line interface. Size of installer - ~900kb, but i downloaded zip (~1Mb) and it worked!
So, now I dont understand what for http://unrealvoodoo.org/hiteck/projects/albumart/ (http://unrealvoodoo.org/hiteck/projects/albumart/) version? It distinguishes from yours and it doesnt work 
Thanks dude!
Title: Album Art Downloader XUI
Post by: AlexVallat on 02 August, 2008, 10:07:18 AM
So, now I dont understand what for http://unrealvoodoo.org/hiteck/projects/albumart/ (http://unrealvoodoo.org/hiteck/projects/albumart/) version? It distinguishes from yours and it doesnt work 
That project is nothing to do with this one. In fact, I wasn't aware of it until you mentioned it here. Guess I've got some competition :-)
Title: Album Art Downloader XUI
Post by: Ritchie Califoreigner on 02 August, 2008, 10:47:51 AM
So, now I dont understand what for http://unrealvoodoo.org/hiteck/projects/albumart/ (http://unrealvoodoo.org/hiteck/projects/albumart/) version? It distinguishes from yours and it doesnt work 
That project is nothing to do with this one. In fact, I wasn't aware of it until you mentioned it here. Guess I've got some competition :-)

If look at program name closely, there is a little difference - Album Art Downloader in yours and Album Cover Art Downloader in his. Dont know who was the first, but i like your stuff. Especially the great idea with foobar database. Its exactly what I needed - to get information from tags. Great work, thanks!
Title: Album Art Downloader XUI
Post by: masterrossi on 09 August, 2008, 08:18:21 PM
Is it me or has the Rate Your Music script not been working for a while know?

Of things I am 100% sure that there is artwork on RYM it doesn't load it any more. Anyone has an idea what this can be?
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 August, 2008, 03:44:04 AM
Anyone has an idea what this can be?
That would be because Rate Your Music added a check for user-agent, and returning 403 Forbidden if they don't like the user-agent requesting the image.

So here's an updated script that sets the user agent to Mozilla/5.0 for requesting the images.

RateYourMusic.boo (http://www.byalexv.co.uk/foobar/rateyourmusic.boo)
Title: Album Art Downloader XUI
Post by: tuxman on 10 August, 2008, 08:11:51 AM
Thanks for the fast update.
Title: Album Art Downloader XUI
Post by: masterrossi on 10 August, 2008, 10:46:41 AM
Anyone has an idea what this can be?
That would be because Rate Your Music added a check for user-agent, and returning 403 Forbidden if they don't like the user-agent requesting the image.

So here's an updated script that sets the user agent to Mozilla/5.0 for requesting the images.

RateYourMusic.boo (http://www.byalexv.co.uk/foobar/rateyourmusic.boo)

Hmm,

I got this error code when loading the scripit

Code: [Select]
Searching for scripts...
Found 26 files: [albumartexchange.boo, amazon-ca.boo, amazon-co-uk.boo, amazon-com.boo, amazon-common.boo, amazon-de.boo, amazon-fr.boo, amazon-jp.boo, amazon.boo, amazon_de.boo, artists.trivialbeing.boo, cduniverse.boo, cover-paradies.boo, coveralia.boo, coverisland.boo, discogs.boo, freecovers.boo, google.boo, itunes.boo, juno-records.boo, lastfm-artist.boo, psyshop.boo, rateyourmusic.boo, revhq.boo, util.boo, yes24.boo]...
Loading references: [ICSharpCode.SharpZipLib.dll, System.Web]...
Compiling scripts...
rateyourmusic.boo(39,13): error BCE0005: Unknown identifier: 'logFile'.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 August, 2008, 06:09:00 AM
I got this error code when loading the scripit

Oops, looks like I uploaded the wrong (debugging) version - I've fixed that and the link should now go to the right script. Or, you can just remove the line starting "logFile".

By the way, if you edit a post rather than posting a new reply, I don't get an email notification, so I don't know to come and read it, which is why this answer is so delayed!

Alex
Title: Album Art Downloader XUI
Post by: masterrossi on 12 August, 2008, 06:11:12 AM
Ahh, I see.

Will look at it when I get home from work this evening.
Title: Album Art Downloader XUI
Post by: masterrossi on 12 August, 2008, 02:53:33 PM
it works

Thanks a lot.
Title: Album Art Downloader XUI
Post by: m_l on 13 August, 2008, 12:13:16 PM
Thank You  for hard work and your efforts
Title: Album Art Downloader XUI
Post by: AlexVallat on 17 August, 2008, 03:10:54 PM
AlbumArt Downloader XUI v0.22 Released

After an absurdly long wait, I've finally gotten around to implementing the Presets idea! As this has involved some fairly major internal changes, I'm not going to update the first post, or main links yet. If you are feeling adventurous, though, you can download 0.22 here and let me know how you get on with it.

To start using presets, add the placeholder %preset% anywhere within your default save path. It will automatically be there for new installations, but when upgrading it keeps your existing settings, so your current save path won't have it in there. For example, if your current save path ends Folder.%extension%, consider changing this to Folder%preset%.%extension%.

Once that placeholder is present, a drop down arrow will appear next to the save buttons in the results - click those to save the result with the %preset% placeholder substituted by one of the values listed in the menu that pops up. I've included some usual candidates (Front, Back, Inlay, etc.), but you can customise the list by clicking the "Edit Presets" item at the bottom of the menu.

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.22.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.22.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: tuxman on 17 August, 2008, 03:25:11 PM
Thanks, as always.

I'll try it. Anyway.
I'm sure it won't explode.

Title: Album Art Downloader XUI
Post by: Whigged on 18 August, 2008, 11:52:40 AM
Alex,

I'm just begining to mess with AAD, and I have what I hope is a pretty simple question. 

I save all of my covers in the album folder as cover.jpg.  AAD defaults to "folder.jpg."  Is there a way to change this permanently so I don't have to go into options each time and do it manually?

Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 August, 2008, 12:05:17 PM
Is there a way to change this permanently so I don't have to go into options each time and do it manually?
Are you starting from the File Browser?

If so, go into the options in the File Browser, and remove the first part (up to and including the | symbol) so that you just have "Cover%preset%.%extension%" (or "Cover.%extension%", if you are still using v0.21). The default path to save to will then be Cover.jpg instead of Folder.jpg. This is because the File Browser creates the default path to save to based on the first alternative, if multiple alternatives (separated by |) are present.

Alex
Title: Album Art Downloader XUI
Post by: Whigged on 18 August, 2008, 12:37:45 PM
Is there a way to change this permanently so I don't have to go into options each time and do it manually?
Are you starting from the File Browser?

If so, go into the options in the File Browser, and remove the first part (up to and including the | symbol) so that you just have "Cover%preset%.%extension%" (or "Cover.%extension%", if you are still using v0.21). The default path to save to will then be Cover.jpg instead of Folder.jpg. This is because the File Browser creates the default path to save to based on the first alternative, if multiple alternatives (separated by |) are present.

Alex


That worked perfectly - thank you.

Another question: Is it possible to launch the File Browser without launching Album Art Downloader first?
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 August, 2008, 01:32:39 PM
Another question: Is it possible to launch the File Browser without launching Album Art Downloader first?
Yes: AlbumArt.exe /fileBrowser will start it as if you'd clicked File/New/File Browser. You can also have it start searching a specified path immediately: AlbumArt.exe /fileBrowser "c:\music"

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 26 August, 2008, 10:34:59 AM
Hi Alex. Thanks for the great program!

Couple of questions:

1) Shouldn't the "File path pattern matching can be made to match folders instead of files, by ending the pattern with "\."" introduced in 0.19 be added to "Command Line Reference -> /localImagesPath"?

2) Why does the "c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe" (Visual C# Command Line Compiler) run everytime I start and close XUI? Is it really needed? After I updated to 0.22 version (installer, previously I used the zipped 0.18), the "csc.exe" starts twice before XUI opens (+ once when closing XUI), how come? I thought that the .NET 3.5 was required, so why is the csc.exe from .NET 2.0 SP1 ran? I'm really not into the deep technical side of this thing, this just seemed a bit odd to me.

3) How come the Discogs search is so awfully slow compared to others? In example, Cover-Paradies gets 15 results when searching "Pearl Jam / Ten" rather quickly (and images are really large compared to Discogs results), Discogs gets 36 and it's REALLY slow.. about 6 (or more) times slower. I tried Discogs webpage search and it's quick, and so is the image loading from the results. The "automatically download full-size images" was set to "never".

I tried to optimize the script by changing:
Code: [Select]
query as string = artist + " " + album

to this:
Code: [Select]
query as string = "\"" + artist + " - " + album + "\""

but it only helps little to weed out the not relevant artist releases (but still improvement nonetheless). I noticed that only the first page of the results (20 items) is used in the script.. which is quite ok since how many albums have over 20 different releases.

Bottom line: I didn't quite understand why the Discogs search is so slow.. do you know?

P.S. You really should be brave and push the versioning to 1.0 since your program is so damn excellent.  Thanks again!
Title: Album Art Downloader XUI
Post by: Akkurat on 26 August, 2008, 11:02:22 AM
Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading? It's really annoying to set everything again after updating. Or does this happen only when using the zipped XUI (I just installed the XUI for the first time)?

Look at the picture below:
(https://hydrogenaud.io/imgcache.php?id=00a92eecb1a27e79ac3fcc440cb0eeb2" rel="cached" data-warn="External image, click to view at original size" data-url="http://img401.imageshack.us/img401/2701/xuiib3.png)
Is the "Url_..." in folder names an indicator of a path where the program lies? Seems rather messy to me. Also, a new folder for every new version?! Is there so many/big changes to the user.config file that it's not possible to merge the old and the new one automatically?

Thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 August, 2008, 11:07:15 AM
1) Shouldn't the "File path pattern matching can be made to match folders instead of files, by ending the pattern with "\."" introduced in 0.19 be added to "Command Line Reference -> /localImagesPath"?
The file path pattern matching referred to here is for the file browser, not the local image search. It doesn't make much sense to search for folders instead of files, if searching for images, as images are files, not folders.

2) Why does the "c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe" (Visual C# Command Line Compiler) run everytime I start and close XUI?
I believe csc.exe is called to perform dynamic compilation to assist with XmlSerializer, and XmlSerializer is used to read and write configuration settings. That would explain why it is being called at loading and closing. I don't know why version 2 is being called, this is not something that is under my direct control. Is it causing a problem?

3) How come the Discogs search is so awfully slow compared to others?
Discogs is slow for a couple of reasons. Firstly, it doesn't have thumbnails, so the full-sized image is downloaded for every result. Secondly, the images can't be obtained directly from the search results page, so for each result, another page must be fetched to obtain the image url from. Thirdly, Discogs is just quite slow, compared to other sites.

P.S. You really should be brave and push the versioning to 1.0 since your program is so damn excellent.  Thanks again!
Thanks for the vote of confidence! I'm actually quite happy with the code now, but a 1.0 release also requires user documentation and a proper website, both of which I've been far too lazy to do so far!

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 August, 2008, 11:21:35 AM
Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading?
This should already be happening. If the upgrade isn't working properly, I'll look into it, but it is definitely supposed to keep existing settings.

Everything past the AlumArt.exe_ in the folder name is not under my control. This is handled automatically by the .net configuration settings / isolated storage mechanism, but yes, I think it relates to the folder the .exe file is in.

The installer will automatically delete all the ApplicationData\AlbumArtDownloader\AlbumArt.exe_* and aad.exe_* folders on uninstall, but has no special behaviour on install. Merging of old settings is done the first time a new version of the application is run.

I could, I suppose, write my own custom configuration system and store the configuration files wherever I wanted, in whatever format I wanted, but as .net provides a ready built configuration file system, I choose to use that. There are usually good, if obscure, reasons for the strange things it does - someone has put a great deal of thought and work into it - that I do not intend to duplicate.

Alex
Title: Album Art Downloader XUI
Post by: Goesen on 26 August, 2008, 01:12:51 PM
Thank you for your superior tool. It's a great help. But I have 1 Problem and 1 suggestion

The Problem: When I open AAD xui and search for the first time, the search will last unbelieveable long for all internet searches.
AND if you choose to many search plugins, you will get 0 results (even searching google images for "foobar" will result in no picture at all)
after the first search was successfull i can make as many searches as i want, all of them really fast and accurate with all plugins. But if i close all aad xui windows, i have to wait again.

I use xp sp3 and no software(windows) firewall

and my sugesstion: could you (or somebody else) add an itunes plugin? you could steal the code from "itunesstorevalidator" 
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 August, 2008, 03:07:52 PM
Thanks for your comments. I can't reproduce the problem you have described - do you think you could check if it is any particular source that is causing it? If you have only one source selected, the next time you start AAD, does it still go slow? Does it matter which source?

We used to have an iTunes image script, but since they started encrypting their images, it can't be used any more.

If you meant some sort of integration with the iTunes client, then no, that's not going to happen. Not unless someone else writes it, anyway, as I won't be installing that junk on my PC. As you say, there is already an itunesstorevalidator, which I believe already integrates with Album Art Downloader in some way.

Alex
Title: Album Art Downloader XUI
Post by: Goesen on 26 August, 2008, 05:47:32 PM
Hi Alex
Yes i would like some tool which uses i tunes.
And i'd rather use a plugin for your code, because each time i use itsv i get the feeling it destroys more than it fixes.
Is here anyone who has free time and nothing to do?


But Alex, if you like, you could add the Encyclopedia Metallum (should be very similar to discogs)
http://www.metal-archives.com/ (http://www.metal-archives.com/)
(registration requiered for the advanced search


Quote
do you think you could check if it is any particular source that is causing it

any script which is using the internet

Quote
If you have only one source selected, the next time you start AAD, does it still go slow

yes. choosing only googleimages for artist "foobar" takes around 15 sek. if i pick more sources it will take even longer or give no images at all. But as soon as i get the first pictures, i can choose "select all", search again and get nearly instantly all images.

Quote
Does it matter which source

any script which is using the internet

I just played a bit with your command line tool and got nearly the same results
aad "foobar" spend 15 sek for the first source (Album Art Exchange)
after the first source was done, it works pretty fast

if i set other sources i spend it's 15 sec on the first other source.

maybe tomorrow i will try this on another pc, but not today
Title: Album Art Downloader XUI
Post by: Akkurat on 26 August, 2008, 08:40:23 PM
I believe csc.exe is called to perform dynamic compilation to assist with XmlSerializer, and XmlSerializer is used to read and write configuration settings. That would explain why it is being called at loading and closing. I don't know why version 2 is being called, this is not something that is under my direct control. Is it causing a problem?

No problems. But remember when I PM'd you about the slow startup of XUI when run for the first time after reboot? I just realized (thou not 100% sure) that part of the slowdown is because the csc.exe is searched from the HD. Why it settles for the "version" (not really versions which makes this even odder) 2 csc.exe, no idea. In fact, I renamed the csc.exe in "v2.0.50727" dir and ran XUI; errorlog.txt pops up:
Code: [Select]
...
App version: 0.18.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ArgumentException: The property 'SearchPathPatternHistory' could not be created from it's default value. Error message: Compiler executable file c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe cannot be found.
...

So it seems that the .NET 2.0 is also required... or does the installer of 3.5 add the "2.0" if it does not exist? The csc.exe of v1.1 and v3.5 is not accepted (again it's the "not versions even if they're named as versions..?). I also noticed that, when running these test in VPC, that the csc.exe runs cvtres.exe (Microsoft® Resource File To COFF Object Conversion Utility) from the same directory.

Is the "property 'SearchPathPatternHistory'" relating straight to your code? I mean, I just wondered if you could try to avoid running the csc.exe (&cvtres.exe) automatically.. maybe not possible at all but doesn't hurt to ask you.  Though this is quite clearly related to the ".net provides a ready built configuration file system" you wrote, right? And thus nothing can be done about it.

And could it be possible to speed up the process by "telling" in your code where the 2.0 csc.exe is? I tried to add the directory to the PATH and rebooted but that had no effect at all.. so it may be that the csc.exe isn't searched after all and it's something else that slows down the startup..

Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading?
This should already be happening. If the upgrade isn't working properly, I'll look into it, but it is definitely supposed to keep existing settings.

I tested by installing 0.18, changed some things, installed 0.21 over (and finally also 0.22) = all changes (I made, to the options, group by, sort by & maximum results) were kept, except window size. So it's not so big of a deal..

P.S. I saved my testbed in VPC, so if you like me to test something out relating to these conversations..
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 August, 2008, 03:24:17 AM
I think the slower startup after reboot is due to initialising WPF. This can be tested by running another WPF application after reboot, before XUI, then running XUI and seeing if it is as fast as usual.

If it was csc.exe causing the problem, then it would happen on every run, not just the first one.

It would be interesting to uninstall the .NET Framework (all versions), then install only version 3.5, and check to see whether that includes csc.exe under the v2.0.50727 dir, or whether it would then start using the one under the v3.5 dir. I don't think it really matters, but it might be good to know.

SearchPathPatternHistory is one of my settings, yes. It is only one of many settings that are stored in XML serialized format though, so I expect it was just the first one to be read. To avoid XML configuration altogether would be a far larger change than just one stored property.

Quite apart from that, I've yet to become convinced that there is any harm in it. I don't think it is searching the hard disk for csc.exe - it knows exactly where to find it, as demonstrated by the fact that if it isn't there, it throws an exception stating where it thought it was. This is just internal functionality of the .net framework, and not something that needs worrying about. I had to switch the timing resolution of process explorer down to 0.5s just to see the thing appear and disappear!

Thanks for the information about the upgrading. It seems that the upgrade process is working, but isn't upgrading the window size (and position?) settings - I'll see if I can figure out why.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 27 August, 2008, 03:20:57 PM
It would be interesting to uninstall the .NET Framework (all versions), then install only version 3.5, and check to see whether that includes csc.exe under the v2.0.50727 dir, or whether it would then start using the one under the v3.5 dir. I don't think it really matters, but it might be good to know.

It does install some (basic required?) of the 1.0, 1.1, 2.0 & 3.0 stuff along with the 3.5. I used the setup installer (which downloads only needed stuff), not the full ~200 MB package. The 2.0 csc.exe is still used like I suspected.. because it's a different product although it's named like a version.. stupid Microsoft. So, no need to change the requirements.

Thanks for the information about the upgrading. It seems that the upgrade process is working, but isn't upgrading the window size (and position?) settings - I'll see if I can figure out why.

Yes, it's also the position which is not retained. Not a biggie but thanks for checking it out.
Title: Album Art Downloader XUI
Post by: weaker on 27 August, 2008, 04:19:47 PM
I don't know if it helps in your case but here you can downlad a .NET cleaning utility if you have trouble with reinstalling:
http://blogs.msdn.com/astebner/archive/200...07/8108332.aspx (http://blogs.msdn.com/astebner/archive/2008/03/07/8108332.aspx)
In step no.4 there is the link to the ".NET Framework cleanup tool"
Title: Album Art Downloader XUI
Post by: ameliajune on 28 August, 2008, 02:08:15 PM
This program is fantastic. Works beautifully!

If I have art already downloaded in some files but it is small in size (200 pixels) can I overwrite this with 500 pixel selections in AAD? How would this work because doesn't it just seek out files that don't have the album art attached to it?

Thanks again!
Title: Album Art Downloader XUI
Post by: AlexVallat on 28 August, 2008, 02:35:10 PM
How would this work because doesn't it just seek out files that don't have the album art attached to it?
The file and foobar browsers will list all albums found, whether or not they have image files. It will also list the image file size of those albums for which it is found, so if it looks too small, you can choose to download new art for them too.

Of course, you can always search directly for artist and album name, regardless of whether that album was found by the file or foobar browsers or not!

Alex
Title: Album Art Downloader XUI
Post by: ameliajune on 28 August, 2008, 03:32:50 PM
Thanks, but here's an anomaly I found that I don't understand.

I ripped two tracks to MP3 using dbpoweramp, Lame 3.97

Both tracks ripped using artwork from the various databases at 310 x 310.
On first look, the file sizes were #1 - 13kb and #2 - 12kb

I then used AAD to select 300 x 300 files from Google, and the sizes changed to #1 - 2kb and #2 - 20kb

I then used AAD to select 400 x 400 files from Google and/or Discogs and the sizes changed to #1 - 117kb and #2 4kb

What is causing the erratic file size change? I thought all files that were 310 x 310 etc. equaled 10kb (or said standard size)?
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 August, 2008, 03:15:15 AM
What is causing the erratic file size change? I thought all files that were 310 x 310 etc. equaled 10kb (or said standard size)?
File size depends on more than just pixel size. For a start, it depends on the format, so a .jpg will be a different size from a .png. For formats other than .bmp, the size also depends on the quality of the image - a more highly compressed image will have a smaller file size, but more noticeable compression artefacts.

Alex
Title: Album Art Downloader XUI
Post by: ameliajune on 29 August, 2008, 03:46:16 AM
Quote
a .jpg will be a different size from a .png.


Ah, ok. When I'm selecting is there a ladder of smallest to largest, i.e., go for a png, then a jpg, etc. or no because I'd have no idea the compression factor? (I'm trying to get the best quality around 500 without too much of an increase if at all possible).
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 August, 2008, 04:07:21 AM
(I'm trying to get the best quality around 500 without too much of an increase if at all possible).
For photo-style images (which artwork tends to be), jpg is probably best. The thing is, if it's been poorly scanned, while it might technically be a high quality image, it could still look bad! I would use Google Images as a last resort, really - I find the quality of the other sources to be more reliable. In any case, it's probably best to preview before finally accepting an image, just in case.

Alex
Title: Album Art Downloader XUI
Post by: ameliajune on 29 August, 2008, 01:25:49 PM
Quote
The thing is, if it's been poorly scanned, while it might technically be a high quality image, it could still look bad!


Yes I found that out! I was testing and saved a 600x600 picture from Amazon of all places and when I imported it and took a look it was blurry! Might've been an anomaly, as you said usually Amazon is a good resource.

The feature to enlarge the pictures before saving is excellent. Thanks again.
Title: Album Art Downloader XUI
Post by: Vermelhu on 09 September, 2008, 08:17:32 PM
Does this not allow you to embed album art in mp3 files? I seem to remember the old version allowing it... I may be thinking of another similar program though.
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 September, 2008, 03:31:55 AM
Does this not allow you to embed album art in mp3 files? I seem to remember the old version allowing it... I may be thinking of another similar program though.
No, neither this version, nor any previous version of Album Art Downloader XUI, Album Art Downloader or Cover Downloader ever allowed embedding of album art in mp3 files, or finding art already embedded. As far as I'm concerned, it won't in the future either - having a copy of the album art embedded in each file of the album is not a system I consider worth supporting.

Alex
Title: Album Art Downloader XUI
Post by: Vermelhu on 10 September, 2008, 05:00:23 AM
having a copy of the album art embedded in each file of the album is not a system I consider worth supporting.

Alex


I don't see why not... Many players (notably iTunes) don't look in the album folder for art, instead opting for their own database of downloaded album art. However this is non-portable... When moving your music to other machines or re-installing your OS, all the art is lost and must be re-download. And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

With embedded album art in tags, none of this is an issue.
Title: Album Art Downloader XUI
Post by: odyssey on 10 September, 2008, 05:22:29 AM
And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

Just to nit-pick, this is NOT true. I've seen albumart in iTunes for albums in my collection that were not for sale.

But still they also miss a lot and many covers are very poor quality.
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 September, 2008, 05:28:27 AM
I don't see why not... Many players (notably iTunes) don't look in the album folder for art, instead opting for their own database of downloaded album art. However this is non-portable... When moving your music to other machines or re-installing your OS, all the art is lost and must be re-download. And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

With embedded album art in tags, none of this is an issue.
Yes, a proprietary database is an even worse solution. Just another reason not to use iTunes, really, as if we needed another. Apple do make a whole lot of technically inferior rubbish in pretty boxes, and iTunes is just another shining example of the genre.

If you have to use iTunes, then [a href='index.php?showtopic=51708']iTSfv[/a] will probably help.

Alex
Title: Album Art Downloader XUI
Post by: Vermelhu on 10 September, 2008, 06:05:25 AM
iTSfv looks handy, but iTunes was just one example among many. It just happened to be the most familiar one. My main point was the fact that if the album art is contained within the file, any similar issues would not be experienced.

I don't see any compelling reason not to embed art - the only one I can think of is storage, and considering the price of storage these days it's not much of an excuse. Feel free to enlighten me if there are others though.

In general, I tend to have the album art both in the folder and in the files... Personal preference. I just think it would be a nice feature to have as an option.
Title: Album Art Downloader XUI
Post by: ameliajune on 11 September, 2008, 04:42:39 PM
GREAT program and this is one of those nit picky questions, but I see that the default for naming the pictures is Folder.jpg. Is there any way to change that to folder.jpg... lowercase? How would I do that program wise so I wouldn't have to do it on each individual one?

Thanks! 

Edit: One other thing - Is there a way to search for album only? Meaning, say I have a compilation cd ripped in FLAC with all of the files in the same folder. I noticed that AAD brings up each song (because it's a compilation they are by different artists) rather than find the album art for the album and then move on.

2nd Edit: Woohoo! I think I did it... I marked the "use file path pattern matching" set to \%artist%\%album%\* and it only brought up or seemed to.. the albums... did I do it?

3rd Edit: Wow, I'm on a roll. I seem to have fixed the naming part too... maybe when I open a blank File Browser and made changes to that it affected the rest?

Excellent. I love it when things work out.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 September, 2008, 02:48:35 AM
Well, you seem to have worked everything out for yourself, well done! To aid others who might be searching for the same answers:

To change the default for naming pictures, when starting a search from the file browser, click the Options link in the file browser and edit the "Specify Path to Find Images" box.

To match various artists albums, the best way is probably that which you mentioned, to use path pattern matching so that the name of the album and artist is taken from the name of the folder that the music files are found in. If the album and artist name can not be determined from the file path and pattern, though, then it is probably not possible.

Alex
Title: Album Art Downloader XUI
Post by: servimo on 14 September, 2008, 11:57:08 AM
Possible a proxy control? I have IE set to use a proxy when I use it, but firefox is not set to use a proxy. Album Art Downloader XUI uses the proxies preferences from IE, by using this it slow down my downloads of album art and don't want to every time I need to look for some album art I have to disable the proxy in IE.
Maybe in Options could have a get proxy configuration from IE or don't use any proxy.
Title: Album Art Downloader XUI
Post by: AlexVallat on 14 September, 2008, 01:39:57 PM
Possible a proxy control?
The proxy server settings can be overridden using the standard .net configuration system. I don't want to start adding specific UI for this into the app, but if you just want to disable proxy use, try placing this config file in your Album Art Downloader program folder (next to AlbumArt.exe): AlbumArt.exe.config (http://www.byalexv.co.uk/temp/AlbumArt.exe.config)

Alex
Title: Album Art Downloader XUI
Post by: servimo on 14 September, 2008, 01:51:20 PM
 worked fine really thanks for your effort. Just what I want: no proxies for AlbumArt Downloader XUI. Thanks! Looking for Album Art fast now and the result was increased.
Title: Album Art Downloader XUI
Post by: unknownllama on 14 September, 2008, 07:40:22 PM
I am hoping to use Album Art Downloader to run automatically for a specific folder containing files in the artist\album\song folder format. I'm not sure how to pass the specific folder for aad.exe to use. This is the code I have now:

"C:\Program Files\AlbumArtDownloader\aad.exe" /artist "%artist%" /album "%album%" /path "$replace(%path%,%filename_ext%,folder.jpg)" /sources "Amazon,Discogs" /minSize "300" /sequence "1"

What and where do I need to place the local folder for this to run correctly? I am hoping to schedule this to run automatically a couple times a week to get art for the new music I download to the folder.
Title: Album Art Downloader XUI
Post by: AlexVallat on 15 September, 2008, 02:58:42 AM
I am hoping to use Album Art Downloader to run automatically for a specific folder containing files in the artist\album\song folder format.
The command line version does include file browser or foobar browser functionality. If you want to be scanning a folder to find files which don't have art yet, you need to use the GUI. You can use the command line AlbumArt.exe /fileBrowser "path to folder" to start scanning that folder immediately.

Alex
Title: Album Art Downloader XUI
Post by: Dr Johnson on 26 September, 2008, 06:30:16 PM
Hi Alex! I'd like to get a few formalities out of the way first if I may. To begin with, congratulations on creating a wonderful program, I'm getting a lot of mileage out of it. Secondly, as this is my first post on hydrogenaudio, my greetings to you all.

OK, I'm having a problem with the cover-paradies script. It was working fine until a week or so ago, but since then it has consistently failed to procure any pics. As I consider this to be the best source of cover art on the net, it's pretty much indispensable to me. I've tried installing different versions and tinkered with the script to no avail. Are you aware of any issues with the current script? Perhaps I've been IP banned by cover-paradies, as I've been very active with this program recently. Having said that I'm still able to enter their website and download art manually, so I doubt it's that. I'm trusting in your infinite wisdom that you can find an answer for me. Thanks! 

Windows XP sp3
Album Art Downloader XUI 0.22.0.0
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 September, 2008, 04:12:47 AM
I'm having a problem with the cover-paradies script
Thanks for reporting this. Yes, they've made some changes, so here's an updated script which should work again: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)

Alex
Title: Album Art Downloader XUI
Post by: Dr Johnson on 27 September, 2008, 06:14:37 AM
Still not working for me. I just replace the old script with the new one right?
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 September, 2008, 07:46:15 AM
Yes, in the Scripts folder, replace the old one with the new one. You will need to restart Album Art Downloader XUI for it to take effect - it should come up with the "Compiling Scripts" screen when it starts again.

Once restarted, in the Sources list on the right hand side,you should see the cover-paradies script listed as version 0.6. If it still shows 0.5, it hasn't been upgraded successfully, for some reason.

If it shows 0.6 and still isn't working for you, please tell me which artist and album name you were searching for, and I'll give it a try myself.
Title: Album Art Downloader XUI
Post by: Dr Johnson on 27 September, 2008, 08:17:11 AM
Ah, never mind it's working now. I tried a search for Led Zeppelin; Physical Graffiti and it sent. Funny, I did the same search earlier and it failed. Go figure. Thanks Alex, the new script seems to have done the trick.

Edit: I've noticed that it doesn't return the same results as the old script used to. If for instance I search for 'Led Zeppelin; Led Zeppelin III', it returns results for the 3rd disc of an unrelated album, rather than the 3rd album by Zep. I've tried various other searches with similar results. Any thoughts?
Title: Album Art Downloader XUI
Post by: AlexVallat on 27 September, 2008, 08:32:01 AM
Edit: I've noticed that it doesn't return the same results as the old script used to. If for instance I search for 'Led Zeppelin; Led Zeppelin III', it returns results for the 3rd disc of an unrelated album, rather than the 3rd album by Zep. I've tried various other searches with similar results. Any thoughts?
I haven't changed anything in this area. It is possible that cover-paradies themselves have changed their search algorithms. The Led Zeppelin search you suggested seems to give me the same results when I try it on their website as it does from Album Art Downloader...
Title: Album Art Downloader XUI
Post by: Dr Johnson on 27 September, 2008, 09:01:38 AM
The Led Zeppelin search you suggested seems to give me the same results when I try it on their website as it does from Album Art Downloader...


Yes, I can confirm this. However, I tried using integers instead of Roman numerals and it found the right covers, so no big deal I guess. Thanks for your help Alex.
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 September, 2008, 06:21:36 AM
Thanks to daju (http://sourceforge.net/users/daju/), we now have a lastfm-cover.boo (http://sourceforge.net/tracker2/download.php?group_id=187008&atid=919578&file_id=295227&aid=2128513) script, which uses the Last FM API to search for covers.

It will be included in the next version, or you can just download it and put it in your Scripts folder to use it.

Alex
Title: Album Art Downloader XUI
Post by: daju on 30 September, 2008, 07:13:29 AM
Hi!
I wrote a script for darktown and put it in the tracker, so you can download it here (http://sourceforge.net/tracker2/download.php?group_id=187008&atid=919578&file_id=295448&aid=2137993).

daju
Title: Album Art Downloader XUI
Post by: Fandango on 30 September, 2008, 11:21:02 AM
Don't know if it has been proposed before, but how about showing the filesize of the images? Along with the preview and image dimensions, this is also an additional way to evaluate the quality of the image.
Title: Album Art Downloader XUI
Post by: AlexVallat on 30 September, 2008, 12:36:12 PM
Don't know if it has been proposed before, but how about showing the filesize of the images? Along with the preview and image dimensions, this is also an additional way to evaluate the quality of the image.
The filesize is not generally available before the full size image is downloaded. Often, the dimensions are, so this can usefully be determined and displayed. Once the full size image is downloaded, you can simply look at it to see the quality anyway.
Title: Album Art Downloader XUI
Post by: Akkurat on 02 October, 2008, 05:56:50 PM
The "Help -> AAD Website" menu & about dialog link (http://album-art.sourceforge.net/) doesn't seem to work. Also the "Command Line Reference" link (http://album-art.sourceforge.net/index.php/Command_Line_Reference) from the first post of this thread is not working.

Feature request: automatic update checker (when starting AAD, once a week, ...). And program & scripts updater straight from AAD (possibly separated?).

Thanks again for your work!! AAD XUI is grrrrreat!
Title: Album Art Downloader XUI
Post by: AlexVallat on 03 October, 2008, 02:29:07 AM
The "Help -> AAD Website" menu & about dialog link (http://album-art.sourceforge.net/) doesn't seem to work. Also the "Command Line Reference" link (http://album-art.sourceforge.net/index.php/Command_Line_Reference) from the first post of this thread is not working.

Feature request: automatic update checker (when starting AAD, once a week, ...). And program & scripts updater straight from AAD (possibly separated?).

Thanks again for your work!! AAD XUI is grrrrreat!
Thanks for reporting this - yes, the whole website seems to be down. Don't know why yet, but I'll look into it as soon as I figure out how it was set up in the first place.

Auto-update is a good idea, and should probably be implemented sometime. It would, of course, be optional.

Alex
Title: Album Art Downloader XUI
Post by: Light on 03 October, 2008, 06:17:16 AM
Thanks for keeping this stuff up to date! now my cover-paradies is working again too!
Title: Album Art Downloader XUI
Post by: ameliajune on 06 October, 2008, 01:46:18 AM
I have the "Group by: Local" so that if there is a folder.jpg I can see what it looks like and compare it in my hunt for a larger sized album art. However, many times (over 50%) the Local Results won't pick up the folder.jpg in the folder. Any ideas why?

Also, I noticed the program has difficulty finding cover art for Compilations, is that just the nature of the program?
Title: Album Art Downloader XUI
Post by: Squeller on 06 October, 2008, 09:42:11 AM
Semi-OT: Is this the expected speed of .net Framework apps? The Album Art Downloader starts up in maybe 5-10 seconds here (P4/GhZ/3G). Like a Photoshop CS 10 on an 386sx  Even on Vista, which at usually profits from a better prefetching mechanism. I even use Java apps which startup faster (a "Go" game app, on kgs)...
Title: Album Art Downloader XUI
Post by: AlexVallat on 07 October, 2008, 09:21:04 AM
However, many times (over 50%) the Local Results won't pick up the folder.jpg in the folder. Any ideas why?
I'm afraid I'll need a little more detail - can you let me know the artist and album you were searching for, the path of the folder.jpg you were expecting to be discovered, and the path pattern it was using to search for it (click the ... in the bottom right of the Local Files source in the sources list, then copy the contents of the "Path to find images" box). I'll then try and figure out why it wasn't picked up.

Also, I noticed the program has difficulty finding cover art for Compilations, is that just the nature of the program?
Compilations can be tricky due to there not always being a good "Artist Name" to use, and having usually fairly generic album names. I would suggest leaving the Artist blank and just putting in the album name, then hoping for the best. Not all sources will come up with anything useful, but hopefully at least one will be able to find it.


The Album Art Downloader starts up in maybe 5-10 seconds here (P4/GhZ/3G)
Is the splash-screen with "Compiling Scripts" appearing? That should only appear when changes are made to the scripts folder, and will take a little time to do the compilation before the main window appears. If it is appearing every time you start the app, then something is wrong, and we can investigate that.

If the splash-screen is not appearing, but you are still experiencing slow start-up, could you check if it happens every time, or just the first time after a reboot? The first time you run any .net app after a reboot, there will be a noticeable delay of a few seconds as it loads the framework into memory. Subsequent runs of that, or any other .net app, should then be fast.

If it is happening every time you run it, then it is just this app that is too slow! I can take a look at the start-up procedure and see if there is anything I can tweak, but I can't guarantee anything.

Alex
Title: Album Art Downloader XUI
Post by: francesco on 08 October, 2008, 02:32:00 AM
is there a version that does not require .NET Framework 3.5 ?

i have mess up pc
i had framework 1
anfter i installed framework3
after many pacthes
Title: Album Art Downloader XUI
Post by: AlexVallat on 08 October, 2008, 03:47:20 AM
is there a version that does not require .NET Framework 3.5 ?
The last version which did not require 3.5 was 0.11 (http://sourceforge.net/project/showfiles.php?group_id=187008&package_id=238728&release_id=570000). Several of the scripts in that will not be up to date though, and some of the latest updates to scripts (past v0.18) will not work, as they depend on functionality added since then.
Title: Album Art Downloader XUI
Post by: francesco on 08 October, 2008, 04:01:57 AM
is there a version that does not require .NET Framework 3.5 ?
The last version which did not require 3.5 was 0.11 (http://sourceforge.net/project/showfiles.php?group_id=187008&package_id=238728&release_id=570000). Several of the scripts in that will not be up to date though, and some of the latest updates to scripts (past v0.18) will not work, as they depend on functionality added since then.

thanks!
can i save the covers in 2 files
i mean save 2 covers files
cover.jpg and folder.jpg
Title: Album Art Downloader XUI
Post by: AlexVallat on 08 October, 2008, 04:18:25 AM
can i save the covers in 2 files
Not automatically, but you can right click on a result and choose "Save As", or click within the filename and edit it, to save another copy of the cover with a different name.

Alex
Title: Album Art Downloader XUI
Post by: BlackAle on 08 October, 2008, 10:13:21 AM
Thanks for the great utility, it's incredibly useful.

I've found some issues,

When I select a bunch of files in the file browser, it doesn't update the status in the file browser once I've saved the folder.jpg ...except for the last one in the queue.

Also the file browser doesn't remember the order of the columns. I have the folder as the last column, though whenever I reopen the file browser, it's defaulted to the first.

Would be useful to see the file size of the image, I realise you can't see this until you've downloaded the full size version, though when you click to preview, you could show it within that window.
Title: Album Art Downloader XUI
Post by: francesco on 10 October, 2008, 02:34:27 AM
is there a version that does not require .NET Framework 3.5 ?
The last version which did not require 3.5 was 0.11 (http://sourceforge.net/project/showfiles.php?group_id=187008&package_id=238728&release_id=570000). Several of the scripts in that will not be up to date though, and some of the latest updates to scripts (past v0.18) will not work, as they depend on functionality added since then.

thanks you so much
but is there a way to save covers for windows media player 11?
i know but my girlfriend uses wmp11
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 October, 2008, 03:34:51 AM
When I select a bunch of files in the file browser, it doesn't update the status in the file browser once I've saved the folder.jpg ...except for the last one in the queue.

Also the file browser doesn't remember the order of the columns. I have the folder as the last column, though whenever I reopen the file browser, it's defaulted to the first.
Thanks for reporting these bugs, I'll fix them for the next version.

is there a way to save covers for windows media player 11?
As far as I know, Windows Media Player should just pick up an image called Folder.jpg as the cover art for tracks within that folder - is that not working for you?
Title: Album Art Downloader XUI
Post by: Light on 10 October, 2008, 04:38:29 AM
I see there's a foobar plugin now to scan for existence of art in the playlists, excellent! I have it set like *front*.jpg|*cover*.jpg and all works fine. But when i get album art for a album that has no art present, it finds the art and wants to save it like %name%front%name%.jpg.

I just want it to save it as front.jpg ... any ideas on how to accomplish this (without adjusting the %name%front%name%.jpg line to front.jpg every time manually)?
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 October, 2008, 05:12:49 AM
I just want it to save it as front.jpg ... any ideas on how to accomplish this (without adjusting the %name%front%name%.jpg line to front.jpg every time manually)?
Yeah, I see the problem here. Unfortunately, replacing * with nothing, rather than a preset (and %name% seemed the most logical) will spoil the local files source searching. I'll have a think and see if I can come up with something more elegant, but it's going to be hard to determine in any automatic way whether a wildcard should be replaced with %name% or nothing, on a case-by-case basis.

I can offer you a work-around, though. The path to save as is taken from the first of the alternates provided, so if you set the path to find images in the file browser to:

front.jpg|*front*.jpg|*cover*.jpg

then it will use the first alternate as the default path to save art to, namely, front.jpg.

Alex
Title: Album Art Downloader XUI
Post by: Squeller on 10 October, 2008, 05:22:13 AM
If it is happening every time you run it, then it is just this app that is too slow! I can take a look at the start-up procedure and see if there is anything I can tweak, but I can't guarantee anything.

The start of your application is generally the first start of a .net framework based application on my system, because usually I avoid using them. Because they are "as fast as shifting sand dunes"  I think you do not need to tweak anything, I will live with that.
Title: Album Art Downloader XUI
Post by: Light on 10 October, 2008, 07:01:15 AM
Quote
front.jpg|*front*.jpg|*cover*.jpg


ah, tnx that will do. You needn't 'fix' this 'problem' since this will solve it all, thank you!
And thnx for the fast reply
Title: Album Art Downloader XUI
Post by: francesco on 10 October, 2008, 07:29:52 AM
this is the best program to download covers

shame that requires Framework
will be a future version without Framework ?


because there are not alternative Album Art Downloader XUI that works


ps is there command line to auto download the covers , i mean to download the covers without to click save....
the command line page do not work to me, i can't open the page
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 October, 2008, 07:54:27 AM
No, there will never be a version which does not require the .net framework. That would be a completely different application, written from scratch. Even the boo scripts require the .net framework, so any application compatible with them would also require it.

To download covers using the command line, use the aad.exe command line tool. I'm sorry the wiki pages aren't working at the moment, but the command line reference can be obtained locally by using the parameter /?.

At its most basic, aad.exe "artist" "album" Folder.jpg will search all available sources for the specified artist and album, and save the result as Folder.jpg in the current folder.

For convenience, here is the full aad.exe command line reference:

Code: [Select]
Usage: aad.exe [options]

Option names may be preceded by a / or a -
Options:

 /artist      Artist to search for            (/artist "Artist Name")
             May be abbreviated to /ar      (/ar "Artist Name")
             Parameter name may be omitted
             if this is the first parameter  ("Artist Name")

 /album      Album to search for            (/album "Album Name")
             May be abbreviated to /al      (/al "Album Name")
             Parameter name may be omitted
             if this is the second parameter ("Artist Name" "Album Name")

 /path        Default path to save art as    (/path "\Art\Folder.jpg")
             May be abbreviated to /p        (/p "\Art\Folder.jpg")
             Parameter name may be omitted
             if this is the third parameter

             The following variables can be used in paths:
               %artist%    Artist searched for
               %album%      Album searched for
               %name%      Name of the image found
               %extension%  Default file extension for the image
               %source%    Name of the source where image was found
               %size%      Dimensions of the image
               %sequence%  A sequence number for the image, corresponding to
                             the number passed to /sequence, or "1" by default

 /sources    Specifies the sources to search,    (/sources "Amazon,Coveralia")
             in the order to search them.
             Separate sources with commas.
             If omitted, all available sources
             except those excluded by the /exclude
             option are searched.
             May be abbreviated to /s            (/s "Amazon,Coveralia")

 /exclude    Does not search the specified    (/exclude "Local Files,Google")
             sources. Separate sources with
             commas.
             May be abbreviated to /es        (/es "Local Files,Google")

 /minSize    Specifies the minimum size of  (/minSize 300)
             image, in pixels, to use.
             Both horizontal and vertical
             dimensions must conform.
             May be abbreviated to /mn      (/mn 300)
            
 /maxSize    Specifies the maximum size of  (/maxSize 1000)
             image, in pixels, to use.
             The smallest dimension of the
             image must conform.
             May be abbreviated to /mx      (/mx 1000)

 /minAspect  Specifies the minimum aspect ratio  (/minAspect 0.9)
             of the image to use. This is how
             square the image must be, where a
             value of 1 represents perfectly
             square (600 x 600, for example). An
             image of size 600 x 300 would only
             be allowed if /minAspect were 0.5
             or lower.
             May be abbreviated to /ma          (/ma 0.9)
            
 /sequence    Specifies which result to use, if  (/sequence 2)
             more than one are found. For
             example, passing 2 as the value
             here would ignore the first result
             found, and use the second.
             May be abbreviated to /seq          (/seq 2)
 
 /listSources Produces a list of all available    (/listSources)
             sources to search.
             May be abbreviated to /l            (/l)

Exit errorlevel codes:

 0            Success
 1            No image found
 -1          Error occured
Title: Album Art Downloader XUI
Post by: francesco on 10 October, 2008, 08:00:01 AM
No, there will never be a version which does not require the .net framework. That would be a completely different application, written from scratch. Even the boo scripts require the .net framework, so any application compatible with them would also require it.

To download covers using the command line, use the aad.exe command line tool. I'm sorry the wiki pages aren't working at the moment, but the command line reference can be obtained locally by using the parameter /?.

At its most basic, aad.exe "artist" "album" Folder.jpg will search all available sources for the specified artist and album, and save the result as Folder.jpg in the current folder.

For convenience, here is the full aad.exe command line reference:

Code: [Select]
Usage: aad.exe [options]

Option names may be preceded by a / or a -
Options:

 /artist      Artist to search for            (/artist "Artist Name")
             May be abbreviated to /ar      (/ar "Artist Name")
             Parameter name may be omitted
             if this is the first parameter  ("Artist Name")

 /album      Album to search for            (/album "Album Name")
             May be abbreviated to /al      (/al "Album Name")
             Parameter name may be omitted
             if this is the second parameter ("Artist Name" "Album Name")

 /path        Default path to save art as    (/path "\Art\Folder.jpg")
             May be abbreviated to /p        (/p "\Art\Folder.jpg")
             Parameter name may be omitted
             if this is the third parameter

             The following variables can be used in paths:
               %artist%    Artist searched for
               %album%      Album searched for
               %name%      Name of the image found
               %extension%  Default file extension for the image
               %source%    Name of the source where image was found
               %size%      Dimensions of the image
               %sequence%  A sequence number for the image, corresponding to
                             the number passed to /sequence, or "1" by default

 /sources    Specifies the sources to search,    (/sources "Amazon,Coveralia")
             in the order to search them.
             Separate sources with commas.
             If omitted, all available sources
             except those excluded by the /exclude
             option are searched.
             May be abbreviated to /s            (/s "Amazon,Coveralia")

 /exclude    Does not search the specified    (/exclude "Local Files,Google")
             sources. Separate sources with
             commas.
             May be abbreviated to /es        (/es "Local Files,Google")

 /minSize    Specifies the minimum size of  (/minSize 300)
             image, in pixels, to use.
             Both horizontal and vertical
             dimensions must conform.
             May be abbreviated to /mn      (/mn 300)
            
 /maxSize    Specifies the maximum size of  (/maxSize 1000)
             image, in pixels, to use.
             The smallest dimension of the
             image must conform.
             May be abbreviated to /mx      (/mx 1000)

 /minAspect  Specifies the minimum aspect ratio  (/minAspect 0.9)
             of the image to use. This is how
             square the image must be, where a
             value of 1 represents perfectly
             square (600 x 600, for example). An
             image of size 600 x 300 would only
             be allowed if /minAspect were 0.5
             or lower.
             May be abbreviated to /ma          (/ma 0.9)
            
 /sequence    Specifies which result to use, if  (/sequence 2)
             more than one are found. For
             example, passing 2 as the value
             here would ignore the first result
             found, and use the second.
             May be abbreviated to /seq          (/seq 2)
 
 /listSources Produces a list of all available    (/listSources)
             sources to search.
             May be abbreviated to /l            (/l)

Exit errorlevel codes:

 0            Success
 1            No image found
 -1          Error occured
thanks you so much
i have the old version which work without 3.5
does add.exe means for AlbumArt.exe ? i haven't the add.exe

and does it save the cover in the folder of the music?
Title: Album Art Downloader XUI
Post by: francesco on 10 October, 2008, 08:12:12 AM
No, there will never be a version which does not require the .net framework. That would be a completely different application, written from scratch. Even the boo scripts require the .net framework, so any application compatible with them would also require it.

To download covers using the command line, use the aad.exe command line tool. I'm sorry the wiki pages aren't working at the moment, but the command line reference can be obtained locally by using the parameter /?.

At its most basic, aad.exe "artist" "album" Folder.jpg will search all available sources for the specified artist and album, and save the result as Folder.jpg in the current folder.

For convenience, here is the full aad.exe command line reference:

Code: [Select]
Usage: aad.exe [options]

Option names may be preceded by a / or a -
Options:

 /artist      Artist to search for            (/artist "Artist Name")
             May be abbreviated to /ar      (/ar "Artist Name")
             Parameter name may be omitted
             if this is the first parameter  ("Artist Name")

 /album      Album to search for            (/album "Album Name")
             May be abbreviated to /al      (/al "Album Name")
             Parameter name may be omitted
             if this is the second parameter ("Artist Name" "Album Name")

 /path        Default path to save art as    (/path "\Art\Folder.jpg")
             May be abbreviated to /p        (/p "\Art\Folder.jpg")
             Parameter name may be omitted
             if this is the third parameter

             The following variables can be used in paths:
               %artist%    Artist searched for
               %album%      Album searched for
               %name%      Name of the image found
               %extension%  Default file extension for the image
               %source%    Name of the source where image was found
               %size%      Dimensions of the image
               %sequence%  A sequence number for the image, corresponding to
                             the number passed to /sequence, or "1" by default

 /sources    Specifies the sources to search,    (/sources "Amazon,Coveralia")
             in the order to search them.
             Separate sources with commas.
             If omitted, all available sources
             except those excluded by the /exclude
             option are searched.
             May be abbreviated to /s            (/s "Amazon,Coveralia")

 /exclude    Does not search the specified    (/exclude "Local Files,Google")
             sources. Separate sources with
             commas.
             May be abbreviated to /es        (/es "Local Files,Google")

 /minSize    Specifies the minimum size of  (/minSize 300)
             image, in pixels, to use.
             Both horizontal and vertical
             dimensions must conform.
             May be abbreviated to /mn      (/mn 300)
            
 /maxSize    Specifies the maximum size of  (/maxSize 1000)
             image, in pixels, to use.
             The smallest dimension of the
             image must conform.
             May be abbreviated to /mx      (/mx 1000)

 /minAspect  Specifies the minimum aspect ratio  (/minAspect 0.9)
             of the image to use. This is how
             square the image must be, where a
             value of 1 represents perfectly
             square (600 x 600, for example). An
             image of size 600 x 300 would only
             be allowed if /minAspect were 0.5
             or lower.
             May be abbreviated to /ma          (/ma 0.9)
            
 /sequence    Specifies which result to use, if  (/sequence 2)
             more than one are found. For
             example, passing 2 as the value
             here would ignore the first result
             found, and use the second.
             May be abbreviated to /seq          (/seq 2)
 
 /listSources Produces a list of all available    (/listSources)
             sources to search.
             May be abbreviated to /l            (/l)

Exit errorlevel codes:

 0            Success
 1            No image found
 -1          Error occured
thanks
i mean scan for a folder full of albums and download all the covers automatically
Title: Album Art Downloader XUI
Post by: AlexVallat on 10 October, 2008, 08:24:04 AM
i mean scan for a folder full of album and download all the cover automatically
No, that functionality is not currently available, sorry.
Title: Album Art Downloader XUI
Post by: Akkurat on 10 October, 2008, 10:21:38 PM
I've a little problem with AAD XUI (0.22 +latest sources).

Search: metallica / metallica (example.. happens with other searches too)
options: open searches in new window = off ... automatically download = only when unknown ... filter size = minimum 499 (results sorted by sources & size desc.)

After 1st search is stopped, click search again (not actually searching again because nothing has been changed).

= suddenly covers (bigger than the "filter size" minimum) for the following sources appear on the list (did not exist after 1st search):

- Coveralia
- Darktown
- Rate Your Music

Tried the same without "filter size" and all sources showed covers after 1st search. Also tried with minimum 10px setting but couldn't reproduce the issue like with 499 as the minimum setting. AAD restarted between these tests.

These sources don't have thumbnails (?) and this is the reason for this behavior..? Though I don't understand why the 10px minimum setting doesn't affect like the 499px setting.. AND discogs don't have thumbnails either but it works.
Title: Album Art Downloader XUI
Post by: ameliajune on 11 October, 2008, 04:03:44 AM
Quote
I'm afraid I'll need a little more detail - can you let me know the artist and album you were searching for, the path of the folder.jpg you were expecting to be discovered, and the path pattern it was using to search for it (click the ... in the bottom right of the Local Files source in the sources list, then copy the contents of the "Path to find images" box). I'll then try and figure out why it wasn't picked up.


Ok, will do. I'm in the middle of another project, so give me a bit.
Title: Album Art Downloader XUI
Post by: AlexVallat on 11 October, 2008, 07:52:29 AM
Thanks for reporting this bug. I can confirm it does happen as described, and will try to figure out why and have a fix for the next version.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 12 October, 2008, 11:41:48 AM
Can anyone write a script for buy.com?  They have a lot of 500x500 images that are often better quality than amazon's.
I'd like to second this request: not only good quality, but sometimes it's the only source where I can find covers of an acceptable size.

Here's an example (http://www.buy.com/prod/velvet/q/loc/109/60056306.html) (click on enlarge image).

Alessandro
Title: Album Art Downloader XUI
Post by: alsaan on 12 October, 2008, 02:32:41 PM
This application is ridiculously useful; thanks for taking the time to code it.

That said, there is a feature I'd love to see included: the ability to save an image by dragging and dropping it to an explorer window. Would be a great time saver for me and potentially for other people.
Title: Album Art Downloader XUI
Post by: AlexVallat on 12 October, 2008, 02:49:19 PM
the ability to save an image by dragging and dropping it to an explorer window.
I like the idea - I've added it to the Feature Requests (http://sourceforge.net/tracker2/?group_id=187008&atid=919578) page. Depending on schedule, it may not make it into the upcoming release, but if not, it will be in the one after.

Alex
Title: Album Art Downloader XUI
Post by: alsaan on 13 October, 2008, 04:39:39 PM
^ Thanks a lot

On an unrelated note, after a few hours wrestling with Boo I managed to write a script for buy.com. It's not tested extensively but it seems to work...
If anyone is interested and wants to help with testing: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
Title: Album Art Downloader XUI
Post by: Cerebus on 15 October, 2008, 05:40:35 PM
Would it be possible to create a .boo script for the amazon mp3 store? They consistently have 500x500 artwork, and it's one of the best resources I know of.

http://www.amazon.com/s/ref=nb_ss_dmusic?u...amp;x=0&y=0 (http://www.amazon.com/s/ref=nb_ss_dmusic?url=search-alias%3Ddigital-music&field-keywords=&x=0&y=0)


I've just started using AAD, and while I haven't made it through the 22 pages of the topic, I was curious if this had been discussed any further...I've also found that the mp3 covers are significantly better quality than the existing CD covers on Amazon, and the ability to snag those would be tremendous.
Title: Album Art Downloader XUI
Post by: francesco on 16 October, 2008, 02:17:32 AM
Thanks for reporting this bug. I can confirm it does happen as described, and will try to figure out why and have a fix for the next version.

Alex

is there a way to invoke/run & download cover from foobar?

i download the run compontents but i was not able to run album art downloader
Title: Album Art Downloader XUI
Post by: AlexVallat on 16 October, 2008, 04:12:41 AM
On an unrelated note, after a few hours wrestling with Boo I managed to write a script for buy.com.
Excellent, thanks! Would you like me to include this in the next release?


Would it be possible to create a .boo script for the amazon mp3 store? They consistently have 500x500 artwork, and it's one of the best resources I know of.
I was curious if this had been discussed any further...
No, I don't think it has. I've just had a look into it myself, and it seems easy enough. I'll include one in the next release (can't post it separately as it depends on some changes to other support scripts that have already been made).

is there a way to invoke/run & download cover from foobar?
People use foo_run (http://www.hydrogenaudio.org/forums/index.php?showtopic=45223) for this. The usual command line would be something like:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /artist "%album artist%" /album "%album%" /path "$replace(%_path%,%_filename_ext%,)Folder.%%extension%%"
Title: Album Art Downloader XUI
Post by: Cerebus on 17 October, 2008, 05:23:05 PM
Some bugs I've run into:

1 - It seems like the 'queue' count is always one more than the number of windows used - so if I wanted 2 queue windows, I would put '3' in the box.

2 - When art is selected from the active AAD window, the new window opened for the next album takes focus in front of the rest, so the queued windows aren't really used unless you switch windows manually.

3 - When a range of albums are selected and artwork is added for all of them, only the last album's entry on the file brower is updated to show that there is art now, and what the size is.

A cool feature:

On the file browser window, it would be great to have the folder.jpg DIMENSIONS in that list, rather than the size in kb of the jpeg file - I could then use the tool to look for artwork at a higher resolution than I already have.

Great program.  I'm currently using it on a samba share to populate the art on my linux box, and it's exactly what I've been looking for.
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 October, 2008, 03:48:08 AM
1 - It seems like the 'queue' count is always one more than the number of windows used - so if I wanted 2 queue windows, I would put '3' in the box.
Are you sure? I couldn't reproduce this. Remember it counts all open search windows, not just the ones launched from the file browser - if you started off with one search window open and didn't close it, there would only be 2 slots left. If in doubt, click the Window menu, and count the number of windows starting "Search".

2 - When art is selected from the active AAD window, the new window opened for the next album takes focus in front of the rest, so the queued windows aren't really used unless you switch windows manually.
Yeah, I see what you mean. Unfortunately I can't see any good way around this at the moment, but I'll keep it in mind.

3 - When a range of albums are selected and artwork is added for all of them, only the last album's entry on the file brower is updated to show that there is art now, and what the size is.
Already fixed, it will be in the new release (coming very soon now).

On the file browser window, it would be great to have the folder.jpg DIMENSIONS in that list, rather than the size in kb of the jpeg file - I could then use the tool to look for artwork at a higher resolution than I already have.
The problem with this is that it would require actually loading each image to determine its dimensions. This would slow things down quite a lot, particularly if the images were on a samba share! I might, in a future version, add another thread that goes over all the images opening them and determining their dimensions, then if you don't want to wait for it, it isn't a problem. That won't be in the next release, though.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 October, 2008, 05:13:19 AM
AlbumArt Downloader XUI v0.23 Released

For this release, I'd like to welcome daju (http://sourceforge.net/users/daju/) to the development team. He is responsible for the addition of the Cover Types functionality added in this release, and the new DarkTown, LastFM (cover) and AllCdCover scripts that have been added, as well as rewriting the Freecovers script to use the API.

Results now show an additional line of information, their Cover Type. This may be Front, Back, Inlay or CD. You can sort or group by this field using the standard sorting and grouping controls. Not all sources support this information; where it isn't available the cover type will be "Unknown".

Other changes in this version:
Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 18 October, 2008, 06:01:47 AM
AlbumArt Downloader XUI v0.23 Released

I love you, man. 
Title: Album Art Downloader XUI
Post by: foo_peter on 18 October, 2008, 06:31:19 AM
Hi Alex

Unfortunately I do not get to run the prog breaks immediately with the following error message.

pardon my bad English


Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\foobar2000\AlbumArtDownloader\errorlog.txt

App version: 0.23.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3

System.IO.DirectoryNotFoundException: Ein Teil des Pfades C:\Dokumente und Einstellungen\Foobar\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_rkg2w2bclauvqwx5a0ud5gtpisbyhy1g\0.23.0.0\scripts konnte nicht gefunden werden.
   bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   bei System.IO.Directory.InternalGetFileDirectoryNames(String path, String userPathOriginal, String searchPattern, Boolean includeFiles, Boolean includeDirs, SearchOption searchOption)
   bei System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)
   bei AlbumArtDownloader.App.LoadScripts()
   bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   bei System.Windows.Application.<.ctor>b__0(Object unused)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: Cerebus on 18 October, 2008, 06:32:27 AM
I got the same thing...I'm going to try the zip.

Edit: the zip works, so something went haywire with the installer.
Title: Album Art Downloader XUI
Post by: foo_peter on 18 October, 2008, 06:41:29 AM
Edit: the zip works, so something went haywire with the installer.
[/quote]



agrees with the zip Works Perfectly
Title: Album Art Downloader XUI
Post by: tuxman on 18 October, 2008, 07:09:57 AM
Could you maybe make the startup a bit .. faster? 
Or is it C#?

Title: Album Art Downloader XUI
Post by: AlexVallat on 18 October, 2008, 07:51:03 AM
I'm looking into the installer issue now, thanks for reporting it.

Tuxman, if you delete scripts that you don't use, it will start considerably faster. Other than that, there's not much I can do about it. The first start of any .net app after a reboot will be quite slow, but subsequent starts should be quicker.

Alex
Title: Album Art Downloader XUI
Post by: Cerebus on 18 October, 2008, 07:53:16 AM
Alex -

Another thing I noticed - paths with commas in them aren't handled correctly when clicking 'folder.jpg' in the file directory list.
Title: Album Art Downloader XUI
Post by: tuxman on 18 October, 2008, 08:01:42 AM
Tuxman, if you delete scripts that you don't use, it will start considerably faster.

Well, they have to be "recompiled" every time, I noticed that; but maybe it's enough to compile them only on changes?
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 October, 2008, 08:30:23 AM
Well, they have to be "recompiled" every time, I noticed that; but maybe it's enough to compile them only on changes?
That's what it's supposed to do! This may be related to the error message foo_peter reported (which was in the area of script compilation). I'm still looking into that.

Cerebus, thanks for the bug report - wish I'd seen that before this release! If I have to get another one out to fix the installer bug, I'll include a fix for this too.

Alex
Title: Album Art Downloader XUI
Post by: Cerebus on 18 October, 2008, 09:12:00 AM
Cerebus, thanks for the bug report - wish I'd seen that before this release! If I have to get another one out to fix the installer bug, I'll include a fix for this too.

Alex


Here's something minor...when sorting by size, the triangle pointing up should sort smallest to largest, but instead it sorts largest to smallest. (small at the top vs. small at the bottom)
Title: Album Art Downloader XUI
Post by: AlexVallat on 18 October, 2008, 09:13:20 AM
AlbumArt Downloader XUI v0.23.1 Released

Apologies for the shoddy quality of the previous 0.23 release - I guess that's what you get when you don't have a QA department!

Here is 0.23.1, which should have fixed up the installer problem, the command line version problem, and the problem with launching explorer windows with commas in the path.

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.1.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: foo_peter on 18 October, 2008, 11:44:44 AM
Hello Alex,

very fast and big thanks for update
It is and remains the best thing I ever seen.

"Gigantic!"

foo_peter
Title: Album Art Downloader XUI
Post by: alsaan on 18 October, 2008, 03:37:01 PM
Thanks for the new release, it's working great.

As for the buy.com script: sure, you can include it in the next release.
I've made a few changes to it and added cover type support (which wasn't very hard to do)
Here is the latest version: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
Title: Album Art Downloader XUI
Post by: phunkydizco on 19 October, 2008, 02:28:29 PM
How can I start file browser directly?
Title: Album Art Downloader XUI
Post by: AlexVallat on 19 October, 2008, 03:18:47 PM
How can I start file browser directly?
Add /fileBrowser to the command line.
Title: Album Art Downloader XUI
Post by: tuxman on 19 October, 2008, 05:45:10 PM
The new version crashed on the first use...

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\AlbumArtDownloader\errorlog.txt

App version: 0.23.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3

System.Reflection.TargetInvocationException: Ein Aufrufziel hat einen Ausnahmefehler verursacht. ---> System.ArgumentOutOfRangeException: Der Index lag außerhalb des Bereichs. Er muss nicht negativ und kleiner als die Auflistung sein.
Parametername: index
   bei System.Collections.ArrayList.RemoveAt(Int32 index)
   bei System.Windows.Data.ListCollectionView.ProcessCollectionChanged(NotifyCollectionChangedEventArgs args)
   bei System.Windows.Data.CollectionView.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
   bei System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   bei System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   bei System.Collections.ObjectModel.ObservableCollection`1.RemoveItem(Int32 index)
   bei System.Collections.ObjectModel.Collection`1.Remove(T item)
   bei System.Collections.ObjectModel.Collection`1.System.Collections.IList.Remove(Object value)
   bei AlbumArtDownloader.Controls.ArtPanelList.OnImageSizeChanged(Object sender, EventArgs e)
   bei AlbumArtDownloader.AlbumArt.SetImageDimensions(Double width, Double height)
   bei AlbumArtDownloader.AlbumArt.<>c__DisplayClass7.<RetrieveFullSizeImageWorker>b__6()
   --- Ende der internen Ausnahmestapelüberwachung ---
   bei System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   bei System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   bei System.Delegate.DynamicInvokeImpl(Object[] args)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)


(Appeared after performing a search.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 October, 2008, 12:07:36 PM
The new version crashed on the first use...
Thanks for reporting it. I'm afraid I can't reproduce the problem, though - does it happen every time for you, or was it just once? If it is every time, could you tell me which sources you use, and what you search for?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 20 October, 2008, 12:14:02 PM
Alex, I'm just writing a big post here.. wait a bit, I have the same crash and I've lots of information...
Title: Album Art Downloader XUI
Post by: macman4hire on 20 October, 2008, 12:16:52 PM
A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).  This site has some of the best quality album covers on the web.  You may want to consider offering it as a selection choice in your application.  Why not give your users the best quality that is out there.
Title: Album Art Downloader XUI
Post by: tuxman on 20 October, 2008, 12:19:15 PM
I used all available sources, including the new .boo file above, and searched for the album "Sex/ The End Of My Life" (with the /) by Sex (a nice progrock group btw); reproducable here.

(Ah; a search history would be appreciated.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 October, 2008, 12:47:28 PM
A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).
Thanks for the link. A script for Album Art Exchange was added back in version 0.16, and was updated in version 0.20 when they started providing an API. Please update to the latest version, and you should find it available there.

I used all available sources, including the new .boo file above, and searched for the album "Sex/ The End Of My Life" (with the /) by Sex (a nice progrock group btw); reproducable here.
Hmm... still no luck with this. What grouping/sorting settings are you using? Any filtering? Do you have Automatically Download Full Size Images enabled?
Title: Album Art Downloader XUI
Post by: tuxman on 20 October, 2008, 12:53:25 PM
(https://hydrogenaud.io/imgcache.php?id=d104664a496b86c029a121ced62245da" rel="cached" data-warn="External image, click to view at original size" data-url="http://img3.imagebanana.com/img/fx4j0ox/options.png)
Title: Album Art Downloader XUI
Post by: Akkurat on 20 October, 2008, 12:53:31 PM
Same crash bug here as well. Only difference to tuxman error log is that I've WINXP SP2 and in English language.

The reason for crash?: your Filtered out items aren't shown when size becomes known (http://sourceforge.net/tracker2/?func=detail&aid=2159259&group_id=187008&atid=919575) bug fix (which you didn't list in any changelog by the way). "Coveralia", "Darktown", "Juno Records", "LastFM Artist", "Rate Your Music" & "Yes24" sources are the culprits, but only when the "filter by image size" option is checked (I used only minimum setting).

Please show the progress bar for these sources when doing the size detecting/sort for "unknown" size images. I'd hate to start navigating the result list when suddenly the list would be re-sorted and I would lose the place I was in the list (and what covers I already looked thru). Thanks.

After testing a bit more I found a very strange behavior which may lead you to the culprit of this problem; steps to reproduce:

1) set "automatically download" to never
2) set on "filter by image size" to minimum 50px
3) select ONLY coveralia source
4) search metallica / metallica (= 2 covers, sizes unknown)
5) change "filter by image size" to minimum 51px

= BUG: the 2 covers disappear from the list.

6) change "automatically download" to "when unknown"

= BUG: crash

-> if you set the "automatically download" to "when unknown" in step 1 AND the minimum size to 51px (or bigger) in step 2, AAD crashes when searching in step 4.

I also tested with "Yes24" source:

1) set "automatically download" to never
2) set on "filter by image size" to minimum 106px
3) select ONLY Yes24 source (limit to 10 results)
4) search metallica / metallica (= 10 covers, sizes unknown)
5) change "filter by image size" to minimum 107px

= BUG: 1 cover disappears from the list.

6) change "filter by image size" to minimum 155px

= BUG: again 1 cover disappears from the list.

7) change "filter by image size" to minimum 221px

= BUG: the rest 8 covers disappear from the list.

8) change "automatically download" to "when unknown"

= BUG: crash

So it seems that these vary between sources/results. Why? I don't know.. maybe the search yields some size data although AAD says that it's unknown.. how else do you explain this behavior, especially with "Yes24" results (1 cover with 106px, 1 with 154px and 8 with 220px (width?) sizes even if they're unknown).

Here's some additional questions/notes:
[/end bitchin.., I mean debugging]  Maybe I should de-bug-off myself.
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 October, 2008, 01:45:21 PM
Wow, thanks for your detailed analysis and post! I will look into this crash in detail with the information you've provided, but here are some answers for you now:

[quote name='Akkurat' post='594539']Please show the progress bar for these sources when doing the size detecting/sort for "unknown" size images.[/quote]The progress bar is for the source finding the results. The automatic download of full size images runs separately, and simultaneously, so making it affect the same progress bar will be tricky. You can even turn on automatic download after all sources have already completed searching, so the progress bars will already have been removed.

Would a separate progress bar showing the automatic full size image downloading progress be helpful? That could be accurately calculated and displayed, then you would know when the list won't be re-sorting any more.

It might be helpful to know that while the mouse is down on the scrollbar, the list will not update (resort or have new items added), so if you want to look through what you've got right now without it changing under you, you can drag the scrollbar up and down without releasing the mouse to do so.

[quote name='Akkurat' post='594539']I downloaded v0.23.1, the program shows 0.23 everywhere (script compile window, about window, file version)?[/quote]0.23.1 was primarily a fix to the installer, and I did not update the version number in the app. Probably should have done, but I was in a big hurry to get something up there that wouldn't crash out on first install. It will automatically be resolved for the next version, of course!

[quote name='Akkurat' post='594539']IMHO it would be nicer to NOT active the drag&drop when holding down mouse button and previewing the big image. It seems that there's about 5px range for the d&d action to become active.. maybe increasing the range would suffice? (if that's possible)[/quote]Possible, sure, but I'm not sure what sort of range to make it. Is it just to eliminate wobbly-mouse problems, or is there some reason to be moving the mouse around while previewing? It's going to be tough to know when to initiate a drag.

[quote name='Akkurat' post='594539']I like the previous behavior more; the big image preview is showed and no re-sort to the list.[/quote]That wasn't intentional, thanks for bringing it to my attention - I'll fix that.

[quote name='Akkurat' post='594539']Have you looked into the "window size not retained after updating" issue? I didn't see this in the SF tracker.[/quote]I don't remember fixing it, so I'll assume it isn't fixed, and add it to the tracker.

[quote name='Akkurat' post='594539']Can you please use the same update list both in this thread and in the "File Release Notes and Changelog" in sourceforge (+wiki)?[/quote]Different format, so can't use the actual same list. Apologies for not keeping them in better synch though. You may have noticed that documentation isn't my strongest area.

[quote name='Akkurat' post='594539']Why is the SF download page (http://sourceforge.net/project/platformdownload.php?group_id=187008) showing "Download Album Art Downloader XUI v0.23 installer" text/link even if that link downloads the 0.23.1?[/quote]Same reason as the app version showing 0.23. The .1 is just a nasty little footnote in history that shouldn't have happened, and the sooner we can forget about anything below 0.minor, the better :-)

...continued

...continued

[quote name='Akkurat' post='594539']Does the filebrowser scan FLAC (or any other) tags for covers?[/quote]For embedded covers? No. This app doesn't read or write embedded covers. It will read FLAC tags for the album and artist name, if that's what you mean. It will only do one of tags or filenames at a time, though, you can't search for both simultaneously.

[quote name='Akkurat' post='594539']I also noticed that it doesn't detect my "_folder.jpg" cover files[/quote]Add "|_folder.%extension%" to the end of the Specify Path to Find Images box in the file browser.

[quote name='Akkurat' post='594539']Filebrowser: wouldn't it be better to detect VA albums as just one album and not list all of the artists from it?[/quote]This has been covered in detail in previous posts. Basically, Various Artists can't be reliably detected in a standard way, so unless you are using File Path Pattern matching, and they're all in the same folder, AAD doesn't know they are all part of the same album.

[quote name='Akkurat' post='594539']Sometimes the "name:, size:, type:, etc." field "labels" are not visible for some of the search result items until I press the search again.[/quote]I haven't been able to reproduce this, but I'll try again after fixing the other bugs mentioned.

[quote name='Akkurat' post='594539']It seems that the sort is made only to the first dimension of the cover image, e.g. all images with 500px width are not additionally sorted by height.[/quote]Yes, that's true. I'll put that one down as a feature request, I think.

[quote name='Akkurat' post='594539'][/end bitchin.., I mean debugging]  Maybe I should de-bug-off myself. [/quote]Your efforts with putting together this information are appreciated!

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 October, 2008, 02:46:09 PM
OK, thanks to some great detective work by Akkurat, I think I've fixed the crashes reported. If you'd like to help me test this out, I've put up a debug build here: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe) (just drop it over the existing one in your program folder). I'd appreciate it if those of you experiencing the crash could let me know if this fixes it.

Oh, and Akkurat, in all those replies I made, I think I missed one:

The reason the filtering behaves the way it does (apart from the crashing, which should be fixed), is that if the full size image size is not known, then it filters on the size of the thumbnail, the theory being that if the thumbnail is over 50px big, then the full size image is going to be too. I appreciate that this might be confusing, though - it might be more clear to exclude unknown sized results from any filtered result set regardless of thumbnail size.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 20 October, 2008, 02:57:16 PM
OK, it works fine now; getting an assertion error with "Rate Your Music", though:

Quote
Script Rate Your Music threw an exception while searching: Der Remoteserver hat einen Fehler zurückgegeben: (500) Interner Serverfehler.





    at ScriptSource.SearchInternal(String artist, String album, IScriptResults results) 

    at Source.SearchWorker(Object state) 

    at ThreadHelper.ThreadStart_Context(Object state) 

    at ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) 

    at ThreadHelper.ThreadStart(Object obj)


Seems to be on their server.
Title: Album Art Downloader XUI
Post by: AlexVallat on 20 October, 2008, 03:00:46 PM
OK, it works fine now; getting an assertion error with "Rate Your Music", though:
Yeah, you can safely ignore assertion errors - they are silently dropped in release builds, but are shown in debug builds. Scripts, and the sites they depend on, can be fairly sketchy, so these things do pop up.

Thanks for letting me know the crash seems to be gone, though!
Title: Album Art Downloader XUI
Post by: Akkurat on 20 October, 2008, 07:28:50 PM
I'll answer this quickly, I'll get back to those other topics tomorrow.

I'd appreciate it if those of you experiencing the crash could let me know if this fixes it.

Still crashes.  Both test cases I wrote. Thou differently this time; no error log and with an error message window with text:
"Album Art Downloader has encountered a problem and needs to close.  We are sorry for the inconvenience.
If you were in the middle of something, the information you were working on might be lost."


The reason the filtering behaves the way it does (apart from the crashing, which should be fixed), is that if the full size image size is not known, then it filters on the size of the thumbnail, the theory being that if the thumbnail is over 50px big, then the full size image is going to be too. I appreciate that this might be confusing, though - it might be more clear to exclude unknown sized results from any filtered result set regardless of thumbnail size.

Ok, I understand to some point what you're saying, it's a bit confusing as you said. Your suggested behavior makes more sense but there's a pitfall: if the "automatically download" is set to never, user might miss some covers because there's a possibility to get confused of the settings.. I don't know, maybe my brains are not working at the moment, the more I try to think about it, the more I get confused. There, you see? I got very Konfutsed.

Off the top suggestion: make the change as you suggested AND put a "show unknowns" checkbox into "filter size" "group" and disable (greyed out) it unless the "automatically download" setting is set to "never"...?
Title: Album Art Downloader XUI
Post by: odyssey on 21 October, 2008, 03:14:49 AM
A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).  This site has some of the best quality album covers on the web.  You may want to consider offering it as a selection choice in your application.  Why not give your users the best quality that is out there.

I'd also like this. Maybe someone has the ability to write a script for it?
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 October, 2008, 03:28:47 AM

A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).  This site has some of the best quality album covers on the web.  You may want to consider offering it as a selection choice in your application.  Why not give your users the best quality that is out there.

I'd also like this. Maybe someone has the ability to write a script for it?

Does no one actually read my replies here? A script for Album Art Exchange was added back in version 0.16, and was updated in version 0.20 when they started providing an API. Please update to the latest version, and you should find it available there.
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 October, 2008, 03:43:28 AM
Still crashes.  Both test cases I wrote. Thou differently this time; no error log and with an error message window
Huh. I wasn't expecting that. How about the problem where the list would update while the preview was being shown, does that still happen? The other crashes seemed to be caused by the fact that the code to suspend updates to the list was broken (which of course also stopped the list being suspended while the preview was shown). I've fixed that up, and the list updates should be being suspended properly now. If it's suspending, but still crashing, I've got to come up with another idea.

For the filtering, I think I'm going to have it so that  Unknowns are never filtered out. At least that way you know they are there, and can choose to ignore or download them as you please. If automatically downloading, as they are downloaded they might then become filtered out, if they don't meet the criteria.
Title: Album Art Downloader XUI
Post by: Akkurat on 21 October, 2008, 11:03:39 AM
Still crashes.  Both test cases I wrote. Thou differently this time; no error log and with an error message window
Huh. I wasn't expecting that.
Can't you reproduce the crash with the steps I gave? Strange.

In case you didn't understand the German version of the error log, here it's in English (note: this is from the 0.23.1 version, not from the debug version!):
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.23.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
   at System.Collections.ArrayList.RemoveAt(Int32 index)
   at System.Windows.Data.ListCollectionView.ProcessCollectionChanged(NotifyCollectionChangedEventArgs args)
   at System.Windows.Data.CollectionView.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
   at System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.RemoveItem(Int32 index)
   at System.Collections.ObjectModel.Collection`1.Remove(T item)
   at System.Collections.ObjectModel.Collection`1.System.Collections.IList.Remove(Object value)
   at AlbumArtDownloader.Controls.ArtPanelList.OnImageSizeChanged(Object sender, EventArgs e)
   at AlbumArtDownloader.AlbumArt.SetImageDimensions(Double width, Double height)
   at AlbumArtDownloader.AlbumArt.<>c__DisplayClass7.<RetrieveFullSizeImageWorker>b__6()
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   at System.Delegate.DynamicInvokeImpl(Object[] args)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
What I understand is that your code crashed because it tried to access an array index which was not there anymore. I'd guess that this is due to the fact that the filter removes covers from the result list and the process for getting the full size images ("RetrieveFullSizeImageWorker" perhaps?) tries to read an array index which was removed because of the filter. So, if you make the change to never filter out the "Unknowns" in the results list/window, I bet that the crash goes away.. or it might not.. or it could bring more problems (wrong index/image get).. it would be wise to check out that the "get full images" process always tries to access the correct index, which could have been moved or removed.. that is if the processes are run in parallel (the "update result list" & "get full"). Do I make sense at all or am I talking rubbish? I could be wrong.. considering that this "black box" testing I'm doing is pretty hard.

How about the problem where the list would update while the preview was being shown, does that still happen?
It's fixed. Thou honestly I still hate the fact that the cover is re-sorted (if it was different size) after I let the preview close. BUT, it's consistent now and no freezes so I guess I've to live with that. With big lists you could lose the position of the cover you were previewing. Although you could consider using, in example, a color indication (colored border on the image, put a transparent green "correct" image over the image (you could use a transparent disk image in same way for saved covers), etc.) whether the preview has been opened or not. This would make browsing much clearer, i.e. you instantly see which covers you've already checked.

In addition, it would be nice to have indicators for covers I've clicked to show the full size image in background (letting go of the preview window) when those are fully loaded. Now it only shows the "search" image in the left-top corner. A "search/download complete" image would be nice. This would also enhance the usability a lot. E.g. I always check many full size images and when they're big, the loading takes a while, and I like to open many "background full images", but it's hard to detect which images I chose when the full size image is ready.

For the filtering, I think I'm going to have it so that  Unknowns are never filtered out.
Good call. Maybe the best solution here.
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 October, 2008, 11:26:53 AM
No, I can't reproduce it using the steps you gave me, not in the fixed debug version I put up.

The crash report there (in English or in German) is the same one as tuxman had, that seem to be resolved now for him.

In case you're interested, the cause behind it was due to a failure of the system for suspending updates to the results list. When the list is suspended, it is supposed to batch up additions and removals, then when the list unsuspends, play them back so that the UI can update itself. Further, when an image size changes, that result is removed and re-added to the list so that it gets placed in the correct position. Unfortunately there is no nicer way to convince the WPF control to re-order its contents than removing and re-adding them.

So, you can probably see where this is going now; the full size image would download, triggering a size change, which would be badly batched up by the suspended change system, then replayed incorrectly, causing it to replay the removal (prior to the subsequent immediate re-addition) of the changed item incorrectly, confusing the WPF list control which was being told that a non-existent item had been removed.

Anyway, that's all just for curiosity's sake, that particular problem is definitely resolved now, so if there is something else causing a crash for you, I've got to look elsewhere. You say you are finding it tough doing black-box testing - if there's anything I can do to make things easier for you in this regard, please do let me know!

I take your point about the item moving once you finish previewing. I'm going to see whether it is possible to scroll the list so that after you release the mouse, and it updates, the list is scrolled so that the result you just previewed is still visible. It might not be in exactly the same spot, but you should at least be able to see it.

I like the suggestion for indicating which images are full sized and which are not. I tend to to this just by looking at them - the fuzzy ones aren't full sized! I'll see what I can think up, UI-wise, to indicate this in a non-obtrusive way. I don't think an overlay is the best way to go, though - I'd like to keep the actual image unchanged.

Some good news for you, I think I've got window size and position settings upgrading working for 0.24.
Title: Album Art Downloader XUI
Post by: Akkurat on 21 October, 2008, 11:56:38 AM
Wow, thanks for your detailed analysis and post!

Wow, you weren't disheartened by my massive post.  I've to confess that I've been couple of times in the REACT thread with big posts.. sometimes too much is just, well, too much.

The progress bar is for the source finding the results. The automatic download of full size images runs separately, and simultaneously, so making it affect the same progress bar will be tricky. You can even turn on automatic download after all sources have already completed searching, so the progress bars will already have been removed.

Would a separate progress bar showing the automatic full size image downloading progress be helpful? That could be accurately calculated and displayed, then you would know when the list won't be re-sorting any more.

Well, when you're right, you're right, the idea to use the source progress bar was not good. What you suggested sounds absolutely marvelous! Maybe a popup (since you don't have status bar) progress bar at the bottom of the results window?

IMHO it would be nicer to NOT active the drag&drop when holding down mouse button and previewing the big image. It seems that there's about 5px range for the d&d action to become active.. maybe increasing the range would suffice? (if that's possible)
Possible, sure, but I'm not sure what sort of range to make it. Is it just to eliminate wobbly-mouse problems, or is there some reason to be moving the mouse around while previewing? It's going to be tough to know when to initiate a drag.

Yes, it would be just for eliminating wobbly-caffeinedeprivation-mouse problems.  10-20px?

Can you please use the same update list both in this thread and in the "File Release Notes and Changelog" in sourceforge (+wiki)?
Different format, so can't use the actual same list. Apologies for not keeping them in better synch though. You may have noticed that documentation isn't my strongest area.

Yeah, I meant in sync, not the format. Show me a coder who IS good at documentation, I'm crap at it and I hate it soooo much.  Coding my REACT mod, I've learned always to write down a documentation/changelog (if needed) for a particular update/change/new feature I just have coded. This way the documentation process doesn't get too boring, baby steps, baby steps to open the changelog, etc.

Sometimes the "name:, size:, type:, etc." field "labels" are not visible for some of the search result items until I press the search again.
I haven't been able to reproduce this, but I'll try again after fixing the other bugs mentioned.

Ok, I hope I found the way to reproduce this; do a search (any search), then minimize the cover "area" until the labels drop off, then press search again = labels are back. It doesn't matter if you're showing the info below or on the side.

Remember that sometimes, for some of the result list covers, this happens after searching (no resizing of the result cover areas).

Actually now when I look at the "on the side view" without the labels, I kind of like it better. The info is pretty self-explanatory, so maybe the labels could be turned off from settings? Jésus, it seems that I'm full of ideas/suggestions at the moment, sorry. Pick out the best (if any) if you like.

Your efforts with putting together this information are appreciated!

Your lightning fast replys and fixes are very much appreciated!! Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 October, 2008, 12:22:43 PM
Well, when you're right, you're right, the idea to use the source progress bar was not good. What you suggested sounds absolutely marvelous! Maybe a popup (since you don't have status bar) progress bar at the bottom of the results window?
Hah, great minds... from the upcoming 0.24:

(https://hydrogenaud.io/imgcache.php?id=70eb050b64ca3e7ef09cabcc5bd972be" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/temp/AADprogressBar.png)

I've also increased the drag start size, and some informal playing about with it seems to show that 32px works well enough.

Ok, I hope I found the way to reproduce this; do a search (any search), then minimize the cover "area" until the labels drop off, then press search again = labels are back. It doesn't matter if you're showing the info below or on the side.
Got it, thanks. Issue added to the tracker for this.
Title: Album Art Downloader XUI
Post by: Zarggg on 21 October, 2008, 12:38:24 PM
Maybe I just didn't read the FAQ/manual/etc closely enough, but when "automatically download..." is enabled, does it actually save the files, or just store them in temp?
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 October, 2008, 12:42:24 PM
Maybe I just didn't read the FAQ/manual/etc closely enough, but when "automatically download..." is enabled, does it actually save the files, or just store them in temp?
They are just stored in memory until the window is closed. Nothing is automatically saved to file using this option.
Title: Album Art Downloader XUI
Post by: Zarggg on 21 October, 2008, 12:43:34 PM
Excellent!
Title: Album Art Downloader XUI
Post by: Akkurat on 21 October, 2008, 12:58:07 PM
No, I can't reproduce it using the steps you gave me, not in the fixed debug version I put up.

The crash report there (in English or in German) is the same one as tuxman had, that seem to be resolved now for him.

It would be interesting to see if tuxman passes the two cases I wrote down. EDIT: I just PM'd tuxman.

..so if there is something else causing a crash for you, I've got to look elsewhere.

Unfortunately. Tell me what to do. The crash happens exactly the same but instead of errorlog, I got error window. Put lot's of debug points and send me the exe.

You say you are finding it tough doing black-box testing - if there's anything I can do to make things easier for you in this regard, please do let me know!

No no, I've no interest to throw myself into learning your code, would take too much time to even understand a small bit of your codebase. I merely covered my ass if my guess for the problem would be wrong.

I take your point about the item moving once you finish previewing. I'm going to see whether it is possible to scroll the list so that after you release the mouse, and it updates, the list is scrolled so that the result you just previewed is still visible. It might not be in exactly the same spot, but you should at least be able to see it.

Hmm, couldn't you just ignore the change for those covers resort-wise? Didn't the previous versions work like this?

I like the suggestion for indicating which images are full sized and which are not. I tend to to this just by looking at them - the fuzzy ones aren't full sized! I'll see what I can think up, UI-wise, to indicate this in a non-obtrusive way. I don't think an overlay is the best way to go, though - I'd like to keep the actual image unchanged.

That's not actually what I meant, I meant that indicate which full size images have been loaded from net after clicking to show the preview and letting the preview close before the image has been loaded. The "search" icon overlay on top of the small image (not the preview image "window/dialog") shows nicely what images are being fetched, BUT, when they're fetched there's no indication of that.. and if you clicked many images to load the full sized images in the background, you have a very hard time knowing which ones you did click. Add the resort feature for changed sizes images, and you're totally lost which ones you put into "download mode". I hope you understand what I mean.

Fuzzy ones are impossible to detect in side view with small images. I guess you have bottom view and a big stretched cover area so that the images are huge.

Some good news for you, I think I've got window size and position settings upgrading working for 0.24.

It's unbelievable how fast you work, I just peeked in the SF tracker & SVN repo and started to worry about your Real Life™.  And mine too, this takes so much time.. but it's for good cause.. and I benefit from this also.

BTW. Is it possible to include AAD XUI in my REACT mod release in the future? I've some plans (actually my ToDo list is huge) to update the mod in near future. Though I've to fix many things in config files and in the REACT code before I could put XUI to the rel.. but nonetheless I thought to ask now since it popped into my mind.
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 October, 2008, 01:19:02 PM
I think I've come up with something reasonably nice for indicating which of the results have full sized images already downloaded. I'm now displaying the image dimensions greyed until a full sized image has been downloaded, which suggests that these dimensions aren't confirmed yet, and are only an estimate provided by the source. (In fact, for some of the scripts, they're even worse - just a usual size of image returned by that source!) Once the full size image is downloaded, the image size appears black like the other information.

That should make it quick to tell at a glance which ones have full size images downloaded already.

Here's a link to a compiled version of the current state of 0.24 (note to others - this does not represent the final 0.24 - you can download this if you like, but it is unsupported and unfinished). If that one crashes, it should at least provide an error log. AlbumArtDownloaderXUI-0.24.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.24.zip).

Yes, you are welcome to include AAD XUI in your REACT mod. Send me a link when you do, I'd be interested to see it in use!
Title: Album Art Downloader XUI
Post by: AlexVallat on 21 October, 2008, 02:25:23 PM
As for the buy.com script: sure, you can include it in the next release.
I've made a few changes to it and added cover type support (which wasn't very hard to do)
Here is the latest version: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
I'm about to include this in version 0.24, but before I do, is there any chance you could make it provide thumbnail images? It does help a lot with the search responsiveness. If it really can't be done, then just leave the full sized image parameter of the Add call as null, so it just uses the thumbnail as the full sized image rather than re-downloading it a second time.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 21 October, 2008, 03:31:52 PM
I think I've come up with something reasonably nice for indicating which of the results have full sized images already downloaded. I'm now displaying the image dimensions greyed until a full sized image has been downloaded, which suggests that these dimensions aren't confirmed yet, and are only an estimate provided by the source. (In fact, for some of the scripts, they're even worse - just a usual size of image returned by that source!) Once the full size image is downloaded, the image size appears black like the other information.

That should make it quick to tell at a glance which ones have full size images downloaded already.

The crashes went away, yea!

But, infamous but, now the unknown images which become "known" and are in example, below the minimum filter px, are NOT removed from the list.  After all searches and full-size image downloads are over, I've to re-apply the minimum filter setting for it to become effective. + sort also fails with these results. Crap. Actually I just noticed that it sorts some of the covers, not all.

Steps to reproduce both problems:
1) set download when unknown
2) set minimum filter 600px
3) set group by source (just in case this affects too)
4) set sort by size desc
5) select ONLY "LastFM Artist" source (limit to 40)
6) search metallica / metallica

= minimum filter has no effect
= notice that the first (at least in the beginning of the "download full sizes") 2 covers detected (in my search this happens this way) are 1000px wide and placed at the top. When the "download full" continues, smaller than 1000px wide images are NOT sorted.. then about in the middle there comes 2 covers with 1424 width and they ARE placed at the top before the 2 1000px wide covers. Strange. Maybe the first result is used as the "base" in all comparisons? It would explain the behavior I'm seeing.


Discogs source shows image sizes in grey even if they really are full sized straight from the get go. Not a big problem, I just thought to mention this. Were there other sources too with no thumbnails?

One new thing, sorry, when after the first search, you add more sources and click search again, the "stop all" doesn't popup anymore. Only after you change the search artist &/ album.

new progress bar = fabulous
image size grey -> black text = ok
drag&drop area = ok

Were there more fixes/changes? (sort asc/desc fixed, others?)

And yes one thing more; I noticed that the "download unknowns" gets only 1 image at a time including all sources. If the download stagnates for one source, it could get really boring to wait for all of the covers in the queue to finish. I already saw this happen almost everytime I did my tests with the above problems. This could get complicated, but could you change it so that it gets only 1 image at a time PER source? This way one stagnating source doesn't affect all.

I hope you're not getting tired with me.

Yes, you are welcome to include AAD XUI in your REACT mod. Send me a link when you do, I'd be interested to see it in use!

Thanks, I will. Though people are already using AAD XUI with REACT, it's just that REACT doesn't support it fully at the moment (limited support for other than .jpg's (only jpg's in the "original" AAD) -> some encoders crash, etc. bugs/problems).
Title: Album Art Downloader XUI
Post by: alsaan on 21 October, 2008, 07:48:22 PM
As for the buy.com script: sure, you can include it in the next release.
I've made a few changes to it and added cover type support (which wasn't very hard to do)
Here is the latest version: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
I'm about to include this in version 0.24, but before I do, is there any chance you could make it provide thumbnail images? It does help a lot with the search responsiveness. If it really can't be done, then just leave the full sized image parameter of the Add call as null, so it just uses the thumbnail as the full sized image rather than re-downloading it a second time.

Alex

Ok, I followed your suggestion and made some performance improvements: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
It's still a bit slower than I'd like, but it will do the job for now.
Title: Album Art Downloader XUI
Post by: AlexVallat on 22 October, 2008, 04:30:01 AM
now the unknown images which become "known" and are in example, below the minimum filter px, are NOT removed from the list.
I wasn't able to reproduce this. Following the steps you gave resulted in exactly correct behaviour. As each Unknown image was downloaded, it was removed from the list, with the exception of two results at 1000px width, and two at 1424px width. These were sorted in the correct order.

I'm guessing the reason that the images smaller than 1000px are sorting incorrectly for you is that they aren't supposed to be there at all (should have been filtered out), and are therefore not being sorted at all.

Are you clicking on any preview images, or scrolling during the search? Do you have a maximum filter turned on? Anything else you can think of we might be doing differently?

Discogs source shows image sizes in grey even if they really are full sized straight from the get go
You know that, and I know that, but AAD has no way of knowing that the size is accurate until it tries to get a full size image for them, and is told by the script to just use the thumbnail.

One new thing, sorry, when after the first search, you add more sources and click search again, the "stop all" doesn't popup anymore.
Tracker added - I'll look into that.

Were there more fixes/changes? (sort asc/desc fixed, others?)
Also: Window Size and Position should have been upgraded, the popup preview should ensure that the previewed image is brought into view when it closes, and the information label re-appearing should have been fixed.

could you change it so that it gets only 1 image at a time PER source?
Not really. The full sized image download worker is a low-priority background thread that crawls over all the results downloading the full sized images when appropriate. Having one thread per source would be a major architectural change that I won't be doing any time soon.

What I could do would be to add an option for each source (next to the Limit Results option) to ignore thumbnails for that source and download full size images right from the start. That way they'd be downloaded as part of the initial search, in that plugin's search thread. Would that be any use?
Title: Album Art Downloader XUI
Post by: Akkurat on 22 October, 2008, 03:31:26 PM
I wasn't able to reproduce this. Following the steps you gave resulted in exactly correct behaviour. As each Unknown image was downloaded, it was removed from the list, with the exception of two results at 1000px width, and two at 1424px width. These were sorted in the correct order.

I'm guessing the reason that the images smaller than 1000px are sorting incorrectly for you is that they aren't supposed to be there at all (should have been filtered out), and are therefore not being sorted at all.

Are you clicking on any preview images, or scrolling during the search? Do you have a maximum filter turned on? Anything else you can think of we might be doing differently?

No maximum filter, not doing anything while searching & downloading full size images. You're right about the reason why some of the images are not sorted, so the situation now is that only the filter isn't working.

I tested this problem with WinXP SP2 in MS Virtual PC, just normal windows install with all the latest updates (-this month updates), installed .NET3.5 = same thing, filter doesn't work.

Can you test this with some other computer which doesn't have your IDEs, SDKs and such dev. tools? I find it odd that this doesn't work in "vanilla" WinXP.

You know that, and I know that, but AAD has no way of knowing that the size is accurate until it tries to get a full size image for them, and is told by the script to just use the thumbnail.

Ok, just as I thought.

Also: Window Size and Position should have been upgraded, the popup preview should ensure that the previewed image is brought into view when it closes, and the information label re-appearing should have been fixed.

Works. Excellent.

What I could do would be to add an option for each source (next to the Limit Results option) to ignore thumbnails for that source and download full size images right from the start. That way they'd be downloaded as part of the initial search, in that plugin's search thread. Would that be any use?

I guess yeah, more features is good I guess.. thou it could confuse some users since there's the "download full size images : never" option. Maybe the functionality AAD has now is good enough (regarding this topic ).


New thing again: the "LastFM Artist" source returns some images twice. It seems that this happens with images which have the same link as the image below as a text link (jsus, does that make sense? English is sometimes hard).. look at this example gallery (http://www.last.fm/music/Corduroy/+images), the last image is the only one that has an extra link to the picture underneath it (text: l_af929402e4888ea54bd..), and if you search "corduroy" in AAD, only that image is listed twice.
Title: Album Art Downloader XUI
Post by: AlexVallat on 22 October, 2008, 04:19:46 PM
Can you test this with some other computer which doesn't have your IDEs, SDKs and such dev. tools?
No, I'm afraid not. Even if I could, it might not be that much help if I can't reproduce it with a debugger available.

Just once thing occurs to me, in the environments you tested in, was it .net 3.5 SP1? or plain 3.5?

Weird about that LastFM artist thing, I wonder why they've got that junk text link under the picture. I'll tweak the script to ignore it.
Title: Album Art Downloader XUI
Post by: Akkurat on 22 October, 2008, 09:23:27 PM
First, I'll vent out, I hate Micro$oft & I hate .NET even more after this. Thanks MS and your .NET POS and it's versions that are NOT (or should I say .NOT) versions, etc. crap (e.g.: after updating to 3.5 SP1, your existing 2.0 SP1 & 3.0 SP1 .NETs are updated to SP2 (these are NOT available separately, only with 3.5 SP1)... yeah, makes perfect sense.).

As you may have already guessed, the problem is solved. Installing .NET 3.5 SP1 to my VPC Win image solved it... at least in VPC image, I don't have the time or opportunity to install it on my "main" system at the moment because I "can't" reboot now (only hibernate).. but I'm sure it will work there too.

I didn't know that 3.5 SP1 was out, windows update (website, not the systray popup crap) doesn't offer it (all previous updates have been there), released on 8/11/2008, couple of months ago but still not in win update. Thumbs up MS, great work. One funny thing more: if you download just 3.5 ("bootstrapper"), the filename is "dotNetFx35setup.exe", guess what filename is used with 3.5 SP1? Yes, same "dotNetFx35setup.exe". -b Same thing with full setup downloads. Filename description & product name say that it's "Microsoft .NET Framework 3.5", the only way to know that it's SP1, is to "know" that the file version "3.5.30729.1" is the SP1.  It's so terrible that you can only laugh. Well, MS is known for poor versioning, but this time they stepped into big pile of.. eh pudding.

@Alex: So, it seems that you have either just upgraded to SP1 or started to use new features from it in AAD. I bet that you like .NET less after this.  Is there tools available to .NET IDE to track framework requirements of written code? Maybe it would be best to automatically push AAD users to new framework versions if you upgrade.

Btw. remember to update the first post link to the SP1.. and put up reminders everywhere.

Aaaannndd, one thing more.. it seems that this never stops.  I've now noticed couple of times that sources sometimes gets more images than the limit is. E.g. last search to "Darktown" returned 11 images (all different) while the limit is 10. Again, I've to say that this is not a biggie, and I've only seen, IIRC, 1 or 2 images over the limit. Nonetheless, I thought to report this so that you can keep an eye out for this. Small test: 10 searches, 2x 11 results (no filters used).
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 October, 2008, 03:07:57 AM
Yeah, they've really dropped the ball on that one. I upgraded to SP1 some time ago, actually. I can't remember exactly when, but I would have thought at least version 0.22 would have been compiled under it.

Anyway, I haven't used any new features from SP1, but SP1 did include a whole bunch of bug fixes and performance enhancements for WPF. One of which must have been to fix some buggy behaviour of the list control the results list is based on.

The IDE does track requirements of written code, and can be made to enforce requirements too. Unfortunately, it does not regard SP1 as any different from 3.5, so while I could track and enforce .net 2.0, 3.0 or 3.5, I can't do so for SP1. Not that it would help anyway, as the code I have used is supposed to work on plain 3.5 too, it's just 3.5 has some bug with it.

So, options now... well, first, I need to find a way to detect whether AAD is running on SP1 or not. Once I can do that, my first choice would be to implement some work-around code that makes it update the list correctly, at the cost of performance. Probably clearing the list completely and repopulating it would work, rather than just repopulating the single changed item.

I'll also have it pop up a warning on first run that installing SP1 would improve performance, and, of course, update the link in the posts to point to the SP1 installer.

Finally, I'll have a look at that maximum results thing. Sounds very strange, but I'll see if I can figure out what's going on. Probably some sort of timing thing.
Title: Album Art Downloader XUI
Post by: AlexVallat on 23 October, 2008, 03:44:07 AM
OK, no joy on detecting SP1 yet, but I've put together a version with what I am hoping will be a workaround to the filtered items not being removed thing. Note that in this version the bringing into view of the previewed result will not work. That is a side-effect of the workaround, and can't be helped.

AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe)

Could you let me know if it helps at all on a no SP1 system?
Title: Album Art Downloader XUI
Post by: acmodeu on 23 October, 2008, 03:30:43 PM
Just one question. When AAD learns to remember file extensions? If you click on a picture, choose "save as" and enter a new filename, you also have to put an extension for the file, otherwise AAD saves file without any.
Title: Album Art Downloader XUI
Post by: Akkurat on 23 October, 2008, 07:35:20 PM
Could you let me know if it helps at all on a no SP1 system?

Nope. Same behavior. I got that you don't have 2nd computer to test things out, right? Why don't you use MS Virtual PC (http://www.microsoft.com/windows/products/winfamily/virtualpc/default.mspx)? It's free. Though I'm considering moving to VirtualBox (http://www.virtualbox.org/) because at the first glance it seems to have a better "snapshot" system.

You might want to look at this: Update on .NET Framework 3.5 SP1 and Windows Update (http://www.hanselman.com/blog/UpdateOnNETFramework35SP1AndWindowsUpdate.aspx). There's a patch coming to SP1, before MS puts it in Windows Update.. one user comment is indeed funny: "How will we distinguish between 3.5 SP1 unpatched and 3.5 SP1 patched? Will it now be called 3.5 SP2? Or maybe 3.5 SP1 SP1!", good question knowing microsoft versioning.

If I understood correctly, the "plain" .NET 3.5 has not been in WUpdate yet.. at least I didn't see it when I just upgraded my VPC XP image to the 3.5 SP1.
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 October, 2008, 02:40:21 AM
If you click on a picture, choose "save as" and enter a new filename, you also have to put an extension for the file, otherwise AAD saves file without any.
Thanks for reporting this, I'll fix it for the next version.

Why don't you use MS Virtual PC (http://www.microsoft.com/windows/products/winfamily/virtualpc/default.mspx)?
I guess I'll have to then. Hopefully I'll find some time over the weekend to set it up, dig up an XP install disk and put Windows on to an image.
Title: Album Art Downloader XUI
Post by: Light on 24 October, 2008, 06:23:55 AM
i used a weird mouseclick sequence and now i only see the albums when i search for album art, like this:

(https://hydrogenaud.io/imgcache.php?id=2887d16d7e4db264c4bc053c8b6e2433" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.picvalley.net/u/1201/417972158_s.JPG) (http://www.picvalley.net/v.php?p=u/1201/417972158.JPG)

can i get that back to 'normal'? Like this:

(https://hydrogenaud.io/imgcache.php?id=5250174601b789d0385b9191f7ae6ce2" rel="cached" data-warn="External image, click to view at original size" data-url="http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FullArtPanel.gif)

And i have a simple solution to the 'various artist' folder problem... In the foobar browser, simply add a little toolbar or something where you can select folders you want to discard in the search, so that you can add anything you want, i'm thinking about: Skip : VA-*|VA_-*|Various*

Maybe that can work...
Title: Album Art Downloader XUI
Post by: AlexVallat on 24 October, 2008, 06:35:06 AM
i used a weird mouseclick sequence and now i only see the albums when i search for album art
See the grabber (line of grey dots) on the right-hand edge of the result, just past the thumbnail image? When your mouse is over that, you should get a horizontal resize cursor : <->. Click and drag the grabber to the right to expand the area so that you can see the text again.
Title: Album Art Downloader XUI
Post by: Light on 24 October, 2008, 06:43:12 AM
ah yes, that was it. Thanks, i made the picture too big by accident
Title: Album Art Downloader XUI
Post by: Akkurat on 24 October, 2008, 10:53:26 PM
"AllCdCover" source started to show "yes, we have the cover you're looking for, but no, we can't show it to you" custom image for some results.  I searched: "supergrass / i should coco", all 3 covers showed thumbnails but previewing them showed "don't leech" images with the above text.

2nd search only to that source showed correctly all, even the full size images in preview!? It could be that I fudged this test up; removed other sources and clicked search again -> no new search.

3rd search (all sources) showed same 3 "AllCdCover" thumbnails, and I mean ONLY thumbnails. I almost missed those because I had the minimum filter set at 495px (the previous searches showed them because AllCdCover returned the full size image sizes). No "don't leech" images this time!?

4th and all subsequent searches show only thumbnails like in the 3rd search.

It seems that they've coded some leech prevention system to their website (maybe IP restriction). Or what's wrong?

Ok, I tried to search some other covers and it definitely seems that they really are doing IP restriction (with time limit maybe?), all covers are thumbnails.

This is the big minus of AAD type of programs, you constantly have to fix sources because they restrict their service, and I do understand them to some point.. though I'm not so sure about the legality of their services, so.. AAD leeching from illegal services, who's the villain here? xxAA's?
Title: Album Art Downloader XUI
Post by: AlexVallat on 26 October, 2008, 04:23:56 PM
About the AllCdCover thing, it sounds like some sort of leech prevention, yes. I'm not getting those results here, probably because I haven't downloaded a lot of images from them using this IP address! If you want to address your concerns to daju, the author of that script, he might be able to do something about it, but frankly I doubt it.

If the script is no longer useful because of this, I will remove it from the installer, but as it is working for me at the moment, my preference would be to leave it in and see what happens.

On another subject, I've finally managed to get a pre SP1 environment running in a virtual machine (damn, but that was a pain to set up), and think I have something that should fix the list refresh bug. It's performance is a bit worse, so I've added a one-time warning that performance can be improved by downloading SP1.

Let me know if this does the job: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe)
Title: Album Art Downloader XUI
Post by: Akkurat on 26 October, 2008, 08:26:48 PM
About the AllCdCover thing, it sounds like some sort of leech prevention, yes. I'm not getting those results here, probably because I haven't downloaded a lot of images from them using this IP address! If you want to address your concerns to daju, the author of that script, he might be able to do something about it, but frankly I doubt it.

If the script is no longer useful because of this, I will remove it from the installer, but as it is working for me at the moment, my preference would be to leave it in and see what happens.

I ran the test again just now and I couldn't reproduce the previous problems. Just as I suspected. I did some detective work again and I noticed that when browsing their site, the full image download URL changes:

1st:
www.allcdcovers.com/download/cfb45d83c6f1ba7a6785441ce28e7356/90123/8cd3a44d0c5cd3bd4ec72c0e04a74f17/4904f992/supergrass_diamond_hoo_ha_2008_retail_cd-back

2nd (after clear cookies & clicking the download button again):
www.allcdcovers.com/download/cfb45d83c6f1ba7a6785441ce28e7356/90123/9969abe0a29799a44b2a67bb2b905bef/4904fa53/supergrass_diamond_hoo_ha_2008_retail_cd-back

These URLs work (refresh) even if you clear cookies. Then I waited about 10-15 minutes before I refreshed the images again, wellwell, here it is again; the "don't leech" image.

So, it seems that this would happen in AAD if user searches some covers and doesn't touch the results for a while. After that "don't leech" image, all subsequent searches would yield only thumbnails (or possibly the "don't leech" image) for X amount time which has been set by AllCdCover in the server side. Yes, it's definitely an IP address leech prevention; right after the both above image URL's "failed/timeouted", all my AAD searches started to show only thumbnails.

I then waited about 20-30 minutes and ran AAD search again, still thumbnails. Then some browsing in their website, all full size images load up fine. Back to AAD, still thumbnails. Tried to close&reopen AAD, nope, still doesn't work.  Nasty leech prevention.

I'll PM daju just in case to read this post.

Let me know if this does the job: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe)

Excellent. Unfortunately I just upgraded my main system last night. I quickly tried to uninstall SP1 in my VPC and reinstall plain 3.5, but it seems that the bug was corrected in either 2.0 SP2 or in 3.0 SP2 and I'm not going to start uninstalling&reinstalling those. Sorry. I'm sure it works ok if you tested it in 3.5.
Title: Album Art Downloader XUI
Post by: Akkurat on 27 October, 2008, 10:32:40 PM
Hi again. Guess what? One new problem.

I've seen this couple of times in the past but finally I awoke to report this.

Sometimes the full size preview image is cropped and is not showing the full image. I understand that very big images must be resized in order to see them in full in preview, but, it seems that some images are resized badly, i.e. cutting some portion of the image away from the preview. Now, this is crucial because user might discard that image because it seems that it's poorly scanned/cropped. Only by saving the image and checking it with other software, user sees the real image.

My screen resolution is 1280x1024 & I've taskbar in autohide mode (I tried w/o it but that had no effect) and in top of the screen (no change when moved to bottom).

Here's one example:

1) search "manic street preachers / gold against" from "AllCdCover" source (you should see 2 results)
2) click the thumbnail of the front cover; notice how it seems that the image is cropped thru the band & album name in the bottom of the image
3) save image
4) open the image with external software

= the artist & band name text is fully visible

I noticed that the other result (back cover) is also slightly cropped from the bottom in the preview.

I enlarged the thumbnail view and the thumbnail is not cropped.
Title: Album Art Downloader XUI
Post by: AlexVallat on 28 October, 2008, 03:51:10 AM
The size of the popup preview is limited by your screen resolution. It is deliberately not resized, as the point is to be able to see it at 1:1 zoom, for quality inspection.

If you want to see the real image in detail, to check the cropping at the edges or zoom in to an area of interest, then you don't need to save and open with another editor, just right click on the image and choose "Preview". You will then get a new resizeable preview window with the image in it you can scroll and zoom as you please.
Title: Album Art Downloader XUI
Post by: Akkurat on 28 October, 2008, 08:56:25 AM
The size of the popup preview is limited by your screen resolution. It is deliberately not resized, as the point is to be able to see it at 1:1 zoom, for quality inspection.

I'm confused. You say that the popup preview is NOT resized ever? Ok, if my screen resolution is 1280x1024, then how is it possible that I can see the full size of image (this one is not slightly cropped at the bottom) which size is 2845x1398? No resize? I'm sorry but I don't understand. Or is this a confusion over word semantics? Scaled/resized/?

Anyways, the point is that for some images a small portion of the bottom part is not visible in popup previews and I consider that as a bug. The screen resolution makes no difference since AAD tries to show the whole image (and succeeds in that for most of the images), no matter how much bigger it's compared to the screen resolution.
Title: Album Art Downloader XUI
Post by: AlexVallat on 28 October, 2008, 09:08:24 AM
Ah, no, don't worry, it's me getting confused, I'd forgotten I'd changed the behaviour of large popups a while back. I'll look into the cropping problem, thanks.
Title: Album Art Downloader XUI
Post by: Akkurat on 28 October, 2008, 09:31:40 AM
Ok, thanks a lot again. For your sanity's sake I hope I'm finished with "hitting AAD with my blessed +10 Debug sword".  BTW the image preview window was new to me, nice "new" feature.. I wonder what else I've missed.
Title: Album Art Downloader XUI
Post by: Zarggg on 28 October, 2008, 12:33:32 PM
Two quick questions: Does this program only search out .jpg files? If so, any chance on having it (optionally) also search for .png?
Title: Album Art Downloader XUI
Post by: AlexVallat on 28 October, 2008, 12:55:11 PM
Two quick questions: Does this program only search out .jpg files? If so, any chance on having it (optionally) also search for .png?
No, there is no limitation on file format. Most cover sites provide .jpg files, but there are a few that also have .png's. There are so few .png's around that it can be hard to notice, but the occasional one is there.
Title: Album Art Downloader XUI
Post by: Akkurat on 28 October, 2008, 04:38:29 PM
I see that you already have fixed the crop problem. Unbelievably fast. Excellent.

I've one thing more, this time not a bug/problem but a GUI "rethink": with my screen res. 1280x1024, taskbar in autohide and maximized AAD window, all of the sources are just visible. I noticed that you have one new source coming and it's going to put my source list to scroll, which isn't so nice because I'd like to see all the sources at the same time (searches, number of results).

Could you redesign the source list so that more sources could be fitted there without a scroll? One way to do this would be to cut the second line from the source info. Make the source a bit wider so that the search progress bar fits to the right side of the source name. Clicking the source name would open the options. The version and the author would be shown at the bottom in the options for that source. I made a quick mockup of it.. it's a bit crowded, especially with the search prog. bar.. this is just an idea, feel free to diss this down.
(https://hydrogenaud.io/imgcache.php?id=a1fe74d6720f880731a678cee10e9439" rel="cached" data-warn="External image, click to view at original size" data-url="http://img386.imageshack.us/img386/4913/aadpb5.jpg)
Title: Album Art Downloader XUI
Post by: tuxman on 28 October, 2008, 05:33:03 PM
I wonder why it tells me that it will "probably run slower" with my current configuration...

.net 3.5 SP-1 is available, I "only" got .net 3.5, so AAD came up with a strange message...

I guess it should be more tolerant... v3.5 is v3.5, basically.

Title: Album Art Downloader XUI
Post by: Akkurat on 28 October, 2008, 08:00:19 PM
I wonder why it tells me that it will "probably run slower" with my current configuration...

.net 3.5 SP-1 is available, I "only" got .net 3.5, so AAD came up with a strange message...

I guess it should be more tolerant... v3.5 is v3.5, basically.

I see, you haven't followed this thread. There's a bug (bugs?) in 3.5 which was causing AAD to fail one feature. Alex made a fix/workaround if plain 3.5 is installed which could (or probably will) lower the performance. So no, it shouldn't be more "tolerant".. at least you can run AAD and it works.. + you got a notice which suggests that you should upgrade your .NET.. pretty cool? And yes, 3.5 is 3.5 but 3.5 SP1 is 3.5 SP1.

Did you download that "test" version from the same post which had the following text by Alex over the link: "I have something that should fix the list refresh bug. It's performance is a bit worse, so I've added a one-time warning that performance can be improved by downloading SP1."

You were too busy to read?
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 October, 2008, 03:49:48 AM
Akkurat, thanks for the suggestion for the sources list. I don't think I'll go with that, though, as it would make the list quite a bit wider. The example you gave was using one of the shorter source names. To fit the longer ones in, the list would either become unacceptably wide, crop the name of the source, or have sideways scrolling. I prefer the vertical scrolling solution to all of those options.

You could always delete some scripts, if you really want to avoid vertical scrolling. Juno, PsyShop and RevHQ are all fairly specialist, and LastFM Cover often turns out to be duplicates of other sources.

v3.5 is v3.5, basically.
It would be nice if that were true, unfortunately it just isn't. I didn't put the warning in for the fun of it!

Under SP0, whenever I need to remove a result from the list (for example if it doesn't meet the minimum size filter), or reposition it (for sorting), then the whole list must be rebuilt. Under SP1, just that single changing item needs to be altered. Apart from being a monumental pain to track down and work around, this is also considerably slower, and I thought a warning might be useful.

If you leave the "don't ask me again" box checked, you won't see it again, and can safely ignore it.
Title: Album Art Downloader XUI
Post by: tuxman on 29 October, 2008, 07:41:54 AM
Did you download that "test" version from the same post which had the following text by Alex over the link: "I have something that should fix the list refresh bug. It's performance is a bit worse, so I've added a one-time warning that performance can be improved by downloading SP1."

You were too busy to read?

Yep, obviously... I'm quite sorry. 
Title: Album Art Downloader XUI
Post by: Akkurat on 29 October, 2008, 12:56:30 PM
I don't think I'll go with that

You could always delete some scripts, if you really want to avoid vertical scrolling. Juno, PsyShop and RevHQ are all fairly specialist, and LastFM Cover often turns out to be duplicates of other sources.

Sorry no, I don't like "bubblegum" solutions.  Oh well, was worth the try.. you could invent a new way to list the sources, *wink wink*, maybe some day.

Yep, obviously... I'm quite sorry. 

Nothing to be sorry about, it was a friendly tease.
Title: Album Art Downloader XUI
Post by: unabatedshagie on 29 October, 2008, 01:10:17 PM
I have my music stored in the following format.

H:\$left(%albumartistsort%,1)\%artist%\[%date%] %album%\

Which equates to

H:\B\Jeff Buckley\[1994-08-15] Grace\

Is there any way of automating AAD to save in this format?

Also I was wanting to use this to save artist pictures.

Is there any way to automate this using AAD? Is there any way of using the foobar browser to get the artist tag from the files?
Title: Album Art Downloader XUI
Post by: AlexVallat on 29 October, 2008, 01:29:48 PM