Hydrogenaudio Forums

CD-R and Audio Hardware => CD Hardware/Software => Topic started by: Synthetic Soul on 2006-11-17 07:53:46

Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-17 07:53:46
REACT 2.0 is not backward compatible with version 1.0. This version is  more powerful, easier to use and configure. It uses only two  configuration scripts: REACT-image.cfg, and REACT-track.cfg. Image mode  (F10) is recommended, as it may be used for creating both an image and  tracks, and is a little more robust. With Nyaochi's excellent ACDIR, it  will split the image to tracks while encoding. You can pick and choose  from which formats you want by only editing a few characters in the  .cfg file. See examples below.

NEWSFEATURES
The wiki has more info : http://wiki.hydrogenaudio.org/index.php?title=REACT (http://wiki.hydrogenaudio.org/index.php?title=REACT)

More information and download (http://www.hydrogenaudio.org/forums/index.php?showtopic=50259) in the thread REACT 2, EAC plugin (http://www.hydrogenaudio.org/forums/index.php?showtopic=50259)
Title: REACT 2 Released
Post by: Xenion on 2006-11-17 10:39:09
i'm new to this tool. is it possible to rip as image, then replaygain, write this replaygain information to the cuesheet and then encode wavpack with embedded cue and log ?
Title: REACT 2 Released
Post by: tycho on 2006-11-17 11:26:35
If you rip as image, you may encode to either a wavpack image or to wavpack tracks.

For tracks, set ImageExt=wav in REACT.ini and Wavpack=1 in REACT-image.cfg.
For image, set ImageExt=wv in REACT.ini and Wavpack=0 in REACT-image.cfg. It will embed both cuesheet and log file as tags in the image. For wv-images, REACT (wvgain actually) can only compute album gain (not track gain for individual tracks). Replaygain will be stored as tags in the image file only - not in the cuesheet.

However, if you encode to wavpack tracks, it will compute both album and track gain values and tag them to the track files. Make sure ReplayGain=1 in the .cfg file.

edit: just realized that for wavpack images, no replaygain computation is done. You will have to add
    if %ReplayGain%==1 @tools@\wvgain.exe -a "@image@"
after the wavpack.exe call in the .cfg file.
Title: REACT 2 Released
Post by: drbeachboy on 2006-11-17 17:12:52
Hi Tycho,

With embedded cuesheets (Especially with FLAC), foobar2000 rewrites (the embedded cuesheet) all the track PERFORMER's to "Various" if you use "-T artist="@artist@"" tag on Various Artists images. Replacing the ARTIST tag with the  ALBUM ARTIST tag would fix this problem.

Is it possible to set up 2 scenarios in the config file; one for regular images (with ARTIST tag) and one for VA's (with ALBUM ARTIST tag)?


Thanks,

Dirk
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-17 17:34:58
Hi Tycho,

With embedded cuesheets (Especially with FLAC), foobar2000 rewrites (the embedded cuesheet) all the track PERFORMER's to "Various" if you use "-T artist="@artist@"" tag on Various Artists images. Replacing the ARTIST tag with the  ALBUM ARTIST tag would fix this problem.

Is it possible to set up 2 scenarios in the config file; one for regular images (with ARTIST tag) and one for VA's (with ALBUM ARTIST tag)?
This has only come to my attention recently, possibly due to behavioural changes in foobar 0.9, or possibly that I generally use ACDIR in my REACT script.  It is a reasonable issue really, considering REACT and foobar's userbase.

I would certainly favour using ARTIST or ALBUM ARTIST depending on the situation.  It seems that this could be done using something like:

Code: [Select]
if @various@==0 set ArtistField=artist
if @various@==1 set ArtistField=album artist
...
@tools@\flac.exe %Flac_opt% %Flac_RG% %Flac_RG% %Flac_cover% -T "%ArtistField%=@cdartist@" -T album="@album@"...
...
@tools@\wavpack.exe %Wavpack_opt% -w "%ArtistField%=@cdartist@" -w album="@album@"...

... possibly.

Also note the use of @cdartist@ and not @artist@.
Title: REACT 2 Released
Post by: valnar on 2006-11-17 20:32:28
You know, I never had to uninstall REACT v1.0.  How do you do it?  Just delete the folder?

Robert
Title: REACT 2 Released
Post by: Keykey on 2006-11-17 20:39:19
I am a total newbie to REACT, sorry.

How do I get it to make a FLAC CDImage and loose mp3s? 

Waht should I change and how?

Greetz
Title: REACT 2 Released
Post by: Gow on 2006-11-17 22:34:39
Awesome release.  Keep up the good work.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-17 23:38:15
Can't wait to try this release tonight when I get home.

I'm also wondering can the disc ID be saved to a tag?
Title: REACT 2 Released
Post by: HbG on 2006-11-18 01:03:29
Just set it up to work with flake and metaflac for adding the cuesheet. Works beautifully. React rocks!
Title: REACT 2 Released
Post by: hanning on 2006-11-18 03:56:08
It seems that the following section in REACT-image.cfg is failing if @cover@ is containing a closing parenthesis, ")":

Code: [Select]
if exist "@cover@" (
    set Flac_cover=--picture="|image/jpeg|||@cover@"
    set MetaFlac_cover=--import-picture="|image/jpeg|||@cover@"
    set MetaMP3_cover=--pict "{3}@cover@"
    set AacTag_cover_acdir=-add-cover:front:$q@cover@$q
    set add_cover=1
    set add_meta=1
)


It fails silently on the "set AacTag_cover_acdir=..." line as the closing parenthesis in @cover@ isn't inside a "quoted string". The following code seems to work around the issue:

Code: [Select]
if not exist "@cover@" goto end_cover
    set Flac_cover=--picture="|image/jpeg|||@cover@"
    set MetaFlac_cover=--import-picture="|image/jpeg|||@cover@"
    set MetaMP3_cover=--pict "{3}@cover@"
    set AacTag_cover_acdir=-add-cover:front:$q@cover@$q
    set add_cover=1
    set add_meta=1
:end_cover


I hope this helps. Thanks for a great tool!
Title: REACT 2 Released
Post by: wolfsong on 2006-11-18 06:54:34
So I just tried it out and like the new config but I have some questions.

  • Accepts both "Various" and "Various Artists" as compilation disk.

How do I get:

Code: [Select]
\Various Artist\$album$

when EAC only uses Various? The wiki mentions @Various-destN@ but I have no idea how to use it. Thanks.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-18 09:49:27
I am a total newbie to REACT, sorry.
We are all noobs to v2.0, which has a very different format to v1, so I'm afraid we're all in the same position.  Take a look at the readme and experiment.

I'm also wondering can the disc ID be saved to a tag?
Isn't that the @freedbid@ token?  I think it is...

How do I get:

Code: [Select]
\Various Artist\$album$

when EAC only uses Various? The wiki mentions @Various-destN@ but I have no idea how to use it.
Sorry wolfsong, I forget: do you use images or tracks?

In REACT-image.cfg you have lines like:

set Flac_ImageDir=%OutRoot%\Flac-Images\$cdartist$

You could add somewhere (soon) below this something like:

IF @various@==1 set Flac_ImageDir=%OutRoot%\Flac-Images\Various Artists
Title: REACT 2 Released
Post by: drbeachboy on 2006-11-18 17:32:38
I also found the tag lines for embedding the cuesheet & eaclog in FLAC incorrect. You need to change the tag line to: "--tag-from-file" instead of "-T".
Title: REACT 2 Released
Post by: wolfsong on 2006-11-18 18:09:39
I'm also wondering can the disc ID be saved to a tag?
Isn't that the @freedbid@ token?  I think it is...
Actually I should have been more specific. I meant the TOC which I don't think is the same as @freedbid@.
Sorry wolfsong, I forget: do you use images or tracks?

I had been using images to get AG (never figured out how to do this in v1) and just deleting the image files. Now I just need tracks.
Title: REACT 2 Released
Post by: tycho on 2006-11-19 01:08:20
Thanks for all the great feedback. I have uploaded a new beta:
beta 2:Note that REACT.exe is unchanged (version change only). The modifications are in the .cfg files only.

@wolfsong: What TOC are you talking about? The cuesheet is a kind of a TOC. @freedbid@ is the freedb id number.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-19 04:12:10
@wolfsong: What TOC are you talking about? The cuesheet is a kind of a TOC. @freedbid@ is the freedb id number.

I thought there was a unique disc ID or TOC from the CD that I could tag. From my understanding the freedb id is generated by freedb.
Title: REACT 2 Released
Post by: tycho on 2006-11-19 10:15:17
AFAIK, there is no explicit ID stored on the CD, but freedb can generate a (fairly) unique id from the table of content (TOC) of CD, which it uses for lookup in the database. The TOC itself is basically the info in the raw cuesheet (without titles/names).
Title: REACT 2 Released
Post by: wolfsong on 2006-11-19 12:42:14
AFAIK, there is no explicit ID stored on the CD, but freedb can generate a (fairly) unique id from the table of content (TOC) of CD, which it uses for lookup in the database. The TOC itself is basically the info in the raw cuesheet (without titles/names).

hmmm for some reason I though the TOC itself could be tagged and there was a specific frame for this
Title: REACT 2 Released
Post by: bhoar on 2006-11-19 19:40:37
hmmm for some reason I though the TOC itself could be tagged and there was a specific frame for this


Me too... Catalog Number?

Ah:  http://digitalx.org/cuesheetsyntax.php (http://digitalx.org/cuesheetsyntax.php)

-brendan
Title: REACT 2 Released
Post by: spoon on 2006-11-19 19:47:08
There is ISRC (International Standards Recoding Code per track stored in the sub-codes) and UPC (universal product code per disc). Both of these are optional and are not implemented anywhere near 50% of cds.
Title: REACT 2 Released
Post by: sdgenxr on 2006-11-20 04:44:17
Thanks for the great release tycho!  This version is much easier to configure and run.

My question, for anyone, is how can I have REACT run the post-processing when there is a data track.  And how can I have it encode even when I have read errors?

Thanks!
Title: REACT 2 Released
Post by: tycho on 2006-11-20 07:52:41
My question, for anyone, is how can I have REACT run the post-processing when there is a data track.
Unfortunately, this is not possible with this release. Actually, it only worked sometimes in REACT 1, so I removed the support for @islast@.  Instead, you can extract using image mode. It will split the image into tracks while encoding. This will give the same result as EAC track mode (but you always get all tracks on the CD).
And how can I have it encode even when I have read errors?
As long as you are able to rip the image (even with read errors), it will encode, so I'm not sure what you mean here.

Cheers.
Title: REACT 2 Released
Post by: TomGroove on 2006-11-20 15:23:50
 excellent, I like the new version. Struggled a little bit at the beginning as I copied over the cfg to EAC dir, and wondered, why it was not used until I changed than the cfg within react 2 directory 

how can I use the album cover downloader, where do I have to download the cover to ?.. it comes up with a  jpg list and I guess, that I have to define than the relevant directory ??

edit: so the problem was probably related to not finding the cover at all of the latest Renaissance mix...
Title: REACT 2 Released
Post by: wolfsong on 2006-11-20 16:41:12
I'm having a problem with CoverArtDownloader. It seems to not use the filename specified in the settings and instead does something like ImageDir.jpg.

Also, could a hotkey option be added to launch CAD manually with the values passed?
Title: REACT 2 Released
Post by: tycho on 2006-11-20 18:48:51
The coverdownloader will fill in a name <destdir>\<album>.jpg. You should not change this name! Simply save it to the suggested directory/file name (Doubleclick on the cover you want). The .cfg script will then take care of copying it to the folder where the encoded audio will be stored, and change name to e.g. folder.jpg.

The destination directory you set up in EAC is only a temporary directory - the files are copied/moved to the final destinations by the script.

If you don't find all covers you expect, rename some of the files in the coverdownloader\scripts directory from "<name>.boo.disabled" to "<name>.boo". Try google.boo and discogs.boo. itunes.boo does unfortunately not work anylonger.

There is already a hotkey for only launching coverdownloader (mentioned in Readme): Alt-F10
Title: REACT 2 Released
Post by: wolfsong on 2006-11-20 20:00:29
The coverdownloader will fill in a name <destdir>\<album>.jpg. You should not change this name! Simply save it to the suggested directory/file name (Doubleclick on the cover you want). The .cfg script will then take care of copying it to the folder where the encoded audio will be stored, and change name to e.g. folder.jpg.

The destination directory you set up in EAC is only a temporary directory - the files are copied/moved to the final destinations by the script.

Ahhhh Good to know.
There is already a hotkey for only launching coverdownloader (mentioned in Readme): Alt-F10

I Thought I had read that somewhere but didn't see it in the ini so I didn't find it the again. Thanks.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-21 13:02:13
The destination directory you set up in EAC is only a temporary directory - the files are copied/moved to the final destinations by the script.
I tested this again this morning and this step isn't happening. The cover and log file are still in the EAC directory when using track config and deleted when using image config.

Track Config:
Code: [Select]
@echo off
chcp 1252
title @track@/@numtracks@ - "@album@"

rem ** You may consider using image mode (F10)
rem ** as it supports creating tracks via acdir.exe,
rem ** and post-processing will always work (see below).


REM ================== USER SETTINGS ======================


REM ---- Enable/disable track formats:

rem ** Flac requires flac.exe/metaflac.exe (v1.1.3)
rem ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
rem ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.

set Flac=0
set Wavpack=0
set LameMP3=1
set NeroAac=0
set OggEnc2=0

REM ---- General settings:

set Debug=0

rem ** I prefer applying album gain 92dB to get a reasonable
rem ** volume for my DAP. The RG tags are still relative
rem ** to 89dB SPL, i.e. album gain will be about -3.0dB.

set ReplayGain=1
set ApplyMp3AacAlbumGain=1
set AdjustMp3AacAlbumGain_dB=+0.0

REM ---- Encoder options:

set Flac_opt=-5 -f
set Wavpack_opt=-hmy
set LameMP3_opt=-V4 --vbr-new --noreplaygain --nohist
rem ** Nero LC-AAC @ ~ 90kbps - great for e.g. iPods:
set NeroAac_opt=-lc -q 0.22
set OggEnc2_opt=-q 3.0

set Flac_ver=1.1.3b2
set LameMP3_ver=3.97
set NeroAac_ver=1.0.0.2

REM ---- Output directories and track names:

set OutRoot=E:\TAGZ

rem ** Track dirs:
set Flac_TrackDir=%OutRoot%\Flac\$cdartist$\[$year$] $album$
set Wavpack_TrackDir=%OutRoot%\Wavpack\$cdartist$\[$year$] $album$
set MP3_TrackDir=%OutRoot%\$cdartist$\$album$
IF @various@==1 set MP3_TrackDir=%OutRoot%\Various Artists\$album$
set AAC_TrackDir=%OutRoot%\AAC\$cdartist$\[$year$] $album$
set OGG_TrackDir=%OutRoot%\OGG\$cdartist$\[$year$] $album$

rem ** Track names:
if @various@==0 set TrackName=[$track$] $title$
if @various@==1 set TrackName=[$track$] $title$ ($artist$)


REM ============== BEGIN MAIN SCRIPT ==================


if %Debug%==1 echo on


REM ---- Track ----


if %Flac%==0 goto end_flac_tracks
set dest=%Flac_TrackDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\flac.exe %Flac_opt% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="Ripped with EAC/REACT" "@source@" -o "%dest%\%TrackName%.flac"
:end_flac_tracks


if %Wavpack%==0 goto end_wavpack_tracks
set dest=%Wavpack_TrackDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\wavpack.exe %Wavpack_opt% -w artist="@artist@" -w album="@album@" -w track="@track@/@numtracks@" -w title="@title@" -w year="@year@" -w genre="@genre@" -w comment="Ripped with EAC/REACT" "@source@" "%dest%\%TrackName%.wv"
title @track@/@numtracks@ - "@album@"
:end_wavpack_tracks


if %LameMP3%==0 goto end_mp3_tracks
set dest=%MP3_TrackDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\lame.exe %LameMP3_opt% "@source@" "%dest%\%TrackName%.mp3"
@tools@\metamp3.exe --artist "@artist@" --album "@album@" --track @track@/@numtracks@ --title "@title@" --year "@year@" --genre "@genre@" --comment "Ripped with EAC/REACT" --frame TPE2:"@cdartist@" --frame TENC:"%USERNAME%" --frame TSSE:"LAME %LameMP3_ver% %LameMP3_opt%" "%dest%\%TrackName%.mp3"
:end_mp3_tracks


if %NeroAac%==0 goto end_aac_tracks
set dest=%AAC_TrackDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\neroAacEnc.exe %NeroAac_opt% -if "@source@" -of "%dest%\%TrackName%.m4a"
@tools@\neroAacTag.exe "%dest%\%TrackName%.m4a" -meta:artist="@artist@" -meta:album="@album@" -meta:track=@track@ -meta:totaltracks=@numtracks@ -meta:title="@title@" -meta:year="@year@" -meta:genre="@genre@" -meta:comment="Ripped with EAC/REACT"
:end_aac_tracks


if %OggEnc2%==0 goto end_ogg_tracks
set dest=%OGG_TrackDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\oggenc2.exe %OggEnc2_opt% -c artist="@artist@" -c album="@album@" -c tracknumber="@track@/@numtracks@" -c title="@title@" -c date="@year@" -c genre="@genre@" -c comment="Ripped with EAC/REACT" "@source@" -o "%dest%\%TrackName%.ogg"
:end_ogg_tracks


rem ** Delete the source .wav

del "@source@"


REM ---- Post-processing ----


rem ** Scan and compute ReplayGain and add cover picture for supported formats.
rem **
rem ** NB: The following will only work if at least the last track is selected,
rem ** and it is a regular audio track.

if not @track@==@numtracks@ goto end_post_process

set add_rg=%ReplayGain%
set add_meta=%add_rg%
set add_cover=0
set small_cover=@cover@

if %ReplayGain%==1 (
set MetaFlac_RG=--add-replay-gain
set MetaMp3_RG=--replay-gain
)
if %ApplyMp3AacAlbumGain%==1 (
set AacGain_RG=/a /o /c /d %AdjustMp3AacAlbumGain_dB%
set MetaMP3_RG=--apply-gain album%AdjustMp3AacAlbumGain_dB%
set add_rg=1
set add_meta=1
)
if exist "@cover@" (
set MetaFlac_cover=--import-picture="|image/jpeg|||@cover@"
set MetaMP3_cover=--pict "{3}@cover@"
set AacTag_cover=-add-cover:front:"@cover@"
set add_cover=1
set add_meta=1
)


rem ** Formats:

if %Flac%==1 (
pushd "%Flac_TrackDir%"
if %add_meta%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %MetaFlac_RG% %MetaFlac_cover% *.flac
if exist "@eaclog@" copy "@eaclog@" "EAClog.txt"
if %add_cover%==1 copy "@cover@" "folder.jpg"
popd
)

if %Wavpack%==1 (
pushd "%Wavpack_TrackDir%"
if %ReplayGain%==1 @tools@\wvgain.exe -a *.wv
if exist "@eaclog@" copy "@eaclog@" "EAClog.txt"
if %add_cover%==1 copy "@cover@" "folder.jpg"
popd
)

if %LameMP3%==1 (
pushd "%MP3_TrackDir%"
if %add_meta%==1 @tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% *.mp3
popd
)

if %NeroAac%==1 (
pushd "%AAC_TrackDir%"
if %add_cover%==1 for %%i in (*.m4a) do @tools@\neroAacTag.exe "%%i" %AacTag_cover%
if %add_rg%==1 @tools@\aacgain.exe %AacGain_RG% *.m4a > "gainlog.txt"
popd
)

if %OggEnc2%==1 (
pushd "%OGG_TrackDir%"
if %ReplayGain%==1 @tools@\vorbisgain.exe -a *.ogg
popd
)


rem ** Cleanup

del "@eaclog@"
del "@albumfile@.[*].cue"
del "@cover@"
:end_post_process


REM ================ END MAIN SCRIPT ===================


if %Debug%==1 (
pause
REM exit
)

rem ** Delete this .bat file:
del %0
Image Config:
Code: [Select]
@echo off
chcp 1252
title REACT - "@album@"


REM ================== USER SETTINGS ======================


rem ** To archive a CD as one large "image", you must set
rem ** ImageExt=... in the REACT.ini file (Press Alt-F2).
rem ** This will set the @imageext@ variable. Extensions
rem ** currently supported:  flac, wv, mp3. Set to 'wav'
rem ** for no image archiving (default).

REM ---- Enable/disable additional track formats:

rem ** Splits the wav-image into tracks during encoding, using ACDIR.
rem ** Flac requires flac.exe/metaflac.exe (v1.1.3)
rem ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
rem ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.

set Flac=0
set Wavpack=0
set LameMP3=1
set NeroAac=0
set OggEnc2=0

REM ---- General settings ----

set Debug=0

rem ** I prefer applying album gain 92dB to get a reasonable
rem ** volume for my DAP. The RG tags are still relative
rem ** to 89dB SPL, i.e. album gain will be about -3.0dB.

set ReplayGain=1
set ApplyMp3AacAlbumGain=1
set AdjustMp3AacAlbumGain_dB=+0.0

REM ---- Encoder options ----

set Flac_opt=-5 -f
set Wavpack_opt=-hmy
set LameMP3_opt=-V4 --vbr-new --noreplaygain --nohist
rem ** Nero LC-AAC @ ~ 90kbps - great for e.g. iPods:
set NeroAac_opt=-lc -q 0.22
set OggEnc2_opt=-q 3.0

set Flac_ver=1.1.3b2
set LameMP3_ver=3.97
set NeroAac_ver=1.0.0.2

REM ---- Output directories and track names ----

set OutRoot=E:\TAGZ

rem ** Image dirs:
set Flac_ImageDir=%OutRoot%\Flac-Images\$cdartist$
set Wavpack_ImageDir=%OutRoot%\Wavpack-Images\$cdartist$
set MP3_ImageDir=%OutRoot%\MP3-Images\$cdartist$

rem ** Track dirs:
set Flac_TrackDir=%OutRoot%\Flac\$cdartist$\[$year$] $album$
set Wavpack_TrackDir=%OutRoot%\Wavpack\$cdartist$\[$year$] $album$
set MP3_TrackDir=%OutRoot%\$cdartist$\$album$
IF @various@==1 set MP3_TrackDir=%OutRoot%\Various Artists\$album$
set AAC_TrackDir=%OutRoot%\AAC\$cdartist$\[$year$] $album$
set OGG_TrackDir=%OutRoot%\OGG\$cdartist$\[$year$] $album$

rem ** Track names (for ACDIR):
if @various@==0 set TrackName=[$n] $~t
if @various@==1 set TrackName=[$n] $~t ($~a)


REM ============== BEGIN MAIN SCRIPT ==================


if %Debug%==1 echo on

set add_rg=%ReplayGain%
set add_meta=%add_rg%
set add_cover=0
set small_cover=@cover@

if %ReplayGain%==1 (
set Flac_RG=--replay-gain
set MetaFlac_RG=--add-replay-gain
set MetaMp3_RG=--replay-gain
)
if %ApplyMp3AacAlbumGain%==1 (
set AacGain_RG=/a /o /c /d %AdjustMp3AacAlbumGain_dB%
set MetaMP3_RG=--apply-gain album%AdjustMp3AacAlbumGain_dB%
set add_rg=1
set add_meta=1
)
if exist "@cover@" (
set Flac_cover=--picture="|image/jpeg|||@cover@"
set MetaFlac_cover=--import-picture="|image/jpeg|||@cover@"
set MetaMP3_cover=--pict "{3}@cover@"
set AacTag_cover_acdir=-add-cover:front:$q@cover@$q
set add_cover=1
set add_meta=1
)


REM ---- Image ----


if not "@imageext@"=="flac" goto end_flac_image
set dest=%Flac_ImageDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\flac.exe %Flac_opt% %Flac_RG% %Flac_RG% %Flac_cover% -T artist="@artist@" -T album="@album@" -T totaltracks="@numtracks@" -T date="@year@" -T genre="@genre@" -T comment="Ripped with EAC/REACT" -T cuesheet="@@cuesheet@" -T eaclog="@@eaclog@" "@source@" -o "@image@"
move "@image@" "%dest%"
copy "@cuesheet@" "%dest%"
if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_flac_image


if not "@imageext@"=="wv" goto end_wavpack_image
set dest=%Wavpack_ImageDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\wavpack.exe %Wavpack_opt% -w artist="@artist@" -w album="@album@" -w totaltracks="@numtracks@" -w year="@year@" -w genre="@genre@" -w comment="Ripped with EAC/REACT" -w cuesheet="@@cuesheet@" -w eaclog="@@eaclog@" "@source@" "@image@"
title REACT - "@album@"
move "@image@" "%dest%"
copy "@cuesheet@" "%dest%"
if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_wavpack_image

if not "@imageext@"=="mp3" goto end_mp3_image
set dest=%MP3_ImageDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\lame.exe %LameMP3_opt% "@source@" "@image@"
@tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% --artist "@artist@" --album "@album@" --track @numtracks@ --year "@year@" --genre "@genre@" --comment "Ripped with EAC/REACT" --frame TPE2:"@cdartist@" --frame TENC:"%USERNAME%" --frame TSSE:"LAME %LameMP3_ver% %LameMP3_opt%" "@image@"
move "@image@" "%dest%"
copy "@cuesheet@" "%dest%"
if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_mp3_image



REM ---- Tracks ----


if %Flac%==0 goto end_flac_tracks
set dest=%Flac_TrackDir%
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.flac" --pipe "title $n/$N flac $#T & @tools@\flac.exe %Flac_opt% -T artist=$#a -T album=$#T -T title=$#t -T tracknumber=$n/$N -T date=$q@year@$q -T genre=$q@genre@$q -T comment=$qRipped with EAC/REACT$q - -o $#o" "@sourcecuesheet@"
if %add_meta%==1 (
pushd "%dest%"
@tools@\Glob.exe -v -c @tools@\metaflac.exe %MetaFlac_RG% %MetaFlac_cover% *.flac
popd
)
copy "@eaclog@" "%dest%\EAClog.txt"
if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
if exist "@albumfile@.[*].cue" copy "@albumfile@.[*].cue" "%dest%"
:end_flac_tracks


if %Wavpack%==0 goto end_wavpack_tracks
set dest=%Wavpack_TrackDir%
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.wv" --pipe "@tools@\wavpack.exe %Wavpack_opt% -w artist=$#a -w album=$#T -w title=$#t -w track=$n/$N -w year=$q@year@$q -w genre=$q@genre@$q -w comment=$qRipped with EAC/REACT$q - $#o" "@sourcecuesheet@"
if %ReplayGain%==1 (
pushd "%dest%"
@tools@\wvgain.exe -a *.wv
popd
)
title REACT - "@album@"
copy "@eaclog@" "%dest%\EAClog.txt"
if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
if exist "@albumfile@.[*].cue" copy "@albumfile@.[*].cue" "%dest%"
:end_wavpack_tracks


if %LameMP3%==0 goto end_mp3_tracks
set dest=%MP3_TrackDir%
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.mp3" --pipe "title $n/$N mp3 $#T & @tools@\lame.exe %LameMP3_opt% - $#o & @tools@\metamp3.exe --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $qRipped with EAC/REACT$q --frame TPE2:$q@cdartist@$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME %LameMP3_ver% %LameMP3_opt%$q $#o" "@sourcecuesheet@"
if %add_meta%==1 (
pushd "%dest%"
@tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% *.mp3
popd
)
REM copy "@eaclog@" "%dest%\EAClog.txt"
REM if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
:end_mp3_tracks


if %NeroAac%==0 goto end_aac_tracks
set dest=%AAC_TrackDir%
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.m4a" --pipe "title $n/$N aac $#T & @tools@\neroAacEnc.exe %NeroAac_opt% -if - -of $#o & @tools@\neroAacTag.exe $#o %AacTag_cover_acdir% -meta:artist=$#a -meta:album=$#T -meta:title=$#t -meta:track=$n -meta:totaltracks=$N -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$qRipped with EAC/REACT$q" "@sourcecuesheet@"
if %add_rg%==1 (
pushd "%dest%"
@tools@\aacgain.exe %AacGain_RG% *.m4a > gainlog.txt
popd
)
REM copy "@eaclog@" "%dest%\EAClog.txt"
REM if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
:end_aac_tracks


if %OggEnc2%==0 goto end_ogg_tracks
set dest=%OGG_TrackDir%
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.ogg" --pipe "title $n/$N ogg $#T & @tools@\oggenc2.exe %OggEnc2_opt% -c artist=$#a -c album=$#T -c title=$#t -c tracknumber=$n/$N -c date=$q@year@$q -c genre=$q@genre@$q -c comment=$qRipped with EAC/REACT$q - -o $#o" "@sourcecuesheet@"
if %ReplayGain%==1 (
pushd "%dest%"
@tools@\vorbisgain.exe -a *.ogg
popd
)
REM copy "@eaclog@" "%dest%\EAClog.txt"
REM if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
:end_ogg_tracks


REM ================ END MAIN SCRIPT ===================

if %Debug%==1 (
pause
REM exit
)

rem ** Cleanup

del "@source@"
del "@eaclog@"
del "@cuesheet@"
del "@albumfile@.[*].cue"
del "@cover@"

rem ** Delete this .bat file:
del %0

Also, are boolean arguements supported? So something like:
Code: [Select]
IF @various@==1 set MP3_TrackDir=%OutRoot%\Various Artists\Collections\$album$
IF @various@==1 AND IF @genre@==Soundtrack set MP3_TrackDir=%OutRoot%\Various Artists\Soundtracks\$album$
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-21 13:24:48
Also, are boolean arguements supported? So something like:
Code: [Select]
IF @various@==1 set MP3_TrackDir=%OutRoot%\Various Artists\Collections\$album$
IF @various@==1 AND IF @genre@==Soundtrack set MP3_TrackDir=%OutRoot%\Various Artists\Soundtracks\$album$
You can do:

Code: [Select]
IF @various@==1 IF @genre@==Soundtrack set MP3_TrackDir=%OutRoot%\Various Artists\Soundtracks\$album$

The second IF will only run if the first is true.

If you needed to get more complex you can start using brackets and/or ELSE, e.g.:

Code: [Select]
IF @various@==1 (
  IF @genre@==Soundtrack (
    REM CD is both VA and a soundtrack
    SET MP3_TrackDir=%OutRoot%\Various Artists\Soundtracks\$album$
  ) ELSE (
    REM CD is VA but not a soundtrack
    SET MP3_TrackDir=%OutRoot%\Various Artists\$album$
  )
) ELSE (
  REM CD is not VA
  SET MP3_TrackDir=%OutRoot%\$artist$\$album$
)
Title: REACT 2 Released
Post by: wolfsong on 2006-11-21 13:48:26
You can do:

Nifty. I like the more complex option simply because it's more readable.

I also notice that albumart tends to hang and take up CPU resources (around 95%) for 30 to 90 seconds while trying to save the image. I know this isn't tycho's code, just wondering if anyone else is seeing this too.

@tycho: could this extra bit of code i'm using be throwing off how the cover image is being handled?
Title: REACT 2 Released
Post by: tycho on 2006-11-21 15:02:00

You can do:

Nifty. I like the more complex option simply because it's more readable.

I also notice that albumart tends to hang and take up CPU resources (around 95%) for 30 to 90 seconds while trying to save the image. I know this isn't tycho's code, just wondering if anyone else is seeing this too.

@tycho: could this extra bit of code i'm using be throwing off how the cover image is being handled?

First, although it looks more readable with the paranthesis blocks in the script, e.g.
IF @various@==1 (
    set MP3_TrackDir=%OutRoot%\Various Artists\$album$
    echo %MP3_TrackDir%
)
it will fail if either %OutRoot% or $album$ contains a ')' character, because the silly dos-script interprets it as closing of the block!
Also be aware of that the echo line will not print out the value you set above! First outside the parathesis block it will be readable!
Conclusion: use labels and 'goto's instead to avoid both of these problems.

Secondly, the discogs.boo script does find many covers, but I think it is because of this that albumart hangs. Disable it.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-21 20:01:03
Conclusion: use labels and 'goto's instead to avoid both of these problems.

Can you give me an idea what this looks like? I'm not sure what language syntax is being used in the scripting? Is it pure DOS syntax? I'm afraid my brain can't access that file any longer (but I may have a book on the shelf at home).
Secondly, the discogs.boo script does find many covers, but I think it is because of this that albumart hangs. Disable it.

Hmm then it may just be that it hasn't finished grabbing covers when I try to save one because I tend to find one right away. I'll hold off on disabling it and giving it a chance to run first but if it gets too annoyin it'a good to know what the problem is. Thanks.
Title: REACT 2 Released
Post by: countryman on 2006-11-21 23:36:46
Hi,

I have downloaded REACT 2 but cannot get it to work.  In the ‘REACT-image.cfg’ file I have the following:

set Flac=1
set Wavpack=0
set LameMP3=0
set NeroAac=0
set OggEnc2=0

In the ‘REACT-track.cfg’ file I have:

set Flac=1
set Wavpack=0
set LameMP3=0
set NeroAac=0
set OggEnc2=0

When I hit the ‘MP3’ icon in EAC I get a new folder called ‘EAC\Flac\Artist\Album name\ but the folder is empty.  I have decided to start from scratch again and uninstall REACT but it does not appear in the ‘Add/Remove Programs’ pane.

Any advice gratefully received!

Cheers.
Title: REACT 2 Released
Post by: drbeachboy on 2006-11-22 01:36:35
Try pressing the "F10" key on your keyboard.

Also, please read the REACT wiki (http://wiki.hydrogenaudio.org/index.php?title=REACT) on how to use the program.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-22 05:34:30
@tycho
Even when I leave out this extra bit of code (which seemed to work fine) the image is not copied to the destination folder. The file is in the temp directory when I select/save it but once the batch runs it's deleted. I assume it's in the post processing portion of the config that this step should occur.
Title: REACT 2 Released
Post by: tycho on 2006-11-22 08:39:43
@tycho
Even when I leave out this extra bit of code (which seemed to work fine) the image is not copied to the destination folder. The file is in the temp directory when I select/save it but once the batch runs it's deleted. I assume it's in the post processing portion of the config that this step should occur.

The .flac or .wv image is *moved* to the destination folder (default My Documents\My Music\Flac-Images\... for flac). If the move operation should fail for some reason, the compressed image will stay in the original EAC destination folder. The only image that is ever deleted is the ripped .wav image - but why would you ever want that?

@countryman: You want to create flac tracks only, right? It should actually work by pressing the MP3 icon, like you did. I think your problem is that you have forgotten to download flac.exe and metaflac.exe and put it in the REACT2\tools folder. Make sure to get the latest beta 1.1.3 beta 2 (a release is soon to come i believe).

However, like drbeachboy suggested, it is better to rip in image mode, and let REACT split the image into tracks, by hitting F10. This also starts CoverDownloader for you, so you can save a cover picture. The picture will be embedded in each flac track, using the new option in flac 1.1.3
Title: REACT 2 Released
Post by: wolfsong on 2006-11-22 11:53:37

@tycho
Even when I leave out this extra bit of code (which seemed to work fine) the image is not copied to the destination folder. The file is in the temp directory when I select/save it but once the batch runs it's deleted. I assume it's in the post processing portion of the config that this step should occur.

The .flac or .wv image is *moved* to the destination folder (default My Documents\My Music\Flac-Images\... for flac). If the move operation should fail for some reason, the compressed image will stay in the original EAC destination folder. The only image that is ever deleted is the ripped .wav image - but why would you ever want that?

Sorry. I mean cover art.
Title: REACT 2 Released
Post by: tycho on 2006-11-22 14:22:51
Ah. The cover is embeded in the tracks for flac, mp3 and m4a files, so they are not copied to the directory by default. You may extract them using metaflac, metamp3 and neroaactag correspondingly. If you want to have the cover files in the directory as standard, remove the REM from the line:
REM IF %add_cover%==1 COPY "@cover@" "folder.jpg"
for the format in question.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-22 15:13:40
Ah. The cover is embeded in the tracks for flac, mp3 and m4a files, so they are not copied to the directory by default. You may extract them using metaflac, metamp3 and neroaactag correspondingly. If you want to have the cover files in the directory as standard, remove the REM from the line:
REM IF %add_cover%==1 COPY "@cover@" "folder.jpg"
for the format in question.

I'll give it a try tonight. One more thing.

Conclusion: use labels and 'goto's instead to avoid both of these problems.

Can you give me an idea what this looks like? I'm not sure what language syntax is being used in the scripting? Is it pure DOS syntax? I'm afraid my brain can't access that file any longer (but I may have a book on the shelf at home).

I did locate my DOS 6.2 books BTW if that's the syntax I can probably figure it out from there. Thanks.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-22 15:44:17
It is basic DOS commands BTW.

http://www.ss64.com/nt/goto.html (http://www.ss64.com/nt/goto.html)

Essentially it's as easy as:

Code: [Select]
GOTO MyLabel
REM This will never execute
:MyLabel
REM Do something here

I must admit I'm not sure exactly what Tycho has in mind, but one solution may be:

Code: [Select]
IF @various@==1 GOTO Various
REM CD is not VA
SET MP3_TrackDir=%OutRoot%\$artist$\$album$
GOTO Complete
:Various
IF @genre@==Soundtrack GOTO Soundtrack
REM CD is VA but not a soundtrack
SET MP3_TrackDir=%OutRoot%\Various Artists\$album$
GOTO Complete
:Soundtrack
REM CD is both VA and a soundtrack
SET MP3_TrackDir=%OutRoot%\Various Artists\Soundtracks\$album$
:Complete
Title: REACT 2 Released
Post by: wolfsong on 2006-11-23 18:26:48
If you want to have the cover files in the directory as standard, remove the REM from the line:
REM IF %add_cover%==1 COPY "@cover@" "folder.jpg"
for the format in question.

@tycho
FYI: This line is not in the track config. I'm assuming this line
Code: [Select]
if %add_meta%==1 @tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% *.mp3

adds the cover tag but since F2K doesn't have a component that reads this tag and I've seen embedded cover art cause problems, I'll also assume that I can remove the  %MetaMP3_cover% option without ill effect.

One more thing. Thanks for doing so much development and this version in particular has been the easiest to use so far. Keep up the good work.

@Synthetic Soul
Thanks for creating the wiki and always taking a crack at answering questions. You rock!
Title: REACT 2 Released
Post by: sdgenxr on 2006-11-25 05:33:15
Image creation assistance needed.  For some reason when I create an image by pressing F10 all I get is track 2 in FLAC format and nothing else.  I'm not sure what is happening here.  Any ideas?

image.cfg
Code: [Select]
@echo off
chcp 1252
title REACT - "@album@"


REM ================== USER SETTINGS ======================


rem ** To archive a CD as one large "image", you must set
rem ** ImageExt=... in the REACT.ini file (Press Alt-F2).
rem ** This will set the @imageext@ variable. Extensions
rem ** currently supported:  flac, wv, mp3. Set to 'wav'
rem ** for no image archiving (default).

REM ---- Enable/disable additional track formats:

rem ** Splits the wav-image into tracks during encoding, using ACDIR.
rem ** Flac requires flac.exe/metaflac.exe (v1.1.3)
rem ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
rem ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.

set Flac=1
set Wavpack=0
set LameMP3=1
set NeroAac=0
set OggEnc2=0

REM ---- General settings ----

set Debug=0

rem ** I prefer applying album gain 92dB to get a reasonable
rem ** volume for my DAP. The RG tags are still relative
rem ** to 89dB SPL, i.e. album gain will be about -3.0dB.

set ReplayGain=1
set ApplyMp3AacAlbumGain=1
set AdjustMp3AacAlbumGain_dB=+3.0

REM ---- Encoder options ----

set Flac_opt=-5 -f
set Wavpack_opt=-hmy
set LameMP3_opt=-V2 --vbr-new --noreplaygain -c --nohist
rem ** Nero LC-AAC @ ~ 90kbps - great for e.g. iPods:
set NeroAac_opt=-lc -q 0.22
set OggEnc2_opt=-q 3.0

set Flac_ver=1.1.3b2
set LameMP3_ver=3.97
set NeroAac_ver=1.0.0.2

REM ---- Output directories and track names ----

set OutRoot=E:\Ripping

rem ** Image dirs:
set Flac_ImageDir=%OutRoot%\Flac-Images\$cdartist$
set Wavpack_ImageDir=%OutRoot%\Wavpack-Images\$cdartist$
set MP3_ImageDir=%OutRoot%\MP3-Images\$cdartist$

rem ** Track dirs:
set Flac_TrackDir=%OutRoot%\Flac\$cdartist$\$cdartist$ - ($year$) - $album$
set Wavpack_TrackDir=%OutRoot%\Wavpack\$cdartist$\$cdartist$ - ($year$) - $album$
set MP3_TrackDir=%OutRoot%\MP3\$cdartist$\$cdartist$ - ($year$) - $album$
set AAC_TrackDir=%OutRoot%\AAC\$cdartist$\$cdartist$ - ($year$) - $album$
set OGG_TrackDir=%OutRoot%\OGG\$cdartist$\$cdartist$ - ($year$) - $album$

rem ** Vairous Track dirs:
if @various@==1 set Flac_TrackDir=%OutRoot%\Flac\$album$ - ($year$)
if @various@==1 set Wavpack_TrackDir=%OutRoot%\$album$ - ($year$)
if @various@==1 set MP3_TrackDir=%OutRoot%\MP3\$album$ - ($year$)
if @various@==1 set AAC_TrackDir=%OutRoot%\AAC\$album$ - ($year$)
if @various@==1 set OGG_TrackDir=%OutRoot%\OGG\$album$ - ($year$)

rem ** Track names:
if @various@==0    set TrackName=$track$ - $title$
if @various@==1    set TrackName=$track$ - $title$ ($artist$)

REM ============== BEGIN MAIN SCRIPT ==================


if %Debug%==1 echo on

set add_rg=%ReplayGain%
set add_meta=%add_rg%
set add_cover=1
set small_cover=@cover@

if %ReplayGain%==1 (
    set Flac_RG=--replay-gain
    set MetaFlac_RG=--add-replay-gain
    set MetaMp3_RG=--replay-gain
)
if %ApplyMp3AacAlbumGain%==1 (
    set AacGain_RG=/a /o /c /d %AdjustMp3AacAlbumGain_dB%
    set MetaMP3_RG=--apply-gain album%AdjustMp3AacAlbumGain_dB%
    set add_rg=1
    set add_meta=1
)
if exist "@cover@" (
    set Flac_cover=--picture="|image/jpeg|||@cover@"
    set MetaFlac_cover=--import-picture="|image/jpeg|||@cover@"
    set MetaMP3_cover=--pict "{3}@cover@"
    set AacTag_cover_acdir=-add-cover:front:$q@cover@$q
    set add_cover=1
    set add_meta=1
)


REM ---- Image ----
   

if not "@imageext@"=="flac" goto end_flac_image
    set dest=%Flac_ImageDir%
    if not exist "%dest%" mkdir "%dest%"
    @tools@\flac.exe %Flac_opt% %Flac_RG% %Flac_RG% %Flac_cover% -T artist="@artist@" -T album="@album@" -T totaltracks="@numtracks@" -T date="@year@" -T genre="@genre@" -T comment="Ripped with EAC/REACT" -T cuesheet="@@cuesheet@" -T eaclog="@@eaclog@" "@source@" -o "@image@"
    move "@image@" "%dest%"
    copy "@cuesheet@" "%dest%"
    if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_flac_image


if not "@imageext@"=="wv" goto end_wavpack_image
    set dest=%Wavpack_ImageDir%
    if not exist "%dest%" mkdir "%dest%"
    @tools@\wavpack.exe %Wavpack_opt% -w artist="@artist@" -w album="@album@" -w totaltracks="@numtracks@" -w year="@year@" -w genre="@genre@" -w comment="Ripped with EAC/REACT" -w cuesheet="@@cuesheet@" -w eaclog="@@eaclog@" "@source@" "@image@"
    title REACT - "@album@"
    move "@image@" "%dest%"
    copy "@cuesheet@" "%dest%"
    if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_wavpack_image

if not "@imageext@"=="mp3" goto end_mp3_image
    set dest=%MP3_ImageDir%
    if not exist "%dest%" mkdir "%dest%"
    @tools@\lame.exe %LameMP3_opt% "@source@" "@image@"
    @tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% --artist "@artist@" --album "@album@" --track @numtracks@ --year "@year@" --genre "@genre@" --comment "Ripped with EAC/REACT" --frame TPE2:"@cdartist@" --frame TENC:"%USERNAME%" --frame TSSE:"LAME %LameMP3_ver% %LameMP3_opt%" "@image@"
    move "@image@" "%dest%"
    copy "@cuesheet@" "%dest%"
    if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_mp3_image

   

REM ---- Tracks ----


if %Flac%==0 goto end_flac_tracks
    set dest=%Flac_TrackDir%
    @tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.flac" --pipe "title $n/$N flac $#T & @tools@\flac.exe %Flac_opt% -T artist=$#a -T album=$#T -T title=$#t -T tracknumber=$n/$N -T date=$q@year@$q -T genre=$q@genre@$q -T comment=$qRipped with EAC/REACT$q - -o $#o" "@sourcecuesheet@"
    if %add_meta%==1 (
        pushd "%dest%"
        @tools@\Glob.exe -v -c @tools@\metaflac.exe %MetaFlac_RG% %MetaFlac_cover% *.flac
        popd
    )
    copy "@eaclog@" "%dest%\EAClog.txt"
    if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
    if exist "@albumfile@.[*].cue" copy "@albumfile@.[*].cue" "%dest%"
:end_flac_tracks


if %Wavpack%==0 goto end_wavpack_tracks
    set dest=%Wavpack_TrackDir%
    @tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.wv" --pipe "@tools@\wavpack.exe %Wavpack_opt% -w artist=$#a -w album=$#T -w title=$#t -w track=$n/$N -w year=$q@year@$q -w genre=$q@genre@$q -w comment=$qRipped with EAC/REACT$q - $#o" "@sourcecuesheet@"
    if %ReplayGain%==1 (
        pushd "%dest%"
        @tools@\wvgain.exe -a *.wv
        popd
    )
    title REACT - "@album@"
    copy "@eaclog@" "%dest%\EAClog.txt"
    if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
    if exist "@albumfile@.[*].cue" copy "@albumfile@.[*].cue" "%dest%"
:end_wavpack_tracks


if %LameMP3%==0 goto end_mp3_tracks
    set dest=%MP3_TrackDir%
    @tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.mp3" --pipe "title $n/$N mp3 $#T & @tools@\lame.exe %LameMP3_opt% - $#o & @tools@\metamp3.exe --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $qRipped with EAC/REACT$q --frame TPE2:"%AlbumArtist%" --frame TENC:"LAME %LameMP3_ver%" --frame TSSE:$qLAME %LameMP3_ver% %LameMP3_opt%$q $#o" "@sourcecuesheet@"
    if %add_meta%==1 (
        pushd "%dest%"
        @tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% *.mp3
        popd
    )
    REM copy "@eaclog@" "%dest%\EAClog.txt"
    REM if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
:end_mp3_tracks


if %NeroAac%==0 goto end_aac_tracks
    set dest=%AAC_TrackDir%
    @tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.m4a" --pipe "title $n/$N aac $#T & @tools@\neroAacEnc.exe %NeroAac_opt% -if - -of $#o & @tools@\neroAacTag.exe $#o %AacTag_cover_acdir% -meta:artist=$#a -meta:album=$#T -meta:title=$#t -meta:track=$n -meta:totaltracks=$N -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$qRipped with EAC/REACT$q" "@sourcecuesheet@"
    if %add_rg%==1 (   
        pushd "%dest%"
        @tools@\aacgain.exe %AacGain_RG% *.m4a > gainlog.txt
        popd
    )
    REM copy "@eaclog@" "%dest%\EAClog.txt"
    REM if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
:end_aac_tracks


if %OggEnc2%==0 goto end_ogg_tracks
    set dest=%OGG_TrackDir%
    @tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.ogg" --pipe "title $n/$N ogg $#T & @tools@\oggenc2.exe %OggEnc2_opt% -c artist=$#a -c album=$#T -c title=$#t -c tracknumber=$n/$N -c date=$q@year@$q -c genre=$q@genre@$q -c comment=$qRipped with EAC/REACT$q - -o $#o" "@sourcecuesheet@"
    if %ReplayGain%==1 (
        pushd "%dest%"
        @tools@\vorbisgain.exe -a *.ogg
        popd
    )
    REM copy "@eaclog@" "%dest%\EAClog.txt"
    REM if %add_cover%==1 copy "@cover@" "%dest%\folder.jpg"
:end_ogg_tracks


REM ================ END MAIN SCRIPT ===================

if %Debug%==1 (
    pause
    REM exit
)

rem ** Cleanup

del "@source@"
del "@eaclog@"
del "@cuesheet@"
del "@albumfile@.[*].cue"
del "@cover@"

rem ** Delete this .bat file:
del %0

How do I put scroll bars and a title in the code section above?

[!--sizeo:1--][span style=\"font-size:8pt;line-height:100%\"][!--/sizeo--]Moderation: CODE to CODEBOX[/size]
Title: REACT 2 Released
Post by: wolfsong on 2006-11-25 05:42:12
How do I put scroll bars and a title in the code section above?
Change code to codebox. Not sure about title.
Code: [Select]
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Here's an example
Title: REACT 2 Released
Post by: wolfsong on 2006-11-25 06:57:21
Thanks for all the great feedback. I have uploaded a new beta:
beta 2:
  • Sets either "album" or "album artist" tag on images, depending on @various@ (thx drbeachboy and synthetic soul)
  • Adds "album artist" tag to track files on various-artists albums (in addition to artist).
  • Using new variable %AlbumArtist%. Default to "Album Artist" for various-artists albums.

I noticed that my Album Artist was not showing tagged in F2K but looking at the config, this is actually being tagged to the TPE2 frame which is the BAND (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:ID3_Tag_Mapping) field. Any way to write this to the ALBUM ARTIST field instead?

Also, an old problem has returned. It seems multi-work genres (i.e. Acid Jazz) cause REACT to stop processiong. The batch file is created after extraction (image-config) but REACT stops at this point.
Title: REACT 2 Released
Post by: Martin H on 2006-11-26 17:10:05
@tycho

1. Would you please add an option for adding AG REM comments into the embedded cuesheet(i don't want them in the tags) ?

2. Is it possible to start the script(F10) without the Coverdownloader starting(i don't wan't covers) ?

3. Can i still use '--scale' to get AG scaled MP3 track files together with an WV image(instead of just adding RG tags to the MP3 track files) ?

I haven't tried this version yet, and is sticking to v1.0 as the above questions concerns me, but i really hope that i will be able to use the new version instead at a later time...

Thank's in advance

Martin.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-26 17:59:01
2. Is it possible to start the script(F10) without the Coverdownloader starting(i don't wan't covers) ?

Change RunCoverDowloader to 0 in REACT.ini
3. Can i still use '--scale' to get AG scaled MP3 track files together with an WV image(instead of just adding RG tags to the MP3 track files) ?

I used scale before too but honestly don't know what the difference is between scale and the ApplyMp3AacAlbumGain setting.
Title: REACT 2 Released
Post by: tycho on 2006-11-26 21:48:58
Again, Thanks for all feedback.

@sdgenxr: You must set the ImageExt=flac in the REACT.ini file. The set Flac=1 in the REACT-image.cfg file is for tracks.  In the 2.0 final version, all normal user configuration is moved to the REACT.ini file, so regular user will only need to modify the REACT.ini file.

@wolfsong: The BAND field is very often interpreted as Artist Album, e.g. by Winamp. However, I guess foobar uses a TXXX frame for album artist. You may add (or replace) a TXXX frame in the mp3 tracks section:
Code: [Select]
IF @various@==1 SET VA_tag_MP3=--frame TPE2:$q$cdartist$$q --user-text $q[album artist]@cdartist@$q

I suppose I could add this in the final release.

The multi-word genre problem you mention surprises me. I have just tested a "Acid Jazz" CD with and all formats, and it worked fine. (Image mode F10).

@Martin H:
1) There is no internal support for adding Album Gain REM comments. It is however possible to do this with some advanced DOS scripting. To outline how:
Code: [Select]
WaveGain.exe -a "@source@" -e echo '%%ALBUM_GAIN%%'%%ALBUM_PEAK%%'%%ALBUM_SCALE%%'> tmp1.txt

FOR /F "tokens=1-6 delims='" %%i IN (tmp1.txt) DO (
    echo REM REPLAYGAIN_ALBUM_GAIN %%j dB> tmp2.txt
    echo REM REPLAYGAIN_ALBUM_PEAK %%k>> tmp2.txt
    SET album_scale=%%l
)
TYPE @cuesheet@ >> tmp2.txt
MOVE /Y tmp2.txt @cuesheet@
DEL tmp1.txt

And later when you encode with lame or oggenc2, you may use --scale %album_scale%

Note: The %ALBUM_PEAK% and other *_PEAK variables accessible in the WaveGain line  should be divided by 32767 to normalize them to 0.0 - 1.0 range.  If you notify john33 about it, he may fix that for next WaveGain release.

@wolfsong: Using --scale when encoding will apply volume to exactly 89 dB, whereas using aacgain or metamp3 after encoding will result in 89 +- 0.75 dB. However it allows to losslessy undo volume changes made, unlike when using --scale. Also, for AAC, you must resort to aacgain, because there is no --scale option for the encoder.

edit: formatting.
Title: REACT 2 Released
Post by: Martin H on 2006-11-26 22:31:32
@wolfsong

Thank's for your reply 

Btw, the reason i prefer the '--scale' method rather than just adding RG tags to the MP3 track files or using MP3Gain, is that it is more space effecient, as the files will be about 10% smaller on new music, when lowering the loudness before initiating the encoding process + the MP3 track files will playback as album gained in non-RG aware players also, just like if MP3Gain had been used.

@tycho

Thank you very much for your reply, and i appreciate that you have outlined a working solution for me

Thank's again mates

Martin.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-27 00:08:10
@wolfsong: The BAND field is very often interpreted as Artist Album, e.g. by Winamp. However, I guess foobar uses a TXXX frame for album artist. You may add (or replace) a TXXX frame in the mp3 tracks section:
Code: [Select]
IF @various@==1 SET VA_tag_MP3=--frame TPE2:$q$cdartist$$q --user-text $q[album artist]@cdartist@$q

I suppose I could add this in the final release.

Hmm. I can't really "read" this but from what you've said it should write a custom "album artist" tag. Just to clarify does it set the album artist to the @cdartist@ when not various and Various Artists when it is?

Right now I have the 2 lines remarked that set AlbumArtist. Should I unremark them?

The multi-word genre problem you mention surprises me. I have just tested a "Acid Jazz" CD with and all formats, and it worked fine. (Image mode F10).

I retested on another PC. I was having some other problems and it looks like this was caused by a conflict with other software. Thanks.
Title: REACT 2 Released
Post by: tycho on 2006-11-27 08:39:55

@wolfsong: The BAND field is very often interpreted as Artist Album, e.g. by Winamp. However, I guess foobar uses a TXXX frame for album artist. You may add (or replace) a TXXX frame in the mp3 tracks section:
Code: [Select]
IF @various@==1 SET VA_tag_MP3=--frame TPE2:$q$cdartist$$q --user-text $q[album artist]@cdartist@$q

I suppose I could add this in the final release.

Hmm. I can't really "read" this but from what you've said it should write a custom "album artist" tag. Just to clarify does it set the album artist to the @cdartist@ when not various and Various Artists when it is?

Right now I have the 2 lines remarked that set AlbumArtist. Should I unremark them?

The line sets both the BAND and a custom user text field with "album artists" as description to "Various", when and only when the CD is Various Artists. The v2.0 Final adds a key VA in the REACT.ini file (default VA=Various Artists). This will be the value of @cdartist@ for VA albums, otherwise @cdartist@ equals @artist@. I.e. you won't need the "set AlbumArtist" lines in the final release, but for now I believe you will.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-27 14:07:05
The line sets both the BAND and a custom user text field with "album artists" as description to "Various", when and only when the CD is Various Artists. The v2.0 Final adds a key VA in the REACT.ini file (default VA=Various Artists). This will be the value of @cdartist@ for VA albums, otherwise @cdartist@ equals @artist@. I.e. you won't need the "set AlbumArtist" lines in the final release, but for now I believe you will.

If I don't want BAND set do I just remove VA_tag_MP3=--frame TPE2:$q$cdartist$$q? I only want to use this field for classical recordings and would prefer it be blank for nonclassical for query purposes. Thanks.
Title: REACT 2 Released
Post by: tycho on 2006-11-27 14:23:04
Correct.
Title: REACT 2 Released
Post by: mogorp on 2006-11-27 20:15:02
I have found React 2 to work flawlessly.  I just have a couple of questions.  Just for background, I am encoding flac and Lame tracks. 

1. Can you explain the default settings for replay gain int the tracks config.  I am pretty sure that album replay gain is applied.  Is this correct?  Is the gain adjusted +3db and what is the advantage of doing this?

2.  When I looked at my flac files with foobar the cover art was present.  I did not see cover art when playing mp3 files with foobar.  I added a section to copy the cover art to my mp3/artist/album folder (see below).  Is this necessary?  Why was cover art not present orginally?  Thanks for your hard work. This really makes ripping and multiformat encoding much easier. 

Code: [Select]
if %LameMP3%==1 (
pushd "%MP3_TrackDir%"
copy "@eaclog@" "EAClog.txt"
if %add_meta%==1 @tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% *.mp3
if %add_cover%==1 copy "@cover@" "folder.jpg"
popd
Title: REACT 2 Released
Post by: wolfsong on 2006-11-27 20:20:28
2.  When I looked at my flac files with foobar the cover art was present.  I did not see cover art when playing mp3 files with foobar.  I added a section to copy the cover art to my mp3/artist/album folder (see below).  Is this necessary?  Why was cover art not present orginally?  Thanks for your hard work. This really makes ripping and multiformat encoding much easier. 

Code: [Select]
if %LameMP3%==1 (
pushd "%MP3_TrackDir%"
copy "@eaclog@" "EAClog.txt"
if %add_meta%==1 @tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% *.mp3
if %add_cover%==1 copy "@cover@" "folder.jpg"
popd
foo_uie_albumart does not support embedded album art which is what the default REACT settings provide. What you have now should embed an image and copy folder.jpg to the album's directory.
Title: REACT 2 Released
Post by: tycho on 2006-11-28 06:37:33
Quote
1. Can you explain the default settings for replay gain int the tracks config. I am pretty sure that album replay gain is applied. Is this correct? Is the gain adjusted +3db and what is the advantage of doing this?

Yes, on MP3's and M4A's, album gain is *applied*, and adjusted by +3dB to 93dB. I do this because it gives a consistent loudness between the albums. The +3dB is done because it increases the volume of my iPod a little, so I don't have to put the volume near max. Setting volme to (near) max, increases noise and distortions.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-28 14:30:07
I keep running into issues and I think it's some conflicting app but haven't figured out which one. This time around I was ripping Ottmar Liebert's "Poets & Angels". Debug showed that it couldn't create the album directory, apparently because of the ampersand. I don't recall having this probelm before.

Also, with both computers, I'm getting duplicate comments.

Lastly, on the "good" PC
Code: [Select]
IF @various@==1 SET --user-text $q[album artist]@cdartist@$q

doesn't set the Album Artist field at all.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-28 15:38:51
Lastly, on the "good" PC
Code: [Select]
IF @various@==1 SET --user-text $q[album artist]@cdartist@$q

doesn't set the Album Artist field at all.
I haven't really been following all this, but the above looks horribly wrong.  I think you are after something like:

Code: [Select]
IF @various@==1 SET userText=--user-text $q[album artist]@cdartist@$q
...
FLAC.EXE ... %userText% ...

This will include --user-text $q[album artist]@cdartist@$q in your FLAC command line, only if the album is VA.
Title: REACT 2 Released
Post by: tycho on 2006-11-28 15:47:33
Lastly, on the "good" PC
Code: [Select]
IF @various@==1 SET --user-text $q[album artist]@cdartist@$q

doesn't set the Album Artist field at all.
I haven't really been following all this, but the above looks horribly wrong.  I think you are after something like:

Code: [Select]
IF @various@==1 SET userText=--user-text $q[album artist]@cdartist@$q
...
FLAC.EXE ... %userText% ...

This will include --user-text $q[album artist]@cdartist@$q in your FLAC command line, only if the album is VA.


Yes, that is part of the problem. However because there are no real quotes (") around the artist name (only $q), the '&' is taken to be DOS command separator, and it is therefore failing. I will try to release the final version without these problems. I've just  added the WaveGain + --scale features that martin H requested, so it should not be too far away.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-28 16:52:34
Lastly, on the "good" PC
Code: [Select]
IF @various@==1 SET --user-text $q[album artist]@cdartist@$q

doesn't set the Album Artist field at all.
I haven't really been following all this, but the above looks horribly wrong.  I think you are after something like:

Code: [Select]
IF @various@==1 SET userText=--user-text $q[album artist]@cdartist@$q
...
FLAC.EXE ... %userText% ...

This will include --user-text $q[album artist]@cdartist@$q in your FLAC command line, only if the album is VA.

I'm only doing MP3s with image.cfg (to get AG & TG).
Yes, that is part of the problem. However because there are no real quotes (") around the artist name (only $q), the '&' is taken to be DOS command separator, and it is therefore failing. I will try to release the final version without these problems. I've just  added the WaveGain + --scale features that martin H requested, so it should not be too far away.

Except this is the ALBUM field, not the ARTIST.

I may have found one more quirk. I have an AutoPlaylist to check for tracks missing TG (AG is assumed) and 2 tracks ripped with REACT 2 show up. Both are initials are just initials, S.O.S. and V.F.D.
Title: REACT 2 Released
Post by: Martin H on 2006-11-29 14:13:09
[...] I've just  added the WaveGain + --scale features that martin H requested [...]

Thank you very much tycho  I really appreciate it

CU, Martin.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-29 14:26:13
I'm only doing MP3s with image.cfg (to get AG & TG).
OK, sorry, I'm not familiar with the configs yet (no time to rip CDs).

The basic idea is that you use the line:

Code: [Select]
IF @various@==1 SET userText=--user-text $q[album artist]@cdartist@$q

.. and then add %userText% to whatever command line you are running, where the switch should appear (if relevant).

I guess this relies on tycho's amends to cope with command symbols, like ampersand, outside of quotes.
Title: REACT 2 Released
Post by: wolfsong on 2006-11-30 19:26:06
The basic idea is that you use the line:

Code: [Select]
IF @various@==1 SET userText=--user-text $q[album artist]@cdartist@$q

.. and then add %userText% to whatever command line you are running, where the switch should appear (if relevant).

I guess this relies on tycho's amends to cope with command symbols, like ampersand, outside of quotes.

I was hoping I could do something like
Code: [Select]
SET userText=--user-text $q[album artist]%AlbumArtist%$q

since AlbumArtist is set at the beginning of the config with
Code: [Select]
if @various@==0 set AlbumArtist=$cdartist$
if @various@==1 set AlbumArtist=Various Artists

but it doesn't seem to work.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-11-30 20:12:30
It should work, unless your variable AlbumArtist contains a command symbol (like "&") as previously discussed.

Code: [Select]
SET var1=fghij
SET var2=abcde%var1%klmno
ECHO %var2%

... should result in:

abcdefghijklmno
Title: REACT 2 Released
Post by: wolfsong on 2006-11-30 23:58:57
It should work, unless your variable AlbumArtist contains a command symbol (like "&") as previously discussed.

Code: [Select]
SET var1=fghij
SET var2=abcde%var1%klmno
ECHO %var2%

... should result in:

abcdefghijklmno

The ampersand problem was in the ALBUM not ARTIST. I tested this with a compilation and it didn't work for me. I'm a bit confused about the variables since cdartist uses @ and AlbumArtist uses % but not where it's being set.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-01 09:09:52
I'm a bit confused about the variables since cdartist uses @ and AlbumArtist uses % but not where it's being set.
The @ parts are REACT's.  They're more tokens, or placeholders, than variables.  Those tokens are replaced by actual values before your config even runs.

The % variables are true DOS variables.  In DOS you use SET myvar=x to set a variable, and %myvar% to retrieve the value of the variable.  You need to use these DOS variables in your config to execute conditionally, whereas the @ REACT tokens will only ever return the value that REACT sets for them.

Without seeing your whole config, and even then perhaps, I can't tell you why your code is not working.  I provided the code above to prove to you that the concept is correct.  If you save the following code as a bat file and double click it you will see it in action:

Code: [Select]
@ECHO OFF
SET AlbumArtist=Test Artist
SET userText=--user-text $q[album artist]%AlbumArtist%$q
ECHO %userText%
ECHO.
PAUSE

With this in mind something else must be adversely affecting your config.
Title: REACT 2 Released
Post by: wolfsong on 2006-12-01 16:12:49
If you save the following code as a bat file and double click it you will see it in action:

Code: [Select]
@ECHO OFF
SET AlbumArtist=Test Artist
SET userText=--user-text $q[album artist]%AlbumArtist%$q
ECHO %userText%
ECHO.
PAUSE
With this in mind something else must be adversely affecting your config.
This works as expected so I assume it's a config problem. Here's the entire config just in case.

Code: [Select]
@echo off
chcp 1252
title REACT - "@album@"


REM ================== USER SETTINGS ======================


rem ** To archive a CD as one large "image", you must set
rem ** ImageExt=... in the REACT.ini file (Press Alt-F2).
rem ** This will set the @imageext@ variable. Extensions
rem ** currently supported:  flac, wv, mp3. Set to 'wav'
rem ** for no image archiving (default).

REM ---- Enable/disable additional track formats:

rem ** Splits the wav-image into tracks during encoding, using ACDIR.
rem ** Flac requires flac.exe/metaflac.exe (v1.1.3)
rem ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
rem ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.

set Flac=0
set Wavpack=0
set LameMP3=1
set NeroAac=0
set OggEnc2=0

REM ---- General settings ----

set Debug=0

rem ** I prefer applying album gain 92dB to get a reasonable
rem ** volume for my DAP. The RG tags are still relative
rem ** to 89dB SPL, i.e. album gain will be about -3.0dB.

set ReplayGain=1
set ApplyMp3AacAlbumGain=1
set AdjustMp3AacAlbumGain_dB=+0.0

REM ---- Encoder options ----

set Flac_opt=-5 -f
set Wavpack_opt=-hmy
set LameMP3_opt=-V4 --vbr-new --noreplaygain --nohist
rem ** Nero LC-AAC @ ~ 90kbps - great for e.g. iPods:
set NeroAac_opt=-lc -q 0.22
set OggEnc2_opt=-q 3.0

set Flac_ver=1.1.3b2
set LameMP3_ver=3.97
set NeroAac_ver=1.0.0.2

REM ---- Output directories and track names ----

set OutRoot=H:\TAGZ

if @various@==0 set AlbumArtist=$cdartist$
if @various@==1 set AlbumArtist=Various Artists

rem ** Image dirs:
set Flac_ImageDir=%OutRoot%\Flac-Images\%AlbumArtist%
set Wavpack_ImageDir=%OutRoot%\Wavpack-Images\%AlbumArtist%
set MP3_ImageDir=%OutRoot%\MP3-Images\%AlbumArtist%

rem ** Track dirs:
set Flac_TrackDir=%OutRoot%\Flac\%AlbumArtist%\[$year$] $album$
set Wavpack_TrackDir=%OutRoot%\Wavpack\%AlbumArtist%\[$year$] $album$
REM set MP3_TrackDir=%OutRoot%\MP3\%AlbumArtist%\[$year$] $album$
set AAC_TrackDir=%OutRoot%\AAC\%AlbumArtist%\[$year$] $album$
set OGG_TrackDir=%OutRoot%\OGG\%AlbumArtist%\[$year$] $album$

REM set ** MP3_TrackDir
IF @various@==1 GOTO Various
REM CD is not VA
SET MP3_TrackDir=%OutRoot%\$cdartist$\$album$
GOTO Complete
:Various
IF @genre@==Soundtrack GOTO Soundtrack
REM CD is VA but not a soundtrack
SET MP3_TrackDir=%OutRoot%\Various Artists\Collections\$album$
GOTO Complete
:Soundtrack
REM CD is both VA and a soundtrack
SET MP3_TrackDir=%OutRoot%\Various Artists\Soundtracks\$album$
:Complete

rem ** Track names (for ACDIR):
if @various@==0 set TrackName=[$n] $~t
if @various@==1 set TrackName=[$n] $~t ($~a)


REM ============== BEGIN MAIN SCRIPT ==================


if %Debug%==1 echo on

set add_rg=%ReplayGain%
set add_meta=%add_rg%
set add_cover=0

if %ReplayGain%==0 goto end_RG
set Flac_RG=--replay-gain
set MetaFlac_RG=--add-replay-gain
set MetaMp3_RG=--replay-gain
:end_RG

if %ApplyMp3AacAlbumGain%==0 goto end_apply_AG
set AacGain_RG=/a /o /c /d %AdjustMp3AacAlbumGain_dB%
set MetaMP3_RG=--apply-gain album%AdjustMp3AacAlbumGain_dB%
set add_rg=1
set add_meta=1
:end_apply_AG

if not exist "@cover@" goto end_cover
set Flac_cover=--picture="|image/jpeg|||@cover@"
set MetaFlac_cover=--import-picture="|image/jpeg|||@cover@"
set MetaMP3_cover=--pict "{3}@cover@"
set AacTag_cover=-add-cover:front:"@cover@"
set add_cover=1
set add_meta=1
:end_cover

if @various@==0 (
set ArtistField=artist
set MP3ArtistField=TPE1
) else (
set ArtistField=album artist
set MP3ArtistField=TPE2
)


REM ---- Image ----


if not "@imageext@"=="flac" goto end_flac_image
set dest=%Flac_ImageDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\flac.exe %Flac_opt% %Flac_RG% %Flac_cover% -T "%ArtistField%=@cdartist@" -T "album=@album@" -T "totaltracks=@numtracks@" -T "date=@year@" -T "genre=@genre@" -T "comment=Ripped with EAC/REACT" -T encoded-by="%USERNAME%" --tag-from-file="cuesheet=@cuesheet@" --tag-from-file="eaclog=@eaclog@" "@source@" -o "@image@"
move "@image@" "%dest%"
copy "@cuesheet@" "%dest%"
if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_flac_image


if not "@imageext@"=="wv" goto end_wavpack_image
set dest=%Wavpack_ImageDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\wavpack.exe %Wavpack_opt% -w "%ArtistField%=@cdartist@" -w "album=@album@" -w "totaltracks=@numtracks@" -w "year=@year@" -w "genre=@genre@" -w "comment=Ripped with EAC/REACT" -w "cuesheet=@@cuesheet@" -w "eaclog=@@eaclog@" "@source@" "@image@"
if %ReplayGain%==1 @tools@\wvgain.exe -a "@image@"
title REACT - "@album@"
move "@image@" "%dest%"
copy "@cuesheet@" "%dest%"
if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_wavpack_image


if not "@imageext@"=="mp3" goto end_mp3_image
set dest=%MP3_ImageDir%
if not exist "%dest%" mkdir "%dest%"
@tools@\lame.exe %LameMP3_opt% "@source@" "@image@"
@tools@\metamp3.exe %MetaMP3_RG% %MetaMP3_cover% --frame %MP3ArtistField%:"@cdartist@" --album "@album@" --track @numtracks@ --year "@year@" --genre "@genre@" --comment "Ripped with EAC/REACT" --frame TENC:"%USERNAME%" --frame TSSE:"LAME %LameMP3_ver% %LameMP3_opt%" "@image@"
move "@image@" "%dest%"
copy "@cuesheet@" "%dest%"
if %add_cover%==1 copy "@cover@" "%dest%\@basename@.jpg"
:end_mp3_image



REM ---- Tracks ----


if %Flac%==0 goto end_flac_tracks
set dest=%Flac_TrackDir%
if @various@==1 set Flac_VA_tag=-T $qalbum artist=%AlbumArtist%$q
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.flac" --pipe "title $n/$N flac $#T & @tools@\flac.exe %Flac_opt% %Flac_VA_tag% -T artist=$#a -T album=$#T -T title=$#t -T tracknumber=$n/$N -T date=$q@year@$q -T genre=$q@genre@$q -T comment=$qRipped with EAC/REACT$q -T encoded-by=$q%USERNAME%$q - -o $#o" "@sourcecuesheet@"
pushd "%dest%"
if %add_meta%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %MetaFlac_RG% %MetaFlac_cover% *.flac
copy "@eaclog@" "EAClog.txt"
if %add_cover%==1 copy "@cover@" "folder.jpg"
if exist "@albumfile@.[*].cue" copy "@albumfile@.[*].cue" .
popd
:end_flac_tracks


if %Wavpack%==0 goto end_wavpack_tracks
set dest=%Wavpack_TrackDir%
if @various@==1 set Wavpack_VA_tag=-w $qalbum artist=%AlbumArtist%$q
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.wv" --pipe "@tools@\wavpack.exe %Wavpack_opt% %Wavpack_VA_tag% -w artist=$#a -w album=$#T -w title=$#t -w track=$n/$N -w year=$q@year@$q -w genre=$q@genre@$q -w comment=$qRipped with EAC/REACT$q - $#o" "@sourcecuesheet@"
pushd "%dest%"
if %ReplayGain%==1 @tools@\wvgain.exe -a *.wv
copy "@eaclog@" "EAClog.txt"
if %add_cover%==1 copy "@cover@" "folder.jpg"
if exist "@albumfile@.[*].cue" copy "@albumfile@.[*].cue" .
popd
title REACT - "@album@"
:end_wavpack_tracks


if %LameMP3%==0 goto end_mp3_tracks
set dest=%MP3_TrackDir%
REM if @various@==1 set MP3_VA_tag=--frame TPE2:$q%AlbumArtist%$q
SET userText=--user-text $q[album artist]%AlbumArtist%$q
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.mp3" --pipe "title $n/$N mp3 $#T & @tools@\lame.exe %LameMP3_opt% - $#o & @tools@\metamp3.exe %MP3_VA_tag% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $qRipped with EAC/REACT$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME %LameMP3_ver% %LameMP3_opt%$q $#o" "@sourcecuesheet@"
pushd "%dest%"
if %add_meta%==1 @tools@\metamp3.exe %MetaMP3_RG% *.mp3
REM copy "@eaclog@" "EAClog.txt"
if %add_cover%==1 copy "@cover@" "folder.jpg"
popd
:end_mp3_tracks


if %NeroAac%==0 goto end_aac_tracks
set dest=%AAC_TrackDir%
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.m4a" --pipe "title $n/$N aac $#T & @tools@\neroAacEnc.exe %NeroAac_opt% -if - -of $#o & @tools@\neroAacTag.exe $#o -meta:artist=$#a -meta:album=$#T -meta:title=$#t -meta:track=$n -meta:totaltracks=$N -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$qRipped with EAC/REACT$q" "@sourcecuesheet@"
pushd "%dest%"
if %add_cover%==1 for %%i in (*.m4a) do @tools@\neroAacTag.exe "%%i" %AacTag_cover%
if %add_rg%==1 @tools@\aacgain.exe %AacGain_RG% *.m4a > gainlog.txt
REM copy "@eaclog@" "EAClog.txt"
REM if %add_cover%==1 copy "@cover@" "folder.jpg"
popd
:end_aac_tracks


if %OggEnc2%==0 goto end_ogg_tracks
set dest=%OGG_TrackDir%
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.ogg" --pipe "title $n/$N ogg $#T & @tools@\oggenc2.exe %OggEnc2_opt% -c artist=$#a -c album=$#T -c title=$#t -c tracknumber=$n/$N -c date=$q@year@$q -c genre=$q@genre@$q -c comment=$qRipped with EAC/REACT$q -c encoded-by=$q%USERNAME%$q - -o $#o" "@sourcecuesheet@"
pushd "%dest%"
if %ReplayGain%==1 @tools@\vorbisgain.exe -a *.ogg
REM copy "@eaclog@" "EAClog.txt"
REM if %add_cover%==1 copy "@cover@" "folder.jpg"
popd
:end_ogg_tracks


REM ================ END MAIN SCRIPT ===================

if %Debug%==1 (
pause
REM exit
)

rem ** Cleanup

del "@source@"
del "@eaclog@"
del "@cuesheet@"
del "@albumfile@.[*].cue"
del "@cover@"

rem ** Delete this .bat file:
del %0

I just had a thought. Does --user-text need to be added to?
Code: [Select]
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.mp3" --pipe "title $n/$N mp3 $#T & @tools@\lame.exe %LameMP3_opt% - $#o & @tools@\metamp3.exe %MP3_VA_tag% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $qRipped with EAC/REACT$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME %LameMP3_ver% %LameMP3_opt%$q $#o" "@sourcecuesheet@"
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-01 18:17:15
I just had a thought. Does --user-text need to be added to?
...
Yes.

Also, on an unrelated note, on line 89 I think it should be:

Code: [Select]
if @various@==1 set TrackName=[$n] $~t ^($~a^)

... but I may be wrong.

I have still yet to actually use REACT 2, so I can't really advise on configs.
Title: REACT 2 Released
Post by: wolfsong on 2006-12-01 18:41:55
I just had a thought. Does --user-text need to be added to?
...
Yes.

Well adding it by itself doesn't work. In fact most of the tags are now blank. I guess it is expecting some sort of arguement like
Code: [Select]
--user-text $q[album artist]%AlbumArtist%$q

which seemingly makes the previous line:
Code: [Select]
SET userText=--user-text $q[album artist]%AlbumArtist%$q

unnecessary but I'm not really sure if that is correct or the syntax is right.
Also, on an unrelated note, on line 89 I think it should be:

Code: [Select]
if @various@==1 set TrackName=[$n] $~t ^($~a^)

... but I may be wrong.

I have still yet to actually use REACT 2, so I can't really advise on configs.

This part works fine actually.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-01 19:15:36
I'm sorry, I should have been more clear: you need to add %userText% to the command line.

Code: [Select]
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.mp3" --pipe "title $n/$N mp3 $#T & @tools@\lame.exe %LameMP3_opt% - $#o & @tools@\metamp3.exe %MP3_VA_tag% %userText% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $qRipped with EAC/REACT$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME %LameMP3_ver% %LameMP3_opt%$q $#o" "@sourcecuesheet@"

This part works fine actually.
Yes, on thinking about it, I think I had to do that previously as I had the line already in brackets.  Sorry for confusing the issue.
Title: REACT 2 Released
Post by: wolfsong on 2006-12-01 19:53:38
I'm sorry, I should have been more clear: you need to add %userText% to the command line.

Code: [Select]
@tools@\acdir.exe --overwrite --output "%dest%\%TrackName%.mp3" --pipe "title $n/$N mp3 $#T & @tools@\lame.exe %LameMP3_opt% - $#o & @tools@\metamp3.exe %MP3_VA_tag% %userText% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $qRipped with EAC/REACT$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME %LameMP3_ver% %LameMP3_opt%$q $#o" "@sourcecuesheet@"

YEAH! That worked. Thanks SS.
Title: REACT 2 Released
Post by: Dondo on 2006-12-01 20:02:24
Thanks Tycho for creating REACT. I'm finding it very useful! And thanks to Synthetic Soul for the tech help. What an improvement for Various Artist albums! Excellent.

I tried the previous version for the first time about a month ago, and worked my way through the forum threads until I had a basic understanding - and a good Test & Copy Flac tracks routine.
Now, with REACTv2, I've added AAC tracks to my Test & Copy Flac tracks. It's all working well, except for one minor thing - I'd like to save CRC values in the FLAC tags, but I'm not getting the code right.

Code: [Select]
if %Flac%==0 goto end_flac_tracks
    set dest=%Flac_TrackDir%
    if not exist "%dest%" mkdir "%dest%"
    if @various@==1 set Flac_VA_tag=-T "album artist=%AlbumArtist%"
    @tools@\flac.exe %Flac_opt% %Flac_VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="Ripped with EAC/REACT" -T CRC="%CRC%" "@source@" -o "%dest%\%TrackName%.flac"
:end_flac_tracks


I've probably missed something major.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-02 09:34:32
YEAH! That worked. Thanks SS.
No problem.  This is actually what I was referring to in post #57 when I suggested:

Code: [Select]
FLAC.EXE ... %userText% ...

... but I mistakingly used FLAC.EXE in the example assuming --user-text to be a FLAC switch, and not a METAMP3 switch.  Ah well, we got there in the end.

Code: [Select]
if %Flac%==0 goto end_flac_tracks
    set dest=%Flac_TrackDir%
    if not exist "%dest%" mkdir "%dest%"
    if @various@==1 set Flac_VA_tag=-T "album artist=%AlbumArtist%"
    @tools@\flac.exe %Flac_opt% %Flac_VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="Ripped with EAC/REACT" -T CRC="%CRC%" "@source@" -o "%dest%\%TrackName%.flac"
:end_flac_tracks
I think you want -T CRC="@crc@" and not -T CRC="%CRC%", unless you have set a DOS variable previously in your config.

Thanks for the thanks.
Title: REACT 2 Released
Post by: Dondo on 2006-12-02 21:53:57
I think you want -T CRC="@crc@" and not -T CRC="%CRC%", unless you have set a DOS variable previously in your config.


I was afraid it was something simple like that! It's working perfectly now, Thanks again.

I was having something odd happen last night - I would start ripping a CD by hitting F4 - EAC would begin checking for gaps, and the coverart downloader would start. Then EAC would just stop after finishing saving the cue sheets - no copying tracks.
I've rebooted and have not been able to re-produce the problem (not that I'm complaining!).
Has anybody else had this trouble?
Title: REACT 2 Released
Post by: SpiceWeasel on 2006-12-02 23:28:20
I've installed REACT 2 several times on Windows Vista Ultimate (final, not beta or RC) and I never get a REACT.ini file.  The other files seem to be there.  Hitting Alt-F2 gets me a "Cannot find the C:\Program Files\REACT2\React.ini file would you like to create it?" dialog.  I assume I can just get a copy from somebody else or create my own if somebody can post or PM me the text of the file, right?
Title: REACT 2 Released
Post by: wolfsong on 2006-12-02 23:48:35
I've installed REACT 2 several times on Windows Vista Ultimate (final, not beta or RC) and I never get a REACT.ini file.  The other files seem to be there.  Hitting Alt-F2 gets me a "Cannot find the C:\Program Files\REACT2\React.ini file would you like to create it?" dialog.  I assume I can just get a copy from somebody else or create my own if somebody can post or PM me the text of the file, right?

Are you starting EAC or REACT? When you run REACT it creates the INI file for you. You should always start with REACT going forward.
Title: REACT 2 Released
Post by: SpiceWeasel on 2006-12-03 19:14:43
Are you starting EAC or REACT? When you run REACT it creates the INI file for you. You should always start with REACT going forward.


Yep, I'm running REACT.exe from C:\Program Files\REACT2\
You have to right click the exe and select 'Run as administrator' to get it to create the ini.  Apparently react.exe isn't allowed to create files in the Program Files directory if it isn't run by an administrator.
Title: REACT 2 Released
Post by: FauDrei on 2006-12-03 23:44:29
Hi,

Perhaps this information will spare someone's nerves and time. I've certainly spent a lot of both on this...

Watch out for the dots at the end of the album (or artist) name. When using REACT in track mode on album called f.e. "The Very Best of...", nothing will be converted.

Reason?

You can not have directory names which end with dots (most probably because of . and .. being current and parent directory).

In mentioned case ("The Very Best of..."), the directory will be created but without the dots f.e. "Q:\MUSiC\WiP\Wavpack\Mike Oldfield\[1996] The Very Best of\". Encoder will then fail to create output file because it will try to write to f.e. "Q:\MUSiC\WiP\Wavpack\Mike Oldfield\[1996] The Very Best of...\01 - Sentinel.wv".

Obvious way to solve the problem is to remove ending dots from album (or artist's) name, but this is not the flexible nor elegant way of doing it...

Possible solution could be to use pushd/popd before/after invoking encoder, and invoking encoder with just the filename.

...and BTW, nice tool - keep up the good work



            V3
Title: REACT 2 Released
Post by: Mangix on 2006-12-04 02:59:47
You can not have directory names which end with dots (most probably because of . and .. being current and parent directory).

you're right. however, i just tried mkdir(with cmd.exe) and when i tried to make a directory with the name "blahblah...", it made a directory named "blahblah". must have something to do with the way REACT or EAC writes directories.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-04 10:35:06
It's down to how Windows creates directories.

REACT is setting the directory name as "<something>..." but when it tells Windows to create this folder Windows creates "<something>".

You can test this yourself by just trying to create a new folder using Explorer.

Knowing that Windows cannot create a folder with 1-n full stops (periods) at the end I think REACT may have to check and amend its variable accordingly.

E.g.:

Code: [Select]
Func fRemoveTrailingPeriods($strText)
    Return StringRegExpReplace($strText, "^(.*?)\.+$", "\1")
EndFunc
Title: REACT 2 Released
Post by: tycho on 2006-12-05 08:27:17
Thanks for making me aware of this. Release 2.0 will add a fix. Unfortunately, I had no time for doing development on this last week, but hopefully within a week it should be ready. @soul: I'm still using AutoIt 3.1.1, and regex are not included there. I'll just remove any trailing dots. Edit: I'll enclose any trailing dots with []. E.g. "The Very Best Of..." becomes "The Very Best Of[...]"
As an observation, folders and files with leading dots are possible to create from a command shell, however explorer does not allow you to create them at all!
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-05 09:20:01
Slightly OT, but, I had to upgrade to 3.2.1.10 (beta) as AVG anti-virus started complaining about AutoItSC.bin in the previous version!  Whenever I tried compiling a script it would hassle me to death.
Title: REACT 2 Released
Post by: bhoar on 2006-12-05 18:05:30
Slightly OT, but, I had to upgrade to 3.2.1.10 (beta) as AVG anti-virus started complaining about AutoItSC.bin in the previous version!  Whenever I tried compiling a script it would hassle me to death.


From what I've read, a significant number of malware apps are based on the AutoIT core executable, so I don't think the false positive issue will ever be solved.

-brendan
Title: REACT 2 Released
Post by: schnittlich on 2006-12-06 00:30:55
Just started using REACT 2 (been using the older version for quite some time) and have a question:

In the previous version, I was able to run multiple sessions simultaneously.  To be more specific, my computer has 4 Plextor Premium drives that I use for extraction.  I have 4 instances of EAC running, in the past, have been able to have it all going at one time.  With the new version, only 1 REACT command window seems to be able to open at a time.  If the compression routine is running, I cannot seem to get another running, it just never opens up.

Any thoughts?

Thanks again for this GREAT software…

brett
Title: REACT 2 Released
Post by: awnm on 2006-12-10 11:29:27
Thanks for the new version - it's great. The new format (single config file) makes it much easier.
This time around I was ripping Ottmar Liebert's "Poets & Angels". Debug showed that it couldn't create the album directory, apparently because of the ampersand. I don't recall having this probelm before.
I am having the same problem - tried to rip "The Songs Of Tim & Neil Finn" and the directory created was "The Songs Of Tim ". React2 then failed when trying to put the MP3's in the directory, as it was expecting the full name. When I changed the album name to "...Tim And Neil..." it worked fine.
Title: REACT 2 Released
Post by: tycho on 2006-12-11 12:35:28
schnittlich: I can't see why this version should be different than v1.0 in this respect. It should still support multiple instances (although I haven't tested myself). Please retest and report.

awnm: Version 2.0 final is ready, and does not have this problem. I will release it as soon as I have updated the REACT wiki documentation.
Title: REACT 2 Released
Post by: phaedra on 2006-12-11 23:31:20
... I will release it as soon as I have updated the REACT wiki documentation.


The links at the bottom of the wiki page should be updated (they still point to the download & discussion pages for v1.0).
Title: REACT 2 Released
Post by: Meddler on 2006-12-12 03:28:28
First of all let me say thank you tycho.

I've tried using REACT in the past with little success, in fact only yesterday I was pulling my hair out with my track based rips (whole album encoded as one track with the name of track 2)

Then lo and behold a new version today, which quite simply worked.

Perfect rip & encode + replay gain etc.

Just two questions if I may:

Thanks again.
Title: REACT 2 Released
Post by: tycho on 2006-12-12 09:28:12
Meddler: You're welcome.

1) metamp3/mp3gain and foobar has different implementations.  I think there will be no audible loudness differences.

2) metamp3 is similar to mp3gain, but writes ID3v2 tags instead of APEv2. REACT applies albumgain by default, and adjusts it by 3dB to 92dB, so that it can be played back on every DAP with consistent (and sufficient) loudness. The UNDO tag is there so that you may undo the gain applied with metamp3 --undo-gain <files>.

Edit: You will notice that all your mp3's will get album gain of about -3.0dB (relative to 89) because of the default settings.

If you don't want to apply album gain, set ApplyAlbumGain=0 in the REACT.ini file.
If you don't want replay gain tags at all, set ReplayGain=0 in the REACT.ini file.

phaedra: Thanks, I will update the wiki soon.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-12 10:46:56
Ooh.  I did it already.  I was reading the new wiki and noticed so I updated them.
Title: REACT 2 Released
Post by: drbeachboy on 2006-12-12 15:04:32
Hi tycho,

Would you please explain to me why these 2 lines are written the way they are? In the INI file, I had "UseWaveGainAG" set to 0 and "AddCuesheetAG" set to 1. Everytime I ran the program I couldn't figure out why WaveGain ran before FLAC was started to encode, until I saw the 2nd line below in REACT-image.cfg. Why is run_wavegain set to 1 when AddCuesheetAG is set to 1? Is there a correlation?

SET run_wavegain=@UseWaveGainAG@
IF @AddCuesheetAG@==1 SET run_wavegain=1


Thanks in advance for the explanation. And thank you again for REACT. :-)
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-12 15:09:19
If I understand correctly @AddCuesheetAG@ represents whether album gain values should be written to the cuesheet.

They can only be written if first calculated by WavGain.
Title: REACT 2 Released
Post by: tycho on 2006-12-12 15:37:24
Yep, because of limitations in DOS scripting language, the two lines simply says:

"IF @AddCuesheetAG@ = 1 OR @UseWaveGainAG@ = 1 THEN execute WaveGain."


The @UseWaveGainAG@ variable says if you want to transfer the WaveGain album gain values to the encoded files, rather than using metaflac, wvgain, metamp3, aacgain..., which takes a bit longer.
Title: REACT 2 Released
Post by: drbeachboy on 2006-12-12 17:04:39
tycho & SS,

Thank you for the explanations.
Title: REACT 2 Released
Post by: Meddler on 2006-12-12 22:15:04
1) metamp3/mp3gain and foobar has different implementations.  I think there will be no audible loudness differences.

2) metamp3 is similar to mp3gain, but writes ID3v2 tags instead of APEv2. REACT applies albumgain by default, and adjusts it by 3dB to 92dB, so that it can be played back on every DAP with consistent (and sufficient) loudness. The UNDO tag is there so that you may undo the gain applied with metamp3 --undo-gain <files>.

Edit: You will notice that all your mp3's will get album gain of about -3.0dB (relative to 89) because of the default settings.


Does this mean that ApplyAlbumGain "changes" the mp3 file as opposed to just tagging it? My DAP handles replaygain through tags anyway so I'd rather leave the files alone as much as possible.

Thank you for your swift response and your software, saved me a load of time writing a VB program
Title: REACT 2 Released
Post by: robwade on 2006-12-13 01:34:31
tycho,

Hello from a longtime enthusiast and first time poster -

First and foremost, thank you for developing REACT.  It's truly an early holiday gift!

Question/comment:  With regard to VA tagging, "TITLE" and "PERFORMER" appear REVERSED in the produced cue sheet (testing FLAC image and OGG tracks - REACT 2.0 FINAL).  The result of course is that these two fields tag "backwards" for both the FLAC image and OGG tracks.  Am I doing something obviously wrong?

No changes were made in config at all.  Note that non-VA discs tag perfectly.

Thanks in advance for your thoughts and comments.
Title: REACT 2 Released
Post by: Ahmet on 2006-12-13 09:14:28
Hi everyone,

First of all I have to express my appreciation to the author of this awesome tool. I have been using it just for couple of days and it does exactly what I need except one thing. And this is the reason I dare to ask you.

I installed REACT 2.0 final. Decoding into image and separate track works flawlesly but I am not able to set coverdownloader to work for me.  My idea is just to cpy the cover art into the specified folders with ripped image (tracks).

A found cover art using albumart.exe is always stored in C:\"album".jpg form while the REACT script expects to have it in "OutRoot"\"album".jpg. It means at the end that the album covers are not copied to the specified folders for my rips.

I have struggled with coverdownloader last night but for some reason the folder set for storing the dowloaded covers cannot be changed. Every time after manual change it is again reset back to C:\"album".jpg.  I do not know if it is a problem of albumart.exe or REACT.

Does enyone have the same problem ???

Thanks for any advice.
Title: REACT 2 Released
Post by: tycho on 2006-12-13 09:19:03
@Meddler: You are correct. ApplyAlbumGain should probably have been set to 0 by default. Note that 'ApplyAlbumGain' is only for lossy formats. FLAC and WAVPACK are always tagged only.

@robwade: Welcome to the forum. This is due to that some have registered the artist / title reversed in the freedb database. Try another VA disc, and you will probably get it right.

@Ahmet: Welcome to the forum. Set a fixed extraction directory by "Use directory ..." in the EAC options -> Directories. Set it to any direrectory, it is only a temporary directory for REACT. Restart EAC/REACT. Albumart.exe should now set its output path to this directory.
Title: REACT 2 Released
Post by: Ahmet on 2006-12-13 09:55:18
Thanks Tycho for your prompt answer!!

I knew it would be something so easy that would be embarassing to ask.

But, anyway, it might help to some other newbie like me:)
Title: REACT 2 Released
Post by: tycho on 2006-12-13 12:05:31
I've just found a small glitch in the REACT-image.cfg file, in the NeroAac section:

The line:
Code: [Select]
IF @ApplyAlbumGain@==1 @tools@\aacgain.exe %ApplyAG_AacGain% *.m4a > gainlog.txt

should be:
Code: [Select]
IF %add_rg%==1 @tools@\aacgain.exe %ApplyAG_AacGain% *.m4a > gainlog.txt


Without the fix, AAC files are RG scanned only when the album gain also is *applied* to the files.
Title: REACT 2 Released
Post by: Martin H on 2006-12-14 11:39:50
I would just like to say many thanks to the great one i.e. tycho  for adding not only WaveGain and --scale support, but also optional album gain REM comments into the embedded cuesheet

I can't thank you enough tycho and i really appreciate all the hard work that you have layed into this great tool.

Thanks again tycho, you are the man



CU, Martin.
Title: REACT 2 Released
Post by: tycho on 2006-12-14 21:51:18
Thank you, Martin. You have been a great supporter for this tool. I must say I'm pretty pleased with it myself now. I guess the only thing that would have made it even simpler for beginners is a GUI for the settings in the INI file. Would be fairly easy to do using AutoIt, but I'm afraid I won't find the time to program it.

Cheers.
Title: REACT 2 Released
Post by: Martin H on 2006-12-15 11:45:06
Thank you very much tycho  Yes, the app surely has increased it's newbie friendlieness alot in this release and although no GUI present, then the new setup system shouldn't be as intimidating to the new users as it probably was for many before.

Thank's again tycho

CU, Martin.
Title: REACT 2 Released
Post by: awnm on 2006-12-16 07:23:11
Can I add my thanks Tycho - REACT is a great tool and this new version is excellent. Adding custom frames and replaygain via your metamp3 is fantastic stuff.
Title: REACT 2 Released
Post by: Martin H on 2006-12-16 10:03:29
@tycho

I have actually just now for the first time set REACT v2.0 up on my system and i am having a problem unfortunetly. The problem is that when trying to run either your own metamp3.exe or wavegain.exe, then the CLI window just reports : "The system cannot execute the specified program". I'm running a newly installed Windows XP Pro. SP2 system with all post-SP2 hotfixes and security updates installed and i also have a "msvcr71.dll" file placed in the "tools" folder, as else acdir.exe will complain about it missing and i have also tried to place a "msvcr80.dll" file in the folder, but still without any luck. I'm pretty sure that it's just a matter of some missing dependency, but i don't know which one unfortunetly ?

Thank's in advance.

CU, Martin.

Edit: Sorry tycho  I haden't even seen your announcement thread for metaMP3 and when i found it, then it clearly said that it required the VC8 runtimes. First i just downloaded and copied the two files msvcr80.dll and msvcp80.dll into the "REACT2\tools" folder, but that didn't work. Then i tried with the official installer and deleted the files from the tools folder and then everything worked perfectly.

Sorry for wasting your time reading this tycho and again many thanks for this wonderfull timesaver

CU, Martin.
Title: REACT 2 Released
Post by: Martin H on 2006-12-17 15:17:07
Well, after having played around with this new REACT release for some ours now, as to get it setup exactly to my own preference, then i really have to say that this release is simply just absolutely fantastic  Thumbs up to tycho for doing such a very well done scripting job, to say the least  Also his app metamp3.exe is also a really great and needed invention IMHO and it's great that it e.g. has options for setting any TXXX frames to MP3s + doing RG scans and adding the RG tags as ID3v2 tags instead of APEv2 tags + also being able to list what precise frames a MP3 file has in it and also list the contents of the LAME info tag etc. etc. Just bloddy brilliant  Also the ability to bypass lame.exe's anouying ID3v2 genre problem, so we don't need that '--ignore-tag-errors' switch anymore and having to edit those 'Other' genres afterwards. Another thing that also just totally blew my mind, was the ability to add an 'Album Artist' tag to VA albums in addition to the standard 'Artist' tag and all is done fully automatic  Just absolutely brilliant  Thank's again tycho for this great release and also you don't need to respond to this post, but i just wanted to express my deepest gratitude for your absolutely fantastic work and not only that, but also for sharing it with the community for absolutely free  Thank's alot mate

Anyway, to others that make WV images + MP3 track files and like me only want's AG REM comments in the embedded cuesheets and not stored as extra tags in the lossless images or in the lossy track files, then the following changes needs to be done :

Add REM in front of line 43 :

REM SET add_rg=1

Add REM in front of line 179 : (i have adjustalbumgain_db set to 0, but nonetheless...)

REM IF @ApplyAlbumGain@==1 @tools@\metamp3.exe %ApplyAG_MetaMP3% *.mp3

Also, if not wanting an external cuesheet, then add REM in front of line 120 also :

REM MOVE /Y "@cuesheet@" %dest%

Also, if not wanting a "REM REPLAYGAIN_ALBUM_SCALE X.XXXX" line under the two "REM REPLAYGAIN_ALBUM_GAIN" and "REM REPLAYGAIN_ALBUM_PEAK" lines in the embedded cuesheet(something new in this release and wasen't made in v1.0), then also add REM in front of line 73 :

REM ECHO REM REPLAYGAIN_ALBUM_SCALE %album_scale%>> %wg_tmp%.cue

Finally, i change the "-w cuesheet=xxx" and -w "eaclog=xxx" under the WavPack image part of the script to instead : "-w CUESHEET=xxx" and -w "EACLOG=xxx", since that was the format used in REACT v1.0 and i want the new rips i make to be in the same format as the old ones made vith REACT v1.0.

The first "REM" line(line 43) i did several ripping runs to find, and then only after doing a debug run, then i saw the problem. I didn't saw it at first, since as i haden't enabled %replaygain% = 1, then i couldn't understand why the RG tags where still made...

Personally i have also edited the config to not add any other tags to the WV images except 'cuesheet' and 'eaclog' and for the MP3 track files, then i have only made it to include the standard ID3v1 tags i.e. artist,album,title,tracknumber(not xx/xx, but just x),year, genre and comment and i have changed the comment tag to show how much scalling had been done like this : "--comment $qAG applied: %album_gain% dB$q", which then shows :    "AG applied: -x.xx dB". Also i have added the "--fit" switch, as to only add ID3v2 tags in addition to the ID3v1 tags, when the fields are to big to fit in ID3v1 fields. Also if an album is a VA album, or if the genre is not on the standard LAME genre list, then an ID3v2 tag is also still made, even though the fields are maybe small enough to fit in ID3v1 tags, since the ID3v1 spec. dosen't allow any "Album Artist" tags, or adding the "Genre" tag as a text string, instead of just an index number.

Anyway, i just posted this post to first show my appreciation to tycho's great work and then also to list my own setup preferences, so as to maybe give some inspiration to others...

CU, Martin.
Title: REACT 2 Released
Post by: Martin H on 2006-12-20 16:12:32
I would just like to make a correction to my previous post.

I said that i had added the metamp3.exe "--fit" switch to my LAME track file command line, which would only make ID3v2 tags besides the ID3v1 tags, when the fields where to big to fit in ID3v1 tags. Still this is of course correct, but the problem then arises when ripping VA albums. I didn't catch it at first, since i nearly never rip VA albums myself and actually dosen't even own a single one of those albums, but just to test that part of the script out, then i decided to rip a normal CD as a VA album and that way i found out that the "--fit" switch will make it so that no "Album Artist" ID3v2 tag is made unfortunetly. So if one wants only ID3v2 tags when the fields are to big to fit in ID3v1 tags, but still also would like to have VA albums tagged with an "Album Artist" ID3v2 tag, then one should not add "--fit" to the metamp3.exe command line, but instead add e.g. "%Fit_tag%" to the metamp3.exe command line and then also at an earlier place in the script add this line also : "IF @various@==0 SET Fit_tag=--fit". I personally add that line right after this line : "IF @various@==1 SET VA_tag=--user-text $q[album artist]@VA@$q". Note, that this line used to have an extra switch that added a TPE2 ID3v2 frame besides the "Album Artist" TXXX frame, but as i only wanted the TXXX frame(as fb2k also makes when making an "Album Artist" tag) and not the TPE2 frame(which will show up in fb2k as "Band"), then i deleted that last switch i.e. "--frame "TPE2:@VA@"".

CU, Martin.

Edit: D***, that "--fit" switch is making me crazy  right after posting this thread, then i just thought off another potential problem with that switch, and sure enough, i have just tested it and it also was a problem there. What i'm reffering to is genre's wich dosen't fit the LAME genre list and hence, can't be written in an ID3v1 "Genre" tag with just an index number. I would have hoped that if using the "--fit" switch and a non-standard genre was used, then an ID3v2 tag would just be made, but unfortunetly, thats not the way that switch works and instead it just dosen't even add a genre tag . Hmm, not the end of the world, as genre tags aren't really that important to me personally, but it's just a little bit annoying, that's all

Also please note that this isn't tycho's fault, but only because of id3lib - the ID3v1/2 tagging library which metamp3.exe is statically linked against and uses that libraries functions for all it's ID3 tagging operations(instead of re-inventing the wheel ).

CU, Martin.

Edit2 : Well, i have thought about this issue some more and i must confess that i'm now actually pretty pleased about the functionality of that "--fit" switch after all  The reason for that is that i personally only wants to have ID3v1 tags on my MP3 track files and then only added ID3v2 tags also, whenever it is absolutely un-avoidable i.e. whenever a tag field is to big to fit in an ID3v1 tag field, or if the album is a VA album and hence, needs an "Album Artist" ID3v2 tag also. The problem about VA albums is now easilly overcome by instead of using the "--fit" switch directly, then instead adding a conditional variable holding the switch instead and then the final problem with that switch, was about non-standard genres, but come to think about it some more, then i would actually think that adding an ID3v2 tag just because of a non-standard genre is used, isn't very good anyway, and i actually like that it just ignores it instead, since i personally don't really care that much about "Genre" tags anyway and to me it is the least important one of the ones i use.

CU, Martin.
Title: REACT 2 Released
Post by: Martin H on 2006-12-22 10:03:24
First of all, i'm sorry for making so many posts after eachother and i promise that this will be the last one untill i get some feedback

@tycho or Synthetic Soul(or if there are any others which the same great amount of REACT knowledge )

Mates, i would be very happy if one of you guys would answer something for me. I have my "ImageNaming" variable set to "$artist$ - ($year$) $album$" and also the same folder structure for the MP3 track files. This is fine for standard albums and i like this naming-sceme very much because of the cronological sorting of an artists albums based on release year. Now the problem then arises when dealing with VA albums, since IMHO it dosen't make sence to sort VA albums cronologically by release year which the following example will show :

Various - (2001) Dance Hits Vol. 1.wv

Various - (2002) Summer Hits Vol. 1.wv

Various - (2003) Dance Hits Vol. 2.wv

Various - (2004) Summer Hits Vol. 2.wv

Now because of this bad sorting for VA albums, then i would like to have another "ImageNaming" variable which would be used for VA albums and it should look like this : "Various - $album$ ($year$)" and also the same for the folder of the MP3 track files.

I would then like to ask if there is an easy and elegant solution to doing this ?

I have actually allready made it to work, but i don't think that it's very elegant and i would like a better implementation. Also the way i do it, will make it so that the log file will still show the old naming scheme for the file name of the image that's ripped when ripping VA albums. This solution additionally requires Tangerines excelent little console app "cuemod.exe", since i need that to change the "FILE "FOO BAR.wv" WAVE" line in the cuesheet from the old naming-sceme to the new one for VA albums, before it gets embedded. If anyone else should be interested, then "cuemod.exe" can be downloaded here : http://tangerine.uw.hu/prog/cuemod_060406.rar (http://tangerine.uw.hu/prog/cuemod_060406.rar). 

Basically i have added these two lines right over the line of the wavpack.exe command line :

IF @various@==0 SET Image_path="D:\Musik\WV\$artist$ - ($year$) $album$"
IF @various@==1 SET Image_path="D:\Musik\WV\Various - $album$ ($year$)" & @tools@\cuemod.exe --cue "@cuesheet@" --f "Various - $album$ ($year$).wv"

Then for the actual wavpack.exe command line that follows, i have replaced the "@image@" at the end, with instead %Image_path%. Also i have added REM in front of the line that moves the image from the temp folder to the destination folder, as the changes i made encoded the image directly to the destination folder and not in the temp folder.

Then under the MP3 track file configuration, i have just added(besides the changes explained in my previous posts) : "IF @various@==1 SET dest="D:\Musik\MP3\Various - $album$ ($year$)"".

So again, if another more elegant solution is available, then i would love to hear about it, since allthough it dosen't really matter, then it annoyes me alittle that the log file shows the wrong file name when ripping VA albums i.e. the old naming scheme and also if i could get to skip the extra "cuemod.exe" step.

Thank's in advance.

CU, Martin.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-22 10:53:07
I am not familair with REACT 2 at all.  In fact I am currently having my first play with it as I type.

I've just read your last three posts and it seems to me that you have consistently solved your problems with good solutions.  Thanks for the --fit tip BTW; I've just added --fit to my command line, but will make the change that you suggest.

With regard to your latest post, I think yours is the only solution that a user can make.  To resolve your log file issue I think Tycho would have to add the ability to specify an alternate ImageDir for VA albums in the INI.

With regard to the tracks it may be possible that you could do:

Code: [Select]
TrackDir_MP3=@mymusic@
...
TrackName_SA=$artist$ - ($year$) $album$\$track$ - $title$
TrackName_VA=Various - $album$ ($year$)\$track$ - $title$ ($artist$)
TrackName_SA_acdir=$A - ($r{DATE}) $T\$n - $~t
TrackName_VA_acdir=Various - $T ($r{DATE})\$n - $~t ($~a)

Not sure though,  I haven't tested.  You may need to do something to ensure the folders are created (ACDIR will create folders IIRC, but REACT may not at this point).  I may test out of interest.

If you are really bothered about the log file and Tycho sees no reason to add a VA alternate my only other thought is using an app like SED to do a find and replace on the log file.

Edit:  I have just tested my track solution above and by golly I think it works!  No need to do anything else.  I think this is slightly more elegant than your solution, as it keeps user config in the INI, rather than having to adapt the cfg file, which I think is Tycho's intention.  Not sure though.  I'm still a little confused about REACT 2...
Title: REACT 2 Released
Post by: Martin H on 2006-12-22 11:26:46
Hi Synthetic Soul

Thank you very much for your reply - i really appreciate it  Also that MP3 track file ini modification you suggested is IMHO pure genious and indeed it's much better than my retarded way of doing it, so again many thanks for giving me that solution and for being so nice as to also test it out for me

Also i must say that i really appreciate your always helpfull attitude Synthetic Soul and i wish you a merry christmas together with your nice looking family  (as seen from the picture in your profile )

Cheers mate and best regards

CU, Martin.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-22 11:40:40
I don't think your solution was at all retarded.  Unfortunately some workarounds do have to be achieved in the cfg file.

Thank you very much for your kind words.  A very Merry Christmas to you also Martin, and to Tycho, and all REACT users!
Title: REACT 2 Released
Post by: Meddler on 2006-12-22 13:52:25
Code: [Select]
TrackDir_MP3=@mymusic@
...
TrackName_SA=$artist$ - ($year$) $album$\$track$ - $title$
TrackName_VA=Various - $album$ ($year$)\$track$ - $title$ ($artist$)
TrackName_SA_acdir=$A - ($r{DATE}) $T\$n - $~t
TrackName_VA_acdir=Various - $T ($r{DATE})\$n - $~t ($~a)

Not sure though,  I haven't tested.  You may need to do something to ensure the folders are created (ACDIR will create folders IIRC, but REACT may not at this point).  I may test out of interest.


Now that is excellent, I was gonna start hacking around to solve this and then I read this 

Wonderful, I don't need to play with the AU3 file which is what I feared
Title: REACT 2 Released
Post by: drbeachboy on 2006-12-23 16:33:01
Hi,

I need some help with changing from AtomicParsley to NeroAACTag in my REACT-image.cfg. I use foobar2000 to play my music and it apparently cannot read tags produced by AP. I've messed with this for hours and I cannot get it to work. I had NeroAACTag working fine with REACT 1, but so far unsucessful in React 2. Any help would be surely appreciated.

Merry Christmas & Happy Holidays!

Dirk
Title: REACT 2 Released
Post by: Martin H on 2006-12-23 19:50:21
I would just like to add that i haven't got any REACT problems anymore, since i have reconcidered my approach and have now changed my mind about my naming-sceme to instead use : "cdartist" - "album", since afterall, my only interface to the files is through fb2k, which i have setup as automatically sorting by year before album for SA albums and no year before album for VA albums. Also i have decided that i will not have RG comments in the cuesheets anymore, since i don't use the lossless images for playback, but only for archiving. Also i now use tycho's new fantastic tool metamp3.exe to analyze and add RG ID3v2 tags to the MP3 track files. I have just spend the last many ours to rename my current WV images and to extract the cuesheets and logfiles to change the filename + delete the RG REM comments, and then reembed them, and then i have deleted my current MP3 track file archive(-V2 --vbr-new), and transcoded all my WV images to MP3 track files(-V5 --vbr-new) + RG analyze and tag them afterwards. Now i'm completely satisfied with my new approach, and have ammended my REACT script to reflect this new system and now everything is absolutely perfect  (also my final adjustment was to disable fb2k's clipping prevention and add the Advanced Limiter DSP instead, so as to avoid clipping while still keeping the same relative loudness between albums, since the clipping prevention will scale down clipping tracks/albums i.e. lower the loudness).

CU, Martin.
Title: REACT 2 Released
Post by: ESP85 on 2006-12-24 00:13:58
Well I've tried React 2 and it works great but is there a way to set it up so it can encode two sets of mp3s?

I want one set using -V2 for listening on my computer and one set -V4 or -V5 for the car audio so I can fit more mp3s on an mp3CD (I don't have an ipod :-/ )
Title: REACT 2 Released
Post by: drbeachboy on 2006-12-24 03:17:48
Hi,

I was finally able to figure out how to use neroAacTag in place of AtomicParsley. If anyone is interested, post here, and I will gladly post the Nero portion of the config file.
Title: REACT 2 Released
Post by: dummptyhummpty on 2006-12-27 10:19:21
I've noticed a small bug in REACT 2. EAC is set to put everything in C:\Documents and Settings\myusername\My Documents\My Music. I notice all the temp files and things end up just in the "My Documents" folder and everything gets placed in the right spot after (so I don't care). But cover downloader puts the .jpg file in the "My Music" folder so REACT doesn't find it unless I move it to "My Documents".

Also how can I add the Replay Gain tag (that says XXdb) to all the flac files i've ripped with REACT 1?

From my REACT.ini file:
Code: [Select]
[UserOutputNames]
OutRoot=@mymusic@
ImageDir_Flac=@OutRoot@\FLAC\$cdartist$\$album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\$album$
Title: REACT 2 Released
Post by: ESP85 on 2006-12-27 18:08:16
I've noticed a small bug in REACT 2. EAC is set to put everything in C:\Documents and Settings\myusername\My Documents\My Music.

That's weird.  I have the same settings as you but my files are automatically put into "C:\EAC"


Is there anyway to set it up so the log files aren't deleted after the files are compressed?  I want them automatically moved to a log folder.
Title: REACT 2 Released
Post by: dummptyhummpty on 2006-12-27 20:58:19

I've noticed a small bug in REACT 2. EAC is set to put everything in C:\Documents and Settings\myusername\My Documents\My Music.

That's weird.  I have the same settings as you but my files are automatically put into "C:\EAC"


Is there anyway to set it up so the log files aren't deleted after the files are compressed?  I want them automatically moved to a log folder.


You need to edit REACT-image.cfg or REACT-track.cfg it should be towards the bottom. What folder do you want them moved to i'll try to write out the code.
Title: REACT 2 Released
Post by: ESP85 on 2006-12-27 21:12:37
Well the mp3s are put in C:\EAC\MP3 on my system so C:\EAC\logs would be good.  Thanks.



Edit:

Actually I think it would be a better idea to copy the log file to each output folder.

So if I rip a FLAC image and have REACT2/ACDIR split it up into MP3s then the log should go in the FLAC folder AND the MP3 folder.
Title: REACT 2 Released
Post by: Martin H on 2006-12-27 22:27:25
Just a little tip...

If you are using metamp3.exe to ReplayGain scan your MP3 track files, then besides the normal RG tags : 

REPLAYGAIN_TRACK_GAIN
REPLAYGAIN_TRACK_PEAK
REPLAYGAIN_ALBUM_GAIN
REPLAYGAIN_ALBUM_PEAK

Then there are also added :

MP3GAIN_MINMAX
MP3GAIN_ALBUM_MINMAX

If you, like me, would like to skip having metamp3.exe add these tags to your MP3 track files, then you just add this line :
Code: [Select]
IF %add_rg%==1 @tools@\metamp3.exe --remove [mp3gain_*]TXXX *.mp3

Just after this line :
Code: [Select]
IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3

So it should look like this :
Code: [Select]
IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3
IF %add_rg%==1 @tools@\metamp3.exe --remove [mp3gain_*]TXXX *.mp3

CU, Martin.
Title: REACT 2 Released
Post by: dummptyhummpty on 2006-12-28 05:57:33
Well the mp3s are put in C:\EAC\MP3 on my system so C:\EAC\logs would be good.  Thanks.

Edit:

Actually I think it would be a better idea to copy the log file to each output folder.

So if I rip a FLAC image and have REACT2/ACDIR split it up into MP3s then the log should go in the FLAC folder AND the MP3 folder.


In the flac image section of REACT-image.cfg add
Code: [Select]
COPY /Y "@eaclog@" %dest%

Between:
Code: [Select]
MOVE /Y "@cuesheet@" %dest%
IF %have_cover%==1 COPY /Y "@cover@" %dest%\"cover.jpg"

Then in the MP3/LAMEMP3 track section add it above:
Code: [Select]
REM COPY /Y "@eaclog@" "EAClog.txt"

Let me know if something dosn't work.

Also how can I add the Replay Gain tag (that says XXdb) to all the flac files i've ripped with REACT 1?


I figured it out. Any word on the bug i'm experiencing?
Title: REACT 2 Released
Post by: ESP85 on 2006-12-29 00:35:23
Thanks alot.  The code snippets work great. 


But I'm having a problem with long wav image filenames.  There is this one wav filename that is 84 characters long (88 if you include ".wav" )

This is the original image file that EAC rips.  My REACT2 is set up to compress the image to FLAC, move it to the FLAC folder, split up the image into individual MP3 tracks and move those to their respective folder.

The FLAC dir is created but only the log is copied to there.  The FLAC encoder says "The filename or extention is too long." after it finishes compressing and because of this, never moves the FLAC file.

Is there anyway around this? 88 characters definitely isn't that long of a filename; the maximum Windows will allow is 255 I think.
Title: REACT 2 Released
Post by: ESP85 on 2006-12-30 19:48:30
But I'm having a problem with long wav image filenames.  There is this one wav filename that is 84 characters long (88 if you include ".wav" )

This is the original image file that EAC rips.  My REACT2 is set up to compress the image to FLAC, move it to the FLAC folder, split up the image into individual MP3 tracks and move those to their respective folder.

The FLAC dir is created but only the log is copied to there.  The FLAC encoder says "The filename or extention is too long." after it finishes compressing and because of this, never moves the FLAC file.

Is there anyway around this? 88 characters definitely isn't that long of a filename; the maximum Windows will allow is 255 I think.


Sorry to bump the thread but does anyone know a work around for this problem?
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-30 20:23:56
Are you sure that FLAC.EXE is the problem?  I have just encoded a file with a 100 character filename successfully.

I don't have the cfg here to check what the sequence is, but it may well be worth posting the relevant part of your log to diagnose further.

It appears that one of the apps has an issue with long-ish filenames, and we need to find out which one.
Title: REACT 2 Released
Post by: ESP85 on 2006-12-30 22:58:38
Are you sure that FLAC.EXE is the problem?  I have just encoded a file with a 100 character filename successfully.

I don't have the cfg here to check what the sequence is, but it may well be worth posting the relevant part of your log to diagnose further.

It appears that one of the apps has an issue with long-ish filenames, and we need to find out which one.

Ok.  I turned Debug on.  Apparently the problem is not with FLAC.  It's right after FLAC encodes and tries to move the cue and FLAC image to the FLAC dir.

Here's where the problem is..

Code: [Select]
C:\EAC>MOVE /Y "C:\EAC\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996].flac" "C:\EAC\FLAC-images\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996]"
The filename or extension is too long.

C:\EAC>MOVE /Y "C:\EAC\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996].cue" "C:\EAC\FLAC-images\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996]"
The filename or extension is too long.
Title: REACT 2 Released
Post by: ESP85 on 2006-12-31 08:47:30
I just discovered another possible bug today.

REACT2 has a problem with slashes "/" in the title.  I have some CDs that have slashes in the title and when I press F10 to make an image the screen just flashes and the Save Waveform window doesn't pop up at all unless I take the slashes out of the title.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-31 09:09:54
Good band by the way. 

Hmm... if I do:

MOVE /Y "C:\Documents and Settings\Neil\Desktop\12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345
67890.flac" "C:\Documents and Settings\Neil\Desktop\12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345
67890"

... on my XP laptop it works fine.

I've had a look at this problem and it doesn't look like there's an easy way in NT DOS to get the short file name.  I did find this page (http://www.robvanderwoude.com/truename.html), but I wouldn't call the resolve easy.

One option may be for REACT to use short file names by default (AutoIt has built-in functions to get the SFN for a path), or perhaps even to provide some more placeholders, like ~cuesheet~ or ~eaclog~, which return SFN filenames.
Title: REACT 2 Released
Post by: Synthetic Soul on 2006-12-31 12:29:00
REACT2 has a problem with slashes "/" in the title.  I have some CDs that have slashes in the title and when I press F10 to make an image the screen just flashes and the Save Waveform window doesn't pop up at all unless I take the slashes out of the title.
Known issue with EAC (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=35158&view=findpost&p=344557).
Title: REACT 2 Released
Post by: ESP85 on 2007-01-01 09:34:02
Good band by the way. 

Hmm... if I do:

MOVE /Y "C:\Documents and Settings\Neil\Desktop\12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345
67890.flac" "C:\Documents and Settings\Neil\Desktop\12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345
67890"

... on my XP laptop it works fine.

I've had a look at this problem and it doesn't look like there's an easy way in NT DOS to get the short file name.  I did find this page (http://www.robvanderwoude.com/truename.html), but I wouldn't call the resolve easy.

One option may be for REACT to use short file names by default (AutoIt has built-in functions to get the SFN for a path), or perhaps even to provide some more placeholders, like ~cuesheet~ or ~eaclog~, which return SFN filenames.

I have Windows 2000 Pro.

I've tried to find where the maximum filename length would be set but with no luck.  Maybe my settings are messed up somewhere.

REACT2 has a problem with slashes "/" in the title.  I have some CDs that have slashes in the title and when I press F10 to make an image the screen just flashes and the Save Waveform window doesn't pop up at all unless I take the slashes out of the title.
Known issue with EAC (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=35158&view=findpost&p=344557).

The slashes in the title work just fine when I'm not running REACT2 so I think it's a REACT2 issue.
Title: REACT 2 Released
Post by: Fameless on 2007-01-04 22:13:43
I just started to mess around this this, and I have a few issues/questions. 

I want to use React to make .mp3's for my portable player, and .flac files for listening at home. Here is how my REACT.ini file is set up:
[Settings]
Version=2.0
ImageExt=wav
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F5}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=1
CoverDownloader=C:\Program Files\REACT2\coverdownloader\albumart.exe
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
Tools=C:\Program Files\REACT2\tools
MinimizeCompressionWindow=1
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
OutRoot=@mymusic@\EAC
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\[$year$] $album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\[$year$] $album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\[$year$] $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
TrackName_SA=$track$ - $title$
TrackName_VA=$track$ - $title$ [$artist$]
TrackName_SA_acdir=$n - $~t
TrackName_VA_acdir=$n - $~t [$~a]

[UserSettings]
Debug=1
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=1
ApplyAlbumGain=1
AdjustAlbumGain_dB=+3.0
AddCuesheetAG=1
UseWaveGainAG=1
Opt_Flac=-5 -f
Opt_Wavpack=-hmy
Opt_LameMP3=-V2 --vbr-new  --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.3
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5

After React runs, the wave files are not deleted even though I checked Delete WAV after compression in EAC. How do I configure React to delete .wav's after it runs? Can I use the single .cue file created to decompress the .flac tracks to restore to a cd-r for back-up? I've never used .flac before and I'm unsure the best course of action to take for track restoration with React. I had installed flac frontend to decompress the flac tracks, but React would no longer create .flac tracks for new cd's. I apologize if this is hard to follow, but I'm new to flac and React. I'm good with LAME, I'll LAME it up all day long.

That was LAME...
Title: REACT 2 Released
Post by: Martin H on 2007-01-05 12:40:03
For getting the WAV image and cuesheet deleted afterwards, then you need to set 'Debug' to '0' instead of '1'. If you want a cuesheet for your ripped tracks, then you must set the 'CreateAllCuesheets' to '1' and then all the 4 different cuesheet formats are made, but they are only copied into the directories of lossless formats, though, so if you want a cuesheet into a lossy formats directory, then just copy the changed line a little under here, and place it into your lossy format's track section in your CFG file.

Press ALT+F3 and there you need to scroll down to the '---tracks---' section and then under the FLAC tracks section, then find this line :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .

And then change it to :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"


CU, Martin.
Title: REACT 2 Released
Post by: ESP85 on 2007-01-05 13:04:29

Good band by the way. 

Hmm... if I do:

MOVE /Y "C:\Documents and Settings\Neil\Desktop\12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345
67890.flac" "C:\Documents and Settings\Neil\Desktop\12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345
67890"

... on my XP laptop it works fine.

I've had a look at this problem and it doesn't look like there's an easy way in NT DOS to get the short file name.  I did find this page (http://www.robvanderwoude.com/truename.html), but I wouldn't call the resolve easy.

One option may be for REACT to use short file names by default (AutoIt has built-in functions to get the SFN for a path), or perhaps even to provide some more placeholders, like ~cuesheet~ or ~eaclog~, which return SFN filenames.

I have Windows 2000 Pro.

I've tried to find where the maximum filename length would be set but with no luck.  Maybe my settings are messed up somewhere.

REACT2 has a problem with slashes "/" in the title.  I have some CDs that have slashes in the title and when I press F10 to make an image the screen just flashes and the Save Waveform window doesn't pop up at all unless I take the slashes out of the title.
Known issue with EAC (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=35158&view=findpost&p=344557).

The slashes in the title work just fine when I'm not running REACT2 so I think it's a REACT2 issue.


Does anybody have any idea how to fix either of these problems?
Title: REACT 2 Released
Post by: Fameless on 2007-01-05 20:00:28
Thanks Martin H, that's what I was looking for. One more question: which .cue sheet should I use to decode the .flac tracks to burn to a cd-r for back-up? If I read the EAC .cue sheet guide correctly, I want to use the noncompliant sheet, right? Out of the four sheets that React creates, which one is it?
Title: REACT 2 Released
Post by: Martin H on 2007-01-06 11:45:56
You are very welcome Fameless

The cuesheet you will need is the "multiple files with gaps" i.e. "@albumfile@.[mg].cue" and that should also be copied to your FLAC files directory according to the changes i posted to you previously.

CU, Martin.
Title: REACT 2 Released
Post by: Fameless on 2007-01-06 19:04:27
Awesome, thanks for the help.
Title: REACT 2 Released
Post by: The Chaos Path on 2007-01-07 21:14:48
I've tried to figure this out on my own, but with no success. I'm trying to create a WavPack image and mp3 tracks. The image comes out fine and in the proper folder, but when it comes to the track creation, it looks like React is running it correctly, but no files are created and all I get is an empty folder. Any ideas?

Edit: Never mind, of course I figured it out five minutes after I posted.
Title: REACT 2 Released
Post by: lwbecker2 on 2007-01-08 00:04:25
I was looking at using EAC with iTunesEncode and Nero's AAC encoder, along with REACT. I see that support is built in and was looking at the code in the config section and have questions about the following two code segments.  The line before :end_itunes_aac_tracks says "GOTO end_nero_aac_tracks" (see code below)... is this a typo? not sure why the itunes acc section would goto the end of the nero aac section.

In the second code snippet, the one for Nero's encoder, it calls neroAacEnc.exe but doesn't call the nero tagger (neroAacTag.exe), but instead uses some other tagging program.. why is this?  Thanks in advance for any information.

Code: [Select]
IF NOT @iTunesAac@==1 GOTO end_itunes_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF %embed_cover%==1 SET Cover_tag=-r "@cover@"
        ECHO ON
        @tools@\iTunesEncode.exe @Opt_iTunesAac@ -e "AAC Encoder" %Cover_tag% -x @various@ -a "@artist@" -l "@album@" -n "@track@" -m "@numtracks@" -t "@title@" -y "@year@" -g "@genre@" -c "@comment@" -i "@source@" -o "%TrackName%.m4a"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
    GOTO end_nero_aac_tracks
:end_itunes_aac_tracks

Code: [Select]
IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF @various@==1 SET VA_tag=--albumArtist "@VA@" --compilation true
        IF %embed_cover%==1 SET Cover_tag=--artwork "@cover@"
        ECHO ON
        @tools@\neroAacEnc.exe @Opt_NeroAac@ -if "@source@" -of "%TrackName%.m4a"
        @tools@\AtomicParsley.exe "%TrackName%.m4a" -o REACT_tmp.m4a %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@" --tracknum "@track@/@numtracks@" --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@" --encodingTool "neroAacEnc @Ver_NeroAac@ @Opt_NeroAac@"
        @ECHO OFF
        MOVE /Y REACT_tmp.m4a "%TrackName%.m4a"
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_nero_aac_tracks
Title: REACT 2 Released
Post by: getsource on 2007-01-08 09:05:30
I've been looking in the WIKI and configs for a while, but can't seem to figure out:

Is there a way to generate M3U files for track ripping?  (like EAC does normally when it rips tracks)

Thanks,
GS
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-01-08 09:27:28
Is there a way to generate M3U files for track ripping?  (like EAC does normally when it rips tracks)
Does EAC do this normally?  If it does then it probably still can.

If not, I have created a batch file to create an M3U.  It accepts a folder to process and a filename as parameters, e.g.:

@tools@\CREATE-M3U.BAT "@TrackDir_MP3@" "$cdarist$ - $album$"

Here's the code.  If you're interested, copy it into a text file, save it in the REACT "tools" directory as "create-m3u.bat", and then use the line above after your track files have been created.

Code: [Select]
@ECHO OFF
CLS

REM CREATE-M3U.BAT Written by Neil Popham, 2005 (neilpopham@bigfoot.com)

SET batchname=CREATE-M3U.BAT
SET version=1.1.0
TITLE=%batchname%, Version %version%

REM Set the name of the playlist to create in each folder
IF [%2] EQU [] (SET playlist=playlist.m3u) ELSE (SET playlist="%~2.m3u")
REM Create list of valid file extensions
SET validExtn=.mp3.mp2.mp1.mpc.mp+.mpp.ogg.aac.mac.ape.flac.fla.wv.shn.ofr.ofs.ogg.m4a.mp4

REM Add another delimiter to the end so I can search for .<ext>.
SET validExtn=%validExtn%.

REM Check a folder has been passed
IF NOT EXIST %1 GOTO NoParams
IF %~z1 GTR 0 GOTO NoParams

REM Remove all existing "playlist.m3u" files otherwise files will be appended
FOR /R %1 %%G IN (%playlist%) DO IF EXIST %%G DEL "%%G"

REM Iterate through every file and pass the path to :WriteToPlayList
FOR /R %1 %%G IN (*.*) DO CALL :WriteToPlayList "%%G" %playlist%

GOTO:EOF

REM ======================================================================
REM WriteToPlayList : Adds the file to the playlist, if the extension fits
REM : %1 The file to process
REM ======================================================================
:WriteToPlayList
REM Check that the file extension is valid
SET extn=%~x1
IF [%extn%] EQU [] GOTO:EOF
SET tmpExtn=%validExtn%
CALL SET result=%%tmpExtn:%extn%.=%%
REM If no match found in list of extensions exit function
IF [%result%] EQU [%validExtn%] GOTO:EOF
REM Escape ampersand and caret
SET tmpString="%~nx1"
SET tmpString=%tmpString:^=^^%
SET tmpString=%tmpString:&=^^^&%
REM Remove quotes
SET tmpString=%tmpString:"=%
REM Write filename to playlist
ECHO %tmpString%>>"%~dp1\%~2"
GOTO:EOF

REM =======================================
REM NoParams : a folder has not been passed
REM =======================================
:NoParams
ECHO To run this script, please pass a folder as a parameter.
ECHO.
ECHO Press any key to exit
PAUSE >NUL

REM ===============
REM Version History
REM ===============
REM 1.0.0 ---------- Initial Version
REM 1.1.0 2006-11-01 Fixed bug when hypens used.
NB: This was originally posted in the REACT 1 thread here (http://www.hydrogenaudio.org/forums/index.php?showtopic=35158&st=275&p=398387&#entry398387) and here (http://www.hydrogenaudio.org/forums/index.php?showtopic=35158&st=475&p=445927&#entry445927).
Title: REACT 2 Released
Post by: grombulk on 2007-01-08 18:55:28
Is there a way to generate M3U files for track ripping?  (like EAC does normally when it rips tracks)


I use tag as in:
@tools@\tag.exe --playlist --onlyfiles --sort track --plname "00 - @basename@.m3u" "%dest%\*.mp3"
in
REACT-image.cfg

I us the Synthetic Soul's version (http://www.synthetic-soul.co.uk/tag/)
Title: REACT 2 Released
Post by: cpalcott on 2007-01-08 20:50:52
I am a curremt 1.0 user, but am having some trouble getting 2.0 to work. Here's what I am looking to do:

• Rip to Flac 1.1.3 tracks and Lame 3.97 tracks
• Run Wavegain and store Album-Gain, Album-Peak, Track-Gain and Track-Peak findings in Flac tags and mp3 tags and apply Track-Gain to the mp3s.
• Get album art, save it as folder.jpg in the Flac album folder, embed art in Flac file and mp3 file.

Any sample ini or cfg files out there?

See below for current config:

Code: [Select]
[Settings]
Version=2.0
ImageExt=wav
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F6}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=1
CoverDownloader=C:\Program Files\REACT2\coverdownloader\albumart.exe
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
Tools=C:\Program Files\REACT2\tools
MinimizeCompressionWindow=1
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
OutRoot=@mymusic@\EAC
ImageDir_Flac=C:\Documents and Settings\calcott\My Documents\My Music\Archive\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=C:\Documents and Settings\calcott\My Documents\My Music\Portable\$cdartist$
TrackDir_Flac=C:\Documents and Settings\calcott\My Documents\My Music\Archive\$cdartist$\[$year$] $album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\[$year$] $album$
TrackDir_MP3=C:\Documents and Settings\calcott\My Documents\My Music\Portable\$cdartist$\[$year$] $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
TrackName_SA=$track$ - $title$
TrackName_VA=$track$ - $title$ [$artist$]
TrackName_SA_acdir=$n - $~t
TrackName_VA_acdir=$n - $~t [$~a]

[UserSettings]
Debug=1
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=1
ApplyAlbumGain=1
AdjustAlbumGain_dB=+3.0
AddCuesheetAG=0
UseWaveGainAG=1
Opt_Flac=-5 -f
Opt_Wavpack=-hmy
Opt_LameMP3=-V3 --vbr-new
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.3
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5

@ECHO OFF
CHCP 1252
TITLE @track@/@numtracks@ - "@album@"

REM Copyright © Tycho, 2006
REM
REM ** Create compressed audio tracks from ripped .wav tracks.
REM **
REM ** You may consider using image mode (F10)
REM ** as it supports creating tracks via acdir.exe,
REM ** and post-processing will always work (see below).
REM **
REM ** Flac requires flac.exe/metaflac.exe (v1.1.3)
REM ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
REM ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.
REM **
REM ** I prefer applying album gain 92dB to get a reasonable
REM ** volume for my DAP. The RG tags are still relative
REM ** to 89dB SPL, i.e. album gain will be about -3.0dB.


REM ============== Begin Main Script ==================


IF @Debug@==1 ECHO ON

SET TrackDir_Flac="@TrackDir_Flac@"
SET TrackDir_Wavpack="@TrackDir_Wavpack@"
SET TrackDir_MP3="@TrackDir_MP3@"
SET TrackDir_AAC="@TrackDir_AAC@"
SET TrackDir_OGG="@TrackDir_OGG@"

IF @various@==0    SET TrackName=@TrackName_SA@
IF @various@==1    SET TrackName=@TrackName_VA@

SET add_rg=@ReplayGain@
SET have_cover=0
SET embed_cover=0

IF NOT @ReplayGain@==1 GOTO end_RG
    SET RG_Flac=--replay-gain
    SET RG_MetaFlac=--add-replay-gain
    SET RG_MetaMP3=--replay-gain
:end_RG

IF NOT @ApplyAlbumGain@==1 GOTO end_apply_AG
    SET ApplyAG_MetaMP3=--apply-gain album@AdjustAlbumGain_dB@
    SET ApplyAG_AacGain=/a /o /c /d @AdjustAlbumGain_dB@
    SET add_rg=1
:end_apply_AG

IF EXIST "@cover@" (
    SET have_cover=1
    SET embed_cover=@EmbedCover@
)

IF @various@==0 (
    SET ArtistField=artist
    SET MP3Artist=--artist "@artist@"
) else (
    SET ArtistField=album artist
    SET MP3Artist=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"
)

SET run_wavegain=@UseWaveGainAG@
IF @AddCuesheetAG@==1 SET run_wavegain=1

IF %run_wavegain%==0 GOTO end_wavegain
    SET wg_tmp=wg_%RANDOM%
    @tools@\WaveGain.exe --album "@source@" --exec ECHO '%%ALBUM_GAIN%%'%%ALBUM_PEAK%%'%%ALBUM_NEW_PEAK%%'%%ALBUM_SCALE%%'> %wg_tmp%.txt
    FOR /F "usebackq tokens=1-6 delims='" %%a IN (%wg_tmp%.txt) DO (
        SET album_gain=%%b
        SET album_peak=%%c
        SET album_new_peak=%%d
        SET album_scale=%%e
    )
    ECHO REM REPLAYGAIN_ALBUM_GAIN %album_gain% dB> %wg_tmp%.cue
    ECHO REM REPLAYGAIN_ALBUM_PEAK %album_peak%>> %wg_tmp%.cue
    ECHO REM REPLAYGAIN_ALBUM_SCALE %album_scale%>> %wg_tmp%.cue
    DEL %wg_tmp%.txt
    TYPE "@cuesheet@" >> %wg_tmp%.cue
    MOVE /Y %wg_tmp%.cue "@cuesheet@"
:end_wavegain


REM ** Transfer RG values from Wavgain calculations, instead of recalculation.
IF @UseWaveGainAG@==1 IF %add_rg%==1 (
    SET RG_Flac=-T "replaygain_album_gain=%album_gain% dB" -T "replaygain_album_peak=%album_peak%"
    SET RG_MetaFlac=--set-tag="replaygain_album_gain=%album_gain% dB" --set-tag="replaygain_album_peak=%album_peak%"
    SET RG_Wavpack=-w "replaygain_album_gain=%album_gain% dB" -w "replaygain_album_peak=%album_peak%"
    SET RG_Wavpack_acdir=-w $qreplaygain_album_gain=%album_gain% dB$q -w $qreplaygain_album_peak=%album_peak%$q
    SET RG_MetaMP3=--user-text "[replaygain_album_gain]%album_gain% dB" --user-text "[replaygain_album_peak]%album_peak%"
    SET RG_OggEnc2_acdir=-c $qreplaygain_album_gain=%album_gain% dB$q -c $qreplaygain_album_peak=%album_peak%$q
)

REM ** Apply AlbumGain by using --scale <factor> computed from WaveGain. Only for MP3 and OGG.
IF @UseWaveGainAG@==1 IF @ApplyAlbumGain@==1 (
    SET ApplyAG_Lame=--scale %album_scale%
    SET ApplyAG_MetaMP3=--apply-gain @AdjustAlbumGain_dB@
    SET RG_MetaMP3=--user-text "[replaygain_album_gain]0.0 dB" --user-text "[replaygain_album_peak]%album_new_peak%"
    SET RG_OggEnc2_acdir=--scale %album_scale% -c $qreplaygain_album_gain=0.0 dB$q -c $qreplaygain_album_peak=%album_new_peak%$q
)


REM ---- Track ----


IF NOT @Flac@==1 GOTO end_flac_tracks
    IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
    PUSHD %TrackDir_Flac%
        IF @various@==1 SET VA_tag=-T "album artist=@VA@"
        IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
        ECHO ON
        @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" "@source@" -o "%TrackName%.flac"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_flac_tracks


IF NOT @Wavpack@==1 GOTO end_wavpack_tracks
    IF NOT EXIST %TrackDir_Wavpack% MKDIR %TrackDir_Wavpack%
    PUSHD %TrackDir_Wavpack%
        IF @various@==1 SET VA_tag=-w "album artist=@VA@"
        ECHO ON
        @tools@\wavpack.exe @Opt_Wavpack@ %VA_tag% -w artist="@artist@" -w album="@album@" -w track="@track@/@numtracks@" -w title="@title@" -w year="@year@" -w genre="@genre@" -w comment="@comment@" -w encodedby="%USERNAME%" -w encodersettings="Wavpack @Ver_Wavpack@ @Opt_Wavpack@" "@source@" "%TrackName%.wv"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
        TITLE @track@/@numtracks@ - "@album@"
    POPD
:end_wavpack_tracks


IF NOT @LameMP3@==1 GOTO end_lame_tracks
    IF NOT EXIST %TrackDir_MP3% MKDIR %TrackDir_MP3%
    PUSHD %TrackDir_MP3%
        IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"
        IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"
        ECHO ON
        @tools@\lame.exe @Opt_LameMP3@ "@source@" "%TrackName%.mp3"
        @tools@\metamp3.exe %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@" --track @track@/@numtracks@ --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@" --frame TENC:"%USERNAME%" --frame TSSE:"LAME @Ver_LameMP3@ @Opt_LameMP3@" "%TrackName%.mp3"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_lame_tracks


IF NOT @iTunesAac@==1 GOTO end_itunes_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF %embed_cover%==1 SET Cover_tag=-r "@cover@"
        ECHO ON
        @tools@\iTunesEncode.exe @Opt_iTunesAac@ -e "AAC Encoder" %Cover_tag% -x @various@ -a "@artist@" -l "@album@" -n "@track@" -m "@numtracks@" -t "@title@" -y "@year@" -g "@genre@" -c "@comment@" -i "@source@" -o "%TrackName%.m4a"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
    GOTO end_nero_aac_tracks
:end_itunes_aac_tracks

IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF @various@==1 SET VA_tag=--albumArtist "@VA@" --compilation true
        IF %embed_cover%==1 SET Cover_tag=--artwork "@cover@"
        ECHO ON
        @tools@\neroAacEnc.exe @Opt_NeroAac@ -if "@source@" -of "%TrackName%.m4a"
        @tools@\AtomicParsley.exe "%TrackName%.m4a" -o REACT_tmp.m4a %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@" --tracknum "@track@/@numtracks@" --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@" --encodingTool "neroAacEnc @Ver_NeroAac@ @Opt_NeroAac@"
        @ECHO OFF
        MOVE /Y REACT_tmp.m4a "%TrackName%.m4a"
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_nero_aac_tracks


IF NOT @OggEnc2@==1 GOTO end_oggenc_tracks
    IF NOT EXIST %TrackDir_OGG% MKDIR %TrackDir_OGG%
    PUSHD %TrackDir_OGG%
        IF @various@==1 SET VA_tag=-c "album artist=@VA@"
        ECHO ON
        @tools@\oggenc2.exe @Opt_OggEnc2@ %VA_tag% -c artist="@artist@" -c album="@album@" -c tracknumber="@track@/@numtracks@" -c title="@title@" -c date="@year@" -c genre="@genre@" -c comment="@comment@" -c encoded-by="%USERNAME%" -c encoding="OggEnc @Ver_OggEnc2@ @Opt_OggEnc2@" "@source@" -o "%TrackName%.ogg"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_oggenc_tracks


REM ================ End Main Script ===================


IF @Debug@==1 (
    PAUSE
    EXIT
)

REM ** Cleanup

DEL "@source@"
DEL "@eaclog@"
DEL "@cuesheet@"
DEL "@albumfile@.[*].cue"
DEL "@cover@"

REM ** Delete this .bat file:
DEL %0
[!--sizeo:1--][span style=\"font-size:8pt;line-height:100%\"][!--/sizeo--]
Moderation: Changed CODE to CODEBOX[/size]
Title: REACT 2 Released
Post by: getsource on 2007-01-09 03:34:53
If not, I have created a batch file to create an M3U.  It accepts a folder to process and a filename as parameters, e.g.:
[snip]

I use tag as in:
[snip]


Thanks for both of your suggestions!  I apologize for not finding the script before -- I was not certain if the information from the old threads would apply to the new version.

I'll try those out -- Thanks muchly!

GS

[edit] My understanding as to why EAC doesn't create an M3U automatically when using REACT with image + tracks is due to the behavior when one wants to rip an image as opposed to tracks.  Since EAC is just ripping in bulk, it doesn't send an M3U out including a track listing -- nor could it know that it will end up in FLAC (or whatever format) in the end anyway (to set the M3U file names correctly). [/edit]
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-01-09 07:11:50
Thanks for both of your suggestions! I apologize for not finding the script before -- I was not certain if the information from the old threads would apply to the new version.
If the Tag solution works I would go with that, seeing as it's already in the tools dir.  I wasn't saying that you should have found my batch file in the other thread - to be fair, it's around 20 pages long - I was just providing a little background to my post.

My understanding as to why EAC doesn't create an M3U automatically when using REACT with image + tracks is due to the behavior when one wants to rip an image as opposed to tracks. Since EAC is just ripping in bulk, it doesn't send an M3U out including a track listing -- nor could it know that it will end up in FLAC (or whatever format) in the end anyway (to set the M3U file names correctly).
Ah, I see.  I'm not familiar with EAC's M3U generation.  Thanks for the explanation.
Title: REACT 2 Released
Post by: mmortal03 on 2007-01-10 05:59:41
I have CreateAllCuesheets=1, but I am using track creation.  No cuesheets are created.  Are cuesheets created only with image creation?  Further, is there any way to have it create ONLY a non-compliant cuesheet (e.g. the EAC cuesheet that is created when choosing "Create cuesheet with current settings")?  Is there any way to have it replace inside of the cuesheet the string ".wav" with ".flac", and the filenames relative to the position of the cuesheet placement, such to make the cuesheet compatible with the files that are actually outputted?
Title: REACT 2 Released
Post by: getsource on 2007-01-10 08:34:05
Another question, if I may.  If it turns out that this is the incorrect place to ask it, please let me know, as I'm new here.

I'm attempting to plan the backup of my CD collection and trying to get the planning right this time -- as I started it earlier only to find out the plan was flawed.  What I'm trying to figure out is if REACT is correct for the job -- I believe it is, but am having some trouble getting the final details correct.

Here's what I'd like to have at the end of the process:
1) I'd like to have a lossless backup of each CD with all of the gaps (and potentially CD-TEXT, although this is less important) preserved.  Whether this backup is easy to listen to (i.e. in Tracks) or just a .flac and a .cue, for instance, is unimportant, although I certainly wouldn't mind having the .flacs in tracks that I could listen to on a regular basis.

2) MP3s of each track to use on portable devices and for standard listening with .M3U to have easy access to the album's correct order.  These would be better without the 'gaps' attached at the end of each track ... although if it's impossible to preserve the album another way, I'd be willing to do it like this.  I like how REACT tags, sets volume information, and adds album art -- I'd certainly like to still have all of this included if possible.

During this process, I'd prefer to use AccurateRip to verify my rips, since I know that some of my CDs are getting old and already starting to get errors (this is part of the reason for backing up now as opposed to later).  Plus, I haven't used these drives for very much secure audio ripping and am still in the process of trusting them.

The problem I've been coming upon is that with REACT and similar tools is in using AccurateRip due to the problem I talked about before with EAC using bulk mode instead of track mode because AccurateRip only functions in track mode.

Is there some way to preserve gaps by creating a .CUE that points to MP3s or WAVs (or requires decoding into WAVs to reburn) -- or otherwise another manner to get a perfect CD backup when ripping to tracks?  Maybe I can use REACT with some sort of script to reconstruct the album after ripping in track mode?

I also noticed it mentioned that there are some problems with album art and volume checking with track ripping -- what are these, and should I avoid this mode due to these problems?

Is there some automated way to do what I'm seeking -- or would it be better to just hit two buttons for each CD (even though the 'image' wouldn't be verified, per se)?

Am I just being overcautious/paranoid and should just use REACT and trust EAC/ignore AccurateRip?

Thanks for your help -- Again, if this should be moved, let me know, and I'll do so.  I'd like to use REACT, since I like its faculties, which is the reason I decided to post this here.

GS
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-01-17 10:00:15
Ok.  I turned Debug on.  Apparently the problem is not with FLAC.  It's right after FLAC encodes and tries to move the cue and FLAC image to the FLAC dir.

Here's where the problem is..

Code: [Select]
C:\EAC>MOVE /Y "C:\EAC\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996].flac" "C:\EAC\FLAC-images\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996]"
The filename or extension is too long.

C:\EAC>MOVE /Y "C:\EAC\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996].cue" "C:\EAC\FLAC-images\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996]"
The filename or extension is too long.
I think I have found a resolve for this (maybe a bit late ):

If you define a label as such:

Code: [Select]
:GetShortPath
SET %2=%~fs1
GOTO:EOF

You can then use:

Code: [Select]
CALL :GetShortPath "C:\This is a long path\to a file.mp3" shortValue

ECHO %shortValue%


Or in the above example:

Code: [Select]
REM Remove original code
REM MOVE /Y "@image@" %dest%
REM MOVE /Y "@cuesheet@" %dest%

REM Create short name variables
CALL :GetShortPath %dest% destShortPath
  CALL :GetShortPath "@image@" imageShortPath
  CALL :GetShortPath "@cuesheet@" cuesheetShortPath

REM Move using short names
MOVE /Y %imageShortPath% %destShortPath%
MOVE /Y %cuesheetShortPath% %destShortPath%
  
...

:GetShortPath
SET %2=%~fs1
GOTO:EOF

May be useful in future... may not be.
Title: REACT 2 Released
Post by: happypyro on 2007-01-18 02:18:44
(Sorry Soul, I originally put this in the wrong thread)

Hi all, I want to start by thanking everyone who has worked on this great tool. I am a definate noob as far as ripping and archiving goes, but Ive found so much info here at hydrogenaudio I am almost overwelmed. What I have learned I am now acting on - I am using EAC with React2 to rip to flac for archiving and encode to vbr mp3 using lame for playback. So far everything is going great after reading through most of these posts and the wiki, so thanks again for all of your hard work.

One thing I havent found is how to define "mymusic" within React. currently EAC is ripping wav to a music folder on my desktop which is defined within EAC as the working directory, but then transcodes the flac and mp3 to the EAC folder in "C\docs & settings\my docs\my music". Not a big deal right now, but as the archive gets larger I want to have these files saved onto my D: drive. Can someone tell me how to define the "my music folder?
Thanks!

Heres my configs:
Code: [Select]
Version=2.0
ImageExt=wav
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F5}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=1
CoverDownloader=C:\Program Files\REACT2\coverdownloader\albumart.exe
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
Tools=C:\Program Files\REACT2\tools
MinimizeCompressionWindow=1
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
OutRoot=@mymusic@\EAC
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\[$year$] $album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\[$year$] $album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\[$year$] $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
TrackName_SA=$track$ - $title$
TrackName_VA=$track$ - $title$ [$artist$]
TrackName_SA_acdir=$n - $~t
TrackName_VA_acdir=$n - $~t [$~a]

[UserSettings]
Debug=0
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=1
ApplyAlbumGain=1
AdjustAlbumGain_dB=+3.0
AddCuesheetAG=0
UseWaveGainAG=0
Opt_Flac=-5 -f
Opt_Wavpack=-hmy
Opt_LameMP3=-V2 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.3
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5
[!--sizeo:1--][span style=\"font-size:8pt;line-height:100%\"][!--/sizeo--]Moderation: changed CODE to CODEBOX[/size]
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-01-18 07:21:00
(Sorry Soul, I originally put this in the wrong thread)
...
Not a big deal right now, but as the archive gets larger I want to have these files saved onto my D: drive. Can someone tell me how to define the "my music folder?
I have deleted your other post.

@mymusic@ is hard-coded to your "My Music" system folder.  Don't worry about it, just adjust OutRoot accordingly:

Change:

Code: [Select]
OutRoot=@mymusic@\EAC

... to:

Code: [Select]
OutRoot=D:

OutRoot uses @mymusic@ as its base purely as an example, and can be amended to any path you want.
Title: REACT 2 Released
Post by: ESP85 on 2007-01-18 09:08:43
Ok.  I turned Debug on.  Apparently the problem is not with FLAC.  It's right after FLAC encodes and tries to move the cue and FLAC image to the FLAC dir.

Here's where the problem is..

Code: [Select]
C:\EAC>MOVE /Y "C:\EAC\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996].flac" "C:\EAC\FLAC-images\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996]"
The filename or extension is too long.

C:\EAC>MOVE /Y "C:\EAC\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996].cue" "C:\EAC\FLAC-images\Sublime - What I Got (Very Clean Radio Version) (Promo CD Single GAS5P-3874) [1996]"
The filename or extension is too long.
I think I have found a resolve for this (maybe a bit late ):

If you define a label as such:

Code: [Select]
:GetShortPath
SET %2=%~fs1
GOTO:EOF

You can then use:

Code: [Select]
CALL :GetShortPath "C:\This is a long path\to a file.mp3" shortValue

ECHO %shortValue%


Or in the above example:

Code: [Select]
REM Remove original code
REM MOVE /Y "@image@" %dest%
REM MOVE /Y "@cuesheet@" %dest%

REM Create short name variables
CALL :GetShortPath %dest% destShortPath
  CALL :GetShortPath "@image@" imageShortPath
  CALL :GetShortPath "@cuesheet@" cuesheetShortPath

REM Move using short names
MOVE /Y %imageShortPath% %destShortPath%
MOVE /Y %cuesheetShortPath% %destShortPath%
  
...

:GetShortPath
SET %2=%~fs1
GOTO:EOF

May be useful in future... may not be.


Thanks alot.  It works great!!
Title: REACT 2 Released
Post by: mmortal03 on 2007-01-18 15:49:20
Are cuesheets created only with image creation when CreateAllCuesheets=1?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-01-18 15:58:48
Are cuesheets created only with image creation when CreateAllCuesheets=1?
No, IIRC, that flag's solely to create cuesheets when track-ripping.
Title: REACT 2 Released
Post by: mmortal03 on 2007-01-18 17:52:51
Are cuesheets created only with image creation when CreateAllCuesheets=1?
No, IIRC, that flag's solely to create cuesheets when track-ripping.


Well, I have CreateAllCuesheets=1, and am using track creation, and no cuesheets are created.  Is there extra code in the REACT-track.cfg that activates the actual process that I could have somehow mistakenly removed, then?
Title: REACT 2 Released
Post by: cpalcott on 2007-01-18 23:37:35
Replay Gain: Album AND Track Gain On iPod?

Does this philosophy make sense?

Use REACT 2.0 to rip to Flac tracks and Lame tracks. Set the .ini to embed cover art in both Flac and Lame, run Replay Gain scanner in post process, record Replay Gain values to tags accordingly and apply ALBUM GAIN to mp3s, thus permanently altering the loudness of the actual digital file. 

Flacs are done and ready to be archived.

For the mp3s, use Mp3tag, (using the process described in this thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=24620&pid=462471&st=25&#entry462471)) to transfer and re-calculate the value from the Replay Gain TRACK gain field to the newly created (by mp3tag) COMMENT ITUNNORM  field (or Sound Check field) …making sure that in Options/Tags/MPEG the write section is set to ID3v2.3 ISO-8859-1.

Load mp3s to itunes library with sound check on.  Load to ipod.

OUTCOME:

With sound check on the ipod turned off, all my music will play back at the replay gain ALBUM level (because that value was applied back in REACT).

With sound check on the ipod turned on, all my music will play back at the replay gain TRACK level (because that value was transferred from the replay gain track tag in mp3tag).

I know its probably already being done out there, but I am just curious to see if it makes sense. Am I missing anything? Will this somehow screw up the RG tags or am I on the right track?
Title: REACT 2 Released
Post by: fiery on 2007-01-21 13:04:13
Hi all,

First off, thank to Tycho for such a great tool, and for those of you that have helped refine it with ideas along the way.

I am having trouble running REACT 2 on Linux under Wine, I cannot get the hotkeys to work. When I hit F10 it goes into the drive options setup screen, so basically its still using the standard function key settings in EAC. Although when I press ALT-F2 it does try to bring up the .ini file, but it doesn't actually find the ini file correctly, so creates a new text file instead. At first I had REACT 2 it installed within a folder within my EAC folder, but thought that since it was creating a new ini file when pressing ALT-F2, that it might be looking for it at /Program Files/REACT2 which is the default folder that comes up at installation time. But deleting and then reinstalling at that location didn't help.. Has anyone had any luck getting REACT 2 working in Linux under Wine? There is probably something stupidly simple that I am missing somewhere..

So for the timebeing I have installed it on my XP partition, but now I am getting another error. When using F10, albumart.exe brings up the following: "The application failed to initialize properly (0xc0000135). Click on OK to terminate the application". Everything else works fine though. Any ideas on this one? FYI, I have already tried reinstalling a fresh download of the program but it still happens.

Thanks in advance,
Title: REACT 2 Released
Post by: chrisgeleven on 2007-01-21 13:34:00
Replay Gain: Album AND Track Gain On iPod?

Does this philosophy make sense?

Use REACT 2.0 to rip to Flac tracks and Lame tracks. Set the .ini to embed cover art in both Flac and Lame, run Replay Gain scanner in post process, record Replay Gain values to tags accordingly and apply ALBUM GAIN to mp3s, thus permanently altering the loudness of the actual digital file. 

Flacs are done and ready to be archived.

For the mp3s, use Mp3tag, (using the process described in this thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=24620&pid=462471&st=25&#entry462471)) to transfer and re-calculate the value from the Replay Gain TRACK gain field to the newly created (by mp3tag) COMMENT ITUNNORM  field (or Sound Check field) …making sure that in Options/Tags/MPEG the write section is set to ID3v2.3 ISO-8859-1.

Load mp3s to itunes library with sound check on.  Load to ipod.

OUTCOME:

With sound check on the ipod turned off, all my music will play back at the replay gain ALBUM level (because that value was applied back in REACT).

With sound check on the ipod turned on, all my music will play back at the replay gain TRACK level (because that value was transferred from the replay gain track tag in mp3tag).

I know its probably already being done out there, but I am just curious to see if it makes sense. Am I missing anything? Will this somehow screw up the RG tags or am I on the right track?


That is the way I do it and it works slick.
Title: REACT 2 Released
Post by: Balthazar_B on 2007-01-23 02:25:45
I haven't seen this asked/answered yet, but I want EAC to run in burst mode, and do a test/rip compressed (shift-F6) to build the WAV file from each CD.  I haven't found anything in react.ini or the config files that stands out to trigger this action. Any suggestions?

EDIT: Never mind. I don't know how I missed it in the wiki before now, but just found it. There are some oddities I'm finding and will try to replicate. If I can, I'll post a followup.
Title: REACT 2 Released
Post by: Balthazar_B on 2007-01-24 01:34:06

Are cuesheets created only with image creation when CreateAllCuesheets=1?
No, IIRC, that flag's solely to create cuesheets when track-ripping.


Well, I have CreateAllCuesheets=1, and am using track creation, and no cuesheets are created.  Is there extra code in the REACT-track.cfg that activates the actual process that I could have somehow mistakenly removed, then?


I'm by no means an expert on FLAC command-line options, but from the FLAC documentation (http://flac.sourceforge.net/documentation_tools_flac.html#flac_options_cuesheet) it would appear that FLAC cuesheets can only be associated with image rips.  I thought I read somewhere else at HA that track-ripped FLACs can be used to burn a CD with a cuesheet, so I'm hoping SS or one of the other experts can clarify this.
Title: REACT 2 Released
Post by: getsource on 2007-01-24 03:21:18

Are cuesheets created only with image creation when CreateAllCuesheets=1?
No, IIRC, that flag's solely to create cuesheets when track-ripping.


Well, I have CreateAllCuesheets=1, and am using track creation, and no cuesheets are created.  Is there extra code in the REACT-track.cfg that activates the actual process that I could have somehow mistakenly removed, then?


I am also having the same problem.  I can't find the CUE sheets generated when using "CreateAllCuesheets=1" and track creation either.

GS
Title: REACT 2 Released
Post by: Martin H on 2007-01-24 09:28:15
Press ALT+F3 in EAC and scroll down to the '---tracks---' section. Under your choosen format(s), locate this line :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .

And then change it to :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"



Note, that by default, then there are only copied cuesheets into the destination directory for lossless formats, but if you also want a cuesheet for a lossy format, then just copy and paste the above line into the lossy format's track section. Also, i must admit that i don't understand the original line ? The "pushd %dest%", a couple of lines above in the CFG file, makes the "%dest%" defined directory, the default directory, but then there is just used a "." as destination filename for the COPY command in the original CFG ? Anyway, i don't rip to lossless tracks, so i haven't tested the original CFG file for cuesheet creation for tracks(or my example above either).
Title: REACT 2 Released
Post by: mmortal03 on 2007-01-25 02:10:06
Press ALT+F3 in EAC and scroll down to the '---tracks---' section. Under your choosen format(s), locate this line :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .

And then change it to :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"



Note, that by default, then there are only copied cuesheets into the destination directory for lossless formats, but if you also want a cuesheet for a lossy format, then just copy and paste the above line into the lossy format's track section. Also, i must admit that i don't understand the original line ? The "pushd %dest%", a couple of lines above in the CFG file, makes the "%dest%" defined directory, the default directory, but then there is just used a "." as destination filename for the COPY command in the original CFG ? Anyway, i don't rip to lossless tracks, so i haven't tested the original CFG file for cuesheet creation for tracks(or my example above either).


But it isn't pulling the cuesheets in the first place, therefore, "@albumfile@.[mg].cue" DOESN'T exist, and nothing happens.  Where is the actual call to create the cuesheets in EAC occurring?
Title: REACT 2 Released
Post by: Martin H on 2007-01-25 10:31:23
If the "CreateAllCuesheets" variable in the ini file is set to "1", then all four types of cuesheets are made and stored in the temporary ripping directory. Then if you use my line, then the "non-compliant" cuesheet is copied from the temp directory and into the destination directory. The script ends with all temporary files in the temp directory is deleted, and that includes the four cuesheets, so if they haven't been defined in the cfg, to be copied correctly into the destination directory, then you will not see the cuesheets afterwards in the temp directory either, as they have been deleted. If they aren't made at all, in the first place(check your temp ripping folder during ripping), then your EAC gap settings aren't compatible with your drive, so you must experiment to find the correct mode for your drive i.e. either A, B or C(in secure mode).
Title: REACT 2 Released
Post by: mmortal03 on 2007-01-25 13:10:29
If they aren't made at all, in the first place(check your temp ripping folder during ripping), then your EAC gap settings aren't compatible with your drive, so you must experiment to find the correct mode for your drive i.e. either A, B or C(in secure mode).


This is the problem:  the cuesheets are not being made at all, in the first place.  I have checked my temp ripping folder.  My EAC gap settings are completely compatible with my drive.  I have created cuesheets for years with EAC.
Title: REACT 2 Released
Post by: Martin H on 2007-01-26 12:08:04
This is the problem:  the cuesheets are not being made at all, in the first place.

Sorry, mate - then i cannot help you i'm affraid
Title: REACT 2 Released
Post by: mogorp on 2007-01-27 05:16:23
Eac logs and cuesheets are made for me but are never copied into the flac directory folder.  I see them in the eac destination folder during ripping and then they are deleted at the end. 

This is in my flac tracks config.
                COPY /Y "@eaclog@" "EAClog.txt"
      IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
      IF EXIST "@albumfile@.
Title: REACT 2 Released
Post by: Martin H on 2007-01-27 12:08:11
Any ideas?

I don't understand why the EAC log isn't copied over, as this line should do that :
Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"

I would recommend that you do a debug run.

About the cuesheet, then i don't understand the original line Tycho has made i.e. the "." defined as destination filename, but just in case that this is a bug(i couldn't find any references to using a "." as destination filename to the COPY command on SS64.com), then try this instead and this will also only copy the non-compliant cuesheet into your destination directory, instead of all four of them :

Press ALT+F3 in EAC and scroll down to the '---tracks---' section. Under your choosen format(s), locate this line :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .

And then change it to :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"
Title: REACT 2 Released
Post by: wraithdu on 2007-01-31 17:10:51
I have a few questions, simple I hope.

1.  Is there a way to have a FLAC image scanned for both album_RG and track_RG?  Right now it is only scanned for album_RG with flac.exe --replay-gain.

2.  Is there any way to have my track and totaltrack numbers zero-padded in the metadata for flac images and mp3 tracks?  It works ok in the filename creation, but my metadata for everything is still 1, 2, 3, etc. instead of 01, 02, 03.

Thanks for a great plugin!
Title: REACT 2 Released
Post by: Balthazar_B on 2007-02-02 02:57:12
Here's what I want to end up with:

1. FLAC tracks (on an external drive)
2. iTunes-AAC tracks (on a local drive)

The path/filenames should be in this format: \\extdrivepath\music\pop\artist\album\(tracknum) song.flac and
C:\mymusic\pop\artist\album\(tracknum) song.m4p

For a while I was running REACT2 configured to rip both in full track mode (F4), which was working fine (mostly), but then I was influenced by postings that suggested doing an image rip to WAV and then having that decomposed to tracks was a bit more foolproof, so I've been trying that, but getting stymied each time by errors. In debug mode, I come up with the following:

Code: [Select]
Z:\Music\pop\Cars, The\The Cars Greatest Hits>C:\PROGRA~1\REACT2\tools\acdir.exe
--overwrite --output "($n) - $~t.flac" --extra-opt "|image/jpeg|||C:\EAC\The Ca
rs Greatest Hits.jpg" --pipe "TITLE $n/$N flac $#T & C:\PROGRA~1\REACT2\tools\fl
ac.exe -5 -f --picture=$#x  -T artist=$#a -T album=$#T -T title=$#t -T tracknumb
er=$n/$N -T date=$q1985$q -T genre=$qRock$q -T comment=$qCreated with EAC/REACT2
, 2007-02-01$q -T encoded-by=$qJohn$q -T encoding=$qFlac 1.1.3 -5 -f$q - -o $#o"
"C:\EAC\Ctmp1!542-react.cue"

Z:\Music\pop\Cars, The\The Cars Greatest Hits>IF 1 == 1 C:\PROGRA~1\REACT2\tools
\Glob.exe -v -c C:\PROGRA~1\REACT2\tools\metaflac.exe --add-replay-gain *.flac
Executing: C:/PROGRA~1/REACT2/tools/metaflac.exe "--add-replay-gain"
ERROR: you must specify at least one FLAC file;
       metaflac cannot be used as a pipe


I think the problem has to do with acdir.exe not splitting the WAV image file into tracks, which in turn spawns a metaflac error. Just by way of explanation, I'm ripping the WAV image to a temporary directory (C:\EAC), successfully getting a cover image, but at that point I reckon that something is misconfigured. I just can't figure out what it is.

More info: After the batch file continues execution (without doing much of anything beyond GO TO END routines) and exits, in my C:\EAC directory remain:The log file indicates no extraction problems. I'll post the operative parts of the BAT file on request, if needed.

The destination directory on my external drive (for FLAC tracks) is also created, but the only contents are 4 cuesheets, the folder.jpg cover, and eaclog.txt (with no errors indicated).

Any suggestions on edits to make or other things to try?  I'd like to get this working to see whether I like this method better than the other...and because I hate it when I can't get something to work  .

Thanks!!!
Title: REACT 2 Released
Post by: Balthazar_B on 2007-02-02 20:31:50
I'm not crazy about following one message with another, but I think I found the solution to half the problem I was experiencing, but need some help with the other half.

I tried running acdir.exe from the command line for testing purposes and it came back complaining that it couldn't find msvcr71.dll (for some reason it wasn't in path, and REACT debug mode didn't reveal it), so after I fixed that, REACT2 was able to rip to a WAV image and then acdir decomposed it to FLAC tracks.

Now the other half of the problem is to decompose the WAV to iTunes-encoded AAC (m4a) tracks, and I hadn't noticed it before, but REACT-image.cfg has no provision for invoking iTunesEncode.exe to do this (although REACT-track does if ripping in track mode, and does the job well with the latest iTunes).

I haven't seen it mentioned at HA, but is iTunesEncode incompatible with acdir.exe?  I've tried editing REACT-image.cfg to invoke iTunesEncode, but I'm pretty unfamiliar with the iTunes COM interface and have not gotten it to run successfully (I've used some of what I found in REACT-track.cfg as a starting point, but haven't figured out some of the options).  Has anyone been able to get this to work, or am I on a hopeless quest?

BTW, I've been remiss in thanking Tycho for a very useful tool...just hoping I can get over this last hump.

Thanks, everyone!

EDIT: Alternatively, is there any possibility that Tycho will support iTunes via its COM interface directly (as Omni Encoder does) rather than indirectly through iTunesEncode, which is not longer actively supported since the source code was lost?  Seems to me that would make it possible to let REACT2 automate the process I'm trying to do (i.e., rip to WAV/cuesheet, decompose to FLAC tracks, decompose to iTunes m4a, do the right thing with tags, album/track gain, etc., and delete WAV) in one pass.
Title: REACT 2 Released
Post by: dewey1973 on 2007-02-02 23:51:48
I'm by no means an expert on FLAC command-line options, but from the FLAC documentation (http://flac.sourceforge.net/documentation_tools_flac.html#flac_options_cuesheet) it would appear that FLAC cuesheets can only be associated with image rips.  I thought I read somewhere else at HA that track-ripped FLACs can be used to burn a CD with a cuesheet, so I'm hoping SS or one of the other experts can clarify this.

I'm not an expert either, but you can save a cue sheet for a track-based rip and use it with CD burning software to burn a CD.  The cue just tells the burner where to put the gaps, etc.  I don't know how/if REACT2 will save a cue sheet during a track based rip but if it doesn't, you can always save it yourself before you run REACT.  Then just keep it in the same folder as the flac tracks.

1.  Is there a way to have a FLAC image scanned for both album_RG and track_RG?  Right now it is only scanned for album_RG with flac.exe --replay-gain.


I doubt you can scan each track when there is only one "track" - the image file.  Could you load the image file into foobar via the cue sheet and calculate the per track values?  Where would it save them?
Title: REACT 2 Released
Post by: Martin H on 2007-02-03 01:32:44
Yes, it can be done with fb2k and this is the only way that i know of doing this. fb2k then adds the gain/peak values into extra REM entries defined for every track in the cuesheet. Also, with fb2k, then one can use all tags  wanted with images and even also use only track specific tags(not the same tag/value for each track), as fb2k just adds special track specific tags to the image file with this info.
Title: REACT 2 Released
Post by: great juan on 2007-02-07 22:33:00
I think there might be some missing code in the REACT version that is being distributed. When ripping an image to be split into flac tracks there is no replaygain data. It seems the React-image checks the ReplayGain flag and makes command line settings for flac.exe in RG_Flac.
Code: [Select]
IF NOT @ReplayGain@==1 GOTO end_RG
    SET RG_Flac=--replay-gain

When making an image %RG_Flac% is included in flac settings.
Code: [Select]
IF NOT @Flac@==1 GOTO end_flac_tracks ...
@tools@\acdir.exe --overwrite --output "%TrackName%.flac" --extra-opt "|image/jpeg|||@cover@" --pipe "TITLE $n/$N flac $#T & @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist=$#a -T album=$#T -T title=$#t -T tracknumber=$n/$N -T date=$q@year@$q -T genre=$q@genre@$q -T comment=$q@comment@$q -T encoded-by=$q%USERNAME%$q -T encoding=$qFlac @Ver_Flac@ @Opt_Flac@$q - -o $#o" "@sourcecuesheet@" ...

I think it should be @tools@\flac.exe @Opt_Flac@ %RG_Flac% %Cover_tag%
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.flac" --extra-opt "|image/jpeg|||@cover@" --pipe "TITLE $n/$N flac $#T & @tools@\flac.exe @Opt_Flac@ %RG_Flac% %Cover_tag% %VA_tag% -T artist=$#a -T album=$#T -T title=$#t -T tracknumber=$n/$N -T date=$q@year@$q -T genre=$q@genre@$q -T comment=$q@comment@$q -T encoded-by=$q%USERNAME%$q -T encoding=$qFlac @Ver_Flac@ @Opt_Flac@$q - -o $#o" "@sourcecuesheet@"...

If you are using Wavgain and replaygain the album gain data will be copied over, but there will be nothing for track gain with original verison.
Title: REACT 2 Released
Post by: singaiya on 2007-02-08 06:26:10
I'm encoding to Wavpack tracks and itunesAAC via F4, but for some reason the REACT dos window wants me to press a key to continue after each itunesencode track is finished. Is there a way to disable this requirement? I just had to babysit the machine and "press any key" 32 times 

Also, is there a way to leave the m4a file in the itunes library instead of REACT deleting them and us having to manually add them again afterward?
Title: REACT 2 Released
Post by: Martin H on 2007-02-08 12:34:41
@great juan

The reason that the flac.exe "--replay-gain" switch isn't used for encoding FLAC track files, is that this will require that all files of an album is passed at once to flac.exe to make flac.exe able to calculate correct album gain in addition to the track gain. Their is no missing code in the FLAC tracks section, because the next line will run metaflac.exe on all the files at once with metaflac.exe's "--add-replay-gain" switch, which will calculate correct track/album gain and peak values and add that info as Vorbis comments in the files. Glob.exe is used for expanding wildcards in the win32 cli :

Code: [Select]
IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac% *.flac
Title: REACT 2 Released
Post by: mogorp on 2007-02-13 12:23:29
Sorry to beat a dead horse but I can't figure this out. 

Cuesheets and Eaclogs are copied into my temporary directory but never to the final destination directory.  They are erased at the end of the process.  I am using tracks and have the following in my react2config for both mp3 and flac. 

                COPY /Y "@eaclog@" "EAClog.txt"
      IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
      IF EXIST "@albumfile@.
Title: REACT 2 Released
Post by: Martin H on 2007-02-13 17:36:18
I would change :

IF EXIST "@albumfile@.
Title: REACT 2 Released
Post by: mogorp on 2007-02-14 05:07:10
Thanks for the response.  I do want non-compliant cue sheets.  I had read your prior post and already tried your suggestion without success.  Cuesheets and the eaclog are both created temporarily but they are never copied into flac and mp3 directories.  They are not "rem"ed out.

1.  Is there something wrong with this syntax.

                COPY /Y "@eaclog@" "EAClog.txt"
      IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
      IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"
I don't know what copy/y means but it definately works for @cover@.


2. When I set debug to 1, where should I look for problems with eaclog and cuesheets? 

Thanks again for your help.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-02-14 07:07:26
Code: [Select]
/Y           Suppresses prompting to confirm you want to overwrite an existing destination file.

I can't help thinking that:

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"

... will copy the log into your system32 folder as EAClog.txt.

That doesn't explain your cuesheet going missing though.

I would just be interested to see what those lines look like once the tokens have been replaced, i.e.: the actual command that is run.  The log may well give you this info. Another debug technique I've used before is to copy the temporary batch file that REACT creates while it is present, allowing you to see exactly what is being processed without it disappearing on you.
Title: REACT 2 Released
Post by: Martin H on 2007-02-14 11:17:14
Code: [Select]
/Y           Suppresses prompting to confirm you want to overwrite an existing destination file.

I can't help thinking that:

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"

... will copy the log into your system32 folder as EAClog.txt.

Hi Synthetic Soul

Yes, you are right, but what you didn't get to see in mogorp's quoted part of the cfg.(and of course you can't remember the whole .cfg file in your head ) was that a little above those lines there was this command : "PUSHD %dest%" and at the end of the lines, this command : "POPD", which explains it

Btw, now that i am talking to you...

I'm personally no command-line expert like yourself  So i have been wondering about a line in the .cfg that i don't understand :

IF EXIST "@albumfile@.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-02-14 11:31:15
Ah, thanks for the additional info Martin!

I must admit I have never used the dot syntax that Tycho employs.  I have just performed a small test using the batch file below, and it seems to me that it just uses the current directory as the destination.  I assume it is like the "./" syntax sometimes used in other scripting.

Code: [Select]
IF EXIST "C:\Documents and Settings\Neil\Desktop\*.bat" COPY "C:\Documents and Settings\Neil\Desktop\*.bat" .
PAUSE

The result of the script above, which is not on my desktop, is that all batch files on my desktop where copied to the folder in which the script resides.  As you say, removing the dot appears to give the same result.

Edit: I realised that the test above was a little inconclusive, so I amended it slightly:

Code: [Select]
PUSHD "C:\Documents and Settings\Neil\Desktop\Freeview Radio Test"
IF EXIST "C:\Documents and Settings\Neil\Desktop\*.bat" COPY "C:\Documents and Settings\Neil\Desktop\*.bat" .
POPD
PAUSE

Running the script above from a totally different folder the files are copied to the folder "Freeview Radio Test" - i.e.: the current working directory, not the directory in which the script resides.  This is as expected, but clarifies it more than my previous test!
Title: REACT 2 Released
Post by: Martin H on 2007-02-14 13:05:59
Thank you very much for your reply Synthetic Soul and for testing it out for me  When i had read your post i thought to myself how big of an idiot i was for not just thinking about testing it out for myself

Btw, on another thought...

Your nick-name(or what it's called) is a little long to write, so i would like to ask you if you would mind if i used a shorter version of it(e.g. Synthetic or SS or ???), and in which case, what you preffered ? Of course i can continue to write it completely and that is no problem either, but just a thought

Btw, for people seeing this, then if they want to ask me something, then i preffer to be called Martin, and that i only choose Martin H, since the name "Martin" was allready taken  (Btw, My name is Martin Hertz )
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-02-14 13:36:55
Anything is fine by me Martin.  "SS", "Synthetic" or, even "Neil" from you.

I should have really gone for a shorter name, and Gambit did offer to have it amended for me, but I'm kind of attached to it now.

That said, I'm not precious about it - so anything that you think will catch my attention, but not violate TOS #2 , is fine by me.

NB: Thank you for your good work in this thread BTW.  I am not as active as I was, as I really have had little chance to play with REACT v2.  My AVG antivirus seems to really hate the EXE, so I've pretty much reverted to ripping to WAV until I can find some time to sort it all out.  Unfortunately I have more pressing things to occupy my time.
Title: REACT 2 Released
Post by: dios-mt on 2007-02-14 13:43:26
...
My AVG antivirus seems to really hate the EXE, so I've pretty much reverted to ripping to WAV until I can find some time to sort it all out.  Unfortunately I have more pressing things to occupy my time.


My AVG has no problems with REACT at all. I am using AVG 7.5 free.

And by the way:
Will there be an REACT Update with CueProc instead of acdir?

And finaly:
Great work done on REACT! I like this tool. Thank you very much.
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-14 15:44:15
So, have we determined where the cuesheets should be getting placed?  EAC has to process the disc and bring up the process bar to create each cuesheet, right?  It can't just magically come up with them.  Based on this, I have had no luck getting it to produce ANY cuesheets with REACT, and I have already tried changing the * to mg.  That would probably work if it was creating them in the first place, but it isn't.
Title: REACT 2 Released
Post by: Martin H on 2007-02-14 23:39:36
@Neil

Thank you very much, my friend  Yeah, i can perfectly imagine that REACT isn't your first priority when dealing with both work, small children and a wife

Btw, if you only want me calling you Neil in PM's, then please let me know, as i don't want to step on your toass(or whatever it's called, - and speeled)

Take care

@mmortal03

I will now test it out for you and report back when i'm done with testing
Title: REACT 2 Released
Post by: Martin H on 2007-02-15 00:38:39
@mmortal03

Okay, i have tested it now and i can tell you that it works perfectly, so it must be something wrong on your end i'm affraid. I ammended the ini file to setup REACT to make WavPack and MP3 track files. When the process had run through, then i had a WV and a MP3 folder in my Testing directory and in the WV folder there where the tracks of the album, four different cuesheet types and an EAC logfile. In the MP3 folder there where the tracks of the album and nothing else. I new that this would happen from reading the config file and when i changed it alittle, and did a re-run, then i had a WV folder with the tracks of the album and one non-compliant cuesheet named "%basename%.cue" and an EAC logfile. In the MP3 folder i had the tracks of the album, a non-compliant cuesheet named "%basename%.cue" and an EAC logfile. The changes i made to achive the latest result was : 

Under the WV tracks section, then change :

Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


To :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"


Under the MP3 tracks section, then change :

Code: [Select]
REM COPY /Y "@eaclog@" "EAClog.txt"


To :

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"


And also add this line :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-15 01:01:01
@mmortal03

Okay, i have tested it now and i can tell you that it works perfectly, so it must be something wrong on your end i'm affraid. I ammended the ini file to setup REACT to make WavPack and MP3 track files. When the process had run through, then i had a WV and a MP3 folder in my Testing directory and in the WV folder there where the tracks of the album, four different cuesheet types and an EAC logfile. In the MP3 folder there where the tracks of the album and nothing else. I new that this would happen from reading the config file and when i changed it alittle, and did a re-run, then i had a WV folder with the tracks of the album and one non-compliant cuesheet named "%basename%.cue" and an EAC logfile. In the MP3 folder i had the tracks of the album, a non-compliant cuesheet named "%basename%.cue" and an EAC logfile. The changes i made to achive the latest result was : 

Under the WV tracks section, then change :

Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


To :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"


Under the MP3 tracks section, then change :

Code: [Select]
REM COPY /Y "@eaclog@" "EAClog.txt"


To :

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"


And also add this line :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"


Thanks Martin, I'll try it out.  One thing, though:  What windows does EAC show when it is doing this process?  Does it just show the ripping dialogue, or are you also getting a window pop up that says that it is detecting the gaps and/or creating the cuesheets?
Title: REACT 2 Released
Post by: mogorp on 2007-02-15 01:19:39
Martin and Synthetic Soul. 

Thank you as always. I appreciate the fact that you guys are always willing to help others.
I must confess that I am in fact an idiot.  My problem is solved.  I was ripping in track mode and therefore of course using the REACT-track.cfg file.  I was editing the track section of the REACT-image.cfg file.  It is no wonder that this was useless.

Martin,
I added your
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"
change you suggested and ripped in image mode and the non-compliant cuesheet was created. 

I then switched back to track mode (for some reason I like accuraterip) and used
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"
and this worked.  Thank you guys again.  I am so sorry for wasting your time. 
Title: REACT 2 Released
Post by: Martin H on 2007-02-15 01:31:06
Hi mmortal03

Yeah, sorry - i forgot that you also asked about that in your previous post

When i press F10, then a small window pops up, which displays "Analyzing" and then detects the timings of the pause areas and retrieves the UPC/ISRC codes. Then again this window comes up 4 times, which now only detects UPC/ISRC, as the pause areas already have been determined(REACT uses AutoIT to script the EAC GUI, so it's just like you yourself had choosen to make the 4 cuesheets, one by one). Then you now have several different cuesheets and a bat file in your temp ripping folder and then the ripping starts. Then the image and cuesheets/eaclogs are all processed/copied/moved and all temporary files deleted from the temp folder

I am so sorry for wasting your time. 

Hi mogorp

Don't be sorry, it's no problem at all  I'm just glad to hear that you got it sorted out in the end

CU, Martin.
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-15 01:46:54
Solution: Use F4, don't use the MP3s button.  Problem solved.
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-15 05:55:18
Bug:  REACT automatically refills the genre box in EAC at rip time, if I blank it.
Title: REACT 2 Released
Post by: Martin H on 2007-02-15 14:50:50
Bug:  REACT automatically refills the genre box in EAC at rip time, if I blank it.

If you are reffering to there being set an empty genre tag field, if you haven't entered a genre in EAC's main window, then that's not a bug. Either you make sure that a genre is defined, or you remove that part of the command-line in your cfg file which sets the genre tag field.

Edit: I'm sorry, mate  I have just reread your post and saw that i had misunderstood you. What you are reffering to is not a REACT bug, but a bug in EAC. To make sure that this dosen't happen(after a certain time period, the changes you have made is reverted back to it's previous values), then instead of making the changes directly in EAC's main window, then instead press ALT+L and make the changes from there and select "OK".
Title: REACT 2 Released
Post by: robinpb on 2007-02-15 15:39:57
ok...i'm getting myself lost in the config. i want a streamlined react2 config (to place on friend's machines) that will generate *only* --scaled mp3's, eac cue, and eac log. i've set:

[UserTrackFormats]
Flac=0
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0

and get everything except the cue sheet. i suspect i'm getting lost in this section of REACT-image.cfg:

IF NOT @LameMP3@==1 GOTO end_lame_tracks
   SET dest="@TrackDir_MP3@"
   IF NOT EXIST %dest% MKDIR %dest%
   PUSHD %dest%
      IF @various@==1 SET VA_tag=--user-text $q[album artist]@VA@$q --frame $qTPE2:@VA@$q
      IF %embed_cover%==1 SET Cover_tag=--pict $#x
      @tools@\acdir.exe --overwrite --output "%TrackName%.mp3" --extra-opt "{3}@cover@" --pipe "TITLE $n/$N mp3 $#T & @tools@\lame.exe @Opt_LameMP3@ %ApplyAG_Lame% - $#o & @tools@\metamp3.exe %Cover_tag% %VA_tag% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME @Ver_LameMP3@ @Opt_LameMP3@$q $#o" "@sourcecuesheet@"
      IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3
      IF @ApplyAlbumGain@==1 @tools@\metamp3.exe %ApplyAG_MetaMP3% *.mp3
      COPY /Y "@eaclog@" "EAClog.txt"
      IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
      IF EXIST "@albumfile@.
Title: REACT 2 Released
Post by: Martin H on 2007-02-15 16:23:45
should i simply replace "@albumfile@.
  • .cue" with "@cuesheet@" ?
    eg should
    IF EXIST "@albumfile@.
  • .cue" COPY /Y "@albumfile@.
  • .cue" .
    be something like
    IF EXIST "@cuesheet@" MOVE /Y "@cuesheet@"  %dest%

Hi robinpb

You should replace :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


With instead :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"



CU, Martin.
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-15 16:31:44

Bug:  REACT automatically refills the genre box in EAC at rip time, if I blank it.

If you are reffering to there being set an empty genre tag field, if you haven't entered a genre in EAC's main window, then that's not a bug. Either you make sure that a genre is defined, or you remove that part of the command-line in your cfg file which sets the genre tag field.

Edit: I'm sorry, mate  I have just reread your post and saw that i had misunderstood you. What you are reffering to is not a REACT bug, but a bug in EAC. To make sure that this dosen't happen(after a certain time period, the changes you have made is reverted back to it's previous values), then instead of making the changes directly in EAC's main window, then instead press ALT+L and make the changes from there and select "OK".


Interesting.  I don't remember this happening in EAC before using REACT, because I would always blank the genre information (being that it is too inconsistent), and then rip, and not only would it stay blank, but EAC would remember that it wasn't filled the next time that I inserted that CD.

Yeah, I did already remove -T genre="@genre@" to beat this, before you suggested, actually, so at least it doesn't write the information to the files.  I'm just looking for a way to have EAC remember that it is blank.  I will try what you mentioned.

Btw, is there any variable to represent the track number WITH the zero at the front for 1-9 (how EAC outputs the track number to the filenames prior to encoding)?  I need this to do some find and replace work in the cuesheets, without having to search twice per file.
Title: REACT 2 Released
Post by: robinpb on 2007-02-15 16:43:24

should i simply replace "@albumfile@.
  • .cue" with "@cuesheet@" ?
    eg should
    IF EXIST "@albumfile@.
  • .cue" COPY /Y "@albumfile@.
  • .cue" .
    be something like
    IF EXIST "@cuesheet@" MOVE /Y "@cuesheet@"  %dest%

Hi robinpb

You should replace :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


With instead :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"



CU, Martin.



ok i'm testing that out now.
i do have
CreateAllCuesheets=1
set in react.ini
but during the ripping process i'm only seeing one cue sheet being generated (without any 'mg' naming convention).
Title: REACT 2 Released
Post by: Martin H on 2007-02-16 15:15:43
Btw, is there any variable to represent the track number WITH the zero at the front for 1-9 (how EAC outputs the track number to the filenames prior to encoding)?

I believe that EAC's track number variable "%n" is returned with the leading zero appended, but it's then up to the app that retrieves this value(for further processing) what they do with it, like e.g. lame.exe cuts the zero of when setting the "Track" ID3v1.1 tag and/or TRCK ID3v2.3 frame.
ok i'm testing that out now.
i do have
CreateAllCuesheets=1
set in react.ini
but during the ripping process i'm only seeing one cue sheet being generated (without any 'mg' naming convention).

I'm sorry, mate - I really don't know what's your problem is then, but i can just say that i atleast could get it to work, so i'm affraid that it's something on your end - Again, Sorry for that, mate 

One thing that is important though, is that your pause area(called gap in EAC) settings are matching your drive correctly...
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-16 18:30:01

Btw, is there any variable to represent the track number WITH the zero at the front for 1-9 (how EAC outputs the track number to the filenames prior to encoding)?

I believe that EAC's track number variable "%n" is returned with the leading zero appended, but it's then up to the app that retrieves this value(for further processing) what they do with it, like e.g. lame.exe cuts the zero of when setting the "Track" ID3v1.1 tag and/or TRCK ID3v2.3 frame.



The point I was making was that REACT does cut the leading zero off the variable @track@.
Title: REACT 2 Released
Post by: phaedra on 2007-02-16 18:47:27
Will REACT2 work with the new flac 1.1.4?    If so, can I just overwrite the flac.exe file in the ...\REACT2\tools\ directory?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-02-16 19:01:44
The point I was making was that REACT does cut the leading zero off the variable @track@.
Use $track$ to get a leading zero.

Will REACT2 work with the new flac 1.1.4?    If so, can I just overwrite the flac.exe file in the ...\REACT2\tools\ directory?
Yes, no reason why not.
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-17 04:02:02
The point I was making was that REACT does cut the leading zero off the variable @track@.
Use $track$ to get a leading zero.


Thanks!  The next question is this:  Can we come up with a way to have arguments specific to what characters REACT would write for a folder name, and arguments specific to what characters REACT would write for a filename?  Just one example is where there are periods in an album's name, which will be in a folder name.  "Takk..." becomes "Takk" when written out by REACT into the folder name, but for the track called "Takk...", it leaves the periods in the file name.  I am sure there are other cases of this that can happen.  Is there a way to know how REACT will write out the actual filenames so that I can search and replace my cuesheets accordingly?

Edit:  I think currently, as I just tested it, @-surrounded variables aren't filtered according to what is allowed/outputted in a filename, as they are to become the meta-data.  I assume that $-surrounded variables are what EAC uses to build the filenames and what it passes to REACT*.

*Edit2:  I think I got it to work with a combination of @s and $s surrounding various variables, but it wasn't completely straightforward.  For some reason, with the same name for BOTH the album and the title (Takk...), these are what I get:
$album$="Takk"
$title$= "Takk..."
@album@="Takk..."
@title@="Takk..."

So, it looks as if EAC was specifically coded to pass the album string with the knowledge that album names are generally placed in a folder name, thus filtering it as such, but doesn't touch the track information.  Maybe there are cases where it will alter even the track name -> What isn't allowed in a filename?

For this particular case, another problem was that EAC even STILL will output the album title as "Takk..." in the cuesheet, but only in places where there is no folder structure, so I had to use @album@ in my search and replace string to find these specific cases, even though the @ variable's purpose is generally only to be used in metadata situations.
Title: REACT 2 Released
Post by: wraithdu on 2007-02-17 04:17:27
Take note - while $track$ will get you zero-padded values in a directory or file name, metamp3.exe will NOT write the zero-padded value to your id3v1 or id3v2 tags.  I'm not sure about the other meta tagging programs used, as I don't use them.
Title: REACT 2 Released
Post by: phaedra on 2007-02-18 08:50:33
Will REACT2 work with the new flac 1.1.4?    If so, can I just overwrite the flac.exe file in the ...\REACT2\tools\ directory?
Yes, no reason why not.

Hmmmm ...    OK, so I downloaded the new flac (flac-1.1.4-win.zip) and it came with a bunch of files in addition to flac.exe. I think I can ignore most of them but I notice there is a new metaflc.exe and a new dll (in_flac.dll). Should I add these to the  ...\REACT2\tools\ directory in addition to the new flac.exe file?

Thanks very much in advance, and sorry for being so clueless 

- p
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-02-18 08:56:28
Basically, any app already in the REACT tools directory can be overwritten by a newer version.  I think REACT uses metaflac, so you would do well to replace that.  I doubt you need anything else though.
Title: REACT 2 Released
Post by: mmortal03 on 2007-02-18 09:07:08

Will REACT2 work with the new flac 1.1.4?    If so, can I just overwrite the flac.exe file in the ...\REACT2\tools\ directory?
Yes, no reason why not.

Hmmmm ...    OK, so I downloaded the new flac (flac-1.1.4-win.zip) and it came with a bunch of files in addition to flac.exe. I think I can ignore most of them but I notice there is a new metaflc.exe and a new dll (in_flac.dll). Should I add these to the  ...\REACT2\tools\ directory in addition to the new flac.exe file?

Thanks very much in advance, and sorry for being so clueless 

- p


Nope, all you need is the executable (exe file).  The rest are source files, documentation, and the dll is just an alternate format that other programs may use, but not REACT.
Title: REACT 2 Released
Post by: phaedra on 2007-02-19 16:38:41
Basically, any app already in the REACT tools directory can be overwritten by a newer version.  I think REACT uses metaflac, so you would do well to replace that.  I doubt you need anything else though.

@ Syn Soul and mmortal03 ... thank you for your responses. I replaced flac.exe and metaflac.exe and left everything else alone and it seems to be working fine. 

I have one more dumb question tho  . How can I tell if my album art is being embedded in the files? (I'm using F10 to rip to image but then encode to flac and mp3 tracks only) When I check them in MediaMonkey the cover art only displays when a folder.jpg image is present. If I move the folder.jpg out of the directory containing the tracks, then no picture displays.

I've got "EmbedCover=1" in the .ini
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-02-19 16:43:11
The new FLAC image embedding may be too new for MediaMonkey.

I haven't heard of any apps supporting the embedded image as yet (although there may well be some).  I would use metaflac to check.
Title: REACT 2 Released
Post by: Ryushi on 2007-02-19 16:44:41
Hi everyone,

Quote
Changelog for EAC 0.95b3:
Here comes the new EAC 0.95b3. There are several issues fixed, e.g. some CUE sheets could not been written to CD-R using CDRDAO and now it is possible to wait for external compressors to finish the job before powering down the computer. For some users with high ping times (like satellite internet users) there is a new command line option called -slowconnect which will wait longer for a connection to be established, hope that will work better.
For the next version, I will finally implement the test & copy function for CD images, due to many requests.
Good luck with this version!

as we all know there is actually no test© for images and it is uncertain when the new EAC version with this announced feature will arrive

But is it possible to somehow use a kind of test & copy with images in REACT 2?
Maybe make a first fast image-rip in burstmode and calculate a CRC or md5 and then make an image-rip in secure-mode and compress it with wavpack when the CRCs are identically?

Thanks in advance.

Ryushi
Title: REACT 2 Released
Post by: tycho on 2007-02-19 18:43:36
The new FLAC image embedding may be too new for MediaMonkey.

I haven't heard of any apps supporting the embedded image as yet (although there may well be some).  I would use metaflac to check.

Both softpointer (http://softpointer.com/)'s Tag&Rename and AudioShell (free) support embedded album art in FLAC files (and even OGG files). Also developer version of mp3tag (http://developer.mp3tag.de/) (free) since version 2.37d (current 2.37f) support FLAC album art.

Ryushi: Technically, I think it is possible to add test & copy of images with REACT 2 (actually copy & copy), but I won't prioritize that now. First I will update the metamp3.exe tool.
Title: REACT 2 Released
Post by: phaedra on 2007-02-20 06:33:51
Thank you once again Syn Soul and tycho for answering my question. Also thanks so much for such an awesome tool and equally awesome support!! You guys are the best  .  I tried the developer version of MP3Tag and was able to confirm that yes indeed, the cover art is embedded into the picture block of my new flac files!   

There is now just one more thing that I can't figure out. Is it possible to get REACT to create Album Artist tags for single artist albums (i.e. in addition to the ones created for VA albums) in order to facilitate sorting by Album Artist?

Thanks,

- p
Title: REACT 2 Released
Post by: Martin H on 2007-02-20 18:40:46
There is now just one more thing that I can't figure out. Is it possible to get REACT to create Album Artist tags for single artist albums (i.e. in addition to the ones created for VA albums) in order to facilitate sorting by Album Artist?

Hi phaedra

Here are the instructions for editing your "react-image.cfg" to set "album artist" tag in your FLAC and MP3 track files :

In EAC then press ALT+F3. Scroll down untill you come to the "REM ---- Tracks ----" section.

Under the "flac_tracks" section, then you change this line :
Code: [Select]
IF @various@==1 SET VA_tag=-T $qalbum artist=@VA@$q


To instead :
Code: [Select]
SET VA_tag=-T $qalbum artist=@cdartist@$q


Under the "lame_tracks" section, then you change this line :
Code: [Select]
IF @various@==1 SET VA_tag=--user-text $q[album artist]@VA@$q --frame $qTPE2:@VA@$q


To instead :
Code: [Select]
SET VA_tag=--user-text $q[album artist]@cdartist@$q --frame $qTPE2:@cdartist@$q


The above line will by default both make an ID3v2.3 TXXX frame with the description "album artist" and an ID3v2.3 TPE2 frame(a "band" tag). If you only want an "album artist" TXXX frame, then use this line instead :
Code: [Select]
SET VA_tag=--user-text $q[album artist]@cdartist@$q


Or if you only want a TPE2 frame :
Code: [Select]
SET VA_tag=--frame $qTPE2:@cdartist@$q


Edit: To elaborate a little further... Different apps use different ID3v2 frames for defining the "album artist" tag. There isn't defined an "album artist" frame in the ID3v2 spec. so e.g. foobar2000 sets the "album artist" tag by using a TXXX frame with the description "album artist", but e.g. winamp sets it with a TPE2 frame. If you use foobar2000, then i would recommend only setting the "album artist" TXXX frame and if you use winamp, then i would recommend you to set a TPE2 frame and if you use a combination of both, then set both of them.
Title: REACT 2 Released
Post by: phaedra on 2007-02-21 00:32:05
Hi phaedra

Here are the instructions for editing your "react-image.cfg" to set "album artist" tag in your FLAC and MP3 track files :

Hi Martin,

Thank you for the elegant solution (and the detailed explanation). It works perfectly  ! Also thank you for all the great advice you have been giving on this topic and elsewhere in the HA forums. I have learned a lot from you. It's great that people like you with so much knowledge about these things are willing to share it!

All the best  ,

- p
Title: REACT 2 Released
Post by: phaedra on 2007-02-21 08:09:14
Hi again Martin,

Unfortunately there seems to be a small problem with the code you provided  . When I try to rip an album with an ampersand (&) in the title, I get a syntax error and the flac files fail to encode. I also get the error for the lame encode, but the mp3's still get created. I've tried several such albums and always get the same problem.

For example, when I try to rip the album "Mambo Sinuendo" by Ry Cooder & Manuel Galbán, I get the following error message:

Code: [Select]
'Manuel' is not recognized as an internal or external command,
operable program or batch file.
The filename, directory name, or volume label syntax is incorrect.


Any suggestions?

Thanks,

- p

p.s. no problems at all with albums without ampersands 
Title: REACT 2 Released
Post by: tycho on 2007-02-21 09:13:05
This problem is due to the way the acdir command line must be set up. As you want to add "album artist" frame unconditionally, simply replace the string %VA_tag% with
  -T $qalbum artist=@cdartist@$q
in the flac_tracks section, and replace the string %VA_tag% with
  --user-text $q[album artist]@cdartist@$q --frame $qTPE2:@cdartist@$q
in the mp3_tracks section.

And then remove the lines with SET  VA_tag=..., which caused the problem.
Title: REACT 2 Released
Post by: Martin H on 2007-02-21 11:36:06
Also thank you for all the great advice you have been giving on this topic and elsewhere in the HA forums. I have learned a lot from you. It's great that people like you with so much knowledge about these things are willing to share it!

Thank you very much for the kind words, my friend  You are too kind
Unfortunately there seems to be a small problem with the code you provided 

Please accept my apology for this mistake  Luckilly, tycho has kindly provided the correct solution for you to fix this issue  Again, sorry about that

CU, Martin.
Title: REACT 2 Released
Post by: dewey1973 on 2007-02-21 13:52:04
REACT didn't seem to be handling my VA albums correctly so I turned on debugging and this is what I found.  Even though the VA check box in EAC was checked, the @various@ variable was set to 0, not 1.  Does anyone know what might cause this?

I mostly listen to albums so I like to browse artist > album > play on my Karma.  Therefore, I never really liked the VA tagging scheme because the files show up under their track artist in most players.  That means they don't show up together when I browse the way I'm used to browsing.  But EAC won't let me use "Various Artists" as the artist without the check box checking itself.  Can I edit the REACT cfg file so that when the check box is checked, it treats the album like a normal album but replaces the artist tags with what I set the VA variable to in the ini file? It should also use <track title> / <track artist> for the title tag.

Of course, the problem I'm having above would need to be fixed first for this to work.

I am ripping to WavPack images and ogg tracks.
Title: REACT 2 Released
Post by: phaedra on 2007-02-22 06:02:44
As you want to add "album artist" frame unconditionally, simply ...

tycho, first of all, I cannot adequately express my appreciation to you for developing this awesome tool and sharing it with the world ... for free yet!  You are truly an awesome guy!!!  You're a true genius  Also, thank you for taking the time to address my particular issue. It must get frustrating for you after awhile responding to people trying to tweak your already awesome tool but not being able to figure it out for themselves.  I'm just wondering tho  , is there any downside to my desire for wanting to always have a filled in "album artist" field? I thought it would be good in case I want to sort / search my collection by album artist.

Please accept my apology for this mistake  ...

Martin, do not apologise !!!  Your solution works on at least 90% of the albums out there and I really appreciate you making the effort to answer my question ... you're an awesome guy too !!!  Like my Dad says, 'There's more than one way to skin a cat, but some work better than others ...' 

- p
Title: REACT 2 Released
Post by: Martin H on 2007-02-22 11:34:57
tycho, first of all, I cannot adequately express my appreciation to you for developing this awesome tool and sharing it with the world ... for free yet!  You are truly an awesome guy!!!  You're a true genius 

Well said, mate  I wholehartedly agree and he deserves it for sure
Quote
Martin, do not apologise !!!  Your solution works on at least 90% of the albums out there and I really appreciate you making the effort to answer my question ... you're an awesome guy too !!!  Like my Dad says, 'There's more than one way to skin a cat, but some work better than others ...'

Thank you so much, my friend 

Best regards and take care

CU, Martin.
Title: REACT 2 Released
Post by: Ryushi on 2007-02-22 12:16:20
[...]
Ryushi: Technically, I think it is possible to add test & copy of images with REACT 2 (actually copy & copy), but I won't prioritize that now. First I will update the metamp3.exe tool.

Never mind. I am pretty patient  I am waiting since over a year - since Andre announced "T&C image" in EAC - for it and as it look like I have to wait some more months for a native EAC solution.
Maybe I will try to find out how I can implement your suggested "copy & copy"-method into my cfg-file. I remember there was somebody who implement something like that in his REACT1-configuration.

Cya Ryushi

P.S. Many thanks for this very useful tool.
Title: REACT 2 Released
Post by: Bill02888 on 2007-02-24 04:23:28
I'd been using an older version of REACT for a while. Recently had to reinstall Windows so thought it was a good time to use the latest and greatest.

I'm getting an error when albumart.exe tries to start:

"The application failed to initialize properly (0xc0000135). Click on OK to terminate the application."

I tried clicking on albumart.exe in the coverdownloader directory and received the same error. What have I done -- or haven't I done?
Title: REACT 2 Released
Post by: Martin H on 2007-02-24 04:56:32
You need to install the .NET runtimes for that app to work.
Title: REACT 2 Released
Post by: Bill02888 on 2007-02-24 14:21:32
Thanks -- installing .NET did it! How simple!

More questions:

1) The albumart application seems to want to put the image into the root of the C: drive. The "work" directory where I have EAC save the .WAV file is my D:\. Where should I save the album art file so that REACT2 will pick it up and work with it automagically?

2) A long time ago in a galaxy far far away I mentioned preemphasis. I can use SoX to remove that. Is there a simple (ha!) spot where I can put the appropriate sox command so REACT will, if a special deemph flag is set in the REACT.ini file, deemphasize the ripped .WAV file so that all images and tracks that are created from it will sound as the artist originally intended? (Yes, I realize that changing an image may be wrong, and yet, I doubt that any player in existence will play the CD correctly as-is. Doing the deemph before saving to the image is indeed what I think I want!)

3) I'm saving to a Wavpack image and to LAME MP3 tracks. When I use foobar to look at the properties of the resultant MP3 files I see that the comment field is doubled-up: "Created with EAC/REACT2, 2007-02-24; Created with EAC/REACT2, 200". This seems like a possible bug in the .cfg files?

Thanks muchly,
Bill
Title: REACT 2 Released
Post by: Martin H on 2007-02-24 15:46:15
I don't know the answer to your albumart.exe question as i have never used that personally and the pre-emphasis thing i'm also not able to help you with, i'm afraid. For those two questions, then hopefully another more knowledgeble member into this particular area can come to your rescue. The final question about the two "comment" tags being made to the MP3's is because that metamp3.exe by default sets both an ID3v1.1 + an ID3v2.3 tag to the MP3's and so the shortened "comment" tag is the ID3v1.1 tag and the full one is the ID3v2.3 tag. That said, i have never personally seen fb2k display two "comment" tags in the "Properties" dialog of an MP3 track file consisting og both an ID3v1.1 and a ID3v2.3 tag. In this case it would just show the content of the ID3v2.3 tag into the "Properties"dialog.
Title: REACT 2 Released
Post by: phaedra on 2007-02-25 06:24:47
1) The albumart application seems to want to put the image into the root of the C: drive. The "work" directory where I have EAC save the .WAV file is my D:\. Where should I save the album art file so that REACT2 will pick it up and work with it automagically?

Hi Bill,
The cover art has to go to the same directory where REACT puts the temporary files during ripping (otherwise it won't get embedded in your files). You need to specify a directory where REACT will store the temporary ripping files. In EAC, go to "EAC Options" > Directories, then check "Use directory ..." and specify the path to your "work" directory. The cover downloader should also use the same directory for saving images. After setting the path you might have to restart EAC/REACT in order for everything to take effect. 
Title: REACT 2 Released
Post by: dewey1973 on 2007-02-26 03:39:00
Can anyone help me with my Various Artist problem posted above in post 215?
Title: REACT 2 Released
Post by: pholzmann on 2007-02-26 17:46:05
The new version of albumart requires modified command line switches, i.e.

  -ae on -pf on -ar "artist" -al "album" -p "save path-name.jpg"

I don't see anywhere in react's ini/cfg files to set this up. Any hints?
Title: REACT 2 Released
Post by: Martin H on 2007-02-26 19:50:24
Can anyone help me with my Various Artist problem posted above in post 215?

Sorry, mate - I personally wasen't ignoring you, but i just didn't know the answer to your questions, unfortunetly
Title: REACT 2 Released
Post by: wraithdu on 2007-02-26 22:13:46
The new version of albumart requires modified command line switches, i.e.

  -ae on -pf on -ar "artist" -al "album" -p "save path-name.jpg"

I don't see anywhere in react's ini/cfg files to set this up. Any hints?

I see this too, now that you mention it (I've been lazy getting the new version so I hadn't noticed).  I'd say until REACT2 is updated to support it, stick with the last supported version.  I guess the parameters passed to albumart are hardcoded into the REACT .exe.
Title: REACT 2 Released
Post by: tycho on 2007-02-27 06:42:45
REACT didn't seem to be handling my VA albums correctly so I turned on debugging and this is what I found.  Even though the VA check box in EAC was checked, the @various@ variable was set to 0, not 1.  Does anyone know what might cause this?

I mostly listen to albums so I like to browse artist > album > play on my Karma.  Therefore, I never really liked the VA tagging scheme because the files show up under their track artist in most players.  That means they don't show up together when I browse the way I'm used to browsing.  But EAC won't let me use "Various Artists" as the artist without the check box checking itself.  Can I edit the REACT cfg file so that when the check box is checked, it treats the album like a normal album but replaces the artist tags with what I set the VA variable to in the ini file? It should also use <track title> / <track artist> for the title tag.

Of course, the problem I'm having above would need to be fixed first for this to work.

I am ripping to WavPack images and ogg tracks.

For your first question, you must set EAC's file naming sceme to start with '%D -', to recognise that the filename start with "Various -" (or "Various Artists -").

For the next Q, in the OGG section, you must replace '-c artist=$#a' with '-c artist=$q@cdartist@$q'. This works because @cdartist@ equals @VA@ when @various@=1, otherwise it equals @artist@.

@Bill: I have added back the support for removing preemph (deemph) these rare CDs in the next version of REACT.
Title: REACT 2 Released
Post by: pholzmann on 2007-02-27 13:13:19
I have a strange one:

* creating flac image and mp3 files
* flac is NOT created, MP3's ARE
* debug run shows the problem but I don't know how to fix it:

- the flac run fails because the eac log file does not exist
- yet the file DOES exist by the time I look

Sounds like a race condition of some kind?

Have others seen this?
Title: REACT 2 Released
Post by: pholzmann on 2007-02-27 13:29:21
* debug run shows the problem but I don't know how to fix it:

- the flac run fails because the eac log file does not exist
- yet the file DOES exist by the time I look

OK, now I watched everything carefully. I'm sure this must be simple:

When EAC finishes ripping, it puts up a dialog with an "OK" button.

The log file is not created until I press "OK".

I assume REACT wants this dialog disabled somehow? How do I do that?

Thanks muchly!
Title: REACT 2 Released
Post by: Martin H on 2007-02-27 14:09:57
Hi pholzmann.

Something is very wrong with your setup, as REACT will auto-close that dialog automatically, so that the logfile is made. Please reconfigure REACT with your EAC setup by pressing CTRL+F2 and see if the problem persists. If the problem dosen't go away, then i'm affraid that i cannot help you unfortunetly and you must then wait for Tycho to come to your rescue.
Title: REACT 2 Released
Post by: wraithdu on 2007-02-27 16:26:00
That's interesting.  The rip report dialog doesn't autoclose on my machine either, but I have not had any errors complaining the eaclog is missing, and I believe it is still embedded in my flac images.  I have REACT2 correctly configured in EAC (Ctrl-F2).
Title: REACT 2 Released
Post by: pholzmann on 2007-02-27 19:02:19
Something is very wrong with your setup, as REACT will auto-close that dialog automatically, so that the logfile is made. Please reconfigure REACT with your EAC setup by pressing CTRL+F2 and see if the problem persists. If the problem dosen't go away, then i'm affraid that i cannot help you unfortunetly and you must then wait for Tycho to come to your rescue.
Good idea, Martin! At least that made it act a bit differently

Now I get two consistent log errors in flac:
- unable to extract resolution and color info from file (that's new... and the file is fine)
- can't open file

AND the log file is definitely NOT created, and the dialog box is NOT auto-closed.

I'm running on a duo-core XPSP2 laptop.

I tried reducing the "simultaneous background thread" count to one, but that didn't change anything.
I tried turning off run-in-background, but ctrl-F2 reconfigure turned it back on so I assume it is required.

Anybody else have ideas? I feel sooo close yet so far away

Thanks muchly for all suggestions!
MrPete

Code: [Select]
E:\media\Music\eac>IF 1 == 1 SET Cover_tag=--picture="|image/jpeg|||E:\media\Music\eac\The Passionate Pursuit.jpg"

E:\media\Music\eac>C:\apps\media\audio\REACT2\tools\flac.exe -5 -f --replay-gain
--picture="|image/jpeg|||E:\media\Music\eac\The Passionate Pursuit.jpg" -T "artist=Scott Wesley Brown"
 -T album="The Passionate Pursuit" -T totaltracks="11" -T date="1991" -T genre="Worship"
-T comment="Created with EAC/REACT2, 2007-02-27" -T encoded-by="Pete" -T encoding="Flac 1.1.3 -5 -f"
--tag-from-file="cuesheet=E:\media\Music\eac\Scott Wesley Brown - [1991] The Passionate Pursuit.cue"
--tag-from-file="eaclog=E:\media\Music\eac\The Passionate Pursuit.log"
"E:\media\Music\eac\Stmp54266.wav"
-o "E:\media\Music\eac\Scott Wesley Brown - [1991] The Passionate Pursuit.flac"

ERROR: (--picture) unable to extract resolution and color info from file, user must set explicitly
Type "flac" for a usage summary or "flac --help" for all options
ERROR: (--tag-from-file) can't open file for tag value
Type "flac" for a usage summary or "flac --help" for all options

(PS: If I could, I'd change my handle to MrPete which is how i'm known elsewhere )
Title: REACT 2 Released
Post by: pholzmann on 2007-02-28 02:47:21
A small bug found: in a workflow of image->mp3 tracks, if (eac? ac? not sure what?) decides there is a blank character at the end of the name of a song, it never gets trimmed... resulting in a pain-in-the-neck mp3 filename "xyzzy .mp3"

Can spare spaces be trimmed?
Title: REACT 2 Released
Post by: Martin H on 2007-02-28 16:08:30
Hi MrPete

The first error you get is about the Cover-image which flac.exe cannot retrieve the color and resolution from automatically and hence, wants you to enter those parameters manually. I'm personally not into cover-art myself, so i'm affraid that i can't help you with that, since i have never used those options of flac.exe before. The second error is then as you have found, about the missing logfile. I'm sure that REACT will do this during it's setup, but just in case, then please check if you have this option enabled : EAC options > Tools > "Automatically write status report after extraction". If that option is enabled, then i would recommend that you go into regedit(WinKey+R > "regedit") and delete the key : "HKEY_CURRENT_USER\Software\AWSoftware"(rightclick > Delete) and then reconfigure EAC and install REACT again. I have also had to do this on occasions because EAC acted funny, but i haven't experienced your problem though. This is the only advice that i can give you, but of course you are welcome to instead wait untill Tycho comes along and then hear his take on this issue

@wraithdu

There are two dialogs. the first one is the one that REACT auto-closes, and the next one is the one that e.g. states "Copy OK" and "No errors occured" etc. and this one isn't auto-closed
Title: REACT 2 Released
Post by: wraithdu on 2007-02-28 18:32:36
@Martin
Ahhh, thanks for pointing that out.  Makes sense then that I've never seen it
Title: REACT 2 Released
Post by: pholzmann on 2007-03-01 10:19:26
Question: EAC V0.95 beta 4 comes in two flavors: with/without CDRDAO.

Is it possible that it would matter which one I use? Which one are YOU using?

Thanks.
Title: REACT 2 Released
Post by: Martin H on 2007-03-01 11:22:22
Is it possible that it would matter which one I use?

No, since that is entirely writing-only related.
Quote
Which one are YOU using?

I am personally using the version without cdrdao.exe. If you want to use EAC to also write audio CD's, then check to see if your drive works with EAC's internal writing routines. If it does, then you don't need the EAC version with cdrdao.exe, since that version is only meant for people with drives that dosen't work with it and also on many drives then CD-TEXT writing isn't possible with EAC's cdrdao frontend. My drive only works with EAC's cdrdao frontend, but since i'm not using EAC to write audio CD's, then i'm sticking to the version without it. I personally use Burrrn (http://www.burrrn.net/?page_id=4) to write all my audio CDs, since besides beeing an awesome non-bloated and well-coded app, then it also supports writing WavPack images with embedded cuesheets.
Title: REACT 2 Released
Post by: wraithdu on 2007-03-01 14:50:53
I personally use Burrrn (http://www.burrrn.net/?page_id=4) to write all my audio CDs, since besides beeing an awesome non-bloated and well-coded app, then it also supports writing WavPack images with embedded cuesheets.

I am waiting for this great app to support write offsets hopefully in the near future.  I wrote my first totally offset corrected CD with EAC the other night (individual read and write offsets) and all track CRCs matched up with the AccurateRip database after a test of the copy!  I was really shocked and pleased, as this is the first time I've accomplished this.



Secondly, how can I modify the REACT2 .ini to work with the new version of Albumart Downloader?  It has some different commandline switches for search and path options.
Title: REACT 2 Released
Post by: phaedra on 2007-03-01 16:38:32
... how can I modify the REACT2 .ini to work with the new version of Albumart Downloader?

Hi wraithdu,

You don't have to modify the REACT2 .ini ... all you have to do is overwrite the old with the new (i.e. change the folder name of the new Albumart Downloader program from "AlbumArtDownloader" to "coverdownloader" and place it in your REACT2 folder, overwriting the old "coverdownloader" folder. At least that worked for me. 

Also if you want any scripts from the old coverdownloader that aren't included in the new version (such as Walmart.boo), you can just copy them over to the new version "as is" and they will work. 

- p
Title: REACT 2 Released
Post by: wraithdu on 2007-03-01 17:00:13
You don't have to modify the REACT2 .ini ... all you have to do is overwrite the old with the new (i.e. change the folder name of the new Albumart Downloader program from "AlbumArtDownloader" to "coverdownloader" and place it in your REACT2 folder, overwriting the old "coverdownloader" folder. At least that worked for me. 

And this works?  I know the commandline switches for the newest version of the downloader are different.  Is it still being passed the correct information for search and download path?  This seems unlikely to me.  I'm sure the program is still executed, but...I will definitely test it when I get home.
Title: REACT 2 Released
Post by: pholzmann on 2007-03-01 19:16:55
You don't have to modify the REACT2 .ini ... all you have to do is overwrite the old with the new (i.e. change the folder name of the new Albumart Downloader program from "AlbumArtDownloader" to "coverdownloader" and place it in your REACT2 folder, overwriting the old "coverdownloader" folder. At least that worked for me. 


phaedra, perhaps you are not using the truly new version? It has very different command line parameters and does not work at all with REACT2

At least, not for me!
Title: REACT 2 Released
Post by: mc365mc on 2007-03-04 22:24:58
How do I change the nameing scheme for TrackName_SA_acdir?

What parameters can I use to  get my FLAC split and named artist-album-track-title?

Thanks
Title: REACT 2 Released
Post by: pholzmann on 2007-03-04 22:28:59
...you are welcome to instead wait untill Tycho comes along and then hear his take on this issue

I've reinstalled everything. Nothing helped.

I think I have a clue about the issue though. I use the dbPowerAmp AccurateRip plugin for EAC to ensure I'm getting good rips. I think the extra UI for that is unknown to REACT. If only we could add our own plugin-related handling!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-03-04 22:32:24
How do I change the nameing scheme for TrackName_SA_acdir?

What parameters can I use to  get my FLAC split and named artist-album-track-title?
1. Check "react.ini"

2. Use "$~A-$~T-$n-$~t"
Title: REACT 2 Released
Post by: mc365mc on 2007-03-08 05:43:25
One more ? or maybe 2.

I'm using all the new flac and metaflac tools but the dialog window says that I'm using flac v1.1.3

Is this just an oversight in the coding of the latest version that was not updated?

I downloaded the package from rarewares I think,  I't was call flac-1.1.4.zip


and could you point me to a good thread or post detailing how to embed the cue sheet as well as save one externaly
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-03-08 07:07:57
Unless you have amended the config REACT will be using the FLAC exe in your REACT\tools directory.

Personally I like to only maintain one version on my PC, so my recommendation would be to amend the config to point to your 1.1.4 exe.  An easier solution is to copy the new exe over the exe in \tools though.

I don't have REACT on this laptop, so I can't give you code or line numbers, but essentially you will need to delete the line that deletes the cuesheet, and have it moved with all the other files.
Title: REACT 2 Released
Post by: Martin H on 2007-03-08 10:41:58
and could you point me to a good thread or post detailing how to embed the cue sheet as well as save one externaly

REACT will by default embed the cuesheet and also copy an external cuesheet into the destination directory, so if that is what you want, then you don't have to do anything.

For people, like me, which don't want to have an additional external cuesheet, then they need to open the REACT-image.cfg file(ALT+F3 in EAC) and then find the section for the image format that you have selected in the REACT.ini, like e.g. "wavpack_image" if you had selected ".wv" as image extension in the REACT.ini, or "flac_image" if you had selected ".flac" in the REACT.ini and then enter REM in front of this line : "MOVE /Y "@cuesheet@" %dest%", so it becomes : "REM MOVE /Y "@cuesheet@" %dest%". The reason that i don't want an external cuesheet, is that the two apps that i use for music playback and music writing(fb2k (http://www.foobar2000.org/) and Burrrn (http://www.burrrn.net/?page_id=4)), both supports embedded cuesheets perfectly and so i have no use for an external cuesheet in that case. Also, it just takes a single parameter with Synthetic Soul's ammended Tag.exe (http://www.synthetic-soul.co.uk/tag/) version to get the cuesheet extracted, or to use wvunpack.exe to decode the image to WAV and additionally extract the cuesheet.

Please note, that i'm not trying to persuade anyone into ditching the external cuesheet, but i'm only adding these instructions to help people out, which feel that they don't want the "by-default-made" external cuesheet either.
Title: REACT 2 Released
Post by: mc365mc on 2007-03-09 02:11:17
Unless you have amended the config REACT will be using the FLAC exe in your REACT\tools directory.


Yes I have overwritten Flac.exe and metaflac in the react\tools directory.

I even did this twice as I thought the download package I had was old.

The last package I got from the flac page linked in these forums once it was updated.

I also thought it might have been the libflac.dll but read that that is for decoding and does not need to be changed to ge the encoding benifits of v1.1.4

Maybe I'll delete it reboot then place the new files in the tools folder.




I will most likey need the external cuesheet becuase I use rockbox on my Ipod and it cant read embedded cuesheets, neither does XBMC which I use a a media server.
Title: REACT 2 Released
Post by: pholzmann on 2007-03-10 21:48:36
I use the dbPowerAmp AccurateRip plugin for EAC to ensure I'm getting good rips. I think the extra UI for that is unknown to REACT. If only we could add our own plugin-related handling!

Question: Does anyone use REACT together with AccurateRip?
Title: REACT 2 Released
Post by: mogorp on 2007-03-10 23:48:21
Yes,
I use react with accuraterip.  It works fine.  You set up accurate rip for eac.  Then you have to rip tracks not an image.  For this I changed trackshotval to F6 and rip test and copy in burst mode.  If accuraterip has the info from the cd great, if not I check the eac log for the same crc in test and copy.  I consider it a good rip if accuraterip says it is good or if the crc's of test and copy match.  The great thing about EAC and react is that I can rip with 2 different drives at the same time.
Title: REACT 2 Released
Post by: Bill02888 on 2007-03-17 17:34:16
Yes,
I use react with accuraterip.  It works fine.  You set up accurate rip for eac.  Then you have to rip tracks not an image.  For this I changed trackshotval to F6 and rip test and copy in burst mode.  If accuraterip has the info from the cd great, if not I check the eac log for the same crc in test and copy.  I consider it a good rip if accuraterip says it is good or if the crc's of test and copy match.  The great thing about EAC and react is that I can rip with 2 different drives at the same time.

Edit: Are you saying that AccurateRip won't work unless EAC rips tracks to individual WAV files? If ...

So what's the "best way" to get the best of all worlds? I've configured REACT 2 to rip to WavPack image files and to LAME MP3 track files, but I also want to get feedback from AccurateRip.

- Bill
Title: REACT 2 Released
Post by: Nik on 2007-03-18 00:21:47
Yes,
I use react with accuraterip.  It works fine.  You set up accurate rip for eac.  Then you have to rip tracks not an image.  For this I changed trackshotval to F6 and rip test and copy in burst mode.  If accuraterip has the info from the cd great, if not I check the eac log for the same crc in test and copy.  I consider it a good rip if accuraterip says it is good or if the crc's of test and copy match.  The great thing about EAC and react is that I can rip with 2 different drives at the same time.

Edit: Are you saying that AccurateRip won't work unless EAC rips tracks to individual WAV files? If ...

So what's the "best way" to get the best of all worlds? I've configured REACT 2 to rip to WavPack image files and to LAME MP3 track files, but I also want to get feedback from AccurateRip.

- Bill

Because I found my desktop drive/EAC combination inconsistent/unreliable, I need AccurateRip too.
And I want to rip CD into individual flac and mp3 files.
But I also want to have external cue sheets, so I can re-create audio CD from flac and cue sheets using Burrrn.
Is that two possible i.e. don't exclude each other?

I think that I read that I need to rip in track mode for AccurateRip to work
And also, I think that I read that I need to rip in image mode to produce cue sheets.
Title: REACT 2 Released
Post by: mogorp on 2007-03-18 02:52:46
You can rip in track mode and create cue sheets with your flac files.  This is not a problem.  Accuraterip will only work if you are ripping in track mode.
Title: REACT 2 Released
Post by: Nik on 2007-03-18 13:40:27
You can rip in track mode and create cue sheets with your flac files.  This is not a problem.  Accuraterip will only work if you are ripping in track mode.

Thanks,
Now I have to go throuhg all the settings to figure out how.  .
It's a shame that such a great piece of software doesn't have a GUI, for those basic settings, at least.
It seems that it's so flexoble that it can fulfill almost any demand.
Title: REACT 2 Released
Post by: mogorp on 2007-03-18 19:31:13
open Eac/react
Hit alt f2 and set CreateAllCuesheets=1

Go to your react folder and open REACT-track.cfg.

make sure this line is in your config under flac section

IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"

I have the config below for flac tracks

IF NOT @Flac@==1 GOTO end_flac_tracks
   IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
   PUSHD %TrackDir_Flac%
      IF @various@==1 SET VA_tag=-T "album artist=@VA@"
      IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
      ECHO ON
      @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" "@source@" -o "%TrackName%.flac"
      @ECHO OFF
      IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
      IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"
      COPY /Y "@eaclog@" "EAClog.txt"
   POPD
:end_flac_tracks

The other thing I find helpful is to rip in burst mode with test and copy.  This way if accuraterip doesn't not have the album, you can check the eac crc log.  If a track has the same crc for test and copy it is more likely correct (or consistently wrong).  To rip in burst mode you can edit the react ini file to TracksHotVal=+{F6}.  Then when you hit f4, it will rip in test and copy mode.  Hope this helps.
Title: REACT 2 Released
Post by: Sully on 2007-03-19 15:36:00
Per a response from SyntheticSoul, I am reposting a question I posted yesterday in the REACT v1 thread here (http://www.hydrogenaudio.org/forums/index.php?showtopic=35158&st=475&p=445927&#entry445927):

I've also put part of his reply here in quotes, on the off chance someone might be able to parse the settings I have, as well as help me make the leap to REACT 2.

Thanks (in advance) for your help!
Sully

Quote
I see no reason to change anything else (not that I've scrutinised your INI). If it worked before it should work now.

I guess I should tell you that you really should move to v2. However, as you know, I have not yet made the switch myself. That said, I am not getting much time to provide support on this forum at the moment anyway; you may do best to ask for help in the v2 thread switching this config to a v2 config. I really don't think it would be much effort.
Title: REACT 2 Released
Post by: gsa999 on 2007-03-21 16:59:15
my recommendation would be to amend the config to point to your 1.1.4 exe.


Hi can you tell me where I change this in the config. I also want to change LAME to point to my seperate LAME folder, rather than the ones in the tools folder.

Thanks
G
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-03-21 17:19:25
In your CFG file, change any instance of @tools@\flac.exe or @tools@\lame.exe to the path to your EXEs.

Remember to surround the path in quotes if it has spaces.

E.g.:

Code: [Select]
@tools@\flac.exe @Opt_Flac@ %RG_Flac% %Cover_tag% -T "%ArtistField%=@cdartist@" -T album="@album@" -T totaltracks="@numtracks@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" --tag-from-file="cuesheet=@cuesheet@" --tag-from-file="eaclog=@eaclog@" "@source@" -o "@image@"

to:

Code: [Select]
"C:\Program Files\FLAC\flac.exe" @Opt_Flac@ %RG_Flac% %Cover_tag% -T "%ArtistField%=@cdartist@" -T album="@album@" -T totaltracks="@numtracks@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" --tag-from-file="cuesheet=@cuesheet@" --tag-from-file="eaclog=@eaclog@" "@source@" -o "@image@"


If your FLAC and LAME EXEs are in the same place you could just change the @tools@ path in the INI file:

Code: [Select]
Tools=C:\Program Files\REACT2\tools

... to:
Code: [Select]
Tools=C:\Program Files\My Audio Tools


If FLAC.EXE and LAME.EXE are in a folder in PATH (like your Windows folder) you can just remove the @tools@\ bit, e.g.:

Code: [Select]
flac.exe @Opt_Flac@ %RG_Flac% %Cover_tag% -T "%ArtistField%=@cdartist@" -T album="@album@" -T totaltracks="@numtracks@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" --tag-from-file="cuesheet=@cuesheet@" --tag-from-file="eaclog=@eaclog@" "@source@" -o "@image@"
Title: REACT 2 Released
Post by: TheChipstar on 2007-03-22 09:20:17
I have read through some of the recent posts, but not all of the pages...was just wondering if the newest version "Album Art Downloader" is implimented in React?
Does the artist and album get looked up automatically or?

Thanks.
Title: REACT 2 Released
Post by: TheChipstar on 2007-03-22 10:00:40
Or is "Album Art Downloader" totally seperate form "CoverArt downloader"?
Title: REACT 2 Released
Post by: wraithdu on 2007-03-22 15:43:53
The original program was CoverDownloader.  Development was taken over by AlexVallet and one other individual, and was renamed AlbumArt Downloader.  The newest preview release, AlbumArt XUI, is again compatible with REACT2.  Just change the path in the react.ini file to point to your XUI installation.
Title: REACT 2 Released
Post by: dewey1973 on 2007-03-22 18:02:15
REACT seems to be ignoring my ImageNaming parameter.  I set the parameter to:

ImageNaming=$album$ [$year$]

but the files are being saved as if it is still using the default:

ImageNaming=$artist$ - [$year$] $album$

Can anyone tell me how to fix this?
Title: REACT 2 Released
Post by: Chicoughski on 2007-03-22 19:01:09
I was wondering if anyone knows if REACT can be run on an existing WAV/CUE image ripped by EAC? I have REACT running great for rips - configured to rip to FLAC, embed cue and art, then split and compress LAME files for everyday listening.  The thing is, I got this running AFTER having simply ripped a lot of discs to WAV image + CUE sheet with EAC, so I was wondering if I could run through all those WAV images with the same settings (FLAC archive image + LAME files), instead of re-ripping all of them.

Any help is appreciated, I'm not an expert with EAC...

Thanks
Title: REACT 2 Released
Post by: gsa999 on 2007-03-22 19:40:34
A few REACT2 questions for a new user

1. When using REACT, does it matter what settings are applied in EAC itself. Prior to using REACT I had profiles for MP3, FLAC, AAC etc. My question is whether it matters as to which one of these is actually loaded when I use REACT. Presumably the ini and cfg files will overwrite all the EAC compression settings.

2. Can the coverartdownloader be set so that you can browse the hard disk for the images. I have most of them already and want to use them as they are better quality than those on the search sites

3. I am a little lost about how to set up the cover art bits? I want to embed the image into my flac image, all my flac tracks, all my mp3 tracks AND copy it as folder.jpg to the folders where the individual flac and mp3 tracks are. How do I do this?

4. Can the format of @curdate@ be changed to UK date format?

5. I can't seem to get tracknumbers with a padded space (ie 01, 02, 03 etc) on MP3's using LAME. FLAC works fine. I am using the image cfg to generate tracks as well

6. What does this hotkey actually do - TracksHotVal=+{F5}

Thanks
G
Title: REACT 2 Released
Post by: Nik on 2007-03-23 01:18:31
open Eac/react
Hit alt f2 and set CreateAllCuesheets=1

Go to your react folder and open REACT-track.cfg.

make sure this line is in your config under flac section

IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"

I have the config below for flac tracks

IF NOT @Flac@==1 GOTO end_flac_tracks
   IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
   PUSHD %TrackDir_Flac%
      IF @various@==1 SET VA_tag=-T "album artist=@VA@"
      IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
      ECHO ON
      @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" "@source@" -o "%TrackName%.flac"
      @ECHO OFF
      IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
      IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"
      COPY /Y "@eaclog@" "EAClog.txt"
   POPD
:end_flac_tracks

The other thing I find helpful is to rip in burst mode with test and copy.  This way if accuraterip doesn't not have the album, you can check the eac crc log.  If a track has the same crc for test and copy it is more likely correct (or consistently wrong).  To rip in burst mode you can edit the react ini file to TracksHotVal=+{F6}.  Then when you hit f4, it will rip in test and copy mode.  Hope this helps.


Thanks.
It works (partialy).
Both cue sheet and log file are copied.
However, I noticed that cue sheet files are not processed i.e. they point to wav files instead of flac files.
Because I don't keep wav files, they are useless.
I know that I can process them manually using e.g. burrrn, but I want to automate things.
I thought that REACT will process them, similar to Flacattack so they can be used for re-creating audio CD.
Title: REACT 2 Released
Post by: phaedra on 2007-03-23 16:29:49
The newest preview release, AlbumArt XUI, is again compatible with REACT2

Thanks for getting that done.
Title: REACT 2 Released
Post by: Martin H on 2007-03-23 17:14:42
However, I noticed that cue sheet files are not processed i.e. they point to wav files instead of flac files.

Download Tangerine's cuemod.exe (http://tangerine.uw.hu/prog/cuemod_060406.rar) and place it into 'C:\Program Files\REACT2\tools'.

Open 'REACT-tracks.cfg' and add this line to the FLAC tracks section :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" MOVE /Y "@albumfile@.[mg].cue" "@basename@.cue"


Under that line, then add this line :
Code: [Select]
@tools@\cuemod.exe --cue "@basename@.cue" --f "%TrackName%.flac"


If you have added this line previously, then delete it(not in the .cfg originally) :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"


Edit: Sorry, disregard this post. I was thinking about image ripping and image cuesheets, but this would not work for track cuesheets(atleast not in the present way and i don't think that you can use: "--f *.flac" with cuemod.exe). Again, sorry about this.
Title: REACT 2 Released
Post by: Nik on 2007-03-26 23:25:02

However, I noticed that cue sheet files are not processed i.e. they point to wav files instead of flac files.

Download Tangerine's cuemod.exe (http://tangerine.uw.hu/prog/cuemod_060406.rar) and place it into 'C:\Program Files\REACT2\tools'.

Open 'REACT-tracks.cfg' and add this line to the FLAC tracks section :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" MOVE /Y "@albumfile@.[mg].cue" "@basename@.cue"


Under that line, then add this line :
Code: [Select]
@tools@\cuemod.exe --cue "@basename@.cue" --f "%TrackName%.flac"


If you have added this line previously, then delete it(not in the .cfg originally) :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"


Edit: Sorry, disregard this post. I was thinking about image ripping and image cuesheets, but this would not work for track cuesheets(atleast not in the present way and i don't think that you can use: "--f *.flac" with cuemod.exe). Again, sorry about this.

No problem.
Thanks for the try  .
I can't believe that nobody does cue sheets in track mode.
Somene must have come to the solution.
I need track mode to be able to use AccurateRip.
Title: REACT 2 Released
Post by: Nik on 2007-03-26 23:36:42
I was fed up looking for descriptions for parameters in REACT.ini, so I put them all in a file as comments.
During the process I learned them  , but some newbies might find them useful.
Even me in a few months time.
It replaces the content of original REACT.ini

Code: [Select]
; This file defines variables used by .cfg files
; In [User...] sections any KEY=VALUE defines a variable @KEY@,
; which gets expanded to VALUE in the .cfg files.
; Furter, $KEY$ will be file friendly version - illegal characters for creating file names will
; be replaced with legal ones using scheme defined in variable Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt

[Settings]
Version=2.0
ImageExt=wav
; image mode only, extension for the compressed image file + cue file
; (e.g. flac, wv or mp3). Set to wav for no image file
ImageNaming=$artist$ - [$year$] $album$
; image mode only, naming for image files and their cuesheets. Available variables are:
; $album$, $artist$, $year$, $genre$ and $freedb$ and are populated from EAC textboxes.
ImageHotKey={F10}
; defines hotkey for image mode
; activates menu command Action/Copy Image and Create Cue Sheet.../Uncompressed in EAC
TracksHotKey={F4}
; defines hotkey for track mode
; activates Shift[TracksHotVal] in EAC (Shift+F5 by default)
; and optionally coverart downloader.
TracksHotVal=+{F5}
; if you want TracksHotKey to activate Shift+F6 instead of Shift+F5 in EAC
; then change +{F5} into +{F6}
VA=Various Artists
; variable describing various artists.
; @CDARTIST@ will hold this value for Various Artists album
; @CDARTIST@ = @artist@ for single artist CDs
CreateAllCuesheets=0
; create all 4 types of cuesheets in extraction folder defined in EAC
; cuesheet base name can be accessed using @albumfile@ variable
RunCoverDownloader=1
; if not 0 runs albumart.exe, cover art downloading application
; 1 - makes albumart wait until it's closed before starting copying in Tracks mode
; 2 - makes albumart wait until it's closed before starting copying in both modes
; 3 - makes albumart wait until it's closed before starting copying in Image mode
; 4 - doesn't wait
CoverDownloader=C:\Program Files\REACT2\coverdownloader\albumart.exe
; path to cover art downloading application executable
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
; path to EAC executable
Tools=C:\Program Files\REACT2\tools
; path to tools folder
MinimizeCompressionWindow=1
;
ProcessPriority=1
;
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]
; character replacing scheme for replacing characters in @variable@ type variables
; which cannot be used for creating file names, thus creating $variable$ type variables
; EAC uses scheme:
; (Slash) / => ,
; (Backslash) \ => cuts off everything after
; (Colon) : => -
; (Questionmark) ? => (space)
; (Bar or pipe) | =>
; (Double quotes) " => '
; (Asterisk) * => x
; (Less then) < => [
; (Greater then) > => ]

[UserTrackFormats]
Flac=0 ; create flac files (0-no, 1-yes)
Wavpack=1 ; create wavpack files (0-no, 1-yes)
LameMP3=1 ; create mp3 files (0-no, 1-yes)
NeroAac=0 ; create Nero AAC files (0-no, 1-yes)
iTunesAac=0 ; create iTunes AAC files (0-no, 1-yes)
OggEnc2=0 ; create Ogg Vorbis files (0-no, 1-yes)

[UserOutputNames]
OutRoot=@mymusic@\EAC
; music root folder, common for all formats.
; @mymusic@ variable contains path to My Music folder in Windows (usually under My Documents)
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
; folder containing FLAC image files
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
; folder containing Wavepack image files
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
; folder containing mp3 image files
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\[$year$] $album$
; folder containing flac tracks
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\[$year$] $album$
; folder containing wavpack tracks
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\[$year$] $album$
; folder containing mp3 tracks
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
; folder containing AAC tracks
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
; folder containing ogg tracks
TrackName_SA=$track$ - $title$
; file names for single artist albums
TrackName_VA=$track$ - $title$ [$artist$]
; file names for various artists albums
TrackName_SA_acdir=$n - $~t
; file names for single artist albums, when tracks are created from image file
; using acdir. Image mode only
TrackName_VA_acdir=$n - $~t [$~a]
; file names for various artists albums, when tracks are created from image file
; using acdir. Image mode only

[UserSettings]
Debug=0
; 0 or 1. If 1 REACT will pause before exiting, so it's possible to examine console output
Comment=Created with EAC/REACT2, @curdate@
; Overrides the default @comment@ variable taken from EAC.
; You can comment it if you want to use value from EAC
EmbedCover=1
; 0-no, 1-yes. Embed cover pictures into the audio files.
ReplayGain=1
; Enables Replay Gain calculation and tagging
ApplyAlbumGain=1
; Applies Album Gain
AdjustAlbumGain_dB=+3.0
; Default value for Replay Gain adjustment is 89dB. Here you can adjust it to some other
; value, relative to the default one (e.g. make them sound louder for iPod)
AddCuesheetAG=0
; Adds Album gain and Album peak values to cuesheet as REM lines. Using WaveGain
UseWaveGainAG=0
; Use WaveGain to calculate Album Gain values on the wav image file. Values will be
; transferred to the various compressed formats, rather then being calculated with other tools.
Opt_Flac=-5 -f
; command line options for flac encoder
Opt_Wavpack=-hmy
; command line options for wavpack encoder
Opt_LameMP3=-V5 --vbr-new --noreplaygain --nohist
; command line options for Lame mp3 encoder
Opt_NeroAac=-lc -q 0.21
; command line options for Nero AAC encoder
Opt_iTunesAac=-d -s 2000
; command line options for iTunes AAC encoder
Opt_OggEnc2=-q 3.0
; command line options for Ogg encoder
Ver_Flac=1.1.3
; flac encoder version
Ver_Wavpack=4.40
; wavpack encoder version
Ver_LameMP3=3.97
; Lame mp3 encoder version
Ver_NeroAac=1.0.0.2
; nero AAC encoder version
Ver_OggEnc2=2.83 Lancer aoTuV b5
; Ogg encoder version

Probably it could be useful to put it in original package if author checks the content and someone tests it properly.
I tested it for me and it seems that it works.
I changed a few parameters to suit me and it still works.
Title: REACT 2 Released
Post by: feelgood on 2007-03-27 11:24:02
I was wondering if anyone knows if REACT can be run on an existing WAV/CUE image ripped by EAC? I have REACT running great for rips - configured to rip to FLAC, embed cue and art, then split and compress LAME files for everyday listening.  The thing is, I got this running AFTER having simply ripped a lot of discs to WAV image + CUE sheet with EAC, so I was wondering if I could run through all those WAV images with the same settings (FLAC archive image + LAME files), instead of re-ripping all of them.

I'm in a similar situation. Please, let us know if there's a solution, thanks!
Title: REACT 2 Released
Post by: gsa999 on 2007-03-27 13:38:30
A few REACT2 questions for a new user

1. When using REACT, does it matter what settings are applied in EAC itself. Prior to using REACT I had profiles for MP3, FLAC, AAC etc. My question is whether it matters as to which one of these is actually loaded when I use REACT. Presumably the ini and cfg files will overwrite all the EAC compression settings.

2. Can the coverartdownloader be set so that you can browse the hard disk for the images. I have most of them already and want to use them as they are better quality than those on the search sites

3. I am a little lost about how to set up the cover art bits? I want to embed the image into my flac image, all my flac tracks, all my mp3 tracks AND copy it as folder.jpg to the folders where the individual flac and mp3 tracks are. How do I do this?

4. Can the format of @curdate@ be changed to UK date format?

5. I can't seem to get tracknumbers with a padded space (ie 01, 02, 03 etc) on MP3's using LAME. FLAC works fine. I am using the image cfg to generate tracks as well

6. What does this hotkey actually do - TracksHotVal=+{F5}

Any one have any thoughts for me on these questions. Nos 2-5 in particular. Thanks
Title: REACT 2 Released
Post by: wraithdu on 2007-03-27 17:07:46

I was wondering if anyone knows if REACT can be run on an existing WAV/CUE image ripped by EAC? I have REACT running great for rips - configured to rip to FLAC, embed cue and art, then split and compress LAME files for everyday listening.  The thing is, I got this running AFTER having simply ripped a lot of discs to WAV image + CUE sheet with EAC, so I was wondering if I could run through all those WAV images with the same settings (FLAC archive image + LAME files), instead of re-ripping all of them.

I'm in a similar situation. Please, let us know if there's a solution, thanks!

All EAC does when it is finished ripping the WAV/CUE files is pass a set or parameters to the REACT.exe.  Take a look at the variables in your External Compression options and you should be able to work out the actual commandline to send to REACT.exe manually (well at least I think so, there's the chance that REACT does more than that when launching EAC, but it's worth a shot).
Title: REACT 2 Released
Post by: Martin H on 2007-03-28 15:34:19
1. [...] My question is whether it matters as to which one of these is actually loaded when I use REACT. Presumably the ini and cfg files will overwrite all the EAC compression settings.

Yes, as you said, then REACT upon installation asks you if you want to setup REACT to work with EAC and if you select 'Yes', then some EAC options is adjusted and the compression options ammended. This then means that you may not alter the compression options afterwards(and some of the EAC options), as else REACT will not work correctly, but you always have the option of reconfiguring REACT with EAC again by pressing : 'CTRL+F2'.
Quote
5. I can't seem to get tracknumbers with a padded space (ie 01, 02, 03 etc) on MP3's using LAME.

You need to download metamp3 v0.92b4 from this page : http://www.hydrogenaudio.org/forums/index....showtopic=49751 (http://www.hydrogenaudio.org/forums/index.php?showtopic=49751)

Then you also need an external manifest file to get the beta to run, so follow the instructions from this previous post of mine : http://www.hydrogenaudio.org/forums/index....st&p=478005 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=49751&view=findpost&p=478005)
Quote
6. What does this hotkey actually do - TracksHotVal=+{F5}
It defines what the 'F4' hotkey is set to i.e. now it's set to : 'Shift+F5', which is 'Copy tracks - Compressed', but you can also change it to instead : '+{F6}', which then will rip the tracks in test & copy mode(Shift+F6).

@Chicoughski

No, you can't run REACT on images/tracks that's allready ripped, but you can use the command-line tools manually to do those things - just like REACT would have done.
Title: REACT 2 Released
Post by: mRuss on 2007-03-29 02:28:55
I am having a problem with REACT.  The metamp3 program is not tagging my files.  My error message is "The system cannot execute the specified program". 

{edit}

I figured out that the VC++ runtime files need to be installed in order for the metamp3 tagger to function; without it the above error message occurs.  This information should be included in a readme file, since metamp3 is included with REACT.

Here is a link for the VC++ runtime files.
http://www.microsoft.com/downloads/details...;displaylang=en (http://www.microsoft.com/downloads/details.aspx?familyid=32BC1BEE-A3F9-4C13-9C99-220B62A191EE&displaylang=en)

Other than this problem, REACT is working great for me.  Thanks for the great software.

Russ.
Title: REACT 2 Released
Post by: gsa999 on 2007-03-30 23:22:42
You need to download metamp3 v0.92b4 from this page : http://www.hydrogenaudio.org/forums/index....showtopic=49751 (http://www.hydrogenaudio.org/forums/index.php?showtopic=49751)

Then you also need an external manifest file to get the beta to run, so follow the instructions from this previous post of mine : http://www.hydrogenaudio.org/forums/index....st&p=478005 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=49751&view=findpost&p=478005)


Hi,  I have downloaded metamp3 v0.92b5 (not b4 as you suggest as I can't find this anymore) and now I am not getting any tags at all added to my mp3 files via REACT.
I think its something to do with the --pict parameter not appearing in the metamp3.txt file. Presumably I now need to make changes to the REACT config files to get all this working again since the metamp3 command line parameters have changed - I think its the %Cover_tag% and possibly the %VA-tag% fields that need changing, but what do they need changing to and does the mp3 image bit need to change as well.
I have checked that metamp3 does work by adding an artist without using REACT.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-05 19:25:47
Thanks to some encouragement from Synthetic Soul I have braved my first day with REACT.  I know have it doing everything I need apart from a few things and I was advised to post here rather than in my 'Help' thread.

I am managing to modify the REACT files but I am a batchfile newbie

I unREMed the logfile line and added a cuesheet command to REACT-track.cfg to move the log and cuesheet

IF @Flac@==1 (
      PUSHD %TrackDir_Flac%
         IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac% *.flac
         COPY /Y "@eaclog@" "@album@ EAClog.txt"
         COPY /Y "@albumfile@.[mg].cue" "@album@ (noncmpl).cue"
      POPD
   )
   
This is great, as react also creates the cuesheet for me.  However react insists on %D in the EAC naming scheme whereas I do not use the artist name in the FLAC/MP3 names.  Therefore the cuesheet FILE entries do not match the FLAC (or extracted WAVS).  I can use a text editor to correct the cuesheet (searching for '"* -- ' IOW the part of the filename to the first divider)  Can I script this within react?.

I manually add the accuraterip info to the log, I am considering delaying the copying of the logfile so I can add the accrip info to the temporary log and have react then move it to the FLAC and MP3 directories.  My question is can I make an entry in REACT-track.cfg which would put up a prompt reminding the user to copy the accrip info, then take the clipboard contents and append it to the temporary logfile before duplicating this to FLAC and MP3?

I had to change the FLAC tag to '-T tracknumber="@track@" -T totaltracks="@numtracks@"' rather than use 1/18 (with lame these end up in different fields but not with the default for flac)  With the default foobar could not pad the numbers

Finally, I removed the +3.0dB from the ini file, was this right? (the author said it was to get some extra volume on his portable?).  So I have AdjustAlbumGain_dB=+0.0.  I haven't used replaygain before, I understand it does not change the actual FLAC, but I might like the MP3 file to be modified (can an ipod shuffle understand replaygain?  I can create the MP3 after if REACT does not permit this)

Thanks in advance
L
Title: REACT 2 Released
Post by: lipidicman on 2007-04-08 08:32:30
Can anyone confirm the replaygain settings?  I am ripping to FLAC tracks and (sometimes) LAME mp3

ReplayGain     Enable/Disable ReplayGain calculation and tagging.
I want this on to add tags to my flacs and mp3? Will this setting alone RG as an album?

ApplyAlbumGain    Apply the album gain to the files, so they are played back with a consistent volume across the albums on every player.
So will this actually adjust the mp3, not just tag it (but leave the flac as is with RG tags?).  If this is off will the flac tracks be RGed as an album?
Quote
@Meddler: You are correct. ApplyAlbumGain should probably have been set to 0 by default. Note that 'ApplyAlbumGain' is only for lossy formats. FLAC and WAVPACK are always tagged only.
Ok, so...
Quote
If you don't want to apply album gain, set ApplyAlbumGain=0 in the REACT.ini file.
If you don't want replay gain tags at all, set ReplayGain=0 in the REACT.ini file.
This is what is confusing me, I want album gain, but not to 'apply' it.  By 'apply' I guess you mean directly to the files

AdjustAlbumGain_dB    If you want to adjust the album gain from 89.0 dB when applying to the audio, set adjustment in dB here.
Is this for the flac file tags, or just the adjusted mp3 as questioned above.

AddCuesheetAG    Add Album gain/Album peak values to the cuesheet as REM lines. This implies that WaveGain is ran.
I have tracks and a cusheet, but I guess I do not need this

UseWaveGainAG    Instruct to use WaveGain to calculate AlbumGain values on the wav image file. The values will be transferred to the various compressed formats, rather than calculating them via other tools. If ApplyAlbumGain=1, LAME and OggEnc2 will use the --scale option to apply the album gain scale factor calculated by WaveGain.
Again, not needed for individual tracks?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-08 08:55:08
I don't use ReplayGain, so I can't really answer your RG questions.

This is great, as react also creates the cuesheet for me. However react insists on %D in the EAC naming scheme whereas I do not use the artist name in the FLAC/MP3 names. Therefore the cuesheet FILE entries do not match the FLAC (or extracted WAVS). I can use a text editor to correct the cuesheet (searching for '"* -- ' IOW the part of the filename to the first divider) Can I script this within react?.
You could do what you need using SED (http://gnuwin32.sourceforge.net/packages/sed.htm), but it's a tool that I'm not familiar with, so I can't really advise any further.

I manually add the accuraterip info to the log, I am considering delaying the copying of the logfile so I can add the accrip info to the temporary log and have react then move it to the FLAC and MP3 directories. My question is can I make an entry in REACT-track.cfg which would put up a prompt reminding the user to copy the accrip info, then take the clipboard contents and append it to the temporary logfile before duplicating this to FLAC and MP3?
You can easily get the script to display a reminder and pause, but I don't know about copying rfom the clipboard.  If the info was all on one line you could enter it at a prompt, but I suspect it isn't.  To pause with a message just add the lines:

Code: [Select]
ECHO Please copy the accuraterip info to the logfile and then press any key.
PAUSE>NUL

Finally, I removed the +3.0dB from the ini file, was this right? (the author said it was to get some extra volume on his portable?). So I have AdjustAlbumGain_dB=+0.0. I haven't used replaygain before, I understand it does not change the actual FLAC, but I might like the MP3 file to be modified (can an ipod shuffle understand replaygain? I can create the MP3 after if REACT does not permit this)
I increase files to 97dB for my Creative Zen, as I found quiter albums needed too much volume, and many of my albums were at that sort of level in the first place.  For my car stereo I use 89dB.

I think your subsequent questions mean that you have a better understanding of RG, so I'll not say much.  Normally RG is used to just tag the files so that an RG-aware player will adjust the level accordingly.  However, REACT will also let you apply the gain to the files, so that the volume is physically changed, and any player will play at the new volume.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-08 10:00:55
Thanks for the tip about SED, I am looking into it now.

I really don't know much about replaygain.  I like the idea of having it in the tags as I can easily tell foobar to ignore it.  I also quite like the idea of having my mp3 files actually adjusted so they play ok on my shuffle.

Now I am settling on having react create my flacs and using foobar to make the mp3 as I need them.  Can convert create mp3 with the actual levels adjusted using the flac tags (or by calculating them itself)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-08 10:45:16
I'm a little strapped for time at the mo, so I probably won't get chance to action, but my current thought is this (given that I'd like a solution that anyone can use):
This should create a process that anyone can easily use to amend the cuesheet to their requirements.

If you aren't successful by the time I can find some time I'll have a go myself.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-08 11:00:36
  • On every track write a SED command, to change that track's FILE reference in the cuesheet, to a text file (sed-commands.txt).
  • Use REACT's $ tokens to create the find/replace values.
  • On the last track use SED -f sed-commands.txt <old >new to perform the find and replaces (see tutorial (http://www.grymoire.com/Unix/Sed.html#uh-16)).



I don't understand the first line.  I think I am thinking of a solution that would only work for me, I wanted to test the idea in a very simple way.  I need to remove "Pearl Jam  -- " etc as REACT insists on %D in the EAC naming, but my react naming does not have the artist.  I thought I could use "@artist@ -- " in the SED command to achieve this.  I would then issue a SED command with .wav for .flac.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-08 11:48:35
Not everyone wants to just remove the first part, so I would like a solution that worked for any replacement format.

On thinking there is no need to create a text file with all the commands, you may as well just run SED for each track.

I think you could use something like:

Code: [Select]
SED 's/$artist$ \-\- \(.*\)\.wav/\1\.flac/' <old.cue >new.cue

..but that's untested, and likely only 90% there!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-08 12:30:39
I've just managed to do a quick test with a dummy "cuesheet" and by George I think I was 100% right!

Therefore, instead of:

Code: [Select]
COPY /Y "@albumfile@.[mg].cue" "@album@ (noncmpl).cue"

... you could try:

Code: [Select]
@tools@\SED 's/$artist$ \-\- \(.*\)\.wav/\1\.flac/' <"@albumfile@.[mg].cue" >"@album@ (noncmpl).cue"

(put SED.EXE in your tools directory)
Title: REACT 2 Released
Post by: lipidicman on 2007-04-08 17:37:27
Thank you very much SS.  I will give that a shot when I get home.

edit: I haven't tried this and I understand most of it (had a look at SED earlier)
I followed the tutorial with: sed 's/day/night/' <old >new
and even
sed 's_/usr/local/bin_/common/bin_' <old >new
Some people use commas, others use the "|" character. Pick one you like. As long as it's not in the string you are looking for, anything goes not sure I get why this works

but yours:
's/$artist$ \-\- \(.*\)\.wav/\1\.flac/'

I get the s/ and $artist$
but
why \-\- for --
and
(.*\) has me lost

I need to replace '$artist$ -- ' with *nothing*, zip zilch
also shouldn't it end with '.wav/.flac/'

Don't take this the wrong way.  I'm not saying it wont work.  I am asking why it does!

edit2: Just read some more of the tutorial and delved into regular expressions.  My brain hurts.  I find the slashes very unreadable.  I don't follow what \1 is for (this doesn't really matter for now) but why cant I simply use '.wav/.flac/'?

edit3: sorry about the mess I tried
SED -e "s/Pearl Jam -- //" -e "s/.wav/.flac/" <"test.txt" >"testoutput.txt"
and this worked
so what do you think of
@tools@\SED -e "s/$artist$ -- //" -e "s/.wav/.flac/" <"@albumfile@.[mg].cue" >"@album@ (noncmpl).cue"
To me this is more readable and seems to work
Oh, and thanks again!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-08 22:00:57
I've run further tests, and come up with a solution that would work for any set-up.

I forgot why I originally suggested using SED's -f switch, and that is so that we can easily run multiple replacements on the cuesheet.  I think that often we could just do one replace, to remove the artist (as per lipidicman), or both artist and album, but it's useful to be able to replace the standard "$artist$ - $album$ - $track$ - $title$.wav" format with anything we want, which may require a specific replace for each track.

The process involves writing a SED command for each track to a temporary text file, and then running them all in one go.

The two key lines are:

Code: [Select]
ECHO s/FILE "$artist$ \- $album$ \- $track$ \- $title$\.wav"/FILE "$track$ \- $title$\.flac"/>>sedlist.txt
This line will be run for each track, and writes the SED command to the temporary file "sedlist.txt".  The example above replaces "$artist$ - $album$ - $track$ - $title$.wav"  with "$track$ - $title$.flac" .  Notice that the hypens and file delimiter are all escaped with a backslash.

Code: [Select]
@tools@\SED -f sedlist.txt <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"
The call to SED  is only made at the end.  It runs the SED commands in sedlist.txt on  "@albumfile@.[mg].cue"  and outputs the result to "$cdartist$ - $album$.cue".

I had to comment out the codepage change (CHCP 1252) to achieve this, as SED was writing some  characters shit at the beginning of the new cuesheet.

Add in a line to delete "sedlist.txt" after the call to SED and you're basically there.

Here is my test config for reference (MP3 used):

Code: [Select]
@ECHO OFF
REM CHCP 1252
TITLE @track@/@numtracks@ - "@album@"

REM Copyright © Tycho, 2006
REM
REM ** Create compressed audio tracks from ripped .wav tracks.
REM **
REM ** You may consider using image mode (F10)
REM ** as it supports creating tracks via acdir.exe,
REM ** and post-processing will always work (see below).
REM **
REM ** Flac requires flac.exe/metaflac.exe (v1.1.3)
REM ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
REM ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.
REM **
REM ** I prefer applying album gain 92dB to get a reasonable
REM ** volume for my DAP. The RG tags are still relative
REM ** to 89dB SPL, i.e. album gain will be about -3.0dB.


REM ============== Begin Main Script ==================


IF @Debug@==1 ECHO ON

SET TrackDir_Flac="@TrackDir_Flac@"
SET TrackDir_Wavpack="@TrackDir_Wavpack@"
SET TrackDir_MP3="@TrackDir_MP3@"
SET TrackDir_AAC="@TrackDir_AAC@"
SET TrackDir_OGG="@TrackDir_OGG@"

IF @various@==0    SET TrackName=@TrackName_SA@
IF @various@==1    SET TrackName=@TrackName_VA@

SET have_cover=0
SET embed_cover=0

IF EXIST "@cover@" (
    SET have_cover=1
    SET embed_cover=@EmbedCover@
)

REM ---- Track ----

IF NOT @Flac@==1 GOTO end_flac_tracks
    IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
    PUSHD %TrackDir_Flac%
        IF @various@==1 SET VA_tag=-T "album artist=@VA@"
        IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
        ECHO ON
        @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" "@source@" -o "%TrackName%.flac"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_flac_tracks


IF NOT @Wavpack@==1 GOTO end_wavpack_tracks
    IF NOT EXIST %TrackDir_Wavpack% MKDIR %TrackDir_Wavpack%
    PUSHD %TrackDir_Wavpack%
        IF @various@==1 SET VA_tag=-w "album artist=@VA@"
        ECHO ON
        @tools@\wavpack.exe @Opt_Wavpack@ %VA_tag% -w artist="@artist@" -w album="@album@" -w track="@track@/@numtracks@" -w title="@title@" -w year="@year@" -w genre="@genre@" -w comment="@comment@" -w encodedby="%USERNAME%" -w encodersettings="Wavpack @Ver_Wavpack@ @Opt_Wavpack@" "@source@" "%TrackName%.wv"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
        TITLE @track@/@numtracks@ - "@album@"
    POPD
:end_wavpack_tracks


IF NOT @LameMP3@==1 GOTO end_lame_tracks
    IF NOT EXIST %TrackDir_MP3% MKDIR %TrackDir_MP3%
    PUSHD %TrackDir_MP3%
        IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"
        IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"
        ECHO ON
        @tools@\lame.exe @Opt_LameMP3@ "@source@" "%TrackName%.mp3"
        @tools@\metamp3.exe %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@" --track @track@/@numtracks@ --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@" --frame TENC:"%USERNAME%" --frame TSSE:"LAME @Ver_LameMP3@ @Opt_LameMP3@" "%TrackName%.mp3"
        ECHO s/FILE "$artist$ \- $album$ \- $track$ \- $title$\.wav"/FILE "$track$ \- $title$\.mp3"/>>sedlist.txt
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
       
    POPD
:end_lame_tracks


IF NOT @iTunesAac@==1 GOTO end_itunes_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF %embed_cover%==1 SET Cover_tag=-r "@cover@"
        ECHO ON
        @tools@\iTunesEncode.exe @Opt_iTunesAac@ -e "AAC Encoder" %Cover_tag% -x @various@ -a "@artist@" -l "@album@" -n "@track@" -m "@numtracks@" -t "@title@" -y "@year@" -g "@genre@" -c "@comment@" -i "@source@" -o "%TrackName%.m4a"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
    GOTO end_nero_aac_tracks
:end_itunes_aac_tracks

IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF @various@==1 SET VA_tag=--albumArtist "@VA@" --compilation true
        IF %embed_cover%==1 SET Cover_tag=--artwork "@cover@"
        ECHO ON
        @tools@\neroAacEnc.exe @Opt_NeroAac@ -if "@source@" -of "%TrackName%.m4a"
        @tools@\AtomicParsley.exe "%TrackName%.m4a" -o REACT_tmp.m4a %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@" --tracknum "@track@/@numtracks@" --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@" --encodingTool "neroAacEnc @Ver_NeroAac@ @Opt_NeroAac@"
        @ECHO OFF
        MOVE /Y REACT_tmp.m4a "%TrackName%.m4a"
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_nero_aac_tracks


IF NOT @OggEnc2@==1 GOTO end_oggenc_tracks
    IF NOT EXIST %TrackDir_OGG% MKDIR %TrackDir_OGG%
    PUSHD %TrackDir_OGG%
        IF @various@==1 SET VA_tag=-c "album artist=@VA@"
        ECHO ON
        @tools@\oggenc2.exe @Opt_OggEnc2@ %VA_tag% -c artist="@artist@" -c album="@album@" -c tracknumber="@track@/@numtracks@" -c title="@title@" -c date="@year@" -c genre="@genre@" -c comment="@comment@" -c encoded-by="%USERNAME%" -c encoding="OggEnc @Ver_OggEnc2@ @Opt_OggEnc2@" "@source@" -o "%TrackName%.ogg"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_oggenc_tracks


REM ** Delete the source .wav
DEL "@source@"


REM ---- Post-processing ----


rem ** Scan and compute ReplayGain and add cover picture for supported formats.
rem ** NB: The following will only work if at least the last track is selected,
rem ** and it is a regular audio track.

IF NOT @track@==@numtracks@ GOTO end_post_process

    SET add_rg=@ReplayGain@
    SET aac_enc=@NeroAac@
    IF @iTunesAac@==1 SET aac_enc=1

    IF NOT @ReplayGain@==1 GOTO end_RG
        SET RG_MetaFlac=--add-replay-gain
        SET RG_MetaMP3=--replay-gain
    :end_RG

    IF NOT @ApplyAlbumGain@==1 GOTO end_apply_AG
        SET RG_MetaMP3=--apply-gain album@AdjustAlbumGain_dB@
        SET RG_AacGain=/a /o /c /d @AdjustAlbumGain_dB@
        SET add_rg=1
    :end_apply_AG


    REM ** Audio Formats:

    IF @Flac@==1 (
        PUSHD %TrackDir_Flac%
            IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac% *.flac
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )

    IF @Wavpack@==1 (
        PUSHD %TrackDir_Wavpack%
            IF %add_rg%==1 @tools@\wvgain.exe -a *.wv
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )

    IF @LameMP3@==1 (
        PUSHD %TrackDir_MP3%
            IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3
            REM COPY /Y "@eaclog@" "EAClog.txt"
            REM COPY /Y "@albumfile@.[mg].cue" "@album@ (noncmpl).cue"
            @tools@\SED -f sedlist.txt <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"
            DEL sedlist.txt
        POPD
    )

    IF %aac_enc%==1 (
        PUSHD %TrackDir_AAC%
            IF %add_rg%==1 @tools@\aacgain.exe %RG_AacGain% *.m4a > "gainlog.txt"
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )

    IF @OggEnc2@==1 (
        PUSHD %TrackDir_OGG%
            IF %add_rg%==1 @tools@\vorbisgain.exe -a *.ogg
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )


    REM ** Cleanup

    DEL "@eaclog@"
    DEL "@albumfile@.[*].cue"
    DEL "@cover@"

:end_post_process


REM ================ End Main Script ===================


IF @Debug@==1 (
    PAUSE
    EXIT
)

REM ** Delete this .bat file:
DEL %0
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-08 22:20:53
but yours:
's/$artist$ \-\- \(.*\)\.wav/\1\.flac/'

I get the s/ and $artist$
but
why \-\- for --
and
(.*\) has me lost
"-" is a regular expression special character, used to provide ranges, like "a-z", so I thought it needed escaping, thus "\-" instead of "-".  I'm surprised it doesn't.  NB: escaping is essentially preceding any special character with a backslash to state that you want a string literal, instead of the normal special meaning. Therefore "-" becomes "\-", "." becomes "\.", etc.

"\(.*\)" basically means grab anything else [.*] and remember it [the brackets].  This will capture the rest of the filename, so if your filename was "$artist$ -- $album$ -- $track$ -- $title$.wav" it would match and record "$album$ -- $track$ -- $title$".  This match can then be referenced in the replacement text using "\1".

I need to replace '$artist$ -- ' with *nothing*, zip zilch
also shouldn't it end with '.wav/.flac/'
My single command simply matches  "$artist$ -- <stuff>.wav" and replaces it with "<stuff>.flac".  That's it in a nutshell.  As mentioned earlier "\(.*\)" captures "<stuff>" and "\1" references that capture.  If I knew what your filename format was I could used something more specific than ".*" I guess.

edit3: sorry about the mess I tried
SED -e "s/Pearl Jam -- //" -e "s/.wav/.flac/" <"test.txt" >"testoutput.txt"
and this worked
so what do you think of
@tools@\SED -e "s/$artist$ -- //" -e "s/.wav/.flac/" <"@albumfile@.[mg].cue" >"@album@ (noncmpl).cue"
To me this is more readable and seems to work
If you're happier with that then go with it - the concept is sound.  My solution uses one command rather than two, but I hardy think you'll get a performance hit. 

Hmm.. I see you're not escaping the "." also.  I think that may translated as "*wav" -> ".flac" (where "*" is any character), which may screw you if you have "wav" in the middle of a word.  Please test.  I would use "s/\.wav/\.flac/" (the delimiter is escaped to show it is a string literal). Check out this quick test:

Code: [Select]
C:\Documents and Settings\Neil\Desktop>sed s/.ped/.es/ test.txt
The quick brown fox ju.es over the lazy dog.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-08 23:24:03
Wow    I see the error of my ways.

I think you are right about using \.wav looking at your example.  I didn't run into that problem as I did not have wav anywhere else in the file.  You have just saved me a lot of trouble.

Quote
My single command simply matches "$artist$ -- <stuff>.wav" and replaces it with "<stuff>.flac"

I get this now!

I think I follow your (save to a text file and then read it) method and why you have a line for each track.  This is very clever and will certainly make this more flexible.  By using the default config that REACT puts into EACs naming config it could even be added to the distribution (REACT would have to enforce the default EAC naming more strongly and the ECHO command could be derived directly from the REACT.ini?)

Thank you for taking the trouble to look at this (and to educate a newb).  I have seen several other people ask about .wav to .flac in the cuesheet and get no joy, so I really appreciate this.  My girlfriend will be happy when she can click on the cuesheets and click BURRRN.  That is, if I still have a girlfriend bearing in mind the time I spend planning my FLAC library (which luckily she is quite keen to have too)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-09 07:59:06
I think I follow your (save to a text file and then read it) method and why you have a line for each track. This is very clever and will certainly make this more flexible. By using the default config that REACT puts into EACs naming config it could even be added to the distribution (REACT would have to enforce the default EAC naming more strongly and the ECHO command could be derived directly from the REACT.ini?)
Yes, that method should be flexible enough for anyone, and I wanted a solution that anyone could adapt.  That said, I think the type of command you are using may be adequate for many - I personally name my tracks "$track$ - $title$" so I could just do a blanket removal of "$artist$ - $album$ - ".  I use image mode though.

I did think about using REACT variables to create the commands (@basename@ and %TrackName%), but I would have to write more code to escape the hyphens - i.e.: turn "$artist$ - $album$ - $track$ - $title$" into "$artist$ /- $album$ /- $track$ /- $title$".  Hmm... I just remembered that useful tool SED.  Maybe I'll have a play.

Edit:  I've just had a quick test, and a quick skim of of the tutorial, and it doesn't seem that "-" is used as a special character in SED.  I guess instead of "a-z" you have to do "[abcdefghijklmnopqrstuvwxyz]".  Anyway, that's good news for simplifying the commands.  I can't test now, but I guess the line could be changed to:

Code: [Select]
ECHO s/FILE "@basename@\.wav"/FILE "%TrackName%\.flac"/>>sedlist.txt

That makes things look a lot less complicated, and a hell of a lot more portable.  Thanks for highlighting that for me.

Thank you for taking the trouble to look at this (and to educate a newb). I have seen several other people ask about .wav to .flac in the cuesheet and get no joy, so I really appreciate this. My girlfriend will be happy when she can click on the cuesheets and click BURRRN. That is, if I still have a girlfriend bearing in mind the time I spend planning my FLAC library (which luckily she is quite keen to have too)
You're welcome. I was pleased to see the work you put in also, so I feel that my help was well-deserved.  I like a challenge as well.

It must be nice to have a girlfriend that's interested in the subject.  My wife ribs me about my obsession, and the time I spent yesterday morning posting and testing almost caused a massive argument (I was supposed to be doing jobs around the house)!  As I say though, I like a challenge.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-09 08:40:18
I did think about using REACT variables to create the commands (@basename@ and %TrackName%), but I would have to write more code to escape the hyphens - i.e.: turn "$artist$ - $album$ - $track$ - $title$" into "$artist$ /- $album$ /- $track$ /- $title$".  Hmm... I just remembered that useful tool SED.  Maybe I'll have a play.


Are you talking about using SED to alter the string to send to SED?  Ouch!  That would be very neat though.  This would certainly allow it to be included in REACT for everyone to benefit from.  For now I think I have a solution (I don't get home to my computer until later).

edit:  I'm trying to think through whether your method will work for VA, mine would not I fear.  Anyhow I am sold on using a sedlist.txt now!

I did try to do as much of the work as I could, but you were way ahead of me.  Your replies left me very pleasantly surprised!

My other issue was copying the accuraterip details to the clipboard and having these be inserted into the logfile.
I came up with this suite including winclip:
http://www.dmst.aueb.gr/dds/sw/outwit/ (http://www.dmst.aueb.gr/dds/sw/outwit/)

My idea is to clear the clipboard (so you dont accidentally paste the details from the previous rip! paranoia I know), ask the user to grab the accrip log and then output it to a file (winclip -p file.txt) before appending this file to the EAClog.  There is even scope for checking that the clipboard contains accrip data I guess and looping until it does (might be problems here if the window has been closed, easy to do!)

Even the idea that any of this was possible was way off of my radar a few days ago so I should thank you for the pointer towards REACT really!

Let me be clear about my GF.  She likes the end result, the fact she can grab an album or make a compilation (from our library) in a few seconds with burrrn.  She also wants a jukebox PC for the lounge.  When I try to explain the problems with the cuesheet and the fine details of the naming conventions her eyes glaze over.  Still at least there have been no arguments.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-09 09:11:10
Edit:  I've just had a quick test, and a quick skim of of the tutorial, and it doesn't seem that "-" is used as a special character in SED.  I guess instead of "a-z" you have to do "[abcdefghijklmnopqrstuvwxyz]".  Anyway, that's good news for simplifying the commands.  I can't test now, but I guess the line could be changed to:

Code: [Select]
ECHO s/FILE "@basename@\.wav"/FILE "%TrackName%\.flac"/>>sedlist.txt
That makes things look a lot less complicated, and a hell of a lot more portable.  Thanks for highlighting that for me.
Tested, and works just great.  Using %TrackName% means it will work for VA albums also (tested).

Here's my current test config:

Code: [Select]
@ECHO OFF
REM CHCP 1252
TITLE @track@/@numtracks@ - "@album@"

REM Copyright © Tycho, 2006
REM
REM ** Create compressed audio tracks from ripped .wav tracks.
REM **
REM ** You may consider using image mode (F10)
REM ** as it supports creating tracks via acdir.exe,
REM ** and post-processing will always work (see below).
REM **
REM ** Flac requires flac.exe/metaflac.exe (v1.1.3)
REM ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
REM ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.
REM **
REM ** I prefer applying album gain 92dB to get a reasonable
REM ** volume for my DAP. The RG tags are still relative
REM ** to 89dB SPL, i.e. album gain will be about -3.0dB.


REM ============== Begin Main Script ==================


IF @Debug@==1 ECHO ON

SET TrackDir_Flac="@TrackDir_Flac@"
SET TrackDir_Wavpack="@TrackDir_Wavpack@"
SET TrackDir_MP3="@TrackDir_MP3@"
SET TrackDir_AAC="@TrackDir_AAC@"
SET TrackDir_OGG="@TrackDir_OGG@"

IF @various@==0    SET TrackName=@TrackName_SA@
IF @various@==1    SET TrackName=@TrackName_VA@

SET have_cover=0
SET embed_cover=0

IF EXIST "@cover@" (
    SET have_cover=1
    SET embed_cover=@EmbedCover@
)

REM ---- Track ----

IF NOT @Flac@==1 GOTO end_flac_tracks
    IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
    PUSHD %TrackDir_Flac%
        IF @various@==1 SET VA_tag=-T "album artist=@VA@"
        IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
        ECHO ON
        @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" "@source@" -o "%TrackName%.flac"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_flac_tracks


IF NOT @Wavpack@==1 GOTO end_wavpack_tracks
    IF NOT EXIST %TrackDir_Wavpack% MKDIR %TrackDir_Wavpack%
    PUSHD %TrackDir_Wavpack%
        IF @various@==1 SET VA_tag=-w "album artist=@VA@"
        ECHO ON
        @tools@\wavpack.exe @Opt_Wavpack@ %VA_tag% -w artist="@artist@" -w album="@album@" -w track="@track@/@numtracks@" -w title="@title@" -w year="@year@" -w genre="@genre@" -w comment="@comment@" -w encodedby="%USERNAME%" -w encodersettings="Wavpack @Ver_Wavpack@ @Opt_Wavpack@" "@source@" "%TrackName%.wv"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
        TITLE @track@/@numtracks@ - "@album@"
    POPD
:end_wavpack_tracks


IF NOT @LameMP3@==1 GOTO end_lame_tracks
    IF NOT EXIST %TrackDir_MP3% MKDIR %TrackDir_MP3%
    PUSHD %TrackDir_MP3%
        IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"
        IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"
        ECHO ON
        @tools@\lame.exe @Opt_LameMP3@ "@source@" "%TrackName%.mp3"
        @tools@\metamp3.exe %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@" --track @track@/@numtracks@ --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@" --frame TENC:"%USERNAME%" --frame TSSE:"LAME @Ver_LameMP3@ @Opt_LameMP3@" "%TrackName%.mp3"
        ECHO s/FILE "@basename@\.wav"/FILE "%TrackName%\.mp3"/>>sedlist.txt
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
       
    POPD
:end_lame_tracks


IF NOT @iTunesAac@==1 GOTO end_itunes_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF %embed_cover%==1 SET Cover_tag=-r "@cover@"
        ECHO ON
        @tools@\iTunesEncode.exe @Opt_iTunesAac@ -e "AAC Encoder" %Cover_tag% -x @various@ -a "@artist@" -l "@album@" -n "@track@" -m "@numtracks@" -t "@title@" -y "@year@" -g "@genre@" -c "@comment@" -i "@source@" -o "%TrackName%.m4a"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
    GOTO end_nero_aac_tracks
:end_itunes_aac_tracks

IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
    IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
    PUSHD %TrackDir_AAC%
        IF @various@==1 SET VA_tag=--albumArtist "@VA@" --compilation true
        IF %embed_cover%==1 SET Cover_tag=--artwork "@cover@"
        ECHO ON
        @tools@\neroAacEnc.exe @Opt_NeroAac@ -if "@source@" -of "%TrackName%.m4a"
        @tools@\AtomicParsley.exe "%TrackName%.m4a" -o REACT_tmp.m4a %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@" --tracknum "@track@/@numtracks@" --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@" --encodingTool "neroAacEnc @Ver_NeroAac@ @Opt_NeroAac@"
        @ECHO OFF
        MOVE /Y REACT_tmp.m4a "%TrackName%.m4a"
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_nero_aac_tracks


IF NOT @OggEnc2@==1 GOTO end_oggenc_tracks
    IF NOT EXIST %TrackDir_OGG% MKDIR %TrackDir_OGG%
    PUSHD %TrackDir_OGG%
        IF @various@==1 SET VA_tag=-c "album artist=@VA@"
        ECHO ON
        @tools@\oggenc2.exe @Opt_OggEnc2@ %VA_tag% -c artist="@artist@" -c album="@album@" -c tracknumber="@track@/@numtracks@" -c title="@title@" -c date="@year@" -c genre="@genre@" -c comment="@comment@" -c encoded-by="%USERNAME%" -c encoding="OggEnc @Ver_OggEnc2@ @Opt_OggEnc2@" "@source@" -o "%TrackName%.ogg"
        @ECHO OFF
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_oggenc_tracks


REM ** Delete the source .wav
DEL "@source@"


REM ---- Post-processing ----


rem ** Scan and compute ReplayGain and add cover picture for supported formats.
rem ** NB: The following will only work if at least the last track is selected,
rem ** and it is a regular audio track.

IF NOT @track@==@numtracks@ GOTO end_post_process

    SET add_rg=@ReplayGain@
    SET aac_enc=@NeroAac@
    IF @iTunesAac@==1 SET aac_enc=1

    IF NOT @ReplayGain@==1 GOTO end_RG
        SET RG_MetaFlac=--add-replay-gain
        SET RG_MetaMP3=--replay-gain
    :end_RG

    IF NOT @ApplyAlbumGain@==1 GOTO end_apply_AG
        SET RG_MetaMP3=--apply-gain album@AdjustAlbumGain_dB@
        SET RG_AacGain=/a /o /c /d @AdjustAlbumGain_dB@
        SET add_rg=1
    :end_apply_AG


    REM ** Audio Formats:

    IF @Flac@==1 (
        PUSHD %TrackDir_Flac%
            IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac% *.flac
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )

    IF @Wavpack@==1 (
        PUSHD %TrackDir_Wavpack%
            IF %add_rg%==1 @tools@\wvgain.exe -a *.wv
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )

    IF @LameMP3@==1 (
        PUSHD %TrackDir_MP3%
            IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3
            COPY /Y "@eaclog@" "EAClog.txt"
            @tools@\SED -f sedlist.txt <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"
            DEL sedlist.txt
        POPD
    )

    IF %aac_enc%==1 (
        PUSHD %TrackDir_AAC%
            IF %add_rg%==1 @tools@\aacgain.exe %RG_AacGain% *.m4a > "gainlog.txt"
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )

    IF @OggEnc2@==1 (
        PUSHD %TrackDir_OGG%
            IF %add_rg%==1 @tools@\vorbisgain.exe -a *.ogg
            REM COPY /Y "@eaclog@" "EAClog.txt"
        POPD
    )


    REM ** Cleanup

    DEL "@eaclog@"
    DEL "@albumfile@.[*].cue"
    DEL "@cover@"

:end_post_process


REM ================ End Main Script ===================


IF @Debug@==1 (
    PAUSE
    EXIT
)

REM ** Delete this .bat file:
DEL %0
My other issue was copying the accuraterip details to the clipboard and having these be inserted into the logfile.
I came up with this suite including winclip:
http://www.dmst.aueb.gr/dds/sw/outwit/ (http://www.dmst.aueb.gr/dds/sw/outwit/)

My idea is to clear the clipboard (so you dont accidentally paste the details from the previous rip! paranoia I know), ask the user to grab the accrip log and then output it to a file (winclip -p file.txt) before appending this file to the EAClog.  There is even scope for checking that the clipboard contains accrip data I guess and looping until it does (might be problems here if the window has been closed, easy to do!)
Cool, I have no idea what you are talking about, but I'll try to take a look.

NB: To append file.txt to the logfile you could use:

Code: [Select]
TYPE file.txt >> "@eaclog@"
... or if you wanted a few carriage returns, etc.:

Code: [Select]
ECHO.>>"@eaclog@"
ECHO.>>"@eaclog@"
ECHO Accuraterip data:>>"@eaclog@"
ECHO.>>"@eaclog@"
TYPE file.txt >> "@eaclog@"
When I try to explain the problems with the cuesheet and the fine details of the naming conventions her eyes glaze over. Still at least there have been no arguments.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-09 09:37:58
Tested, and works just great.  Using %TrackName% means it will work for VA albums also (tested).


Great news.  I thought it would, and I had realised my method was going to trip up here

with the TYPE hint I will have a go at the clipboard solution tomorrow.  I am just unsure if I can test the contents of the clipboard to make the solution more robust
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-09 11:12:22
I am just unsure if I can test the contents of the clipboard to make the solution more robust
I have no idea what text you will have so I can't really make any suggestions as yet as to how to validate.  I'll gladly stick my nose in though if you paste an example.

@All:

NB: In my test I used the MP3 section for ease.  I'm sure most people interested in this process would be using lossless, but I feel I should point out that if you do use MP3 you should really use:

Code: [Select]
ECHO s/FILE "@basename@\.wav" WAVE/FILE "%TrackName%\.mp3" MP3/>>sedlist.txt

Valid values for the file type are "WAVE", "MP3" and "AIFF", so if you use FLAC, Wavpack, Monkey's Audio, etc. it's fine/recommended to just leave "WAVE" as "WAVE", but for MP3 you need "MP3".
Title: REACT 2 Released
Post by: lipidicman on 2007-04-09 12:25:59
I am just unsure if I can test the contents of the clipboard to make the solution more robust
I have no idea what text you will have so I can't really make any suggestions as yet as to how to validate.  I'll gladly stick my nose in though if you paste an example.

Can't at the moment, it is standard accurate rip output though.  So I was going to test if the contents of the clipboard contained the word 'accurate'.  The plan was to empty the clipboard in the script first (to avoid identifying data from an earlier rip) then check the user had done a manual paste with this check

@All:

NB: In my test I used the MP3 section for ease.  I'm sure most people interested in this process would be using lossless, but I feel I should point out that if you do use MP3 you should really use:

Code: [Select]
ECHO s/FILE "@basename@\.wav" WAVE/FILE "%TrackName%\.mp3" MP3/>>sedlist.txt

Valid values for the file type are "WAVE", "MP3" and "AIFF", so if you use FLAC, Wavpack, Monkey's Audio, etc. it's fine/recommended to just leave "WAVE" as "WAVE", but for MP3 you need "MP3".


If this does not end up in a distribution it should be in a guide at least.  You wrote the knowledgebase article, right?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-09 18:52:05
I've no idea what the standard AccurateRip output is, as I always use images.

I wrote the initial wiki article/help (http://wiki.hydrogenaudio.org/index.php?title=REACT), but tycho has since made numerous updates.

In response to Nik's crusade to document everything, and create a REACT GUI, I did suggest a wiki page (or pages) that had suggestions for improvements or amendments to the REACT configs.  Maybe I should start one and document this...
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-09 19:06:54
BTW I had a play with winclip.  I'm not sure how far you have got, but you may get some help from this:

Code: [Select]
REM Clear the clipboard
WINCLIP.EXE -c <NUL

REM Prompt to copy to the clipboard
:PauseForClipboard
ECHO.
ECHO Please copy the AccurateRip data to the clipboard and press any key
REM Wait
PAUSE >NUL

REM Copy the clipboard contents to winclip.txt
WINCLIP.EXE -p >winclip.txt

REM Check file for the word 'Accurate'
FINDSTR /I "ACCURATE" winclip.txt
IF ERRORLEVEL 1 (
  ECHO.
  ECHO Cannot find the word 'Accurate'.  Please try again.
  GOTO PauseForClipboard
)

REM Append the AccurateRip data to the log
ECHO.>>"@eaclog@"
ECHO.>>"@eaclog@"
ECHO AccurateRip Data:>>"@eaclog@"
ECHO.>>"@eaclog@"
TYPE winclip.txt >>"@eaclog@"
DEL winclip.txt
Title: REACT 2 Released
Post by: lipidicman on 2007-04-09 20:25:32
This is what I did (don't laugh, I've never written batch files before so mine only gave the user two chances.  I'm off to learn from your code now!) edit: result in second code window, basically the same as yours with a different search string (cant remember if you get 'Accurate' when it fails, and cant find a failing disc right now!)  Only thing it might need is a way to get out of the loop if you have closed the AccRip window.  Thanks

Code: [Select]
        REM ** winclip test first clear the clipboard
    echo notgrabbed| @tools@\winclip -c
    REM ** prompt
    echo.
    echo Please copy the accurate rip data
    pause
    @tools@\winclip -p clipboard.txt    
    REM ** TEST CONTENTS
    findstr "notgrabbed" clipboard.txt >NUL
    if errorlevel 1 GOTO end_NOTGRABBED
        echo.
        echo You need to copy the accuraterip data
        pause
        @tools@\winclip -p clipboard.txt
    :end_NOTGRABBED
    
    REM modify the EAClog
    ECHO.>>"@eaclog@"
    ECHO.>>"@eaclog@"
    ECHO Accuraterip data:>>"@eaclog@"
    ECHO.>>"@eaclog@"
    TYPE clipboard.txt >> "@eaclog@"
    DEL clipboard.txt


Code: [Select]
REM Get AccurateRip Data
    REM first clear the clipboard
    @tools@\WINCLIP.EXE -c <NUL
    REM Prompt to copy to clipboard
    :PauseForClipboard
    ECHO.
    ECHO Please copy the accurate rip data and press a key
    PAUSE >NUL
    
    REM Copy the clipboard contents to winclip.txt
    @tools@\WINCLIP.EXE -p clipboard.txt    
    
    REM Check file for the phrase 'Ripping Status'
    FINDSTR /I "RIPPING STATUS" clipboard.txt
    IF ERRORLEVEL 1 (
          ECHO.
          ECHO Cannot find the phrase 'Ripping Status'.  Please try again.
          GOTO PauseForClipboard
    )
    
    REM modify the EAClog
    ECHO.>>"@eaclog@"
    ECHO.>>"@eaclog@"
    ECHO Accuraterip data:>>"@eaclog@"
    ECHO.>>"@eaclog@"
    TYPE clipboard.txt >> "@eaclog@"
    DEL clipboard.txt
Title: REACT 2 Released
Post by: Nik on 2007-04-10 17:53:39
My other issue was copying the accuraterip details to the clipboard and having these be inserted into the logfile.
I came up with this suite including winclip:
http://www.dmst.aueb.gr/dds/sw/outwit/ (http://www.dmst.aueb.gr/dds/sw/outwit/)

My idea is to clear the clipboard (so you dont accidentally paste the details from the previous rip! paranoia I know), ask the user to grab the accrip log and then output it to a file (winclip -p file.txt) before appending this file to the EAClog.  There is even scope for checking that the clipboard contains accrip data I guess and looping until it does (might be problems here if the window has been closed, easy to do!)


Alegedly, AutoFLAC (http://legroom.net/software/autoflac) already does that (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=45496&view=findpost&p=441608) (inserts AccurateRip results into log files), and it's based on the same scripting language, so maybe that part of the code can be borrowed from there.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-10 19:37:54
Alegedly, AutoFLAC (http://legroom.net/software/autoflac) already does that (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=45496&view=findpost&p=441608) (inserts AccurateRip results into log files), and it's based on the same scripting language, so maybe that part of the code can be borrowed from there.
That would be interesting to see.  I know nothing of AutoFLAC.

Only thing it might need is a way to get out of the loop if you have closed the AccRip window.
Code: [Select]
REM Get AccurateRip Data
REM Clear the clipboard
@tools@\WINCLIP.EXE -c <NUL
:PauseForClipboard
SET k=
ECHO.
SET /P k=Copy the Accurate Rip data and press return, or enter 'X' to ignore:
IF /I [%k%] EQU [X] GOTO PostAccurateRip

REM Copy the clipboard contents to clipboard.txt
@tools@\WINCLIP.EXE -p clipboard.txt

REM Check file for the phrase 'Ripping Status'
FINDSTR /I "RIPPING STATUS" clipboard.txt
IF ERRORLEVEL 1 (
    ECHO.
    ECHO Cannot find the phrase 'Ripping Status'.  Please try again.
    GOTO PauseForClipboard
)

REM Modify the EAC log
ECHO.>>"@eaclog@"
ECHO.>>"@eaclog@"
ECHO Accuraterip data:>>"@eaclog@"
ECHO.>>"@eaclog@"
TYPE clipboard.txt >> "@eaclog@"
DEL clipboard.txt

:PostAccurateRip
Title: REACT 2 Released
Post by: lipidicman on 2007-04-11 13:24:21
Synth, cheers.  Of course it was simple to add that it is just that  I find batchfile syntax perverse after much simpler languages like python and VB.

I've done some tweaking to make it look nicer.  One problem is that it clears the clipboard too late if you copied the data whilst an earlier track was encoding.  This is a detail really and I could tell my GF to wait for the prompt, but encoding should be a background task.  I am going to add a test for FIRSTTRACK, like there is for postprocessing.  Clear the clipboard then and if the Accrip data is not already done the code will not need to prompt (rearranging the loop really)

Nik, didn't you ask before about correcting the cuesheets?  Was all this helpful to you?  Anyway I'm off to investigate AUTOFLAC, cheers

edit: AUTOFLACs ToDo list:
Quote
add support for rip/write verification
add support for WavPack and Monkey's Audio
add support for pars - comment 45
add support for AccurateRip - comment 90
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-11 13:43:30
Batch file scripting isn't nice.  I'm more used to VB/VBScript, and now PHP.  I always feel like I'm having to work around things in batch files.

I did have a check on the first track to ensure sedlist.txt was clear:

Code: [Select]
IF [@track@] EQU [1] (
    REM Delete the SED commands file, if left over
    DEL sedlist.txt
)
... but decided it was unnecessary.

Putting the clipboard clear in there makes a lot of sense.  It also makes a lot of sense to check whether the data is there before stopping the process.  I did think about that earlier, but I knew that you were concerned about the data being the previous disc's.  I guess clearing the clipboard at track 1 solves this.  Nice thinking.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-11 14:43:08
I need to have a think about how I want it.  If you start ripping another CD, the clipboard may be cleared before the encoding gets to that point.  Anyhow these are details, it is working nicely at the moment.

I just noticed I am using EAC0.95b3, am I OK here before I get going?  From the website it looked like b4 removed some features?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-11 14:47:48
Personally I would move to the latest version, but if it's working for you now then I guess there's really no need.  I've never missed the dropped features, as I never used them.  I have no idea what the difference is between the two versions to be honest.

I just think it makes it easier for people to help if you are on the latest versions, as most people here will be.  It saves confusion.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-11 14:58:50
To bring up something from earlier:

React was tagging flac TRACKNUMBER like this: "1/15"  Foobar wouldn't pad this so I changed it to insert only "1" and put "15" in TOTALTRACKS (I think, I am away from my machine ATM).  Foobar pads this fine.  Any potential problems here?  Using 1/15 seemed weird to me anyway when there is a field for the total.  Could I have problems in other apps?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-11 15:02:24
I have no idea about other apps.  I doubt it would ever cause problems.

I think using TRACKNUMBER and TOTALTRACKS makes most sense.  It also gives you the option to move to a 'nn/mm' format at a later date if need be.

I'm not sure why 'nn/mm' was used as the default.  Maybe someone who has used tracks for a while can enlighten us.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-11 15:20:44
That was the conclusion I arrived at.  Any other opinions most welcome!

edit; it appears it is stored in the ID3 tag as 1/15 anyway looking at this:
http://wiki.hydrogenaudio.org/index.php?ti...ID3_Tag_Mapping (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:ID3_Tag_Mapping)
I dont really get the foobar tag to id3 tag differences
Title: REACT 2 Released
Post by: mogorp on 2007-04-12 01:43:27
Yes, I had that problem with foobar also.  Does anyone know an easy way to mass convert track numbers from the 1/15, 2/15 format to 01,02 etc.  Lipidicman, you are smart for working this out prior to ripping.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-12 07:49:30
Does anyone know an easy way to mass convert track numbers from the 1/15, 2/15 format to 01,02 etc.
http://www.hydrogenaudio.org/forums/index....showtopic=50739 (http://www.hydrogenaudio.org/forums/index.php?showtopic=50739)

Edit: That actually looks a little convoluted (and slightly restrictive).  I'd use this:

TOTALTRACKS
Code: [Select]
$num($substr(%tracknumber%,$add($strchr(%tracknumber%,/),1),$len(%tracknumber%)),1)

TRACKNUMBER
Code: [Select]
$num($left(%tracknumber%,$sub($strchr(%tracknumber%,/),1)),1)


Edit 2: I've added a little more code to check the current format, and uploaded the masstagger script here (http://www.synthetic-soul.co.uk/temp/split-nn-mm-tracknumber.mts).  Now, if there is no '/' found TOTALTRACKS won't be set, but if TRACKNUMBER exists it will be converted to an integer (09 -> 9).  Therefore:

Code: [Select]
CURRENT    TRACKNUMBER    TOTALTRACKS
=====================================

4          4
09         9
15         15
04/08      4              8
1/20       1              20
15/100     15             100


Edit 3: I guess I should point out, just in case, that if you create a script yourself you must action the TOTALTRACKS code first.  If you action the TRACKNUMBER code first you'll lose the TOTALTRACKS info before you can copy it over.
Title: REACT 2 Released
Post by: mogorp on 2007-04-12 23:45:04
Synthetic soul,
You are truly awesome.  I am always amazed by the time you spend helping others here.  Many thanks....again.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-13 13:57:47
Yes, I had that problem with foobar also.  Does anyone know an easy way to mass convert track numbers from the 1/15, 2/15 format to 01,02 etc.  Lipidicman, you are smart for working this out prior to ripping.


Yeah, I chucked my files into foobar and thought "hang on.....".  I am surprised that REACT has this setting (which ia why I am asking here whether I have done something wrong)

SS, where would you use that script, is it for foobar?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-13 14:06:48
SS, where would you use that script, is it for foobar?
Yeah, foobar.

Select the files, choose "Tagging" > "Manage Scripts" from the context menu, then "Load from file..." on the dialogue.

Edit: You could then optionally save it to your local config by providing a name in the dropdown combo and clicking "Save".
Title: REACT 2 Released
Post by: lipidicman on 2007-04-13 15:46:11
Right, foobar clearly has a few more tricks I need to learn
Title: REACT 2 Released
Post by: lipidicman on 2007-04-15 09:53:05
Just popping back in to tweak my React script.  I am being paranoid about preserving my flacs.  I have added "ATTRIB +R *.*" in the flac postprocessing (after the RG command).  This will prevent most other unwanted changes when using foobar for playback and conversion to mp3 etc

I am keen to have a verification method.  With flac I think I understand md5 is not necessary (and clumsy as a tag change will change the md5 anyway).  Should I use a 'fingerprint' as in the flac frontend.  Can this be written from the command line and later verified?.  I cannot see how flac.exe does this, but SHNtool hash generates the same checksums.

Or is running a 'test' on the flacs all that is needed (ie is the fingerprint held internally and tested against)?

edit: just been reading here http://wiki.etree.org/index.php?page=FlacFingerprint (http://wiki.etree.org/index.php?page=FlacFingerprint)
seems people like to argue about it, but I feel better now about the flacs.  I like that the ffp is the md5 of the raw audio data.  I have this command:
metaflac --show-md5sum flac_file_names > ffp.txt
so I am off to test this against SHNTOOL.


Looks like what I need is to write a script to run a test on my FLAC file tree against the internally held md5.  Flac in test mode in recursive mode should do this right?  If flac finds an error does it report it per file, or at the end?  Again I will run some tests, but any input is welcome!
Title: REACT 2 Released
Post by: lipidicman on 2007-04-16 13:40:31
Right another question.  When I rip a single what should I do.  I am happy to tweak foobar later to read the tags but does putting the Album Title as 'Alive (single)' allow me to do this later?  I do not want to have to RETAG later unless I can test for '(single)' and use a script

I would really like to have seperate trees for albums and singles (in foobar, I guess this can be done) or to choose to group the singles in a subtree under each artist
eg
Code: [Select]
PEARL JAM
>1992 Ten
>2000 Riot Act
>Singles
  >1992 Jeremy
  >1992 Oceans


So please do not misunderstand, this is not a foobar question (I will learn more later) it is a 'how to get my use of EAC and REACT correct in preparation' question
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-16 14:26:25
Great track BTW. 

Hmm.. this kind of reminds me of some tests I did with the REACT code a while back.  My idea was that you could use tags in fields that could then be used as per the usually available tags.

For example, you could use "Alive <type>single</type>" as the album name, thus creating @album@ = "Alive" and @type@ = "single".

My thought was that you could use "Sandinista! <disc>1</disc>" or "Stadium Arcadium <discname>Jupiter</discname>".

I probably still have the code around, although it was not quite there.  It was just before v2 came out so I dropped the idea.

Anyway, that aside, given the fields available to you, I can only think that you use "(single)" and then use foobar to re-tag and re-name all those matching or perhaps use the comment field (Compression Options > Offset tab) and check the value of @comment@ in your CFG and act accordingly.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-16 14:41:08
Thanks again

"Alive <type>single</type>"

so you would type that into EAC and have REACT interpret it as two variables.  That seems like the neatest idea.  My girlfriend will *HATE* it though.  So far I have used (single) and what I was looking for was reassurance that down the line I will be able to use this standard notation to tweak my library the way I want it.  Nothing like forward planning to save yourself a big headache

Still, if the code works I might be able to persuade her to comply.  So if you have something that is easy to tweak and get going with I am interested

Any ideas on an easy way to test an entire directory tree of flacs?

By 'great track' you were referring to Alive?  So true, and they have made so many great tracks.  I have tickets to their first UK gig for seven years (the last time I saw them).  Cannot wait!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-16 15:07:48
I don't have the code working from within REACT v2 (I did in v1) and I'm not comfortable releasing a modded version of REACT really.  I was just wibbling, as I'd forgotten that I'd done that.  I could see it being useful in various situations (I'd definately like it for creating the DISC tag).  Maybe tycho might see this and show his interest..

If you'd rather not use the @comment@ idea then I would say that you could quite easily re-tag and re-name the files in foobar.  Off the top of my head I would say that, if all the files are in your foobar Media Library, you could search for the existence of "(single)", create a playlist of all those files, retag "<single name> (single)" to "<single name>", and move all files to a "%artist%\Singles\%date% %album%" folder structure.  That shouldn't be much effort.

On the other hand, using the @comment@ tag would allow you to do it as and when, and not have to make amends in batches. Although, it would require some CFG amends, and remembering to add and remove the comment... which isn't quite as easy to do as add " (single)" to the 'album' name.
Title: REACT 2 Released
Post by: steve3386 on 2007-04-17 03:24:35
First, I just want to say that REACT2 is such a great tool.  Thanks for all the work & support on this.  AFter extensive reading, I am planning on ripping my entire CD collection to WavPack images and LameMP3 tracks, using EAC with REACT2.  I have done some test ripping and played with the REACT ini & image-cfg files, and have a few questions.

1) Can I embed the cover (album art) in the WavPack (wv) file? 

2) The comment tag on the MP3 files contains my comment twice (example: "REACT2/EAC; REACT2/EAC").  The comment tag is correct on the WavPack files.  Any idea what would cause this?

3) How do I get ReplayGain track values written into the MP3 files?  I want both the album and track gain values written to the MP3 files, but without applying the gain to the files (no scaling).  I have played around with the files to use wavegain, wvgain, and both (without copying values), but only ever get the album gain values written to the files.  I read here that you get both album and track gain values written into tracks, but maybe that is only in track (not image) mode.  If so, is it possible to do this with MP3 tracks from the wavPack image file through REACT?

4) Is there a difference between using wavegain and wvgain to calculate the ReplayGain values, or ar e they just different implementations of the same algorithm?

5) Is there a way to have the Ipod use the ReplayGain tags.  I thought I read somewhere that there was a program to do this, but that it was only available for Macs.  Any way to do this using a PC?

6) If I let iTunes get the album art for the MP3's, will it embed it into the files so that it can be seen elsewhere, or does it only store it encoded for its own use?

And one suggestion for REACT2: I would frequently get an error from the WavPack executeable because the EAClog was not written yet when the executable was called.  I do not think it was written until I clicked "OK" on the EAC riping report, so if you do not use WaveGain, then WavPack was called too fast.  I added this line just before the call to the WavPack executable in the image section of the image-cfg file, and since then it has always worked fine, and it only stops if it needs to:

IF NOT EXIST "@eaclog@" PAUSE


Thanks in advance for all the great answers and assistance I'm sure to get from this extremely helpful forum!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-17 07:46:38
I have had issues with the log being late also; however, as far as I am aware the wait is generally only for a second or so, and therefore having to pause your automated script for user input may be overkill.

I used the following code, which should check for the existence of the log, and wait for two seconds before trying again, if it is not found:

Code: [Select]
REM ---- Image ----

REM Ensure that the EAC log is available
:CheckForLog
IF NOT EXIST "@eaclog@" GOTO Pause

Code: [Select]
GOTO :EOF

REM Pause for 2000 milliseconds and return to :CheckForLog
:Pause
@ECHO Waiting for EAC log file...
PING 1.1.1.1 -n 1 -w 2000 >NUL
GOTO CheckForLog

Thes first snippet goes under the existing "REM ---- Image ----" line.  The second should be added to the very end of the batch file.

I'm afraid I'm not up on album art and replay gain so I'll leave those for the others.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-17 10:35:29
Please Note:

I have created a REACT category (http://wiki.hydrogenaudio.org/index.php?title=Category:REACT) in the wiki, for the purpose of grouping guides, tips and tricks together.

To start the process, I have documented two recent tips, "Amending Cuesheet File References (http://wiki.hydrogenaudio.org/index.php?title=REACT:Amending_Cuesheet_File_References)" and "Pausing For The Logfile (http://wiki.hydrogenaudio.org/index.php?title=REACT%3a%50ausing_For_The_Logfile)".

I hope that other contributors will find time to document useful tips they they have provided in this thread (I'm looking at you Martin H  ).

If anyone can think of anything else useful that I have contributed in this thread, which they feel should be recorded in the wiki, then please feel free to PM me with the details and I'll try to add it as soon as I have the time.

If you do add pages to this category, please note two formatting requirements:Edit: Actually, if you use "[[Category:REACT|<page name>]]" the page will be indexed correctly, e.g.: "[[Category:REACT|Pausing For The Logfile]]" is now indexed under "P", not "R".
Title: REACT 2 Released
Post by: Nik on 2007-04-17 12:00:56
Please Note:

I have created a REACT category (http://wiki.hydrogenaudio.org/index.php?title=Category:REACT) in the wiki, for the purpose of grouping guides, tips and tricks together.

To start the process, I have documented two recent tips, "Amending Cuesheet File References (http://wiki.hydrogenaudio.org/index.php?title=REACT:Amending_Cuesheet_File_References)" and "Pausing For The Logfile (http://wiki.hydrogenaudio.org/index.php?title=REACT%3a%50ausing_For_The_Logfile)".


Thanks SS.
I hope it will save us time not having to search through the posts, when looking for help how to achieve certain features/scenarios.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-17 13:52:33
I have created a REACT category (http://wiki.hydrogenaudio.org/index.php?title=Category:REACT) in the wiki, for the purpose of grouping guides, tips and tricks together.


Nice job.  and thank you for acknowledging my (meagre) input!  I got a PM from someone today who was frustrated by this limitation and hadn't read this thread fully so I pointed him at our posts

On the sorting singles issue.  I am keen to leave the cd directory structure but achieve the seperation of singles using the Album tree in foobar (easy to change your mind this way and I dont browse the folders much).  I am trying to write code to detect '(single)' in the album tag and add an extra level to the tree as described above.  I am going to study the foobar syntax later and have a bash at it
Title: REACT 2 Released
Post by: Frank vZ on 2007-04-18 07:04:58
Code: [Select]
ECHO s/FILE "@basename@\.wav" WAVE/FILE "%TrackName%\.mp3" MP3/>>sedlist.txt

Valid values for the file type are "WAVE", "MP3" and "AIFF", so if you use FLAC, Wavpack, Monkey's Audio, etc. it's fine/recommended to just leave "WAVE" as "WAVE", but for MP3 you need "MP3".

I have tested these lines in image mode for flac:
Code: [Select]
IF NOT @Flac@==1 GOTO end_flac_tracks
    SET dest="@TrackDir_Flac@"
    IF NOT EXIST %dest% MKDIR %dest%
    PUSHD %dest%
        IF @various@==1 SET VA_tag=-T $qalbum artist=@VA@$q
        IF %embed_cover%==1 SET Cover_tag=--picture=$#x
        @tools@\acdir.exe --overwrite --output "%TrackName%.flac" --extra-opt "|image/jpeg|||@cover@" --pipe "TITLE $n/$N flac $#T & @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist=$#a -T album=$#T -T title=$#t -T tracknumber=$n/$N -T date=$q@year@$q -T genre=$q@genre@$q -T comment=$q@comment@$q -T encoding=$qFlac @Ver_Flac@ @Opt_Flac@$q - -o $#o" "@sourcecuesheet@"
        IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac% *.flac
        COPY /Y "@eaclog@" "EAClog.txt"
        IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
        IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" .
        ECHO s/\.wav"/\.flac"/>>sedlist.txt
        ECHO s/FILE "@cdartist@ - @album@ - /FILE "/>>sedlist.txt
        @tools@\SED -f sedlist.txt <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"
        DEL "sedlist.txt"
        DEL "@albumfile@.[mg].cue"
    POPD
:end_flac_tracks

They seem to work and I prefer image mode since it works even if the last track is a data track. The trade-off is that the sed-commands are more "wildcardish".
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-18 07:55:03
Code: [Select]
ECHO s/\.wav"/\.flac"/>>sedlist.txt
ECHO s/FILE "@cdartist@ - @album@ - /FILE "/>>sedlist.txt
@tools@\SED -f sedlist.txt <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"
DEL "sedlist.txt"

I only used the external command list (sedlist.txt) as I needed to run multiple commands.  Instead of the above, you could just use (untested):

Code: [Select]
@tools@\SED "s/$cdartist$ - $album$ - \(.*\)\.wav/\1\.flac/" <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"

.. but as discussed previously yours does the job and is absolutely fine.  One point though: you are using the non-filename-friendly tokens.  You need to change to:

Code: [Select]
ECHO s/FILE "$cdartist$ - $album$ - /FILE "/>>sedlist.txt


They seem to work and I prefer image mode since it works even if the last track is a data track. The trade-off is that the sed-commands are more "wildcardish".
If this turned out to be an issue you could stick with the syntax you have, but add the line to write the SED command to sedlist.txt as part of the ACDIR run.

I.e.:  ACDIR is already setting the console title and running FLAC for each track (2 separate commands).  You could just append "& <my command line>" to the end of the ACDIR call and the command would execute for each track (<set title> & <run FLAC> & <write to sedlist>).

I don't think this should ever be necessary though.  Just for interests sake.
Title: REACT 2 Released
Post by: Frank vZ on 2007-04-18 19:42:29
Code: [Select]
@tools@\SED "s/$cdartist$ - $album$ - \(.*\)\.wav/\1\.flac/" <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"

Have just tried this: Great! 

They seem to work and I prefer image mode since it works even if the last track is a data track. The trade-off is that the sed-commands are more "wildcardish".
If this turned out to be an issue you could stick with the syntax you have, but add the line to write the SED command to sedlist.txt as part of the ACDIR run.

I.e.:  ACDIR is already setting the console title and running FLAC for each track (2 separate commands).  You could just append "& <my command line>" to the end of the ACDIR call and the command would execute for each track (<set title> & <run FLAC> & <write to sedlist>).

Will try this later...
Title: REACT 2 Released
Post by: lipidicman on 2007-04-19 16:29:58
Code: [Select]
@tools@\SED "s/$cdartist$ - $album$ - \(.*\)\.wav/\1\.flac/" <"@albumfile@.[mg].cue" >"$cdartist$ - $album$.cue"


Could you not use the form we used to replace the EAC name with the REACT name.  Or is this not an issue with Images? (I haven't used them)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-19 17:10:14
Frank vZ is ripping to an image and then using ACDIR to create tracks.  The image config has no way of knowing what the track names (or naming schemes) are.  The only thing that deals with track names is ACDIR, as it processes the cuesheet to split the image and add tags.

With this in mind, you could use a similar format if you created a SED command for each track via ACDIR (as mentioned in my previous post), but you would still have to hard code the initial format I think, as you have no track-based @basename@ to refer to ... off the top of my head.


BTW, while I'm here,  I played around a bit more with my idea for passing/parsing tags in the Artist, Album and Comment fields to create additional tokens (like @disc@, @discnumber@, etc.).

Unfortunately, getting it to work with Artist and Album in REACT is a bit messy, although it's simple with Comment.  However, accessing the comment field is not as easy as the Artist and Album fields, and it's length is limited, so I'm not sure about the use of that.

I did get it working with Artist and Album, but it involves: grabbing the values; getting the tags and storing them in a temporary text file; removing the tags before any processing starts (otherwise filenames are really screwy and a lot more work is needed); and finally, on encoding, reading the tags from the text file and adding them to any found in the comment.  As I say, a bit messy, although it does work.  I've uploaded a script demonstrating the possibilities (not within REACT - it's just a little dialogue that converts tags to values) if anyone is interested: react-tags.au3 (http://www.synthetic-soul.co.uk/temp/react-tags.au3) (5KiB, needs AutoIt installed to run) and react-tags.zip (http://www.synthetic-soul.co.uk/temp/react-tags.zip) (176KiB, compiled EXE - no need for AutoIt).  NB: I see newer versions of AutoIt have regular expressions inbuilt.  That would have been really handy.

I had another idea, regarding a hotkey that opens up a dialogue as part of REACT, in which you can specify other information - now I come to think about it a simple key/value list (pretty much like the foobar properties dialogue) would be most flexible, so you can create new tokens of any given name, with any given value.  I had originally thought of a dialogue that extends the Artist/Album/Genre/Year submissions, providing Discnumber/TotalDiscs/DiscName, etc. text boxes - but a key/value submission would be most flexible.  Perhaps a few key fields could be included with a key/value list for additional/bespoke tokens.  Dunno, just another idea to throw in the pot.
Title: REACT 2 Released
Post by: Frank vZ on 2007-04-19 20:39:37
They seem to work and I prefer image mode since it works even if the last track is a data track. The trade-off is that the sed-commands are more "wildcardish".
If this turned out to be an issue you could stick with the syntax you have, but add the line to write the SED command to sedlist.txt as part of the ACDIR run.

I.e.:  ACDIR is already setting the console title and running FLAC for each track (2 separate commands).  You could just append "& <my command line>" to the end of the ACDIR call and the command would execute for each track (<set title> & <run FLAC> & <write to sedlist>).

I don't think this should ever be necessary though.  Just for interests sake.

I have just tried out these lines:
Code: [Select]
        @tools@\acdir.exe --overwrite --output "%TrackName%.flac" --extra-opt "|image/jpeg|||@cover@" --pipe "TITLE $n/$N flac $#T & @tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist=$#a -T album=$#T -T title=$#t -T tracknumber=$n/$N -T date=$q@year@$q -T genre=$q@genre@$q -T comment=$q@comment@$q -T encoding=$qFlac @Ver_Flac@ @Opt_Flac@$q - -o $#o & ECHO s/$cdartist$ - $album$ - %TrackName%\.wav/%TrackName%\.flac/>>sedlist.txt" "@sourcecuesheet@"
        @tools@\SED -f sedlist.txt <"@albumfile@.[mg].cue" >"$cdartist$ - $album$ (noncompl).cue"
        DEL "sedlist.txt"

They worked out fine! 
To make them perfect, I would appreciate any hints about getting the 'FILE "'-part into the ACDIR options. I left it out because I didn't know how to include the quote... 
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-19 20:52:20
Cool.

It should just be a case of using ACDIR's $q token.

Code: [Select]
ECHO s/FILE $q$cdartist$ - $album$ - %TrackName%\.wav$q/FILE $q%TrackName%\.flac$q/>>sedlist.txt

You could also swap REACT's tokens for ACDIR's tokens (not sure why):

Code: [Select]
ECHO s/FILE $q$#a - $#T - %TrackName%\.wav$q/FILE $q%TrackName%\.flac$q/>>sedlist.txt
Title: REACT 2 Released
Post by: Frank vZ on 2007-04-19 21:19:51
This line finally rocks: 
Code: [Select]
ECHO s/FILE $q$cdartist$ - $album$ - %TrackName%\.wav$q/FILE $q%TrackName%\.flac$q/>>sedlist.txt

Unfortunately, I couldn't use the short ACDIR tokens for cdartist and album, since they return the values in quotation marks...
Title: REACT 2 Released
Post by: lipidicman on 2007-04-20 13:06:23
I had another idea, regarding a hotkey that opens up a dialogue as part of REACT, in which you can specify other information - now I come to think about it a simple key/value list (pretty much like the foobar properties dialogue) would be most flexible, so you can create new tokens of any given name, with any given value.  I had originally thought of a dialogue that extends the Artist/Album/Genre/Year submissions, providing Discnumber/TotalDiscs/DiscName, etc. text boxes - but a key/value submission would be most flexible.  Perhaps a few key fields could be included with a key/value list for additional/bespoke tokens.  Dunno, just another idea to throw in the pot.


and a very good idea at that.  Keep this one on the burner.  This forum has opened my eyes to the possibilities of EAC (I used to simply use it to make CDs back in the day, no freeDB, no LAME, certainly no REACT) but being the perfectionist I am it has opened my eyes to the limitations and this solution would be a big gap filler in my eyes.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-20 13:25:05
I'm already thinking things through a bit.

(http://www.synthetic-soul.co.uk/temp/additional-meta-data.png)

I should probably be concentrating on how the data will be maintained, how it will fit into REACT, etc., but I couldn't resist having a play with AutoIt's GUI script.

We'll see.  It may eventually get into a position where tycho might show some interest, but I'm sorely lacking time at the moment.
Title: REACT 2 Released
Post by: Frank vZ on 2007-04-21 09:00:47
One of my CDs contains 3 audio tracks and 1 data track at the end. When I use REACT in image mode and tell REACT to create all cue sheets, the resulting *.[mg].cue only refers the range.wav instead of the multiple wav files. I.e. it looks like the *..cue.  This problem only occurs from time to time - sometimes everything works the way it should.
Does anyone know about this issue?

Edit: This also happens with CDs not containing data tracks.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-23 13:17:06
One of my CDs contains 3 audio tracks and 1 data track at the end. When I use REACT in image mode and tell REACT to create all cue sheets, the resulting *.[mg].cue only refers the range.wav instead of the multiple wav files. I.e. it looks like the *..cue.  This problem only occurs from time to time - sometimes everything works the way it should.
Does anyone know about this issue?

Edit: This also happens with CDs not containing data tracks.


Remind me, are you ripping tracks, or images (and splitting to tracks)?

I rip tracks.  If this problem affects me I have not noticed it


(http://www.synthetic-soul.co.uk/temp/additional-meta-data.png)


This is a prototype right?  I got all excited there for a nanosecond
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-04-23 13:42:43
This is a prototype right?  I got all excited there for a nanosecond
I spent a little more time on it over the weekend.  I now have that GUI working as a standalone script, so that you can add, edit and delete items.  I also have it populating from an INI file.

I am intending to see it through, so that you can press a hotkey with EAC/REACT open and the dialogue will open, etc.  However, I don't know what I'll do with it once I've satisfied my curiosity.  I don't want to p*ss of tycho at all, and I'm not overly interested in creating some sort of confusing REACT fork.  Once I'm done maybe I'll post the code and see if tycho is interested.  The easiest way is probably to post a patch to the REACT source, so that anyone can apply the patch and create a new EXE themselves.  I need to check what license REACT is released under, and then try to understand what that means.

If it's as useful as I think it could be then I hope that tycho will approve.
Title: REACT 2 Released
Post by: Frank vZ on 2007-04-23 16:10:58

One of my CDs contains 3 audio tracks and 1 data track at the end. When I use REACT in image mode and tell REACT to create all cue sheets, the resulting *.[mg].cue only refers the range.wav instead of the multiple wav files. I.e. it looks like the *..cue.  This problem only occurs from time to time - sometimes everything works the way it should.
Does anyone know about this issue?

Edit: This also happens with CDs not containing data tracks.


Remind me, are you ripping tracks, or images (and splitting to tracks)?

I rip tracks.  If this problem affects me I have not noticed it


This problem occured in both, image and track mode. It seems to me that it only happens directly after starting REACT and it may take a few tries till the cue sheets are built correctly. Once it worked, the problem never reoccured unless restarting REACT. But it's hard to describe, since it occurs only sporadically. 
Title: REACT 2 Released
Post by: lipidicman on 2007-04-24 13:15:09
This problem occured in both, image and track mode. It seems to me that it only happens directly after starting REACT and it may take a few tries till the cue sheets are built correctly. Once it worked, the problem never reoccured unless restarting REACT. But it's hard to describe, since it occurs only sporadically. 


Probably not related, but I have had problems where the cuesheets cause problems.  I changed gap detection mode (from C to A) and now I get it less.  Also, if you abandon a rip it seems to be necessary to close EAC and then close the REACT icon in the taskbar before restarting REACT.  If you do not one problem I noticed was the ripping window would not be closed and therefore the log file would not be ready

I am intending to see it through, so that you can press a hotkey with EAC/REACT open and the dialogue will open, etc.  However, I don't know what I'll do with it once I've satisfied my curiosity.  I don't want to p*ss of tycho at all, and I'm not overly interested in creating some sort of confusing REACT fork.  Once I'm done maybe I'll post the code and see if tycho is interested.  The easiest way is probably to post a patch to the REACT source, so that anyone can apply the patch and create a new EXE themselves.  I need to check what license REACT is released under, and then try to understand what that means.

If it's as useful as I think it could be then I hope that tycho will approve.


Lets hope so.  I would certainly be interested in testing this for you!
Title: REACT 2 Released
Post by: scooterfrog on 2007-04-24 16:16:04
wow very cool tool baut a but over whelming.

I currently rip with audeio grabber
then mp3 gain
then clean tags and embed album art with mp3tag

could I get some help with image and track cfgs
I want to rip an album to mp3 tracks (lame -b 320)
run mp3 gain ( track)  89db (mp3gain /r /c)
embed album art
clean tags like this

delete leading and trailing spaces in tags
remove the and The on artists
change & to and
change : and _ to spaces

and write the mp3 files to
c:\music\%artist%\%artist% - %album% - %track% - %title%
Title: REACT 2 Released
Post by: Frank vZ on 2007-04-24 18:27:26

This problem occured in both, image and track mode. It seems to me that it only happens directly after starting REACT and it may take a few tries till the cue sheets are built correctly. Once it worked, the problem never reoccured unless restarting REACT. But it's hard to describe, since it occurs only sporadically. 

Probably not related, but I have had problems where the cuesheets cause problems.  I changed gap detection mode (from C to A) and now I get it less.  Also, if you abandon a rip it seems to be necessary to close EAC and then close the REACT icon in the taskbar before restarting REACT.  If you do not one problem I noticed was the ripping window would not be closed and therefore the log file would not be ready

Thanks for the hints! It is very well possible that my problems only occured after having abandoned a rip previously. I will have an eye on this.
Title: REACT 2 Released
Post by: lipidicman on 2007-04-25 14:14:32
could I get some help with image and track cfgs
I want to rip an album to mp3 tracks (lame -b 320)
run mp3 gain ( track)  89db (mp3gain /r /c)
embed album art

clean tags like this

delete leading and trailing spaces in tags
remove the and The on artists
change & to and
change : and _ to spaces

and write the mp3 files to
c:\music\%artist%\%artist% - %album% - %track% - %title%


REACT's ini will let you do all the bold bits I believe.  The rest?  I make sure my EAC freeDB info is correct before ripping.  I leave 'The' on the start and then have foobar remove it in my album tree (this way I can change my mind later)  I am sure you can have react do this for you (using something like SED maybe) but I am not the man to write the script for you I am afraid
Title: REACT 2 Released
Post by: scooterfrog on 2007-04-25 21:09:35

could I get some help with image and track cfgs
I want to rip an album to mp3 tracks (lame -b 320)
run mp3 gain ( track)  89db (mp3gain /r /c)
embed album art

clean tags like this

delete leading and trailing spaces in tags
remove the and The on artists
change & to and
change : and _ to spaces

and write the mp3 files to
c:\music\%artist%\%artist% - %album% - %track% - %title%


REACT's ini will let you do all the bold bits I believe.  The rest?  I make sure my EAC freeDB info is correct before ripping.  I leave 'The' on the start and then have foobar remove it in my album tree (this way I can change my mind later)  I am sure you can have react do this for you (using something like SED maybe) but I am not the man to write the script for you I am afraid


thanks io got most if it working
I am sure I can get it to work with SED
then I treid to isntall the album art downlaoder.
it required dot net 3
it worked but now acdir is giving em unhandled exceptions  and needing to turn on the just in time debugger.
damn


uninstalled and reinstalled.
more of the same.
rips fine in track mode.  that doesn't use acdir right.
I can get proabaly get it to do everyting I want.
Title: REACT 2 Released
Post by: scooterfrog on 2007-04-26 01:35:50
Quote
thanks i got most if it working
I am sure I can get it to work with SED
then I treid to isntall the album art downlaoder.
it required dot net 3
it worked but now acdir is giving em unhandled exceptions  and needing to turn on the just in time debugger.
damn


uninstalled and reinstalled.
more of the same.
rips fine in track mode.  that doesn't use acdir right.
I can get proabaly get it to do everyting I want.

found that problem it was a typo on my acdir file nameing conventron string.
so i can reapply dot net 3  and used the newer verion of album art cover downloader


next question
when ripping images

the process is rip image, process bat file.
any way to make it not process the bat file.

I could then just rip a bunch of cds to images. create a bunch of batch files and then kick them off later  ( when I go to bed  un attended).

better yet I could easily chain the batch files together.

how to keep the batch files from executing.

I have a couple of ideas but would appeceiate an easier way
idea
make the batch file look for a special file or quit.  then the batch wont run at rip time and leave everyting in place. then create that special file (simple text file run.ok)  and re run the batch files.
idea off

second new question 
I use mp3 track gain  I put that in the image cfg.  it works.
but metamp3 uses mp3gain source code right.  do I just set applyreplygain =1 and albumn gain = 0 
does it change the file not just tags?

I use itunes, and ipods  but all mp3 no aac
my alpine ipod controller ( the new ida) plays digitally from ipods or other mass storqage devices I dont htink it supports soundheck internally.
Title: REACT 2 Released
Post by: scooterfrog on 2007-04-26 04:40:52
Quote
second new question 
I use mp3 track gain  I put that in the image cfg.  it works.
but metamp3 uses mp3gain source code right.  do I just set applyreplygain =1 and albumn gain = 0 
does it change the file not just tags?

I use itunes, and ipods  but all mp3 no aac
my alpine ipod controller ( the new ida) plays digitally from ipods or other mass storqage devices I dont htink it supports soundheck internally.


just tried it.
changing the ini file to replay gain 1 album gain 0 does not give the same result as mp3 gain defaults.

the metamp3 is louder but thatsall i could tell. I dont have any thing that reads the ape tags
I could un mp3gain all my files ( it reversable)
and re apply gain with metamp3.  on all my files.  (50gb)
then simply use the metamp3 stuff above.

I wna them track normalized because I mosly listen to my music on complex play list  shuffles.


I should just go to bed
I found the metamp3 thread
its 3db louder
I canuse metamp3 to undo, redo and apply mp3gain(ed) files.
it uses standasd tags
tycho is god
Title: REACT 2 Released
Post by: wraithdu on 2007-04-26 04:58:28
any way to make it not process the bat file.

I could then just rip a bunch of cds to images. create a bunch of batch files and then kick them off later  ( when I go to bed  un attended).

better yet I could easily chain the batch files together.

how to keep the batch files from executing.


Hit CTRL-Q (or Tools -> Compression Queue Control Center) and tick the box 'Make all compression tasks sleep'.  When you're done for the night, go back, untick the box and click OK.  Your compression tasks will now start all queued up.  Wake up happy
Title: REACT 2 Released
Post by: scooterfrog on 2007-04-26 18:23:07


any way to make it not process the bat file.

I could then just rip a bunch of cds to images. create a bunch of batch files and then kick them off later  ( when I go to bed  un attended).

better yet I could easily chain the batch files together.

how to keep the batch files from executing.


Hit CTRL-Q (or Tools -> Compression Queue Control Center) and tick the box 'Make all compression tasks sleep'.  When you're done for the night, go back, untick the box and click OK.  Your compression tasks will now start all queued up.  Wake up happy

thx
Title: REACT 2 Released
Post by: Stone Free on 2007-04-27 19:16:54
In track mode how can I get Various Artists to create the artist directory based on the $artist$ tag, as the following doesn't work.

TrackName_VA=$artist$\$track$ - $title$

This did not create an Artist directory, or create the finished track.
Title: REACT 2 Released
Post by: scooterfrog on 2007-04-27 19:27:48
new question
in image mode
I would like to clean tags ( see my prevous post)
I think I want to use SED on the cue file befor calling acdir.

any suggestions /  examples
Title: REACT 2 Released
Post by: Golfer on 2007-04-29 04:00:48
Having a small problem with embedding album art.  Everything else seem to do Ok, I do a F10 Album Art downloader come up and I save it(might not be saving to correct location).  I edited the REACT.ini file only. I don't know enough about scripting to edit the REACT-image.cfg file.  I running windows xp2, update the to flac v1.14 and AlbumArtDownloaderXUI.  I can embed albumart using MP3Tag.

Good news, I got it working.  I needed 'CreateAllCuesheets=0' set to 1 instead of 0. And name of file saved as album name and saved to root directory of file where the music was to be saved.
Title: REACT 2 Released
Post by: lipidicman on 2007-05-01 15:23:11
In track mode how can I get Various Artists to create the artist directory based on the $artist$ tag, as the following doesn't work.

TrackName_VA=$artist$\$track$ - $title$

This did not create an Artist directory, or create the finished track.


Hang on, artist will vary for a various artists album!  I use VariousArtists/Album/number -- track -- artist.flac
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-03 07:06:03
(http://www.synthetic-soul.co.uk/temp/additional-meta-data.png)
This is a prototype right?  I got all excited there for a nanosecond
I thought it was about time that I made it known publicly that I now have this working.

With my amended EXE pressing Alt+F5 will bring up a non-modal dialogue very similar to that above (it has since been turned into a toolbox dialogue so that it does not show up in the task bar).

The dialogue allows you to set both disc- and track-level meta data.  Setting "discnumber" to 1 as above, will allow you to use the tokens @discnumer@ (1) and $discnumber$ (01) in your CFG (for $-style tokens integers are zero-padded and strings are converted to their filename-friendly equivalent).

For users ripping to tracks the format "<token>[<track>]" may be used. E.g.: "composer[1]" will set the @composer@ token value for track one, "composer[2]" will set the @composer@ token value for track two, etc.

As an example of how the default "discnumber" and "totaldiscs" tokens may be used:

Code: [Select]
IF @totaldiscs@ GTR 1 SET TrackDir_Flac=%TrackDir_Flac% (Disc @discnumber@)

or

Code: [Select]
IF @totaldiscs@ GTR 1 SET D_Wavpack=-w "discnumber=@discnumber@" -w "total discs=@totaldiscs@"
...
@tools@\wavpack.exe @Opt_Wavpack@ %RG_Wavpack% %D_Wavpack% -w "%ArtistField%=@cdartist@" ...

I have recently made some steps towards adding these values to the cuesheet(s) also.

@Tycho : Are you happy for me to release an EXE with source, or would you like me to send it to you for your perusal first?  I can find no documentation regarding REACT's license, and I have no desire to annoy you or hinder your work with REACT.  I will no release this publicly until I have a response from you.
Title: REACT 2 Released
Post by: tycho on 2007-05-03 14:40:30
@Synthetic Soul: Thanks for working and supporting REACT. I have been very silent in this thread - sorry. Please release the new version, including source code. I am slowly working on a new version, but it's not a major upgrade. If you have the new GUI code fairly separated from the rest (in functions), it should be easy for me to integrate it in my code later.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-03 14:45:14
OK tycho, will do.

Where possible I have functionalised all new code and put it in a new au3 file which is in turn included by REACT.au3.  I have then had to amend REACT.au3 just to add calls to those functions where relevant.

I'll make sure that it's all in a good state and upload later on.

Thanks again.

Edit: Ah, I just remembered a key point.  I have utilised the new regular expression functionality in the latest version of AutoIt, so it will not compile with earlier versions.  I'm using the stable 3.2.2.0.  Not sure if this is an issue with you.

FYI: The system utilises it's own INI file (metadata.ini) in the REACT directory, to achieve persistence.  The INI has two sections: "Default" sets the default token/value pairs available upon initialisation (which also occurs when a new disc is inserted, or drive changed) while "Current" stores the active token/value pairs for the current run.  The INI is created if not present, and neither the REACT.ini or CFG files are touched.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-03 16:00:22
OK, REACT_2.0.ssb5.zip (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb5.zip) has been uploaded.

The zip contains the EXE, a readme, the original source and icon, and the new source files.

The readme is a hastily-put-together document describing the new functionality.

A few points:Edit: And remember: running this new version (2.0.ssb5) will result in your REACT.ini file being rewritten!  Either amend the first line to "Version=2.0.ssb5" in your ini, or make a backup!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-04 21:32:55
The Additional Meta Data dialogue is non-modal, but does stay on top of all windows.  My preference would be to act as it currently does, but stay on top of EAC only; however I don't think I can do this.
I'm really pleased to say that I have resolved this.  I can't  believe that it was such an easy fix  - I'm kicking myself.  The  dialogue now stays on top of the EAC window, but not other windows (it is a child of the EAC window).

I have also made the dialogue disabled as soon as ripping begins, and re-enabled when ripping finishes, to save any confusion.

Source-wise, to save confusion, I have renamed the functions to begin "fDiag..." rather than "fGUI...", as that prefix has already been used by the main source when referring to the main window.

REACT 2.0.ssb6 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb6.zip)

The dialogue will revert to the default values any time the EAC window title changes - which should be on disc or drive change. I did this as I saw little point in retaining, e.g., discname=Jupiter, if the disc has changed. It's possible this may confuse or annoy people.
I noticed another, unwanted, side of this tonight.  As the function looks for a change in the window title amending the CD Artist or CD Title will cause the dialogue to reset.  With this in mind the basic idea is to just deal with the dialogue as the last step, after you have ensured that the main meta data is correct.

As I say, and depending on what Tycho chooses to do with this, if you give this a try maybe you'll come up with a better way for the dialogue to work.  It needs some proper user testing to come up with the optimum resolve for the majority... personally, as it stands, I intend to just remember to work with the dialogue as the last step before hitting F10 - once the main dialogu is "stable" (disc inserted, freedb data down and checked).
Title: REACT 2 Released
Post by: brainsoft on 2007-05-07 04:58:22
I just wanted to say, for anyone interested, to check out this thread if you want AccurateRip checking with Image ripping (http://www.hydrogenaudio.org/forums/index.php?showtopic=53583&st=25&gopid=490640&#).  It's not ideal, you need Perl installed, but it works!

http://www.hydrogenaudio.org/forums/index....id=490640&# (http://www.hydrogenaudio.org/forums/index.php?showtopic=53583&st=25&gopid=490640&#)


I've not ready through this thread in a while, I'll have to later to see if there have been any other good advances
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-08 14:42:50
If anyone is testing my REACT mod, 2.0.ssb6 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb6.zip), they may want to read the wiki article REACT:Adding Support For Disc Information (http://wiki.hydrogenaudio.org/index.php?title=REACT:Adding_Support_For_Disc_Information).  I've gotten around to updating my config files to use the @discname@, @discnumber@ and @totaldiscs@ tokens provided by 2.0.ssb6 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb6.zip) to set folder paths and tags.  I thought I may as well document the changes, so here they are.

@Tycho

Given the underwhelming response to 2.0.ssb6 I wonder whether it is worth your time integrating my changes into your core release.  I am happy to maintain a mod for those that want it... if we can agree on a sensible version string, or something...
Title: REACT 2 Released
Post by: ESP85 on 2007-05-13 22:07:07
3) How do I get ReplayGain track values written into the MP3 files? I want both the album and track gain values written to the MP3 files, but without applying the gain to the files (no scaling).


I would like to know about this also.

How can this be done?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-14 07:24:20
This really isn't my field, but as no-one else is answering...

I believe that you simply need to rip to an image (even though you want MP3 tracks), and amend yor INI so:

Code: [Select]
ImageExt=wav
...
LameMP3=1
...
ReplayGain=1
ApplyAlbumGain=0
...
UseWaveGainAG=1

This should create a WAVE image from which WaveGain can calculate album gain.  It will then split that into track MP3s, write the RG tags, and eventually delete the WAVE image file.
Title: REACT 2 Released
Post by: ESP85 on 2007-05-14 08:04:07
Yeah, that writes the album RG to each track but not the track RG.

I've tried adding "--replaygain-accurate" to my "Opt_LameMP3=" line but it won't write the track RGs for some reason.

Or maybe it does and metamp3.exe erases them when it updates the files?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-14 08:16:12
Again, not my field, but I think the RG tags that LAME writes are not compatible with "normal" RG tags anyway.

I'll try to have a think about the track gain.

I don't use it generally, certainly not through REACT, so I'm not really up on it I'm afraid.
Title: REACT 2 Released
Post by: tycho on 2007-05-14 08:49:11
OK, inputs are noted. To tag both AG and TG but not apply them, you must set

ReplayGain=1
ApplyAlbumGain=0
UseWaveGainAG=0  ; when 1, it computes AG scale value to apply on lame while encoding. 

I will rethink how to organise the RG options in future releases.
Title: REACT 2 Released
Post by: lipidicman on 2007-05-14 15:19:19
I need 'big-up' the above, since I pushed for its development (and did diddly-squat else).

Eac can only add ARTIST, ALBUM and TRACKNAME.
What about Two Disc albums?  You could put (disc2) in the name, then you need to adjust the tags to get foobar to list the two discs together
Wouldn't it be great if you could tell REACT the DISCNUMBER, TOTALDISCS and maybe add a tag for the type (Single, Album, Live etc)
Synthetic Soul's Mod allows you to do just this by creating REACT variables that you can add to your REACT config.  The possibilities are endless (well, maybe not endless and I think I might have borrowed that slogan and....ahem)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-14 15:32:51
 Thank lipidicman!

I must admit that I am slightly bemused by the lack of interest... but if the two of us find it useful then that's something.  It was an interesting project to undertake regardless - I needed to get it out of my system.

I will reiterate that I see no point in merging this with the core REACT dist until a lot more people show interest!

With that in mind, I suppose the following question is moot, but, meh:

What additional tokens/tags/meta data do people think would be useful to submit from EAC?

My mod has DISCNUMBER, TOTALDISCS and DISCNAME by default, and I'm finding them useful.  I have amended my conf to add disc-related tags, and to use a "Artist\Album\Disc" folder structure where relevant.  I previously had to do this manually, and only bothered with the MP3s, not the WavPack images, so it's saving me time and hassle.

I did consider including ALBUM SUBTITLE in the defaults, but they so infrequently have one; I may adapt my config to be able to cope with one though, in the unlikely event.  I know lipidicman was talking of using a DISCTYPE token, which could process discs differently, according to whether they were albums, singles, EPs, etc.

I just wondered whether anyone else could see a really useful addition to the tokens, out of curiosity.  Bear in mind that the token value can be yes/no, a number, or a string, and you can even set a token for an individual track (I have used the example "@composer@" previously)...
Title: REACT 2 Released
Post by: lipidicman on 2007-05-14 15:53:31
The users who would really benefit (as already recognised by the 'COMPOSER' idea) are Classical fans.

I am leaving my classical albums until I find a decent guide.  Tagging these properly seems like a minefield
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-14 16:19:23
The users who would really benefit (as already recognised by the 'COMPOSER' idea) are Classical fans.

I am leaving my classical albums until I find a decent guide.  Tagging these properly seems like a minefield
True on all accounts.

NB: I have now uploaded beta 9 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb9.zip).  Here's the revamped readme (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb8_readme.txt).

Changes:Remember to set Version to 2.0.ssb9 in your REACT INI before running, if you don't want to lose the contents.

Edit: Updated to beta 9 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb9.zip)  - track cuesheets now supported.
Title: REACT 2 Released
Post by: gsa999 on 2007-05-15 13:21:25
I am having trouble with CoverDownloader and REACT2. I want to be able to select a folder.jpg from an existing folder on my hard disc rather than go out to the web. Is this possible. If not can I disable it altogether in REACT2.
If I do this is there a tool that I can use later on to batch add albumart to flac and mp3 tracks and a flac image.

Rgds
G
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-15 13:28:05
You can disable it by setting RunCoverDownloader=0 in your REACT.ini file.

To use existing artwork you would need to amend your config to stop relying on CoverDownloader and to point to the existing image.  Edit: Actually, if you put the cover in the working directory, with the same name as the EAC log (album name, with illegal chars replaced with spaces), it would work as is (still setting RunCoverDownloader to 0).

How are your existing covers filed?
Title: REACT 2 Released
Post by: lipidicman on 2007-05-15 15:20:09
I want to try your mod on my main ripping machine (been trialling it on my laptop till now)
Can I just copy my REACT directory apply it there and run it without affecting my tweaked setup?  I think this will work but wanted to check.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-15 15:26:03
The only issue I can see is a potential difference in paths used in your REACT ini ([UserOutputNames] section).

As for the mod, it won't be affected.

To confirm my understanding: if you copy REACT.ini, REACT.exe, REACT-image.cfg and REACT-track.cfg from your laptop to the PC then the INI will remain as it is, REACT will still be modded, and everything should run as it did on the laptop.
Title: REACT 2 Released
Post by: gsa999 on 2007-05-16 08:47:33
How are your existing covers filed?

Hi, thanks for the info.
All my images are stored in a single folder in the following format  "Artist - Album Title". I have used a program called Catraxx to catalog my music collection for the last 10 years or so and having all the cover art in a single folder was the best way to organise things. Now I want to embark on ripping my entire collection but using the coverart I already have becuase (a) they are all the same size and (b) they are all good quality.

Are you saying that if I copy all the images to my working directory (which one is this?) it will pick them up automatically. When I rip to image I use the format "artist - year - album title"; for tracks it is "artist - album title - trackno - tracktitle"

G
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-16 09:22:54
All my images are stored in a single folder in the following format  "Artist - Album Title".
...
Are you saying that if I copy all the images to my working directory (which one is this?) it will pick them up automatically. When I rip to image I use the format "artist - year - album title"; for tracks it is "artist - album title - trackno - tracktitle"
REACT looks for an image with the same name as the EAC log, which is the album name with all illegal characters replaced with spaces.  Your naming scheme is irrelevant.

I see two options:
Title: REACT 2 Released
Post by: gsa999 on 2007-05-16 13:13:59
I see two options:
  • You create a script to rename all your images using REACT's format (as described above).  You put all the images in the working folder, and off you go.
  • You amend your config to look for the images where they reside, using their existing naming scheme.  This wouldn't be too much of a problem, except that you need to make sure that REACT uses the same illegal character replacement scheme as you did when naming the images - which could actually be a problem.  That said, there should only be a few albums where that's an issue, so you could deal with those manually afterward.

Hi again.
I am not at all familiar with scripting and am not sure where to start with option 1. Option 2 looks a little more manageable to me. Could you give me an example of what I would need to put in the config file and whereabouts assuming my files are in folder "c:\my documents\catraxx\cover art\*.jpg" in the format "artist - album title"

Many thanks
G
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-16 13:36:52
I don't have time to test this, but here's a start: From a previous post I am assuming that you are ripping to FLAC image with FLAC and MP3 tracks.

In your REACT.ini ensure the settings below:

Code: [Select]
[Settings]
...
ImageExt=flac
RunCoverDownloader=0
...
[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0
...
[UserSettings]
...
EmbedCover=1
...

In your config (REACT-image.cfg), presuming it has not been edited previously, on line 49 you will see:

Code: [Select]
IF EXIST "@cover@" (
    SET have_cover=1
    SET embed_cover=@EmbedCover@
)

Change that code to:

Code: [Select]
SET cover = C:\My Documents\Catraxx\Cover Art\$cdartist$ - $album$.jpg
IF EXIST "%cover%" (
    SET have_cover=1
    SET embed_cover=@EmbedCover@
) ELSE (
    ECHO.
    ECHO WARNING: '%cover%' does not exist!
    ECHO.
)

Then, find and replace any instance of the text "@cover@" in the subsequent code with "%artist%". E.g. on line 108, change:

Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"

... to:
Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||%cover%"

Pay particular attention to lines 108, 150 and 180.
Title: REACT 2 Released
Post by: wraithdu on 2007-05-16 17:01:16
Another option for you - upgrade to the latest version of Albumart Downloader (find the thread in the Uploads forum).  It is version XUI 0.4.1; this is the continuation of the original CoverDownloader project.  In the options you can set a location for local files (you an then disable all the online searches).  The XUI version will accept the same parameters as the old CoverDownloader, so you just need to amend the path in your react.ini.

You need .NET 3 for this to work.

If you do it this way, you don't have to worry about editing all the stuff above, and naming issues shouldn't be a problem.
Title: REACT 2 Released
Post by: gsa999 on 2007-05-17 08:17:02
Synthetic Soul and Wraithdu
Thanks for both of your tips on this  . I am going to have a go with both options over the weekend to see how I get on before going for one of them. I'll let you know which one I ended up with.

Just one thing re Synthetic Souls code. You say I should replace all instances of @cover@ with %artist% but the line 108 example replaces it with %cover%. I think the example is probably correct, but could you just confirm that please. Thanks
Title: REACT 2 Released
Post by: lipidicman on 2007-05-18 13:36:09
Was there ever a fix for albums with data tracks on the end.  I have been trying to make the postprocessing occur at @numtracks@-1 for these albums but the decision in the track.cfg seems to hold numtracks as a string making it hard to subtract one (for a newbie like me).  Any help out there?

If this cant be fixed in react standard, maybe SS's mod would allow the user to overwrite numtracks for these few albums?  Just musing on the idea
Title: REACT 2 Released
Post by: wraithdu on 2007-05-18 15:20:19
Was there ever a fix for albums with data tracks on the end.  I have been trying to make the postprocessing occur at @numtracks@-1 for these albums but the decision in the track.cfg seems to hold numtracks as a string making it hard to subtract one (for a newbie like me).  Any help out there?

If this cant be fixed in react standard, maybe SS's mod would allow the user to overwrite numtracks for these few albums?  Just musing on the idea

Try setting @numtracks@ to a variable and using that to test
Code: [Select]
SET /a endtrack=@numtracks@-1

of if that doesn't work

SET _numtracks=@numtracks@
SET /a endtrack=%_numtracks%-1
Title: REACT 2 Released
Post by: lipidicman on 2007-05-18 15:58:20
Cheers, I'll give that a try.  I could then change the config for an album with a data track (I only have a handful)

I wonder if it could be possible to test for the presence of a data track and have react decide automatically
Title: REACT 2 Released
Post by: gsa999 on 2007-05-20 08:40:46
Synthetic Soul and Wraithdu
Thanks for both of your tips on this  . I am going to have a go with both options over the weekend to see how I get on before going for one of them. I'll let you know which one I ended up with.

Both,
I thought I would let you know how I got on with both options.

I tried the latest version of AlbumArtDownloader first. In an ideal world it did exactly what I was looking for. Trouble is it was very very slow and even reduced my machines virtual memory to zero and I had to reboot. It was just unworkable. My laptop is about 4.5 years old so it probably isn't up to running something that requires .NET3

I then tried Synthetic Souls solution and this worked perfectly apart from it deleting my original file. I REMed out the delete %cover% at the end of the cfg to fix this

So I am going to stick with this solution. Thanks for your help.
Title: REACT 2 Released
Post by: lipidicman on 2007-05-21 10:41:14
Try setting @numtracks@ to a variable and using that to test
Code: [Select]
SET /a endtrack=@numtracks@-1


This worked a treat.  Thank You!.  My Enhanced CD was post processed.  The cuesheet needs a manual tweak but that is it.  Now I need to use a TAG is SS's mod to tell the script whether I have an enhanced CD
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-23 13:58:56
I assume that you could do this yourself, but just in case, this is what I would do (untested):

Create a new token called "datadisc" in your Additional Meta Data defaults, and set it to "0" (false):

Code: [Select]
[DefaultMetaData]
discnumber=1
totaldiscs=1
discname=
datadisc=0

In your track config, add the following near the top of the file:

Code: [Select]
SET realNumTracks=@numtracks@
IF [@datadisc@] EQU [1] SET /a realNumTracks=@numtracks@-1

Then change:

Code: [Select]
IF NOT @track@==@numtracks@ GOTO end_post_process

to:

Code: [Select]
IF [@track@] NEQ [%realNumTracks%] GOTO end_post_process

Then, when you encounter a disc with a data track, simply open up the Additional Meta Data dialogue (Alt+F5) and change "datadisc" to "1" (true).  Easy!
Title: REACT 2 Released
Post by: lipidicman on 2007-05-23 14:20:07
Thanks again to SS.  I Just wanted to chip in to hammer home the significance of the above.
This is the simplest fix I have seen for handling ENHANCED CDs.
(The problem usually encountered is that you are not ripping the final track, therefore React does not perform any post processing)

If anyone has an alternative solution to the Enhanced CD problem then let us know here.  Cheers
Title: REACT 2 Released
Post by: mc365mc on 2007-05-25 05:17:11
Edit

found my own answer.

I was adding: IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" .

to the track cfg file but I left out the period at the end.



Hi all,

My react2 setup is simple.  I've only activated stuff in the .INI havent changed anything in the cfg files.

I have 1 for save cue sheets and I get 4 cue sheets when I copy flac image and tracks {F10} but not when I compress just to flac tracks {F4}.

Is there something I need to do to get the noncompliant cuesheet for multiple files?
Title: REACT 2 Released
Post by: Stone Free on 2007-05-27 18:36:08
Trying to rip 100% Columbian by Fun Lovin' Criminals, to .flac results in zero files.  For some reason the final commandline appears as follows:

D:\CDs\Fun Lovin' Criminals\100 Colombian>C:\PROGRA~1\Audio\REACT2\tools\flac.exe -8 -f  -T artist="Fun Lovin' Criminals" -T album="100USERNAME\Documents and Settings\Peter\My Documents\My Music\Ftmp(842(.wav" -o "14 - Fisty Nuts.flac"

If I remove the % from the album title then everything goes fine
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-27 19:13:31
The addition of the extra % has caused DOS to get totally confused with variable names, essentially inverting variable name and static text.  I.e.:  It has treated everything following that %, until it meets another (which should actually be the start of a variable name, not the end), as a variable name.

Not sure of a workaround for this. 

Edit: I think % has to be replaced with %% to be taken as text, so I guess it may just be a case of ensuring that any % is replaced by %% in REACT (?).
Title: REACT 2 Released
Post by: lipidicman on 2007-05-29 10:41:27
I have noticed a problem with '&' as in Blur's Track 'Girls & Boys'
The REACT name becomes 'Girls .flac'

The TAGs are fine and the filename ends up truncated in my SED modified cuesheet too (so everything works).  However the perfectionist in me does not like the poorly named files.  Why is this happening?

note:  the EAC name and the unmodified cuesheet has the full name (and the original EAC wav extension)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-29 11:15:14
As per the % issue above, this will be because & is a special character in DOS, used to execute multiple commands.

I can only assume that this is down to the lines:

Code: [Select]
IF @various@==0 SET TrackName=@TrackName_SA@
IF @various@==1 SET TrackName=@TrackName_VA@

... which would produce (for my INI):

 
Code: [Select]
IF @various@==0 SET TrackName=01 - Boys & Girls
...

.. which is basically saying 'Set the variable TrackName to "01 - Boys" and then execute the command  "Girls"'.

I suspect you would see a line in the console saying:

Code: [Select]
'Girls' is not recognized as an internal or external command,
operable program or batch file.

Again, maybe REACT needs to replace "&" with "^&" before replacing the token (?).

Edit: to clarify, to work correctly the line should be:

Code: [Select]
IF @various@==0 SET TrackName=01 - Boys ^& Girls

(The caret escapes the ampersand)

Edit 2: Bah!

Actually, looking at the source and putting my thinking head on, I realise that this is not as easy as I imagined.  REACT will replace @TrackName_SA@ with the value set by TrackName_SA in the INI, and then REACT will replace the tokens used in that value - so it's not really possible to pin down that value.

Therefore, I would suggest doing this:

Code: [Select]
IF @various@==0 SET TrackName="@TrackName_SA@"
IF @various@==1 SET TrackName="@TrackName_VA@"
SET TrackName=%TrackName:&=^&%
SET TrackName=%TrackName:"=%

This surrounds the original value with quotes so the ampersand doesn't cause a problem.  It then replaces "&" with "^&" and finally removes the quotes.
Title: REACT 2 Released
Post by: morisimo on 2007-05-29 17:28:50
I do apologise if this has been covered before, but with so many posts and so many different issues it is easy to miss things. (Perhaps a dedicated RACT forum is required? )

So, on to my question...

Using the EAC + REACT combo, can I tag the following example of an album in the follwing way?

Album: Trance Nation (This is the actual name of the album)
Disc Number: 1 or 2 (It is a two disc album)
Album Artist: Ministy Of Sound
Mixed by: System F - Ferry Corsten
Track Artists: Insert track artist here

Here I am torn as to who the album artist actually is, because it could justifiably be either. (Not a big deal, preferably having album artist as Ministry Of Sound)

My requirement is two fold in that I want this to be under the folder structure:

Ministry Of Sound/Trance Nation/Disc x/tracknumber Trackname

I also want the tags to be handled correctly and include the "Mixed By" or eqivalent tag, if it exists.

Is this possible, and if it is, how do I configue REACT to implement this in both Id3v2 tags (for my mp3's) and APEv2 tags (for my wavpack's)?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-29 20:20:45
You can do as you wish, but you would probably need my mod, and a reasonable amount of config editing.

I have created a mod of REACT that allows you to easily insert and update tokens (e.g.: @discnumber@).

I have published amendments to the config to amend the path to utilise @discnumber@ or @discname@ tokens.  Unfortunately the wiki appears to be down at the moment so I can't provide a link.

My mod would allow you to easily set @discnumber@, @albumartist@ and @mixedby@ tokens (and @totaldiscs@ if you want).  However, the bit that takes the time is amending the config to utilise these tokens.  As I say, I've published code for adding the disc number to the path.  Setting a "Mixed By" tag shouldn't be too complicated.  I think you'd just need some code that checked whether a value was set for @albumartist@, and set the tag accordingly.

In essence, yes it is possible, with a little work.

NB: You could do it without my mod, by directly adding values to the REACT INI, but the idea with the mod is that you can easily adjust values using a GUI, from within EAC.  It depends how often you intend to use this approach.
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 08:34:46
Code: [Select]
IF @various@==0 SET TrackName="@TrackName_SA@"
IF @various@==1 SET TrackName="@TrackName_VA@"
SET TrackName=%TrackName:&=^&%
SET TrackName=%TrackName:"=%

This surrounds the original value with quotes so the ampersand doesn't cause a problem.  It then replaces "&" with "^&" and finally removes the quotes.


Superb!  Any reason that this should not be standard in React?  The problem isn't noted anywhere and must be fairly common (I have had to correct about 10% of my albums!)

NB: You could do it without my mod, by directly adding values to the REACT INI, but the idea with the mod is that you can easily adjust values using a GUI, from within EAC.  It depends how often you intend to use this approach.


A guide to this might be a good idea for those of us with less experience.  I think I have the basics but was wondering about some string manipulation.

In foobar I do stuff like "The Cure" to "Cure, The" for my album lists.  Now, could I take the EAC name "Ima (Disc1/2) and have REACT recognise the '(Disc1/2)' and strip it off the name and use it to fill in DISC and TOTALDISCS?  Just a thought for the moment.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-30 09:39:22
Superb!  Any reason that this should not be standard in React?  The problem isn't noted anywhere and must be fairly common (I have had to correct about 10% of my albums!)
The perfectionist in me finds the code a bit of a hack, but it works, and I can't think of a reason why it couldn't be included.  I have been wondering about tackling it in the REACT source though, so REACT would detirmine whether TrackName_SA or TrackName_VA was to be used, do a replace on all tokens within the value, and then, e.g., replace "&" with "^&".

I've already added code to my mod to deal with the "%" issue above.  I was hoping to have a think about the "&" issue and then release beta 10, which, incidentally, will also include the ability to prefix "temporary" (process-level) variables (like your @datadisc@) with an underscore (@_datadisc@), to stop them being added to the cuesheet.

 
A guide to this might be a good idea for those of us with less experience.  I think I have the basics but was wondering about some string manipulation.

In foobar I do stuff like "The Cure" to "Cure, The" for my album lists.  Now, could I take the EAC name "Ima (Disc1/2) and have REACT recognise the '(Disc1/2)' and strip it off the name and use it to fill in DISC and TOTALDISCS?  Just a thought for the moment.
I'm trying to get away from writing people's code for them though, unless I'm really bored!  I potentially have some evening work on the horizon, so will be just too damn busy.

DOS' string manipulation is pretty damn poor, so I think the basic answer is to gem up on SED and use that.  You could use SED to pick out the disc number and total discs from "Album Name (Disc 1/2)", and change "The Artist" to "Artist, The".  I'm no expert with SED.

Edit: Actually, what you want to do with the disc number is quite similar to my markup idea that I was pursuing before moving on to the GUI idea, e.g.: setting CD Title to "Album Name <discnumber>1</discnumber><totaldiscs>2</totaldiscs>" and then extracting the three parts.  I had the code to extract the parts, but my main issue was the mess it made of the filenames, etc.  I decided the GUI idea was probably equally, if not more, easy for the user to work with.  I suppose maybe you want the format "Album Name (Disc 1/2)" in some places, but the ability to use "Album Name" in others?  Or did you think it may be just quicker to use, and allow you to leave some freedb entries as they are?
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 10:23:23
I suppose maybe you want the format "Album Name (Disc 1/2)" in some places, but the ability to use "Album Name" in others?  Or did you think it may be just quicker to use, and allow you to leave some freedb entries as they are?


A mix of the two.  I leave the cds in separate folders but want them together in foobar so the folder is "Album Name (Disc 1/2)" whilst the tags should be "Album Name".  I do remember your suggestion before you started on the GUI.  In any case the GUI is more flexible.

I understand why you might not want to write others code.  I have always been amazed at how much help you offer.  The bit we really need documented is how users can add tokens to the ini and use them.  I certainly did not appreciate that this possibility existed.

e.g. When does the ini get parsed?  Before every rip or on load.  If I change the cfg do I need to reload React?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-30 10:42:14
A mix of the two.  I leave the cds in separate folders but want them together in foobar so the folder is "Album Name (Disc 1/2)" whilst the tags should be "Album Name".  I do remember your suggestion before you started on the GUI.  In any case the GUI is more flexible.
If I understand correctly you should really do this in foobar with titleformatting - in simple (not correct!) terms:

Code: [Select]
%album% (Disc %discnumber%/%totaldiscs%)

I use:

Code: [Select]
[%album%]
[ ' ('%album subtitle%')']
[' ('%discname%')']
$if($greater(%totaldiscs%,1),[' ('Disc %discnumber%')'])


The bit we really need  documented is how users can add tokens to the ini and use them. I  certainly did not appreciate that this possibility existed.

e.g. When does the ini get parsed?  Before every rip or on load.  If I change the cfg do I need to reload React?
The [UserTrackFormats], [UserOutputNames] and [UserSettings] sections are all read every time REACT runs.  You can add your own variables to these sections as REACT just grabs everything in the section, not each variable by name.

This means that you could actually add discnumber=1 in the [UserSettings] section, without my modded REACT, and you could still use @discnumber@ (not $discnumber$) in your config.  My mod mainly has the benefit of easy access to your tokens through a GUI, rather than having to edit the INI by hand for each disc - but you coud do it this way.
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 11:02:49
If I understand correctly you should really do this in foobar with titleformatting - in simple (not correct!) terms:

Code: [Select]
%album% (Disc %discnumber%/%totaldiscs%)


Do what?  Do you mean grab the tags from the filename or modify them using a script from the tags that react has made?  I can manually change the tags in 'properties' but I do not seem to have masstagger (why would this be?)  I use titleformat for my album tree and file info and in columns UI so I am a little familiar with it

The [UserTrackFormats], [UserOutputNames] and [UserSettings] sections are all read every time REACT runs.


I am still not clear.  When the exe is run, or when you press F4 to rip?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-30 11:05:53
Do what? Do you mean grab the tags from the filename or modify them using a script from the tags that react has made? I can manually change the tags in 'properties' but I do not seem to have masstagger (why would this be?) I use titleformat for my album tree and file info and in columns UI so I am a little familiar with it
Sorry, I should have been more specific.  I am suggesting that you use code like that in your display script - in your case your "Album" column in ColumnsUI.

In essence, you keep %album%, %discnumber% and %totaldiscs% totally separate tag-wise, but use them all to create the value displayed by foobar for the "Album" column.

The [UserTrackFormats], [UserOutputNames] and [UserSettings] sections are all read every time REACT runs.
I am still not clear.  When the exe is run, or when you press F4 to rip?
When you press F4/F10.

When you press F4/F10 another instance of REACT is run, but it acts differently (processes your config) because of the parameters passed to it by EAC.  Therefore when you are ripping there are two instances of REACT running - one interacting with EAC, and one that processes your config and sets the batch file running.  This second instance will re-read the INI sections I quoted.  It will not re-read all the INI though.
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 11:18:53
In essence, you keep %album%, %discnumber% and %totaldiscs% totally separate tag-wise, but use them all to create the value displayed by foobar for the "Album" column.


I get you but I need to be clearer

I want to have

BT/Ima (Disc1)/01 Track1.flac

But then tagged like this
Album: Ima
Discnumber: 1
Totaldiscs: 2

And I do do what you suggested with foobar to build the album name make the display look nice.  I get all the tracks from all the discs when I add the album from the list.

I can do the tags with your mod easy enough.  I haven't tried but I think I can add the "(disc1/2)" to the end of the directory name.  Some people might add the discnumber to the filename and have both discs in one directory.  I wanted to keep it the same as for the others so you can burn the cd like any other by clicking on the cuesheet (modded by SED) without confusion.

My present solution is to go into properties in foobar for the albums that need it delete "(disc1)" from the albumtitle and fill in the discnumber fields.  I have not implemented your mod on my main ripping machine as I was in the middle of a ripping marathon and changing things was stressing me out!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-30 11:26:21
I'm not sure what your problem is, but if it's creating a folder using the disc number I have tackled that in a wiki article.

The config amends suggested allow you to change:

Artist Name\Album Name\01 - Title

... to:

Artist Name\Album Name\Disc 1\01 - Title

or

Artist Name\Album Name\Disc Name\01 - Title

... depending whether @discname@ is populated or @totaldiscs@ is greater than one.


Edit: In case your are confused, to achieve:

Artist Name\Album Name (Disc1)\01 - Title

... simply change

Code: [Select]
SET trackDir=%trackDir%\Disc @discnumber@

... to:
Code: [Select]
SET trackDir=%trackDir% (Disc@discnumber@)
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 11:32:30
When you press F4/F10.

When you press F4/F10 another instance of REACT is run, but it acts differently (processes your config) because of the parameters passed to it by EAC.  Therefore when you are ripping there are two instances of REACT running - one interacting with EAC, and one that processes your config and sets the batch file running.  This second instance will re-read the INI sections I quoted.  It will not re-read all the INI though.


OK, interesting.  I love React, but isn't its detailed working baffling sometimes?  Until you explain it that is!

Anyway it isn't design for everyone.  I was at a friend-of-a-friends flat at the weekend who downloads in mp3 (quite good ones mind, not a complete muppet) and I was going to tell him about the library I was building of my collection using React.  When he mentioned that he was burning mp3 onto CD and printing out labels for them I took a deep breath and kept my mouth shut.

I'm not sure what your problem is

I'm not sure anyone is! 

I haven't read the wiki as I think it is down.  I'm sure I could mod what you have done to avoid the extra directory level in your examples above (edit:  I see you have helpfully added that!).  I need to have a good look through the wiki as last time I saw it was when you created it after the SED discussions we had

Above I thought your code was to take the 'album' tag (ie "Ima (Disc1)") and separate the tags out in foobar using a script rather than my manual method.  Rather it was just a display format.  Sorry for the confusion!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-30 11:36:25
I couldn't access the wiki (http://wiki.hydrogenaudio.org/index.php?title=REACT:Adding_Support_For_Disc_Information) earlier but I can now.

See my edit two posts above for the simple change that you require.

Also note that the code in the article deals with setting the tags as well.
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 11:43:19
Superb.  Sorry to have made a simple discussion so complicated this morning! 
Title: REACT 2 Released
Post by: morisimo on 2007-05-30 11:48:49
You can do as you wish, but you would probably need my mod, and a reasonable amount of config editing.

I have created a mod of REACT that allows you to easily insert and update tokens (e.g.: @discnumber@).

I have published amendments to the config to amend the path to utilise @discnumber@ or @discname@ tokens.  Unfortunately the wiki appears to be down at the moment so I can't provide a link.

I found the wiki (http://wiki.hydrogenaudio.org/index.php?title=REACT:Adding_Support_For_Disc_Information), thanks.

My mod would allow you to easily set @discnumber@, @albumartist@ and @mixedby@ tokens (and @totaldiscs@ if you want).  However, the bit that takes the time is amending the config to utilise these tokens.  As I say, I've published code for adding the disc number to the path.  Setting a "Mixed By" tag shouldn't be too complicated.  I think you'd just need some code that checked whether a value was set for @albumartist@, and set the tag accordingly.

In essence, yes it is possible, with a little work.

NB: You could do it without my mod, by directly adding values to the REACT INI, but the idea with the mod is that you can easily adjust values using a GUI, from within EAC.  It depends how often you intend to use this approach.

Are you planning to add this kind of functionality to coming releases of REACT? I am not good at coding and it takes me alot of trial and error to even get simple things working! I would be extremely interested in these kind of freatures being built in as I am quite particular that my music is tagged correctly (I suspect I am not alone here ).

I will have a proper read of the wiki and have a go at implementing the changes you were talking about and will let you know how I get on.

Thanks for the help and great work on REACT!
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 11:59:11
I would be extremely interested in these kind of freatures being built in as I am quite particular that my music is tagged correctly (I suspect I am not alone here ).


There you go Neil, the interest is building!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-30 12:01:21
Are you planning to add this kind of functionality to coming releases of REACT?
Pleas note that Tycho is the author of REACT.  I have created a mod which enables you to set additional meta data easily, but the core functionality is his.

There is no need to update REACT for your requiements.  With my mod and some config editing you can do it.  Editing the config is the way in which users are supposed to tweak REACT to do exactly what they want.

Good luck.


There you go Neil, the interest is building!
"Build it, and they will come"
Title: REACT 2 Released
Post by: lipidicman on 2007-05-30 12:06:49
There is no need to update REACT for your requiements.  With my mod and some config editing you can do it.  Editing the config is the way in which users are supposed to tweak REACT to do exactly what they want.


This is true.  Everyone wants to do something different with their configs and this is the beauty of the flexibility of REACT.  However I think the extended tagging mod opens up what people could do with their configs a lot and there is an argument for having it there when you install React.  I think of it as making up for the limitations of EAC rather than changing React (like you say you can do it through the ini).  I thought Tycho was onboard?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-05-30 16:27:04
I have just uploaded version 2.0.ssb10 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb10.zip) of my mod.Remember to set Version=2.0.ssb10 in your INI.

* You could actually just remove those lines altogether, and replace any occurence of %TrackName% with @trackname@ in your config - but the suggestion above means less editing, and therefore less chance of error.
Title: REACT 2 Released
Post by: lipidicman on 2007-06-01 12:53:17
I really need to try this.  However if the weather is good this weekend I might get 'reassigned'

In advance I have a couple of questions:
Does the 'trackname' replacement in the post above still handle various artist albums OK? 
[/list]Remember to set Version=2.0.ssb10 in your INI.

Please, remind me, what does this achieve?

The wiki is up for me (I couldn't access it earlier in the week), and I just wanted to thank you for all of the great work.  I am going to tweak and consider adding some of the things I have been working on.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-01 13:38:22
Does the 'trackname' replacement in the post above still handle various artist albums OK?
Yes.

Please, remind me, what does this achieve?
The default behaviour of REACT is to rewrite the INI if the version number in the INI does not match that of the EXE.  If you don't want to lose all those nice changes you've made in your INI you should either back it up before running a new EXE or, if it is a beta update, just change the version in the INI to that of the EXE.

REACT obviously does this to ensure that the INI is in keeping with the EXE, but maybe it should only do it on major (2.0.ssb10) or minor changes (2.0.ssb10), and not build (2.0.ssb10).
Title: REACT 2 Released
Post by: lipidicman on 2007-06-01 14:44:27
Code: [Select]
IF @various@==0 SET TrackName=@TrackName_SA@
IF @various@==1 SET TrackName=@TrackName_VA@
with:
Code: [Select]
SET TrackName=@trackname@

I am still confused about this, and the changes are different to what we had in post 386/7.  If you drop the 'if' statements then how does this handle a different various artists naming scheme?
Sorry if I am being dumb (and remember I am away from my React setup at the mo)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-01 14:53:31
The decision making is done within REACT.

Previous SetupMy Setup
Title: REACT 2 Released
Post by: lipidicman on 2007-06-01 15:21:02
I think I get it.  I thought you were handling the & problem through the config (you were in post 386/7 right?).  It would seem however that you have rewritten React to correct the problem.  Right? (edit found it in post 391, sorry I should be paying attention)  I do like to understand what is going on.
Cheers again.  Have a great weekend
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-01 15:28:59
I think I get it.  I thought you were handling the & problem through the config (you were in post 386/7 right?).  It would seem however that you have rewritten React to correct the problem.  Right?
Cheers again.  Have a great weekend
Correct on all parts.

You can still use the hack in the posts you quote, or (with beta 10 or above) change the lines to use @tracknumber@.  I just thought it would be neater, and possibly more robust, if REACT handled it.

Enjoy your weekend.
Title: REACT 2 Released
Post by: lipidicman on 2007-06-01 15:34:08
You can still use the hack in the posts you quote, or (with beta 10 or above) change the lines to use @tracknumber@.  I just thought it would be neater, and possibly more robust, if REACT handled it.


I agree.  I forgot you had suggested you could code it into React.

So I am convinced I need to run this mod (as part of my main ripping routine) but where do you stand if tycho releases 2.1?  You are the official support so do you think it likely that these changes would make it into this theoretical 2.1?  Or, is 2.1 unlikely?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-01 15:47:43
but where do you stand if tycho releases 2.1?  You are the official support so do you think it likely that these changes would make it into this theoretical 2.1?  Or, is 2.1 unlikely?
I have no idea whether Tycho will implement any of my changes with his upcoming release of REACT, we don't speak privately or anything.

Given that it seems only you and I are using my mod at the moment (I should really check the download stats for the zips I post) I am reticent to suggest that Tycho implements the Additional Meta Data dialogue in the core; but of course it is up to him.  I suppose there is no real downside, apart from the fact that the newer AutoIt bin used to compile my EXE appears to almost double the file size.  At 217KB that's hardly a real concern though.

I suppose it would be sensible for him to implement the "%" and "&" fixes, or something similar at least.  I can't remember if I've made any other "improvements"!  I really should have kept a change log - I guess if I trawled this thread I may be able to collate one.

If Tycho does not include the Additional Meta Data dialogue, and with his agreement, I will attempt to mod his new release.  It shouldn't be difficult, as most of the code is separated from his source.  Of course I will continue to support my mod as long as I can.
Title: REACT 2 Released
Post by: lipidicman on 2007-06-01 16:03:15
Well, that's good enough for me then.  I have learnt to expect your high level of dedication here, but I don't like to assume
Title: REACT 2 Released
Post by: hitchin on 2007-06-04 03:52:08
I am trying to use REACT to rip to mp3's and flac images. When I press F10 it gives me mp3's, a flac image and flac tracks. Anybody know what I need to do to remedy this so I get only the mp3's and a flac image? What am I doing wrong or what should my settings look like in my INI file? I thought that by pressing F10 the end result would be a flac image and mp3's...

Thanks for your help and I am very impressed by the level of help and knowledge on these forums.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-04 07:01:58
In your REACT.ini you will see the section UserTrackFormats.  This section detirmines what track formats are created.  Ensure you have set Flac=0, not Flac=1.

The image format is determined by the value of ImageExt under Settings.
Title: REACT 2 Released
Post by: hitchin on 2007-06-04 17:11:26
In your REACT.ini you will see the section UserTrackFormats.  This section detirmines what track formats are created.  Ensure you have set Flac=0, not Flac=1.

The image format is determined by the value of ImageExt under Settings.


That was exactly it. It makes sense now. I am still trying to get my head around some of the stuff in the INI file. One other question. I have CreateAllCuesheets=1. After making the change you suggested I am given a flac image of the cd I ripped w/ only 1 cuesheet. Other posts I have read have said something about 4 different cuesheets being created. Is there only 1 style of cuesheet created when ripping to an image?

Thanks for your help and I am astounded by your knowledge on this subject.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-04 18:58:32
CreateAllCuesheets is really for track processing, not image processing.

If you have it checked you will (should) be creating the four (additional) cuesheets, but unless you make amends to your config, to do something with them, they will be deleted at the end of the processing run.

They really are no use to you if you are creating an image; you only need the cuesheet you have.

If you want more information on the INI settings it may be worth checking the REACT wiki article (http://wiki.hydrogenaudio.org/index.php?title=REACT).

Edit: Actually, the wiki has just reminded me of a nuance with CreateAllCuesheets: it will only work if you have specified a "static" extraction directory, i.e.: have "Use this directory" checked on the "Directories" tab of the "EAC options".  If you have "Ask every time" checked it won't work IIRC.
Title: REACT 2 Released
Post by: hitchin on 2007-06-04 22:44:26
CreateAllCuesheets is really for track processing, not image processing.

If you have it checked you will (should) be creating the four (additional) cuesheets, but unless you make amends to your config, to do something with them, they will be deleted at the end of the processing run.

They really are no use to you if you are creating an image; you only need the cuesheet you have.

If you want more information on the INI settings it may be worth checking the REACT wiki article (http://wiki.hydrogenaudio.org/index.php?title=REACT).

Edit: Actually, the wiki has just reminded me of a nuance with CreateAllCuesheets: it will only work if you have specified a "static" extraction directory, i.e.: have "Use this directory" checked on the "Directories" tab of the "EAC options".  If you have "Ask every time" checked it won't work IIRC.


As I thought about the CreateAllCuesheets question I posted earlier I figured that the answer would end up being as you wrote.

I have gotten to know the INI file well in the short time I have been using REACT. Thanks again for all your help and sharing your knowledge. A subject such as this (i.e., music, ripping, etc.) can, to say the least, lead to people being very opinionated and passionate and to see people like yourself and the others who are patient and happy to help is very refreshing!
Title: REACT 2 Released
Post by: ngc1967 on 2007-06-05 04:42:44
I've just started playing with React 2 and I am now really confused.

It changes the settings of the Filename in the EAC Options and gets rid of all references to '\' and replaces them with '-'. This stops me creating the sub-directories under the headings 'CD Artist\CD Title' etc.

For example in EAC I use "%D\%C\%N - %T - %A" and "Various Artists\%C\%N - %T - %A". It changes them to "%D - %C - %N - %T" and "%D - %C - %N - %T (%A)" and then saves the files in the main folder as specified in the 'Directories' option without letting me create the sub-directories.

Can I get round this way of naming the converted music files so that it is the same as EAC used to be?


Also I've had a play with the Cover Art Downloader but it also puts the .jpg in the main folder (with the correct Album title though). Can I change the settings to put the jpg into the associated album sub-directories. I've tried adding all different combinations of '%' '$' and '&' followed by 'Artist' and 'Album' in the 'save as' box but to no avail. Can anyone help me on this
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-05 07:53:25
It changes the settings of the Filename in the EAC Options and gets rid of all references to '\' and replaces them with '-'. This stops me creating the sub-directories under the headings 'CD Artist\CD Title' etc.

For example in EAC I use "%D\%C\%N - %T - %A" and "Various Artists\%C\%N - %T - %A". It changes them to "%D - %C - %N - %T" and "%D - %C - %N - %T (%A)" and then saves the files in the main folder as specified in the 'Directories' option without letting me create the sub-directories.

Can I get round this way of naming the converted music files so that it is the same as EAC used to be?
REACT does this so that it can use the filename to detirmine whether the album is Various Artist or not.  When using REACT, these values are irrelevant to how the tracks will finally be named.  To specify the file naming scheme for your images and/or tracks you need to look at the REACT.ini file, and amend the values in the "UserOutputNames" section.

As an example, using your preferred scheme, you may use the following:

Code: [Select]
[UserOutputNames]
OutRoot=C:\Path\To\My\Music
...
TrackDir_MP3=@OutRoot@\$cdartist$\$album$
...
TrackName_SA=$tracknumber$ - $title$ - $artist$
TrackName_VA=$tracknumber$ - $title$ - $artist$
TrackName_SA_acdir=$n - $~t - $~a
TrackName_VA_acdir=$n - $~t - $~a

This:Have a look at the default values to try to get an understanding of what is being done.  Note that the "TrackName_*A_acdir" variables are for use with ACDIR in the REACT-image.cfg, and match the "TrackName_*A" variables in format, but use ACDIR's own syntax.

Also I've had a play with the Cover Art Downloader but it also puts the .jpg in the main folder (with the correct Album title though). Can I change the settings to put the jpg into the associated album sub-directories. I've tried adding all different combinations of '%' '$' and '&' followed by 'Artist' and 'Album' in the 'save as' box but to no avail. Can anyone help me on this
I'm not overly familiar with this, as I don't use it; however, if it's no working as it should, it may be that you need to edit your CFG to deal with the file as you wish.  You shouldn't really need touch the GUI's Save As dialogue text - let REACT deal with it.

Edit: Just spotted, and deleted, your thread on this issue.  Easiest to keep discusion here, and no cross-posting please.
Title: REACT 2 Released
Post by: ngc1967 on 2007-06-06 09:04:36
Thanks for your help 'Synthetic Soul'.

Just one quick question, can you configure the 'ImageExt' command line to allow both 'flac' and 'wv' images and cue sheets to be created.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-06 09:10:19
No.

However, you could amend the REACT-image.cfg to process both the FLAC and WavPack sections, and use something like SED (http://gnuwin32.sourceforge.net/packages/sed.htm) to make a copy of the cuesheet, replacing ".flac" with ".wv".

It's all possible...

Do you really need two lossless versions?
Title: REACT 2 Released
Post by: ngc1967 on 2007-06-06 09:38:46
No.

However, you could amend the REACT-image.cfg to process both the FLAC and WavPack sections, and use something like SED (http://gnuwin32.sourceforge.net/packages/sed.htm) to make a copy of the cuesheet, replacing ".flac" with ".wv".

It's all possible...

Do you really need two lossless versions?


Probably not.

At the moment I am archiving all my CDs in Wavpack and after playing with React I've decided to archive the CDs as whole files instead of separate tracks. I chose wavepack over FLAC for some reason I cannot exactly remember now and as I am relatively new to ripping, archiving and Lossless formats, etc. I'm not too sure which format is the best with respect to compression ratio, speed and product support.

If I want to convert to flac at a later date I know I can do it in Foobar. Its just that I would have prefered to do everything all at once now instead of revisiting later.

Anyway thanks for your help previously. I've just spent half the night playing with the config file to get it doing pretty much what I want.
Title: REACT 2 Released
Post by: ESP85 on 2007-06-10 16:51:40
My config is

ReplayGain=1
ApplyAlbumGain=0
AdjustAlbumGain_dB=0
AddCuesheetAG=0
UseWaveGainAG=0



I was wondering, is the ReplayGain calculated off of 89db (just for the tags)?



Also is there anyway to get metamp3.exe to work by itself?  I was trying to use it to write ReplayGain tags to files that didn't have them.  I tried using Foobar but foobar doesn't write tags that Winamp can read.

I tried using the windows console to go to the directory (album) that needed tags and tried to run metamp3 out of that just like REACT2 does (by running "C:\PROGRA~1\REACT2\tools\metamp3.exe --replay-gain *.mp3" out of the dir that needs tags) but it didn't quite work.  It wrote the replaygain tags but messed up the rest of the ID3v1 and ID3v2 tags.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-10 19:40:40
I was wondering, is the ReplayGain calculated off of 89db (just for the tags)?
From the REACT wiki page (http://wiki.hydrogenaudio.org/index.php?title=REACT#UserSettings_Section):
Quote
AdjustAlbumGain_dB
If you want to adjust the album gain from 89.0 dB when applying to the audio, set adjustment in dB here.
I believe the default is:

Code: [Select]
AdjustAlbumGain_dB=+3.0

... or, an album gain of 92dB.

Also is there anyway to get metamp3.exe to work by itself? I was trying to use it to write ReplayGain tags to files that didn't have them. I tried using Foobar but foobar doesn't write tags that Winamp can read.

I tried using the windows console to go to the directory (album) that needed tags and tried to run metamp3 out of that just like REACT2 does (by running "C:\PROGRA~1\REACT2\tools\metamp3.exe --replay-gain *.mp3" out of the dir that needs tags) but it didn't quite work. It wrote the replaygain tags but messed up the rest of the ID3v1 and ID3v2 tags.
It will work absolutely fine from the command line.  It may be worth taking a look at the metamp3 thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=49751) to see if you have encountered a known bug.
Title: REACT 2 Released
Post by: ZeroPlay on 2007-06-16 11:56:42
FLAC and MP3 images simultaneously?

I want to archive my CD collection as FLAC images and then keep MP3 individual tracks for use on my portable DAP.  However, if the album requires gapless playback, I'd like to have an MP3 image instead of individual tracks, since my DAP doesn't support gapless playback.

How can I create FLAC and MP3 images with REACT (as opposed to a FLAC image and individual MP3 tracks)?

Thanks for any help.
Title: REACT 2 Released
Post by: Scout on 2007-06-17 16:18:35
schnittlich: I can't see why this version should be different than v1.0 in this respect. It should still support multiple instances (although I haven't tested myself). Please retest and report.

.....

Has anyone succeeded in running multiple instances of React v2?  No matter how hard I try to hide the first instance from the second (run second instance from second install directory as a different user without permission to access most of the files of the first...) the two instances always manage to load the same .ini file and then one of them won't execute the compression script properly.

It would be nice to use both cd drives at once. (Double productivity!)

-david


EDIT:  Nevermind.  Did something in a different order and it now seems to work.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-17 21:41:21
FLAC and MP3 images simultaneously?
If you intend to produce FLAC images with MP3 tracks most of the time, but FLAC images with an MP3 image on ocassion, I think my mod may be of help.

Either way, I would suggest that you set a variable in your INI - either using my mod, or by editing the INI by hand, and adding:

MP3Image=1

... to the "UserSettings" section.

You could then, by amending the LameMP3 variable under "UserTrackFormats" and the MP3Image variable, switch between producing MP3 tracks and an image.  With a little config editing obviously.

What's your plan with the cuesheet?  Would you hope to amend the file reference?  Are you embedding it?  As well as keeping it or solely?  You may need to use SED to create a copy of the FLAC cuesheet and point it to the MP3.

All very do-able though.
Title: REACT 2 Released
Post by: SteveD30 on 2007-06-24 00:48:38
Hi,

I'm having a small file naming problem with REACT. I have a cd of various artists, which I'm ripping. My problem is that some of the file names of the tracks that I have ripped are incomplete. In the tracks themselves, the ones that are incomplete have two artists or more on them, and I've chosen to name these track First artist name & second artist name - Track number - track title. But for some reason, the file output is just First artist name, with no & second artist name - Track number - track title present.

Any help would be appreciated. 

Thanks
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-06-24 06:38:37
Let me guess, you are ripping to tracks, not images?

Take a look at post 387 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=50273&view=findpost&p=495130) for one resolve (config edit), and post 405 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=50273&view=findpost&p=495493) for another (my mod).
Title: REACT 2 Released
Post by: SteveD30 on 2007-06-24 18:07:24
Let me guess, you are ripping to tracks, not images?

Take a look at post 387 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=50273&view=findpost&p=495130) for one resolve (config edit), and post 405 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=50273&view=findpost&p=495493) for another (my mod).


Yes, thank you very much!
Title: REACT 2 Released
Post by: dummptyhummpty on 2007-06-29 07:44:35
So I had React2+EAC working fine on my XP Machine. I bought a new Acer recently (with Vista) and I copied my EAC profile and my REACT2 directory over. I made sure React was setup. Everything works fine except my .flac and .cue files are ending up as .wav.flac and .wav.cue which didn't happen before. What did I miss? Thanks!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-01 07:53:00
Just a note to REACT users that they should not upgrade to EAC 0.99 prebeta 1 (http://www.hydrogenaudio.org/forums/index.php?showtopic=55852) and still expect REACT to work as it should.

I have yet to perform any tests myself, but I have already noted one change that will confuse REACT: one user has reported that the log file is now named "<artist> - <album>.log", rather than just "<album>.log".  This will, of course, mean that REACT can no longer find the log file.

It's very possible that there are other changes that will confuse REACT.

All testing welcomed, so that we can report such changes to Tycho.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-01 08:04:49
So I had React2+EAC working fine on my XP Machine. I bought a new Acer recently (with Vista) and I copied my EAC profile and my REACT2 directory over. I made sure React was setup. Everything works fine except my .flac and .cue files are ending up as .wav.flac and .wav.cue which didn't happen before. What did I miss? Thanks!
Open "EAC Options" > "Directories" and make sure that "Use this directory" is checked.

IIRC, if it is not, REACT will not automagically amend the image filename and submit the Save As dialogue.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-01 12:55:41
Just a note to REACT users that they should not upgrade to EAC 0.99 prebeta 1 (http://www.hydrogenaudio.org/forums/index.php?showtopic=55852) and still expect REACT to work as it should.
 
the log file is now named "<artist> - <album>.log", rather  than just "<album>.log". This will, of course, mean that REACT  can no longer find the log file.
NB: I amend the REACT source to look for "<artist> - <album>.log" and my image config worked fine, so maybe that's it; however more testing is obviously required...
Title: REACT 2 Released
Post by: Cynic on 2007-07-01 14:15:04
Just a note to REACT users that they should not upgrade to EAC 0.99 prebeta 1 (http://www.hydrogenaudio.org/forums/index.php?showtopic=55852) and still expect REACT to work as it should.
 
the log file is now named "<artist> - <album>.log", rather  than just "<album>.log". This will, of course, mean that REACT  can no longer find the log file.
NB: I amend the REACT source to look for "<artist> - <album>.log" and my image config worked fine, so maybe that's it; however more testing is obviously required...
A workaround for people like me who don't know how to do that is adding the "Pausing For The Logfile" code to the REACT-image.cfg file as described in http://wiki.hydrogenaudio.org/index.php?ti...For_The_Logfile (http://wiki.hydrogenaudio.org/index.php?title=REACT%3a%50ausing_For_The_Logfile) and create the log manually with EAC after the extraction is finished. Not elegant but it works.
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-01 17:28:38
For a FLAC image within the REACT-image Config file, I was able to make REACT2 work with EAC v0.99pb1 by changing the eaclog tag section to read --tag-from-file="eaclog=@basename@.log" instead of the default --tag-from-file="eaclog=@eaclog@"
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-01 18:44:26
For a FLAC image within the REACT-image Config file, I was able to make REACT2 work with EAC v0.99pb1 by changing the eaclog tag section to read --tag-from-file="eaclog=@basename@.log" instead of the default --tag-from-file="eaclog=@eaclog@"
If you name your images "<artist> - <album>", as I'm sure many of us do, this is a nice workaround.

I'm happy to upload an amended EXE, that would work with both this and earlier version of EAC, but I don't want to step on Tycho's toes.  I also don't really want to just upload my mod with the new functionality, as I'd feel like I was forcing people to use my mod. Dilemma!
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-01 21:46:46
For a FLAC image within the REACT-image Config file, I was able to make REACT2 work with EAC v0.99pb1 by changing the eaclog tag section to read --tag-from-file="eaclog=@basename@.log" instead of the default --tag-from-file="eaclog=@eaclog@"
If you name your images "<artist> - <album>", as I'm sure many of us do, this is a nice workaround.

I'm happy to upload an amended EXE, that would work with both this and earlier version of EAC, but I don't want to step on Tycho's toes.  I also don't really want to just upload my mod with the new functionality, as I'd feel like I was forcing people to use my mod. Dilemma!

Actually, I use "[Year] Album" for my name scheme. When using REACT with the new EAC version, my log file renames to whatever I enter as "ImageNaming" in the REACT.ini file.

Hopefully, as before, Tycho will be OK with the mod. Seems to me it's always best to use a program as intended. If you build it, they will download it! ;-) Thanks Neil

EDIT: Spelling
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-01 21:49:13
Hmm.  After a little more testing it seems the log file isn't flatly named "<artist> - <album>.log", it simply follows the same format as the image and cuesheet.

Therefore, if you use:

Code: [Select]
ImageNaming=$artist$ - [$year$] $album$

.. the log file will follow the same format.

With that in mind using @basename@ is the best solution by far.

Edit:  LMAO!  Three minutes too late!
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-01 21:56:53
Hmm.  After a little more testing it seems the log file isn't flatly named "<artist> - <album>.log", it simply follows the same format as the image and cuesheet.

Therefore, if you use:

Code: [Select]
ImageNaming=$artist$ - [$year$] $album$

.. the log file will follow the same format.

With that in mind using @basename@ is the best solution by far.

Edit:  LMAO!  Three minutes too late!

Hi Neil,

You are still our best resource when trouble arises; 3 minutes late or not. ;-) Thanks again for spending the time to find a solution.
Title: REACT 2 Released
Post by: dobo on 2007-07-01 22:11:30
I've configured eac and accurate rip and it works great, i got confidence 200 on alanis morisette CD.
I then went and installed and configured react which also works great however the accurate rip box doesnt popup with the confidence info after the rip, is this normal? how do i change that?
Sorry if this has already been asked, its a big thread..
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-01 22:45:41
You are still our best resource when trouble arises; 3 minutes late or not. ;-) Thanks again for spending the time to find a solution.
Thanks for the kind words Dirk. 

Well, rightly or wrongly, I've uploaded 2.0.ssb12 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb12.zip) for people to test.  It's a bit late, so I haven't had much chance to test, but it all seems fine.  I need to check it with an older version of EAC, to ensure that it still works with the old-style log file naming as well.  It should do.

Changes for 2.0.ssb12:Edit: Uploaded b12 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb12.zip).  I shouldn't have been so swift to get b11 up.  I realised this morning that using basename would no work for track rips, which use the format "<artist> - <album.log".  b12 will now first check whether we are ripping to image or tracks, and set the log file name accordingly.  It will therefore check for "<basename>.log" and "<album>.log" for image rips, and "<artist> - <album>.log" and "<album>.log" for track rips.
Title: REACT 2 Released
Post by: z7x8c9 on 2007-07-02 00:11:17
I don't know if this is the right place to ask this, if not, I'm sorry.

I'm trying to setup eac to use react to rip an image to flac and split the tracks to mp3.
The problem only happens when I try to rip a CD with various artists. The image and the mp3's are created ok, but the filenames for the mp3's are having a strange behavior, i.e. only the track numbers appear, no names...

Can anyone help me?

Thanks
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-02 07:59:20
I don't know if this is the right place to ask this, if not, I'm sorry.

I'm trying to setup eac to use react to rip an image to flac and split the tracks to mp3.
The problem only happens when I try to rip a CD with various artists. The image and the mp3's are created ok, but the filenames for the mp3's are having a strange behavior, i.e. only the track numbers appear, no names...
It's definately the right place to ask.

A description of how the tracks listing looks in the EAC main dialogue (post a screenshot if it's easier - use a service like www.imageshack.us), and a copy of your react.INI may help.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-03 10:20:46
Well, rightly or wrongly, I've uploaded 2.0.ssb12 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb12.zip) for people to test.  It's a bit late, so I haven't had much chance to test, but it all seems fine.  I need to check it with an older version of EAC, to ensure that it still works with the old-style log file naming as well.  It should do.
In case anyone is concerned: I have now tested with image and track rips using EAC 0.95 beta 4 and 0.99 prebeta 1, and 2.0.ssb12 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb12.zip) will correctly identify the log file in all situations.

I'm now using EAC 0.99 prebeta 1 with 2.0.ssb12 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb12.zip).
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-03 15:39:14
Hi Neil,

Though sb12 works fine now with the logfile, I now seem to have a problem with the naming of albumart. REACT is passing the artist & album info to albumart.exe, and the jpg file is named "%album%.jpg".
The REACT batch file though, is now looking for the ImageNaming name for the jpg file, which in my case is "[Year] Album". Hence, I always have a failure embedding album art into my FLAC image.

Your sb10 file works correctly, but sb11 & sb12 do not. Did your logfile change also change the naming of the albumart @cover@ file name, as well?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-03 15:59:34
Yes, it did.

The image naming will follow that of the 0.99 prebeta 1 log file, i.e.: "<basename>.jpg" for images or "<artist> - <album>.jpg" for tracks.

I assumed that this made the most sense, but as someone who does not use album art I am not the best person to make that decision!

If you can explain how you think it should work I am more than happy to make the amend.

Is it best if it just stays as "<album>.jpg"?
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-03 16:07:59
Yes, it did.

The image naming will follow that of the 0.99 prebeta 1 log file, i.e.: "<basename>.jpg" for images or "<artist> - <album>.jpg" for tracks.

I assumed that this made the most sense, but as someone who does not use album art I am not the best person to make that decision!

If you can explain how you think it should work I am more than happy to make the amend.

Is it best if it just stays as "<album>.jpg"?

I don't have a problem per se with using ImageNaming for the jpg file. My problem is how do I get the jpg file name to match the @cover@ naming scheme? Does REACT pass the file naming scheme to albumart.exe? If so, then it would need to pass ImageNaming as the file name and not <album>.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-03 16:22:16
I see.  REACT calls albumart.exe from within the REACT script, not as part of the config.  OK.

It only has the main EAC GUI data (CD Artist, CD Album, year, etc.) at it's disposal at this time, so I think it will be safest (or perhaps the only option) to revert it to "<album>.jpg".

I will upload beta 13 ASAP.  Thanks for the heads up.
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-03 16:31:13
I see.  REACT calls albumart.exe from within the REACT script, not as part of the config.  OK.

It only has the main EAC GUI data (CD Artist, CD Album, year, etc.) at it's disposal at this time, so I think it will be safest (or perhaps the only option) to revert it to "<album>.jpg".

I will upload beta 13 ASAP.  Thanks for the heads up.

Hi Neil,

I kind of figured that I would not have any control over the file naming. Though, I think we did in the original REACT release (pre-REACT2).

Thanks again for your help, and for beta 13. You are the man! 


Dirk
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-03 16:33:56
OK, 2.0.ssb13 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb13.zip) is there.

I'm testing at the moment and it's going fine so far, but it needs more testing.

Thanks again for the feedback.  Out of interest, are you using the Additional Meta Data functionality, or are you solely after the few bugfixes/improvements I've made ("%" issue; "&" issue; new style log files)?

Changes from b12:
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-03 16:46:25
Actually, I have need for all of the fixes and additional meta data functionality. Thank you for adding all of the extras.

I will try beta 13 as soon I arrive home from work. Boy, you are a quick one! 
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-03 16:56:36
Actually, I have need for all of the fixes and additional meta data functionality. Thank you for adding all of the extras.

I will try beta 13 as soon I arrive home from work. Boy, you are a quick one! 
Ah, cool.  It's good to hear of someone making use of the added functionality.  That makes a total of three now I think!

I'm lucky enough to work for an "Internet" company, with people who just care if I get my work done, so I have the flexibility to trawl HA or make a quick fix and upload once in a while.
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-03 22:26:22
REACT 2.0.ssb13 is working perfectly with my FLAC images. Thank you, Neil.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-03 22:29:21
Good news.  Thanks for your help Dirk.
Title: REACT 2 Released
Post by: Kluyg on 2007-07-09 07:21:53
Thanks for REACT! Great tool for fast and secure ripping! I have just solved a problem with REACT: it was not working on my PC (Windows XP pro sp2 RUS) because it uses code page 1252 when running script, and Russian characters in folder name (My documents -> Мои документы) are shown wrong. I’ve only changed one string in REACT-image.cfg: CHCP 1252 -> CHCP 1251 and now it works as it should. Hope this will be useful for others who have Win XP with language different from English.
Title: REACT 2 Released
Post by: rohangc on 2007-07-11 06:43:33
Okay, I read the whole thread and now I am confused! I know that this has been already answered in this very thread, but puhleaaase answer my question:

If I set any of the following options to '1' (i.e., enable it), will this permanently (as in, permanently in a non-recoverable way), alter my FLAC images?:

ReplayGain
ApplyAlbumGain
AdjustAlbumGain_dB
AddCuesheetAG
UseWaveGainAG

I am fine with things being written out into tags, but I want to ensure that my FLAC images themselves are not modified irreversibly.

Please tell me which (if any) of the above options actually alter the audio, and not just write to FLAC/APEv2 tags.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-11 07:10:36
I can only quote Tycho:
OK, inputs  are noted. To tag both AG and TG but not apply them, you must set

ReplayGain=1
ApplyAlbumGain=0
UseWaveGainAG=0  ; when 1, it computes AG scale value to apply on lame while encoding. 

I will rethink how to organise the RG options in future releases.

Also, from the wiki (http://wiki.hydrogenaudio.org/index.php?title=REACT#The_REACT.INI_File):

ReplayGain
Enable/Disable ReplayGain calculation and tagging.
ApplyAlbumGain
Apply the album gain to the files, so they are played back with a consistent volume across the albums on every player.
AdjustAlbumGain_dB
If you want to adjust the album gain from 89.0 dB when applying to the audio, set adjustment in dB here.
AddCuesheetAG
Add Album gain/Album peak values to the cuesheet as REM lines. This implies that WaveGain is ran.
UseWaveGainAG
Instruct to use WaveGain to calculate AlbumGain values on the wav image file. The values will be transferred to the various compressed formats, rather than calculating them via other tools. If ApplyAlbumGain=1, LAME and OggEnc2 will use the --scale option to apply the album gain scale factor calculated by WaveGain.

I don't use RG, but I think the above all adds up.
Title: REACT 2 Released
Post by: bryanb on 2007-07-17 15:21:21
All,

Long time EAC user and somehow missed this great tool!! Thanks to all who have made this possible. I have tested the REACT 2.0.ssb13 version and everything works fine with the exception of my CUE sheets not being moved over as they were before. But I can confirm that the log file is being moved over correctly.

One more question... I tried searching but could not come up with anything.

I copied over 1.1.4 FLAC binaries (flac.exe, libflac.dll and metaflac.exe) and changed the ini to 1.1.4 and compression will not work with these binaries. Is there any way to get 1.1.4 to work with REACT?

Thanks.


Bryan
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-17 16:00:21
Are you ripping to tracks or image?  Can we see the config code that deals with the cuesheet please?

There should be no reason why FLAC 1.1.4 will not work.  Does the binary work OK from the command line?

Edit: Ah, I see.  REACT-track.cfg uses "@albumfile@.
Title: REACT 2 Released
Post by: bryanb on 2007-07-17 16:25:11
Are you ripping to tracks or image?  Can we see the config code that deals with the cuesheet please?

There should be no reason why FLAC 1.1.4 will not work.  Does the binary work OK from the command line?


I am ripping to an image (F10). The only config stuff I have messed with is the .ini file. Below is what I have:

Code: [Select]
[Settings]
Version=2.0
ImageExt=wav
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F5}
VA=Various Artists
CreateAllCuesheets=1
RunCoverDownloader=1
CoverDownloader=C:\Program Files\REACT2\coverdownloader\albumart.exe
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
Tools=C:\Program Files\REACT2\tools
MinimizeCompressionWindow=1
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=0
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
OutRoot=@mymusic@\EAC
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\[$year$] $album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\[$year$] $album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\[$year$] $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
TrackName_SA=$track$ - $title$
TrackName_VA=$track$ - $title$ [$artist$]
TrackName_SA_acdir=$n - $~t
TrackName_VA_acdir=$n - $~t [$~a]

[UserSettings]
Debug=0
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=0
ApplyAlbumGain=0
AdjustAlbumGain_dB=+3.0
AddCuesheetAG=0
UseWaveGainAG=0
Opt_Flac=-6 -f
Opt_Wavpack=-hmy
Opt_LameMP3=-V5 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.3
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5


and the meta.ini:
Code: [Select]
[Current]
discnumber=1
totaldiscs=1
discname=


In doing a diff on the source, the only stuff I see that deals differently with CUE's is:

Code: [Select]
; Add additional meta data to all track cuesheets
        fLoadMetaDataFromIni()
        fLoadAndResaveCuesheet($gui_albumfile & ".[s].cue")
        fLoadAndResaveCuesheet($gui_albumfile & ".[mg].cue")
        fLoadAndResaveCuesheet($gui_albumfile & ".[m].cue")
        fLoadAndResaveCuesheet($gui_albumfile & ".[mc].cue")
    EndIf


And yes, the 1.1.4 FLAC binary I used can encode form the command line.

Thanks for the help.


Bryan

EDIT:
Just reverted to original 2.0 binary and CUE's were copied correctly and log was not (expected behavior). This is also in EAC 0.99pb1.
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-17 16:27:26
If using ACDIR, it will not work with the new libflac.dll. The only libflac file that seems to work is the one that is packaged with the ACDIR binary.
Title: REACT 2 Released
Post by: bryanb on 2007-07-17 16:29:48
If using ACDIR, it will not work with the new libflac.dll. The only libflac file that seems to work is the one that is packaged with the ACDIR binary.


Thanks for the info.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-17 16:38:19
OK, you are ripping to an image, but you are also creating the four cuesheets by specifying CreateAllCuesheets=1 in your INI.  Any reason for this?  You only really need to do this for track rips.

The token @cuesheet@ should still work.  As reported above (I was editing a second time when you posted so you may want to re-read) the @albumfile@ token is going to be working differently now.  I see this is used in the track sections of REACT-image.cfg. Is this where you are experiencing issues?  As you are ripping to an image @albumfile@ will (I suppose wrongly, considering its name) actually follow the image name, i.e.: "$artist$ - [$year$] $album$".  Therefore "@albumfile@.
Title: REACT 2 Released
Post by: bryanb on 2007-07-17 17:12:48
OK, you are ripping to an image, but you are also creating the four cuesheets by specifying CreateAllCuesheets=1 in your INI.  Any reason for this?  You only really need to do this for track rips.

I get the impression that perhaps you are ripping to an image but to create track files (for album gain purposes)?


I guess I should spend some more time learning the program 

I was doing cuesheets b/c that's what I have always done and when ripping to an image and setting FLAC=1, I assumed I needed cuesheets if I wanted to make a copy of the disc at some future date. I guess I just need to set the image type to 'flac'.

I just tried ripping to tracks (F4) and FLAC 1.1.4 DOES work but I still see the same behavior with the cuesheets and when watching the temp directory I see the .log file, and when everything finishes it disappears and is NOT being moved to the final directory.

I need to tinker some more with the program. I'll do more testing and report back once I think I have a better grasp on how everything works.

Thanks.


Bryan
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-17 17:35:44
If you are ripping to an image then the image cuesheet, accessed using @cuesheet@, is automatically createdYou do not need to tell REACT to create them by all specifying CreateAllCuesheets=1; this is normally used when ripping to tracks.

You do need a cuesheet.

I am going to release another version of my mod in the next few hours (possibly in the next half hour).  I will revert @albumfile@ to represent "<source directory>\<album>", as I think this makes most sense - given the token's name! I am now using @logfile@ for what was previously @albumfile@, where "@logfile@.log" == "@eaclog@".
Title: REACT 2 Released
Post by: bryanb on 2007-07-17 17:39:08
If you are ripping to an image then the image cuesheet, accessed using @cuesheet@, is automatically createdYou do not need to tell REACT to create them by all specifying CreateAllCuesheets=1; this is normally used when ripping to tracks.

You do need a cuesheet.

I am going to release another version of my mod in the next few hours (possibly in the next half hour).  I will revert @albumfile@ to represent "<source directory>\<album>", as I think this makes most sense - given the token's name! I am now using @logfile@ for what was previously @albumfile@, where "@logfile@.log" == "@eaclog@".


Thanks for the clarification. I appreciate your help and prompt responses.


Bryan
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-17 18:50:25
OK, I have reverted @albumfile@ to represent "<sourcedir>\<album>", irrespective of the EAC version.

What was (incorrectly, given the token name) @albumfile@ is now @logfile@, where "@logfile@.log" == "@eaclog@" (i.e.: it is the path to the log file without the file extension).  I can't see @logfile@ being any use, but it's available. 

I think this makes most sense: @albumfile@ does now again refer to a file using the album name.

2.0.ssb15 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb15.zip)

Changelog:NB: ssb14 was something I was working on at home, and has now been incorporated into ssb15.  The Test setting has been tested, but not exhaustively so.  I thought I may as well throw it into ssb15, from ssb14, though. All feedback welcome.  To clarify: Set Test=1 and then hitting F10 will run "Test & Copy Image & Create CUE Sheet" and F4 will run "Test & Copy Selected Tracks".
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-17 23:49:09
Hi Neil,

I set Test=1 and hit F10 and "Test & Copy Image & Create CUE Sheet" ran perfectly. Thanks for adding that!
Title: REACT 2 Released
Post by: bryanb on 2007-07-18 05:01:48
Have tested out 2.0.ssb15 and everything works as I had hoped. After spending some time reading over the source and CFG files everything is now becoming clearer as to how everything ties together.

Thanks for the help.


Bryan
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-18 06:38:00
I set Test=1 and hit F10 and "Test & Copy Image & Create CUE Sheet" ran perfectly. Thanks for adding that!
 
Have tested out 2.0.ssb15 and everything works as I had hoped. After spending some time reading over the source and CFG files everything is now becoming clearer as to how everything ties together.

Thanks for the help.
I've just got up.  Nice to wake up to some good news and polite members!  You're both welcome.  Thanks for testing Dirk.
Title: REACT 2 Released
Post by: dobo on 2007-07-18 20:48:36
Started using eac 0.99pb1 and Synthetic Souls's ssb15 mod that creates wavpack and mp3's, works great but i have a query.
React moves my album art and log to the newly ripped wavpack dir which is fine, but i would also like it if the album art could also be copied to the newly created mp3 album, is this possible?

Also embedding album art doesn't seem to work for me, i'm hitting F10 and ripping to separate tracks for mp3 and wavpack. What i would really like is to embed album art into the separate files and also keep a copy in the album folder, is this possible?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-18 22:55:19
React moves my album art and log to the newly ripped wavpack dir which is fine, but i would also like it if the album art could also be copied to the newly created mp3 album, is this possible?
Yes.  However, looking at REACT-image.cfg it looks like it should be copied to both by default.  Confused.

Also embedding album art doesn't seem to work for me, i'm hitting F10 and ripping to separate tracks for mp3 and wavpack. What i would really like is to embed album art into the separate files and also keep a copy in the album folder, is this possible?
Do you have EmbedCover set to 1 in the UserSettings section of REACT.ini?  I believe I'm right in saying that, with that setting, you will have the album art embedded and copied.
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-19 09:56:45
looking at REACT-image.cfg it looks like it should be copied to both by default.  Confused.


It does just that for me
thanks,
IH
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-19 10:10:13
A problem arose - now it's the tracks
while most of the files LAME fine
Code: [Select]
TITLE 07/13 mp3 "Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte -
Boulez/BBC Sym..." & C:\PROGRA~1\REACT2\tools\lame.exe -V3 --vbr-new --noreplayg
ain --nohist  - "07 - VII. Finale.mp3" & C:\PROGRA~1\REACT2\tools\metamp3.exe --
pict "{3}C:\Documents and Settings\ibm\Moje dokumenty\Serenade; 5 Pieces for Orc
hestra; Ode to Napoleon Buonaparte - Boulez BBC Symphony Ensemble InterContempor
ain Shirley-Quirk W.jpg"  --artist "Arnold Schoenberg" --album "Serenade; 5 Piec
es for Orchestra; Ode to Napoleon Buonaparte - Boulez/BBC Sym..." --title "VII.
Finale" --track 07/13 --year "" --genre "Classical" --comment "Created with EAC/
REACT2, 2007-07-19" --frame TENC:"ibm" --frame TSSE:"LAME 3.97 -V3 --vbr-new --n
oreplaygain --nohist" "07 - VII. Finale.mp3"
LAME 3.97 32bits (http://www.mp3dev.org/)
CPU features: MMX (ASM used), SSE (ASM used), SSE2
Using polyphase lowpass filter, transition band: 17960 Hz - 18494 Hz
Encoding <stdin> to 07 - VII. Finale.mp3
Encoding as 44.1 kHz VBR(q=3) j-stereo MPEG-1 Layer III (ca. 8.2x) qval=3
metamp3 v0.91 - Copyright © 2006 by Tycho
Updating: 07 - VII. Finale.mp3
some do not
Code: [Select]

TITLE 08/13 mp3 "Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte -
Boulez/BBC Sym..." & C:\PROGRA~1\REACT2\tools\lame.exe -V3 --vbr-new --noreplayg
ain --nohist  - "08 - 5 Pieces for Orchestra, Op. 16 -- I. Vorgefuhle.mp3" & C:\
PROGRA~1\REACT2\tools\metamp3.exe --pict "{3}C:\Documents and Settings\ibm\Moje
dokumenty\Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte - Boulez
BBC Symphony Ensemble InterContemporain Shirley-Quirk W.jpg"  --artist "Arnold S
choenberg" --album "Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte
 - Boulez/BBC Sym..." --title "5 Pieces for Orchestra, Op. 16 -- I. Vorgefuhle"
--track 08/13 --year "" --genre "Classical" --comment "Created with EAC/REACT2,
2007-07-19" --frame TENC:"ibm" --frame TSSE:"LAME 3.97 -V3 --vbr-new --noreplayg
ain --nohist" "08 - 5 Pieces for Orchestra, Op. 16 -- I. Vorgefuhle.mp3"
Can't init outfile '08 - 5 Pieces for Orchestra, Op. 16 -- I. Vorgefuhle.mp3'
metamp3 v0.91 - Copyright © 2006 by Tycho

Usage: C:\PROGRA~1\REACT2\tools\metamp3.exe [options] [mp3files]
options:
  --artist <artist>   audio/song artist
  --album <album> audio/song album
  --track <track>[/total] audio/song track number
  --title <title> audio/song title
  --year <year>   audio/song year of issue (1 to 9999)
  --genre <genre> audio/song genre name
  --comment [[desc]][{lng}]<text> add user-defined text
  --user-text [[desc]]<text>   add user text frame (TXXX)
  --user-url [[desc]]<URL> add user URL frame (WXXX)
  --frame <frame:text> set any T* or W* type frame
  --pict [[desc]][{type}]<file>  add picture artwork
  --save-pict <pict>   pict=[[desc]][{type}]<file>
  --list-pict-types   list possible picture type numbers
  --list-frames   list Text and URL id3v2.3 frames
  --list-genres   list standard id3v1.1 genres
  --1 add id3v1 tag only (default both v1 and v2)
  --2 add id3v2 tag only (--1 --2 will add both)
  --fit   add id3v1 + id3v2 if tag does not fit id3v1
  --remove [[desc]]<frame> remove frame(s). accepts wildcards *,?
  --replay-gain   calculate and set replay gain tags
  --apply-gain <gain> change volume. gain=[album|radio]<+dB|-dB>
  --undo-gain undo previous apply-gain
  --info   print detailed mp3/lametag info
  --version   show version info
  --help   show this help
Very strange
IH
EDIT:
I did it again, and the results were the same. I'm using the latest SynthS's react
EDIT:
Now that's weird - Foobar brought errors on the very same files - maybe it's a filename problem?
Code: [Select]
Error writing to file (Encoder has terminated prematurely with code -1; please re-check parameters) : file://C:\Documents and Settings\ibm\Moje dokumenty\@OutRoot@\MP3\Arnold Schoenberg\[] Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte - Boulez-BBC Symphony-Ensemble InterContemporain-Shirley-Quirk-W\04 IV. Sonett von Petrarca_ 'O konnt' ich je der Rach' an ihr genesen'.mp3
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-19 10:34:55
Can we see the cuesheet please?  Surround the text with [CODEBOX] and [/CODEBOX].

LAME is failing to encode the file.  I can only assume that it is a file naming issue.  Does the cuesheet have the track title as "5 Pieces for Orchestra, Op. 16 -- I. Vorgefuhle"?
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-19 12:26:31
I can only assume that it is a file naming issue.
That's what I thought. Here's the cuefile

Code: [Select]
REM DISCNUMBER 1
REM TOTALDISCS 1
REM GENRE Classical
REM DISCID C30F6E0D
REM COMMENT "ExactAudioCopy v0.99pb1"
PERFORMER "Arnold Schoenberg"
TITLE "Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte - Boulez/BBC Sym..."
FILE "Arnold Schoenberg - Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte - Boulez-BBC Symphony-Ensemble InterContemporain-Shirley-Quirk-W.flac" WAVE
  TRACK 01 AUDIO
    TITLE "Serenade, Op. 24 -- I. Marsch"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 00:00:00
  TRACK 02 AUDIO
    TITLE "II. Menuett"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 04:34:52
  TRACK 03 AUDIO
    TITLE "III. Variationen"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 11:55:20
  TRACK 04 AUDIO
    TITLE "IV. Sonett von Petrarca: 'O konnt' ich je der Rach' an ihr genesen'"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 16:10:05
  TRACK 05 AUDIO
    TITLE "V. Tanzscene"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 19:04:47
  TRACK 06 AUDIO
    TITLE "VI. Lied (ohne Worte)"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 26:10:17
  TRACK 07 AUDIO
    TITLE "VII. Finale"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 28:32:60
  TRACK 08 AUDIO
    TITLE "5 Pieces for Orchestra, Op. 16 -- I. Vorgefuhle"
    PERFORMER "Arnold Schoenberg"
    INDEX 00 33:58:05
    INDEX 01 34:07:55
  TRACK 09 AUDIO
    TITLE "II. Vergangenes"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 36:10:37
  TRACK 10 AUDIO
    TITLE "III. Farben"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 40:52:50
  TRACK 11 AUDIO
    TITLE "IV. Peripetie"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 43:43:10
  TRACK 12 AUDIO
    TITLE "V. Das obligate Rezitativ"
    PERFORMER "Arnold Schoenberg"
    INDEX 01 45:47:05
  TRACK 13 AUDIO
    TITLE "Ode to Napoleon Buonaparte, Op. 41"
    PERFORMER "Arnold Schoenberg"
    INDEX 00 49:17:22
    INDEX 01 49:27:00
Quote
Does the cuesheet have the track title as "5 Pieces for Orchestra, Op. 16 -- I. Vorgefuhle"?"
As you see, it does.
Thanks,
IH
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-19 14:21:39
I just used your cuesheet with another WAVE file, using this command line:

Code: [Select]
ACDIR.EXE -o "%n - %~t.mp3" --pipe "LAME.EXE -V3 --vbr-new --noreplaygain - $#o" "Arnold Schoenberg - Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte - Boulez-BBC Symphony-Ensemble InterContemporain-Shirley-Quirk-W.cue"

All MP3s were created.  I then tried (more similar to the actual line REACT would have executed):

Code: [Select]
ACDIR.EXE --overwrite --output "%n - %~t.mp3" --pipe "TITLE $n/$N mp3 $#T & LAME.EXE -V3 --vbr-new --noreplaygain - $#o & METAMP3.EXE --fit --artist $#a --album $#T --title $#t --track $n/$N --year $q$R{YEAR}$q --genre $q$R{GENRE}$q --comment $q$R{COMMENT}$q $#o" "Arnold Schoenberg - Serenade; 5 Pieces for Orchestra; Ode to Napoleon Buonaparte - Boulez-BBC Symphony-Ensemble InterContemporain-Shirley-Quirk-W.cue"

... and all MP3s were created again.

I'm a bit stumped what to try next!  Have you edited the MP3 track section of the config at all?

Did track 9 work?  Was it only track 8 that failed?  Has it failed repeatedly (i.e.: if you rip the disc again does it always fail on track 8)?  Is it only with this disc that this has happened?

I'm not sure if you can pass on any more information but I'm stumped for now.  The only other thing I could think of for the "Can't init outfile" error would be some sort of disk error...

Edit: Another thought: is it possible somehow that the WAVE has been truncated, so that it was not long enough for track 8 (34:07:55)?  I'm going to test this to see what LAME or ACDIR says in this circumstance.
Edit: Meh.  ACDIR just reports "Failed to open the input file!".
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-19 14:37:35
Have you edited the MP3 track section of the config at all?

I do not think I did.

Quote
Did track 9 work?  Was it only track 8 that failed?  Has it failed repeatedly (i.e.: if you rip the disc again does it always fail on track 8)?  Is it only with this disc that this has happened?


All the disc converted fine, except 4&8. I had the same problem with another disc, a Stravinsky with french titles - maybe it's a problem of non standard ASCII characters (>128)? I'm using the polish version of XPs, so maybe there's some code page conflict.
I ripped 12+ discs today, and had errors just on those two - one has German, another French characters
Quote
Edit: Another thought: is it possible somehow that the WAVE has been truncated, so that it was not long enough for track 8 (34:07:55)?  I'm going to test this to see what LAME or ACDIR says in this circumstance


No, wave (flac) is ok, plays ok. What's more, converting by fb2k gave errors on the very same file! So it looks like a LAME problem.
Now ain't that strange?
IH
Title: REACT 2 Released
Post by: robert on 2007-07-19 14:53:19
You may want to check the full filename length. The OS limit is 260 characters (MAX_PATH).
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-19 15:07:26
You may want to check the full filename length. The OS limit is 260 characters (MAX_PATH).
I can't believe that I didn't think of that.  Thanks robert.

4 and 8 have the longest track names.

I can replicate it using a long path.

Edit: I have tested, and it seems that you can utilise the GetShortPath (http://wiki.hydrogenaudio.org/index.php?title=REACT:Using_Short_Filenames) tip.

1. At the bottom of your REACT-image.cfg file replace:

Code: [Select]
REM ** Delete this .bat file
DEL %0

... with:

Code: [Select]
REM ** Delete this .bat file:
DEL %0

GOTO :EOF

:GetShortPath
SET %2=%~fs1
GOTO:EOF


2. In the LAME tracks section replace:

Code: [Select]
SET dest="@TrackDir_MP3@"

.. with:

Code: [Select]
SET dest="@TrackDir_MP3@"
CALL :GetShortPath %dest% destShortPath

...and:

Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.mp3" --extra-opt "{3}@cover@" --pipe "TITLE $n/$N mp3 $#T & @tools@\lame.exe @Opt_LameMP3@ %ApplyAG_Lame% - $#o & @tools@\metamp3.exe %Fit_tag% %Cover_tag% %VA_tag% %Disc_MP3_acdir% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q $#o" "@sourcecuesheet@"

... with:

Code: [Select]
@tools@\acdir.exe --overwrite --output "%destShortPath%\%TrackName%.mp3" --extra-opt "{3}@cover@" --pipe "TITLE $n/$N mp3 $#T & @tools@\lame.exe @Opt_LameMP3@ %ApplyAG_Lame% - $#o & @tools@\metamp3.exe %Fit_tag% %Cover_tag% %VA_tag% %Disc_MP3_acdir% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q $#o" "@sourcecuesheet@"


If my tests are anything to go by this should appease LAME.

Edit: clarified final amend (see post #489).
Title: REACT 2 Released
Post by: poop on 2007-07-20 05:36:30
Hi - I'm new to React and this forum - both are fantastic!

Have got React working nicely thanks to a bit of research, but cannot figure out how to set the bitrate of my MP3 encoding. Always seems to rip using VBR, but would love it to be 192.

Am also trying to figure out exactly what is being done to the FLAC files that React outputs. I am after bitperfect files as exact as possible to the original on the CD. I assume that by their nature, the various 'gain' instructions will impact on the FLAC file produced, thereby making the file louder or softer than the original recording. Is this correct? If it is, what is the best way to ensure a FLAC file that is unadulterated in any way? Are there other processes happening that may also change the file?


Many thanks...

Sorry... also noticed that the MP3 files being produced seem noticeably quieter than the FLAC files with React. When using another program to rip MP3, the comparative volume against FLAC seems almost identical. Any suggestion as to why this may be happening?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-20 07:46:52
Have got React working nicely thanks to a bit of research, but cannot figure out how to set the bitrate of my MP3 encoding. Always seems to rip using VBR, but would love it to be 192.
The LAME settings can be amended using the Opt_LameMP3 setting under the [UserSettings] section in REACT.ini.  However, I would recommend sticking with VBR files, but if you want higher bitrate maybe changing -V5 to -V2.  If you must have 192 CBR then change the line to:

Opt_LameMP3=-b 192 --noreplaygain --nohist

Am also trying to figure out exactly what is being done to the FLAC files that React outputs. I am after bitperfect files as exact as possible to the original on the CD. I assume that by their nature, the various 'gain' instructions will impact on the FLAC file produced, thereby making the file louder or softer than the original recording. Is this correct? If it is, what is the best way to ensure a FLAC file that is unadulterated in any way? Are there other processes happening that may also change the file?
...
Sorry... also noticed that the MP3 files being produced seem noticeably quieter than the FLAC files with React. When using another program to rip MP3, the comparative volume against FLAC seems almost identical. Any suggestion as to why this may be happening?
Your summary of replay gain is essentially correct, although you may want to read up on it in the wiki.  The calculations should only be stored as tags unless you specify ApplyAlbumGain=1 in your INI, in which case the volume will be permanently altered.  There is no concern over having RG tags stored, and your file will be no less lossless.

Perhaps you should post your INI, surrounding it with [CODEBOX] and [/CODEBOX], so we can see how your gain-related settings are currently set.

Edit: RE: gain settings.  It may also be worth looking at this post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=50273&view=findpost&p=503890) in this thread
Title: REACT 2 Released
Post by: poop on 2007-07-20 08:30:28
Really appreciate your response!

I would recommend sticking with VBR files, but if you want higher bitrate maybe changing -V5 to -V2.
I like CBR because I know I am listening to a constant. Is the reason you suggest using VBR because it will provide grater quality at a smaller size due to the varied in bitrate? Or are there other benifits?

The calculations should only be stored as tags...  There is no concern over having RG tags stored, and your file will be no less lossless.
Meaning that the tag can be altered easily at a later stage? Didn't know you could set this kind of parameter via tags - pretty impressive. So setting gain to 0 would be the same as the original recording during playback?

Perhaps you should post your INI so we can see how your gain-related settings are currently set.

Code: [Select]
[Settings]
Version=2.0
ImageExt=wav
ImageNaming=$artist$ - $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F5}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=1
CoverDownloader=C:\Program Files\REACT2\coverdownloader\albumart.exe
EAC=F:\EAC\EAC.exe
Tools=C:\Program Files\REACT2\tools
MinimizeCompressionWindow=1
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
OutRoot=@mymusic@\New Rips
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\$album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\$album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\$album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\$album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\$album$
TrackName_SA=$track$  $title$
TrackName_VA=$track$  $title$ [$artist$]
TrackName_SA_acdir=$n  $~t
TrackName_VA_acdir=$n  $~t [$~a]

[UserSettings]
Debug=0
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=0
ApplyAlbumGain=0
AdjustAlbumGain_dB=0
AddCuesheetAG=0
UseWaveGainAG=0
Opt_Flac=-5 -f
Opt_Wavpack=-hmy
Opt_LameMP3=-V5 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.3
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5





Thanks again...
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-20 09:27:14
Yes.  VBR files will provide better quality for the filesize, as CBR is not efficient (you are using more bits on easily-encoded parts than necessary).

You would not (normally) manually amend RG tags - you either have them set accurately (by some application like metaflac or foobar), or not at all.

I must admit I'm out of my comfort zone with the RG settings, but from what I can see your MP3s are more quiet because you have ApplyAlbumGain set, and that is telling metamp3 to apply the gain to the file, in the same way MP3Gain does.  If you don't like the quieter files then set this to 0 instead.  I believe that your FLAC files will only have the RG tags set, so should be CD volume.  As I say though, not really my field.

Edit: hang on, I just re-read my post and your INI and it seems that you don't have ApplyAlbumGain set!  Did you amend this with your post edit, or was I seeing things?
Title: REACT 2 Released
Post by: poop on 2007-07-20 10:16:41
Yeah sorry - it was part of the edit - changed the ini to test some other settings and forgot I changed gain before the save    Apologies for the confusion. Thank you again for your help, will test the MP3 volume and compare again.
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-20 13:52:10
If my tests are anything to go by this should appease LAME.


Thanks a lot - they did. Everything is OK now. I'd never do it by myself.
By the way, is there any reason for the hack not being a part of the official pack?
IH

PSI initally just copied & pasted your changes, and this one obviously did not work:
Quote
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.mp3" ...

... with:

Code: [Select]
@tools@\acdir.exe --overwrite --output "%destShortPath%\%TrackName%.mp3" ...

as "..." means "whatever comes next".
So maybe you could edit that post so that it includes the full thing just to be copied & pasted? That could be helpful for people looking to solve that problem in the future.
Thanks again - I have a fully functional REACT system now.
Title: REACT 2 Released
Post by: Junon on 2007-07-20 14:27:08
I like CBR because I know I am listening to a constant.

You listen to the music instead of the bits, which are the only constant in this case.
Actually, it's the other way round: Constant bitrate = variable quality  ---> variable bitrate = (almost)* constant quality

This is due to the fact that the complexity of your music isn't always the same. A silent strings ensemble is much easier to encode than a loud Thrash Metal-Band playing its guitar riffs, with the drummer banging into his drums like that was the last thing he'd do in his life. The latter needs a lot more bits to encode at a quality level that's comparable to the first example.

You can observe this behaviour on a highly dynamic and diversified VBR-encoded song, while playing it back with a player that displays the currently used bitrate instead of the whole file's average one. During silent parts the bitrate will drop, during more complex ones it will rise, ensuring that the quality level you specified in your encoder can be maintained throughout the whole song.

And that's the problem of CBR: While it wastes bits at the less complex areas of a song, it possibly doesn't get enough of those during the more troublesome moments, resulting in variations of the quality. Of course, it depends on your ears and the CBR bitrate whether these quality variations are audible. But in theory they're always there.

*About the (almost): 100% constancy is a theoretical case, of course. The VBR algorithm of an encoder can also have its flaws, which negatively impact the actual result.
Title: REACT 2 Released
Post by: poop on 2007-07-20 15:41:08
Personally I think that a single violin playing a constant note can be just as demanding as the Thrash Metal band you mention. That single note from the violin has a complexity of sound not unlike the combination of the many colours an oil painter might use to give the impression of clear blue water - though we see that water as a sparkling lake, looking closer reveals an almost chaotic pattern of millions of swirling intermingling hues. For me, MP3 allows me to see the lake, and for portable audio that is all I need. I have not yet convinced myself that FLAC is the perfect replica of a CD it is often touted as being, but my ears have not noticed the difference so far, so I rely on it for quality.

I suppose CBR means I know exactly what quality of sound I will achieve - I like knowing what I can audiably expect from a 192 vs 320kbps file. Perhaps it is just that I am more familiar with CBR than VBR...
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-20 17:28:27
Personally I think that a single violin playing a constant note can be just as demanding as the Thrash Metal band you mention.


What, I suppose,  is meant by complexity in this context is NOT the musical complexity, but difficulty to compress the given sound. And as such, loud rock bands are, AFAIK, more difficult to compress.
The measure of such complexity? You provide some sound sample to a number of people and check at which bitrate they won't be able to tell the mp3 from the original.

Quote
I have not yet convinced myself that FLAC is the perfect replica of a CD it is often touted as being, but my ears have not noticed the difference so far, so I rely on it for quality.


Now, be covinced - this is the very same thing. You could as well ask yourself if a zipped file has the quality of the original. After you turn it to wav, you get the very same .wav file you started with - bit per bit.

Quote
I suppose CBR means I know exactly what quality of sound I will achieve - I like knowing what I can audiably expect from a 192 vs 320kbps file. Perhaps it is just that I am more familiar with CBR than VBR...


There's really a lot to be gained from VBR; there a lot of optimisation to be achieved this way.
If you were to use mp3s ona computer it would not be that important - you could use 320kbps; hard disk space is cheap. But if you use a portable players, using a lower bitrate (and VBR will give  you a  much lower average bitrate with the same quality) has a lot of merits: you can put more mp3s on a disk, power consumption is smaller (less disk operatrions).
Have fun,
IH
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-20 17:29:04
Personally I think that a single violin playing a constant note can be just as demanding as the Thrash Metal band you mention. That single note from the violin has a complexity of sound not unlike the combination of the many colours an oil painter might use to give the impression of clear blue water - though we see that water as a sparkling lake, looking closer reveals an almost chaotic pattern of millions of swirling intermingling hues. For me, MP3 allows me to see the lake, and for portable audio that is all I need. I have not yet convinced myself that FLAC is the perfect replica of a CD it is often touted as being, but my ears have not noticed the difference so far, so I rely on it for quality.

I suppose CBR means I know exactly what quality of sound I will achieve - I like knowing what I can audiably expect from a 192 vs 320kbps file. Perhaps it is just that I am more familiar with CBR than VBR...

Well, after reading your post above, you have a most mis-informed life regarding FLAC & MP3. It's a very good thing that you came to the HA forum to get educated. Kind of like the Earth is round, the Earth is flat type thing. It took a long time for the correct answer to win acceptance, but in the end it finally did. If you read the forum threads, you will get a good and thorough education regarding digital music. The people who post here know their stuff. Gabriel, Robert, Menno, Garf, Josh, Bryant; these guys know what they are talking about, along with working on the lossless/lossy encoders. Synthetic Soul is a knowledgeable & great resource, so take advantage of what he knows. Experiment & have fun learning. This is a pretty cool place to hang out. 
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-20 18:46:37
By the way, is there any reason for the hack not being a part of the official pack?
I've only heard of one other person experiencing this issue.  I think I did mention at that time though that perhaps REACT could replace file paths with the short name version by default.

PSI initally just copied & pasted your changes, and this one obviously did not work:
Quote

Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.mp3" ...

... with:

Code: [Select]
@tools@\acdir.exe --overwrite --output "%destShortPath%\%TrackName%.mp3" ...

as "..." means "whatever comes next".
So maybe you could edit that post so that it includes the full thing just to be copied & pasted? That could be helpful for people looking to solve that problem in the future.
I always wonder when I use that technique whether it may throw some people.  OK, I'll edit the original post.

Thanks again - I have a fully functional REACT system now.
You're welcome.  Good luck with the ripping.
Title: REACT 2 Released
Post by: dobo on 2007-07-20 19:02:32
I've done a reinstall of eac and react etc and i can now embed album art into mp3 and copy the album art into both mp3 and wavpack album folders, which is a result.
However I'm still unable to embed album art into my wavpack tracks. has anyone actually manged this?

I've taken a look at the react image cfg and can't figure out what part of the script embeds art into the wavpack tracks.

react.ini has EmbedCover=1

So is it possible for react to embed art into wavpack?
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-20 19:02:57
Quote
Edit: I have tested, and it seems that you can utilise the GetShortPath tip.
...
If my tests are anything to go by this should appease LAME.


This appeases lame - but not the OS!
The system itself has a lot of trouble communicating with those files. You can't change their filenames, you can't copy them directly (but you can copy the directory...)
It's an incredibly serious bug in Windows - not the first nor the only in the filenames category (codepage problems...)
So, contrary to what I suggested, the 'MS - DOS' should not be integrated to the to the main product, nor - in fact - should it be suggested to users without warning.. It's not the solution's fault, but microsoft's bug, of course.
I suggest that the information about the problem be included in the REACT: Using Short Filenames (http://wiki.hydrogenaudio.org/index.php?title=REACT:Using_Short_Filenames) wiki entry.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-20 19:08:15
So is it possible for react to embed art into wavpack?
MP3Tag will do it, but nothing used in REACT will.  It's a new development.  See here (http://www.hydrogenaudio.org/forums/index.php?showtopic=40603).

This appeases lame - but not the OS!
The system itself has a lot of trouble communicating with those files. You can't change their filenames, you can't copy them directly (but you can copy the directory...)
It's an incredibly serious bug in Windows - not the first nor the only in the filenames category (codepage problems...)
So, contrary to what I suggested, the 'MS - DOS' should not be integrated to the to the main product, nor - in fact - should it be suggested to users without warning.. It's not the solution's fault, but microsoft's bug, of course.
I suggest that the information about the problem be included in the REACT: Using Short Filenames (http://wiki.hydrogenaudio.org/index.php?title=REACT:Using_Short_Filenames) wiki entry.
Hmmm.... very true.  Guess the best idea is to go with shorter paths.
Title: REACT 2 Released
Post by: dobo on 2007-07-20 19:16:12
Thanks for the clarification Synthetic Soul, i'm currently using audioshell to embed art into wavpacks but was under the impression react could do it, oh well, looks like react is now doing everything it should so i'm happy.

look forward to these tools developing further, and when foobar can read embed art in my wavpacks

EDIT lazy edit :0
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-20 19:21:14
Thanks for the clarification Synthetic Soul, i'm currently using audioshell to embed art into wavpacks but was under the impression react could do it, oh well, looks like react is now doing everything it should so i'm happy.
I see from that thread that MP3Tag uses the same format as AudioShell, so it seems that you are in good hands (if they had differed I may have warned you against it).

I'm sure a command line tagger will get th functionality soon, and then it can be used in REACT.  I doubt I'm up to adding the functionality to Case's Tag, although it would be nice if someone could.
Title: REACT 2 Released
Post by: poop on 2007-07-21 02:24:56
Well, after reading your post above, you have a most mis-informed life regarding FLAC & MP3. It's a very good thing that you came to the HA forum to get educated. Kind of like the Earth is round, the Earth is flat type thing. It took a long time for the correct answer to win acceptance, but in the end it finally did. If you read the forum threads, you will get a good and thorough education regarding digital music. The people who post here know their stuff. Gabriel, Robert, Menno, Garf, Josh, Bryant; these guys know what they are talking about, along with working on the lossless/lossy encoders. Synthetic Soul is a knowledgeable & great resource, so take advantage of what he knows. Experiment & have fun learning. This is a pretty cool place to hang out. 


LOL!!!

Just because a bunch of people write a bunch of info on a topic, doesn't make me believe it more... I can see alot of people in this forum know a great deal more than I do about audio formats - which is why I am here. That said - I like to know for myself rather than blindly accept. I would consider that I am quite well informed on MP3 and FLAC, VBR and CBR, contrary to your beliefs, which is why I understand both sides of the argument, and have heard all of what has been said in this thread regarding these formats before.

I am not suggesting that anyone here is wrong (if anyone is I am sure it will be me  ), just that I have not had the time to prove it all to myself at this stage.

Many people out there still believe the earth is round... nice and big and sperical, rather than the squashed sphere it truly is... Perhaps it won't be long until we learn it is dented in at the poles like a donut - best to keep an open mind just in case...   

Thanks to everyone for putting up with the nonsensical rants of a noob, and your help. Think I am seriously off topic here now - my apologies.
Title: REACT 2 Released
Post by: drbeachboy on 2007-07-21 03:41:48
Hey, we were all noobs at some point. I didn't know squat about lossy/lossless when I first found my here a few years back. I know squat now, though! Like you, I don't blindly accept anything as fact either, but I do accept things as facts when experts explain, and give me good, intelligent reasons why to believe. As you'll come to find out as you peruse through the forums, most of what is discussed here at HA is backed up by proof and not opinion. So, you won't find a lot of BS or untruths circulating around the forum. I'm still learning more each day that I come here, and I appreciate that whenever I have a question, there is someone here that is always willing to help. I try to help others whenever I can, as well. It's a very cool Community with knowledeable, nice members.
Sounds like you learned Earth Science from Homer Simpson. 


Regards,
Dirk
Title: REACT 2 Released
Post by: poop on 2007-07-21 04:40:29
Sounds like you learned Earth Science from Homer Simpson. 


And audio science...   
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-21 07:23:58
This appeases lame - but not the OS!
The system itself has a lot of trouble communicating with those files. You can't change their filenames, you can't copy them directly (but you can copy the directory...)
It's an incredibly serious bug in Windows - not the first nor the only in the filenames category (codepage problems...)
So, contrary to what I suggested, the 'MS - DOS' should not be integrated to the to the main product, nor - in fact - should it be suggested to users without warning.. It's not the solution's fault, but microsoft's bug, of course.
I suggest that the information about the problem be included in the REACT: Using Short Filenames (http://wiki.hydrogenaudio.org/index.php?title=REACT:Using_Short_Filenames) wiki entry.
Hmmm.... very true.  Guess the best idea is to go with shorter paths. 
Warning added to the wiki article.  While writing I was reminded of a useful command line utility: SUBST.  From the wiki:

One solution to this subsequent issue may be creating a virtual  drive, mapped to a long folder path. This can easily be achieved on the  command line using SUBST, e.g.:


Code: [Select]
SUBST R: "C:\Documents and Settings\My Long Name\My Documents\My Music\My Ripped Music"

You can then access "C:\Documents and Settings\My Long Name\My  Documents\My Music\My Ripped Music\Pixies\Doolittle\01 - Debaser.mp3"  using the virtual path "R:\Pixies\Doolittle\01 - Debaser.mp3".
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-21 15:44:37
I encountered another problem with tracks.
This time, the file itself is created, but it lacks tags.
Here's the cuefile:
Code: [Select]
REM DISCNUMBER 1
REM TOTALDISCS 1
REM GENRE Classical
REM DATE 1993
REM DISCID 050E0D14
REM COMMENT "ExactAudioCopy v0.99pb1"
PERFORMER "Igor Stravinsky"
TITLE "Firebird - 4 Etudes - Fireworks - Boulez, Chicago"
FILE "Igor Stravinsky - Firebird - 4 Etudes - Fireworks - Boulez, Chicago.flac" WAVE
  TRACK 01 AUDIO
    TITLE "Introduction"
    PERFORMER "Igor Stravinsky"
    INDEX 00 00:00:00
    INDEX 01 00:00:33
  TRACK 02 AUDIO
    TITLE "Le jardin enchanté de Kachtcheď"
    PERFORMER "Igor Stravinsky"
    INDEX 01 02:32:65
  TRACK 03 AUDIO
    TITLE "Apparation de l'Oiseau de feu"
    PERFORMER "Igor Stravinsky"
    INDEX 01 04:19:28
  TRACK 04 AUDIO
    TITLE "Danse de l'Oiseau de feu"
    PERFORMER "Igor Stravinsky"
    INDEX 01 06:45:28
  TRACK 05 AUDIO
    TITLE "Capture de l'Oiseau de feu"
    PERFORMER "Igor Stravinsky"
    INDEX 01 08:07:05
  TRACK 06 AUDIO
    TITLE "Supplications de l'Oiseau de feu"
    PERFORMER "Igor Stravinsky"
    INDEX 01 08:59:73
  TRACK 07 AUDIO
    TITLE "Jeu des princesses"
    PERFORMER "Igor Stravinsky"
    INDEX 01 17:14:00
  TRACK 08 AUDIO
    TITLE "Apparition d'Ivan Tsarévitch"
    PERFORMER "Igor Stravinsky"
    INDEX 01 19:38:58
  TRACK 09 AUDIO
    TITLE "Ronde des princesses"
    PERFORMER "Igor Stravinsky"
    INDEX 01 21:16:08
  TRACK 10 AUDIO
    TITLE "Lever du jour"
    PERFORMER "Igor Stravinsky"
    INDEX 01 24:59:33
  TRACK 11 AUDIO
    TITLE "Carillon féerique"
    PERFORMER "Igor Stravinsky"
    INDEX 01 26:31:03
  TRACK 12 AUDIO
    TITLE "Danse de la suite de Kachtchéď"
    PERFORMER "Igor Stravinsky"
    INDEX 01 32:12:20
  TRACK 13 AUDIO
    TITLE "Danse infernale"
    PERFORMER "Igor Stravinsky"
    INDEX 01 32:56:68
  TRACK 14 AUDIO
    TITLE "Berceuse"
    PERFORMER "Igor Stravinsky"
    INDEX 01 37:39:40
  TRACK 15 AUDIO
    TITLE "Disparition du palais"
    PERFORMER "Igor Stravinsky"
    INDEX 01 42:56:08
  TRACK 16 AUDIO
    TITLE "Feu d'artifice"
    PERFORMER "Igor Stravinsky"
    INDEX 00 46:09:33
    INDEX 01 46:19:33
  TRACK 17 AUDIO
    TITLE "Etudes pour orchestre - Danse"
    PERFORMER "Igor Stravinsky"
    INDEX 00 50:13:33
    INDEX 01 50:21:33
  TRACK 18 AUDIO
    TITLE "Etudes pour orchestre - Excentrique"
    PERFORMER "Igor Stravinsky"
    INDEX 01 51:20:33
  TRACK 19 AUDIO
    TITLE "Etudes pour orchestre - Cantique"
    PERFORMER "Igor Stravinsky"
    INDEX 01 53:31:33
  TRACK 20 AUDIO
    TITLE "Etudes pour orchestre - Madrid"
    PERFORMER "Igor Stravinsky"
    INDEX 01 57:09:33
and here's the REACT output[codebox]
Aktywna strona kodowa: 1252

flac 1.1.3, Copyright © 2000,2001,2002,2003,2004,2005,2006  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

Itmp1!542.wav: wrote 235273440 bytes, ratio=0,371
Liczba skopiowanych plików:        1.
Audio CD Image Reader (ACDIR) 0.12 alpha  Copyright © 2003-2005 by Nyaochi

TITLE 01/20 mp3 "Firebird - 4 Etudes - Fireworks - Boulez, Chicago" & C:\PROGRA~
1\REACT2\tools\lame.exe -V3 --vbr-new --noreplaygain --nohist  - "c:\REACTR~1\MP
3\IGORST~1\_1993_~1\01 - Introduction.mp3" & C:\PROGRA~1\REACT2\tools\metamp3.ex
e --pict "{3}C:\Documents and Settings\ibm\Moje dokumenty\Firebird - 4 Etudes -
Fireworks - Boulez, Chicago.jpg"  --artist "Igor Stravinsky" --album "Firebird -
 4 Etudes - Fireworks - Boulez, Chicago" --title "Introduction" --track 01/20 --
year "1993" --genre "Classical" --comment "Created with EAC/REACT2, 2007-07-21"
--frame TENC:"ibm" --frame TSSE:"LAME 3.97 -V3 --vbr-new --noreplaygain --nohist
" "c:\REACTR~1\MP3\IGORST~1\_1993_~1\01 - Introduction.mp3"
LAME 3.97 32bits (http://www.mp3dev.org/)
CPU features: MMX (ASM used), SSE (ASM used), SSE2
Using polyphase lowpass filter, transition band: 17960 Hz - 18494 Hz
Encoding <stdin> to c:\REACTR~1\MP3\IGORST~1\_1993_~1\01 - Introduction.mp3
Encoding as 44.1 kHz VBR(q=3) j-stereo MPEG-1 Layer III (ca. 8.2x) qval=3
metamp3 v0.91 - Copyright © 2006 by Tycho
Updating: c:\REACTR~1\MP3\IGORST~1\_1993_~1\01 - Introduction.mp3

TITLE 02/20 mp3 "Firebird - 4 Etudes - Fireworks - Boulez, Chicago" & C:\PROGRA~
1\REACT2\tools\lame.exe -V3 --vbr-new --noreplaygain --nohist  - "c:\REACTR~1\MP
3\IGORST~1\_1993_~1\02 - Le jardin enchanté de Kachtchei.mp3" & C:\PROGRA~1\REAC
T2\tools\metamp3.exe --pict "{3}C:\Documents and Settings\ibm\Moje dokumenty\Fir
ebird - 4 Etudes - Fireworks - Boulez, Chicago.jpg"  --artist "Igor Stravinsky"
--album "Firebird - 4 Etudes - Fireworks - Boulez, Chicago" --title "Le jardin e
nchanté de Kachtchei" --track 02/20 --year "1993" --genre "Classical" --comment
"Created with EAC/REACT2, 2007-07-21" --frame TENC:"ibm" --frame TSSE:"LAME 3.97
 -V3 --vbr-new --noreplaygain --nohist" "c:\REACTR~1\MP3\IGORST~1\_1993_~1\02 -
Le jardin enchanté de Kachtchei.mp3"
LAME 3.97 32bits (http://www.mp3dev.org/)
CPU features: MMX (ASM used), SSE (ASM used), SSE2
Using polyphase lowpass filter, transition band: 17960 Hz - 18494 Hz
Encoding <stdin>
      to c:\REACTR~1\MP3\IGORST~1\_1993_~1\02 - Le jardin enchanté de Kachtchei.
mp3
Encoding as 44.1 kHz VBR(q=3) j-stereo MPEG-1 Layer III (ca. 8.2x) qval=3
metamp3 v0.91 - Copyright © 2006 by Tycho
Code: [Select]
error: could not open file: c:\REACTR~1\MP3\IGORST~1\_1993_~1\02 - Le jardin enc
hanté de Kachtchei.mp3

Usage: C:\PROGRA~1\REACT2\tools\metamp3.exe [options] [mp3files]
options:
  --artist <artist>              audio/song artist
  --album <album>                audio/song album
  --track <track>[/total]        audio/song track number
  --title <title>                audio/song title
  --year <year>                  audio/song year of issue (1 to 9999)
  --genre <genre>                audio/song genre name
  --comment [[desc]][{lng}]<text> add user-defined text
  --user-text [[desc]]<text>      add user text frame (TXXX)
  --user-url [[desc]]<URL>        add user URL frame (WXXX)
  --frame <frame:text>            set any T* or W* type frame
  --pict [[desc]][{type}]<file>  add picture artwork
  --save-pict <pict>              pict=[[desc]][{type}]<file>
  --list-pict-types              list possible picture type numbers
  --list-frames                  list Text and URL id3v2.3 frames
  --list-genres                  list standard id3v1.1 genres
  --1                            add id3v1 tag only (default both v1 and v2)
  --2                            add id3v2 tag only (--1 --2 will add both)
  --fit                          add id3v1 + id3v2 if tag does not fit id3v1
  --remove [[desc]]<frame>        remove frame(s). accepts wildcards *,?
  --replay-gain                  calculate and set replay gain tags
  --apply-gain <gain>            change volume. gain=[album|radio]<+dB|-dB>
  --undo-gain                    undo previous apply-gain
  --info                          print detailed mp3/lametag info
  --version                      show version info
  --help                          show this help


now the problem seems to be that the metamp3 wants to write to a file named "c:\REACTR~1\MP3\IGORST~1\_1993_~1\02 - Le jardin enchanté de Kachtchei.mp3", while on the disc it's named "02 - Le jardin enchanté de Kachtcheď.mp3" (the last character not being  a d+', but, as far as i can see a single d').
Apparently, the problem arises from that character, as it appears as well on the other track that contains it. 
Another thing I see here is that there is a charcter (CR, space or whatever)
Code: [Select]
error: could not open file: c:\REACTR~1\MP3\IGORST~1\_1993_~1\02 - Le jardin enc
hanté de Kachtchei.mp3
which is not present in the encoding part
Code: [Select]
Encoding <stdin>
      to c:\REACTR~1\MP3\IGORST~1\_1993_~1\02 - Le jardin enchanté de Kachtchei.
but that might well be an artifact of the notepad.
Might it have anything to do with the codepage?
IH
PS converting form cue/flac to an mp3 in the REACT mp3 directory gives no problems.

EDIT: It's definitlely that weird character - changing the name to katchei made it work
Title: REACT 2 Released
Post by: robmck on 2007-07-22 09:57:21
Having a hard time getting REACT to generate flac images.  I do a clean install, then hit F10, and I get a cue file and a .wav, but no flac.  Setting debug=1, it looks like REACT is using the wrong filenames to refer to the cue sheet & log. 

Here's my steps:
1. Clean install of EAC 0.99pb1
2. Clean install of REACT 2
3. Run react & hit yes to install.
4. Alt-F2 to edit react.ini & change ImageExt=flac; and Debug=1.
5. Hit F10.
6. It prompts me for where to save - I hit enter.
7. It chugs for a while and hits the pause at the end of the react script.

At this point, I study the script history and find that flac choked on --tag-from-file:
Code: [Select]
C:\tmp\rip>C:\PROGRA~1\REACT2\tools\flac.exe -5 -f --replay-gain  -T "artist=Goodman, Benny" -T album="Margie" -T totaltracks="20" -T date="" -T genre="Jazz" -T comment="Created with EAC/REACT2, 2007-07-22" -T encoded-by="Rob" -T encoding="Flac 1.1.3 -5 -f" --tag-from-file="cuesheet=C:\tmp\rip\Goodman, Benny - [] Margie.cue" --tag-from-file="eaclog=C:\tmp\rip\Margie.log" "C:\tmp\rip\Gtmp54266.wav" -o "C:\tmp\rip\Goodman, Benny - [] Margie.flac"
ERROR: (--tag-from-file) can't open file for tag value
Type "flac" for a usage summary or "flac --help" for all options


Looking at that directory, I find (note: still haven't hit a key to let the script finish):
Code: [Select]
 Directory of C:\tmp\rip

07/22/2007  01:22 AM    <DIR>          .
07/22/2007  01:22 AM    <DIR>          ..
07/22/2007  01:22 AM             3,358 Goodman, Benny - [] Margie.log
07/22/2007  01:22 AM             2,699 Gtmp54266-react.cue
07/22/2007  01:22 AM       612,888,908 Gtmp54266.wav
07/22/2007  01:22 AM            12,213 Margie.bat


Looks like both --tag-from-file lines point to files that don't exist (or are not yet using those names).  @cuesheet@ resolves to "C:\tmp\rip\Goodman, Benny - [] Margie.cue", but the cue sheet is named Gtmp54266-react.cue, and @eaclog@ resolves to "C:\tmp\rip\Margie.log" but is currently called "Goodman, Benny - [] Margie.log"

If I then fixup the batch file to point to the right files, everything runs exactly as it should.


Soooo: any ideas on how to fix this?  Do I have some version mismatch between EAC & REACT?
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-22 10:50:39
Having a hard time getting REACT to generate flac images.  I do a clean install, then hit F10, and I get a cue file and a .wav, but no flac.  Setting debug=1, it looks like REACT is using the wrong filenames to refer to the cue sheet & log. 

Here's my steps:
1. Clean install of EAC 0.99pb1

You are the right place to ask the question - I had my problem solved here.
Basically, the new 0.99 EAC does not work with REACT correctly. You can download a version modified by Syntethic Soul, and provided on this forum - the latest download is available [http://wiki.hydrogenaudio.org/index.php?title=REACT:Mods]here[/url]
I had similar problems, and that's what solved it.
Have fun
IH

EDIT: link to sytnth's soul wiki instead of the thread
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-22 13:00:23
Ivan.  Good to see you giving back.

FYI: I am maintaining a page in the wiki for my mod, so I'd probably point people there (http://wiki.hydrogenaudio.org/index.php?title=REACT:Mods) for the latest version.

The wiki article mainly focuses on the Additional Meta Data dialogue, but I did compile a changelog (http://wiki.hydrogenaudio.org/index.php?title=REACT:Mods#Changelog) from my posts in this thread, so that could be useful for users to see what the mod includes (perhaps I ought to summarise the good bits into a bullet list of features).

The article can be found here: REACT:Mods (http://wiki.hydrogenaudio.org/index.php?title=REACT:Mods)


BTW: I can only assume that you latest problem is a codepage issue, and I have no idea how to resolve it.  As you suggest the line feed in the filename is purely a console drawing issue, and nothing to worry about.

Edit: Actually, it may be worth you skimming the metamp3 thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=49751), and trying the beta linked to in that thread.  It is possible that the beta handles other codepages better, but the answer would be in the thread.
Title: REACT 2 Released
Post by: vulc44n on 2007-07-23 03:48:32
I started using React 2 today [the latest mod, to be exact].  However, I have run into a few issues.  I'm hoping someone here can help me figure them out...

1. EAC Log file does not get copied to either my flac image output directory or the lame mp3 track directory.

2. The album art in the flac image folder gets named like this: %artist% - %album%.  I'd prefer if it was just folder.jpg like my mp3 track output folder.

Thanks,
Matt
Title: REACT 2 Released
Post by: poop on 2007-07-23 05:48:14
I started using React 2 today [the latest mod, to be exact].  However, I have run into a few issues.  I'm hoping someone here can help me figure them out...

1. EAC Log file does not get copied to either my flac image output directory or the lame mp3 track directory.

2. The album art in the flac image folder gets named like this: %artist% - %album%.  I'd prefer if it was just folder.jpg like my mp3 track output folder.

Thanks,
Matt


Pretty sure you can change the album art naming in the ini file in the section UserOutputNames. Look for ImageDir for each file type (FLAC and MP3, which in your case sound like they will be different). Not 100% sure this is the solution, but if you post your ini here it will be more helpful in being able to see what is happening. There is also an option to embed the album art within the tag file.

For the log file - I think this gets specified in EAC - again could be wrong, but check the destination directory set in EAC for log files and see if they are there.
Title: REACT 2 Released
Post by: robmck on 2007-07-23 06:06:03
Thanks Ivan and Synthetic Soul - I'm now running just fine with the ssb version.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-23 07:36:56
I started using React 2 today [the latest mod, to be exact].  However, I have run into a few issues.  I'm hoping someone here can help me figure them out...

1. EAC Log file does not get copied to either my flac image output directory or the lame mp3 track directory.

2. The album art in the flac image folder gets named like this: %artist% - %album%.  I'd prefer if it was just folder.jpg like my mp3 track output folder.
Are you definately using 2.0.ssb15?  It sounds like you are using an earlier version - the log file was sorted in b12 and image art in b13.  When you open REACT the running version should be displayed in EAC's title bar.  Out of interest, what version of EAC as well please?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-23 08:30:59
Pretty sure you can change the album art naming in the ini file in the section UserOutputNames. Look for ImageDir for each file type (FLAC and MP3, which in your case sound like they will be different). Not 100% sure this is the solution, but if you post your ini here it will be more helpful in being able to see what is happening. There is also an option to embed the album art within the tag file.
REACT specifies the filename using "<album>.jpg".  This can't be changed by the user.  The name is set using the basic information set in the EAC main window, as coverdownloader is run before the cfg file is processed, so there's not a lot of option.

For  the log file - I think this gets specified in EAC - again could be  wrong, but check the destination directory set in EAC for log files and  see if they are there.
Yes, EAC specifies the log file name.  Before 0.99 it used "<album>.log", but now it has two separate naming schemes: for tracks it will use "<artist> - <album>.log" but for images it will use the same naming scheme as the image, which may be "<artist> - <album>.log", but may be something like "<artist> - [<date>] <album>.log" (using REACT's default image naming scheme).
Title: REACT 2 Released
Post by: vulc44n on 2007-07-23 16:22:56
I started using React 2 today [the latest mod, to be exact].  However, I have run into a few issues.  I'm hoping someone here can help me figure them out...

1. EAC Log file does not get copied to either my flac image output directory or the lame mp3 track directory.

2. The album art in the flac image folder gets named like this: %artist% - %album%.  I'd prefer if it was just folder.jpg like my mp3 track output folder.
Are you definately using 2.0.ssb15?  It sounds like you are using an earlier version - the log file was sorted in b12 and image art in b13.  When you open REACT the running version should be displayed in EAC's title bar.  Out of interest, what version of EAC as well please?

I have V2.0.ssb15 in the titlebar and the EAC about dialog says version v0.99 prebeta 1.

For the log file - I think this gets specified in EAC - again could be wrong, but check the destination directory set in EAC for log files and see if they are there.

Well, the log file does get output there, but I'd like to have it output to my flac-image directory then.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-23 17:33:35
I have V2.0.ssb15 in the titlebar and the EAC about dialog says version v0.99 prebeta 1.
OK, I've woken up now.

I see now from the image config (you are ripping to images, right?) that the cover is copied using @basename@ to create the final filename.  If you just want 'folder.jpg' (which is what the tracks config uses strangely) you just need to edit REACT-image.cfg so that:

Code: [Select]
IF %have_cover%==1 COPY /Y "@cover@" %dest%\"@basename@.jpg"

... becomes:

Code: [Select]
IF %have_cover%==1 COPY /Y "@cover@" %dest%\folder.jpg

... in the relevant section for you (flac, wv, etc.).

The log is not copied to the destination folder by default, only embedded in the image.  To move the log to your destination folder just add:

Code: [Select]
MOVE /Y "@eaclog@" %dest%

.. to the relevant section, with the similar lines that move the image and cuesheet.

As you are using FLAC, here's what your FLAC code should probably look like now:

Code: [Select]
IF NOT @ImageExt@==flac GOTO end_flac_image
    SET dest="@ImageDir_Flac@%imageDir%"
    IF NOT EXIST %dest% MKDIR %dest%
    IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
    @tools@\flac.exe @Opt_Flac@ %RG_Flac% %Cover_tag% %Disc_Flac% -T "%ArtistField%=@cdartist@" -T album="@album@" -T totaltracks="@numtracks@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" --tag-from-file="cuesheet=@cuesheet@" --tag-from-file="eaclog=@eaclog@" "@source@" -o "@image@"
    MOVE /Y "@image@" %dest%
    MOVE /Y "@cuesheet@" %dest%
    MOVE /Y "@eaclog@" %dest%
    IF %have_cover%==1 COPY /Y "@cover@" %dest%\folder.jpg
:end_flac_image

NB: If you want the log in your MP3 folder as well you may want to use COPY, instead of MOVE, and uncomment to relevant line in the MP3 tracks section.
Title: REACT 2 Released
Post by: Ivan Helguera on 2007-07-24 16:53:12
Quote
Edit: Actually, it may be worth you skimming the metamp3 thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=49751), and trying the beta linked to in that thread.  It is possible that the beta handles other codepages better, but the answer would be in the thread.

Well, I was about to give up - the problem is rare and changing the name solves it -  but i decided to give the beta a try - and it seems to work (actually, I just ripped a single problematic track, not the image - but that should make no difference whatsoever). Thank you!
What I'm a bit worried about is that you have to look well into the compression window to learn that something went wrong - wouldn't it be nice to provide some visible error report if there were errors? If one rips a number of cd's, finding the cause of problem might be quite difficult.
BTW - has anyone had any success running REACT on linux/wine? Now that gtkpod supports gapless tags for the lame-encoded mp3 tags, I'm quite seriously considering switching to *buntu. I had foobar and EAC as such running quite nicely in wine.

EDIT: forgot to thank for help...
Title: REACT 2 Released
Post by: deltadave on 2007-07-28 16:24:38
I need a bit of help configuring REACT ssb15 to add disc numbers to the file structure.  What I'd like to do is conditionally add "Disc x of x" to album directory name if there is more than one disc in the set.

I'm ripping to tracks and using  TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\$album$ [$year$] for flac output and replacing FLAC with MP3 for mp3 output.  Would like to add "Disc $discnumber$ of $totaldiscs$" after the album name if there is more than one disc in a set - ie no disc 1 of 1 in the file structure.

any help with this would be greatly appreciated
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-28 19:04:42
The following wiki article details the process necessary:

REACT:Adding Support For Disc Information (http://wiki.hydrogenaudio.org/index.php?title=REACT:Adding_Support_For_Disc_Information)

The article uses the simple format "Disc @discnumber@" - appending that to the standard path if @totaldiscs@ is greater than one.

You should just be able to follow the article, and change lines like:

Code: [Select]
SET imageDir=%imageDir%\Disc @discnumber@
SET trackDir=%trackDir%\Disc @discnumber@

...to:

Code: [Select]
SET imageDir=%imageDir%\Disc @discnumber@ of @totaldiscs@
SET trackDir=%trackDir%\Disc @discnumber@ of @totaldiscs@
Title: REACT 2 Released
Post by: deltadave on 2007-07-28 21:24:03
The following wiki article details the process necessary:

REACT:Adding Support For Disc Information (http://wiki.hydrogenaudio.org/index.php?title=REACT:Adding_Support_For_Disc_Information)

The article uses the simple format "Disc @discnumber@" - appending that to the standard path if @totaldiscs@ is greater than one.

You should just be able to follow the article, and change lines like:

Code: [Select]
SET imageDir=%imageDir%\Disc @discnumber@
SET trackDir=%trackDir%\Disc @discnumber@

...to:

Code: [Select]
SET imageDir=%imageDir%\Disc @discnumber@ of @totaldiscs@
SET trackDir=%trackDir%\Disc @discnumber@ of @totaldiscs@



That did the trick... for about half the tracks of disc 1.  Then something happened and the program switched back to not appending Disc x of x onto the path.  Researching why... Perhaps the ini file isn't storing the disc info?

I figured out when it's happening - when the disc is ejected, the metadata dialog resets and the encoding programs lose track of it.  I'm going to try turning off disc eject and see what happens.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-28 22:36:37
I figured out when it's happening - when the disc is ejected, the metadata dialog resets and the encoding programs lose track of it.  I'm going to try turning off disc eject and see what happens.
The meta data does indeed reset when the disc is ejected.

I thought it made sense that values returned to their defaults when the disc changes, so the user doesn't have to worry about resetting the values.

Hmm... I think I have just realised what you are saying.  The disc ejects part ways through the process (once all tracks have been ripped to WAVE) and the meta data is reset, even though the process is mid way through.

Not good.

I guess you are ripping to tracks.  REACT is run each time a track s processed.  Each time it's run it will reload the meta data values from the meta.ini.  Meanwhile, the (initial) instance of REACT that is dealing with EAC has noted the disc change and updated meta.ini.

I will need to resolve this somehow.  Thanks for the report.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-29 08:21:39
I will need to resolve this somehow.  Thanks for the report.
OK, 2.0.ssb16 uploaded.  Please see the wiki (http://wiki.hydrogenaudio.org/index.php?title=REACT:Mods#Changelog) for changelog and link.

The dialogue will still reset when a new disc is inserted; however the recorded values in meta.ini will only be updated just before a rip begins.  Therefore, if you insert a new disc while processing a rip, the GUI will be reset and you can start editing the values, but the ini values will stay unchanged until you hit F4 or F10 to begin the new rip, at which point they will be updated to the current GUI values.

All feedback welcome.
Title: REACT 2 Released
Post by: deltadave on 2007-07-29 09:43:52
tested ssb16, ripping to tracks. No changes in configuration - ripped the wav files and then didn't run the conversions to flac and mp3...  falling back to the ssb15 with no ejection strategy.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-29 09:47:49
tested ssb16, ripping to tracks. No changes in configuration - ripped the wav files and then didn't run the conversions to flac and mp3...  falling back to the ssb15 with no ejection strategy.
Hmmm... it's worked fine for me while testing track ripping.  Confused.

Edit: I've not changed anything near the encoding process - only the meta data dialogue and EAC wrapping.  The whole function that runs with the processing instance of REACT has been untouched.

Edit: I've noticed in testing that @totaldiscs@ (for example) will return "03" instead of "3", as intended.  I have just resolved this an uploaded the new b16.  @totaldiscs@ will now return "3", while $totaldiscs$ will return "03".
Title: REACT 2 Released
Post by: dewey1973 on 2007-07-29 20:44:50
Since switching to EAC 0.99pb1 and ssb16 I am having a problem.  Everything goes great until the extractions is complete.  Nothing happens after the extraction completes.  I use F10 to do an image test & copy.  I get the wav, log, cue, and jpg but none of the other processes begin.  Here is my ini.  Any help would be appreciated.

Code: [Select]
[Settings]
Version=2.0
ImageExt=wv
ImageNaming=$artist$ - $album$ [$year$]
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F5}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=2
CoverDownloader=C:\Program Files\REACT2\coverdownloader\albumart.exe
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
Tools=C:\Program Files\REACT2\tools
MinimizeCompressionWindow=0
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]
Test=1

[UserTrackFormats]
Flac=0
Wavpack=0
LameMP3=0
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
OutRoot=@mymusic@
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\CD-Images\$cdartist$\$album$ [$year$]
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\[$year$] $album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\[$year$] $album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\[$year$] $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
TrackName_SA=$track$ - $title$
TrackName_VA=$track$ - $title$ [$artist$]
TrackName_SA_acdir=$n - $~t
TrackName_VA_acdir=$n - $~t [$~a]

[UserSettings]
Debug=1
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=1
ApplyAlbumGain=1
AdjustAlbumGain_dB=+0.0
AddCuesheetAG=1
UseWaveGainAG=1
Opt_Flac=-5 -f
Opt_Wavpack=-hhx6my
Opt_LameMP3=-V5 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.3
Ver_Wavpack=4.41
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5


[DefaultMetaData]
discnumber=1
totaldiscs=1
discname=
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-29 20:48:54
Perhaps you could try b15 (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb15.zip), to see if I have screwed something up with b16.

I'm confused, because b16 works fine on my Win2K PC, and XP laptop; however deltadave has said that b16 is not processing his WAVE files, so it may well be worth a try.
Title: REACT 2 Released
Post by: deltadave on 2007-07-30 03:01:11
I'm confused, because b16 works fine on my Win2K PC, and XP laptop; however deltadave has said that b16 is not processing his WAVE files, so it may well be worth a try.


Still no joy on ssb16 - it rips to wav, but doesn't go any further than that.  For now, I've fallen back to ssb15 as it works correctly as long as the disc remains in the drive.


This actually got me thinking about another repercussion of doing the disc numbers of a set dynamically - ssb16 wont process correctly in batch mode.  the interface has to be open with the correct numbers in the metadata tags in order for it to work.  Is there any way to have that data go into a tag or data file that is persistent until the rip is processed to flac or ogg or whatever?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-30 07:37:11
Still no joy on ssb16 - it rips to wav, but doesn't go any further than that.  For now, I've fallen back to ssb15 as it works correctly as long as the disc remains in the drive.
I'm finding this extremely frustrating, as I can't get b16 to fail.  The changes between b15 and b16 are so minimal.  I need to hear from dewey1973 to see if b15 works for him, and maybe some other kind-hearted souls who are willing to test.  Do I take it the batch file (that actually does all the processing) is never even created?

This  actually got me thinking about another repercussion of doing the disc  numbers of a set dynamically - ssb16 wont process correctly in batch  mode. the interface has to be open with the correct numbers in the  metadata tags in order for it to work. Is there any way to have that  data go into a tag or data file that is persistent until the rip is  processed to flac or ogg or whatever?
Before I worked on the Additional Meta Data dialogue I had an idea of using markup to pass extra values in the few fields available (artist, album, comment).  E.g.:

Album Name <discnumber>2</discnumber><totaldiscs>3</totaldiscs>

I had the markup parsing working fine, but it caused real problems, or at least confusion, when messing with the album and artist name.  Using the comment field was no issue, but IIRC there is a short character limit on the comment field, rendering it near useless (unless you used single character tokens I suppose).

With regard to this solution, it may be possible that REACT could store meta data in a specific file for each album, perhaps using the artist and album name as the file name.  When the processing REACT instance is run it could use the specific ini and ensure that it is deleted afterwards. I can't really see a problem with this approach.

I want to resolve the potential issue with b16 before doing any other work though.
Title: REACT 2 Released
Post by: dewey1973 on 2007-07-30 16:11:34
Quote
I need to hear from dewey1973 to see if b15 works for him


Testing now...
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-30 16:14:40
Since switching to EAC 0.99pb1 and ssb16 I am having a problem.  Everything goes great until the extractions is complete.  Nothing happens after the extraction completes.  I use F10 to do an image test & copy.  I get the wav, log, cue, and jpg but none of the other processes begin.  Here is my ini.  Any help would be appreciated.
I just tested with ssb16 on my XP machine at work - using your INI file with only OutRoot amended, and the standard cfg file - and it worked fine.

Ho hum.


Quote
I need to hear from dewey1973 to see if b15 works for him
Testing now...
Cool, thanks.
Title: REACT 2 Released
Post by: dewey1973 on 2007-07-30 17:42:02
I get the same result for b15.  Nothing happens after extraction.  All I did was unzip and pull those files into my REACT folder.  I hope that is the correct way to install.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-07-30 17:47:32
So, we're yet to know whether b16 is an issue for other people than deltadave.

Dumping the new EXE in there is fine if you already had REACT and EAC configured.

Is EAC properly configured to use REACT?  It may be worth hitting  Ctrl-F2 with REACT/EAC open, to let REACT (re-)configure EAC.
Title: REACT 2 Released
Post by: dewey1973 on 2007-07-31 00:51:08
It may be worth hitting  Ctrl-F2 with REACT/EAC open, to let REACT (re-)configure EAC.


After doing this the next set of processes did kick off.  I did however get an error that I'm sure has to do with where the files are saved.  I'm sure I can fix it after reading the log more carefully.
Title: REACT 2 Released
Post by: deltadave on 2007-08-01 02:35:20
It may be worth hitting  Ctrl-F2 with REACT/EAC open, to let REACT (re-)configure EAC.


ssb16 rips and converts only for single disc sets.  If any entry is made in the new dialog then the wav file is created and then the process stops.  No conversion, no renames, etc.

I also had to use Ctrl+F2 to reset EAC before ssb16 would rip, convert and rename single disc sets.

Would like to suggest as well, that the dialog not be reset when a new disc is inserted.  If you are ripping a multi disc set, then two values have to be entered with every disc and if ripping a 6 disc set for example, there is a high probability of making a mistake and having to re-rip a disc. Plus it's lot of extra keystrokes.

edit 2: I got ssb16 to work, had to reset EAC with Ctrl+F2 and I also had a missing quote mark in one of the track.cfg file.  Took some doing, but I tracked it down. Sorry about blaming you for my bad typing.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-01 07:22:22
ssb16 rips and converts only for single disc sets. If any entry is made in the new dialog then the wav file is created and then the process stops. No conversion, no renames, etc.

I also had to use Ctrl+F2 to reset EAC before ssb16 would rip, convert and rename single disc sets.
...
edit 2: I got ssb16 to work, had to reset EAC with Ctrl+F2 and I also had a missing quote mark in one of the track.cfg file. Took some doing, but I tracked it down. Sorry about blaming you for my bad typing.
I'm glad you finally got it working.

I would say that I have not had to use Ctrl+F2 on all three computers that I have tested b16 on; it's worked straight off the bat.  Ctrl+F2 seems to resolve issues for people relatively often; I wonder why it (REACT/EAC?) gets confused sometimes.

Would like to suggest as well, that the dialog not be reset when a new disc is inserted. If you are ripping a multi disc set, then two values have to be entered with every disc and if ripping a 6 disc set for example, there is a high probability of making a mistake and having to re-rip a disc. Plus it's lot of extra keystrokes.
My main concern retaining values is that someone could set totaldiscs to 2, hide the dialogue, and then rip a hundred discs forgetting to set it back.  Single disc albums are far more prevalent than muli-disc albums.  The idea is that the settings refer to default - i.e.: the value they will be for most discs - and therefore I would say that you are minimising typing by not having to reset after multi-disc albums.

That's my contra-argument; however if other users disagree I have no problem changing the logic according to the majority.

Thanks for the feedback anyway, I'll certainly bear it in mind.  I have considered providing options on the dialogue before, and perhaps this could be solved with a checkbox to set user preference - possibly even on  a per token basis.

Also, contrary to my previous remark, I have made some steps towards storing the meta data in an album-specific ini, so that it can be used in batch ripping.  My main concern, however, is that - because the EAC wrapper instance only has access to basic info like artist and album - I am currently using "<artist> - <album>.ini" as the naming scheme; fine most times, but not for multi-disc albums.  I don't know a resolve to this, unless I somehow utilise some (as yet undescovered) command line app to calculate the freedb id, use that, and then use the freedb id passed by EAC in the REACT params to find the ini for the album being processed.  Any thoughts?
Title: REACT 2 Released
Post by: deltadave on 2007-08-01 18:53:48
Would like to suggest as well, that the dialog not be reset when a new disc is inserted. If you are ripping a multi disc set, then two values have to be entered with every disc and if ripping a 6 disc set for example, there is a high probability of making a mistake and having to re-rip a disc. Plus it's lot of extra keystrokes.
My main concern retaining values is that someone could set totaldiscs to 2, hide the dialogue, and then rip a hundred discs forgetting to set it back.  Single disc albums are far more prevalent than muli-disc albums.  The idea is that the settings refer to default - i.e.: the value they will be for most discs - and therefore I would say that you are minimising typing by not having to reset after multi-disc albums.

That's my contra-argument; however if other users disagree I have no problem changing the logic according to the majority.

Thanks for the feedback anyway, I'll certainly bear it in mind.  I have considered providing options on the dialogue before, and perhaps this could be solved with a checkbox to set user preference - possibly even on  a per token basis.


A check box for persistence would solve the problem quite neatly. I'm not sure how big of a problem this would actually be, I keep an eye on the file conversions as things move along.  If they aren't named properly, it would be fairly easy to notice. That is my personal experience only, not sure if it would be applicable to anyone else.

Also, contrary to my previous remark, I have made some steps towards storing the meta data in an album-specific ini, so that it can be used in batch ripping.  My main concern, however, is that - because the EAC wrapper instance only has access to basic info like artist and album - I am currently using "<artist> - <album>.ini" as the naming scheme; fine most times, but not for multi-disc albums.  I don't know a resolve to this, unless I somehow utilise some (as yet undescovered) command line app to calculate the freedb id, use that, and then use the freedb id passed by EAC in the REACT params to find the ini for the album being processed.  Any thoughts?


code libraries:
http://www.codeproject.com/cs/media/freedb.asp (http://www.codeproject.com/cs/media/freedb.asp)

Thread on this very topic:
http://www.autohotkey.com/forum/topic13706.html (http://www.autohotkey.com/forum/topic13706.html)

In EAC isn't %f the tag for storing freedb id?  Not usually used from what I can tell, but still available. I think.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-01 19:09:59
code libraries:
http://www.codeproject.com/cs/media/freedb.asp (http://www.codeproject.com/cs/media/freedb.asp)

Thread on this very topic:
http://www.autohotkey.com/forum/topic13706.html (http://www.autohotkey.com/forum/topic13706.html)

In EAC isn't %f the tag for storing freedb id?  Not usually used from what I can tell, but still available. I think.
Thanks for the links.  I found another of interest earlier today also (http://www.vbaccelerator.com/home/vb/code/vbMedia/Audio/CD_Tracklistings/article.asp).

The processing instance of REACT will have access to the %f parameter; however the EAC-wrapper instance does not.  I can only think that the wrapper instance will have to calculate the ID itself somehow, in order to write the INI file.

I'm also worried about over-complicating my mod, with the need for additional EXEs/DLLs and extra processing time.

I've just thought of a sure-fire way to get the freedb id.  Force EAC to write a "Single WAV File" cuesheet (Alt+S) and then grab the freedb id from the REM statement.  Slightly messy, but no need for additional exes/dlls, and I know the id will be the same.

Of course, this will also rely on the user using unique names for their images when ripping to WAVE with the compression queue on.
Title: REACT 2 Released
Post by: deltadave on 2007-08-01 20:41:58
I'm also worried about over-complicating my mod, with the need for additional EXEs/DLLs and extra processing time.

I've just thought of a sure-fire way to get the freedb id.  Force EAC to write a "Single WAV File" cuesheet (Alt+S) and then grab the freedb id from the REM statement.  Slightly messy, but no need for additional exes/dlls, and I know the id will be the same.

Of course, this will also rely on the user using unique names for their images when ripping to WAVE with the compression queue on.


I can understand your concern re processing time and additional dll's etc.... 


If you need a guinea pig to test out your stuff, I'm willing to volunteer.  Should this turn out to be too much of a pain to deal with a special case, I'll just deal with it by hand and take the time.  Default behavior is just fine for most of my collection.

Edit:
I think that I'm slightly confused as to how EAC/REACT works... would you mind putting up a brief summary or pointing to one? 

My understanding:  REACT opens using the .ini file then rips the files from CD to .wav file.  Once the .wav file(s) are created it uses the .cfg file to create a batch file that processes the wav file(s) by instancing FLAC, LAME or whatever external compression program is desired.  The processing instance would be the REACT that creates the wav files? Wrapper would be the batch file that calls the external processor?
Title: REACT 2 Released
Post by: dewey1973 on 2007-08-01 22:02:04
After doing this the next set of processes did kick off.  I did however get an error that I'm sure has to do with where the files are saved.  I'm sure I can fix it after reading the log more carefully.


I've done some more playing around and this is what I have found.  I did a complete reinstal of EAC and REACT ssb16.  When I set "Test=1" and "Debug=1" I find the following error.

Code: [Select]
error in tag spec: eaclog=@C:\My Documents\My Music\CD Images\The Police - The Police (Disc 1) [2007].log !


Then the rest of the bat file tries to execute for the file moves, etc.

When I set "Test=0" this error does not occur and the process completes successfully with the exception that the log file is not moved to the new directory.  The log is, however, saved in the tag of the wv file.

I'd really like to use Test & Copy.  Any idea what I can do to make this work?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-01 22:53:35
I think that I'm slightly confused as to how EAC/REACT works... would you mind putting up a brief summary or pointing to one? 

My understanding:  REACT opens using the .ini file then rips the files from CD to .wav file.  Once the .wav file(s) are created it uses the .cfg file to create a batch file that processes the wav file(s) by instancing FLAC, LAME or whatever external compression program is desired.  The processing instance would be the REACT that creates the wav files? Wrapper would be the batch file that calls the external processor?
You're pretty much there. The "wrapper" instance and "processing" instance are purely terminology I have coined recently.

When you first run REACT it determines that no command parameters have been passed, and sets itself up as what I call the wrapper instance, because it wraps the EAC GUI.  This instance handles the hotkeys, setting EAC up, my meta data dialogue, etc.  As you say, it uses some settings in REACT.ini to detirmine the way it acts.

When you hit F10 or F4 to rip the wrapper instance is simply using EAC menu commands to start EAC ripping.  As EAC has been set up to use REACT as an external compressor EAC rips to WAVE, and then calls REACT, passing the parameters specified in the compression options.  This instance of REACT is what I call the processing instance, as it processes the files.  As you say, this instance will take the settings in REACT.ini, the parameters EAC passes (file names and meta data), and the appropriate config file, and create a unique batch file which it eventually sets running.  This batch file can contain any commands you like (written in the cfg file), but the default has options for the major encoders, like FLAC, WavPack, LAME, Nero AAC, etc.

At the time the batch file is running you have two instances of REACT running.  When the batch file finishes the processing instance closes and only the wrapper instance (which shows the icon in the sys tray) remains again.

When I set "Test=0" this error does not occur and the process completes successfully with the exception that the log file is not moved to the new directory.  The log is, however, saved in the tag of the wv file.

I'd really like to use Test & Copy.  Any idea what I can do to make this work?
I will try to do some testing tomorrow. I can't see why the log would be named differently.  I must admit I haven't tested using Test & Copy exhaustively, but I did test it, and never noticed a problem.  I seem to remember Dirk reporting success also.  I will test some more.  Do I take it that you have your images set up to use the scheme "$artist$ - $album$ [$year$]"?

When I set "Test=0" this error does not occur and the process completes successfully with the exception that the log file is not moved to the new directory.  The log is, however, saved in the tag of the wv file.
IIRC the standard behaviour is to not move the log file - if you want this to happen you have to add the line to your cfg.  Therefore, when not in Test mode I think things are working for you as they should.

The log will normally just get deleted at the end of the process; however when debugging various files are not deleted as normal (see cfg extract below - notice that when debugging the batch file exits before cleanup begins).

Code: [Select]
IF @Debug@==1 (
    PAUSE
    EXIT
)

REM ** Cleanup

DEL "@source@"
DEL "@eaclog@"
DEL "@cuesheet@"
DEL "@albumfile@.[*].cue"
DEL "@cover@"

REM ** Delete this .bat file:
DEL %0
Title: REACT 2 Released
Post by: drbeachboy on 2007-08-02 02:16:48
I ran ssb16 on a single disc converting to a FLAC image and it worked flawlessly. My cuesheet & log were inserted, along with a jpg album cover. All tags were correct and the FLAC file was moved to the correct directory.

Missing a quote mark in the ini & config files can really mess things up big time. Also, check whether you are using $ and @ signs correctly with the tokens. Check slashes, back slashes, comma's, periods, and spaces.
And lastly, check the spelling of all lines that you edited in the ini & config files.

P.S. I ran the single disc twice. Once normal & then Test & Copy. Correct results both times.
Title: REACT 2 Released
Post by: kalen3285 on 2007-08-02 06:04:49
Hi,

I've just recently figured out that foobar doesn't read the tags that AtomicParsley creates for Nero AAC files, so I've tried modifying the image cfg file to use neroaactag instead, but I can't get it to work.  Please that this is my first time trying to mess with the config files, so I've probably made some simple mistake(s).  I have REACT setup to create a flac image and then nero tracks.  Of course, the flac image is created fine as I haven't messed with that at all, but the nero tracks are not created at all.  I can't tell what the error is (if there's even an error) because the command window closes right after it's done with the flac image.  This is what I've tried so far:

Code: [Select]
IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
SET dest="@TrackDir_AAC@"
IF NOT EXIST %dest% MKDIR %dest%
PUSHD %dest%
IF @various@==1 SET VA_tag=-meta-user:albumArtist=$q@VA@$q -meta-user:compilation=true
IF %embed_cover%==1 SET Cover_tag=-add-cover:front:$#x
@tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --extra-opt "@cover@" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\neroAacTag.exe $#o %Cover_tag% %VA_tag% -meta:artist=$#a -meta:album=$#T -meta:track=$n -meta:title=$#t -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$q@comment@$q -meta-user:encodingTool=$qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q -meta:totaltracks=$N -meta:label=$q@label@$q -meta:disc=$q@discnumber@$q -meta:totaldiscs=$q@totaldiscs@$q"
IF @ApplyAlbumGain@==1 @tools@\aacgain.exe %ApplyAG_AacGain% *.m4a > gainlog.txt
COPY /Y "@eaclog@" "EAClog.txt"
IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
POPD
:end_nero_aac_tracks

I'm still fuzzy on the acdir stuff, so I have no idea if what I've done should even be working.  Thanks in advance for any help.
Title: REACT 2 Released
Post by: dewey1973 on 2007-08-02 06:13:26
Do I take it that you have your images set up to use the scheme "$artist$ - $album$ [$year$]"?


Code: [Select]
ImageNaming=$artist$ - $album$ [$year$]
ImageDir_Wavpack=@OutRoot@\CD Images\$cdartist$\$album$ [$year$]


I wonder if this is a timing issue with Test & Copy.  If the REACT script tries to access the log and it is not yet saved, wouldn't that cause the error?  I noticed that when using Test & Copy the status bar progress indicator goes from 0% to 50% during the test and then goes back to 0% for the copy.  As the copy completes it goes to 50% again.  It never reaches 100%.  If this somehow delays the saving of the log (like until I hit OK on the viewable log that pops up) then the wavpack command line would be looking for a file that didn't exist yet.  Any thoughts?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-02 07:38:34
I wonder if this is a timing issue with Test & Copy.  If the REACT script tries to access the log and it is not yet saved, wouldn't that cause the error?  I noticed that when using Test & Copy the status bar progress indicator goes from 0% to 50% during the test and then goes back to 0% for the copy.  As the copy completes it goes to 50% again.  It never reaches 100%.  If this somehow delays the saving of the log (like until I hit OK on the viewable log that pops up) then the wavpack command line would be looking for a file that didn't exist yet.  Any thoughts?
I think you are very likely correct. I don't believe that the logfile can be named differently when using Test, so it's probably just not there yet.  It may be worth having a look at this article:

REACT:Pausing For The Logfile (http://wiki.hydrogenaudio.org/index.php?title=REACT%3a%50ausing_For_The_Logfile)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-02 20:11:37
Just to let you know, as I don't like to say I'll do something and then not:  my wife's ill at the moment (nothing terminal) and I've taken a couple of days off to look after the kids, so I'm afraid I've no time for testing or code changes, and won't have for a few days.

@dewey1973, Although it's a bit of a workaround, hopefully the pause code in the config will sort your issue.  I hope to still test when I get chance, but if it is simply the logfile getting created a little bit late then I'm not sure I can do anything else except suggest that code.  We'll see.

@kalen3285, You seem to be missing the reference to the cuesheet. Append:

Code: [Select]
 "@sourcecuesheet@"

... to the end of your line.
Title: REACT 2 Released
Post by: dewey1973 on 2007-08-02 21:00:39
Just to let you know, as I don't like to say I'll do something and then not:  my wife's ill at the moment (nothing terminal) and I've taken a couple of days off to look after the kids, so I'm afraid I've no time for testing or code changes, and won't have for a few days.


By all means, take care of your family!  That's always the top priority.  I'll test the pause code and post my results.  I know it's odd to say this having never met you in person, but please let me know if there is anything I can do to make it easier for to care for your family.  I truly appreciate the work you are doing, thank you!
Title: REACT 2 Released
Post by: dewey1973 on 2007-08-04 02:15:48
The pause code worked like a champ!  I guess if someone didn't want to use the pause code they could instead check "Make all compression tasks sleep" in the Compression Queue Control Center.  That way they could make sure nothing happens until the log is ready.
Title: REACT 2 Released
Post by: pholzmann on 2007-08-05 20:40:53
OK, MrPete checking in after a (looong) pause.

I loaded up the latest, ssb16. The new (XUI) albumart as well. Everything worked GREAT... for one album.

On album #2 I get through the rip->wav part, and then it stops.

It's very strange:
* Hangs on "CHCP 1252" command (?!!)... even though doing it myself works fine on cmd line
* Everything works fine IF I...
  - Set DEBUG on
  - Modify the batch file to put the WAV and LOG files back in their proper place, at the top
  - Run the batch file manually after killing REACT

Some kind of window-control thing. I'm guessing it's your windows scripting language... have seen things like this before with WinBatch which is similar.

THANKS for all your hard work! This is soooooooo close...
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-05 21:35:58
let me know if there is anything I can do to make it easier for to care for your family.  I truly appreciate the work you are doing, thank you!
That's very kind, thank you.  She's pretty much fine now, thankfully.

The pause code worked like a champ!  I guess if someone didn't want to use the pause code they could instead check "Make all compression tasks sleep" in the Compression Queue Control Center.  That way they could make sure nothing happens until the log is ready.
Good news.  I can't think of any other way around this.  However, following this, and an idea I had a while back, I have now created some updated CFG files, which incorporate this amend and various others.  I will include them in my mod from now on.

I loaded up the latest, ssb16. The new (XUI) albumart as well. Everything worked GREAT... for one album.

On album #2 I get through the rip->wav part, and then it stops.
Your symptoms don't make any sense to me, so I have to start with the basics:  is this one disc that causes the problems, or have you tried various discs, all with no luck?
Title: REACT 2 Released
Post by: big_red on 2007-08-06 13:37:16
REACT 1 was great but REACT 2 is excellent, it is much easier to configure.  Thanks for continuing to develope it.

I have one issue.  I do not get the cover art embedded into the FLAC or MP3 files.

I have tried to rip FLAC and MP3 tracks using both EAC095pb3 for copyrighted CD's and EAC099pb1 both with ssb16 with the same results.  On debug it shows the 'have_cover' and 'embed_cover' being reset to '0' and then when the jpg is detected being set to '1'.  The correct location of the jpg is also displayed in the debug file but I can not see the cover when I check it using Mp3tag.

I have noticed that my REACT_track.cfg differs from ones others have posted on this thread in that mine has the cover embedding actions under each individual file format heading whereas other posts show a single mention under Post-processing.

Any help appreciated, thanks again
Title: REACT 2 Released
Post by: pholzmann on 2007-08-06 17:41:48
I loaded up the latest, ssb16. The new (XUI) albumart as well. Everything worked GREAT... for one album.

On album #2 I get through the rip->wav part, and then it stops.
Your symptoms don't make any sense to me, so I have to start with the basics:  is this one disc that causes the problems, or have you tried various discs, all with no luck?


OK, here's an update... first, to answer your question: I have had trouble with quite a few different discs. It is NOT the disc!

I went beack to ssb15... seemed to work better...but still not fully reliable. Messed around with debug settings and REM's.

* If I leave DEBUG off, the batch file never runs. Is it possible that with DEBUG=1 in the ini file, something inside REACT changes?
* With DEBUG=1, I also made the following changes to the CFG file, and I'm now running reliably:

At the top:
Quote
rem ECHO OFF
rem CHCP 1252


(My guess: echo off doesn't matter. But for some reason, the CHCP command still hangs a lot)

Quote
IF @Debug@==1 (
rem   PAUSE
rem   EXIT
)

REM ** Cleanup

DEL "@source@"
rem DEL "@eaclog@"
DEL "@cuesheet@"
DEL "@albumfile@.
  • .cue"
    DEL "@cover@"

    REM ** Delete this .bat file:
    DEL %0

(I like to preserve the log files, particularly when there's trouble...)
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-06 19:14:48
I have noticed that my REACT_track.cfg differs from ones others have posted on this thread in that mine has the cover embedding actions under each individual file format heading whereas other posts show a single mention under Post-processing.
I'm not really au fait with album art practices, but it sounds like it is being embedded, but just in a way that MP3Tag is not expecting.  That said, I find that difficult to believe.  As an experiment you could try processing an album both embedding and not embedding the file and see if the resulting files are the same size or not.  Not much help I'm afraid; I mainly posted to say that your track cfg sounds fine - each section should have a "IF %embed_cover%==1 SET Cover_tag" line.

I went beack to ssb15... seemed to work better...but still not fully reliable.
I find it hard to believe that b15 should perform any different to b16 - the changes were with the GUI.

* If I leave DEBUG off, the batch file never runs. Is it possible that with DEBUG=1 in the ini file, something inside REACT changes?
I would have said that it does run, but exits so fast you don't see it.  Just a guess.

* With DEBUG=1, I also made the following changes to the CFG file, and I'm now running reliably:

At the top:
Quote
rem ECHO OFF
rem CHCP 1252

(My guess: echo off doesn't matter. But for some reason, the CHCP command still hangs a lot)
Hmm.. seems like CHCP is your problem, from what you've said, but I have no idea why.  If so you should be able to run the normal cfg not in debug mode, by just commenting out the CHCP line.
Title: REACT 2 Released
Post by: big_red on 2007-08-06 22:12:02
[quote name='Synthetic Soul' date='Aug 6 2007, 19:14' post='508772']
[quote name='big_red' post='508706' date='Aug 6 2007, 13:37']I have noticed that my REACT_track.cfg differs from ones others have posted on this thread in that mine has the cover embedding actions under each individual file format heading whereas other posts show a single mention under Post-processing.[/quote]I'm not really au fait with album art practices, but it sounds like it is being embedded, but just in a way that MP3Tag is not expecting.  That said, I find that difficult to believe.  As an experiment you could try processing an album both embedding and not embedding the file and see if the resulting files are the same size or not.  Not much help I'm afraid; I mainly posted to say that your track cfg sounds fine - each section should have a "IF %embed_cover%==1 SET Cover_tag" line.

Thanks for the advice and confirmation of my cfg file Synthetic Soul.
School boy error on my part, I hadn't set the directory in my new install of EAC so Coverdownloader was saving the image in one location and REACT was looking for it in another. All sorted now and working wonderfully.

Cheers,
Title: REACT 2 Released
Post by: big_red on 2007-08-07 23:07:29
Ripping is going well except for a small problem where the EAClog is not copied to the track directory and then the cover art and the EAClog are not deleted from the temp directory.

I have run debug and have noticed that the numtracks value is always at 0.  The track value however represents the correct track number.  Therefore because of the line:

Code: [Select]
IF NOT @track@==@numtracks@ GOTO end_post_process


REACT never runs post processes and therefore does not copy the EAClog or delete the temp files.

Is there something in EAC or REACT that I need to set to get it to pass the numtracks value?

I can work around it by simply moving the files after I have ripped a CD but I'm sure I must have missed something.

Thanks for any help
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-08 07:17:34
The number of tracks is passed in the parameters to REACT, using EAC's %x token.

Ensure that your command line options are as below:

Code: [Select]
REACT %o %s %d "%a" "%g" "%t" "%n" "%x" "%y" "%m" "%e" "%f" "%b" %r

... or maybe Hit Ctrl+F2 to let REACT reconfigure EAC.
Title: REACT 2 Released
Post by: big_red on 2007-08-08 15:01:47
The number of tracks is passed in the parameters to REACT, using EAC's %x token.

Ensure that your command line options are as below:

Code: [Select]
REACT %o %s %d "%a" "%g" "%t" "%n" "%x" "%y" "%m" "%e" "%f" "%b" %r

... or maybe Hit Ctrl+F2 to let REACT reconfigure EAC.


Thanks, "%x" is listed. I did have REACT configure EAC on installation and it does not load the numtracks info when using EAC095pb3.  I have just tried using EAC099pb1 and this does pass the numtracks info but it is unable to find the "@eaclog@" file.
Looking at the file names I can see that the log file created is "artist - album.log" whereas debug states that it can not find "album.log"
Where can I configure what the log file is to be named?

Thanks for the help, sorry if these are basic or stupid questions.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-08 20:13:21
What version of REACT are you using?

It sounds like you may need to upgrade to my mod (http://wiki.hydrogenaudio.org/index.php?title=REACT:Mods#Synthetic_Soul.27s_Mod) (the official REACT,  2.0.1 (?), has not been upgraded to deal with the change in log file name with 0.99 prebeta 1 - my mod has).

Edit: Hmmm... I see in post 548 you say you are using 2.0.ssb16 - my latest mod.  Another idea may be that the log file just has not been created yet.  Maybe you should add the code in this article (http://wiki.hydrogenaudio.org/index.php?title=REACT%3a%50ausing_For_The_Logfile) to your CFG.
Title: REACT 2 Released
Post by: big_red on 2007-08-08 20:57:11
Edit: Hmmm... I see in post 548 you say you are using 2.0.ssb16 - my latest mod.  Another idea may be that the log file just has not been created yet.  Maybe you should add the code in this article (http://wiki.hydrogenaudio.org/index.php?title=REACT%3a%50ausing_For_The_Logfile) to your CFG.

Excellent, all working as sweet as a nut now.  Thanks for all the help and for the mods it is much appreciated.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-08 21:14:27
Excellent, all working as sweet as a nut now.  Thanks for all the help and for the mods it is much appreciated.
Cool and the Gang.  You're welcome. 

As I posted before, I have created two new CFGs which include that addition, and a few others (TAK processing, disc-related tags, "&" bug fix), which I will include with my mod releases from now on.  There's no reason why any of the amends should <edit>not</edit> (  ) be included - it's a win/win thing.
Title: REACT 2 Released
Post by: big_red on 2007-08-08 21:25:22
Thanks again, It is a lot quicker with REACT 2 not having to use different programs for different tasks.
I've tried to get EAC095pb3 to pass the numtracks info to REACT but with no success but EAC099pb1 is cooking on gas.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-10 21:25:31
I've been doing a little work on a couple of points raised by deltadave, and I'm looking for some feedback.

1. Amending the meta.ini system so that values are stored separately for each disc, so that the mod can be used with the Compression Queue.

deltadave highlighted an issue in b15 where the additional meta data (AMD) stored in meta.ini was reset when a new disc was inserted, even though the previous disc was still being processed.  This was fixed in b16 - meta.ini is now only updated just before a disc is ripped.

However, storing the AMD in the same place for every disc still means that b16 cannot be used with the Compression Queue.

I have done some testing, storing the AMD for a disc under the freedb id for the disc, allowing multiple sets to be stored.  To calculate the freedb id before ripping I am creating a cuesheet, extracting the freedb id, and then deleting it - unless CreateAllCuesheets is set in which case I extract it from one of those.  This appears to work OK, although I would like an easier/faster way to get the freedb id before ripping.

I'm a little concerned about the extra overhead and complication of doing this, for the majority of users who don't use the Compression Queue.  I have wondered whether this behaviour could be set with a react.ini setting, e.g.: CompressionQueue=1.

2. Allowing the user to specify whether a token, or all tokens, should not be reset to its default value when a new disc is inserted.

Currently, all tokens are reset to their default values when a new disc is inserted.  I have been looking at ways for users to change this behaviour on a per-token basis.

Unfortunately for me, the way the current system works cannot easily be changed to cope with this.

However, this has led me to think about the AMD dialogue, and question the logic of the current set-up.  Currently the dialogue will let users add, amend and delete tokens.  Does it need to?  Given that you need to amend your CFG to deal with tokens, it's not as if you create new tokens on the spur of the moment - the correct process is to set the default in react.ini and amend your CFG to deal with the token.  It seems to me that you only need to amend token values in the dialogue.  If no-one can suggest otherwise, then it  seems that the dialogue needs a complete revamp. Any suggestions welcome.
Title: REACT 2 Released
Post by: poop on 2007-08-12 08:53:32
I'm sure I have read the answer to this before, but can't find it again...

I use React2 to rip to FLAC and MP3. Album art is embedded for MP3 files, but for FLAC there is a JPEG created called 'folder'.

SO now you're all shaking your heads because you know what I'm about to ask... and I have mine hung in shame... 

How do I ensure that the album art is named specific to artist/album? Can I embed album art into FLAC files the same as MP3?

Thanks.



And sorry... 
Title: REACT 2 Released
Post by: deltadave on 2007-08-12 18:07:03
I've been doing a little work on a couple of points raised by deltadave, and I'm looking for some feedback.

1. Amending the meta.ini system so that values are stored separately for each disc, so that the mod can be used with the Compression Queue.

deltadave highlighted an issue in b15 where the additional meta data (AMD) stored in meta.ini was reset when a new disc was inserted, even though the previous disc was still being processed.  This was fixed in b16 - meta.ini is now only updated just before a disc is ripped.

However, storing the AMD in the same place for every disc still means that b16 cannot be used with the Compression Queue.

I have done some testing, storing the AMD for a disc under the freedb id for the disc, allowing multiple sets to be stored.  To calculate the freedb id before ripping I am creating a cuesheet, extracting the freedb id, and then deleting it - unless CreateAllCuesheets is set in which case I extract it from one of those.  This appears to work OK, although I would like an easier/faster way to get the freedb id before ripping.

I'm a little concerned about the extra overhead and complication of doing this, for the majority of users who don't use the Compression Queue.  I have wondered whether this behaviour could be set with a react.ini setting, e.g.: CompressionQueue=1.


Is there a reason that you have to look up the freedbid before ripping begins?  Isn't that when the AMD tags are committed?  Why not use the cfg file to echo any values added into a file named with the freedbid using the output redirect (>) operator - ie echo @freedbid@ > @outroot@\@freedbid@.amd  Following that up with an append operator (>>) for any further metadata for that album.

How does EAC know when to do a compression queue? is that switch accessible to react?

2. Allowing the user to specify whether a token, or all tokens, should not be reset to its default value when a new disc is inserted.

Currently, all tokens are reset to their default values when a new disc is inserted.  I have been looking at ways for users to change this behaviour on a per-token basis.

Unfortunately for me, the way the current system works cannot easily be changed to cope with this.

However, this has led me to think about the AMD dialogue, and question the logic of the current set-up.  Currently the dialogue will let users add, amend and delete tokens.  Does it need to?  Given that you need to amend your CFG to deal with tokens, it's not as if you create new tokens on the spur of the moment - the correct process is to set the default in react.ini and amend your CFG to deal with the token.  It seems to me that you only need to amend token values in the dialogue.  If no-one can suggest otherwise, then it  seems that the dialogue needs a complete revamp. Any suggestions welcome.


I agree, amending values is probably the right way to do it. I'd also like to recommend that in addition to hitting the 'update' button in the dialog, tabbing thru or using enter to commit the value also be valid methods of committing the tag data.  I know it's a nitpick, but its also an interface behavior standard.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-12 19:11:31
I'm sure I have read the answer to this before, but can't find it again...

I use React2 to rip to FLAC and MP3. Album art is embedded for MP3 files, but for FLAC there is a JPEG created called 'folder'.

SO now you're all shaking your heads because you know what I'm about to ask... and I have mine hung in shame... 

How do I ensure that the album art is named specific to artist/album? Can I embed album art into FLAC files the same as MP3?
I'm presuming that you are using REACT-track.cfg.

If you are embedding the artwork in yor MP3s you should already successfully be embedding it in your FLACs as well.  You could use metaflac, or possibly MP3Tag, to test.

To change the name of the JPEG replace the following line in the FLAC section of the CFG:

Code: [Select]
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg

... with:

Code: [Select]
IF %have_cover%==1 IF NOT EXIST "$artist$ - $album$.jpg" COPY "@cover@" "$artist$ - $album$.jpg"

... or something similar.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-12 20:13:55
Is there a reason that you have to look up the freedbid before ripping begins?  Isn't that when the AMD tags are committed?  Why not use the cfg file to echo any values added into a file named with the freedbid using the output redirect (>) operator - ie echo @freedbid@ > @outroot@\@freedbid@.amd  Following that up with an append operator (>>) for any further metadata for that album.

How does EAC know when to do a compression queue? is that switch accessible to react?
The AMD gets written just prior to ripping by the wrapper instance of REACT, and is read just prior to running the batch file by the processing instance of REACT.  The processing instance is not run until the queue is activated.  The wrapper instance has no access to the @freedbid@ token, as that is part of the processing phase.

It's possible that I could use REACT to check whether the queue is active, but that would involve opening the dialgue and checking the state of the checkbox - yet more screen flickering, time, and risk of going wrong - which is my concern with creating this temporary cuesheet...  it's an idea though.

 
I agree, amending values is probably the right way to do it. I'd also like to recommend that in addition to hitting the 'update' button in the dialog, tabbing thru or using enter to commit the value also be valid methods of committing the tag data.  I know it's a nitpick, but its also an interface behavior standard.
Yes, if it's just updating I am basically planning to turn to simple text boxes - which should hopefully give us normal Windows form behaviour.  AutoIt's GUI authoring is not as good a Visual Studio (I am disappointed that using the keyboard only is not properly supported by the current dialogue).  My intention would be, as soon as a user exists a text box that value would be recorded.
Title: REACT 2 Released
Post by: deltadave on 2007-08-12 22:06:54
The wrapper instance is very limited in the data it has access to, which is why you would like a command line way of getting the freedbid.  That also brings up the question of what to do if a disc isn't in the freedb database.  It sounds as if we should lobby the EAC developer(s) to make more hooks available since the data is acquired prior to ripping by EAC.  Hmmmm, will have to ponder this.

I've also noticed a weird behavior in REACT - the longer that the program is open and working there builds up a delay between inserting the disc and displaying the track information.  When freshly opened, and a disc is inserted the track data shows up almost immediately after the freedb query is complete.  If REACT has been open several hours it can take 20-30 seconds to show and after a day or so, can be almost a minute.  The workaround has been to periodically restart REACT, but I thought I would share this with you.
Title: REACT 2 Released
Post by: poop on 2007-08-13 04:17:32
If you are embedding the artwork in yor MP3s you should already...


Thanks Synthetic Soul. Now that I have worked it out, I realised that Foobar won't recognise album art unless called 'folder.jpeg', which is why I didn't do it the first time.

Have checked FLAC files with Abander Tag Control, and still no embedded album art. Might have to check with metaflac in case, because if the album art is embedded it should solve all my issues (provided foobar sees it). Strange that it is working for my MP3s coded at the same time though...

Thanks again.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-13 08:00:02
The wrapper instance is very limited in the data it has access to, which is why you would like a command line way of getting the freedbid. That also brings up the question of what to do if a disc isn't in the freedb database. It sounds as if we should lobby the EAC developer(s) to make more hooks available since the data is acquired prior to ripping by EAC.
That's right; it basically has access to the album-level meta data entered in the main EAC GUI (artist, album, date, genre) and the additional meta data (AMD). And thn of course it can execute EAC menu commands to achieve its goals (like creating cuesheets, or starting the rip process).

I don't think it should matter if the disc isn't in the database, there will still be a freedb id (just no matching id in the database).  It would be nice to have an easy way to get the id.

FYI there is another way I found to get the freedb id, which is to export the disc data to a DB text file, ensuring that the settings (freedb / Database options > Export) are such that the freedb id is included.  However, this process is no less simple than creating a cuesheet, and requires that the user's EAC settings are tampered with (and maintained), so I still favour the cuesheet approach.

I've also noticed a weird behavior in REACT - the longer that the program is open and working there builds up a delay between inserting the disc and displaying the track information. When freshly opened, and a disc is inserted the track data shows up almost immediately after the freedb query is complete. If REACT has been open several hours it can take 20-30 seconds to show and after a day or so, can be almost a minute. The workaround has been to periodically restart REACT, but I thought I would share this with you.
IIRC I have heard of other people having problems after running REACT for a while.  I can't think what might be going on; certainly nothing that would make a difference of almost a minute!  I guess AutoIt, or the REACT code, is doing something wrong.
Title: REACT 2 Released
Post by: big_red on 2007-08-15 14:07:33
Having a problem when creating Various Artists.  The EAClog is not copied to the Music Directories or deleted.  All is great for Single Artists.

I can see the EAClog text file saved as 'Various - $album$.txt' in the Temporary Directory specified in EAC. 
When I debug I see that REACT is looking in the same Temporary Directory but for a file named '$artist$ - $album$.txt' where $artist$ is the artist's name of the final track of the CD.  So REACT states that it can not find the specified file.

What have I done wrong?  I have tried replacing the standard copy with  COPY /Y "C:\Temp Music\Various - $album$.txt$" "Various Artists - $album$ - EAClog.txt"    but with no success.

Any help appreciated.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-15 15:14:17
Here's a hastily bugfixed b16b (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16b.zip).

When ripping to tracks the log file was set as "$artist$ - $album$".

IIRC, from past issues with REACT, EAC will not always pass "Various" as the CD artist for VA albums - it depends on the freedb submission.  Sometimes it's "Various", sometimes its "Various Artists" - IIRC the submission has to begin with "Various" for EAC to pick it up as a VA album - users sometimes submit using something else!

EDIT: NB: I Just searched and found the original discussion (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=35158&view=findpost&p=441451).  It's pretty convoluted, but documents the time that we discovered how EAC deals with VA freedb entries.

With this in mind this fix grabs the CD Artist from the basename string when dealing with a VA album ripped to tracks - hopefully ensuring that it will match EAC's naming scheme (whether the freedb entry has used "Various", "Various Artists", "Various Artist", or "Various Badgers").

Please let me know how it goes.

NB: I used b16b as I'm part way through b17 (see my post on Aug 10).
Title: REACT 2 Released
Post by: big_red on 2007-08-15 15:46:12
Here's a hastily bugfixed b16b (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16b.zip).

When ripping to tracks the log file was set as "$artist$ - $album$".

IIRC, from past issues with REACT, EAC will not always pass "Various" as the CD artist for VA albums - it depends on the freedb submission.  Sometimes it's "Various", sometimes its "Various Artists" - IIRC the submission has to begin with "Various" for EAC to pick it up as a VA album - users sometimes submit using something else!  (Just searched and found the original discussion (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=35158&view=findpost&p=443449) (that is a concluding post, you can read before and after for a greater understanding)).

With this in mind this fix grabs the CD Artist from the basename string when dealing with a VA album ripped to tracks - hopefully ensuring that it will match EAC's naming scheme (whether the freedb entry has used "Various", "Various Artists", "Various Artist", or "Various Badgers").

Please let me know how it goes.

NB: I used b16b as I'm part way through b17 (see my post on Aug 10).


Thanks, I thought I was going mad.  I shall give b16b a try tonight and let you know.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-15 15:49:41
Thanks, I thought I was going mad.  I shall give b16b a try tonight and let you know.
Disclaimer: I cannot promise that REACT 2.0.ssb16b (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16b.zip) will stop you from going mad.

If you're backing up a large catalogue of CDs you're probably too far gone...
Title: REACT 2 Released
Post by: big_red on 2007-08-15 17:11:44
Thanks, I thought I was going mad.  I shall give b16b a try tonight and let you know.
Disclaimer: I cannot promise that REACT 2.0.ssb16b (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16b.zip) will stop you from going mad.

If you're backing up a large catalogue of CDs you're probably too far gone...


You're probably right, in fact more than probably!!

I tried ssb16b and it did copy the log file and the cover art to the music directory but my (much alterered as I tried to get it to copy the log file last night) REACT-track.cfg copied the log file with the same $artist$ name as the same as the artist name as the final track of the CD and I had cover art for every artist on the CD.

I added the following lines in stead of the standard ones and all appears good.

Code: [Select]
        IF @various@==1 GOTO end_SA_Cover
            IF %have_cover%==1 IF NOT EXIST "$artist$ - $album$ - Cover.jpg" COPY "@cover@" "$artist$ - $album$ - Cover.jpg"
        :end_SA_Cover
        IF @various@==0 GOTO end_VA_Cover
            IF %have_cover%==1 IF NOT EXIST "Various Artists - $album$ - Cover.jpg" COPY "@cover@" "Various Artists - $album$ - Cover.jpg"
        :end_VA_Cover


Code: [Select]
            IF @various@==1 GOTO end_SA_EAClog
                COPY /Y "@eaclog@" "$artist$ - $album$ - EAClog.txt"
            :end_SA_EAClog
            IF @various@==0 GOTO end_VA_EAClog
                COPY /Y "@eaclog@" "Various Artists - $album$ - EAClog.txt"
            :end_VA_EAClog


So I am working now so thanks very much
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-15 17:22:48
My brain's a bit fried, and it looks like you're pretty much sorted anyway, but it looks to me like you could simply use $cdartist$ instead of $artist$, with no decision making necessary.  For VA albums $cdartist$ will return the value of the VA variable set in your REACT.ini, which defaults to "Various Artists".

Therefore, for a VA album "$cdartist$ - $album$" should give you "Various Artists - $album$" while a non-VA will still equate to "$artist$ - $album$" (cdartist == artist) .

Code: [Select]
IF %have_cover%==1 IF NOT EXIST "$cdartist$ - $album$ - Cover.jpg" COPY "@cover@" "$cdartist$ - $album$ - Cover.jpg"

Code: [Select]
COPY /Y "@eaclog@" "$cdartist$ - $album$ - EAClog.txt"
Title: REACT 2 Released
Post by: big_red on 2007-08-15 17:45:26
My brain's a bit fried, and it looks like you're pretty much sorted anyway, but it looks to me like you could simply use $cdartist$ instead of $artist$, with no decision making necessary.  For VA albums $cdartist$ will return the value of the VA variable set in your REACT.ini, which defaults to "Various Artists".

Therefore, for a VA album "$cdartist$ - $album$" should give you "Various Artists - $album$" while a non-VA will still equate to "$artist$ - $album$" (cdartist == artist) .

Code: [Select]
IF %have_cover%==1 IF NOT EXIST "$cdartist$ - $album$ - Cover.jpg" COPY "@cover@" "$cdartist$ - $album$ - Cover.jpg"

Code: [Select]
COPY /Y "@eaclog@" "$cdartist$ - $album$ - EAClog.txt"


Yeah, I see it now.  I shall change it to cdartist.
Title: REACT 2 Released
Post by: pholzmann on 2007-08-19 00:05:04
I went beack to ssb15... seemed to work better...but still not fully reliable.
I find it hard to believe that b15 should perform any different to b16 - the changes were with the GUI.

Understand, but there it is. I have reason to suspect the GUI is interacting with other windows in various "wait for XYZZY to happen" ways... see below. I'll try ssb17 when it's ready...

Quote
* If I leave DEBUG off, the batch file never runs. Is it possible that with DEBUG=1 in the ini file, something inside REACT changes?
I would have said that it does run, but exits so fast you don't see it.  Just a guess.

Nope. The batch file *hangs*. I should not have said "never runs". I mean, it opens, and hangs immediately.

ANYway... I've been running for a while now, on my patched ssb15, and have learned some things. I found workarounds for everything until now...

1) If I begin an F10 whole-disk capture (I'm capturing single-file FLAC plus multi-file MP3), and then something goes wrong so I have to cancel:
  a) If I cancel during gap-finding, I can restart with no problem
  b) If I cancel later, I need to restart REACT

2) After performing several rips, the albumart software does not fire up the first time I press F10. If I wait for the gap-find to complete, wait another minute or two, then press F10 again, it goes forward. I think this relates to the comment elsewhere in this thread about REACT slowing down after many rips.

  a) Idea: could it be NOT fully resetting after the CD is removed and/or while firing up the next Rip? I'm guessing that something is waiting for a window to complete or close or ???

  b) It would help to have a keystroke that does a "full reset-- restart REACT as if just opened"... for those strange error situations

3) It's not clear to me what REACT knows or does with respect to the AccurateRip database, and/or when a rip is unsuccessful.

QUESTIONS:
  - How does REACT decide whether a RIP was completed successfully?
    a) If I stop the RIP, I want REACT to not-process
    b) If I let the RIP complete, if REACT thinks there was a problem, it should ask me about continuing, rather than auto-killing. It is hard for REACT to know for sure if things worked or not!
        - on a C2 drive like mine, "timing error" is not a problem, usually... just means some retries happened
        - it's possible to have AccurateRip tell me the rip was "bad" when it isn't. I just ripped a CD that's perfect, but it's a different pressing than the 2 copies in the DB. It worked, but AccurateRip doesn't know that.
    c) In the case of this good-but-AR-thinks-not, I get the following result
        - Full rip to wav
        - REACT skips making the FLAC file
        - But the MP3 files ARE created
        - I get no indication of error or trouble... just missing flac file(s)!

Your thoughts on this last one especially appreciated. I can't get REACT to make the flac file! No error messages, it just doesn't do it.

Thanks muchly,
MrPete
Title: REACT 2 Released
Post by: dobo on 2007-08-19 00:29:29
Thought i'd report that React 2 16b + EAC0.99pb3 & Accuraterip + Album Art Downloader 0.8 all seems to work together just fine ripping to Wavpack and mp3.

Thanks to all thats made this possible.
Title: REACT 2 Released
Post by: pholzmann on 2007-08-19 02:13:17
Update:
QUESTIONS:
    c) In the case of this good-but-AR-thinks-not, I get the following result
        - Full rip to wav
        - REACT skips making the FLAC file
        - But the MP3 files ARE created
        - I get no indication of error or trouble... just missing flac file(s)!

Your thoughts on this last one especially appreciated. I can't get REACT to make the flac file! No error messages, it just doesn't do it.


SOLVED that one... Very strange. Turns out the album art downloader found a GIF file, saved as JPG, and got everything confused. Resaving as a real JPG fixed the flac process. All other questions do remain...

thx
Title: REACT 2 Released
Post by: mogorp on 2007-08-19 13:58:43
I haven't been following this since the new version of EAC came out.  Is there a command to get REACT to use the new test and copy image function?
Title: REACT 2 Released
Post by: 288db on 2007-08-19 16:14:12
I haven't been following this since the new version of EAC came out.  Is there a command to get REACT to use the new test and copy image function?


Yes.  You would add Test=1 to the react.ini file and use F10 as the image hotkey.  It would look like below:
Code: [Select]
[Settings]
Version=2.0.ssb16b
ImageExt=flac
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F6}
Test=1
.....


I'm using EAC .99 prebeta 3 and REACT 2.0.ssb16b.
Title: REACT 2 Released
Post by: Stone Free on 2007-08-19 18:10:08
I had been using the b10 version of the mod and when I tried to rip a various artists CD from the Uni Bands society for a bit of nostalgia, I found the .FLAC track rips only contained the track numbers and the dash character but no band or title.

The tracks are titled Song - Artist, and the CD Artist says Various and the Various Artists checkbox is ticked

I have just tried upgrading to beta 16, but this has not fixed the issue.

Here is my track cfg file:

Code: [Select]
@ECHO OFF
CHCP 1252
TITLE @track@/@numtracks@ - "@album@"
REM Copyright © Tycho, 2006
REM
REM ** Create compressed audio tracks from ripped .wav tracks.
REM **
REM ** You may consider using image mode (F10)
REM ** as it supports creating tracks via acdir.exe,
REM ** and post-processing will always work (see below).
REM **
REM ** Flac requires flac.exe/metaflac.exe (v1.1.3)
REM ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
REM ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.
REM **
REM ** I prefer applying album gain 92dB to get a reasonable
REM ** volume for my DAP. The RG tags are still relative
REM ** to 89dB SPL, i.e. album gain will be about -3.0dB.


REM ============== Begin Main Script ==================


IF @Debug@==1 ECHO ON

SET TrackDir_Flac="@TrackDir_Flac@"
SET TrackDir_Wavpack="@TrackDir_Wavpack@"
SET TrackDir_MP3="@TrackDir_MP3@"
SET TrackDir_AAC="@TrackDir_AAC@"
SET TrackDir_OGG="@TrackDir_OGG@"

IF @various@==0 SET TrackName=@TrackName_SA@
IF @various@==1 SET TrackName=@TrackName_VA@

SET realNumTracks=@numtracks@
IF [@datadisc@] EQU [1] SET /a realNumTracks=@numtracks@-1

SET have_cover=0
SET embed_cover=0

IF EXIST "@cover@" (
SET have_cover=1
SET embed_cover=@EmbedCover@
)

REM ---- Track ----


IF NOT @Flac@==1 GOTO end_flac_tracks
IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
PUSHD %TrackDir_Flac%
IF @various@==1 SET VA_tag=-T "album artist=@VA@"
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
ECHO ON
@tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T

album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T

genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@

@Opt_Flac@" "@source@" -o "%TrackName%.flac"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_flac_tracks


IF NOT @Wavpack@==1 GOTO end_wavpack_tracks
IF NOT EXIST %TrackDir_Wavpack% MKDIR %TrackDir_Wavpack%
PUSHD %TrackDir_Wavpack%
IF @various@==1 SET VA_tag=-w "album artist=@VA@"
ECHO ON
@tools@\wavpack.exe @Opt_Wavpack@ %VA_tag% -w artist="@artist@" -w album="@album@" -w

track="@track@/@numtracks@" -w title="@title@" -w year="@year@" -w genre="@genre@" -w

comment="@comment@" -w encodedby="%USERNAME%" -w encodersettings="Wavpack @Ver_Wavpack@

@Opt_Wavpack@" "@source@" "%TrackName%.wv"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
TITLE @track@/@numtracks@ - "@album@"
POPD
:end_wavpack_tracks


IF NOT @LameMP3@==1 GOTO end_lame_tracks
IF NOT EXIST %TrackDir_MP3% MKDIR %TrackDir_MP3%
PUSHD %TrackDir_MP3%
IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"
IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"
ECHO ON
@tools@\lame.exe @Opt_LameMP3@ "@source@" "%TrackName%.mp3"
@tools@\metamp3.exe %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@"

--track @track@/@numtracks@ --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@"

--frame TENC:"%USERNAME%" --frame TSSE:"LAME @Ver_LameMP3@ @Opt_LameMP3@" "%TrackName%.mp3"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_lame_tracks


IF NOT @iTunesAac@==1 GOTO end_itunes_aac_tracks
IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
PUSHD %TrackDir_AAC%
IF %embed_cover%==1 SET Cover_tag=-r "@cover@"
ECHO ON
@tools@\iTunesEncode.exe @Opt_iTunesAac@ -e "AAC Encoder" %Cover_tag% -x @various@ -a

"@artist@" -l "@album@" -n "@track@" -m "@numtracks@" -t "@title@" -y "@year@" -g "@genre@" -c

"@comment@" -i "@source@" -o "%TrackName%.m4a"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
GOTO end_nero_aac_tracks
:end_itunes_aac_tracks

IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
PUSHD %TrackDir_AAC%
IF @various@==1 SET VA_tag=--albumArtist "@VA@" --compilation true
IF %embed_cover%==1 SET Cover_tag=--artwork "@cover@"
ECHO ON
@tools@\neroAacEnc.exe @Opt_NeroAac@ -if "@source@" -of "%TrackName%.m4a"
@tools@\AtomicParsley.exe "%TrackName%.m4a" -o REACT_tmp.m4a %Cover_tag% %VA_tag%

--artist "@artist@" --album "@album@" --tracknum "@track@/@numtracks@" --title "@title@" --year

"@year@" --genre "@genre@" --comment "@comment@" --encodingTool "neroAacEnc @Ver_NeroAac@

@Opt_NeroAac@"
@ECHO OFF
MOVE /Y REACT_tmp.m4a "%TrackName%.m4a"
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_nero_aac_tracks


IF NOT @OggEnc2@==1 GOTO end_oggenc_tracks
IF NOT EXIST %TrackDir_OGG% MKDIR %TrackDir_OGG%
PUSHD %TrackDir_OGG%
IF @various@==1 SET VA_tag=-c "album artist=@VA@"
ECHO ON
@tools@\oggenc2.exe @Opt_OggEnc2@ %VA_tag% -c artist="@artist@" -c album="@album@" -c

tracknumber="@track@/@numtracks@" -c title="@title@" -c date="@year@" -c genre="@genre@" -c

comment="@comment@" -c encoded-by="%USERNAME%" -c encoding="OggEnc @Ver_OggEnc2@ @Opt_OggEnc2@"

"@source@" -o "%TrackName%.ogg"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_oggenc_tracks
IF @Debug@==1 ECHO ON

REM ** Delete the source .wav
DEL "@source@"


REM ---- Post-processing ----


rem ** Scan and compute ReplayGain and add cover picture for supported formats.
rem ** NB: The following will only work if at least the last track is selected,
rem ** and it is a regular audio track.

rem IF NOT @track@==@numtracks@ GOTO end_post_process
IF [@track@] NEQ [%realNumTracks%] GOTO end_post_process

SET add_rg=@ReplayGain@
SET aac_enc=@NeroAac@
IF @iTunesAac@==1 SET aac_enc=1

IF NOT @ReplayGain@==1 GOTO end_RG
SET RG_MetaFlac=--add-replay-gain
SET RG_MetaMP3=--replay-gain
:end_RG

IF NOT @ApplyAlbumGain@==1 GOTO end_apply_AG
SET RG_MetaMP3=--apply-gain album@AdjustAlbumGain_dB@
SET RG_AacGain=/a /o /c /d @AdjustAlbumGain_dB@
SET add_rg=1
:end_apply_AG


REM ** Audio Formats:

IF @Flac@==1 (
PUSHD %TrackDir_Flac%
IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac%

*.flac
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF @Wavpack@==1 (
PUSHD %TrackDir_Wavpack%
IF %add_rg%==1 @tools@\wvgain.exe -a *.wv
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF @LameMP3@==1 (
PUSHD %TrackDir_MP3%
IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF %aac_enc%==1 (
PUSHD %TrackDir_AAC%
IF %add_rg%==1 @tools@\aacgain.exe %RG_AacGain% *.m4a > "gainlog.txt"
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF @OggEnc2@==1 (
PUSHD %TrackDir_OGG%
IF %add_rg%==1 @tools@\vorbisgain.exe -a *.ogg
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)


REM ** Cleanup

DEL "@eaclog@"
DEL "@albumfile@.[*].cue"
DEL "@cover@"

:end_post_process


REM ================ End Main Script ===================


IF @Debug@==1 (
PAUSE
EXIT
)

REM ** Delete this .bat file:
DEL %0
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-19 19:08:45
Added CODEBOX tags added to your post.  Can you post your INI file using CODEBOX tags please?

Also, try adding DebugMode=1 in the UserSettings section of REACT.ini, and then posting the contents of debugging.txt which will be created in your REACT folder (again, using CODEBOX).
Title: REACT 2 Released
Post by: Stone Free on 2007-08-19 19:26:32
OK Heres the .INI,

Code: [Select]
[Settings]
Version=2.0.ssb16b
ImageExt=flac
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F5}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=0
CoverDownloader=C:\Program Files\Audio\REACT2\coverdownloader\albumart.exe
EAC=C:\Program Files\Audio\Exact Audio Copy\EAC.exe
Tools=C:\Program Files\Audio\REACT2\tools
MinimizeCompressionWindow=1
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=0
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
;OutRoot=@mymusic@\EAC
OutRoot=D:\
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\CDs\$cdartist$\$album$
TrackDir_Wavpack=@OutRoot@\CDs\$cdartist$\$album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\[$year$] $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
TrackName_SA=$track$ - $title$
TrackName_VA=$track$ - $title$
TrackName_VA_acdir=$n - $~t [$~a]
TrackName_SA_acdir=$n - $~t


[UserSettings]
Debug=0
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=0
ApplyAlbumGain=1
AdjustAlbumGain_dB=+5.0
AddCuesheetAG=0
UseWaveGainAG=0
Opt_Flac=-8 -f
Opt_Wavpack=-hmy -c -b192 -n -x3
Opt_LameMP3=-V5 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.4
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5

[DefaultMetaData]
discnumber=1
totaldiscs=1
discname=

will come back to you with the debug output

Do I have to rip the entire disk to get debugging.txt because I see no text files generated?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-19 19:50:49
Yes, you do.

However, after re-reading your post, I am wondring about the part where you say "The tracks are titled Song - Artist", as the proper format for a VA disc is "Artist / Title".  This is likely to be your problem.
Title: REACT 2 Released
Post by: Stone Free on 2007-08-19 20:03:38
Yes, you do.

However, after re-reading your post, I am wondring about the part where you say "The tracks are titled Song - Artist", as the proper format for a VA disc is "Artist / Title".  This is likely to be your problem.
Well ripped entire album and still no debugging .txt

Code: [Select]
 POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>IF 0 == 1 (
PUSHD "D:\\MP3\Various Artists\[] Above & Beyond"
 IF 1 == 1 C:\PROGRA~1\Audio\REACT2\tools\metamp3.exe --apply-gain album+5.0 *.m
p3
 REM COPY /Y "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log" "EAClog.txt"
 POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>IF 0 == 1 (
PUSHD "D:\\AAC\Various Artists\[] Above & Beyond"
 IF 1 == 1 C:\PROGRA~1\Audio\REACT2\tools\aacgain.exe /a /o /c /d +5.0 *.m4a  1>
"gainlog.txt"
 REM COPY /Y "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log" "EAClog.txt"
 POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>IF 0 == 1 (
PUSHD "D:\\OGG\Various Artists\[] Above & Beyond"
 IF 1 == 1 C:\PROGRA~1\Audio\REACT2\tools\vorbisgain.exe -a *.ogg
 REM COPY /Y "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log" "EAClog.txt"
 POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>REM ** Cleanup

C:\Documents and Settings\Peter\My Documents\My Music>DEL "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log"

C:\Documents and Settings\Peter\My Documents\My Music>DEL "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.[*].cue"
Could Not Find C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.[*].cue

C:\Documents and Settings\Peter\My Documents\My Music>DEL "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.jpg"
Could Not Find C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.jpg

C:\Documents and Settings\Peter\My Documents\My Music>REM ================ End Main Script ===================

C:\Documents and Settings\Peter\My Documents\My Music>IF 1 == 1 (
PAUSE
 EXIT
)
Press any key to continue . . .
Will try swapping round artist and track and replacing - with /
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-19 20:11:43
I have reason to suspect the GUI is interacting with other windows in various "wait for XYZZY to happen" ways... see below. I'll try ssb17 when it's ready...
The AMD GUI does not rely on anything else.  I am undecided about releasing b17.  I don't think it would help you anyway.

2) After performing several rips, the albumart software does not fire up the first time I press F10. If I wait for the gap-find to complete, wait another minute or two, then press F10 again, it goes forward. I think this relates to the comment elsewhere in this thread about REACT slowing down after many rips.

a) Idea: could it be NOT fully resetting after the CD is removed and/or while firing up the next Rip? I'm guessing that something is waiting for a window to complete or close or ???

b) It would help to have a keystroke that does a "full reset-- restart REACT as if just opened"... for those strange error situations
This is definitely a concern, but I'm not sure that I'm in a position to do anything about it.  I can only assume that something isn't resetting, but it's a bit of a needle in a haystack, and the fact that I'd need to rip numerous discs to even begin testing is a little prohibitive.

I added the functionality in b15 (IIRC) to output text to a debug file (debugging.txt).  Maybe I could release a test version of REACT that wrote everything to the file, in the hope that it might highlight the problem when it occurs.

3) It's not clear to me what REACT knows or does with respect to the AccurateRip database, and/or when a rip is unsuccessful.

QUESTIONS:
- How does REACT decide whether a RIP was completed successfully?
a) If I stop the RIP, I want REACT to not-process
b) If I let the RIP complete, if REACT thinks there was a problem, it should ask me about continuing, rather than auto-killing. It is hard for REACT to know for sure if things worked or not!
- on a C2 drive like mine, "timing error" is not a problem, usually... just means some retries happened
- it's possible to have AccurateRip tell me the rip was "bad" when it isn't. I just ripped a CD that's perfect, but it's a different pressing than the 2 copies in the DB. It worked, but AccurateRip doesn't know that.
REACT knows nothing about the AR results, whether the rip matched well, etc.  EAC controls the running of REACT, so if REACT is running when you don't want it to, there's nothing REACT can do really.
Title: REACT 2 Released
Post by: 288db on 2007-08-19 20:24:01
This is resolved.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-19 22:33:34
I would like to start by saying thanks to all of those who have put an effort to making REACT work with no problems.  I have noticed that some people, like myself, would like to be able to update files such as flac.exe, metamp3.exe and etc.  Well I update acdir.exe to version .12 and have noticed that my flac image is no longer made.  All mp3 and flac tracks are made and copied to the correct directories, along with the cue and jpg file being copied to the image folder, but no flac image exists. I have ran a debug and noticed nothing out of the ordinary.  Any ideas?

REACT 2.0.ssb16b & EAC .99 prebeta 3.  Also there are problems when upgrading flac.exe and metaflac.exe to 1.2.0 and metamp3.exe will not tag mp3s.  I believe it has something to do with the commands being changed.  I will look more into those once I figure out acdir
I'm surprised that changing ACDIR has caused problems - especially with the FLAC image creation in which it plays no part.  I can also see no reason why you could not upgrade FLAC to the latest version, although I'm less sure about metamp3, as I'm not overly familiar with its syntax, or changes made.  I believe I am using the latest beta though, with no problems or changes required.

All in all, I have no idea, sorry.
Title: REACT 2 Released
Post by: pholzmann on 2007-08-20 01:41:56
REACT knows nothing about the AR results, whether the rip matched well, etc.  EAC controls the running of REACT, so if REACT is running when you don't want it to, there's nothing REACT can do really.


THANK YOU! Now I feel pretty dumb. It just clicked: there's the "outer" REACT that drives the UI, and the post-rip REACT that gets called as a compressor.

I think understanding my "album-art-JPG are not really jpg files" problem has cleaned up most if not all remaining anomalies. And that is decidedly NOT a REACT issue. Whew!

Thanks soooo much. This is getting smoother all the time.

I'll aim some of my more advanced debug tools at REACT to see if I can discover any hints about what is going wrong over a series of rips...

Until then,
THANKS!

--MrPete
Title: REACT 2 Released
Post by: pholzmann on 2007-08-20 12:03:44
OK, I've learned some more, and found a few things perhaps worth chewing on.

First, the CHCP command is necessary, for non-ASCII characters in filenames, like "Scott Denté" -- so I messed around with that a bit more. It's VERY strange on my (Win XP SP2, tablet edition) machine.
* It always locks up if I use "CHCP 1252" the first time a CMD window is opened
* It usually works ok if I use "CHCP 1252 | CHCP"    (but not always)

I'm suspecting that some of the MS Windows extensions in support of tablet PC's is causing grief

Second, if I abort the batch file (due to CHCP lockup or whatever), in EAC using Alt-V (compress WAV's), I can get REACT to create and run the appropriate batch file -- **almost**. The result is almost correct but not quite:
* For FLAC single-file output: the artist folder's not created; FLAC and CUE not placed correctly, JPG not copied.
* For MP3 file-per-track output: the artist folder is created as "[]" (or maybe no artist folder, and that's the album name?. Again, MP3's placed in the mp3 "root" (as with flac), and the JPG album art is not copied

Finally, and perhaps most useful: while monitoring REACT over an extended period using System internals' Filemon.exe app, I found REACT got into a continuous background loop trying to open the CUE file for one of my rips. Even after later rips had been done, it would continue to attempt to open this cue file. Perhaps that's the source of the slowdown.

*Possible* related topic: does REACT properly handle semi-overlapping operations? Here's my typical workflow:
* Run REACT
* Insert CD
* Press F10, let gap-finder complete, wait for AlbumArt to load
* Pick albumart; that app auto-closes
* now EAC starts ripping
* when rip complete, REACT batch file starts waiting for the log file
* press "OK" on EAC status messages; log gets auto-written
* now the REACT batch process begins
* eject CD
* Insert new CD, wait for FreeDB to load CD info
* Press F10 and continue

NOTE that I press F10 to begin ripping the next CD, *before* the batch file completes for the previous one.

Is there any reason this should cause grief?
Title: REACT 2 Released
Post by: pholzmann on 2007-08-20 14:16:32
Finally, and perhaps most useful: while monitoring REACT over an extended period using System internals' Filemon.exe app, I found REACT got into a continuous background loop trying to open the CUE file for one of my rips. Even after later rips had been done, it would continue to attempt to open this cue file. Perhaps that's the source of the slowdown.

*Possible* related topic: does REACT properly handle semi-overlapping operations?...


Update: definite correlation. REACT does not loop on CUE file-open attempts until I begin a new rip (F10) while the previous one is still running in EAC's "compression queue". As *soon* as I press F10, the loop-trying-to-open-CUE begins, and does not stop until I close REACT.

Also noted:

1) EAC supports the overlap quite nicely. It maintains a background compression queue, does not begin the next compression until the first one is done (I told it I only had a 2-cpu machine), etc.

2) I think I've found a satisfactory workaround for my CHCP problem. This works without lockup (so far):
        CHCP 1252|prompt

3) It would be helpful in general if the batch file could check return status from FLAC, LAME, etc... and not delete files needed to re-run when there's an error.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-20 14:32:23
The REACT code will go into a recurring loop if one of the track cuesheets (created by specifiying CreateAllCuesheets) is not found.  I could change this so that it gives up after a certain time.  When looking for the log file Tycho's code will try for a maximum of five seconds (20 loops waiting 0.25 seconds between each check) perhaps I should change his fMoveCuesheet() function to do the same.

Good find.

OK, just seen your next post.  No idea why it is happening.  Essentially the code sends key combinations to access EAC's menu commands to make all the types of cuesheet.  So, either the key commands are not being sent, or the cuesheets just aren't being created for some reason.

I know that b15 will have a problem with the meta data if you rip in the way you do, as the data held in meta.ini will be overwritten when you eject the disc.  This was fixed in b16.  As for the core REACT code, I cannot really say, although I can't think where an issue might happen.

At some point, when I get some time, I will go through all the source with a fine tooth comb, trying to ascertain whether the line may cause problems in this situation, or when ripping multiple discs.  The code in fMoveCuesheet() which will loop indefinately if the cueseet is not found is a prime example.  At this same time I may add huge numbers of debug statements, to create b16_debug, which will output KB of debug text, but could be used to try to fix these strange issues that a few people are seeing!
Title: REACT 2 Released
Post by: 288db on 2007-08-20 16:49:11
Well after upgrading flac, metaflac and acdir, everything went fine.  Once I replaced metamp3.exe with v092b5 things went wrong.  I have the flac, flac image and mp3s created, but no tagging for mp3s.  Problems arise at the start of creating the mp3s with metamp3.

Code: [Select]
TITLE 01/15 mp3 "The Singles 1992-2003" & C:\PROGRA~1\EXACTA~1\encoders\lame.exe
-V5 --vbr-new --noreplaygain --nohist  - "01 - Just a Girl.mp3" & C:\PROGRA~1\E
XACTA~1\encoders\metamp3.exe --pict "{3}C:\Users\Steve\Music\EAC\The Singles 199
2-2003.jpg"  --artist "No Doubt" --album "The Singles 1992-2003" --title "Just a
Girl" --track 01/15 --year "2003" --genre "Pop" --comment "FreedbID:CB0E000F" -
-frame TENC:"Steve" --frame TSSE:"LAME 3.97 -V5 --vbr-new --noreplaygain --nohis
t" "01 - Just a Girl.mp3"
LAME 3.97 32bits (http://www.mp3dev.org/)
CPU features: MMX (ASM used), 3DNow! (ASM used), SSE (ASM used)
Using polyphase lowpass filter, transition band: 15826 Hz - 16360 Hz
Encoding <stdin> to 01 - Just a Girl.mp3
Encoding as 44.1 kHz VBR(q=5) j-stereo MPEG-1 Layer III (ca. 11.9x) qval=3
'C:\PROGRA~1\EXACTA~1\encoders\metamp3.exe' is not recognized as an internal or
external command,
operable program or batch file.


I would post more from the debug, but I do not have a debug.txt file that was created.  I'm looking more into the problem, but hoping others might have an idea.  Thanks.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-20 17:00:31
It looks like it simply can't find metamp3.exe

Is it actually in "C:\Program Files\Exact Audio Copy\encoders"?  If not, either change the value of the "Tools" setting under "Settings" in your REACT.ini to point to the right place (normally "C:\Program Files\REACT2\tools"), or put metamp3 in "C:\Program Files\Exact Audio Copy\encoders".
Title: REACT 2 Released
Post by: 288db on 2007-08-20 17:08:29
Argh....it's fixed finally.  Jusdt rebooted and all works now.  Have to love computers. 
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-20 17:16:29
Maybe it's a runtime thing.  The metamp3 thread states:

You must have the vc sp1 redististributable runtime libraries to get it working. Get it from here:
http://www.apachelounge.com/download/vcredist_x86-sp1.exe (http://www.apachelounge.com/download/vcredist_x86-sp1.exe)

This may only be true for the beta.

Also, see this post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=49751&view=findpost&p=478005) from Martin H.  It may be worth reading on, in case things have changed.
Title: REACT 2 Released
Post by: pholzmann on 2007-08-21 02:56:33
The REACT code will go into a recurring loop if one of the track cuesheets (created by specifiying CreateAllCuesheets) is not found.  I could change this so that it gives up after a certain time.  When looking for the log file Tycho's code will try for a maximum of five seconds (20 loops waiting 0.25 seconds between each check) perhaps I should change his fMoveCuesheet() function to do the same.

Good find.

OK, just seen your next post.  No idea why it is happening.  Essentially the code sends key combinations to access EAC's menu commands to make all the types of cuesheet.  So, either the key commands are not being sent, or the cuesheets just aren't being created for some reason.


Update, now running ssb16b...

I'm not sure if this is normal or unexpected:
* When in this mode, REACT always looks for a "plain" Trackname.CUE file, but all the cue files are Trackname [something].cue

Good News! overlapping rips and compression works fine from the output perspective (i.e. all files in the right place, AFAIK.)

Medium News: I ripped four CD's in a row with no problem, and no CUE-loop! Unfortunately, on CD #5, FileMon says the CUElooper is back. Bleah.

BugFix Help Request: remember my problem with AlbumArt GIF/BMP downloading as JPG? Apparently, there's a setting I don't know how to set, in REACT:

At least with AlbumArt Downloader XUI, there's support for a target download file of
    Trackname.%extension%

i.e. if the track is "Strawberry Fields Forever", the AlbumArt request should be
    Strawberry Fields Forever.%extension%

but right now it is
    Strawberry Fields Forever.jpg

Where can I fix this?

Thx muchly!!!!

MrPete
Title: REACT 2 Released
Post by: pholzmann on 2007-08-21 04:35:13
By the way, this:

CHCP 1252 | PROMPT

...has proven reliable. I recommend making it part of the default cfg. Can't explain WHY chcp hangs sometimes without it, but it is a very real effect.

thx

MrPete
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-21 07:50:23
By the way, this:

CHCP 1252 | PROMPT

...has proven reliable. I recommend making it part of the default cfg. Can't explain WHY chcp hangs sometimes without it, but it is a very real effect.
I don't see a reason why not.  I don't understand what's happening to you.

I'm not sure if this is normal or unexpected:
* When in this mode, REACT always looks for a "plain" Trackname.CUE file, but all the cue files are Trackname [something].cue
What mode?  "Trackname" should never be used; IIRC REACT uses the album name for the four cuesheets created ("<album>.[<type>].cue"). When ripping to images it is named the same as the image file.  You're ripping to tracks (using REACT-track.cfg) aren't you?  Can you possibly explain further please?

Good News! overlapping rips and compression works fine from the output perspective (i.e. all files in the right place, AFAIK.)
Great.  Good to hear some good news from you!

Medium News: I ripped four CD's in a row with no problem, and no CUE-loop! Unfortunately, on CD #5, FileMon says the CUElooper is back. Bleah.
It's strange that it will take a while to manifest itself.  Thanks for the info anyway.

BugFix Help Request: remember my problem with AlbumArt GIF/BMP downloading as JPG? Apparently, there's a setting I don't know how to set, in REACT:

At least with AlbumArt Downloader XUI, there's support for a target download file of
Trackname.%extension%

i.e. if the track is "Strawberry Fields Forever", the AlbumArt request should be
Strawberry Fields Forever.%extension%

but right now it is
Strawberry Fields Forever.jpg

Where can I fix this?
Unfortunately I am not familiar with the album art processing, as I don't use it.  However, I have taken a look at the source and the AlbumArt Downloader XUI thread and I think I see that this is quite achievable.  Maybe I could move the parameters used to REACT.ini.  REACT currently uses:

'<artist>' '<album>' '<filename-friendly album>.jpg'

I suppose a more accurate XUI parameter string would be:

/artist '<artist>' /album '<album>' /path '<filename-friendly album>.%extension%'

However, I don't know if there is any way for REACT to know what extension was used, so when it replaces the token "@cover@" it is going to have to see if '<filename-friendly album>.jpg' exists and if not expect '<filename-friendly album>.gif'.  I'm not sure if that will cause problems.  Presumably the image should always be there before the batch file runs?
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-21 11:30:33
BugFix Help Request: remember my problem with AlbumArt GIF/BMP downloading as JPG? Apparently, there's a setting I don't know how to set, in REACT:

At least with AlbumArt Downloader XUI, there's support for a target download file of
    Trackname.%extension%

i.e. if the track is "Strawberry Fields Forever", the AlbumArt request should be
    Strawberry Fields Forever.%extension%

but right now it is
    Strawberry Fields Forever.jpg

Where can I fix this?
Please try ssb16c (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16c.zip).  Add CoverDownloaderXUI=1 to the [Settings] section of your REACT.ini.  This will then use the parameters:

Code: [Select]
/artist "<artist>" /album "<album>" /path "<album>.%extension%" /autoclose

The processing instance of REACT will look for the existence of "<album>.gif", then "<album>.png" but finally default to "<album>.jpg" without checking for it's existence.  Therefore, for it to catch a non-JPEG file you will have to ensure that you are saving the image before the processing instance begins.  I believe that this is default behaviour when ripping to tracks (but not images).  For those interested, check out the RunCoverDownloader settings (http://wiki.hydrogenaudio.org/index.php?title=REACT#Settings_Section) in the wiki article.

I have also made a couple of other small changes, including giving up on trying to move the cuesheet after five seconds, and a little more debug text.  As said before, to view any debug text set DebugMode=1 under the [UserSettings] section and restart REACT.  REACT will then output various information into debugging.txt in the REACT directory.  This is not connected to the existing Debug=1 setting (Debug is useful for catching CFG-related issues; I implemented DebugMode in order for users to be able to provide information when reporting bugs).
Title: REACT 2 Released
Post by: pholzmann on 2007-08-21 12:37:45
I'm not sure if this is normal or unexpected:
* When in this mode, REACT always looks for a "plain" Trackname.CUE file, but all the cue files are Trackname [something].cue
What mode?  "Trackname" should never be used; IIRC REACT uses the album name for the four cuesheets created ("<album>.[<type>].cue"). When ripping to images it is named the same as the image file.  You're ripping to tracks (using REACT-track.cfg) aren't you?  Can you possibly explain further please?

I apologize. I got mixed up. I'm ripping images. That should have been AlbumName.cue that it searches for. "In this mode" is what I'm calling a CUEloop ... searching forever for a file, in the background.

If the album is called "Imagine", what I see is:
  Folder has Imagine..cue etc
but REACT is searching for Imagine.cue (and never finds it of course... particularly when i've moved on to another image!)

Quote
Unfortunately I am not familiar with the album art processing...I don't know if there is any way for REACT to know what extension was used, so when it replaces the token "@cover@" it is going to have to see if '<filename-friendly album>.jpg' exists and if not expect '<filename-friendly album>.gif'.  I'm not sure if that will cause problems.  Presumably the image should always be there before the batch file runs?

I think you're guaranteed it will be there before the batch file runs. Don't know why, but the rip does not even begin until the album art has been saved.

So far, I've seen jpg, gif and bmp album art.

For me at least, I would use the above "fix" to ensure I only pick jpg files! (The problem with "album.jpg" vs "album.%extension%" is that with the former, i get no software indication of the kind of file i'm saving...)

I'll try 16c asap...

THANKS!!!!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-21 13:21:12
I apologize. I got mixed up. I'm ripping images. That should have been AlbumName.cue that it searches for. "In this mode" is what I'm calling a CUEloop wink.gif... searching forever for a file, in the background.

If the album is called "Imagine", what I see is:
Folder has Imagine..cue etc
but REACT is searching for Imagine.cue (and never finds it of course... particularly when i've moved on to another image!)
Hmm.. if you are ripping to image you really should not be using CreatAllCuesheets to create the four cuesheets.  When ripping to image a cuesheet is automatically created, using the same name as the image.

The fact that your image cuesheet is named "<album>.cue" is a concern.  What value do you have set for ImageNaming under [Settings] in the ini?  The default is "$artist$ - [$date$] $album$" IIRC (I use "$artist$ - $album$"). The image name must begin with $artist$!  Otherwise you will have problems with VA albums.

Edit: OK, to clarify: If you use CreateAllCuesheets EAC will create four cuesheets named "<album>.cue".  As REACT tells EAC to create them it then renames them to "<album>.[<type>].cue".  This may be where the confusion is coming in - I am now presuming that your ImageNaming value is fine.  I do think you may solve some of your problems (if not all) if you set CreateAllCuesheets=0 in your ini - you don't need them.

I think you're guaranteed it will be there before the batch file runs. Don't know why, but the rip does not even begin until the album art has been saved.
According to the wiki, when using images it will not wait (unless you set the value to 2 or 3).  if you are ripping to images perhaps you should set RunCoverDownloader to 2, in case.

I'll try 16c asap...
Thanks. Maybe I'll upload 16d to deal with BMP as well... 

Edit: OK, ssb16d (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16d.zip) should cope with GIF, PNG, BMP and JPG.
Title: REACT 2 Released
Post by: pholzmann on 2007-08-21 17:33:10
If you are ripping to image you really should not be using CreatAllCuesheets to create the four cuesheets.  When ripping to image a cuesheet is automatically created, using the same name as the image.

I did have CreateAllCuesheets=1

So, if that's incorrect for image rips, why not internally force it to zero?  -- I think you're right. That setting sometimes conflicts with image-rip cuesheet creation and causes a possible race condition for file names, etc.

Quote
The fact that your image cuesheet is named "<album>.cue" is a concern.  What value do you have set for ImageNaming under [Settings] in the ini?  The default is "$artist$ - [$date$] $album$" IIRC (I use "$artist$ - $album$"). The image name must begin with $artist$!  Otherwise you will have problems with VA albums.


Fine. I'm using the default... I think I've seen a dynamic sequence as the process takes place, something like:
  <album>.cue
  Tempfilename.cue
  $artist$ - [$date$] $album$.cue (in the final image folder)

Quote
According to the wiki, when using images it will not wait (unless you set the value to 2 or 3).  if you are ripping to images perhaps you should set RunCoverDownloader to 2, in case.

Mine was set to 2 -- obviously by me and I didn't remember. Just Made Sense at the time

Quote
I'll upload 16d...should cope with GIF, PNG, BMP and JPG.


OK, we're mostly making progress. Unfortunately, one bug remembered, and one serious backtrack

Progress: the new XUI switch works perfectly!

Bug remembered: if you exit EAC while REACT is monitoring (i.e. any time after pressing F10 and before the the batch file has finished), REACT never exits on its own. It sits hidden in the systray.

Suggestion: be sure to code for user-abort at various points in the process. Be particularly read, at the least, to exit if EAC crashes or is closed.

Serious backtrack: under 16c and 16d, something gets badly scrambled in EAC. Going back to 16b "fixes" the following...

(I'm using gap-detection method A, accurate)
Normally, the pre-track gap detection counts from 2 to n and stops.

In 16c and 16d, gap detection counts up some, backtracks, counts up more, goes to various numbers, and ends at zero (!)... and locks. The rest of EAC continues ok, and the rip completes. Eventually, the gap detector times out with some horrible error message. Then EAC dies. Fortunately, the time out is a long time after the rip is done. But I get only one RIP and then must kill/restart EAC and REACT.

This is repeatable on every CD I've tried, and does NOT happen if I go back to 16b.

Waaah!


In 16c and 16d, gap detection...ends at zero (!)... and locks.


BTW, "locks" means the cancel button is grayed out and the detection popup is completely unresponsive.

--MrPete
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-21 17:36:52
Serious backtrack: under 16c and 16d, something gets badly scrambled in EAC. Going back to 16b "fixes" the following...

(I'm using gap-detection method A, accurate)
Normally, the pre-track gap detection counts from 2 to n and stops.

In 16c and 16d, gap detection counts up some, backtracks, counts up more, goes to various numbers, and ends at zero (!)... and locks. The rest of EAC continues ok, and the rip completes. Eventually, the gap detector times out with some horrible error message. Then EAC dies. Fortunately, the time out is a long time after the rip is done. But I get only one RIP and then must kill/restart EAC and REACT.

This is repeatable on every CD I've tried, and does NOT happen if I go back to 16b.
That is so weird.  I can't see how REACT plays any part when this process is happening!!

I'll think on it.

NB: Of course, it works fine for me...
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-21 19:14:56
So, if that's incorrect for image rips, why not internally force it to zero? wink.gif -- I think you're right. That setting sometimes conflicts with image-rip cuesheet creation and causes a possible race condition for file names, etc.
I guess there are times when users may want both - I suppose it's possible that they may want a multi-file cuesheet also, so they could burn from track files created using ACDIR and still perfectly re-create the CD.  I don' think it is likely, or advisable though.  Still, I wouldn't want to restrict users completely, and Tycho obviously didn't.

Bug remembered: if you exit EAC while REACT is monitoring (i.e. any time after pressing F10 and before the the batch file has finished), REACT never exits on its own. It sits hidden in the systray.

Suggestion: be sure to code for user-abort at various points in the process. Be particularly read, at the least, to exit if EAC crashes or is closed.
I may have to investigate this.  I've not noticed this before - but then I tend to just rip one disc at a time, and leave things well alone once I've pressed F10.

In 16c and 16d, gap detection counts up some, backtracks, counts up more, goes to various numbers, and ends at zero (!)... and locks. The rest of EAC continues ok, and the rip completes. Eventually, the gap detector times out with some horrible error message. Then EAC dies. Fortunately, the time out is a long time after the rip is done. But I get only one RIP and then must kill/restart EAC and REACT.
I'm flabbergasted by the results you get.  I don't understand how you can have so many issues that I have never seen, or anyone else has reported.  I just cannot see how REACT is doing this, but the fact that b16b is OK for you must say something.  Have you set CreatAllCuesheets=0?  The only thing I can think that has changed around that time is the checking for the cuesheets' existence.  Perhaps you could use DebugMode (detailed previously) and see what gets written before this happens.  Maybe I do need to create a serious debug version for you to use...
Title: REACT 2 Released
Post by: pholzmann on 2007-08-22 02:43:21
I'm flabbergasted by the results you get.  I don't understand how you can have so many issues that I have never seen, or anyone else has reported.  I just cannot see how REACT is doing this, but the fact that b16b is OK for you must say something.

It's a gift  -- I used to get paid the Big Bucks to break (and fix) software :-D

Seriously, I have no idea. I just Do Stuff, and pay more attention than most when things go wrong. I usually know when something's a bug vs just me messing up. I don't just reboot and try again

Lemme play a little more. It helps knowing that all's well for you!
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-22 07:05:17
It's a gift  -- I used to get paid the Big Bucks to break (and fix) software :-D
Indeed!

Don't get me wrong, I do appreciate the feedback.  It's just that it's quite frustrating for me, when I can't emulate the problem.  I don't really have the time to test for hours and hours, if the truth be told.

If you could try DebugMode with b16d it may help me out.

Thanks.
Title: REACT 2 Released
Post by: dobo on 2007-08-22 22:54:42
I think a bug has been introduced with mods after 16b. Its to do with album art, let me explain

If you rip 2 consecutive CD's, on the 2nd CD the 2nd time the album art runs it searches on the first albums & artists name, its a bit annoying, however the rip still works of course, no major problems like pholzmann is having.

16b works as expected, 16d does not, can anyone confirm?

Also wish the memory leeks cold e fixed with the art downloader  obviously not reacts fault though.

I'm using RunCoverDownloader=1
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-23 07:56:35
I think a bug has been introduced with mods after 16b. Its to do with album art, let me explain

If you rip 2 consecutive CD's, on the 2nd CD the 2nd time the album art runs it searches on the first albums & artists name, its a bit annoying, however the rip still works of course, no major problems like pholzmann is having.

16b works as expected, 16d does not, can anyone confirm?
Yes, I can see it now.  Thanks for the report.  Silly bug on my part.

Please try ssb16e (http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16e.zip).
Title: REACT 2 Released
Post by: Martin H on 2007-08-24 04:13:51
Hi Neil

Just wanted to say many thanks for this nice REACT mod of yours and that the 'Test=1' function simply rocks

I have been occupied with some other stuff lately and have not been using REACT for some time now(or ripping with anything else for that matter), but now when i return back to check out what's happening currently, then i happily find that EAC has now gotten both test & copy + AccurateRip support for images and also that you have faithfully continued the REACT development with great new features and fixes in Tycho's absence, so i just wanted to say many thank's for all your troubles, mate

CU, Martin.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-24 07:35:07
Hi Martin,

I'm glad that my mod has been useful to you.

I'm actually getting quite concerned that I have been causing tycho's absence, rather than helping.  I hope he will be back soon with REACT 3, at which point I will gladly step back into the shadows.

Anyway, good to see you back.
Title: REACT 2 Released
Post by: tycho on 2007-08-24 08:59:52
Hi Martin,

I'm glad that my mod has been useful to you.

I'm actually getting quite concerned that I have been causing tycho's absence, rather than helping.  I hope he will be back soon with REACT 3, at which point I will gladly step back into the shadows.

Anyway, good to see you back.

Hi. Don't be concerned - you have been a great help all the way. I don't think REACT 3 will appear anytime soon, unless EAC is changed a lot, which is not likely. However, as I've promised earlier, I will try to merge in some *smaller* updates I have done, and then at some point a new "official" release. Please, continue to develop and support REACT if you can (and want to).
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-24 09:16:58
Hi. Don't be concerned - you have been a great help all the way.
...
Please, continue to develop and support REACT if you can (and want to).
That's a weight off my mind.  Thanks tycho.

I don't think  REACT 3 will appear anytime soon, unless EAC is changed a lot, which is  not likely. However, as I've promised earlier, I will try to merge in  some *smaller* updates I have done, and then at some point a new  "official" release.
Looking forward to it.
Title: REACT 2 Released
Post by: kockroach on 2007-08-25 04:31:06
Hello,

I just started to look at using REACT with the newest EAC 0.99pb3.  I have tried to get REACT to create a FLAC image and Nero AAC tracks, as well as download Album Art (using AlbumArtDownloaderXUI).  I am having a couple of issues, and I am not sure where to go now.  I have tried searching, but the information I have found doesn't seem to help.

I set REACT to wait until the album art is downloaded before it copies (set to 2 in the INI file).  I want to have a "folder.jpg" file when the process is done, but I don't end up with an image in the final directory at all.  Is it possible to set the path and name that should always be used by the AlbumArtDownloaderXUI so that REACT can find it?  When the XUI window opens, the default destination is not the same as the folder where the temporary CUE/WAV/LOG files are being held, plus it is defaulting to a filename format of "cdartist"- "album".jpg, which I don't want.

When REACT creates the CUE file and starts copying the temporary WAV, it is not placing these tempory files in a directory I have not set.  In my INI file I have it set for
Code: [Select]
OutRoot="D:\Music\Test"
however, the temporary CUE/WAV/LOG files are being put into my "D:\MUSIC\FLAC" directory (which is where my current music library resides).  I don't know how or why it is using my current FLAC directory.

Basically, I was hoping that the temporary files (CUE/WAV/LOG) and the folder.jpg would be held in the same temporary directory.

Thanks.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-25 07:45:01
I dont use AlbumArtDownloaderXUI - and I currently don't have it installed on this laptop (looks like I need .Net 3) - but can't you just change the output directory?  In fact, thinking about it, I think if you resolve the issue below (D:\Music\FLAC > D:\Music\Test) this may resolve itself.

Using "<artist> - <album>.jpg" is standard naming for the source image, and can't be changed; however the source name is irrelevant.  By default REACT moves it to the destination directory renaming it to the same as the image file.  You can amend this behaviour by changing:

Code: [Select]
IF %have_cover%==1 COPY /Y "@cover@" %dest%\"@basename@.jpg"

...to:
Code: [Select]
IF %have_cover%==1 COPY /Y "@cover@" %dest%\folder.jpg

... in the FLAC image section of your REACT-image.cfg.

To change the folder that REACT is using for the source files go to EAC Options >  Directories.  Check "Use this directory" and select "D:\Music\Test".
Title: REACT 2 Released
Post by: dobo on 2007-08-25 08:40:50
Kockroach, what Synthetic Soul suggests is how i have mine set and works.

Synthetic Soul ssb16e has fixed the bug i posted, thanks again.
Title: REACT 2 Released
Post by: kockroach on 2007-08-25 14:14:31
Hi Synthethic Soul,

I had already made that change regarding the @basename@.jpg, changing it to folder.jpg.

Just to be safe, for your other suggestion, I started with a fresh directory.  I set the directory to "D:\Test"
Changing the directory in EAC Options doesn't help completely.  It is sending the folder.jpg image there, but it is not sending the temporary WAV/CUE/LOG files there.  They are going to "D:\Music\FLAC".  This is where my current FLAC library is held, so I would prefer it not be touched.  I don't know why EAC is throwing the files in there, especially since it is not the last directory I used, nor is it the one set in EAC Option --> Directories.

One thing I notice is that after selecting my Album Art, the "Save As" window from EAC pops up quickly, and I can see that it is using my "D:\Music\FLAC" directory, but it closes after about a second or two.

EDIT:  While I was writing this message, I was letting REACT/EAC do its thing on a CD.  Even though I have the "EAC Options/Directory" set to "D:\Test", the only thing that is going in there is the Album Art I downloaded.  The temporary files are being stored in "D:\Music\FLAC", while the final files are being put into "D:\Music\Test".  In the "D:\Music\Test", it has the proper directories, containing the music files, cue and logs, but no album art.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-25 20:01:37
Hmmm... if you look in the registry, under:

HKEY_CURRENT_USER\Software\AWSoftware\EAC\StartUp Options

... you will notice a couple of other file paths.  It seems to me that "Actual Path" is the one that needs to change.

I just managed this in EAC by doing the following:If you're happy with regedit you may just want to edit the paths in the registry.  For safety: REACT uses DirectorySpecification - the directory set under "Use this directory".

I think if you used regedit to change all the paths above to "D:\Test" and then opened REACT/EAC it would all work as expected.
Title: REACT 2 Released
Post by: FredipusRex on 2007-08-25 20:28:18
I'm sorry, but I must be especially challenged today.

I have previously used EAC+FlackAttack to do ripping and compressing (to FLAC + Ogg, with embedded cue sheets). I then would tweak the tags and add album art using The Godfather. As I have a new computer and FlacAttack seems to have faded away, I thought I'd try REACT.

So far, no real luck. I downloaded both the REACT 2.0 (from the REACT 2/EAC plugin Uploads thread) and the latest ssb16e from this thread.

My problem is that neither of those appear to be a "full install" with the proper plugins in the "Tools" directory and the albumart cover downloader. They're just the REACT executable and a readme file.

I've grabbed and installed the AlbumArtDownloader, the EAC Ultimate Pack, newer FLAC and OggEnc2 encoders, figured out that REACT must be Run As Administrator under Vista to create the REACT.INI file - but this seems way too complicated considering that most members on this thread seem to be up and running within minutes.

Am I missing something? I just want to be able to rip a CD (with non-compliant cue sheets), create individual .FLAC and .ogg files, embed the album art into both the Oggs and FLACs and the cue sheets in the FLACs (I don't want one big FLAC image of the CD). Doable?

Thanks,

Derf!
Title: REACT 2 Released
Post by: kockroach on 2007-08-25 22:26:38
I just managed this in EAC by doing the following:
  • I chose a new directory (let's call it "X:\") under "Use this directory".
  • I changed the radio button to "Ask every time".
  • I ripped using F10, ripping to the new directory, "X:\".
  • I closed EAC and re-opened it.
  • I ripped using F10, and EAC opened the dialogue in "X:\".
  • I changed the radio button to "Use this directory".

I went with this route, and everything seems to work fine now.  Thanks for the help. 

I wonder if this problem arose since EAC (non-REACT) always asks for the directory to save when doing an Image based copy, but when doing track based, it uses the Directory path in the settings.  I think it may have been causing the problem.  But no worries, it is working now.

I do have one other question.  I had wanted to tag my files in a certain way regarding track number and total tracks.  My changes work for WavPack, FLAC and OGG tracks, but it will not work for MP3 and NeroAAC.

Here is what I have for the MP3 files (found in the Image CFG file):
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.mp3" --extra-opt "{3}@cover@" --pipe "TITLE $n/$N mp3 $#T & @tools@\lame.exe @Opt_LameMP3@ %ApplyAG_Lame% - $#o & @tools@\metamp3.exe %Cover_tag% %VA_tag% --artist $#a --album $#T --title $#t --track $n --totaltracks $N --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME @Ver_LameMP3@ @Opt_LameMP3@$q $#o" "@sourcecuesheet@"


And this is in the NeroAAC section:
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --extra-opt "@cover@" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\AtomicParsley.exe $#o -o REACT_tmp.m4a %Cover_tag% %VA_tag% --artist $#a --album $#T --tracknum $n --totaltracks $N --title $#t --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q --encodingTool $qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q & MOVE /Y REACT_tmp.m4a $#o" "@sourcecuesheet@"


When the encoder runs, it says that it doesn't recognize the "--totaltracks" option for MP3 and NeroAAC, and there are no tags at all in the files.  What should I change to get this to work?  I basically did the same type of change for WV, FLAC and OGG, and they work without a problem (I know the tag formats are different, so that is mainly why they do work in those files).

I know I could go back to the $n/$N format, and then open them in Mp3tag to change them, but I really don't want the extra step if it can be avoided.

Thanks again for your help!
Title: REACT 2 Released
Post by: drbeachboy on 2007-08-25 22:51:15
Neither metamp3 or atomicparsley have a "totaltracks" field, though Neroaactag does. I can post what I use (a combination of both neroaactag & atomicparsley) if you want to try it.

For mp3, try using Tag v2.0.53b2 from synthetic soul's site and use the "-t" option to create "totaltracks" field.
Title: REACT 2 Released
Post by: kockroach on 2007-08-25 23:04:32
Thanks for the info drbeachboy.  I took a look at Synthetic Soul's Tag program, and from a brief look through the readme file I think I should be able to make the proper changes to get it to work.  I just don't have the time right now.

As far as your config using NeroAacTag and AtomicParsley, yes, I would like to take a look at what you are doing to tag your files.  I would appreciate it if you could post your code.

Thanks again!
Title: REACT 2 Released
Post by: drbeachboy on 2007-08-25 23:09:19
Here you go!

Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\neroAacTag.exe $#o %VA_tag% -meta:artist=$#a -meta:album=$#T -meta:track=$n -meta:totaltracks=$N -meta:title=$#t -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$q@comment@$q & @tools@\AtomicParsley.exe $#o -o REACT_tmp.m4a --encodingTool $qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q & MOVE /Y REACT_tmp.m4a $#o" "@sourcecuesheet@"
Title: REACT 2 Released
Post by: kockroach on 2007-08-25 23:35:02
Thanks drbeachboy!  I'll give it a try.
Title: REACT 2 Released
Post by: Martin H on 2007-08-26 03:20:52
@kockroach

When dealing with MP3s, then i would strongly advice against using any 'totaltracks' tags, as it's very non-standard and since most apps probably will not be able to parse them correctly. The ID3v2 spec clearly defines that any optional total tracks values should be appended to the track number in the TRCK frame and seperated by a '/' charachter, just like e.g. the 'discnumber' value and optionally the 'totaldiscs' value are to be stored in the TPOS frame and seperated by a '/' charachter and then e.g foobar2000 will then parse those TRCK and TPOS frames and display there values as though it where two seperate tags i.e. 'tracknumber' and 'totaltracks' and 'discnumber' and ''totaldiscs', even though they aren't, but are just mapped to those fields internally by foobar2000, for easing the metadata handling between the different tagging formats. If you absolutely want to, then you can make a 'totaltracks' TXXX ID3v2 frame with metamp3.exe, but i can't see why you would ever want to when there allready are frames available which is meant for storing exactly those values. The TXXX frames are meant for stuff which aren't covered by the frames defined in the spec.
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-08-26 09:52:35
My problem is that neither of those appear to be a "full install" with the proper plugins in the "Tools" directory and the albumart cover downloader. They're just the REACT executable and a readme file.
The 1.99MB download in the REACT download thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=50259) contains all the tools.  Note that some may now be outdated, e.g.: FLAC.  The thread also has links to tools not included.

My mod only includes REACT.exe, to overwrite the exe included in tycho's original release (in that thread).

Make sure you let REACT configure EAC.  REACT should do this on first run, but if you are in any doubt hit Ctrl+F2 to re-do it.

I just want to be able to rip a CD (with non-compliant cue sheets), create individual .FLAC and .ogg files, embed the album art into both the Oggs and FLACs and the cue sheets in the FLACs (I don't want one big FLAC image of the CD). Doable?
Most definately.

For mp3, try using Tag v2.0.53b2 from synthetic soul's site and use the "-t" option to create "totaltracks" field.
Unfortunately Case's Tag won't write ID3v2 tags; I don't know what whould happen if you use -t "totaltracks=12" on an MP3 file - probably APEv2 would be used.

When dealing with MP3s, then i would strongly advice against using any 'totaltracks' tags, as it's very non-standard and since most apps probably will not be able to parse them correctly.
I 100% agree.

If you absolutely want to, then you can make a 'totaltracks' TXXX ID3v2 frame with metamp3.exe, but i can't see why you would ever want to when there allready are frames available which is meant for storing exactly those values. The TXXX frames are meant for stuff which aren't covered by the frames defined in the spec.
To clarify, I believe you would set a switch as below for metamp3:

Code: [Select]
--frame "TXXX[totaltracks]:@numtracks@"
Title: REACT 2 Released
Post by: FredipusRex on 2007-08-26 15:06:43
The 1.99MB download in the REACT download thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=50259) contains all the tools.  Note that some may now be outdated, e.g.: FLAC.  The thread also has links to tools not included.

My mod only includes REACT.exe, to overwrite the exe included in tycho's original release (in that thread).

Make sure you let REACT configure EAC.  REACT should do this on first run, but if you are in any doubt hit Ctrl+F2 to re-do it.

I just want to be able to rip a CD (with non-compliant cue sheets), create individual .FLAC and .ogg files, embed the album art into both the Oggs and FLACs and the cue sheets in the FLACs (I don't want one big FLAC image of the CD). Doable?
Most definately.


Thanks! I'll try it out (after vacation).
Title: REACT 2 Released
Post by: drbeachboy on 2007-08-26 17:04:24
Quote
Unfortunately Case's Tag won't write ID3v2 tags; I don't know what whould happen if you use -t "totaltracks=12" on an MP3 file - probably APEv2 would be used


My apologies! I completely forgot that TAG doesn't write ID3v2 tags. I haven't used TAG in a long time, so it slipped my mind. Though logically, it was most likely one of the reasons why I no longer use it. 
Title: REACT 2 Released
Post by: kockroach on 2007-08-26 21:21:52
For mp3, try using Tag v2.0.53b2 from synthetic soul's site and use the "-t" option to create "totaltracks" field.
Unfortunately Case's Tag won't write ID3v2 tags; I don't know what whould happen if you use -t "totaltracks=12" on an MP3 file - probably APEv2 would be used.

When dealing with MP3s, then i would strongly advice against using any 'totaltracks' tags, as it's very non-standard and since most apps probably will not be able to parse them correctly.
I 100% agree.

If you absolutely want to, then you can make a 'totaltracks' TXXX ID3v2 frame with metamp3.exe, but i can't see why you would ever want to when there allready are frames available which is meant for storing exactly those values. The TXXX frames are meant for stuff which aren't covered by the frames defined in the spec.
To clarify, I believe you would set a switch as below for metamp3:

Code: [Select]
--frame "TXXX[totaltracks]:@numtracks@"


Interesting, I didn't realize that it is non-standard to do it that way.  I was wanting to have it set that was for consistency, since I can do it with the other formats, but oh well.  I may not even go with MP3 for my lossy files.  I recently have been using NeroAAC, so that one was more important to get to work properly.  But, I am going to do some of my own testing to see which format my ears prefer, and REACT will be a nice way to convert a number of CDs into multiple formats for testing.

Thanks for all of your help Synthetic Soul, drbeachboy and Martin H!  I appreciate it.
Title: REACT 2 Released
Post by: kockroach on 2007-08-26 23:04:38
Here you go!

Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\neroAacTag.exe $#o %VA_tag% -meta:artist=$#a -meta:album=$#T -meta:track=$n -meta:totaltracks=$N -meta:title=$#t -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$q@comment@$q & @tools@\AtomicParsley.exe $#o -o REACT_tmp.m4a --encodingTool $qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q & MOVE /Y REACT_tmp.m4a $#o" "@sourcecuesheet@"

Hey drbeachboy, what are you using for your Various Artist tag format?  I cannot get NeroAACTag.exe to tag the file, it is choking on the VA tag.  It was also have trouble with the cover file tag.

The original Image CFG has this:
Code: [Select]
        IF @various@==1 SET VA_tag=--album artist $q@VA@$q --compilation true
        IF %embed_cover%==1 SET Cover_tag=--artwork $#x

I have tried converting that to use "-meta-user" since Album Artist isn't standard, but it won't work.  I am not sure if I have the cover option set properly, but I am using "-add-cover:front:$#x" for that part.
Title: REACT 2 Released
Post by: drbeachboy on 2007-08-26 23:18:32
Here is my code for the two lines that you referenced.

Code: [Select]
IF @various@==1 SET VA_tag=-meta-user:albumArtist=$q@VA@$q -meta-user:compilation=true
        IF %embed_cover%==1 SET Cover_tag=-add-cover:front:$#x


I am using SS's REACT version ssb16
Title: REACT 2 Released
Post by: kockroach on 2007-08-26 23:23:28
I was close in what I had used.  I was thinking there might have been a way to use "Album Artist" being able to keep consistent with the other formats.  But NeroAACTag doesn't like the spaces at all...I wish there was a way to allow for the space and use "Album Artist", instead of "AlbumArtist".

Thanks!

EDIT: I created an Action in Mp3tag to change the field, so I can live with that for now.  Looks like I have everything working now.  Thanks again everyone for your help.
Title: REACT 2 Released
Post by: drbeachboy on 2007-08-27 00:27:51
@ kockroach

Place $q (quotes) around Album Artist like in the code below, and neroaactag will tag it properly.

Code: [Select]
IF @various@==1 SET VA_tag=-meta-user:$qalbum artist$q=$q@VA@$q -meta-user:compilation=true
Title: REACT 2 Released
Post by: kockroach on 2007-08-27 00:48:58
Awesome!  Thanks again for the help drbeachboy.

EDIT:
I was looking at the different downloads, making sure I had the most up-to-date versions.  I noticed that nyaochi created CueProc as a replacement for ACDIR.  There was a post in this thread in February, asking if REACT would be updated to use CueProc, but I didn't find any response to that.  I would almost assume it could be used instead of ACDIR.  Is this correct?
Title: REACT 2 Released
Post by: drbeachboy on 2007-08-27 03:00:58
I used CueProc with REACT 1.0 with no issues, but I ran into a few difficulties using it with REACT 2.0. IMHO, there is really no benefit of one over the other, so I just stayed with ACDIR since it was already pre-written in the config file and worked perfectly.
Title: REACT 2 Released
Post by: kockroach on 2007-08-27 03:18:25
Good to know.  I was thinking that if CueProc was a significant improvement that it would have been changed in REACT.  Just thought I would ask.  Thanks.
Title: REACT 2 Released
Post by: sdgenxr on 2007-09-03 17:22:07
REACT and Vista?  I recently upgraded to Vista Premium and installed the latest version of EAC (V0.99 prebeta 3) and copied over my .ini and .cfg files from my XP build.  Now when I'm ripping a CD, I get an error when REACT starts to cut the image up using acdir and stops.  Is this an issue with EAC prebeta 3, Vista, or acdir?

On a separate note, does anyone know how I can make REACT either auto run, or a GUI to use in Vista Media Center?

Thanks
Title: REACT 2 Released
Post by: dewey1973 on 2007-09-03 20:04:10
REACT and Vista?  I recently upgraded to Vista Premium and installed the latest version of EAC (V0.99 prebeta 3) and copied over my .ini and .cfg files from my XP build.  Now when I'm ripping a CD, I get an error when REACT starts to cut the image up using acdir and stops.  Is this an issue with EAC prebeta 3, Vista, or acdir?

On a separate note, does anyone know how I can make REACT either auto run, or a GUI to use in Vista Media Center?

Thanks

If I recall correctly, this is an issue with acdir.  I remember having the same problem when I upgraded to Vista.  I do most of my ripping on an XP machine so I just abandoned the Vista box.  Sorry, I can't help further.
Title: REACT 2 Released
Post by: Bill02888 on 2007-09-06 05:21:10
When using REACT v2.0.ssb16e and EAC prebeta 3 on Windows XP w/SP2, ripping to WavPack images and MP3 tracks I noticed the following fly by in the Command Prompt window:

Quote
TITLE 06/22 mp3 "Unforgettable With Love" & C:\PROGRA~1\REACT2\tools\lame.exe -V5 --vbr-new --norepl
aygain --nohist  - "06 This Can't Be Love.mp3" & C:\PROGRA~1\REACT2\tools\metamp3.exe --pict "{3}E:\
Unforgettable With Love.jpg"  --artist "Cole, Natalie" --album "Unforgettable With Love" --title "Th
is Can't Be Love" --track 06/22 --year "1991" --genre "Vocal" --comment "Created with EAC/REACT2, 20
07-09-06" --frame TENC:"Myname Here" --frame TSSE:"LAME 3.97 -V5 --vbr-new --noreplaygain --nohist"
"06 This Can't Be Love.mp3"
LAME 3.97 32bits (http://www.mp3dev.org/)
CPU features: MMX (ASM used), 3DNow! (ASM used), SSE (ASM used), SSE2
Using polyphase lowpass filter, transition band: 15826 Hz - 16360 Hz
Encoding <stdin> to 06 This Can't Be Love.mp3
Encoding as 44.1 kHz VBR(q=5) j-stereo MPEG-1 Layer III (ca. 11.9x) qval=3
metamp3 v0.91 - Copyright © 2006 by Tycho

Usage: C:\PROGRA~1\REACT2\tools\metamp3.exe [options] [mp3files]
options:
  --artist <artist>              audio/song artist
  --album <album>                audio/song album
  --track <track>[/total]        audio/song track number
  --title <title>                audio/song title
  --year <year>                  audio/song year of issue (1 to 9999)
  --genre <genre>                audio/song genre name
  --comment [[desc]][{lng}]<text> add user-defined text
  --user-text [[desc]]<text>      add user text frame (TXXX)
  --user-url [[desc]]<URL>        add user URL frame (WXXX)
  --frame <frame:text>            set any T* or W* type frame
  --pict [[desc]][{type}]<file>  add picture artwork
  --save-pict <pict>              pict=[[desc]][{type}]<file>
  --list-pict-types              list possible picture type numbers
  --list-frames                  list Text and URL id3v2.3 frames
  --list-genres                  list standard id3v1.1 genres
  --1                            add id3v1 tag only (default both v1 and v2)
  --2                            add id3v2 tag only (--1 --2 will add both)
  --fit                          add id3v1 + id3v2 if tag does not fit id3v1
  --remove [[desc]]<frame>        remove frame(s). accepts wildcards *,?
  --replay-gain                  calculate and set replay gain tags
  --apply-gain <gain>            change volume. gain=[album|radio]<+dB|-dB>
  --undo-gain                    undo previous apply-gain
  --info                          print detailed mp3/lametag info
  --version                      show version info
  --help                          show this help

TITLE 07/22 mp3 "Unforgettable With Love" & C:\PROGRA~1\REACT2\tools\lame.exe -V5 --vbr-new --norepl


Any ideas what's making metamp3 get upset? Maybe the ' in the track name?

- Bill
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-09-06 07:01:55
No.  I ran your metamp3 command and it worked fine.  Even changing the album art to a non-existent file didn't cause a problem.  I did produce the same result by specifying a non-existent MP3, so I can only assume that the MP3 that LAME created (if it did) did not have the same path as expected.

I believe that I have seen this issue before (somewhere in this thread).  Is it possible that the path to the MP3 files is very long?  What would be the full path to that file?

Edit: Here's the resolving post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=50273&view=findpost&p=505497) (see further up that page for the full story).
Title: REACT 2 Released
Post by: Bill02888 on 2007-09-07 01:46:25
Thanks SS. My first rip after making that change happened to be a different CD named "Lost & Found Sound and Beyond". Instead of naming the MP3 track path[blockquote]F:\Audio\CD Rips\MP3\NPR All Things Considered\Lost & Found Sound and Beyond\[/blockquote]it created[blockquote]F:\Audio\CD Rips\MP3\NPR All Things Considered\LOST\[/blockquote]Trying the Natalie Cole CD now (as I type) to see what happens... (insert music on hold here) ...

I've got an unrelated issue while I'm thinking about it. Sometimes when I look at my EAC drive settings it will show my Plextor PX-716A 1.11 as only supporting the speed "Actual". Other times it will list Actual, 4x, and 8x. And other times it'll show quite a lengthy list (comparatively) going up to (IIRC) 40x. When I can select 40x the test and copy is quite speedy. This time it only allowed me to specify 8x so the process is taking much longer than it should (about 20 mins for the test). Any idea why EAC (still the latest -- prebeta 3) would report different drive speed capabilities for this, the only CD/DVD drive on this system?

Okay. The Natalie Cole CD just finished. I did not see the same error this time. Looks like the short path solution worked, 'cept for the & issue I reported in the first paragraph.

- Bill
Title: REACT 2 Released
Post by: Synthetic Soul on 2007-09-07 08:20:58
Thanks SS. My first rip after making that change happened to be a different CD named "Lost & Found Sound and Beyond". Instead of naming the MP3 track path

    F:\Audio\CD Rips\MP3\NPR All Things Considered\Lost & Found Sound and Beyond\

it created

    F:\Audio\CD Rips\MP3\NPR All Things Considered\LOST\
Hmm.  That change should not have altered the way that REACT creates destination folders - only the path passed to LAME.  Did you change the line:

Code: [Select]
IF NOT EXIST %dest% MKDIR %dest%

... at all?

Okay. The Natalie Cole CD just finished. I did not see the same error this time. Looks like the short path solution worked, 'cept for the & issue I reported in the first paragraph.
Good news.  I'm a little confused though, as the path you posted above is nowhere near the 250 character limit that robert spoke of.

This whole situation isn't making a lot of sense to me at the moment.

I've got an unrelated issue while I'm thinking about it.
This is well out of the realms of this thread.  Please start a new topic in the CD Hardware/Software forum.  Unfortunately I can't personally help you with this anyway.
Title: REACT 2 Released
Post by: vulc44n on 2007-09-07 23:28:23
I've used REACT2 successfully for some time.  However, I am now having issues on my new system.

I have configured EAC .99 pb3 and REACT2 ssb16b as I normally would, but after hitting F10 I am just given a blank command prompt window. 

Also, when I find the batch file and try to run it, the same thing happens.

Any ideas?
Title: REACT 2 Released
Post by: Bill02888 on 2007-09-09 01:53:18
I un-did the changes to the REACT scripts, deleted both my track and image directories for Natalie Cole, then re-ripped with no error whatsoever. Don't we all hate when that happens!?!

I just noticed that on the link where I downloaded ssb16e there is a separate Zip file with .CFG files. I've been