Hydrogenaudio Forums

Hosted Forums => foobar2000 => Support - (fb2k) => Topic started by: Anakunda on 2019-07-09 10:37:59

Title: foobar2000 1.5 beta 1 properties bug
Post by: Anakunda on 2019-07-09 10:37:59
There's a mess with properties subcategories Selection Properties -> Metadata alone displays nothing, must be combined with other subcategory

I can't somehow get used to new properties dialogue. Could be the old box available?
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-09 10:55:14
Thanks for the bug report.

I understand that the new dialog breaks some people's habits; the old one will be made available as a standalone component later.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: emaulana on 2019-07-09 16:07:39
Thanks for the bug report.

I understand that the new dialog breaks some people's habits; the old one will be made available as a standalone component later.

When we add pictures for cover and artwork please set to search in it's music/album folder automatically. I love your Foobar2000, Good job sir.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TuNk77 on 2019-07-09 17:12:55
Also, when exporting images, it should default to the current directory, IE foobar2000 automatically selects the folder in question.

Nevermind, I made a mstake
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: arch21 on 2019-07-09 17:50:24
Some feedback to new properties dialog:
1. Artwork.
- I wish the first letter on column Name uses big letter, similar to context menu.
- Previous version shows format of attached picture. I wonder if you will add it later.
- Right-click on free space, 'Remove' context menu is enabled but nothing to be removed.
2. ReplayGain
- By using Tools -> ReplayGain -> (scan menu), I wish it will be redirected to ReplayGain tab, if that makes sense.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: beardgoggles on 2019-07-09 18:16:00
I’ve also noticed that the width of the “Name” column on the “Metadata” tab resets itself to much narrower than I would like whenever I re-open the Properties dialog. (I have some long-ish field names!)

Currently, foobar2000 1.4.* remembers the width I set for the “Name” column.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TheQwertiest on 2019-07-10 11:20:36
Some feedback on new properties dialog: IMO, there should be a separator between columns, since it makes harder to distinguish visually the end of data in one column and the start of the data in the next column (especially if these column contain long space separated strings).
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-10 15:50:55
Thanks for all the feedback.
Beta 2 posted, most of the reported issues have been addressed.

Some feedback on new properties dialog: IMO, there should be a separator between columns, since it makes harder to distinguish visually the end of data in one column and the start of the data in the next column (especially if these column contain long space separated strings).
Post a screenshot please so I can get a better idea what it looks like for you.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: emaulana on 2019-07-10 16:26:21
Thanks for the bug report.

I understand that the new dialog breaks some people's habits; the old one will be made available as a standalone component later.

When we add pictures for cover and artwork please set to search in it's music/album folder automatically. I love your Foobar2000, Good job sir.

Thank you for anwer my prayer immediately in 1.5 beta 2 :) I don't need mp3tag now.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: beardgoggles on 2019-07-10 18:17:37
I’ve also noticed that the width of the “Name” column on the “Metadata” tab resets itself…
Thanks for all the feedback.
Beta 2 posted, most of the reported issues have been addressed.
Thanks for the quick fix! 😊
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: anamorphic on 2019-07-10 19:53:09
Peter,

Would it be possible to make the Properties dialog use the current color scheme for background / text / highlight as set in Preferences? (Maybe an option in Advanced?) I use a dark grey background and light text which pops a bit more making it easier on the eyes.

I'm also crossing my fingers you could maybe expand the Selection Properties element to include specific headings for the "Other" components, which could solve Spider Monkey Panels theft (https://hydrogenaud.io/index.php/topic,116669.msg968309.html#msg968309) of the %rating% display from Playback Statistics. >:(  ;)

(And, speaking of Preferences, Advanced > Display > Album List, there is a typo)

Cheers

Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: j7n on 2019-07-11 18:41:44
The properties dialog crashes on Windows XP/2003 often, about a quarter of the time as soon as it appears, and more often on a slower computer. Also crashes at the end of a ReplayGain scan started from the dialog. If you don't want to look at the problem, it is not a big deal.

The tabular overview of ReplayGain is nice. I'd like to see an option to manipulate a selection/column of values, in order to delete all album gains if I discover that the set has uneven loudness (for example).

The column headers in the properties dialog look a bit ugly, they don't line up with the top of the dialog,extend past the tabs on either side, and are set in the Microsoft Sans Serif font, unlike the rest of the dialog.

An old issue still exists, where the default "Edit" option is not available after clicking on multiple fields on first startup of Foobar. The first menu option is "Remove".
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: deus-ex on 2019-07-11 22:35:18
Hi Peter,

I love the new ease of accessibility of the file properties using the keyboard shortcuts, it's very much appreciated. There's just one little cosmetic issue that I would like you to address, if possible. Currently, except for the details tab, the width of the columns aren't remembered. Both v1.5 beta 1 and beta 2 are affected.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-11 23:59:09
When trying to add a new metadata field that already exists in other files, pre 1.5, the field name would autocomplete (such as when typing "CA", you'd get "CATALOG #"). Now, the autocomplete is gone and you lose the ability to autocomplete the field name, which leads to a greater chance of typing errors and improper tags.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-12 15:33:14
The properties dialog crashes on Windows XP/2003 often, about a quarter of the time as soon as it appears, and more often on a slower computer. Also crashes at the end of a ReplayGain scan started from the dialog. If you don't want to look at the problem, it is not a big deal.
I see nothing on the crash report tracker. Please autosend reports, or send me the .txt/.dmp files if sending automatically is impossible.

EDIT
Problem recreated in a virtual machine, I see crash log writing doesn't work at all in this case, investigating.

EDIT 2
Neat bug, fixed for the next update... affects 1.4 series too but harder to trigger.
Also improved crash report writing so stack overflows produce valid reports that can be submitted automatically.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Foobar3031 on 2019-07-12 21:21:31
I've noticed that the return key now has the same effect as double click, in that it opens whichever field is currently highlighted. Previously, return had the same effect as clicking the 'OK' button to save/close the properties window or any field editing pop-up.

If this is intentional, is it possible for return key behaviour to be toggled, perhaps in Advanced Settings? The muscle memory is strong after tagging through these menus for the past decade...!  ;) :D

I also echo earlier points regarding the visual pattern of the rows. It would be helpful if the old Excel-style light grey lines between fields could be toggled, or else, for the shading to be more distinct for those of us with poor eyesight or poor screens.

As always, thanks so much for your hard work!
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: j7n on 2019-07-13 08:10:31
Thank you for the fix. I did not get a crash report or even the dialog from windows. It just closed.

These faint alternating shaded rows do exist in some other traditional, non-flat software. And they are quite helpful in following lines due to their halved frequency. Maybe their intensity could be increased a notch? I see one other example with 247. The read only columns to the left could be shaded further, to indicate that they cannot be edited. For example, if I open a multi-field tagging dialog, and see the same string under Item and Title, a different background color would make the dialog more organized. In other software this happens with line number column or sorted columns (e.g. Xyplorer).
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TuNk77 on 2019-07-13 14:30:43
I've noticed that the return key now has the same effect as double click, in that it opens whichever field is currently highlighted. Previously, return had the same effect as clicking the 'OK' button to save/close the properties window or any field editing pop-up.

If this is intentional, is it possible for return key behaviour to be toggled, perhaps in Advanced Settings? The muscle memory is strong after tagging through these menus for the past decade...!  ;) :D

I also echo earlier points regarding the visual pattern of the rows. It would be helpful if the old Excel-style light grey lines between fields could be toggled, or else, for the shading to be more distinct for those of us with poor eyesight or poor screens.

As always, thanks so much for your hard work!

I posted something similar here (https://hydrogenaud.io/index.php/topic,116509.msg973056.html#msg973056) about the enter key now is the same as double click.

I also would like to see a change in this behavior. :)
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Sandrine on 2019-07-13 21:01:23
When trying to add a new metadata field that already exists in other files, pre 1.5, the field name would autocomplete (such as when typing "CA", you'd get "CATALOG #"). Now, the autocomplete is gone and you lose the ability to autocomplete the field name, which leads to a greater chance of typing errors and improper tags.

Yup, I have to concurr - without autocomplete my acceptance factor tends towards zero...
In the old dialogue we were able to choose from already used tag names when adding new fields so writing wasn't necessary. This is a big step backwards now.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Rollin on 2019-07-13 21:26:46
When trying to add a new metadata field that already exists in other files, pre 1.5, the field name would autocomplete (such as when typing "CA", you'd get "CATALOG #"). Now, the autocomplete is gone and you lose the ability to autocomplete the field name, which leads to a greater chance of typing errors and improper tags.
Autocomplete is not gone. It is adjustable now. File->Preferences->Advanced->Display->Properties dialog->Field name suggestions
And, after you typed some name manually in Properies dialog, it becomes automatically remembered in "Field name suggestions". So you need to type it manually only first time.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-14 16:32:55
Regarding autocomplete of field names, it works.... it *logically* does the right thing, suggests known field names that are not yet listed in the table.
I have to admit that at some point I myself thought it was not working properly, not listing the field names I expected, because they were already listed above.
I'm changing it to list all fields, because the way it is now confuses too many people.
I guess some of you also expect a dropdown list instead of edit+autocomplete... I don't currently have the technology to embed such in a table instead of the editbox, but I'll investigate it at some point.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: bbqchinchilla on 2019-07-14 17:44:04
Peter, I sent you a private message if you could give it a read.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-14 19:46:46
So you need to type it manually only first time.

Ah.. I thought it would use tags that already exist in my library.

Regarding autocomplete of field names, it works.... it *logically* does the right thing, suggests known field names that are not yet listed in the table.
I have to admit that at some point I myself thought it was not working properly, not listing the field names I expected, because they were already listed above.
I'm changing it to list all fields, because the way it is now confuses too many people.
I guess some of you also expect a dropdown list instead of edit+autocomplete... I don't currently have the technology to embed such in a table instead of the editbox, but I'll investigate it at some point.

If any change could be made to improve usability, I would suggest keeping the old behavior where if you typed "CA", "CATALOG #" (or whatever) would be automatically filled into the box. That way, if you type "CA" and tab to the value field, the "CATALOG #" tag is kept and you can immediately type its value.

Currently if you type "CA", you have to hit down, then tab. I've already accidentally added several incomplete tag names (like "CA" for "CATALOG #" or "PU" for "PUBLISHER") and each time have to go deep into the advanced preferences to remove those entries.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: j7n on 2019-07-14 19:55:25
Add commonly used fields like Label / Catalog number to the standard fields in Advanced -> Display so you don't have to type the name at all.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-14 21:11:51
Beta 3 posted.

Properties crash has been fixed.
Some changes in visual appearance have been introduced.
Enter key behavior should now make sense. If it's still mishandled in some dialog/page, please post about it and it will be fixed.
Various accessibility issues have been fixed, checkboxes should be presented to screen readers properly.
Add new field autocomplete no longer hides fields already present.

The next update will bring more autocomplete behavior changes.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: j7n on 2019-07-14 22:07:03
The crash is fixed. The gridlines are now too heavy on a dark color scheme (on the main interface in Selection Properties). The UI is too busy with horizonal lines, including the group headings, and kinda old-school looking. The background of a selected row does not get shaded anymore, and the text disappears on some combinations of colors. On WinSeven, happens with Faded, Vintage (white gets a system-blue selection), and on WinXP happens with White as well. With Black, and Dark Grey the selection is not visible. All that was need was to make the shaded rows slightly more contrasted.

http://i.imgur.com/Jekqit4.png
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-15 08:06:44
Noted, beta 4 will be out soon.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TheQwertiest on 2019-07-15 10:33:23
Post a screenshot please so I can get a better idea what it looks like for you.
Sorry, missed your reply...

What I mean is this - flat Windows 10 style, no separators, everything blends in, which makes it harder to distinguish fields with just one look:
Spoiler (click to show/hide)

Smth like this would have been much better, IMHO (note the separators):
Spoiler (click to show/hide)
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: anamorphic on 2019-07-15 12:11:06
^ That looks nice. Agreed with above suggestions. I greatly prefer alternate row colors to grid lines. Just looks a lot cleaner, aside from matching the playlist.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-15 14:17:36
Beta 4 posted. Selection drawing regression has been fixed, column delimiters have been added as suggested.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TheQwertiest on 2019-07-15 14:30:21
Thanks! I would say that horizontal delimiter for table header would improve readability as well, but I'll live with the current UI =)
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TuNk77 on 2019-07-15 14:46:47
Thank you very much, Peter :D
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Vicas on 2019-07-15 20:10:48
In v1.5 beta 4, there is no horizontal scrollbar at properties window metadata and details tab (works on v1.4.6).
Also on artwork tab there is an empty tab or separator.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: VEG on 2019-07-16 07:25:50
A small graphical glitch on Windows 7:
(http://veg.by/z/2019-07-16-09-24-37-eb125c3e.png)
It looked OK on previous versions:
(http://veg.by/z/2019-07-16-09-24-23-fbc1b1b4.png)
Probably, it makes sense to move content of a tab a bit higher, like in the main window, just to hide this corner.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-17 23:11:50
In v1.5 beta 4, there is no horizontal scrollbar at properties window metadata and details tab (works on v1.4.6).
Also on artwork tab there is an empty tab or separator.

And now, ironically in beta 5, for some reason the Properties dialog's Details tab is far far wider than the widest field, meaning there's a horizontal scrollbar for no reason.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TuNk77 on 2019-07-18 00:34:57
Quote
And now, ironically in beta 5, for some reason the Properties dialog's Details tab is far far wider than the widest field, meaning there's a horizontal scrollbar for no reason.

This does not happen to me, on my portable install of beta 5:

(https://i.imgur.com/0Uixggu.png)
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-18 18:58:16
Ah, it only seems to happen if you resize the window vertically such that the vertical scrollbar appears.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-18 21:31:39
Reproduced and fixed truncated fields (per TuNk77's screenshots), fix will be out with beta 6 tomorrow.

Can't seem to trigger too wide Details columns.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-19 14:36:55
Can't seem to trigger too wide Details columns.

I've attached a video of it happening. Only happens if the Details tab is shorter than the contents and shows a vertical scrollbar.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Peter on 2019-07-19 14:55:00
Bug reproduced, thanks for the video, fixing.

.... fixed, beta 6 posted.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TuNk77 on 2019-07-19 20:37:03
I don't know if it's a bug or feature, but when editing metadata for multiple files, the properties windows scrollbar automatically scrolls to the right.
Just select a few tracks, let's say an album, click a field or press F2, then it scrolls to the right.

(https://i.imgur.com/bUovgWH.png)
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: foo2000 on 2019-07-19 21:24:33
In previous versions the column size in Metadata and Details tab was adjusted to the Properties Dialog window size. Longer fields were truncated (indicated by ellipsis). By mouse-over a tooltip was displayed with more information (but also truncated for very long fields).
Since beta 6 the column size in Metadata and Details tab is always adjusted to the longer tooltip, resulting in horizontal scrollbars. This change also leads to the effect described by TuNk77.
I liked the previous behavior much more.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: TuNk77 on 2019-07-19 21:32:51
I liked the previous behavior much more.

Me too
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-22 02:52:25
When editing values, the Item column on the Individual Values tab does not stay sized if you manually resize it. See the attachment.

No matter how wide you make the Item column, next time you open that Edit Value window, it goes back to being tiny again.. which is a pain when the track does not have any tags and just shows filenames.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-22 15:56:41
Another issue in beta 6.

If you open the Properties window and you have a horizontal scroll bar, if you double click in one of the fields to edit it, the window scrolls over such that only the Value column is visible. This means you can't see the name of the field you're editing anymore.

Video attached.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Snowknight26 on 2019-07-26 19:53:26
Another issue in beta 6.

If you open the Properties window and you have a horizontal scroll bar, if you double click in one of the fields to edit it, the window scrolls over such that only the Value column is visible. This means you can't see the name of the field you're editing anymore.

Video attached.

Also fixed in beta 7, woohoo!
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: foo2000 on 2019-07-26 23:37:46
When selecting some tracks with the same embedded cover and some tracks without a cover, the cover will be displayed in Artwork tab of Properties Dialogue. But because not all tracks have the cover embedded, "N/A; multiple items" would be the correct info.
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: j7n on 2019-07-27 11:03:12
Thank you for the removal of "nulling current selection info". Task switching or just opening dialogs inside the application has become a smooth experience!
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: Rollin on 2019-07-28 21:00:23
I want to ask: if option "Always preload complete info for N tracks" is gone in 1.5, what is default behavior now?
Title: Re: foobar2000 1.5 beta 1 properties bug
Post by: anamorphic on 2019-07-29 09:22:37
(There is still a typo under Preferences > Advanced > Display > Album List > "Seach box delay")
SimplePortal 1.0.0 RC1 © 2008-2019