Hydrogenaudio Forums

Hosted Forums => foobar2000 => 3rd Party Plugins - (fb2k) => Topic started by: MordredKLB on 2018-06-29 16:33:02

Title: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-29 16:33:02
(https://i.imgur.com/pspQQeb.png)

At long last I'm pleased to announce that my theme Georgia is available for public use. Georgia is a dynamically generated theme which uses album art to choose colors for it's panels. It was originally designed for running full screen on HTPCs, but also works well in a standard desktop environment. Georgia also looks amazing in 4k.

Gallery of what's possible with Georgia (https://imgur.com/a/TtjUS)

Inspired by XBMC/Kodi, I might have created the first fanart based fb2k theme years ago, and Georgia is the logical conclusion of that work. It supports band logos, record label images, cdArt/vinylArt, multiple covers, etc. It's designed primarily to look good, and look good on a big screen, so it is lacking some functionality that other themes have.

Get Georgia now (https://github.com/kbuffington/Georgia). Be sure to follow the installation instructions.

NOTE: Georgia is currently in beta. There will probably be some bugs/crashes. I'm pretty sure the lyrics display is not working correctly. I'm hoping some of you folks will be kind enough to help me test this out and iron out any kinks.

Components recommended for this theme:

This theme would not be possible without the hard work of Peter, marc2003, and TheQwertiest.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-29 16:34:28
Reserved
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2018-06-29 16:59:40
So you are that Mordred! I didn't connect until today, but the reason I got into foobar2000 is because about three years ago, while searching for inspiring music player layouts, I stumbled on this one (https://www.deviantart.com/mordredklb/art/WSHtpc-Mordred-0-8-0-427251767) which definitely looks like Georgia's forefather. Well, thanks for inspiring me  :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Vicas on 2018-06-29 17:09:18
Looks nice! I might give it a try. ;)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-29 17:09:46
So you are that Mordred! I didn't connect until today, but the reason I got into foobar2000 is because about three years ago, while searching for inspiring music player layouts, I stumbled on this one (https://www.deviantart.com/mordredklb/art/WSHtpc-Mordred-0-8-0-427251767) which definitely looks like Georgia's forefather. Well, thanks for inspiring me  :)
Haha, yep! If by some crazy chance you're still running that one, you should definitely upgrade. It hurts me to look at now (and I was running it up until December!) Glad you stumbled onto my stuff and the fb2k community!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-06-30 13:26:53
It doesn't load properly:

Code: [Select]
Error: JScript Panel v2.1.5.2 (Georgia by Mordred)
Error in JavaScript execution time:
'PanelProperties' is not defined
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\globals.js
Line: 2, Col: 1
<source text only available at compile time>

 :'(
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-30 21:23:53
It doesn't load properly:

 :'(
Thanks! Right before releasing I updated some file paths for TheQwertiest's playlist manager, but apparently didn't push the commit. There's a new release which should fix the problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-06-30 23:12:31
Got it working, thank you!

Hmm...

It crashes foobar if I add music through foo-input-spotify...
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-01 05:03:15
And this is why I need beta testers. Never used foo-input-spotify, but I'll check it out and see what's going on. Thanks for reporting!

Edit: The crash of foobar is either a bug in foobar itself or foo_input_spotify. What's causing it is attempting to retrieve %directoryname%. I was able to replicate it with 3 lines of Javascript. I reported a bug to Peter as I think it's foobar's problem, but can't tell for certain.

Skipping any calls that would process that field, I did run into a couple other issues which I've fixed but not pushed up yet. Doesn't look like I'm getting any album art though. Do you typically see art in other themes?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-07-01 12:17:33
Quote
... Doesn't look like I'm getting any album art though. Do you typically see art in other themes?

I was thinking that no art was possible through foo-input-spotify, at least not in the themes I tried (mainly foobox 4.2), buy yesterday I tried it with Br3tt js-smooth-playlist and it gets Spotiy art.



Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-01 15:45:34
Quote
... Doesn't look like I'm getting any album art though. Do you typically see art in other themes?

I was thinking that no art was possible through foo-input-spotify, at least not in the themes I tried (mainly foobox 4.2), buy yesterday I tried it with Br3tt js-smooth-playlist and it gets Spotiy art.
Yeah, I saw in the console it was attempting to retrieve art, but it didn't appear available to the theme. I'll need to look into that.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-02 00:52:38
I was thinking that no art was possible through foo-input-spotify, at least not in the themes I tried (mainly foobox 4.2), buy yesterday I tried it with Br3tt js-smooth-playlist and it gets Spotiy art.
I've got artwork working with spotify now, and fixed some crashes. Give it a try and let me know if you're still having issues there.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-07-02 12:30:28
 Wow! Working now with Spotify and showing the Spotify art!!! Also working the flags, band logos etc.

I'll tell you if something doesn't go.

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: TheQwertiest on 2018-07-04 13:41:19
MordredKLB: good job on the theme! Probably gonna end up stealing some features getting some inspiration from it :D
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-23 22:46:06
Version 0.9.9 released.

Change log:
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-12 08:58:14
MordredKLB, can you share a portable version, because I can not install it, yet I followed the information. thank you very much
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-08-13 05:53:05
MordredKLB, can you share a portable version, because I can not install it, yet I followed the information. thank you very much
Are you saying you have a portable version of foobar and it doesn't work, or you want me to give you .fcl files?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-13 08:04:43
MordredKLB, share portable version please, I want one. Thank
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: jazzthieve on 2018-08-13 23:12:10
He's probably asking for the complete foobar folder as portable.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-14 04:13:35
that's it, jazzthieve.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-08-14 16:49:03
I apologize, but that's not something I'm able to provide at the moment. I can try and walk you through the issues you're having installing the theme if you like. What exactly isn't working for you?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-14 17:44:54
JScript Panel v2.1.6 (Georgia by Mordred): initialised in 10 ms
Error: JScript Panel v2.1.6 (Georgia by Mordred)
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\polyfills.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\helpers.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\hyperlinks.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\js_marc2003\js\lodash.min.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\js_marc2003\js\helpers.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Common.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Utility_LinkedList.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\globals.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_ContextMenu.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_HtaMsgBox.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_HtaGroupPresetsMngr.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_Scrollbar.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_List.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Panel_Playlist.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_Button.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\color.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\themes.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\Image_Caching.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\georgia-main.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\lyrics.js
JScript Panel v2.1.6 (Georgia by Mordred): initialised in 8 ms
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-08-14 19:01:58
@IP974 Looks like the issue is your paths are wrong. It's looking for the theme in "C:\Users\hld97\Desktop\Georgia-master\foobar2000\" but it doesn't seem the files are there.

Find where those files are and move them to the correct location.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-11-03 05:34:35
v1.0.0 was just released (https://github.com/kbuffington/Georgia/releases). Major addition this time around is the integration of WilB's LibraryTree. There are also a ton of bug fixes, speed improvements, fit-and-finish updates, etc. It's a much more solid theme this time around, with a lot more configurable options in the Options menu.

A selected changelist:

As always, let me know if you have any issues setting this up.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-11-04 19:49:01
Working fine here, thanks!!
Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: 3vilgenius on 2018-11-05 18:31:05
Hi, I'm on a QHD screen and for somereason the scaling of the library tree gets really wonky and scrunched together when full screen. and it looks pretty small when it is not full screen up to a certain size. Not only that but the scroll bar will not go away even when unchecked in the options for that. I'm attaching a pic so you can see the scaling issue I'm talking about:  https://imgur.com/u4JzksF

Btw thanks for all your work on this, its just a plain beautiful theme and I look forward to helping let ya know the kinks I find.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: 3vilgenius on 2018-11-05 19:12:34
Also, what are the metadata sections for things like the Record label and such that I can add to file properties so that they will show up in the theme? Should I add to the metadata a section called "Record Label" and then add the name for example?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-11-05 20:41:24
Hi, I'm on a QHD screen and for somereason the scaling of the library tree gets really wonky and scrunched together when full screen. and it looks pretty small when it is not full screen up to a certain size. Not only that but the scroll bar will not go away even when unchecked in the options for that. I'm attaching a pic so you can see the scaling issue I'm talking about:  https://imgur.com/u4JzksF

Btw thanks for all your work on this, its just a plain beautiful theme and I look forward to helping let ya know the kinks I find.
Crap, I thought I had that fixed, and unfortunately no longer have a 4k display to test on.

For now you can right click on the background, select Properties, and then scroll down to the bottom and change user.row.height from the default of 20 to 40. That ought to fix the problem.

Also, what are the metadata sections for things like the Record label and such that I can add to file properties so that they will show up in the theme? Should I add to the metadata a section called "Record Label" and then add the name for example?
All metadata tag definitions are set in globals.js (although some reference Properties). Record label is a special case which currently exists, and already looks for both label and publisher tags. These are set in the tf.labels array in globals.js. If you're using another one, let me know and I can add it to that array so that other people don't have to manually update it.

If you want to add a completely new field you can do that in the tf.grid object. Just add a label, and then a titleformatting value.

Let me know if you're still having issues.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: 3vilgenius on 2018-11-29 00:53:39
Hey thanks for the info! It took me a while to remember this site. I'll let you know if I got any more problems for sure :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-01-25 18:00:52
I published v1.0.1 of this theme a couple days ago which was primarily a bug fix release.

Changelist:
 - Fixed a bunch of errors related to 4k mode
 - Added ability to set 4k detection mode (auto, always, never)
 - Pre-init Library tree after delay for snappier initial load of the library tab (if you wait 10 seconds first)
 - Much improved handling of long artist names (optimal font detection)

I've got some more stuff in the works so hopefully I'll have a 1.1 release out in a week or two.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-08 16:49:46
Hi @MordredKLB , I'm taking a look at your scripts because I'm trying to figure out how you managed to clip the graphic elements (including text) in the playlist view. I've been going through the Panel_Playlist.js script, especially the Row() function, but I was not able to extrapolate the code I'm looking for. Would you mind explaining how it works?










Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-08 18:15:10
Re-reading my previous post, I realized if I were you I wouldn't understand what I'm talking about. So here's a picture to illustratre what I mean:

Spoiler (click to show/hide)

If the playlist viewer was actually a panel itself, the x and y coordinates of the clipped elements on top (circled in red in the picture) would be virtually outside of the panel and only the pixels inside the panel area would be painted, but since the whole layout is just one panel, how did you achieve this effect? The drawimage function takes cropping coordinates, but what about the text?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-05-13 23:03:44
@davideleo First off in that screen shot you're missing the installed fonts. You should install them and restart foobar and things will look better :)

As for the clipping, that's something @TheQwertiest did in his CatRoX update, and I might have slightly modified for my theme (can't remember right now). For speed purposes, each group Header block is initialized only once and drawn in full to a header_image. Then we clip that header_image to the playlist "viewport". This does mean the playlist uses a much bigger memory footprint than you'd expect, but that's mitigated a bit because we only draw the Header the first time if at least one pixel is visible on the screen. Until that happens the header_image is undefined for every non-drawn header. Switching playlists will cause the entire cache to be destroyed (freeing the memory) and rebuilt if needed.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-13 23:39:13
@davideleo First off in that screen shot you're missing the installed fonts. You should install them and restart foobar and things will look better :)
Ah ah ah, I knew you were going to say that! I actually thought of cropping the screenshot, but it was too late to edit the post  :P


As for the clipping, that's something @TheQwertiest did in his CatRoX update, and I might have slightly modified for my theme (can't remember right now).
Yes, the scripts I've looking at were taken from the Catrox theme, but comparing it with the original ones I noticed your mods and I thought they were an adaptation to the singe panel environment, since Catrox is a multiple panel theme. I guess I'll take a look at the Catrox scripts and eventually ask @TheQwertiest. Hopefully your explanation above will help me understand the code better.
BTW I posted a more general question on the issue in the spider monkey thread.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-13 23:41:09
@davideleo First off in that screen shot you're missing the installed fonts. You should install them and restart foobar and things will look better :)
Ah ah ah, I knew you were going to say that! I actually thought of cropping the screenshot, but it was too late to edit the post  :P


As for the clipping, that's something @TheQwertiest did in his CatRoX update, and I might have slightly modified for my theme (can't remember right now).
Yes, the scripts I've been looking at were taken from the Catrox theme, but comparing it with the original ones I noticed your mods and I thought they were an adaptation to the singe panel environment, since Catrox is a multiple panel theme. I guess I'll take a look at the Catrox scripts and eventually ask @TheQwertiest . Hopefully your explanation above will help me understand the code better.
BTW I posted a more general question (https://hydrogenaud.io/index.php/topic,116669.msg971353.html#msg971353) on the issue in the spider monkey thread.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-05-14 18:29:41
Yeah, I did have to make some adaptations to handle the single pane stuff. Primarily though it was just that I now pass an X & Y offset everywhere in draw, resize callbacks, and then make sure it's handled properly so that the theme doesn't assume that it'll draw or clip against (0,0) but rather (xOffset, yOffset). It was pretty simple to get working though. Functionally that's the only difference I can remember between mine and TheQwertiest's version, although there is some cosmetic stuff. (The hyperlink code is also new to mine and does require some additional functionality, but it's still mostly cosmetic)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-14 21:05:26
...and then make sure it's handled properly so that the theme doesn't assume that it'll draw or clip against (0,0) but rather (xOffset, yOffset). It was pretty simple to get working though. Functionally that's the only difference I can remember between mine and TheQwertiest's version

That sounds exactly like what I was asking for! Would you mind explaining me in detail how you managed it or pointing me to the relevant code lines, as far as the playlist viewer is concerned?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 03:18:56
I'm playing around with the theme and it's growing on me a lot, but I have some questions:

1. The lyrics panel doesn't seem to do anything, it just doesn't load the lyrics to anything. Do I need a component (I can't see it documented anywhere) or is this a known bug?

2. Can I increase the font size in your playlist view? There seems to be a setting for it but if I increase the number it doesn't make any difference to the font in that panel.

Then, I also have a minor suggestion: It would be nice if the country field accepted codes and not just very specific versions of the names. United States is the form for the USA, but US and USA would also be good to have valid. Likewise, UK for United Kingdom. Ideally, it'd supported all of the standard two-letter and three-letter codes, I guess. It seems minor but it does save time if you're setting tags!

Finally, do you have a label suggestion thread or anything anywhere? I don't know how you decide which labels to add to the packages.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: jazzthieve on 2019-05-25 04:15:03
Then, I also have a minor suggestion: It would be nice if the country field accepted codes and not just very specific versions of the names. United States is the form for the USA, but US and USA would also be good to have valid. Likewise, UK for United Kingdom. Ideally, it'd supported all of the standard two-letter and three-letter codes, I guess. It seems minor but it does save time if you're setting tags!

It would probably only take a few seconds work to change all tags UK to United Kingdom and likewise for USA or US to United States. While it would be a bit more work for the developer to adapt only to your wishes.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 04:48:04
Then, I also have a minor suggestion: It would be nice if the country field accepted codes and not just very specific versions of the names. United States is the form for the USA, but US and USA would also be good to have valid. Likewise, UK for United Kingdom. Ideally, it'd supported all of the standard two-letter and three-letter codes, I guess. It seems minor but it does save time if you're setting tags!

It would probably only take a few seconds work to change all tags UK to United Kingdom and likewise for USA or US to United States. While it would be a bit more work for the developer to adapt only to your wishes.

Not sure why my comment needed your critique, it was reasonable feedback. All suggestions are adapting to someone or other's wishes and suggestions can be freely taken up or ignored. :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: jazzthieve on 2019-05-25 04:59:28
My critique was also very reasonable also given the fact it only takes a very small amount of effort, seriously about a couple of seconds work but somehow you're not willing. There's a word for that: laziness. That's why your suggestion needed some critical adjustments. Sure, suggestions can be taken up and ignored, and hope such a lazy suggestion gets ignored. Anything else?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 13:01:27
I really don't want to get into a flame war over something so trivial, I really like this theme and just wanted to offer a minor suggestion to the person (who I've spoken to before elsewhere, under other usernames though) who makes it.

I'll explain a bit more, though: Yes, I know I can just mass edit all of the tags, and I did that a long time ago in seconds. But the point is that as you're adding the information to new albums, it does take significantly longer to type "United States" than it does to type "US". Sure, it's a split second maybe, and you may find that pedantic, but a lot of foobar2000 usability things are about that split second, and the time adds up. After all, how many keyboard shortcuts can't just be accessed from a menu? Additionally, which I didn't mention because this was a minor minor suggestion that honestly didn't need five posts, but might be the better reason for suggesting this: It wasn't obvious how to get a U.S. flag to show - I tried US, USA and United States of America before United States. (Tip for others: It matches the spelling of the flag image files, minus the hyphens.) Supporting the variations would just make it a little bit more user friendly, but yes, it's a little thing and I wouldn't want nor expect a developer to slave over it if it wasn't easy for them. Their code may mean it's easy and they may be looking to build the theme into something with wide appeal, so it's still feedback I'd give. I'm sorry that you dislike that form of suggestion, but given this is a beta, it seemed fair.

To Mordred: Please don't mind us and do keep up your good work on this and AlbumArtDownloader things and so on :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 13:10:25
I have another question, also:

Is there a full list of tags that are supported for display in the information section (as in this: https://i.imgur.com/gigACuQ.png) on the theme? I've looked in the Properties list at the various settings but there's support for some with no reference there it seems. I'm struggling to figure out what the field name you use for Release Type is, for example. Also, is it easy (or possible to add as a feature) to customise what's shown, as in adding additional fields? For example, if I wanted to show a "Hometown" tag, is that something I can add to that area in the theme somewhere fairly intuitively?

(Edit: The Release Type field seems to be just %releasetype% but doesn't display if the type is Album, which I assume is your own choice of not having that data unless it's not an album. That'd be a nice thing to be able to toggle, if possible!)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 15:55:30
Just figured out my above post! For other users, there's a section in js/globals.js called tf.grid that has the list of metadata shown. You can reorder it there or add new fields, it's quite easy in any decent text editor. :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-06-11 17:05:08
Just figured out my above post! For other users, there's a section in js/globals.js called tf.grid that has the list of metadata shown. You can reorder it there or add new fields, it's quite easy in any decent text editor. :)
Yup! Sorry, I know the documentation is lacking in several areas. If I ever get time to work on this again.... :)

As for your flag question, there's a super simple solution (and one I might do as well). The flags I use come from gosquared's (https://github.com/gosquared/flags) repo of country flags. I have both 32x32 and 64x64 (for 4K) sizes, and just do simple pattern matching. If you're using the 4K setting, and your %artistcountry% value is United Kingdom, I just look for /images/flags/64/United Kingdom.png. If your %artistcountry% value is UK, then it won't find anything. Fortunately for you, gosquared includes their country flags by full name, and also by ISO code.

You can get the folder you need and just put them in the appropriate flags folder.
64x64 2-digit country flags: https://github.com/gosquared/flags/tree/master/flags/flags-iso/flat/64
32x32 2-digit country flags: https://github.com/gosquared/flags/tree/master/flags/flags-iso/flat/32

If you're not familiar with git, you probably don't want to download 200 different images manually. Go to the project root (https://github.com/gosquared/flags) and click the "Clone or Download" button in the top right, find the folder you need, and copy the contents to the flags/32 or 64 folder.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-08-10 01:11:19
I'm about to release a new version, but while everyone is waiting I've heard that it's hard to get older versions of foo_jscript that still works. Here's 2.1.4 which should work with the publicly available version of Georgia.

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: artins90 on 2019-08-10 23:45:23
There are no interface elements to control volume or did I miss something during the configuration?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-08-11 00:47:23
There are no interface elements to control volume or did I miss something during the configuration?
You're currently correct. I'm going to be testing out an option which will enable volume control shortly, so stay tuned.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-08-11 03:09:17
I officially released v1.1.0 this afternoon. Adds a Dark Mode and a whole bunch of other fixes.
(https://i.imgur.com/Eu9Q1Mv.jpg)

You can get it here (https://github.com/kbuffington/Georgia).

v1.1.0 Changelog - 2019-08-10
 - Dark mode (new default)! Switch between the two in the options menu
 - A ton more 4k fixes
 - Re-initing playlist when 4k mode switches to avoid scrollbar issues
 - accurate date difference code based on human accepted norms of what a date difference is (i.e. 1 month ago)
 - correctly handling forbidden characters when attempting to find artwork/files
 - better sorting of results when clicking on hyperlinks
 - searching dates by year only
 - Fixed a bunch of issues with Multi-channel display
 - Highlight colors in library/playlist should still allow text to be legible
 - Drastically reduced console spam
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: CyPha on 2019-09-09 11:29:17
Hi, nice theme you have here, i'd love to try it out, but so far i'm just getting this error once i've entered the TXT lines into the JS Panel

JScript Panel v2.3.0-Beta.2 (Georgia by Mordred)
JavaScript runtime error:
Wrong number of arguments or invalid property assignment
File: C:\Users\CyPha\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\js_marc2003\js\helpers.js
Line: 295, Col: 9
and 'aw crashed' on the main.

Thanks in advance for any help :)

Edit; these are my versions, FoobarCore 1.4.6, Georgia 1.1.3
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-09-10 17:59:20
Hi, nice theme you have here, i'd love to try it out, but so far i'm just getting this error once i've entered the TXT lines into the JS Panel

JScript Panel v2.3.0-Beta.2 (Georgia by Mordred)
jscript 2.3.x has breaking changes. I'll be updating the script in the next day or two to support it, but for now, stick with v2.2.2.4 and you should be fine.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-09-30 01:02:45
Thanks for the updates! I'm still getting used to the new dark mode but I'm sure I'll prefer in the end.

(https://i.imgur.com/sfNlXj5.jpg)

I'm keen to see what you might add from here. I do use a totally different tab for my library and browsing through albums, I do feel that the built-in feature isn't great, mainly because it seems to lag so much when opening it (I think it's to do with loading the art?), it would be amazing to have a way to browse albums that's as pretty as the rest of the theme!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-10-18 09:00:50
I've had a semi-persistent problem of Georgia crashing on startup with the "Aw, Crashed :(" on startup.

Just tried upgrading(Georgia -> 1.1.4, JScriptPanel -> 2.2.2.4), but it's still happening.

Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Spoiler (click to show/hide)

I did notice from my font viewer that the names seem to be ever so slightly different than the strings in my console:
Code: [Select]
Full Name: HelveticaNeueLTStd-Th
Full Name: HelveticaNeueLTStd-Lt
Full Name: HelveticaNeueLTStd-Md
Full Name: HelveticaNeueLTStd-Bd

I tried changing them all to have spaces (Ex. 'Helvetica Neue LT Std'), but that didn't seem to help.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-21 01:22:29
It crashes for me on startup or a little after startup too, but after I "Reload" the panel it doesn't do it again, so it's never bothered me much.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-21 22:38:43
It crashes for me on startup or a little after startup too, but after I "Reload" the panel it doesn't do it again, so it's never bothered me much.
If you send me the error line from the console, I can fix that for ya :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-21 22:50:07
I've had a semi-persistent problem of Georgia crashing on startup with the "Aw, Crashed :(" on startup.
Again, send me the error from the console and I can fix it.

Quote
Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Spoiler (click to show/hide)

I did notice from my font viewer that the names seem to be ever so slightly different than the strings in my console:
Code: [Select]
Full Name: HelveticaNeueLTStd-Th
Full Name: HelveticaNeueLTStd-Lt
Full Name: HelveticaNeueLTStd-Md
Full Name: HelveticaNeueLTStd-Bd

I tried changing them all to have spaces (Ex. 'Helvetica Neue LT Std'), but that didn't seem to help.
The font names of the files is not what Windows reports as the names. To see those, you need to open up "Font Settings" (on Windows 10 at least) and then find the font in the list there. Things might look okay, but if the test is failing then you aren't seeing the correct fonts and are probably falling back to Arial or something.

There will be a new release in a couple days to handle JScript 2.3.x and fix a couple other minor issues. As part of that release I will be including brand new fonts which will hopefully make things a little simpler.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-22 04:20:02
It crashes for me on startup or a little after startup too, but after I "Reload" the panel it doesn't do it again, so it's never bothered me much.
If you send me the error line from the console, I can fix that for ya :)

This is the error that appears:

Error: JScript Panel v2.1.8 (Georgia by Mordred)
JavaScript runtime error:
Unable to get property '0' of undefined or null reference
File: C:\foobar2000x\georgia\js\georgia-main.js
Line: 2991, Col: 2
<source text only available at compile time>
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-22 19:56:53
Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Are you using foo_ui_hacks? Marc2k3 pointed out to me there's an issue where if you're using the UI Hacks method to load fonts locally that Utils.CheckFont returns false even though the font is available to foobar. If that's the case you can safely ignore that warning.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-22 22:56:39
Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Are you using foo_ui_hacks? Marc2k3 pointed out to me there's an issue where if you're using the UI Hacks method to load fonts locally that Utils.CheckFont returns false even though the font is available to foobar. If that's the case you can safely ignore that warning.

Yeah, I think that's installed as part of my setup.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-23 04:08:18
Yeah, I think that's installed as part of my setup.
I was actually asking @f9fb4d656d but that's a good datapoint. What version of Windows are you on? If it's XP or Vista I've got an idea of what's going wrong.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-23 20:42:07
Yeah, I think that's installed as part of my setup.
I was actually asking @f9fb4d656d but that's a good datapoint. What version of Windows are you on? If it's XP or Vista I've got an idea of what's going wrong.

Oh, it's Windows 10...
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Fukuro on 2019-10-26 14:53:33
I'm bad at this...
How do I extract the component?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-27 15:08:00
Wow! Working now with Spotify and showing the Spotify art!!! Also working the flags, band logos etc.

I'll tell you if something doesn't go.



Updated to last version. Everything working fine except importing foo-spotify art

Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-29 17:17:55
Updated to last version. Everything working fine except importing foo-spotify art
What do you mean by "importing" exactly? Just that art isn't showing up from foo_input_spotify?

Also were you coming from Georgia 1.1.4 or an earlier version?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-30 09:54:46
Updated to last version. Everything working fine except importing foo-spotify art
What do you mean by "importing" exactly? Just that art isn't showing up from foo_input_spotify?

Also were you coming from Georgia 1.1.4 or an earlier version?

Actually I was using a previous versione. When updated to 1.1.5, it loads but then js panel crash. My foobar right now is a little bloated, will try with a fresh install with only the needed components.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-30 17:04:29
Actually I was using a previous versione. When updated to 1.1.5, it loads but then js panel crash. My foobar right now is a little bloated, will try with a fresh install with only the needed components.
Darn. Probably no easy way to determine what that version was then, unless you still have the old .zip file and can check out the top of globals.js.

When you say the js panel crashes, do you mean all the time (some are reporting a single crash at startup that I can't reproduce) or just when loading images from foo_input_spotify?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-30 22:46:36
Oki, I did a fresh install.
1.1.5 loads then crash, lods crash load crash, message is:
JScript Panel v2.3.1 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
El objeto no acepta la propiedad o el método 'GetLibraryRelativePath'
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Panel_Library.js
Line: 1205, Col: 224

It could be that Foobar is still scanning the library hard disk?
Windows 10, Foobar 1.5.beta 20

Ps. Tried with a previous version of Jscript Panel v.2.2.2 and the crash is no more.
Now it crashes when loading music from foo-input-spotify, and no spotify images are seen.
Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: WilB on 2019-10-30 23:23:09
GetLibraryRelativePath, which is causing the error, is incompatible with JScript panel v2.3.1. The new replacement method is significantly faster :) , but until its changed you can't use view by folder structure in the library panel. Since it's originally my panel I did offer to send @MordredKLB a version with the needed fixes a while ago. But it seems he wanted to wait until I released an updated version with the solution, or there was some confusion over the matter???

To stop Georgia 1.1.5/JScript panel v2.3.1 locking you out now, you can open (panel) properties, find SYSTEM.View By (its likely to be near the bottom of properties) and change it to 1. You will then be able to choose any of the available library views except View by Folder Structure because that will error.

HTH
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-31 05:44:56
GetLibraryRelativePath, which is causing the error, is incompatible with JScript panel v2.3.1. The new replacement method is significantly faster :) , but until its changed you can't use view by folder structure in the library panel. Since it's originally my panel I did offer to send @MordredKLB a version with the needed fixes a while ago. But it seems he wanted to wait until I released an updated version with the solution, or there was some confusion over the matter???
I had to make significant changes to your panel to get it to work in the theme (this is the issue with not using separate WSH panels for each piece of the theme). If you can send me the relevant changes I'll get them fixed ASAP, but unfortunately I can't just replace the file and have things work.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-31 10:24:54
The crash message with foo-input-spotify is:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setColors' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 1835, Col: 4
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-03 07:09:37
The crash message with foo-input-spotify is:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setColors' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 1835, Col: 4

Thanks for the debug help. Can you download this file https://raw.githubusercontent.com/kbuffington/Georgia/master/js/georgia-main.js and replace your existing georgia-main.js with it? Restart foobar and let me know if that fixes your problem with spotify. It might actually expose another issue so if you get a crash again, please post the file and linenumber like you did this time.

Unfortunately I don't have a Spotify premium account so I can't test this myself.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-11-03 19:00:04
Replaced Georgia.main.js.
Crashed when loading spotify album:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setPlayTimes' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 2610, Col: 2

Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-11-03 22:04:51
Yeah, I think that's installed as part of my setup.
I was actually asking @f9fb4d656d but that's a good datapoint. What version of Windows are you on?

I do not have foo_ui_hacks. I'm on Windows 10.
Spoiler (click to show/hide)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-11-03 22:14:36
Installed 1.1.5, new jscript panel, and all the new fonts. Still crashes on startup, but seems to work after a reload.

New dump of my console:
Spoiler (click to show/hide)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-04 01:22:26
Replaced Georgia.main.js.
Crashed when loading spotify album:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setPlayTimes' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 2610, Col: 2

Ys
Rozzo

I thought it might crash there. For some reason it seem on_playback_new_track() is not being called from foo_input_spotify. I'm gonna see if I can't borrow someones premium account for a day and try and figure this out.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-04 01:48:20
Installed 1.1.5, new jscript panel, and all the new fonts. Still crashes on startup, but seems to work after a reload.

New dump of my console:
This is super helpful. I think it's some kind of weird race condition that I can't duplicate. Let's see if I can't fix it on your machine though.

Can you open up georgia-main.js and find function createButtonObjects

At the very top of the function, right after the line that is btns = [] there's a 4 line if-else block. Can you delete that block and replace it with:

   if (ww <= 0 || wh <= 0) {
      return;
   } else if (typeof btnImg === 'undefined') {
      createButtonImages();
   }


Then close foobar and reopen and let me know if that fixes the problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-06 01:36:30
@katieinthecoconut You could also try replacing that code block to see if it fixes your problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: OryxCallotis on 2019-11-09 21:28:06
It seems like it crashes for me when I try to view my library by folder structure;

https://imgur.com/a/A6Q59ym

It looks like it's something to do with LibraryTree (https://hydrogenaud.io/index.php?topic=110938.0) that I think this skin uses;

http://i.imgur.com/YBmIWEM.png

The big issue is... I have no idea how to even make it stop trying to look via folder structure anymore. It's just an endless loop of crashing because I can't change it back.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-11 17:43:24
The big issue is... I have no idea how to even make it stop trying to look via folder structure anymore. It's just an endless loop of crashing because I can't change it back.
Yup, I have a fix, and will push an updated version of the theme tonight or tomorrow. I was hoping for some feedback from some of the other people complaining about different crashes first, but will just go ahead and hope someone else can test it later.

Until that happens you can stop the crash happening by going into Panel Properties, and changing the value of "SYSTEM.View By" to 0 (or any other number lower than what it's currently set to).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-14 05:51:33
v1.1.6 released. Let me know if you guys are still experiencing crashes.

I wasn't able to get a Spotify premium login. If someone is willing to share a password with me for a couple hours some day I wouldn't say no, but otherwise I'm not exactly sure how I can debug a baffling crash I can't reproduce.
SimplePortal 1.0.0 RC1 © 2008-2019