Hello!
I just sort of finished creating a new dsp plugin for foobar2000 that will enable the user to use directx audio plugins. Its working perfectly (I hope) except for the fact that I have no idea how to list the available dx plugins on the computer. This is where I need your expertise. Right now I hard coded the plugin to use iZotope Ozone dx plugin, but other users might want to use something else.
So any information about how to list the available dx audio plugins will be greatly appreciated!
/ Johan
In other words, do you mean a DirectShow filter wrapper? If so that sounds interesting.
I don't know the exact way of listing the avaliable ActiveX filters, but surely you'll have to deal with the Registry, under the CLSID branch. For instance, this is a good place to start:
HKEY_CLASSES_ROOT\CLSID\{083863F1-70DE-11d0-BD40-00A0C911CE86}\Instance\
Or get GraphEdit and try look the Registry keys it accesses with Regmon.
Good luck
I would guess the System Device Enumerator (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directshow/htm/enumeratingdevicesandfilters.asp) (well, probably the filter mapper would be more useful). Not sure what exactly "iZotope Ozone dx plugin" is though so could be wrong. But enumerating filters is explained in detail on the linked page.
Yes I mean a DirectShow filter wrapper.
I've tried using a System Device Enumerator already, but the problem is identifying which filters can actually be used for audio processing. There is a similar plugin for winamp named "Adapt-X" that can do this. It show a list with all "audio" filters and DMOs in the system. How it do this I dont know. I've tried to disassemble it to find out but my reverse engineering skills are too limited
I guess it would be possible to enumerate all available filters and create an instance of each filter. Then try to insert the filter into my graph which will call CheckMediaType() to determine if the filter can connect with my custom source filter. But this would take forever to do. Can I get this information without actually creating an instane of the filter?
/ Johan
/ Johan
You might be able to get enough information from the registry to do this. At least, this would give you a smaller amount of filters to enumerate. GraphEdit categorizes filters in this manner... you could snoop at what it's doing.
Yes I mean a DirectShow filter wrapper.
I've tried using a System Device Enumerator already, but the problem is identifying which filters can actually be used for audio processing. There is a similar plugin for winamp named "Adapt-X" that can do this. It show a list with all "audio" filters and DMOs in the system. How it do this I dont know. I've tried to disassemble it to find out but my reverse engineering skills are too limited
I guess it would be possible to enumerate all available filters and create an instance of each filter. Then try to insert the filter into my graph which will call CheckMediaType() to determine if the filter can connect with my custom source filter. But this would take forever to do. Can I get this information without actually creating an instane of the filter?
/ Johan
/ Johan
[{POST_SNAPBACK}][/a] (http://index.php?act=findpost&pid=358154")
Did you look at the filter mapper (from the lnked page, or [a href="http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directshow/htm/usingthefiltermapper.asp]here[/url])? You can specify the required input and output types of the filter. For example I use it to enumerate all MPEG-2 video decoders.
I can't say I'm too sure how much it would help in your case, so ignore me if you already looked at it.
The only information I can read from HKEY_CLASSES_ROOT\CLSID\{083863F1-70DE-11d0-BD40-00A0C911CE86}\Instance\ are theese values: CLSID, FriendlyName and FilterData. I think the filterdata key is what the System Device Enumerator matches a search against. I can't read it because its binary encoding is undocumented.
GraphEdit categorize the filters in categories defined here: http://msdn.microsoft.com/library/default....rcategories.asp (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directshow/htm/directshowfiltercategories.asp)
I've been trying to figure out how to create a search using IFilterMapper2::EnumMatchingFilters() to enumerate those filters that can be used. My problem is defining a search that separates the filters that can be used from the rest.
I tried searching for filters who's pins have a major type of MEDIATYPE_Audio but it return to many filters and refining the search with a minor type does not work because not all filters have the same minor type. For example iZotope Ozone have its pins minor type set to TIME_FORMAT_NONE while PCM Silence Suppressor have its pins minor type set to MEDIASTUBTYPE_WAVE.
I also tried combining a major search of MEDIATYPE_Audio with every pin category set for pPinCategoryIn parameter.
I'm kinda stuck!
Any ideas?
I don't have any other ideas (I haven't used DirectShow that much), except specifying multiple subtypes (though it sounds like you already tried that), or asking the Adapt-X author
BTW you mentioned enumeratating DMOs, the DMOEnum (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directshow/htm/dmoenum.asp) function can be used to enumerate those if you didn't notice that, I guess you want those in the category DMOCATEGORY_AUDIO_EFFECT.
I already asked the Adapt-X author but I never got a reply. DMOs are no problem. I'll just dig into it a little more and see if I can come up with something.
There are a couple of places to look:
http://msdn.microsoft.com/library/default....hingfilters.asp (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directshow/htm/ifiltermapper2enummatchingfilters.asp)
and the PlatformSDK, where the sample in
C:\Program Files\Microsoft Platform SDK\Samples\Multimedia\DirectShow\Misc\Mapper
and for DMOs:
C:\Program Files\Microsoft DirectX SDK (December 2005)\Samples\C++\DirectSound\EnumDevices
looks relevant.
I'd be interested to see whether your plug-in picks up my convolver, which comes in both DMO (Comvolver) and DX (convolverFilter/convolverWrapper) flavours (see http://convolver.sf.net) (http://convolver.sf.net))
Good luck!
Thanks for the tips. I'll check it out and see if I can make something out of it. I tried my plugin with that convolver filter. It did not work. I'm not sure why though. The error is that the input pin of the convolver filter will not connect with the output pin of my source filter. On the convolver homepage it say the filter support IEEE float which my source filter is using. I've downloaded the source for the convolver filter to see if I can make something out.
/ Johan
Which won't connect?
ConvolverWrapper or ConvolverFilter? They take 2 different approaches. (ConvolverWMP is effectively a DMO.)
What filter / config is loaded when you are rejected?
It goes without saying that the negotiation will not succeed unless the number of channels and sample rate match.
Both did not work, but I was to lazy to read how to use them. I tried ConvolverWrapper with Adapt-X (as a reference) and it worked. Then I tried ConvolverWrapper with my own plugin - did not work #ยค%#!!/(!
I'm not sure why, but I know where it goes wrong. I'll see if I can fix it.
/ Johan
The problem is that ConvolverFilter do its processing in a worker thread. When my source filters output pin call Receive() on ConvolverFilters input pin, Receive() return before it has done the processing. I must somehow wait until it has finished.
I tried to use an event like this:
MySourcePin::Deliver()
{
...
ResetEvent(hEvent);
hr = CBaseOutputPin::Deliver( pMediaSample );
WaitForSingleObject(hEvent, INFINITE);
...
}
and then set the event to a signaled state when the data is received by my render filter like this:
MyInputPin::Receive()
{
...
SetEvent(hEvent);
...
}
Unfortunatelly this only resulted in deadlock :/
Sugestions are welcome. In the meantime I just see if I can find some information about this problem
/ Johan
ConvolverFilter uses the standard DirectoShow filter classes provided by MS, so you will will want to make it work.
ConvolverWrapper wraps a DMO and is based on the DScaler5 code.
Once you have got past the threading issue, if it really is one, be aware that ConvolverWrapper/Filter should reject any solicitations until a filter is loaded (either as a WAV file or config file) because it is not until it has a filter that it can tell how many channels and sample rate it is using.
However, you should be able to pick it up as a filter that accepts audio:
const REGPINTYPES sudPinTypes[] =
{
{&MEDIATYPE_Audio, &MEDIASUBTYPE_NULL}
};
const REGFILTERPINS sudpPins[] =
{
{
L"Input", // Pins string name
FALSE, // Is it rendered
FALSE, // Is it an output
FALSE, // Are we allowed none
FALSE, // And allowed many
&CLSID_NULL, // Connects to filter
NULL, // Connects to pin
1, // Number of types
sudPinTypes // Pin information
},
{
L"Output", // Pins string name
FALSE, // Is it rendered
TRUE, // Is it an output
FALSE, // Are we allowed none
FALSE, // And allowed many
&CLSID_NULL, // Connects to filter
NULL, // Connects to pin
1, // Number of types
sudPinTypes // Pin information
}
};
const AMOVIESETUP_FILTER sudconvolverFilter =
{
&CLSID_convolverFilter, // Filter CLSID
TRANSFORM_NAME, // String name
MERIT_DO_NOT_USE+1, // Filter merit
2, // Number of pins
sudpPins // Pin information
};
:
STDAPI DllRegisterServer(void)
{
HRESULT hr = AMovieDllRegisterServer2(TRUE);
if (FAILED(hr))
{
return hr;
}
IFilterMapper2 *pFM2 = NULL;
hr = CoCreateInstance(CLSID_FilterMapper2, NULL, CLSCTX_INPROC_SERVER,
IID_IFilterMapper2, (void **)&pFM2);
if (SUCCEEDED(hr))
{
// Declare filter information
const REGFILTER2 rf2convolverFilterReg =
{
1, // Version number
MERIT_DO_NOT_USE+1, // Filter merit
2, // Number of pins
sudpPins // Pin information
};
hr = pFM2->RegisterFilter(
CLSID_convolverFilter, // Filter CLSID.
TRANSFORM_NAME, // Filter name.
NULL, // Device moniker.
&CLSID_LegacyAmFilterCategory, // DirectShow filter
NULL, // Instance data.
&rf2convolverFilterReg // Filter information.
);
pFM2->Release();
}
The filter connects perfectly to my graph once I've set a wav file as config. The problem is that my source filter keep Deliver()ing data to ConvolverFilter which in turn never seem to Deliver() any data to my render filter.
From msdn (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directshow/htm/imeminputpinreceive.asp) I read this:
Remarks
This method is synchronous and possibly blocking. The pin does one of the following:
* Rejects the sample.
* Returns immediately and processes the sample in a worker thread.
* Processes the sample before returning.
When I debug with iZotope Ozone, Ozone::Receive() does not return until the processing is done and MyRenderFilter::Receive() is called before Ozone::Receive() returns.
When I debug with ConvolverFilter, ConvolverFilter::Receive() return immediately and MyRenderFilter::Receive() is never called.
/ Johan
I fixed the problem. It was not a threading problem. I dug into the source of the baseclasses library and found out that a transform filter can return E_FALSE from its Transform() method and its Receive() method still return NOERROR. Thats why I thought ConvolverFilter was processing in a worker thread while in fact it seem to buffer the samples thus causing a delay before it in turn will start to Deliver().
I uploaded a sample you can try. This version is hard coded to load a filter named "ConvolverFilter". Tell me if its working correct. All I hear with this config is a lot of noise!
http://oern.mine.nu/tmp/foo_dsp_dxbridge.dll (http://oern.mine.nu/tmp/foo_dsp_dxbridge.dll)
http://oern.mine.nu/tmp/02.wav (http://oern.mine.nu/tmp/02.wav)
/ Johan
That's right: a common feature of convolvers is that you will get no output from them until you have submitted a half partition-length's-worth of data whereupon you will get half a partition out. Thereafter each half-partition submitted will get a full partition's worth out.
An S_FALSE result for Transform says "Do not deliver this sample" (which will be the case until that first half partition length has been submitted).
I am reasonably confident that ConvolverFilter works as it does so from within Adobe Audition.
I'll try this later. Do you get anything different with ConvolverWrapper?
Do you have a set of sources that you could let me debug from?
John
When I try to connect MySourceFilter::OutputPin with ConvolverWrapper::InputPin I get this error: VFW_E_TYPE_NOT_ACCEPTED
Is there any way for MySourceFilter::OutputPin::Deliver() to know what ConvolverFilter::Transform() return? The fact that ConvolverFilter::InputPin::Receive() does not propagate S_FALSE back to MySourceFilter::OutputPin::Deliver() make it imposible for me to know why MyRenderFilter never received anything. Was there an error or did the transform filter simply hold back the samples? What is the best way to respond to this? As I do now in the dsp plugin I simply ignore the fact that there was never any samples returned (error or deliberate) and put back the original samples in the audio_chunk.
I'll upload the source code for you. If you fix any bugs/add anything useful, please let me know so I can update my version too.
/ Johan
OK. Will do.
You can download the source code here: http://oern.mine.nu/tmp/(src)foo_dsp_dxbridge.rar (http://oern.mine.nu/tmp/(src)foo_dsp_dxbridge.rar)
I hope I dont violate anything by uploading
use the "release turbo" version of foo_dsp_dxbridge project.
All release versions are compiled using __fastcall. Debug versions are compiled using __stdcall.
You have to use my version of the foobar SDK/pfc etc to make it work.
I've modified the DXi SDK (dont remember where I got it)
Sorry if MY code is not very structured, but it grew as I learned how to do this. I've never done any DirectX programming before, nor have I done any FB2K development either. I'll clean it up later.
/ Johan
Thanks. Will look at this later. Know what you mean...
I have not managed to get very far as that with the code that you supplied.
The ConvolverFilter is initialized, and I can access its property page, but none of the internal routines (Transform, etc) seems to be called. Perhaps I am not attached to the right thread. (This is with the Debug build)
So playback seems to be unaffected.
Try amending to code to return S_OK, as the buffer length should still be correctly set to 0. All that S_FALSE does is say don't bother delivering it.
Bear in mind that ConvolverFilter is not an InPlace filter.
Does your code work with any of the sample filters such as Gargle (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directshow/htm/sampledirectshowfilters.asp)?
I am confident that ConvolverFilter negotiates its pins correctly as it works from withing GraphEdt.
Happy to continue testing, but perhaps you can give me a step-by-step on how to get to the point where you negotiate pins, call Transform, etc.
I have not tried with any of the sample filters. I'll do this.
Try amending to code to return S_OK, as the buffer length should still be correctly set to 0. All that S_FALSE does is say don't bother delivering it.
Where should I return S_OK? What buffer length should be set to 0 (by me or by ConvolverFilter?)?
I never tried the debug build of ConvolverFilter, just the installed release build. But I would guess that you can just load convolverFilter.cpp and set a breakpoint in CconvolverFilter::Transform(). Are you sure its loading the debug version and not a release version of the dll? When you start playback the filter is inserted into the graph and you can follow CDxFilterGraph::doCreateGraph() The negotiations of pins take place when the pins are connected, e.g.:
CHECK( m_pGraphBuilder->ConnectDirect( pOPin, pIPin, &mtSrc ) );
What I am saying is that I can debug and set a breakpoint in the ConvolverFilter constructor which is triggered, and which produces some traces. I also have a breakpoint on Transform, etc, but they are never triggered.
On the S_OK stuff, I was just referring to the Transform routine code.
I don't have the code here, but I don't remember a CDxFilterGraph::doCreateGraph()
Try setting a breakpoint in CTransformFilter::Receive() in transfrm.cpp as it will in turn call Transform(). Btw, if you "step into" return m_pInputPin->Receive(pSample); in the code below (taken from amfilter.cpp) should you not get into CTransformFilter::Receive() if you built ConvolverFilter with the debug version of BaseClasses?
CBaseOutputPin::Deliver(IMediaSample * pSample)
{
if (m_pInputPin == NULL) {
return VFW_E_NOT_CONNECTED;
}
return m_pInputPin->Receive(pSample);
}
The CDxFilterGraph class is the graph manager class that I use in my code. It's implemented in SDK\DXiClasses\DxFilterGraph.cpp
The doCreateGraph() is the function that inserts the filters into the graph and connect their pins.
Well I am still struggling to get to 2nd base.
In class CInitQuit I had to use the commented out code at the bottom of on_init(), instead of the main code, to get a bit further and get as far as DecideBuffer. All seemed OK.
I cannot, however, see how CDspDxBridge gets called. In particular, on_chunk never gets called, which may explain why no processing or transformation takes place in my setup.
Perhaps if you could amend your code and add some tracing I could look at it again.
Strange that CDspDxBridge::on_chunk() is never called. Is the constructor/destructor ever called? Perhaps the guid is not unique for your system? For me CDspDxBridge::on_chunk() gets called frequently during playback (and only playback).
If you use the commented out code at the bottom of on_init(), the line
hr = g_pGraph->SetFilter( pFilter );
should fail if you use ConvolverFilter. This because the properties have not yet been set. That is why I moved that part of the code into CDspDxBridge constructor.
Perhaps if you could amend your code and add some tracing I could look at it again.
Amend how? I mean it is working for me... What tracing do you want me to add? Sorry if I'm a bit slow so please be more specific.
Sorry, I don't have the code here, but I could not see how or where DspDxBridge got constructed. Tracing suggests that it does not get constructed in my setup, so I never get beyond OnInitQuit, which works OK.
I clearly need to get a tracing handle on the on_chunk stuff if I am to help on the deadlock problem that you have got to.
A new instance of CDspDxBridge is created by foobar2000 when playback is started and it is destroyed when playback stop. In the constructor of CDspDxBridge I create an instance of the graph and insert the filter created in on_init() into the graph.
I already fixed the deadlock problem...
Good. Happy to help test when you are ready.
Enumerate Directshow plugins?
Since you seem to be using Cakewalk's DXi2SDK, take a look at the example Host which has an example of how to enumerate Directshow DXi synth plugins. I think it first enumerates Directshow DX plugins then goes through the list and searches for DXi synth plugins. Anyway look in file PluginInventory.cpp in the Host folder of Cakewalk's DXi2SDK.
What's the licensing for your dxbridge sourcecode? BSD? GPL? Public domain?
I guess any license that does not violate Cakewalk's DXi2SDK. However I would appreciate if any bugfixes are reported back to me so I can work them into my own code.
I looked at the code in PluginInventory.cpp. It uses the same approach that I already tried, in vain
I looked at the code in PluginInventory.cpp. It uses the same approach that I already tried, in vain
[a href="index.php?act=findpost&pid=361493"][{POST_SNAPBACK}][/a]
Hmmm, If you skip the DXi check, it does enumerate all the Directshow filters using EnumMatchingFilters() which includes some stuff like audio compression managers. Maybe you need to tweak the parameters to match. Or you need some extra steps to remove stuff from the list that you don't want. Seems like the question of enumerating DX effects plugins comes up. Wonder why there is no example in DXi2SDK?
I think I saw another post by you using CLSID_LegacyAmFilterCategory. I have not tried that.
I've tried to tweak the parameters, but I always get to many filters or to few. I've been searching the registry for a "common DX audio folder" where clsid's are stored. But I never found a folder listing iZotope Ozone, ConvolverFilter and Ni GuitarRig Plugin. If I dont find a way to enumerate the correct filters I'll just enumerate every audio filter and then the user have to figure out for himself what filter work or not.
I already fixed the deadlock problem...
[a href="index.php?act=findpost&pid=360175"][{POST_SNAPBACK}][/a]
How did you fix it in the end?
The deadlock was caused by me when I added synchronization (critical section) to the code. I just removed the synchronization code and it worked fine.
I think I'm close now to finding out how to list "valid" audio filters. I'll post a new plugin when I'm done.
How is this wrapper coming on?
Sorry for taking such a long time. I've just been too busy lately. I'm moving to a new city and I've been away on job interviews. I'll try to finish it soon.
Has there been any movement on this wrapper. I'm really keen to see it!
i'm not using fb2k until this one comes out ..
i'm not using fb2k until this one comes out ..
This is good news indeed. Oern, please don't ever publish your plugin
There are millions more vst plugins, vst is the
way more common approach. Writing a dxi wrapper only because some izotope stuff is also available as dxi is a waste of human lifetime Just curious: Why didn't you write a vst wrapper?
well looking at this thread this seems to be the place to ask, sorry if it is off topic but i don't have a lot of directshow/directx knowledge.
At some point i was able to get adaptx to show "Convolver DSP plugin" in its list (which is i beleive the DMO), now i can't seem to get it to do this on another pc unless i replace its adaptx.cfg with the other. its still doesn't list the plugin however, only opens with it in the window.
graph edit shows it under DMO Audio effects.
is there a way to register DMO's or something, is that the reason adaptx isn't seeing it?
thanks guys and sorry for being a bit dumb and off topic!!
i'm not using fb2k until this one comes out ..
This is good news indeed. Oern, please don't ever publish your plugin
There are millions more vst plugins, vst is the way more common approach. Writing a dxi wrapper only because some izotope stuff is also available as dxi is a waste of human lifetime Just curious: Why didn't you write a vst wrapper?
SHHHH =) we want the wrapper!! =) =) =)
doing good bud, lets code, woohoo rawrr =)
thought that might get you going
Not much action on this... what happened to our coder?