HydrogenAudio

Hydrogenaudio Forum => Uploads => Topic started by: yandexx on 2005-01-19 14:28:54

Title: Killer sample
Post by: yandexx on 2005-01-19 14:28:54
Both Musepack encoder versions: 1.14 & 1.15s fail on this sample at all settings up to q10. This synthetic sample was created using Fruity Loops 4.5. It is repeated kick sound.
Title: Killer sample
Post by: cane on 2005-01-19 15:07:23
I tried encoding with Q2 (mppenc 1.15s) and paradoxically the result is better than the one obtained with higher quality settings (maybe still abx-able, but not as flagrant as with, say, Q5).

Bye.
Title: Killer sample
Post by: h.tuehn on 2005-01-19 16:21:04
Standard 44.1 16bit stereo sample.  Adding silence at the beginning helps that first beat, but the main problem is still there.  Xlevel doesn't help.  The sample, unlike most music you'll hear,does include true silence in between each beat.

...

Yes, mixing some low level sound into the sample makes a huge difference, from obvious to transparent (except at the start).
Title: Killer sample
Post by: naturfreak on 2005-01-19 19:05:21
I was curious, downloaded the sample and did a test encode with LAME, OggVorbis and Musepack 1.14, 1.15s.

The decoded version of both Musepack Samples shows in CoolEdit's Waveform Window wrong phasing of some of the 'pulses', which is very audible too.

I guess this is a bug of the musepack encoders. Both LAME and OggVorbis encoded samples are okay regarding phasing.
Title: Killer sample
Post by: ak on 2005-01-19 19:39:29
Quote
The decoded version of both Musepack Samples shows in CoolEdit's Waveform Window wrong phasing of some of the 'pulses', which is very audible too.
[{POST_SNAPBACK}][/a] (http://index.php?act=findpost&pid=266642")

Could you try this one: [a href="http://4nykey.nm.ru/tmp/mppenc-1.15s.zip]http://4nykey.nm.ru/tmp/mppenc-1.15s.zip[/url] (gcc compile).
Produces ~10kbps bigger bitrate on this one (at q5), but no such artifacts (afaics
Title: Killer sample
Post by: westgroveg on 2005-01-19 22:04:12
Quote
Quote
The decoded version of both Musepack Samples shows in CoolEdit's Waveform Window wrong phasing of some of the 'pulses', which is very audible too.
[{POST_SNAPBACK}][/a] (http://index.php?act=findpost&pid=266642")

Could you try this one: [a href="http://4nykey.nm.ru/tmp/mppenc-1.15s.zip]http://4nykey.nm.ru/tmp/mppenc-1.15s.zip[/url] (gcc compile).
Produces ~10kbps bigger bitrate on this one (at q5), but no such artifacts (afaics
[a href="index.php?act=findpost&pid=266651"][{POST_SNAPBACK}][/a]


Code: [Select]
ABC/HR Version 1.0, 6 May 2004
Testname:

1R = C:\Temp\teh sample 1_15s new.wav
2L = C:\Temp\teh sample 1_15s old.wav

---------------------------------------
General Comments:

---------------------------------------
ABX Results:
Original vs C:\Temp\teh sample 1_15s new.wav
   6 out of 17, pval = 0.928
Original vs C:\Temp\teh sample 1_15s old.wav
   17 out of 17, pval < 0.001

Tested at q7/insane, new encoder sounds transparent to me.
Title: Killer sample
Post by: h.tuehn on 2005-01-20 16:20:24
Quote
Quote
The decoded version of both Musepack Samples shows in CoolEdit's Waveform Window wrong phasing of some of the 'pulses', which is very audible too.
[{POST_SNAPBACK}][/a] (http://index.php?act=findpost&pid=266642")

Could you try this one: [a href="http://4nykey.nm.ru/tmp/mppenc-1.15s.zip]http://4nykey.nm.ru/tmp/mppenc-1.15s.zip[/url] (gcc compile).
Produces ~10kbps bigger bitrate on this one (at q5), but no such artifacts (afaics
[a href="index.php?act=findpost&pid=266651"][{POST_SNAPBACK}][/a]

Thanks.  That works great.

Apparently we just need the binary releasers to stop using lossy compilers. 
Title: Killer sample
Post by: Lefungus on 2005-01-20 16:34:07
Weird, the gcc compile for linux create bit-identical files to the MSVC compile for windows. ( talking about binaries hosted on musepack.net )

What settings has been used for this compilation ?
Title: Killer sample
Post by: h.tuehn on 2005-01-20 16:47:50
Quote
Weird, the gcc compile for linux create bit-identical files to the MSVC compile for windows. ( talking about binaries hosted on musepack.net )

What settings has been used for this compilation ?
[a href="index.php?act=findpost&pid=266862"][{POST_SNAPBACK}][/a]

All the settings.

Definitely not bit identical.  GCC is 132096 bytes.  Musepack.net compile is 80384.
Title: Killer sample
Post by: Lefungus on 2005-01-20 16:50:04
Quote
All the settings.

Definitely not bit identical.  GCC is 132096 bytes.  Musepack.net compile is 80384.
[a href="index.php?act=findpost&pid=266865"][{POST_SNAPBACK}][/a]


The linux compile, and the windows compile, the versions hosted on musepack.net produce bit-identical musepack files. And this with two different compilers, gcc and msvc.

Of course the executables themselves aren't bit-identical ...
Title: Killer sample
Post by: ak on 2005-01-20 16:53:49
Quote
Weird, the gcc compile for linux create bit-identical files to the MSVC compile for windows. ( talking about binaries hosted on musepack.net )

What settings has been used for this compilation ?
[a href="index.php?act=findpost&pid=266862"][{POST_SNAPBACK}][/a]

I checked with linux compile (built from sources), no such problem either.
Looks like resetting CFLAGS to defaults triggers that though. I'll try to play with cflags to figure which one helps.

...
Well, fwiw, simply adding '-march=i686' to those default (using svn from musepack.net) seems to be enough.
Title: Killer sample
Post by: naturfreak on 2005-01-20 17:38:45
Hi! Another confirmation from me. The sample is now transparent to me.

Is this modified version now a (official) recommend encoder?
If so, I suggest to change its name to 1.15t to avoid confusion about different versions with the same name.
Title: Killer sample
Post by: ak on 2005-01-20 18:13:57
To confuse things even farther, it ain't modified in any way, just other compiler used.
Title: Killer sample
Post by: Lefungus on 2005-01-20 18:20:15
Huh, we need to know first what is the cause of this.
This gcc compile has a different behaviour, not only with this sample. It's too early to just assume it is consistently better than the previous binary.

Random-guess: AK, can you try march=i686 and --ffast-math ?
Title: Killer sample
Post by: naturfreak on 2005-01-20 18:28:11
Quote
To confuse things even farther, it ain't modified in any way, just other compiler used.
[a href="index.php?act=findpost&pid=266887"][{POST_SNAPBACK}][/a]

Does that mean the bug was caused by the compiler used to code the 'original' release of musepack 1.15s for windows platform?
Title: Killer sample
Post by: Seed on 2005-01-20 18:28:38
1. It's too early to call anything 1.15t. A serious investigation is in order first. Will the person who compiled this binary please contact me?

2. The new binary creates different MPCs for many known problematic samples. Examples: Walkyries_short.ape (--insane): Official 1.15s = 257.1 kbps. New compile = 240.6 kbps. fsol.flac (--insane): Official 1.15s = 265.1 kbps. New compile = 263.8 kbps.

Please don't jump to conclusions before we know what's wrong. Don't forget that Nero and Wavpack failed in a similar way to the official mppenc build. We will test this thoroughly and post our conclusions.
Title: Killer sample
Post by: ak on 2005-01-20 18:29:49
fast-math is in default cflags already, which are:
-O3 -ffast-math -fomit-frame-pointer -funroll-loops  -fmove-all-movables -falign-jumps=5 -falign-loops=0 -falign-functions=5
So in the end at commandline gcc gets those + -mrach appended at the end.
Title: Killer sample
Post by: Seed on 2005-01-20 18:41:42
I want to know if anyone can come up with another sample that the new compile encodes differently and they can hear a difference between it and a file the official 1.15s compiles produce.

guruboolez, can you encode Walkyries_short with the new encoder and test if there's a difference in how it sounds?
Title: Killer sample
Post by: h.tuehn on 2005-01-23 12:57:53
Quote
I want to know if anyone can come up with another sample that the new compile encodes differently and they can hear a difference between it and a file the official 1.15s compiles produce.

guruboolez, can you encode Walkyries_short with the new encoder and test if there's a difference in how it sounds?
[a href="index.php?act=findpost&pid=266897"][{POST_SNAPBACK}][/a]

Guru deserves a rest.

mpc15s gcc vs. mpc15s msvc

All ABX tests done with --insane.  Tested each encoded version against the original.  No new problems introduced.  At the same time ... as a final test, I tried this out with the Bloch_Formule sample that I was able to ABX with 1.14.

Walkyries_short GCC 14/25
Walkyries_short MSVC 12/25
Fatboy GCC 11/25
Fatboy MSVC 14/25
BeautySlept GCC 14/25
BeautySlept MSVC 8/25
Bloch_Formule GCC 10/25
Bloch_Formule MSVC 17/25

Couple more notes:
* I tried encoding a couple albums with 15s GCC.  No obvious problems and the mpcscan tool verified all the frames were written correctly.
* The MSVC files are bigger (higher bitrate) than the GCC in all the samples other than teh_sample.

No more MSVC for me, thank you.  And a big thank you to ak for pointing this out.
Title: Killer sample
Post by: westgroveg on 2005-01-23 13:21:53
Anyone who wants a copy of ak's GCC compile (fixed encoder) can get it here (http://users.tpg.com.au/chirano/mppenc-1.15s.zip) until something else becomes available.
Title: Killer sample
Post by: Seed on 2005-01-23 14:30:41
The Musepack Development Team (including ak) is working hard on a complete solution. We're thoroughly testing the quality of new builds with the kind help of Frank Klemm. Please be patient and do not adopt ak's current build. teh_sample is not the only sample it deals with differently and it's too risky to assume it's ready for using.

We'll notify the community as soon as we have a fixed binary.
Title: Killer sample
Post by: westgroveg on 2005-01-24 00:38:50
Some more ABX tests by Pio2001 here (http://www.hydrogenaudio.org/forums/index.php?showtopic=30875) the results do not favor the GCC compile.
Title: Killer sample
Post by: Seed on 2005-01-25 18:32:23
Pio2001 is testing an encoder that sounds much better than the "GCC" one you all test. There's absolutely no reason to keep it. It's flawed. Please be patient and we'll release a new mppenc soon.

Edit: Don't panic. Only the first build ak released is flawed. There's nothing wrong with whichever official encoder you use. We did improve amnesia over the old GCC build from ak, but 1.15r and 1.15s are not inferior to our build, except for "teh sample" which is 100% fixed now.
Title: Killer sample
Post by: yandexx on 2005-01-25 20:23:53
G-R-E-A-T !
Title: Killer sample
Post by: Messo on 2005-01-27 10:11:19
I'm confused!!!

The bug in mppenc 1.15s MSVC is a bug that affects only one or two killer sample or is a "quality" bug that affects all track with a loss of quality??

GCC compile is better than MSVC compile??

And what it mean that bug 1.15s is fixed now?? There is a new version??

Thanks........
Title: Killer sample
Post by: Seed on 2005-01-27 11:06:53
Time for some order in the chaos we've created:

There is no bug in MSVC. We are experimenting with different compiler settings based on Frank's advice, to find out which ones are safe. ak's first GCC compile should not be used by anyone. It only fixed one obvious problem but it creates others.

The official Windows compiles are indeed made by MSVC but there is nothing wrong with them. My suggestion is to just wait one more day before the new official version is released for both Linux and Windows. You don't have to worry about 1.15s or which compiler was used. Stick to official builds only.
Title: Killer sample
Post by: Messo on 2005-01-27 11:23:53
Thanks Seed.....