HydrogenAudio

Hosted Forums => foobar2000 => Support - (fb2k) => Topic started by: regor on 2024-05-03 16:13:52

Title: Crash playing a missing item
Post by: regor on 2024-05-03 16:13:52
Attached 2 crash reports, but I can reproduce it anytime playing a missing item on a playlist. Have not been able to reproduce it on a clean install, but also zero clues about the problematic component.

Foobar 1.6.17

EDIT: removed logs.
Title: Re: Crash playing a missing item
Post by: Case on 2024-05-03 16:18:13
Both textual logs show foo_openlyrics activity right before the crash.
Title: Re: Crash playing a missing item
Post by: marc2k3 on 2024-05-03 16:46:45
Had a quick glance and it uses get_full_info_ref without try/catch. The SDK does warn that it will throw exceptions on failure...

https://github.com/jscript-panel/foobar2000-sdk/blob/8203adcce8efe20815d0dd93f5f48be5371a5aa4/foobar2000/SDK/metadb_handle.h#L131-L134


Title: Re: Crash playing a missing item
Post by: regor on 2024-05-03 16:59:45
Thanks, will open an issue at github then. I have been having theses crashes since months
Title: Re: Crash playing a missing item
Post by: regor on 2024-06-12 16:34:04
In case someone more has this problem and can't wait for a fix, if you are also using dead items daily. Here it is an updated version:

This one uses 1.8.1 version number
https://github.com/regorxxx/foo_openlyrics/releases/tag/c
And this one maintains the 1.8 version number
https://github.com/regorxxx/foo_openlyrics/releases/tag/b
Title: Re: Crash playing a missing item
Post by: sveakul on 2024-06-13 09:59:25
Version 1.9 is out now (https://github.com/jacquesh/foo_openlyrics/releases/tag/v1.9 (https://github.com/jacquesh/foo_openlyrics/releases/tag/v1.9)) but besides providing Regor's fix is a huge disappointment.  After waiting since October for a new version, still no requested additional sources added and no source ID option for found lyrics.  I've posted before to github but the developer does not seem overly concerned with user requests there.  Well, what is provided, is free and does work very well.