HydrogenAudio

Lossless Audio Compression => WavPack => Topic started by: martin.steghoefer on 2014-08-12 13:58:39

Title: Bug in WavPack 4.70.0
Post by: martin.steghoefer on 2014-08-12 13:58:39
Hi!

I couldn't find a bug tracker, so I'm posting the bug report here (as this is the "official" forum, I suppose the developers are reading this).

Version 4.70.0 of wvgain contains a bug that has been detected by the Mayhem software and has been reported to the Debian bug tracker:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=716478 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=716478)

The Mayhem test case can be generalized: The executable wvgain crashes with segmentation fault whenever given an invalid filename and the "-n" option. The reason is a call to WavpackCloseFile(..) on a NULL pointer as file handle, if the file couldn't be opened. I'm proposing the bug fix that I've already posted on the Debian bug tracker (URL given above).

Cheers,
Martin
Title: Bug in WavPack 4.70.0
Post by: martin.steghoefer on 2014-08-12 14:27:39
Link to the patch: https://bugs.debian.org/cgi-bin/bugreport.c...tt=1;bug=716478 (https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=segfault-closing-invalid-file-handle.patch;att=1;bug=716478)
Title: Bug in WavPack 4.70.0
Post by: bryant on 2014-08-15 19:19:09
Hi Martin,

Thanks for the patch; I'll get it in right away! 

There actually is an issue tracker in the GitHub repo, but I don't think anyone has used it; I need to make it clearer that WavPack is now hosted there.

Cheers,
David
Title: Bug in WavPack 4.70.0
Post by: martin.steghoefer on 2014-08-31 13:15:05
Oh, if I had known that, I'd have sent a pull request directly...
Title: Bug in WavPack 4.70.0
Post by: DARcode on 2014-10-04 18:16:26
Patched WvGain in the pipeline  ?
Title: Bug in WavPack 4.70.0
Post by: bryant on 2014-12-01 05:55:21
Patch has been applied in Git. Thanks again!