HydrogenAudio

Lossy Audio Compression => Opus => Topic started by: qduaty on 2013-07-31 22:49:01

Title: Opus GSPlayer plugin
Post by: qduaty on 2013-07-31 22:49:01
For those who still enjoy relatively good sound quality of some WinMo devices, like mine. ARMv4, 22% CPU on Marvell PXA 312 with stereo. Source code included.
Title: Opus GSPlayer plugin
Post by: derf_ on 2013-08-06 22:36:56
I just committed a number of win32 changes to opusfile. It'd be great if you could test and make sure they didn't break anything for you.
Title: Opus GSPlayer plugin
Post by: qduaty on 2013-08-08 18:36:11
Git version works as usual in VS2008 and mingw32ce, with obvious issues such as errno, _fseeki64(). Edit: Seems to no longer open non-ASCII filenames.
Title: Opus GSPlayer plugin
Post by: qduaty on 2013-08-10 11:51:15
Well, I know what is going on with my non-ASCII file names. The unicode conversion function does not read UTF-8 correctly on this platform (ARM win32) [edit: or at least in my builds: VS2008 and mingw32ce]. I also tried to replace it with MultiByteToWideChar() and it worked as expected.
Title: Opus GSPlayer plugin
Post by: derf_ on 2013-08-25 18:00:04
I also tried to replace it with MultiByteToWideChar() and it worked as expected.


Sorry, you're saying you had to replace op_utf8_to_utf16() with MultiByteToWideChar()?

Can you give some more detail about what doesn't work?
Title: Opus GSPlayer plugin
Post by: qduaty on 2013-08-27 10:32:41
Sorry, you're saying you had to replace op_utf8_to_utf16() with MultiByteToWideChar()?

Can you give some more detail about what doesn't work?

It looks like when compiled on wince/ARM, op_utf8_to_utf16() does not translate multibyte into unicode characters but returns something that looks like the first byte of not decoded multibyte characters.
Title: Opus GSPlayer plugin
Post by: derf_ on 2013-09-03 23:06:03
It looks like when compiled on wince/ARM, op_utf8_to_utf16() does not translate multibyte into unicode characters but returns something that looks like the first byte of not decoded multibyte characters.


Can you try https://git.xiph.org/?p=opusfile.git;h=779e...f5;a=commitdiff (https://git.xiph.org/?p=opusfile.git;h=779ea4dafdf5;a=commitdiff) and let me know if that fixes the problem?
Title: Opus GSPlayer plugin
Post by: qduaty on 2013-09-06 01:54:05
Can you try https://git.xiph.org/?p=opusfile.git;h=779e...f5;a=commitdiff (https://git.xiph.org/?p=opusfile.git;h=779ea4dafdf5;a=commitdiff) and let me know if that fixes the problem?

Seems to work now.
Title: Opus GSPlayer plugin
Post by: derf_ on 2013-09-06 07:33:46
Seems to work now.


Great! Thanks for reporting the bug and thanks for testing.
Title: Opus GSPlayer plugin
Post by: lightningrod on 2014-07-12 15:57:18
Can't believe good old WinMo gets this wonderful new trick. Thanks!