Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

2023-09-17 11:56:16

I'm using fb2k mostly with Musepack files on an Android phone (Samsung, arm64).
Bug is reproduced with v1.4-2023-07-31 (arm64).

With 1.4, when Media Library scanning is finished, "ReplayGain Scanner" shows that there is no info for Musepack files ("567 albums and 23 single tracks need scanning."), and this info is indeed not used when playing these files.
If I choose "Reload from tags" in that screen, it gets busy for ~1 minute, and finishes with no changes.
I have looked into "Console", there are no clues.

The same files are recognized without issues before v1.4.

This seems to be specific to Musepack - I tested v1.4 with a few mp3 and opus files, and their ReplayGain info is recognized correctly.

(P.S. I previously reported in https://hydrogenaud.io/index.php/topic,124278.75.html but there were no responses and I am guessing it's OK to post v1.4 bugs as dedicated threads since I saw others do so - hope I'm not breaking any rules)

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #1 – 2023-09-17 20:35:47

Could you try the latest beta?
S.th. tag reading related was fixed in 2023-08-07, not sure if this might have affected your bug to.

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #2 – 2023-09-17 21:25:06

I can try again some time soon.

(Downgrade after testing is a problem - everything is lost, including the media library.
so I'll need to plan ahead a bit, or get around downgrading by some other way.)

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #3 – 2023-09-18 12:21:18

Sorry, cannot confirm.

Perhaps ReplayGain info was scanned by old foobar2000 mobile but not saved to tags?

Nothing changed in my Musepack support code in years and it's 1:1 identical across all foobar2000 versions.

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #4 – 2023-09-18 18:33:18

Thank you for confirming it's nothing intentional.

No, ReplayGain info was scanned before copying the files onto the SD card in the Android phone.
Using `rsgain` utility with parameters "rsgain custom -a -s i" which writes the following tags:
"REPLAYGAIN_TRACK_GAIN"
"REPLAYGAIN_ALBUM_GAIN"
And some - using `r128gain` utility, which AFAIK writes the same tags.

v1.4-2023-07-31 also could not save the new RG tags for MPC files either. (after trying to scan directly inside fb2k mobile)

I'll try again with the latest beta as mentioned above, hope that would be it..

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #5 – 2023-09-18 18:56:22

Checked with v1.4-2023-09-18, the problem still reproduces.
I can try to prepare some minimal reproduction steps, would it help?

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #6 – 2023-09-18 19:46:36

The latest beta can read the tags that it has itself written, though. This is great news!
I can figure out what exactly it writes and replicate it on PC.

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #7 – 2023-09-18 21:53:50

I see, the difference is that when working with MPC files, fb2k now only recognizes ReplayGain tags built into Musepack header.

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #8 – 2023-09-19 11:46:58

OK, thanks for checking, looks like tag merging behaviors changed. I'll restore old behavior.

Re: Preview 1.4 Android - ReplayGain tags reading from Musepack files is broken

Reply #9 – 2023-09-19 19:38:20

Thank you so much!

(I thought of adding MPC native tagging in a script as a workaround, but it's not exactly as straightforward as I imagined at first -
as I saw I'd have needed to convert it to 2-byte int after applying this formula `(64.82 - gain) * 256` and writing it at the correct location in the file, I guess it'd be awkward to test and debug)