HydrogenAudio

Hosted Forums => foobar2000 => Support - (fb2k) => Topic started by: bison on 2013-02-01 06:25:33

Title: FLAC file that makes loud beeps in foobar
Post by: bison on 2013-02-01 06:25:33
Hi guys, running the latest version of foobar I get a good bunch of loud beeps in a tune so here's a sample(remuxed to MKA in order to avoid any reencoding): http://www.datafilehost.com/download-e6c1e344.html (http://www.datafilehost.com/download-e6c1e344.html)

You need to uncheck "Use our download manager and get recommended downloads" and click on the left DOWNLOAD button.

It passes all tests successfully in the official FLAC frontend, the decoded WAV file plays fine in foobar and there's no beep with madflac in MPC. I don't think I'm doing something wrong so if it really beeps, a bugfix would be amazing please
Title: FLAC file that makes loud beeps in foobar
Post by: Case on 2013-02-01 16:55:43
You could have posted a raw FLAC file without fearing it would get re-encoded on its own. Anyway, the file is corrupted. Flac.exe reports "ERROR, MD5 signature mismatch" and it can't decode it to wav without forcing decoding through errors. I suspect the only reason flac.exe decoded file doesn't sound so bad is that the PCM format clips the error to normal level. foobar decoded file has peak 65 thousand times above digital fullscale.
Title: FLAC file that makes loud beeps in foobar
Post by: bison on 2013-02-01 17:50:56
ORLY? I will check again, thanks for the notice. But on the original file, FLAC Tester says:

Quote
[1/1]   06 Misty In Roots - Judas Iscariote.flac...OK
1 files, 0 errors


And if I click on "TEST" in the FLAC frontend, I get:
Quote
flac 1.2.1, Copyright © 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

06 Misty In Roots - Judas Iscariote.flac: ok


You prolly get a MD5 notice because I obviously cut a small sample with MKVToolnix but the full file checks fine and plays perfectly with madflac(and other several audio players IIRC). Maybe MKVToolnix cut it in a nasty way, but it does decode to WAV without forcing "dec. through errors":
Quote
flac 1.2.1, Copyright © 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

06 Misty In Roots - Judas Iscariote.flac: done

-------------------------------------------------------------------------------

I can post the full file if it's allowed, or I can PM you a link as the file doesn't look damaged to me.
Title: FLAC file that makes loud beeps in foobar
Post by: bison on 2013-02-02 01:07:01
more testing:
Quote
flac.exe -t "06 Misty In Roots - Judas Iscariote.flac"

flac 1.2.1, Copyright © 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

06 Misty In Roots - Judas Iscariote.flac: ok

Quote
flac.exe -d "06 Misty In Roots - Judas Iscariote.flac"

flac 1.2.1, Copyright © 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

06 Misty In Roots - Judas Iscariote.flac: done


It glitches up in foobar so yeah, I guess a conversion to WAV in foobar isn't going to help much. Lemme know how I can send you the full file so you can see for yourself. Thanks!
Title: FLAC file that makes loud beeps in foobar
Post by: kode54 on 2013-02-02 08:22:48
You could try sendspace or mediafire, or anonfiles if you think they won't botch the files on their server like they have for me a few times, and PM the link to Peter.
Title: FLAC file that makes loud beeps in foobar
Post by: bison on 2013-02-03 05:01:41
Alright, here goes the full file then: [removed as per TOS #9]

It glitches up at 2'21 and there are other occurrences IIRC.
Title: FLAC file that makes loud beeps in foobar
Post by: Rollin on 2013-02-03 16:54:26
Really. In foobar this file glitches, but flac.exe decodes it with no problems.
Title: FLAC file that makes loud beeps in foobar
Post by: Peter on 2013-02-03 17:03:51
Problem being investigated, thanks for reporting.
Title: FLAC file that makes loud beeps in foobar
Post by: bison on 2013-02-03 22:00:33
Great news, thanks in advance
Title: FLAC file that makes loud beeps in foobar
Post by: Peter on 2013-02-04 09:54:46
Same problem as here:
http://www.hydrogenaudio.org/forums/index....showtopic=61792 (http://www.hydrogenaudio.org/forums/index.php?showtopic=61792)

According to the FLAC author himself, such file is corrupted.

I can make foobar2000 decode this correctly but it will cause a slight drop in FLAC decoding performance for everyone.

Issue does not affect other apps (such as standalone FLAC.exe) if they don't operate on 32-bit float audio samples.
Title: FLAC file that makes loud beeps in foobar
Post by: bison on 2013-02-04 12:40:46
Oh, well how about an extra option for pesky files? FWIW this file decodes fine in all the other players I tried and ppl with fast CPU's couldn't care less about a tiny extra load that would ensure that they never get loud beeps in their music IMHO.
Title: FLAC file that makes loud beeps in foobar
Post by: Porcus on 2013-02-04 14:10:19
I can make foobar2000 decode this correctly but it will cause a slight drop in FLAC decoding performance for everyone.


Depends a bit on what “correctly” should mean for a noncompliant file.

One might consider handling this by the file integrity verifier?  (Would there be the same performance penalty there? Is this an issue only with a certain encoder, and which is detectable by e.g. %__tool%?)
Title: FLAC file that makes loud beeps in foobar
Post by: EpicForever on 2013-02-04 19:23:37
How about setting in "Advanced\Decoding" or "Advanced\Playback" preferences - like "Enable alternative FLAC decoding routine (decreased performance, workarounds malformed FLAC files)" ?
Title: FLAC file that makes loud beeps in foobar
Post by: Dandruff on 2013-02-04 20:08:48
Who cares about performance in this case?
Title: FLAC file that makes loud beeps in foobar
Post by: lvqcl on 2013-02-04 20:34:11
But who cares about broken FLAC files?
Title: FLAC file that makes loud beeps in foobar
Post by: EpicForever on 2013-02-04 20:48:43
Who cares about performance in this case?


I can make foobar2000 decode this correctly but it will cause a slight drop in FLAC decoding performance for everyone.


Developer

But who cares about broken FLAC files?


Author of the thread
Title: FLAC file that makes loud beeps in foobar
Post by: bison on 2013-02-05 00:52:39
Well, there are both poorly encoded audio and video files out there and my file plays fine in all the other audio players I tried(and some of them process audio internally in 64fp for that matter). I don't really see how an end-user would care about a most likely unmeasurable performance drop if that would ensure that he doesn't get loud beeps in his music? But yeah, sure, an "enable error resilience at the cost of a slight performance hit" sub-option will do just fine
Title: FLAC file that makes loud beeps in foobar
Post by: Peter on 2013-02-09 12:56:40
Problem corrected in the new 1.2.3 beta. Because other optimizations have been added at the same time, it should be at least as fast as the old versions without the fix.

Additionally, the File Integrity Verifier component can now reliably detect such files.
Title: FLAC file that makes loud beeps in foobar
Post by: EpicForever on 2013-02-10 21:17:13
On File Integrity Verifier download site ( http://www.foobar2000.org/components/view/foo_verifier (http://www.foobar2000.org/components/view/foo_verifier) ) there's still version from 2009:

"Current version
1.1, released on 2009-10-05"

So I understand that it will be updated soon ?
Title: FLAC file that makes loud beeps in foobar
Post by: Peter on 2013-02-11 09:24:14
No, the FLAC decoder has been changed to tell the integrity verifier about these. No new verifier update needed.