Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Columns UI (Read 4577049 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Columns UI

Reply #3950
But it is never used, as the effort ends on the condition in is_available() above, because I always get host with the same GUID [FC0ED6EF-DCA2-4679-B7FE-48162DE321FC], regardless of where I add the panel. I thought that each host (main window, splitter, ...) have a different GUID, doesn't it?

You have some good points: basically the implementation is_available doesn't really make sense any more. Originally, it was to compare the host pointers when there was just a sidebar and toolbar area. The idea was to prevent you trying to add the (same single instance) panel twice in the sidebar or toolbars which I thought at the time would give confusing results (the panel would remove from the old location and be added at the new one). When the layout was added, each panel had a unique host (when in the layout area) and so this implementation did not make any sense any more. So I changed it to compare the GUIDs but this also doesn't make too much sense.

I think really just always returning true would be OK. But it seems like there are some issues on my end if you do that as a panel may get removed whilst the host is creating the panels, and it doesn't look like that is handled correctly. So leave it as is for now.

BTW: The horizontal and vertical splitter have the same host guid, but the other splitters, toolbar area, and root layout node have different GUIDs. I don't think these GUIDs are too relevant any more because the splitters can have multiple instances - these GUIDs used to represent fixed areas (toolbars or sidebar).

So, essentially (with the current is_available implementation) create_or_transfer_window is more likely to be called again if your panel is a toolbar. With live editing, it may be called as well (e.g. h/v splitter -> tab stack)

Also BTW: There is some helper that takes care of the implementation of some of these functions, see uie::window_base_t. I don't use that however, I only create multiple instance panels and so use uie::container_ui_extension_t instead. Anyway, if you use those you don't really need to worry about these details (and I have some control over them with SDK updates).

I would love to, but I'm limited by the underlying architecture I have no control over (namely it cannot render into multiple windows at once nor run in multiple instances). But I already had the panel working without any unexpected behaviour with dummy spacers created for the second and any subsequent instances, so if single instance panels are generally not recommended, I will just use that.
OK that is a reasonable reason  (Personally I would just stay away from such a crappy library but that is up to you). I am curious, is this a vis plugin? Anyway, i checked with a single instance panel and the layout editor (in prefs) does prevent you from adding multiple instances (apart from that loophole I mentioned). (It uses get_is_single_instance for this, but that should be implemented by the uie::window factory anyway) It does seem to be broken in live editing, however, hmm I'll have to investigate more there seems to be a few potential problems.
.

Columns UI

Reply #3951
ad is_available(), GUIDs, etc. -
OK, I see it's rather left-over functionality, so I'll stay with your original code.

Also BTW: There is some helper that takes care of the implementation of some of these functions, see uie::window_base_t. I don't use that however, I only create multiple instance panels and so use uie::container_ui_extension_t instead. Anyway, if you use those you don't really need to worry about these details (and I have some control over them with SDK updates).
Actually I saw the helper, but I need to do more things (particularly during the destroying, where it does just a DestroyWindow()), so I would rewrite most of the class anyway.
(Btw, are you sure there shouldn't be rather 'return !m_host.is_valid() || ...'  at imp_helper.h:29?)

Personally I would just stay away from such a crappy library but that is up to you.
Speak about Winamp plugins. (...)

I am curious, is this a vis plugin?
Yup, relevant thread.

Anyway, i checked with a single instance panel and the layout editor (in prefs) does prevent you from adding multiple instances (...) It does seem to be broken in live editing, however, hmm I'll have to investigate more there seems to be a few potential problems.

You are right, now when I tried it, it works in the preferences. Unfortunately I always tested it in the live editing mode only.
Full-quoting makes you scroll past the same junk over and over.


Columns UI

Reply #3953
Hi,  i think i found a little bug in the latest alpha version. or i misunderstood the feature:
in the filter panel i chose as field settings "Genre;Album Artist;Album;" but the field with "Album Artist" shows only music with $meta(album artist) not these files with tagged %artist%. i think it should use %album artist% behavior.
btw, 2 feature requests from me:
1. make the filter panel more like the facet element  (sorting, more columns, additionel info...)
2. add the possibility to hide the ng group header under certain circumstances like $if($not(%discnumber%),!noheader!,)
don't know if there are already mentioned ...
bye

Columns UI

Reply #3954
1. Filter panel doesn't use internal foobar2000 titleformatting. Requested and in the known requests list.
2. I second the request. Like if string returns empty or some predefined value then header is not shown.
Sharing delusions since 1991.

Columns UI

Reply #3955
I notice a weird bug, when choosing in windows explorer to play a folder in foobar.

When I delete tracks (with delete key) in the ng playlist the songs from the next group go into the group I deleted song from.

It seems to happen everytime when I delete songs from a group.

Columns UI

Reply #3956
Hi musicmusic,

Preferences - Playlist view - Columns
-> initially, there's no column name visually selected. If we select one, leave the window, come back, again nothing is selected. The problem: We have no indicator about which column we are currently editing. (Latest alpha).

Columns UI

Reply #3957
Hi musicmusic,

Are you going to update the album list panel, so that manual refresh will not be necessary any more, just like with the new foo_albumlist in 0.9.5?

Columns UI

Reply #3958
Rightclick on a playlist tab, "remove" --> nothing happens.
My bad, it was a write protected playlist.

Columns UI

Reply #3959
I notice a weird bug, when choosing in windows explorer to play a folder in foobar.

When I delete tracks (with delete key) in the ng playlist the songs from the next group go into the group I deleted song from.

It seems to happen everytime when I delete songs from a group.
Are you using the latest v3 version? If so, can you make a screen shot with the group headers of the current and next group visible, before and after the delete?

Hi musicmusic,

Preferences - Playlist view - Columns
-> initially, there's no column name visually selected. If we select one, leave the window, come back, again nothing is selected. The problem: We have no indicator about which column we are currently editing. (Latest alpha).
I see the bug, though it didn't trigger on my Vista. Should be fixed in next build.

Hi musicmusic,

Are you going to update the album list panel, so that manual refresh will not be necessary any more, just like with the new foo_albumlist in 0.9.5?
The panel is based on a older version of album list source code, so that will remain unchanged unless it is updated to a newer version of album list. I won't add it in to the old album list code, namely as it seems like too much unwarranted work and I have enough trouble understanding my own code

Rightclick on a playlist tab, "remove" --> nothing happens.
My bad, it was a write protected playlist.
Yes, though really it should disable the remove command in that case.
.

Columns UI

Reply #3960

I notice a weird bug, when choosing in windows explorer to play a folder in foobar.

When I delete tracks (with delete key) in the ng playlist the songs from the next group go into the group I deleted song from.

It seems to happen everytime when I delete songs from a group.
Are you using the latest v3 version? If so, can you make a screen shot with the group headers of the current and next group visible, before and after the delete?



Problem is over now with version 3, I didn't notice there was a new version out yet

Columns UI

Reply #3961
Quick question: is there any way to change the font/color of the filter panel?  If not, could that be added?  It's a pretty minor issue, but I strive for visual consistency

Columns UI

Reply #3962
I have little suggestion...it will be nice if columns ui allows to set background image on the play list.

Columns UI

Reply #3963
Hi musicmusic, just wanted to say Columns UI looks great, and I love the new NG Playlist. I think collapsible groups would be amazing, can you tell me how likely/ how soon it is that they'll be implemented?

Also, I am having trouble with some cwb_hooks in group headers. %cwb_activelist_duration% doesn't update either automatically or on play and stop when tracks are removed from the playlist, it only updates when you change focused playlist. I think a better solution would be the a new field called %group_length% or something, which would return the total group length (which would be preferable to playlist length for me anyway). Is this possible? It would be pretty cool. It would be nice to be able to align it on the right and still have album name on the left too.

Cheers.


Columns UI

Reply #3965
Hi musicmusic, just wanted to say Columns UI looks great, and I love the new NG Playlist. I think collapsible groups would be amazing, can you tell me how likely/ how soon it is that they'll be implemented?
I think I only ever said it would be unlikely  I really just want to finish up what I've got before I think about new features too much.

Also, I am having trouble with some cwb_hooks in group headers. %cwb_activelist_duration% doesn't update either automatically or on play and stop when tracks are removed from the playlist, it only updates when you change focused playlist.
The group headers do not support playlist/playback specific fields, and so do not update with notifications about those fields. Basically, if cwb hooks is relying on the component that executes the titleformat script to update on those notifications it is obviously broken.

I think a better solution would be the a new field called %group_length% or something, which would return the total group length (which would be preferable to playlist length for me anyway). Is this possible?
In the grouping script, that would require some hacks to get it to work (something like colour codes, but that's not really visible to users so much anymore). I don't really like these hacks so much. If you don't get it, you can't group by the length of the group. That's determined after it has been grouped. So (on my side) it would need some kind of place holder for it in the script instead, and evaluate those sometime later. So, it could be done, but it's a bit messy.
.

Columns UI

Reply #3966
This is most likely not a bug, but anyway...

Double clicking on the group title performs the action that is assigned to the double click on empty area. So instead of starting playing first track in the group I get Add files... window (assigned to Double Click on empty area).

o_o

Columns UI

Reply #3967
from memory Musicmusic said there is yet to be any additional functionality to the grouping > including assigning keys to clicking and double clicking on them.. this is a feature request > at present ironing out all bugs and finishing off existing features seems to be priority 1 then once thats signed sealed and delivered the extras be tacked on

Columns UI

Reply #3968
This is most likely not a bug, but anyway...

Double clicking on the group title performs the action that is assigned to the double click on empty area. So instead of starting playing first track in the group I get Add files... window (assigned to Double Click on empty area).

o_o

Yes, that is a bug, thanks for reporting. It's fixed for next version.
.

Columns UI

Reply #3969
I download the new columns UI recently, the NG playlist is so good. However, it doesn't have horizontal scrollbar, please add a option to display the scrollbar.

Columns UI

Reply #3970
Thanks musicmusic for the info. I see what you mean about group length- I guess it wouldn't make sense unless you could specify the grouping and the group display separately. I just found you can set playlist length in the playlist switcher, so that will do me instead.

I guess I'll have to keep my fingers crossed for collapsible groups, they'd be ace, but I don't want to bug you about it!

Cheers.

Columns UI

Reply #3971
Here's a few other feature requests.

1) In the Filter panel (with autosend disabled) there's no visual indication for middle-clicking. Maybe the clicked item should blink or become selected.

2) Scroll to the items added to the NG Playlist from the Filter on "Add to active playlist" action.

3) Support for mouse wheel scrolling when the items are dragged in NG Playlist.

 

Columns UI

Reply #3972
Hmm.  Can anyone else reproduce this?  Create a simple layout with a vertical split containing an autohiding toolbar (can be menu, buttons, whatever) and one of the two standard playlist views (hide captions for both).
Then mouse over the toolbar to make it show, and while it's showing, drag the minimize, maximize, or close buttons downward.  As in, click and hold on them and move the mouse down.
Does your mouse freeze up like mine does (until you alt+tab or hit the windows key or do anything to remove focus from the window)?

Weird. o_O

Columns UI

Reply #3973
Weird behaviour.
Selecting several styles from Filter panel results in playlist for repeated entries for tracks that have multiple selected styles tagged.
Sharing delusions since 1991.

Columns UI

Reply #3974
is it any way to have console as panel that i can use in my layout?

upd: solved