HydrogenAudio

Lossless Audio Compression => WavPack => Topic started by: bryant on 2023-02-12 04:01:55

Title: WavPack 5.6.2 imports ID3v2.4 tags
Post by: bryant on 2023-02-12 04:01:55
This is something I meant to add with the AIFF support because sacd_extract users have been asking for it (and making good arguments), but every time I looked at the spec I changed my mind. Well, here it is, and any testing on real ID3v2.4 tags (and v2.3 for that matter) would be greatly appreciated. I also added handling of the COMM tag, multiple values per item, and all the text encodings and picture types (e.g., "Cover Art (Artist)"). I have tested with with sacd_extract output in both dSF and DFF files, and with mp3tag on WAV and AIFF files.

Other minor improvements:

Attached is a set of universal Windows binaries built with mingw.

Thanks!
Title: Re: WavPack 5.6.2 imports ID3v2.4 tags
Post by: Porcus on 2023-02-12 19:30:15
Oh f**c, Windows Defender ... 
I guess that the only thing new that could trigger the trojan warning is "it being new in itself", the temporary lack of false positives reports.
Title: Re: WavPack 5.6.2 imports ID3v2.4 tags
Post by: bryant on 2023-02-14 00:23:27
Oh f**c, Windows Defender ... 
I guess that the only thing new that could trigger the trojan warning is "it being new in itself", the temporary lack of false positives reports.
I have no idea about this stuff. Matt packages WavPack with the Monkey's Audio distribution and he's always having trouble with my binaries flagged as viruses, and it doesn't seem to matter how old they are or where they're built (although Mingw seems to do better than MSVC).

I just ran this through VirusTotal (https://www.virustotal.com/gui/home/upload) and it came up with one detection out of 64:
(https://www.wavpack.com/files/VirusTotal.png)
  
Title: Re: WavPack 5.6.2 imports ID3v2.4 tags
Post by: Nejiro on 2023-02-19 13:40:48
This is something I meant to add with the AIFF support because sacd_extract users have been asking for it (and making good arguments), but every time I looked at the spec I changed my mind. Well, here it is, and any testing on real ID3v2.4 tags (and v2.3 for that matter) would be greatly appreciated. I also added handling of the COMM tag, multiple values per item, and all the text encodings and picture types (e.g., "Cover Art (Artist)"). I have tested with with sacd_extract output in both dSF and DFF files, and with mp3tag on WAV and AIFF files.

Other minor improvements:
  • Fix a bug where the screen output was sometimes wonky under Wine.
  • Obsolete .wvc files are always deleted when stand-alone .wv files are created.
  • Don't allow WavPack files to be the source in --raw-pcm mode.

Attached is a set of universal Windows binaries built with mingw.

Thanks!

The 64bit version of 5.6.2 is not there?
Title: Re: WavPack 5.6.2 imports ID3v2.4 tags
Post by: bryant on 2023-02-20 18:25:59
The 64bit version of 5.6.2 is not there?
For this test release I just wanted something everyone could use. The 32-bit executable should work anywhere a 64-bit version would work, and this one even works on XP. Also, the difference in performance for WavPack is hardly measurable from 32-bit to 64-bit.

Is there a particular reason you'd like a 64-bit version?
Title: Re: WavPack 5.6.2 imports ID3v2.4 tags
Post by: Nejiro on 2023-02-20 19:46:36
No, no particular reason, I'm using BatchEncoder on Windows 11 and I have a 64bit version.... Anyway if the difference between 5.6.0 (which would be the version I'm using) and 5.6.2 is only the import ID3v2.4 I can safely stay with 5.6.0
Thank you
Title: Re: WavPack 5.6.2 imports ID3v2.4 tags
Post by: bryant on 2023-02-21 03:25:07
Anyway if the difference between 5.6.0 (which would be the version I'm using) and 5.6.2 is only the import ID3v2.4 I can safely stay with 5.6.0
There are a few other minor improvements, but I agree that if you don't have a specific need for ID3v2.4 tag imports, then there would be no reason to upgrade until the official release. And then you'll be able to get a 64-bit version...  :)