Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Stopping the Musepack Decoder (Read 4728 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Stopping the Musepack Decoder

Support for Musepack files is almost complete for the Squeezebox/Slimserver - that's the good news.  I've worked on getting APE tags and the Musepack header parsed to allow appropriate album searching, etc through the Slimserver interface, and files play just fine through the system.

However, the problem we have is that when we stop playback, the decoder does not stop trying to decode.  When the LAME decoder is used for MP3 playback, it sees that there is an error in writing output, and stops, but mppdec seems to keep right on chugging along, dumping an error message (mppdec: write error: Invalid argument, repeat once more... or something like that) to the screen every ten seconds.  In order to stop it, you have to kill the process manually.

Is there any way we can get the default behavior of the decoder to change?  Maybe a flag could be set such that when a write error is found, the decoder terminates instead of repeating the error.

Any help here would be appreciated.  Thanks!

Stopping the Musepack Decoder

Reply #1 –
This is still an issue, and I think it'd take someone who has compiled the Musepack source code about 5 minutes to change for me - I think that having Musepack support in the Squeezebox/Slimserver code base is a very important addition, and would be a great thing for both the Musepack community and the users of the Slimdevices hardware/software...

I posted this to the MPC newsgroup as well, with no response...not sure where to turn next.

Stopping the Musepack Decoder

Reply #2 –
Quote
This is still an issue, and I think it'd take someone who has compiled the Musepack source code about 5 minutes to change for me - I think that having Musepack support in the Squeezebox/Slimserver code base is a very important addition, and would be a great thing for both the Musepack community and the users of the Slimdevices hardware/software...

I posted this to the MPC newsgroup as well, with no response...not sure where to turn next.

The source for the sv7 decoder should be on corecodec by now. I can't look at the moment i'm afraid due to being on a train

Christian HJW is coordinating mpc things, but he's on holiday at the moment (I think). I'd be happy to help you, but you'd best check if the source is there first.

sean

Stopping the Musepack Decoder

Reply #3 –
OK, well, I've been holding off on installing cygwin for too long anyway.  I've got the source for the decoder now.  I can make a minor modification to the wave_out.c file to simply exit the write_with_test loop if there's a problem writing it out for now, but long term, this should be some sort of command-line option.

Stopping the Musepack Decoder

Reply #4 –
Quote
OK, well, I've been holding off on installing cygwin for too long anyway.  I've got the source for the decoder now.  I can make a minor modification to the wave_out.c file to simply exit the write_with_test loop if there's a problem writing it out for now, but long term, this should be some sort of command-line option.

Cool. I'd PM christian with the problem, he can add it to the list of things to do

Stopping the Musepack Decoder

Reply #5 –
Quote
Quote
OK, well, I've been holding off on installing cygwin for too long anyway.  I've got the source for the decoder now.  I can make a minor modification to the wave_out.c file to simply exit the write_with_test loop if there's a problem writing it out for now, but long term, this should be some sort of command-line option.

Cool. I'd PM christian with the problem, he can add it to the list of things to do 

Musepack decoder 1.96 has the additional switches:
--retries xxx            (write retries for writing decoded audio, default: 4294967295)

- some bug fixes
- changed copyright notice


Musepack encoder 1.2 has the additional switches:
--retries xxx            (write retries for writing decoded audio, default: 4294967295)
--stereo                  (default, opposite of mono)
--mono                  (downmix to 1 channel)

- some bug fixes
- accept sample rates slightly different from 48/44.1/37.8/32 kHz (+/-1%)
- changed copyright notice


Replaygain source code
- slightly changed API, setting a sample rate do not reset album statistics, etc.
- slightly changed application notes to avoid too big jumps in title settings.
--  Frank Klemm
 

Stopping the Musepack Decoder

Reply #6 –
Where can I get a copy of the source for these?