Skip to main content ↑ ↓
Topic: aoTuV Patches, Vorbis 1.3.5 and Lancer (Read 22810 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #75 –
I am using the Archlinux AUR package. After updating the pkgsums to match the updated patch, the build fails on:

Code: [Select]
gcc: error: xmmlib.o: No such file or directory
(Full build log)

The build function uses:
Code: [Select]
./configure --prefix=/usr --disable-static

I removed "--disable-static" and then it worked.
Any insight?

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #76 –
Hello Isayama,

Great that few of us still enjoy this good mature format.

I have not looked into this in detail, but I have the old working version. The difference between old and new is this
Code: [Select]
diff libvorbis-aotuv_b6.03_2015-lancer.patch libvorbis-aotuv_b6.03_2015-lancer-v2.patch 
141c141
< +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.am	2015-09-11 15:18:53 +0000
---
> +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.am	2016-12-17 11:46:45 +0000
163c163
< +test_sharedbook_LDADD = @VORBIS_LIBS@ .libs/xmmlib.o
---
> +test_sharedbook_LDADD = @VORBIS_LIBS@ xmmlib.o
169c169
< +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.in	2015-09-11 15:12:20 +0000
---
> +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.in	2016-12-17 11:46:31 +0000
200c200
< +test_sharedbook_LDADD = @VORBIS_LIBS@ .libs/xmmlib.o
---
> +test_sharedbook_LDADD = @VORBIS_LIBS@ xmmlib.o

Enzo made the change for a guy who wanted to compile with 
Code: [Select]
--disable-shared --enable-static
parameters and for that we need this change. See Enzo's Edit3. Sounds like no-one tested that it does not work with original settings. Better would have been to version the patches.

Having said that if you patch the patch backward using this diff it should be good.

Having said that I am not sure... maybe even your current compile is just as good.

Triza
 

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #77 –
They are great patches (thanks Enzo). I did not spot any issues with the encodes. I did not train my ears for artifacts (deliberately) and I enjoy quality 3. Amazing that ~100 kbps produces quality which feels like transparent. Obviously this could not be the case without Aoyumi's tireless efforts.

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #78 –
The first patch has been updated again to fix the issues when compiling with different --[dis|en]able-[shared|static] options.

I regenerated lib/Makefile.in this time instead of modifying it by hand. This should fix all potential issues caused by the inclusion of new files in the patch (cpu.c and xmmlib.c).

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #79 –
Thanks a lot Triza & enzo, I confirm the build is successful after the fix with the aforementioned AUR package. Cheers!

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #80 –
Anybody has made a build with these patches for FFMPEG?

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #82 –
btw, there's vorbis 1.3.6 available.

libvorbis 1.3.6 (2018-03-16) -- "Xiph.Org libVorbis I 20180316 (Now 100% fewer shells)"

* Fix CVE-2018-5146 - out-of-bounds write on codebook decoding.
* Fix CVE-2017-14632 - free() on unitialized data
* Fix CVE-2017-14633 - out-of-bounds read
* Fix bitrate metadata parsing.
* Fix out-of-bounds read in codebook parsing.
* Fix residue vector size in Vorbis I spec.
* Appveyor support
* Travis CI support
* Add secondary CMake build system.
* Build system fixes

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #83 –
Quote from: madmax on
btw, there's vorbis 1.3.6 available.
Yes, I noticed. I'm working on updated aoTuV and Lancer patches. They should be ready this weekend.

Re: aoTuV Patches, Vorbis 1.3.5 and Lancer

Reply #84 –
easy mr. enzo, take your time.
 
SimplePortal 1.0.0 RC1 © 2008-2018