Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Biography Discussion (Read 133339 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

Re: Biography Discussion

Reply #775
It really shouldn't matter whether custom or default cache is used. I tried with both with your test albums.

As nobody else seems to have seen the issue, it's best to do further debug via pm. I'll send something shortly.

Re: Biography Discussion

Reply #776
It really shouldn't matter whether custom or default cache is used. I tried with both with your test albums.

As nobody else seems to have seen the issue, it's best to do further debug via pm. I'll send something shortly.

So autocache 0 or 1 is to change between default and custom.

Well, now with autocahe 0 it works well.  :-\  . I tried with all the albums that gives me problems and all of them works now

could be some mess up in the update process to the new version?

I'll tell you if I see something similar again but for now seems to go fine.

Sorry for making you waste time, I should have tried to do a clean start before report it.



Re: Biography Discussion

Reply #778
New Version: Biography v1.3.1

Enhancement and optimization of new features.

Thanks for the new features and bug fixes (that Wikipedia bug was an elusive m*f*  ;) )

Said that, I think I need a little help configuring the image sources the way I like.

I have two sources for cover and artists photo, discogs_tagger and biography panel.

discogs_tagger download cover images to $directory_path(%path%) as album art_[number] and artist photo to Musica\Data\artist_art\%DISCOGS_ARTIST_ID%\%DISCOGS_ARTIST_ID%_[number]

I would like to download all the possible images that biography can download to Musica\Data\art_img and  Musica\Data\rev_img even if there is already a valid cover in $directory_path(%path%)

And display
In cycle bio artist the images of Musica\Data\artist_art\%DISCOGS_ARTIST_ID% + Musica\Data\art_img
In cycle bio review the images of Musica\Data\rev_img + $directory_path(%path%)

But I'm not able to achieve it.

what would be the correct combination of folders and custom folders for that?







Re: Biography Discussion

Reply #779
If I understand you correctly you can try the following:

Photos

You should be able to set Musica\Data\artist_art\%DISCOGS_ARTIST_ID% as the photo > custom folder, which is checked first. If no images are found it will fallback to the download folder (Musica\Data\art_img).

So if you want the discogs photos, when images are available, enable menu> sources > photo > ...custom. If you want the art_img enable the menu> sources > photo > ...download folder.

If, as I believe you're on Wine and biography.cfg is being directly edited use, \\ not \ e.g. Z:\\Musica\\Data\\artist_art\\%DISCOGS_ARTIST_ID%

Review images

I'm not really sure why the rev_img is required if the album art cover is present. Consequently, the behavior is to only download rev_img if the cover is missing. To force it to get rev_img you could block loading of the album art cover until you have them. It's also possible to remove the check with a small edit:
Comment out lines 336 & 337 in server.js:
//const g_img = utils.GetAlbumArtV2(handle, 0, false);
//if (g_img) return;
I think that would be all that's needed in your case, but there are some tricky scenarios and so its not present as an option.

That should then save the rev_img.

Load:
1) $directory_path(%path%): e.g. use fb2k display > front. You can also use back cover etc if you have them.
2) rev_img: in covers: cycle folder (foCycCov) enter, e.g.  Z:\Musica\Data\rev_img (use \\ not \ if directly editing biography cfg)
    - note that your folder puts the review cover images by all artists in the same place
    - so adjust if you didn't mean that or include %BIO_ALBUMARTIST% & %BIO_ALBUM% in the path if you want one image per folder
    - either way the covers: cycle folder & review albumart save folder should be the same
3) On menu sources > cover enable: cycle above [set to front etc]  & cycle from folder

Re: Biography Discussion

Reply #780
If I understand you correctly you can try the following:

Photos

You should be able to set Musica\Data\artist_art\%DISCOGS_ARTIST_ID% as the photo > custom folder, which is checked first. If no images are found it will fallback to the download folder (Musica\Data\art_img).

So if you want the discogs photos, when images are available, enable menu> sources > photo > ...custom. If you want the art_img enable the menu> sources > photo > ...download folder.

If, as I believe you're on Wine and biography.cfg is being directly edited use, \\ not \ e.g. Z:\\Musica\\Data\\artist_art\\%DISCOGS_ARTIST_ID%

That's what I manged to do, 2 directories and change the display in the menu.
I wonder if there is a way to display the 2 directories at once. A menu entry like the one for cover folder and foobar default photos where you can select more than one source and all are displayed and cycled at the same time.

Review images

I'm not really sure why the rev_img is required if the album art cover is present. Consequently, the behavior is to only download rev_img if the cover is missing. To force it to get rev_img you could block loading of the album art cover until you have them. It's also possible to remove the check with a small edit:
Comment out lines 336 & 337 in server.js:
//const g_img = utils.GetAlbumArtV2(handle, 0, false);
//if (g_img) return;
I think that would be all that's needed in your case, but there are some tricky scenarios and so its not present as an option.

That should then save the rev_img.

Load:
1) $directory_path(%path%): e.g. use fb2k display > front. You can also use back cover etc if you have them.
2) rev_img: in covers: cycle folder (foCycCov) enter, e.g.  Z:\Musica\Data\rev_img (use \\ not \ if directly editing biography cfg)
    - note that your folder puts the review cover images by all artists in the same place
    - so adjust if you didn't mean that or include %BIO_ALBUMARTIST% & %BIO_ALBUM% in the path if you want one image per folder
    - either way the covers: cycle folder & review albumart save folder should be the same
3) On menu sources > cover enable: cycle above [set to front etc]  & cycle from folder

I understand the logic. In a normal case there is no need to download a new cover if there is already one, but with the cover downloaded from discogs there's a potencial use.

Sometimes these images are literal photos of the album over a table, have the stickers, prices, etc. or there are specific to the album release (Japan version for example).

Instead the last.fm, allmusic are usually a standard image of the cover.

With that edit, I can download the rev_img without checking if it is already present and use the default fb2k to have two folder. Clever

But i need to do it inversely.

Using the rev_img to the fb2k display because there is only one and point the cycle folder to the $directory_path(%path%) that contains more than one.

So I need to recreate "Z:\\mnt\\wd\\Musica\\Data\\rev_img\\$lower($cut(%BIO_ALBUMARTIST%,1))\\%BIO_ALBUMARTIST%", with %album artist% because %bio_albumartist% is not accessible outside the component right?.

In the default artist image I use this replaces to show one image from the script folder
Code: [Select]
['Z:\mnt\wd\Musica\Data\art_img\'$lower($replace($cut($meta(ARTIST,0),1),.,_))'\'$replace($if($stricmp($cut($meta(ARTIST,0),1),.),_$substr($meta(ARTIST,0),2,$len($meta(ARTIST,0))),$meta(ARTIST,0)),'/','-',':','-','?',)'\'*]

Will the same replaces work with bio_album, or I need something more?

And out of curiosity...what are the possible problems?

 





Re: Biography Discussion

Reply #781
Well, at least for the cover, I think I do it.

I edit the server.js.

In biography.cfg

Code: [Select]
   "foCycCov": "$directory_path(%path%)",
   "foImgCov": "Z:\\mnt\\wd\\Musica\\Data\\rev_img\\$lower($cut(%BIO_ALBUMARTIST%,1))\\%BIO_ALBUMARTIST%\\%BIO_ALBUM%",
   "foImgRev": "Z:\\mnt\\wd\\Musica\\Data\\rev_img\\$lower($cut(%BIO_ALBUMARTIST%,1))\\%BIO_ALBUMARTIST%\\%BIO_ALBUM%",

In fb2k cover display

Code: [Select]
['z:\mnt\wd\musica\data\rev_img\'$lower($replace($cut($meta(ALBUM ARTIST,0),1),.,_))'\'$replace($if($stricmp($cut($meta(ALBUM ARTIST,0),1),.),_$substr($meta(ALBUM ARTIST,0),2,$len($meta(ALBUM ARTIST,0))),$meta(ALBUM ARTIST,0)),'/','-',':','-','?',)'\'$replace($if($stricmp($cut($meta(ALBUM,0),1),.),_$substr($meta(ALBUM,0),2,$len($meta(ALBUM,0))),$meta(ALBUM,0)),'/','-',':','-','?',)'\'*]

In bio sources-cycle  from folder and front

I tried some albums and seems to work. Even display the cover from rev_img first  8)

With the folder you said, it didn't download the cover to rev_image\first letter\album artist\album artist - album.jpg,

This way it does to rev_image\first letter\album artist\album\cover.jpg

Good enough.

If it is possible to merge the artist photos, will be great, but if not I can live with 2 directories and changes between them.

Thanks a lot

Edit:

Even easier. foCycCov, foImgCov, foImgRev point to $directory_path(%path%). As the file downloaded is named cover didn't interference with the one downloaded with discogs tagger. Renaming the album art_ to scan_ to make them display after cover and voilä.
Fewer directories to managed, simpler scripts and more compatible with other softwares.

Re: Biography Discussion

Reply #782
Wilb
When I click the left mouse button on the image, I get the following error:

Error: Spider Monkey Panel v1.6.2-dev+fddbb743 ({DE304636-11CC-4453-A396-69E39A6D7564}: Biography v1.3.1 by WilB)
o.composer is undefined

File: text.js
Line: 1463, Column: 17
Stack trace:
  isTrackRevAvail@text.js:1463:17
  wikiRev@text.js:2099:29
  getText@text.js:1276:11
  getItem@text.js:1048:10
  click@panel.js:401:84
  on_mouse_lbtn_up@callbacks.js:181:79

I comment line 1460-1464 in text.js, and the error has disappeared.
My question is - what is the "isTrackRevAvail" function for?

Re: Biography Discussion

Reply #783
@paregistrase

I'm glad you now have it sorted.

Quote
...possible to merge the artist photos

I use the feature & in my case there are duplicates between the folders & I didn't want them merged. I checked a few discogs vs lfm ones and there seemed to be some duplication of images in those two sources as well. You can always merge them yourself into the lastfm download folder. I can understand you might not want to do that, but at least there is a solution. If you decide to try, I suggest using a back-up copy in case it doesn't work out. Make sure 'Image Filter Lastfm' in panel properties is off else the discogs images won't display.

@pIv
isTrackRevAvail should be fixed in the next version

It's used to set the grayed status of "Track review" on the load menu.

Also fixed for the next version is a regression in set language.

Re: Biography Discussion

Reply #784
I use the feature & in my case there are duplicates between the folders & I didn't want them merged. I checked a few discogs vs lfm ones and there seemed to be some duplication of images in those two sources as well. You can always merge them yourself into the lastfm download folder. I can understand you might not want to do that, but at least there is a solution. If you decide to try, I suggest using a back-up copy in case it doesn't work out.

The duplicates were one of the reason I want to merge them in the display, to be able to spot them and delete them.
I understand that it is not good to display duplicates to the general public.

Seems that I need to rethink my folder structure to artist pictures.