Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1372231 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

Re: foo_discogs

Reply #2275 –
Quote from: zoomorph on
Quote from: Just_Addict on
and a small buglet: "Edit Tag Mappings..." dialog doesn't remember window position in same session
It works for me.

Hi zoomorph,
for me, the "remembering" of the positions and the sizes of the different windows of your component does not work too. (most of the time)

Its kinda strange sometimes. Say, I place the edit tag mapping-window to the middle of the screen, but after closing it and open it again (no f2k restart meanwhile, just directly after closing the window) the window appears somewhere else on the screen. mostly in the right downer corner of the screen. but not everytime....thats odd. I couldnt reproduce, why the heck this happens.

Maybe an important information, I have 2 monitors plugged into my computer running w7 64bit. Maybe thats could be a reason?
I have no software running, which "optimizes" the position of an windows, I know, they exists, I have had uses some of them back with win98 :-)

This oddity happens to the following windows "find release" "edit tag mappings" "match tracks".

Thats not showstopper anyways, just wanted to mention, because I've read Just_Addict had the same thing ;-)

Re: foo_discogs

Reply #2276 –
Quote from: alec.tron on
I'd suggest an option to allow users to enable 'X.YY' so hidden tracks can get written/mapped as tags as:
- there's many old releases on discogs still with X.YY tracklist descriptors...
- even if a hidden track, I personally do extract these further, as to not have multiple single tracks inside a ginormeous file, in which case an option to 'unhide' these 'hidden' tracks, via X-YY / X.YY syntax (which would result in X-YY.ZZ syntax...? if there's hidden tracks on multi CD releases...?) would reqally help.
++1

As posted a long time ago (many posts up from here...), it would be very use- and helpful, if the user could set his/hers own/additional strings to identify a hidden track.

I try to update/correct as many releases as possible, on the dg-website, but on some releases, it seems, I does not have the privilege to change something..dunno why, other releases I can change w/o any problem.

Re: foo_discogs

Reply #2277 –
Quote from: zoomorph on
Quote from: a3aan on
That is exactly what I'm trying but having problems to get it right. When using the tracks example above
Code: [Select]
$join(%<TRACK_HIDDEN_TRACKS_TITLE>%,' / ')
results in Second / Third. But
Code: [Select]
$ifequal(%TRACK_TOTAL_HIDDEN_TRACKS%,0,%TRACK_TITLE%,$join($extend(%TRACK_TITLE%,%<TRACK_HIDDEN_TRACKS_TITLE>%),' / '))
or
Code: [Select]
$ifequal(%TRACK_TOTAL_HIDDEN_TRACKS%,0,%TRACK_TITLE%,$join($extend($array(%TRACK_TITLE%),%<TRACK_HIDDEN_TRACKS_TITLE>%),' / '))
results in just First. What is my mistake?
It works for me.
thank you, whoever came up with this! I've searched ages to something like this to skip manually glueing the tracktitles together.... what an ease now with this codesnipped! thanks again! (for me, the last ist workin fine!)

Re: foo_discogs

Reply #2278 –
Ok, after all the requests and other things I had to nag about, I'd like to say, that today, I worked off all my critical folders with a lot of releases, which had problems (crashes too) with older versions of this fine component. not always sure, why, but they had problems.
I sorted them to several folders like #hidden problem #error json #crash #naming wrong #various artists prob  etc...
and today ALL OF THEM could be easily tagged without any hassle. so easy. (about 20 folders, each a release on the discogs site!)
this component really is the best component for f2k! (maybe beside the components which are responsible for playing the audio and setting up the GUI...) ;-)
thanks and big hoorays for zoomorph! without him, we had an not so quite greatish component. cheers!

Re: foo_discogs

Reply #2279 –
hi,

I change the Configuration->Matching->Track Matching Options->Discogs track formatting string
from its default
Code: [Select]
$ifgreater(%RELEASE_TOTAL_DISCS%,1,%DISC_NUMBER%-,)$num(%TRACK_DISC_TRACK_NUMBER%,2) - $multi_if($multi_and(%ARTISTS_NAME_VARIATION%,$multi_not(%REPLACE_ANVS%)),%ARTISTS_NAME_VARIATION%$multi_if(%DISPLAY_ANVS%,*,),%ARTISTS_NAME%) - %TRACK_TITLE%$ifequal(%TRACK_TOTAL_HIDDEN_TRACKS%,0,,'  [+'%TRACK_TOTAL_HIDDEN_TRACKS%' HIDDEN]')
to this,
Code: [Select]
$ifgreater(%RELEASE_TOTAL_DISCS%,1,%DISC_NUMBER%-,)$num(%TRACK_DISC_TRACK_NUMBER%,2). $multi_if($multi_and(%ARTISTS_NAME_VARIATION%,$multi_not(%REPLACE_ANVS%)),%ARTISTS_NAME_VARIATION%$multi_if(%DISPLAY_ANVS%,*,),%ARTISTS_NAME%) - %TRACK_TITLE%$ifequal(%TRACK_TOTAL_HIDDEN_TRACKS%,0,,'  [+'%TRACK_TOTAL_HIDDEN_TRACKS%' HIDDEN]')  [$multi_if($multi_strcmp(%DISCOGS_TRACK_HEADING%,-),, ► )]"

(thats only adding [$multi_if($multi_strcmp(%DISCOGS_TRACK_HEADING%,-),, ► )])

but after a restart of f2k my changes are overwritten by the default settings.

I guess this is a bug, or intentional, then why is the field editable? or I've got a problem in my code :-) but it works, as long as I don't restart f2k...

Re: foo_discogs

Reply #2280 –
Quote from: fuffi on
this component really is the best component for f2k! (maybe beside the components which are responsible for playing the audio and setting up the GUI...) ;-)
thanks and big hoorays for zoomorph! without him, we had an not so quite greatish component. cheers!
+++1
Is there any send-some-thanks&support-to-zoomoph way via paypal/etc btw ?
Churs.
c.

Re: foo_discogs

Reply #2281 –
Quote from: fuffi on
this is quite old, but it does not work after a few tests:

on this release,  %RELEASE_DAY% is set to "  1988" instead of the original "20" (with the components default string on %RELEASE_DAY%
I guess, its not possible to convert every possible dateformat?
If release day is not defined in the database, then %RELEASE_DAY% is an empty string.

Quote from: fuffi on
Unfortunately, this snipped of code does not work, when inserted into the Edit Tag Mappings Window as a formatting string for DISCOGS_FORMAT.
I tried several combinations, but most always got an empty tag, or this strange error message:
Quote
(FATAL) Error: Error generating tag DISCOGS_FORMAT [Corrupted array string: missing start byte] for file file://C:\test\08 Planet Jazz - Mucho Chocolate.mp3

[ESCAPE to close]
I tried to get rid of the $puts() and $get() but that did not help in any way.

What am I missing to get this piece of code working as a formatting string?
You are using a builtin foobar2000 string formatting function on a foo_discogs array, which doesn't work. You can only use the $multi functions provided by foo_discogs to operate on arrays. Possibly a new function would need to be added for what you want to do. (?)

Quote from: fuffi on
hi,

I change the Configuration->Matching->Track Matching Options->Discogs track formatting string
from its default

but after a restart of f2k my changes are overwritten by the default settings.
This was a bug. :-)

Re: foo_discogs

Reply #2282 –
Version 2.05 is now released. Changes:
- HTTPS is used for everything. This should fix the error some users encountered above on Windows 10.
- "View Artist Art Page" has been re-enabled, now that Discogs has finally updated the URL for it to match all their other newer style URLs.
- Duration columns in match track lists are right-aligned.
- Matching window formatting strings were not being saved properly.

Glad to hear the positive feedback.  ;)

My paypal is jsilver.pmc@gmail.com if you wanted to support my work on this.
 

Re: foo_discogs

Reply #2283 –
Hi zoomorph,

thanks for the new release.
 
Is the oAuth / Internet access issue when used on Linux with wine fixed as well?

Re: foo_discogs

Reply #2284 –
Translated as was possible within my limitations this plugin for the Portuguese of Brazil, leave it attached.

Re: foo_discogs

Reply #2285 –
Hey @zoomorph, thanks for the update!

I'm wondering how difficult it would be to make the "Find Release" filter match each word independently rather than phrases - so you can put in the name of an album and then also, say, a label name, and see any row that contains all those words (in any particular order)?
I think it's been talked about before, and it may be a pain in the ass :) But it'd be a pretty awesome addition when there are lots of different versions of a release!

Re: foo_discogs

Reply #2286 –
Quote from: SpaceAgeHero on
Is the oAuth / Internet access issue when used on Linux with wine fixed as well?
Afair, zoomorph wrote some time ago, that he cannot test every wine/*nix enviroment for glitches or other instability.
So YOU (SpaceAgeHero) have to download the updated component yourself, test it very well and tell US if it works or not.
That way, others can benefit from your activity as well.

Quote from: frogworth on
I'm wondering how difficult it would be to make the "Find Release" filter match each word independently rather than phrases - so you can put in the name of an album and then also, say, a label name, and see any row that contains all those words (in any particular order)? I think it's been talked about before, and it may be a pain in the ass :)
+1
It was talked about that before and I think/hope, it found its way on the todo-list, but we never know what or when something is happening :-)
but the code is moving, I can see it 8-)

Re: foo_discogs

Reply #2287 –
Quote from: fuffi on
Unfortunately, this snipped of code does not work, when inserted into the Edit Tag Mappings Window as a formatting string for DISCOGS_FORMAT.
What am I missing to get this piece of code working as a formatting string?
Quote from: zoomorph on
You are using a builtin foobar2000 string formatting function on a foo_discogs array, which doesn't work. You can only use the $multi functions provided by foo_discogs to operate on arrays. Possibly a new function would need to be added for what you want to do. (?)
Ah, ok, thank you. Now I know, what is wrong, but not how to fix it ;-)
Hmm... dunno, if a new function will be needed for just delete a comma at the end of an string?

Re: foo_discogs

Reply #2290 –
Quote from: frogworth on
I'm wondering how difficult it would be to make the "Find Release" filter match each word independently rather than phrases...
This will be changed in next release.

Quote from: fuffi on
Quote from: fuffi on
Unfortunately, this snipped of code does not work, when inserted into the Edit Tag Mappings Window as a formatting string for DISCOGS_FORMAT.
What am I missing to get this piece of code working as a formatting string?
Quote from: zoomorph on
You are using a builtin foobar2000 string formatting function on a foo_discogs array, which doesn't work. You can only use the $multi functions provided by foo_discogs to operate on arrays. Possibly a new function would need to be added for what you want to do. (?)
Ah, ok, thank you. Now I know, what is wrong, but not how to fix it ;-)
Hmm... dunno, if a new function will be needed for just delete a comma at the end of an string?
Now that I look at it, I think the default format string for DISCOGS_FORMAT is not good. I think it should be replaced with this instead:
Code: [Select]
$zip(%<RELEASE_FORMATS_QUANTITY>%,' x ',%<RELEASE_FORMATS_NAME>%,$multi_if($put(D,$join(%<<RELEASE_FORMATS_DESCRIPTIONS>>%)),', ',),$get(D))
This will also be changed in the next release.

Re: foo_discogs

Reply #2292 –
Quote from: zoomorph on
Now that I look at it, I think the default format string for DISCOGS_FORMAT is not good. I think it should be replaced with this instead:
Code: [Select]
$zip(%<RELEASE_FORMATS_QUANTITY>%,' x ',%<RELEASE_FORMATS_NAME>%,$multi_if($put(D,$join(%<<RELEASE_FORMATS_DESCRIPTIONS>>%)),', ',),$get(D))

Personally I like to drop the '1 x' using this code
Code: [Select]
$replace($zip(%<RELEASE_FORMATS_QUANTITY>%,' x ',%<RELEASE_FORMATS_NAME>%,$multi_if($put(D,$join(%<<RELEASE_FORMATS_DESCRIPTIONS>>%)),', ',),$get(D)),'1 x ',)
Which can be done more elegantly, I suppose.

Another thing, are the free text part(s) of the format descriptions mapped into some attribute?

Cheers.

Re: foo_discogs

Reply #2293 –
Good afternoon, I searched but did not find the option to delete my own posts, would like to remove the post I made earlier, does anyone could direct me how I do it or an administrator erase my previous post this?

Re: foo_discogs

Reply #2294 –
Quote from: a3aan on
Personally I like to drop the '1 x' ...

Another thing, are the free text part(s) of the format descriptions mapped into some attribute?
Good point... the original goal of DISCOGS_FORMAT was to roughly mimic how Discogs prints the release format string. Next release will include the custom text part of a format and default format string will drop the "1 x ".

Re: foo_discogs

Reply #2295 –
Version 2.06 is now released.
Changes:
- New TEXT field of FORMAT object, exposes the custom format text.
- New $zip2 function which is the same as $zip except that it works if the left side is an empty string, unlike the poorly-named $zip.
- Default DISCOGS_FORMAT string now includes the TEXT field, does not include "1 x " when format quantity is 1, and avoids printing a trailing comma when there are no format DESCRIPTIONS. (Mimicking what Discogs' website prints.)
- Find release filter works on multiple words independently. Words are split by spaces. (There's no way to use quotes to change this behavior.)

Note: If you are updating from an older version and want to use the new DISCOGS_FORMAT tag, you have to right click on it and "restore default" in the Edit Tag Mappings dialog.

Re: foo_discogs

Reply #2297 –
Brilliant.
Also, not sure as it's on & off and not 100% reliable, but there seems to be a difference ? i.e. the pre-matching seems much more accurate. Before 2.0.5 I often needed to manually re-order, now, even if the target file names aren't numbered w track release, it seems to do some title/filename matching in the background and re-shuffle accordingly to the best of its abilities ?
This is great! Or am I imagining things and this was all coincidental...?
Cheers.
c.

Re: foo_discogs

Reply #2298 –
wow, things changing and improve quickly :)

Quote from: zoomorph on
Version 2.06 is now released.
- Default DISCOGS_FORMAT string now includes the TEXT field, does not include "1 x " when format quantity is 1, and avoids printing a trailing comma when there are no format DESCRIPTIONS. (Mimicking what Discogs' website prints.)
works like a charm!

will test more the next days... thank you zoomorph!

but now, with this release I'd like to join the artists of hidden tracks the same way, I join the titles of hidden tracks, but I can't get it to work...

I found this neat snippet for joining the track-titles:
Code: [Select]
$ifequal(%TRACK_TOTAL_HIDDEN_TRACKS%,0,%TRACK_TITLE%,$join($extend($array(%TRACK_TITLE%),%<TRACK_HIDDEN_TRACKS_TITLE>%),' / '))
which will join hidden tracks like: "hidden track1 / hidden track2 / hidden track3"....

Now, when I try to adapt this code to the existing default formatting string for the artists
Code: [Select]
$joinnames(%<ARTISTS_NAME>%,%<ARTISTS_JOIN>%)
, I get confused with the join/joinnames and extend/array options I have. (unfortunately, my version of the help-file does not include an explanation for $joinnames() )
I get either an empty string, or an errormessage.

May I ask for any advice, on how to use $joinnames(%<ARTISTS_NAME>%...) to replace
Code: [Select]
%TRACK_TITLE%,$join($extend($array(%TRACK_TITLE%
to have the artist joind together, like i.e. "artists 1; artists2; artist3" ? (semicolon as a seperator)