Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1372228 times) previous topic - next topic
0 Members and 3 Guests are viewing this topic.

Re: foo_discogs

Reply #2050 –
Quote from: fuffi on
for this release: 2538551
I got:
(FATAL) Error: Error loading release 2538551: JSON Parser ExceptionError parsing release credits.
Release credits are not entered correctly. Probably this:
"tracks: 1 to 5, 6 to 9 to 12"

Re: foo_discogs

Reply #2051 –
Hi,
Quote from: zoomorph on
Quote from: fuffi on
for this release: 2538551 I got:
(FATAL) Error: Error loading release 2538551: JSON Parser ExceptionError parsing release credits.
Release credits are not entered correctly. Probably this: "tracks: 1 to 5, 6 to 9 to 12"
I'm not sure, I understand...
Does that mean, the data on DiscoGS is not correct?
You talk about the little word "to" instead of an comma or another separator?
If yes, if've seen this many times, and it does not caused an error yet. I.E. https://www.discogs.com/de/de/release/3070176 which is tagging fine here.

Could you please explain more?


Also,
I got a crash (very rarely), while opening more than one artists at once


Code: [Select]
http://pastebin.com/0huZDPTB

Re: foo_discogs

Reply #2053 –
Updates:
* Remove "back" button from preview dialog when updating tags
* Fix crash when press cancel on preview dialog when update tags
* Fix crash when delete a tag in preview dialog
* Fix crash when updating tags of file with no DISCOGS_RELEASE_ID tag
* Skip over releases if nothing changed when updating tags

Re: foo_discogs

Reply #2054 –
Hi Zoomorph

I realize that multi-disc tracklist parsing issues must be far from your favorite subject these days, but bear with me...

Simon & Garfunkel ‎– The Complete Albums Collection, https://www.discogs.com/release/6719102, has an interesting and loopy result, where it seems to reset every disc to disc 1 track 01 for every heading inserted. I even went through the tracklist a while ago and changed all the dots to dashes, as that has solved problems with other multi-disc releases in the past, but no dice.
It seems possible that the number of headings being lower than the number of discs might trip up the probably already fairly convoluted tracklist parsing algorithm in foo_discogs, I thought of inserting dummy headings in order to try getting my tags fixed, but you ought to have a chance to look at it first, if you care to.  O:)

Re: foo_discogs

Reply #2055 –
Quote from: zoomorph on
Updates:
* Remove "back" button from preview dialog when updating tags
* Fix crash when press cancel on preview dialog when update tags
* Fix crash when delete a tag in preview dialog
* Fix crash when updating tags of file with no DISCOGS_RELEASE_ID tag
* Skip over releases if nothing changed when updating tags

First off, thank you for all the work in updating the component. It is most appreciated. With that, is it possible to update the version from 1.52? With v1.56 being out there, every time I open up fb2k my update component keeps popping up to update foo_discogs.
Thanks again.
Surf's Up!
"Columnated Ruins Domino"
 

Re: foo_discogs

Reply #2056 –
Quote from: roscar on
Simon & Garfunkel ‎– The Complete Albums Collection, https://www.discogs.com/release/6719102, has an interesting and loopy result, where it seems to reset every disc to disc 1 track 01 for every heading inserted. I even went through the tracklist a while ago and changed all the dots to dashes, as that has solved problems with other multi-disc releases in the past, but no dice.
Looks OK for me. Are you using the latest development version, or the officially released version?

Quote from: drbeachboy on
With that, is it possible to update the version from 1.52?
Will do that for the next build, thx.

Re: foo_discogs

Reply #2057 –
Quote from: zoomorph on
Quote from: roscar on
Simon & Garfunkel ‎– The Complete Albums Collection, https://www.discogs.com/release/6719102, has an interesting and loopy result, where it seems to reset every disc to disc 1 track 01 for every heading inserted. I even went through the tracklist a while ago and changed all the dots to dashes, as that has solved problems with other multi-disc releases in the past, but no dice.
Looks OK for me. Are you using the latest development version, or the officially released version?
The dev version. Attached a couple pics.

Edit: 1.56 from last year works fine for me too. I'd rather use the bleeding edge dev version though. :)

Re: foo_discogs

Reply #2058 –
Have you restarted foobar2000 or pressed "Clear cache" since updating the release on Discogs? I don't see that problem... :-)

Re: foo_discogs

Reply #2059 –
Quote from: zoomorph on
Have you restarted foobar2000 or pressed "Clear cache" since updating the release on Discogs? I don't see that problem... :-)
Yep. Several times over days and weeks actually, reboots too of course. Now I've tagged the files with 1.56 rel I can't reproduce the problem with newest "1.52" dev...
Maybe letting fb2k do the 1.56 update fixed something internally, and while I was at it I updated fb2k to 1.3.10 from 1.3.9, so...
I really have no idea what went wrong, or later right for that matter, but now you have some screenshots to entertain coders with. :P

Re: foo_discogs

Reply #2060 –
Updates:
* Window position is remembered for all dialogs (until restarted)
* Version string set to 2.0.1

Re: foo_discogs

Reply #2061 –
Quote from: roscar on
Quote from: zoomorph on
Have you restarted foobar2000 or pressed "Clear cache" since updating the release on Discogs? I don't see that problem... :-)
Yep. Several times over days and weeks actually, reboots too of course. Now I've tagged the files with 1.56 rel I can't reproduce the problem with newest "1.52" dev...
Maybe letting fb2k do the 1.56 update fixed something internally, and while I was at it I updated fb2k to 1.3.10 from 1.3.9, so...
I really have no idea what went wrong, or later right for that matter, but now you have some screenshots to entertain coders with. :P
Continuing the saga I suddenly had another release do the same trick. Only thing I've changed from default was the image-renaming, and that was just changing "cover" to "discogs", leaving the rest of the line the hell alone. But hitting he "Defaults"-button fixed it anyway. I'm at a loss here, probably my fault, but now I can at least get it to work. That was 1.52 dev, I'll swap it for 2.01 dev now. Fingers crossed...

Re: foo_discogs

Reply #2062 –
Lots more changes made... could be some new bugs. Getting close to the point where this version can be officially released.

Updates:
* Update tags "Prompt" option opens the track matching dialog for each release where automatic matching failed (these tracks/releases are silently ignored otherwise)
* Update tags feature is more robust with better error checking
* Fixed bug where track matching was incorrect if "assume tracks are in sorted order" was enabled

Re: foo_discogs

Reply #2063 –
hi,
suddendly discogs tagger stopped to work
I downloaded a new component, uodated foobar but I cant access to the "OAuth aothorization"

http://i.imgur.com/huzpT1Q.jpg (image)
also downloaded the foo discogs dll but still doesnt work
any help?
much thanks.

Re: foo_discogs

Reply #2064 –
Can you check what's logged on the foobar2000 console?

Re: foo_discogs and hidden tracks

Reply #2067 –
Ok, I got to touch on this again as it would make life much easier not having to manually update my m-TAGs to add the data for hidden tracks.
Otherwise I'd never be sure if there's a chance to get the component doing this. (or if it is even already possible ~wishful thinking~ )

Given the following release: https://www.discogs.com/Amy-Winehouse-Frank/release/7340147 (format is not uncommon)
and a playlist view produced with m-TAG pointing to a cue sheet (to split off the the hidden tracks, see screenshot).
and Discogs json data containing the track listing as in below code block (note: "extraartists" data removed to reduce size)
Code: [Select]
"tracklist": [
{"duration": "0:21", "position": "1a",	"type_": "track", "extraartists": [...], "title": "Intro"}, 
{"duration": "3:34", "position": "1b",	"type_": "track", "extraartists": [...], "title": "Stronger Than Me"}, 
{"duration": "5:17", "position": "2a",	"type_": "track", "extraartists": [...], "title": "You Sent Me Flying"}, 
{"duration": "1:34", "position": "2b",	"type_": "track", "extraartists": [...], "title": "Cherry"}, 
{"duration": "3:03", "position": "3",	"type_": "track", "extraartists": [...], "title": "Know You Now"}, 
{"duration": "3:21", "position": "4",	"type_": "track", "extraartists": [...], "title": "Fuck Me Pumps"}, 
{"duration": "2:10", "position": "5",	"type_": "track", "extraartists": [...], "title": "I Heard Love Is Blind"}, 
{"duration": "2:49", "position": "6a",	"type_": "track", "extraartists": [...], "title": "Moody's Mood For Love"}, 
{"duration": "0:40", "position": "6b",	"type_": "track", "extraartists": [...], "title": "Teo Licks"}, 
{"duration": "2:09", "position": "7",	"type_": "track", "extraartists": [...], "title": "(There Is) No Greater Love"}, 
{"duration": "5:17", "position": "8",	"type_": "track", "extraartists": [...], "title": "In My Bed"}, 
{"duration": "3:20", "position": "9",	"type_": "track", "extraartists": [...], "title": "Take The Box"}, 
{"duration": "3:25", "position": "10",	"type_": "track", "extraartists": [...], "title": "October Song"}, 
{"duration": "3:30", "position": "11",	"type_": "track", "extraartists": [...], "title": "What Is It About Men?"}, 
{"duration": "5:01", "position": "12",	"type_": "track", "extraartists": [...], "title": "Help Yourself"}, 
{"duration": "4:15", "position": "13a",	"type_": "track", "extraartists": [...], "title": "Amy Amy Amy"}, 
{"duration": "0:51", "position": "13b",	"type_": "track", "extraartists": [...], "title": "Outro"}, 
{"duration": "4:13", "position": "13c",	"type_": "track", "title": "Brother"}, 
{"duration": "3:57", "position": "13d",	"type_": "track", "title": "Mr. Magic (Through The Smoke)"}
]
How much chance is there to get the discogs data mapped 1:1 to the playlist track listing (so as not to lose track credits and information stored in "extraartists" for the tracks considered 'hidden") ?

Since I'm using m-TAGS the tag data never reaches the actual media files. But even if someone has physically spliced the hidden tracks off to separate tracks, a 1:1 mapping would be very helpful when possible.

Re: foo_discogs

Reply #2068 –
and a small buglet: "Edit Tag Mappings..." dialog doesn't remember window position in same session

Re: foo_discogs

Reply #2070 –
Quote from: zoomorph on
Lots more changes made... could be some new bugs. Getting close to the point where this version can be officially released.

Updates:
* Update tags "Prompt" option opens the track matching dialog for each release where automatic matching failed (these tracks/releases are silently ignored otherwise)
* Update tags feature is more robust with better error checking
* Fixed bug where track matching was incorrect if "assume tracks are in sorted order" was enabled
Thanks a lot for all your work on this!
Tried this:
-----------------------
* foo_discogs.dll
617 KB
downloaded 53 times

Last Edit: 05 April, 2016, 06:16:06 AM by zoomorph
-----------------------

And can (also) report this does not like multi media releases... when trying to tag a multi CD rip from this:
https://www.discogs.com/Quasimoto-The-Unseen/release/697747
it seems to repeat the CD1 info/tags on to CD2 tracks. At a guess, my organization/structure might play into this where CD1 & CD2 files live in their own folders respectively.

And in case you want more feedback - the progress bar when fetching discogs info if stalling, or rather never actually progressing, but can sit a while 'progressing' (had had it up to 10-15 ish seconds), but probably due to discogs API getting slammed then, as many other times it's not even showing the matching progress bar...

Cheers.
c.

Re: foo_discogs

Reply #2071 –
I'm just re-tagging a LOT, so I came across 2 other 2-CD releases with peculiar behaviour with the tagger different to the one I described above which happened on a few multi CD releases. I had one that actually worked as expected, this:
https://www.discogs.com/Various-Mellow-Hip-Hop-Sessions/release/1964479
= which tagged the whole release perfectly over 2 folders, i.e. /CD1/ & /CD2/

This was even more bizarre though (lives in 2 folders, 1 per CD as well), than suggesting to simply rewriting CD1 content to CD2 tracks:
https://www.discogs.com/Beastie-Boys-Anthology-The-Sounds-Of-Science/release/2916601
when queried, it returned with a proposed match of:
01    Beastie Boys (+20 HIDDEN)
02    The Biz Vs. The Nuge (+20 HIDDEN)

So it seems to a mixture of things playing into this but I did not go ahead to see the outcome as it looked rather off...
If you need more info, sing out!
Cheers.
c.

Re: foo_discogs

Reply #2072 –
Quote from: Just_Addict on
Ok, I got to touch on this again as it would make life much easier not having to manually update my m-TAGs to add the data for hidden tracks.
Otherwise I'd never be sure if there's a chance to get the component doing this. (or if it is even already possible ~wishful thinking~ )
Sorry, it's currently not supported. It could be added, but not trivial and not sure when I would find motivation to do that since I never split hidden tracks.

Quote from: Just_Addict on
and a small buglet: "Edit Tag Mappings..." dialog doesn't remember window position in same session
It works for me.

Quote from: alec.tron on
And can (also) report this does not like multi media releases... when trying to tag a multi CD rip from this:
https://www.discogs.com/Quasimoto-The-Unseen/release/697747
it seems to repeat the CD1 info/tags on to CD2 tracks. At a guess, my organization/structure might play into this where CD1 & CD2 files live in their own folders respectively.
Hmmm... it works for me. You realize that the track titles on CD1 are the same as CD2 on this release, right?

Quote from: alec.tron on
This was even more bizarre though (lives in 2 folders, 1 per CD as well), than suggesting to simply rewriting CD1 content to CD2 tracks:
https://www.discogs.com/Beastie-Boys-Anthology-The-Sounds-Of-Science/release/2916601
when queried, it returned with a proposed match of:
01    Beastie Boys (+20 HIDDEN)
02    The Biz Vs. The Nuge (+20 HIDDEN)
Currently foo_discogs treats "X.Y" track positions as hidden tracks, as recommended by the Discogs guidelines. Normally multiple CD tracks are entered as "X-Y" where X is the disc and Y the track number.

Re: foo_discogs

Reply #2073 –
@paregistrase

I was running Ubuntu 12.04 LTS and having the same issues with Wine. Not sure how to fix it there, but I checked out foo_discogs on Ubuntu 16.04 beta and it's working fine.

Re: foo_discogs

Reply #2074 –
Quote from: jmbylsma on
@paregistrase

I was running Ubuntu 12.04 LTS and having the same issues with Wine. Not sure how to fix it there, but I checked out foo_discogs on Ubuntu 16.04 beta and it's working fine.

Thanks for the advice. Updated and running now. Moreover also pleasantly surprised with the stability of a beta release.