Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1372157 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

foo_discogs

Reply #1825 –
Quote from: simcut on
Hi all!

Wondered if you could please help me with an issue I'm having with the plugin.

I'm trying to use the plugin to tag some stuff, and its having issues with a couple of multi-disc releases.

http://www.discogs.com/Various-Energetic-H...release/5149402

for some reason it's showing up like this below:-



I have no idea why, it's also doing the same thing on another discogs entry:-

http://www.discogs.com/Various-A-Remix-Nat...release/6612909

Any ideas what is causing this to happen and how I can resolve it?

Thanks!

Parsing the tracklist is quite difficult, because it is so flexible. The problem here is that the format is 38 x File yet the tracklist is entered as though it's a 2 CD release. Weird. I'm not sure whether this is technically correct from the database point of view (sadly, it may be because they favor entering track positions as they are on the release, rather than in a logical manner) or an error (and the tracks should really be numbered consecutively from 1 to 38).

I have made a slight patch to foo_discogs (the new alpha version) that fixes parsing these releases. Note that it's a band-aid patch that won't catch everything. In fact, it may be impossible to parse every possible tracklist. I'd like to parse as many as possible, though, so if you discover more releases that aren't parsed correctly, posting them here is the right thing to do. :-)

https://www.sendspace.com/file/7wgw83

foo_discogs

Reply #1826 –
Quote from: fuffi on
I gladly report an error, I encountered right now :-)
This release: 2672205

My ALBUM ARTIST: $join($multi_replace(%<RELEASE_ARTISTS_NAME%>,'Various','Various Artists'),$multi_pad(%<RELEASE_ARTISTS_JOIN%>,' '))

$multi_pad() got renamed to $multi_wrap(). New $multi_pad() is an array version of the built-in function $pad().

foo_discogs

Reply #1827 –
Quote from: zoomorph on
Parsing the tracklist is quite difficult, because it is so flexible. The problem here is that the format is 38 x File yet the tracklist is entered as though it's a 2 CD release. Weird. I'm not sure whether this is technically correct from the database point of view (sadly, it may be because they favor entering track positions as they are on the release, rather than in a logical manner) or an error (and the tracks should really be numbered consecutively from 1 to 38).

I have made a slight patch to foo_discogs (the new alpha version) that fixes parsing these releases. Note that it's a band-aid patch that won't catch everything. In fact, it may be impossible to parse every possible tracklist. I'd like to parse as many as possible, though, so if you discover more releases that aren't parsed correctly, posting them here is the right thing to do. :-)

https://www.sendspace.com/file/7wgw83


Thank you very much for the fast reply and the update, it's a bit of a tricky one, because a lot of web releases show up as "disc 1" and "disc 2" so they should be added as such in my opinion, so I think this problem is only going to be for multi-disc releases that are digital only, is that correct?

Going to test this new alpha build now and let you know how I get on

Regards

foo_discogs

Reply #1828 –
Quote from: fuffi on
Quote from: simcut on
any ideas what is causing this to happen and how I can resolve it?

This feature is still in development.

What version of the component are u using?

U may try an older version (not the betas here in the last 20-30 posts) from the links here in the thread (good luck soldier, because this thread is extremly long....u may skip some months) or try the one downloadable from the f2k-components website. http://www.foobar2000.org/components
its v1.55, but I dunno if its working on that feature. (so u may look for a version <v1.55)

If u find a working version, please link it here ;-)

Just wanted to quote myself and add, that all the older (maybe working or better-working, with whatever-feature) are not available anymore via sendspace. they're all deleted.
so anybody, which has no backup of an older version anymore (like the unlucky me), has to go with v1.55 or the beta.

actually, I don't really care (only a little bit...), because using only the beta (and reporting bugs) will hopefully speed up the development of great old and new features! thank you zoomorph!

foo_discogs

Reply #1829 –
Quote from: zoomorph on
Quote from: fuffi on
I gladly report an error, I encountered right now :-)
This release: 2672205

My ALBUM ARTIST: $join($multi_replace(%<RELEASE_ARTISTS_NAME%>,'Various','Various Artists'),$multi_pad(%<RELEASE_ARTISTS_JOIN%>,' '))

$multi_pad() got renamed to $multi_wrap(). New $multi_pad() is an array version of the built-in function $pad().

Well, simply replacing $multi_pad with $multi_wrap did not work. It just wrote "?>" to the album artists tag.

I have read your html-help (wasnt it coloured and nicely formatted in earlier versions? now it seems pretty plain) and I find it very ... interesting ;-)
Although I think, I know what arrays are, and I think, I understood your very clearly and good elaborated words and explanaitions, I only found the solution accidentially, while writing this post ;-)

The % in the album artists example were wrongly placed in the help file:
they should be like this:
Code: [Select]
$join($multi_replace(%<RELEASE_ARTISTS_NAME>%,'Various','Various Artists'),$multi_wrap(%<RELEASE_ARTISTS_JOIN>%,' '))


Its good for me to find errors, because it helps me understanding what I am doing 8-)

anyways, I guess, I need to read the help again and again to understand the new concept of array-tagging...

foo_discogs

Reply #1830 –
Good catch on the mistakes in the help docs "examples" section! I'll update that. Yes, it is colored nicely if the CSS sheet is present.

foo_discogs

Reply #1831 –
Hi zoomorph

quick request, on this alpha version that you uploaded for me, would it please be possible to add back in the ability to change Various to Various Artists please, as the option has disappeared from the configuration section?

Thanks
 

foo_discogs

Reply #1832 –
Quote from: simcut on
quick request, on this alpha version that you uploaded for me, would it please be possible to add back in the ability to change Various to Various Artists please, as the option has disappeared from the configuration section?

Just read back the latest posts, mate! ...and learn your lesson ;-)
starting from here: http://www.hydrogenaud.io/forums/index.php...st&p=900482

foo_discogs

Reply #1833 –
Quote from: fuffi on
Quote from: simcut on
quick request, on this alpha version that you uploaded for me, would it please be possible to add back in the ability to change Various to Various Artists please, as the option has disappeared from the configuration section?

Just read back the latest posts, mate! ...and learn your lesson ;-)
starting from here: http://www.hydrogenaud.io/forums/index.php...st&p=900482


Oh balls, I completely missed that post, cheers!

foo_discogs

Reply #1834 –
Hi there, great to see such a powerful plugin being developed.
I'm mainly interested in the 'album art' feature to tag some legacy files (Sampler CDs, old digitized vinyl...) with album art from discogs.

Now while 'full-auto' mode most probably isn't realistic, I would love to see the feature to not download the album art to files in the folder, but to instead embed it inside the file. This would be a major time saver! Maybe it is even possible using advanced title formatting syntax...?

foo_discogs

Reply #1835 –
Quote from: ImAlive on
I would love to see the feature to not download the album art to files in the folder, but to instead embed it inside the file. This would be a major time saver!
yeah, we all (ok, most of us) like to have such a comfortable and useful time saving feature ;-)
Unfortunately, I never found and easy way to do this in f2k, nor a developer had done something so far.

There are other tools/programs (use search here: embed cover art) ppl use to accomplish what u want, but they're all external, means, not usable inside f2k, which is, for me, a show-stopper.

Maybe this post helps a little bit?
http://www.hydrogenaud.io/forums/index.php...st&p=894812

foo_discogs

Reply #1836 –
New build:  https://www.sendspace.com/file/srno6y

Updates:
- Some interface improvements.
- New option to remove any extra meta tags after writing tags (plus a semi-colon separated list of exceptions).

foo_discogs

Reply #1837 –
Hi zoomorph,

1)
when I try to update a single file, which is already tagged by your component the last days), I got this:
Code: [Select]
(skipped) Error [release 2672204]: Unable to map file to Discogs tracklist.


Its track 6 (Soul Suckers) on release 2672204, which I'd like to update,
which is already tagged with:
Code: [Select]
Artist Name : Amos Lee
Track Title : Soul Suckers
Album Title : Amos Lee
Date : 2005
Genre : Rock
Composer : 
Performer : 
Album Artist : 
Track Number : 06
Total Tracks : 11
Disc Number : 
Total Discs : 
Comment : 
Rating : 0
<DISCOGS_ALBUM_ARTIST_MULTI> : Amos Lee
<DISCOGS_ARTIST_ALIASES> : Ryan Anthony Massaro
<DISCOGS_ARTIST_ID> : 314211
<DISCOGS_ARTIST_MULTI> : Amos Lee
<DISCOGS_ARTIST_REALNAME> : Ryan Anthony Massaro
<DISCOGS_CATALOG> : 7243 5 97350 1 6
<DISCOGS_COUNTRY> : US
<DISCOGS_FORMAT> : Vinyl, LP, Album
<DISCOGS_LABEL> : Classic Records
<DISCOGS_LABEL_ID> : 22206
<DISCOGS_MASTER_RELEASE_ID> : 305520
<DISCOGS_ORIGINAL_TRACK_NUMBER> : 06
<DISCOGS_RATING> : 5.0
<DISCOGS_RELEASE_ID> : 2672204
<DISCOGS_RELEASE_NOTES> : Courtesy of Blue Note Records, a division of Capitol Records, Inc., under exclusive license from EMI-Capitol Special Markets.
<DISCOGS_RELEASED> : 01 Mar 2005
<DISCOGS_RELEASED_RAW> : 2005-03-01
<STYLE> : Folk Rock; Indie Rock
<VINYLTRACK> : B1



2)
Link "Syntax Help" is now visible on the same place, but after clicking, nothing happens. (my default browser is set to firefox, which opens on other links I click in other programs)
Can somebody pleas test/click this link to make sure, its not my systems config which messes up. thanks.

3)
Can u change the position of the update/writable row like in the mock-up, please? its easier to see what line has what status as when the "enabled" row is at the last position.
also, the  staus won't disapear, when doubleclicking on the "Format String"-row, to resize it automaticly to see the most longest/visible information.

foo_discogs

Reply #1838 –
4)
Was there a important/special reason, the tag "DISCOGS_CREDIT_REMIX" was replaced by "REMIXED_BY" in Edit-Tag-Mappings-window?
I'd like to keep it the old way, but didnt read  on the discogs site for more information. Was it removed?

Anyways, while working with the newest version of the component, it is a pleasure to use! So many things are working proper now with the UI. Grrrreat :-)

5)
can we have a "Defaults"-Button on Tag basis, too?
Now, the "Defaults"-Button reverts ALL tags to its defaults, which could be useful,
but if the user has made only one mistake on one single tag line and wish to default it, its not possible.

Feature Request: Add new Default-Tag Button, which defaults only the selected line


6)
can u add a $multi_istrcmp(A,X) in addition to $multi_strcmp(A,X), which ignores the case?


7)
Using the old component, I have configured (in ColumnsUI) the track title with this script:
Code: [Select]
[%TITLE%][ <feat. %DISCOGS_CREDIT_FEATURING%>]
which showed the Title of the Track like "Never Knew Love Like This <feat. Cherrelle>"
(for track no. 3 of this release)

precondition for showing the "<feat. Cherrelle>" was the filled tag DISCOGS_CREDIT_FEATURING, which were autoamticly filled by the component.


Now, I don't get it to work again ;-/

The DISCOGS_TRACK_CREDITS-Tag of the mentioned release shows "Vocals [Featuring] - Cherrelle; Producer - Jimmy Jam And Terry Lewis; Written-By - J. Harris III/T. Lewis"

So I guess, I only need to split or cut or grab the "[Featuring] - Cherrelle"-part of the whole string, but I have no clue how&where to implement this in the two scripts I used:
Code: [Select]
$multi_if($multi_strcmp(%<<TRACK_CREDITS_ROLES>>%,'Featuring'),$join(%<<TRACK_CREDITS_ARTISTS_NAME>>%),)
or
Code: [Select]
$flatten($multi_if($any($multi_strcmp($sextend(%<<TRACK_CREDITS_ROLES>>%,%<<RELEASE_CREDITS_ROLES>>%),'Featuring')),$multi_if($put(aj,$sextend(%<<TRACK_CREDITS_ARTISTS_JOIN>>%,%<<RELEASE_CREDITS_ARTISTS_JOIN>>%)),$join($put(an,$sextend(%<<TRACK_CREDITS_ARTISTS_NAME>>%,%<<RELEASE_CREDITS_ARTISTS_NAME>>%)),$multi_wrap($get(aj),' ')),$get(an)),))

Another tricky part for me is, that some releases, got more than one Featuring Artists, like this release track 8 which is not "[Featuring]", but "Featureing - ": Featuring - Foxy Brown; Featuring - Babyface; Keyboards [Additional Keys] - George Fontenette; Producer - Daven "Prestige" Vanderpool

Now, I'm looking for a way to script all the special cases, but the old component had done it correctly, so I guess, there must be an easier way, but actually, I'm not able to solve the problem ;-/
(I also tried with $append, but wasnt successful so far)

Any help is very appreciated!



8)
JSON error on: http://www.discogs.com/Jay-Z-In-My-Lifetim.../release/753411

foo_discogs

Reply #1839 –
Hi There!
I have error:
"(skipped) Error: Authorization Failed (401) [Is OAuth working?] - (url: http://api.discogs.com/oauth/request_token)[ESCAPE to close]"

I have Discogs account. I tried to get a token logged in Discogs or not.
I tried to create a token in Discogs profile and paste this to plugin, I tried to change foo_discogs.dll (official/beta).
Nothing helps.
Any idea?
TNX!
ps. maybe plugin needs update? 
Discogs ask https, but plugin send http requests only?

foo_discogs

Reply #1840 –
Quote from: mnogo9 on
Hi There!
I have error:
"(skipped) Error: Authorization Failed (401) [Is OAuth working?] - (url: http://api.discogs.com/oauth/request_token)[ESCAPE to close]"

I have Discogs account. I tried to get a token logged in Discogs or not.
I tried to create a token in Discogs profile and paste this to plugin, I tried to change foo_discogs.dll (official/beta).
Nothing helps.
Any idea?
TNX!
ps. maybe plugin needs update? 
Discogs ask https, but plugin send http requests only?

Is the clock on your system set correctly? Incorrect clock seems to cause an error from Discogs when configuring OAuth.

foo_discogs

Reply #1841 –
fuffi,

1) Update tags is a problem since it requires automatically matching files to the tracklist. Old method was unreliable, new method is better but still not perfect. I haven't decided what to do with it yet.
2) Is foo_discogs_help.html in the foo_discogs component folder?
3) I find that unnatural on the left. Maybe you can make the "formatting string" column very narrow to see enabled beside the tag names? Sorry, I don't understand your second point.
4) It looks liked it used to be "REMIXED BY" (by default). It got accidentally changed to "REMIXED_BY". But, for consistency with other tags, I'd be happy to rename it (by default) something like "DISCOGS_CREDIT_REMIXED_BY".
5) I'll consider if there's a way to do this.
6) I'll add multi_istrcmp to the next version.
7) Did you see the "DISCOGS_CREDIT_FEATURING" tag? It seems to be what you're requesting.
8) This is a bug... I will fix it soon. Thanks!

foo_discogs

Reply #1842 –
Quote from: zoomorph on
2) Is foo_discogs_help.html in the foo_discogs component folder?
now it is, thank you!


Quote from: zoomorph on
1) Update tags is a problem since it requires automatically matching files to the tracklist. Old method was unreliable, new method is better but still not perfect. I haven't decided what to do with it yet.
What are you technicially thinking about, when u try to decide?


Quote from: zoomorph on
3) I find that unnatural on the left. Maybe you can make the "formatting string" column very narrow to see enabled beside the tag names?
We all have different perception, I guess. Do you mind, making the columns movable, so the user can change their position when needed.
For me, the "formatting string" column needs to be the widest, because its lines are not multiline, only one single line, which is hard to read all at once.


Quote from: zoomorph on
7) Did you see the "DISCOGS_CREDIT_FEATURING" tag? It seems to be what you're requesting.
Yes, but it did not work here with the mentioned release. That was the reason, I wrote about my unsuccessful attempts. I defaulted the settings but did not get a tag.


Quote from: zoomorph on
4) It looks liked it used to be "REMIXED BY" (by default). It got accidentally changed to "REMIXED_BY". But, for consistency with other tags, I'd be happy to rename it (by default) something like "DISCOGS_CREDIT_REMIXED_BY".
This reminds me on another question: are those tags, which were written to the file defined by the discoGS-Crew, or are they just "made up" by the components developers? I always thought, there were specified by the discoGS-Crew, so they can't be renamed or changed....

foo_discogs

Reply #1843 –
Quote from: fuffi on
Quote from: zoomorph on
1) Update tags is a problem since it requires automatically matching files to the tracklist. Old method was unreliable, new method is better but still not perfect. I haven't decided what to do with it yet.
What are you technicially thinking about, when u try to decide?

Haven't decided how to balance accuracy (make sure that you're updating the right track from the tracklist) vs. automation (no requiring any manual work).

One possibility is to make "update tags" automated whenever it can match tracks, but fall back to manual confirmation if tracks can't be matched with enough accuracy.

Then, there is the question of how to match tracks. Traditionally, it used the track number and just went with it. More recently, it uses the track index in the Discogs tracklist (untested, may not work lol) which is slightly more reliable. Another possibility (only works ~50% of the time) is automatic matching via durations. So, a combination of various methods could be used to try to automatically match files to the tracklist....

Quote from: fuffi on
Quote from: zoomorph on
7) Did you see the "DISCOGS_CREDIT_FEATURING" tag? It seems to be what you're requesting.
Yes, but it did not work here with the mentioned release. That was the reason, I wrote about my unsuccessful attempts. I defaulted the settings but did not get a tag.

I see.. because the credits are "Featuring [...]", they don't match "Featuring". I'm sure this can be solved. For one, replacing $multi_strcmp() with $multi_strstr() should work, but this might accept credits that you don't want, such as "Whatever [Featuring]". Another solution would be to use $multi_left() to get the left 9 characters before doing the $multi_strcmp(). This would accept anything that starts with "Featuring". Another solution, maybe the best?, would be to expose another tag, say CREDIT_TYPE ("Featuring") vs. CREDIT_NAME ("Featuring [Unlisted]").

Quote from: fuffi on
Quote from: zoomorph on
4) It looks liked it used to be "REMIXED BY" (by default). It got accidentally changed to "REMIXED_BY". But, for consistency with other tags, I'd be happy to rename it (by default) something like "DISCOGS_CREDIT_REMIXED_BY".
This reminds me on another question: are those tags, which were written to the file defined by the discoGS-Crew, or are they just "made up" by the components developers? I always thought, there were specified by the discoGS-Crew, so they can't be renamed or changed....

Just made up by the component developers. :-P

foo_discogs

Reply #1847 –
Works fantastic, cheers zoomorph!

One request though, I have disabled style from the list (infact, have removed the entry out) but in the new interface it still shows the Style field where you can enter in text, instead of being greyed out like how it used to if you unticked the 'write tag' option for Style.

Very minor issue but wanted to flag it up to you, also if you untick the "all" tickbox it doesnt remember the setting for the next time you use it, in the past this used to be unticked and stay unticked.

Regards!

P.S. alexinc, yes mate, thanks, I'll reply to you this evening (just finishing lunch break at work now)

foo_discogs

Reply #1848 –
My foobar_discogs_help.html file is missing from the user-components folder for some reason. Would someone be willing to do me a favor and upload it?

foo_discogs

Reply #1849 –
Quote from: zoomorph on
Is the clock on your system set correctly? Incorrect clock seems to cause an error from Discogs when configuring OAuth.

Thankyou, zoomorph, for fast answer.
Hmm... Time was correct, but time-sync service was off. I'd enable service - and authorization get successful!
Thank You!