HydrogenAudio

Hydrogenaudio Forum => General Audio => Topic started by: AlexVallat on 2007-09-09 09:06:17

Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-09 09:06:17
(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Splashscreen.gif)
[blockquote]
(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/SavePathAndSort.gif) (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Tooltip.gif) (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/DownloadingFullSize.gif)

(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Sources.gif) (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FullArtPanel.gif)

(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FileBrowserClip.gif) (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Preview.gif)
[/blockquote]
AlbumArtDownloader XUI - You know you want it...

This project is a rewrite of the Album Art Downloader code, using .NET Framework 3.5.

Features:For the graphically-minded out there, although this app isn't skinnable, the UI is all created in XAML, so if you want to grab the source and start editing the UI, please feel free. It is under the XUI folder in the SVN Repository (https://sourceforge.net/svn/?group_id=187008)

Links:
SourceForge project page (http://sourceforge.net/projects/album-art/)
Wiki and reference guide (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Main_Page) (incomplete)
Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)

Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: TheTravis on 2007-09-09 10:25:36
First! Finally I got .NET Framework succesfully installed. This program is awesome, thanks!
Title: Album Art Downloader XUI
Post by: Max Spicer on 2007-09-09 18:02:24
Does Album Art Downloader XUI only work with mp3s?  I tried pointing the file browser at my collection of flac files and it didn't find any albums.

Thanks,

Max
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-09 18:39:44
Does Album Art Downloader XUI only work with mp3s?  I tried pointing the file browser at my collection of flac files and it didn't find any albums.

Thanks,

Max

The file browser uses MediaInfo (http://mediainfo.sourceforge.net/) to read file tags. I don't think it supports album and artist information in flac (in fact I didn't think flac supported those sorts of tag at all), but if you want to request support for reading a file format, that's the project to ask. If the stand-alone MediaInfo app can read the tags, but Album Art Downloader doesn't, then that's a bug of mine - if you give me a sample file I can try and fix it.

Alex
Title: Album Art Downloader XUI
Post by: SmilerSmiles on 2007-09-09 20:42:37
Does it handle more than 50 albums at a time yet?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-10 08:36:52
Does it handle more than 50 albums at a time yet?

I've still got the warning to enqueue only 50 searches at a time in there, but it is handling them much better now. I tried enqueueing all 250-odd albums I have and it was only unresponsive for about 4-5 seconds while they were being queued up, and fine after that. Cancel All took another 5 seconds or so. Of course, it will depend on your PC, but I'd suggest giving it another go and seeing if you find it acceptable.

Alex
Title: Album Art Downloader XUI
Post by: fooruncle on 2007-09-10 09:47:40
Hi,

I still use the old version on my old notebook for performance reasons. I hadn't used it for some weeks, and yesterday the discogs script failed with the following warning:

Retrieving Art Failed
Capacity must be positive
parameter name: capacity

I thought that the script was outdated, so i copied the discogs-script from the .zip of the XUI-version. It compiled without problems, but I still get the same error message.

Can anyone help me?

Thanks,
frncle
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-10 10:47:26
Hi,

I still use the old version on my old notebook for performance reasons. I hadn't used it for some weeks, and yesterday the discogs script failed with the following warning:

Retrieving Art Failed
Capacity must be positive
parameter name: capacity

I thought that the script was outdated, so i copied the discogs-script from the .zip of the XUI-version. It compiled without problems, but I still get the same error message.

Can anyone help me?

Thanks,
frncle

Discogs script seems to be working fine for me. Can you post the artist and album you searched for?

Alex
Title: Album Art Downloader XUI
Post by: fooruncle on 2007-09-10 12:34:00
Discogs script seems to be working fine for me. Can you post the artist and album you searched for?

Alex


I tried it with several CDs and records I ripped last week. Some examples are:

Company Flow - End to End Burners
D'Nell - 1st Magic
Peeping Tom - Peeping Tom

The preview pictures do appear, but as soon as I try to preview or save them, I get the error message (or a connection time out in some cases...). Amazon works perfectly...

frncle
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-10 14:29:18
The preview pictures do appear, but as soon as I try to preview or save them, I get the error message (or a connection time out in some cases...). Amazon works perfectly...

frncle


I tried the searches you mentioned, and they seem to be working fine for me too. As you say that the results are actually returned, it is just the full size downloads which don't, I suspect that the problem is a bug with the old Album Art Downloader you are using. The discogs script doesn't actually have smaller thumbnails available, it uses the same image for both thumbnail and full size, so if it can show the thumbnail, then it should have the full size one available too.

You could try using the XUI one and seeing if the same problem occurs with that. I'm afraid I'm not going to be investigating or fixing bugs in the old version, though.

Alex
Title: Album Art Downloader XUI
Post by: fooruncle on 2007-09-10 19:09:17
You could try using the XUI one and seeing if the same problem occurs with that. I'm afraid I'm not going to be investigating or fixing bugs in the old version, though.


Hmmm, the script definitly worked several weeks before... However, I completely reinstalled the old version and it works now... Whatever happened, I can't explain it. The only possibility I see is that I returned to an old version of the old version when I had to reinstall my pc with an old backup of the system partition last month. I can't verify that now. Thanks for your help! I really love your program!

frncle
Title: Album Art Downloader XUI
Post by: Jojo on 2007-09-11 05:43:49
can this be used with iTunes? http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/)
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-11 06:22:40
can this be used with iTunes? http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/)

Hmm, it looks like unencrypted iTMS art is available, wonderful. There's a script included with my original 'CoverDownloader' for iTMS, i'll try and convert it. I don't know if it will still work with the XUI version, i haven't been keeping up with the changes.

Edit: Arggh, this 'josh' guy hasn't provided updated source code (that I can see). But from his description the changes necessary shouldn't be too difficult. Here's the original code if anyone wants to try.

Note: THIS CODE DOESN'T WORK, ONLY USE IT IF YOU INTEND TO FIX IT. Also the script itself's probably not compatible with Alex's modifications, any changes necessary should be slight.

Code: [Select]
# refs: ICSharpCode.SharpZipLib.dll System.Windows.Forms
namespace CoverSources
import System.Xml
import System.Drawing
import util
import ICSharpCode.SharpZipLib

class iTMS:
static def GetPageSecret(url as string):
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
request.UserAgent="iTunes/7.0 (Macintosh; U; PPC Mac OS X 10.4.7)"
request.Headers.Add("X-Apple-Tz","7200")
request.Headers.Add("X-Apple-Store-Front","143457")
request.Headers.Add("Accept-Language","en-us, en;q=0.50")
request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
response = request.GetResponse()
return response.GetResponseStream()
static SourceName as string:
get: return "iTunes Music Store"
static SourceVersion as decimal:
get: return 0.1
static def GetThumbs(coverart,artist,album):
x=System.Xml.XmlDocument()
t=GetPageSecret("http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an="+EncodeUrl(artist)+"&pn="+EncodeUrl(album))
x.Load(ICSharpCode.SharpZipLib.GZip.GZipInputStream(t))
tags=x.GetElementsByTagName("dict")
if tags.Count==0:
return
url=""
albumname=album
for tag in tags[0].ChildNodes:
if tag.InnerText=="cover-art-url":
url=tag.NextSibling.InnerText
if tag.InnerText=="playlistName":
albumname=tag.NextSibling.InnerText
if url.Length>0:
coverart.SetCountEstimate(1)
coverart.AddThumb(GetPageSecret(url),albumname,600,600,null)
static def GetResult(param):
return null
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-11 08:16:23
Also the script itself's probably not compatible with Alex's modifications, any changes necessary should be slight.
XUI should be backwards compatible with old scripts. Looking at this one, the only difficulty with it I see is that it needs a reference to ICSharpCode.SharpZipLib.dll, which is not included with Album Art Downloader. If you download (http://www.icsharpcode.net/OpenSource/SharpZipLib/Download.aspx) that dll and stick it (the net-20 version) in your Album Art Downloader XUI folder, it will compile and run just fine.

It won't actually download any art, though, unfortunately. However, trying a few searches on http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/), including his example (http://www.thejosher.net/iTunes/index.php?artist=eisley&album=combinations), shows that he can't download any art either:
Quote
Warning: gzinflate() [function.gzinflate]: data error in /home/josh/public_html/iTunes/index.php on line 122
Oh well.

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-11 10:12:54
It won't actually download any art, though, unfortunately. However, trying a few searches on http://www.thejosher.net/iTunes/ (http://www.thejosher.net/iTunes/), including his example (http://www.thejosher.net/iTunes/index.php?artist=eisley&album=combinations), shows that he can't download any art either:
Quote
Warning: gzinflate() [function.gzinflate]: data error in /home/josh/public_html/iTunes/index.php on line 122
Oh well.

Alex


That's rather odd, his script works fine for me. What country are you in? Is there an iTMS in your country? Maybe that's the problem, we recently got iTMS here in New Zealand. Does this link work for you?  http://a1.phobos.apple.com/r10/Music/32/a3...zi.dbjwyonx.jpg (http://a1.phobos.apple.com/r10/Music/32/a3/53/mzi.dbjwyonx.jpg)
For me it only works in firefox, for some reason. BTW the quality is amazing, better than I've seen from any other source, it's definately not a scan.

Edit: Noticed that the problem you quoted occurred on his webserver, so country shouldn't affect it, still, odd that it's working perfectly here.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-11 11:30:01
That's rather odd, his script works fine for me. What country are you in? Is there an iTMS in your country? Maybe that's the problem, we recently got iTMS here in New Zealand. Does this link work for you?  http://a1.phobos.apple.com/r10/Music/32/a3...zi.dbjwyonx.jpg (http://a1.phobos.apple.com/r10/Music/32/a3/53/mzi.dbjwyonx.jpg)
For me it only works in firefox, for some reason. BTW the quality is amazing, better than I've seen from any other source, it's definately not a scan.

Edit: Noticed that the problem you quoted occurred on his webserver, so country shouldn't affect it, still, odd that it's working perfectly here.
Well, his webserver script is up and running again for me, so must have been some sort of temporary glitch. The problem is that the boo script is still downloading the encrypted version. I can't see any source code for what Josh has done at all, but a guess at just removing the .enc.jpg?... bit by adding the line:
Code: [Select]
url = System.Text.RegularExpressions.Regex("\\.enc\\.jpg\\?.*").Replace(url, ".jpg")
seems to do the job:

Code: [Select]
# refs: ICSharpCode.SharpZipLib.dll System.Windows.Forms
namespace CoverSources
import System.Xml
import System.Drawing
import util

class iTMS:
static def GetPageSecret(url as string):
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
request.UserAgent="iTunes/7.0 (Macintosh; U; PPC Mac OS X 10.4.7)"
request.Headers.Add("X-Apple-Tz","7200")
request.Headers.Add("X-Apple-Store-Front","143457")
request.Headers.Add("Accept-Language","en-us, en;q=0.50")
request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
response = request.GetResponse()
return response.GetResponseStream()
static SourceName as string:
get: return "iTunes Music Store"
static SourceVersion as decimal:
get: return 0.2
static def GetThumbs(coverart,artist,album):
x=System.Xml.XmlDocument()
t=GetPageSecret("http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an="+EncodeUrl(artist)+"&pn="+EncodeUrl(album))
x.Load(ICSharpCode.SharpZipLib.GZip.GZipInputStream(t))
tags=x.GetElementsByTagName("dict")
if tags.Count==0:
return
url=""
albumname=album
for tag in tags[0].ChildNodes:
if tag.InnerText=="cover-art-url":
url=tag.NextSibling.InnerText
if tag.InnerText=="playlistName":
albumname=tag.NextSibling.InnerText
if url.Length>0:
url = System.Text.RegularExpressions.Regex("\\.enc\\.jpg\\?.*").Replace(url, ".jpg")
coverart.SetCountEstimate(1)
coverart.AddThumb(url,albumname,-1,-1,null)
static def GetResult(param):
return null
Title: Album Art Downloader XUI
Post by: fooruncle on 2007-09-11 12:37:31
Hmmm, using it with the old version (again...), I get the following message in the iTMS column:
Error GZIP header, first magic byte doesn't match...

Too bad...
frncle
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-11 13:16:37
Hmmm, using it with the old version (again...), I get the following message in the iTMS column:
Error GZIP header, first magic byte doesn't match...

Too bad...
frncle

Again, you've got to post the thing you're searching for to make any meaningful error report! Some quick testing shows that this error will be reported by the old Album Art Downloader if the album art can't be found on iTMS. If you get a result where searching on Josh's site returns a result, but the boo script doesn't, then I can look into that.

As a more general improvement, the script should probably handle the "no result" case in a more graceful way. Also, worth noting that the script as stands does not do thumbnails, although Josh's site does. Room for improvement here. If I get round to it, I might try writing a new iTMS script based off the information in this script, but until then, this one does mostly work.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-11 14:57:20
Turns out, adding thumbnail support only needs a small tweak after all:

Code: [Select]
# refs: ICSharpCode.SharpZipLib.dll
namespace CoverSources
import System.Xml
import System.Drawing
import util

class iTMS:
static def GetPageSecret(url as string):
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
request.UserAgent="iTunes/7.0 (Macintosh; U; PPC Mac OS X 10.4.7)"
request.Headers.Add("X-Apple-Tz","7200")
request.Headers.Add("X-Apple-Store-Front","143457")
request.Headers.Add("Accept-Language","en-us, en;q=0.50")
request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
response = request.GetResponse()
return response.GetResponseStream()
static SourceName as string:
get: return "iTunes Music Store"
static SourceVersion as string:
get: return "0.3"
static SourceCreator as string:
get: return "david_dl, Alex Vallat"
static def GetThumbs(coverart,artist,album):
x=System.Xml.XmlDocument()
t=GetPageSecret("http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an="+EncodeUrl(artist)+"&pn="+EncodeUrl(album))
try:
x.Load(ICSharpCode.SharpZipLib.GZip.GZipInputStream(t))
except e as ICSharpCode.SharpZipLib.GZip.GZipException:
return //Wasn't a zip, so art wasn't found

tags=x.GetElementsByTagName("dict")
if tags.Count==0:
return
url=""
albumname=album
for tag in tags[0].ChildNodes:
if tag.InnerText=="cover-art-url":
url=tag.NextSibling.InnerText
if tag.InnerText=="playlistName":
albumname=tag.NextSibling.InnerText
if url.Length>0:
url = System.Text.RegularExpressions.Regex("\\.enc\\.jpg\\?.*").Replace(url, "")
coverart.SetCountEstimate(1)
coverart.AddThumb(url + ".170x170-75.jpg", albumname, -1, -1, url + ".jpg")
static def GetResult(param):
return param

I'll add this to the XUI installer along with the SharpZipLib dll and bump the version to 0.9.1

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-12 01:34:35
Thanks, it seems to work for most albums, however if I search artist: Menomena, album: Friend and foe, it saves the thumbnail version, not the full-sized art. The same search works correctly on thejosher.net.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-12 08:26:22
Thanks, it seems to work for most albums, however if I search artist: Menomena, album: Friend and foe, it saves the thumbnail version, not the full-sized art. The same search works correctly on thejosher.net.

Strange, thanks for pointing it out. The result returned from http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?... gives a url of http://a1.phobos.apple.com/r40/Music/1d/68/3f/mzi.xoairpuj.enc.jpg.... This seems to have a thumbnail available, but no full size, at least not at http://a1.phobos.apple.com/r40/Music/1d/68/3f/mzi.xoairpuj.jpg.

Josh's site returns a result of http://a1.phobos.apple.com/r10/Music/32/a3/53/mzi.dbjwyonx.enc.jpg... for exactly the same "Menomena / Friend and foe" search. Without being able to see his source code (in particular the original query he uses), I have no idea why he receives a different result.

I suppose we could always use him as a middle-man, and do the searches through his site and grab the images off that, although I'd prefer not to.

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-12 09:42:13
I suppose we could always use him as a middle-man, and do the searches through his site and grab the images off that, although I'd prefer not to.
Alex


I've emailed him requesting his source code/how he obtains the URL.
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-13 01:19:32
A few changes to the headers sent in the initial request seem to make all the difference:

Code: [Select]
        request.UserAgent="iTunes/7.4 (Macintosh; U; PPC Mac OS X 10.4.7)"
        request.Headers.Add("X-Apple-Tz","-21600")
        request.Headers.Add("X-Apple-Store-Front","143441")
        request.Headers.Add("Accept-Language","en-us, en;q=0.50")
        request.Headers.Add("Accept-Encoding","gzip, x-aes-cbc")
Title: Album Art Downloader XUI
Post by: phunkydizco on 2007-09-13 19:17:15
Performance of the new version is really great. Good work.

What do you think about a context menu item for windows explorer? I organize my library with windows explorer and use the following structure: Artist/(Year) Album. It would be great to start aad with the right parameters by clicking on the album folder.
Title: Album Art Downloader XUI
Post by: masterrossi on 2007-09-13 19:25:22
I have the album art in the folders of my albums. How can I search those for artwork with the foobar browser and how can I save them in those folders?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-14 08:11:28
A few changes to the headers sent in the initial request seem to make all the difference:

Yes, that does fix the search you mentioned, and doesn't appear to break others. Here's an updated itunes.boo (http://www.byalexv.co.uk/foobar/itunes.boo) script with them in.

Performance of the new version is really great. Good work.

What do you think about a context menu item for windows explorer? I organize my library with windows explorer and use the following structure: Artist/(Year) Album. It would be great to start aad with the right parameters by clicking on the album folder.

Thanks! It took some doing, but I'm pleased with the results. If I've understood you right, what you want to be able to do is right click on a folder and choose "Browse for Album Art..." or similar, and have AAD launch with the file browser window searching that folder? AAD has a command line parameter you can use for that, /fileBrowser "path". Here's a little .reg file that will add that command line to the context menu for folders for you: AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg)

Of course, if you've installed AAD somewhere other than "C:\Program Files\AlbumArtDownloader", or you want the command called something other than "Browse for Album Art...", then edit the file before merging it.

I have the album art in the folders of my albums. How can I search those for artwork with the foobar browser and how can I save them in those folders?

If you run the foobar browser it will search your foobar library for artist and albums. For each one it finds, it will try to find art for it. By default, it will look for "Folder.jpg" in the same folder as the album. If that's not where you are storing your art, then click the Options link in the Foobar Browser window, and change it to the right filename. The search is done relative to the media file that the artist/album information was read from.

To save art in the album folder from the Foobar Browser, just double click on the album in the Foobar Browser results list, or select several and click "Get Artwork for Selection...". Each art search window launched from the foobar browser will be set to save the art into the place where the Foobar Browser was searching for art for that album. So, if it was looking for Folder.jpg in the album folder, that's where the search window will save it by default when you click the Save button.

I hope this answers your question.
Title: Album Art Downloader XUI
Post by: phunkydizco on 2007-09-14 08:49:30
Thanks! It took some doing, but I'm pleased with the results. If I've understood you right, what you want to be able to do is right click on a folder and choose "Browse for Album Art..." or similar, and have AAD launch with the file browser window searching that folder? AAD has a command line parameter you can use for that, /fileBrowser "path". Here's a little .reg file that will add that command line to the context menu for folders for you: AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg)

Of course, if you've installed AAD somewhere other than "C:\Program Files\AlbumArtDownloader", or you want the command called something other than "Browse for Album Art...", then edit the file before merging it.


I don't want to launch AAD with file browser window. I want to launch the album art search with right parameters for artist, album and JPG path. I think this is not possible with a reg file. ADD should extract the parameters from the passed path. The algorithm for the extraction should be configurable. I hope you understand what I mean.
Title: Album Art Downloader XUI
Post by: masterrossi on 2007-09-14 09:07:00
To save art in the album folder from the Foobar Browser, just double click on the album in the Foobar Browser results list, or select several and click "Get Artwork for Selection...". Each art search window launched from the foobar browser will be set to save the art into the place where the Foobar Browser was searching for art for that album. So, if it was looking for Folder.jpg in the album folder, that's where the search window will save it by default when you click the Save button.

I hope this answers your question.

A great, now I see how it works.

Great job. Thanks a lot
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-14 09:32:04
I don't want to launch AAD with file browser window. I want to launch the album art search with right parameters for artist, album and JPG path. I think this is not possible with a reg file. ADD should extract the parameters from the passed path. The algorithm for the extraction should be configurable. I hope you understand what I mean.

Ah, OK, I misunderstood. AAD will not attempt to extract artist/album information from a filepath. I don't see this changing any time soon. It can read the artist/album information from most media files, though, so if you pass it a media file from the album you want to search for, or a folder containing media files from the album you want to search for, it will read the information from that. This is what the File Browser is for.

I realise that this is one additional step than what you were hoping for, you have to first see the result in the browser, then double click on it to search, rather than going directly to the search window, but I can't think of a good way around that at the moment.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2007-09-15 07:50:57
I just had the following crash:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programmi\AlbumArtDownloader\errorlog.txt

App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ArgumentException: Caratteri non validi nel percorso.
  in System.IO.Path.CheckInvalidPathChars(String path)
  in System.IO.Path.GetFileName(String path)
  in AlbumArtDownloader.AlbumArt.Save()
  in AlbumArtDownloader.ArtSearchWindow.SaveExec(Object sender, ExecutedRoutedEventArgs e)
  in System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  in System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  in System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  in System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  in System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  in System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  in System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  in System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  in System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  in System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  in System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
  in System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  in System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  in System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  in MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  in System.Windows.Controls.Button.OnClick()
  in System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
  in System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
  in System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  in System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  in System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  in System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  in System.Windows.UIElement.ReRaiseEventAs(RoutedEventArgs args, RoutedEvent newEvent)
  in System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
  in System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  in System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  in System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  in System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  in System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
  in System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  in System.Windows.Input.InputManager.ProcessStagingArea()
  in System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
  in System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
  in System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
  in System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  in System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  in MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  in MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  in System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  in System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  in System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  in System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  in MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  in MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  in System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  in System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  in System.Windows.Threading.Dispatcher.Run()
  in System.Windows.Application.RunInternal(Window window)
  in System.Windows.Application.Run(Window window)
  in System.Windows.Application.Run()
  in AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  in AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  in AlbumArtDownloader.App.Main(String[] args)
It happened when I clicked on the save icon because, I think, foo_run was not properly configured and I was trying to save with a file name containing a double quote.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-15 09:06:21
I just had the following crash:

<snip/>

It happened when I clicked on the save icon because, I think, foo_run was not properly configured and I was trying to save with a file name containing a double quote.

Alessandro

Thank you for the report. Yes, it does seem likely that it was caused by a filename with a double quote in it. I will make sure that invalid filenames are handled better for the next version.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-16 20:18:55
I get error when processing 157 files in queue:

http://cl1p.net/downloadartalbum/ (http://cl1p.net/downloadartalbum/)

Thanks for the error report. Unfortunately it does not give me much of a clue as to what the problem is, only that it occurred when trying to download the full size image for one of the results. Do you recall what the artist/album that was being currently searched for when it crashed was? If you weren't using all sources, then knowing which ones were in use would be helpful too.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-16 23:26:38
hi, i were looking after artist "Joe Bataan" and a album of him. opened a second search (a new window opens) saved a picture, saved a second picture (not sure in which window, first, or second, both were open) and denied the question if i want to overwrite the existing file and gave the file an other name. after some clicking and checking some pictures i wanted to close the album art downloader XUI with clicking on X and then this came up :-)

 Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: E:\Programme\foobar2000\components\AlbumArtDownloaderXUI\errorlog.txt

Code: [Select]
App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.UnauthorizedAccessException: Der Zugriff auf den Pfad C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config wurde verweigert.
  bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
  bei System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
  bei System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
  bei System.Configuration.Internal.WriteFileContext.FileIsWriteLocked(String FileName)
  bei System.Configuration.Internal.WriteFileContext.ReplaceFile(String Source, String Target)
  bei System.Configuration.Internal.WriteFileContext.Complete(String filename, Boolean success)
  bei System.Configuration.Internal.InternalConfigHost.StaticWriteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
  bei System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.W
riteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
  bei System.Configuration.Internal.DelegatingConfigHost.WriteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
  bei System.Configuration.ClientSettingsStore.ClientSettingsConfigurationHost.WriteCompleted(String streamName, Boolean success, Object writeContext)
  bei System.Configuration.UpdateConfigHost.WriteCompleted(String streamName, Boolean success, Object writeContext)
  bei System.Configuration.MgmtConfigurationRecord.SaveAs(String filename, ConfigurationSaveMode saveMode, Boolean forceUpdateAll)
  bei System.Configuration.Configuration.SaveAsImpl(String filename, ConfigurationSaveMode saveMode, Boolean forceSaveAll)
  bei System.Configuration.Configuration.Save()
  bei System.Configuration.ClientSettingsStore.WriteSettings(String sectionName, Boolean isRoaming, IDictionary newSettings)
  bei System.Configuration.LocalFileSettingsProvider.SetPropertyValues(SettingsContext context, SettingsPropertyValueCollection values)
  bei System.Configuration.SettingsBase.SaveCore()
  bei System.Configuration.SettingsBase.Save()
  bei System.Configuration.ApplicationSettingsBase.Save()
  bei AlbumArtDownloader.Properties.WindowSettings.SaveWindowState()
  bei AlbumArtDownloader.Properties.WindowSettings.window_Closing(Object sender, CancelEventArgs e)
  bei System.Windows.Window.OnClosing(CancelEventArgs e)
  bei AlbumArtDownloader.ArtSearchWindow.OnClosing(CancelEventArgs e)
  bei System.Windows.Window.WmClose()
  bei System.Windows.Window.WindowFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: iElectric on 2007-09-16 23:54:16
Sorry, I wasn't careful about that info. I will be next time. Cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-17 08:22:24
hi, i were looking after artist "Joe Bataan" and a album of him. opened a second search (a new window opens) saved a picture, saved a second picture (not sure in which window, first, or second, both were open) and denied the question if i want to overwrite the existing file and gave the file an other name. after some clicking and checking some pictures i wanted to close the album art downloader XUI with clicking on X and then this came up :-)

Hello, thank you for the error report. It occurred because for some reason AAD was denied permission to save to its settings file, at "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config"

Does that error come up every time you close AAD, or did it only happen once? I don't know why it would happen, but what I will do is for the next version make sure that if it can't save its settings, it will just not save them, and not crash.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-17 19:26:17
hi, another *small* issue :-)

my settings:

"e:\Programme\foobar2000\components\AlbumArtDownloaderXUI\AlbumArt.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%album%.jpg"

will produce this in the log:
[20:20:08] Successful execution of "shell32.dll,ShellExec_RunDLL "e:\Programme\foobar2000\components\AlbumArtDownloaderXUI\AlbumArt.exe" "?" "?" "D:\music\?.jpg""

it a song without any tags.

i know, that what AAD is doing here is right, because the commandline told him to do, but i know too, he cant write such a filename "?.jpg" to the disk, so he shouldnt try ;-) because it gives an error.

suggestion:
better to replace illegal chars
or, if illegal chars found, ask the user to rename it by hand.
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-17 19:46:06
hi, i were looking after artist "Joe Bataan" and a album of him. opened a second search (a new window opens) saved a picture, saved a second picture (not sure in which window, first, or second, both were open) and denied the question if i want to overwrite the existing file and gave the file an other name. after some clicking and checking some pictures i wanted to close the album art downloader XUI with clicking on X and then this came up :-)
Hello, thank you for the error report. It occurred because for some reason AAD was denied permission to save to its settings file, at "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config"

Does that error come up every time you close AAD, or did it only happen once? I don't know why it would happen, but what I will do is for the next version make sure that if it can't save its settings, it will just not save them, and not crash.

it crashes all the time, if i close AAD.

funny, because earlier he does not crash at all.

i could test a scenario to see if he crashes if i close it. he did.
but now, it crashes even, if i start it. strange. (and a pitty, because i cannot use it anymore. maybe rebooting XP will do the trick...)

Code: [Select]
App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Configuration.ConfigurationErrorsException: Das Konfigurationssystem konnte nicht initialisiert werden. ---> System.Configuration.ConfigurationErrorsException: Beim Laden einer Konfigurationsdatei ist ein Fehler aufgetreten.: Der Zugriff auf den Pfad C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config wurde verweigert. (C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config) ---> System.UnauthorizedAccessException: Der Zugriff auf den Pfad C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_jut1kpnbrzgm0e4oabrkut0xxquyli2d\0.9.0.0\user.config wurde verweigert.
  bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
  bei System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
  bei System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
  bei System.Configuration.Internal.InternalConfigHost.StaticOpenStreamForRead(String streamName)
  bei System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.O
penStreamForRead(String streamName, Boolean assertPermissions)
  bei System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.O
penStreamForRead(String streamName)
  bei System.Configuration.ClientConfigurationHost.OpenStreamForRead(String streamName)
  bei System.Configuration.BaseConfigurationRecord.InitConfigFromFile()
  --- Ende der internen Ausnahmestapelüberwachung ---
  bei System.Configuration.ConfigurationSchemaErrors.ThrowIfErrors(Boolean ignoreLocal)
  bei System.Configuration.BaseConfigurationRecord.ThrowIfParseErrors(ConfigurationSchemaErrors schemaErrors)
  bei System.Configuration.BaseConfigurationRecord.ThrowIfInitErrors()
  bei System.Configuration.ClientConfigurationSystem.OnConfigRemoved(Object sender, InternalConfigEventArgs e)
  --- Ende der internen Ausnahmestapelüberwachung ---
  bei System.Configuration.ClientConfigurationSystem.OnConfigRemoved(Object sender, InternalConfigEventArgs e)
  bei System.Configuration.Internal.InternalConfigRoot.OnConfigRemoved(InternalConfigEventArgs e)
  bei System.Configuration.Internal.InternalConfigRoot.RemoveConfigImpl(String configPath, BaseConfigurationRecord configRecord)
  bei System.Configuration.BaseConfigurationRecord.Remove()
  bei System.Configuration.BaseConfigurationRecord.GetSectionRecursive(String configKey, Boolean getLkg, Boolean checkPermission, Boolean getRuntimeObject, Boolean requestIsHere, Object& result, Object& resultRuntimeObject)
  bei System.Configuration.BaseConfigurationRecord.GetSection(String configKey, Boolean getLkg, Boolean checkPermission)
  bei System.Configuration.BaseConfigurationRecord.GetSection(String configKey)
  bei System.Configuration.ClientConfigurationSystem.System.Configuration.Internal.IInternalConfigSystem.G
etSection(String sectionName)
  bei System.Configuration.ConfigurationManager.GetSection(String sectionName)
  bei System.Configuration.ClientSettingsStore.ReadSettings(String sectionName, Boolean isUserScoped)
  bei System.Configuration.LocalFileSettingsProvider.GetPropertyValues(SettingsContext context, SettingsPropertyCollection properties)
  bei System.Configuration.SettingsBase.GetPropertiesFromProvider(SettingsProvider provider)
  bei System.Configuration.SettingsBase.GetPropertyValueByName(String propertyName)
  bei System.Configuration.SettingsBase.get_Item(String propertyName)
  bei System.Configuration.ApplicationSettingsBase.GetPropertyValue(String propertyName)
  bei System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
  bei AlbumArtDownloader.Properties.Settings.get_ApplicationVersion()
  bei AlbumArtDownloader.App.UpgradeSettings()
  bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  bei System.Windows.Application.<.ctor>b__0(Object unused)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)


even foobar crashed. (this is failure.txt)

Code: [Select]
Illegal operation:
Code: C0000005h, flags: 00000000h, address: 028E4961h
Access violation, operation: read, address: 00000000h
Call path:
entry=>app_mainloop=>menu_helpers::run_command(), by GUID
This is the first crash logged by this instance.
Code bytes (028E4961h):
028E4921h:  5D C4 8D 45 EC 50 C6 45 FC 01 E8 18 1A 00 00 59
028E4931h:  89 5D F0 39 5E 24 C6 45 FC 03 BF A9 FB 8F 02 76
028E4941h:  05 8B 46 18 EB 02 8B C7 8B 4D EC 8B 11 50 8D 45
028E4951h:  F0 50 FF 52 0C 84 C0 0F 84 5A 01 00 00 8B 4D 08
028E4961h:  8B 01 53 8D 55 F0 52 8D 55 B4 52 53 FF 50 10 84
028E4971h:  C0 0F 84 40 01 00 00 8A 46 28 F6 D8 68 98 D2 8F
028E4981h:  02 8D 4D C8 1B C0 83 E0 06 40 89 45 E8 E8 4D FE
028E4991h:  FF FF 39 5D C4 8B 45 B8 C6 45 FC 04 77 02 8B C7
Stack (0012F5BCh):
0012F59Ch:  00000000 0012F8D8 0012F8B0 00000000
0012F5ACh:  ABFE2DD8 ABFE2AB0 00000000 ABFE2B70
0012F5BCh:  D2CDEAB8 00000000 02924D50 0012F738
0012F5CCh:  00000000 67452301 EFCDAB89 98BADCFE
0012F5DCh:  10325476 028FFBB4 00000000 00000000
0012F5ECh:  00000000 00000000 00000000 028E624A
0012F5FCh:  0012F634 028E6251 D2CDEAB0 00000000
0012F60Ch:  02924D50 0012F738 00000001 004DF5AC
0012F61Ch:  05021FD8 0012F680 028FB5ED 00000003
0012F62Ch:  0012F648 028E6333 00000000 00000006
0012F63Ch:  028FD710 08860658 0012F634 0012F68C
0012F64Ch:  028E6872 00000001 03632FBC D2CDEA18
0012F65Ch:  00000000 02904748 08860658 8148260C
0012F66Ch:  FEDE6332 6F0D9531 0FE5D13B 028FD710
0012F67Ch:  00000006 0012F6DC 028FBD09 00000000
0012F68Ch:  0012F6E8 035CB869 00000000 08860668
0012F69Ch:  0012F738 03632FBC 2FD814CB 00390A84
0012F6ACh:  0367DD38 00000000 005CB2CF 02904748
0012F6BCh:  00000013 00000005 003BA490 75D1DD87
0012F6CCh:  4AAC9E48 25AAA98A BD5AC0D6 035F682B
Registers:
EAX: 00153501, EBX: 00000000, ECX: 00000000, EDX: 00153558
ESI: 029240F0, EDI: 028FFBA9, EBP: 0012F62C, ESP: 0012F5BC
Crash location: "foo_run", loaded at 028E0000h - 0290B000h

Loaded modules:
foobar2000   loaded at 00400000h - 004F3000h
ntdll loaded at 7C910000h - 7C9C7000h
kernel32 loaded at 7C800000h - 7C907000h
COMCTL32 loaded at 773A0000h - 774A3000h
msvcrt   loaded at 77BE0000h - 77C38000h
ADVAPI32 loaded at 77DA0000h - 77E4A000h
RPCRT4   loaded at 77E50000h - 77EE1000h
GDI32 loaded at 77EF0000h - 77F37000h
USER32   loaded at 7E360000h - 7E3F0000h
SHLWAPI   loaded at 77F40000h - 77FB6000h
SHELL32   loaded at 7C9D0000h - 7D1EF000h
ole32 loaded at 774B0000h - 775ED000h
shared   loaded at 10000000h - 10029000h
comdlg32 loaded at 76350000h - 7639A000h
SplashKiller loaded at 003C0000h - 003CC000h
foo_abx   loaded at 009E0000h - 00A13000h
foo_ac3   loaded at 00A30000h - 00A5F000h
foo_adpcm loaded at 00A80000h - 00AD2000h
foo_AdvancedControls loaded at 00B00000h - 00B44000h
foo_albumlist loaded at 00B60000h - 00BA7000h
OLEAUT32 loaded at 770F0000h - 7717B000h
foo_audioscrobbler   loaded at 00BD0000h - 00C07000h
WS2_32   loaded at 71A10000h - 71A27000h
WS2HELP   loaded at 71A00000h - 71A08000h
foo_bitcompare   loaded at 00C30000h - 00C57000h
foo_burninate loaded at 00C80000h - 00CB7000h
VERSION   loaded at 77BD0000h - 77BD8000h
foo_cdda loaded at 00CE0000h - 00D15000h
foo_channel_mixer loaded at 00D40000h - 00D7B000h
foo_common   loaded at 00D90000h - 00DC3000h
foo_converter loaded at 00DF0000h - 00E59000h
foo_convolve loaded at 00E80000h - 00ED1000h
foo_dbsearch loaded at 00F00000h - 00F70000h
foo_discogs   loaded at 00F90000h - 0100E000h
gdiplus   loaded at 4EBA0000h - 4ED43000h
WINMM loaded at 76AF0000h - 76B1E000h
foo_dsp_centercut loaded at 010B0000h - 010D5000h
foo_dsp_crossfader   loaded at 01100000h - 0115F000h
libmmd   loaded at 01170000h - 0141A000h
MSVCR80   loaded at 78130000h - 781CB000h
foo_dsp_silence   loaded at 01440000h - 01469000h
foo_dsp_skip_silence loaded at 01490000h - 014A3000h
foo_dsp_soundtouch   loaded at 014C0000h - 014E3000h
MSVCP80   loaded at 7C420000h - 7C4A7000h
foo_dsp_src9 loaded at 01500000h - 0153B000h
foo_dsp_std   loaded at 01550000h - 01591000h
foo_dsp_vlevel   loaded at 015C0000h - 015E4000h
foo_dsp_vst   loaded at 01610000h - 01632000h
foo_dsp_winamp   loaded at 01660000h - 01683000h
foo_dts   loaded at 016B0000h - 016E7000h
foo_dumb loaded at 01700000h - 01789000h
foo_freedb2   loaded at 017B0000h - 017F1000h
foo_freedb2_fix   loaded at 01820000h - 01835000h
foo_g15lcd   loaded at 01860000h - 01890000h
foo_game loaded at 6C810000h - 6C843000h
foo_gep   loaded at 018C0000h - 0195C000h
MSIMG32   loaded at 76320000h - 76325000h
foo_infobox   loaded at 01980000h - 019C0000h
foo_input_alac   loaded at 019E0000h - 019FD000h
foo_input_awma   loaded at 01A20000h - 01A5D000h
WMVCore   loaded at 15110000h - 1536A000h
WMASF loaded at 11C70000h - 11CA9000h
foo_input_dts loaded at 01A70000h - 01AD5000h
foo_input_matroska   loaded at 01B00000h - 01B88000h
foo_input_monkey loaded at 01BB0000h - 01BFA000h
foo_input_mslive loaded at 01C20000h - 01C97000h
foo_input_reverse loaded at 01CB0000h - 01CDE000h
foo_input_shorten loaded at 01CF0000h - 01D1D000h
foo_input_std loaded at 01D40000h - 01E52000h
foo_input_tak loaded at 01E80000h - 01EC7000h
tak_deco_lib loaded at 01EE0000h - 01F11000h
foo_input_tta loaded at 02040000h - 0206D000h
foo_lirc loaded at 02090000h - 020B8000h
foo_lnk   loaded at 020E0000h - 020F9000h
foo_lock_ex   loaded at 02120000h - 02139000h
foo_lunar2   loaded at 02150000h - 02171000h
foo_lyricsdb loaded at 021A0000h - 021CF000h
WININET   loaded at 77180000h - 77227000h
CRYPT32   loaded at 77A50000h - 77AE5000h
MSASN1   loaded at 77AF0000h - 77B02000h
foo_masstag   loaded at 021F0000h - 02240000h
foo_masstag_addons   loaded at 02260000h - 0227D000h
foo_menu_addons   loaded at 022A0000h - 022F1000h
foo_midi loaded at 02310000h - 023BA000h
foo_navigator loaded at 023E0000h - 02414000h
foo_osd   loaded at 02440000h - 02474000h
foo_out_asio loaded at 024A0000h - 024CF000h
foo_packet_decoder_ac3   loaded at 024F0000h - 02517000h
foo_packet_decoder_wavpack   loaded at 02540000h - 02565000h
foo_playlist_bind loaded at 02590000h - 025B5000h
foo_playlist_manager loaded at 025D0000h - 02614000h
foo_pqview   loaded at 02640000h - 0265B000h
foo_preview   loaded at 02680000h - 026A1000h
foo_psf   loaded at 026C0000h - 027A1000h
foo_random   loaded at 027D0000h - 0280D000h
foo_removeplayed loaded at 02830000h - 02848000h
foo_rgscan   loaded at 02870000h - 028B8000h
foo_run   loaded at 028E0000h - 0290B000h
foo_scheduler loaded at 02930000h - 0299F000h
POWRPROF loaded at 74A50000h - 74A58000h
foo_sendtodevice loaded at 029C0000h - 029FD000h
foo_shutdown loaded at 02A20000h - 02A39000h
foo_sic   loaded at 02A60000h - 02AB9000h
foo_sid   loaded at 02BE0000h - 02C68000h
foo_trackpos loaded at 02C90000h - 02CAF000h
foo_tradersfriend loaded at 02CD0000h - 02D0A000h
foo_uie_albumart loaded at 02D30000h - 02D6C000h
foo_uie_albumlist loaded at 02D90000h - 02DCF000h
foo_uie_bookmarks loaded at 02DF0000h - 02E45000h
foo_uie_console   loaded at 02E60000h - 02E7B000h
foo_uie_lyrics_panel loaded at 02EA0000h - 02F09000h
foo_uie_quicksearch   loaded at 02F30000h - 02F77000h
foo_uie_tabs loaded at 02FA0000h - 02FCA000h
foo_uie_trackinfo_mod loaded at 02FF0000h - 03047000h
foo_uie_vis_projectm loaded at 03060000h - 030AA000h
OPENGL32 loaded at 5F0D0000h - 5F19C000h
GLU32 loaded at 68FC0000h - 68FE0000h
DDRAW loaded at 736D0000h - 73719000h
DCIMAN32 loaded at 73B30000h - 73B36000h
foo_ui_columns   loaded at 035C0000h - 03657000h
foo_ui_std   loaded at 03680000h - 036D7000h
foo_unpack   loaded at 03700000h - 0372E000h
foo_unpack_jma   loaded at 03750000h - 03771000h
foo_unpack_lha   loaded at 037A0000h - 037C0000h
foo_utils loaded at 037E0000h - 03818000h
foo_utils_matroska   loaded at 03840000h - 0385A000h
foo_utils_playback   loaded at 03880000h - 03899000h
foo_verifier loaded at 038C0000h - 038F0000h
foo_version   loaded at 03910000h - 03936000h
dbghelp   loaded at 59DD0000h - 59E71000h
foo_vis_projectM loaded at 03A60000h - 03AD1000h
foo_whatsnew loaded at 03B00000h - 03B30000h
foo_winamp_spam   loaded at 03B50000h - 03B7A000h
sizer loaded at 040A0000h - 040A8000h
uxtheme   loaded at 5B0F0000h - 5B128000h
nvoglnt   loaded at 69500000h - 69A35000h
wtsapi32 loaded at 76F10000h - 76F18000h
WINSTA   loaded at 76300000h - 76310000h
NETAPI32 loaded at 597D0000h - 59824000h
mswsock   loaded at 719B0000h - 719F0000h
DNSAPI   loaded at 76EE0000h - 76F07000h
LgLcdApi loaded at 089B0000h - 089C5000h
dsp_audiostocker loaded at 08B20000h - 08BE7000h
DSOUND   loaded at 73E70000h - 73ECC000h
WINTRUST loaded at 76BF0000h - 76C1E000h
IMAGEHLP loaded at 76C50000h - 76C78000h
wdmaud   loaded at 72C90000h - 72C99000h
msacm32   loaded at 72C80000h - 72C88000h
MSACM32   loaded at 77BB0000h - 77BC5000h
midimap   loaded at 77BA0000h - 77BA7000h
KsUser   loaded at 73E40000h - 73E44000h
rasadhlp loaded at 76F80000h - 76F86000h
hnetcfg   loaded at 66710000h - 66769000h
wshtcpip loaded at 719F0000h - 719F8000h
appHelp   loaded at 77B10000h - 77B32000h
CLBCATQ   loaded at 76F90000h - 7700F000h
COMRes   loaded at 77010000h - 770E3000h
shdocvw   loaded at 77730000h - 7789F000h
CRYPTUI   loaded at 76880000h - 76905000h
WLDAP32   loaded at 76F20000h - 76F4D000h
urlmon   loaded at 77230000h - 772CD000h
Secur32   loaded at 77FC0000h - 77FD1000h
SETUPAPI loaded at 778F0000h - 779E4000h
browseui loaded at 75F20000h - 7601C000h

Stack dump analysis:
Address: 028FFBB4h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E624Ah, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E6251h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 004DF5ACh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 028FB5EDh, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E6333h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028FD710h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028E6872h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 02904748h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028FD710h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 028FBD09h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 035CB869h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 02904748h, location: "foo_run", loaded at 028E0000h - 0290B000h
Address: 035F682Bh, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 03622911h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035CB8B3h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035FC046h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E368B26h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowThreadProcessId" (+000000A6h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 03627AA4h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E3688DAh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongW" (+00000034h)
Address: 004DEE08h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 03621770h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035C6828h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E36B50Ch, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+000001D0h)
Address: 7E36B51Ch, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+000001E0h)
Address: 7E368734h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000006Dh)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E368816h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000014Fh)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E368830h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+00000169h)
Address: 7E36B4C0h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+00000184h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E36B4D0h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+00000194h)
Address: 7E36B50Ch, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+000001D0h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7C91EAE3h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "KiUserCallbackDispatcher" (+00000013h)
Address: 035C66B0h, location: "foo_ui_columns", loaded at 035C0000h - 03657000h
Address: 7E36B473h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DefWindowProcW" (+00000137h)
Address: 7E3694BEh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongA" (+00000061h)
Address: 7E36D4E4h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "SetPropW" (+000000BBh)
Address: 7E36B933h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "IsWindow" (+00000000h)
Address: 7E36B903h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "SendMessageW" (+00000049h)
Address: 7741489Ah, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "Ordinal384" (+000589FAh)
Address: 7741570Bh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000B67h)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E36F95Bh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "CallNextHookEx" (+00000100h)
Address: 7C91EAE3h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "KiUserCallbackDispatcher" (+00000013h)
Address: 040A175Ch, location: "sizer", loaded at 040A0000h - 040A8000h
Symbol: "ReleaseResizeInfo" (+000003D3h)
Address: 7E38E175h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "User32InitializeImmEntryTable" (+00000E18h)
Address: 7E38E152h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "User32InitializeImmEntryTable" (+00000DF5h)
Address: 7E368734h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000006Dh)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E368816h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+0000014Fh)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E368830h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetDC" (+00000169h)
Address: 7E3689CDh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongW" (+00000127h)
Address: 77414BDBh, location: "COMCTL32", loaded at 773A0000h - 774A3000h
Symbol: "CreateToolbar" (+00000037h)
Address: 7E36DAEAh, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DestroyWindow" (+00000000h)
Address: 7E37D950h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "IsDialogMessageW" (+0000008Eh)
Address: 7E390457h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DeregisterShellHookWindow" (+000001CFh)
Address: 7E3689F0h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "GetWindowLongW" (+0000014Ah)
Address: 7E368A10h, location: "USER32", loaded at 7E360000h - 7E3F0000h
Symbol: "DispatchMessageW" (+0000000Fh)
Address: 0042FF5Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 10002DD2h, location: "shared", loaded at 10000000h - 10029000h
Symbol: "uCallStackTracker::uCallStackTracker" (+00000032h)
Address: 004C04F8h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00430AA3h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C07B4h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7650h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C920732h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C7634h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C920732h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 7C920732h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000015Eh)
Address: 7C921538h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "wcsncpy" (+00000AA9h)
Address: 7C921596h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "wcsncpy" (+00000B07h)
Address: 7C9206EBh, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+00000117h)
Address: 004E41B8h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C92056Dh, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlFreeHeap" (+00000130h)
Address: 1000C021h, location: "shared", loaded at 10000000h - 10029000h
Address: 7C91EE18h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "strchr" (+00000117h)
Address: 7C9206F0h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000011Ch)
Address: 7C91EE18h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "strchr" (+00000117h)
Address: 7C9206F0h, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+0000011Ch)
Address: 7C9206EBh, location: "ntdll", loaded at 7C910000h - 7C9C7000h
Symbol: "RtlAllocateHeap" (+00000117h)
Address: 00492BFDh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E4238h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00447B71h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0045CE23h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0044E9CAh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004970A3h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 10002D87h, location: "shared", loaded at 10000000h - 10029000h
Symbol: "uPrintCrashInfo_SetDumpPath" (+000000A7h)
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004AF584h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004C0508h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00430CAAh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E09B0h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0049712Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00492502h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004924FCh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004B49E0h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004B3450h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E4230h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00497440h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004AF978h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00496804h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 0120DC08h, location: "libmmd", loaded at 01170000h - 0141A000h
Symbol: "_csqrtq_f90" (+0009B2CCh)
Address: 0120DC08h, location: "libmmd", loaded at 01170000h - 0141A000h
Symbol: "_csqrtq_f90" (+0009B2CCh)
Address: 00497440h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 7C816FD7h, location: "kernel32", loaded at 7C800000h - 7C907000h
Symbol: "RegisterWaitForInputIdle" (+00000049h)
Address: 0120DC08h, location: "libmmd", loaded at 01170000h - 0141A000h
Symbol: "_csqrtq_f90" (+0009B2CCh)
Address: 7C839AA8h, location: "kernel32", loaded at 7C800000h - 7C907000h
Symbol: "ValidateLocale" (+000002B0h)
Address: 7C816FE0h, location: "kernel32", loaded at 7C800000h - 7C907000h
Symbol: "RegisterWaitForInputIdle" (+00000052h)
Address: 0049686Dh, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E0049h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004F0044h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 01C61B6Ch, location: "foo_input_mslive", loaded at 01C20000h - 01C97000h
Address: 004B0063h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 01C61B6Ch, location: "foo_input_mslive", loaded at 01C20000h - 01C97000h
Address: 00410072h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004E0049h, location: "foobar2000", loaded at 00400000h - 004F3000h
Address: 004F0044h, location: "foobar2000", loaded at 00400000h - 004F3000h

Version info:
foobar2000 v0.9.4.4
UNICODE

Additional info:
Logitech G15 LCD Display 0.3a  (foo_g15lcd)
VLevel 20060324.0  (foo_dsp_vlevel)
Winamp API Emulator 0.95  (foo_winamp_spam)
Components versions viewer 0.3  (foo_version)
Album Art Panel 0.2.6  (foo_uie_albumart)
GCN DSP decoder 1.3  (foo_adpcm)
Acro WMA decoder 0.1.6.5 (Intel SSE)  (foo_input_awma)
Matroska Plugin 0.9.2.1  (foo_input_matroska)
Quick Search Toolbar 2.8j  (foo_uie_quicksearch)
Track info panel mod 0.8.0 beta [Dec  6 2006 - 14:21:24]  (foo_uie_trackinfo_mod)
foosic music database 1.0 beta 12  (foo_sic)
Lunar 2 PCM decoder 0.5  (foo_lunar2)
Default User Interface 0.9acc  (foo_ui_std)
sidplay2 1.13  (foo_sid)
WMA Decoder 1.1  (foo_input_std)
Audio CD Writer 2.0.1  (foo_burninate)
Console panel 0.2.1  (foo_uie_console)
Playlist Manager 1.0.2  (foo_playlist_manager)
OKI-ADPCM decoder 0.14  (foo_adpcm)
Highly Experimental 2.0.6  (foo_psf)
MIDI synthesizer host 1.7  (foo_midi)
ADX decoder 1.6  (foo_adpcm)
Resampler (Secret Rabbit Code) 1.03  (foo_dsp_src9)
Gapless Crossfader 0.3.3.1 (Intel SSE)  (foo_dsp_crossfader)
Standard Input Array 1.0  (foo_input_std)
Matroska Utility Plugin 1.0.2  (foo_utils_matroska)
FLAC Decoder 1.1.0  (foo_input_std)
Tabbed panel modified 0.2.6  (foo_uie_tabs)
Audioscrobbler 1.3.6  (foo_audioscrobbler)
ASIO support 1.2.5  (foo_out_asio)
SoundTouch DSP 0.1 (Intel SSE)  (foo_dsp_soundtouch)
BRR decoder and converter 0.7  (foo_adpcm)
Remove played Files 1.4.0  (foo_removeplayed)
Send to Device 1.1.1 [Sep  7 2007 - 10:34:03]  (foo_sendtodevice)
TTA Audio Decoder (unofficial) 2.4.2  (foo_input_tta)
Shell Link Resolver 1.2  (foo_lnk)
Bookmarks 0.2.5.2  (foo_uie_bookmarks)
Winamp DSP Bridge 1.4.1  (foo_dsp_winamp)
Masstagger Addons 0.3.4 (Intel SSE)  (foo_masstag_addons)
AC3 decoder 0.9  (foo_ac3)
Common services 0.1  (foo_common)
Columns UI 0.1.3 beta 1v6 TEST  (foo_ui_columns)
Database Search 1.4  (foo_dbsearch)
Navigator 0.63  (foo_navigator)
projectM visualization 1.97.6.2  (foo_vis_projectM)
CD Audio Decoder 2.1.1  (foo_cdda)
Channel Mixer 0.9.6.2  (foo_channel_mixer)
Playlist Bind 3.2  (foo_playlist_bind)
Game Emu Player 1.5  (foo_gep)
Menu Addons 0.3.9.5 (Intel SSE)  (foo_menu_addons)
Scheduler 3.53  (foo_scheduler)
Shorten decoder 0.4.2.1  (foo_input_shorten)
ATSC A/52 (AC3) Packet Decoder 0.9  (foo_packet_decoder_ac3)
Preview 1.2  (foo_preview)
Run services 0.3.2  (foo_run)
Album List 3.2.0  (foo_albumlist)
ALAC Decoder 1.0  (foo_input_alac)
DUMB module decoder 0.9.8.4  (foo_dumb)
Binary Comparator 1.1  (foo_bitcompare)
JMA unpacker 1.0  (foo_unpack_jma)
projectM visualization (Panel) 0.4  (foo_uie_vis_projectm)
freedb Tagger 0.5.2.1  (foo_freedb2)
Feature Watcher 1.0.2  (foo_whatsnew)
ZIP/GZIP reader 1.0  (foo_unpack)
Randomized Playlist Entry 1.2.3  (foo_random)
Skip silence 0.1 (Intel SSE)  (foo_dsp_skip_silence)
WavPack Packet Decoder 0.9.1  (foo_packet_decoder_wavpack)
DTS decoder 0.1.7  (foo_input_dts)
File Integrity Verifier 1.0.1  (foo_verifier)
Center Cut 1.0.1  (foo_dsp_centercut)
Reverse Playback 0.1.3 (Intel SSE)  (foo_input_reverse)
RAR reader 1.1  (foo_unpack)
Freedb2 characters fixer (masstagger addon) 0.02  (foo_freedb2_fix)
mslive 0.3.9 (Intel SSE)  (foo_input_mslive)
ABX Comparator 1.3.1  (foo_abx)
Standard DSP array 1.0  (foo_dsp_std)
DTS decoder 0.1.1  (foo_dts)
Converter 1.0.1  (foo_converter)
Pause on Lock (extended) 1.0  (foo_lock_ex)
TAK Decoder 0.3.2  (foo_input_tak)
Convolver 0.3  (foo_convolve)
Game Audio Decoder 1.08  (foo_game)
On-Screen Display GDI+ 1.52  (foo_osd)
Masstagger 1.6  (foo_masstag)
Live Show Tagger 0.6.1  (foo_tradersfriend)
Interplay ACM decoder 1.0  (foo_adpcm)
XA ADPCM decoder 1.2  (foo_adpcm)
Foo Shutdown 0.9.3  (foo_shutdown)
RAC decoder 1.0  (foo_adpcm)
VST bridge 0.60 Beta  (foo_dsp_vst)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-17 20:46:31
cant write such a filename "?.jpg" to the disk, so he shouldnt try ;-) because it gives an error.

This "Illegal Characters in Filename" crash is already fixed for the next version, as mobyduck [a href="index.php?act=findpost&pid=516671"][{POST_SNAPBACK}][/a] reported it.

For your settings bug, please try deleting the folder "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader" and running Album Art Downloader again. That will reset all your settings for it, but it should run again. If you used the Installer, then uninstalling and re-installing will do this automatically.

Also, could I suggest you wrap long crash reports in codebox tags in your posts, so that they don't take up so much space? It makes the thread easier to read for everyone.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-17 22:29:22
hi,
an addition to my/your last post:
i use foobar2000 on my portable usb stick to play some songs i like, if i'm not on my home computer.
now i see, that AAD will save data on every computer i visited and play songs (and download some covers)

do you mind to save data in the AAD-programs folder? (relative path, without a fixed harddrive-letter)?
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-17 22:43:36
For your settings bug, please try deleting the folder "C:\Dokumente und Einstellungen\user\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader" and running Album Art Downloader again. That will reset all your settings for it, but it should run again. If you used the Installer, then uninstalling and re-installing will do this automatically.
i deleted the folder and AAD did not crash again. thank you.
Title: Album Art Downloader XUI
Post by: Jojo on 2007-09-18 03:07:16
Hmm, it looks like unencrypted iTMS art is available, wonderful. There's a script included with my original 'CoverDownloader' for iTMS, i'll try and convert it. I don't know if it will still work with the XUI version, i haven't been keeping up with the changes.

I'm losing track of all the topics here, can you post once you got it to work. thank you
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-18 04:02:56
hi,
you could add an icon file (AlbumArt.ico/bmp/png) to your provided zip-file/installation, because users who want to assign AAD to a button/icon, cannot use the .exe file for the implemented icon in AlbumArt.exe
so i had to extract the icon manually and convert it to a png, which is a lot or work :-) and assigned it to a button which i can now press instead of using the context-menu
cheers,
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-18 04:27:30
ok, it crashed again. did not done alot with AAD meanwhile.
changed the sorting from default-direction to reverse direction. and then sorted by size. while AAD was loading covers. saved a cover. closed AAD. crash.
i'm wainting now till the new version :-) no errorreport necsessary, i think.

Code: [Select]
App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Ein Aufrufziel hat einen Ausnahmefehler verursacht. ---> System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei AlbumArtDownloader.AlbumArt.<>c__DisplayClass1.<RetrieveFullSizeImageWorker>b__0()
  --- Ende der internen Ausnahmestapelüberwachung ---
  bei System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  bei System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  bei System.Delegate.DynamicInvokeImpl(Object[] args)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-18 07:41:09

Hmm, it looks like unencrypted iTMS art is available, wonderful. There's a script included with my original 'CoverDownloader' for iTMS, i'll try and convert it. I don't know if it will still work with the XUI version, i haven't been keeping up with the changes.

I'm losing track of all the topics here, can you post once you got it to work. thank you


It's already included in the latest release which you can download in the first post in this thread.


hi,
an addition to my/your last post:
i use foobar2000 on my portable usb stick to play some songs i like, if i'm not on my home computer.
now i see, that AAD will save data on every computer i visited and play songs (and download some covers)

do you mind to save data in the AAD-programs folder? (relative path, without a fixed harddrive-letter)?


Probably not a good idea in general because of Vista and limited account compatibilty. If I'm not mistaken it allows the .net framework to choose the best place to store the config. However if you want to take your settings with you on your usb stick, you could try creating a file called AlbumArt.exe.config and copying the user.config file mentioned above into this file. I don't think the program will create a user.config file on other machines if the user doesn't change any settings, however I haven't looked at the internals of the XUI version, so you'll have to test it for yourself.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-18 08:36:27
do you mind to save data in the AAD-programs folder? (relative path, without a fixed harddrive-letter)?

Probably not a good idea in general because of Vista and limited account compatibilty. If I'm not mistaken it allows the .net framework to choose the best place to store the config. However if you want to take your settings with you on your usb stick, you could try creating a file called AlbumArt.exe.config and copying the user.config file mentioned above into this file. I don't think the program will create a user.config file on other machines if the user doesn't change any settings, however I haven't looked at the internals of the XUI version, so you'll have to test it for yourself.
david_dl is correct in that you can copy your user.config file to AlbumArt.exe.config to have local settings. I think, technically, if no settings were changed then no user.config would be created, but in practice the settings include window sizes and positions, so are almost certain to change.

I won't be changing AAD to store its settings in its own folder, as david_dl points out, this breaks Vista compatibility, and is generally not recommended anyway. What I could do, if it were helpful, would be to add some command line parameter that would cause AAD to ensure it does not save any settings.

you could add an icon file (AlbumArt.ico/bmp/png) to your provided zip-file/installation
Sure, no problem, I'll stick the .ico in there. You say you already extracted one now, though, so I won't send it to you now.

ok, it crashed again. did not done alot with AAD meanwhile.
This is the same bug as iElectric [a href="index.php?act=findpost&pid=516956"][{POST_SNAPBACK}][/a] reported - something is going wrong when trying to download a full size image. I still haven't been able to figure out what, and without knowing which artist/album result it was trying to download, I'm not sure how I can test it.

Alex
Title: Album Art Downloader XUI
Post by: Blueinferno on 2007-09-18 15:38:56
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.
Title: Album Art Downloader XUI
Post by: kockroach on 2007-09-18 15:43:13
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.

The options section should allow you to set a minimum, or even maximum, size.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-18 15:45:52
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.

Thanks, glad you liked it! To show images of only 500x500, click the Options link (just below the Album search box), and in the Filter by Image Size area, check both Maximum and Minimum and enter a value of 500 for each. Or, to allow values that are close to, but not exactly 500, use 495 for minimum and 505 for maximum, for example. For non-square images, it is the smaller dimension that must match the criteria specified here.

Hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: Blueinferno on 2007-09-18 22:48:57
Fantastic app. But I'm wondering, is there a way to only show those images with a size of 500x500 or close to? That'd be great.

Thanks, glad you liked it! To show images of only 500x500, click the Options link (just below the Album search box), and in the Filter by Image Size area, check both Maximum and Minimum and enter a value of 500 for each. Or, to allow values that are close to, but not exactly 500, use 495 for minimum and 505 for maximum, for example. For non-square images, it is the smaller dimension that must match the criteria specified here.

Hope this helps,

Alex

Many thanks, for both the help, and a quick answer.
Title: Album Art Downloader XUI
Post by: fuffi on 2007-09-18 22:57:31
Quote
david_dl is correct in that you can copy your user.config file to AlbumArt.exe.config to have local settings


thank you both, portability of programs will be the most important thing in the next years. a long time ago (before win95, hehe) there were no problems with storing program settings in program folder. now, as you both say, vista doesnt like it, i'm very amused. :-) i'm still using XP
anyway. AAD isnt not a very important application for me (although i dont wanna miss it, so dont get me wrong!!) so it it stores security-based information on computers which i dont own, its my fault anyway. now, that i know it, it is no problem. thank you again, your program is a really help!
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-19 06:49:42
Here is an updated version of the iTMS script that can get fullsized art for even more albums. However sometimes the fullsized art will be large, and in TIFF format. I don't know if it's possible to report the filetype from the GetResult function (as it cannot be determined before GetResult is called), so you may end up with AlbumArtDownloader saving a TIFF as .jpg. The resultant file still works in foobar and windows picture gallery though, at least on vista.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-19 07:57:00
you may end up with AlbumArtDownloader saving a TIFF as .jpg.

If you have this problem, make sure that the filename pattern to save as doesn't end in .jpg, but ends in .%extension% instead. That way AlbumArtDownloader will determine the extension automatically from the image format, and correctly use .tif instead of .jpg.

Just one question, David, is there any reason you've chosen to use the older headers again, rather than the ones you suggested in your post [a href='index.php?act=findpost&pid=516175']here[/a]?

Also, could you give an example of a search that returns a tiff, for testing?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: david_dl on 2007-09-19 08:34:39
you may end up with AlbumArtDownloader saving a TIFF as .jpg.

Just one question, David, is there any reason you've chosen to use the older headers again, rather than the ones you suggested in your post [a href='index.php?act=findpost&pid=516175']here[/a]?

No, sorry, I thought I had modified the latest version, my mistake.
Quote
Also, could you give an example of a search that returns a tiff, for testing?

Menomena - I am the Fun Blame Monster
Title: Album Art Downloader XUI
Post by: Mercachifle on 2007-09-19 23:59:28
I can't load the program. It crashes on start:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Archivos de programa\AlbumArtDownloader\errorlog.txt

App version: 0.9.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Windows.Markup.XamlParseException: No se puede convertir la cadena 'AlbumArtDownloader.ico' del atributo 'Icon' en un objeto de tipo 'System.Windows.Media.ImageSource'. No se encontró ningún componente de procesamiento de imágenes apto para completar esta operación.  Error en el objeto 'AlbumArtDownloader.Splashscreen' en el archivo de marcado 'AlbumArt;component/splashscreen.xaml'. ---> System.NotSupportedException: No se encontró ningún componente de procesamiento de imágenes apto para completar esta operación. ---> System.Runtime.InteropServices.COMException (0x88982F50): Excepción de HRESULT: 0x88982F50
   --- Fin del seguimiento de la pila de la excepción interna ---
   en MS.Internal.HRESULT.Check(Int32 hr)
   en System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
   en System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, Boolean insertInDecoderCache)
   en System.Windows.Media.Imaging.BitmapFrame.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption)
   en System.Windows.Media.ImageSourceConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
   en System.ComponentModel.TypeConverter.ConvertFromString(ITypeDescriptorContext context, CultureInfo culture, String text)
   en System.Windows.Markup.XamlTypeMapper.ParseProperty(Object targetObject, Type propType, String propName, Object dpOrPiOrFi, ITypeDescriptorContext typeContext, ParserContext parserContext, String value, Int16 converterTypeId)
   --- Fin del seguimiento de la pila de la excepción interna ---
   en System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
   en System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
   en System.Windows.Markup.XamlTypeMapper.ParseProperty(Object targetObject, Type propType, String propName, Object dpOrPiOrFi, ITypeDescriptorContext typeContext, ParserContext parserContext, String value, Int16 converterTypeId)
   en System.Windows.Markup.BamlRecordReader.ParseProperty(Object element, Type propertyType, String propertyName, Object dpOrPi, String attribValue, Int16 converterTypeId)
   en System.Windows.Markup.BamlRecordReader.ReadPropertyRecordBase(String attribValue, Int16 attributeId, Int16 converterTypeId)
   en System.Windows.Markup.BamlRecordReader.ReadPropertyConverterRecord(BamlPropertyWithConverterRecord bamlPropertyRecord)
   en System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   en System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   en System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
   en System.Windows.Markup.TreeBuilder.Parse()
   en System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
   en System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
   en AlbumArtDownloader.Splashscreen.InitializeComponent()
   en AlbumArtDownloader.Splashscreen..ctor()
   en AlbumArtDownloader.Splashscreen.ShowIfRequired()
   en AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   en System.Windows.Application.<.ctor>b__0(Object unused)
   en System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   en System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   en System.Windows.Threading.DispatcherOperation.InvokeImpl()
   en System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   en System.Threading.ExecutionContext.runTryCode(Object userData)
   en System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   en System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   en System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   en System.Windows.Threading.DispatcherOperation.Invoke()
   en System.Windows.Threading.Dispatcher.ProcessQueue()
   en System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   en MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   en MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   en System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   en System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   en System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   en System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   en MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   en MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   en System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   en System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   en System.Windows.Threading.Dispatcher.Run()
   en System.Windows.Application.RunInternal(Window window)
   en System.Windows.Application.Run(Window window)
   en System.Windows.Application.Run()
   en AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   en AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   en AlbumArtDownloader.App.Main(String[] args)


What is the problem?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-20 08:02:01
I can't load the program. It crashes on start:

What is the problem?


I'm sorry, I haven't a clue. The error report is saying that it can't display the program icon, which it needs to do in order to show a window, in this case the splash screen window, as that is the first to be shown.

As to why it can't display the program icon, I have no idea. You could try making sure you have the latest .net framework installed, but other than that, I have nothing to suggest, sorry.

Alex
Title: Album Art Downloader XUI
Post by: Jojo on 2007-09-20 20:15:55
ok, I'm trying to figure this out. Is it possible to search for album art based on ID3 tags? If so, how would I do that? In addition, I don't like adding Album names for my Singles (I just leave it blank). Therefore, iTunes can't find the album art for the songs, since it only searches for "Artist - Album". It would be nice if I could use the title of a song as the Album title to solve this problem.

thank you
Title: Album Art Downloader XUI
Post by: entrecour on 2007-09-20 21:14:14
Does Album Art Downloader XUI only work with mp3s?  I tried pointing the file browser at my collection of flac files and it didn't find any albums.
Thanks,
Max

The file browser uses MediaInfo (http://mediainfo.sourceforge.net/) to read file tags. I don't think it supports album and artist information in flac (in fact I didn't think flac supported those sorts of tag at all), but if you want to request support for reading a file format, that's the project to ask. If the stand-alone MediaInfo app can read the tags, but Album Art Downloader doesn't, then that's a bug of mine - if you give me a sample file I can try and fix it.

Alex,

I haven't seen any further posts on this but I am also interested in the same issue.

I also encountered problems with flac and Album Art Downloader - it downloaded album art for 5 of my albums out of 100+. I can see no difference in the file information in MediaInfo for those particular 5 albums compared to the others. I am very keen to get a fix for this - what info or files can I send you to help you?

Thanks, David.
Title: Album Art Downloader XUI
Post by: mobyduck on 2007-09-21 08:03:34
Is it possible to search for album art based on ID3 tags? If so, how would I do that?
If I understand correctly what you're asking, you can do that using foobar + foo_run (http://foosion.foobar2000.org/0.9/foo_runcmd-1.0_beta_2-20070125.zip).

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-21 08:20:17
ok, I'm trying to figure this out. Is it possible to search for album art based on ID3 tags? If so, how would I do that? In addition, I don't like adding Album names for my Singles (I just leave it blank). Therefore, iTunes can't find the album art for the songs, since it only searches for "Artist - Album". It would be nice if I could use the title of a song as the Album title to solve this problem.

If you mean from within foobar, then as mobyduck points out, foo_run is used for this, and you can pass whatever info you like to the Artist and Album command line args. If you mean within Album Art Downloader itself, then to search for album art based on ID3 tags, you use the File Browser. This can be pointed at a folder to scan, or you can just drag and drop files on to it.

It will not read the track title though, just Artist and Album. As you point out, some sources won't search for just an artist without an album. The way I see it, the Album is the CD that the track is on, even if there is only one track on that CD, and it is the Album that has art, not the track.

I also encountered problems with flac and Album Art Downloader - it downloaded album art for 5 of my albums out of 100+. I can see no difference in the file information in MediaInfo for those particular 5 albums compared to the others. I am very keen to get a fix for this - what info or files can I send you to help you?

If you have a file that, in MediaInfo, displays "Album" and "Performer" correctly, but in Album Art Downloader File Browser does not show the correct Album and Artist values in the columns, or does not appear in the file browser at all (please verify by dragging and dropping that particular file on to it), then it would be very helpful if you were able to send me that file.

You could try just sending me the text report from MediaInfo, but all that would let me do is verify that Album and Performer are correctly reported there, something I'm sure you're able to do just as well yourself!
Title: Album Art Downloader XUI
Post by: entrecour on 2007-09-21 13:43:42
I have sent you a PM with text output. Let me know how I should send the file to you.

Thanks, David.
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2007-09-22 00:40:54
Thanks david_dl and AlexVallat for providing base code for fetching iTMS artwork.  GREAT Work.

I noticed that the GetResponse method can take up to 100 seconds if an album art is found. So I added

Code: [Select]
        request.Timeout = TIME_OUT ' where TIME_OUT  = 5000 milliseconds by default


Any objections to that you think?

Code: [Select]
      Dim request As HttpWebRequest = CType(HttpWebRequest.Create(url), HttpWebRequest)
        request.UserAgent = "iTunes/7.4 (Macintosh; U; PPC Mac OS X 10.4.7)"
        request.Headers.Add("X-Apple-Tz", "-21600")
        request.Headers.Add("X-Apple-Store-Front", "143441")
        request.Headers.Add("Accept-Language", "en-us, en;q=0.50")
        request.Headers.Add("Accept-Encoding", "gzip, x-aes-cbc")
        Dim response As WebResponse = request.GetResponse
        request.Timeout = 5000
        Return response.GetResponseStream
Title: Album Art Downloader XUI
Post by: pirlouy on 2007-09-22 15:56:46
Hello Alex,

AlbumArtDownloader XUI has well progressed since first versions. Even if it does time, I've just wanted to say I don't have freeze anymore when I click on thumbnails ! Thanks.

Else I don't know if it's scripts or software, but it uses a huge number of RAM (I can easily be at 400Mo).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-22 17:52:48
I noticed that the GetResponse method can take up to 100 seconds if an album art is found. So I added
Code: [Select]
        request.Timeout = TIME_OUT ' where TIME_OUT  = 5000 milliseconds by default

Any objections to that you think?

5 seconds seems a bit short to me, I've had art come back slower than that. As long as the cancel button works, I don't think there is any need to add a shorter hard limit to the timeout - if you don't want to wait any longer for it, you don't have to. Feel free to add it to your local copy of the script, though, just remember to take a backup of it before installing a new version over it.

AlbumArtDownloader XUI has well progressed since first versions. Even if it does time, I've just wanted to say I don't have freeze anymore when I click on thumbnails ! Thanks.

Else I don't know if it's scripts or software, but it uses a huge number of RAM (I can easily be at 400Mo).

Thanks, I've tried hard to improve the performance, and I'm glad its noticeable. Measuring RAM usage can be tricky with .net applications, particularly if you are just using the task manager to do it. They tend to grab all the RAM they like, and only release it when something else wants it. One trick I've seen is if you minimise and restore the Album Art Downloader window, that can get it to show a lower number in the task manager.

On the other hand, if you have a search window open with lots of results in, and have set it to download full size images, then 400Mb is not unreasonable at all. Large images take up lots of memory. If you are finding that memory usage keeps going up significantly, and doesn't go back down even after closing open windows, then there may be a leak I haven't found. Unfortunately these can be very tricky to track down, but if you think you've found one, PM me and I can try and work with you to resolve it.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-22 19:31:02
AlbumArt Downloader XUI v0.10 Released

Some of you may have been hoping that the version after 0.9 would be 1.0, but it just doesn't work like that! I'm not waiting on anything specific to jump to a 1.0 release, but I think quite a bit of work around the website/wiki and documentation for it would be at least one requirement. So, this is 0.10.

This version is a stability release, which fixes some bugs that were reported:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.0 (http://www.microsoft.com/downloads/details.aspx?familyid=10CC340B-F857-4A14-83F5-25634C3BF043&displaylang=en) (required)
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2007-09-23 06:48:28
Great stuff Alex.

I noticed that the 0.10 has

Code: [Select]
request.Headers.Add("X-Apple-Store-Front","143457")


but it won't work for me unless I have

Code: [Select]
request.Headers.Add("X-Apple-Store-Front", "143441")


I begin to wonder if this is dependent on the Country for iTunes Music Store.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-23 08:19:35
Great stuff Alex.

I noticed that the 0.10 has

Code: [Select]
request.Headers.Add("X-Apple-Store-Front","143457")


but it won't work for me unless I have

Code: [Select]
request.Headers.Add("X-Apple-Store-Front", "143441")


I begin to wonder if this is dependent on the Country for iTunes Music Store.

Thanks!

The header might be country dependant, that seems at least reasonable. I thought the 143441 value was the latest one, as suggested [a href='index.php?act=findpost&pid=516175']here[/a], but checking the file as shipped, it does seem to have gone back to 143457. Both values work just fine for me, strangely.

So, if iTunes isn't working for you, try this alternative itunes.boo (http://www.byalexv.co.uk/foobar/itunes.boo), which has the 143441 value. I'd also be interested to hear if this version doesn't work for anyone, when the version in the 0.10 release does. Otherwise, I'll use this version for future releases.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2007-09-23 09:13:45
Alex!

Have a go with and I wonder if you will be pulling hair off just like me!

50 Cent
Curtis

I was also wondering where do you use this code

Code: [Select]
    static def GetResult(url):
        try:
            return GetPageSecret(url + ".jpg");
        except e:
            return GetPageSecret(url + ".tif");


More in particular, to debug this thing more, I'd like to see an example string that passes as "url" to the GetResult method.

This is getting mighty exciting.

Thanks,
McoreD
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-23 10:00:05
50 Cent
Curtis
Yep, no results for that. Neither does thejosher.net (http://www.thejosher.net/iTunes/index.php?artist=50+Cent&album=Curtis), it seems.

I was also wondering where do you use this code

Code: [Select]
    static def GetResult(url):
        try:
            return GetPageSecret(url + ".jpg");
        except e:
            return GetPageSecret(url + ".tif");


More in particular, to debug this thing more, I'd like to see an example string that passes as "url" to the GetResult method.
That nice bit of work was from david_dl - it checks to see if the full album art is available either as a .jpg or as a .tif. Previously, only jpgs would be returned. An example of one of these partial url strings would be: "http://a1.phobos.apple.com/r10/Music/y2004/m03/d17/h17/s02.wlcqjasf".

The way that these scripts based on static methods with magic names works is as follows: First, the GetThumbs method is called. The first parameter to that method is an object with a method on it called AddThumb (since renamed to just Add, but the old name still works). AddThumb takes several parameters, the last of which is an arbitrary object that can be set to anything you like.

When (and if) a full size image is required for a result, the GetResult method is called, whose single parameter will be whatever object was passed in as the last parameter for the AddThumb method of that result. Quite often, the GetResult method just returns the parameter directly, as no further processing on it is needed.

The return value from GetResult, like the value passed for the first parameter of AddThumb, can be any of:
In the iTunes case, the last parameter to the AddThumb method is a partial URL string that is extracted from the results XML returned from the initial query. When a full sized image is requested, the GetResult method first tries to complete that partial URL with ".jpg", then if that fails, tries it with ".tif" instead.

Although no scripts use it yet, because, lets face it, copying and pasting an existing one and modifying it is so much easier, I've added a more type-safe object-orientated way of implementing scripts, which does not rely on methods with magic names. If you add a reference to AlbumArtDownloader.Scripts.dll, then there is an interface: IScript. Implementing this makes your class a script. Also in that assembly there is an IScriptResults interface, which is what the object passed to GetThumbs (or IScript.Search) implements, so you can see what methods and properties are available on it.

If this is all too much information, I apologise, but it looked like you were interested in what was going on under the hood.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2007-09-23 10:12:48
Alex, but did you try his alternative method using Album URL?

Code: [Select]
http://phobos.apple.com/WebObjects/MZStore.woa/wa/viewAlbum?id=262406609&s=143460


That's great info, I'd luv to have a dev chat with you online if you don't mind.. 

Currently I am working on trying to get 50 Cent - Curtis searchable.

Passed the TIF challenge.

Code here is an example to search the artwork from all the iTunes Stores around the world.

Code: [Select]
    Public Function GetArtworkPath() As String

        ' Usage :
        'Dim itms As New cITMSArt("4 Strings", "Turn It Around")
        'Process.Start(itms.GetArtworkPath)

        Try
            Dim iTMSdir As String = My.Settings.ArtworkDir + Me.artist + Path.DirectorySeparatorChar + Me.album
            Dim iTMSpath As String = iTMSdir + Path.DirectorySeparatorChar + "iTMS.jpg"

            If Directory.Exists(iTMSdir) = False Then
                Directory.CreateDirectory(iTMSdir)
            End If

            If File.Exists(iTMSpath) Then
                sWriteDebugLog("Found saved iTMS Artwork: " & iTMSpath)
                Return iTMSpath
            Else
                Dim wc As New WebClient
                For Each storeID As String In My.Settings.ListStoresID
                    Dim url As String = GetArtworkURL(storeID.Trim)
                    If url <> String.Empty Then
                        ' now we konw the url is valid
                        Try
                            wc.DownloadFile(url, iTMSpath)
                        Catch ex As System.Net.WebException
                            ' see if tif is availble
                            url = Path.ChangeExtension(url, ".tif")
                            iTMSpath = Path.ChangeExtension(iTMSpath, ".tif")
                            wc.DownloadFile(url, iTMSpath)
                            Try
                                Dim img As Image = Image.FromFile(iTMSpath)
                                ' save the jpg convert
                                Dim iTMSpathJPG As String = Path.ChangeExtension(iTMSpath, ".jpg")
                                img.Save(iTMSpathJPG, System.Drawing.Imaging.ImageFormat.Jpeg)
                                sWriteDebugLog(String.Format("Successfully converted {0} to JPG", iTMSpath))
                                iTMSpath = iTMSpathJPG
                            Catch errSave As Exception
                                ' Error converting
                            End Try
                        End Try
                        sWriteDebugLog("Fetched " & url)
                        Return iTMSpath
                    End If
                Next
                sWriteDebugLog("Could not get iTMS Artwork Path")
                Return String.Empty

            End If
        Catch ex As Exception
            sWriteDebugLog("Error getting iTMS Artwork Path")
            Return String.Empty
        End Try

    End Function


Code: [Select]
   Public Function GetArtworkURL(ByVal id As String) As String

        Dim x As New XmlDocument

        Dim search As String = "http://ax.phobos.apple.com.edgesuite.net/WebObjects/MZSearch.woa/wa/coverArtMatch?an=" + artist + "&pn=" + album
        Console.WriteLine(search + " with " + id)
        Dim t As Stream = GetPageSecret(search, id)
        Try
            Dim gzi As New GZip.GZipInputStream(t)
            x.Load(gzi)
            sWriteDebugLog("Accessed iTMS ID: " & id)
        Catch ex As Exception
            sWriteDebugLog(String.Format("Error getting iTMS Artwork URL with Store ID: {0}. {1}", id, ex.Message))
            Return String.Empty
        End Try

        Dim tags As XmlNodeList = x.GetElementsByTagName("dict")
        If tags.Count = 0 Then
            Return Nothing
        Else
            Dim url As String = String.Empty
            Dim albumname As String = String.Empty
            Dim whichTag As Integer = 0

            For Each tag As Xml.XmlNode In tags(0).ChildNodes
                If tag.InnerText = "cover-art-url" Then
                    url = tag.NextSibling.InnerText
                ElseIf tag.InnerText = "playlistName" Then
                    albumname = tag.NextSibling.InnerText
                    Exit For
                End If
            Next

            If url.Length > 0 Then
                ' url is ' http://a1.phobos.apple.com/r10/Music/y2004/m08/d02/h11/s05.egorzxul.enc.jpg?downloadKey2=1190559591_ff0a61272432c71f489474b1a5712f97
                ' now just have to remove ".enc" and everything after the question make so you get
                ' http://a1.phobos.apple.com/r10/Music/y2004/m08/d02/h11/s05.egorzxul.jpg
                ' which is a valid artwork file!
                Return url.Substring(0, url.IndexOf("?")).Replace(".enc", "")
            Else
                sWriteDebugLog("iTMS artwork was not found")
            End If

        End If

        Return String.Empty

    End Function


Insight to how the scripts work was really great. Thank you for that!
Title: Album Art Downloader XUI
Post by: pirlouy on 2007-09-23 11:17:09
Just a little little bug: when you launch a new search (I use the same window), there is a thumbnail of the previous search !
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-23 13:45:37
Just a little little bug: when you launch a new search (I use the same window), there is a thumbnail of the previous search !

Could you be a little more specific about what you are doing here? If I do a search, I get some results in the window. If I change the artist or album and press the Search button again, then the previous results are removed, and new ones start coming in. What is it you are seeing, are the new results added to the existing results? Or are no new results coming in at all? What did you change between one search and the next?

Alex
Title: Album Art Downloader XUI
Post by: pirlouy on 2007-09-23 19:17:09
After some search, in fact, I think it's the local script which show the wrong thumbnail:
(http://img526.imageshack.us/img526/2490/aad070923sq0.th.png) (http://img526.imageshack.us/my.php?image=aad070923sq0.png)

Another thing: I have not searched for now, but is it possible to automatically add a'1' or '2' at file end, when we save and the file already exists ? (I hope I'm clear)
For example (based on my screenshot, file "Madonna - Die Another Day.jpg" already exists: is it possible to automatically change name by Madonna - Die Another Day2.jpg for next files ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-23 19:49:34
After some search, in fact, I think it's the local script which show the wrong thumbnail:
(http://img526.imageshack.us/img526/2490/aad070923sq0.th.png) (http://img526.imageshack.us/my.php?image=aad070923sq0.png)

Another thing: I have not searched for now, but is it possible to automatically add a'1' or '2' at file end, when we save and the file already exists ? (I hope I'm clear)
For example (based on my screenshot, file "Madonna - Die Another Day.jpg" already exists: is it possible to automatically change name by Madonna - Die Another Day2.jpg for next files ?
Ah, OK, the Local Files search is special. I can't see exactly what file save path you are using, so I can't give you a complete answer, but the Local Files search tries to find existing files on your hard disk based on the save path and album/artist you are searching for.

To change what pattern it is using to look for files, click the ... button to the bottom of the Local Files source, and it has an option to specify where to look. Or, you can just uncheck the local files source and not use it at all, if you prefer.

I don't think automatically renaming second copies of files fits in very well with Album Art Downloader functionality. The idea is that you are downloading the art for an album, so once chances are if it already exists, you either want to keep it, or replace it with a better version, not save another copy.

Alex
Title: Album Art Downloader XUI
Post by: pirlouy on 2007-09-23 20:12:45
Ah, OK, the Local Files search is special. I can't see exactly what file save path you are using, so I can't give you a complete answer, but the Local Files search tries to find existing files on your hard disk based on the save path and album/artist you are searching for.
Oops: D:\Mes documents\Ma musique\[07]pochettes\Madonna - Die Another Day.jpg (%artist% - %title%.jpg)

I have the jacket of Massive Attack and another called "Madonna - Die Another Day.jpg", so it should have shown me this file and not Massive Attack one.

Quote
I don't think automatically renaming second copies of files fits in very well with Album Art Downloader functionality. The idea is that you are downloading the art for an album, so once chances are if it already exists, you either want to keep it, or replace it with a better version, not save another copy.


That's what I thought until now, but since I've been using foo_uie_albumart, it could cycle between several images, so I can save several images if I want. Of course, I can change path manually, but it would have been easier if... But I can understand you don't want to add a lot of options...

Thanks for your answer.
Title: Album Art Downloader XUI
Post by: iElectric on 2007-09-24 12:08:08
AlexVallat, this has grown into a very nice app! Thanks.

I have only one "note".. Have you considered using tabs instead of new windows?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-25 12:47:16
AlexVallat, this has grown into a very nice app! Thanks.

I have only one "note".. Have you considered using tabs instead of new windows?

Thanks, I'm glad you like it! I'm not sure how well tabs would work for this application, really. The original decision at design-time was to make this an SDI rather than MDI app. This means that there is no overall application window to have child 'document' windows, which could be shown as tabs or any other UI to taste.

The design was chosen to mesh well with its intended usage of being called from a command from another application (like foobar), rather than typically being the starting-point application for a task. Running a command opens a window as a result of that command, it does not generally open another tab in the window of the previous command's results.

Thanks for the suggestion, though.

Alex
Title: Album Art Downloader XUI
Post by: 2Pacalypse on 2007-09-26 20:41:40
does version 0.10 contain everything needed for downloading from iTunes or do i need to get a seperate script?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-09-26 21:29:58
does version 0.10 contain everything needed for downloading from iTunes or do i need to get a seperate script?

It contains everything you need, but only searches iTunes storefront 143457. I put up an alternative script to search storefront 143441 instead, which some users have been reporting has having better results. If you want to use that instead, you need to download it: itunes.boo (http://www.byalexv.co.uk/foobar/itunes.boo), and replace the existing script with it.

If I have time, I hope to create a script that searches all storefronts until it finds a match, as suggested by McoreD.

Alex
Title: Album Art Downloader XUI
Post by: mwfuss on 2007-09-28 17:15:32
This seems to be an excellent program. There are several features mentioned in the opening post that I have been unable to figure out how to implement. The features in question are:

# Analyse files to find Artists and Albums from tags, and check if album art is already present.
# Read your foobar2000 media library to find Artists and Albums, and check for album art.

I have been able to search for album art one album at a time by imputing the necessary information in the search fields, but I have not been able to figure out how to do the above.

One other matter, when I go to File>New>File Browser or File>New>Foobar Browser the only thing that happens is that a blank window opens. Am I missing some necessary Foobar components. I have the foo_browser component installed.

Any help would be greatly appreciated.

Nevermind. I must have been using an older version of the program. After installing the latest, everything works just fine.
Title: Album Art Downloader XUI
Post by: Scidd0w on 2007-09-28 21:19:09
It contains everything you need, but only searches iTunes storefront 143457. I put up an alternative script to search storefront 143441 instead, which some users have been reporting has having better results.
...
With almost every search i do the itunes script gives me 1 result back. That is at first unknown by size and after clicking for a preview its 177x177. This is also happens with albums that i allready downloaded via the itunes script with  a very old version (coverart) a long time ago.
Is the above also related to my problem with the itunes script. Or is it normal for this script to output such small files?
The rest if the scripts worked way fine. Thank you for this tool!
Title: Album Art Downloader XUI
Post by: mobyduck on 2007-09-28 23:51:42
With almost every search i do the itunes script gives me 1 result back. That is at first unknown by size and after clicking for a preview its 177x177.
Yeah, same here since yesterday. I'm afraid it's related to this (http://www.hydrogenaudio.org/forums/index.php?act=findpost&pid=519391).

Alessandro
Title: Album Art Downloader XUI
Post by: xamphear on 2007-10-06 02:20:19
I reaaaaaaaaly like this program. It's just missing one feature that would save me so much time. Could you possibly include some built-in image resizing feature?

ie: I specify that my target size is 500x500, so when i save a 800x800 cover it resizes it down to 500x500, but leaves a 300x300 cover alone (because resizing up is ugly!)

I often times find covers in 200x200 and 1000x1000 size with nothing really good in-between.

At any rate, thanks for this great and useful application.
Title: Album Art Downloader XUI
Post by: TedFromAccounting on 2007-10-06 07:58:12
Has anyone written a script for buy.com?
Title: Album Art Downloader XUI
Post by: Hamilcar on 2007-10-07 14:54:57
Hey excellent app but I was scanning my foobar library when I got this message:

Error occured while reading media library: The specified path, file name, or both are too long...

anyway I can check a log to change the file or directory name?
or is that a bug that will be fixed ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-10-07 17:11:36
I reaaaaaaaaly like this program. It's just missing one feature that would save me so much time. Could you possibly include some built-in image resizing feature?
Thanks for the suggestion. I'm not sure whether I want to be doing post-processing on the images after downloading or not. If I do, then resizing will certainly be one of the options offered, as would conversion to .jpg, and possibly aspect ratio correcting.

Hey excellent app but I was scanning my foobar library when I got this message:

Error occured while reading media library: The specified path, file name, or both are too long...

anyway I can check a log to change the file or directory name?
or is that a bug that will be fixed ?
There is a way to get a log file - create a file called AlbumArt.exe.config in the program folder (or edit your user.config for Album Art Downloader, but that's trickier to find!), and put this in it:
Code: [Select]
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
  <system.diagnostics>
    <trace autoflush="true">
      <listeners>
        <add name="debugListener"
                type="System.Diagnostics.TextWriterTraceListener"
                initializeData="tracelog.txt" />
      </listeners>
    </trace>
  </system.diagnostics>
</configuration>
For any .net app, that causes the trace log output to be written to a file called tracelog.txt in the program folder.

Unfortunately, reviewing the source for 0.10, I don't think you will see anything useful enough to tell you which file it is that is too long. I've stuck up a version 0.10.1 (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.10.1.exe) which if you update to will provide more useful information, and also not abandon scanning the rest of the library just because one file failed. The only other change to 0.10.1 is to remove the iTunes script from the installer, since Apple have blocked access again.

Alex
Title: Album Art Downloader XUI
Post by: Hamilcar on 2007-10-07 17:48:10
thank you very much for your fast reply!
Title: Album Art Downloader XUI
Post by: francesco on 2007-10-16 14:18:53
AMAZING
this program is amzing
thanks really for your job!

but how can i save the thumbs in covers.jpg?
Title: Album Art Downloader XUI
Post by: pirlouy on 2007-10-16 16:42:40
If you click on 'options', you will see a field in which you can choose the name.
Else, if you want to save it automatically in a specific path, you have to use command line options:
http://album-art.sourceforge.net/index.php..._Line_Reference (http://album-art.sourceforge.net/index.php/Command_Line_Reference)
Title: Album Art Downloader XUI
Post by: hugo25 on 2007-10-16 16:54:57
I think it miss an option to show size in kb for each cover.

Thanks for this amazing software !
Title: Album Art Downloader XUI
Post by: francesco on 2007-10-18 09:27:45
i would love to download automatically  the best match
Title: Album Art Downloader XUI
Post by: francesco on 2007-10-28 16:18:54
 
do u plan to add a lyrics support ,to download lyrics ?
Title: Album Art Downloader XUI
Post by: Chaser on 2007-10-28 18:11:45
This component is not designed for downloading lyrics. franesco, you get quite some plugins for acquiring lyrics here in the forum - just do a search.
Title: Album Art Downloader XUI
Post by: francesco on 2007-10-30 14:38:48
This component is not designed for downloading lyrics. franesco, you get quite some plugins for acquiring lyrics here in the forum - just do a search.

yes i know
the lyrics downloader doesn't work

it's could be a great new feature for album art downloader
Title: Album Art Downloader XUI
Post by: FavioD on 2007-10-30 15:56:22

This component is not designed for downloading lyrics. franesco, you get quite some plugins for acquiring lyrics here in the forum - just do a search.

yes i know
the lyrics downloader doesn't work

it's could be a great new feature for album art downloader

but then it wouldn't be called album art downloader 
Title: Album Art Downloader XUI
Post by: Chaser on 2007-10-30 20:11:11
Though beeing off-topic, take a look at foo_uie_lyrics. It does it's job quite well!
Title: Album Art Downloader XUI
Post by: Tich on 2007-11-02 16:12:40
Is the Cover-Paradies script working for anybody?
Seems like I'm not getting any results from it anymore (been like this for weeks, if not more than a month) while I get nice results when using the web-search.

Example: Porcupine Tree - In Absentia
http://www.cover-paradies.to/?Module=ViewEntry&ID=282622 (http://www.cover-paradies.to/?Module=ViewEntry&ID=282622)

I would appreciate it if somebody could take a look at it and possibly provide an updated version of the script, since this is the best source for high-quality Albumart scans imo.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-11-02 17:22:58
Is the Cover-Paradies script working for anybody?
Seems like I'm not getting any results from it anymore (been like this for weeks, if not more than a month) while I get nice results when using the web-search.

Example: Porcupine Tree - In Absentia
http://www.cover-paradies.to/?Module=ViewEntry&ID=282622 (http://www.cover-paradies.to/?Module=ViewEntry&ID=282622)

I would appreciate it if somebody could take a look at it and possibly provide an updated version of the script, since this is the best source for high-quality Albumart scans imo.

Fixed: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)

While I'm here:
Alex
Title: Album Art Downloader XUI
Post by: Tich on 2007-11-02 18:45:09
Fixed: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)

You Sir, are a Legend!
Thank you very much Alex!
Title: Album Art Downloader XUI
Post by: joen on 2007-11-02 18:51:46
Fixed: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)


Excellent, I really missed using this script, it's by far the best. Thanks a lot, it's much appreciated
Title: Album Art Downloader XUI
Post by: Melomane on 2007-11-02 20:07:48
i have a bug with "local files" display.

image is sometimes wrong but path is correct.



i use this string with foo run and foobar 0.95 b2

C:\Program Files\AlbumArtDownloader\AlbumArt.exe "%artist%" "%album%" "$replace(%path%,%filename_ext%,folder.jpg)"
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-11-03 07:58:31
i have a bug with "local files" display.

image is sometimes wrong but path is correct.



i use this string with foo run and foobar 0.95 b2

C:\Program Files\AlbumArtDownloader\AlbumArt.exe "%artist%" "%album%" "$replace(%path%,%filename_ext%,folder.jpg)"

Could you check what path the Local Files source is searching? To do this, click the ... button on the bottom right of the Local Files source in the list, and see if the "Specify path to find images" checkbox is checked. If it is, then check what the path in the combo box underneath it says - that will be where it looks for images.

If it is not checked, then it will be looking for images in the default path to save to, but with the placeholders %name%, %extension%, %source% and %size% replaced by wildcards (*).

Alex
Title: Album Art Downloader XUI
Post by: Melomane on 2007-11-03 23:39:03
no, isn't checked

if i check it, folder displayed isn't the "path to save art "

i have add this in foo run :
/localImagesPath "$replace(%path%,%filename_ext%,folder.jpg)"

and now work alltimes

also i have problems with somes albums where artist and album are the same: edit box for album is empty.

no problems if i use this:
C:\Program Files\AlbumArtDownloader\AlbumArt.exe
/ar "%artist%"
/al "%album%" 
/p "$replace(%path%,%filename_ext%,folder.jpg)"
/localImagesPath "$replace(%path%,%filename_ext%,folder.jpg)"

thank you for your answer Alex
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 2007-11-05 23:11:38
Can somebody tell me if the Cover-Paradies script works correct?
If I just use it then I get no results although there are covers on cover-paradise.to.

If someone could make this script work again I would be grateful.

Okay I found the fixed version thanks.
I have had some crashes. But as far as I can tell I works like a charm.
Title: Album Art Downloader XUI
Post by: shlomomofo on 2007-11-09 19:14:34
this program looks pretty sweet, but i'm having trouble getting it work right.  if search for some artist, it looks like only three of the scripts are actually working (artists.trivialbeing, coverisland, yes24). these are the only ones where the progress bars show any action.  i get very few results, even for very popular releases.  also, it seems that yes24 is the only script that actually results at all.

any hints?  i'm using vista, and the newest albumartdownloader version....


edit:  oops, i'm an idiot.  all the scripts work, but only if i enter artist AND album.  sorry.

edit 2: after spending a bit of time with this software, i must say that it is incredible.  powerful and usable!  the the only thing i find myself wishing for is a quicker way to save separate front, back, and disc images.  my idea is to have maybe three text fields with radio button selectors.  you can put a different file name in each text box (e.g. "back.jpg").  select that radio button, and then hitting the little save icons saves the image as "back.jpg" in whatever folder is already selected.  then click the "folder.jpg" radio button... now hit save on a front cover to save a "folder.jpg" to the same folder.  if you were to put this in the "options..." section, i would leave options open by default... that way you don't have to open options every album if you are going through a long queue.  anyway, just an idea to make things easier when grapping multiple images for each album, especially if you are wading through a long queue.  thanks again!!!
Title: Album Art Downloader XUI
Post by: fuffi on 2007-11-10 11:34:09
hi,
i like the program very much. it does, what it should :-)
but in some cases, i'm not completly satisfied, i whish it could be a little improved.
so here's a wish, right bevore xmans *<:-)

the "save as" is a wonderful feature, but a lot of times, i'd like to save more than only one file from the list of found pictures, because there are "front" "back" "inlay" "artist picture" etc. available.
typing all the names for all the different files to be saved it is very unhandy. (and useles for me, because i really dont care about the filenames)

so i'd wished, i had a button "save with original filename" which opens the "save as"-dialogue and has the original filename from the origin website already shown, so that i only have to press enter (or change a little bit, instead of personally whiches oder duplicates)

is this possible?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-11-10 12:05:25
edit 2: after spending a bit of time with this software, i must say that it is incredible.  powerful and usable!  the the only thing i find myself wishing for is a quicker way to save separate front, back, and disc images.
Thanks, glad you liked it! For your suggestion, my idea for solving this problem would be a Preset system. I described it in the old thread, but here it is again:

Presets
1. Addition of a new placeholder for the Save Images path, available from the dropper menu: %preset%
2. Addition of a dropper arrows just to the right of the Save buttons, when clicked pops up a menu with: "Save As...", <list of presets>, "More...". List of presets is initially blank, but "More" pops up:
3. "Save with Preset" dialog. Dialog with two column list of Name and Value preset entries, with Add and Delete buttons, and Save and Close buttons. Adding a Name/Value preset entry shows it as it's name on the list of presets in the menu, to avoid having to go through this dialog again. When an entry is selected, the Save button is enabled. Clicking that has the same effect of choosing the entry from the menu, which is to save, but with:
4. %preset% replaced in the path by the value of the preset, with any placeholders in that entry value also processed.

I may even get round to actually writing it sometime, but it probably won't be any time soon, sorry.

so i'd wished, i had a button "save with original filename" which opens the "save as"-dialogue and has the original filename from the origin website already shown, so that i only have to press enter (or change a little bit, instead of personally whiches oder duplicates)
This would probably also be addressed by the presets idea presented above, but in fact what you are asking for, to use the name of the image in the filename to save as, is already possible.

Open the Options area, then in the Save Images To box, use the placeholder %name% somewhere in the path. For example, C:\AlbumArt\%artist%\%album%\%name%.%extension%. The placeholder will be replaced by the name as displayed in the results list.

Alex
Title: Album Art Downloader XUI
Post by: fuffi on 2007-11-10 13:34:08
alex, thanks for the fast reply.

i've read the "presets"-thing and it sounds quite cool.

i use your program from within foobar run_services (did not mentioned it above, sorry)
with
"x:\foobar2000\components\AlbumArtDownloaderXUI\AlbumArt.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%name%.%extension%"

then, the filemname is "?.?" which is understandable for me, but not solving my problem :-)

i fooled around with single and double quotes ' "
but did not succeed.

i'm not writing all the images into a single directory, but in the directory the music is in. so the directory changes with every album or title.
Title: Album Art Downloader XUI
Post by: Purple Monkey on 2007-11-10 14:08:00
You need to escape the %s otherwise foobar will try to parse them, use %%name%% and %%extension%%.
Title: Album Art Downloader XUI
Post by: fuffi on 2007-11-10 15:57:33
You need to escape the %s otherwise foobar will try to parse them, use %%name%% and %%extension%%.
thank you very much!
now i only have to change the filenames if they have special characters like in this filename

X:\foo\bar\CAMP, Bob \x26amp; Bob GIBSON --\x26gt; V.A.: ....jpg

anyway,
i was not sure, if for this case there is a help, so i clicked the help-menu in album-art-downloader XUI and was redirected to the souceforge website.
after that (i had to say YES to zonealarm for letting it open my firefox browser)
album-art-downloader XUI crashed.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: E:\Programme\foobar2000\components\AlbumArtDownloaderXUI\errorlog.txt

App version: 0.10.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ComponentModel.Win32Exception: Das System kann die angegebene Datei nicht finden
  bei System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)
  bei System.Diagnostics.Process.Start()
  bei System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
  bei System.Diagnostics.Process.Start(String fileName)
  bei AlbumArtDownloader.Menu.GoToPageExec(Object sender, ExecutedRoutedEventArgs e)
  bei System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  bei System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  bei System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  bei System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  bei System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  bei System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  bei System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  bei System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  bei System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
  bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  bei System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  bei System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  bei System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
  bei System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  bei System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  bei System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  bei System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  bei System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
  bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  bei System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  bei System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  bei MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  bei System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-11-10 19:56:11
i was not sure, if for this case there is a help, so i clicked the help-menu in album-art-downloader XUI and was redirected to the souceforge website.
after that (i had to say YES to zonealarm for letting it open my firefox browser)
album-art-downloader XUI crashed.
Yeah, looks like it wasn't happy about being intercepted by ZoneAlarm there. Thanks for reporting it, it will be fixed in the next version.

As I'm sure you've probably realised by now, there isn't really a help either, sorry! There's a Command Line Reference (http://album-art.sourceforge.net/index.php/Command_Line_Reference), and a Wiki page (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Components_0.9/AlbumArtDownloader_XUI), but not much else.

Alex
Title: Album Art Downloader XUI
Post by: shlomomofo on 2007-11-10 22:49:10
I may even get round to actually writing it sometime, but it probably won't be any time soon, sorry.

word.  i like your idea better than mine. hopefully it makes it into the next version, whenever that may be.
Title: Album Art Downloader XUI
Post by: Killmaster on 2007-11-24 20:56:36
Could someone step me through on how to use this program?

I open it up, and none of the sources show. I finally figure out that I need to run it under administrator (I'm using Vista), so now it works. But how do I get it to scan my files? It looks like you can save it to folders according to artist/album; is there a way to add date to the mix? My entire collection is sorted %album artist%/['('%date%')' ]%album%/

The File browser gives me a blank window with "file browser goes here..." and the foobar browser gives me the same. I installed the COM automation plugin for foobar like the OP said. I can't find any documentation and I'm confused

edit: I just realized that I didn't have the latest version. It still doesn't work with Foobar though, even though the COM server is installed. Is there anything I have to do to get it working? Oh and the file browser crashes the program..
Title: Album Art Downloader XUI
Post by: daniel/L on 2007-11-26 14:35:43
After clicking the "Get Artwork" button AlbumArt (started using a "AlbumArt.exe /foobarBrowser" shortcut) immediately crashes, no matter how much songs have been selected.

This is the resulting error log:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\Foobar2000AlbumArtDownloader\errorlog.txt

App version: 0.10.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Windows.Markup.XamlParseException:  Stack empty.  Error at object 'System.Windows.Controls.ControlTemplate', Line 40 Position 9. ---> System.InvalidOperationException: Stack empty.
  at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
  at System.Collections.Generic.Stack`1.Pop()
  at System.Windows.Markup.OptimizedTemplateContent.CheckElementStartForOptimization(BamlRecord bamlRecord)
  at System.Windows.Markup.OptimizedTemplateContent.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.OptimizedTemplateContent.AddContentRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.TemplateBamlRecordReader.AddContentRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.TemplateBamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
  at System.Windows.Markup.TemplateBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TemplateTreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlTemplateSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.StyleBamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.StyleBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.StyleTreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlStyleSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.ReadElement(Int64 startPosition, XamlObjectIds contextXamlObjectIds, Object dictionaryKey)
  at System.Windows.ResourceDictionary.CreateObject(Int32 valuePosition, Object key)
  at System.Windows.ResourceDictionary.RealizeDeferContent(Object key, Object& value, Boolean& canCache)
  at System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
  at System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
  at System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
  at System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
  at System.Windows.ResourceDictionary.FetchResource(Object resourceKey, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
  at System.Windows.SystemResources.LookupResourceInDictionary(ResourceDictionary dictionary, Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
  at System.Windows.SystemResources.FindDictionaryResource(Object key, Type typeKey, ResourceKey resourceKey, Boolean isTraceEnabled, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
  at System.Windows.SystemResources.FindResourceInternal(Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference)
  at System.Windows.StyleHelper.GetThemeStyle(FrameworkElement fe, FrameworkContentElement fce)
  at System.Windows.FrameworkElement.UpdateThemeStyleProperty()
  at System.Windows.FrameworkElement.OnInitialized(EventArgs e)
  at System.Windows.FrameworkElement.TryFireInitialized()
  at System.Windows.FrameworkElement.EndInit()
  at System.Windows.Markup.BamlRecordReader.ElementEndInit(Object& element)
  at System.Windows.Markup.BamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.ArtSearchWindow.InitializeComponent()
  at AlbumArtDownloader.ArtSearchWindow..ctor()
  at AlbumArtDownloader.Common.NewSearchWindow(IAppWindow existingWindow, Boolean forceShown)
  at AlbumArtDownloader.BrowserResults.GetArtworkExec(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  at System.Windows.Controls.Button.OnClick()
  at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
  at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
  at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.ReRaiseEventAs(RoutedEventArgs args, RoutedEvent newEvent)
  at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
  at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.InputManager.ProcessStagingArea()
  at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
  at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
  at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
  at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)


And here's the tracelog:
Code: [Select]
AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.10.1.0
Path not found for file search: X:\Musik\!neues\20070415\Evocation--Tales_from_the_Tomb-Promo-2007-UBE\Folder.jpg
Path not found for file search: X:\Musik\Excrementory Grindfuckers\Bitte nicht vor den Gästen\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070305\Emil_Bulls-The_Life_Acoustic-2007-SnS\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Disbelief - 2004 - Spreading The Rage\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Excrementory Grindfuckers - [2002] - Gesammelte Werke\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\My_Dying_Bride_-_A_Line_Of_Deathless_Kings-Promo-2006-CMG\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\The Accidents\Poison Chalice\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Raised Fist\Sound Of The Republic\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061008\The Turbo A.C.'s - Fuel for Life\Fuel for life\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Logistics-Now_More_than_Ever-NHS112LP-Vinyl-2006-uC\Logistics-Now_More_than_Ever-NHS112LP-Vinyl-2006-uC\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Ltj.Bukem.Presents.Some.Blue.Notes.Of.Drum.N.Bass-2004-0mni\LTJ Bukem Presents Some Blue Notes of Drum N Bass-2004-0MNi\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS.www!OSIOLEK!com\VA_-_Fabio_Presents_Liquid_Funk_Volume_Two-Retail_CD-2005-BOSS\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\_einzelne\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061019\Nekromantix\Curse Of The Coffin\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061129\Jazzkantine\Heiss & Fettig\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\!Drum & Bass\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Jamie.Cullum.-.Catching.Tales.192kbs\Jamie Cullum\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Kataklysm--In_the_Arms_of_Devastation-Promo-2006-UBE\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Miles Davis - Cookin With The Miles Davis Quintet\(JAZZ)Miles Davis - Cookin' With The Miles Davis Quintet - 320kbps - Lame-3.93.1\Folder.jpg
Path not found for file search: X:\Musik\!neues\20060911\Terrorizer-Darker_Days_Ahead-(Advance)-2006-RNS\Folder.jpg
Path not found for file search: X:\Incoming\Das Silmarillion\Folder.jpg
Path not found for file search: X:\Musik\!neues\20061001\Billy_Talent-Billy_Talent_II-2006-RST\Billy_Talent-Billy_Talent_II-2006-RST\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070218\Keen Of The Crow\Hyborea\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070509\LAK_-_Verdammtes_Leben-DE-2007-YSP\LAK_-_Verdammtes_Leben-DE-2007-YSP\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070214\Leng Tch'e\Marasmus\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\Neaera-Armamentarium-2007\Neaera-Armamentarium-2007\armium07\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\Age__2007_\pro-pain_-_age_of_tyranny_the_tenth_crusade_2007\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\The Pyske Project - Apnea\Folder.jpg
Path not found for file search: X:\Musik\!neues\20070921\Witchcraft.-.The.Alchemist-2007-Cmg\Witchcraft_-_The_Alchemist-Promo-2007-CMG\Folder.jpg
AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.10.1.0
How can I solve this problem?

Thanks in advance!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-11-26 17:45:52
After clicking the "Get Artwork" button AlbumArt (started using a "AlbumArt.exe /foobarBrowser" shortcut) immediately crashes, no matter how much songs have been selected.

Thanks for reporting this error. Could you tell me, does it work if you don't start from the foobar browser, or does it crash anyway? Does it crash if, instead of clicking the Get Artwork button, you click the File menu and click New, Search Window? Reading the stack trace, another interesting thing to know would be what theme you are using.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2007-11-26 18:02:42
First, awesome program!

Second, could you please highlight the Album name when tabbing from Artist?  That way you can just start typing in the album name without erasing the previous one first.  I'm pretty sure it used to work like that (back when it was much less developed overall).

Thanks! 
Title: Album Art Downloader XUI
Post by: daniel/L on 2007-11-27 12:02:10
Thanks for reporting this error. Could you tell me, does it work if you don't start from the foobar browser, or does it crash anyway? Does it crash if, instead of clicking the Get Artwork button, you click the File menu and click New, Search Window? Reading the stack trace, another interesting thing to know would be what theme you are using.



Thanks for your reply!

When starting in /FileBrowser mode I'm getting the same result. Opening a new search windows also crashes AlbumArt immediately.
I'm using a completely "naked" Foobar 0.9.5 beta 5 (forgot to mention that) with no themes or stuff.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-11-27 12:10:28
When starting in /FileBrowser mode I'm getting the same result. Opening a new search windows also crashes AlbumArt immediately.
I'm using a completely "naked" Foobar 0.9.5 beta 5 (forgot to mention that) with no themes or stuff.

Sorry, I should have been more specific - I meant Windows theme, not any sort of Foobar customisation (which should not affect it at all). For example, Vista Aero, Vista Windows Classic, XP Luna, XP Royale, etc...
Title: Album Art Downloader XUI
Post by: daniel/L on 2007-11-28 11:22:52
Sorry, I should have been more specific - I meant Windows theme, not any sort of Foobar customisation (which should not affect it at all). For example, Vista Aero, Vista Windows Classic, XP Luna, XP Royale, etc...

Opps. I'm running WinXP SP2 with the default XP theme in silver. Nothing special.
Title: Album Art Downloader XUI
Post by: Snowsfall on 2007-12-02 00:52:58
two quick requests, a last.fm artist photo .boo to replace the broken trivialbeing one and maybe one that searches flickr for artist photos. Not to sure how doable the flickr one would be but i might as well throw it out there.
thanks for the great program
Title: Album Art Downloader XUI
Post by: Ross1 on 2007-12-09 19:02:32
Sadly, this program seems to crash all the time for me.

When I was writing the default directory to save to while it was searching (twice)
When I clicked 'stop all'
When I clicked 'search'
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-12-09 19:17:45
Opps. I'm running WinXP SP2 with the default XP theme in silver. Nothing special.

I'm out of ideas then, sorry. I don't know why this is happening, and therefore can't fix it.

Sadly, this program seems to crash all the time for me.

When I was writing the default directory to save to while it was searching (twice)
When I clicked 'stop all'
When I clicked 'search'

Can you send me the errorlog.txt file created when it crashes? It might let me know what the problem is, usually worth a try anyway.

Oh, and Snowsfall, thanks for the suggestions about the artist searching scripts. I don't think I'll have a chance to try writing one any time soon, and artist image searching isn't really the focus of this app anyway! Perhaps someone else might want to have a go at scripts for these?

Alex
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2007-12-10 17:55:47
artist image searching isn't really the focus of this app anyway



well well its not but AADXUI is marvelously successfull in it with correct script  even google script can return some artist pictures but specialized sites are always better. just face the truth that this pgm doesnt have one purpose and that its idea is just usefull for many others
Title: Album Art Downloader XUI
Post by: Dave_K on 2007-12-10 23:29:59
Is there any way to get this to search a local directory?

I use REACT with EAC and its ability to embed album art when creating a FLAC image is very useful. Unfortunately there are a fair few album covers that can't be found online by the included search scripts. For those I'd like to be able to download the images manually, yet still be able to select them in the Art Downloader during the REACT ripping process.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2007-12-11 08:25:45
Is there any way to get this to search a local directory?

Yes. The "Local Files" source does this. By default it will search in the "save to" folder, but you can change this using the /localImagesPath command line parameter, or by expanding the Local Files source in the UI (click ... in the bottom right of it) and entering the path to search there.

The following variables can be used in paths:
Code: [Select]
%artist%     Artist searched for
%album%      Album searched for
*            Wildcard, matches any characters
\**\         Subfolder search. Any folders will match at this point in the path. For example
             "\Art\Unsorted\**\*.jpg" will match:
              \Art\Unsorted\image.jpg
              \Art\Unsorted\misc\image.jpg
              \Art\Unsorted\misc\old\image.jpg
            
             "\Art\Unsorted\*\*.jpg" will match only:
              \Art\Unsorted\misc\image.jpg
Title: Album Art Downloader XUI
Post by: dd_wizard on 2008-01-04 10:09:26
1. I'm using AAD in an AutoIt script on a Windows Vista system, and I've found an annoying bug.  It is easily replicated from the command line.  I am using the default of three searches active at a time.  Do the following from a command window:

cd "c:\program files\albumartdownloader"
albumart "eric clapton" blues
albumart "Joe Satriani" "Live In San Francisco"
albumart "eric clapton" blues
albumart "Joe Satriani" "Live In San Francisco"

The fourth invocation of AAD causes the Queue Manager window to open. If I double click the search, everything is fine.  ( Artist and album can be anything, I just happen to like those two CDs.  )

However, if I close the Queue Manager with the search pending, I can't start a new AAD search from the command line or from my script.  When I close one of the active AAD search windows, a new one pops up!  In fact, the number of windows that pop up equals the number of searches I tried to start after I closed the Queue Manager with the pending search. Plus the one that was pending.

It looks like the Queue Manager isn't closing properly if a search is queued when the window is closed.  It's still queueing searches, but it doesn't show up on the task bar and it doesn't open a Queue Manager window. Is this an easy fix?

2. I like how you run all the windows from one process, but it's a trick to find the window handle if AAD is running before my script starts.  It appears that the PID for the AAD window I start in my script, AND the PID for the original AAD process both change when the original AAD process inherits the window my script started.  This breaks AutoIt's RunWait() function, but it was fun finding a way to know which window handle belongs to my script.  Oh, and don't expect the command interpreter to hang around after the PID changes, either.  LOL  Have I analyzed the PID behavior correctly?

P.S.  Queueing is the unique word in the English language with 5 or more consecutive vowels. I got that from one of my CS professors.   

Thanks,
dd_wizard
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-04 10:34:27
1. OK, odd as it may be in the circumstances you are describing, this is in fact the correct behaviour of the Queue system. It is there to prevent more than a specified number of simultaneous searches, so after that limit is reached, further searches are held in the queue. They can either be manually triggered by double clicking on them (as you have found), or will automatically run once an existing search is closed.

So, what's happening here is that your fourth search goes on the queue. If you close the Queue Manager window, that doesn't affect the queue at all, just stops showing it to you. (You can see it again by selecting "Queue Manager" from the "Window" menu.) Subsequent searches are also queued up, even though you can't see them if the manager window is closed. As you close existing windows, searches from the queue are popped off the queue and executed.

The important thing is that the Queue Manager window is just the thing that lets see and manipulate the queue, it is not the queue itself.

To avoid queueing behaviour altogether, just set the Simultaneous Windows number in the Queue Manager to a high number (10000 or something).

2. There is no specific PID changing behaviour or anything (I'm not even sure such a thing is possible!). The single-instance behaviour is that if AAD is already running, then any new instance of it started will send its command line parameters to the existing instance (through the named pipe net.pipe://localhost/AlbumArtDownloader/SingleInstance, if that's of any interest), then immediately exit. I can't see any way the PID of the original process would change as a result of this.

There is currently no option to avoid the single instance behaviour and run multiple instances of AAD, sorry. Without this, I can't think of any good way to wait for a specific search to be complete either, as no process will end, only a window will probably close (unless re-used for another search), and it is not programatically obvious which window, either.

Alex
Title: Album Art Downloader XUI
Post by: Zoominee on 2008-01-04 14:27:45
Hi! I just discovered this program, I have installed it (and NET 3.0) because it looks very promising! But on my computer (Windows XP) it does not start. The error message is "This program must be closed, do you want to send the error report to Microsoft?"

According to that window, the error report contains the following information - maybe this is useful to the program developers:

Quote
EventType : clr20r3    P1 : albumart.exe    P2 : 0.10.1.0    P3 : 47090190
P4 : mscorlib    P5 : 2.0.0.0    P6 : 471ebc5b    P7 : 1c4c    P8 : 0   
P9 : system.typeloadexception


The error occurs when I start the program, before anything else happens. I cannot see any program windows. I have tried both installing the program as an administrator and installing it as a normal user, the error message is the same both times.

If there is something else I can do to help identify this error, let me know. With best wishes for 2008!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-04 16:06:59
Hi! I just discovered this program, I have installed it (and NET 3.0) because it looks very promising! But on my computer (Windows XP) it does not start...

Hi, thanks for reporting the error. Unfortunately the information that the error report window contained doesn't say much to me. There is a custom error reporting feature in AAD that should write out any errors to errorlog.txt (in the AAD program folder) then display that file in notepad, should a crash occur, but it looks like the program is failing to even load at all, so this isn't happening.

The only thing I can suggest is installing the latest version of the .net framework (3.5) (http://www.microsoft.com/downloads/details.aspx?FamilyID=333325fd-ae52-4e35-b531-508d977d32a6&displaylang=en) and hoping for the best.

Alex
Title: Album Art Downloader XUI
Post by: Zoominee on 2008-01-04 16:41:47
Hi AlexVallat, ok, I'll try this! For now I'm using the small tool from this thread to retrieve some album art. http://www.hydrogenaudio.org/forums/index....st&p=529261 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=58952&view=findpost&p=529261)
Title: Album Art Downloader XUI
Post by: dd_wizard on 2008-01-04 21:05:01
1. OK, odd as it may be in the circumstances you are describing, this is in fact the correct behaviour of the Queue system....

That makes perfect sense now that I know I can reopen the queue manager window.
2. There is no specific PID changing behaviour or anything (I'm not even sure such a thing is possible!)...

There is currently no option to avoid the single instance behaviour and run multiple instances of AAD, sorry. Without this, I can't think of any good way to wait for a specific search to be complete either, as no process will end, only a window will probably close (unless re-used for another search), and it is not programatically obvious which window, either.

I like the single instance a lot!  It minimizes AAD's system resource usage. I did a lot of testing, and at least on Vista, the PID for the AAD process started by my script changes when the original process takes it over. The change for the script spawned process makes sense, because that process dies once the single instance takes over.  I am about 50% confident the PID for the original process changed, too. This change seems odd, so I may have been sleepy while I was testing.

The easiest way I can think of to identify a script invoked window would be to add a command line argument to AAD along the lines of:

/WinTitle "Whatever you like here"

The script is a back end for EAC, so I'd probably use "Album Art Downloader - EACcompressor - %artist% - %album%" for the window title.  Then my script could find the correct window easily.

EDIT: For now, I'm using a temporary file in the destination directory to control AAD's behavior in my script. So the /WinTitle option would be nice, but not urgent.

Thanks,
dd_wizard
Title: Album Art Downloader XUI
Post by: Zoominee on 2008-01-08 17:06:49
Hi! I just discovered this program, I have installed it (and NET 3.0) because it looks very promising! But on my computer (Windows XP) it does not start...

Hi, thanks for reporting the error. Unfortunately the information that the error report window contained doesn't say much to me.The only thing I can suggest is installing the latest version of the .net framework (3.5) (http://www.microsoft.com/downloads/details.aspx?FamilyID=333325fd-ae52-4e35-b531-508d977d32a6&displaylang=en) and hoping for the best.

Follow-up: The Microsoft installer for 3.5 failed with an unspecified error message, so the blame must have been with the .NET setup in my computer. I tried to "repair" it with the .NET 3.0 installer, which failed also. The only option I had was to erase the whole .NET stuff with this tool: http://blogs.msdn.com/astebner/archive/200...04/6659905.aspx (http://blogs.msdn.com/astebner/archive/2007/12/04/6659905.aspx) . Then I reinstalled .NET version 3.5.
Now the Album Art Downloader works! Looking forward to trying it out.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-08 18:59:18
... I reinstalled .NET version 3.5.
Now the Album Art Downloader works! Looking forward to trying it out.
Great! Thanks for letting me know.

dd_wizard: I'll consider a /WinTitle parameter but it feels a bit ugly. I might try thinking up something more elegant, perhaps a /wait parameter instead...

Alex
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-01-13 18:13:57
Hola,

I've been using the new album art downloader for a few weeks now (another reason to love foobar: great tools on its forum! ) . Let me say that this is the first such program I've been settled, and which worked as it promised... also, you're a quite responsive developer, which is sadly rare, especially in foobar territory... I've encountered several problems along the way, so here's the blacklist (using version 0.10.1.0):


- There's a huge memory leak bug - sometimes (quite randomly, in fact) after dropping files in the File browser, AlbumArt instantly starts to consume several hundred megs of ram (eventually, all) *instantly*. I wish I could give a log file, but when I include the config file to create that, the program doesn't start. log for that attached.
- File browser sometimes doesn't recognize dropped folders/files, even if it has tags.
- Tag guessing could be better, and should be mixed with tag info. An album, which has several artist included (eg. mix cd, features etc) shouldn't show up as a different album when searching for art. A simple check whether the files originate from the same folder should help.
- I think the GUI is a bit confusing at first...couldn't you somehow integrate it more into one window? It's a bit awkward to have at least 3-4 windows open while searching for an art... especially since the default open search window count is set to 3... At least file browser/album search should be integrated into one (along with a file browser, perhaps), so user could make a quick browsing/downloading session without the need to drag&drop, which slows down this process considerably.
- In search window, user should be able to turn the sorting off (or include an option to show new results on the bottom). It happened to me several times that the first few matches were allright, wanted to click on the save button, but in that milisecond a new result appeared, and so I've clicked on the wrong pic...
- On the File Browser, there should be a button to clear the contents of the window. It's a bit of a pain to always open new window/close the previous each time the previous one gets too crowded.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-13 19:26:31

Hello, thank you for your kind comments. Let me reply to your points in order:

Memory Leak Oh dear, that's bad news. I've spent a lot of time trying to track down leaks, and thought I'd got all of them. Unfortunately, to track a leak, I need a loop that returns to the same point, but with less memory. Consuming lots of memory after lots of files have been added to the file browser, while undesirable, doesn't necessarily mean it is leaked, it might just be being used to process those files. It would only be leaked if the memory was not recovered once the files were removed from the list, or the file browser closed. I'll have a look around to see if there is any glaring memory inefficiency in the way that files are added to the browser, though.

If it only happens for certain files, or files added in a certain way, then that would indicate a bug and be a starting point to investigate.

Log file The error log you sent me indicates that the config file was not well formed XML. If you send me the AlbumArt.exe.Config file I can let you know why.

Unrecognized tags Is there a specific file you have that has tags which aren't recognized? If so, please try looking at it with MediaInfo (http://mediainfo.sourceforge.net/), which is what AAD uses internally to read the tags. If that can read Artist and Album tags, but AAD can't, then I will investigate further. In that case it might be helpful if you could send me the file in question.

"Tag guessing could be better, and should be mixed with tag info Sorry, I'm not sure I really understand what you are getting at here. The tags that are read are Artist and Album (as reported by MediaInfo), there is no guessing or other info used.

"A simple check whether the files originate from the same folder should help" That's assuming that each folder contains one album, and there should be only one album image per folder. This is not an assumption I want to limit AAD to making. Various Artists albums are always going to be a bit tricky, as there isn't an easy way to distinguish between that, and a folder full of random singles.

There might be something to be done in this area with Album Artist and Track Artist, but I'm not sure how often a distinction between those fields is actually made.

Multi-window GUI The design to have one window per search is pretty much set in stone now. It would need a pretty fundamental change in architecture to change that, and I don't intend to. Given that constraint, having a separate window for file browser seems the only natural place to put one, given that it could result in several searches.

I'm not sure what you mean about the need to drag and drop - the only time you might use drag and drop would be to drop files on to the browser, and surely that would be the same regardless of whether it was in the same window as the search results or not? Perhaps I'm missing something.

Turning off sorting That makes sense, yes. There would be a performance improvement for not having to sort, too. I'll put it in the next version.

Clearing I'll hook up the Del key to remove selected albums from the list for the next version. Alternatively, if you use the Search button, it will clear the current contents and replace them with what it finds searching the path specified. A quick Search, Esc combination would therefore result in a cleared list :-)

Thanks again for your comments and suggestions,

Alex
Title: Album Art Downloader XUI
Post by: emfletcher on 2008-01-13 20:35:30
Hey, thanks for this program.  It works great.  I have a couple suggestions for the next relase.

1.  In the file browser I would love to have the dimensions of the album art.  This way I can sort by dimensions and be able to replace small album art.  If that isn't possible file size might do.
2.When searching an album that already has album art it would be nice to have a picture of the album art you already have with the size underneath it.  Maybe in the source column, above or below the sources.
3.As previously suggested, it would be great to be in one window with tabs.
4.As previously suggested, various artist albums are a pain.  Maybe there could be an option to select 'one album per folder' so it won't search for art for every song of the various artist album.
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-01-13 21:39:25


Memory leak For the config file, I've suspected that there's an xml error, but I couldn't do much, since, I've copied the exact code from your post: http://www.hydrogenaudio.org/forums/index....st&p=521325 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=521325)
(For future releases, couldn't you just implement a simple config switch in the file application data/albumart/config?) Anyway, here's the file: http://poisonborz.extra.hu/aaconfig (http://poisonborz.extra.hu/aaconfig)

Unrecognized tags I've been experimenting with tags, here's all I can suspect: since mediainfo reads the tags properly, at first I've suspected that AAD encountered unexpected values. But as it turned out, a simple overwriting/re-saving of (these kind of) tags is enough. Don't know if it's a good idea, but here's a link of an unedited file that did not get recognized (It's a Taj Mahal track):
http://poisonborz.extra.hu/temp.mp3 (http://poisonborz.extra.hu/temp.mp3)
If I download, open it in a tag editor, and save it again, it gets recognized. I hope this helps somehow.

Multi-window GUI  emfletcher's idea about tabs is also great - if multiple windows are necessary, at least they could be enclosed in a multiple tabbed window...

Various Artist albums Maybe the user could set the pattern of the folder structure of his collection... Don't know if I'm right, but there's already something like this in the [albumart_recognizer_path] section of the config file. Maybe a text field in the options of the File Browser, with a simple "scripting language" assisted with buttons.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-14 08:29:39

1: That would slow things down considerably, as it would have to open and read each art file. File size could work, though, it should be fast enough to query the filesystem for that.

2: Existing album art is returned by the Local Files source (as long as you have it checked), and appears in the main search area. There seems to be a bug with the path it searches under when launched from the file browser, though, so I'll try to fix that for the next version.

3: Not going to happen. Writing a container window to hold all the other windows inside it would be a pain to do, and would mean that you couldn't see them side by side, and they'd all have to be the same size. I just don't see the advantage of it.

4: The File Browser is exclusively tag based, not file system based. It would be possible to write another browser which got artist and album information from a path pattern that you could specify, and that's a useful idea for the future. There's no reason that you should be forced to use tags when filenames can contain the same info, so long as a pattern for it can be specified. I'll keep it as a nice-to-have idea, but it won't be coming any time soon.


Config File There was a blank line at the start of that config file, where there shouldn't have been. I've fixed the post you linked so that it doesn't start with a blank line, sorry about that. The very first character in the file should be a <. The reason it is a config file rather than a switch, is that this is functionality built in to the .net CLR, not something specific to AAD. A config file like that works for any .net app.

Unrecognized tags Updating to the latest version of MediaInfo allows me to read that test file, so the next version of AAD (which will use the latest available MediaInfo) should read it too. If you don't want to wait, grab the latest MediaInfo DLL (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.5.7_DLL_Win32.7z), and extract MediaInfo.dll into the AAD program folder, overwriting the existing one.

Alex
Title: Album Art Downloader XUI
Post by: plinni on 2008-01-15 11:03:27
This little tool is simply amazing! Thanks for this! But I got one question anyhow. When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-01-16 00:25:38
This little tool is simply amazing! Thanks for this! But I got one question anyhow. When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?

Put the band name in both fields.  You'll get a lot of false positives, probably, but you should find your album cover.  Leaving the album name blank is not the way to go.
Title: Album Art Downloader XUI
Post by: plinni on 2008-01-16 00:49:25
Yeah I know but what I don't understand is why it's not filled in automatically. It's workin when the album title is different from the band name but otherwise it's not workin when both names are equal.
Title: Album Art Downloader XUI
Post by: TedFromAccounting on 2008-01-16 01:24:56
Can anyone write a script for buy.com?  They have a lot of 500x500 images that are often better quality than amazon's.  If i knew anything about scripting i would try myself.
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-01-19 20:32:43
Just some additional ideas:

the file browser not refreshing itself (artwork status field) if the Search window option 'close after
saving' is turned on (if that was not working like that before, it should  - in every file browser
window instance, if that is possible)

please re-do somehow the row selection mechanism in the file browser. It's very annoying that eg.
you select 6 row, and a sloppy click somewhere besides the checkbox clears all those selections.
User should be able to click anywhere in a row to check/uncheck that row. There's many occassions when I don't use 'select all albums with missing artwork', and individually selecting multiple rows with only a tiny checkbox is stressful.

Also, rows where album art is found should be highlighted somehow (a slightly different background color perhaps), since in a crowded file browser window it's a bit harder to pay attention to a simple icon/field value.

In the 'specify path to find images' field in file browser, are multiple expressions allowed? I don't quite get the mechanism: does AAD uses the same value to look for an album art, and to name a file on save? (the label on the field is confusing) Since filling in 'Folder.jpg' won't detect 'folder.jpg', nor any other file types...

Also, when can we expect the next version?
Title: Album Art Downloader XUI
Post by: hendo on 2008-01-20 07:30:42
FIRST UP GREAT PROGRAM !!! 

Now for my question.... the layout is really intuitive to use.... but

I have no idea HOW i can make it just search ONCE for each album which has no album art, not for each song of the album... ???

I know i can go through and a individually select one song from each album... BUT is there a EASIER way?




I have a little free time now and would love to smash through the art in the next couple of hours.


Cheers for your help guys. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-20 08:38:11
When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?

I haven't been able to reproduce this. Could you be more specific about what you are doing? Are you starting from the file browser, or the foobar browser, or the command line?


I'll look into the file browser refreshing issue, that sounds like a bug.

If you want to click anywhere in a row to select, hold down Ctrl to select individual rows, or Shift to select all rows in a range. This is standard selection behaviour. The problem with making click automatically extend the selection is that there is no obvious way of getting the alternative behaviour of clicking to select just what is clicked on. Keeping the normal click to select behaviour means that the alternative click to extend behaviour can still be accessed either through standard keyboard modifiers, or through the checkboxes.

I like the row colour idea, and will see if some subtle shading would look good. Alternatively, you could always sort by the art status.

For the 'specify path to find images' field in file browser, what do you mean by multiple expressions?
Filling in "Folder.jpg" should certainly detect "folder.jpg" as the search is case-insensitive. For other filetypes, try "folder.*" instead. The path (if not absolute) is relative to the audio file the tags were read from, so "folder.jpg" means "folder.jpg in the same folder as the audio file". The placeholder "/**/" can be used to search arbitrary sub-folders, so "./**/folder.jpg" means "folder.jpg in the same folder as the audio file, or any sub-folder of that folder".

When launching a search for an album from the file browser, the default path to save to is automatically filled in as the path to find images for that file browser, on the grounds that if that's where you were expecting to find images, that's where you would like them to go. There's currently a bug that this will include wildcards, but I'll have that fixed for the next version.

You can expect the next version soon. It was going to be today, as I've finished everything that I had planned, but given the above additional changes to make too, it might not be.


Thanks, I'm glad you like it! I'm afraid if each song on your album has a different artist or album title tag, then there is no way to get it to just choose one of those to display in the file browser and ignore the others. If they all have the same artist and album, then only one entry should appear.

There has been a proposal for a filename based browser rather than tag based, which would mean you could define your album and artist by the path to folder rather than the tags in the files, but that won't be in the next release.

Alex
Title: Album Art Downloader XUI
Post by: hendo on 2008-01-20 10:46:48
Cheers Alex....

Now that i understand why
.... is there a way where you could search and aggregate all the files which have the same (ALBUM) title and then only display one instance of the duplicate (in the search window).

Not that i know anything about writing code for program.... surely this would be a (relatively) simple task....

I may have even overcomplicated the process...?

Just an idea and i would love to see other peoples opinions on a solution.

Thanks again.   
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-20 11:12:25

You are right, this would be a relatively simple task. The question, though, is whether it is the right thing to do.

Album name alone is not enough to uniquely identify an album. For a trivial example, how many albums called "Greatest Hits" do you think there are? If you found it impossible to add both your "Greatest Hits" (Spice Girls) and "Greatest Hits" (The Cure) to the file browser without removing one first, with no indication of why the second one wasn't appearing, you'd probably be pretty upset.

Various Artists albums are always going to be a problem, as I mentioned in a previous post. The only solutions I can think of are insisting on a separate Album Artist tag, or doing a filename/folder-based approach. To be honest, this problem is aggravated by my not owning any Various Artists albums, and my being the only developer on this project at present.

Alex
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-01-20 11:18:15
Quote
For other filetypes, try "folder.*"


Besides the already mentioned wildcard bug, how would this work if I set it to folder.jpg, and the file I want to save from search window is a png? Without conversion, it would get an incorrect extension... (it would be a nice feature in a future version, if user would have the ability to set saving extension, with automatic conversion afterwards)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-20 12:15:12
Quote
For other filetypes, try "folder.*"
Besides the already mentioned wildcard bug, how would this work if I set it to folder.jpg, and the file I want to save from search window is a png? Without conversion, it would get an incorrect extension...

Worry not! This case is already handled by the wildcard bug fix, and would appear in the search window as "folder.%extension%", causing the extension used to save the file to be determined by the type of the file being saved.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-20 12:51:00
AlbumArt Downloader XUI v0.11 Released

As promised, here is the new version of Album Art Downloader XUI. This version includes various suggested improvements that were requested on this thread:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.0 (http://www.microsoft.com/downloads/details.aspx?familyid=10CC340B-F857-4A14-83F5-25634C3BF043&displaylang=en) (required)
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-01-20 17:09:44
The changes are great!
However, I couldn't stop to add some additional notes

In the search window, it would be a nice addition if there would be some sort of progress meter, or at least a download notification area. Sometimes images take way too long to download (I mainly use google images) and  esp. for an average user, watching  a little clock icon for 1 min is not the best indication of stability.

In the queue window, there should be a queue count, displaying the number of items in queue.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-20 17:43:42

Thanks, I'm glad you liked the changes. In answer to your additional notes:

All the progress information that is available to me is displayed in the sources list to the right. Each source which is capable of determining the number of images available before actually downloading them will display a progress bar as they are being downloaded. Until a source responds with this information (usually as a result of parsing the search results it retrieves) there is no progress information to be reported.

I'll probably add a queue count to the next release, but it might not be for a while. The number of windows should be being saved. If it is not, there might be a bug. I'll look into it.

Alex
Title: Album Art Downloader XUI
Post by: Heliologue on 2008-01-20 23:11:35
I used this tool successfully last month (0.10.1) to download a bunch of album art.  I just came back to it today and suddenly started getting this error whenever I load the File Browser.  The error occurs in both 0.10.1 and 0.11.0.  I'm running Vista x64, up to date, and .NET 3.5.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: G:\Utilities\album art xui 0.11.0\errorlog.txt

App version: 0.11.0.0, running on Microsoft Windows NT 6.0.6000.0

System.BadImageFormatException: An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B)
   at MediaInfoLib.MediaInfo.MediaInfo_New()
   at MediaInfoLib.MediaInfo..ctor()
   at AlbumArtDownloader.FileBrowser.OnIsVisibleChanged(Object sender, DependencyPropertyChangedEventArgs e)
   at System.Windows.UIElement.RaiseDependencyPropertyChanged(EventPrivateKey key, DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.OnIsVisibleChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.UpdateIsVisibleCache()
   at System.Windows.PresentationSource.RootChanged(Visual oldRoot, Visual newRoot)
   at System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
   at System.Windows.Window.SetRootVisual()
   at System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
   at System.Windows.Window.CreateSourceWindowImpl()
   at System.Windows.Window.ShowHelper(Object booleanBox)
   at System.Windows.Window.Show()
   at AlbumArtDownloader.FileBrowser.AlbumArtDownloader.IAppWindow.Show()
   at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: thuan on 2008-01-21 03:45:21
Thank you, your program works fine on my computer. Just that, on first run, the start up time is very slow, and it appears with no theme when I use custom theme on Windows. Other than those, usability this program is great, better than any others I have tried.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-21 07:52:08

From the error log you posted, it looks like MediaInfo can't be loaded on x64. Looking at the MediaInfo site, they have an x64 version available too. Please download MediaInfo_0.7.5.7_DLL_Windows_x64.7z (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.5.7_DLL_Windows_x64.7z) and extract MediaInfo.dll into the Album Art Downloader program folder.



On first run, the program must compile all the .boo scripts for downloading art. It will only do this again if you add, remove, or change any of the scripts.

Custom themes are not supported by WPF. I suspect this is because WPF is a vector-based system, and the old Win32 themes are a bitmap-based system.

Thanks for your comments!

Alex
Title: Album Art Downloader XUI
Post by: Heliologue on 2008-01-21 09:25:28
From the error log you posted, it looks like MediaInfo can't be loaded on x64. Looking at the MediaInfo site, they have an x64 version available too. Please download MediaInfo_0.7.5.7_DLL_Windows_x64.7z (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.5.7_DLL_Windows_x64.7z) and extract MediaInfo.dll into the Album Art Downloader program folder.


Alex


I could have sworn I ran it successfully on Vista x64 before, but I've been switching operating systems a lot lately, so I guess my memory failed me.  In any case, it all seems to work ok with the x64 version of MediaInfo.  Much obliged;  also, wonderful little program you have here.
Title: Album Art Downloader XUI
Post by: radi0n on 2008-01-21 14:26:14
Great program!

It is possible to select album in foobar then in context menu IN foo download the album art via Album Art Downloader?
Title: Album Art Downloader XUI
Post by: mobyduck on 2008-01-21 16:52:15
@radi0n: try searching for foo_run inside this thread.

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: Wirrunna on 2008-01-22 03:33:06
Great work - thank you AlexVallat !

(I use Album Art Aggregator to list the albums without art work and Album Art Downloader to find the missing coves)
Title: Album Art Downloader XUI
Post by: plinni on 2008-01-22 19:18:57
When an album is exactly called like the band It doesn't find any cover. The only field filled is the artist one. Is there a solution for this problem?

I haven't been able to reproduce this. Could you be more specific about what you are doing? Are you starting from the file browser, or the foobar browser, or the command line?



Hi,

I'll show you what I mean. I'm using the foo flow design and this path:
Quote
"C:\Programme\foobar2000\AlbumArtDownloader\AlbumArt.exe" "%artist%" "%album%"


1. Push the button:
(http://trabifant.dirker.org/Sammelplatz/cover_1.jpg)

2. AlbumArtDownloader opens:
(http://trabifant.dirker.org/Sammelplatz/cover_2.jpg)

I don't know what to do with that.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-22 19:56:35
I'll show you what I mean. I'm using the foo flow design and this path: "C:\Programme\foobar2000\AlbumArtDownloader\AlbumArt.exe" "%artist%" "%album%"

Thank you for reporting this bug, plinni. I can confirm it, and it will be fixed for the next version.

Until then, you can work around it by changing your path to:
"C:\Programme\foobar2000\AlbumArtDownloader\AlbumArt.exe" /artist "%artist%" /album "%album%"

Alex
Title: Album Art Downloader XUI
Post by: plinni on 2008-01-23 01:17:47
Thx for the quick help. Amazing!
Title: Album Art Downloader XUI
Post by: phunkydizco on 2008-01-26 11:02:11
I have updated from 0.9 to 0.11 and the first thing I disliked is that the font is very blurred instead of the default windows font. In the screenshot the font of foobar2000 is very clear and album art downloader totally blurred.

(http://img175.imageshack.us/img175/6381/ablumartdownloaderxj5.th.jpg) (http://img175.imageshack.us/my.php?image=ablumartdownloaderxj5.jpg)

I suppose that album art downloader now is a WPF application and that causes this effect. I haven't developed with WPF yet, but I think that there is a possibility to fix that.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-26 16:09:32
I suppose that album art downloader now is a WPF application and that causes this effect. I haven't developed with WPF yet, but I think that there is a possibility to fix that.

It's called anti-aliasing, is part of how the WPF framework draws itself, and as far as I can tell, there is no way to turn it off (http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=319013&SiteID=1), sorry. The best I can offer is that it doesn't look so bad if you have ClearType turned on for the system, which isn't really a solution, I know.

Anti-aliasing and clear-type seems to be in fashion at the moment, although I've got to say I'm more in agreement with you that font-fuzzing is not the great step forwards it is made out to be.

Alex
Title: Album Art Downloader XUI
Post by: Nii2 on 2008-01-26 16:18:21
Hi,

I hace a little issue with scrolling, it's very very slow. I don't understand why, any help would be appreciate.
Thanks in advance
Title: Album Art Downloader XUI
Post by: phunkydizco on 2008-01-26 17:31:53
The best I can offer is that it doesn't look so bad if you have ClearType turned on for the system, which isn't really a solution, I know.

I have already turned ClearType on. Also the screenshot was made with activated ClearType. I think this anti-aliasing thing is very strange. Perhaps WPF should not be used for a classic window based application. For a theme based application like the new Yahoo! Messenger it could make sense.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-27 18:38:29
AlbumArt Downloader XUI v0.12 Released

Another new version of Album Art Downloader XUI, coming sooner than usual on the heels of the last release. I've added a couple more suggested improvements that were requested on this thread, plus a new feature I've been thinking about for a while, a pure command line interface.

As proud as I am of the UI I've created for Album Art Downloader XUI, I appreciate that sometimes it just gets in the way. That's why, as of version 0.12, I've included a command-line only interface, called aad.exe. This is an optional part of the install, but if you choose to use it then it supports mostly the same parameters as the full AlbumArt.exe. It will download a single result and save it without any further interaction. A /sequence parameter can be used to tell it to download a result other than the first. This can be used to implement "try again" type behaviour, in case the first result was no good.

I'd recommend using it with the /sources parameter to specify the sources to search (and the order to search them), as if the first source searched returns a result, that's the one that will be used.

A couple of additional parameters to help get that first result right have been added, /minSize and /maxSize allow the restriction of results by image (pixel) size.

As it is an initial release of the command line UI, I hope you give it a try and let me know if you find it useful, or how it might be improved to be more useful.

Also, note that I've upgraded to .NET Framework 3.5. If you still only have 3.0 installed, now's the time to download the update from the link provided below.

Ful llist of changes:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
Title: Album Art Downloader XUI
Post by: Jonas Nyrup on 2008-01-27 21:56:51
Can Album Art Downloader XUI automatically search a folder for artists and download album art to the respective album folders?
I haven't found a function so far.
Title: Album Art Downloader XUI
Post by: Heliologue on 2008-01-28 02:08:16
Can Album Art Downloader XUI automatically search a folder for artists and download album art to the respective album folders?
I haven't found a function so far.



I don't think it downloads the art automatically because it searches many different sources.  You can, however, launch the "File Browser," point it to a folder, and it will search all the subfolders a return a list of artists/albums, and you can select them for searching.  If you "save" a picture in this manner, it should be saved to the appropriate folder.
Title: Album Art Downloader XUI
Post by: IAmSoBald on 2008-01-28 04:01:49
After downloading the cover, exactly what do I do to make it show up in my playlist? Also, how do I get it to work with AAC files? Sorry, but I'm a total noob at this and I don't want to go through 7 pages at 11:00.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-28 08:00:25
After downloading the cover, exactly what do I do to make it show up in my playlist? Also, how do I get it to work with AAC files? Sorry, but I'm a total noob at this and I don't want to go through 7 pages at 11:00.

It depends on which UI you are using for foobar. The following threads might help:

[a href='index.php?showtopic=58322']Album art support in 0.9.5 (thread split)[/a]
[a href='index.php?showtopic=39924']updated foo_uie_albumart[/a]
PanelsUI and the Single Column Playlist can also make use of album art.

There shouldn't be any specific issue with AAC files, unless you mean you want to embed the image within them. If so, then that is not supported, sorry.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-01-28 08:01:21
You should be able to show album art if you use Default UI of foobar 0.9.5 (there's an album art UI element provided) or with foo_uie_albumart that provides Album art panel if you use Column UI or a few lines of code if you use Panel UI. For specifically how to do it in each way, please use search. There're threads for them already.

EDIT: WOW, Alex was faster.
Title: Album Art Downloader XUI
Post by: IAmSoBald on 2008-01-29 02:50:59
I use Radecke with Panel UI, but I don't know how to add album art after downloading. Right-clicking the columns doesn't give me any options regarding the album art besides downloading it with Coverdownload. It doesn't load automatically. I really can't find anything related to this, the search tool is poor. Here's the URL for the skin I'm using.

http://www.neugablonz.de/index.php?seite=foobar1 (http://www.neugablonz.de/index.php?seite=foobar1)
Title: Album Art Downloader XUI
Post by: teNtiOn on 2008-01-29 09:15:57
Is this plugin only works for amazon.com? Do it works for other country's amazon like amazon.co.jp?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-01-29 09:36:26
Is this plugin only works for amazon.com? Do it works for other country's amazon like amazon.co.jp?
Scripts for amazon web services (US based, I think) and amazon.de are included. [a href='index.php?showtopic=57212']This guy[/a] wrote an interesting multi-threaded amazon.co.jp one, you might like to try out.

IAmSoBald: Are you sure you've put the path in correctly in the foo_run command, modifying it to where you have foobar 2000 installed? For example, if you have it at c:\program files\foobar2000, then according to http://www.neugablonz.de/foobar2000/foo_run.jpg (http://www.neugablonz.de/foobar2000/foo_run.jpg) it should end in: "c:\program files\foobar2000\albumart\%artist%.%album%.folder.jpg"

Alex
Title: Album Art Downloader XUI
Post by: Useless Warrior on 2008-02-03 03:48:57
Sorry if this has already been posted, but since I don't see it mentioned anywhere I noticed that Clamwin is reporting adware when I scan the installer of 0.12, is this a known issue?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-03 09:04:47
Sorry if this has already been posted, but since I don't see it mentioned anywhere I noticed that Clamwin is reporting adware when I scan the installer of 0.12, is this a known issue?

No, not a known issue. I can assure you that I have not put any adware in it, if that's any help. I think it's a false positive with ClamWin, and have submitted it to them for analysis. Meanwhile, I've uploaded a repackaging of the installer (which also includes a minor uninstall bugfix) and ClamWin seems happy with it.

Thanks for reporting it,

Alex
Title: Album Art Downloader XUI
Post by: vader897 on 2008-02-04 02:54:07
I have run into a little problem with using album art downloader and foo run.  I have set up my run command to be. 
Code: [Select]
P:\Program Files '('x86')'\foobar2000\AlbumArtDownloaderXUI-0.12\AlbumArt.exe "%artist%" "%album%" "$replace(%path%,%filename_ext%,folder.jpg)"

The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.
Can you guess what the problem is?  For example a song with

album : Wishes In The Night "Part Two: Of Passion and Serenity"

When i run the script the Album Art Command Line Parameters window opens up and says
Quote
>"P:\Program Files (x86)\foobar2000\AlbumArtDownloaderXUI-0.12\AlbumArt.exe" "Nightwish" "Wishes In The Night "Part Two: Of Passion and Serenity"" "U:\Audiopholder\Metal, Rock, Alternative etc\__Metal\_Symphonic Power Metal\Nightwish\Of Passion and Serenity\folder.jpg"

Album Art Downloader XUI version 0.12.0.0

**** Only the first three parameters may be un-named ****


The problem is that albumart.exe thinks part of the album is a paremeter.

Any ideas on how I can solve this to make my albumart.exe handle these cases properly?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-04 08:50:32
The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.

If parameters have " marks in them, then those marks must be escaped. I think this can be done by using $replace(%artist%,",\"), but someone with better titleformatting skills might be able to give you a better answer. In any case, you are looking to add a \ before every " in the artist and album.

Alex
Title: Album Art Downloader XUI
Post by: kanak on 2008-02-05 04:01:44
Alex,

thank you very much for this wonderful utility... it's very useful and it's saved me countless hours. The integration with foobar through COM Automation is fantastic (I can't believe I just discovered it), but i have a couple of suggestions which would make it even better:

1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

2. Would it be possible for you to cache the results so that the next time the foobar browser is run, it doesn't recheck all the albums for which art exists?


Thanks again for this wonderful utility.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-05 08:50:54
Alex,

thank you very much for this wonderful utility... it's very useful and it's saved me countless hours. The integration with foobar through COM Automation is fantastic (I can't believe I just discovered it), but i have a couple of suggestions which would make it even better:

1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

2. Would it be possible for you to cache the results so that the next time the foobar browser is run, it doesn't recheck all the albums for which art exists?


Thanks again for this wonderful utility.

Good suggestions. I'm not sure how well populated Album Artist is, but if I can get it in a way that will fall back to Artist if it isn't, it's probably safe to use that instead. I can't think of a good reason to prefer Artist over Album Artist if both are populated.

I'll look into caching, but it would probably not make a huge amount of difference if you have a strict image path format, as it would still have to check for the existence of the last known image file (to see if it had been moved or deleted since caching), and that would take just as long as checking for 'folder.jpg', for example. It would help a lot for fuzzy image path formats, like c:\art\unsorted\**\*.jpg, though...

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-05 10:19:18
The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.

If parameters have " marks in them, then those marks must be escaped. I think this can be done by using $replace(%artist%,",\"), but someone with better titleformatting skills might be able to give you a better answer. In any case, you are looking to add a \ before every " in the artist and album.

Alex


I have the same problem but with hyphen "-". Using the same trick it passes \- over too, any idea?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-05 10:51:41
I have the same problem but with hyphen "-". Using the same trick it passes \- over too, any idea?

Hyphens should not need any escaping. Could you give me an example of a command line that fails, and I will look into it.

Alex
Title: Album Art Downloader XUI
Post by: alwaysdub on 2008-02-05 11:23:34


1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

Good suggestions. I'm not sure how well populated Album Artist is, but if I can get it in a way that will fall back to Artist if it isn't, it's probably safe to use that instead. I can't think of a good reason to prefer Artist over Album Artist if both are populated.



Alex,

By default in titleformatting if %album artist% is not populated it will fall back to %artist%, so I would assume this will be no problem, and would be a useful enhancement.

Thanks for all your work on this component.
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-05 12:46:39
Here you are:
Code: [Select]
"D:\Program Files\AlbumArtDownloader\AlbumArt.exe" /artist "-zann-" /album "Samurai from East" /path "D:\Music\Game Music\01\_Touhou_related\-zann-\Samurai from East\front.jpg"


and your program gave this error "**** Unexpected command line parameter: zann- ****"

EDIT: It crashes with this command line
Code: [Select]
D:\Program Files\AlbumArtDownloader\AlbumArt.exe /artist "一青窈" /album "受け入れて" /path "***\front.jpg"
and here's the log in event log
Code: [Select]
EventType clr20r3, P1 albumart.exe, P2 0.12.0.0, P3 479cc933, P4 system, P5 2.0.0.0, P6 471ebf0d, P7 1be, P8 15, P9 system.argumentoutofrange, P10 NIL.

Well this is likely AmazonJPMultithread fault though as it doesn't crash when I disable it.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-05 12:51:49

Thanks. I can confirm this bug as occurring with parameter values starting with a hyphen, or a /. Hyphens elsewhere are not a problem. I will fix this for the next release.
Title: Album Art Downloader XUI
Post by: dubpistol on 2008-02-08 18:32:40
Is there a way to handle compilations with different track-artists?

IMO the file-browser should look first if album-artist is present, and if not, than take the artist.

BTW: Great application
Title: Album Art Downloader XUI
Post by: Max Spicer on 2008-02-08 20:26:53
Is there a way to handle compilations with different track-artists?

IMO the file-browser should look first if album-artist is present, and if not, than take the artist.

BTW: Great application


I don't think I tag any of my various artist albums to indicate that they are various artists.  I mainly use SlimServer against my music, and it manages to work out that all the tracks belong to one album.  I'm guessing it does this either by the fact that the album name is the same (could easily go wrong) or by the fact that the tracks all live in the same directory.  Could Album Art Downloader employ similar logic?

By the way, would it be possible to add a mode that ran simply from the directory structure, rather than the files within it?  I'm running across a wireless network, so the program is having to pull all my flac files across to examine their tags.  However, the information it needs is mainly in the directory structure.  For example:

Music
- CDs
- - The Beatles
- - - Revolver
- - - - 01.flac
- - - - 02.flac

From the above, you can deduce that I have Revolver by The Beatles without having to examine the flac files themselves.  The presence of flac files in a directory shows that it's an album.  There are obviously situations when the user would want you to look at the tags themselves, but this option would greatly speed things up for me at least, as well as opening up currently unsupported formats a bit.

Max
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-09 08:43:02
IMO the file-browser should look first if album-artist is present, and if not, than take the artist.
I've already got this on the list to look into. It seems certainly possible for the foobar browser, but it isn't looking likely for the file browser. There does not appear to be any standard Album Artist tag.

Would it be possible to add a mode that ran simply from the directory structure, rather than the files within it?
I've posted earlier about the possibility of adding a new browser which works on pattern matching the file paths rather than reading the tags from them. You would specify something like "%artist%\%album%\*.flac", for example. It gets trickier if you have paths which include other data, like the year. You might need "%artist%\(*) %album%\*.flac", for example. I'm really hoping not to have to extend it to regular expressions, hopefully wildcards would suffice.

It would be a fairly large piece of work, though, so I probably won't get round to it for a while - I'd rather get all the little things (like the album artist stuff, and hyphen parameter bug) sorted and released before considering a new feature like that.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-10 11:24:19
AlbumArt Downloader XUI v0.13 Released

This release is mostly a bug-fixing update. The following issues have been fixed:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-02-11 01:10:02
Thanks for the great program Alex. The latest version and also the last few versions have been working beautifully. %AlbumArtist% organization is a nice change. That way it will not scatter for a multi-artist disc. I believe this is how the Folder.jpg is also saved in My Pictures, in Album Art\%AlbumArtist%\%Album% structure? 

In an attempt to show my appreciation of the program, I have added support in iTSfv (http://www.hydrogenaudio.org/forums/index.php?showtopic=51708) to look for AAD saved artwork so iTunes/iTSfv users have another automatic artwork source for adding Artwork to iTunes.

5.40.1.0 iTSfv will look for artwork saved using Album Art Downloader

Code: [Select]
20080211T094900 Job Started: VALIDATE_TRACKS_SELECTED
20080211T095116 Found 1 sources of Artwork
20080211T095121 Artwork from [b]AAD[/b] as G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg with 1620x1579
20080211T095129 Choosing G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg as the best Artwork
20080211T095131 Added Artwork to D:\Music\Da Buzz\Greatest Hits\01 Alive.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095133 Added Artwork to D:\Music\Da Buzz\Greatest Hits\02 Take All My Love.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095135 Added Artwork to D:\Music\Da Buzz\Greatest Hits\03 Dangerous.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095136 Added Artwork to D:\Music\Da Buzz\Greatest Hits\04 Do You Want Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095138 Added Artwork to D:\Music\Da Buzz\Greatest Hits\05 Tonight (Is The Night).mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095139 Added Artwork to D:\Music\Da Buzz\Greatest Hits\06 Wonder Where You Are.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095141 Added Artwork to D:\Music\Da Buzz\Greatest Hits\07 Without Breaking.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095143 Added Artwork to D:\Music\Da Buzz\Greatest Hits\08 Last Goodbye.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095144 Added Artwork to D:\Music\Da Buzz\Greatest Hits\09 Wanna Be With Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095146 Added Artwork to D:\Music\Da Buzz\Greatest Hits\10 How Could You Leave Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095148 Added Artwork to D:\Music\Da Buzz\Greatest Hits\11 Paradise.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095149 Added Artwork to D:\Music\Da Buzz\Greatest Hits\12 Let Me Love You.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095151 Added Artwork to D:\Music\Da Buzz\Greatest Hits\13 Baby Listen To Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095152 Added Artwork to D:\Music\Da Buzz\Greatest Hits\14 Take A Chance.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095154 Added Artwork to D:\Music\Da Buzz\Greatest Hits\15 Don't You Ever Leave Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Added Artwork to D:\Music\Da Buzz\Greatest Hits\16 Da Buzz Club Mix.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Artwork.jpg
20080211T095157 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\AlbumArtSmall.jpg
20080211T095157 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Da Buzz - (2007) Greatest Hits.jpg
20080211T095157 Export Artwork Pass 2 Finished.
20080211T095158 .
20080211T095158 Log saved in G:\Users\McoreD\Documents\iTSfv\Logs\tracks-200802-artwork-added.txt
20080211T095158 Duration: 0 Hours 02 Minutes 58.025715 Seconds
20080211T095158 Cleaning Temporary Files... in G:\Users\McoreD\AppData\Roaming\iTSfv\
20080211T095159 Job Finished: VALIDATE_TRACKS_SELECTED

Keep up the great work!

Cheers,
McoreD
Title: Album Art Downloader XUI
Post by: drbeachboy on 2008-02-11 02:49:42
Hi Alex,



If AAD is supposed to work with fb2k, then why are you using "albumartist" instead of "album artist", which is a fb2k tag? Is there any chance of adding it, along with "date"? Thanks for all of your work on AAD, it is much appreciated.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-11 08:20:36
Hi McoreD, thanks for your comments, and for adding support to your excellent iTSfv! I should point out that the  syntax for specifying where to save images to hasn't changed, though, it is still just %artist%, meaning the artist that was searched for in Album Art Downloader (which may or may not be an album artist, no distinction is made).

If AAD is supposed to work with fb2k, then why are you using "albumartist" instead of "album artist", which is a fb2k tag? Is there any chance of adding it, along with "date"? Thanks for all of your work on AAD, it is much appreciated.

I'm not. The foobar browser reads the result of titleformatting "%album artist%". Date is not read - what would you want it to do with it, just display it in a column in the browser?

Alex
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2008-02-11 17:52:11
the newst version 0.13 just refuses to start for me  (0.12 worked fine with same settings)

this error msg i get (but there are some localized strings in it so it will be probably hardly readable )

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: c:\Program Files\___mp3\foobar2000\albumart\errorlog.txt

App version: 0.13.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.IO.FileNotFoundException: Nelze načíst soubor nebo sestavení System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 nebo jeden z jejich závislých prvků. Systém nemůže nalézt uvedený soubor.
Název souboru: System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
  v AlbumArtDownloader.Arguments..ctor(String[] args, IEnumerable`1 valuedParameters)
  v AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  v AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  v System.Windows.Application.<.ctor>b__0(Object unused)
  v System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  v System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  v System.Windows.Threading.DispatcherOperation.InvokeImpl()
  v System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  v System.Threading.ExecutionContext.runTryCode(Object userData)
  v System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  v System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  v System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  v System.Windows.Threading.DispatcherOperation.Invoke()
  v System.Windows.Threading.Dispatcher.ProcessQueue()
  v System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  v MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  v MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  v System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  v System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  v System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  v System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  v MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  v MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  v System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  v System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  v System.Windows.Threading.Dispatcher.Run()
  v System.Windows.Application.RunInternal(Window window)
  v System.Windows.Application.Run(Window window)
  v System.Windows.Application.Run()
  v AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  v AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  v AlbumArtDownloader.App.Main(String[] args)

WRN: Protokolování vazeb sestavení je VYPNUTO.
Chcete-li povolit protokolování chyb vazeb sestavení, nastavte hodnotu registru [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) na hodnotu 1.
Poznámka: Protokolování chyb vazeb sestavení ovlivňuje výkon systému.
Chcete-li tuto funkci vypnout, odeberte z registru hodnotu [HKLM\Software\Microsoft\Fusion!EnableLog].

ive tried windows update but there arent any .net updates i dont have... any help?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-11 18:44:14
ive tried windows update but there arent any .net updates i dont have... any help?

This looks a lot like not having .net framework 3.5 installed - perhaps you have only 3.0? Try installing 3.5 from here (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6).

Alex
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2008-02-11 19:09:49
This looks a lot like not having .net framework 3.5 installed - perhaps you have only 3.0? Try installing 3.5 from here (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6).

Alex


thx for quick help. i was almost sure that i have .net 3.5 installed so i tried to reinstall it and now everything is working thx.
probably i smehow damaged it and didnt even know about it.
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-02-13 23:01:08
Hi Alex,

I discovered some unexpected behavior which you can easily fix.

I searched:

Artist: Raff
Album: Self Control / Running Away


The results are fine. I managed to find the artwork!

The folder path where the Folder.jpg is saved is however

Pictures\Album Art\Raff\Self Control\Running Away\Folder.jpg

Expected Output:

Pictures\Album Art\Raff\Self Control _ Running Away\Folder.jpg



So it seems to me the illegal characters in Album Name string are not replaced to File System friendly characters.

Double checked with another test:

---------------------------
Album Art Downloader
---------------------------
Could not save image 'G:\Users\McoreD\Pictures\Album Art\ABBA\Gold: Greatest Hits\Folder.jpg':

The given path's format is not supported.
---------------------------
OK 
---------------------------

Here is a function that you could use for the Album Name, (may be also for Artist Name) just prior to saving the Image to File System.

Code: [Select]
     public string mfGetLegalTextForDirectory(string txt)
{
    
     txt = txt.Replace("/", "_");
     txt = txt.Replace(":", "_");
     txt = txt.Replace("*", "_");
     txt = txt.Replace("?", "_");
     txt = txt.Replace(Strings.Chr(34), "_");
     txt = txt.Replace("<", "_");
     txt = txt.Replace(">", "_");
     txt = txt.Replace("|", "_");
    
     return txt;
    
}


iTunes replaces all the illegal characters to "_" so to maintain interoperability could you also please use underscore to replace illegal characters?

Thanks,
McoreD
Title: Album Art Downloader XUI
Post by: dubpistol on 2008-02-14 06:31:43
  • Changed foobar browser to use %album artist% instead of %artist%

Great improvement. Thank you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-14 08:27:25
illegal characters in Album Name string are not replaced to File System friendly characters.
<snip/>
iTunes replaces all the illegal characters to "_" so to maintain interoperability could you also please use underscore to replace illegal characters?

Yes. I'll do that this weekend.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: FavioD on 2008-02-17 03:19:01
I can't seem to figure out why after updating my album art, my previously working foo_run command doesn't seem to work:

"C:\Program Files '('x86')'\AlbumArtDownloader\AlbumArt.exe" /ar %artist%" /al "%album%" /p "$replace(%_path%,%_filename_ext%,)cover.'%extension%'"


Every time I do that the "Album Art download command parameters" pops up.
Title: Album Art Downloader XUI
Post by: kanak on 2008-02-17 03:50:50
Hi Alex,

thanks for adding album artist support .

I have one question regarding COMServer: Can you use it to query the contents of a playlist in foobar (instead of querying the media library)? If this was possible, i could just have it query the contents of the "new albums" playlist and automatically get art for them.

If this is not possible (or is too much work to implement), please disregard the request.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-17 08:04:45
<snip> /ar %artist%" <snip>

Looks like you're missing a " mark there, that should be "%artist%". If that was just a typo copying to the forum, then please copy the first 3 or 4 lines of the error popup which should contain the command line passed to it and the error message.

Can you use it to query the contents of a playlist in foobar (instead of querying the media library)?

Yes, that sounds like a good idea. I'll add that into the next version. The foobar browser will have a drop-down for picking either All Media, or one of the playlists.

Alex
Title: Album Art Downloader XUI
Post by: FavioD on 2008-02-18 02:55:54
<snip> /ar %artist%" <snip>

Looks like you're missing a " mark there, that should be "%artist%". If that was just a typo copying to the forum, then please copy the first 3 or 4 lines of the error popup which should contain the command line passed to it and the error message.


Woooooooooooooooooow, I was missing a quotation mark, thanks for proof reading. I feel terrible.

edit:
Great program !
Title: Album Art Downloader XUI
Post by: Tich on 2008-02-18 21:45:24
A crash just occured while running from foo_run (latest version) with the following arguments:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /ar "%album artist%" /al "%album%" /p "$replace(%_path%,%_filename_ext%,)'%artist%' - '%album%' - Front.'%extension%'"

The first time this crash appeared.

edit: on album Fresh Cream by artist Cream

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.13.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.FormatException: Input string was not in a correct format.
  at System.Text.StringBuilder.FormatError()
  at System.Text.StringBuilder.AppendFormat(IFormatProvider provider, String format, Object[] args)
  at System.String.Format(IFormatProvider provider, String format, Object[] args)
  at AlbumArtDownloader.ArtSearchWindow.AlbumArtDefaultFilePathPatternSubstitution.Convert(Object value, Type targetType, Object parameter, CultureInfo culture)
  at System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
  at System.Windows.Data.BindingExpression.Activate(Object item)
  at System.Windows.Data.BindingExpression.AttachToContext(AttachAttempt attempt)
  at System.Windows.Data.BindingExpression.AttachOverride(DependencyObject target, DependencyProperty dp)
  at System.Windows.Data.BindingExpressionBase.OnAttach(DependencyObject d, DependencyProperty dp)
  at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
  at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  at System.Windows.Data.BindingOperations.SetBinding(DependencyObject target, DependencyProperty dp, BindingBase binding)
  at AlbumArtDownloader.ArtSearchWindow.BindAlbumArtDefaultFilePath(AlbumArt art)
  at AlbumArtDownloader.ArtSearchWindow.OnResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
  at System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
  at System.Collections.ObjectModel.Collection`1.Add(T item)
  at AlbumArtDownloader.Sources.OnSourceResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
  at System.Collections.ObjectModel.Collection`1.Add(T item)
  at AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass9.<Add>b__7()
  --- End of inner exception stack trace ---
  at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  at System.Delegate.DynamicInvokeImpl(Object[] args)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)

Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-19 08:09:09
A crash just occured <snip />

From that error log, I suspect I know what the problem is - could you check if the path to that album includes { or } characters please? If it does, then there is currently a known bug with paths including those characters, a fix for which will be included in the next version. If not, then please let me know the full path to the album so I can figure out if something else has gone wrong.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Tich on 2008-02-19 10:25:42
You are right, the path includes { and }:
Code: [Select]
U:\Cream - Fresh Cream (1966) [FLAC] {DCC Gold Steve Hoffman remaster}

Thanks for the quick reply, I was probably too stoned to search the forum thread for the answer if you had given it already.
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-20 10:03:11
Crash report: I had one instance of AlbumArtDownloader XUI then I launch another using foobar. Before the new instance show up, I closed the old one and it crashed. Here's the error log:
Code: [Select]
App version: 0.13.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ServiceModel.FaultException: The server was unable to process the request due to an internal error.  For more information about the error, either turn on IncludeExceptionDetailInFaults (either from ServiceBehaviorAttribute or from the <serviceDebug> configuration behavior) on the server in order to send the exception information back to the client, or turn on tracing as per the Microsoft .NET Framework 3.0 SDK documentation and inspect the server trace logs.

Server stack trace:
  at System.ServiceModel.Channels.ServiceChannel.ThrowIfFaultUnderstood(Message reply, MessageFault fault, String action, MessageVersion version, FaultConverter faultConverter)
  at System.ServiceModel.Channels.ServiceChannel.HandleReply(ProxyOperationRuntime operation, ProxyRpc& rpc)
  at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout)
  at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs)
  at System.ServiceModel.Channels.ServiceChannelProxy.InvokeService(IMethodCallMessage methodCall, ProxyOperationRuntime operation)
  at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(IMessage message)

Exception rethrown at [0]:
  at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
  at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
  at AlbumArtDownloader.IPriorInstance.Signal(String[] parameters)
  at AlbumArtDownloader.InstanceMutex.QueryPriorInstance(String[] args, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-20 10:30:30
Crash report: I had one instance of AlbumArtDownloader XUI then I launch another using foobar. Before the new instance show up, I closed the old one and it crashed. Here's the error log:

Thanks for reporting this. It seems to be a case of extremely unlucky timing, but I'll see what I can do about mitigating it so it won't crash under those circumstances.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-02-21 07:30:08
I am finding more and more use of this excellent app: Album Art Downloader XUI. In iTunes I got iTSfv to pass Artist and Album information to Album Art Downloader XUI to search for Artwork. AAD saves it as Folder.jpg and when you validate the album in iTunes, the artwork is detected and embedded to tracks.

Thanks again Alex!

Looking forward to a release from you with the previous folder name fixes.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-22 19:35:50
AlbumArt Downloader XUI v0.14 Released

Some fairly big new features added this time round. As has been much requested, it is now possible to use a file path pattern to determine Artist and Album information instead of using tags. Another request was to be able to search just a specific playlist from Foobar, rather than the whole library, so I've added a playlist picker to the Foobar browser. Of course, you can still choose Entire Library there.

To use the file path pattern thing, start the File Browser as usual, and click the Options link. There are now two additional options, which you can use to choose between Tags or File Path Pattern Matching. If you choose the pattern matching option, there is also a box where you can enter the pattern your files are named by, for example \%artist%\%album%\* would match against c:\music\muse\showbiz\01. Sunburn.mp3 as Artist = muse, Album = showbiz. Or, to use an example from a few posts earlier, U:\Cream - Fresh Cream (1966) [FLAC] {DCC Gold Steve Hoffman remaster} could be matched by \%artist% - %album% (*\*. If you've got a really freaky naming scheme which can't be covered by just * and ? wildcards, then you can include literal regular expression code in the pattern in between " marks. For example, the previous pattern could be improved as \%artist% - %album% ("\d{4}")*\* to avoid problems with albums with ( characters in. If you don't want to use the built-in %artist% substitutions, any regex capturing group named artist (or album) can be used.

If you have a freaky naming scheme, and you don't know regular expressions, and you really don't want to use tags, then post some examples of your paths here and someone who does know regular expressions can probably help you out.

The file path pattern matching is generally much, much faster than tag matching, but may be less reliable, depending on how well organised your collection is.

I've also fixed the following bugs:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
Title: Album Art Downloader XUI
Post by: kanak on 2008-02-22 20:51:21
Wow. Thanks for the excellent release! The playlist browser is a godsend. 
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-24 08:13:02
Crash report: when I open up a preview and foobar browser then I turn off the preview window and foobar browser in order, it crashed. Foobar Com Automation component is not installed on my computer. Here's the errorlog:
Code: [Select]
App version: 0.14.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.NullReferenceException: Object reference not set to an instance of an object.
  at AlbumArtDownloader.FoobarBrowser.OnClosed(EventArgs e)
  at System.Windows.Window.WmDestroy()
  at System.Windows.Window.WindowFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)

Also, when I open more than 2 albumartdownloader window and close the older ones sometimes make the currently running one hang. On some occasion it recovers after a while and most of the time not. All albumartdownloader instances I launch are from foobar run service component.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 08:28:53
Crash report: when I open up a preview and foobar browser then I turn off the preview window and foobar browser in order, it crashed. Foobar Com Automation component is not installed on my computer.

Thanks for that report. I can confirm that with 0.14, closing the foobar browser window when the foobar com automation component is not installed will cause this crash. The preview window and order of closing does not affect this, and of course foobar itself is unaffected. I will have a fix for this in the next release, but until then I'd recommend either installing the com automation component, or not using the foobar browser (which doesn't do much without it installed anyway).

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-24 08:46:50
Well, I was just playing around. After that crash somehow it still crashes with this error a bunch of times until I restart. I didn't use the foobar browser again:
Code: [Select]
App version: 0.14.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ServiceModel.CommunicationObjectFaultedException: The communication object, System.ServiceModel.Channels.ServiceChannel, cannot be used for communication because it is in the Faulted state.

Server stack trace:
  at System.ServiceModel.Channels.CommunicationObject.Close(TimeSpan timeout)
  at System.ServiceModel.Channels.CommunicationObject.Close()

Exception rethrown at [0]:
  at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
  at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
  at System.ServiceModel.ICommunicationObject.Close()
  at AlbumArtDownloader.InstanceMutex.QueryPriorInstance(String[] args, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 09:01:50
Well, I was just playing around.

Yes, fair enough, and it should absolutely not crash under those circumstances, I know. It was my own mistake that crept in while adding the playlist functionality, and I'll fix it as soon as possible.

The other crash you report is related to trying to communicate with an existing instance of the app which is not responding (possibly because of the earlier crash? Only a guess). If it happens again, please check Task Manager to see if there is an AlbumArt.exe entry in the processes list. If there isn't, then please let me know as something else strange is going on and I'll need to investigate. If there is, then you can End Process on AlbumArt.exe and avoid having to restart to clear the error.

In either case, I'll see what I can do about adding some automatic recovery for this situation.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-24 09:12:55
Before I restarted the computer I did check for AlbumArt.exe ghost process using Process Explorer, but there's none. That's why I had to restart my computer.

EDIT: I encounter the 2nd crash again and this time, indeed there's a ghost AlbumArt.exe in my process list. It makes me doubt my memory.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 10:06:38
Before I restarted the computer I did check for AlbumArt.exe ghost process using Process Explorer, but there's none. That's why I had to restart my computer.

OK; good to know. I've tried adding some additional robustness to the single instance code, hopefully faced with the same situation now it would automatically recover itself (although potentially having two instances running, if one could not be communicated with).

I've uploaded 0.14.1 which should hopefully resolve these issues - If you could give it a try and let me know if you encounter them again (or any others, of course!), then that would be appreciated. Download links remain the same:

AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe), or AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-24 10:20:54
I can only get 0.14 with your links, please check them again.
Title: Album Art Downloader XUI
Post by: dano on 2008-02-24 10:22:35
-Can you update the Amazon.de script with the image dimensions like the .com version?

-When the option Automatically download full sized images (x) Only when size is unkown
is selected, the size is not updated when the image was loaded, only if you preview the image
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 11:03:22
I can only get 0.14 with your links, please check them again.

Just checked, they are downloading 0.14.1 when I try them here. The filename doesn't include the extra .1 part of the version number, perhaps that is the source of confusion?

-Can you update the Amazon.de script with the image dimensions like the .com version?

-When the option Automatically download full sized images (x) Only when size is unkown
is selected, the size is not updated when the image was loaded, only if you preview the image

I didn't write Amazon.de, that's one of Marc's. Looking at it, though, I don't think it can determine the image dimensions without downloading the image. The .com one uses the Amazon web services API, which does give that information. The .de one relies on reading the Amazon html pages, and the information just isn't there.

I'm not sure why you aren't seeing the size being automatically updated. Are you saying that the full size image has loaded, but the size for it is not updated? Or that the full size image is not being downloaded at all?

Alex
Title: Album Art Downloader XUI
Post by: dano on 2008-02-24 11:34:30
I didn't write Amazon.de, that's one of Marc's. Looking at it, though, I don't think it can determine the image dimensions without downloading the image. The .com one uses the Amazon web services API, which does give that information. The .de one relies on reading the Amazon html pages, and the information just isn't there.

Oh ok, so the best would be to drop the html version (it also gets images with white borders) and replace it with a web api version. I figured I just have to replace .com with .de in url request but not in the namespace to make me a .de version. It seems to work fine.
Quote
I'm not sure why you aren't seeing the size being automatically updated. Are you saying that the full size image has loaded, but the size for it is not updated?

Yes. Some scripts don't get the image size, so I thought they would show it if I let them download the complete images.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 11:54:20
Oh ok, so the best would be to drop the html version (it also gets images with white borders) and replace it with a web api version. I figured I just have to replace .com with .de in url request but not in the namespace to make me a .de version. It seems to work fine.
Quote
I'm not sure why you aren't seeing the size being automatically updated. Are you saying that the full size image has loaded, but the size for it is not updated?

Yes. Some scripts don't get the image size, so I thought they would show it if I let them download the complete images.
If that web api version of the .de script works, that's good news, it could replace the html one. Do you know of any test albums to search for that the .de version returns differently from the .com version?

The automatic image downloading thing is a mystery, I can't see why that wouldn't be working for you. To test this, try deselecting all scripts except Coveralia (a slow source that doesn't have sizes). With the automatically download fullsize images option on Never, search for an album. You should get around 3 images back, usually front cover, back cover and CD. The image size should be "Unknown", and the thumbnails fuzzy (make the thumbnails larger if you can't tell). Then, click on the "Only when size unknown" option, and one of the results should show a little browse globe icon in the top left of the thumbnail, indicating it is downloading. After a few seconds, the thumbnail should become sharp and the image size filled in (usually around 1000 x 1000). Another of the results should then get the globe icon indicating it is being downloaded, and so on until all are completed.

Alex
Title: Album Art Downloader XUI
Post by: dano on 2008-02-24 12:15:28
Quote
If that web api version of the .de script works, that's good news, it could replace the html one. Do you know of any test albums to search for that the .de version returns differently from the .com version?

I don't think that's an issue, quite some albums return different covers, but the code works for both versions.

The automatic image downloading works now, thanks. Was my fault.

I have a new question:
Can the file browser recognize compilation albums (e.g. a tag like Album Artist) when it scans in ID3 tag mode so that it doesn't return 20 albums instead of one?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 12:30:44
Can the file browser recognize compilation albums (e.g. a tag like Album Artist) when it scans in ID3 tag mode so that it doesn't return 20 albums instead of one?

No. I did look into this back in version 0.13, but while the Foobar library has the %album artist% titleformatting value for this, there appears to be no standard ID3 tag for compilation albums.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-02-24 13:01:46
Thanks, Alex. I can confirm that the foobar COM crash problem is fixed. Here's a bunch of endpoint values that you can change the URL request to, to get your version of Amazon cover search:
Code: [Select]
CA:    http://ecs.amazonaws.ca/onca/xml
DE:    http://ecs.amazonaws.de/onca/xml
FR:    http://ecs.amazonaws.fr/onca/xml
JP:    http://ecs.amazonaws.jp/onca/xml
UK:    http://ecs.amazonaws.co.uk/onca/xml
US:    http://ecs.amazonaws.com/onca/xml


Alex, what is the namespace in your Amazon.boo does anyway. That link is dead I think, it redirects to another page.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 16:16:56
Alex, what is the namespace in your Amazon.boo does anyway. That link is dead I think, it redirects to another page.

It isn't exactly a link, it is a namespace. They look like links, for uniqueness reasons, but don't actually have to even be resolvable.

The important thing about it is that it must exactly match the namespace of the returned xml data. If you look at the XML data returned from amazon, it starts like this:

<?xml version="1.0" encoding="UTF-8"?><ItemSearchResponse xmlns="http://webservices.amazon.com/AWSECommerceService/2005-10-05">...

The xmlns bit defines the namespace, and it is this that the namespace in the .boo file must match.

Thanks for the list of domain suffixes too. I'm not sure what the best way to deal with this is, whether to bundle a script for each domain, or have one script and come up with some way of setting the domain to use in the UI. I'll do some experimenting, anyway.

Alex
Title: Album Art Downloader XUI
Post by: dano on 2008-02-24 16:35:03
Can the file browser recognize compilation albums (e.g. a tag like Album Artist) when it scans in ID3 tag mode so that it doesn't return 20 albums instead of one?

No. I did look into this back in version 0.13, but while the Foobar library has the %album artist% titleformatting value for this, there appears to be no standard ID3 tag for compilation albums.

Alex

You could check for the ALBUM ARTIST tag in the files, it's very common among foobar users. It's also the same name for all tag formats.
I've checked if mediainfo can read it. At least the GUI shows the tag, although on mp3 it cuts the first 3 letters of TXXX frames, but I mailed the author, he has already fixed the issue.
Of course I don't know if the DLL returns all tag fields, but maybe you can give it another look.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-24 18:53:16
You could check for the ALBUM ARTIST tag in the files, it's very common among foobar users.

The TXXX ALBUM ARTIST tag appears to be a foobar specific thing. Other media players use the BAND (TPE2) tag, or a TXXX ALBUMARTIST tag (no space), and I've even heard that WMP 11 stores the Artist as the ID3v1 artist tag and Album Artist as the ID3v2 artist tag. There may be other schemes too. The problem is that there appears to be no standardisation at all, and for the File Browser I can't assume that the tags were written by foobar2000.

Alex
Title: Album Art Downloader XUI
Post by: antares on 2008-02-27 13:50:55
Hi Alex,

I have been working with File Broswer and it works like a charm! Thanks for your effort! To improve my results, I would like to know if it is possible, to exclude information which may disturb some search results.

My file-scheme for example is "E:\Musik\mpc\Alice Cooper\[1999] Life And Crimes Of Alice Cooper CD 2"

Is it possible to exclude the Year: "[1999]" and the Volume: "CD 2"? Without these information the results are mostly better. Is this possible and how?

Another question is , how to improve results at albums with various artists? These albums are displayed as "Various" in the "Artist"- naming field of Album Art Downloader. Are there better results if I use other terms than Various?

Thanks for your help


Martin
Title: Album Art Downloader XUI
Post by: _eclectic_ on 2008-02-27 15:12:59
I have just now discovered your tool.  It is absolutely, hands-down, the best, most complete tool I have used bar none for covers.  Every aspect of it has been well-thought out, from using tags or dire structure, size of the existing image, etc.etc.etc..  I am so impressed, I can't stop smiling!  You have saved me immeasurable amounts of time in scanning or searching the web for covers!!!!

ThankyouThankyouThankyouThankyouThankyouThankyouThankyouThankyouThankyouThankyou!!!!!!!

So, do you have a paypal link?  There are few programs out there that deserve it more....
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-02-27 18:20:52
My file-scheme for example is "E:\Musik\mpc\Alice Cooper\[1999] Life And Crimes Of Alice Cooper CD 2"

Is it possible to exclude the Year: "[1999]" and the Volume: "CD 2"? Without these information the results are mostly better. Is this possible and how?

Yes, this is possible. Try:
Code: [Select]
\mpc\%artist%\"(\[\d{4}\] )?"%album%"( CD \d+)?"\*

That assumes that both the date the CD number are optional, but that all music is under \mpc\... If either of those assumptions are wrong, it will need tweaking.

Another question is , how to improve results at albums with various artists? These albums are displayed as "Various" in the "Artist"- naming field of Album Art Downloader. Are there better results if I use other terms than Various?

I would guess that would depend on how the source being searched has classified them. You might try just searching for the album name without anything in the Artists field, that will probably work for most sources. The file-scheme can be tweaked to make the Album come out blank when the folder is Various like so:
Code: [Select]
\mpc\"(Various|%artist%)"\"(\[\d{4}\] )?"%album%"( CD \d+)?"\*


So, do you have a paypal link?  There are few programs out there that deserve it more....

Thanks for your kind words! It is really great to know when my work is appreciated, but I've also got to acknowledge my own debt of thanks to the residents of this forum who have suggested many of those features, and helped me track down bugs when they've appeared.

I hadn't set up a paypal link - it was something I was considering if I ever got round to putting together a proper website and documentation for a 1.0 release. But, as you specifically ask, any donation will be gratefully received here: Paypal Donation (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate) 

Alex
Title: Album Art Downloader XUI
Post by: _eclectic_ on 2008-02-27 22:13:55
Quote
I hadn't set up a paypal link - it was something I was considering if I ever got round to putting together a proper website and documentation for a 1.0 release. But, as you specifically ask, any donation will be gratefully received here: Paypal Donation (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate) 

Alex

Okiedokie, seeing as how the US Dollar is crap compared with the pound, I had to double my efforts. 

Go have a nice pint on me, truly miss those nice mugs...
Title: Album Art Downloader XUI
Post by: antares on 2008-02-28 09:04:13
Hi Alex,

thank you very much for your kind help!


Martin
Title: Album Art Downloader XUI
Post by: Tirade on 2008-03-05 01:25:19
Im using a fresh install of Vista x64 SP1 and the latest AAD XUI

Ive not been able to get it to start yet as I get an error every time I click on the File Browser option.

Here is the error

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files (x86)\AlbumArtDownloader\errorlog.txt

App version: 0.14.1.0, running on Microsoft Windows NT 6.0.6001 Service Pack 1

System.BadImageFormatException: An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B)
   at MediaInfoLib.MediaInfo.MediaInfo_New()
   at MediaInfoLib.MediaInfo..ctor()
   at AlbumArtDownloader.FileBrowser.OnIsVisibleChanged(Object sender, DependencyPropertyChangedEventArgs e)
   at System.Windows.UIElement.RaiseDependencyPropertyChanged(EventPrivateKey key, DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.OnIsVisibleChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
   at System.Windows.UIElement.UpdateIsVisibleCache()
   at System.Windows.PresentationSource.RootChanged(Visual oldRoot, Visual newRoot)
   at System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
   at System.Windows.Window.SetRootVisual()
   at System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
   at System.Windows.Window.CreateSourceWindowImpl()
   at System.Windows.Window.ShowHelper(Object booleanBox)
   at System.Windows.Window.Show()
   at AlbumArtDownloader.FileBrowser.AlbumArtDownloader.IAppWindow.Show()
   at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
   at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-05 08:44:20
Im using a fresh install of Vista x64 SP1 and the latest AAD XUI

Could you try downloading the x64 version of MediaInfo (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.6.0_DLL_Windows_x64.7z?modtime=1204285826&big_mirror=0) and extracting MediaInfo.dll into the Album Art Downloader program folder?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Tirade on 2008-03-05 12:16:51
Im using a fresh install of Vista x64 SP1 and the latest AAD XUI

Could you try downloading the x64 version of MediaInfo (http://downloads.sourceforge.net/mediainfo/MediaInfo_0.7.6.0_DLL_Windows_x64.7z?modtime=1204285826&big_mirror=0) and extracting MediaInfo.dll into the Album Art Downloader program folder?

Thanks,

Alex



/bow

You are the man.

Fixed!
Title: Album Art Downloader XUI
Post by: entrecour on 2008-03-05 19:06:41
Hi Alex,

Album Art Dowloader has grown from strenth to strength -it's definitely the best tool I have found.

As the new owner of a HTPC I wonder wether you have ever looked at adding DVD covers as an additional capability? The concepts involve seem very similar to me.

Thanks, David.
Title: Album Art Downloader XUI
Post by: ryran on 2008-03-08 19:04:09
Hey everyone. Hoping to get some guidance here...
I've used the original Album Art Downloader up until now but finally decided to try this out. Got net3.5 all installed and then this (version 0.14) but now when I load the executable I just get a properly titled black window. I can resize it... if I move the mouse around the cursor changes to text input or hyperlinkink cursors.. but... nothing I can do.
HALP plz!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-10 19:22:28
Sorry about the delayed reply here.

As the new owner of a HTPC I wonder wether you have ever looked at adding DVD covers as an additional capability? The concepts involve seem very similar to me.
There's no particular reason why DVD covers can't be found using this tool, it all depends on the source. For something like Google Images, they'll be returned already. Other more specific DVD cover sources could be written too, which in some cases might just be a modification of an existing script.

I don't think there's any equivalent to ID3 Tags for DVD's, but the folder browser using path pattern matching would still work.

I just get a properly titled black window.
Sorry, Ryran, but this is a complete mystery to me. I've searched around and found no likely explanations, so I can't give you any suggestions on what might be causing this or how to fix it.

Alex
Title: Album Art Downloader XUI
Post by: sylla on 2008-03-18 12:33:36
An idea is to show the size of existing albumart in pixels instead of in kb in the file browser, that makes more sense to me at least.

Great program this, thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-18 12:40:53
An idea is to show the size of existing albumart in pixels instead of in kb in the file browser, that makes more sense to me at least.

Thanks for the suggestion, but this would require each existing image to actually be loaded from disk, resulting in a considerable decrease in performance. The current system does not need to actually load the image files to display the file size.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-03-18 18:16:23
A very simple request:  Tab and Shift-Tab highlight the previous entry (as it once did).  That way you don't have to manually delete the old entry, but can simply start typing.

That said, awesome program!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-18 18:43:31
A very simple request:  Tab and Shift-Tab highlight the previous entry (as it once did).  That way you don't have to manually delete the old entry, but can simply start typing.
I'm not sure I understand what you are asking for here, could you be more specific? If you could tell me in what state the program is (including where the focus is, if you can tell) when you click Tab or Shift Tab, what it actually does, and what you expected it to do, I can probably fix this.

Alex
Title: Album Art Downloader XUI
Post by: jasperooni on 2008-03-23 17:04:22
Crash:
Quote
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\foobar2000\AlbumArtDownloader\errorlog.txt

App version: 0.14.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3, v.3244

System.Reflection.TargetInvocationException: Ein Aufrufziel hat einen Ausnahmefehler verursacht. ---> System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei AlbumArtDownloader.AlbumArt.get_ImageCodecInfo()
  bei AlbumArtDownloader.AlbumArt.CoerceFilePath(DependencyObject sender, Object value)
  bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  bei System.Windows.DependencyObject.CoerceValue(DependencyProperty dp)
  bei AlbumArtDownloader.AlbumArt.OnDefaultFilePathPatternChanged(DependencyObject sender, DependencyPropertyChangedEventArgs e)
  bei System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  bei System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  bei System.Windows.DependencyObject.InvalidateProperty(DependencyProperty dp)
  bei System.Windows.Data.BindingExpression.Invalidate(Boolean isASubPropertyChange)
  bei System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
  bei System.Windows.Data.BindingExpression.ScheduleTransfer(Boolean isASubPropertyChange)
  bei MS.Internal.Data.ClrBindingWorker.NewValueAvailable(Boolean dependencySourcesChanged, Boolean initialValue, Boolean isASubPropertyChange)
  bei MS.Internal.Data.PropertyPathWorker.UpdateSourceValueState(Int32 k, ICollectionView collectionView, Object newValue, Boolean isASubPropertyChange)
  bei MS.Internal.Data.PropertyPathWorker.OnDependencyPropertyChanged(DependencyObject d, DependencyProperty dp, Boolean isASubPropertyChange)
  bei MS.Internal.Data.ClrBindingWorker.OnSourceInvalidation(DependencyObject d, DependencyProperty dp, Boolean isASubPropertyChange)
  bei System.Windows.Data.BindingExpression.HandlePropertyInvalidation(DependencyObject d, DependencyPropertyChangedEventArgs args)
  bei System.Windows.Data.BindingExpression.OnPropertyInvalidation(DependencyObject d, DependencyPropertyChangedEventArgs args)
  bei System.Windows.DependentList.InvalidateDependents(DependencyObject source, DependencyPropertyChangedEventArgs sourceArgs)
  bei System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  bei System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
  bei System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  bei AlbumArtDownloader.Controls.ArtPathPatternBox.set_PathPattern(String value)
  bei AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  bei AlbumArtDownloader.App.<>c__DisplayClass3.<Signal>b__2()
  --- Ende der internen Ausnahmestapelüberwachung ---
  bei System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  bei System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  bei System.Delegate.DynamicInvokeImpl(Object[] args)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-03-23 17:16:56
A very simple request:  Tab and Shift-Tab highlight the previous entry (as it once did).  That way you don't have to manually delete the old entry, but can simply start typing.
I'm not sure I understand what you are asking for here, could you be more specific? If you could tell me in what state the program is (including where the focus is, if you can tell) when you click Tab or Shift Tab, what it actually does, and what you expected it to do, I can probably fix this.

What I mean is if you're in the Artist field and Tab to the Album field, the previous album in that field is already highlighted, so you can simply type over it.  Conversely, if you're in the Album field and Shift-Tab back to the Artist field, the old artist in that field is already highlighted.

I don't know your native language, so if that's not clear, I can provide images to explain better what I mean.

It's not a big deal.  It just saves a little time manually deleting the old info already in the field.  It used to work that way (at my request), but somehow got changed somewhere along the line.

Thanks. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-23 19:28:58
Crash: <snip/>
From the error report, it appears that Album Art Downloader was unable to determine the correct file extension for an image format. I can fix it so that it won't crash in this case (and I will do, for the next version), but it would be really useful if you could let me know which album, artist and image source it came from. That way I can figure out what image format it is, and why it wasn't detected correctly.

What I mean is if you're in the Artist field and Tab to the Album field, the previous album in that field is already highlighted, so you can simply type over it.
Oh, I get it! I thought it was Tab not going to the right control - but it is going to the right control, just not selecting all the text in it. I'll make that change for the next version.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-03-23 20:27:54
What I mean is if you're in the Artist field and Tab to the Album field, the previous album in that field is already highlighted, so you can simply type over it.
Oh, I get it! I thought it was Tab not going to the right control - but it is going to the right control, just not selecting all the text in it. I'll make that change for the next version.

Alex

Thanks, that would be much appreciated. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-24 19:21:52
AlbumArt Downloader XUI v0.15 Released

Mostly bug fixes in this release, and a couple of minor improvements that have been requested. I've also improved the reporting of x64 issues. I don't have a 64 bit copy of Windows, so no testing has been done on that platform, but the default behaviour should no longer be to crash. Instead, you should be requested to install the 64 bit version of the MediaInfo dll. The installer should also automatically detect Win64, and offer to take you to the download page for an installer for the x64 version of MediaInfo.dll that I've put together. The reason I haven't just bundled both the 32 bit and 64 bit versions of the dll in the main installer is that this dll is the largest part of the download already, and the 64 bit version is double the file size.

Also in this release I've refactored the Amazon search scripts into one common script and several optional regional variations. If you are using the installer, the you can just pick any of the regions (.com, .co.uk, .jp, etc...) to install. If you are using the zip file, then make sure amazon-common.boo is present, plus one or more of the other Amazon scripts, like amazon-com.boo, for example.

For those who are interested in scripting, these scripts now demonstrate the XUI object oriented script API of implementing the IScript interface. The amazon-common.boo script implements an abstract class which the other, minimal Amazon scripts inherit from - demonstrating one of the benefits of the object oriented approach.

List of other changes for this version:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2008-03-25 19:10:35
... I've refactored the Amazon search scripts into one common script and several optional regional variations. ... any of the regions (.com, .co.uk, ,.jp, etc...) to install...


i love you! thanks for new scripts. i was hoping you kind of look into them! THX
Title: Album Art Downloader XUI
Post by: bsleeth on 2008-03-26 03:51:37
Thank you for a great and very handy tool.

I recently found some quality images at Album Art Exchange (http://www.albumartexchange.com/covers.php)

I thought I might take a crack at writing an albumartexchange.boo script.  I figured I could use the google.boo  as a starting point, but it was not long before I realized that I have no idea what I am doing.

With the acknowledgment that every web page will present the thumbnails and images slightly different, has anyone put together a general guideline for writing a script?

To be honest, although I would like to write the script myself, unfortunately, I think even with some pointers I will not be able to get a working script.  If someone more capable has the time and thinks a new script for the Album Art Exchange site would be a good addition, I would be very interested in seeing a working script.

Thank you again for a great tool,
Brian
Title: Album Art Downloader XUI
Post by: Razzeli on 2008-03-27 18:50:51
Hi! The program crashes after I have pressed the search button. I have Vista x64 with SP1 and latest version (0.15) of Album Art XUI and Media Info x64 Upgrade. This is the log I get:


Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files (x86)\AlbumArtDownloader\errorlog.txt

App version: 0.15.0.0, running on Microsoft Windows NT 6.0.6001 Service Pack 1

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object.
  at AlbumArtDownloader.Common.MakeSafeForPath(String value)
  at AlbumArtDownloader.ArtSearchWindow.AlbumArtDefaultFilePathPatternSubstitution.Convert(Object value, Type targetType, Object parameter, CultureInfo culture)
  at System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
  at System.Windows.Data.BindingExpression.Activate(Object item)
  at System.Windows.Data.BindingExpression.AttachToContext(AttachAttempt attempt)
  at System.Windows.Data.BindingExpression.AttachOverride(DependencyObject target, DependencyProperty dp)
  at System.Windows.Data.BindingExpressionBase.Attach(DependencyObject target, DependencyProperty dp)
  at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
  at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  at System.Windows.Data.BindingOperations.SetBinding(DependencyObject target, DependencyProperty dp, BindingBase binding)
  at AlbumArtDownloader.ArtSearchWindow.BindAlbumArtDefaultFilePath(AlbumArt art)
  at AlbumArtDownloader.ArtSearchWindow.OnResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
  at System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedAction action, Object item, Int32 index)
  at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
  at System.Collections.ObjectModel.Collection`1.Add(T item)
  at AlbumArtDownloader.Sources.OnSourceResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedAction action, Object item, Int32 index)
  at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
  at System.Collections.ObjectModel.Collection`1.Add(T item)
  at AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass9.<Add>b__7()
  --- End of inner exception stack trace ---
  at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  at System.Delegate.DynamicInvokeImpl(Object[] args)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-28 19:49:15
With the acknowledgment that every web page will present the thumbnails and images slightly different, has anyone put together a general guideline for writing a script?

<snip/> a new script for the Album Art Exchange site would be a good addition, I would be very interested in seeing a working script.

As far as I know, no-one has put together any general guideline for writing a script - the idea has mostly been to grab one that works and modify it. A strong knowledge of regular expressions is a requirement, and some knowledge of .net in general is handy. If you are serious about wanting to write scripts, and need a hand with them, send me a PM and I can probably help.

Here's an albumartexchange.boo (http://www.byalexv.co.uk/foobar/albumartexchange.boo) for you, anyway. Not much selection there yet, I found, but hopefully they'll expand in the future.

Hi! The program crashes after I have pressed the search button.

Hi, thanks for reporting the crash. I'll put a guard against this into the next version, but I don't really understand why it occurred. Does it happen every time for you, or is there anything you do that makes it reliably happen?

Alex
Title: Album Art Downloader XUI
Post by: kkamion on 2008-03-28 21:13:14
Any chance of making script for this site? 

http://www.allcdcovers.com/ (http://www.allcdcovers.com/)
Title: Album Art Downloader XUI
Post by: Razzeli on 2008-03-28 22:41:59
Hi, thanks for reporting the crash. I'll put a guard against this into the next version, but I don't really understand why it occurred. Does it happen every time for you, or is there anything you do that makes it reliably happen?

Yes, it does crash everytime I press the search button, haven't found a way to fix it.
Title: Album Art Downloader XUI
Post by: emfletcher on 2008-03-31 20:53:10
This program just keeps getting better.  The file pattern matching is awesome.  The file pattern I am using is \%artist% - %album%\* which works great.  But sometimes I will have something like [1994 Remaster] or (Disc 2) after the album name.  How would I make it remove everything in parenthesis and brackets? 

Also, right now it doesn't detect my various artist albums because the folder name is just the album.  Instead of ignoring the folder when it doesn't find a -, would it be possible to make it assume it is a various artist album?  When there is no - it could just take the whole folder name as the album name and leave the artist field blank.

One more small suggestion.  Could the local files box be a different color so it is easier to find, or maybe an option to pin it always as first result.  It is hard to find the existing art mixed in with the search results, and many times you need it to compare it too.

Thanks for the great program.
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2008-03-31 22:10:22
This program just keeps getting better.  The file pattern matching is awesome.  The file pattern I am using is \%artist% - %album%\* which works great.  But sometimes I will have something like [1994 Remaster] or (Disc 2) after the album name.  How would I make it remove everything in parenthesis and brackets? 

Also, right now it doesn't detect my various artist albums because the folder name is just the album.  Instead of ignoring the folder when it doesn't find a -, would it be possible to make it assume it is a various artist album?  When there is no - it could just take the whole folder name as the album name and leave the artist field blank.

Thanks for the great program.


i dont know if youre reffering to that folder browser in albumart xui (i dont use it at all) (if so probably ignore the rest of my post ) but you should be able to handle these exceptions inside foobar by simply using complex and sometimes a bit hard titleformating.

for deteciton of "-" you could use $strstr in some kind of this trick: $if($strstr(%path%,'-'), normal, various)

for replacing parenthesis try to find some titleformating gimmick for diming them in cui and adapt these to you needs

these exceptinous shouldnt be harcoded in program for there are probably totaly different for every user, and you should be able to handle them yourself.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-03-31 23:09:00
Any chance of making script for ... http://www.allcdcovers.com/ (http://www.allcdcovers.com/)

They provide an API, which might make it interesting to do a script for. I've asked them for a developer key for it, but had no reply yet. If I get one, I'll do a script for it.

The file pattern I am using is \%artist% - %album%\* which works great.  But sometimes I will have something like [1994 Remaster] or (Disc 2) after the album name.  How would I make it remove everything in parenthesis and brackets?

The pattern matching can be made to use regular expressions by enclosing them between " marks. It does not use title formatting at all (sorry, cartman(2vd), your suggestions don't apply in this case, but thanks all the same!).

To do the match you are describing, you could try:
Code: [Select]
\%artist% - %album%"( \[.+?\])?( \(.+?\))?"\*
This will ignore the end of the album name if it is separated from the album name with a space, and is enclosed in brackets, or parenthesis, or a term in brackets followed by a space, followed by a term in parenthesis. If any of those assumptions are wrong, it may need tweaking.

Also, right now it doesn't detect my various artist albums because the folder name is just the album.  Instead of ignoring the folder when it doesn't find a -, would it be possible to make it assume it is a various artist album?  When there is no - it could just take the whole folder name as the album name and leave the artist field blank.

You could, yes:
Code: [Select]
\"("%artist% - %album%"( \[.+?\])?( \(.+?\))?|%album%)"\*
This adds an alternation that if the first pattern doesn't match, it tries a second, which is just %album%.

One more small suggestion.  Could the local files box be a different color so it is easier to find, or maybe an option to pin it always as first result.  It is hard to find the existing art mixed in with the search results, and many times you need it to compare it too.

Thanks for the suggestion; I'll see how well pinning as the first result works, and it may make it into a future version. I don't like the colouring idea, though.

Thanks for the comments,

Alex
Title: Album Art Downloader XUI
Post by: emfletcher on 2008-04-01 00:26:45
Wow.  That pattern works great.  Thanks for the fast reply.   

I just noticed that the program stops searching when it runs into a really long folder or file name.  I got this error:

Quote
Error occurred while searching: The specified path, file name, or both are too long.  The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters.


Is there any way the program could continue searching after giving the error?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-01 07:49:44
Is there any way the program could continue searching after giving the error?

Possibly. Ideally, of course, the error wouldn't occur at all, but I'm not sure whether there will be any way to work around the character limits. I'll look into it.

Alex
Title: Album Art Downloader XUI
Post by: bsleeth on 2008-04-02 16:59:08
Here's an albumartexchange.boo (http://www.byalexv.co.uk/foobar/albumartexchange.boo) for you, anyway. Not much selection there yet, I found, but hopefully they'll expand in the future.

Alex,

Wow.  Thank you very much.  Your script works great.  The script is also very clean and would make a great starting point.

Yes, AlbumArtExchange is a hit or miss site.  However if they have the cover you are looking for it is generally a quality image.

Sorry for the late reply, but I have been out of town.  Although I am (was) serious about writing the script myself, I am finding that I just do not have the time to "play".

Thank you again,
Brian
Title: Album Art Downloader XUI
Post by: katoblepa on 2008-04-05 20:42:06
Hi!
I dowloaded the program. But It crashes at the first serch. No messages. Only if I wante to send the error to Microsoft.... 

Any idea?

Thanks
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-05 21:53:00
I have MS .Net 3 and 3.5 installed on a Win XP Home SP2 PC. After installation of AlbumArtDownloader it worked well. Now - similar to above Crash every time after trying the first search. Tried to reinstall or use Non-install version, change search terms like Artist & Album - same crash no matter what.
Crash Log - see the attached file.
Title: Album Art Downloader XUI
Post by: katoblepa on 2008-04-05 22:00:11
Exatly arnymars.
I first donloaded .net 3.0 and Albumart worked well. Then I found the version based on +net3.5 and  it crashes at the first search....
Title: Album Art Downloader XUI
Post by: NogginJ on 2008-04-05 22:07:22
i did like this program. downloaded the new version, and now it crashes as soon as it opens.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.15.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.IO.FileNotFoundException: Could not load file or assembly 'System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. The system cannot find the file specified.
File name: 'System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'
   at AlbumArtDownloader.Arguments..ctor(String[] args, IEnumerable`1 valuedParameters)
   at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
   at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   at System.Windows.Application.<.ctor>b__0(Object unused)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-05 22:35:11
Oh dear, what a bunch of crashes. I'll answer them individually:

crashes at the first serch. No messages.
If the error log does not appear, then I may not be able to figure out why the crash is happening. Could you try looking in the Album Art Downloader folder (usually c:\Program Files\AlbumArtDownloader) for a file called errorlog.txt? If there is one there, please send it to me, and I'll see what I can do. If you could let me know what album and artist you were searching for, that might help too.

Crash Log - see the attached file.
Thanks for reporting this crash. You say it always occurs, whatever search terms you use? I don't really understand why this is happening, but could you try replacing your AlbumArt.exe version with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe). It should stop it crashing, or at least make it crash in a different place, which would give me a clue as to why. Please let me know either way, so I can have it fixed for the next version.

downloaded the new version, and now it crashes as soon as it opens.
Code: [Select]
System.IO.FileNotFoundException: Could not load file or assembly 'System.Core
This error means you haven't got .net framework 3.5 installed (you probably have only 3.0). Either use the installer, which automatically detects this, or just download the framework here: .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6)

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-05 23:16:16
Oh dear, what a bunch of crashes. I'll answer them individually:

Crash Log - see the attached file.
Thanks for reporting this crash. You say it always occurs, whatever search terms you use? I don't really understand why this is happening, but could you try replacing your AlbumArt.exe version with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe). It should stop it crashing, or at least make it crash in a different place, which would give me a clue as to why. Please let me know either way, so I can have it fixed for the next version.

Alex

Hi Alex,

Thanks for the excellent program! I tested the last AlbumArt.exe file of 4/5/08 a bit, and it does work. I also checked again the previous AlbumArt.exe file of 3/24/08 and found:

- when foobar2000 or your latest AlbumArt.exe file of 4/5/08 is running, the previous file version can also be launched and works great;
- when none of these 2 programs is running, the previous AlbumArt.exe crashes after the 1st search;
- when called from foobar2000 via Run Service (I'm using beautiful foo_smooth skin (http://www.neugablonz.de/index.php?seite=foobar3) and foo plugins included with it), it works great and gets the right folder to save the pictures. It would help, if AlbumArt window can close automatically after the user returns to Foobar2000 window & hits Play.

Thanks
Arny
Title: Album Art Downloader XUI
Post by: katoblepa on 2008-04-06 00:20:26
Oh dear, what a bunch of crashes. I'll answer them individually:

crashes at the first serch. No messages.
If the error log does not appear, then I may not be able to figure out why the crash is happening. Could you try looking in the Album Art Downloader folder (usually c:\Program Files\AlbumArtDownloader) for a file called errorlog.txt? If there is one there, please send it to me, and I'll see what I can do. If you could let me know what album and artist you were searching for, that might help too.

Crash Log - see the attached file.
Thanks for reporting this crash. You say it always occurs, whatever search terms you use? I don't really understand why this is happening, but could you try replacing your AlbumArt.exe version with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe). It should stop it crashing, or at least make it crash in a different place, which would give me a clue as to why. Please let me know either way, so I can have it fixed for the next version.

downloaded the new version, and now it crashes as soon as it opens.
Code: [Select]
System.IO.FileNotFoundException: Could not load file or assembly 'System.Core
This error means you haven't got .net framework 3.5 installed (you probably have only 3.0). Either use the installer, which automatically detects this, or just download the framework here: .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6)

Alex


Yes I found the error log....
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: E:\Programmi\AlbumArtDownloader\errorlog.txt

App version: 0.15.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Eccezione generata dalla destinazione di una chiamata. ---> System.NullReferenceException: Riferimento a un oggetto non impostato su un'istanza di oggetto.
   in AlbumArtDownloader.Common.MakeSafeForPath(String value)
   in AlbumArtDownloader.ArtSearchWindow.AlbumArtDefaultFilePathPatternSubstitution.Convert(Object value, Type targetType, Object parameter, CultureInfo culture)
   in System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
   in System.Windows.Data.BindingExpression.Activate(Object item)
   in System.Windows.Data.BindingExpression.AttachToContext(AttachAttempt attempt)
   in System.Windows.Data.BindingExpression.AttachOverride(DependencyObject target, DependencyProperty dp)
   in System.Windows.Data.BindingExpressionBase.OnAttach(DependencyObject d, DependencyProperty dp)
   in System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
   in System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
   in System.Windows.Data.BindingOperations.SetBinding(DependencyObject target, DependencyProperty dp, BindingBase binding)
   in AlbumArtDownloader.ArtSearchWindow.BindAlbumArtDefaultFilePath(AlbumArt art)
   in AlbumArtDownloader.ArtSearchWindow.OnResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   in System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   in System.Collections.ObjectModel.Collection`1.Add(T item)
   in AlbumArtDownloader.Sources.OnSourceResultsChanged(Object sender, NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   in System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   in System.Collections.ObjectModel.Collection`1.Add(T item)
   in AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass9.<Add>b__7()
   --- Fine dell'analisi dello stack dell'eccezione interna ---
   in System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   in System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   in System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   in System.Delegate.DynamicInvokeImpl(Object[] args)
   in System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   in System.Windows.Threading.DispatcherOperation.InvokeImpl()
   in System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   in System.Threading.ExecutionContext.runTryCode(Object userData)
   in System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   in System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   in System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   in System.Windows.Threading.DispatcherOperation.Invoke()
   in System.Windows.Threading.Dispatcher.ProcessQueue()
   in System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   in MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   in MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   in System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   in System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   in MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   in MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   in System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   in System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   in System.Windows.Threading.Dispatcher.Run()
   in System.Windows.Application.RunInternal(Window window)
   in System.Windows.Application.Run(Window window)
   in System.Windows.Application.Run()
   in AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   in AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   in AlbumArtDownloader.App.Main(String[] args)

I was looking for ABC - Abracadabra cover.With the previous version worked fine. Im starting now to use the program and I have some questions.
1) I imagine that the program can be activated from Foobar. By what menu option?
2) I syncronizing my ipod with foo-dop and it seems to work fine. How are the covers managed by ipod? Are they "loaded" as any mp4 or mp3 file? Any requirements?

Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-06 08:17:41
Thanks for the excellent program! I tested the last AlbumArt.exe file of 4/5/08 a bit, and it does work. <snip> It would help, if AlbumArt window can close automatically after the user returns to Foobar2000 window & hits Play.
That's great news! I still don't know why it happened, but I'm glad that guard I put in place seems to fix it. It will be included in the next release.

You can't have the window close automatically when you press Play in Foobar, I'm afraid, but what you can do is have it close automatically when you save an album art. The flow then goes something like: click Get Art in foobar, look at results, double click best result. The result is then saved and the search window closes. To get this auto-close behaviour, add /autoclose to your command line, or click the "Automatically close after saving" checkbox in the Options area of the search window.

Yes I found the error log....
<snip>
1) I imagine that the program can be activated from Foobar. By what menu option?
2) I syncronizing my ipod with foo-dop and it seems to work fine. How are the covers managed by ipod? Are they "loaded" as any mp4 or mp3 file? Any requirements?
It looks like you have the same crash as arnymars. Could you verify that replacing your AlbumArt.exe with this test version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe) fixes the problem?

In answer to your other questions, [a href='index.php?showtopic=45223']foo_run[/a] is generally used for launching programs like this from Foobar. For foo_dop, you should probably ask in the [a href='index.php?showtopic=45160']foo_dop thread[/a]. According to the wiki (http://yuo.be/wiki/dop:notes#about_album_art_support), it should support it.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-06 14:53:33
Click Get Art in foobar, look at results, double click best result. The result is then saved and the search window closes.

Thanks Alex!
In this case, can you modify AAD a bit, so that a single click on the Floppy Icon can Save an Album Cover without closing AAD window (allowing to add more Cover variants for the same album), but a double click  on the Cover in search results will Close AAD? And what are the naming rules for saving several Covers for the same Album to show them all in foobar2000 when the Album is placed in a Playlist?

Also, a few of other things:

-    When an Album Cover is saved by AAD, called from foobar2000 via Run service, why that Cover is not updated right away in the Playlist window, and also other foobar windows - like AlbumArt and Graphical Browser Panels and Row (I'm using Foo_Smooth (http://www.neugablonz.de/gaestebuch/index.html) Skin), and how to synch them without  restarting foobar? Would better integration btw AAD, foobar2000 and its plugins help?
-    Can you add a Prefs Option or a Link next to each Cover in search results to open the Cover source page in a default web browser? It'll help to get mote info about the Album and check the Cover match more accurately when needed;
-    While AAD Interface is clearly designed, some functionality may need clarification for novices. Is there any Help, Readme or FAQ file about AAD anywere?
-    Processor load is very high, when searching for Covers in local PC folders with AAD File Browser. Can it be optimized a bit for that operation?
- Can you add some skinning, or at least Interface color matching options to AAD, f.e. to auto or manually match its window color scheme & element appearance with current foobar2000 skin color scheme?

Thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-06 16:44:17
In this case, can you modify AAD a bit, so that a single click on the Floppy Icon can Save an Album Cover without closing AAD window (allowing to add more Cover variants for the same album), but a double click  on the Cover in search results will Close AAD?
Interesting idea. I'm not sure how intuitive that would be, but if I can think of a good way of presenting it, it might make it in to a future version.

And what are the naming rules for saving several Covers for the same Album to show them all in foobar2000 when the Album is placed in a Playlist?
There aren't any, really. I've had a long-standing idea of using a preset system so you can click a dropper arrow next to the save button to save as things like "album name - front" and "- back" and so on, but haven't got round to it yet.

When an Album Cover is saved by AAD, called from foobar2000 via Run service, why that Cover is not updated right away in the Playlist window, and also other foobar windows
I guess because they have no way of knowing to look for new art files, and don't constantly refresh themselves. Not much I can do about that, but you shouldn't have to restart foobar, the art panels should have some sort of refresh command. If they don't, try asking them for one. If an art display panel had an integrated "run cover fetching tool" command that could run an external tool, then update itself once that tool exited, then you could use AAD for that. Just pass the /separateInstance command line arg so that it doesn't re-use an existing instance, and only exits when you close it.

Can you add a Prefs Option or a Link next to each Cover in search results to open the Cover source page in a default web browser?
No. That information is not provided by the sources, and I have no intention of re-writing all of them to provide it.

While AAD Interface is clearly designed, some functionality may need clarification for novices. Is there any Help, Readme or FAQ file about AAD anywere?
There's the wiki page (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Components_0.9/AlbumArtDownloader_XUI), I guess. But no, there is no proper documentation for it, and I agree that there should be. That doesn't mean that I intend to write any any time soon, but if anyone else fancies putting some together, I'll certainly integrate it.

Processor load is very high, when searching for Covers in local PC folders with AAD File Browser. Can it be optimized a bit for that operation?
I'll look into it, but could you check if you find the same issue with using pattern matching as ID3 tag matching? It would be useful to know how much of it is due to the MediaInfo tag reading. Mostly, the file browser searching is optimised for speed, so I would expect a high processor load while it is working.

Can you add some skinning, or at least Interface color matching options to AAD, f.e. to auto or manually match its window color scheme & element appearance with current foobar2000 skin color scheme?
Automatic colour matching to foobar is never going to happen. A colour scheme 'skin' file could be a possibility, though. Any actual skin would need to be a xaml file, and would be closer to development than skinning, but if there is any real interest in this, it might be doable. If anyone is interested in designing xaml skins, the best way to start would be to grab the source off the public SVN (https://sourceforge.net/svn/?group_id=187008) and modify the xaml files there.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-06 18:22:59
Web links information is not provided by the sources, and I have no intention of re-writing all of them to provide it.

It's quite a useful feature though. People may want to look at the found by AAD Album's info on its source page, but - no way... And, I guess, a nice way to make extra money on referals to Amazon etc. to keep AAD development going. Just keep your mind open for it pls.
Quote
It would be useful to know how much of the processor load is due to the MediaInfo tag reading.

About 90% of P4 full load on file path pattern matching for a short time, and feels OK, and 75-85% with ID3 tags matching, but quite lengthy, resulting eventually in overheating & extreme fan noize when searching larger archives. Surprisingly, at idle AAD also uses variable processor power 2 to 6% continuosly. Some tweaking may help here.
Quote
An xaml colour scheme 'skin' file could be a possibility

May be just a simple way for a user to manually change in AAD Options its windows & border & text colors and font to visually match with current foobar2000 color scheme?

Again, thanks for very fast excellent program!
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-06 18:23:14
Can anyone suggest an Album Collection Editor, which can find automatically on the web and offer to the user or auto add as a Prefs Option missing info to Albums like Artist & Title or Album name, and also sort & move such Collection music files to the right Album Folders based on song names & other data.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-06 19:57:34
AlbumArt Downloader XUI v0.16 Released

Small bug fixing issue, but they seemed to be cropping up frequently, so I thought it was worth pushing out a release with the fixes in.

List of changes for this version:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-06 21:24:33
Alex,

Great news! What's Album Art Exchange Script and how to use it?

Also, would you intertain an AAD version in a form of foobar2000 Plugin - possibly for better UI and appearance integration, and auto update of foobar windows after selecting or saving new Covers found by AAD. A standalone AAD version will still be useful with other players, and may have broader functionality, like finding & adding missing Album description info, sorting & auto moving files btw Album folders, and some money making referal mechanism.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-06 22:39:45
Great news! What's Album Art Exchange Script and how to use it?
Album Art Exchange is a website that has cover art available, and the Script lets Album Art Downloader search it for covers. I'd posted the script a few days ago, after someone requested it - the change here is just to bundle it with the installer and zip file. To use it, just make sure the checkbox for it in the list of sources is checked.

Also, would you intertain an AAD version in a form of foobar2000 Plugin
No. AAD is written in C#, and has a WPF UI. Neither of these are in the least bit compatible with the foobar2000 plug-in system. I don't like C++, and have no intention of writing anything extensive in that language.

I've already outlined the only suggestion I would have for automatically updating after running an external cover fetching tool.

finding & adding missing Album description info, sorting & auto moving files btw Album folders, and some money making referal mechanism.
That's an entirely different sort of application. This is not a music manager, or organiser. This is a tool for getting artwork for albums, and it's not going to creep into becoming a music management tool. At best it could be a plug-in to a music management tool, if that tool had some sort of .net plug-in interface.

As for a money making referral mechanism, I'm not sure that there would be much point to that. Surely you only search for cover art for albums you already have, and would therefore not be buying? If the app ever becomes polished enough to warrant being called a 1.0 release (which would include proper website and documentation, at least), I've been considering adding a donate (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate) link to it, probably under the Help menu is traditional, I think.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-07 15:19:43
You only search for cover art for albums you already have

Some people may still want to open the linked to a Cover web page to clarify, if that's the exact Cover they need, and find more info about the Album. Some may have incomplete or low quality version of the Album, and may want to purchase the geniune Album upon review. Regardless of outcome, referal is paid per click, and will support AAD development. Users will be glad as well, as clicking on Cover links is a matter of choice, and adds a real convenience.

As to finding missing basic Album descriptions, I thought it may employee similar search mechanism you already have, allowing users to deal with just one application. BTW, do you have any priority system for Album Art found, in which order they are presented to the user? If you add such search accuracy prioritization (which may use Album descriptions and feels quite logical), similar sorting mechanism may possibly be applied to music collections in general. A lot of music collections are not well organized (like some of this Forum posts), so songs from the same Album may be scattered in various HD folders based on download date. Of course, it's up to you, what features to implement.

Could you explain, why AAD consumes 4 to 6% of processor power at idle? Foobar2000 seldom goes that far when playing music.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-07 16:12:58

You can't sort results by accuracy, because there isn't anything generally meaningful to test against for accuracy. The sources just return the results, there is no measure of certainty about the results they return.

I can see that linking to a web page for a cover might come in handy occasionally, but it would need every source to determine and provide an Info url for each result, and I don't think it's worth it. I don't object to the functionality in principle, though.

As for the other idea, I'll re-iterate that this tool is not, and will not become, a music organization or library management tool. I can see that such an application is a useful thing to have, but this is not that application. It could be an external tool or plugin used by one for finding art, though.

I'm not sure why you are getting 5% CPU utilisation when it isn't doing anything. It's pegged at 0 on my machine here, but then my CPU is a bit faster than a P4, so I guess it might just be that the utilisation isn't high enough to register, without actually being 0. Without being able to measure the effect, I can't do much about it. There are no background threads or tasks running (until a search or browse is performed, of course), so there aren't even any specific areas to look at.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-07 23:27:03
I'm not sure why you are getting 5% CPU utilisation when it isn't doing anything. It's pegged at 0 on my machine here.

After downloading search results AAD uses 15 to 26% P4 capacity continuosly without visibly doing anything - see the attached screenshoot archive. It looks like fixable unnessessary .Net 3.5 WPF related activity.

Is it related to below quote from http://en.wikipedia.org/wiki/Windows_Presentation_Foundation (http://en.wikipedia.org/wiki/Windows_Presentation_Foundation) or something different:
"Periodically, MIL walks the tree and executes the rendering instructions in each node, thus compositing each element on to a DirectX surface, which is then rendered on screen. ..Microsoft recommends that the event handlers only update the properties to reflect new content for application responsiveness; the new content be generated or retrieved in a background thread."
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-08 08:26:05
the new content be generated or retrieved in a background thread."
This is already the way Album Art Downloader is architected. You can tell by the way the application UI stays responsive while it is searching and downloading images. The responsiveness talked about in the Microsoft article linked to from the Wikipedia article you mentioned refers to the responsiveness of the UI - making sure that while content is generated or retrieved the buttons and controls still work, and nothing locks up. It has nothing to do with CPU utilisation, other than if it were pegged at 100% that would probably impact responsiveness a bit!

Neither WPF, nor, by extension, Album Art Downloader, have CPU utilisation as a primary concern. If there is a bug or problem that it is doing unnecessary work when it shouldn't be, or stuck in some sort of loop, I will try and fix that, but when there is no non-framework code running (and I have checked that at idle, AAD is running no code), there is nothing to fix.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-09 15:18:01
There is nothing to fix.

Alex, did you look at the screenshoot files on AAD CPU usage at idle I attached above? How do you explain these results? What are these linked to AAD processes continuosly running in the background using 10% + 15% CPU after 20+ Album Covers were found and the search stoped? Do you still say, after looking at the Sysinternals Process Explorer documented pics, AAD uses 0% CPU at idle? How about 25% of P4 continuosly after an extensive Cover search. And foobar2000 was designed for and works well with minor CPU usage with even P2 PCs.

In addition, when I started AAD yesterday while foobar was playing, intence CPU & power usage resulted in my MS USB Wireless Desktop Receiver been kicked off, and no longer recognized by the PC, so I lost both Keyboard and Mouse. It may well be a bug in .Net 3.5, or just insufficient resulting voltage on the USB port due to a weak (fearly standard) Power Supply, but the worst thing is - there seems to be no XP driver found anywere for the Receiver 3.1, so major Registry cleanups & reinstalls are due now, and there is no guarantee, its not damaged permanently, as its recognized now as Unknown Device, no matter what I do.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-09 16:03:08

Yes, I looked at your screenshots. No, I don't have any specific explanation of them. All I can tell you is that once all the sources have finished searching, and all the images are downloaded (including full sized, if you have that option turned on), and assuming the mouse is outside the window area, then Album Art Downloader is doing absolutely nothing. That is why there is nothing to fix. It isn't doing anything, no code is running. I can't fix code that isn't there.

If the WPF rendering system, or the garbage collector, any other subsytem of the .net framework or anything even further down is doing other work, that's not going to get fixed by me.

I am aware that foobar2000 uses very little CPU, which is is a very useful goal for an application whose purpose is to be continually running in the background without impacting system performance, and the way they have achieved it is to be admired. Album Art Downloader has different goals and priorities. If a primary goal of an application was minimal CPU and resource usage, I wouldn't write it in WPF, for a start!

I'm sorry to hear about your mouse. If your hardware is so unstable that using a high percentage of CPU is enough to break it, then that is a serious problem. It's only be a matter of time before some poorly written application or javascript hits an infinite loop and you get CPU pegged at 100% until you kill the process! It would seem unlikely that anything short of a major mains power spike would damage a USB wireless receiver - and would probably fry the motherboard on its way, so my guess would be you are all right there. Good luck with getting the driver for it.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-10 04:44:01
my guess would be you are all right there. Good luck with getting the driver for it.

Alex
Just to let you know - the wireless tranceiver is dead, confirmed by MS today. It's under warranty though. Regardless, another guy may not be so lucky. I'd suggest you to investigate thoroughthly with MS help, what exactly is going on at idle with your program instead of a flat denial. There should be a processor usage restriction Option when searching through local ID3 Tags, otherwise the fan circuit may fry and PC end up dead. I just checked - its running up to 25% P4 at idle after a start without search terms.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-10 08:11:46
the wireless tranceiver is dead, confirmed by MS today
Shame, unlucky. As you seem to be implying that this is somehow my fault, let me make one thing absolutely clear. Using CPU is not a fault. If your PC cannot tolerate having the CPU running at high loads without dying, *your PC has a fault*.

While it may be of benefit to all if MS were to optimise and reduce the resource usage of WPF, and I hope they have a team working on exactly that, it is nothing to do with me. I am prepared to investigate and resolve faults in my own code, but draw the line at other people's.

If you want to restrict processor usage, try bringing up Task Manager, click the Processes tab, find AlbumArt.exe in the list of processes, right click on it and choose "Set Priority", then "Low". Although I suspect that if nothing else is wanting to use the CPU at the same time, Windows will still assign it a high load anyway - CPU is there to be used, after all.

If it is constantly running at 24% CPU after starting before doing anything other than showing the main window, something has probably gone wrong. I would suggest removing it and the .net framework, then re-installing both, but suspect that you may prefer to stop at step 1.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2008-04-10 19:02:28
If it is constantly running at 24% CPU after starting before doing anything other than showing the main window, something has probably gone wrong.
Not sure if this is a request for more information, anyway...

I also have a similar problem with AAD XUI.

I use it almost exclusively through foo_run (searching one album for each request - all sources selected except Local files and Trivialbeing) and usually after 2 or 3 searches it hogs my CPU at 100% and I have to stop it.

AAD is still responsive (for example, it works if I run another search) but I obviously can't do much with my PC in these conditions.

Note that the high load is there also when AAD isn't (apparently?) searching; I also just tried to open AAD (currently using v0.15.0.0) from Win Explorer and it's using from 30 to 40% of the CPU (as reported by Win Task Manager).

I didn't bother to mention it before because I thought (and I still think) my setup (Celeron 2.4 with 512MB of RAM) isn't exactly the ideal configuration for the .Net framework; nevertheless, maybe something can be done on your side to at least ease, if not solve, the issue.

Regards and thanks for your time.

Alessandro
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-10 19:29:55
I notice this problem, too and it's quite troubling (it might be the fault of WPF) that you said you have checked everything on your side. Here's an image showing AAD XUI 0.16.0.0 when it's just started with no query.
(http://img357.imageshack.us/img357/8151/26696900kg9.th.jpg) (http://img357.imageshack.us/my.php?image=26696900kg9.jpg)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-10 21:32:24
I use it almost exclusively through foo_run (searching one album for each request - all sources selected except Local files and Trivialbeing) and usually after 2 or 3 searches it hogs my CPU at 100% and I have to stop it.

Now that's interesting - are you saying each time you exit Album Art Downloader and start a new instance of it, it uses more CPU? Very curious... Other than the very first time it is run and compiles the scripts, there shouldn't be any difference whether it has been run before or not.

I don't suppose any of you experiencing this problem have a development environment (Visual Studio 2008) available by any chance?

Some things to try:

1) Make sure AAD is not running. Probably best to restart windows, if some strange memory effect between runs is happening, so it is completely clear. Then, run AAD with the "/separateInstance" command arg, and see if it exhibits the same behaviour, and same memory effect between runs.

2) Enable tracing using this config file: AlbumArt.exe.config (http://www.byalexv.co.uk/temp/AlbumArt.exe.config) - put it in your AAD program folder next to AlbumArt.exe. Without doing any searches, leave AAD running for a bit, then close it, and have a look to see if there is anything in the trace log (which will be called tracelog.txt), or send it to me to look at.

I'm still not convinced there will be anything that can be done about this, though. Thuan, could you let me know what CPU and memory you have? It would be useful to know if this is a problem for anyone on a reasonably high spec machine, say Core2 with 1Gb of RAM or upwards.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2008-04-10 23:20:24
are you saying each time you exit Album Art Downloader and start a new instance of it, it uses more CPU?
Not exactly, sorry for not being clear. Actually after the first search I do NOT close AAD, I simply go back to foobar2000 and launch another search (which displays its results in the already running AAD instance).
Quote
I don't suppose any of you experiencing this problem have a development environment (Visual Studio 2008) available by any chance?
Nope, sorry, but I'm willing to try if you think it may help (provided you give me some guidance and my PC has enough power for that).
Quote
run AAD with the "/separateInstance" command arg, and see if it exhibits the same behaviour, and same memory effect between runs.
1) first run: AAD CPU between 19 and 27
2) run 2nd instance with same command arg without closing the first: both tasks between 27 and 33
3) closed 2nd instance: first instance back to initial values
4) closed first instance and run one more time: no difference
Quote
2) Enable tracing using this config file
It only contains the following line:

AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.15.0.0

Even after a reboot I'm unable to reproduce the high load reported in my previous post: now running AAD without doing any search only consumes 20 - 30% of my CPU.

One more clue perhaps; if I minimize AAD its CPU usage goes down to 5 - 8%.

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-11 03:15:06
Then I guess this computer is suffice, it's a Core 2 4300 1.8GHz, 3GB of RAM, ATI HD2400XT, running Vista SP1 and everything is up to date. I have never noticed this before as I haven't actually taken a look at those monitor software when using AAD and my computer is fast enough to feel nothing. Usability wise I don't really care, but it should indeed be checked IMHO. BTW IIRC, when I reported the freeze problems before, there's no CPU usage with ghost instances.
I don't code on VS so of course I don't have it. I wonder if there's a VS2008 express as of now and if it is sufficient to work on AAD. If so I can install it.

EDIT: atiumdag.dll is ATI directx universal driver (this makes me think it's a redrawn issue). Also this program also load DXVA dll of my graphic card and some other DirectX dlls that normal Windows program doesn't load. Is this because it's a WPF program? I don't know much about .NET desktop application.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-11 10:22:28
AlbumArt.exe Information: 0 : Successfully read application version from settings: 0.15.0.0

Hmm... can you confirm you are running version 0.15, not 0.16 then?

The fact that nothing else appears in the log suggests that AAD itself is not doing anything unexpected, which unfortunately doesn't give me a target to fix.

The /separateInstance test indicates that the problem is not with the cross-process communication pipe, but as I'd misunderstood mobyduck's report this was much less likely anyway.

What is interesting is the minimising thing. That would strongly suggest that the CPU usage is coming from WPF rendering.

Thuan's system specs indicate that this is nothing to do with CPU or memory limitations, but do point to this being a WPF rendering issue.

WPF does use hardware acceleration for rendering itself, falling back on software rendering where necessary, which would explain why it is loading the DirectX dlls thuan mentioned.

I think there is no need to look at it in Visual Studio now, as I'm confident we've narrowed down the problem to the WPF rendering. My idea would have been to run under the debugger, then see if any code was actually running while the CPU usage was up, but I'm pretty sure there won't be, as the CPU usage will just be from the WPF rendering. You are, of course, welcome to try anyway, the source can be downloaded from the "XUI" subfolder of the SVN tree (https://sourceforge.net/svn/?group_id=187008).

Thanks for the information,

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-11 17:11:48
The fact that nothing else appears in the log suggests that AAD itself is not doing anything unexpected, which unfortunately doesn't give me a target to fix.

The point however remains:

- most developers take care of their customers by NOT-IMPLEMENTING MS latest software releases until they are relatively bug free with fixes available. Large pull of foobar2000 fans would be just as happy with AAD based on .Net 2.0 or 3.0, if it doesn't cripple their low end PCs;

- When searching local files with AAD File Browser using ID3 Tags, a "Work in Background" OR "Limit CPU Usage" option in AAD Prefs would prevent a low end PC from being fried or hanged on searching large music archives, and feels like a mandatory option to avoid client liability. So far AAD doesn't even have a proper warning in Readme about this gream reality.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-11 17:48:45

OK, a few points to answer here.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-11 18:19:29
I'm not really that concerned about what other different software people might want.

It's not about new features users may suggest - and normally developers say "Thank you" for those. It's about safety of using your program. Basically you say - use it on a high end PC if you want, or don't use at all. AAD will control user's PC experience, and not the other way around. Stop AAD, when you feel your PC is about to fry when you hear extreme fan noize.

Would it be more reasonable to allow USER to choose still run AAD but at slower pace by adding such option in Prefs?

There is nothing personal here. As I said, I like your program. All foobar plugins & extras are some kind of creativity & experience gain & Resume improvement exersize. But most developers are smart enough to still care about those who are supposed to use their fruit. Otherwise - the outcome may be just opposite.
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-11 18:52:33
Stop AAD, when you feel your PC is about to fry when you hear extreme fan noize.

It is your reponsibility to provide your computer with adequate cooling system. You will run into trouble sooner or later anyway if you keep your computer that way.

Would it be more reasonable to allow USER to choose still run AAD but at slower pace by adding such option in Prefs?

Yeah, he might do it, or he might not. If he won't then stop pestering him. But to be honest, if your computer satisfy point above then is this really important.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-11 18:56:46

Oh, I'm happy for feature suggestions, bug reports, and other comments, and am grateful for those received. Many feature suggestions that have been made in this thread have been implemented, and all bug reports have been addressed. Where something is not a feature suggestion, but is instead a suggestion for an entirely different piece of software, I have said so.

For the final time, and I won't bother saying it again: using high CPU load to performing a task quickly is not unsafe, or even undesirable. If your PC has extreme fan noise or overheating problems at high CPU loads, then you need to fix your PC.

No software that I am aware of, except some of those designed to run continuously in the background, offers the user the option to have it perform slowly, and I see no reason that this software should be different.

I never said that you have to use AAD on a high end PC, or not at all. Obviously, if you do, it will run better, though. I'm not sure what the minimum specs for running it are. If anyone wants to list here (or PM me) the lowest specced machine they've run it on and, whether they consider it to be usable on it, I'll collate the results and put a minimum recommended spec to the first post and wiki page. CPU, Memory and Graphics Card will be the biggest factors, so if you are going to send me a spec, please include those details.

Alex
Title: Album Art Downloader XUI
Post by: Mondo on 2008-04-11 20:29:05
i'm running a 2.17ghz amd athlon with 512MB of ram and the program is almost completely unusable. it opens up at about 30MB of memory and escalates from there until it gets into 400+MB 10 seconds later. interface is almost completely unresponsive, usually i click something and sit there hoping my mouse click went through. i know my computer is pretty outdated, but is the program supposed to be using this much memory? if so, i'd say a minimum at 1gb of memory is pretty safe to put on your site.
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-11 21:20:01
It is your reponsibility to provide your computer with adequate cooling system.

This is NOT a really old Win98 PC, like many foobar2000 users still enjou playing music on. If it were a self-assembled box modded by a clueless teen, I wouldn't even mention this problem.

I am running AAD on a stock non-modified huge production volume Medion PC: P4 2.66 Mgz, NVIDIA Ti4, 512 Mb, Win XP SP2. It's somewhat outdated, but hopefully correctly balance-engineered and still adequate for most home user's tasks except for some HD Video Playback & Editing. It's definitely adequate for Audio Playback, and should be sufficient for related MINOR service tasks like an Album Cover search. Such service programs should be correctly designed to not interfere with the prime task of Music Playback enjoument or become a safety or property loss hazard. In fact, same System Requirements or User adjustment options are expected to harmonize it with foobar2000 and other players.

And to be fully objective, some AAD behaviour may be a result of MS .Net code bugs, but other - resulting from limited developer knowledge of new .Net functions. Communication with MS developer teams - and there are many ways for that, including MS programmers' blogs - can help more in alleviating the issues found in beta testing like this then simply flat denials to improve the program.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-11 21:53:21
P4 2.66 Mgz, NVIDIA Ti4, 512 Mb, Win XP SP2
Thanks, arnymars - would you like me to note those down as 'barely usable' or 'unusable'?

2.17ghz amd athlon with 512MB of ram and the program is almost completely unusable.
Thanks, Mondo - could you tell your graphics card too, if you know it?

is the program supposed to be using this much memory?
Memory usage is very hard to measure properly for .net apps, as the framework will tend to only release it when something else needs it. As a very rough guide, my figures are that AAD, with all bundled scripts present, should use up to about 40Mb at startup, and be stable at that figure until a search is performed. Each additional open (empty) search or browse window adds about 2Mb.

After searching, it will use an additional 1Mb or so for each displayed thumbnail, plus a small amount for each result not within view. As a thumbnail is scrolled out of view, the memory used by it is reclaimed, so although memory usage will spike while scrolling, it should settle back down once only the a few thumbnails are visible again.

For each full size image downloaded (of which there may be several if the "download full size images automatically", add on around 10-20Mb, depending on the size of the image. This is reclaimed when the search window is closed, or the results discarded by a new search being performed in that window.

With that in mind, your opening figure of 30Mb is entirely within expectation (better than I see here, in fact). 400Mb is higher than I would expect, but I suppose is possible depending on the number of open search windows, number of thumbnails displayed, and number of full size images downloaded.

If you have only 512Mb of memory, I would recommend deselecting all but your favourite one or two sources, and set those to return only 3 or 4 results each, and turning off any automatic downloading of full size images. Your memory usage should then be far more manageable, and if you don't find a good art result for a search with those settings, you can always select additional sources for that particular search, and just click Search again to search those too.

For anyone who finds their system is not up to the task of running the Album Art Downloader XUI ui (or who finds that the UI is too bloated and takes up too much of their resources, if you prefer), then you might like to consider using the command line interface, aad.exe. You won't be able to pick a cover from a list of thumbnail previews, or scan media files for missing artwork, but it will perform the basic service task of finding and fetching a cover without using much CPU or memory. It is best suited to being called as an external tool by another program, like foobar's foo_run.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-04-11 23:31:16
FWIW, the program uses a fair amount of CPU here (~20%) when open, but idle.  However, when minimized, the CPU usage all but disappears.

Memory usage is more than what I would think (~23K), but no big deal on a modern computer.

This is not the type of program to leave running, so I honestly don't see the problem.  Just close it when you're done. 
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-12 02:56:47
@Alex: I'm thinking that is it possible to deactivate refresh on certain UI control in WPF?

@arnymars: Likely you have a Prescott CPU, I have seen ppl try to use it to cook omelet so it's not surprising (a better choice at the time you bought your computer is one with Athlon XP or better Athlon 64 single core which beat this CPU hand down). Both the intel fan and heatsink come with this CPU iteration and a lot of brand name computers do not have sufficient cooling systems for it (CPU automatic throttles down and extreme fan noise). You're better off with an after market heatsink and fan if it's possible to install them (certain brand name computer makes it impossible to do this). This is why I always self-assemble my box as I have a freedom to choose good components that last me long with a stable computer. In any case, if you have enough knowledge on computer parts and building your own computer is possible (not in the case building thousand of computers for your office which is impossible to assemble on your own), a self-assembled box is infinitely better than any brand name box whether the invidual is a teen or not IMHO. As far as serious .NET application out there, most of them you will need to have 1GB or above to run them adequately.

EDIT: arnymars, forgot to tell you this, likely this is the last time we should talk about it. No need to beat a dead horse to dead anymore.
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-12 06:33:37
this is the last time we should talk about it. No need to beat a dead horse to dead anymore.

My dear, if you believe Forum Rules were violated, you are free to ask the thread moderator to take action. Otherwise, pls don't tell others what to do. Some people may consider just opposite - continuosly alert users about possible damage to their PCs from using this soft. Whether you consider this program adequate or not to fit mass market PCs, and in harmony with foobar2000 in system resources use - you are free and welcome to express your opinion. Beyond that - usually people give advice when they are asked to.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-12 08:37:29
Possible fix for CPU usage while idle: AlbumArtDownloaderXUI-test_cpu_fix.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix.zip).

Could someone who's experiencing CPU usage while idle please try extracting the contents of the above zip over their AAD program folder and letting me know if it has made any difference? My profiling tools say that it theoretically ought to.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-04-12 09:18:40
Possible fix for CPU usage while idle: AlbumArtDownloaderXUI-test_cpu_fix.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix.zip).

Could someone who's experiencing CPU usage while idle please try extracting the contents of the above zip over their AAD program folder and letting me know if it has made any difference? My profiling tools say that it theoretically ought to.

Works for me!  It now pretty much stays on 00, occasionally jumping to 01.  That's with it open, but idle.  I said before that caused about ~20% usage, but I tested it again before copying these files over, and it actually was jumping all over the place, sometimes into the 30s.  20% probably was about average, but it was hard to tell, because it was changing so much.

Thanks (again) for your efforts!
Title: Album Art Downloader XUI
Post by: Mondo on 2008-04-12 09:19:46
i will give that a test tomorrow. i just wanted to chime in to say that if i run this at low priority level it responds how i imagine it should and memory sits around 100MB.
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-04-12 09:38:15
To add to what I reported earlier, after doing a search of a pretty popular album, with all search engines selected, CPU usage again jumps all over the place, as high as into the 30s, even after minimizing.

Just to reiterate, the old version did that even before searching (at least while open - minimizing mostly eliminated it).  The new version uses virtually no CPU even while open, prior to searching.

So it looks like you're on the right track, but in some ways it's worse now (since minimizing no longer helps).

Not complaining;  just reporting.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-12 09:59:47
To add to what I reported earlier, after doing a search of a pretty popular album, with all search engines selected, CPU usage again jumps all over the place, as high as into the 30s, even after minimizing.
Sorry, but just to be clear, do you mean while it is actually searching, or that it stays high after the search completes? (the Stop All link will disappear once all sources have finished searching)

During searching, the CPU usage is expected, but if it is then staying there after the search completes, I'll investigate further.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-04-12 10:49:42
Hi Alex,

I have been enjoying this amazing development of AAD XUI.

I have a couple of feature suggestions to increase the quality of the artwork that's downloaded using AAD command line.

/minRes
/squareFactor

Note: These option names are for demonstration only.

For example:

/minRes 600

would filter results to artwork with only Width >= 600 or Height >= 600
So either Width or Height should meet minimum dimensions.

/squareFactor 0.9

could make sure Width is almost close to Height.

squareFactor can be described as smaller dimension divided by the bigger dimension.

If the artwork is 600x593 thne the squareFactor for the artwork is 0.98833333 which is higher than 0.9 (almost square) so this can be included

If the artwork is 403x600 then the squareFactor for the artwork is 0.67166 which is less than 0.9 (not close to a square) so this will be excluded from the results.

squareFactor 1.0 is a perfect square: 500x500, 600x600 etc.

My expectation for AAD to have

Code: [Select]
aad.exe /artist "Artist Name" /album "Album Name" /minRes 600 /squareFactor 0.9


so AAD could filter results to artwork with Width or Height at least 600px and Square Factor at least 0.9

Best Regards,
McoreD
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-12 11:54:47
I have a couple of feature suggestions to increase the quality of the artwork that's downloaded using AAD command line.

/minRes
/squareFactor

Thanks for the suggestions. /minRes already exists, but I called it /minSize. It behaves the way you described, though.

/squareFactor sounds like a good idea, I'll probably put that in the next version.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-12 11:57:53
I have the same result as KarnEvil9, virtually no CPU usage when open AAD and do nothing. But after doing a search and finish, it is again has CPU usage like before in the picture in one of my previous post.

I have a bunch of computers beside my main computer over here:
Athlon X2 4200+ 1GB Vista SP1 using onboard nvidia 6100;
a laptop with 1.7GHz Dothan Pentium M with 512 MB running XPSP2 with 945G onboard graphic;
a T7200 laptop with 2GB RAM Vista SP1 and onboard 965G
all of them run this program adequately. I have a P3 550 256MB RAM with XP on it, too. But I guess I don't need to test this program on it.

@arnymars:
What I meant by that is: if I can not convince you to change your point of view then it'll be pointless to continue talking. I was naive thinking that you would understand as you still kept your false assumption on this software and how a computer should work from my point of view. I'm sorry that my kindness and advice was unaccounted for and directed at the wrong person or any inconveniences that my posts directed to you have caused. Anyway, I will stop talking to you on this case, don't worry and peace.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-12 13:25:12
I have the same result as KarnEvil9, virtually no CPU usage when open AAD and do nothing. But after doing a search and finish, it is again has CPU usage like before in the picture in one of my previous post.

OK, so I'm on the right track then, but not quite there. Try this one: AlbumArtDownloaderXUI-test_cpu_fix_2.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix_2.zip).

Thanks also for the information on your PCs. The one I find particularly interesting is the Pentium M laptop. The Dothan Pentium M is roughly equivalent in performance to a good P4, I believe (correct me if I'm wrong), and 512Mb would seem to me like a sensible lower limit. I can only assume that if it is running OK on that laptop, but unusable on Mondo's Athlon or anymars' P4 (both also at 512Mb), it's probably down to how much work WPF can offload on to the GPU. I don't really have any experience with the Intel onboard graphics - would you say the 945G was a reasonably good graphics chipset, or more entry-level? anymars is running a GeForce 4, which I don't think support DX9 - which means WPF would have to do most, if not all, of the rendering work in the CPU instead. I can see how that would make a difference.

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-04-12 13:27:51
Thanks for the suggestions. /minRes already exists, but I called it /minSize. It behaves the way you described, though.

/squareFactor sounds like a good idea, I'll probably put that in the next version.

Alex


Oops.. my bad:

Quote
/minSize    Specifies the minimum size of  (/minSize 300)
              image, in pixels, to use.
              Both horizontal and vertical
              dimensions must conform.
              May be abbreviated to /mn      (/mn 300)


I thought it was fileSize. 

That's GREAT news Alex. Thanks for the fast response! 

Cheers,
McoreD
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-12 14:54:26
Alex,

I tested this fix, and it looks very promizing. First AAD window, when open without search terms from within or outside of foobar, draws no CPU resources continuosly whatsoever. When opened with search terms, it stops drawing the resources soon after the search is completed. However, each additional open AAD instance continues drawing CPU resources at 1.5% periodically indefinitely whether empty or showing Search results, while it's active window on the screen. Once passive (you switch to a different program or AAD window), it appears to stop drawing the resources. If none of AAD instances is active on the screen, they all total to 1.5% but only seldom. It's almost perfect in this aspect now, but I feel can be polished a bit. If you are kind enough to give a user without new or any Graphics Card a bit more control over AAD habits in ID3 Tag local search, it will really solve whole this issue for all (as opposed to attempts of simply shutting up users on the forum).

thuan,

I do tend to assemble my own PCs, but also use stock PCs, depending on purpose. I'm well aware of deficiencies of price designed PCs, and CPUs of various generations, even without overclocking. However, this whole "weak PC" issue is irrelevant here, since in my view programs advertized as foobar plugins or helpers should adhere to foobar System Requirements. As well, any program can be improved, as we all know, and bug reports are merely encouragement for this. And on top of this, AAD is a good program.
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-12 15:22:35
Sorry, I was wrong that laptop has a 915G, my main computer is the one that has 945G (but I use a dedicated card now). The 915G and 945G are nearly identical just different in clock speed and different vertex shader versions that they support. 945G supports vertex shader 3.0 (915G supports version 2) and a little more powerful in term of raw power as it has higher core clock. They both do not have support for vertex shader and HW T&L in HW that a GF2/4MX or higher have. Performace wise they are POS to be honest, should be lower than a GF4MX440 a DX7 class card even though they are DX9 capable. As for the CPU, yes you're right it should be as powerful as a good P4.
Performance of AAD on this system is of course not as fast as my main computer and the T7200 laptop but still acceptable IMO. On the Athlon X2, it is not much different from my main computer and the T7200, maybe because I haven't used up all of my RAM yet and the CPU is roughly about the same in power.

Also, I have a long standing problem with your program that I told you some time ago, but it seems like you forgot. If I launch a search then another right after and turn off the first one, the 2nd instance (not really as you only have one process) sometimes freezes. This also happens when there're more than 2 windows, if I close one of old ones the newer ones will randomly freeze. It might unfreeze if there's some change in the UI though.

I have tested your new build it's still the same as the previous test build.

EDIT: somehow I kept getting the old binary however I tried, can you rename the zip?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-12 15:57:35
Also, I have a long standing problem with your program that I told you some time ago, but it seems like you forgot. If I launch a search then another right after and turn off the first one, the 2nd instance (not really as you only have one process) sometimes freezes. This also happens when there're more than 2 windows, if I close one of old ones the newer ones will randomly freeze. It might unfreeze if there's some change in the UI though.
Is [a href='index.php?act=findpost&pid=549182']this[/a] the problem you mean? I thought I'd fixed that in 0.14, but it doesn't seem to match your new description exactly. If it's a different problem you are describing, that you reported to me and I failed to acknowledge, then I apologise for missing it. I'll see if I can reproduce it from the description you've given here, but if there are any other details from the original report, please pass those on again.

EDIT: somehow I kept getting the old binary however I tried, can you rename the zip?
OK, it's now AlbumArtDownloaderXUI-test_cpu_fix_2.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_cpu_fix_2.zip) (AlbumArt.exe inside should have a modified timestamp of 2008-04-12 13:00).

However, each additional open AAD instance continues drawing CPU resources at 1.5% periodically indefinitely whether empty or showing Search results, while it's active window on the screen.
If I've understood right, you run AAD, and it's fine. After completing a search, it's fine. Opening a new search window (through the menu?) results in low, but non-zero CPU usage while the new window has the focus? Does closing the new window return usage to zero? I haven't been able to isolate this case in my profiler tool.

I'll see if I can put together a test build that drops the priority of the file browser search to background when the file browser window is minimised (which will also avoid CPU usage rendering the results as they come in), and you can let me know if it makes enough difference to CPU usage to be worthwhile.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2008-04-12 16:27:39
Great job Alex!

All my problems seem solved with zip #2.

When I launch AAD CPU stays at 0-3%; I also tried 3 or 4 searches through foo_run and CPU usage is back to 0 when the search is over (and I have the impression AAD uses less resources than before also when seeking, though I'm not really sure).

Case closed for me.

Alessandro
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-12 16:28:05
I reported the freeze problem in this post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=549175), the last paragraph. There's nothing more I can say about it though.

About the CPU fix, it really is still the same as the previous one for me.

EDIT: update on the CPU usage problem, it's good on the XP Dothan laptop and not on my main Vista machine (the one with ATI card) whether Aero is on or off. I will try to test the other machines when I can. The T7200 laptop is doing something and that AMD machine is currently in used by other.
Title: Album Art Downloader XUI
Post by: Mondo on 2008-04-12 18:31:19
update seems to fix the problems. memory usage still sits at about 200M even after doing a few searches and closing all the search windows to just have the file browser open. i suppose running it through foobar would help.. i just need to learn how to do it.
definitely a solid update though!! i've been using it for about an hour now without it really inhibiting my progress at all.
oh yeah, my graphics card is an ati radeon 9600.
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-12 22:33:50
Opening a new search window (through the menu?) results in low, but non-zero CPU usage while the new window has the focus?

It looks, like any AAD Search window in focus or visible on screen (unobstructed), even a single open one, whether with or without search results, whether open from AAD menu, foobar or Win Explorer, draws 1.5% every 2-3 sec indefinitely without mouse over activity. With more AAD windows open, and one still in focus & several (partially) visible, frequency of CPU usage increases, while staying at 1.5% and slowly going to 1.5-3+% with 6 AAD windows open, no mouse over. Once all windows are out of focus and fully covered by another program window (but not minimized), AAD draws 0% CPU total regardless of number of windows with or withour search results. In focus File or Foobar Browser windows don't draw CPU at all. It all looks like standard intelligent WPF routing, but may possibly be further minimized.

Timely memory release may be another issue to look at. If done correctly, it should be covered by .Net 3.5. "As long as there exists a reference to an object, which might be either a direct reference to an object or via a graph of objects, the object is considered to be in use by the CLR. When there is no reference to an object, and thus cannot be reached or used, it becomes garbage. However, it still holds on to the memory allocated to it. .NET Framework includes a garbage collector which runs periodically, on a separate thread than the application's thread, that enumerates all the unusable objects and reclaims the memory allocated to them."

As to opening windows minimized, as done in this test build, this option is traditionally reserved for a user in Prefs, and not everyone likes it, as AAD performs some entertainment function as well, complementing foobar in that, so attractiveness - nice Covers apear from nowhere - and immediate visual access to Covers feel important.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-12 23:08:16
I reported the freeze problem in this post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=549175), the last paragraph. There's nothing more I can say about it though.
Can you tell me if the old windows that you close have currently running searches, or if closing idle windows has the same effect? If it is closing currently running searches, I have added a possible fix for it to Test Build 3 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_3.zip).

It looks, like any AAD Search window in focus or visible on screen (unobstructed), even a single open one, whether with or without search results, whether open from AAD menu, foobar or Win Explorer, draws 1.5% every 2-3 sec indefinitely without mouse over activity.
Could you use the tab key to move focus out of the text boxes (for example on to the search button), then leave the mouse outside the window check to see if it is the same? The profiler is telling me that the only area being redrawn on an empty idle AAD search window now is flashing the text-insertion caret in the textbox. I've got to say, it seems unlikely that this will be using 1.5% CPU, but after that, I'm out of ideas.

Timely memory release may be another issue to look at.
Can you be more specific about where? I had a memory leak hunting session at around version 0.7, and while I'm sure the major ones are still plugged (closing a window or clearing search results releases the memory used), there might be minor ones I've missed. I've had a look at the usual suspects, though, and everything seems to be being released when it should be.

As to opening windows minimized, as done in this test build, this option is traditionally reserved for a user in Prefs
I'm not set on using that as a UI mechanism yet. If low-priority file tag scanning goes in at all, there will be some way of indicating that this particular operation should be treated as a background task to run at a low priority (rather than a more general global option). For the moment, minimising the window indicates that it should work in the background. Windows will never be automatically minimised or opened minimised - that will always be a user-initiated action.

Test Build 3 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_3.zip) sets the file scanning thread to low priority while the file browser is minimised. Could you try running it and let me know if that reduces the CPU load significantly for you? It doesn't for me, but then it only runs at about 50-60% CPU here anyway, so there's another 40% or so idle CPU time available for other normal-priority threads before it would take share away from the low priority ones anyway.

Alex
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-13 00:37:11
Alex, I think you exactly right about the cursor - removing it from the window in focus lives AAD with 0% CPU usage regardless of the number of visible windows with or without search results. Still it looks like WPF overhead, for a cursor to draw 1.5-3% CPU every 2 sec. But this problem seems to be resolved.

Can this Mondo's RAM & CPU report help: "i'm running a 2.17ghz amd athlon with 512MB of ram and the program is almost completely unusable. it opens up at about 30MB of memory and escalates from there until it gets into 400+MB 10 seconds later. interface is almost completely unresponsive, usually i click something and sit there hoping my mouse click went through. i know my computer is pretty outdated, but is the program supposed to be using this much memory?". "Memory usage still sits at about 200M even after doing a few searches and closing all the search windows to just have the file browser open". " if i run this at low priority level it responds how i imagine it should and memory sits around 100MB" ?
I'll try to do more tests a bit later.

Pointers Wiki (http://en.wikipedia.org/wiki/Data_pointer)
Memory Management Reference (http://www.memorymanagement.org/)
.NET Framework Developer's Guide - Garbage Collection (http://msdn2.microsoft.com/en-us/library/0xy59wtx.aspx)
Garbage Collection FAQ (http://www.iecc.com/gclist/GC-faq.html)

I'm afraid, "low priority" search won't do much (http://xona.com/2004/07/22.html) from heat standpoint, if there are no other programs running (foobar excluded as it draws very little), so some kind of Application (http://msdn2.microsoft.com/en-us/library/ms998530.aspx) & Resource Throttling (http://msdn2.microsoft.com/en-us/library/ms998544.aspx) approach is needed. Low priority will help to use other programs simultaneously, if one is willing to allow extreme fan noize & PC damage consequences. However, a lot of of people would feel easier, if task throttling is implemented. " The general tuning (http://msdn2.microsoft.com/en-us/library/ms998583.aspx) figure for the threshold limit for processors is 85 percent". Some MS Blogs (http://weblogs.asp.net/scottgu/archive/2008/02/19/net-3-5-client-product-roadmap.aspx) & Forums are good places to ask.

See also:
.NET Framework Developer's Guide - Managed Threading (http://msdn2.microsoft.com/en-us/library/0xy59wtx.aspx)

This is great and unusual experience for a plugin type program. Despite newer models dominating sales, P4 replacement at many homes is slow, especially in the 3-d world. And everyone loves music, with P2P sharply increasing availability. Foobar is still considered an easy choise for lossless formats playback, despite "unfinished" feel. Having completed music collections with Lyrics and Covers is a great hobby. As I mentioned earlier, most audiophiles would want to find more info about an Album and its Cover, if easy links are provided with found covers. I can't think of another App with such a good fit for this as AAD.
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-13 04:13:03
Alex, the freeze issue happens whether the old window is searching or idle. Your latest build doesn't fix it in either case for me. As for the CPU usage problem, it is still the same for me on any of my Vista machine, CPU usage goes wildly again after a search.

EDIT: CPU usage on XP (Dothan) is fine.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-13 16:59:39
Alex, I think you exactly right about the cursor
OK, thanks for letting me know. It's a little disappointing that showing a flashing text insertion cursor uses a measurable amount of CPU, but at least the mystery is solved.

Mondo: "Memory usage still sits at about 200M even after doing a few searches and closing all the search windows"
Yes, that was helpful. It turns out a leak was introduced in 0.11, which I have now managed to track down and eliminate. Test Build 4 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_4.zip) should now always release a search window's memory when it is closed.

Thanks for your links. AAD is a fully managed-code application, though, so information about pointers doesn't apply in this case. If anyone is curious, I've found SciTech's .NET Memory Profiler (http://memprofiler.com) to be invaluable in tracking down managed object leaks (objects expected to be free for garbage collection, but which are still being held on to due to unexpected references to them).

I'm afraid, "low priority" search won't do much (http://xona.com/2004/07/22.html)
Yeah, I figured it probably wouldn't do much, as it didn't sound like there was anything else competing for CPU at the time, but I thought it might be worth a try, as I was doing a test build anyway. I'll remove it. At least it proves that the file scanning is not taking CPU from anything else that needs it more, just making good use of the CPU resource made available to it.

I appreciate the time you took looking up links on throttling and tuning, but I'm afraid they all seem to relate to server applications, where different priorities apply, and scaling must be taken into account.

This just isn't the case for a single-user desktop application performing a user-initiated foreground task. I'm not going to get into all this again, but suffice it to say, I won't be writing any throttling code.

the freeze issue happens whether the old window is searching or idle. Your latest build doesn't fix it in either case for me. As for the CPU usage problem, it is still the same for me on any of my Vista machine, CPU usage goes wildly again after a search.
Fair enough - if the freeze can occur even when not searching, then the fix I put in to test build 3 wouldn't have had any effect. I'm still trying to find any reason there might be a freeze from closing an idle window, but haven't managed to come up with anything yet, sorry. I'll keep looking, though.

Also, lacking a Vista machine to test on, I'm not sure what I can do about it. If you have the time and patience, you can download WpfPerf (http://wpf.netfx3.com/files/folders/10880/download.aspx) (documentation (http://msdn2.microsoft.com/en-us/library/aa969767.aspx)), then using the Perforator tool check to see if the Dirty Rect Addition Rate is non-zero when idle after completing a search. If it is, check the "Show dirty region update overlay" checkbox. Hopefully this will result in some coloured rectangles over whatever area is being re-rendered - if you send me a screenshot of that, I can see if I can figure out why that area might be being re-rendered when it is supposed to be idle.

Of course, I'd understand if you don't want to bother, but I thought I'd mention it anyway, as it's probably the only way to get anywhere with a Vista-only problem.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-14 03:51:27
Of course, I'd understand if you don't want to bother, but I thought I'd mention it anyway, as it's probably the only way to get anywhere with a Vista-only problem.

As you're willing to help fix the problem, at least I should be able to do that, shouldn't I. It's to improve the program I use after all. Here it is:
(http://img399.imageshack.us/img399/1440/aadyn1.th.jpg) (http://img399.imageshack.us/my.php?image=aadyn1.jpg)
The part inside the RED rectangle I drew is the part keep updating after a search. With the rectangle inside the cover sources updates the most, the 2nd in frequency is the search button and the least is the remaining part. When starting up and doing nothing, an inactive AAD window does have Dirty Rect Addition Rate = 0. And here's the data frame inside WpfPerf:
(http://img339.imageshack.us/img339/5351/wpfperfuw7.th.jpg) (http://img339.imageshack.us/my.php?image=wpfperfuw7.jpg)
Thank you for taking your time looking into my/users' problems. It's hard to find someone, working on a FOSS project such as this, who is willing to help and tolerant as you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-14 13:37:57
Wow, 816 dirty rect addition rate! I need a faster pc... :-)

OK, I've had another stab at preventing the sources area from redrawing when it shouldn't. I'm going to assume the Search button redrawing is a side-effect of that, as I can't think of anything that would cause the button to redraw itself. Try Test Build 5 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_5.zip) and see if that resolves the problem after performing a search. If it doesn't, could you let me know if any of the sources have "test: true" written under them? They should all say "test:false", if everything is working the way I am hoping.

For the freezing problem, does it still draw the window at all? Or do you get a black or corrupted display? If it is drawing the window, try moving the mouse over Options link, and see if the cursor changes to the hand pointer, and then hover over the sort triangle, and see if a tooltip pops up. If the tooltip does pop up, does the window then become responsive afterwards? How about minimizing and restoring the window, does that unfreeze it? I just need to know if I'm looking at the right effect or not. Does it ever happen if you open new window within AAD itself, rather than using foo_run to trigger it?

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-14 14:41:29
With this new test build, it seems like it even redraws faster after a search, all sources return test:false though. And yes, you're right about the cover sources part is the main problem as only that part is redrawn when AAD is inactive after a search.

I found some new bugs in this test build:
- Do a search and when the search is still taking place, doing another search with the same search term by either click on the search button or press enter inside the text box completely freeze AAD.

- Launh first search, then launch a 2nd search, close down the 2nd window when the first one still searching will completely freeze AAD.

About the freeze issue:
Quote
For the freezing problem, does it still draw the window at all? Or do you get a black or corrupted display?

Yes it still draws the window.
Quote
If it is drawing the window, try moving the mouse over Options link, and see if the cursor changes to the hand pointer, and then hover over the sort triangle, and see if a tooltip pops up. If the tooltip does pop up, does the window then become responsive afterwards?

No, the cursor doesn't change to the hand pointer at any place.
Quote
How about minimizing and restoring the window, does that unfreeze it?

Doesn't do any good in older versions, the latest test build is reponsive afterward though.
Quote
Does it ever happen if you open new window within AAD itself, rather than using foo_run to trigger it?

It happens in either case.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-14 17:30:23
Hmm... Windows Vista progress bars are continuously animated, aren't they? It would seem that they are being animated by WPF even when they aren't visible too. Hopefully this Test Build 6 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_6.zip) will finally lay them to rest and stop them animating. If it doesn't, I might need some holy water and a silver stake, just to be sure.

I've fixed the second-search freezing bug in this test build too, thanks for pointing it out.

In this test build I've also tried a couple more ideas to help with the freezing bug from the answers you gave me, so let me know if anything improves there too, please.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-14 18:08:51
Yes, progress bars in Vista are continuously animated.
Fortunately, it seems like you have brought me holy water and a silver stake. This version seems to work fine CPU usage wise and the freeze issue wise. I only did a few searchs though. I will try more tomorrow. It's late night over here already.

EDIT: Ok, in this version you managed to make everything goes to sleep when searching is finished. "Dirty Rect Addition Rate" does equal zero. There's a small CPU usage (well in a RARE case I have seen it goes nearly to 10% on my Core 2, but haven't encountered this behavior again) in AlbumArt.exe thread, as shown in Process Explorer, happens SOMETIMES whether the windows are active, inactive or minimized, though. If you're willing to continue investigating, I'm able to help, too.

Another small problem, when changing the Album search string (mostly delete some unnecessary words, it's not a new search string so most of the time AAD uses the old window) and do a search again during the original search is taking place, the GUI may temporary freeze. It will be reponsive soon though with the same trigger as in previous freeze problem. Other than this, the GUI doesn't freeze now.

EDIT2: It seems like I found out the cause of the freeze issue I talk about above. It only happens either when you stop the search using the stop all button or do another search that satisfies certain criteria making it happen in the current search window. IOW, when user stops a search it causes AAD to freeze.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-16 20:07:26
OK, good news on the redraw after search issue then, I'm going to call that resolved. If there's another separate issue with CPU usage while idle, then we have to go back to the start to figure out what it is actually doing (if anything). Is that just on Vista (I'm not seeing it on XP here)? Does it ever happen before a search is made?

I've made some changes to the Stop All (including when stopping searches ready to perform a new replacement search), so hopefully freezing should be minimised. If a lot of sources are searching, there may still be a brief delay, but hopefully not much now. There may be a significant delay in actually stopping a source to a slow server, as it is unfortunately not possible to interrupt it while it is actually receiving data as part of a download, but the UI should be responsive while waiting though.

Test Build 7 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_7.zip) should be more responsive in the search-stopping area, and also fixes a bug where the Stop All button may remain visible even though all searches have stopped.

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-17 04:58:53
OK, good news on the redraw after search issue then, I'm going to call that resolved.
Yeah, I don't think we can do anything more with this.
 
If there's another separate issue with CPU usage while idle, then we have to go back to the start to figure out what it is actually doing (if anything).

I also think this is a seperate issue, as only AlbumArt.exe thread has CPU usage and dirty frame addition rate is really 0 after a search.
 
Is that just on Vista (I'm not seeing it on XP here)?

Yes, only on Vista.
Does it ever happen before a search is made?

No, as far as I can tell.
Test Build 7 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_7.zip) should be more responsive in the search-stopping area, and also fixes a bug where the Stop All button may remain visible even though all searches have stopped.

Yes, it's as good as I expect it to be.
Title: Album Art Downloader XUI
Post by: AlunAlun on 2008-04-18 14:16:47
Can I just say that, as a new foobar2k user, I found and downloaded this program and it worked an absolute treat, I found it a joy to use. Well done and thank you very much!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-18 18:42:02
I also think this is a seperate issue, as only AlbumArt.exe thread has CPU usage and dirty frame addition rate is really 0 after a search.
OK, I've put together some fairly random performance optimisations into Test Build 8 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_8.zip). If none of them hit the mark, I think I'll have to leave this as it is - sorry. If I move to a Vista development environment, I'll take another look at it, though.

I plan to package up what we've got here with McoreD's /squareFactor suggestion, fix up Coveralia and Google search scripts again, and release as 0.17 this weekend. Thanks for all your help with tracking down the performance issues.

Can I just say that, as a new foobar2k user, I found and downloaded this program and it worked an absolute treat, I found it a joy to use. Well done and thank you very much!
Thanks, it's always great to know when people appreciate my work!

Alex
Title: Album Art Downloader XUI
Post by: thuan on 2008-04-19 02:49:23
OK, I've put together some fairly random performance optimisations into Test Build 8 (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-test_build_8.zip). If none of them hit the mark, I think I'll have to leave this as it is - sorry. If I move to a Vista development environment, I'll take another look at it, though.

It doesn't fix it, but it seems to be better. And it seems to only happen when there're a lot of album arts found whether in single or multiple window. No picky, though. I can wait, as I said if there had been no one bringing this up, I wouldn't have noticed it. Thanks for taking your time and fixed my issues with this simple but indispensable program.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-19 14:20:19
AlbumArt Downloader XUI v0.17 Released

This is a performance release, several issues have been fixed relating to CPU usage for rendering the search window, and a memory leak when closing a search window has been plugged. Responsiveness in general has also been improved.

Additionally, the Coveralia script has been fixed and the Google Images script re-written to cope with their changes, and should both now work again.

Finally, a new parameter has been added to the command line interface (aad.exe): /minAspect. This specifies the minimum aspect ratio of the image to use. This is how square the image must be, where a value of 1 represents perfectly square (600 x 600, for example). An image of size 600 x 300 would only be allowed if /minAspect were 0.5 or lower.

Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: arnymars on 2008-04-19 16:58:00
Alex,
I also wanted to thank you for your persistant work on this nice utility. Its always a pleasure to deal with intelligent person as well. I checked your website and found, your hardware resources were quite limited for a while. It raises a reasonable question though, why you don't want to help others with limited resources to enjou your program by adding some limited throttling algorithm. And why don't you want to add Cover Weblink Return code to your sources, which doesn't look that hard and time consuming, based on the Cover sources scripts posted on your website.

Another question I have is about your Foobar Configuration File Tool (http://www.byalexv.co.uk/index.html?Personal.html). Is it possible to add the new checksum calculation to it to avoid patching Foobar? Also, with this tool, is there a way to increase Foobar Max Sound Volume? Is there any reason for it to be so low anyway compare to Apollo, WinAmp etc.?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-19 18:16:03

Thank you for your comments. In answer to your questions: I don't regard throttling to be generally helpful, even for low spec machines - it would just make a slow process even slower, with no real benefits. I concede that if your PC has a hardware fault that causes overheating at high CPU loads, you might benefit from throttling, but it's a bit of an edge case.

As I'm feeling helpful, though, I'll point you at WinThrottle (http://www.oldskool.org/pc/throttle), a free tool which will let you throttle your CPU in a flexible and configurable way. If you are unable or unwilling to resolve the overheating problem in hardware, this is probably the best solution to work around it in software.

Adding a information web link to the results is not a bad idea, and may even make it into a future version sometime. All I'm saying is that I disagree with your estimate of how laborious and  time consuming it would be to do, and it's not something that I'm likely to want to work on any time soon. What I might do, though, is add the functionality to display an information web link in the results pane if that data is supplied by the source, then if anyone does want to spend the time modifying the scripts to scrape that information, it would automatically be displayed.

About the Foobar Configuration File Tool, I'm not at liberty to discuss that publicly here.

If you have an issue with Foobar's max sound volume, you might have better luck starting a new thread about that - someone on the forum is bound to know about that, but won't see the question buried here in an unrelated topic.

Alex
Title: Album Art Downloader XUI
Post by: boondie on 2008-04-20 06:57:15
Hey guys this is a great plugin first of all. Secondly I just formatted and have forgotten how to get this working with foobar (from the right click menu). If anyone could help me out that would be great. Perhaps this information should be in the first post?

Cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-21 08:01:18
I just formatted and have forgotten how to get this working with foobar (from the right click menu). If anyone could help me out that would be great
You need to use the [a href='index.php?showtopic=45223']foo_run[/a] plugin to do this. The usual command line would be something like:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /artist "%album artist%" /album "%album%" /path "$replace(%_path%,%_filename_ext%,)Folder.%%extension%%"

The Command Line Reference (http://album-art.sourceforge.net/index.php/Command_Line_Reference) for Album Art Downloader XUI might be helpful too.

Alex
Title: Album Art Downloader XUI
Post by: tuz on 2008-04-22 20:02:47
Hi, first of all, thanks a lot for this software.
i've got problems with the different versions.
It can be described as "crash at startup"
I join to this post my errorlog.txt but it's in french.

here is the first lines :

System.Windows.Markup.XamlParseException: Impossible de convertir la chaîne « AlbumArtDownloader.ico » de l’attribut « Icon » en objet de type « System.Windows.Media.ImageSource ». Impossible de trouver un composant d’image adapté pour terminer l’opération.  Erreur à l’objet « AlbumArtDownloader.Splashscreen » dans le fichier de balisage « AlbumArt;component/splashscreen.xaml ». ---> System.NotSupportedException: Impossible de trouver un composant d’image adapté pour terminer l’opération. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception de HRESULT : 0x88982F50
  --- Fin de la trace de la pile d'exception interne ---


Let me know if you can't understand a thing. I'll try to translate a few if it can help us.

Thanks

Ps: i've already tried to uninstall and reinstall .net framework, even using a special .net cleaner but without success
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 2008-04-22 21:00:00
I use AAD with foo_func telling AAD to be started when there is no cover. I works wonderful. Thanks for AAD.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-23 07:51:54
It can be described as "crash at startup"
Hello tuz, I've tried searching around to see if I could find any information on the problem you are describing. The only thing I could find was this thread from the Microsoft forums: "DLL version not correct" when loading an image from the assembly (http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=507038&SiteID=1).

If you want to try the solution they came up with, uninstall .NET Framework 3.5, then uninstall Windows Imaging Components (WIC), then re-install .NET Framework 3.5. To uninstall WIC, you can use the command %windir%\$NtUninstallWIC$\spuninst\spuninst.exe

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-04-23 15:50:22
AlbumArt Downloader XUI v0.17 Released

Finally, a new parameter has been added to the command line interface (aad.exe): /minAspect. This specifies the minimum aspect ratio of the image to use. This is how square the image must be, where a value of 1 represents perfectly square (600 x 600, for example). An image of size 600 x 300 would only be allowed if /minAspect were 0.5 or lower.


Alex,

THANK YOU for the feature addition. Now AAD can be used to automate downloading of more reliable artwork. 

Cheers,
McoreD

Edit:

http://itsfv.svn.sourceforge.net/viewvc/it...r1=24&r2=33 (http://itsfv.svn.sourceforge.net/viewvc/itsfv/itsfv5/trunk/iTSfv/Artwork/cArtworkSources.vb?r1=24&r2=33)

20080424T001501 Job Started: VALIDATE_TRACKS_SELECTED
20080424T001504 Validating Disc: Mistaken Identity - Delta Goodrem in D:\Music\Delta Goodrem\Mistaken Identity
20080424T001504 Checks? True, Tracks? True, Library? True, File System? True
20080424T001504 Chosen Most Common Artist: "Delta Goodrem" with 100.00% confidence
20080424T001515 Found 3 sources of Artwork
20080424T001515 Artwork from File as D:\Music\Delta Goodrem\Mistaken Identity\Artwork.jpg with 600x600
20080424T001515 Artwork from Track as G:\Users\Administrator\AppData\Roaming\iTSfv\Delta Goodrem\Mistaken Identity\1482-TrackArtwork.jpg with 600x600
20080424T001515 Artwork from AAD as G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg with 709x709
20080424T001515 Choosing G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as the best Artwork
20080424T001515 Replace 600x600 with 709x709 for D:\Music\Delta Goodrem\Mistaken Identity\Folder.jpg? True
20080424T001515 Saved G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as D:\Music\Delta Goodrem\Mistaken Identity\Folder.jpg
20080424T001515 Replace 600x600 with 709x709 for D:\Music\Delta Goodrem\Mistaken Identity\Artwork.jpg? True
20080424T001515 Saved G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as D:\Music\Delta Goodrem\Mistaken Identity\Artwork.jpg
20080424T001515 Replace 600x600 with 709x709 for D:\Music\Delta Goodrem\Mistaken Identity\AlbumArtSmall.jpg? True
20080424T001515 Saved G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg as D:\Music\Delta Goodrem\Mistaken Identity\AlbumArtSmall.jpg
20080424T001515 Export Artwork Pass 1 Finished.
20080424T001516 Compare Artwork Path: G:\Users\Administrator\Pictures\iTSfv\Delta Goodrem\Mistaken Identity\AAD.jpg
20080424T001516 Cached Artwork dimensions for D:\Music\Delta Goodrem\Mistaken Identity\14 You Are My Rock.mp3
20080424T001516 Cached Track Artwork Path:  G:\Users\Administrator\AppData\Roaming\iTSfv\Delta Goodrem\Mistaken Identity\1482-XmlArtwork.jpg
20080424T001516 Track Artwork Size: 600x600, Compare Artwork Size: 709x709
20080424T001516 Replace Artwork for 14 You Are My Rock.mp3? True

Works GREAT! Thanks again. 
Title: Album Art Downloader XUI
Post by: david_dl on 2008-04-25 13:40:24
How about proxy support, ie. using the Internet Explorer proxy settings?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-25 14:54:46
How about proxy support, ie. using the Internet Explorer proxy settings?
It should already be doing that.

If you need to use a proxy other than the one specified by the system Internet Options (Control Panel, Internet Options, Connections, Lan Settings on XP), then it is possible to add or modify the AlbumArt.exe.config file to specify the proxy to use with the standard .net (http://msdn2.microsoft.com/en-us/library/kd3cf2ex.aspx) configuration settings:

Code: [Select]
<configuration>
<system.net>
  <defaultProxy>
    <proxy proxyaddress="your proxy address" />
  </defaultProxy>
</system.net>
</configuration>
Title: Album Art Downloader XUI
Post by: TarkusShakti on 2008-04-26 18:13:25
First lets say thanks for Alex's effort. This is a great time saver.

I rebuilt my OS and installed AAD-v17 on my system. I noticed that when I right-click a folder (containing mp3s) in explorer; I no longer see a selection for "Search for Album art." This was a great convenience item, can we get it back?

TS
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-26 18:49:00
Thanks, glad Album Art Downloader made it on to your list of software to re-install!

I'll add an option to the installer to put a Search for Album Art command on the context menu for folders in explorer for the next version. Until then, you can use AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg) to add it. If Album Art Downloader is not in C:\Program Files\AlbumArtDownloader, it will need editing first, though.

Alex
Title: Album Art Downloader XUI
Post by: TarkusShakti on 2008-04-26 19:03:36
I'll add an option to the installer to put a Search for Album Art command on the context menu for folders in explorer for the next version. Until then, you can use AlbumArtDownloaderBrowseFolder.reg (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderBrowseFolder.reg) to add it.


Thank you and thank you!!

TS
Title: Album Art Downloader XUI
Post by: MP3Me on 2008-04-27 02:52:01
Anybody know why Album Art Downloader would be unable to write a jpg file into a folder?
I run a search with the File Browser and under the 'Artwork Status' column some albums
are listed as 'Not Present' and others as 'Found:Folder.jpg'.  However, in actuality,  there are no Folder.jpg in
any of my music folders.  When I get artwork for the former case I am able to write the jpg; for the latter case, I first get a dialog claiming file already exists, when I choose to overwrite, a second dialog appears stating access is denied.

I am running XP.  When I examine folder/file permissions, all are listed as 'Read Only'.
When I do a recursive change on the permissions and then reexamine, XP claims they
are still read only.

thanks

Edit -
Solved:
folder.jpg is a protected operating system file!  In folder view disable 'Hide protected operating system files'.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-27 10:27:59
AlbumArt Downloader XUI v0.18 Released

Just a couple of minor new features here. The installer has had a couple of minor cosmetic issues fixed, and now has an option to add a "Browse for Album Art..." entry to the context menu for folders in Explorer. The creation of Start Menu entries is now optional too.

In the search results, if a script provides a url with additional information for a result, a small (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/info.png) is displayed next to the result name, which will launch the default browser to show that page. So far, only Google Image and Amazon searches will provide these links. Other scripts may gain them in the future - if anyone else wants to add this functionality to a script, then the Add method has an additional optional string parameter after the name of the result which is the info url to use.

Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: david_dl on 2008-04-28 11:26:36
How about proxy support, ie. using the Internet Explorer proxy settings?
It should already be doing that.

If you need to use a proxy other than the one specified by the system Internet Options (Control Panel, Internet Options, Connections, Lan Settings on XP), then it is possible to add or modify the AlbumArt.exe.config file to specify the proxy to use with the standard .net (http://msdn2.microsoft.com/en-us/library/kd3cf2ex.aspx) configuration settings:

Code: [Select]
<configuration>
<system.net>
  <defaultProxy>
    <proxy proxyaddress="your proxy address" />
  </defaultProxy>
</system.net>
</configuration>


Thanks, it doesn't seem to be automatically using those settings but i'll try the .config method.
On another note, I received an email from amazon the other day that said my 'access key' was being used to request data using an old version of their web protocol, and that they would be cutting off support soon, so could I please upgrade my application, or something to that effect. Since I assume AAD is still using my amazon key, I'd recommend looking into it.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-04-28 11:37:39
Since I assume AAD is still using my amazon key, I'd recommend looking into it.
Thanks for letting me know! I'm afraid the amazon query URL has just been carried along the copy and paste trail until I had no idea where it originally came from. I'll have a look at what the protocol changes needed are.

Alex
Title: Album Art Downloader XUI
Post by: Bob... Just Bob on 2008-05-12 11:41:51
Hate to bump an old topic but, I recently decided to look for a new album art downloading program as my old one hasn't been updated to work with the new amazon.com API, and thus misses a lot of possible covers, I downloaded this one and was really happy with it at first, until I realized I couldn't use a date or year parameter in my save directory, which means it doesn't work with my sorting methods. Is this possible to add?

Sorry if this has been covered before.
Title: Album Art Downloader XUI
Post by: mobyduck on 2008-05-12 13:07:10
Not sure what you mean. If you want to store the covers in a path containing your %DATE% tag, it should be feasible... Do you invoke AAD through foo_run?

Alessandro
Title: Album Art Downloader XUI
Post by: EeKuM on 2008-05-14 17:20:25
Hey, I have searched through this topic and the previous one, and I really couldn't find my answer, so I would figure I'd just ask.

Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?

Reason being is from downloading, every names files different.  Some of the folders I have contain folder.jpg and some cover.jpg.  So if I could search both of them at the same time it would make my life of sorting through the images a heck of a lot easier.

Hopefully it's just a simple little option in the program that I am overlooking.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-14 17:40:34
Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?

Do you mean for the file or foobar browsers? If so, click the Options link, then use the "Specify path to find images" box. You can't actually specify multiple alternative filenames here, but you can use wildcards, so *.jpg should do the job. The path is relative to the track being checked.

If you meant for the Local Files search, which shows the images as results when you are doing a search, then look for the Local Files entry in the Sources list, and click on the "..." button. Check the "Specify path to find images" checkbox, and in the box below, enter the absolute path pattern to where the images are (using %artist% and %album% placeholders, usually), for example: "c:\music\%artist%\%album%\*.jpg"

Hope that helps,

Alex
Title: Album Art Downloader XUI
Post by: EeKuM on 2008-05-15 04:13:06
Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?

Do you mean for the file or foobar browsers? If so, click the Options link, then use the "Specify path to find images" box. You can't actually specify multiple alternative filenames here, but you can use wildcards, so *.jpg should do the job. The path is relative to the track being checked.

If you meant for the Local Files search, which shows the images as results when you are doing a search, then look for the Local Files entry in the Sources list, and click on the "..." button. Check the "Specify path to find images" checkbox, and in the box below, enter the absolute path pattern to where the images are (using %artist% and %album% placeholders, usually), for example: "c:\music\%artist%\%album%\*.jpg"

Hope that helps,

Alex


I should have specified that I was referring to the Foobar Browser, I'm sorry!
Title: Album Art Downloader XUI
Post by: Jimmy_Neuron on 2008-05-15 22:12:05
Hello,
Is there some doc on the API of the scripts? I'd like to create a script for downloading covers from Last.fm, but can't figure out the exact semantics of the functions used in the scripts...
Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-16 08:17:52
Is there some doc on the API of the scripts?

I'm afraid this whole project is shamefully lacking in any sort of proper documentation. The best way to start a script is to copy an existing one and modify it - I'd recommend the AlbumArtExchange.boo as the best one to start from, as it uses the new strongly-typed script API.

In summary, to create a script you need to create a class that inherits from the AlbumArtDownloader.Scripts.IScript interface. This interface defines 3 string members: Author, Name, and Version, for information, and two methods: Search and RetrieveFullSizeImage for performing the actual search.

The Search method is where the main body of work for a script is done, it is here that you should retrieve your results. Apart from the artist and album names to search for, a results object implementing the IScriptResults interface is also provided as a parameter. This is used to communicate the results of the search back to the main application.

Once you know how many results you are likely to return, set the results.EstimatedCount property. This allows the progress bar to show an estimate of progress, rather than the indeterminate state. This property can be updated at any time if your estimate changes, so even if the exact count is not known until further pages have been downloaded and parsed, but a rough estimate can be provided quickly, it's usually best to start with a rough estimate as soon as possible and refine it later.

Apart from that, there is the results.Add method. This should be called for each result that you want to return. The first parameter is the thumbnail image for the result. This can be an actual Bitmap, or a Stream containing image data, or a Uri pointing to an image, or a String containing the image uri. The second parameter is the name of the result.

After that, there are some optional parameters. infoUri (String) may be used to provide a link to a web page with more information on the result (like the Amazon and Google Image scripts do).

A width and height of the full-size image may be provided, if known, as Int32. If at all possible, try to include these, as the size of the image is a really useful thing to know before having to actually download it.

The last parameter is not optional, and may contain whatever data you choose. If the full sized image for this result is requested, then the RetrieveFullSizeImage method will be called on your class, and the parameter passed to it will be that data. You can then use it to obtain a full sized image for the result, and return it. Usually, this data is the uri for the full sized image, and the RetrieveFullSizeImage method just returns it directly.

The return value of RetrieveFullSizeImage can be any of the types that are allowed for the thumbnail image: Bitmap, Stream, Uri, or String.

Scripts are typically written in Boo, and are compiled automatically. Alternatively, any compiled .net dll in the Scripts folder containing classes implementing AlbumArtDownloader.Scripts.IScript will also be loaded. This can be helpful for debugging scripts.

I hope this explains things sufficiently, but if you have any further questions about it, please ask.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 2008-05-16 18:27:22
Do you mean for the file or foobar browsers? If so, click the Options link, then use the "Specify path to find images" box. You can't actually specify multiple alternative filenames here, but you can use wildcards, so *.jpg should do the job. The path is relative to the track being checked.


This doesn't work for me. When using the File Browser, I'd like to all local images in the album folder to be displayed among the downloaded thumbnails. But when I use *.jpg in the "Specify path to find images" box, no local images are shown among the thumbnails. If I explicity put Folder.jpg in the "Specify.." box, then that image if correctly found and displayed. Ditto for front.jpg, back.jpg, or whatever, but wildcards don't work.

Also, as a future feature request, I'd like local images displayed separately among the search results, even if sorting by e.g. size. Or perhaps use a different border color for local results.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-16 19:08:32

I think I see the confusion here. The path to find images entered in the file browser is the path it uses to check if there is already an image for that album present or not. If you want to set the path to use for finding local images in the search results, that's a separate setting (which I also described in the earlier post).

However, if you use the file browser to launch a search, it automatically populates the path to save the image to for the search to be the path to find images in from the browser. Currently, if this includes wildcards, they are removed (as you can't save to a path with a wildcard in it). The resulting path, something like c:\music\artist\album\.jpg, is then also used by the local image search (unless a specific path has previously been set for it) which of course it can't find.

For the next version, I'll see if I can do something better about wildcard replacing, probably substituting the %name% placeholder for wildcards instead of just removing them.

Segregating local image results has been requested before, and I'm open to any suggestions on the best way to display this. A different border or background colour would be easy enough, as would any other sort of visual indicator, but having them appear in a different area or order will be tricker. I'll look into it, though.

Alex
Title: Album Art Downloader XUI
Post by: kopf on 2008-05-16 19:16:42
just upgraded to the latest version. had to install .net framework 3.5 too.

now, when i try to search something, the program crashes, and the following error report is sent to microsoft:

EventType : clr20r3 P1 : albumart.exe P2 : 0.10.1.0 P3 : 47090190
P4 : mscorlib P5 : 2.0.0.0 P6 : 471ebc5b P7 : 1295 P8 : 25
P9 : system.typeloadexception
Title: Album Art Downloader XUI
Post by: blackspawn on 2008-05-17 20:57:02
I don't know if this at all possible but here goes...

I current have the following path scheme for my music collection:

1 CD: \%artist%\[%year%] %album%\
N CD: \%artist%\[%year%] %album%\CDX (where X is the disc number)

I want to save the folder.jpg to \%artist%\[%year%] %album%\folder.jpg independently if it's a single or multiple cd album. However I can't seem to get Album Art's file browser to "understand" this scheme...
If I "use ID3 tags from files" then all multiple cd albums' folder.jpg don't get recognized (and if I manually select them then they get saved to CD2 folder, don't know why...)
I tried using \%artist%\
  • %album%\*[/b] pattern matching (tried using the %year% tag but that didn't work) which resulted in Album Art correctly identifying multiple cd albums which already had a folder.jpg, however those that didn't have a folder.jpg don't even show up on the file browser.

    Basically want I want is for Album Art to check if \%artist%\[%year%] %album%\ has a folder.jpg and if not, retrieve the appropriate artist and album from the path and search for the corresponding cover. Finally I want to save all covers to \%artist%\[%year%] %album%\folder.jpg

    Can this be done? If so how? what is the config I should use in the file browser?


    Thanks in advance!
Title: Album Art Downloader XUI
Post by: gamingexpert13 on 2008-05-17 22:28:34
i dont know if nobody's ever done this or if i just had weird settings but i tried searching for an album with the artist blank and i got a bluescreen. (had plenty of normal searches work before trying that)

i dont know how much detail you want but:
windows xp sp2
Album Art Downloader XUI-0.18 Installer version
also installed the extra amazon source plugins through the installer
.net framework 3.5

opened a file browser first, searched for all my albums in my music folder, selected like 5 (same artist) and clicked Get Artwork For Selection, so it opened a few windows and queued the rest, i would save an album image then close its search window and save the next album image, close its window, and it would open the new search windows, i was also switching between different sort options (which sorted every search window by the same option, kinda weird), then i got to an album that was a compilation album (multiple artists) and i only got one result for it which wasn't right so i figured if i removed the entry for artist it would just search for the album by any artist and give me more results, well i did this, clicked search, and windows gave me a blue screen.

if you want to know any other details let me know. i'd like to be able to search without an artist.
Title: Album Art Downloader XUI
Post by: thuan on 2008-05-18 02:51:40
Coincident? I have done searches without artist field a lot without any problem. Have you ever had BSOD else where recently?
Title: Album Art Downloader XUI
Post by: jahpal on 2008-05-18 06:56:13
Alex Im sorry to bother you with this what happen to the AlbumArt Downloader V 0.6 Alpha 2 , no more updates on that one . only on the XUI . THANK YOU...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-18 09:36:45
Right, a whole bunch of answers here:

the program crashes, and the following error report is sent to microsoft:

EventType : clr20r3 P1 : albumart.exe P2 : 0.10.1.0 P3 : 47090190
P4 : mscorlib P5 : 2.0.0.0 P6 : 471ebc5b P7 : 1295 P8 : 25
P9 : system.typeloadexception
This error indicates that the .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) is not installed properly. I'd recommend removing it and re-installing it.

Can this be done? If so how? what is the config I should use in the file browser?
There isn't a great answer for this at the moment. The file browser currently can only match files, so if your album folder doesn't have any files in it (just CDX folders), there's nothing to match the pattern. When matching against files, then, the problem is that folder.jpg could be in two possible places (relative to the file), either folder.jpg (1 CD), or ..\folder.jpg (N CDs). The current version doesn't support checking multiple places for the image in the file browser either.

For the next version I plan to address both these issues, and I'll have a better answer for you, but for now you will have to run two separate searches.

First, to find art for all your 1 CD albums, have the path to find image as folder.jpg (or folder.* if you might have non-jpg images). To use path pattern matching, \%artist%\
  • %album%\*[/font] that you tried is almost correct, but as you noticed it is picking up folder.jpg from multi-cd albums too, so you could restrict it to just counting music files: \%artist%\
    • %album%\*.mp3[/font] should do the job (or .flac, or whatever format you use). If your files are in multiple formats, you might find it easier to exclude .jpg files instead: \%artist%\
      • %album%\*."(?!jpg)"*[/font]

        For the second pass, to find your multi-CD albums, use ..\folder.jpg (or ..\folder.*) as the path to find images, and \%artist%\
        • %album%\CD?\*.mp3[/font] (or similar) as the pattern.

          i tried searching for an album with the artist blank and i got a bluescreen
          Album Art Downloader doesn't do anything low-level enough to cause a bluescreen, so I'm going to have to agree with thuan's answer. If it does happen every time you try to search without an artist, then you could try a re-install of the .net framework, I suppose. I don't have any other suggestions for this, sorry.

          what happen to the AlbumArt Downloader V 0.6 Alpha 2
          Marc Landis hasn't been seen for a long time now, and when he was, I believe he was thinking of moving to the XUI branch too (although I might be mistaken).

          In any case, I personally will not be doing any work on 0.6 alpha 2, I started the XUI re-write because I considered the old one to be unmaintainable.

          Alex
Title: Album Art Downloader XUI
Post by: Waywisher on 2008-05-18 12:13:32
Hi,

Apologies if I've missed this being covered before..
Is it possible to include a script for Amazon.co.uk (or amend another like the .de version)?

I ask because the current versions seem to miss out, especially non-mainstream, images from the .co.uk site- for example the album Bottlenecks and Armbreakers by Session A9 has a 500 x 500 image on the .co.uk site but this doesn't show up in AAD XUI 0.18.

Thanks in advance

EDIT - Sorry, I think I've posted this in the wrong place.. should have been under Album Art Downloader XUI

Moderation: Moved into the appropriate thread.
Title: Album Art Downloader XUI
Post by: Jimmy_Neuron on 2008-05-18 20:25:23
Is there some doc on the API of the scripts?

I'm afraid this whole project is shamefully lacking in any sort of proper documentation. The best way to start a script is to copy an existing one and modify it - I'd recommend the AlbumArtExchange.boo as the best one to start from, as it uses the new strongly-typed script API.

(...)

I hope this explains things sufficiently, but if you have any further questions about it, please ask.

Thanks,

Alex


Wow, thanks for the info! I hope I'll be able to make up something usefull with these explanations and the scripts included with the app 

Kind regards,
Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-19 08:01:25
Is it possible to include a script for Amazon.co.uk (or amend another like the .de version)?
Amazon.co.uk (and other domains) are already included. If you are using the installer, when you reach the step to select the components to install, expand the "Image Download Script", then expand "Amazon", and choose the countries you want.

Alex
Title: Album Art Downloader XUI
Post by: Waywisher on 2008-05-19 13:50:36
Thanks Alex, I clearly missed that on the first install (by the way.. excellent work!).

I've now noticed a slightly strange thing though..
For some images AAD 0.18 'seems to change' the dimensions ever so slightly.. Taking the Session A9 cover in my earlier post example (Bottlenecks and Armbreakers) .. If you look at the properties for the image on Amazon.co.uk (the enlarged version) Firefox says it's 500 x 500 (if you save this and open in Irfanview or whatever that application also says it's 500 x 500).. the version pulled in to AAD 0.18 however is reported to be 500 x 499..

I assume AAD doesn't do anything about 'editing' images.. Do you whether this is something AAD is doing, or why this difference is occurring?

Cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-19 14:57:58
For some images AAD 0.18 'seems to change' the dimensions ever so slightly..
Strange. No, AAD, doesn't do any editing, re-encoding, reformatting or other processing of the image, it just uses the image data directly provided. A script may modify an image before returning it as a result, but none of the bundled ones (including Amazon) do.

For some reason it would appear that Amazon is providing a slightly different image through its web service than through the HTML site - I don't know why.

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 2008-05-19 17:30:03
Thanks Alex for your response to my query above (posts 356 and 357). I incorrectly assumed that wildcards were intended to give me the behavior I wanted. What I want is this:

I currently have my album art stored in the same folder as the album MP3s, but the images are inconsistently named. I want AAD to show *all* images in the local album folder as results, no matter what filename I enter in "Specify path to find images" (e.g. Folder.jpg).

This would give me a convenient semi-automatic way of selecting a main album art image among the ones I already have, and simultaneously comparing image quality to that available online. Another reason is that many of my albums are rare and produce no online results - but I may already have images in the local folders, so AAD should show them!

Local results should also be clearly marked as such, ideally by being separated somehow. But if this is too complicated to implement, marking them with "Source: LOCAL" and changing the thumbnail background color would be acceptable.

I hope you see what I mean now. Is this something we can hope for in v0.19?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-19 17:41:43
Is this something we can hope for in v0.19?

0.19 is on the way, being held up mostly by my attempts to get grouping of results to work!

In 0.19, if you put *.jpg in as the path to find images in the browser, then when you do a Get Artwork from the browser, all .jpg images in the folder will be shown as local results. The default name to save to will be %name%.jpg, though, so you might want to use a Save As to save it as Folder.jpg instead.

Alternatively, if you want the browser to only show artwork present if it is Folder.jpg, then put Folder.jpg in as the path to find images in the browser, but in the Search window you will have to expand the Local Files source, check the "Specify path to find images" checkbox, and in the box below, enter the absolute path pattern to where the images are (using %artist% and %album% placeholders, usually), for example: "c:\music\%artist%\%album%\*.jpg". That way all the images will be displayed. This can be done now, there is no need to wait for 0.19 for that.

Alex
Title: Album Art Downloader XUI
Post by: blackspawn on 2008-05-19 17:46:24
For the next version I plan to address both these issues, and I'll have a better answer for you, but for now you will have to run two separate searches.

First, to find art for all your 1 CD albums, have the path to find image as folder.jpg (or folder.* if you might have non-jpg images). To use path pattern matching, \%artist%\
  • %album%\*[/font] that you tried is almost correct, but as you noticed it is picking up folder.jpg from multi-cd albums too, so you could restrict it to just counting music files: \%artist%\
    • %album%\*.mp3[/font] should do the job (or .flac, or whatever format you use). If your files are in multiple formats, you might find it easier to exclude .jpg files instead: \%artist%\
      • %album%\*."(?!jpg)"*[/font]

        For the second pass, to find your multi-CD albums, use ..\folder.jpg (or ..\folder.*) as the path to find images, and \%artist%\
        • %album%\CD?\*.mp3[/font] (or similar) as the pattern.

          Alex


Thanks for the reply  looking forward to the "OR" option in pattern matching .

Just a minor pet peeve of mine... eheh, the drop down entry for the "Specify path to find images:" remembers the previous entries (by the way is it possible to delete some of these? are they stored in some config file?) but the one for "Use file path pattern matching" is always blank.

Anyway this IS a GREAT app thank you for all your hard work!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-19 17:59:07
Just a minor pet peeve of mine... eheh, the drop down entry for the "Specify path to find images:" remembers the previous entries (by the way is it possible to delete some of these? are they stored in some config file?) but the one for "Use file path pattern matching" is always blank.

Anyway this IS a GREAT app thank you for all your hard work!
Thanks, I'm glad it's appreciated :-)

I'll look into why the "Use file path pattern matching" box isn't remembering previous entries, and see if I can't hook up the delete key to remove entries too.

Until then, all settings are stored in: C:\Documents and Settings\[user]\Local Settings\Application Data\AlbumArtDownloader\AlbumArt.exe_Url_[random junk]\0.18.0.0\user.config, which is an xml file and can be hand edited if you need to. Under Vista, this starts as \Users rather than \Documents and Settings, I think.

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 2008-05-19 19:36:23
Excellent news, looking forward to 0.19! Thanks for a great app Alex - and even better support!
Title: Album Art Downloader XUI
Post by: jahpal on 2008-05-20 03:47:55
Right, a whole bunch of answers here:

the program crashes, and the following error report is sent to microsoft:

EventType : clr20r3 P1 : albumart.exe P2 : 0.10.1.0 P3 : 47090190
P4 : mscorlib P5 : 2.0.0.0 P6 : 471ebc5b P7 : 1295 P8 : 25
P9 : system.typeloadexception
This error indicates that the .NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) is not installed properly. I'd recommend removing it and re-installing it.

Can this be done? If so how? what is the config I should use in the file browser?
There isn't a great answer for this at the moment. The file browser currently can only match files, so if your album folder doesn't have any files in it (just CDX folders), there's nothing to match the pattern. When matching against files, then, the problem is that folder.jpg could be in two possible places (relative to the file), either folder.jpg (1 CD), or ..\folder.jpg (N CDs). The current version doesn't support checking multiple places for the image in the file browser either.

For the next version I plan to address both these issues, and I'll have a better answer for you, but for now you will have to run two separate searches.

First, to find art for all your 1 CD albums, have the path to find image as folder.jpg (or folder.* if you might have non-jpg images). To use path pattern matching, \%artist%\
  • %album%\*[/font] that you tried is almost correct, but as you noticed it is picking up folder.jpg from multi-cd albums too, so you could restrict it to just counting music files: \%artist%\
    • %album%\*.mp3[/font] should do the job (or .flac, or whatever format you use). If your files are in multiple formats, you might find it easier to exclude .jpg files instead: \%artist%\
      • %album%\*."(?!jpg)"*[/font]

        For the second pass, to find your multi-CD albums, use ..\folder.jpg (or ..\folder.*) as the path to find images, and \%artist%\
        • %album%\CD?\*.mp3[/font] (or similar) as the pattern.

          i tried searching for an album with the artist blank and i got a bluescreen
          Album Art Downloader doesn't do anything low-level enough to cause a bluescreen, so I'm going to have to agree with thuan's answer. If it does happen every time you try to search without an artist, then you could try a re-install of the .net framework, I suppose. I don't have any other suggestions for this, sorry.

          what happen to the AlbumArt Downloader V 0.6 Alpha 2
          Marc Landis hasn't been seen for a long time now, and when he was, I believe he was thinking of moving to the XUI branch too (although I might be mistaken).

          In any case, I personally will not be doing any work on 0.6 alpha 2, I started the XUI re-write because I considered the old one to be unmaintainable.

          Alex

THANK YOU ALEX
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-23 19:05:17
AlbumArt Downloader XUI v0.19 Released

This release includes several minor new features that were requested:Some bugs were fixed too:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)



0.19 also allows me to make some better replies to issues previously raised:
Is there a way to search your folders for two files.  Instead of just like folder.jpg, would it be possible to search for both folder.jpg and cover.jpg?
Yes. Use the | symbol between the alternatives you want.

I'd like local images displayed separately among the search results, even if sorting by e.g. size.
Done. Click the Group By drop down above the results and select "Local".

I current have the following path scheme for my music collection:

1 CD: \%artist%\[%year%] %album%\
N CD: \%artist%\[%year%] %album%\CDX (where X is the disc number)

I want to save the folder.jpg to \%artist%\[%year%] %album%\folder.jpg independently if it's a single or multiple cd album.
To use pattern matching to match against a folder rather than a file, end the pattern in \. so:  \%artist%\
  • %album%\.[/font] should do the job. If not, then you can restrict it further by making sure that the artist and album folders are where you expect them to be, so something like: \music\%artist%\
    • %album%\.[/font] , or whatever your parent folder is called.

      I currently have my album art stored in the same folder as the album MP3s, but the images are inconsistently named. I want AAD to show *all* images in the local album folder as results, no matter what filename I enter in "Specify path to find images" (e.g. Folder.jpg).
      To do this, expand the Local Files source (click the ... to the bottom right of it) and change the "Path to find images" box to: %folder%\*.jpg (or *.* if you have images other than jpg, but this will be slower as it has to check every file to see if it is a valid image).

      the drop down entry for the "Specify path to find images:" remembers the previous entries (by the way is it possible to delete some of these? are they stored in some config file?) but the one for "Use file path pattern matching" is always blank.
      To delete an entry, highlight it (move the mouse over it) and click the Delete key on the keyboard.
Title: Album Art Downloader XUI
Post by: m-z on 2008-05-24 11:03:01
  • Search results grouping (by source, or by local / online results). There is a new Group By option, next to the Sort By option, which allows grouping of the results either by source, or by whether they are local results or not.

That's very nice. It'd be even cooler if all of the Amazon scripts would group together.

Anyway, excellent release, AlexVallat. Keep up the good work.
Title: Album Art Downloader XUI
Post by: nicke2323 on 2008-05-26 00:02:54
Brilliant Alex, thanks!

If you're still hungry for ideas for even more improvement, here's one:

Suppose I use the file browser to find art for an album in a certain folder. If I don't get good hits using the artist and album names from the MP3 tags, I edit these fields in AAD and hit search again. I then find some images and click the save icon. However, these images are no longer placed in the original folder, but in My Pictures somewhere, so I have to find them and move them manually. No big problem, but it would be nice if AAD had an option to search again using the same folder settings. Also, perhaps it could perform this second search immediately instead of placing it at the end of the queue.

I need to edit the search fields in about 33% of my albums, so this feature would be useful.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-26 08:17:40
I edit these fields in AAD and hit search again.
I can't think of any reliable way of automatically determining whether someone has edited the fields to refine their search, or is starting a new search for a different album and artist.

What you can do, though, is uncheck the "Open search results in new window" checkbox (under Options). That way, your edited search will be performed immediately, replacing the existing results, and without changing the default path to save to - which should address the concerns you've raised, I think.

Alex
Title: Album Art Downloader XUI
Post by: nicke2323 on 2008-05-26 15:28:44
I edit these fields in AAD and hit search again.
I can't think of any reliable way of automatically determining whether someone has edited the fields to refine their search, or is starting a new search for a different album and artist.

What you can do, though, is uncheck the "Open search results in new window" checkbox (under Options). That way, your edited search will be performed immediately, replacing the existing results, and without changing the default path to save to - which should address the concerns you've raised, I think.

Alex


That checkbox was exactly what I wanted - I have no idea how I managed to miss it. I'm really running out of suggestions for you now. Hmmm ... how about an option to automatically add a number suffix when saving an image to a name that already exists (instead of asking to overwrite and/or prompting for a new name)?

Or is that functionality already in the current version too?
Title: Album Art Downloader XUI
Post by: blackspawn on 2008-05-26 23:31:51
AlbumArt Downloader XUI v0.19 Released

This release includes several minor new features that were requested:
  • Search results grouping (by source, or by local / online results). There is a new Group By option, next to the Sort By option, which allows grouping of the results either by source, or by whether they are local results or not.
  • Added the ability to the File Browser path pattern matching function to specify the path should match folders rather than files. This can be used to speed up scanning by avoiding needlessly scanning files when all the relevant information is in the folder names. To specify that a pattern should match folders, end it with \.

    For example, if your music is stored as c:\music\%artist%\%album%\*.mp3, then using the pattern \music\%artist%\%album%\. will avoid having to scan every .mp3 file in the folder, and will also match folders which have no files in them.

  • Delete key now removes items from history lists.


Thanks a bunch! This is awesome. Can't think of anything more I would like

Edit: I think I found a bug eheh I'm getting a consistent crash when using the "Group By Source" option. I have all images script selected and after searching for a single album through the file browser, and after all images have been downloaded, when I select "Group By Source" AAD crashes with the messages "Album Art has stopped working / Option: Close program" (yes I'm using Vista x32). Happens every time (tried with different albums and all).
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 2008-05-26 23:41:36
One question/request.....
With the 9.5.2 it was possible to check if a cover exists and if not to start AAD automatically.
It would be cool to have such a feature in the newer versions. Is there a way to do this in the newer versions?
I like when AAD automatically opens if a cover is missing.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-27 08:16:47
how about an option to automatically add a number suffix when saving an image to a name that already exists (instead of asking to overwrite and/or prompting for a new name)?
This might become part of the Presets system, if I ever get round to actually writing it. The idea would be that as well as being able to select a fixed suffix (like front, back, inlay, etc.) you could define a sequential numeric suffix too.

when I select "Group By Source" AAD crashes
Is an errorlog.txt file created? It's going to be hard for me to narrow down without one. Perhaps you could check to see if it is any particular source that is causing it? (Try turning half of them off, and if no longer occurs, turn that half back on, and the other half off. If it does still occur, halve the remaining sources again until the minimum set of sources that cause the bug has been isolated)

With the 9.5.2 it was possible to check if a cover exists and if not to start AAD automatically.
I don't know anything about this, but that functionality was never part of AAD, and has certainly never been removed. There has never been a version 9.5.2 of AAD.

Alex
Title: Album Art Downloader XUI
Post by: blackspawn on 2008-05-27 14:47:17
when I select "Group By Source" AAD crashes
Is an errorlog.txt file created? It's going to be hard for me to narrow down without one. Perhaps you could check to see if it is any particular source that is causing it? (Try turning half of them off, and if no longer occurs, turn that half back on, and the other half off. If it does still occur, halve the remaining sources again until the minimum set of sources that cause the bug has been isolated)

Alex


No errorlog.txt created, I tried doing what you said (disabling all scripts then activating them one by one) too see if the crash was related to any of them.. lo and behold the crash is gone lol... must have been some quirk of updating to version 0.19 from 0.17 (deactivating and re-activating the scripts seemed to have worked).

Thanks for everything Alex, you rock!
Title: Album Art Downloader XUI
Post by: Spirit_of_the_ocean on 2008-05-28 22:27:20
With the 9.5.2 it was possible to check if a cover exists and if not to start AAD automatically.
I don't know anything about this, but that functionality was never part of AAD, and has certainly never been removed. There has never been a version 9.5.2 of AAD.

Alex

Since this is a Foobar discussion board I thought i was clear that I was talking about Foobar in relation with AAD (using foo_func and foo_comserver). Foo_func is deprecated. So this won't work anymore in 0.9.5.3. I wanted to tell that it would be cool to have something implemeted that checks if the albumart of the current exists and if not start a AAD search.

I can understand if that isn't possible.

I like AAD very much good work.
Title: Album Art Downloader XUI
Post by: jahpal on 2008-05-29 07:37:54
Can Anybody help with this command line ,i can get it to work its not opening the art downloader this is what im using :  "C:\Program Files (x86)\foobar2000\AlbumArtDownloader\AlbumArt.exe" -ae -ar "%artist%" -al "%album%" -p "$replace(%_path%,%_filename_ext%,)folder.jpg" i can make it work please Thank you . by the way im using windows xp professional 64 edition . i also updated xui to the 64 bit and installed the 3.5 runtime, i just dont know what else to do . THANK YOU...
My Music its in individual folders each one by the name of the band or artist with cover inside and i keep it on another drive .      H:\Music    just in case anybody needs the info. THANKS...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-29 08:03:01
Foo_func is deprecated. So this won't work anymore in 0.9.5.3.
Ah, OK, sorry for the misunderstanding. You might have better luck asking in the foo_func thread, though, as it is this that you need a replacement for.

Can Anybody help with this command line...
Are you sure that's where you've installed AAD to? The default would be "C:\Program Files (x86)\AlbumArtDownloader\AlbumArt.exe" (not under the foobar2000 folder), but if you changed that during installation, then the command line you wrote might be OK.

Alex
Title: Album Art Downloader XUI
Post by: jahpal on 2008-05-29 08:32:01
Foo_func is deprecated. So this won't work anymore in 0.9.5.3.
Ah, OK, sorry for the misunderstanding. You might have better luck asking in the foo_func thread, though, as it is this that you need a replacement for.

Can Anybody help with this command line...
Are you sure that's where you've installed AAD to? The default would be "C:\Program Files (x86)\AlbumArtDownloader\AlbumArt.exe" (not under the foobar2000 folder), but if you changed that during installation, then the command line you wrote might be OK.

Alex

you are right this is the default "C:\Program Files (x86)\AlbumArtDownloader\AlbumArt.exe" but  i change it to the foo directory cos that is where i have it  and its opening C:\program files instead of xui ,dont know why .
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-05-29 08:51:11
its opening C:\program files instead of xui
Ah, I think I know this one. For foo_run you need to escape the ( and ) characters, so you should use:  "C:\Program Files '('x86')'\foobar2000\AlbumArtDownloader\AlbumArt.exe"

Alex
Title: Album Art Downloader XUI
Post by: jahpal on 2008-05-29 09:18:32
its opening C:\program files instead of xui
Ah, I think I know this one. For foo_run you need to escape the ( and ) characters, so you should use:  "C:\Program Files '('x86')'\foobar2000\AlbumArtDownloader\AlbumArt.exe"

Alex

Beautiful Alex it Work ,i was going out of my mind i try just about everything in the book nothing work. i would never figure that one out. THANK YOU... another happy customer .
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-06-02 20:43:33
Hola again, AAD became an even more awesome tool since I've updated it...

---I have a feature idea: with AAD it was always a bit tricky to manage albums that had more than one Artist (VA albums) Path pattern is one way to overcome this, but here is another idea: in the browser, there could be a new sorting column: Path - this would show the file path of the element. Elements from the same folder would have no thin white margin on top/bottom as they have by default (= or other non highly visible marking)

I know you don't like methods that assume a certain path structure, but this would have little to no impact on the general feel, and is a great help to everyone who stores files in album folders (95% of users )

---And I don't know if it's only me, but the size of the Search window is not saved on simple exit from a window instance - so, if there are 10 items queued, I resize a search window, and the next item in the queue pops up in the old size Search. It only saves in the case of a single Search/last queue item's Search... this is a bit annoying.

---There could be an option for AAD to - if there is one - also check the size/resolution of a folder image. So the user could set that eg. anything under 100x100px would count as missing (of course this could be marked differently in the file browser results - eg. a slightly brighter background color). Since the new image will propably overwrite the old small one, there should be a warning message before turning this on. This might make the search to last a bit longer, but AAD would gain a nice new feature, to replace low resolution folder images.

---There should be an option in the search window to search for only specific file types (eg. only jpg results). This would propably not work for all search engines (or...?), but at least for google, it would. In the distant future, it would be mega-awesome to have some sort of auto-converting ability.

---(And please, even if multi-windowed gui is hardcoded, couldn't you make one parent window to hold all the others? 3-4 open windows of the same app is not a good sight even on high resolution)
Title: Album Art Downloader XUI
Post by: blackspawn on 2008-06-02 22:42:13
---(And please, even if multi-windowed gui is hardcoded, couldn't you make one parent window to hold all the others? 3-4 open windows of the same app is not a good sight even on high resolution)


I second this request, a unified, tab-based interface would be very nice indeed.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-06-03 08:23:15
Thanks for all the suggestions, poisonboroz:

Path column in file browser:
This is a possibility - I'd need to make columns optional/hideable, then this could be a column that could be turned on and sorted by. Visible marking of items from the same path is less likely to happen, though.

Resized search window does not apply to queued searches:
That's a bug, I'll fix that.

Read pixel size of folder image in file browser:
I don't want to open and read every image during a scan, so a pixel size can't be shown. A file size is already shown, though, which should give some indication of the pixel size of the image. They don't count as missing, but the file size column can be sorted by, so you can just select all the albums with images under a certain (file)size and search for replacements if you want.

Search for specific file types:
None of the sources, with the possible exception of google images, would support this, so it isn't worth adding any sort of dedicated UI for it.

Auto-converting:
One possible future feature for AAD would be to add an image processing pipeline (crop, resize, add watermark/border, change format). So far I've been of the opinion that this is better left to a dedicated image manipulation tool rather than trying to bring it into scope for an image downloading tool, but I'm not totally against the idea, so it might eventually happen.

Tabbed UI:
Not going to happen. Not by me, anyway. I don't think a tabbed interface is right for this utility, and won't be writing one. If someone else wants to write one, I'd accept it, but only if optional and not the default.

Alex
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-06-03 14:17:51
Some sort of management for file formats is a must (even if not conversion for now), because right now AAD saves the files with the pre-set file names (eg. png files are saved with .jpg extension).
Title: Album Art Downloader XUI
Post by: thuan on 2008-06-03 16:17:12
You can save to the right extension using %extension% variable in the save path in AAD.
Title: Album Art Downloader XUI
Post by: poisonborz on 2008-06-05 11:44:56
Another bug to report: in the search window, image dimensions are often reported incorrectly. If I single click on one thumbnail, the image appears to be upscaled to the reported false dimensions, only after the image downloads, is the preview image/size indicator "corrected". Can this be fixed?

Also, it would be nice in the File browser if there would be an option to open the directory of the results (perhaps trough a context menu, or this could be the default action for double right-click) - this way AAD would provide a quick way to check the presence of album art manually.
Title: Album Art Downloader XUI
Post by: FavioD on 2008-06-05 13:42:01
is anyone else getting this?

(http://i31.tinypic.com/sym2de.jpg)
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2008-06-05 19:05:29
is anyone else getting this?


yeah it looks like they change something with referer on thumbnails. but when i click these, full size images are downloaded correctly.
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-06-05 19:26:12
is anyone else getting this?

Yes, I've been getting that for the last several days.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-06-05 22:00:46
Another bug to report: in the search window, image dimensions are often reported incorrectly.
Which script? If the image dimensions reported by a script are always wrong, then I'll remove them, but if they are at least usually right, or almost right, it's worth leaving them in as a rough guide.

Also, it would be nice in the File browser if there would be an option to open the directory of the results
Once Path becomes a column, the value will be a hyperlink like the folder image is now (when present), which will open that path in explorer.

is anyone else getting this?
I'll have a go at a workaround for this in the cover paradies script. At worst, I'll have it just always download the full sized image, as that still seems to work.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-06-07 10:41:09
is anyone else getting this?

Updated Cover-Paradies script: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)
Requires updated common utilities script: util.boo (http://www.byalexv.co.uk/foobar/util.boo)

Just stick them both in your Scripts folder, overwriting the existing ones.

Alex
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-06-07 21:31:06
Updated Cover-Paradies script: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)
Requires updated common utilities script: util.boo (http://www.byalexv.co.uk/foobar/util.boo)

Just stick them both in your Scripts folder, overwriting the existing ones.

Thanks for the update.  Seems to be working just fine again! 
Title: Album Art Downloader XUI
Post by: Fractal_Mortality on 2008-06-17 22:18:14
Would it be possible to create a .boo script for the amazon mp3 store? They consistently have 500x500 artwork, and it's one of the best resources I know of.

http://www.amazon.com/s/ref=nb_ss_dmusic?u...amp;x=0&y=0 (http://www.amazon.com/s/ref=nb_ss_dmusic?url=search-alias%3Ddigital-music&field-keywords=&x=0&y=0)
Title: Album Art Downloader XUI
Post by: blueboybob on 2008-06-18 17:21:39
will there be an option to add album art to id3tags?

that would only make this program taht much better
Title: Album Art Downloader XUI
Post by: rme on 2008-06-22 16:51:35
Is there a way to get iTunes v 7 to use the folder.jpg in the artist\album directory where I stored it from searching in AAD?  iTunes has it's own album art directory structure and doesn't recognize my folder.jps's when I load my itunes library with new discs.

Is there an automatic way to accomplish this with AAD and have it save itunes artwork directory structure as well as folder.jpg?  I suppose one way to make this universal would be if AAD saved artwork in the mp3 tags (let's not debate if that is a good idea or not please).  Trying to save some steps here.

I currently rip using either eac+mareo or foobar+mareo into flac and mp3.  Then have to foobrowse through AAD and lookup artwork, then load itunes library then can't access artwork?  I am trying to avoid using foo_dop as the rest of my family has to sync their ipdos as well and foo_dop doesn't have calendar syncing for iphone.

Thanks in advance for your help
Title: Album Art Downloader XUI
Post by: Light on 2008-06-23 15:21:09
I too am waiting for someone to update the amazon.boo script so it can search amazon again...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-06-23 19:22:10
Sorry, I haven't had a chance to reply for a while.

First, AAD won't be storing images embedded in tags, sorry. If you want to work with iTunes, can I recommend the very fine [a href='index.php?showtopic=51708']iTunes Store file validator[/a]?

I've just tested the amazon scripts, and they seem to be working fine for me. Could anyone else confirm whether the amazon scripts work for them or not? If you aren't using version 0.6 of the amazon scripts, then you could try updating to the latest version of AAD which includes them.

Alex
Title: Album Art Downloader XUI
Post by: Light on 2008-06-23 21:23:58
damn, i see mine is 0.3... thought i had the latest aad, but i guess not... will try now

:UPDATE:

yeah, that was it, thank you  ... now it all works with more results... and faster as well!
Title: Album Art Downloader XUI
Post by: AlbumArtExchange on 2008-07-07 02:18:38
edit: removed by request.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-07 07:57:04
I've just added a new XML search interface
Excellent, that's appreciated. I'll include an updated script for AlbumArtExchange in the next release.

(Which is coming along soon now, honestly! Sorry it's taken so long.)

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 2008-07-08 23:31:00
if i start albumart via command line, it works great:
Code: [Select]
D:\Program Files\AlbumArtDownloader>albumart.exe /ar "madonna" /p "d:\test.jpg"

(http://img3.imagebanana.com/img/9i0brwxw/thumb/Zwischenablage01.jpg) (http://img3.imagebanana.com/view/9i0brwxw/Zwischenablage01.jpg)

aad i get this error:
Code: [Select]
D:\Program Files\AlbumArtDownloader>aad.exe /ar "madonna" /p "d:\test.jpg"
Album Art Downloader XUI Command Line Interface version 0.19.0.0

Unexpected faliure: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.

this means something like: the object reference was not set to a object instance.

edit:
ahh ok for the cmd version the album isnt optional. so how to only get some pics of the artists? a wildcard for the album?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-09 08:02:10
ahh ok for the cmd version the album isnt optional. so how to only get some pics of the artists? a wildcard for the album?

I'll fix that for the next version, there's no reason the album shouldn't be allowed to be optional here.

Until then, to work around it, just pass " " for the album, so:

aad.exe /ar "madonna" /p "d:\test.jpg" /al " "

should do the job.

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 2008-07-09 10:38:52
thank you! i figured out the same yesterday late at night. the result with a space char is the same as in albumart.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-09 13:14:39
I'll include an updated script for AlbumArtExchange in the next release.
Here's the new script that uses the new AlbumArtExchange XML API: albumartexchange.boo (http://www.byalexv.co.uk/foobar/albumartexchange.boo)

It will be included in the next release (this weekend, hopefully), but until then, if anyone would like to start using it and let me know if there are any problems with it, that would be appreciated.

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 2008-07-09 20:42:46
lol net framework is realy interesting:
i tried /ma 0.6 but in germany i have to use 0,6 cause
in germany 1,500 means one and a half and 1.500 means fifteen hundred.

that's localization ^^

is it possible to filter such pictures:

GoogleImage: 112 ft. Puff Daddy & Notorious B.I.G (http://images.google.de/images?q=112+ft.+Puff+Daddy+%26+Notorious+B.I.G).

(http://img3.imagebanana.com/img/nklxsoh/thumb/112ft.PuffDaddyNotoriousB.I.G..jpg) (http://img3.imagebanana.com/view/nklxsoh/112ft.PuffDaddyNotoriousB.I.G..jpg)
Title: Album Art Downloader XUI
Post by: TheChipstar on 2008-07-10 05:07:05
Thanks for the cool application - just updating to the newer version.
I am just busy installing this...

Just a quick question: Is there any way of filtering results with the aspect ratio of 1:1??
Title: Album Art Downloader XUI
Post by: krabapple on 2008-07-10 07:18:27
I have local album art in two places -- as folder.xxx files in individual album folders, e.g.

F:/music/Pink Floyd/1971 - Meddle/folder.png

and a bunch of uniquely-named art files (artist_album.xxx) in a separate folder called 'covers'.

F:/covers/The Beatles_Revolver.jpg

I'm able to get AAD to list local album art -- using alternation to find jpgs, pngs, or gifs --  from one place but so far not  both.  Can someone tell me the alternation syntax for this?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-10 08:23:29
is it possible to filter such pictures:
No, I don't think so. The only thing wrong with the picture is that it is useless, which is a pretty subjective judgement to make. For all the software knows, the cover might actually be supposed to be pure black with a number grey 56 on it.

Just a quick question: Is there any way of filtering results with the aspect ratio of 1:1??
Not in the normal (interactive) application, no. I hadn't considered it necessary, as the thumbnails give a good indication of aspect ratio. For the command line version (aad.exe), as you can't preview the images, I did add this feature. To limit results to only 1:1 aspect ratio images, use /minAspect 1 in the command line.

I'm able to get AAD to list local album art -- using alternation to find jpgs, pngs, or gifs --  from one place but so far not  both.  Can someone tell me the alternation syntax for this?
How about folder.png|folder.jpg|folder.gif|/covers/%artist%_%album%.*

There's no way of grouping alternations, so you can't have (folder|cover).(png|jpg), for example. Each alternation has to stand alone. So, if .* doesn't cut it for the /covers/ folder, and you need to restrict to .png, .jpg, .gif, you have to add alternations for each of those too!

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 2008-07-10 11:30:52
No, I don't think so. The only thing wrong with the picture is that it is useless, which is a pretty subjective judgement to make. For all the software knows, the cover might actually be supposed to be pure black with a number grey 56 on it.
no dont filter black pictures with a dark gray 56, but pictures that have the same RGB value for 90% of the whole image - this cant be a valid picture or do you know such a album cover?

edit:
except the beatles's white album 

maybe it could be implemented as an optional feature?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-10 11:47:14
or do you know such a album cover?
"It's like, 'how much more black could this be?' and the answer is none. None more black."

Also, The Black Album (http://en.wikipedia.org/wiki/The_Black_Album_(Prince_album)) 

In any case, I'm not going to add a feature to make a judgement on the usefulness of a cover based on its appearance. That's what the search result thumbnails are there for. If you just avoid using the google image search, you'll eliminate the vast majority of incorrect results at a single stroke anyway.

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 2008-07-10 13:02:08
google image is the best source for rare or less known artists but ok. i try to handle this on another way
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-12 09:05:52
AlbumArt Downloader XUI v0.20 Released

New features and fixes:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: ladiko on 2008-07-12 11:23:55
works great! do you think you could add a script for last.fm? or another website with a lot of artist images? cause i prefer artist images instead of album covers.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-13 09:17:56
It's not designed for artist images, really. There is a script for http://artists.trivialbeing.org (http://artists.trivialbeing.org), but that seems to have been "Temporarily Offline" for long enough that it's return now seems unlikely.

To replace it, here's a script for Last FM artist images: lastfm-artist.boo (http://www.byalexv.co.uk/foobar/lastfm-artist.boo).

Alex
Title: Album Art Downloader XUI
Post by: ladiko on 2008-07-13 10:00:47
ohh thank you
while it's not designed for artist images, it's working as good as for album covers!

one aditional question: the aspect ratio is between 0 and 1.
so this means 640x480 has the same ratio as 480x640? do you think it's possible to add an aditional option like /aspect "{horizontal|vertical}" that means that an ratio of 0.75 and horizontal allow all images f.e. 480 high and 480 to 640 wide but not vice versa?
Title: Album Art Downloader XUI
Post by: Squeller on 2008-07-19 09:27:04
Because of ColumnsUI NGplaylist I'm now also one of those AlbumArt hunting folks. Haven't tested your component yet, but anyway: Thank you.

OMG, the .Net framework 3.5 redist package is 195 MB.
Title: Album Art Downloader XUI
Post by: Squeller on 2008-07-19 09:50:17
Wow, your program is the bomb. Many thanks. I have some suggestions, because I download "front", "back" and "disc", and I guess this is what many people do: Would you add two additional buttons besides the save button, which save to a userdefined name? This would make the workflow faster. Currently I use "save as...".

Also, a quick preview when hovering images would also be nice.

A minor thing: I start it with foo_run, but it doesn't come to top. Can you make your program come to foreground, when called?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-19 10:12:28
do you think it's possible to add an aditional option like /aspect "{horizontal|vertical}" that means that an ratio of 0.75 and horizontal allow all images f.e. 480 high and 480 to 640 wide but not vice versa?
I'll see if I can think of a good way of doing this. Possibly /requireOrientation portrait|landscape, but I'm not set on that yet.

Wow, your program is the bomb. Many thanks. I have some suggestions, because I download "front", "back" and "disc", and I guess this is what many people do: Would you add two additional buttons besides the save button, which save to a userdefined name? This would make the workflow faster. Currently I use "save as...".

Also, a quick preview when hovering images would also be nice.

A minor thing: I start it with foo_run, but it doesn't come to top. Can you make your program come to foreground, when called?
Thanks for your comments! I've had plans for a system of name [a href='index.php?act=findpost&pid=528906']Presets[/a], which would cover the behaviour you wanted for front/back/disc, for quite a long time now, but have still never actually got round to coding it. It may still happen, if I end up with a lot of time to work on this app, but I can't say when.

The problem with previewing on Hover is that previewing causes the full sized image to be downloaded, which is an action I'd rather be more explicit than just a hover. Also, having tested it out, it ends up being more irritating than anything else, as the question of when to dismiss the popup becomes a problem. Moving the mouse outside the popup (the usual way of dismissing one) can be a big annoying move if it is a large image, and it is easy to accidentally popup a preview when you didn't want one. So, on balance, no, hovering will not pop up previews, sorry.

I'm not sure why you are seeing the application not come to the front when it is started with foo_run - it always has for me. Do other programs you start with foo_run come to the front?

Alex
Title: Album Art Downloader XUI
Post by: Squeller on 2008-07-19 11:03:03
Just realized clicking on the image shows a preview, this is enough. Yes, front/back/disc would be nice.
OK, at first start it comes to front. But when I uncheck the "Search in new window" option, in order to have only one instance, additional calls via foo_run do not bring the window to front, this is what I mean.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-19 13:09:50
Great tool, I use it with Winamp though...
Is there a way to make it run through Winamp's Media Library automatically?



edit:
Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-19 19:04:37
when I uncheck the "Search in new window" option, in order to have only one instance, additional calls via foo_run do not bring the window to front, this is what I mean.
Ah, OK, yes I see this now. I'll fix that for the next version.

Great tool, I use it with Winamp though...
Is there a way to make it run through Winamp's Media Library automatically?
I suppose, if Winamp exposes its media library to external applications through an API, a Winamp Browser could be written. It's not a priority though, I'm afraid, as I'd have to learn the Winamp API first!

Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?
Could you be more specific about the steps that cause this problem? The only thing I can think of that might be related is that if you start a search from an item in the File Browser, then the path to save to in the Search Window is automatically set from the path to the item in the file the search was launched from. If that's not it, could you try opening a new window (using the menu), entering the value you want for the save path, then closing the window. Open a new one again, and it should show the changed value.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-19 19:13:56
Ah, yes... after a restart the problem is gone, thanks.

Another suggestion:
When I resize the cover previews, could the whole item be resized, too, so the text is not truncated?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-19 19:30:27
When I resize the cover previews, could the whole item be resized, too, so the text is not truncated?
I did look into this, but when I tried both possibilities, I found having the size of the preview and the size of the whole item being independent to be easier to use.

Just to check - you are aware you can resize the whole item by grabbing the dragger on the right hand edge of it? Also, you can also choose to have the text underneath the item, so it is less truncated, by clicking the little curved arrow thing on the bottom right of the item. In that mode, the whole item is resized when the image is resized too. There's a slight cosmetic bug with this mode in that the information link icon and the curved arrow to switch back to the original mode get in each others way, but I should have that fixed for the next version too.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-19 21:38:50
I' aware of the separate resizing possibilities indeed, but I didn't know if this was by design. Thanks.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-19 21:54:00
Ah... another suggestion:
I would appreciate a possibility to specify special character replacements.

The AAD replaces : by _, but Winamp requires - instead...

edit:
Why do the saved pictures always have a great quality, while the preview images have a lot of visible artefacts?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-19 22:49:46
I would appreciate a possibility to specify special character replacements.
I'll consider it. I'm not sure how generally useful it would be (why does Winamp even care if _'s are in the filename?), and there's no room to add that to the Options area without making it take up considerably more space. Anyone else here want to say if they'd find this a useful feature or not?

Why do the saved pictures always have a great quality, while the preview images have a lot of visible artefacts?
Possibly because the full size images haven't downloaded yet? AAD shows a thumbnail for the results it finds. If you preview one, it starts to download the full sized image to display, but until it's downloaded the preview will show a scaled-up version of the thumbnail. It says "Full sized image downloading..." at the top of the image while this is happening. If you keep the preview visible for long enough, it should replace itself with the high quality image soon enough.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-19 22:52:53
It's quite hard to decide which image to download without having the "full quality" thumbnail... is it possible to increase their quality a very, very tiny bit?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-20 07:50:20
It's quite hard to decide which image to download without having the "full quality" thumbnail... is it possible to increase their quality a very, very tiny bit?
Unfortunately, no. The thumbnail is as provided by the source website providing the cover art, so the size and quality of it is not under my control. If you need to see full size images before you choose which one to save, you can either just click on a few of the most likely candidates and wait for them to download, or use the option to always automatically download full sized images.

Alex
Title: Album Art Downloader XUI
Post by: phibercrack on 2008-07-20 09:38:13
Quote
Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?


Quote
Could you be more specific about the steps that cause this problem? The only thing I can think of that might be related is that if you start a search from an item in the File Browser, then the path to save to in the Search Window is automatically set from the path to the item in the file the search was launched from. If that's not it, could you try opening a new window (using the menu), entering the value you want for the save path, then closing the window. Open a new one again, and it should show the changed value.


Hi, I tried the same, and I think it is realy a bug in this version, with version 0.19 erverthing works fine...

Thanks for this nice programm 

phiber
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-20 09:50:41
Quote
Why does it always reset to "Folder.*" when I run the File Browser and choose to save as "%album%.*"?
Hi, I tried the same, and I think it is realy a bug in this version, with version 0.19 erverthing works fine...
OK, let me get this straight. You run AAD, then click File, New, File Browser. You then click the Options link, and in the "Specify path to find images" box, enter "%album%.*". You then close the file browser window. You then open a new file browser window (again), click the Options link, and the "Specify path to find images" does not show the "%album%.*" that you had entered?

The above works just fine for me, but if that's not what you are doing, or not the result you are seeing, then please give me detailed steps like those to explain what you do, and the result you get.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: phibercrack on 2008-07-20 10:34:46
I use the explorer extension to select an artist with e.g. 5 cds
- "Specify path to find images" is e.g. folder.jpg
- then i select all 5 cds and press "get artwork for selection"
- the 1st cd is O.K.
- but all other cds have a wron "save image to" path (alway's %artist%%extension%oldfilepahtof.folder.jpg

phiber
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-20 12:08:03
- the 1st cd is O.K.
- but all other cds have a wron "save image to" path (alway's %artist%%extension%oldfilepahtof.folder.jpg
Thanks for the extra info. I think I might have tracked down the problem - are the other searches being held in the queue? That could have been a bug introduced between 0.19 and 0.20, as I changed how settings applied to windows as they are dequeued. If that's the case, I'll have it fixed for the next version.

Alex
Title: Album Art Downloader XUI
Post by: phibercrack on 2008-07-20 12:19:39
yes, all other searches being held in the queue.

phiber
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-21 08:26:13
AlbumArt Downloader XUI v0.21 Released

This is a bug fixing release, to address the issues that were raised over the last few days:Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-21 11:42:53
Updating immediately, thanks for the quick fixes. 
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-21 13:47:15
Is it planned to add sth like Multi-Language Support?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-21 14:59:05
Is it planned to add sth like Multi-Language Support?
No. Internationalisation is an absolute pain to do, and even more so to retro fit to a project that wasn't built to support it from the start.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-21 15:23:25
OK, no problem then. 
Title: Album Art Downloader XUI
Post by: Squeller on 2008-07-22 08:43:25
it are teh roxxorz
Title: Album Art Downloader XUI
Post by: locutus on 2008-07-23 13:38:37
I use only embedded arts. Is this with the toll possible?
Title: Album Art Downloader XUI
Post by: teh roxxors on 2008-07-23 15:29:48
I use Amazon or Wikipedia. Why run MP3s through yet another app?

Does this offer high resolution inserts and CD labels?
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-23 18:23:20
AFAIK it mainly finds front covers.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-23 18:44:03
I use only embedded arts. Is this with the toll possible?
No, sorry. This tool has no support for embedded artwork.

I use Amazon or Wikipedia. Why run MP3s through yet another app?

Does this offer high resolution inserts and CD labels?
Scripts to search Amazon are included. Wikipedia is not, as it does not have any standardised way of presenting cover art, it can't be automated.

Some of the included sources have high resolution CD labels and back covers, but I haven't seen any that offer inserts. If you know of a website offering them, let me know and I might be able to make a script to search it too.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-23 18:54:39
Wikipedia is not, as it does not have any standardised way of presenting cover art, it can't be automated.

Uhm, it actually has. It should be enough to cover the English Wikipedia, as it is the largest one, where cover art is usually presented this way:

Quote
{{Infobox Album | <!-- See Wikipedia:WikiProject_Albums (THIS NOTE IS OPTIONAL!) -->
|  Name        = Misplaced Childhood
|  Type        = [[Album]]
|  Artist      = [[Marillion]]
|  Cover      = Marillion-Misplaced_Childhood(gatefold).jpg
|  Released    = June 1985<br/>October 1998 (two-disc edition)
|  Recorded    = Hansa Ton Studios, [[West Berlin]], March - May 1985
|  Genre      = [[Progressive rock]]
...
}}


(Source (http://en.wikipedia.org/wiki/Misplaced_Childhood))
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-07-23 19:09:33
Looks like they've done some work on it since I last looked at it. If the majority of albums now use that standard, then they could be picked up by a script. Unfortunately there doesn't seem to be any good way of searching for albums, but if I think of one, I might do a Wikipedia script.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-07-23 19:20:47
You might try to search for the particular Infobox template...

I don't think that all albums use this template, but it nevertheless exists.
Title: Album Art Downloader XUI
Post by: dewey1973 on 2008-07-28 18:31:12
I searched the thread and did not see anything on this.  Has anyone been able to rework the Walmart script?
Title: Album Art Downloader XUI
Post by: Ritchie Califoreigner on 2008-08-02 12:14:40
Hey everybody.
I have a little problem wuth this program.
I tried all of possible versions of program, but only in 1.1 - 1.3 i can read symbols, and in 1.3 - 1.6.5 i can't read and set up this prog because of troubles with strange symbols instead of normal english. Here is sreen.
(http://img53.imageshack.us/img53/1306/albumartrg1.jpg)
(http://img365.imageshack.us/img365/4509/albumart2ql8.jpg)
I have Russian-interface version of Windows XP, maybe i should change something in system settings, using "regedit" for example. What should i do to make it work? Sorry for my english, thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-02 13:22:14

I'm not sure what version of which ancient predecessor of Album Art Downloader you are using there, but if you'd like to try downloading the latest version: AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe), you will probably find it works just fine.

Alex
Title: Album Art Downloader XUI
Post by: Ritchie Califoreigner on 2008-08-02 14:48:54

I'm not sure what version of which ancient predecessor of Album Art Downloader you are using there, but if you'd like to try downloading the latest version: AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe), you will probably find it works just fine.

Alex


Yeah, thats great!    It works. You know, i had AlbumArtDownloaderXUI-0.21.exe file, but i didnt know what it was. I tried to install and it created folder in Program Files with just one exe file - aad.exe with command line interface. Size of installer - ~900kb, but i downloaded zip (~1Mb) and it worked!
So, now I dont understand what for http://unrealvoodoo.org/hiteck/projects/albumart/ (http://unrealvoodoo.org/hiteck/projects/albumart/) version? It distinguishes from yours and it doesnt work 
Thanks dude!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-02 15:07:18
So, now I dont understand what for http://unrealvoodoo.org/hiteck/projects/albumart/ (http://unrealvoodoo.org/hiteck/projects/albumart/) version? It distinguishes from yours and it doesnt work 
That project is nothing to do with this one. In fact, I wasn't aware of it until you mentioned it here. Guess I've got some competition :-)
Title: Album Art Downloader XUI
Post by: Ritchie Califoreigner on 2008-08-02 15:47:51
So, now I dont understand what for http://unrealvoodoo.org/hiteck/projects/albumart/ (http://unrealvoodoo.org/hiteck/projects/albumart/) version? It distinguishes from yours and it doesnt work 
That project is nothing to do with this one. In fact, I wasn't aware of it until you mentioned it here. Guess I've got some competition :-)

If look at program name closely, there is a little difference - Album Art Downloader in yours and Album Cover Art Downloader in his. Dont know who was the first, but i like your stuff. Especially the great idea with foobar database. Its exactly what I needed - to get information from tags. Great work, thanks!
Title: Album Art Downloader XUI
Post by: masterrossi on 2008-08-10 01:18:21
Is it me or has the Rate Your Music script not been working for a while know?

Of things I am 100% sure that there is artwork on RYM it doesn't load it any more. Anyone has an idea what this can be?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-10 08:44:04
Anyone has an idea what this can be?
That would be because Rate Your Music added a check for user-agent, and returning 403 Forbidden if they don't like the user-agent requesting the image.

So here's an updated script that sets the user agent to Mozilla/5.0 for requesting the images.

RateYourMusic.boo (http://www.byalexv.co.uk/foobar/rateyourmusic.boo)
Title: Album Art Downloader XUI
Post by: tuxman on 2008-08-10 13:11:51
Thanks for the fast update.
Title: Album Art Downloader XUI
Post by: masterrossi on 2008-08-10 15:46:41
Anyone has an idea what this can be?
That would be because Rate Your Music added a check for user-agent, and returning 403 Forbidden if they don't like the user-agent requesting the image.

So here's an updated script that sets the user agent to Mozilla/5.0 for requesting the images.

RateYourMusic.boo (http://www.byalexv.co.uk/foobar/rateyourmusic.boo)

Hmm,

I got this error code when loading the scripit

Code: [Select]
Searching for scripts...
Found 26 files: [albumartexchange.boo, amazon-ca.boo, amazon-co-uk.boo, amazon-com.boo, amazon-common.boo, amazon-de.boo, amazon-fr.boo, amazon-jp.boo, amazon.boo, amazon_de.boo, artists.trivialbeing.boo, cduniverse.boo, cover-paradies.boo, coveralia.boo, coverisland.boo, discogs.boo, freecovers.boo, google.boo, itunes.boo, juno-records.boo, lastfm-artist.boo, psyshop.boo, rateyourmusic.boo, revhq.boo, util.boo, yes24.boo]...
Loading references: [ICSharpCode.SharpZipLib.dll, System.Web]...
Compiling scripts...
rateyourmusic.boo(39,13): error BCE0005: Unknown identifier: 'logFile'.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-12 11:09:00
I got this error code when loading the scripit

Oops, looks like I uploaded the wrong (debugging) version - I've fixed that and the link should now go to the right script. Or, you can just remove the line starting "logFile".

By the way, if you edit a post rather than posting a new reply, I don't get an email notification, so I don't know to come and read it, which is why this answer is so delayed!

Alex
Title: Album Art Downloader XUI
Post by: masterrossi on 2008-08-12 11:11:12
Ahh, I see.

Will look at it when I get home from work this evening.
Title: Album Art Downloader XUI
Post by: masterrossi on 2008-08-12 19:53:33
it works

Thanks a lot.
Title: Album Art Downloader XUI
Post by: m_l on 2008-08-13 17:13:16
Thank You  for hard work and your efforts
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-17 20:10:54
AlbumArt Downloader XUI v0.22 Released

After an absurdly long wait, I've finally gotten around to implementing the Presets idea! As this has involved some fairly major internal changes, I'm not going to update the first post, or main links yet. If you are feeling adventurous, though, you can download 0.22 here and let me know how you get on with it.

To start using presets, add the placeholder %preset% anywhere within your default save path. It will automatically be there for new installations, but when upgrading it keeps your existing settings, so your current save path won't have it in there. For example, if your current save path ends Folder.%extension%, consider changing this to Folder%preset%.%extension%.

Once that placeholder is present, a drop down arrow will appear next to the save buttons in the results - click those to save the result with the %preset% placeholder substituted by one of the values listed in the menu that pops up. I've included some usual candidates (Front, Back, Inlay, etc.), but you can customise the list by clicking the "Edit Presets" item at the bottom of the menu.

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.22.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.22.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: tuxman on 2008-08-17 20:25:11
Thanks, as always.

I'll try it. Anyway.
I'm sure it won't explode.

Title: Album Art Downloader XUI
Post by: Whigged on 2008-08-18 16:52:40
Alex,

I'm just begining to mess with AAD, and I have what I hope is a pretty simple question. 

I save all of my covers in the album folder as cover.jpg.  AAD defaults to "folder.jpg."  Is there a way to change this permanently so I don't have to go into options each time and do it manually?

Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-18 17:05:17
Is there a way to change this permanently so I don't have to go into options each time and do it manually?
Are you starting from the File Browser?

If so, go into the options in the File Browser, and remove the first part (up to and including the | symbol) so that you just have "Cover%preset%.%extension%" (or "Cover.%extension%", if you are still using v0.21). The default path to save to will then be Cover.jpg instead of Folder.jpg. This is because the File Browser creates the default path to save to based on the first alternative, if multiple alternatives (separated by |) are present.

Alex
Title: Album Art Downloader XUI
Post by: Whigged on 2008-08-18 17:37:45
Is there a way to change this permanently so I don't have to go into options each time and do it manually?
Are you starting from the File Browser?

If so, go into the options in the File Browser, and remove the first part (up to and including the | symbol) so that you just have "Cover%preset%.%extension%" (or "Cover.%extension%", if you are still using v0.21). The default path to save to will then be Cover.jpg instead of Folder.jpg. This is because the File Browser creates the default path to save to based on the first alternative, if multiple alternatives (separated by |) are present.

Alex


That worked perfectly - thank you.

Another question: Is it possible to launch the File Browser without launching Album Art Downloader first?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-18 18:32:39
Another question: Is it possible to launch the File Browser without launching Album Art Downloader first?
Yes: AlbumArt.exe /fileBrowser will start it as if you'd clicked File/New/File Browser. You can also have it start searching a specified path immediately: AlbumArt.exe /fileBrowser "c:\music"

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-08-26 15:34:59
Hi Alex. Thanks for the great program!

Couple of questions:

1) Shouldn't the "File path pattern matching can be made to match folders instead of files, by ending the pattern with "\."" introduced in 0.19 be added to "Command Line Reference -> /localImagesPath"?

2) Why does the "c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe" (Visual C# Command Line Compiler) run everytime I start and close XUI? Is it really needed? After I updated to 0.22 version (installer, previously I used the zipped 0.18), the "csc.exe" starts twice before XUI opens (+ once when closing XUI), how come? I thought that the .NET 3.5 was required, so why is the csc.exe from .NET 2.0 SP1 ran? I'm really not into the deep technical side of this thing, this just seemed a bit odd to me.

3) How come the Discogs search is so awfully slow compared to others? In example, Cover-Paradies gets 15 results when searching "Pearl Jam / Ten" rather quickly (and images are really large compared to Discogs results), Discogs gets 36 and it's REALLY slow.. about 6 (or more) times slower. I tried Discogs webpage search and it's quick, and so is the image loading from the results. The "automatically download full-size images" was set to "never".

I tried to optimize the script by changing:
Code: [Select]
query as string = artist + " " + album

to this:
Code: [Select]
query as string = "\"" + artist + " - " + album + "\""

but it only helps little to weed out the not relevant artist releases (but still improvement nonetheless). I noticed that only the first page of the results (20 items) is used in the script.. which is quite ok since how many albums have over 20 different releases.

Bottom line: I didn't quite understand why the Discogs search is so slow.. do you know?

P.S. You really should be brave and push the versioning to 1.0 since your program is so damn excellent.  Thanks again!
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-08-26 16:02:22
Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading? It's really annoying to set everything again after updating. Or does this happen only when using the zipped XUI (I just installed the XUI for the first time)?

Look at the picture below:
(http://img401.imageshack.us/img401/2701/xuiib3.png)
Is the "Url_..." in folder names an indicator of a path where the program lies? Seems rather messy to me. Also, a new folder for every new version?! Is there so many/big changes to the user.config file that it's not possible to merge the old and the new one automatically?

Thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-26 16:07:15
1) Shouldn't the "File path pattern matching can be made to match folders instead of files, by ending the pattern with "\."" introduced in 0.19 be added to "Command Line Reference -> /localImagesPath"?
The file path pattern matching referred to here is for the file browser, not the local image search. It doesn't make much sense to search for folders instead of files, if searching for images, as images are files, not folders.

2) Why does the "c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe" (Visual C# Command Line Compiler) run everytime I start and close XUI?
I believe csc.exe is called to perform dynamic compilation to assist with XmlSerializer, and XmlSerializer is used to read and write configuration settings. That would explain why it is being called at loading and closing. I don't know why version 2 is being called, this is not something that is under my direct control. Is it causing a problem?

3) How come the Discogs search is so awfully slow compared to others?
Discogs is slow for a couple of reasons. Firstly, it doesn't have thumbnails, so the full-sized image is downloaded for every result. Secondly, the images can't be obtained directly from the search results page, so for each result, another page must be fetched to obtain the image url from. Thirdly, Discogs is just quite slow, compared to other sites.

P.S. You really should be brave and push the versioning to 1.0 since your program is so damn excellent.  Thanks again!
Thanks for the vote of confidence! I'm actually quite happy with the code now, but a 1.0 release also requires user documentation and a proper website, both of which I've been far too lazy to do so far!

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-26 16:21:35
Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading?
This should already be happening. If the upgrade isn't working properly, I'll look into it, but it is definitely supposed to keep existing settings.

Everything past the AlumArt.exe_ in the folder name is not under my control. This is handled automatically by the .net configuration settings / isolated storage mechanism, but yes, I think it relates to the folder the .exe file is in.

The installer will automatically delete all the ApplicationData\AlbumArtDownloader\AlbumArt.exe_* and aad.exe_* folders on uninstall, but has no special behaviour on install. Merging of old settings is done the first time a new version of the application is run.

I could, I suppose, write my own custom configuration system and store the configuration files wherever I wanted, in whatever format I wanted, but as .net provides a ready built configuration file system, I choose to use that. There are usually good, if obscure, reasons for the strange things it does - someone has put a great deal of thought and work into it - that I do not intend to duplicate.

Alex
Title: Album Art Downloader XUI
Post by: Goesen on 2008-08-26 18:12:51
Thank you for your superior tool. It's a great help. But I have 1 Problem and 1 suggestion

The Problem: When I open AAD xui and search for the first time, the search will last unbelieveable long for all internet searches.
AND if you choose to many search plugins, you will get 0 results (even searching google images for "foobar" will result in no picture at all)
after the first search was successfull i can make as many searches as i want, all of them really fast and accurate with all plugins. But if i close all aad xui windows, i have to wait again.

I use xp sp3 and no software(windows) firewall

and my sugesstion: could you (or somebody else) add an itunes plugin? you could steal the code from "itunesstorevalidator" 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-26 20:07:52
Thanks for your comments. I can't reproduce the problem you have described - do you think you could check if it is any particular source that is causing it? If you have only one source selected, the next time you start AAD, does it still go slow? Does it matter which source?

We used to have an iTunes image script, but since they started encrypting their images, it can't be used any more.

If you meant some sort of integration with the iTunes client, then no, that's not going to happen. Not unless someone else writes it, anyway, as I won't be installing that junk on my PC. As you say, there is already an itunesstorevalidator, which I believe already integrates with Album Art Downloader in some way.

Alex
Title: Album Art Downloader XUI
Post by: Goesen on 2008-08-26 22:47:32
Hi Alex
Yes i would like some tool which uses i tunes.
And i'd rather use a plugin for your code, because each time i use itsv i get the feeling it destroys more than it fixes.
Is here anyone who has free time and nothing to do?


But Alex, if you like, you could add the Encyclopedia Metallum (should be very similar to discogs)
http://www.metal-archives.com/ (http://www.metal-archives.com/)
(registration requiered for the advanced search


Quote
do you think you could check if it is any particular source that is causing it

any script which is using the internet

Quote
If you have only one source selected, the next time you start AAD, does it still go slow

yes. choosing only googleimages for artist "foobar" takes around 15 sek. if i pick more sources it will take even longer or give no images at all. But as soon as i get the first pictures, i can choose "select all", search again and get nearly instantly all images.

Quote
Does it matter which source

any script which is using the internet

I just played a bit with your command line tool and got nearly the same results
aad "foobar" spend 15 sek for the first source (Album Art Exchange)
after the first source was done, it works pretty fast

if i set other sources i spend it's 15 sec on the first other source.

maybe tomorrow i will try this on another pc, but not today
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-08-27 01:40:23
I believe csc.exe is called to perform dynamic compilation to assist with XmlSerializer, and XmlSerializer is used to read and write configuration settings. That would explain why it is being called at loading and closing. I don't know why version 2 is being called, this is not something that is under my direct control. Is it causing a problem?

No problems. But remember when I PM'd you about the slow startup of XUI when run for the first time after reboot? I just realized (thou not 100% sure) that part of the slowdown is because the csc.exe is searched from the HD. Why it settles for the "version" (not really versions which makes this even odder) 2 csc.exe, no idea. In fact, I renamed the csc.exe in "v2.0.50727" dir and ran XUI; errorlog.txt pops up:
Code: [Select]
...
App version: 0.18.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ArgumentException: The property 'SearchPathPatternHistory' could not be created from it's default value. Error message: Compiler executable file c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe cannot be found.
...

So it seems that the .NET 2.0 is also required... or does the installer of 3.5 add the "2.0" if it does not exist? The csc.exe of v1.1 and v3.5 is not accepted (again it's the "not versions even if they're named as versions..?). I also noticed that, when running these test in VPC, that the csc.exe runs cvtres.exe (Microsoft® Resource File To COFF Object Conversion Utility) from the same directory.

Is the "property 'SearchPathPatternHistory'" relating straight to your code? I mean, I just wondered if you could try to avoid running the csc.exe (&cvtres.exe) automatically.. maybe not possible at all but doesn't hurt to ask you.  Though this is quite clearly related to the ".net provides a ready built configuration file system" you wrote, right? And thus nothing can be done about it.

And could it be possible to speed up the process by "telling" in your code where the 2.0 csc.exe is? I tried to add the directory to the PATH and rebooted but that had no effect at all.. so it may be that the csc.exe isn't searched after all and it's something else that slows down the startup..

Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading?
This should already be happening. If the upgrade isn't working properly, I'll look into it, but it is definitely supposed to keep existing settings.

I tested by installing 0.18, changed some things, installed 0.21 over (and finally also 0.22) = all changes (I made, to the options, group by, sort by & maximum results) were kept, except window size. So it's not so big of a deal..

P.S. I saved my testbed in VPC, so if you like me to test something out relating to these conversations..
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-27 08:24:17
I think the slower startup after reboot is due to initialising WPF. This can be tested by running another WPF application after reboot, before XUI, then running XUI and seeing if it is as fast as usual.

If it was csc.exe causing the problem, then it would happen on every run, not just the first one.

It would be interesting to uninstall the .NET Framework (all versions), then install only version 3.5, and check to see whether that includes csc.exe under the v2.0.50727 dir, or whether it would then start using the one under the v3.5 dir. I don't think it really matters, but it might be good to know.

SearchPathPatternHistory is one of my settings, yes. It is only one of many settings that are stored in XML serialized format though, so I expect it was just the first one to be read. To avoid XML configuration altogether would be a far larger change than just one stored property.

Quite apart from that, I've yet to become convinced that there is any harm in it. I don't think it is searching the hard disk for csc.exe - it knows exactly where to find it, as demonstrated by the fact that if it isn't there, it throws an exception stating where it thought it was. This is just internal functionality of the .net framework, and not something that needs worrying about. I had to switch the timing resolution of process explorer down to 0.5s just to see the thing appear and disappear!

Thanks for the information about the upgrading. It seems that the upgrade process is working, but isn't upgrading the window size (and position?) settings - I'll see if I can figure out why.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-08-27 20:20:57
It would be interesting to uninstall the .NET Framework (all versions), then install only version 3.5, and check to see whether that includes csc.exe under the v2.0.50727 dir, or whether it would then start using the one under the v3.5 dir. I don't think it really matters, but it might be good to know.

It does install some (basic required?) of the 1.0, 1.1, 2.0 & 3.0 stuff along with the 3.5. I used the setup installer (which downloads only needed stuff), not the full ~200 MB package. The 2.0 csc.exe is still used like I suspected.. because it's a different product although it's named like a version.. stupid Microsoft. So, no need to change the requirements.

Thanks for the information about the upgrading. It seems that the upgrade process is working, but isn't upgrading the window size (and position?) settings - I'll see if I can figure out why.

Yes, it's also the position which is not retained. Not a biggie but thanks for checking it out.
Title: Album Art Downloader XUI
Post by: weaker on 2008-08-27 21:19:47
I don't know if it helps in your case but here you can downlad a .NET cleaning utility if you have trouble with reinstalling:
http://blogs.msdn.com/astebner/archive/200...07/8108332.aspx (http://blogs.msdn.com/astebner/archive/2008/03/07/8108332.aspx)
In step no.4 there is the link to the ".NET Framework cleanup tool"
Title: Album Art Downloader XUI
Post by: ameliajune on 2008-08-28 19:08:15
This program is fantastic. Works beautifully!

If I have art already downloaded in some files but it is small in size (200 pixels) can I overwrite this with 500 pixel selections in AAD? How would this work because doesn't it just seek out files that don't have the album art attached to it?

Thanks again!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-28 19:35:10
How would this work because doesn't it just seek out files that don't have the album art attached to it?
The file and foobar browsers will list all albums found, whether or not they have image files. It will also list the image file size of those albums for which it is found, so if it looks too small, you can choose to download new art for them too.

Of course, you can always search directly for artist and album name, regardless of whether that album was found by the file or foobar browsers or not!

Alex
Title: Album Art Downloader XUI
Post by: ameliajune on 2008-08-28 20:32:50
Thanks, but here's an anomaly I found that I don't understand.

I ripped two tracks to MP3 using dbpoweramp, Lame 3.97

Both tracks ripped using artwork from the various databases at 310 x 310.
On first look, the file sizes were #1 - 13kb and #2 - 12kb

I then used AAD to select 300 x 300 files from Google, and the sizes changed to #1 - 2kb and #2 - 20kb

I then used AAD to select 400 x 400 files from Google and/or Discogs and the sizes changed to #1 - 117kb and #2 4kb

What is causing the erratic file size change? I thought all files that were 310 x 310 etc. equaled 10kb (or said standard size)?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-29 08:15:15
What is causing the erratic file size change? I thought all files that were 310 x 310 etc. equaled 10kb (or said standard size)?
File size depends on more than just pixel size. For a start, it depends on the format, so a .jpg will be a different size from a .png. For formats other than .bmp, the size also depends on the quality of the image - a more highly compressed image will have a smaller file size, but more noticeable compression artefacts.

Alex
Title: Album Art Downloader XUI
Post by: ameliajune on 2008-08-29 08:46:16
Quote
a .jpg will be a different size from a .png.


Ah, ok. When I'm selecting is there a ladder of smallest to largest, i.e., go for a png, then a jpg, etc. or no because I'd have no idea the compression factor? (I'm trying to get the best quality around 500 without too much of an increase if at all possible).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-08-29 09:07:21
(I'm trying to get the best quality around 500 without too much of an increase if at all possible).
For photo-style images (which artwork tends to be), jpg is probably best. The thing is, if it's been poorly scanned, while it might technically be a high quality image, it could still look bad! I would use Google Images as a last resort, really - I find the quality of the other sources to be more reliable. In any case, it's probably best to preview before finally accepting an image, just in case.

Alex
Title: Album Art Downloader XUI
Post by: ameliajune on 2008-08-29 18:25:49
Quote
The thing is, if it's been poorly scanned, while it might technically be a high quality image, it could still look bad!


Yes I found that out! I was testing and saved a 600x600 picture from Amazon of all places and when I imported it and took a look it was blurry! Might've been an anomaly, as you said usually Amazon is a good resource.

The feature to enlarge the pictures before saving is excellent. Thanks again.
Title: Album Art Downloader XUI
Post by: Vermelhu on 2008-09-10 01:17:32
Does this not allow you to embed album art in mp3 files? I seem to remember the old version allowing it... I may be thinking of another similar program though.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-10 08:31:55
Does this not allow you to embed album art in mp3 files? I seem to remember the old version allowing it... I may be thinking of another similar program though.
No, neither this version, nor any previous version of Album Art Downloader XUI, Album Art Downloader or Cover Downloader ever allowed embedding of album art in mp3 files, or finding art already embedded. As far as I'm concerned, it won't in the future either - having a copy of the album art embedded in each file of the album is not a system I consider worth supporting.

Alex
Title: Album Art Downloader XUI
Post by: Vermelhu on 2008-09-10 10:00:23
having a copy of the album art embedded in each file of the album is not a system I consider worth supporting.

Alex


I don't see why not... Many players (notably iTunes) don't look in the album folder for art, instead opting for their own database of downloaded album art. However this is non-portable... When moving your music to other machines or re-installing your OS, all the art is lost and must be re-download. And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

With embedded album art in tags, none of this is an issue.
Title: Album Art Downloader XUI
Post by: odyssey on 2008-09-10 10:22:29
And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

Just to nit-pick, this is NOT true. I've seen albumart in iTunes for albums in my collection that were not for sale.

But still they also miss a lot and many covers are very poor quality.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-10 10:28:27
I don't see why not... Many players (notably iTunes) don't look in the album folder for art, instead opting for their own database of downloaded album art. However this is non-portable... When moving your music to other machines or re-installing your OS, all the art is lost and must be re-download. And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

With embedded album art in tags, none of this is an issue.
Yes, a proprietary database is an even worse solution. Just another reason not to use iTunes, really, as if we needed another. Apple do make a whole lot of technically inferior rubbish in pretty boxes, and iTunes is just another shining example of the genre.

If you have to use iTunes, then [a href='index.php?showtopic=51708']iTSfv[/a] will probably help.

Alex
Title: Album Art Downloader XUI
Post by: Vermelhu on 2008-09-10 11:05:25
iTSfv looks handy, but iTunes was just one example among many. It just happened to be the most familiar one. My main point was the fact that if the album art is contained within the file, any similar issues would not be experienced.

I don't see any compelling reason not to embed art - the only one I can think of is storage, and considering the price of storage these days it's not much of an excuse. Feel free to enlighten me if there are others though.

In general, I tend to have the album art both in the folder and in the files... Personal preference. I just think it would be a nice feature to have as an option.
Title: Album Art Downloader XUI
Post by: ameliajune on 2008-09-11 21:42:39
GREAT program and this is one of those nit picky questions, but I see that the default for naming the pictures is Folder.jpg. Is there any way to change that to folder.jpg... lowercase? How would I do that program wise so I wouldn't have to do it on each individual one?

Thanks! 

Edit: One other thing - Is there a way to search for album only? Meaning, say I have a compilation cd ripped in FLAC with all of the files in the same folder. I noticed that AAD brings up each song (because it's a compilation they are by different artists) rather than find the album art for the album and then move on.

2nd Edit: Woohoo! I think I did it... I marked the "use file path pattern matching" set to \%artist%\%album%\* and it only brought up or seemed to.. the albums... did I do it?

3rd Edit: Wow, I'm on a roll. I seem to have fixed the naming part too... maybe when I open a blank File Browser and made changes to that it affected the rest?

Excellent. I love it when things work out.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-12 07:48:35
Well, you seem to have worked everything out for yourself, well done! To aid others who might be searching for the same answers:

To change the default for naming pictures, when starting a search from the file browser, click the Options link in the file browser and edit the "Specify Path to Find Images" box.

To match various artists albums, the best way is probably that which you mentioned, to use path pattern matching so that the name of the album and artist is taken from the name of the folder that the music files are found in. If the album and artist name can not be determined from the file path and pattern, though, then it is probably not possible.

Alex
Title: Album Art Downloader XUI
Post by: servimo on 2008-09-14 16:57:08
Possible a proxy control? I have IE set to use a proxy when I use it, but firefox is not set to use a proxy. Album Art Downloader XUI uses the proxies preferences from IE, by using this it slow down my downloads of album art and don't want to every time I need to look for some album art I have to disable the proxy in IE.
Maybe in Options could have a get proxy configuration from IE or don't use any proxy.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-14 18:39:57
Possible a proxy control?
The proxy server settings can be overridden using the standard .net configuration system. I don't want to start adding specific UI for this into the app, but if you just want to disable proxy use, try placing this config file in your Album Art Downloader program folder (next to AlbumArt.exe): AlbumArt.exe.config (http://www.byalexv.co.uk/temp/AlbumArt.exe.config)

Alex
Title: Album Art Downloader XUI
Post by: servimo on 2008-09-14 18:51:20
 worked fine really thanks for your effort. Just what I want: no proxies for AlbumArt Downloader XUI. Thanks! Looking for Album Art fast now and the result was increased.
Title: Album Art Downloader XUI
Post by: unknownllama on 2008-09-15 00:40:22
I am hoping to use Album Art Downloader to run automatically for a specific folder containing files in the artist\album\song folder format. I'm not sure how to pass the specific folder for aad.exe to use. This is the code I have now:

"C:\Program Files\AlbumArtDownloader\aad.exe" /artist "%artist%" /album "%album%" /path "$replace(%path%,%filename_ext%,folder.jpg)" /sources "Amazon,Discogs" /minSize "300" /sequence "1"

What and where do I need to place the local folder for this to run correctly? I am hoping to schedule this to run automatically a couple times a week to get art for the new music I download to the folder.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-15 07:58:42
I am hoping to use Album Art Downloader to run automatically for a specific folder containing files in the artist\album\song folder format.
The command line version does include file browser or foobar browser functionality. If you want to be scanning a folder to find files which don't have art yet, you need to use the GUI. You can use the command line AlbumArt.exe /fileBrowser "path to folder" to start scanning that folder immediately.

Alex
Title: Album Art Downloader XUI
Post by: Dr Johnson on 2008-09-26 23:30:16
Hi Alex! I'd like to get a few formalities out of the way first if I may. To begin with, congratulations on creating a wonderful program, I'm getting a lot of mileage out of it. Secondly, as this is my first post on hydrogenaudio, my greetings to you all.

OK, I'm having a problem with the cover-paradies script. It was working fine until a week or so ago, but since then it has consistently failed to procure any pics. As I consider this to be the best source of cover art on the net, it's pretty much indispensable to me. I've tried installing different versions and tinkered with the script to no avail. Are you aware of any issues with the current script? Perhaps I've been IP banned by cover-paradies, as I've been very active with this program recently. Having said that I'm still able to enter their website and download art manually, so I doubt it's that. I'm trusting in your infinite wisdom that you can find an answer for me. Thanks! 

Windows XP sp3
Album Art Downloader XUI 0.22.0.0
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-27 09:12:47
I'm having a problem with the cover-paradies script
Thanks for reporting this. Yes, they've made some changes, so here's an updated script which should work again: cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo)

Alex
Title: Album Art Downloader XUI
Post by: Dr Johnson on 2008-09-27 11:14:37
Still not working for me. I just replace the old script with the new one right?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-27 12:46:15
Yes, in the Scripts folder, replace the old one with the new one. You will need to restart Album Art Downloader XUI for it to take effect - it should come up with the "Compiling Scripts" screen when it starts again.

Once restarted, in the Sources list on the right hand side,you should see the cover-paradies script listed as version 0.6. If it still shows 0.5, it hasn't been upgraded successfully, for some reason.

If it shows 0.6 and still isn't working for you, please tell me which artist and album name you were searching for, and I'll give it a try myself.
Title: Album Art Downloader XUI
Post by: Dr Johnson on 2008-09-27 13:17:11
Ah, never mind it's working now. I tried a search for Led Zeppelin; Physical Graffiti and it sent. Funny, I did the same search earlier and it failed. Go figure. Thanks Alex, the new script seems to have done the trick.

Edit: I've noticed that it doesn't return the same results as the old script used to. If for instance I search for 'Led Zeppelin; Led Zeppelin III', it returns results for the 3rd disc of an unrelated album, rather than the 3rd album by Zep. I've tried various other searches with similar results. Any thoughts?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-27 13:32:01
Edit: I've noticed that it doesn't return the same results as the old script used to. If for instance I search for 'Led Zeppelin; Led Zeppelin III', it returns results for the 3rd disc of an unrelated album, rather than the 3rd album by Zep. I've tried various other searches with similar results. Any thoughts?
I haven't changed anything in this area. It is possible that cover-paradies themselves have changed their search algorithms. The Led Zeppelin search you suggested seems to give me the same results when I try it on their website as it does from Album Art Downloader...
Title: Album Art Downloader XUI
Post by: Dr Johnson on 2008-09-27 14:01:38
The Led Zeppelin search you suggested seems to give me the same results when I try it on their website as it does from Album Art Downloader...


Yes, I can confirm this. However, I tried using integers instead of Roman numerals and it found the right covers, so no big deal I guess. Thanks for your help Alex.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-29 11:21:36
Thanks to daju (http://sourceforge.net/users/daju/), we now have a lastfm-cover.boo (http://sourceforge.net/tracker2/download.php?group_id=187008&atid=919578&file_id=295227&aid=2128513) script, which uses the Last FM API to search for covers.

It will be included in the next version, or you can just download it and put it in your Scripts folder to use it.

Alex
Title: Album Art Downloader XUI
Post by: daju on 2008-09-30 12:13:29
Hi!
I wrote a script for darktown and put it in the tracker, so you can download it here (http://sourceforge.net/tracker2/download.php?group_id=187008&atid=919578&file_id=295448&aid=2137993).

daju
Title: Album Art Downloader XUI
Post by: Fandango on 2008-09-30 16:21:02
Don't know if it has been proposed before, but how about showing the filesize of the images? Along with the preview and image dimensions, this is also an additional way to evaluate the quality of the image.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-09-30 17:36:12
Don't know if it has been proposed before, but how about showing the filesize of the images? Along with the preview and image dimensions, this is also an additional way to evaluate the quality of the image.
The filesize is not generally available before the full size image is downloaded. Often, the dimensions are, so this can usefully be determined and displayed. Once the full size image is downloaded, you can simply look at it to see the quality anyway.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-02 22:56:50
The "Help -> AAD Website" menu & about dialog link (http://album-art.sourceforge.net/) doesn't seem to work. Also the "Command Line Reference" link (http://album-art.sourceforge.net/index.php/Command_Line_Reference) from the first post of this thread is not working.

Feature request: automatic update checker (when starting AAD, once a week, ...). And program & scripts updater straight from AAD (possibly separated?).

Thanks again for your work!! AAD XUI is grrrrreat!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-03 07:29:07
The "Help -> AAD Website" menu & about dialog link (http://album-art.sourceforge.net/) doesn't seem to work. Also the "Command Line Reference" link (http://album-art.sourceforge.net/index.php/Command_Line_Reference) from the first post of this thread is not working.

Feature request: automatic update checker (when starting AAD, once a week, ...). And program & scripts updater straight from AAD (possibly separated?).

Thanks again for your work!! AAD XUI is grrrrreat!
Thanks for reporting this - yes, the whole website seems to be down. Don't know why yet, but I'll look into it as soon as I figure out how it was set up in the first place.

Auto-update is a good idea, and should probably be implemented sometime. It would, of course, be optional.

Alex
Title: Album Art Downloader XUI
Post by: Light on 2008-10-03 11:17:16
Thanks for keeping this stuff up to date! now my cover-paradies is working again too!
Title: Album Art Downloader XUI
Post by: ameliajune on 2008-10-06 06:46:18
I have the "Group by: Local" so that if there is a folder.jpg I can see what it looks like and compare it in my hunt for a larger sized album art. However, many times (over 50%) the Local Results won't pick up the folder.jpg in the folder. Any ideas why?

Also, I noticed the program has difficulty finding cover art for Compilations, is that just the nature of the program?
Title: Album Art Downloader XUI
Post by: Squeller on 2008-10-06 14:42:11
Semi-OT: Is this the expected speed of .net Framework apps? The Album Art Downloader starts up in maybe 5-10 seconds here (P4/GhZ/3G). Like a Photoshop CS 10 on an 386sx  Even on Vista, which at usually profits from a better prefetching mechanism. I even use Java apps which startup faster (a "Go" game app, on kgs)...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-07 14:21:04
However, many times (over 50%) the Local Results won't pick up the folder.jpg in the folder. Any ideas why?
I'm afraid I'll need a little more detail - can you let me know the artist and album you were searching for, the path of the folder.jpg you were expecting to be discovered, and the path pattern it was using to search for it (click the ... in the bottom right of the Local Files source in the sources list, then copy the contents of the "Path to find images" box). I'll then try and figure out why it wasn't picked up.

Also, I noticed the program has difficulty finding cover art for Compilations, is that just the nature of the program?
Compilations can be tricky due to there not always being a good "Artist Name" to use, and having usually fairly generic album names. I would suggest leaving the Artist blank and just putting in the album name, then hoping for the best. Not all sources will come up with anything useful, but hopefully at least one will be able to find it.


The Album Art Downloader starts up in maybe 5-10 seconds here (P4/GhZ/3G)
Is the splash-screen with "Compiling Scripts" appearing? That should only appear when changes are made to the scripts folder, and will take a little time to do the compilation before the main window appears. If it is appearing every time you start the app, then something is wrong, and we can investigate that.

If the splash-screen is not appearing, but you are still experiencing slow start-up, could you check if it happens every time, or just the first time after a reboot? The first time you run any .net app after a reboot, there will be a noticeable delay of a few seconds as it loads the framework into memory. Subsequent runs of that, or any other .net app, should then be fast.

If it is happening every time you run it, then it is just this app that is too slow! I can take a look at the start-up procedure and see if there is anything I can tweak, but I can't guarantee anything.

Alex
Title: Album Art Downloader XUI
Post by: francesco on 2008-10-08 07:32:00
is there a version that does not require .NET Framework 3.5 ?

i have mess up pc
i had framework 1
anfter i installed framework3
after many pacthes
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-08 08:47:20
is there a version that does not require .NET Framework 3.5 ?
The last version which did not require 3.5 was 0.11 (http://sourceforge.net/project/showfiles.php?group_id=187008&package_id=238728&release_id=570000). Several of the scripts in that will not be up to date though, and some of the latest updates to scripts (past v0.18) will not work, as they depend on functionality added since then.
Title: Album Art Downloader XUI
Post by: francesco on 2008-10-08 09:01:57
is there a version that does not require .NET Framework 3.5 ?
The last version which did not require 3.5 was 0.11 (http://sourceforge.net/project/showfiles.php?group_id=187008&package_id=238728&release_id=570000). Several of the scripts in that will not be up to date though, and some of the latest updates to scripts (past v0.18) will not work, as they depend on functionality added since then.

thanks!
can i save the covers in 2 files
i mean save 2 covers files
cover.jpg and folder.jpg
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-08 09:18:25
can i save the covers in 2 files
Not automatically, but you can right click on a result and choose "Save As", or click within the filename and edit it, to save another copy of the cover with a different name.

Alex
Title: Album Art Downloader XUI
Post by: BlackAle on 2008-10-08 15:13:21
Thanks for the great utility, it's incredibly useful.

I've found some issues,

When I select a bunch of files in the file browser, it doesn't update the status in the file browser once I've saved the folder.jpg ...except for the last one in the queue.

Also the file browser doesn't remember the order of the columns. I have the folder as the last column, though whenever I reopen the file browser, it's defaulted to the first.

Would be useful to see the file size of the image, I realise you can't see this until you've downloaded the full size version, though when you click to preview, you could show it within that window.
Title: Album Art Downloader XUI
Post by: francesco on 2008-10-10 07:34:27
is there a version that does not require .NET Framework 3.5 ?
The last version which did not require 3.5 was 0.11 (http://sourceforge.net/project/showfiles.php?group_id=187008&package_id=238728&release_id=570000). Several of the scripts in that will not be up to date though, and some of the latest updates to scripts (past v0.18) will not work, as they depend on functionality added since then.

thanks you so much
but is there a way to save covers for windows media player 11?
i know but my girlfriend uses wmp11
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-10 08:34:51
When I select a bunch of files in the file browser, it doesn't update the status in the file browser once I've saved the folder.jpg ...except for the last one in the queue.

Also the file browser doesn't remember the order of the columns. I have the folder as the last column, though whenever I reopen the file browser, it's defaulted to the first.
Thanks for reporting these bugs, I'll fix them for the next version.

is there a way to save covers for windows media player 11?
As far as I know, Windows Media Player should just pick up an image called Folder.jpg as the cover art for tracks within that folder - is that not working for you?
Title: Album Art Downloader XUI
Post by: Light on 2008-10-10 09:38:29
I see there's a foobar plugin now to scan for existence of art in the playlists, excellent! I have it set like *front*.jpg|*cover*.jpg and all works fine. But when i get album art for a album that has no art present, it finds the art and wants to save it like %name%front%name%.jpg.

I just want it to save it as front.jpg ... any ideas on how to accomplish this (without adjusting the %name%front%name%.jpg line to front.jpg every time manually)?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-10 10:12:49
I just want it to save it as front.jpg ... any ideas on how to accomplish this (without adjusting the %name%front%name%.jpg line to front.jpg every time manually)?
Yeah, I see the problem here. Unfortunately, replacing * with nothing, rather than a preset (and %name% seemed the most logical) will spoil the local files source searching. I'll have a think and see if I can come up with something more elegant, but it's going to be hard to determine in any automatic way whether a wildcard should be replaced with %name% or nothing, on a case-by-case basis.

I can offer you a work-around, though. The path to save as is taken from the first of the alternates provided, so if you set the path to find images in the file browser to:

front.jpg|*front*.jpg|*cover*.jpg

then it will use the first alternate as the default path to save art to, namely, front.jpg.

Alex
Title: Album Art Downloader XUI
Post by: Squeller on 2008-10-10 10:22:13
If it is happening every time you run it, then it is just this app that is too slow! I can take a look at the start-up procedure and see if there is anything I can tweak, but I can't guarantee anything.

The start of your application is generally the first start of a .net framework based application on my system, because usually I avoid using them. Because they are "as fast as shifting sand dunes"  I think you do not need to tweak anything, I will live with that.
Title: Album Art Downloader XUI
Post by: Light on 2008-10-10 12:01:15
Quote
front.jpg|*front*.jpg|*cover*.jpg


ah, tnx that will do. You needn't 'fix' this 'problem' since this will solve it all, thank you!
And thnx for the fast reply
Title: Album Art Downloader XUI
Post by: francesco on 2008-10-10 12:29:52
this is the best program to download covers

shame that requires Framework
will be a future version without Framework ?


because there are not alternative Album Art Downloader XUI that works


ps is there command line to auto download the covers , i mean to download the covers without to click save....
the command line page do not work to me, i can't open the page
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-10 12:54:27
No, there will never be a version which does not require the .net framework. That would be a completely different application, written from scratch. Even the boo scripts require the .net framework, so any application compatible with them would also require it.

To download covers using the command line, use the aad.exe command line tool. I'm sorry the wiki pages aren't working at the moment, but the command line reference can be obtained locally by using the parameter /?.

At its most basic, aad.exe "artist" "album" Folder.jpg will search all available sources for the specified artist and album, and save the result as Folder.jpg in the current folder.

For convenience, here is the full aad.exe command line reference:

Code: [Select]
Usage: aad.exe [options]

Option names may be preceded by a / or a -
Options:

 /artist      Artist to search for            (/artist "Artist Name")
              May be abbreviated to /ar      (/ar "Artist Name")
              Parameter name may be omitted
              if this is the first parameter  ("Artist Name")

 /album      Album to search for            (/album "Album Name")
              May be abbreviated to /al      (/al "Album Name")
              Parameter name may be omitted
              if this is the second parameter ("Artist Name" "Album Name")

 /path        Default path to save art as    (/path "\Art\Folder.jpg")
              May be abbreviated to /p        (/p "\Art\Folder.jpg")
              Parameter name may be omitted
              if this is the third parameter

              The following variables can be used in paths:
              %artist%    Artist searched for
              %album%      Album searched for
              %name%      Name of the image found
              %extension%  Default file extension for the image
              %source%    Name of the source where image was found
              %size%      Dimensions of the image
              %sequence%  A sequence number for the image, corresponding to
                            the number passed to /sequence, or "1" by default

 /sources    Specifies the sources to search,    (/sources "Amazon,Coveralia")
              in the order to search them.
              Separate sources with commas.
              If omitted, all available sources
              except those excluded by the /exclude
              option are searched.
              May be abbreviated to /s            (/s "Amazon,Coveralia")

 /exclude    Does not search the specified    (/exclude "Local Files,Google")
              sources. Separate sources with
              commas.
              May be abbreviated to /es        (/es "Local Files,Google")

 /minSize    Specifies the minimum size of  (/minSize 300)
              image, in pixels, to use.
              Both horizontal and vertical
              dimensions must conform.
              May be abbreviated to /mn      (/mn 300)
             
 /maxSize    Specifies the maximum size of  (/maxSize 1000)
              image, in pixels, to use.
              The smallest dimension of the
              image must conform.
              May be abbreviated to /mx      (/mx 1000)

 /minAspect  Specifies the minimum aspect ratio  (/minAspect 0.9)
              of the image to use. This is how
              square the image must be, where a
              value of 1 represents perfectly
              square (600 x 600, for example). An
              image of size 600 x 300 would only
              be allowed if /minAspect were 0.5
              or lower.
              May be abbreviated to /ma          (/ma 0.9)
             
 /sequence    Specifies which result to use, if  (/sequence 2)
              more than one are found. For
              example, passing 2 as the value
              here would ignore the first result
              found, and use the second.
              May be abbreviated to /seq          (/seq 2)
 
 /listSources Produces a list of all available    (/listSources)
              sources to search.
              May be abbreviated to /l            (/l)

Exit errorlevel codes:

 0            Success
 1            No image found
 -1          Error occured
Title: Album Art Downloader XUI
Post by: francesco on 2008-10-10 13:00:01
No, there will never be a version which does not require the .net framework. That would be a completely different application, written from scratch. Even the boo scripts require the .net framework, so any application compatible with them would also require it.

To download covers using the command line, use the aad.exe command line tool. I'm sorry the wiki pages aren't working at the moment, but the command line reference can be obtained locally by using the parameter /?.

At its most basic, aad.exe "artist" "album" Folder.jpg will search all available sources for the specified artist and album, and save the result as Folder.jpg in the current folder.

For convenience, here is the full aad.exe command line reference:

Code: [Select]
Usage: aad.exe [options]

Option names may be preceded by a / or a -
Options:

 /artist      Artist to search for            (/artist "Artist Name")
              May be abbreviated to /ar      (/ar "Artist Name")
              Parameter name may be omitted
              if this is the first parameter  ("Artist Name")

 /album      Album to search for            (/album "Album Name")
              May be abbreviated to /al      (/al "Album Name")
              Parameter name may be omitted
              if this is the second parameter ("Artist Name" "Album Name")

 /path        Default path to save art as    (/path "\Art\Folder.jpg")
              May be abbreviated to /p        (/p "\Art\Folder.jpg")
              Parameter name may be omitted
              if this is the third parameter

              The following variables can be used in paths:
              %artist%    Artist searched for
              %album%      Album searched for
              %name%      Name of the image found
              %extension%  Default file extension for the image
              %source%    Name of the source where image was found
              %size%      Dimensions of the image
              %sequence%  A sequence number for the image, corresponding to
                            the number passed to /sequence, or "1" by default

 /sources    Specifies the sources to search,    (/sources "Amazon,Coveralia")
              in the order to search them.
              Separate sources with commas.
              If omitted, all available sources
              except those excluded by the /exclude
              option are searched.
              May be abbreviated to /s            (/s "Amazon,Coveralia")

 /exclude    Does not search the specified    (/exclude "Local Files,Google")
              sources. Separate sources with
              commas.
              May be abbreviated to /es        (/es "Local Files,Google")

 /minSize    Specifies the minimum size of  (/minSize 300)
              image, in pixels, to use.
              Both horizontal and vertical
              dimensions must conform.
              May be abbreviated to /mn      (/mn 300)
             
 /maxSize    Specifies the maximum size of  (/maxSize 1000)
              image, in pixels, to use.
              The smallest dimension of the
              image must conform.
              May be abbreviated to /mx      (/mx 1000)

 /minAspect  Specifies the minimum aspect ratio  (/minAspect 0.9)
              of the image to use. This is how
              square the image must be, where a
              value of 1 represents perfectly
              square (600 x 600, for example). An
              image of size 600 x 300 would only
              be allowed if /minAspect were 0.5
              or lower.
              May be abbreviated to /ma          (/ma 0.9)
             
 /sequence    Specifies which result to use, if  (/sequence 2)
              more than one are found. For
              example, passing 2 as the value
              here would ignore the first result
              found, and use the second.
              May be abbreviated to /seq          (/seq 2)
 
 /listSources Produces a list of all available    (/listSources)
              sources to search.
              May be abbreviated to /l            (/l)

Exit errorlevel codes:

 0            Success
 1            No image found
 -1          Error occured
thanks you so much
i have the old version which work without 3.5
does add.exe means for AlbumArt.exe ? i haven't the add.exe

and does it save the cover in the folder of the music?
Title: Album Art Downloader XUI
Post by: francesco on 2008-10-10 13:12:12
No, there will never be a version which does not require the .net framework. That would be a completely different application, written from scratch. Even the boo scripts require the .net framework, so any application compatible with them would also require it.

To download covers using the command line, use the aad.exe command line tool. I'm sorry the wiki pages aren't working at the moment, but the command line reference can be obtained locally by using the parameter /?.

At its most basic, aad.exe "artist" "album" Folder.jpg will search all available sources for the specified artist and album, and save the result as Folder.jpg in the current folder.

For convenience, here is the full aad.exe command line reference:

Code: [Select]
Usage: aad.exe [options]

Option names may be preceded by a / or a -
Options:

 /artist      Artist to search for            (/artist "Artist Name")
              May be abbreviated to /ar      (/ar "Artist Name")
              Parameter name may be omitted
              if this is the first parameter  ("Artist Name")

 /album      Album to search for            (/album "Album Name")
              May be abbreviated to /al      (/al "Album Name")
              Parameter name may be omitted
              if this is the second parameter ("Artist Name" "Album Name")

 /path        Default path to save art as    (/path "\Art\Folder.jpg")
              May be abbreviated to /p        (/p "\Art\Folder.jpg")
              Parameter name may be omitted
              if this is the third parameter

              The following variables can be used in paths:
              %artist%    Artist searched for
              %album%      Album searched for
              %name%      Name of the image found
              %extension%  Default file extension for the image
              %source%    Name of the source where image was found
              %size%      Dimensions of the image
              %sequence%  A sequence number for the image, corresponding to
                            the number passed to /sequence, or "1" by default

 /sources    Specifies the sources to search,    (/sources "Amazon,Coveralia")
              in the order to search them.
              Separate sources with commas.
              If omitted, all available sources
              except those excluded by the /exclude
              option are searched.
              May be abbreviated to /s            (/s "Amazon,Coveralia")

 /exclude    Does not search the specified    (/exclude "Local Files,Google")
              sources. Separate sources with
              commas.
              May be abbreviated to /es        (/es "Local Files,Google")

 /minSize    Specifies the minimum size of  (/minSize 300)
              image, in pixels, to use.
              Both horizontal and vertical
              dimensions must conform.
              May be abbreviated to /mn      (/mn 300)
             
 /maxSize    Specifies the maximum size of  (/maxSize 1000)
              image, in pixels, to use.
              The smallest dimension of the
              image must conform.
              May be abbreviated to /mx      (/mx 1000)

 /minAspect  Specifies the minimum aspect ratio  (/minAspect 0.9)
              of the image to use. This is how
              square the image must be, where a
              value of 1 represents perfectly
              square (600 x 600, for example). An
              image of size 600 x 300 would only
              be allowed if /minAspect were 0.5
              or lower.
              May be abbreviated to /ma          (/ma 0.9)
             
 /sequence    Specifies which result to use, if  (/sequence 2)
              more than one are found. For
              example, passing 2 as the value
              here would ignore the first result
              found, and use the second.
              May be abbreviated to /seq          (/seq 2)
 
 /listSources Produces a list of all available    (/listSources)
              sources to search.
              May be abbreviated to /l            (/l)

Exit errorlevel codes:

 0            Success
 1            No image found
 -1          Error occured
thanks
i mean scan for a folder full of albums and download all the covers automatically
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-10 13:24:04
i mean scan for a folder full of album and download all the cover automatically
No, that functionality is not currently available, sorry.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-11 03:21:38
I've a little problem with AAD XUI (0.22 +latest sources).

Search: metallica / metallica (example.. happens with other searches too)
options: open searches in new window = off ... automatically download = only when unknown ... filter size = minimum 499 (results sorted by sources & size desc.)

After 1st search is stopped, click search again (not actually searching again because nothing has been changed).

= suddenly covers (bigger than the "filter size" minimum) for the following sources appear on the list (did not exist after 1st search):

- Coveralia
- Darktown
- Rate Your Music

Tried the same without "filter size" and all sources showed covers after 1st search. Also tried with minimum 10px setting but couldn't reproduce the issue like with 499 as the minimum setting. AAD restarted between these tests.

These sources don't have thumbnails (?) and this is the reason for this behavior..? Though I don't understand why the 10px minimum setting doesn't affect like the 499px setting.. AND discogs don't have thumbnails either but it works.
Title: Album Art Downloader XUI
Post by: ameliajune on 2008-10-11 09:03:44
Quote
I'm afraid I'll need a little more detail - can you let me know the artist and album you were searching for, the path of the folder.jpg you were expecting to be discovered, and the path pattern it was using to search for it (click the ... in the bottom right of the Local Files source in the sources list, then copy the contents of the "Path to find images" box). I'll then try and figure out why it wasn't picked up.


Ok, will do. I'm in the middle of another project, so give me a bit.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-11 12:52:29
Thanks for reporting this bug. I can confirm it does happen as described, and will try to figure out why and have a fix for the next version.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2008-10-12 16:41:48
Can anyone write a script for buy.com?  They have a lot of 500x500 images that are often better quality than amazon's.
I'd like to second this request: not only good quality, but sometimes it's the only source where I can find covers of an acceptable size.

Here's an example (http://www.buy.com/prod/velvet/q/loc/109/60056306.html) (click on enlarge image).

Alessandro
Title: Album Art Downloader XUI
Post by: alsaan on 2008-10-12 19:32:41
This application is ridiculously useful; thanks for taking the time to code it.

That said, there is a feature I'd love to see included: the ability to save an image by dragging and dropping it to an explorer window. Would be a great time saver for me and potentially for other people.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-12 19:49:19
the ability to save an image by dragging and dropping it to an explorer window.
I like the idea - I've added it to the Feature Requests (http://sourceforge.net/tracker2/?group_id=187008&atid=919578) page. Depending on schedule, it may not make it into the upcoming release, but if not, it will be in the one after.

Alex
Title: Album Art Downloader XUI
Post by: alsaan on 2008-10-13 21:39:39
^ Thanks a lot

On an unrelated note, after a few hours wrestling with Boo I managed to write a script for buy.com. It's not tested extensively but it seems to work...
If anyone is interested and wants to help with testing: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
Title: Album Art Downloader XUI
Post by: Cerebus on 2008-10-15 22:40:35
Would it be possible to create a .boo script for the amazon mp3 store? They consistently have 500x500 artwork, and it's one of the best resources I know of.

http://www.amazon.com/s/ref=nb_ss_dmusic?u...amp;x=0&y=0 (http://www.amazon.com/s/ref=nb_ss_dmusic?url=search-alias%3Ddigital-music&field-keywords=&x=0&y=0)


I've just started using AAD, and while I haven't made it through the 22 pages of the topic, I was curious if this had been discussed any further...I've also found that the mp3 covers are significantly better quality than the existing CD covers on Amazon, and the ability to snag those would be tremendous.
Title: Album Art Downloader XUI
Post by: francesco on 2008-10-16 07:17:32
Thanks for reporting this bug. I can confirm it does happen as described, and will try to figure out why and have a fix for the next version.

Alex

is there a way to invoke/run & download cover from foobar?

i download the run compontents but i was not able to run album art downloader
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-16 09:12:41
On an unrelated note, after a few hours wrestling with Boo I managed to write a script for buy.com.
Excellent, thanks! Would you like me to include this in the next release?


Would it be possible to create a .boo script for the amazon mp3 store? They consistently have 500x500 artwork, and it's one of the best resources I know of.
I was curious if this had been discussed any further...
No, I don't think it has. I've just had a look into it myself, and it seems easy enough. I'll include one in the next release (can't post it separately as it depends on some changes to other support scripts that have already been made).

is there a way to invoke/run & download cover from foobar?
People use foo_run (http://www.hydrogenaudio.org/forums/index.php?showtopic=45223) for this. The usual command line would be something like:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /artist "%album artist%" /album "%album%" /path "$replace(%_path%,%_filename_ext%,)Folder.%%extension%%"
Title: Album Art Downloader XUI
Post by: Cerebus on 2008-10-17 22:23:05
Some bugs I've run into:

1 - It seems like the 'queue' count is always one more than the number of windows used - so if I wanted 2 queue windows, I would put '3' in the box.

2 - When art is selected from the active AAD window, the new window opened for the next album takes focus in front of the rest, so the queued windows aren't really used unless you switch windows manually.

3 - When a range of albums are selected and artwork is added for all of them, only the last album's entry on the file brower is updated to show that there is art now, and what the size is.

A cool feature:

On the file browser window, it would be great to have the folder.jpg DIMENSIONS in that list, rather than the size in kb of the jpeg file - I could then use the tool to look for artwork at a higher resolution than I already have.

Great program.  I'm currently using it on a samba share to populate the art on my linux box, and it's exactly what I've been looking for.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-18 08:48:08
1 - It seems like the 'queue' count is always one more than the number of windows used - so if I wanted 2 queue windows, I would put '3' in the box.
Are you sure? I couldn't reproduce this. Remember it counts all open search windows, not just the ones launched from the file browser - if you started off with one search window open and didn't close it, there would only be 2 slots left. If in doubt, click the Window menu, and count the number of windows starting "Search".

2 - When art is selected from the active AAD window, the new window opened for the next album takes focus in front of the rest, so the queued windows aren't really used unless you switch windows manually.
Yeah, I see what you mean. Unfortunately I can't see any good way around this at the moment, but I'll keep it in mind.

3 - When a range of albums are selected and artwork is added for all of them, only the last album's entry on the file brower is updated to show that there is art now, and what the size is.
Already fixed, it will be in the new release (coming very soon now).

On the file browser window, it would be great to have the folder.jpg DIMENSIONS in that list, rather than the size in kb of the jpeg file - I could then use the tool to look for artwork at a higher resolution than I already have.
The problem with this is that it would require actually loading each image to determine its dimensions. This would slow things down quite a lot, particularly if the images were on a samba share! I might, in a future version, add another thread that goes over all the images opening them and determining their dimensions, then if you don't want to wait for it, it isn't a problem. That won't be in the next release, though.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-18 10:13:19
AlbumArt Downloader XUI v0.23 Released

For this release, I'd like to welcome daju (http://sourceforge.net/users/daju/) to the development team. He is responsible for the addition of the Cover Types functionality added in this release, and the new DarkTown, LastFM (cover) and AllCdCover scripts that have been added, as well as rewriting the Freecovers script to use the API.

Results now show an additional line of information, their Cover Type. This may be Front, Back, Inlay or CD. You can sort or group by this field using the standard sorting and grouping controls. Not all sources support this information; where it isn't available the cover type will be "Unknown".

Other changes in this version:
Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2008-10-18 11:01:47
AlbumArt Downloader XUI v0.23 Released

I love you, man. 
Title: Album Art Downloader XUI
Post by: foo_peter on 2008-10-18 11:31:19
Hi Alex

Unfortunately I do not get to run the prog breaks immediately with the following error message.

pardon my bad English


Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\foobar2000\AlbumArtDownloader\errorlog.txt

App version: 0.23.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3

System.IO.DirectoryNotFoundException: Ein Teil des Pfades C:\Dokumente und Einstellungen\Foobar\Lokale Einstellungen\Anwendungsdaten\AlbumArtDownloader\AlbumArt.exe_Url_rkg2w2bclauvqwx5a0ud5gtpisbyhy1g\0.23.0.0\scripts konnte nicht gefunden werden.
   bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   bei System.IO.Directory.InternalGetFileDirectoryNames(String path, String userPathOriginal, String searchPattern, Boolean includeFiles, Boolean includeDirs, SearchOption searchOption)
   bei System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)
   bei AlbumArtDownloader.App.LoadScripts()
   bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   bei System.Windows.Application.<.ctor>b__0(Object unused)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: Cerebus on 2008-10-18 11:32:27
I got the same thing...I'm going to try the zip.

Edit: the zip works, so something went haywire with the installer.
Title: Album Art Downloader XUI
Post by: foo_peter on 2008-10-18 11:41:29
Edit: the zip works, so something went haywire with the installer.
[/quote]



agrees with the zip Works Perfectly
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-18 12:09:57
Could you maybe make the startup a bit .. faster? 
Or is it C#?

Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-18 12:51:03
I'm looking into the installer issue now, thanks for reporting it.

Tuxman, if you delete scripts that you don't use, it will start considerably faster. Other than that, there's not much I can do about it. The first start of any .net app after a reboot will be quite slow, but subsequent starts should be quicker.

Alex
Title: Album Art Downloader XUI
Post by: Cerebus on 2008-10-18 12:53:16
Alex -

Another thing I noticed - paths with commas in them aren't handled correctly when clicking 'folder.jpg' in the file directory list.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-18 13:01:42
Tuxman, if you delete scripts that you don't use, it will start considerably faster.

Well, they have to be "recompiled" every time, I noticed that; but maybe it's enough to compile them only on changes?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-18 13:30:23
Well, they have to be "recompiled" every time, I noticed that; but maybe it's enough to compile them only on changes?
That's what it's supposed to do! This may be related to the error message foo_peter reported (which was in the area of script compilation). I'm still looking into that.

Cerebus, thanks for the bug report - wish I'd seen that before this release! If I have to get another one out to fix the installer bug, I'll include a fix for this too.

Alex
Title: Album Art Downloader XUI
Post by: Cerebus on 2008-10-18 14:12:00
Cerebus, thanks for the bug report - wish I'd seen that before this release! If I have to get another one out to fix the installer bug, I'll include a fix for this too.

Alex


Here's something minor...when sorting by size, the triangle pointing up should sort smallest to largest, but instead it sorts largest to smallest. (small at the top vs. small at the bottom)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-18 14:13:20
AlbumArt Downloader XUI v0.23.1 Released

Apologies for the shoddy quality of the previous 0.23 release - I guess that's what you get when you don't have a QA department!

Here is 0.23.1, which should have fixed up the installer problem, the command line version problem, and the problem with launching explorer windows with commas in the path.

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.23.1.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 (http://www.microsoft.com/downloads/details.aspx?FamilyId=333325FD-AE52-4E35-B531-508D977D32A6) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: foo_peter on 2008-10-18 16:44:44
Hello Alex,

very fast and big thanks for update
It is and remains the best thing I ever seen.

"Gigantic!"

foo_peter
Title: Album Art Downloader XUI
Post by: alsaan on 2008-10-18 20:37:01
Thanks for the new release, it's working great.

As for the buy.com script: sure, you can include it in the next release.
I've made a few changes to it and added cover type support (which wasn't very hard to do)
Here is the latest version: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
Title: Album Art Downloader XUI
Post by: phunkydizco on 2008-10-19 19:28:29
How can I start file browser directly?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-19 20:18:47
How can I start file browser directly?
Add /fileBrowser to the command line.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-19 22:45:10
The new version crashed on the first use...

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Programme\AlbumArtDownloader\errorlog.txt

App version: 0.23.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3

System.Reflection.TargetInvocationException: Ein Aufrufziel hat einen Ausnahmefehler verursacht. ---> System.ArgumentOutOfRangeException: Der Index lag außerhalb des Bereichs. Er muss nicht negativ und kleiner als die Auflistung sein.
Parametername: index
   bei System.Collections.ArrayList.RemoveAt(Int32 index)
   bei System.Windows.Data.ListCollectionView.ProcessCollectionChanged(NotifyCollectionChangedEventArgs args)
   bei System.Windows.Data.CollectionView.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
   bei System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   bei System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   bei System.Collections.ObjectModel.ObservableCollection`1.RemoveItem(Int32 index)
   bei System.Collections.ObjectModel.Collection`1.Remove(T item)
   bei System.Collections.ObjectModel.Collection`1.System.Collections.IList.Remove(Object value)
   bei AlbumArtDownloader.Controls.ArtPanelList.OnImageSizeChanged(Object sender, EventArgs e)
   bei AlbumArtDownloader.AlbumArt.SetImageDimensions(Double width, Double height)
   bei AlbumArtDownloader.AlbumArt.<>c__DisplayClass7.<RetrieveFullSizeImageWorker>b__6()
   --- Ende der internen Ausnahmestapelüberwachung ---
   bei System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   bei System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   bei System.Delegate.DynamicInvokeImpl(Object[] args)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)


(Appeared after performing a search.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-20 17:07:36
The new version crashed on the first use...
Thanks for reporting it. I'm afraid I can't reproduce the problem, though - does it happen every time for you, or was it just once? If it is every time, could you tell me which sources you use, and what you search for?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-20 17:14:02
Alex, I'm just writing a big post here.. wait a bit, I have the same crash and I've lots of information...
Title: Album Art Downloader XUI
Post by: macman4hire on 2008-10-20 17:16:52
A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).  This site has some of the best quality album covers on the web.  You may want to consider offering it as a selection choice in your application.  Why not give your users the best quality that is out there.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-20 17:19:15
I used all available sources, including the new .boo file above, and searched for the album "Sex/ The End Of My Life" (with the /) by Sex (a nice progrock group btw); reproducable here.

(Ah; a search history would be appreciated.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-20 17:47:28
A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).
Thanks for the link. A script for Album Art Exchange was added back in version 0.16, and was updated in version 0.20 when they started providing an API. Please update to the latest version, and you should find it available there.

I used all available sources, including the new .boo file above, and searched for the album "Sex/ The End Of My Life" (with the /) by Sex (a nice progrock group btw); reproducable here.
Hmm... still no luck with this. What grouping/sorting settings are you using? Any filtering? Do you have Automatically Download Full Size Images enabled?
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-20 17:53:25
(http://img3.imagebanana.com/img/fx4j0ox/options.png)
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-20 17:53:31
Same crash bug here as well. Only difference to tuxman error log is that I've WINXP SP2 and in English language.

The reason for crash?: your Filtered out items aren't shown when size becomes known (http://sourceforge.net/tracker2/?func=detail&aid=2159259&group_id=187008&atid=919575) bug fix (which you didn't list in any changelog by the way). "Coveralia", "Darktown", "Juno Records", "LastFM Artist", "Rate Your Music" & "Yes24" sources are the culprits, but only when the "filter by image size" option is checked (I used only minimum setting).

Please show the progress bar for these sources when doing the size detecting/sort for "unknown" size images. I'd hate to start navigating the result list when suddenly the list would be re-sorted and I would lose the place I was in the list (and what covers I already looked thru). Thanks.

After testing a bit more I found a very strange behavior which may lead you to the culprit of this problem; steps to reproduce:

1) set "automatically download" to never
2) set on "filter by image size" to minimum 50px
3) select ONLY coveralia source
4) search metallica / metallica (= 2 covers, sizes unknown)
5) change "filter by image size" to minimum 51px

= BUG: the 2 covers disappear from the list.

6) change "automatically download" to "when unknown"

= BUG: crash

-> if you set the "automatically download" to "when unknown" in step 1 AND the minimum size to 51px (or bigger) in step 2, AAD crashes when searching in step 4.

I also tested with "Yes24" source:

1) set "automatically download" to never
2) set on "filter by image size" to minimum 106px
3) select ONLY Yes24 source (limit to 10 results)
4) search metallica / metallica (= 10 covers, sizes unknown)
5) change "filter by image size" to minimum 107px

= BUG: 1 cover disappears from the list.

6) change "filter by image size" to minimum 155px

= BUG: again 1 cover disappears from the list.

7) change "filter by image size" to minimum 221px

= BUG: the rest 8 covers disappear from the list.

8) change "automatically download" to "when unknown"

= BUG: crash

So it seems that these vary between sources/results. Why? I don't know.. maybe the search yields some size data although AAD says that it's unknown.. how else do you explain this behavior, especially with "Yes24" results (1 cover with 106px, 1 with 154px and 8 with 220px (width?) sizes even if they're unknown).

Here's some additional questions/notes:
[/end bitchin.., I mean debugging]  Maybe I should de-bug-off myself.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-20 18:45:21
Wow, thanks for your detailed analysis and post! I will look into this crash in detail with the information you've provided, but here are some answers for you now:

[quote name='Akkurat' post='594539']Please show the progress bar for these sources when doing the size detecting/sort for "unknown" size images.[/quote]The progress bar is for the source finding the results. The automatic download of full size images runs separately, and simultaneously, so making it affect the same progress bar will be tricky. You can even turn on automatic download after all sources have already completed searching, so the progress bars will already have been removed.

Would a separate progress bar showing the automatic full size image downloading progress be helpful? That could be accurately calculated and displayed, then you would know when the list won't be re-sorting any more.

It might be helpful to know that while the mouse is down on the scrollbar, the list will not update (resort or have new items added), so if you want to look through what you've got right now without it changing under you, you can drag the scrollbar up and down without releasing the mouse to do so.

[quote name='Akkurat' post='594539']I downloaded v0.23.1, the program shows 0.23 everywhere (script compile window, about window, file version)?[/quote]0.23.1 was primarily a fix to the installer, and I did not update the version number in the app. Probably should have done, but I was in a big hurry to get something up there that wouldn't crash out on first install. It will automatically be resolved for the next version, of course!

[quote name='Akkurat' post='594539']IMHO it would be nicer to NOT active the drag&drop when holding down mouse button and previewing the big image. It seems that there's about 5px range for the d&d action to become active.. maybe increasing the range would suffice? (if that's possible)[/quote]Possible, sure, but I'm not sure what sort of range to make it. Is it just to eliminate wobbly-mouse problems, or is there some reason to be moving the mouse around while previewing? It's going to be tough to know when to initiate a drag.

[quote name='Akkurat' post='594539']I like the previous behavior more; the big image preview is showed and no re-sort to the list.[/quote]That wasn't intentional, thanks for bringing it to my attention - I'll fix that.

[quote name='Akkurat' post='594539']Have you looked into the "window size not retained after updating" issue? I didn't see this in the SF tracker.[/quote]I don't remember fixing it, so I'll assume it isn't fixed, and add it to the tracker.

[quote name='Akkurat' post='594539']Can you please use the same update list both in this thread and in the "File Release Notes and Changelog" in sourceforge (+wiki)?[/quote]Different format, so can't use the actual same list. Apologies for not keeping them in better synch though. You may have noticed that documentation isn't my strongest area.

[quote name='Akkurat' post='594539']Why is the SF download page (http://sourceforge.net/project/platformdownload.php?group_id=187008) showing "Download Album Art Downloader XUI v0.23 installer" text/link even if that link downloads the 0.23.1?[/quote]Same reason as the app version showing 0.23. The .1 is just a nasty little footnote in history that shouldn't have happened, and the sooner we can forget about anything below 0.minor, the better :-)

...continued

...continued

[quote name='Akkurat' post='594539']Does the filebrowser scan FLAC (or any other) tags for covers?[/quote]For embedded covers? No. This app doesn't read or write embedded covers. It will read FLAC tags for the album and artist name, if that's what you mean. It will only do one of tags or filenames at a time, though, you can't search for both simultaneously.

[quote name='Akkurat' post='594539']I also noticed that it doesn't detect my "_folder.jpg" cover files[/quote]Add "|_folder.%extension%" to the end of the Specify Path to Find Images box in the file browser.

[quote name='Akkurat' post='594539']Filebrowser: wouldn't it be better to detect VA albums as just one album and not list all of the artists from it?[/quote]This has been covered in detail in previous posts. Basically, Various Artists can't be reliably detected in a standard way, so unless you are using File Path Pattern matching, and they're all in the same folder, AAD doesn't know they are all part of the same album.

[quote name='Akkurat' post='594539']Sometimes the "name:, size:, type:, etc." field "labels" are not visible for some of the search result items until I press the search again.[/quote]I haven't been able to reproduce this, but I'll try again after fixing the other bugs mentioned.

[quote name='Akkurat' post='594539']It seems that the sort is made only to the first dimension of the cover image, e.g. all images with 500px width are not additionally sorted by height.[/quote]Yes, that's true. I'll put that one down as a feature request, I think.

[quote name='Akkurat' post='594539'][/end bitchin.., I mean debugging]  Maybe I should de-bug-off myself. [/quote]Your efforts with putting together this information are appreciated!

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-20 19:46:09
OK, thanks to some great detective work by Akkurat, I think I've fixed the crashes reported. If you'd like to help me test this out, I've put up a debug build here: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe) (just drop it over the existing one in your program folder). I'd appreciate it if those of you experiencing the crash could let me know if this fixes it.

Oh, and Akkurat, in all those replies I made, I think I missed one:

The reason the filtering behaves the way it does (apart from the crashing, which should be fixed), is that if the full size image size is not known, then it filters on the size of the thumbnail, the theory being that if the thumbnail is over 50px big, then the full size image is going to be too. I appreciate that this might be confusing, though - it might be more clear to exclude unknown sized results from any filtered result set regardless of thumbnail size.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-20 19:57:16
OK, it works fine now; getting an assertion error with "Rate Your Music", though:

Quote
Script Rate Your Music threw an exception while searching: Der Remoteserver hat einen Fehler zurückgegeben: (500) Interner Serverfehler.





    at ScriptSource.SearchInternal(String artist, String album, IScriptResults results) 

    at Source.SearchWorker(Object state) 

    at ThreadHelper.ThreadStart_Context(Object state) 

    at ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) 

    at ThreadHelper.ThreadStart(Object obj)


Seems to be on their server.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-20 20:00:46
OK, it works fine now; getting an assertion error with "Rate Your Music", though:
Yeah, you can safely ignore assertion errors - they are silently dropped in release builds, but are shown in debug builds. Scripts, and the sites they depend on, can be fairly sketchy, so these things do pop up.

Thanks for letting me know the crash seems to be gone, though!
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-21 00:28:50
I'll answer this quickly, I'll get back to those other topics tomorrow.

I'd appreciate it if those of you experiencing the crash could let me know if this fixes it.

Still crashes.  Both test cases I wrote. Thou differently this time; no error log and with an error message window with text:
"Album Art Downloader has encountered a problem and needs to close.  We are sorry for the inconvenience.
If you were in the middle of something, the information you were working on might be lost."


The reason the filtering behaves the way it does (apart from the crashing, which should be fixed), is that if the full size image size is not known, then it filters on the size of the thumbnail, the theory being that if the thumbnail is over 50px big, then the full size image is going to be too. I appreciate that this might be confusing, though - it might be more clear to exclude unknown sized results from any filtered result set regardless of thumbnail size.

Ok, I understand to some point what you're saying, it's a bit confusing as you said. Your suggested behavior makes more sense but there's a pitfall: if the "automatically download" is set to never, user might miss some covers because there's a possibility to get confused of the settings.. I don't know, maybe my brains are not working at the moment, the more I try to think about it, the more I get confused. There, you see? I got very Konfutsed.

Off the top suggestion: make the change as you suggested AND put a "show unknowns" checkbox into "filter size" "group" and disable (greyed out) it unless the "automatically download" setting is set to "never"...?
Title: Album Art Downloader XUI
Post by: odyssey on 2008-10-21 08:14:49
A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).  This site has some of the best quality album covers on the web.  You may want to consider offering it as a selection choice in your application.  Why not give your users the best quality that is out there.

I'd also like this. Maybe someone has the ability to write a script for it?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-21 08:28:47

A note to the developer check out the following link AlbumArtExchange (http://www.albumartexchange.com/).  This site has some of the best quality album covers on the web.  You may want to consider offering it as a selection choice in your application.  Why not give your users the best quality that is out there.

I'd also like this. Maybe someone has the ability to write a script for it?

Does no one actually read my replies here? A script for Album Art Exchange was added back in version 0.16, and was updated in version 0.20 when they started providing an API. Please update to the latest version, and you should find it available there.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-21 08:43:28
Still crashes.  Both test cases I wrote. Thou differently this time; no error log and with an error message window
Huh. I wasn't expecting that. How about the problem where the list would update while the preview was being shown, does that still happen? The other crashes seemed to be caused by the fact that the code to suspend updates to the list was broken (which of course also stopped the list being suspended while the preview was shown). I've fixed that up, and the list updates should be being suspended properly now. If it's suspending, but still crashing, I've got to come up with another idea.

For the filtering, I think I'm going to have it so that  Unknowns are never filtered out. At least that way you know they are there, and can choose to ignore or download them as you please. If automatically downloading, as they are downloaded they might then become filtered out, if they don't meet the criteria.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-21 16:03:39
Still crashes.  Both test cases I wrote. Thou differently this time; no error log and with an error message window
Huh. I wasn't expecting that.
Can't you reproduce the crash with the steps I gave? Strange.

In case you didn't understand the German version of the error log, here it's in English (note: this is from the 0.23.1 version, not from the debug version!):
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.23.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
  at System.Collections.ArrayList.RemoveAt(Int32 index)
  at System.Windows.Data.ListCollectionView.ProcessCollectionChanged(NotifyCollectionChangedEventArgs args)
  at System.Windows.Data.CollectionView.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
  at System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
  at System.Collections.ObjectModel.ObservableCollection`1.RemoveItem(Int32 index)
  at System.Collections.ObjectModel.Collection`1.Remove(T item)
  at System.Collections.ObjectModel.Collection`1.System.Collections.IList.Remove(Object value)
  at AlbumArtDownloader.Controls.ArtPanelList.OnImageSizeChanged(Object sender, EventArgs e)
  at AlbumArtDownloader.AlbumArt.SetImageDimensions(Double width, Double height)
  at AlbumArtDownloader.AlbumArt.<>c__DisplayClass7.<RetrieveFullSizeImageWorker>b__6()
  --- End of inner exception stack trace ---
  at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  at System.Delegate.DynamicInvokeImpl(Object[] args)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
What I understand is that your code crashed because it tried to access an array index which was not there anymore. I'd guess that this is due to the fact that the filter removes covers from the result list and the process for getting the full size images ("RetrieveFullSizeImageWorker" perhaps?) tries to read an array index which was removed because of the filter. So, if you make the change to never filter out the "Unknowns" in the results list/window, I bet that the crash goes away.. or it might not.. or it could bring more problems (wrong index/image get).. it would be wise to check out that the "get full images" process always tries to access the correct index, which could have been moved or removed.. that is if the processes are run in parallel (the "update result list" & "get full"). Do I make sense at all or am I talking rubbish? I could be wrong.. considering that this "black box" testing I'm doing is pretty hard.

How about the problem where the list would update while the preview was being shown, does that still happen?
It's fixed. Thou honestly I still hate the fact that the cover is re-sorted (if it was different size) after I let the preview close. BUT, it's consistent now and no freezes so I guess I've to live with that. With big lists you could lose the position of the cover you were previewing. Although you could consider using, in example, a color indication (colored border on the image, put a transparent green "correct" image over the image (you could use a transparent disk image in same way for saved covers), etc.) whether the preview has been opened or not. This would make browsing much clearer, i.e. you instantly see which covers you've already checked.

In addition, it would be nice to have indicators for covers I've clicked to show the full size image in background (letting go of the preview window) when those are fully loaded. Now it only shows the "search" image in the left-top corner. A "search/download complete" image would be nice. This would also enhance the usability a lot. E.g. I always check many full size images and when they're big, the loading takes a while, and I like to open many "background full images", but it's hard to detect which images I chose when the full size image is ready.

For the filtering, I think I'm going to have it so that  Unknowns are never filtered out.
Good call. Maybe the best solution here.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-21 16:26:53
No, I can't reproduce it using the steps you gave me, not in the fixed debug version I put up.

The crash report there (in English or in German) is the same one as tuxman had, that seem to be resolved now for him.

In case you're interested, the cause behind it was due to a failure of the system for suspending updates to the results list. When the list is suspended, it is supposed to batch up additions and removals, then when the list unsuspends, play them back so that the UI can update itself. Further, when an image size changes, that result is removed and re-added to the list so that it gets placed in the correct position. Unfortunately there is no nicer way to convince the WPF control to re-order its contents than removing and re-adding them.

So, you can probably see where this is going now; the full size image would download, triggering a size change, which would be badly batched up by the suspended change system, then replayed incorrectly, causing it to replay the removal (prior to the subsequent immediate re-addition) of the changed item incorrectly, confusing the WPF list control which was being told that a non-existent item had been removed.

Anyway, that's all just for curiosity's sake, that particular problem is definitely resolved now, so if there is something else causing a crash for you, I've got to look elsewhere. You say you are finding it tough doing black-box testing - if there's anything I can do to make things easier for you in this regard, please do let me know!

I take your point about the item moving once you finish previewing. I'm going to see whether it is possible to scroll the list so that after you release the mouse, and it updates, the list is scrolled so that the result you just previewed is still visible. It might not be in exactly the same spot, but you should at least be able to see it.

I like the suggestion for indicating which images are full sized and which are not. I tend to to this just by looking at them - the fuzzy ones aren't full sized! I'll see what I can think up, UI-wise, to indicate this in a non-obtrusive way. I don't think an overlay is the best way to go, though - I'd like to keep the actual image unchanged.

Some good news for you, I think I've got window size and position settings upgrading working for 0.24.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-21 16:56:38
Wow, thanks for your detailed analysis and post!

Wow, you weren't disheartened by my massive post.  I've to confess that I've been couple of times in the REACT thread with big posts.. sometimes too much is just, well, too much.

The progress bar is for the source finding the results. The automatic download of full size images runs separately, and simultaneously, so making it affect the same progress bar will be tricky. You can even turn on automatic download after all sources have already completed searching, so the progress bars will already have been removed.

Would a separate progress bar showing the automatic full size image downloading progress be helpful? That could be accurately calculated and displayed, then you would know when the list won't be re-sorting any more.

Well, when you're right, you're right, the idea to use the source progress bar was not good. What you suggested sounds absolutely marvelous! Maybe a popup (since you don't have status bar) progress bar at the bottom of the results window?

IMHO it would be nicer to NOT active the drag&drop when holding down mouse button and previewing the big image. It seems that there's about 5px range for the d&d action to become active.. maybe increasing the range would suffice? (if that's possible)
Possible, sure, but I'm not sure what sort of range to make it. Is it just to eliminate wobbly-mouse problems, or is there some reason to be moving the mouse around while previewing? It's going to be tough to know when to initiate a drag.

Yes, it would be just for eliminating wobbly-caffeinedeprivation-mouse problems.  10-20px?

Can you please use the same update list both in this thread and in the "File Release Notes and Changelog" in sourceforge (+wiki)?
Different format, so can't use the actual same list. Apologies for not keeping them in better synch though. You may have noticed that documentation isn't my strongest area.

Yeah, I meant in sync, not the format. Show me a coder who IS good at documentation, I'm crap at it and I hate it soooo much.  Coding my REACT mod, I've learned always to write down a documentation/changelog (if needed) for a particular update/change/new feature I just have coded. This way the documentation process doesn't get too boring, baby steps, baby steps to open the changelog, etc.

Sometimes the "name:, size:, type:, etc." field "labels" are not visible for some of the search result items until I press the search again.
I haven't been able to reproduce this, but I'll try again after fixing the other bugs mentioned.

Ok, I hope I found the way to reproduce this; do a search (any search), then minimize the cover "area" until the labels drop off, then press search again = labels are back. It doesn't matter if you're showing the info below or on the side.

Remember that sometimes, for some of the result list covers, this happens after searching (no resizing of the result cover areas).

Actually now when I look at the "on the side view" without the labels, I kind of like it better. The info is pretty self-explanatory, so maybe the labels could be turned off from settings? Jésus, it seems that I'm full of ideas/suggestions at the moment, sorry. Pick out the best (if any) if you like.

Your efforts with putting together this information are appreciated!

Your lightning fast replys and fixes are very much appreciated!! Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-21 17:22:43
Well, when you're right, you're right, the idea to use the source progress bar was not good. What you suggested sounds absolutely marvelous! Maybe a popup (since you don't have status bar) progress bar at the bottom of the results window?
Hah, great minds... from the upcoming 0.24:

(http://www.byalexv.co.uk/temp/AADprogressBar.png)

I've also increased the drag start size, and some informal playing about with it seems to show that 32px works well enough.

Ok, I hope I found the way to reproduce this; do a search (any search), then minimize the cover "area" until the labels drop off, then press search again = labels are back. It doesn't matter if you're showing the info below or on the side.
Got it, thanks. Issue added to the tracker for this.
Title: Album Art Downloader XUI
Post by: Zarggg on 2008-10-21 17:38:24
Maybe I just didn't read the FAQ/manual/etc closely enough, but when "automatically download..." is enabled, does it actually save the files, or just store them in temp?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-21 17:42:24
Maybe I just didn't read the FAQ/manual/etc closely enough, but when "automatically download..." is enabled, does it actually save the files, or just store them in temp?
They are just stored in memory until the window is closed. Nothing is automatically saved to file using this option.
Title: Album Art Downloader XUI
Post by: Zarggg on 2008-10-21 17:43:34
Excellent!
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-21 17:58:07
No, I can't reproduce it using the steps you gave me, not in the fixed debug version I put up.

The crash report there (in English or in German) is the same one as tuxman had, that seem to be resolved now for him.

It would be interesting to see if tuxman passes the two cases I wrote down. EDIT: I just PM'd tuxman.

..so if there is something else causing a crash for you, I've got to look elsewhere.

Unfortunately. Tell me what to do. The crash happens exactly the same but instead of errorlog, I got error window. Put lot's of debug points and send me the exe.

You say you are finding it tough doing black-box testing - if there's anything I can do to make things easier for you in this regard, please do let me know!

No no, I've no interest to throw myself into learning your code, would take too much time to even understand a small bit of your codebase. I merely covered my ass if my guess for the problem would be wrong.

I take your point about the item moving once you finish previewing. I'm going to see whether it is possible to scroll the list so that after you release the mouse, and it updates, the list is scrolled so that the result you just previewed is still visible. It might not be in exactly the same spot, but you should at least be able to see it.

Hmm, couldn't you just ignore the change for those covers resort-wise? Didn't the previous versions work like this?

I like the suggestion for indicating which images are full sized and which are not. I tend to to this just by looking at them - the fuzzy ones aren't full sized! I'll see what I can think up, UI-wise, to indicate this in a non-obtrusive way. I don't think an overlay is the best way to go, though - I'd like to keep the actual image unchanged.

That's not actually what I meant, I meant that indicate which full size images have been loaded from net after clicking to show the preview and letting the preview close before the image has been loaded. The "search" icon overlay on top of the small image (not the preview image "window/dialog") shows nicely what images are being fetched, BUT, when they're fetched there's no indication of that.. and if you clicked many images to load the full sized images in the background, you have a very hard time knowing which ones you did click. Add the resort feature for changed sizes images, and you're totally lost which ones you put into "download mode". I hope you understand what I mean.

Fuzzy ones are impossible to detect in side view with small images. I guess you have bottom view and a big stretched cover area so that the images are huge.

Some good news for you, I think I've got window size and position settings upgrading working for 0.24.

It's unbelievable how fast you work, I just peeked in the SF tracker & SVN repo and started to worry about your Real Life™.  And mine too, this takes so much time.. but it's for good cause.. and I benefit from this also.

BTW. Is it possible to include AAD XUI in my REACT mod release in the future? I've some plans (actually my ToDo list is huge) to update the mod in near future. Though I've to fix many things in config files and in the REACT code before I could put XUI to the rel.. but nonetheless I thought to ask now since it popped into my mind.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-21 18:19:02
I think I've come up with something reasonably nice for indicating which of the results have full sized images already downloaded. I'm now displaying the image dimensions greyed until a full sized image has been downloaded, which suggests that these dimensions aren't confirmed yet, and are only an estimate provided by the source. (In fact, for some of the scripts, they're even worse - just a usual size of image returned by that source!) Once the full size image is downloaded, the image size appears black like the other information.

That should make it quick to tell at a glance which ones have full size images downloaded already.

Here's a link to a compiled version of the current state of 0.24 (note to others - this does not represent the final 0.24 - you can download this if you like, but it is unsupported and unfinished). If that one crashes, it should at least provide an error log. AlbumArtDownloaderXUI-0.24.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.24.zip).

Yes, you are welcome to include AAD XUI in your REACT mod. Send me a link when you do, I'd be interested to see it in use!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-21 19:25:23
As for the buy.com script: sure, you can include it in the next release.
I've made a few changes to it and added cover type support (which wasn't very hard to do)
Here is the latest version: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
I'm about to include this in version 0.24, but before I do, is there any chance you could make it provide thumbnail images? It does help a lot with the search responsiveness. If it really can't be done, then just leave the full sized image parameter of the Add call as null, so it just uses the thumbnail as the full sized image rather than re-downloading it a second time.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-21 20:31:52
I think I've come up with something reasonably nice for indicating which of the results have full sized images already downloaded. I'm now displaying the image dimensions greyed until a full sized image has been downloaded, which suggests that these dimensions aren't confirmed yet, and are only an estimate provided by the source. (In fact, for some of the scripts, they're even worse - just a usual size of image returned by that source!) Once the full size image is downloaded, the image size appears black like the other information.

That should make it quick to tell at a glance which ones have full size images downloaded already.

The crashes went away, yea!

But, infamous but, now the unknown images which become "known" and are in example, below the minimum filter px, are NOT removed from the list.  After all searches and full-size image downloads are over, I've to re-apply the minimum filter setting for it to become effective. + sort also fails with these results. Crap. Actually I just noticed that it sorts some of the covers, not all.

Steps to reproduce both problems:
1) set download when unknown
2) set minimum filter 600px
3) set group by source (just in case this affects too)
4) set sort by size desc
5) select ONLY "LastFM Artist" source (limit to 40)
6) search metallica / metallica

= minimum filter has no effect
= notice that the first (at least in the beginning of the "download full sizes") 2 covers detected (in my search this happens this way) are 1000px wide and placed at the top. When the "download full" continues, smaller than 1000px wide images are NOT sorted.. then about in the middle there comes 2 covers with 1424 width and they ARE placed at the top before the 2 1000px wide covers. Strange. Maybe the first result is used as the "base" in all comparisons? It would explain the behavior I'm seeing.


Discogs source shows image sizes in grey even if they really are full sized straight from the get go. Not a big problem, I just thought to mention this. Were there other sources too with no thumbnails?

One new thing, sorry, when after the first search, you add more sources and click search again, the "stop all" doesn't popup anymore. Only after you change the search artist &/ album.

new progress bar = fabulous
image size grey -> black text = ok
drag&drop area = ok

Were there more fixes/changes? (sort asc/desc fixed, others?)

And yes one thing more; I noticed that the "download unknowns" gets only 1 image at a time including all sources. If the download stagnates for one source, it could get really boring to wait for all of the covers in the queue to finish. I already saw this happen almost everytime I did my tests with the above problems. This could get complicated, but could you change it so that it gets only 1 image at a time PER source? This way one stagnating source doesn't affect all.

I hope you're not getting tired with me.

Yes, you are welcome to include AAD XUI in your REACT mod. Send me a link when you do, I'd be interested to see it in use!

Thanks, I will. Though people are already using AAD XUI with REACT, it's just that REACT doesn't support it fully at the moment (limited support for other than .jpg's (only jpg's in the "original" AAD) -> some encoders crash, etc. bugs/problems).
Title: Album Art Downloader XUI
Post by: alsaan on 2008-10-22 00:48:22
As for the buy.com script: sure, you can include it in the next release.
I've made a few changes to it and added cover type support (which wasn't very hard to do)
Here is the latest version: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
I'm about to include this in version 0.24, but before I do, is there any chance you could make it provide thumbnail images? It does help a lot with the search responsiveness. If it really can't be done, then just leave the full sized image parameter of the Add call as null, so it just uses the thumbnail as the full sized image rather than re-downloading it a second time.

Alex

Ok, I followed your suggestion and made some performance improvements: http://alsaan.iespana.es/buy-com.boo (http://alsaan.iespana.es/buy-com.boo)
It's still a bit slower than I'd like, but it will do the job for now.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-22 09:30:01
now the unknown images which become "known" and are in example, below the minimum filter px, are NOT removed from the list.
I wasn't able to reproduce this. Following the steps you gave resulted in exactly correct behaviour. As each Unknown image was downloaded, it was removed from the list, with the exception of two results at 1000px width, and two at 1424px width. These were sorted in the correct order.

I'm guessing the reason that the images smaller than 1000px are sorting incorrectly for you is that they aren't supposed to be there at all (should have been filtered out), and are therefore not being sorted at all.

Are you clicking on any preview images, or scrolling during the search? Do you have a maximum filter turned on? Anything else you can think of we might be doing differently?

Discogs source shows image sizes in grey even if they really are full sized straight from the get go
You know that, and I know that, but AAD has no way of knowing that the size is accurate until it tries to get a full size image for them, and is told by the script to just use the thumbnail.

One new thing, sorry, when after the first search, you add more sources and click search again, the "stop all" doesn't popup anymore.
Tracker added - I'll look into that.

Were there more fixes/changes? (sort asc/desc fixed, others?)
Also: Window Size and Position should have been upgraded, the popup preview should ensure that the previewed image is brought into view when it closes, and the information label re-appearing should have been fixed.

could you change it so that it gets only 1 image at a time PER source?
Not really. The full sized image download worker is a low-priority background thread that crawls over all the results downloading the full sized images when appropriate. Having one thread per source would be a major architectural change that I won't be doing any time soon.

What I could do would be to add an option for each source (next to the Limit Results option) to ignore thumbnails for that source and download full size images right from the start. That way they'd be downloaded as part of the initial search, in that plugin's search thread. Would that be any use?
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-22 20:31:26
I wasn't able to reproduce this. Following the steps you gave resulted in exactly correct behaviour. As each Unknown image was downloaded, it was removed from the list, with the exception of two results at 1000px width, and two at 1424px width. These were sorted in the correct order.

I'm guessing the reason that the images smaller than 1000px are sorting incorrectly for you is that they aren't supposed to be there at all (should have been filtered out), and are therefore not being sorted at all.

Are you clicking on any preview images, or scrolling during the search? Do you have a maximum filter turned on? Anything else you can think of we might be doing differently?

No maximum filter, not doing anything while searching & downloading full size images. You're right about the reason why some of the images are not sorted, so the situation now is that only the filter isn't working.

I tested this problem with WinXP SP2 in MS Virtual PC, just normal windows install with all the latest updates (-this month updates), installed .NET3.5 = same thing, filter doesn't work.

Can you test this with some other computer which doesn't have your IDEs, SDKs and such dev. tools? I find it odd that this doesn't work in "vanilla" WinXP.

You know that, and I know that, but AAD has no way of knowing that the size is accurate until it tries to get a full size image for them, and is told by the script to just use the thumbnail.

Ok, just as I thought.

Also: Window Size and Position should have been upgraded, the popup preview should ensure that the previewed image is brought into view when it closes, and the information label re-appearing should have been fixed.

Works. Excellent.

What I could do would be to add an option for each source (next to the Limit Results option) to ignore thumbnails for that source and download full size images right from the start. That way they'd be downloaded as part of the initial search, in that plugin's search thread. Would that be any use?

I guess yeah, more features is good I guess.. thou it could confuse some users since there's the "download full size images : never" option. Maybe the functionality AAD has now is good enough (regarding this topic ).


New thing again: the "LastFM Artist" source returns some images twice. It seems that this happens with images which have the same link as the image below as a text link (jsus, does that make sense? English is sometimes hard).. look at this example gallery (http://www.last.fm/music/Corduroy/+images), the last image is the only one that has an extra link to the picture underneath it (text: l_af929402e4888ea54bd..), and if you search "corduroy" in AAD, only that image is listed twice.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-22 21:19:46
Can you test this with some other computer which doesn't have your IDEs, SDKs and such dev. tools?
No, I'm afraid not. Even if I could, it might not be that much help if I can't reproduce it with a debugger available.

Just once thing occurs to me, in the environments you tested in, was it .net 3.5 SP1? or plain 3.5?

Weird about that LastFM artist thing, I wonder why they've got that junk text link under the picture. I'll tweak the script to ignore it.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-23 02:23:27
First, I'll vent out, I hate Micro$oft & I hate .NET even more after this. Thanks MS and your .NET POS and it's versions that are NOT (or should I say .NOT) versions, etc. crap (e.g.: after updating to 3.5 SP1, your existing 2.0 SP1 & 3.0 SP1 .NETs are updated to SP2 (these are NOT available separately, only with 3.5 SP1)... yeah, makes perfect sense.).

As you may have already guessed, the problem is solved. Installing .NET 3.5 SP1 to my VPC Win image solved it... at least in VPC image, I don't have the time or opportunity to install it on my "main" system at the moment because I "can't" reboot now (only hibernate).. but I'm sure it will work there too.

I didn't know that 3.5 SP1 was out, windows update (website, not the systray popup crap) doesn't offer it (all previous updates have been there), released on 8/11/2008, couple of months ago but still not in win update. Thumbs up MS, great work. One funny thing more: if you download just 3.5 ("bootstrapper"), the filename is "dotNetFx35setup.exe", guess what filename is used with 3.5 SP1? Yes, same "dotNetFx35setup.exe". -b Same thing with full setup downloads. Filename description & product name say that it's "Microsoft .NET Framework 3.5", the only way to know that it's SP1, is to "know" that the file version "3.5.30729.1" is the SP1.  It's so terrible that you can only laugh. Well, MS is known for poor versioning, but this time they stepped into big pile of.. eh pudding.

@Alex: So, it seems that you have either just upgraded to SP1 or started to use new features from it in AAD. I bet that you like .NET less after this.  Is there tools available to .NET IDE to track framework requirements of written code? Maybe it would be best to automatically push AAD users to new framework versions if you upgrade.

Btw. remember to update the first post link to the SP1.. and put up reminders everywhere.

Aaaannndd, one thing more.. it seems that this never stops.  I've now noticed couple of times that sources sometimes gets more images than the limit is. E.g. last search to "Darktown" returned 11 images (all different) while the limit is 10. Again, I've to say that this is not a biggie, and I've only seen, IIRC, 1 or 2 images over the limit. Nonetheless, I thought to report this so that you can keep an eye out for this. Small test: 10 searches, 2x 11 results (no filters used).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-23 08:07:57
Yeah, they've really dropped the ball on that one. I upgraded to SP1 some time ago, actually. I can't remember exactly when, but I would have thought at least version 0.22 would have been compiled under it.

Anyway, I haven't used any new features from SP1, but SP1 did include a whole bunch of bug fixes and performance enhancements for WPF. One of which must have been to fix some buggy behaviour of the list control the results list is based on.

The IDE does track requirements of written code, and can be made to enforce requirements too. Unfortunately, it does not regard SP1 as any different from 3.5, so while I could track and enforce .net 2.0, 3.0 or 3.5, I can't do so for SP1. Not that it would help anyway, as the code I have used is supposed to work on plain 3.5 too, it's just 3.5 has some bug with it.

So, options now... well, first, I need to find a way to detect whether AAD is running on SP1 or not. Once I can do that, my first choice would be to implement some work-around code that makes it update the list correctly, at the cost of performance. Probably clearing the list completely and repopulating it would work, rather than just repopulating the single changed item.

I'll also have it pop up a warning on first run that installing SP1 would improve performance, and, of course, update the link in the posts to point to the SP1 installer.

Finally, I'll have a look at that maximum results thing. Sounds very strange, but I'll see if I can figure out what's going on. Probably some sort of timing thing.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-23 08:44:07
OK, no joy on detecting SP1 yet, but I've put together a version with what I am hoping will be a workaround to the filtered items not being removed thing. Note that in this version the bringing into view of the previewed result will not work. That is a side-effect of the workaround, and can't be helped.

AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe)

Could you let me know if it helps at all on a no SP1 system?
Title: Album Art Downloader XUI
Post by: acmodeu on 2008-10-23 20:30:43
Just one question. When AAD learns to remember file extensions? If you click on a picture, choose "save as" and enter a new filename, you also have to put an extension for the file, otherwise AAD saves file without any.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-24 00:35:20
Could you let me know if it helps at all on a no SP1 system?

Nope. Same behavior. I got that you don't have 2nd computer to test things out, right? Why don't you use MS Virtual PC (http://www.microsoft.com/windows/products/winfamily/virtualpc/default.mspx)? It's free. Though I'm considering moving to VirtualBox (http://www.virtualbox.org/) because at the first glance it seems to have a better "snapshot" system.

You might want to look at this: Update on .NET Framework 3.5 SP1 and Windows Update (http://www.hanselman.com/blog/UpdateOnNETFramework35SP1AndWindowsUpdate.aspx). There's a patch coming to SP1, before MS puts it in Windows Update.. one user comment is indeed funny: "How will we distinguish between 3.5 SP1 unpatched and 3.5 SP1 patched? Will it now be called 3.5 SP2? Or maybe 3.5 SP1 SP1!", good question knowing microsoft versioning.

If I understood correctly, the "plain" .NET 3.5 has not been in WUpdate yet.. at least I didn't see it when I just upgraded my VPC XP image to the 3.5 SP1.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-24 07:40:21
If you click on a picture, choose "save as" and enter a new filename, you also have to put an extension for the file, otherwise AAD saves file without any.
Thanks for reporting this, I'll fix it for the next version.

Why don't you use MS Virtual PC (http://www.microsoft.com/windows/products/winfamily/virtualpc/default.mspx)?
I guess I'll have to then. Hopefully I'll find some time over the weekend to set it up, dig up an XP install disk and put Windows on to an image.
Title: Album Art Downloader XUI
Post by: Light on 2008-10-24 11:23:55
i used a weird mouseclick sequence and now i only see the albums when i search for album art, like this:

(http://www.picvalley.net/u/1201/417972158_s.JPG) (http://www.picvalley.net/v.php?p=u/1201/417972158.JPG)

can i get that back to 'normal'? Like this:

(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FullArtPanel.gif)

And i have a simple solution to the 'various artist' folder problem... In the foobar browser, simply add a little toolbar or something where you can select folders you want to discard in the search, so that you can add anything you want, i'm thinking about: Skip : VA-*|VA_-*|Various*

Maybe that can work...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-24 11:35:06
i used a weird mouseclick sequence and now i only see the albums when i search for album art
See the grabber (line of grey dots) on the right-hand edge of the result, just past the thumbnail image? When your mouse is over that, you should get a horizontal resize cursor : <->. Click and drag the grabber to the right to expand the area so that you can see the text again.
Title: Album Art Downloader XUI
Post by: Light on 2008-10-24 11:43:12
ah yes, that was it. Thanks, i made the picture too big by accident
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-25 03:53:26
"AllCdCover" source started to show "yes, we have the cover you're looking for, but no, we can't show it to you" custom image for some results.  I searched: "supergrass / i should coco", all 3 covers showed thumbnails but previewing them showed "don't leech" images with the above text.

2nd search only to that source showed correctly all, even the full size images in preview!? It could be that I fudged this test up; removed other sources and clicked search again -> no new search.

3rd search (all sources) showed same 3 "AllCdCover" thumbnails, and I mean ONLY thumbnails. I almost missed those because I had the minimum filter set at 495px (the previous searches showed them because AllCdCover returned the full size image sizes). No "don't leech" images this time!?

4th and all subsequent searches show only thumbnails like in the 3rd search.

It seems that they've coded some leech prevention system to their website (maybe IP restriction). Or what's wrong?

Ok, I tried to search some other covers and it definitely seems that they really are doing IP restriction (with time limit maybe?), all covers are thumbnails.

This is the big minus of AAD type of programs, you constantly have to fix sources because they restrict their service, and I do understand them to some point.. though I'm not so sure about the legality of their services, so.. AAD leeching from illegal services, who's the villain here? xxAA's?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-26 20:23:56
About the AllCdCover thing, it sounds like some sort of leech prevention, yes. I'm not getting those results here, probably because I haven't downloaded a lot of images from them using this IP address! If you want to address your concerns to daju, the author of that script, he might be able to do something about it, but frankly I doubt it.

If the script is no longer useful because of this, I will remove it from the installer, but as it is working for me at the moment, my preference would be to leave it in and see what happens.

On another subject, I've finally managed to get a pre SP1 environment running in a virtual machine (damn, but that was a pain to set up), and think I have something that should fix the list refresh bug. It's performance is a bit worse, so I've added a one-time warning that performance can be improved by downloading SP1.

Let me know if this does the job: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe)
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-27 00:26:48
About the AllCdCover thing, it sounds like some sort of leech prevention, yes. I'm not getting those results here, probably because I haven't downloaded a lot of images from them using this IP address! If you want to address your concerns to daju, the author of that script, he might be able to do something about it, but frankly I doubt it.

If the script is no longer useful because of this, I will remove it from the installer, but as it is working for me at the moment, my preference would be to leave it in and see what happens.

I ran the test again just now and I couldn't reproduce the previous problems. Just as I suspected. I did some detective work again and I noticed that when browsing their site, the full image download URL changes:

1st:
www.allcdcovers.com/download/cfb45d83c6f1ba7a6785441ce28e7356/90123/8cd3a44d0c5cd3bd4ec72c0e04a74f17/4904f992/supergrass_diamond_hoo_ha_2008_retail_cd-back

2nd (after clear cookies & clicking the download button again):
www.allcdcovers.com/download/cfb45d83c6f1ba7a6785441ce28e7356/90123/9969abe0a29799a44b2a67bb2b905bef/4904fa53/supergrass_diamond_hoo_ha_2008_retail_cd-back

These URLs work (refresh) even if you clear cookies. Then I waited about 10-15 minutes before I refreshed the images again, wellwell, here it is again; the "don't leech" image.

So, it seems that this would happen in AAD if user searches some covers and doesn't touch the results for a while. After that "don't leech" image, all subsequent searches would yield only thumbnails (or possibly the "don't leech" image) for X amount time which has been set by AllCdCover in the server side. Yes, it's definitely an IP address leech prevention; right after the both above image URL's "failed/timeouted", all my AAD searches started to show only thumbnails.

I then waited about 20-30 minutes and ran AAD search again, still thumbnails. Then some browsing in their website, all full size images load up fine. Back to AAD, still thumbnails. Tried to close&reopen AAD, nope, still doesn't work.  Nasty leech prevention.

I'll PM daju just in case to read this post.

Let me know if this does the job: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe)

Excellent. Unfortunately I just upgraded my main system last night. I quickly tried to uninstall SP1 in my VPC and reinstall plain 3.5, but it seems that the bug was corrected in either 2.0 SP2 or in 3.0 SP2 and I'm not going to start uninstalling&reinstalling those. Sorry. I'm sure it works ok if you tested it in 3.5.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-28 02:32:40
Hi again. Guess what? One new problem.

I've seen this couple of times in the past but finally I awoke to report this.

Sometimes the full size preview image is cropped and is not showing the full image. I understand that very big images must be resized in order to see them in full in preview, but, it seems that some images are resized badly, i.e. cutting some portion of the image away from the preview. Now, this is crucial because user might discard that image because it seems that it's poorly scanned/cropped. Only by saving the image and checking it with other software, user sees the real image.

My screen resolution is 1280x1024 & I've taskbar in autohide mode (I tried w/o it but that had no effect) and in top of the screen (no change when moved to bottom).

Here's one example:

1) search "manic street preachers / gold against" from "AllCdCover" source (you should see 2 results)
2) click the thumbnail of the front cover; notice how it seems that the image is cropped thru the band & album name in the bottom of the image
3) save image
4) open the image with external software

= the artist & band name text is fully visible

I noticed that the other result (back cover) is also slightly cropped from the bottom in the preview.

I enlarged the thumbnail view and the thumbnail is not cropped.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-28 07:51:10
The size of the popup preview is limited by your screen resolution. It is deliberately not resized, as the point is to be able to see it at 1:1 zoom, for quality inspection.

If you want to see the real image in detail, to check the cropping at the edges or zoom in to an area of interest, then you don't need to save and open with another editor, just right click on the image and choose "Preview". You will then get a new resizeable preview window with the image in it you can scroll and zoom as you please.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-28 12:56:25
The size of the popup preview is limited by your screen resolution. It is deliberately not resized, as the point is to be able to see it at 1:1 zoom, for quality inspection.

I'm confused. You say that the popup preview is NOT resized ever? Ok, if my screen resolution is 1280x1024, then how is it possible that I can see the full size of image (this one is not slightly cropped at the bottom) which size is 2845x1398? No resize? I'm sorry but I don't understand. Or is this a confusion over word semantics? Scaled/resized/?

Anyways, the point is that for some images a small portion of the bottom part is not visible in popup previews and I consider that as a bug. The screen resolution makes no difference since AAD tries to show the whole image (and succeeds in that for most of the images), no matter how much bigger it's compared to the screen resolution.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-28 13:08:24
Ah, no, don't worry, it's me getting confused, I'd forgotten I'd changed the behaviour of large popups a while back. I'll look into the cropping problem, thanks.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-28 13:31:40
Ok, thanks a lot again. For your sanity's sake I hope I'm finished with "hitting AAD with my blessed +10 Debug sword".  BTW the image preview window was new to me, nice "new" feature.. I wonder what else I've missed.
Title: Album Art Downloader XUI
Post by: Zarggg on 2008-10-28 16:33:32
Two quick questions: Does this program only search out .jpg files? If so, any chance on having it (optionally) also search for .png?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-28 16:55:11
Two quick questions: Does this program only search out .jpg files? If so, any chance on having it (optionally) also search for .png?
No, there is no limitation on file format. Most cover sites provide .jpg files, but there are a few that also have .png's. There are so few .png's around that it can be hard to notice, but the occasional one is there.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-28 20:38:29
I see that you already have fixed the crop problem. Unbelievably fast. Excellent.

I've one thing more, this time not a bug/problem but a GUI "rethink": with my screen res. 1280x1024, taskbar in autohide and maximized AAD window, all of the sources are just visible. I noticed that you have one new source coming and it's going to put my source list to scroll, which isn't so nice because I'd like to see all the sources at the same time (searches, number of results).

Could you redesign the source list so that more sources could be fitted there without a scroll? One way to do this would be to cut the second line from the source info. Make the source a bit wider so that the search progress bar fits to the right side of the source name. Clicking the source name would open the options. The version and the author would be shown at the bottom in the options for that source. I made a quick mockup of it.. it's a bit crowded, especially with the search prog. bar.. this is just an idea, feel free to diss this down.
(http://img386.imageshack.us/img386/4913/aadpb5.jpg)
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-28 21:33:03
I wonder why it tells me that it will "probably run slower" with my current configuration...

.net 3.5 SP-1 is available, I "only" got .net 3.5, so AAD came up with a strange message...

I guess it should be more tolerant... v3.5 is v3.5, basically.

Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-29 00:00:19
I wonder why it tells me that it will "probably run slower" with my current configuration...

.net 3.5 SP-1 is available, I "only" got .net 3.5, so AAD came up with a strange message...

I guess it should be more tolerant... v3.5 is v3.5, basically.

I see, you haven't followed this thread. There's a bug (bugs?) in 3.5 which was causing AAD to fail one feature. Alex made a fix/workaround if plain 3.5 is installed which could (or probably will) lower the performance. So no, it shouldn't be more "tolerant".. at least you can run AAD and it works.. + you got a notice which suggests that you should upgrade your .NET.. pretty cool? And yes, 3.5 is 3.5 but 3.5 SP1 is 3.5 SP1.

Did you download that "test" version from the same post which had the following text by Alex over the link: "I have something that should fix the list refresh bug. It's performance is a bit worse, so I've added a one-time warning that performance can be improved by downloading SP1."

You were too busy to read?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-29 07:49:48
Akkurat, thanks for the suggestion for the sources list. I don't think I'll go with that, though, as it would make the list quite a bit wider. The example you gave was using one of the shorter source names. To fit the longer ones in, the list would either become unacceptably wide, crop the name of the source, or have sideways scrolling. I prefer the vertical scrolling solution to all of those options.

You could always delete some scripts, if you really want to avoid vertical scrolling. Juno, PsyShop and RevHQ are all fairly specialist, and LastFM Cover often turns out to be duplicates of other sources.

v3.5 is v3.5, basically.
It would be nice if that were true, unfortunately it just isn't. I didn't put the warning in for the fun of it!

Under SP0, whenever I need to remove a result from the list (for example if it doesn't meet the minimum size filter), or reposition it (for sorting), then the whole list must be rebuilt. Under SP1, just that single changing item needs to be altered. Apart from being a monumental pain to track down and work around, this is also considerably slower, and I thought a warning might be useful.

If you leave the "don't ask me again" box checked, you won't see it again, and can safely ignore it.
Title: Album Art Downloader XUI
Post by: tuxman on 2008-10-29 11:41:54
Did you download that "test" version from the same post which had the following text by Alex over the link: "I have something that should fix the list refresh bug. It's performance is a bit worse, so I've added a one-time warning that performance can be improved by downloading SP1."

You were too busy to read?

Yep, obviously... I'm quite sorry. 
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-10-29 16:56:30
I don't think I'll go with that

You could always delete some scripts, if you really want to avoid vertical scrolling. Juno, PsyShop and RevHQ are all fairly specialist, and LastFM Cover often turns out to be duplicates of other sources.

Sorry no, I don't like "bubblegum" solutions.  Oh well, was worth the try.. you could invent a new way to list the sources, *wink wink*, maybe some day.

Yep, obviously... I'm quite sorry. 

Nothing to be sorry about, it was a friendly tease.
Title: Album Art Downloader XUI
Post by: unabatedshagie on 2008-10-29 17:10:17
I have my music stored in the following format.

H:\$left(%albumartistsort%,1)\%artist%\[%date%] %album%\

Which equates to

H:\B\Jeff Buckley\[1994-08-15] Grace\

Is there any way of automating AAD to save in this format?

Also I was wanting to use this to save artist pictures.

Is there any way to automate this using AAD? Is there any way of using the foobar browser to get the artist tag from the files?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-10-29 17:29:48
Is there any way to automate this using AAD? Is there any way of using the foobar browser to get the artist tag from the files?
AAD will not be able to automatically determine where to save the art in this format, not least because it doesn't have information such as the date available.

However, if you are launching AAD through foo_run, you usually pass in the full path to save the image to anyway, so that probably won't be much of an issue for you. Similarly, if you are starting from the foobar or file browser, then it already knows the path to the folder the music is in, and will store it there by default.

If you want the information from the tags in the files, the file browser should be able to extract them using the default "Use ID3 tags from files" setting.

If you want the artist and album information from your foobar library instead, use the foobar browser instead of the file browser.

If you do want to use file path pattern matching to match artist and album for the file browser, then you can use the pattern:

H:\*\%artist%\"[^\]]+] "%album%\.

(I think - untested, so if it doesn't quite work, let me know and I'll have another go)

It's a slight variation on the normal pattern which makes it ignore all characters up to the ] character, and a following space, for the album folder name.

If this doesn't answer your question, I've misunderstood what you are trying to do - please try explaining again and I'll do my best to answer!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-11-01 08:14:23
Album Art Downloader XUI v0.24 Released

This is primarily a bug fixing release. Thanks to the tireless efforts of Akkurat and other helpful forum members, many bugs and minor issues have been tracked down and fixed. Apart from bug fixes, this release also adds a new script, for CDCoverHideout, and a shiny new progress bar that is displayed while automatically downloading full sized images (if you have that option enabled).

There's a couple of slight behaviour changes to be aware of: Images of Unknown size are now always included, regardless of size filtering settings, and if the full size image for a result has not yet been downloaded, then the size of that image is displayed in grey, as it can't be confirmed as accurate (accuracy will depend on the source).

Finally, it seems that the .net Framework 3.5 has a bug in it that is resolved in 3.5 SP1. I've therefore updated all the links to point to the 3.5 SP1 version, and would recommend anyone who hasn't done so already to upgrade to it. I've put in some compatibility code into Album Art Downloader XUI, so it will still work under 3.5, just a bit slower. For this reason, the first time it is run under 3.5 it will display a warning. If you don't want to upgrade to 3.5 SP1, feel free to ignore it, though.

Full list of bug fixes in this version:Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.24.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.24.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: GHammer on 2008-11-02 07:05:55
Thank you very much for an extremely useful and usable tool!
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-11-03 23:20:32
Thanks for the update!

Sorry, new bug introduced by "Fixed bug where "Stop All" would not appear when adding or removing sources from a search":

1) select 1-n sources
2) search something
3) wait for the search to stop
4) click search again

= bug: "stop all" appears although nothing is searched (because there was no change to the artist/album fields, nor to the limits).. also clicking that link doesn't do anything for obvious reasons.

Make sure that the "stop all" is showed after search click only when user has added sources OR the artist/album fields are altered (OR, when increasing the limit of a source).. i.e. when a search is really done, not only when search button is clicked. I guess you've to store the selected sources list between searches and compare it to the selected ones when starting a search (without this, I guess it would be hard to detect a source being first unselected and then reselected before a new search).
Title: Album Art Downloader XUI
Post by: Xenion on 2008-11-04 00:28:56
thank you so much for that software
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-11-04 08:09:11
Sorry, new bug introduced by "Fixed bug where "Stop All" would not appear when adding or removing sources from a search"
OK; I've added a tracker issue for this. It's only cosmetic, though, so I'm not going to rush out a fix for it immediately.
Title: Album Art Downloader XUI
Post by: leadfoot on 2008-11-15 04:16:13
OK, from what I have read, the  | separates an either | or. What I would like to do an this AND that: I would like to save a folder.jpg and an %artist% - %album%.jpg. Is this possible?

Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-11-15 07:58:01
What I would like to do an this AND that: I would like to save a folder.jpg and an %artist% - %album%.jpg. Is this possible?
Sorry, no, only a single copy of the image is saved. You could use Save As, or set up presets so that you could easily switch between the two, but you would still need to actually save it twice to get two copies.
Title: Album Art Downloader XUI
Post by: leadfoot on 2008-11-15 18:46:38
Yeah, I was afraid of that. I have a way of doing this, but it takes another program.  Thanks for following up.
Title: Album Art Downloader XUI
Post by: herojoker on 2008-11-23 21:59:28
Is it possible to automatically set the default preset to the type the image is categorized in?
For example I get a result list with some images grouped in "Back", some for "CD" and some for "Front".
I have setup values for the corresponding presets and now I want (if it's correctly grouped) just press the save button and get the files saved as back.jpg, cd.jpg or front.jpg (based on what the current image is), but only the value for "Default" is inserted when using %preset% in the path.

Another issue: Automatic renaming if a file with the same name is already existent would be nice. For example I get 5 different inlays as result, then I want to save them by just clicking the save button as Inlay 1, Inlay 2, Inlay 3, Inlay 4 and Inlay 5. It would be ideal if the user could setup naming rules for this case, one rule for each type (CD, Front etc.). I want different rules for different rules because usually I save 2 covers, one big and one small one, with the small one named "cover" and the big one "cover_big" or something similar.

Furthermore it would be nice if there were a possibility to hide the source list such that the space can be used by the album art result list. Personally, I have setup the list once and will probably never touch it again...

I hope these suggestions help you to improve your great software AAD XUI  even more
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-11-24 07:58:41
I'll add a placeholder of %type% so that the type of the cover can be substituted into the filename automatically. That isn't quite the same as selecting a preset automatically, but should achieve the effect you wanted.

Automatic renaming rules are less likely to happen. Naming one cover as big, one as small, is the sort of thing that Presets were designed for.

The reason the source list remains visible is for progress indication, and the ability to stop sources that are taking too long to complete. I don't see any reason not to offer the option to hide it, though, so I'll have a go at that next version too.

Thanks for your suggestions!
Title: Album Art Downloader XUI
Post by: herojoker on 2008-11-24 22:33:04
Thank you very much 
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-12-08 11:30:28
Hi Alex,

Would it be possible to add minAspect to AlbumArt.exe as well? It seems like the following command line is only missing out on that, it has everything else. That way we can use both AAD and AlbumArt with the same same command line without modification.

"H:\Standalone\AlbumArtDownloader\AlbumArt.exe" /artist "Željko Joksimović" /album "Ima Nešto U Tome Što Me Neceš" /minSize 600 /minAspect 0.9 /path "H:\Users\Mike\Documents\My Pictures\iTSfv\Željko Joksimović\Ima Nešto U Tome Što Me Neceš\AAD.jpg"

Album Art Downloader XUI version 0.24.0.0

**** Unexpected command line parameter: minAspect ****

Usage: AlbumArt.exe [options]

Option names may be preceded by a / or a -
Options:

/artist      Artist to search for            (/artist "Artist Name")
              May be abbreviated to /ar      (/ar "Artist Name")
              Parameter name may be omitted
              if this is the first parameter  ("Artist Name")

/album      Album to search for            (/album "Album Name")
              May be abbreviated to /al      (/al "Album Name")
              Parameter name may be omitted
              if this is the second parameter ("Artist Name" "Album Name")

.
.
.
.
/separateInstance                            (/separateInstance)
              Starts a new instance as a new
              process, which will neither re-use
              nor be re-used by any other
              instance of the application.
             
              (not recommended)

Thanks,
McoreD
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-08 12:11:42
Sorry, I know I've not done anything on this project for a few weeks now. I will eventually get round to it, though.

The only issue with adding minAspect to AlbumArt.exe is it would then need visibility in the UI too, so it's not as simple as just adding the command line. I suppose if I can't come up with a good UI for it, I could stick it in as an undocumented command line option, though.
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-12-08 12:56:49
Thanks for the reply Alex. 

I didn't think of that did I! Could you for the time been please ignore the parameters supported in AAD.exe but not yet implemented in AlbumArt.exe, so that it won't interrupt the operation?

Thanks,
McoreD
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-08 17:13:38
Could you for the time been please ignore the parameters supported in AAD.exe but not yet implemented in AlbumArt.exe, so that it won't interrupt the operation?
Sure, no problem. Here's a tweaked version: AlbumArt.exe (http://www.byalexv.co.uk/temp/AlbumArt.exe) which silently ignores the parameters that are valid for the command line version, but not the GUI version (minaspect, ma, sequence, seq, listsources and l).

I'm not sure if I want to make that change to the main codebase, though. If a parameter does nothing, I do think the user should probably be told that it is unsupported.
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2008-12-09 08:15:21
Alex,

Thanks for the modded exe.  I might have to consider handling this issue myself depending on the exe I am using.
Title: Album Art Downloader XUI
Post by: PatchWorKs on 2008-12-09 09:12:18
Here's a couple of similar - open source - projects:

Album Cover Art Downloader (http://www.unrealvoodoo.org/hiteck/projects/albumart/) (multiplatform)

CDCover (http://cdcover.altervista.org/)

Hope that helps, or at least inspires !
Title: Album Art Downloader XUI
Post by: JWiels on 2008-12-10 17:22:48
Have successfully used v0.24 XUI since shortly after it's release but have now run into a crashing/no-start problem. While running Albumart started a Foobar browser which I stopped because it was taking too long, then started a "regular" file browser.  Immediately got "Application Error" dialog box:

Titled: AlbumArt.exe - Application Error
"Application has generated an exception that could not be handled
Process ID=0xf54 (3924), Thread ID=0xf78 (3960)

Click OK to terminate the application
Click CANCEL to debug the application"

Clicking OK terminates as I would expect without any useful info
Clicking CANCEL to "debug" yields another dialog box
Titled: AlbumArt.exe - NO debugger found.
No registered JIT debugger was specified
Click on Retry to have the process wait while attaching a debugger manually
Click on Cancel to about the JIT debug request"

Click Retry and... nothing
Click Cancel and ends.

This now happens every time I try to start AlbumArt.exe with expected changes in IDs.
AlbumArt will not start.  Have rebooted, no change.  Tried to reinstall and install fails with a "AlbumArt.exe cannot be opened for writing"  Uninstalled AlbumArt thru Add/Remove Programs and was left with AlbumArt.exe and AlbumArtDownloader.Scripts.dll in the AlbumArtDownloader folder, which now cannot be deleted even after a reboot and/or a boot into safe mode.  Both files can be renamed but still not deleted.  AlbumArtDownloader reinstall still fails in writing AlbumArt.exe.  Re-downloaded the install exe and same failed reinstall.

Any idea WTF happened here?  Any Help would be greatly appreciated.

Running WinXP sp3 with DotNet v3.5sp1  (fully updated)

JWiels
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-10 18:00:47
[quote name='JWiels' date='Dec 10 2008, 18:22' post='603942']have now run into a crashing/no-start problem./quote]Now that is very weird. Album Art Downloader does not do anything to make itself start with windows, so after a reboot, there should be no reason at all for the AlbumArt.exe and AlbumArtDownloader.Scripts.dll to be impossible to delete.

There are two things I can think of to try. One would be to uninstall the .net framework, try again to delete the files, then reinstall the framework.

The other less blunt approach would be to download Unlocker (http://ccollomb.free.fr/unlocker/#download) (or other similar tool) to tell you what is preventing the file from being deleted, and force the deletion of it if necessary.
Title: Album Art Downloader XUI
Post by: JWiels on 2008-12-10 18:28:43
Have used Unlocker which allowed deleting AlbumArt.exe and AlbumArtDownloader.Scripts.dll.  Thank You.
Reinstalled v0.24.
But got "Script compilation failed" message in AlbumArt dialog at first and subsequent starts.  "Retry" failed as well, "Exit"... exits...
Uninstall and Reinstall, same "Script compilation failed"
Redownload install exe, same
Download zip and extract, same

Here's the text of the AlbumArt initial "compilation window", if it helps:

Searching for scripts...
Found 28 files: [albumartexchange.boo, allcdcover.boo, amazon-ca.boo, amazon-co-uk.boo, amazon-com-mp3.boo, amazon-com.boo, amazon-common.boo, amazon-de.boo, amazon-fr.boo, amazon-jp.boo, buy-com.boo, cdcoverhideout.boo, cduniverse.boo, cover-paradies.boo, coveralia.boo, coverisland.boo, darktown.boo, discogs.boo, freecovers-api.boo, google.boo, juno-records.boo, lastfm-artist.boo, lastfm-cover.boo, psyshop.boo, rateyourmusic.boo, revhq.boo, util.boo, yes24.boo]...
Loading references: [System.Core, System.Web]...
Compiling scripts...
(-1,-1): error BCE0011: An error occurred during the execution of the step 'Boo.Lang.Compiler.Steps.SaveAssembly': 'Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))'.

hmmm access denied using boo.lang.compiler?  hmm why? ideas?

I'm hesitant and reluctant to uninstall then reinstall DotNet... It was an amazingly painful process to get all the applications I have which rely on the particulars of DotNet to work.  I'm not sure it was worth it....
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-10 19:02:30
hmmm access denied using boo.lang.compiler?  hmm why? ideas?

At that point, the script compiler will be trying to save a compiled .dll file to your application settings folder, under: \Documents and Settings\username\Local Settings\Application Data\AlbumArtDownloader. Try deleting that folder (again, using Unlocker if it is uncooperative), and perhaps when it recreates it it will not be denied access to it.
Title: Album Art Downloader XUI
Post by: JWiels on 2008-12-11 02:20:30
Okay installed and am using AlbumArtDownloader XUI again.  Script compilation failure was a firewall issue with Comodo Defense+ not allowing access to the Local Setting folder.  *sigh*

Now, onto a usability problem.  Having trouble with AlbumArt not "remembering" presets and search directories.  One search window will have my entered presets, the next will not.  Sometimes a subsequent search window will have the wrong search directory, typically a previously used one. 

Also, I can use a file browser to select folder or files to search for art but sometimes I can save more than one file (cover, back, inlay, etc.) and sometimes I save one file, then the window closes and the next search in the queue starts.  ??

I do not recall having this trouble before. Any ideas?
Thanks for help

JWiels
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-11 09:31:45
Well, I'm going to make an educated guess that this is Comodo Defense+ being overzealous again.

Album Art Downloader stores its configuration settings in a file called user.config, in a subfolder of \Documents and Settings\username\Local Settings\Application Data\AlbumArtDownloader. If it can't write to this file, then no change of settings (including presets, search directories, window auto-close behaviour) will take effect outside of the immediate window it is made to.
Title: Album Art Downloader XUI
Post by: Charly B on 2008-12-11 10:19:58
Hi all,
I use this to start AADXUI form run service :
"coverDownloader\albumart.exe" /ar "%artist%" /al "%album%" /p "$replace(%_path%,%_filename_ext%,)\" -f "cover%preset%.jpg" /o size-
But %preset% is resolved as ?, how can I deal with that ?

EDIT : I've found the answer : '%preset%' ... sorry !
Title: Album Art Downloader XUI
Post by: odigg on 2008-12-12 15:42:16
This is an absolutely fantastic program.  I've been collecting mp3s for a little over a decade and I've never added album art because it was too time consuming.  With this I've been able to get the front covers for all most of my albums in just a few hours.

My computer is old (in computer years at least) so the software would regularly freeze in Vista.  I just had to wait (usually less than a minute) and it would wake up.

Thanks for the great software!
Title: Album Art Downloader XUI
Post by: TheOnlyRick on 2008-12-14 17:29:39
First off - Should I be adding this as a reply, or as a new topic?

Second - Thanks to Alex, daju and Marc for a very useful tool.

Thirdly - Is there a manual that describes how I achieve the following:

I would like AAD to scan by \folder\subfolder\ and then AAD to let me choose & download a jpg into the subfolder, and to rename it folder.jpg.

I thought I had already achieved this, but I'm getting very confused.  (Does AAD save settings?)

Thanks,

Richard

PS - I would happily be pointed towards some documentation on this.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-14 17:54:06
Replying to the thread is the right way to go.

Unfortunately, there isn't any proper documentation, no.

To do what you are asking, you need to use the File Browser window. After starting Album Art Downloader, click File, New, File Browser. Point it at the root folder within which the subfolders you want to put images into are using the "..." button, or entering the path directly, then click the Search button.

By default, it will scan the ID3 tags of music files it finds within the folders to determine the artist and album name to search for for each folder. If this doesn't produce the expected results, let me know how you want it to determine what the artist and album name for any given subfolder should be.

Once you've got the list of albums to search for, select those you want to search and download images for and click the "Get Artwork for Selection" button.

I'm not sure what else there is to say, really, so if you get stuck on anything in particular, just ask.

AAD does save its settings, yes.
Title: Album Art Downloader XUI
Post by: TheOnlyRick on 2008-12-14 19:03:37
Thanks for the speedy reply - I'm gust giving it a go now.

I got AAD to search based on \folder\subfolder (which is \artist\album)

In the 'Save images to' field, I told it to name the downloaded JPGs as 'folder.jpg' and put them in the same folder as the mp3s.

But:
- Once it copied the existing folder structure (\artist\album) on the root of my hard drive and put in the JPG.
- Another time it copied the folder structure, but put it under 'My Pictures'.
- The final variation was that it saved the JPG as folder.jpg in the right folder, but when carrying out subsequent downloads, it would not rename it to 'folder.jpg' and instead just keep it with the original name.

I'll get back with my results.  Thanks,

Richard


Replying to the thread is the right way to go.

Unfortunately, there isn't any proper documentation, no.

To do what you are asking, you need to use the File Browser window. After starting Album Art Downloader, click File, New, File Browser. Point it at the root folder within which the subfolders you want to put images into are using the "..." button, or entering the path directly, then click the Search button.

By default, it will scan the ID3 tags of music files it finds within the folders to determine the artist and album name to search for for each folder. If this doesn't produce the expected results, let me know how you want it to determine what the artist and album name for any given subfolder should be.

Once you've got the list of albums to search for, select those you want to search and download images for and click the "Get Artwork for Selection" button.

I'm not sure what else there is to say, really, so if you get stuck on anything in particular, just ask.

AAD does save its settings, yes.
Title: Album Art Downloader XUI
Post by: TheOnlyRick on 2008-12-15 00:10:59
Working like a dream.  Incredible, thanks!

Am I right in saying that any changes to the options in the Album Art Downloader window won't 'carry over' to the next window if I have a load of searches queued up?


One question.  Sometimes I click on an image and it downloads and shows in max resolution.  Sometimes it disappears.  Why does it disappear/Where does it go?

Thanks,

Richard
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-15 08:19:36
Am I right in saying that any changes to the options in the Album Art Downloader window won't 'carry over' to the next window if I have a load of searches queued up?
They should do. This was fixed in version 0.20 - so long as you have that version or newer, the latest options should be applied to each new window as it comes off the queue.

Sometimes I click on an image and it downloads and shows in max resolution.  Sometimes it disappears.  Why does it disappear/Where does it go?
If you hold the mouse down over an image, a preview at full size (or as large as will fit on the screen, if full size would be larger than that) is shown. When you release the mouse button, the preview is no longer shown. The full size image will only be downloaded once, though, so if you then save or preview the image, it will use the full size image that is still in memory. It will be removed from memory when the window is closed, or a new search done in the same window.
Title: Album Art Downloader XUI
Post by: dutch109 on 2008-12-17 21:29:16
First AlexVallat thanks for your great soft, I use it with foobar2000 and foo_run and it is very useful to me.

I am am looking for a way to select all sources without having to name them all (I sometimes only need some of them, and sometimes all of them), is there a command line parameter to do that ?

I also noticed a small bug : launching AlbumArt.exe with /exclude "" in command line makes it crash.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-17 22:34:28
Thanks for reporting the bug, I've reproduced it, fixed it, and it will be included in the next release. Incidentally, this is a bug with any "" parameter, not just /exclude.

I'm afraid there isn't any way of selecting all sources from the command line at present. I've added it as a feature request though: 2442822 (https://sourceforge.net/tracker2/?func=detail&aid=2442822&group_id=187008&atid=919578)
Title: Album Art Downloader XUI
Post by: Adagio on 2008-12-22 11:28:17
Just slightly adjusted my foo_run command line to have it display .jpg .jpeg and .png images.
It's using foobar's $directory_path function (a bit more straightforward).
Just wanted to share that.

AAD is a wonderfully useful tool! Thank you, Alex. 

Code: [Select]
C:\TOOLS\Sound\AlbumArtDownloader\AlbumArt.exe 
/ar "%album artist%"
/al "%album%"
/p "$directory_path(%path%)\'%preset%'.'%extension%'"
/localImagesPath "$directory_path(%path%)\**\*.*g"
Title: Album Art Downloader XUI
Post by: TheOnlyRick on 2008-12-22 14:36:31
[quote name='TheOnlyRick' post='604713' date='Dec 15 2008, 01:10']Sometimes I click on an image and it downloads and shows in max resolution.  Sometimes it disappears.  Why does it disappear/Where does it go?[/quote]If you hold the mouse down over an image, a preview at full size (or as large as will fit on the screen, if full size would be larger than that) is shown. When you release the mouse button, the preview is no longer shown. The full size image will only be downloaded once, though, so if you then save or preview the image, it will use the full size image that is still in memory. It will be removed from memory when the window is closed, or a new search done in the same window.
[/quote]

I'm fairly sure that a few times there have been (for example) 10 pictures in the preview window.  I click on an image - it appears full size and then disappears - leaving only 9 picture in the preview window.

Thanks once again - AAD was helpful in getting more artwork onto my iPod.

Now all I need to do is sort out why the iPod database gets so messed up.


Cheers,

Richard
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-12-22 14:52:06
Do you have min or max size filter settings enabled? And do you have "automatically download full-size images" to "Never"? If yes, this is my guess what happens: the source returns images with no size information (= all "unknown" size images are shown), then you preview it (= size becomes known), after closing the preview (releasing mouse button) the image disappears because its filtered by either min or max setting.
Title: Album Art Downloader XUI
Post by: TheOnlyRick on 2008-12-23 09:33:35
Do you have min or max size filter settings enabled? And do you have "automatically download full-size images" to "Never"? If yes, this is my guess what happens: the source returns images with no size information (= all "unknown" size images are shown), then you preview it (= size becomes known), after closing the preview (releasing mouse button) the image disappears because its filtered by either min or max setting.


Hmmmm...  I replied to this yesterday, but obviously didn't click submit at the end.


Thanks - you're spot on - and now it looks kinda obvious!  The problems only appeared after I had a bit of a fiddle to customise and optimise the AAD experience.

Next on my list is to sort out the syncing probs between Winamp and my 'Pod (but I think a format and reinstall of XP might be the only thing to sort that one...)

Cheers,

Richard
Title: Album Art Downloader XUI
Post by: Moonbase on 2008-12-26 09:50:05
Apart from some »Illegal Path" messages, really working great. (Drag ’n’ drop usually saves the image with exactly the same name it was supposed to use when clicking on »Save«.)

Seems that AllCdCover have changed something: Since today, I sometimes get a »full resolution« image showing a CD and a text like »Yes, we have the cover you are looking for but we cannot show it to you. You seem to be using an old link or something else is broken.«.

This seems intermittent, so I’m not sure who to blame: AAD or AllCdCover.
Just to let everyone know and maybe get some feedback.
Title: Album Art Downloader XUI
Post by: Akkurat on 2008-12-26 13:37:58
About AllCdCover, read my older post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=595466) from this thread (read that post and 2 next ones).
Title: Album Art Downloader XUI
Post by: Moonbase on 2008-12-26 17:40:59
Yep, thanks! Hunting things down in so many forums, bug reporting systems and mailing lists leads to missing some posts …
Title: Album Art Downloader XUI
Post by: IndieRockSteve on 2008-12-29 15:48:01
Is there an "options/preferences" window or ini file I can edit to change settings or am I stuck with the defaults and having to change them manually each time?

thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2008-12-29 16:06:23
Is there an "options/preferences" window or ini file I can edit to change settings or am I stuck with the defaults and having to change them manually each time?
You shouldn't need to change them each time, all preferences are persisted. If you are having trouble with some particular setting being forgotten, then please give me some more details and I will look into it for you.

You could try just running Album Art Downloader, changing the setting, exiting, then restarting it and checking that it has kept the new value.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-01-02 11:51:45
Album Art Downloader XUI v0.25 Released
There have been some minor feature requests and bug fixes that have been piling up for frankly a shameful amount of time, so I thought I'd do a New-Year's clear out of them. Here's a new release which brings me up to date with all the changes I always meant to get around to sometime.

Full list of changes in this version:Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.25.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.25.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: WebFox on 2009-01-07 16:11:21
First of all, thank you for this wonderful application!
Now, I have one problem (ERROR) and 3 requests.

The problem:
when I try to download an album art for a song that already has an album art, and then press save,
I get a permission error, and the album art isn't saved.

The requests:
1. add an option to search only for album arts that their width and height are the same
2. add an option to search for album arts by their exact width&height (the min/max bug was fixed in latest version)
3. add an option to block all the unknown-size pictures

Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-01-07 16:36:14
Are you sure the art file you are trying to replace is not read-only, and that you (or the user that launched Album Art Downloader) have the necessary security permissions to overwrite it?

Searching for albums with a specific width and height, or width/height ratio, can't be done; the sources don't support that. I could add filtering to hide results which didn't match, though.

You can already filter for art with an exact size - click the Options link, then in the "Filter by image size" box enter the same number as both the minimum and maximum. I appreciate that without being able to specify a 1:1 aspect ratio, this might not meet all your requirements, though.

Finally, if you want to block unknown size pictures, simply uncheck the sources that do not provide size information. There are no sources that sometimes provide size information and sometimes don't, so if you see an unknown size result, just look at the name of the source for it, and uncheck it.

You might find it more useful to set the option to automatically download full size images when the size is unknown instead though - up to you.

Alex
Title: Album Art Downloader XUI
Post by: WebFox on 2009-01-07 16:39:57
...

Thanks, I didn't see the full-size option!
I found the reason why the replacing didn't work, but I can't find a way to fix that:
the WMP downloads Folder.jpg from the internet and makes it a system file.
That's the reason you can't replace it.
And that's also the reason why I no longer use WMP.
Anyway, How can I remove all system Album Arts' from all my music folders?

Thank you!

EDIT: I erased all the album arts where the file size was too low, and downloaded them again.
Now everything works just fine.

Quote
I could add filtering to hide results which didn't match

That would be great if you would to that. ^^

Thanks for everything
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-01-07 19:02:51
You can do this from the command line using:

attrib -s -h -r folder.jpg /s

to remove system, hidden and readonly attributes from all files named folder.jpg in the current folder and all sub folders.

If you really want to delete them, del /s folder.jpg will delete all files named folder.jpg in the current folder and all sub folders (be careful with that one!)
Title: Album Art Downloader XUI
Post by: WebFox on 2009-01-07 19:06:42
You can do this from the command line using ...

I guess you didn't see that I've edited my post? (thanks for the solution anyway. good to know that)
Title: Album Art Downloader XUI
Post by: Maxoo on 2009-01-07 22:06:59
Hi,

This program worked fine for me in the past, but I had to reinstall Vista. The first time I ran AAD, it said that Framework 3.5 wasn't installed so the interface turned a bit ugly (windows 2000 like). Since this time, I have downloaded and installed .Netframework 3.5 SP1, but I still have this UI...
I think the program keeps his settings, but I don't know how to change it :s
Need help !
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-01-08 08:35:30
There is no specific "ugly-ui" mode in AAD. If you do not have .net 3.5 SP1 installed, it just runs a little slower. If you don't have .net 3.5 installed at all, then it won't even run.

The only thing I can think of is if you have set Windows to the "Classic" theme, but that would affect everything, not just AAD.

If it really is just AAD affected, then all I can suggest is uninstalling it and re-installing it.

Alex
Title: Album Art Downloader XUI
Post by: dutch109 on 2009-01-08 16:44:41
The new version works fine here. Thanks Alex for adding the "/source all" switch.
Title: Album Art Downloader XUI
Post by: Hayden54 on 2009-01-11 00:14:39
I know that you've commented about embedding album art in the past, saying that it is not worth supporting. The main reason for supporting this is portability to hardware devices like the ps3 and many portable mp3 players. When I copy music over, it is not stored in the artist/album folder structure so all those folder.jpg files are useless. It does however read art embedded.

Having an option to embed (& overwrite) at the same time as saving the jpg file would be great. This would be really useful, considering there is no other option within foobar to do this. Hopefully you will reconsider your stance on embedding art.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-01-11 08:37:10
One of the major issues with embedding art is that it would have to know exactly which files to embed it into. This would be fairly easy if you have a simple scheme like having one folder per album, and saving the image into that folder. It could then just embed the image into every file in that folder.

The problem is, that isn't the only scheme in use, and I can't think of any good way of automatically determining which files to embed the artwork into that would be safe enough to ship. It could be catastrophically bad if AAD 'updated' a whole bunch of your files with new embedded art, irrevocably losing the art you already had for them.

AAD will remain a tool for downloading album art, and saving it as a file. The job of synchronising album art with embedded tags is a tag-management task, and should be handled by a separate tag-management tool. It's the same class of task as ensuring that all the tracks in an album have the same 'album' tag, and correct track number tag, or that the album tag matches the folder name, that sort of thing.

I expect there are already tools that do this - I don't use embedded album art myself, so I haven't tried one myself. A quick poke around the internet threw up mp3tag (http://www.mp3tag.de/en/) (instructions (http://www.geektonic.com/2008/02/automatically-embed-album-art-to-large.html)) and a dedicated ID3 Embed Pictures (http://www.dalepreston.com/Blog/2007/03/id3-embed-pictures.html) tool, either of which should do the job if your image files and album files are well organised.
Title: Album Art Downloader XUI
Post by: Hayden54 on 2009-01-11 10:21:51
Thanks for your reply. I understand where you are coming from, and although it would have been nice to have an all-in-one method of adding album art to files, I agree that the potentional for disaster is quite high.
I guess I'll just have to wait for someone to make a plug-in (or natively added to foobar) that lets you click on a file and embed a jpg file based on a file-naming scheme using titleformatting.

In the meantime, mp3tag seems to do the job reasonably well, although having another separate program was not the most ideal method. It can also be used through foo_run scripts, which integrate it into foobar a little better.

Either way, I'd like to thank you for the time you've put into this plugin. I just updated from v0.7 to 0.25, and it is much faster
Title: Album Art Downloader XUI
Post by: wernerson on 2009-01-12 07:48:46
Ist ein gutes Programm.

Aber alle Bilder haben den selben Namen. folder.jpg !!!
Save as folder.jpg !!!
Automatik save as orig. Name..... !!!! is besser.
I have Downloading T-Rex save as folder.jpg !!!!
i have Downloading Boehse Onkelz save as folder.jpg !!!!

Das ist nicht gut. Eine Lösung muss her. Eine Verbesserung.

Ansonsten ist das Programm TOP !! 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-01-12 07:58:50
Thanks for your comments. If you want to save your images using the name as the filename, please click "Options", then in the "Save images to" box, replace the text "Folder" with "%name%" instead. You should end up with something like: ...\%artist%\%album%\%name%%preset%.%extension%

(I hope you understand - if not, PM me and I will do my best in German, but this is an English forum, and here I will post only in English)
Title: Album Art Downloader XUI
Post by: Jeffsteez on 2009-01-15 02:54:00
Thanks for making this tool. Looks really handy.

I'm in a similar position to the person wanting to embed album art. I have a collection of single tracks currently sorted only as Genre\Artist-Trackname.mp3

I'm assuming since I have lots of different artists/albums in the genre folders, using the option to name the artwork the same as the mp3 filename would be my best option. What would be a good automated way to get the art embedded? Sorry for being quite dumb on this, the only embedding I've done before has been from itunes (and some of the mp3s already have albumart from itunes.)

Thanks
Title: Album Art Downloader XUI
Post by: dutch109 on 2009-01-15 03:36:17
Thanks for making this tool. Looks really handy.

I'm in a similar position to the person wanting to embed album art. I have a collection of single tracks currently sorted only as Genre\Artist-Trackname.mp3

I'm assuming since I have lots of different artists/albums in the genre folders, using the option to name the artwork the same as the mp3 filename would be my best option. What would be a good automated way to get the art embedded? Sorry for being quite dumb on this, the only embedding I've done before has been from itunes (and some of the mp3s already have albumart from itunes.)

Thanks


I personally use a script which combines foo_run (http://www.hydrogenaudio.org/forums/index.php?showtopic=45223) to call the script from foobar, AAD to download the cover, ImageMagick (http://www.imagemagick.org/script/index.php) to resize the picture and metamp3 (http://www.hydrogenaudio.org/forums/index.php?showtopic=49751) to embed it.
Title: Album Art Downloader XUI
Post by: aphasia on 2009-01-20 14:06:21
Hi Alex,
I must say a very big thanks for your program. I have been using it for a long time now and it has proved indispensable. It is only now that I have realised that this thread has moved from the foobar forums and I see that your software has progressed enormously. It is really an extremely useful tool.

One problem that I have experienced since I upgraded to the latest version (love the preset idea btw, very very cool) is that sometimes if I call your program from foobar using foo_run the previous download path will still be active. To be more specific: say if I call my foo_run script for album art and then my foo_run script for artist picture the latter will remember the save path from the former. This doesn't happen all the time and perhaps it is not the fault of your program but I thought that I would point it out.

Thanks again.
Title: Album Art Downloader XUI
Post by: brianmel on 2009-01-31 05:26:27

hi

I used the old version and I had a problem, the old software copied a cover to all the songs in my collection (that is horrible, but improving slowly changing the covers).

I want to know how to download the cover , and save it to the song file.
because i want to have all the songs with covers without depending on the cover/photo files!

Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-01-31 08:06:03
One problem that I have experienced ... is that sometimes if I call your program from foobar using foo_run the previous download path will still be active.
Thanks for your comments. About this bug, I'm not sure I understand. It is supposed to remember the previous download path. Or do you mean it is ignoring a path specified in the command line using /path? I'll look into that.

I want to know how to download the cover , and save it to the song file.
If you look up a few posts you can see we already discussed this. Tag management (including embedded artwork tags) is out of scope for this application. I made a couple of suggestions for software that can batch embed artwork from image files into tags [a href='index.php?act=findpost&pid=608858']here[/a]
Title: Album Art Downloader XUI
Post by: singaiya on 2009-01-31 20:16:12
Alex: thanks for AAD, it's really helpful for me.

I made a couple of suggestions for software that can batch embed artwork from image files into tags [a href='index.php?act=findpost&pid=608858']here[/a]


I tried the mp3tag method, and it does put art in the file tags. But a note to others, if you're looking for a tag solution because you're using itunes/ipod (as I am): after mp3tag saves art to the file tags, itunes still doesn't know about it. Since itunes doesn't have a "reload file tags" command, I found you have to either play each song, or open it's properties so itunes recognizes the changed tag. Not very efficient.

itsfv may be able to work around this, but I haven't figured out how to do it. For now I just select a group of songs that make one album, get info, drag the jpg file from windows explorer to the art tag in itunes, click ok. If anyone has any alternatives, please tell.
Title: Album Art Downloader XUI
Post by: Ben! on 2009-02-02 23:04:36
What should I use for a foo_run script if I want to download artist pictures (saved as artistname.jpg in a directory that stays the same for all images) using Album Art Downloader?  I only have the program set to search last.fm (since I only want artist pictures and not album art) and it's set to save them to the directory that I want.  I just need a foo_run command to launch the program and automate the process if at all possible.

EDIT: I've finally got the program launching and automatically searching for my artist.  Now I just need to download a picture automatically (%artist%.%extension%) to a specific directory (C:\Documents and Settings\Ben\My Documents\Artist Pictures\).  Is that possible?


EDIT(x2): Ok, nevermind.  I guess it's be pretty pointless for me to allow the program to select a picture and save it for me since I'd generally like to pick it myself.
Title: Album Art Downloader XUI
Post by: dyermaker on 2009-02-03 23:35:39
hey folks, foobar noob here so please excuse my ignorance:)

ive been trying to populate my library with artwork using album art downloader to make coverflow nice and pretty. from what i can see it searches for artwork as cover|folder.jpg with the default path variables. this is fine in general but the thing is i have lots of artwork already in my file folders, just not with that naming convention. is there any way possible that i can get album artwork to read any .jpeg or random image in a folder using wildcards for example? ive tinkered a bit with the path but cant seem to get it to do what id like.

also in chronflow preferences.. sources, i see '$replace(%path%,%filename_ext%,)folder.jpg'
is there a variable that would allow me again to read any image it finds in a directory? (i know this has nothing to do with album art downloader just thought maybe someone reading this might have the answer).

*edit* okay ive progressed a bit further with the second problem.. i can get the notificator in fooAVA 1.05 to pick up on any filename using $replace(%path%,%filename_ext%,)* but the image only displays in the small notificator window and not as cover art? argh..
Title: Album Art Downloader XUI
Post by: aphasia on 2009-02-04 09:29:15
One problem that I have experienced ... is that sometimes if I call your program from foobar using foo_run the previous download path will still be active.
Thanks for your comments. About this bug, I'm not sure I understand. It is supposed to remember the previous download path. Or do you mean it is ignoring a path specified in the command line using /path? I'll look into that.
Yeah it's ignoring the path specified in my foo_run script and instead using the one from the script previously invoked. This seems to only happen if I call the two scripts in quick succession if that helps.
Title: Album Art Downloader XUI
Post by: Ross1 on 2009-02-04 18:16:42
Ive been using this program for a while now..... and I have to say each time I use a new version its significantly better with features that are incredibly useful every time. Basically the development on this appears to be fantastic, and continues to save me more and more time finding art for my music.

thankyou.
Title: Album Art Downloader XUI
Post by: Ben! on 2009-02-04 21:19:13
On second thought...it would be handy if I could automatically download artist pictures for all of my artists.  I see how that would be easy for cover art, but how would I go about doing it with artist pictures?
Title: Album Art Downloader XUI
Post by: acmodeu on 2009-02-07 12:42:27
AlexVallat, can you add support for the modern vista file dialog windows in future version? They support bookmarks and recent places.

Current:
(http://img4.imageshack.us/img4/2420/capture02072009153717ig8.th.jpg) (http://img4.imageshack.us/my.php?image=capture02072009153717ig8.jpg)

That's, what am I talking about:
(http://img3.imageshack.us/img3/6869/capture02072009153455ij9.th.jpg) (http://img3.imageshack.us/my.php?image=capture02072009153455ij9.jpg)
Title: Album Art Downloader XUI
Post by: frnk on 2009-02-07 16:30:55
Hi there!

It seems like recently the script for Discogs stopt working. I don't get any results at all, even though the album art I'm looking for is on the website.

Does anyone else have this problem too, or am I the only one?
Title: Album Art Downloader XUI
Post by: aphasia on 2009-02-08 06:47:00
Hi there!

It seems like recently the script for Discogs stopt working. I don't get any results at all, even though the album art I'm looking for is on the website.

Does anyone else have this problem too, or am I the only one?

Yes I can reproduce this behaviour.
Title: Album Art Downloader XUI
Post by: frnk on 2009-02-08 12:35:55
Hi there!

It seems like recently the script for Discogs stopt working. I don't get any results at all, even though the album art I'm looking for is on the website.

Does anyone else have this problem too, or am I the only one?

Yes I can reproduce this behaviour.


OK. So it's not just me?

Does anyone know what to do about it then?
Title: Album Art Downloader XUI
Post by: dyermaker on 2009-02-09 03:19:27
just noticed this too.. the foo_discogs plugin seems broken as well (most options are greyed out)

might just be a glitch and fix itself in a few days
Title: Album Art Downloader XUI
Post by: frnk on 2009-02-09 07:52:21
Hm, might this (http://www.discogs.com/help/forums/topic/178572) have anything to do with it?

Discogs' search function has had an overhaul as well recently.
Title: Album Art Downloader XUI
Post by: dyermaker on 2009-02-09 17:44:29
looks like the culprit.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-02-10 18:07:52
Sorry for the late reply. It looks like email notification of thread replies has been broken recently, and I haven't checked manually in a while!

Anyway, here's an updated discogs.boo (http://www.byalexv.co.uk/foobar/discogs.boo) for you all; thanks for reporting it.

acmodeu, I am using the standard common file dialog control provided by WPF. It is a shame that this does not automatically provide the new-style dialogs under Vista, I agree.

There is almost certainly some sort of hacky work-around to call the APIs directly to get this dialog, but as I don't have a copy of Vista, I won't be able to do this. Sorry.

Alex
Title: Album Art Downloader XUI
Post by: frnk on 2009-02-10 18:10:44
You sir, are a gentleman and a scholar.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-02-11 20:25:38
Sorry for the late reply. It looks like email notification of thread replies has been broken recently, and I haven't checked manually in a while!

It's not broken, "Immediate Email Notification" setting changed when the forum upgrade was made. I just posted a voting topic for this setting: "Immediate Email Notification" setting POLL (http://www.hydrogenaudio.org/forums/index.php?showtopic=69384)

BTW, the required .NET Framework 3.5 SP1 was rolled out to microsoft update site recently.. not sure about the automatic update.
Title: Album Art Downloader XUI
Post by: blackspawn on 2009-02-26 14:37:10
I've got a small usability feature request... currently when I hit ctrl+b to open the file browser, the initial window (the one that opens when you run AAD) remains open without any use. Normally I just close it since it counts torwards the queue count (but runs no searches). What would be nice was that ctrl+b would also close the original window or use it for one of the searches.

Also (this has probably been requested before) it would be awesome if you could implement a single window (tabbed) interface but I don't know if this would be possible or very time consuming so I'll just leave it to wishfull thinking :-)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-02-26 15:22:35
I've got a small usability feature request... currently when I hit ctrl+b to open the file browser, the initial window (the one that opens when you run AAD) remains open without any use. Normally I just close it since it counts torwards the queue count (but runs no searches). What would be nice was that ctrl+b would also close the original window or use it for one of the searches.

Also (this has probably been requested before) it would be awesome if you could implement a single window (tabbed) interface but I don't know if this would be possible or very time consuming so I'll just leave it to wishfull thinking :-)

Tabbed interface is not going to happen, sorry.

For the file browser, have you considered adding /fileBrowser to the command line you use for launching Album Art Downloader? That way it would start with just the file browser window open, and no initial search window.

Alex
Title: Album Art Downloader XUI
Post by: mullinFOAD on 2009-02-27 03:33:16
I've been trying to install Album Art Downloader XUI.  Once it's done it says it needs to install the mediainfo x64 upgrade file, but when it runs it says I have the wrong operating system.  I'm running Vista Ultimate 64 so I don't understand what the problem is?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-02-27 08:26:50
I've been trying to install Album Art Downloader XUI.  Once it's done it says it needs to install the mediainfo x64 upgrade file, but when it runs it says I have the wrong operating system.  I'm running Vista Ultimate 64 so I don't understand what the problem is?

I'm sorry, I don't have Vista 64 to test under, but I'll try to figure out what's going on. First, what is it that tells you you have the wrong operating system? Is it the mediainfo x64 upgrade file installer? Or trying to run Album Art Downloader after installing it? Could you tell me exactly what the error message is, or send me a screenshot of it?
Title: Album Art Downloader XUI
Post by: acmodeu on 2009-02-27 08:37:22
I have absolutely no problems running Album Art Downloader XUI under Vista Ultimate SP1 x64.
Title: Album Art Downloader XUI
Post by: blackspawn on 2009-03-03 19:27:41
For the file browser, have you considered adding /fileBrowser to the command line you use for launching Album Art Downloader? That way it would start with just the file browser window open, and no initial search window.

Alex


Yes this is exactly what I wanted! Thx!
Title: Album Art Downloader XUI
Post by: Fangs404 on 2009-03-03 22:17:24
I'm really liking this program.  It's saving me a whole lot of time.  I have over 1000 albums, and I'm able to get album art for them pretty quick.

I just thought I'd let you know that the source script for Cover-Paradise is misspelled.  It's currently spelled Cover-Paradies.  At first I thought it was a site of CD cover paradies, but then I realized it was just a misspelling.

Great program.  Keep up the good work. 
Title: Album Art Downloader XUI
Post by: Der_Iltis on 2009-03-05 16:24:19
Hey guys,

I'm wondering why I can't get this one to work:

I would like to scan my foobar media library and, if there isn't already a file called %album%.jpg in my <root>\Album Art\ folder I would like to download it automatically. I neither can make Album Art Downloader read the library nor keep the folder structure. What shall I do?

Thanks for your patience and help.

Edit: Reading library works now, how do I get the jpg's now?
Title: Album Art Downloader XUI
Post by: 2E7AH on 2009-03-05 17:15:26
ay alright, now you are here
i don't want you to get me wrong, but there is no tool (at least i'm not aware of such) that will download automatically all album art for your library unless you do it step by step - album by album - release by release
this is great tool, so is foo_discogs and some others, but having all library without album art and disire to fill it in sec, i don't think it is it's purpose
which album exactly, which relese, and cover and so on...
Title: Album Art Downloader XUI
Post by: fb2k_kdRt on 2009-03-08 16:34:23
Hello, i've just download & install Album Art Downloader XUI and foo_run. But i'm completly lost how to make it run with foo_run.

I'd like to go to the contextual menu in foobar, run albumartdownloader and to save the choosen cover in the folder where the selected song is.

If someone could help me, that'd be great.

Thank in advance
Title: Album Art Downloader XUI
Post by: 2E7AH on 2009-03-08 16:44:42
I'd like to go to the contextual menu in foobar, run albumartdownloader and to save the choosen cover in the folder where the selected song is.

go to "preferences > tools > run..." add new service and something like this:

[font= "Courier New"]"<insert path to AlbumArtDownloader>\AlbumArt.exe" /ar "%artist%" /al "%album%" /p "$replace(%path%,%filename_ext%,)cover.jpg"[/font]
Title: Album Art Downloader XUI
Post by: fb2k_kdRt on 2009-03-08 17:06:59
That works.
Thank you.
Title: Album Art Downloader XUI
Post by: DoXer on 2009-03-17 15:03:19
Hello,

can anybody integrate this Website for searching?

http://www.albumartexchange.com/ (http://www.albumartexchange.com/)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-03-17 16:19:06
Feel free to write a script for it.
Title: Album Art Downloader XUI
Post by: DoXer on 2009-03-17 18:09:25
Feel free to write a script for it.

My knowledge doesn't allow this, but I make a mistake. It's still there. Sorry for the topic....
Title: Album Art Downloader XUI
Post by: Chris Norman on 2009-03-21 10:59:45
Thanks for this great tool.

I am using the foobar com integration and it works like a charm.

However it looks like the cover-paradies.boo script doesn't work or got broken.

I had a look at the script and I am not much of a programmer but is there somewhere a reference helping to understand / write these scripts?

-Chris
Title: Album Art Downloader XUI
Post by: Chris Norman on 2009-03-22 09:00:23
While playing around and editing presets in foobar mode it crashed. It crashes repeatedly when I hit the "add" button in the preset section:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file:
C:\Programme\AlbumArtDownloader\errorlog.txt

App version: 0.25.0.0, running on Microsoft Windows NT 5.1.2600 Service
Pack 3

System.ArgumentNullException: Der Wert darf nicht NULL sein.
Parametername: element
  bei MS.Internal.Media.VisualTreeUtils.AsNonNullVisual(DependencyObject
element, Visual& visual, Visual3D& visual3D)
  bei
System.Windows.Media.VisualTreeHelper.GetChildrenCount(DependencyObject
reference)
  bei AlbumArtDownloader.Common.FindVisualChild[TChild](DependencyObject
obj)
  bei AlbumArtDownloader.EditPresets.OnNewItemContainerGenerated(Object
sender, EventArgs e)
  bei System.EventHandler.Invoke(Object sender, EventArgs e)
  bei
System.Windows.Controls.ItemContainerGenerator.SetStatus(GeneratorStatus
value)
  bei
System.Windows.Controls.ItemContainerGenerator.Generator.System.IDisposab
le.Dispose()
  bei
System.Windows.Controls.VirtualizingStackPanel.MeasureOverride(Size
constraint)
  bei System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  bei System.Windows.UIElement.Measure(Size availableSize)
  bei System.Windows.ContextLayoutManager.UpdateLayout()
  bei System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object
arg)
  bei System.Windows.Media.MediaContext.InvokeOnRenderCallback.DoWork()
  bei System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
  bei System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object
resizedCompositionTarget)
  bei System.Windows.Media.MediaContext.RenderMessageHandler(Object
resizedCompositionTarget)
  bei
System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate
callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object
source, Delegate callback, Object args, Boolean isSingleParameter,
Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate
callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei
System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Obje
ct state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei
System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedC
leanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext
executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext
executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32
msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr
wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei
System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate
callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object
source, Delegate callback, Object args, Boolean isSingleParameter,
Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate
callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority
priority, TimeSpan timeout, Delegate method, Object args, Boolean
isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority
priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg,
IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame
frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame
frame)
  bei System.Windows.Window.ShowHelper(Object booleanBox)
  bei System.Windows.Window.Show()
  bei System.Windows.Window.ShowDialog()
  bei AlbumArtDownloader.ArtSearchWindow.OnEditPresets(Object sender,
RoutedEventArgs e)
  bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target,
RoutedEventArgs routedEventArgs)
  bei System.Windows.EventRoute.InvokeHandlersImpl(Object source,
RoutedEventArgs args, Boolean reRaised)
  bei System.Windows.UIElement.RaiseEventImpl(DependencyObject sender,
RoutedEventArgs args)
  bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
  bei System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object
arg)
  bei
System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate
callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object
source, Delegate callback, Object args, Boolean isSingleParameter,
Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate
callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei
System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Obje
ct state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei
System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedC
leanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext
executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext
executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32
msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr
wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei
System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate
callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object
source, Delegate callback, Object args, Boolean isSingleParameter,
Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate
callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority
priority, TimeSpan timeout, Delegate method, Object args, Boolean
isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority
priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg,
IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame
frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame
frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunDispatcher(Object ignore)
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei
AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance
instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)

A German WinXP SP3 is used here.
Title: Album Art Downloader XUI
Post by: tuxman on 2009-03-22 20:06:31
Is there an easy way to store a "Save images to" preset?
My preferred default is G:\%artist%\%album%.%extension%...
Title: Album Art Downloader XUI
Post by: docnoq on 2009-03-28 18:30:47
I think I have the same question as tuxman. But to elaborate a bit, I just want my images to save as cover.jpg instead of Folder.jpg. WMP has been erasing/replacing my Folder.jpg files, so I think I am going to switch to the cover.jpg method instead (plus my D2 reads album art as cover.jpg). I see the option to change the name, and the Save as button, but neither one remember my setting for the next album. Thanks,

-Docnoq
Title: Album Art Downloader XUI
Post by: soulkarver on 2009-03-28 19:17:03
I also would like a setting to remember to save art as 'cover.jpg' or whatever other name I choose.
Title: Album Art Downloader XUI
Post by: jasperooni on 2009-03-29 22:19:54
Hello, on Vista Business x64 I encounter crashes sometimes while AAA is searching for covers. I don´t know why.

And I don´t know how to post a crash report on this. Where is the logfile, in which folder?

Thanks for AAA. It´s an essential addon for me. I use it via foo_run with a button in my foobar2000.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-03 08:24:16
Hello all,

Sorry about the delay in replying. This board having broken email notification of replies has really not helped!

Anyway, lets get down to some answers:
I just thought I'd let you know that the source script for Cover-Paradise is misspelled.
No, not misspelled, just German. That's what they call themselves, so that's what I'll call the script: http://www.cover-paradies.to (http://www.cover-paradies.to)

However it looks like the cover-paradies.boo script doesn't work or got broken.
Yes, looks like they've changed their site again, I'll update the script soon when I get a chance, and post it here.

I had a look at the script and I am not much of a programmer but is there somewhere a reference helping to understand / write these scripts?
Sorry, no. The language is Boo (http://boo.codehaus.org), a .net-based language, if that helps. If you are serious about writing scripts and want some help, I can answer some questions on them for you.

Quote
I also would like a setting to remember to save art as 'cover.jpg' or whatever other name I choose.
The path to save art is already saved. The exception to this is that if you start the search window from the file browser, the path to save art is set to the path it searched for art in for that folder. So, if you want to change it from folder.jpg to cover.jpg, then open the Options panel in the File Browser and remove the folder.jpg option, or move the cover.jpg option to be the first one. (It is the first alternate in the list that is used for the path to save art to. Alternates are separated by the | character).

Quote from:  link=msg=624525 date=0
I don´t know how to post a crash report on this. Where is the logfile, in which folder?
The log file should be created in the Album Art Downloader program folder, which by default is C:\Program Files\AlbumArtDownloader\errorlog.txt.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-03 08:44:47
As promised, updated cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo).
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-04-03 16:05:46
Thanks for the updated script.

Sorry about the delay in replying. This board having broken email notification of replies has really not helped!

In case you missed my last post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=614537) about this, it's not broken, "Immediate Email Notification" setting changed when the forum upgrade was made. Back then I made a voting topic for this setting: "Immediate Email Notification" setting POLL (http://www.hydrogenaudio.org/forums/index.php?showtopic=69384), other half seems to like the new setting, and other half not, I'm still finding it stupid that I've to do log in/log out everytime I get a notification email (if I want to get further notifications for that thread), e.g. I've been doing that for this thread.. it's stupid but what can you do, the admins are not interested to change this new setting nor providing the old setting as an alternative. Also the RSS problem (only new threads are shown as unread in various RSS readers (FeedDemon, Google Reader, etc.), old threads with new posts are NOT shown as unread again even if the content has changed) is a major drag.

EDIT: Hmm, maybe it's broken after all, I'm pretty sure that I've used the "log in/log out" method for every new post to ensure I get further notifications for the "REACT 2 Released" thread, but I just noticed that there's a new post made on 27th March, which I have totally missed, no notification for that post at all.
Title: Album Art Downloader XUI
Post by: docnoq on 2009-04-05 20:06:11
Quote
I also would like a setting to remember to save art as 'cover.jpg' or whatever other name I choose.
The path to save art is already saved. The exception to this is that if you start the search window from the file browser, the path to save art is set to the path it searched for art in for that folder. So, if you want to change it from folder.jpg to cover.jpg, then open the Options panel in the File Browser and remove the folder.jpg option, or move the cover.jpg option to be the first one. (It is the first alternate in the list that is used for the path to save art to. Alternates are separated by the | character).


Ah, that did the trick. Many thanks!


Title: Album Art Downloader XUI
Post by: tesa185 on 2009-04-08 21:27:05
As promised, updated cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo).


Hi !

This is an amazing tool !!!

I just added the V0.8 Cover-Paradies script but it doesn't seem to work for me.
I never get any result from the Cover-Paradies site, which is pretty sad, coz this used to be my favourite cover source site.

Cheers,

Dave
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-09 08:07:48
I just added the V0.8 Cover-Paradies script but it doesn't seem to work for me.
Still works for me. Can you tell me what artist and album you were searching for?
Title: Album Art Downloader XUI
Post by: tesa185 on 2009-04-09 21:24:25
I just added the V0.8 Cover-Paradies script but it doesn't seem to work for me.
Still works for me. Can you tell me what artist and album you were searching for?

I used Madonna just to give it a try.
In the meantime I found something out:

When entering only the artist (Madonna) ... Cover-paradise finds no itmes
When entering the artist (Madonna) AND an album (ray of light) ... Cover-paradise shows me 8 results.

So it seems that i do have to enter an album aswell, right ?

Dave
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-10 08:04:09
So it seems that i do have to enter an album aswell, right ?
Yeah, several of the scripts are like that. Probably possible to fix them in most cases, but as a quick workaround you can generally just put a space in the Album field and it will work.
Title: Album Art Downloader XUI
Post by: pej on 2009-04-10 19:41:17
I have been using this application for some time now, and recently it's stopped working for me. I can't quite figure out what's wrong. I just get this error message every time I try to run the exe file.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.25.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3

System.Windows.Markup.XamlParseException: Cannot convert string 'AlbumArtDownloader.ico' in attribute 'Icon' to object of type 'System.Windows.Media.ImageSource'. No imaging component suitable to complete this operation was found.  Error at object 'AlbumArtDownloader.Splashscreen' in markup file 'AlbumArt;component/splashscreen.xaml'. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
  at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
  at System.Windows.Media.Imaging.BitmapFrame.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy)
  at System.Windows.Media.ImageSourceConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
  at System.ComponentModel.TypeConverter.ConvertFromString(ITypeDescriptorContext context, CultureInfo culture, String text)
  at System.Windows.Markup.XamlTypeMapper.ParseProperty(Object targetObject, Type propType, String propName, Object dpOrPiOrFi, ITypeDescriptorContext typeContext, ParserContext parserContext, String value, Int16 converterTypeId)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.XamlTypeMapper.ParseProperty(Object targetObject, Type propType, String propName, Object dpOrPiOrFi, ITypeDescriptorContext typeContext, ParserContext parserContext, String value, Int16 converterTypeId)
  at System.Windows.Markup.BamlRecordReader.ParseProperty(Object element, Type propertyType, String propertyName, Object dpOrPi, String attribValue, Int16 converterTypeId)
  at System.Windows.Markup.BamlRecordReader.ReadPropertyRecordBase(String attribValue, Int16 attributeId, Int16 converterTypeId)
  at System.Windows.Markup.BamlRecordReader.ReadPropertyConverterRecord(BamlPropertyWithConverterRecord bamlPropertyRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.Splashscreen.InitializeComponent()
  at AlbumArtDownloader.Splashscreen..ctor()
  at AlbumArtDownloader.Splashscreen.ShowIfRequired()
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: tesa185 on 2009-04-11 06:47:07
So it seems that i do have to enter an album aswell, right ?
Yeah, several of the scripts are like that. Probably possible to fix them in most cases, but as a quick workaround you can generally just put a space in the Album field and it will work.

Thanks, Works fine for mir now with the space
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-11 07:59:28
I have been using this application for some time now, and recently it's stopped working for me. I can't quite figure out what's wrong. I just get this error message every time I try to run the exe file.

Strange. Do you know if any of your other .net applications have stopped working too? The only thing I can think of is to try uninstalling and re-installing the .NET Framework (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7).
Title: Album Art Downloader XUI
Post by: poisonborz on 2009-04-19 08:57:20
Will AAD in the future be able to write album art directly in to the files? (I also dislike this trend, but many players, including mobile devices, only recognize embedded covers)
Title: Album Art Downloader XUI
Post by: dutch109 on 2009-04-19 15:36:38
Will AAD in the future be able to write album art directly in to the files? (I also dislike this trend, but many players, including mobile devices, only recognize embedded covers)

http://www.hydrogenaudio.org/forums/index....st&p=608858 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=608858)
AAD will remain a tool for downloading album art, and saving it as a file.
Title: Album Art Downloader XUI
Post by: SkripT2 on 2009-04-21 19:49:24
Hi, First of all congratulations to AlexVallat for this very useful program. I'm very pleased with it. With just a new feature it would become just perfect for my taste. I would like that AAD would search automaticaly for all the albums in a root folder and automatically would asign a cover to the album in a batch process witouth interaction with the user. The cover could be the first or the biggest in size found in Amazon.com. Or it could be a more smart process comparing different covers found in other sources and assigning the better one. But all without interaction with the user, as I've said. What do you think?

Many thanks. Regards.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-24 11:02:14
I would like that AAD ... automatically would asign a cover to the album in a batch process witouth interaction with the user.
It's a possibility for the future. The command line version can already be used to download a single cover non-interactively. The only issue is that for it to work well you need to be very specific about what you are looking for, both in artist and album name, and in desired cover size and order of sources to use. Even then, with some of the sources you still end up with a reasonable chance of getting an incorrect cover returned.
Title: Album Art Downloader XUI
Post by: SkripT2 on 2009-04-24 22:56:42
Thanks again AlexVallat. I think that, in addition to that feature, could be something like this. From each album contained in a root folder, obtain a certain number of image results from each source. Then
compare the thumbnails between each of them. The image that is repeated more times is meant to be the cover of the album. Then asign the cover greater in
size for example  from that group or from a specified source (from a list of priority sources). I think that's a smart process that follows what is done manually. what do you think? I was a beginner in programming when i was younger and that's how I would do this task but other ideas would be accepted 


Many thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-25 07:40:35
Then compare the thumbnails between each of them.
That is almost certainly not going to happen. Useful image similarity comparison is Tricky, with a capital T, and not something I'm about to work on here.
Title: Album Art Downloader XUI
Post by: SkripT2 on 2009-04-25 18:05:55
Ok many thanks anyway
Title: Album Art Downloader XUI
Post by: floepie on 2009-04-28 16:37:04
Hi, thanks for this great app.  Very handy!

I've run up against a bit of a limitation and am wondering how to go around it.  When I point the browser to my collection, it will run fine until it runs up against an album/artist whose letters exceed that of the allowable character limit.  First, I've never run up against any problems with any media players not being able to see or play the files.  But, more importantly, because I have such a large collection, I don't know which albums were omitted from the search importation.  It seems that when the character limit is encountered, the search aborts entirely so that albums that haven't been indexed and which otherwise would have been searched, are not included in the browser list. 

Would there be any way to modify the app such that once the character limit has been encountered the search will continue, OR have the app report which album it was in the process of importing and which triggered the error.  Thanks again...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-29 08:31:07
When I point the browser to my collection, it will run fine until it runs up against an album/artist whose letters exceed that of the allowable character limit.
Sounds like a bug to me. There's not supposed to be a limit - could you give me an example of an album/artist which fails? If I can't reproduce it with that, I may need to ask you to email me a sample track which fails too - would you be able to do that?
Title: Album Art Downloader XUI
Post by: floepie on 2009-04-30 14:54:59
When I point the browser to my collection, it will run fine until it runs up against an album/artist whose letters exceed that of the allowable character limit.
Sounds like a bug to me. There's not supposed to be a limit - could you give me an example of an album/artist which fails? If I can't reproduce it with that, I may need to ask you to email me a sample track which fails too - would you be able to do that?


OK thanks for the reply.  This is a very strange problem that you won't be able to replicate unless you're sitting in front of my computer.  The longest file path + filename in my collection is 257 characters.  If I scan this folder (album) by itself or relocate it to a path of similar length so that it becomes the only folder scanned by the browser, no errors are reported.  When it was removed from the larger collection, I re-scanned.  This time, it stopped at another album whose tracks averaged about 240 characters or so.  I removed that album along with other albums that were relatively long as well and stuck them all in the same parent directory called "Long Names".  I then scanned this "Long Names" folder with the browser, and everything worked as well.  Finally, I went back to the much larger collection (with their long named albums removed) and everything scanned without error.  If I then bring back the "Long Names" directory into the larger collection, errors result again.  Bizarre.

Sorry I can't help further...
Title: Album Art Downloader XUI
Post by: floepie on 2009-04-30 15:41:19
Would there be a relatively easy way to add a "resolution" or "dimensions" column in addition to the 5 existing possible column headers that can be selected from in the browser window?  Or, perhaps two additional columns - one with horizontal pixels and one with vertical pixels?  It would a be great way to easily determine which covers have too much resolution for their size (low quality cover art) and which albums simply don't have enough pixels.  Thanks again...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-04-30 16:06:49
Floepie, thanks for taking the time to look into this for me. From your descriptions, I will try and see if I can reproduce the error here, and if I can, I'll fix the bug.

In answer to your other question, in order to display the dimensions of the images, they would actually have to be loaded from disk. This would slow down the search operation considerably, which is why I have not done so. The file size can be obtained without needing to load the image, and is usually a good enough indicator of the approximate image-size. I have considered having a background second pass which would slowly crawl over all the results filling in dimensions for each as it loads them, but I'm not sure if this will ever make it in.
Title: Album Art Downloader XUI
Post by: floepie on 2009-04-30 19:11:17
Floepie, thanks for taking the time to look into this for me. From your descriptions, I will try and see if I can reproduce the error here, and if I can, I'll fix the bug.

In answer to your other question, in order to display the dimensions of the images, they would actually have to be loaded from disk. This would slow down the search operation considerably, which is why I have not done so. The file size can be obtained without needing to load the image, and is usually a good enough indicator of the approximate image-size. I have considered having a background second pass which would slowly crawl over all the results filling in dimensions for each as it loads them, but I'm not sure if this will ever make it in.


Oh, I really like the idea of a background second pass.  You could have it disabled by default as an unchecked box in the options and have a warning in parentheses that it may slow the scan.  I just tried this using the built in Windows explorer by adding a 'dimensions' column, and it doesn't seem to slow the search down at all with a *.jpg search of my entire music directory.  In any case, that would be very handy but something I could certainly live without.  Thanks again for the best album art tool available....
Title: Album Art Downloader XUI
Post by: GHammer on 2009-05-01 04:30:14
Floepie, thanks for taking the time to look into this for me. From your descriptions, I will try and see if I can reproduce the error here, and if I can, I'll fix the bug.

In answer to your other question, in order to display the dimensions of the images, they would actually have to be loaded from disk. This would slow down the search operation considerably, which is why I have not done so. The file size can be obtained without needing to load the image, and is usually a good enough indicator of the approximate image-size. I have considered having a background second pass which would slowly crawl over all the results filling in dimensions for each as it loads them, but I'm not sure if this will ever make it in.


Oh, I really like the idea of a background second pass. You could have it disabled by default as an unchecked box in the options and have a warning in parentheses that it may slow the scan. I just tried this using the built in Windows explorer by adding a 'dimensions' column, and it doesn't seem to slow the search down at all with a *.jpg search of my entire music directory. In any case, that would be very handy but something I could certainly live without. Thanks again for the best album art tool available....


That should be harmless enough if you are getting good search results.
I see many 'not-in-the-ballpark' results when I search for art for my particular collection. I'd not want to download all the erroneous files if I didn't have to.
Right now I have a size limit of 400 pixels and then can see how large each is to do a preview of the candidates if there are more than one.

For the same reason, I would not use an automatic retrieval feature if there were one.
I tend to listen to the music while geting the cover art, so for me it is not a chore.
This tool makes it very easy to get the art I want without much fiddling with this or that, reviewing results, etc.

If these features are added in the future, please make them selectable.

Title: Album Art Downloader XUI
Post by: floepie on 2009-05-01 15:43:43
That should be harmless enough if you are getting good search results.
I see many 'not-in-the-ballpark' results when I search for art for my particular collection. I'd not want to download all the erroneous files if I didn't have to.
Right now I have a size limit of 400 pixels and then can see how large each is to do a preview of the candidates if there are more than one.

For the same reason, I would not use an automatic retrieval feature if there were one.
I tend to listen to the music while geting the cover art, so for me it is not a chore.
This tool makes it very easy to get the art I want without much fiddling with this or that, reviewing results, etc.

If these features are added in the future, please make them selectable.


What are you referring to?  No one is talking about downloading images.    I was referring to adding a 'dimensions' column to the *browser* window (ctrl b) so that dimensions can be shown for your *existing* album covers.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-09 13:34:16
Album Art Downloader XUI v0.26 Released
This release adds an online update checking feature. By default, it will check for updates automatically (maximum of once per day), checking for both new releases, and more importantly, updated scripts. That way, when I need to fix up a script because a site has changed their layout, you can easily grab the updated version. To disable automatic update checking, go to the Help menu, click Check for Updates, then uncheck the "Automatically check for updates" checkbox.

If you prefer, you can also look at the scripts list in your web browser and manually download whatever you want: Updates.xml (http://album-art.sourceforge.net/Updates.xml).

You will still need to let me know if a script you use stops working, though, as I don't use them all myself so rely on users to report when they are broken!

There are two new scripts included in this release: maniadb and Encyclopaedia Metallum. Juno Records, CDCoverHideout and Yes24 scripts have been updated and should now work again. Rate Your Music has been removed, as it isn't worth the effort of writing a workaround for the obfuscation and protection that the site is using to prevent scripted access.

Also, a couple more highly requested features have been added to this release: I've added "Dimensions" column to file and foobar browser results grid. I think the way I've implemented this shouldn't result in a performance problem, as it is reading the dimensions out of the file header, so doesn't need to read the whole image file (just the start of it). If anyone is finding File Browser performance to have slowed significantly in this release, though, please let me know.

Secondly, I've added some Various Artists detection to the file browser. This works by checking to see if a single folder contains tracks which all have the same album name, but different artist names. If so, then these are treated as a single album with the artist name "Various Artists". It only checks per-scan, so if you drag one track from that folder into the browser, then drag a second one, it will never combine them into a single various artists album.

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.26.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.26.1.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-MediaInfoX64Upgrade.exe) (x64 version of MediaInfo - must be installed if you are running a 64 bit version of Windows)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-05-09 14:15:40
Pops up, then crashes.

Quote
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.26.0.0, running on Microsoft Windows NT 6.0.6001 Service Pack 1

System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei AlbumArtDownloader.Properties.Settings.get_LastUpdateCheck()
  bei AlbumArtDownloader.Updates.CheckForUpdates(Boolean forceCheck)
  bei AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  bei System.Windows.Application.<.ctor>b__0(Object unused)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunDispatcher(Object ignore)
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)


Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-05-09 14:24:44
I have a similar error as well after upgrading. Vista x64
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files (x86)\AlbumArtDownloader\errorlog.txt

App version: 0.26.0.0, running on Microsoft Windows NT 6.0.6001 Service Pack 1

System.NullReferenceException: Object reference not set to an instance of an object.
  at AlbumArtDownloader.Updates.CheckForUpdates(Boolean forceCheck)
  at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Application.RunInternal(Window window)
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-09 16:51:08
Damn, but that's irritating. Let me look into it, see if I can reproduce the problem. Until then, probably best if others hold off updating.

Sorry,

Alex
Title: Album Art Downloader XUI
Post by: LordWarlock on 2009-05-09 16:53:34
Also crashing here on Win7.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-09 17:15:04
OK, I think it's a settings upgrading problem.

I think I've fixed it with this 0.26.1. Could you give it a go and let me know if it resolves the issue for you?

AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.26.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.26.1.zip) (zip archive for those who don't like installers)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2009-05-09 17:28:52
Works! Thank you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-09 17:33:55
Oh good! I've updated the link in the release announcement post, and hopefully this small hiccup can get swept under the carpet. :-)

Apologies for missing this in my own pre-release testing.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2009-05-09 17:55:58
No, I'll blog this immediately, pointing with my fingers at this hiccup!
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-05-09 18:15:44
Hi Alex,

Yes indeed, it has been fixed. Thanks!
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-05-10 14:49:09
This release adds an online update checking feature. By default, it will check for updates automatically (maximum of once per day), checking for both new releases, and more importantly, updated scripts.
...
If you prefer, you can also look at the scripts list in your web browser and manually download whatever you want: Updates.xml (http://album-art.sourceforge.net/Updates.xml).

Fan-tas-tic! Thank you. But, the infamous but:

1) Updates.xml shows hitparade.ch v0.1 script, no update notification, not included in the latest installer?
2) Updates.xml shows Metal Library v0.1 script, no update notification, not included in the latest installer?
3) Encyclopaedia Metallum script filename metal-archives.boo is maybe a bit misleading, all other scripts have "proper" identifiable filenames.

Maybe the updater should handle also new and obsolete scripts. If you implement these changes, there would be no need to manually check and download/delete..? And add an option to ignore updates for those who doesn't want to use all scripts (manually deleted scripts).. in fact, taking it further, make a disable (do not show these sources in the main window)/update "control panel" for scripts.. keep the script directory updated at all times (it should contain exactly the same scripts as listed in your online Updates.xml).. or something like that.. just try to eliminate the need to manually check/update/delete scripts.. it's PITA. Thanks.

Rate Your Music has been removed

Only from new installs.. maybe the installer should remove obsolete scripts when updating?! (or it could be handled by the updater/"control panel" like I visioned above) That would be great.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-10 15:23:34
Thanks for the feedback. Yes, hitparade and Metal Library should have been part of the installer, but got missed out. They are in the zip file, or you can download them directly. I'll make sure they are bundled into the installer for the next version.

Metal-archives.boo was originally named after the url, but I agree it would be better if it had been named after the script name. Unfortunately it would be an absolute nightmare to change. An installer could force a rename, but not everyone would run the installer, and having two copies of the script with different names would cause problems. I think this one will just stay as it is now, sorry.

At the moment, only updates for scripts that you have installed will be shown. In the future, I may add a separate command to browse for available scripts. If that does go in, then a notification that new scripts are available could go in, which would notify only once per script that you had not seen before. The only problem I have with this is that the first time it is run after installation, unless you installed with all available scripts, you would get the notification of new scripts popping up. That could be a bit annoying if you'd deliberately chosen not to install them.

I'll have a think about how best to handle obsolete scripts. I don't much like the idea of automatically deleting them from the installer, although I can't put my finger on exactly why, though. Just the general principle that you wouldn't expect running an installer to delete files, I suppose, but I can't see that it's really any more harmful than automatically replacing them with newer versions.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-05-10 16:18:04
An installer could force a rename, but not everyone would run the installer, and having two copies of the script with different names would cause problems.

This would not be a problem with my suggestion to keep the scripts directory updated at all times (i.e. synched from web). But then, with my suggested system, user wouldn't have to be concerned about script filenames.

In the future, I may add a separate command to browse for available scripts. If that does go in, then a notification that new scripts are available could go in, which would notify only once per script that you had not seen before. The only problem I have with this is that the first time it is run after installation, unless you installed with all available scripts, you would get the notification of new scripts popping up. That could be a bit annoying if you'd deliberately chosen not to install them.

I'll have a think about how best to handle obsolete scripts. I don't much like the idea of automatically deleting them from the installer, although I can't put my finger on exactly why, though. Just the general principle that you wouldn't expect running an installer to delete files, I suppose, but I can't see that it's really any more harmful than automatically replacing them with newer versions.

If AAD XUI would

- keep the scripts directory updated at all times (check from net)
- remove script selection from installer (install all.. I see no harm in that)
- implement a "control panel" (think about Mozilla Add-On dialog windows style) for disabling scripts that the user doesn't need when searching (the disabled scripts would still update.. I see no harm in that)
- an update notification (maybe "update yes/no dialog" which lists all changes) that there are new/updated/obsolete scripts (user can then disable new scripts, if they like, from the "scripts control panel")

you would improve the situation for you and the users. I don't see it as a bad move to "automate" the scripts control as long as you provide an option to disable scripts. What the users want? Scripts that are up-to-date and working automatically without any manual checking/downloading/deleting. And an option to disable scripts so that those are not shown in the main search window. Am I missing something?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-10 18:37:33
Hmm... I can tell we are looking at this in different ways. I had assumed users would generally only have a couple of scripts that they used, and would want those kept up to date. Adding a new script would be a specific action to try and address some area their usual scripts were lacking (adding one of the Metal specialist scripts, for example, if they needed it).

From what you've said, it sounds more like you'd want to have every possible script installed, and install any new script whenever it was available. The exception would be to exclude a specifically unwanted script, rather than pick and choose the wanted ones.

Anyone else want to express an opinion? Do you just pick and use a small number of scripts, or do you like to have everything possible, then sift through all the results to choose the best each time?
Title: Album Art Downloader XUI
Post by: floepie on 2009-05-10 19:02:49
Alex, Thanks very much for the update - I'm eager to use the new dimensions feature.  However, I can't run it, because I think I have a botched .NET 3.5 SP1 installation that is irreparable on my Vista install.  I've tried everything (MS hotfixes, etc, etc.).  Time for Windows 7 RC1.  Oddly, your previous version worked fine. 

I like as many sources and scripts as possible.  It really doesn't take too long to wait for the results, and if you have the results sorted by size or source, you pretty much know where your favorite sources (or size) will end up in the list of results.  As for removing scripts that no longer work, you could implement some sort of script status page in the options, which lists the installed script and their status as to whether they work or have become obsolete, in which case they would be safe to delete.  That way, your installer would not have to delete anything, and you could leave it up to the end user to leave it be.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-05-10 23:10:34
From what you've said, it sounds more like you'd want to have every possible script installed, and install any new script whenever it was available. The exception would be to exclude a specifically unwanted script, rather than pick and choose the wanted ones.

I would not use "exclude" but "disable" word, did you mean exclude from the search? Anyways, how many new users really know which scripts they would like to use when installing AAD for the first time? If I say that none, IMHO I'm not far away from the truth. And isn't AAD's main feature to have many different cover sources to choose from? Old users who have disabled (in my system) some of the sources, would not see them in the search until they decide to enable those from the "source control panel", even if they update AAD and/or sources. Either way, from installer or from the running program, user would have to disable a source once. On the plus side (in my system), all of the scripts are there and up-to-date if one suddenly wants to use them. No manual checks (PITA task to compare which script files you have and don't have), no manual downloads, no manual deleting of files, no problems with deploying new sources, no problems deleting obsolete sources. Only change for the end user (new user) would be that they would have to disable sources after installing rather than not installing them.

And I wouldn't "offer" updates, I'd just notify the user that these sources are going to be changed (accept? yes/no.. no choosing of individual sources of what to change/update.. just updating a whole "set"), listing all new/updated/deleted (obsolete) sources. My idea is to have the sources always exactly as they are in your website where the situation is checked from. So, every user (who has loaded the latest update from your website) has the same set of source files, the only change is which ones (if any) the users have disabled (and those disabled are still updated.. or make AAD check for an update when a source is enabled again).

Sorry if I'm repeating myself here but I sensed that you didn't fully understand what I was after. (My life problem, I see that I'm the Mr. Clarity itself (almost) always but many many times people misunderstands me. )

Anyone else want to express an opinion? Do you just pick and use a small number of scripts, or do you like to have everything possible, then sift through all the results to choose the best each time?

That's interesting to know, I agree, but IMHO it doesn't matter in the case "status quo Vs. "my vision""  because both scenarios are possible in both. And using many sources is not a problem when using "group by: source" (and possibly "Sort by: size"). It's easy to go thru all results that way.. the best sources are usually always on top of the result list (if bigger cover size = good cover = good source).
Title: Album Art Downloader XUI
Post by: phunkydizco on 2009-05-11 14:35:50
Is it possible to save the album art in an mp3 tag? I need this for my mobile phone.
Title: Album Art Downloader XUI
Post by: tuxman on 2009-05-11 14:41:28
No.
Title: Album Art Downloader XUI
Post by: Pike84 on 2009-05-12 07:16:21
I like Akkurat's vision - I like the idea of having several options to choose from (not only in this program's case) .
Title: Album Art Downloader XUI
Post by: Anas on 2009-05-12 19:08:30
Anyone else want to express an opinion? Do you just pick and use a small number of scripts, or do you like to have everything possible, then sift through all the results to choose the best each time?

I only have a small number of scripts. As much as are needed to get at least a few results for each request, which isn't quite easy sometimes. Some scripts are not used by me, because their quality isn't that great after all.
I think it would be nice to have an update/install dialog for scripts. Auto-update would be fine with me and concerning installation of new scripts, it would be nice to define which scripts are installed and which not. It would be useful though to have new scripts installed always, so that you are forced to evaluate them.

Thanks for the program, by the way, it's one of the utilities that make your computer-life much easier.
Title: Album Art Downloader XUI
Post by: kinglaiho on 2009-05-13 10:13:15
hi all

i was just wondering how i can change the default save path for Album Art Downloader (i have the latest version)

i am looking to do this so i can have all my album art in one folder which has each of the files as artist - album

any help would be greatly appreciated

cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-13 11:04:20
i was just wondering how i can change the default save path for Album Art Downloader
In the search window, click the Options link, then put the path in the "Save images to" box. You probably want something like C:\AlbumArtImages\%artist% - %album%.%extension%

If you use the file or foobar browser windows, then you should also update the path it uses to look for images, so it knows to find them there. To do this, in the file or foobar browser window, click the Options link, then put the path in the "Specify path to find images" box. As it's an absolute path (not relative to the folder the music is found in), just use the same path that you used for the search window.

Hope this helps!

Alex
Title: Album Art Downloader XUI
Post by: kinglaiho on 2009-05-13 12:12:10
i was just wondering how i can change the default save path for Album Art Downloader
In the search window, click the Options link, then put the path in the "Save images to" box. You probably want something like C:\AlbumArtImages\%artist% - %album%.%extension%

If you use the file or foobar browser windows, then you should also update the path it uses to look for images, so it knows to find them there. To do this, in the file or foobar browser window, click the Options link, then put the path in the "Specify path to find images" box. As it's an absolute path (not relative to the folder the music is found in), just use the same path that you used for the search window.

Hope this helps!

Alex


Hey

yeah that works well for putting them into the same folder, cheers, but what i'm looking for is how to get it to save that path so that i dont have to re-enter it every time
i'll do the file list thingo and then select the ones i want, search all and have 1 search window come up at a time, i change the path, double click on the image i want to save and it saves all well and good
so then i hit the X in the top right, it closes and the next search opens and the path has reverted back. Is there something i'm missing?

Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-13 12:50:31
Is there something i'm missing?
If you start a search from the file browser, then it automatically saves the image to the place the file browser was expecting to find the image file. So, if your path in the file browser is just "Folder.jpg", then it will automatically try to save the result as Folder.jpg in the folder the music was in.

You need to tell the file browser where the images are to be found, so that it knows whether they are missing or not, and where to save them if you start a search for a missing artwork from there.

To do this, in the file or foobar browser window, click the Options link, then put the path in the "Specify path to find images" box, as I mentioned in my first reply.

Alex
Title: Album Art Downloader XUI
Post by: kinglaiho on 2009-05-13 13:00:07
magical
thank you so much :D:D
Title: Album Art Downloader XUI
Post by: phunkydizco on 2009-05-14 15:31:05
@AlexVallat: What do you think about adding mp3 tag support? I know that JPG files are the best way to save album art. But my mobile device can only read embedded album art. There are several id3 libraries, so that it should be easy to implement this.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-14 17:08:28
What do you think about adding mp3 tag support? [...]it should be easy to implement this.
It's not the actual embedding of image into the tag that's the problem, it's the choosing of which files to embed which images into. I refer you to my earlier answer on this subject, which still stands:

One of the major issues with embedding art is that it would have to know exactly which files to embed it into. This would be fairly easy if you have a simple scheme like having one folder per album, and saving the image into that folder. It could then just embed the image into every file in that folder.

The problem is, that isn't the only scheme in use, and I can't think of any good way of automatically determining which files to embed the artwork into that would be safe enough to ship. It could be catastrophically bad if AAD 'updated' a whole bunch of your files with new embedded art, irrevocably losing the art you already had for them.

AAD will remain a tool for downloading album art, and saving it as a file. The job of synchronising album art with embedded tags is a tag-management task, and should be handled by a separate tag-management tool. It's the same class of task as ensuring that all the tracks in an album have the same 'album' tag, and correct track number tag, or that the album tag matches the folder name, that sort of thing.

I expect there are already tools that do this - I don't use embedded album art myself, so I haven't tried one myself. A quick poke around the internet threw up mp3tag (http://www.mp3tag.de/en/) (instructions (http://www.geektonic.com/2008/02/automatically-embed-album-art-to-large.html)) and a dedicated ID3 Embed Pictures (http://www.dalepreston.com/Blog/2007/03/id3-embed-pictures.html) tool, either of which should do the job if your image files and album files are well organised.


If you want, you can track the official Feature Request for this functionality here: support images embedded in id3 tag (http://sourceforge.net/tracker/?func=detail&aid=1858610&group_id=187008&atid=919578). I honestly don't see it ever happening, though.
Title: Album Art Downloader XUI
Post by: ameliajune on 2009-05-16 02:18:01
Hi Alex,
Quite awhile ago I posted about the fact that I have a "folder.jpg" image in my music folder with the music. However, when I go to scan my library and Group By: Local, it doesn't show up. The line Path to Find File Images is %folder%\%filename% and when I hover over it shows the correct path.

It even has the number (1) next to the Local Files box.

I am running Vista 64bit.

Any ideas?

I'd like to be able to scan to compare my current 310x310 image with 600x600 version that I might be able to replace.

Thank you!

Edit: Got it, I had my search parameters to a low resolution artwork so it wasn't showing up. 
Title: Album Art Downloader XUI
Post by: saratoga on 2009-05-16 06:40:19
Is there someway to default to folder.jpg instead of Folder.jpg?  Some of us have to deal with case sensitive file systems.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-16 07:54:47
Is there someway to default to folder.jpg instead of Folder.jpg?  Some of us have to deal with case sensitive file systems.
There are two places the default filename can come from. If you are start searches from the file browser, then click the options link there, and in the "Specify path to find images" box, change Folder to folder. If you are starting searches from the command line, or by entering the details in the search window directly, then click the options link in the search window and edit the "Save images to" box.

Hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: rhumbus on 2009-05-16 10:28:01
I'm trying to launch the AlbutArtDownloader through Run Services in foobar on Windows 7 x64, but it does not seem to work for.
I manage to run AAD through CMD, and it accepts parameters, so there doesn't seem to be a problem with AAD itself.
Is anyone with Win7 X64 managing to launch AAD through foobar?
do you mind sharing your Run Services code line?
Title: Album Art Downloader XUI
Post by: phunkydizco on 2009-05-16 16:11:00
Does someone know an command line tag editor for windows that can embed album art?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-16 20:13:18
Does someone know an command line tag editor for windows that can embed album art?
Surprisingly, there does not appear to be one. I couldn't find one, anyway. What I did find was TagLib# (http://developer.novell.com/wiki/index.php/TagLib_Sharp), which includes as one of it's examples a short command line tool for embedding art in tags. I've compiled it up for you here: SetPictures.zip (http://www.byalexv.co.uk/temp/SetPictures.zip), but it comes untested and unsupported (except potentially by the TagLib# guys, I guess - it's their code!).

Actually, TagLib# looks like pretty nice tagging library, I might investigate switching to using that instead of MediaInfo for the next version, it's a smaller download and wouldn't need a dedicated 64bit version either...

Alex
Title: Album Art Downloader XUI
Post by: phunkydizco on 2009-05-17 09:21:13
Does someone know an command line tag editor for windows that can embed album art?
Surprisingly, there does not appear to be one. I couldn't find one, anyway. What I did find was TagLib# (http://developer.novell.com/wiki/index.php/TagLib_Sharp), which includes as one of it's examples a short command line tool for embedding art in tags. I've compiled it up for you here: SetPictures.zip (http://www.byalexv.co.uk/temp/SetPictures.zip), but it comes untested and unsupported (except potentially by the TagLib# guys, I guess - it's their code!).

Actually, TagLib# looks like pretty nice tagging library, I might investigate switching to using that instead of MediaInfo for the next version, it's a smaller download and wouldn't need a dedicated 64bit version either...

Alex


Thank you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-17 11:41:07
Initial tests have shown that TagLib# is faster, and does not appear to be any less reliable or be able to read fewer tag formats. As removing the 64bit complication, and reducing the download size are both desirable, I'd quite like to move to using it instead.

Before I do, though, could I ask anyone who has an extensive music collection and a little time to help me test it out? I've put together a test build of AAD which will check the tags using both libraries, and report any discrepancies. If you use the file browser to scan your collection (in ID3 tag mode, of course, not file path pattern matching!) then it will produce a report listing any cases in which the two libraries produced different results. If there are any interesting ones listed there, then I'd appreciate it if you'd let me know - and if it isn't obvious, also let me know which result is better or more accurate!

AlbumArtDownloaderXUI-0.26.2-experimental.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.26.2-experimental.zip)

Just unzip it over your existing Album Art Downloader program folder. Once you're finished, you can just re-install or unzip 0.26.1 back over it.

Thanks!

Alex
Title: Album Art Downloader XUI
Post by: Anas on 2009-05-17 12:55:01
I don't exactly know what would qualify as interesting, but there are some that I personally found interesting:

Code: [Select]
[Artist Name] "Янтарные Слезы"(T#) != "???????? ?????"(MI)        (08 - Отреченное Одиночество.mp3)
[Artist Name] "Witt"(T#) != "Witt / Heppner"(MI)        (04 - Die Flut.flac)
[Artist Name] "Various Artists"(T#) != "Ravage"(MI)        (14 - Ravage - Cold Cold World.mp3)
[Artist Name] "Various Artists"(T#) != "Rob Laufer"(MI)        (19 - Rob Laufer - Towards The Sunrise.mp3)
[Artist Name] "Various Artists"(T#) != "Drowning Pool"(MI)        (08 - No More.mp3)
[Album Name]  "A Guitar Odyssey: a Tribute to"(T#) != "A Guitar Odyssey: a Tribute to Yngwie Malmsteen"(MI)        (Various Artists - A Guitar Odyssey_ A Tribute To Yngwie Malmsteen - 1999 - 11 - Evergrey - Rising Force.mp3)

App version: 0.26.2.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)
23207 files scanned; 354 discrepancies detected
Time spent reading tags by MediaInfo: 479531,25ms
Time spent reading tags by TagLib#:   332484,375ms

My interpretation of this results is, that...
MI doesn't seem to read russian characters correctly.
T# on the contrary seems to have problems with multivalue-fields. (Witt vs Witt / Heppner)
T# (sometimes?) reads the album artist field, when MI reads the artist field.
Then there are a whole lot of occureances where T# reads a tag and MI doesn't.

If you need the full log I'll happily post it.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-17 13:38:34
I don't exactly know what would qualify as interesting, but there are some that I personally found interesting:
Good choices, those are very interesting! Score one to the TagLib# library on the Cyrillic characters front, then.

Multi-value fields can be handled better; I told TagLib# to just return the first one, but I can make it keep all of them, separated by / instead.

TagLib# reading album artist (when available) in preference to artist was another deliberate choice. I'm open to other opinions as to which would be the more useful field to use, though - if you have one, post it here.

Another score to TagLib# on being able to read some tags that MediaInfo couldn't.

The only cause for concern I have is with "A Guitar Odyssey: a Tribute to Yngwie Malmsteen", which TagLib# managed to mangle as "A Guitar Odyssey: a Tribute to" instead. I can't think of a good reason why, though.

Thanks for the info!

Alex
Title: Album Art Downloader XUI
Post by: Anas on 2009-05-17 16:12:56
Glad I could be of help.

To set the preference to the album artist field is a good idea, since the covers will normally be listed under the album artist and not under the track artist.

The tags, it does contain are: id3v2|apev2|id3v1, if this is of any help. It might be that T# prefers reading the id3v1 tag vs reading the id3v2. (The id3v1 fields do have a character limit, don't they?)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-17 17:27:11
It might be that T# prefers reading the id3v1 tag vs reading the id3v2.

Good thought, but I just tested it and no, it reads v2 in preference to v1. (Also, it could have fit "Guitar Odyssey: a Tribute to Y" into v1, if it was just auto-clipped).
Title: Album Art Downloader XUI
Post by: Anas on 2009-05-17 18:34:29
I just updated the file tags and it's now using only apev2 and id3v1. The album title is read correctly now as it does no more appear in the taglog.
Maybe it wasn't even T# fault, but the file tag's content was faulty. Alas I can't check that anymore.
Title: Album Art Downloader XUI
Post by: ~*McoreD*~ on 2009-05-18 01:18:37
Alex,

I can definitely vouch for TagLib# - this is the same library I am using for iTSfv.

All the Best,
McoreD
Title: Album Art Downloader XUI
Post by: Cerebus on 2009-05-21 20:33:38
I really like using XUI, but I have this file structure:

Artist / (Year) Album
VA / Album (Year)

this works fine, but:

Artist / (Year) Album / Disc 1
VA / Album (Year) / Disc 2

I can have it ignore the last directory with **, but then it only shows up once in the list of albums instead of twice.  Is my only recourse to use the tags?


Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-22 08:28:07
Is my only recourse to use the tags?

No, you don't have to use tags. You've got a couple of options here. If all your music is under a single folder, so your structure is something like:

\Music\Artist\(Year) Album
\Music\Artist\(Year) Album\Disc 1

and so on, then you can use a pattern starting from that root, and finishing at the album folder, ignoring anything below it. To specify that it should just look at the folder name, end the pattern with a "." The downside to this is that it won't be looking for music files, so if you have folders containing other sorts of files they'd still be listed as albums.

\Music\%artist%\(*) %album%\.

An alternative this would be to make the Disc folder optional. To do this a bit of regex syntax is required:

\%artist%\(*) %album%\"("Disc *\")?"*

The bits inside the quotes are treated as regex, so has the effect of wrapping the Disc *\ portion of the pattern in ( )?, which means it is optional (may appear 0 or 1 times).

Finally, whichever of these options you choose to go with, we can make it deal with the year being allowed both in front of and behind the album name by making it optional in the same way:

\"("(*) ")?"%album%"(" (*)")?"\

That would, also allow albums with no year portion to appear. If that's not the effect you want, and you'd prefer to only include folders which had the year in them, then let me know and I'll show you a different pattern for that. It could also be restricted to look for 4 digits within the brackets too, if necessary.

Final result then:

\Music\%artist%\"(" (*)")?"%album%"("(*) ")?"\.

or

\%artist%\"("(*) ")?"%album%"(" (*)")?"\"("Disc *\")?"*

according to taste.

Hope this helps!

Alex
Title: Album Art Downloader XUI
Post by: Cerebus on 2009-05-22 16:14:12
...but since the %album% part would be the same for each of the cases where there's a subdirectory:

Bargrooves- Azure (2006)\Disc 1 - Ben Sowton\
Bargrooves- Azure (2006)\Disc 2 - Richard Earnshaw\

If, during the scan, you get two albums with the same %album% (and artist is not defined), then it only appears once in the list of found albums - but what if one of the Disc subdirectories doesn't have art?

Thanks for the response.

C
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-22 16:56:42
but what if one of the Disc subdirectories doesn't have art?

Ah, I see what you're getting at now. There's no good solution here, as the file browser is designed to display albums only once, and save only one image per album. There's no way to automatically save one result to two different folders (you'd have to use Save As manually).

If you want each disc to appear as a separate entry in the list, then you'd need to include part of the disc identifier in either the album or artist name, so that it is considered to be a separate album. For example:

\%artist%\%album% (*)\"("Disc %artist%\")?"*

when applied to the paths:
\VA\Bargrooves- Azure (2006)\Disc 1 - Ben Sowton\
\VA\Bargrooves- Azure (2006)\Disc 2 - Richard Earnshaw\

would result in 3 entries in the list, all for the same album name (Bargrooves- Azure), but with artist names "VA", "1 - Ben Sowton", and "2 - Richard Earnshaw". It's not ideal, but it's probably as good as you're going to get. If all your discs are labelled in that form, and the disc names are useful at all, you can do a bit better with:

\%artist%\%album% (*)\"("Disc "\d" - %artist%\")?"*

Which will return artist names of just "Ben Sowton" and "Richard Earnshaw", but would fail to match discs that weren't named using that system.

What you can't have is multiple entries for the same artist and album name - it's designed to consider those to be the same album, and show only once.

Alex
Title: Album Art Downloader XUI
Post by: Cerebus on 2009-05-23 15:51:10
Thx Alex.  Most of the time I only have 'Disc 1' and 'Disc 2' subdirectories, so that makes it less useful, then I'd have to have %artist% set to Disc 1 or Disc 2 in order to split up the albums...anyway, I appreciate your time.  It's still a fantastic program, and I use it constantly.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-24 15:39:22
Album Art Downloader XUI v0.27 Released
Starting with this release, Album Art Downloader no longer depends on MediaInfo. The installer will remove the dll automatically, if upgrading an existing installation. If you are not using the installer, you can just delete it manually, or leave it there - it won't do any harm. The new tag reading library is TagLib#, which should be faster and more accurate.

I have also updated to the latest version of the Boo script compiler (0.91), so scripts can be written taking advantage of the latest language features that makes available.

The Online Update checking feature has been extended to allow download of new scripts, as well as updates to existing one. Once an online update has taken place, if there are scripts available that you do not have installed, a "Get more scripts" link will become available below the sources list. This will bring up a window listing the available scripts, and allowing download and installation. Also in this window is a checkbox to automatically download and install new scripts as they become available, without prompting. That way you will always have all possible scripts installed, if you prefer not to pick and choose.

The Online Update / Get more scripts system can not delete existing scripts, even if they become obsolete. Obsolete scripts will be removed by the installer - for example, the installer currently removed iTunes.boo and RateYourMusic.boo, both of which are now non-functional.

Full list of changes:
Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.27.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.27.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: _oao on 2009-05-26 08:57:33
thanks for the new version!

i just have a small request:
the variable %type% shows Unknown when that info isn't available (in Google searches for example).
so could it be possible to add an option to set the field for when the %type% is Unknown? For example: folder

I also prefer to save the Front cover as folder.*, so it also be cool if i could set the Front (from %type%) to folder.
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-05-26 15:08:30
Hi Alex,

New version 0.27 will not run on my XP Pro SP2 machine using .NET 3.5. This is a work machine and has not been updated to .NET 3.5 SP1. Version 0.25 ran fine in compatibility mode, but 0.27 crashes at opening. Is there a work around? If not, is it possible for me to get version 0.25 to install again?

Thanks!

Edit: Found version 0.25 on page 27. Also, missed the ".NET 3.5 SP1 (Required)" on version 0.27.
Title: Album Art Downloader XUI
Post by: GHammer on 2009-05-26 15:43:35
Thanks for a most useful tool.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-26 16:58:04
could it be possible to add an option to set the field for when the %type% is Unknown? For example: folder

Sounds like a good idea. I've added a feature request (http://sourceforge.net/tracker/?func=detail&aid=2796911&group_id=187008&atid=919578) for it.

Version 0.25 ran fine in compatibility mode, but 0.27 crashes at opening.

That's not something I've done deliberately - there's no reason 0.27 shouldn't continue to run in compatibility mode on 3.5. I'll have to look into it. I don't suppose you kept the errorlog.txt?

Thanks for a most useful tool.

Thanks! Always nice to know when my work is appreciated.

Alex
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-05-26 17:12:37
Hi Alex,

No, I did not keep the error log. I can try and install v.0.27 again to produce one. Let me know. The crash window is the typical XP box that pops up that asks whether to report the crash instance or not. While it is up, v0.27 starts up and you can even click on File or Help and see context box dropdowns and such.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-26 17:33:52
The crash window is the typical XP box that pops up that asks whether to report the crash instance or not. While it is up, v0.27 starts up and you can even click on File or Help and see context box dropdowns and such.

That's interesting... it doesn't even get caught by the AAD error reporting system. There's no need to re-install (unless you want to see if it magically disappears), if it only popped up the standard XP box, no errorlog.txt would be created. What's even stranger is that AAD continues to load itself and run regardless. Could be a clue there; I'll look into it!

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: _oao on 2009-05-27 10:09:43
could it be possible to add an option to set the field for when the %type% is Unknown? For example: folder

Sounds like a good idea. I've added a feature request (http://sourceforge.net/tracker/?func=detail&aid=2796911&group_id=187008&atid=919578) for it.

Alex

Thanks! 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-05-27 18:59:16
Album Art Downloader XUI v0.27.1 Released
This update is just to restore compatibility with .NET 3.5 with no SP1 applied. (v0.26 had unintentionally broken compatibility). If you are already successfully running 0.27 then there is no need to update to 0.27.1. If you have .NET 3.5 without SP1, then I'd first of all recommend updating to SP1, but if you can't for whatever reason, then this version should no longer crash for you.

I've also added a script for ArkivMusic (http://www.arkivmusic.com/), which has covers for classical music albums. It should show up in your Get More Scripts link, or you can download it directly from arkivmusic.boo (http://album-art.sourceforge.net/scripts/arkivmusic.boo).

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.27.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.27.1.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-05-27 21:34:51
Thanks for your continuous development! 
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-05-27 21:41:40
Thanks Alex! Version 0.27.1 is running as expected under .NET 3.5
Title: Album Art Downloader XUI
Post by: antman on 2009-05-31 22:08:51
Alright now.  Who wrote the Buy.com script to give the Black Eyed Peas new album, The End, with every search?!

Type Korn, get Black Eyed Peas.  Type Metallica, get Black Eyed Peas.  Type... you get the point.

My crash in v27.1:

-Search for an album
-Save it
-Try to save another album with same search
-"Do you want to replace it"
-Select 'no'
-Delete an image in the save as box
-Click 'save'
-AAD crashes
-Displays errorlog
-'System.ArithmeticException: Overflow or underflow in the arithmetic operation.'

Title: Album Art Downloader XUI
Post by: Anandamid on 2009-06-01 22:03:34
It's working great here, thank you very much.

GreetinX from Berlin, Germany
Anandamid
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-03 08:46:46
Alright now.  Who wrote the Buy.com script to give the Black Eyed Peas new album, The End, with every search?!

Very strange. I tried searching for Artist: Korn, Album: <blank>, and Artist: Metallica, Album: <blank>, but didn't get Black Eyed Peas for either of them. If it's still happening, could you try the same search on the actual Buy.com website, and see whether Black Eyed Peas appears anywhere on the results page?

As for the crash, I couldn't reproduce it. Does it happen with any album? Or is there a specific search and results that cause it? Could you send me a bit more of the error log, it might help determine what went wrong.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: antman on 2009-06-03 21:57:45
Search for Artist: Korn, Album: Issues, and Artist: Metallica, Album: Master, and I get Black Eyed Peas cover in both.

And yeah, when I search Buy.com for either album, the Black Eyed Peas album is listed in "Similar Products in general" section.  Matter of fact, every album listed in the similar products section makes it way into the search results.  Well, that explains that.

And the crash happens with any album.  I'm running XP-SP3 with .NET 3.5-SP1.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-04 08:42:12
every album listed in the similar products section makes it way into the search results.
I can fix that. I'm sure alsaan won't mind me tweaking his script. buy-com.boo (http://album-art.sourceforge.net/scripts/buy-com.boo) has now been updated, and should show up next time the online update check is made, or you can just download it manually.

Alex
Title: Album Art Downloader XUI
Post by: zim2411 on 2009-06-07 06:32:20
I'm running a fresh install of Vista Business 64 bit SP2, and the program is instantly crashing. I can't get it to run at all

I installed .net 3.5 SP1, installed 0.27.1 from the main installer, then the 64bit upgrade, started the program and got the windows "Album Art Downloader has stopped working, check online for solution, close the program, or debug". Any idea on what I'm doing wrong? 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-07 08:22:11
I'm running a fresh install of Vista Business 64 bit SP2, and the program is instantly crashing. I can't get it to run at all
I'm sorry, but I can't think of what might be causing that. Could you check to see if an errorlog.txt file was produced in the Album Art Downloader folder? If so, you can post it, or send it to me and I'll see if I can figure out what's gone wrong.

By the way, the 64bit upgrade is no longer required (since 0.27) - if something instructed you to install it, please let me know where so I can fix it!

Alex
Title: Album Art Downloader XUI
Post by: zim2411 on 2009-06-07 17:08:48
There is no errorlog.txt generated. The page was here: http://wiki.hydrogenaudio.org/index.php?ti...tDownloader_XUI (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Components_0.9/AlbumArtDownloader_XUI) (first result when googling "album art downloader foobar")
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-06-18 23:42:20
First, thanks a lot for the updates and the update feature. I'm sorry that it took so long for me to comment.

Here's again "couple" of thoughts that came to my mind:

1) Unable to uncheck the "automatically download and install new scripts" once set! The "Get more scripts" is never shown again. Of course it's possible to turn it off manually by editing the "AutoDownloadAllScripts" value in the user.config file.. but that's hardly a user friendly action. Also, it would be nice to have an information window of the update(s), whether it happens automatically or not.. because it would be nice to test out the new source(s), could be hard to notice a change when there are many sources. Yes, I know, then do not use the automatic update, right? Well wrong, the "Get more scripts" link is maybe too subtle (compared to the other update window popping up).. I actually missed it first EVEN though I (well kind of) knew what to expect after reading the changelog.

2) Was it really necessary to break down the update (of scripts & program) and the "Get more scripts" into 2 completely different update systems? I find it a bit odd, wouldn't it be more clear and less hassle for the user to be able to do ALL "updates" from one place?

3) After install, manually checking the updates yielded 8 updates (amazon-ca.boo, amazon-com.boo, amazon-com-mp3.boo, amazon-co-uk.boo, amazon-de.boo, amazon-fr.boo, amazon-jp.boo & buy-com.boo). The 7 amazon updates said 0.9 -> 0.10, I unchecked all but amazon-ca.boo, updated that and restarted, only to find that once doing the manual update check, there were only buy-com.boo left. The amazon-ca.boo was not changed at all (I copied the old one and did compare after), so what happened? Was the amazon-common.boo only file that changed? I think so. Anyways, just letting you know in case you haven't seen this happen.. might be confusing to somebody.. like me.

4) What does "Script updates now include dependency information" actually mean from the user perspective? Strange things happen like I described in the previous point?

5) Are you sure "The Online Update / Get more scripts system can not delete existing scripts"? I'm just thinking of a situation where you're "forced" to release an update of the whole program which only deletes source(s). This when AAD XUI is feature ready and no bugfixes needed (if that's possible at all with computer software ). Then again, are the obsolete scripts a problem? Maybe not.. I can only think of a situation where users would start to complain that sources are not working anymore.. and you'd have no bugfixes or features in the pipeline.

6) It seems that it's not possible to include sources with command line switches. And adding "/localImagesPath" when starting doesn't enable/include "Local Files" source if that was disabled previously. What do you think, would it be a good thing to make "/localImagesPath" switch to automatically enable "Local Files" source? Currently there's a problem in REACT with this, I don't want to use "/sources all" and mess up the disable statuses of the sources users might have done earlier. It really would make sense to enable it if the switch was used in the first place. Maybe additionally the enable should not be "sticky", i.e. not saving the state, just enabling the source for "sessions" which are started with the "/localImagesPath" switch..?

7) I found out that I must change REACT code to handle the update restart XUI does (the PID changes and REACT thinks that the program was shutdown and continues though it should still wait).. oh well, I guess there's always a bad side to everything. I guess it's not feasible but, any chance that you could make XUI load/compile the updated scripts without a restart? Thanks for the efforts on the update feature, good to see that AAD still evolves.


Again I encourage you to boldly push the version to 1.0. I say it's ready for that status. It's SO GOOD! Thank you again for this amazing and wonderful software! I bow befor thee.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-26 10:19:41
Hi, sorry it's taken me a long time to respond. Here's some answers for you:

1) Yes, having some sort of notification that scripts have automatically been updated would be a good thing. That would also be a nice place to hang the UI for disabling auto-update off - you could click on the notification to see a list of the updated scripts and have the checkbox there to uncheck. Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2812643&group_id=187008&atid=919578)

2) I still regard updating existing features and adding new scripts to be two completely separate operations. Installing a new script is not an update. A user should certainly be able to distinguish between keeping all the scripts they've chosen to install up to date, and automatically installing any new script that might become available.

3) Yeah, sorry about that. Someone found a bug with the common functionality for all amazon scripts. That means that if you have any of the amazon scripts installed, each one of them counts as having been updated. As the common functionality for amazon is shared (amazon-common.boo), if you update any of them, then all the others will share the fixed code.

4) From a user perspective, it means I can actually provide updates for files that scripts depend on, as well as the script files themselves. Such as, yes, amazon-common.boo. It's not a common scenario, most scripts are self-contained in a single file.

5) Yes, I'm absolutely sure that I don't want to have the capability to remotely automatically delete scripts.

6) I don't want the /localImagesPath to do anything other than specify the local images path. What I could do is add another parameter, "/include", which would work like "/exclude". It would enable the sources specified, but not change the status of any other sources. Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2812644&group_id=187008&atid=919578)

7) Restarting to apply updates is pretty standard behaviour. It isn't forced, though, so if running from REACT you're best off just not restarting, and the updates will be picked up next time the app is started.

I think what it really lacks for a v1.0 status is proper documentation, and probably a proper website too. Which I will get round to some time. Probably.

As far as code goes, there are a few minor features that will probably make it in. The only big one I'm considering is adding a post-processing system where you could specify the operations to be performed when you hit save (default is to just save as file to %filename%, but options would include resizing, saving additional copies, embedding into specified files, execution of arbitrary external programs, that sort of thing). I haven't decided if it is worthwhile, or would be too confusing, but it's a possibility.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-06-26 22:36:54
Thanks for the answers and added feature reqs.

6) I don't want the /localImagesPath to do anything other than specify the local images path. What I could do is add another parameter, "/include", which would work like "/exclude".

Ok, I didn't suggest the /include switch because I didn't see any other use for it (lack of imagination?). That's why I thought that it would make sense to make the /localImagesPath enable the local source automatically.

7) Restarting to apply updates is pretty standard behaviour. It isn't forced, though, so if running from REACT you're best off just not restarting, and the updates will be picked up next time the app is started.

Unfortunately I can't control the restarting from REACT. I could just write a warning of not to restart to manual but who reads them, really.. where did the RTFM came from.  Or I could try to code REACT so that it detects the restart.. it seems that there's very little time between PID (process) changes.. I could use that, 1 or 2 second delay (in case there's no actual restart) hurts no-one. Can you think of a situation where the new process would start much later after the 1st one closes?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-27 08:11:49
Can you think of a situation where the new process would start much later after the 1st one closes?
I suppose if it was running on a very slow machine, which was busy doing something else at the time? Tough one to test, really.

As far as my code goes, if a restart is requested, a new instance is started (with the same command line parameters the first had) immediately before the first instance exits.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-06-27 12:06:13
Ok, the new instance starts before the old one dies, just what I wanted to hear, so basically there's always an instance running. Thanks for the info.
Title: Album Art Downloader XUI
Post by: kanak on 2009-06-27 18:13:16
Hi Alex, I have a feature request: New AAD windows should not steal focus from existing AAD windows.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-27 18:26:07
New AAD windows should not steal focus from existing AAD windows.

Hi Kanak - can you be a bit more specific? How are you launching the new AAD window? Wouldn't you expect any new window you open to open in the foreground?

Alex
Title: Album Art Downloader XUI
Post by: kanak on 2009-06-27 18:41:12
New AAD windows should not steal focus from existing AAD windows.

Hi Kanak - can you be a bit more specific? How are you launching the new AAD window? Wouldn't you expect any new window you open to open in the foreground?

Alex


Hi Alex,

This is what i mean:

1. I do a File Browser search and queue items.
2. I've set it to launch up to 3 windows at a time.
3. I've set the windows to close automatically after the downloads are gone.
4. So i have like 3 windows open. I download art from Album A. the window closes and now i'm looking at the art for album B. At this time, the new window (replacing the closed window for album A) opens.

It might sound like a minor annoyance, but it's making it really difficult for me to download in batch... as i'm trying to click on the appropriate art, the new window opens obscuring the view. I now have to go back to window B and make the selection.

I hope this clarifies the issue... I can try to be more specific.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-27 18:52:40
This is what i mean:

OK, I understand now. Yes, de-queued windows should open behind existing search windows; I expect that will be fixed in the next version. Bug Tracker (https://sourceforge.net/tracker/?func=detail&aid=2813299&group_id=187008&atid=919575)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: jo-the-ripper on 2009-06-28 15:40:13
hi...

at first a big thx to alex for his nice application. i realy love it.

i just have one question. is it posible to search by artist - title...i just want to search for the "single"("maxi")-cover.

hope it's posible.

thx
joe
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-28 15:48:11
i just want to search for the "single"("maxi")-cover.

Hi Joe, thanks for your comments. You can search for whatever you like, it's up to the individual sources whether they have covers for singles as well as albums. If all else fails, the Google Image source will usually come up with something.

If you mean to get the file browser to use the Title ID3 tag instead of the Album tag, then no, that isn't possible, sorry.

Alex
Title: Album Art Downloader XUI
Post by: jo-the-ripper on 2009-06-28 20:32:27
thx for the fast answer...

i got it by using the mp3tag v2.43. it' realy nice.

but now i have the next problem...if i start your application multiple times,
it will use the queue. i have 3 aktive windows and the other be in queue.
for now if i download a cover it rename it to a special path. for the first 3 active
windows it works very well. but all the others in queue renamed it wrong?

this is what i'm using:

/artist "%artist%" /album "%title%" /p ".\Art\%artist%-%title%.jpg"



i'm using windows 7...should this be the problem??
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-29 08:11:47
for now if i download a cover it rename it to a special path. for the first 3 active
windows it works very well. but all the others in queue renamed it wrong?

i'm using windows 7...should this be the problem??

Windows 7 shouldn't make any difference, although I haven't tested it myself. I'm not sure I understand the problem you are describing, though. Could you give me some simple steps to follow to see it happen?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: jo-the-ripper on 2009-06-29 21:18:54
hi alex...

many thx for your support.

mp3tag - download (http://www.mp3tag.de/en/download.html)

in mp3tag you are able to use external tools...like Album Art Downloader XUI:

mp3tag->tools->options->tools->new
name:albumArt
Path: C:\Program Files\AlbumArtDownloader\AlbumArt.exe
Parameter: /artist "%artist%" /album "%title%" /p ".\Art\%artist%-%title%.jpg"
checked: all selected files

next step:
select some files->RightClick->tools->albumArt

now it should start your application...and now it only rename the first 3 covers correct. if i set the simultaneous search windows to 5...it renames the first 5.

hm...i think mp3tag use the same variables like your app: %artist%" "%title%"

mp3tag-help-tools (http://help.mp3tag.de/en/options_tools.html)

hope we find the failure...

thx again
joe

Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-30 11:10:03
hope we find the failure...

Found it now, thanks. I'll make sure that's fixed for the next release. Bug Tracker (https://sourceforge.net/tracker/?func=detail&aid=2814478&group_id=187008&atid=919575)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-06-30 11:41:07
Parameter: /artist "%artist%" /album "%title%" /p ".\Art\%artist%-%title%.jpg"

By the way, until I fix the bug, you can work around the issue by using the parameter:

/artist "%artist%" /album "%title%" /p ".\Art\%%artist%%-%%album%%.jpg"

instead. That way, the path will always be the same (and Album Art Downloader will perform the artist and album name substitution on save).

Alex
Title: Album Art Downloader XUI
Post by: PJay-Z on 2009-07-03 09:14:08
LastFM Cover doesn't work
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-03 09:30:14
LastFM Cover doesn't work

Hmm... I just tried it here, and it seems to be OK. Are you using v0.3 of the script? What artist and album name did you search for?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-04 14:29:31
Album Art Downloader XUI v0.28 Released
There are various minor fixes and feature requests added to this version. I know the custom %type% labels could probably have been done in a more user friendly way, but at least they're in there now, for those who needed them. Just insert the placeholder, and replace the labels in it with the labels you want to use instead of them.

Changelog:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.28.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.28.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-07-04 14:33:37
The .zip file gives an error 500. 
Title: Album Art Downloader XUI
Post by: RyanThaDude29 on 2009-07-04 15:07:25
Thanks for such a great program!
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-07-04 15:24:50
Thanks for the update. Couple of notes (wow that's a surprise ):

1) the update link in AAD goes to download AlbumArtDownloaderXUI-0.27.1.exe... and it's possible because:
1.1) the summary (https://sourceforge.net/projects/album-art/) page of AAD in sourceforge has "download now" link for 0.27.1.
2) the buy-com and amazon scripts update texts in the changelog could note that these were already previously released through the AAD updates feature, i.e. this is the first release of them in the installer.. dunno what could be a good way to describe these in the changelog though.
Title: Album Art Downloader XUI
Post by: tuxman on 2009-07-04 15:36:11
BTW:
Works now, thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-04 18:35:27
The .zip file gives an error 500. 

the update link in AAD goes to download AlbumArtDownloaderXUI-0.27.1.exe...

Yeah, SourceForge seems to be playing up. What a time for it to happen! I can't seem to convince it to point to the 0.28 version from the Download Now link at the moment. At least they've fixed the 500 errors. Hopefully the Download Now link will just start working soon, but I'll keep trying every so often just to make sure. Sorry about that.

2) the buy-com and amazon scripts update texts in the changelog could note that these were already previously released through the AAD updates feature, i.e. this is the first release of them in the installer.. dunno what could be a good way to describe these in the changelog though.

Yeah, I see what you mean. But the way I see it is the changelog shows what has changed since the last version - even if you've already got those changes.

Thanks for the comments, and RyanThaDude29 - it's nice to know when my work is appreciated!

Alex
Title: Album Art Downloader XUI
Post by: itisljar on 2009-07-04 22:41:21
I get crashes when search result window is full screen, and I exit it clicking on X.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: c:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.28.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.InvalidOperationException: Cannot show Window when ShowActivated is false and WindowState is set to Maximized.
  at System.Windows.Window.VerifyConsistencyWithShowActivated()
  at System.Windows.Window.CoerceVisibility(DependencyObject d, Object value)
  at System.Windows.DependencyObject.ProcessCoerceValue(DependencyProperty dp, PropertyMetadata metadata, EntryIndex& entryIndex, Int32& targetIndex, EffectiveValueEntry& newEntry, EffectiveValueEntry& oldEntry, Object& oldValue, Object baseValue, CoerceValueCallback coerceValueCallback, Boolean coerceWithDeferredReference, Boolean skipBaseValueChecks)
  at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
  at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  at System.Windows.UIElement.set_Visibility(Visibility value)
  at AlbumArtDownloader.SearchQueue.DequeueNextSearchWindow()
  at AlbumArtDownloader.SearchQueue.set_NumberOfOpenSearchWindows(Int32 value)
  at AlbumArtDownloader.SearchQueue.OnSearchWindowClosed(Object sender, EventArgs e)
  at System.EventHandler.Invoke(Object sender, EventArgs e)
  at System.Windows.Window.OnClosed(EventArgs e)
  at AlbumArtDownloader.ArtSearchWindow.OnClosed(EventArgs e)
  at System.Windows.Window.WmDestroy()
  at System.Windows.Window.WindowFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.DefWndProcWrapper(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-07-05 00:35:56
I just experienced the same crash while enqueuing about 114 albums (saved the first cover art, it opened the next window, crash).

Also full screen.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-05 08:41:22
Album Art Downloader XUI v0.28.1 Released

Thanks for reporting this crash. I can confirm it is caused by the code for making dequeued search windows open behind other search windows. Apparently maximized windows can't be shown without making them the active window.

To fix this, I'll have them shown non-maximized, then maximize them as soon as they become the active window. It's not ideal, as you'll see the 'maximizing' animation the first time a maximized window becomes active, but I think we can live with that.

As it's a serious issue, I'm going to release a 0.28.1 immediately with the fix:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.28.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.28.1.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-07-05 15:42:15
I managed to find a situation where AAD crashes:

1) set "automatically check for updates" and "automatically download new scripts" on in AAD
2) delete one script from the Scripts folder
3a) start AAD and do update check (and close the update window)
OR
3b) set your PC clock one day ahead and start AAD (does the update check automatically)
4) click the "new scripts downloaded..." notification
5) close the opened window
6) do update check again

= crash! The "new scripts downloaded..." notification pops-up again at the same time.

If I uncheck the "automatically download new scripts" after the 4th step and continue the same way, there's no crash.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-05 16:23:24
I managed to find a situation where AAD crashes

Thanks for reporting this. I've found it and fixed it - as it doesn't seem like a common situation, the fix will be included in the next version.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-07-05 18:16:13
Already? That was fast.. again. Thanks a lot.
Title: Album Art Downloader XUI
Post by: bsleeth on 2009-07-06 09:20:27
Alex,

Thank you for such a wonderful application and amazing, thoughtful support.

I recently had the need to embed album art into each track (yes, for loading on an iPod ... I have been assimilated!).  I am using another great tool, mp3tag, to embed the art and to fix a few errant tags.

All that to say, that I am starting to playing around with some of the command-line switches and found that when using the /fileBrowser <folder> switch, if <folder> is double-quoted and ends with a trailing slash, the ending quote is not stripped from the value (although the trailing slash is).  This causes the File Browser window to open with an invalid (at least incorrect) "Search for audio files in:" value.  Obviously, the trailing quote must be removed before a search can be performed.

For example, given the command-line of:
Code: [Select]
albumart.exe /fileBrowser "c:\rootmusic\artist_name\album_name\"

the "Search for audio files in:" location in the File Browser window will be:
Code: [Select]
c:\rootmusic\artist_name\album_name"


I assume that any parameter expecting a path value which is double-quoted and ends in a slash will have the same problem.

Thank you once again for such a terrific product,
Brian

NOTE:
I found a work around was to either add an extra slash or to add a trailing dot.  For example either of the following will work:
Code: [Select]
albumart.exe /fileBrowser "c:\rootmusic\artist_name\album_name\\"
albumart.exe /fileBrowser "c:\rootmusic\artist_name\album_name\."



Title: Album Art Downloader XUI
Post by: frnk on 2009-07-07 11:58:37
Thanks for the great great GREAT app, Alex! It's a real time saver.

Just wanted to let you know.

Oh, and that the discogs script doesn't seem to be working. Discogs probably changed their search function... again.
Title: Album Art Downloader XUI
Post by: MC Escher on 2009-07-07 19:07:44
This latest version is using 98% of CPU and 470 MB of RAM when searching album art. I only have three searches going on at the same time, and with earlier versions I had no trouble with that.
Title: Album Art Downloader XUI
Post by: itisljar on 2009-07-09 19:07:11
It ate 700 MB of RAM, 500 is in VM. Nice 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-10 19:20:38
if <folder> is double-quoted and ends with a trailing slash, the ending quote is not stripped from the value (although the trailing slash is).

Thanks for your comments, Brian, it's always nice to know when my work is appreciated. I think I understand why you are seeing the behaviour you describe, the \ is used to escape " marks in command line parameters, so the last \" is being treated as an escaped " mark, rather than a closing quote. I'll fix this for the next version. Bug Tracker (https://sourceforge.net/tracker/?func=detail&aid=2819770&group_id=187008&atid=919575)

the discogs script doesn't seem to be working

Thanks for letting me know, I'll fix that and push out an update shortly.

This latest version is using 98% of CPU and 470 MB of RAM when searching album art [...] with earlier versions I had no trouble with that.

It's possible I've broken something to cause that. When I get a chance, I'll run through some profiling and see if there is anything happening that shouldn't be. It would be really helpful if you could download an older version and verify that for the same search, with the same sources selected, it doesn't spike the CPU in the same way.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-10 19:35:36
Discogs script now updated to 0.6. Should be available through your auto-updater, or you can download it directly here: discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo)
Title: Album Art Downloader XUI
Post by: frnk on 2009-07-10 19:57:06
Thanks Alex! Good stuff!

(The auto-updater only works when run as administrator, but that's probably know already.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-10 20:05:19
OK, I've been through my changes since v0.27, and the only thing I can see that would impact search performance is one additional Regex evaluation per result, with a simple pattern. That wouldn't make a noticeable difference, so I'm going to need some more details. Could you tell me the last version you used that didn't exhibit the problem? Please also let me know whether the problem occurs when performing a search by entering the artist name and album directly, then hitting the Search button, or if it is only when launched from the File Browser. Finally, if you could give me the artist and album you searched for, and the sources searched, I'll see if I can reproduce the problem here.

About memory usage, this app can easily eat up large amounts of RAM depending on settings. If you want to reduce RAM consumption, make sure that Automatically Download Full Size Images is set to Never (under the Options link in the search window), uncheck any sources you don't find useful, and avoid having multiple search windows open at the same time. You may also like to limit the number of results certain sources return. To do this, click the "..." in the bottom left of the source in the list, and enter a smaller limit (10 is the default).

For example, if you have 3 search windows, each with 30 sources providing 10 results, that's 900 results. With Automatically Download Full Size Images set to Always, that could easily be over 1Mb per image, resulting in very large RAM requirements! In practice, you probably don't use every possible source, and for most searches there will be fewer than the maximum 10 results returned by most sources, but this gives you an idea of where the memory is going - I'm not just using it up for the fun of it. Memory is released as soon as a search window is closed, or the results cleared to make way for a new search.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-10 20:27:09
The auto-updater only works when run as administrator, but that's probably know already.

It's supposed to work as a limited user too. Of course, it can't actually update the scripts in the program files folder, as it doesn't have write access to there; so what it does instead is to download the updated script file to \Documents and Settings\<user>\Local Settings\Application Data\AlbumArtDownloader\AlbumArt.exe_Url_<junk>\0.28.1.0\scripts where it overrides the older versions left in the \Program Files\AlbumArtDownloader\Scripts.

I've tested it as a limted user under Windows XP SP3, so if you're finding it doesn't work, could you let me know what OS you are using, and exactly how it doesn't work. (Does it not report an updated version available? Report it available, but fail to download it? Download it, but still show as the old version after restart? Display any error messages of any kind?)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: frnk on 2009-07-11 00:08:29
Hm, yeah, I think it actually used to work.

I have Vista Home Premium SP1.

The updater reports that a new version of the script is available, then when I update and it restarts it hasn't updated. I'll see if I can reproduce it tomorrow to provide you with mopre info.
Title: Album Art Downloader XUI
Post by: tuxman on 2009-07-11 18:53:09
Now I wonder... as a template I set G:\%artist%\%album%.%extension% in the main window. Why does the File Browser still try to save images as folder.jpg?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-11 19:01:19
Why does the File Browser still try to save images as folder.jpg?

Because the File Browser's Path to Find Images doesn't get set automatically from the Search Window's Path to Save Images To. So, chances are, you've still got the Path to Find Images set to Folder.jpg. Change that in the File Browser window, and it should then find them OK. Searches launched directly from the file browser automatically save to the path set there, so that should work too.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2009-07-11 19:08:57
OK I changed the Folder%preset%.%extension%|Cover%preset%.%extension%|%album%.%extension% there to %album%.%extension now. Should fix it, I presume?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-11 19:43:20
OK I changed the Folder%preset%.%extension%|Cover%preset%.%extension%|%album%.%extension% there to %album%.%extension now. Should fix it, I presume?

You should probably have G:\%artist%\%album%.%extension% instead, otherwise it will look for a file named %album%.%extension% in the folder the music track is found in.
Title: Album Art Downloader XUI
Post by: tuxman on 2009-07-11 19:48:16
I usually search covers for files in G: anyway... but OK I thought this would only be the file name, not the full path. Thank you for the hint.
Title: Album Art Downloader XUI
Post by: PJay-Z on 2009-07-12 11:43:18
LastFM Cover doesn't work

Hmm... I just tried it here, and it seems to be OK. Are you using v0.3 of the script? What artist and album name did you search for?


EDIT: Yes, it works, but I gotta use a VPN
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-07-12 12:20:43
Works fine here, tested with "metallica / ride the lightning" search, one result 300x300px.

Maybe it's a "leech prevention" again? Check this post (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=595466) that I made in 2008.. and read the next 2 also. The beef: "So, it seems that this would happen in AAD if user searches some covers and doesn't touch the results for a while.", the posts are about "AllCdCover" source but something similar could be happening with LastFM source too.

EDIT: Oh, it works when using VPN.. then a different IP address was reported to the LastFM source, which makes the "leech prevention" case even more probable.
Title: Album Art Downloader XUI
Post by: Jester-NL on 2009-07-14 20:07:14
This latest version is using 98% of CPU and 470 MB of RAM when searching album art. I only have three searches going on at the same time, and with earlier versions I had no trouble with that.

I am happy that I am not the only who sees his machine come to a grinding hold when using this version.
I love the program, and use it a lot, but at the moment with only 20 or so albums queued, I can have a cigarette and two coffees before any results are displayed.
I am using 0.28.10 on a Windows7 machine. 3GB of RAM, and a 3.2 ghz P4. A few selected script are being used (for instance, I do not need last.fm artists when looking for albumart )

Even after all the searches are done, the program is sluggish and I need a lot of attention just to scroll. This infects other windows as well, until the moment I close Album Art Downloader...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-14 21:41:21
sees his machine come to a grinding hold when using this version.

Thanks for reporting this, it's very useful to know it isn't specific to just one user.

To help me track down the cause, could you tell me:

What version were you using previously, that didn't exhibit the problem?

Does it also happen when performing a search by entering the artist name and album directly, then hitting the Search button, or is it only when launched from the File Browser?

Does it only happen when windows are queued? For example, open 3 blank search windows (File, New, Search Window), then use the File Browser to queue up another 2 or 3 windows - does everything slow down?

You mentioned that CPU usage remained spiked even after the search finishes - does it stay high after you close the search window too? (leave the File Browser open so Album Art Downloader doesn't exit).

I will do my best to come up with an resolution for this.
Title: Album Art Downloader XUI
Post by: Jester-NL on 2009-07-15 18:21:41
(...)

I upgrade from (as far as I recall) 0.27.something, and that version was a lot faster.
A test with just the download-window, and a manually entered search was fast, allowed me to scroll (even during search) and does not slow down my PC. Opening the file-browser doesn't change the working speed of my PC. However, the moment the queue-manager contains more than 3 albums (and I have set it to do my albums one by one, I do not search for multiple albums at the time) the thing slows down.
Once I close all windows again, until just the search-window or filebrowser is open, my machine is back to normal again. So it seems there is an issue (at least on my machine) with the queue-window.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-15 18:45:23
So it seems there is an issue (at least on my machine) with the queue-window.

That's very helpful, thank you. Could you try this experimental version, and let me know whether it still behaves the same way for you?

AlbumArtDownloaderXUI-0.28.2-experimental.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.28.2-experimental.zip)
(just unzip in your album art downloader program folder)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: GHammer on 2009-07-15 20:38:40
This experimental version caused the Metal Library, Buy.com, & Yes scripts to crash.
It does seem to fix the CPU issue here though.
Title: Album Art Downloader XUI
Post by: zim2411 on 2009-07-17 05:15:12
Am I still alone in instant crashes? I still can't get the program to run at all on Vista Business 64bit SP2. No errorlog is generated, and I've had absolutely no luck with compatibility settings. Here's the only remotely relevant information I can provide  . This is from the .28.2 .zip above, but every version back has had the exact same behavior. I do have .Net installed.

From the Vista crash dialogue:
Code: [Select]
Description:
  Stopped working

Problem signature:
  Problem Event Name: APPCRASH
  Application Name: AlbumArt.exe
  Application Version: 0.28.2.0
  Application Timestamp: 4a5e02d5
  Fault Module Name: unknown
  Fault Module Version: 0.0.0.0
  Fault Module Timestamp: 00000000
  Exception Code: c0000005
  Exception Offset: 0000000000000000
  OS Version: 6.0.6002.2.2.0.256.6
  Locale ID: 1033

Am I just sorely out of luck? 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-17 08:12:28
I still can't get the program to run at all on Vista Business 64bit SP2.

Unfortunately, that error doesn't give me much to go on. There's no reason I can think of why it shouldn't work on Vista Business 64bit SP2. As no errorlog is created, I suspect the problem lies with the .net framework. Are you able to run other .net applications? Try NoteScraps (http://www.notescraps.com), for example.

The only suggestion I can make, really, is to try uninstalling and reinstalling .NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7)
Title: Album Art Downloader XUI
Post by: Jester-NL on 2009-07-17 18:07:03
This experimental one seems to do the trick, but I experienced the 'metal library' crash as well (don't use buy or yes)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-17 18:21:09
This experimental one seems to do the trick

Excellent, I'll use that as the basis for a 0.28.2 release this weekend, then. Don't worry about the messages for Metal Library, Buy.com, & Yes, you can safely ignore those. They won't be present in the release version.

Alex
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-07-17 19:12:20
Hi Alex,

I'm getting this error upon installing the v0.28.1.0 overtop of v0.28 in compatibility mode.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.

If you wish to report this error, please include this information, which

has been written to the file: C:\Documents and Settings\WesterfD\AlbumArtDownloader\errorlog.txt



App version: 0.28.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2 (32 bit)



System.MissingMethodException: Method not found: 'Void System.Windows.Window.set_ShowActivated(Boolean)'.

at AlbumArtDownloader.SearchQueue.DequeueNextSearchWindow()

at AlbumArtDownloader.SearchQueue.set_SimulataneousWindowsAllowed(Int32 value)

at AlbumArtDownloader.SearchQueue..ctor()

at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)

at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)

at System.Windows.Application.<.ctor>b__0(Object unused)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)

at System.Windows.Threading.DispatcherOperation.InvokeImpl()

at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)

at System.Threading.ExecutionContext.runTryCode(Object userData)

at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)

at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)

at System.Windows.Threading.DispatcherOperation.Invoke()

at System.Windows.Threading.Dispatcher.ProcessQueue()

at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)

at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)

at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)

at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)

at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)

at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)

at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)

at System.Windows.Threading.Dispatcher.Run()

at System.Windows.Application.RunInternal(Window window)

at System.Windows.Application.Run(Window window)

at System.Windows.Application.Run()

at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()

at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)

at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-17 19:24:32
I'm getting this error upon installing the v0.28.1.0 overtop of v0.28 in compatibility mode.

Thanks for reporting this. I'll make sure it's fixed for 0.28.2, although it will probably mean that you can't have de-queued windows opening behind other search windows in compatibility mode, I'm afraid.
Title: Album Art Downloader XUI
Post by: zim2411 on 2009-07-18 06:09:32
Got it solved! It wasn't a .Net error, but some other processes causing it to crash. I have a thing called amBX: http://www.ambx.com/ (http://www.ambx.com/) which annoyingly loads nearly 10 separate processes upon startup. I killed a bunch of them, and now Album Art Downloader works 

As for why the two things don't play nice... no clue. The only other application that doesn't work with amBX running is Media Player Classic Home Cinema. (Regular MPC works fine though.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-18 09:53:50
Album Art Downloader XUI v0.28.3 Released

This is a bug-fixing release. It should address the performance concerns raised since 0.28, as well as other reported minor issues.

Full list of changes since 0.28.1:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.28.3.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.28.3.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: Adagio on 2009-07-18 11:02:53
Installed 0.28.2 over 0.28.1 (as Admin) under Windows 7RC.
Previous versions were running fine.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\TOOLS\Sound\AlbumArtDownloader\errorlog.txt

App version: 0.28.2.0, running on Microsoft Windows NT 6.1.7100.0 (32 bit)

System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei AlbumArtDownloader.ArtSearchWindow.OnAutoDownloadFullSizeImagesChanged(Object sender, RoutedEventArgs e)
  bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  bei System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
  bei System.Windows.Controls.RadioButton.OnChecked(RoutedEventArgs e)
  bei System.Windows.Controls.Primitives.ToggleButton.OnIsCheckedChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
  bei System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  bei System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  bei System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  bei System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
  bei System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  bei System.Windows.Markup.BamlRecordReader.SetDependencyValueCore(DependencyObject dependencyObject, DependencyProperty dependencyProperty, Object value)
  bei System.Windows.Markup.BamlRecordReader.SetDependencyValue(DependencyObject dependencyObject, DependencyProperty dependencyProperty, Object value)
  bei System.Windows.Markup.BamlRecordReader.SetDependencyComplexProperty(Object currentTarget, BamlAttributeInfoRecord attribInfo, Object o)
  bei System.Windows.Markup.BamlRecordReader.SetPropertyValueToParent(Boolean fromStartTag, Boolean& isMarkupExtension)
  bei System.Windows.Markup.BamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
  bei System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  bei System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  bei System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  bei System.Windows.Markup.TreeBuilder.Parse()
  bei System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  bei System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  bei AlbumArtDownloader.ArtSearchWindow.InitializeComponent()
  bei AlbumArtDownloader.ArtSearchWindow..ctor()
  bei AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  bei System.Windows.Application.<.ctor>b__0(Object unused)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  bei System.Windows.Threading.Dispatcher.Run()
  bei System.Windows.Application.RunDispatcher(Object ignore)
  bei System.Windows.Application.RunInternal(Window window)
  bei System.Windows.Application.Run(Window window)
  bei System.Windows.Application.Run()
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-18 11:22:22
Installed 0.28.2 over 0.28.1 (as Admin) under Windows 7RC.
Previous versions were running fine.

Argh! How irritating. Someday I'll get this right first time.

Here's 0.28.3 which should fix it. I'm also editing the above release post to point to 0.28.3 too, no sense in pointing to the broken version.

AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.28.3.exe)

Alex
Title: Album Art Downloader XUI
Post by: Adagio on 2009-07-18 12:36:15
Cool, thank you.
Just for info, under Windows 7 I get the Program Compatibility Assistant popping up after installation (using Admin account) saying that Installation may not have been successful and if I want to re-run it using compatibility settings for this Windows version.
However it's running fine nonetheless.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-18 13:24:06
under Windows 7 I get the Program Compatibility Assistant popping up after installation
Thanks for the info. I'm planning to upgrade to Win7 once it's released to retail, so I'll look into it then. Or, if it provided any more specific details about exactly why it thought the installation may not have been successful, I could try figuring it out from that.

There's nothing I'm doing specifically to mark the application as compatible or not with Windows 7, and as far as I'm aware there shouldn't be any reason for it not to work 100% correctly without any special settings or compatibility layer.

Alex
Title: Album Art Downloader XUI
Post by: Adagio on 2009-07-18 15:57:25
As far as I can see the Program Compatibility Assitant does not provide any specifics as to why or what may have failed to install.
But I re-run installer without checking the "Add to Explorer context menu" option and the Compatibility Assistant did not pop up.
Edit: Just realized that in the previous install (where the Program Comp Assistant did appear) the Explorer context menu was apparently not properly installed, afaics.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-18 16:17:35
the Explorer context menu was apparently not properly installed, afaics.

Good to know. For information, checking this option in the installer just adds the registry key "HKEY_CLASSES_ROOT\Folder\shell\AlbumArtDownloader", which adds the Browse for Album Art command to the context menu for folders. I don't know whether Windows 7 just no longer allows commands to be added to folders like this any more, or if it is just that the installer isn't allowed to write to that part of the registry.

Alex
Title: Album Art Downloader XUI
Post by: Jester-NL on 2009-07-20 07:44:17
0.28.3 does work far better than 0.28.1, thank you
However, after my initial tests I started working seriously again this weeken (over 800 albums to check ), and I must say that if more than 20-25 albums are queued, the programs does tend to slow down.
To be more precise: I queued 59 albums, and experienced no problem there. I started working and everything went peachy-keen still. However after about 25 albums, the downloads became sluggish, the response was lagging, and even my browsing, foobar and IRC became less responsive.
Closing down Album Art Downloader and starting it again cured this.
For now, it is something I can live with (I managed to do over 200 albums in a lazy saterday afternoon), I just thought I might share it with you
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-20 07:57:58
after about 25 albums, the downloads became sluggish

Strange... according to my profiling software, once the window is closed it frees up all the resources it was using (with the exception of a few small formatted text strings). It does sound like something is leaking somewhere, though, according to your description. I'll poke around some more and see if I can spot it. To help me rule out one possibility, here's a version which does not cache formatted text strings. In general, this will be slightly slower as it has to continually recreate them - but, it will mean that there should be nothing at all left of a window after it closes. Could you let me know if it fixes the issue you're seeing?

AlbumArtDownloaderXUI-0.28.3-notextcache.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.28.3-notextcache.zip)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-07-20 15:01:32
Hi Alex,

I'm still getting an error in XP Pro SP2, .Net 3.5, Compatibility mode.
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.

If you wish to report this error, please include this information, which

has been written to the file: C:\Documents and Settings\WesterfD\AlbumArtDownloader\errorlog.txt



App version: 0.28.3.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2 (32 bit)



System.MissingMethodException: Method not found: 'Void System.Windows.Window.set_ShowActivated(Boolean)'.

at AlbumArtDownloader.SearchQueue.DequeueNextSearchWindow()

at AlbumArtDownloader.SearchQueue.set_SimulataneousWindowsAllowed(Int32 value)

at AlbumArtDownloader.SearchQueue..ctor()

at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)

at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)

at System.Windows.Application.<.ctor>b__0(Object unused)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)

at System.Windows.Threading.DispatcherOperation.InvokeImpl()

at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)

at System.Threading.ExecutionContext.runTryCode(Object userData)

at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)

at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)

at System.Windows.Threading.DispatcherOperation.Invoke()

at System.Windows.Threading.Dispatcher.ProcessQueue()

at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)

at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)

at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)

at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)

at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)

at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)

at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)

at System.Windows.Threading.Dispatcher.Run()

at System.Windows.Application.RunInternal(Window window)

at System.Windows.Application.Run(Window window)

at System.Windows.Application.Run()

at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()

at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)

at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-20 15:33:28
I'm still getting an error in XP Pro SP2, .Net 3.5, Compatibility mode.

Hmm... I'm not quite sure how that can be happening, the line of code in that error report should be skipped over if SP1 is not found. Does the message box warning about SP1 being missing show up?
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-07-20 18:10:53
The .Net box pops up and I press Compatibility mode and the program starts just as like any other update that I've done. At the point where I expect the main window to open, the error log pops up.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-20 18:45:45
At the point where I expect the main window to open, the error log pops up.

Oh, so not even dequeuing a queued search window, just starting up the app? OK, that gives me a clue. Could you try this one for me, please?

AlbumArtDownloaderXUI-0.28.4-preSP1experimental.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.28.4-preSP1experimental.zip)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-07-20 21:06:35
Hi Alex,

That one did the trick. It's working fine. Thank you.
Title: Album Art Downloader XUI
Post by: Kelani on 2009-07-21 02:52:48
Thanks for making this. I gotta say as far as time savers go, this is just Godly.  I have a few questions about some file naming problems. Few comments and suggestions, also. Currently, I have this setup:

Use File Path: \%artist%\(*) %album%\.
Specify Path: %artist% - %album% (%preset%).%extension%

Presets:
Default %type(Unknown,Front,Back,Inlay,CD)%
CD2  (CD2)
Tray  (Tray)
Booklet1-2  (Booklet 1-2)

etc..

This is the only way I could get it to keep %preset% available and let me save to %type% if needed. It's a clunky solution, in that you can't do the single-click save. So, Is it possible to use | to choose between %type(Unknown,Front,Back,Inlay,CD)% or %preset%? from the file browser?

To clarify, for the four main types (Front, Back, Inlay, CD) I want to save those with one click, but also have the the preset submenu available for Unknown & other variants. I just can't seem to get both working. With %type(Unknown,Front,Back,Inlay,CD)%.%extension%|%preset%.%extension% in file browser, the preset submenu arrow does not appear. Reverse it, and without manually clicking Default in presets, your get artist - album ().jpg

This leads me to bugs & suggestions.

1.  When using %preset%, one would expect the Default preset to be applied by default  It isn't. You still have to choose it from the preset menu, which is a bit tedious. (side note: If this were default behavior, my above problem would be history)

2.  The Preset menu doesn't exist in the Preview window, so to apply it, you have to close the preview, find the image (which for unknown size has usually been moved, depending on your sorting settings) and save it from there. Also tedious.

3.  The field in the Search/Downloader window that you made read-only. Can you make that optional? I realize it was done to lessen confusion, but that field being editable is actually really useful:

-The easiest way to test how settings from the file browser are applied. With it read-only, you have to either close the window, edit settings in the file browser, reopen and repeat the search, or open and work from an entirely new search window. 

-Say you're looking for art for album#1. During the search, art for album#2 (that didn't show up on album#2 search) appears. With this read-only, if you want to save it to the other album's folder, you have go through a clickfest to that path in each save dialog, not to mention manually rename the files. It's much easier to just temporarily substitute \%album% with \album2 in that field.

Third, I saw that someone asked for a feature to pick a default name for Unknown art. Expanding on that, I'd love to see the ability to also set a preferred name for the other types AAD maps elsewhere. Coveralia, for example shows some as Interior Frontal and Interior Trasera, which are both set to Inlay. There's a few more, (LP, Cover, ec) but you get my drift.

Fourth, a question about the actual naming choices. How come this maps the jewel box's back card (the folded one beneath the cd tray, with two side wings showing artist + title) as Back, and the booklet back (or the reverse of a 1-page tray card) as the Inlay?  I've designed several cd layouts, and every template and spec guide I've ever seen says inlay = the card stuck in the back of the jewel box (i.e. *inlaid* into the tray).  Am I wrong?  If so, out of curiosity, what names do you guys use for all the other miscellaneous art types?

I use the following, but am always open to ideas.

Cover = The Front and back of a booklet as a single image
Front = The front of the booklet or the outer package for multidisc or boxsets.
Back = The back of the booklet or outer package. Anything that's not an inlay
Front Inside = Page on the reverse of the Front
Back Inside =  Page on the reverse of the Back
Inlay = The back card under the cd tray
Tray = An inlay beneath a clear CD tray that's visible from the front.
Booklet 1-99 = Any pages between Front Inside and Back Inside

Lastly, and semi-off-topic, for those wanting to auto-convert/siize images and hate Imagemagic, check out Photoresize (http://www.rw-designer.com/photo-resizer-advanced). It's neat in that you renaming the exe will auto-configure the output (i.e. PhotoResizeF800ISNO.exe would be 800px max width, Inplace (overwrite file) Skip smaller, Sharpen, Autoclose console window) Of course you can also pass the same via command line to a plain Photoresize.exe and do the same thing. With a little work, I got it so that one batch file will processes each art type in a  folder the way I want (Cover=1600x1200 max, Front = 800x800 max Thumbnail=240x240 fixed, CD=640x640, etc.) Then I added a few shortcuts in SendTo for the most common tasks I do.

It's not as full-featured as ImageMagic, but is also free and works well. A less-nuclear solution, if you will.

Sorry for the novel, and thanks in advance if anyone can answer any of the above questions.

Kel
Title: Album Art Downloader XUI
Post by: GHammer on 2009-07-21 04:20:33
At the point where I expect the main window to open, the error log pops up.

Oh, so not even dequeuing a queued search window, just starting up the app? OK, that gives me a clue. Could you try this one for me, please?

AlbumArtDownloaderXUI-0.28.4-preSP1experimental.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.28.4-preSP1experimental.zip)

Thanks,

Alex



Fixed the problem for me as well.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-21 08:36:35
Thanks for making this. I gotta say as far as time savers go, this is just Godly.  I have a few questions about some file naming problems. Few comments and suggestions, also.

Thanks for your comments and suggestions, I'll try and give them all answers:

1.  When using %preset%, one would expect the Default preset to be applied by default

Yes, that was the intention. Looks like I screwed it up somewhere along the line, I'll fix that for 0.29.

For your setup, then, %preset%.%extension% in the file browser, and a default preset of %type% should do the trick.

2.  The Preset menu doesn't exist in the Preview window

Good suggestion. I'll probably stick that in 0.29 too. Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2824674&group_id=187008&atid=919578)

3.  The field in the Search/Downloader window that you made read-only. Can you make that optional?

Sorry, but I think that on balance it's better off as read-only. What I would suggest is just to kick off a new search window by tweaking the search terms (just add a space, or change letter capitalisation if they really are exactly right already). With "Open search results in new window" checked, that will open a new window that uses the default path pattern, but should have the same results.

Third, I saw that someone asked for a feature to pick a default name for Unknown art. Expanding on that, I'd love to see the ability to also set a preferred name for the other types AAD maps elsewhere

You can set the names of any of the types using the same method, just replace the name in the %type% placeholder. %type(Unknown,Front,Back,Inlay,Face)% would call CD "Face", for example.

As for the actual choice of types, what it comes down to is what is available from the sources. The majority have only the front cover, of course, but the other types AAD knows about reflect what was available from sources at the time. I don't know about the official terms, but I've always thought of Front and Back as referring to the front and back of the jewel case, and Inlay being the part inside. What I'd suggest is to rename "Inlay" as "Inside" for the next version (Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2824682&group_id=187008&atid=919578)), which is a more general term for anything that isn't on the outside, or printed onto the CD. I'd rather not add more types at this point, as sources can't be relied upon to be more specific than that.

Thanks also for the tip about Photoresize. I'm sure people here will find it handy. I have vague plans to eventually add some sort of image post-processing system (including resizing) to AAD, but it's certainly not going to happen soon.

Alex
Title: Album Art Downloader XUI
Post by: blackspawn on 2009-07-22 22:57:32
Hello, I just upgraded from 0.28.1 to 0.28.3 and I'm getting a consistent crash when I run AAD with "/fileBrowser" argument. It was working ok in 0.28.1, also if I run AAD normaly (without arguments) and then do Ctrl+B the browser opens up just fine. I tried with both the external hard drive connected and disconected (default browser path) but it didn't make a difference, it would always crash.

Heres the crash log (hope it helps):
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.28.3.0, running on Microsoft Windows NT 6.0.6002 Service Pack 2 (32 bit)

System.IndexOutOfRangeException: Index was outside the bounds of the array.
  at AlbumArtDownloader.App.PathFix(String pathParam)
  at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-23 07:42:48
I'm getting a consistent crash when I run AAD with "/fileBrowser" argument.

Oops, thanks for reporting that. I'll have it fixed for the next version. Until then, to work around this, add a path to the fileBrowser argument, like:  /fileBrowser "f:\music"

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-25 11:43:28
Album Art Downloader XUI v0.29 Released

Although this is mostly bug fixing, I've also added a couple of minor requested features. It may also have improved long-term memory usage (after opening and closing several search windows), but that's a bit theoretical at the moment.

Full list of changes since 0.28.3:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.29.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.29.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: blackspawn on 2009-07-27 10:55:09
  • Fixed crash when /fileBrowser argument is used without path parameter

Thanks for the quick fix!
Title: Album Art Downloader XUI
Post by: itisljar on 2009-07-30 21:47:19
I am sorry if this was answered before, but 35 pages are lot to read. How can I limit it's search to folder.jpg only files? Now it finds front.jpg and back.jpg, and I don't want that, I want to have front.jpg for album art.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-31 08:18:12
I am sorry if this was answered before, but 35 pages are lot to read. How can I limit it's search to folder.jpg only files? Now it finds front.jpg and back.jpg, and I don't want that, I want to have front.jpg for album art.


I don't quite understand. Do you mean that, when searching for a cover for an album, you only want to see results which have the type Front or Unknown? Or that when you are using the File Browser, you only want it to consider an album to have art already present if it is called exactly "folder.jpg"? Or that you always want to save results as exactly "folder.jpg"?

Alex
Title: Album Art Downloader XUI
Post by: itisljar on 2009-07-31 09:12:39
I am sorry... I see it is hard to see what I want from the way I wrote question  when I search in File Browser for albums which already has cover art, it searches directories, and marks them green if there is ANY coverart, be it front.jpg, folder.jpg, or nrg948hdidf8.jpg. I want it to search just for folder.jpg, and nothing else. But I haven't found any options for that.
Right now I have to manually enter these folders and rename and resize existing cover art, and it would be much easier for me to just download it from internet.
Title: Album Art Downloader XUI
Post by: SwiftDestiny101 on 2009-07-31 15:54:28
I signed up to these forums just to say THANKYOU! Between this and foo_discogs you get simply the best music library ever. This app makes even itunes art look low res.. so big love <3
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-07-31 17:54:10
when I search in File Browser for albums which already has cover art, it searches directories, and marks them green if there is ANY coverart, be it front.jpg, folder.jpg, or nrg948hdidf8.jpg. I want it to search just for folder.jpg, and nothing else.
In the File Browser window, click the Options link, then in the "Specify path to find images" box, put just:  folder.jpg

I signed up to these forums just to say THANKYOU!
Thanks, always nice to know when my work is appreciated!

Alex
Title: Album Art Downloader XUI
Post by: itisljar on 2009-07-31 22:55:10
Thank you, Alex! I would expect this as a button, or an option from the menus, not as a link... that's why I couldn't find it!
Title: Album Art Downloader XUI
Post by: ericursus on 2009-07-31 23:45:08
Hi, I am new here. I have been a light user of Foobar for several years now.
I am currently using version 0.9.5.2  with fooAvA 1.05.


I downloaded Net 3.5 framework, then Album Art Downloader, and Foo_run. 
The Album Art Downloader program and foo_run work fine. My Foobar works fine.
They just don't seem to have hooked up...

In other words, none of the covers that AAD has found & that i have added, are showing up when i run Foobar. For example, I have a Beethoven Piano Concerto that I was amazed AAD found the right cover for, since I never could. Here is what happens: I click on the image. AAD momentarily displays the message, "Downloading  image" or something like that. And then on to the next one. I did this for my very small library of music. Then I re-loaded Foobar. Voila! Nothing was any different. All the covers that were missing before, are still missing. Maybe there is some obvious mistake or oversight i have made, or maybe an incompatibility? I'm wise enough to admit i really need some help.
Any suggestions/ advice/ from anyone, would be much appreciated!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-01 07:48:37
none of the covers that AAD has found & that i have added, are showing up when i run Foobar.
Could you check to see if the art has been correctly saved in a .jpg file in the album folder? If it hasn't, then there is some problem with your use or configuration of AAD that I will try to get to the bottom of with you.

If the .jpg file is in the album folder, then AAD has done its job correctly, and Foobar isn't displaying the artwork for some reason. In that case, could you check where it configured to look for artwork files?

Alex
Title: Album Art Downloader XUI
Post by: itisljar on 2009-08-01 22:47:45
Well, here I come again - is there a possibility to sort results as I would like by sites - and to have an optional "stop loading" button like browsers have? I'd like to set three sites to see results from them first. For instance, right now it is sorted alphabetically, so Album Art Exchange comes first. I'd like to sort results from three sites first, Album Art Exchange, Discogs and CD Universe, and then the rest - and then, if results are found on two of the three sites, to stop downloading the rest and conserve bandwidth, or to just hit ESC and stop searching.
I think it would be neat 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-02 08:12:46

Sources are searched simultaneously, there is no order. You can have the results sorted by source (site), but only alphabetically, I'm afraid.

If you want to try certain sources first, then others only if they don't have the results you want, then I'd suggest searching with just the best sources first, and the others unchecked. If that doesn't produce the results you want, check some additional sources, and hit Search again. If you haven't changed the album or artist name, the already checked sources won't be searched again, and the results from the newly checked sources will be added to existing the results list.

Each source has a Stop link in the bottom right corner, next to the progress bar, while it is working. There is a Stop All link which appears at the top right corner of the sources list during a search. Pressing Escape should have the same effect.

Alex
Title: Album Art Downloader XUI
Post by: ericursus on 2009-08-05 05:44:27
got it figured out. file path error. 


Hi, I am new here. I have been a light user of Foobar for several years now.
I am currently using version 0.9.5.2  with fooAvA 1.05.


I downloaded Net 3.5 framework, then Album Art Downloader, and Foo_run. 
The Album Art Downloader program and foo_run work fine. My Foobar works fine.
They just don't seem to have hooked up...

In other words, none of the covers that AAD has found & that i have added, are showing up when i run Foobar. For example, I have a Beethoven Piano Concerto that I was amazed AAD found the right cover for, since I never could. Here is what happens: I click on the image. AAD momentarily displays the message, "Downloading  image" or something like that. And then on to the next one. I did this for my very small library of music. Then I re-loaded Foobar. Voila! Nothing was any different. All the covers that were missing before, are still missing. Maybe there is some obvious mistake or oversight i have made, or maybe an incompatibility? I'm wise enough to admit i really need some help.
Any suggestions/ advice/ from anyone, would be much appreciated!

Title: Album Art Downloader XUI
Post by: bsleeth on 2009-08-06 17:28:26
...I click on the image. AAD momentarily displays the message, "Downloading  image"...

Did you click on the Image, as-in the cover thumbnail, or the "floppy-disk" save icon?
Title: Album Art Downloader XUI
Post by: Mar2zz on 2009-08-06 21:59:15
I have my music organized like this:
parent:
artist/album/tracks+folder.jpg
artist/album/tracks+folder.jpg

Can I make AAD to search in the artistfolder for a folder.jpg, and if not there, search for it? It seems it only wants to show results from folders with an audiofile inside, but my artistfolders only has subfolders (albums), the tracks are inside those subfolders.

(for the record, I want to save my artistpictures inside the artistfolder, and search and save them with this string: /ar "%album artist%" /al "%album%" /mn 300 /mx 1000 /path "Q:\Music\%album artist%\folder.jpg")

The endresult I need
parent:
artist/album+folder.jpg/tracks+folder.jpg
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-07 08:28:28

Yes, you can do this. You have two options, you can either continue to use tag matching (so it matches audio files), but have the path to search for art as: ..\folder.jpg

Or, you can use path pattern matching to ignore audio files altogether, and work on the folder names. In your case, the path pattern would be: Q:\Music\%artist%\. (note the . at the end, instructing it to look at the folder rather than a file). The path to search art for would just stay as folder.jpg, in this case. It would run a lot faster, as it wouldn't have to search through all the albums and tracks, and would mean that if you started a search from file browser, the Album field would be blank (only the Artist field would be populated).

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: Mar2zz on 2009-08-07 09:12:15
Thank you for reacting that fast. It helps, your 2nd tip, %artist%\. works!

I did some testing myself last night (with Q:\Music\%artist%\, and managed to get it to scan my folders for missing folder.jpg's in the artistfolders. But it got as many results as there were subfolders in the artistsfolders. (if it didn't find a folder.jpg, it didn't found it 4 times if there were 4 subfolders. And a problem, it found also no folder.jpg's in artistfolders with swapped prefixed names, and some compilationfolders and genrefolders. (e.g.: a folder called Trance compilations and a folder called soundtracks). Inside those 'different' folders I have a different substructure, it has subfolders called %artist% - %year% - %album%.

I don't know how to use your first tip. the ../folder.jpg. It searches all artists (ignores %album artist%, it seems), so it has too many results.

But thx anyway, got a good solution here.
Title: Album Art Downloader XUI
Post by: sylla on 2009-08-08 20:40:38
First, thanks a lot for the program, I really appreciate it, and it has worked perfectly for me until today

But now, when I try to run the program it doesn't start, and I get this message

Code: [Select]
App version: 0.29.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.ArgumentOutOfRangeException: Parametervärdet måste vara mellan '0' och '3579139,40666667'.
Parameternamn: paragraphWidth
  vid MS.Internal.TextFormatting.TextFormatterImp.VerifyTextFormattingArguments(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextRunCache textRunCache)
  vid MS.Internal.TextFormatting.TextFormatterImp.PrepareFormatSettings(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache, Boolean useOptimalBreak, Boolean isSingleLineFormatting)
  vid MS.Internal.TextFormatting.TextFormatterImp.FormatLineInternal(TextSource textSource, Int32 firstCharIndex, Int32 lineLength, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache)
  vid MS.Internal.TextFormatting.TextFormatterImp.FormatLine(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache)
  vid System.Windows.Controls.TextBlock.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Control.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Grid.MeasureCell(Int32 cell, Boolean forceInfinityV)
  vid System.Windows.Controls.Grid.MeasureCellsGroup(Int32 cellsHead, Size referenceSize, Boolean ignoreDesiredSizeU, Boolean forceInfinityV)
  vid System.Windows.Controls.Grid.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Border.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid MS.Internal.Helper.MeasureElementWithSingleChild(UIElement element, Size constraint)
  vid System.Windows.Controls.ContentPresenter.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Decorator.MeasureOverride(Size constraint)
  vid System.Windows.Documents.AdornerDecorator.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Border.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Window.MeasureOverrideHelper(Size constraint)
  vid System.Windows.Window.MeasureOverride(Size availableSize)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Interop.HwndSource.SetLayoutSize()
  vid System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
  vid System.Windows.Interop.HwndSource.set_RootVisual(Visual value)
  vid System.Windows.Window.SetRootVisual()
  vid System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
  vid System.Windows.Window.CreateSourceWindowImpl()
  vid System.Windows.Window.SafeCreateWindow()
  vid System.Windows.Window.ShowHelper(Object booleanBox)
  vid System.Windows.Window.Show()
  vid System.Windows.Window.ShowDialog()
  vid AlbumArtDownloader.Splashscreen.ShowIfRequired()
  vid AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  vid System.Windows.Application.<.ctor>b__0(Object unused)
  vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.DispatcherOperation.InvokeImpl()
  vid System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  vid System.Threading.ExecutionContext.runTryCode(Object userData)
  vid System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  vid System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  vid System.Windows.Threading.DispatcherOperation.Invoke()
  vid System.Windows.Threading.Dispatcher.ProcessQueue()
  vid System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  vid MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  vid MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  vid MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  vid MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  vid System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  vid System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  vid System.Windows.Threading.Dispatcher.Run()
  vid System.Windows.Application.RunDispatcher(Object ignore)
  vid System.Windows.Application.RunInternal(Window window)
  vid System.Windows.Application.Run(Window window)
  vid System.Windows.Application.Run()
  vid AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  vid AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  vid AlbumArtDownloader.App.Main(String[] args)

First time I got this, I was trying to run the program using a foo_run command to search for an image for aa album which I think I had moved the folder for. It was in an old playlist in foobar, and so the "link" in foobar was pointing to a folder that didn't exist anymore. As the foo_run script involved commands for saving the image to the folder that the files lay in, I'm thinking that can have something to do with it.

I have tried reinstalling the program but that didn't help. Oh and sorry for the bad grammar, my english is very limited, hope you understand
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-09 07:47:54
But now, when I try to run the program it doesn't start, and I get this message

That's strange, it is an error occurring when it is trying to show the splash screen. Unless you've added or removed scripts, it shouldn't have been trying to show that screen anyway.

One thing you can try is to delete the folder C:\Documents and Settings\<user name>\Local Settings\Application Data\AlbumArtDownloader
. This will reset all the album art downloader settings, and force it to recompile the scripts.

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: pedr0 on 2009-08-09 10:38:11
Hello all,

I've got the hang of this as a stand alone application, but I'm just starting to use foobar.  How should I integrate this with foobar?  Do I need to copy any dll files into my components folder?  I think I probably installed AlbumArtDownloader before foobar.  Should I uninstall and reinstall AlbumArtDownloader?

Sorry about asking such an elementary question.

Cheers
Title: Album Art Downloader XUI
Post by: sylla on 2009-08-09 15:32:57
That's strange, it is an error occurring when it is trying to show the splash screen. Unless you've added or removed scripts, it shouldn't have been trying to show that screen anyway.

One thing you can try is to delete the folder C:\Documents and Settings\<user name>\Local Settings\Application Data\AlbumArtDownloader
. This will reset all the album art downloader settings, and force it to recompile the scripts.

I hope this helps,

Alex


Great, that solved it, even though the folder was empty. Thanks!
Title: Album Art Downloader XUI
Post by: antman on 2009-08-09 15:59:02
pedr0:

1. You're going to have to download Foobar COM Automation Server (http://www.hydrogenaudio.org/forums/index.php?showtopic=39946)
2. Open foobar and go to Library > Configure.  Tell foobar where your music is.
3. Open AAD and select File > New > Foobar Browser.

Or at least something similar.  I never use it with foobar.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-09 17:19:00
How should I integrate this with foobar?

You're going to have to download Foobar COM Automation Server (http://www.hydrogenaudio.org/forums/index.php?showtopic=39946)[...]

That's certainly one option, and will allow you to browse your Foobar library from Album Art Downloader. The other way people use the two tools together is to use [a href='index.php?showtopic=45223']foo_run[/a] to add a command to the context menu for a track called "Find Cover Art..." or similar, which then runs Album Art Downloader to find the cover art for that track. There is some discussion about the best command line to use for this, but I'd just go with: "C:\Program Files\Album Art Downloader\AlbumArt.exe" /ar "%artist%" /al "%album%" /path "$replace(%_path%,%_filename_ext%,)folder.%%extension%%"

Someone has written some more detailed instructions here: Foobar2000 Manual - Covers (http://eolindel.free.fr/foobar0.9/covers.php).

Alex
Title: Album Art Downloader XUI
Post by: pedr0 on 2009-08-09 18:08:34
Thanks very much Alex and antman
Title: Album Art Downloader XUI
Post by: Chris Norman on 2009-08-09 23:17:02
Hello Alex,
 
  It's good to see that your tool get's better and better.
 
  I am using here v. 0.29 and I observed that the program is still  crashing when I try to edit the presets in the foobar mode: I can have  there up to 7 presets but when I try to add the 8th the program crashes  every time.
 
I had the same issue on a German XP Sp 3 System and now also on my new German Vista SP 1 machine.

 
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
  If you wish to report this error, please include this information, which
  has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt
 
  App version: 0.29.0.0, running on Microsoft Windows NT 6.0.6001 Service Pack 1 (32 bit)
 
  System.ArgumentNullException: Der Wert darf nicht NULL sein.
  Parametername: element
    bei MS.Internal.Media.VisualTreeUtils.AsNonNullVisual(DependencyObject element, Visual& visual, Visual3D& visual3D)
    bei System.Windows.Media.VisualTreeHelper.GetChildrenCount(DependencyObject reference)
    bei AlbumArtDownloader.Common.FindVisualChild[TChild](DependencyObject obj)
    bei AlbumArtDownloader.EditPresets.OnNewItemContainerGenerated(Object sender, EventArgs e)
    bei System.EventHandler.Invoke(Object sender, EventArgs e)
    bei System.Windows.Controls.ItemContainerGenerator.SetStatus(GeneratorStatus value)
    bei System.Windows.Controls.ItemContainerGenerator.Generator.System.IDisposable.Dispose()
    bei System.Windows.Controls.VirtualizingStackPanel.MeasureOverride(Size constraint)
    bei System.Windows.FrameworkElement.MeasureCore(Size availableSize)
    bei System.Windows.UIElement.Measure(Size availableSize)
    bei System.Windows.ContextLayoutManager.UpdateLayout()
    bei System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
    bei System.Windows.Media.MediaContext.InvokeOnRenderCallback.DoWork()
    bei System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
    bei System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
    bei System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
    bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object  source, Delegate callback, Object args, Boolean isSingleParameter,  Delegate catchHandler)
    bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate  callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
    bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
    bei System.Threading.ExecutionContext.runTryCode(Object userData)
    bei  System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode  code, CleanupCode backoutCode, Object userData)
    bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
    bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
    bei System.Windows.Threading.DispatcherOperation.Invoke()
    bei System.Windows.Threading.Dispatcher.ProcessQueue()
    bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd,  Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
    bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object  source, Delegate callback, Object args, Boolean isSingleParameter,  Delegate catchHandler)
    bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate  callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bei  System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority  priority, TimeSpan timeout, Delegate method, Object args, Boolean  isSingleParameter)
    bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
    bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
    bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
    bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
    bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
    bei System.Windows.Window.ShowHelper(Object booleanBox)
    bei System.Windows.Window.Show()
    bei System.Windows.Window.ShowDialog()
    bei AlbumArtDownloader.ArtSearchWindow.OnEditPresets(Object sender, RoutedEventArgs e)
    bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
    bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
    bei System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
    bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
    bei System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
    bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object  source, Delegate callback, Object args, Boolean isSingleParameter,  Delegate catchHandler)
    bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate  callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
    bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
    bei System.Threading.ExecutionContext.runTryCode(Object userData)
    bei  System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode  code, CleanupCode backoutCode, Object userData)
    bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
    bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
    bei System.Windows.Threading.DispatcherOperation.Invoke()
    bei System.Windows.Threading.Dispatcher.ProcessQueue()
    bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd,  Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
    bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object  source, Delegate callback, Object args, Boolean isSingleParameter,  Delegate catchHandler)
    bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate  callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bei  System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority  priority, TimeSpan timeout, Delegate method, Object args, Boolean  isSingleParameter)
    bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
    bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
    bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
    bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
    bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
    bei System.Windows.Threading.Dispatcher.Run()
    bei System.Windows.Application.RunDispatcher(Object ignore)
    bei System.Windows.Application.RunInternal(Window window)
    bei System.Windows.Application.Run(Window window)
    bei System.Windows.Application.Run()
    bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
    bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
    bei AlbumArtDownloader.App.Main(String[] args)
 
 
Additionally I have a feature request:

Is it possible to include a coverart renaming mode. Right now you can see already the local art but if you save you'll have both old and new. Thus a rename function would be very nice.

Cheeers and keep on the good work,

Chris
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-10 07:48:52
I am using here v. 0.29 and I observed that the program is still  crashing when I try to edit the presets in the foobar mode
Thanks for reporting this bug. I haven't been able to reproduce it, though - could you give me exact steps of what you do to make it happen?

Is it possible to include a coverart renaming mode. Right now you can see already the local art but if you save you'll have both old and new. Thus a rename function would be very nice.
Do you mean in the File/Foobar browsers, where it shows the existing art as a link, you should be able to rename that? I could probably put an option on the right click menu to do that.

Alex
Title: Album Art Downloader XUI
Post by: Chris Norman on 2009-08-10 23:33:32
Quote
I haven't been able to reproduce it, though - could you give me exact steps of what you do to make it happen?


It's weird because I couldn't reproduce it either today. I just added some presets and it worked. It might be that got confused by a leading space before e.g. " - disc". If it occurs again I'll let you know.

Quote
Do you mean in the File/Foobar browsers, where it shows the existing art as a link, you should be able to rename that? I could probably put an option on the right click menu to do that.

Exactly. A plus would be a highlighting function - showing image files not matching the presets

-Chris


Title: Album Art Downloader XUI
Post by: smcforum on 2009-08-20 15:36:35
Unfortunately Amazon is not working anymore. It seems that they have changed the API. I have an other Image Grabbing Tool that is not working too.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-20 16:02:36
Unfortunately Amazon is not working anymore. It seems that they have changed the API. I have an other Image Grabbing Tool that is not working too.

Yes, it looks like they are now requiring all requests to be signed and authenticated: ref (http://developer.amazonwebservices.com/connect/ann.jspa?annID=476).

That's just not going to happen. So, it looks like Amazon is off the menu now. :-(
Title: Album Art Downloader XUI
Post by: music collector on 2009-08-21 06:58:20
great software! but...
i have my songs's file name in this format
"Metallica - One"
how could i go about using this software for it to automatically search for the correct album?
help!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-21 07:42:30
i have my songs's file name in this format
"Metallica - One"

Firstly, if you have the files properly tagged, you can just use that and ignore the file name. However, if you can't or don't want to just use the ID3 tags, you can still do it using a file path pattern of \%artist% - %album%.%extension%

Alex

Title: Album Art Downloader XUI
Post by: smcforum on 2009-08-21 15:41:14
Yes, it looks like they are now requiring all requests to be signed and authenticated: ref (http://developer.amazonwebservices.com/connect/ann.jspa?annID=476).

That's just not going to happen. So, it looks like Amazon is off the menu now. :-(


Amazon provides the most valuable and accurate images. In 90 % of al cases, Amazon has the best an the correct album cover.

Killing Amazon from your great tool would be very sad. I think implementing the signed request is not too hard and it is also notcombined with costs.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-21 15:53:50
I think implementing the signed request is not too hard
I'd love to hear your thoughts on how this might be implemented in a script, as I don't have any good ideas at the moment.

Alex
Title: Album Art Downloader XUI
Post by: smcforum on 2009-08-21 17:08:07
I think your application is written in .NET?

Here are two examples:

Product Advertising API Signed Requests Sample Code - C# REST/QUERY
http://developer.amazonwebservices.com/con...p;categoryID=14 (http://developer.amazonwebservices.com/connect/entry.jspa?externalID=2480&categoryID=14)

Product Advertising API Signed Requests Sample Code - C# SOAP
http://developer.amazonwebservices.com/con...p;categoryID=14 (http://developer.amazonwebservices.com/connect/entry.jspa?externalID=2481&categoryID=14)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-21 17:26:48
Yes, it's not so much the code itself (although it would certainly be a monumental pain to translate all of that into boo for the script file), as the fact that the code requires these variables to be set:

        private const string MY_AWS_ACCESS_KEY_ID = "YOUR_AWS_ACCESS_KEY_ID";
        private const string MY_AWS_SECRET_KEY    = "YOUR_AWS_SECRET_KEY";

This is obviously the intention of Amazon, deliberately to prevent public access to their API. I suppose there's always falling back to screen scraping, but I'm going to wait a bit and see how this develops, and what other tools do, first. Of course, this is an open tool, if anyone else fancies either writing a screen scraping amazon script, or can figure out a way to do an API-accessing script (which doesn't require me to have or publish an AWS Secret Key), I'll be more than happy to stick them up on the project site.

Alex
Title: Album Art Downloader XUI
Post by: music collector on 2009-08-21 17:31:48
i have my songs's file name in this format
"Metallica - One"

Firstly, if you have the files properly tagged, you can just use that and ignore the file name. However, if you can't or don't want to just use the ID3 tags, you can still do it using a file path pattern of \%artist% - %album%.%extension%

Alex



So my format is ok?
i used a ID# tag software that allowed me to use the file name as and id3 tag...
so "metallica - one" comes out as "artist - title"
can i still use the
Title: Album Art Downloader XUI
Post by: music collector on 2009-08-21 17:33:04
and also what and hows does the foobar option work?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-21 19:25:52
and also what and hows does the foobar option work?
If your collection is in the Foobar2000 Media Library, then you can install the Foobar COM Automation Server (http://www.hydrogenaudio.org/forums/index.php?showtopic=39946) (there's also a link to this from the Foobar Browser in Album Art Downloader if you don't have it installed yet.) Once you've done that, the Foobar Browser will list all your album art from the Foobar Media Library, rather than trying to read the album and artist information from the file itself.

For your other question, if you used tagging software to automatically name the file based on the tags, then there is absolutely no need to use a file path pattern, just leave the File Browser set to use ID3 tags and it will pick up the album and artist information directly from them.

Alex
Title: Album Art Downloader XUI
Post by: music collector on 2009-08-21 20:14:12
ncie!
so then my album art will be picked up by itunes automatically?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-22 07:40:13
so then my album art will be picked up by itunes automatically?

I don't use iTunes, I'm afraid, so I can't help you there. You might want to look at [a href='index.php?showtopic=51708']iTSfv[/a] though, which should be manage this sort of thing.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-22 10:31:08
Testing Amazon Scraper Script

I've decided to write a scraper script to search Amazon without using the API, which they broke. If you'd like to help me test it, please download: amazon-common.boo (http://www.byalexv.co.uk/foobar/amazon-common.boo) and stick it in your scripts folder. Ignore any offers to update the amazon scripts, as I'm not publishing this through the auto-updater system until it's had some more testing.

It should work make all of the Amazon scripts work again, with the exception of the mp3 search. That one will now just return identical results to the Amazon US (.com) script, so it's harmless, but might as well be removed or disabled.

Known Limitations:

If you find any problems with the script, please let me know which Amazon source (.co.uk, .com, .ca, .de, .fr, .jp) you searched, and the artist and album searched for.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-08-23 23:14:33
It's working wonders for me, mate!!! 
Thank you so much. I missed Amazon covers...
(even Amazon MP3 is working well, it seams... --> nevermind, I get it now = same results as regular Amazon.com as you said below)

Since there isn't the size of the covers anymore, is there any way that I can instruct the program to pre-download the covers from Amazon (and only Amazon)?
(I know how to turn it on in the "options..." - "automaticaly download full size images", but I don't want it to do so for the other sites since I have a pretty slow connection)

Testing Amazon Scraper Script

I've decided to write a scraper script to search Amazon without using the API, which they broke. If you'd like to help me test it, please download: amazon-common.boo (http://www.byalexv.co.uk/foobar/amazon-common.boo) and stick it in your scripts folder. Ignore any offers to update the amazon scripts, as I'm not publishing this through the auto-updater system until it's had some more testing.

It should work make all of the Amazon scripts work again, with the exception of the mp3 search. That one will now just return identical results to the Amazon US (.com) script, so it's harmless, but might as well be removed or disabled.

Known Limitations:
  • Image dimensions are no longer available without downloading the full size image, as Amazon doesn't provide that info on the website.
  • Only one image per album result is found (multiple results are found, though)
  • .jp search doesn't show Japanese characters in results (I think - maybe it does on a Japanese OS, but I doubt it)

If you find any problems with the script, please let me know which Amazon source (.co.uk, .com, .ca, .de, .fr, .jp) you searched, and the artist and album searched for.

Alex
Title: Album Art Downloader XUI
Post by: RyanThaDude29 on 2009-08-24 00:43:15
...
Since there isn't the size of the covers anymore, is there any way that I can instruct the program to pre-download the covers from Amazon (and only Amazon)?
(I know how to turn it on in the "options..." - "automaticaly download full size images", but I don't want it to do so for the other sites since I have a pretty slow connection)

Just have it download only unknown sizes, not all.
Title: Album Art Downloader XUI
Post by: electricprophet on 2009-08-29 16:02:10
i installed the program, in windows 7, but it does not run, not even in compatibility mode with xp
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-29 16:51:46
i installed the program, in windows 7, but it does not run, not even in compatibility mode with xp

I wouldn't recommend xp compatibility mode for this app. It should work fine normally - does it give you any error message?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-08-30 09:41:24
Script Update
As no one has reported any problems with the Amazon Scraper script, I've now pushed that out through the automatic updates system. All your installed Amazon scripts should now report a new version available, which is 0.1s (s for "scraper"). The Amazon MP3 script has been removed, so feel free to remove that from your Scripts folder too, or just leave it in there and ignore it.

I've also added a newly requested script, for YesAsia (http://www.yesasia.com), which is useful if you are trying to find covers for Japanese, Chinese or Korean albums. It should be available from your Get More Scripts link, or you can download it directly here: yesasia.boo (http://album-art.sourceforge.net/scripts/yesasia.boo)

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-06 10:31:32
Album Art Downloader XUI v0.30 Released

This release adds a couple of requested features, and brings scripts up to date. In the File and Foobar browsers, when an existing image file is located, a link to that image appears in the results. I've now added a context (right click) menu to that link to allow you to perform some handy operations to the existing image file. Currently you can Open in Explorer (same as clicking the link), Preview (opens the image in the preview window), Rename or Delete the file.

The other requested feature added to this release is the ability to define primary search sources. To do this, click the ... in the bottom right of any search source to show the options for that source. There is now an additional "Search first" option that can be checked. If you check this, then that source will be searched first, and other searches only searched if that one returns no results. You can mark multiple sources as "Search first", in which case all of those will be searched first, and only if none of them returns a result that passes your filters will the other selected sources be searched.

If they do return results, but you still want to search the other selected sources anyway, just hit the Search button again (without changing artist or album), and the other sources will be searched.

If you don't want to use the functionality, then just don't have any sources marked as "Search first", and all sources will be searched at the same time, just as it previously did.

There are two new scripts included in this release: MusicMight (http://musicmight.com) (rock music) and YesAsia (http://yesasia.com) (Japanese, Chinese, Korean music). To make things easier, the installer now groups scripts by rough genre, so you can have a better idea of which ones you might want to install.

Other minor changes:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.30.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.30.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: Scidd0w on 2009-09-06 20:39:55
Thank you very much for the new version. I really like the "Search first" option. Saves alot of waiting and searching for albumart exchange
Title: Album Art Downloader XUI
Post by: tuxman on 2009-09-07 02:23:27
Something's still wrong. When enqueuing a bunch of searches (90 for me), the Queue Manager goes weird...

I tried to activate it, but my screen started to flicker, and I couldn't do anything. I had to click the X of the (hanging) Queue Manager. Then all worked fine again.



(There were two Queue Managers open. How was that possible?)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-07 07:56:38
Something's still wrong.
When you say still wrong, do you mean that you've seen this Queue Manager problem on previous versions too? Or just that things are still going wrong in general?

Inspecting the WPF Window code, the only way I can see that two Queue manager windows could be open at the same time is if the first one stopped receiving, or being able to process, windows messages. Then, when WPF closed the window, it would send the Closed event (informing the AAD that the queue manager window was closed), but then the WM_CLOSE message it sends would not be processed.

As to how it got in to such a state, I have no idea! Is it reproducible, or was it a one-off?

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-07 10:43:14
I like the "Search first", great new feature. Is there a cmd line switch to put this on/off? Again thinking from the REACT dev POV; the local source, if wanted by user (i.e. REACT would include this source), should always search when AAD is started (it's obvious that the local files should have the highest priority), and it's not if there's 1-n sources with "search first" on. I don't know if this needs a cmd line switch. Suggestion: if the local source is on, make it always "search first" (hidden from the user.. or greyed out) AND if it's the only one with "search first", ignore it..? This way it wouldn't interfere with the "search first" feature and local files would always be highest priority. Thanks for the update btw!
Title: Album Art Downloader XUI
Post by: tuxman on 2009-09-08 00:01:36
As to how it got in to such a state, I have no idea! Is it reproducible, or was it a one-off?

I couldn't reproduce it yet. 

On my machine (2 GHz, 3 GB RAM, Vista 32 bit) the AAD is a bit sluggish anyway, this may be due to the whole WPF thingy... so I could guess the Queue Manager was just hanging for a second.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-08 08:16:17
Is there a cmd line switch to put this on/off?
No, but there probably should be. I don't want to make Local Files always search first, but a command line parameter of /sourcesFirst or /sF to go with the existing /sources parameter would be a good idea. You could then do something like /sourcesFirst "Local Files" /sources "GoogleImage".

On my machine (2 GHz, 3 GB RAM, Vista 32 bit) the AAD is a bit sluggish anyway
Aw, don't tell me we've got perf problems again, I spent ages fixing that only a couple of releases ago! If this is a recent problem, do you happen to know the last release in which it was performing OK for you?

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2009-09-08 09:01:39
WPF applications are generally performing bad for me. Dunno why.

The AAD has a very awful performance when switching between its windows (I think it's the actual drawing process), else it's OK...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-08 09:12:39
WPF applications are generally performing bad for me. Dunno why.
It's probably worth checking your graphics card drivers are up to date. Keeping DirectX (http://www.microsoft.com/downloads/details.aspx?FamilyID=2da43d38-db71-4c1b-bc6a-9b6652cd92a3) up to date doesn't hurt either.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2009-09-08 09:17:34
My DirectX is quite recent (v10), the drivers should also be (recently updated via Windows Update).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-08 09:27:54
(recently updated via Windows Update).
That generally gives me (possibly baseless) cause for suspicion. I never trust Microsoft to get third party graphics drivers right through Windows Update. I'm afraid I'm out of other ideas, though. Your spec should be easily high enough to run AAD without any performance problems (unless using some ancient and horrible graphics card, I suppose, but it doesn't seem likely).
Title: Album Art Downloader XUI
Post by: tuxman on 2009-09-08 09:37:49
Well, a nVidia driver update wrecked my Windows XP installation, so I don't really want to try official drivers on Vista at all... Flyff (a 3D MMORPG) doesn't have any performance problems either, so I think it's WPF that causes the problems. Another C# application I use (Nomad.NET) has similar problems. (However, switching its windows doesn't make them white for a short second.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-08 09:45:43
Another C# application I use (Nomad.NET) has similar problems.
Now that's interesting - Nomad.NET isn't a WPF application, which suggests the problem might be with .net in general, rather than WPF (or as well as WPF, I suppose).
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-08 13:08:17
Hi, Alex,
is it possible to develop a "CDBaby" (http://www.cdbaby.com/) Scraper Script in the same manner that you did with Amazon?

Thanks! I'm loving the new version. Some very good improvements!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-08 15:04:32
is it possible to develop a "CDBaby" (http://www.cdbaby.com/) Scraper Script in the same manner that you did with Amazon?
Hi audio20, thanks for your comments. Yes, it wouldn't be hard to write a CDBaby script, but I've been looking at the site (and wow, it's a slow one), and there doesn't seem to be any way to search for both artist and album together. For example, try searching for Steve Dawson: Telescope. I can search for Telescope (http://www.cdbaby.com/Search/VGVsZXNjb3Bl), or I can search for Steve Dawson (http://www.cdbaby.com/Search/U3RldmUgRGF3c29u), but not Telescope by Steve Dawson. If you can figure out any way to do a search for an album by an artist, then let me know.
Title: Album Art Downloader XUI
Post by: tuxman on 2009-09-08 16:36:46
Now that's interesting - Nomad.NET isn't a WPF application, which suggests the problem might be with .net in general, rather than WPF (or as well as WPF, I suppose).

Might be, never checked its source code... but why does .net act like that?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-08 16:47:34
Might be, never checked its source code... but why does .net act like that?
I'm sorry, I have no idea. I've never seen that issue on any of the PC's I've used .net applications on, and I haven't got any clues to go on either!
Title: Album Art Downloader XUI
Post by: tuxman on 2009-09-08 16:57:34
OK, thank you anyway..
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-08 23:51:46
[font= \"Verdana\"]
...it wouldn't be hard to write a CDBaby script...doesn't seem to be any way to search for both artist and album together...If you can figure out any way to do a search for an album by an artist, then let me know.
Hi, Alex,
can't thank you enough for you very quick response. You're absolutely right about CDBaby search capabilities, indeed.

What made me want to have them in the search capabilities in the program is the fact that they are indeed one of the biggest distributors of indie music (if not the biggest). There are a whole lot of artists that only have their CD for sale at CDBaby, so for some artists the only place you'll probably get a cover (and not a great one, only 200px in size) is there, unfortunately.

Exactly because the site is normally so slow (as you correctly stated), searching for a good number of these indie artists albums with your program would probably save me (and other indie music lovers like me) a whole lot of time! I though of an alternative for the search problem, but please tell me if it is too complicated or difficult to implement and I'll just forget about it.

I was thinking something in these lines:

[A] Launch two simultaneous searches, 1 for the album, 1 for the artist and then concatenate the results (album first, artist second), presenting the first n results.
If the above is not possible then just search for the artist, as it will probably get all the artist's albums right in the first results (indie artists normally don't have that many albums).

It seams to me the image results presented by the search pages are the same as the "bigger" ones, with just the "_small.jpg" suffix. e.g.
tripleavemusic_small.jpg (http://www.cdbaby.com/Images/Album/tripleavemusic_small.jpg)  -->  tripleavemusic.jpg (http://www.cdbaby.com/Images/Album/tripleavemusic.jpg)

Maybe you could put out here in the forum a "beta" script as you did with the Amazon Scraper at first. I would be very grateful!

In advance, thank you so much for your time!
[/font]
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-09 08:28:01
Maybe you could put out here in the forum a "beta" script as you did with the Amazon Scraper at first. I would be very grateful!

Yeah, I appreciate that CDBaby has covers no other site will have, otherwise they wouldn't be worth the hassle. The problem with combining the searches like you suggest is that you would end up with not only every album of that name by any artist, but every album the named artist had produced! The one you wanted would probably be buried in there somewhere, but there'd be a whole lot of junk too.

The best I've come up with so far is to search by album title, then look through the results and discard those whose artist is not the one requested. This does mean that for a very common album title you might not be able to find any results, in which case I'd suggest searching by just Artist or just Album (whichever one looks more uncommon), then manually looking at the results for the one you want.

Let me know how you get on with it: cdbaby.boo (http://www.byalexv.co.uk/foobar/cdbaby.boo)

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-09 11:32:43
...CDBaby has covers no other site will have, otherwise they wouldn't be worth the hassle...
Indeed!

Quote
The problem...end up with not only every album of that name by any artist, but every album the named artist had produced...a whole lot of junk too.
I had not thought of that... 

Quote
...search by album title, then look through the results and discard those whose artist is not the one requested.
Good method.

Quote
...a very common album title you might not be able to find any results, in which case I'd suggest searching by just Artist or just Album (whichever one looks more uncommon), then manually looking at the results for the one you want.
I suppose we'd have to use Artificial Inteligence to be able to get this right without intervention  , but still I am positive that this script will save me some valuable time. Just considering the time alone it would take me to manually search the folders that don't have a cover yet, copying the album and artist title, opening the CDBaby page, inputing the data, waiting for results, etc, and multiply this by thirty or something in this area and you can see how great this is for me (and probably for someone else too). I have no words to express my gratitude! 

Quote
Let me know how you get on with it: cdbaby.boo (http://www.byalexv.co.uk/foobar/cdbaby.boo)
I'll put the script to the test and I'll let you know the results as soon as possible.

Again, thank you so much! 
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-09 12:17:21
  hmmm...
It does not seam to be working here...

I took the liberty to open the script in a text editor and saw (what I could interpret as) the program using something like "http://www.cdbaby.com/Search/"+ album + "/0/cmVzdWx0VHlwZTo6QWxidW0%3d", e.g. http://www.cdbaby.com/Search/beauregard/0/...wZTo6QWxidW0%3d (http://www.cdbaby.com/Search/beauregard/0/cmVzdWx0VHlwZTo6QWxidW0%3d) .

I suspect that "cmVzdWx0VHlwZTo6QWxidW0%3d" part of the code isn't static, that's why I'm getting nothing in the results, no matter what I try. I went on to the browser and tried different strings to that search page formation. Every single one of them returned a page with the message "We're sorry. An error has occured processing your request. Go back to CD Baby home page." .

So I thought of another sideways solution, I don't know if it is at all possible, but it kind of works for me:

Instead of using CDBaby's own search capabilities (since we're not really interested in the page itself or the information inside it), we could use google image's search capabilities, but limited to CDBaby's site. e.g.:

"http://images.google.com/images?as_st=y&safe=off&sa=1&q=%22" + artist + "%22+%22" + album + "%22+site%3Acdbaby.com&btnG=Search+images&aq=f"

Like this --> http://images.google.com/images?as_st=y&am...by.com&aq=f (http://images.google.com/images?as_st=y&safe=off&sa=1&q=%22laura+jansen%22+%22trauma%22+site%3Acdbaby.com&aq=f) , which get perfect results for "laura jansen" "trauma" CD.

or just:

"http://images.google.com/images?as_st=y&safe=off&sa=1&q=" + album + "+site%3Acdbaby.com&aq=f"

Like  this --> http://images.google.com/images?as_st=y&am...by.com&aq=f (http://images.google.com/images?as_st=y&hl=en&safe=off&sa=1&q=trauma+site%3Acdbaby.com&aq=f) , which still get good results for "laura jansen" "trauma" CD, which is the 3rd result in the page.

The beauty of it also is that we could get much faster results! 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-09 12:33:10
It does not seam to be working here...

Could you let me know what artist and album name you searched for? I'll test it here and see if I can figure out why you aren't getting results. The one I usually use for testing is Telescope by Steve Dawson, which works fine when I try it here.

The "cmVzdWx0VHlwZTo6QWxidW0%3d" part is "resultType::Album" in url-encoded base64. If you look in the script, it isn't "+ album +" it is "+ EncodeUrl(Base64(album)) +", so if you are just substituting the album name in clear text into the url, it won't work.

If you want to use GoogleImage search instead, that's fine. There's already a google image search. If the album is only available from CDBaby, and google has it indexed there, it should be returned by it without needing to restrict it to just CDBaby. I'm not going to do a CDBaby script that uses google image - that's what the google image script is for.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-09 13:48:14
Oh, I get it now. I'm very sorry for the confusion. 

I was searching, as an example, "Laura Jansen" album "trauma" (or "Beauregard" EP) for instance.

The problem with google image search with this, for example, is that it will return completely random results, as both "Laura Jansen" and "trauma" are very common, so I end up with a lot of lady's pictures and injuries pictures. When the search was restricted, I got exactly what I wanted.

The first couple of tries I was so excited about the new script that I couldn't wait for it to work. I got no results and came here to report right after.

Turns out, as I've just discovered, that my internet connection was having problems (and probably that's why I couldn't get any results at all earlier). Now the script is working mighty fine, and with very good results, I must say. The point of using it is only to get those hard-to-find covers. Thank you so much for the script!



It does not seam to be working here...

Could you let me know what artist and album name you searched for? I'll test it here and see if I can figure out why you aren't getting results. The one I usually use for testing is Telescope by Steve Dawson, which works fine when I try it here.

The "cmVzdWx0VHlwZTo6QWxidW0%3d" part is "resultType::Album" in url-encoded base64. If you look in the script, it isn't "+ album +" it is "+ EncodeUrl(Base64(album)) +", so if you are just substituting the album name in clear text into the url, it won't work.

If you want to use GoogleImage search instead, that's fine. There's already a google image search. If the album is only available from CDBaby, and google has it indexed there, it should be returned by it without needing to restrict it to just CDBaby. I'm not going to do a CDBaby script that uses google image - that's what the google image script is for.

Alex

Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-09 19:30:17
I don't want to make Local Files always search first

Why not? It would make perfect sense if the local source is enabled. Why a user would enable this source? Because he/she has images locally which could match searches. If the local source is enabled (by user) and the "search first" automatically enabled (by AAD) for that source (be it hidden or greyed out), I can see 2 scenarios when searching:

1) local search yields results, if not what the user wanted, click search again to search the other sources not set as "search first".
2) local source doesn't have results (and other, if enabled, "search first" sources doesn't return any results too), AAD would automatically search other sources ("search first" disabled).

Is there a problem I'm not seeing? Wouldn't this be only advantageous to the end-users? The local source has different use cases than the rest of the sources, that's why I'm suggesting this change. I really don't see a situation where a user would like to enable the local source but not enable "search first". Maybe I'm short-sighted.

command line parameter of /sourcesFirst or /sF to go with the existing /sources parameter would be a good idea. You could then do something like /sourcesFirst "Local Files" /sources "GoogleImage".

Would there be a switch to turn it off for e.g. local source?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-09 20:20:15
Just because your usage would be to do a local search first doesn't mean it would be everyone else's too. There's absolutely no reason to force local search to be Search First, when there's a perfectly good checkbox available to set it like that if that's the way you want it. In any case, I always try to follow the principle of least surprise, and if you don't know about the Search First functionality, then you would be very surprised when none of your searches returned any results when you added the local files source to your search set. It would be unlikely to occur to you to hit the search button again, and if you did by accident, you'd probably assume it was a bug that they didn't show up until you hit the button again.

I don't envisage the need for a command line switch to disable search first for a source - is there any reason you want this?
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-09 23:50:06
Just because your usage would be to do a local search first doesn't mean it would be everyone else's too.

And I thought that I expressed my views so that I've thought about it generally, not just from my use case. The whole reason I posted about this was because I was thinking about REACT (I'm planning to pack AAD to my mod rel.) and its users. Personally I don't use the local source at all.

then you would be very surprised when none of your searches returned any results when you added the local files source to your search set.

But this is not what would happen!! If none of the "search first" sources return any results, AAD would continue to search the rest of the enabled sources, right? At least this is how you presented this new feature in this thread.

This is partly the reason I suggested to automatically use "search first" for the local source IF that source is turned on in the first place. Again, I honestly can't think of a situation where a user would like to enable the local source but not enable "search first". I don't see how this would harm searches. I can list my reasons to do automatic search first for local source if you like. But you do what you think is the best.

It would be unlikely to occur to you to hit the search button again, and if you did by accident, you'd probably assume it was a bug that they didn't show up until you hit the button again.

And may I ask how this case is any different from the fact that the functionality of this "search first" feature is not presented to the user in GUI when: a) user checks any source "search first" checkboxes, or b) doing an initial search when 1-n "search first"s are enabled? It was my intention to write about this in my previous post but forgot. The GUI currently doesn't give any hints of the "click the search button for the 2nd time to search more/other sources" feature. I.e. AAD doesn't tell/show that only a specific set of enabled sources were used in the search AND a subsequent search button click would search other enabled sources.

And I tried to suggest that you'd only "grey out" the ticked "search first" checkbox for the local source.. that way the user would know how the source works.

I don't envisage the need for a command line switch to disable search first for a source - is there any reason you want this?

Well, "just because your usage..." applies here too.  Long story short: I'm trying to avoid messing up users source settings anymore than I have to. And I was curious because my initial question included both on/off from the cmd switch and your reply didn't quite answer to that. I guess there's no must reason.. at least I can't think of any right now.. doesn't that show that there's no need to turn off that "search first" for the local source.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-10 08:30:16
But this is not what would happen!! If none of the "search first" sources return any results, AAD would continue to search the rest of the enabled sources, right?
Yes, that's right. But if it does find a local image, then none of the other sources would be searched until they hit the Search button again, and the user wouldn't know why.

Having a local image file does not automatically mean that they don't want to search online too. Maybe it's the wrong one, or poor quality, or maybe they're using local image search in some other strange way neither of us have thought of. Certainly it should be possible to set local source to be Search First, and I can see good reasons for setting it that way, but as the behaviour can be confusing if you're not expecting it, it shouldn't be the default, and it certainly shouldn't be forced (greying out the Search First checkbox for local source).

And may I ask how this case is any different from...
The idea is, the user has to specifically choose to use the search first functionality, so they would start off by expecting those searches to be treated specially. I don't know whether they'll guess that clicking the button a second time will search the rest of them, but I haven't been able to think of a better way to indicate it. I'm hoping the Search First terminology implies that your Second search will search the rest of the sources, but without observing some actual users trying it, I don't know if that works.

I can see where this might be an issue for you, if you use the command line to automatically set search first options then that behaviour could be presented to the user without them knowing about it, leading to the same confusion about why some checked sources hadn't been searched. Perhaps it would be better not to have a command line switch for it, after all.

So, open to suggestions, can anyone think of a good way to indicate to the user that, for reasons they may not immediately appreciate, further results from other sources may be available to them if they press the Search button again?


I don't envisage the need for a command line switch to disable search first for a source - is there any reason you want this?

Well, "just because your usage..." applies here too.
That's true, but to design a sensible command line, I need to know the usage I'm aiming for. I'd assumed the usage was for a command line user to specify a source or two that should be searched first, and some more sources that should be searched second. It wouldn't affect the users settings at all. With all the command line usage, the intention has been to avoid parameters specifically for changing user settings, but rather to use parameters to control how the particular search being executed is performed.

If the requirement is that sources which the user has marked as Search First but that are not included in the /sourcesFirst parameter are not searched first, then I would suggest that when the /sourcesFirst parameter is present, all user Search First settings are ignored (just for the search being performed by that command line, of course).

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-10 11:05:21
I'm terribly sorry to get in the middle of this discussion, but pardon my ignorance: Is there any option to make the program continue the search on the other selected sites, after all the "search first" are done?
(is this a stupid question?... - 'cause I'm thinking that maybe the program doesn't "know" when all the searches are done?)

P.S.: I must also say that the CDBaby script is working wonderfully! From the 37 covers I was looking for, I quickly got 31 of them! Thanks again!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-10 11:25:59
Is there any option to make the program continue the search on the other selected sites, after all the "search first" are done?
It will search the other selected sites automatically if the Search First ones return no results that match your filters. There is no option to make it search the other sources automatically if the Search First ones did return results, though, no. That would be the equivalent of just turning off Search First on all sources - all selected sources are searched. I suppose the difference would be that if you saw results you liked already, you could hit the Stop All button and cancel the remaining sources, but I think it's better to choose by explicitly searching further, rather than by 'not cancelling' a further search.

I'm glad the CDBaby script is working out, I'll push it out through the Automatic Updates / Get More Scripts link for everyone shortly.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-12 00:46:41
Hi, Alex,
thank you so much for your reply. I get it now. I thought that even if it had found nothing on the "search first" you still had to push the search button one more time. I usually do search for multiple covers on a queue and let the program take the necessary time to do it in the background, so I wasn't completely sure if the "search first" was the best option for me, although it saved me some good bandwidth.

I guess I was making the right use for the function, but I had not very well comprehended just how it was working. Because I have a slow connection to the internet, I loved the idea of giving priority search to some sources. I hadn't noticed I also had an option to stop all the searches after a good source was found, and that will be great for me. Thank you once more!

Since you've been so generous with your time, let me ask you another question, and feel free to not respond if you don't feel like:

I love the "Group by" option on the Search Window, and I normally use the "Group by: Source" option. Is it possible to have an option to "Group by: Size", e.g., like:
- Above 1000px (or Full-Res)
- Above 700px (or High-Res) (700-999px)
- Around 600px (or iTunes-Res) (540-699px)
- Around 500px (or Amazon-Res) (400-539px)
- Below 400px (or Low-Res)

I know there is already an option to filter out the high and low resolutions, but there is a lot of trouble involved in constantly changing that, especially to allow and see lower/higher resolutions when no image in the desired resolution is found.

I thought that since you already have the filter capabilities by the resolution in the program, making it work also as a grouping capability might not be such a hassle (maybe). And I really believe a lot of people would like and benefit from it.

It will search the other selected sites automatically if the Search First ones return no results that match your filters. There is no option to make it search the other sources automatically if the Search First ones did return results, though, no. That would be the equivalent of just turning off Search First on all sources - all selected sources are searched. I suppose the difference would be that if you saw results you liked already, you could hit the Stop All button and cancel the remaining sources, but I think it's better to choose by explicitly searching further, rather than by 'not cancelling' a further search.

Title: Album Art Downloader XUI
Post by: GHammer on 2009-09-12 04:21:59
I use this tool to replace poor quality images that I already have.
I wouldn't want to see local be a default that requires me to do something to get additional results.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-12 07:45:31
Is it possible to have an option to "Group by: Size"
This could probably be done, sure, but doesn't sorting by Size do the same job? There doesn't seem to be any good reason to group arbitrary size ranges together rather than have the smooth gradient that sorting would provide, unless I'm missing something...

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-12 18:01:03
This could probably be done, sure, but doesn't sorting by Size do the same job? There doesn't seem to be any good reason to group arbitrary size ranges together rather than have the smooth gradient that sorting would provide, unless I'm missing something...

Well... Not really (I think). [it's not actually the very same job]
To achieve a similar effect, we would have to choose "Group by: none" and "Sort by: Size". And this way you have a single group that won't help you very much in selecting your desired one.

The major difference would be that by grouping the images in those descripted size ranges would give us an extra option, of "Sort by: Source" or some other sort option that we desire.

Another big difference is that we wouldn't have to keep changing the "options..." -> "filter image by size" settings all the time to see if there are any results below the minimum that we had established before.

As an example, all the Amazons (.com, .uk, etc) very similar or identical results would be grouped very cohesively and it would be easy to spot if there is a difference between any one of those images. Besides that, if you're aiming for those kind of images in the first place they all will probably be near each other, easy to compare and select. The same is valid for a iTunes-like images (around 600px) and other categories.

I might advocate that I can't see any use at all for the "Group by: Local" option, that maybe it could be replaced, but that's not the point at all (and probably a lot of people actually use it). The point I'm trying to make is that I really think the "resolution banding" would make things a little clearer in the results and make it so much easier to select from the results with an additional sort option.

I hope you can see my point of view. I mean it in the most respectful way. I believe you have good control of the program's options and directions (as you should) and you might have some insight about it that most of us don't. Still, I would be happy if you decide to accommodate that extra option in the future.

Thanks again!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-12 19:27:23
Fair enough. There wouldn't be any down-side to it that I can think of, either.

Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2857652&group_id=187008&atid=919578) added. I don't think it should be too tricky, so it will probably go in to the next version.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-12 22:41:21
Thank you, thank you, thank you!     
Whenever it is possible, there is no hurry, that will be so  !!!
Fair enough. There wouldn't be any down-side to it that I can think of, either.
Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2857652&group_id=187008&atid=919578) added. I don't think it should be too tricky, so it will probably go in to the next version.

Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-13 03:33:30
I can see where this might be an issue for you, if you use the command line to automatically set search first options then that behaviour could be presented to the user without them knowing about it, leading to the same confusion about why some checked sources hadn't been searched. Perhaps it would be better not to have a command line switch for it, after all.

But this would wreck my control of AAD from REACT point of view. Remember when I asked you to provide /include switch? The reason was that I didn't want to mess other user settings in order to make sure that the local source is enabled if I use the /localImagesPath switch. Now, if the user has 1-n sources as "search first" (not local source) & I use the localImagesPath and include the local source, what will happen? AAD would ignore the local source completely until either, a) initial search fails, or b) user clicks the search button. Not good.

With the /include switch, it is not absolutely required for me to /exclude the local source when launching AAD without /localImagesPath switch. The search works and I don't want to turn local source off, the user might have turned it on by himself..

BUT, with this "search first" I'm in deep shite so to speak, I really would need at least the enable "source first" switch.. maybe the off switch too.

So, open to suggestions, can anyone think of a good way to indicate to the user that, for reasons they may not immediately appreciate, further results from other sources may be available to them if they press the Search button again?

IMHO you really should inform the user some way.. as audio20 showed, it's not so easy to understand that feature.

I've a suggestion.. would you believe.

Since the feature is connected to the search result list (user searches something and looks at the window control which lists the images), the best option would be to have an info in the top part of that control.

Look at the yellow popup infobar under the address field. Put something like that at the top part of the result list control and instruct them to click the search button again.. should be enough space for a short message. Of course only when user has search first sources and other sources.. and the first search gives results.
(https://interchange.indianamedicaid.com/images/ie6_with_infobar.gif)

OR something like this. Dunno if you can make that stay (and that's what you should do).. doesn't those usually have some maximum "visible" value?! I like the 1st idea better.. at least that could be made to stick until closed.
(http://www.seekfordsolutions.com/Products/ActiveX/ToolTipWizard/images/ToolTipv3_FoxPro.gif)

I'd assumed the usage was for a command line user to specify a source or two that should be searched first, and some more sources that should be searched second. It wouldn't affect the users settings at all. With all the command line usage, the intention has been to avoid parameters specifically for changing user settings, but rather to use parameters to control how the particular search being executed is performed.

Wouldn't affect the users settings at all? Avoid all command line usage to permanently change user settings? I'm sorry but what? Almost every command line switch I've used so far HAS permanently changed my AAD settings. Did I understand right what you were saying?

I've used the below switches and ALL of them change the settings permanently (tested by running AAD with the switches first (and I made sure that those changed previous settings) and then without switches in the end).

localImagesPath, include, path, sort, minSize

Interestingly /autoclose is not remembered. Didn't test others than these. Maybe the command line reference should list what switches are remembered and what not? Or make them consistent, I guess it would be the easiest. Make all change or not.

Actually, I think I could manage with "do not change user settings" "search first" command line switch. Dunno about others though, somebody could like it to change settings permanently.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-13 08:14:37
OK, I do see where you're coming from. The info-bar thing is not a bad idea, but I'm thinking it might be better to put it inside the results list, at the bottom, rather than floating above it. That way, if you scroll through all your results and still haven't found what you're looking for, a link with "Continue search with other selected sources..." (or similar, not dead set on the wording yet) would be there. Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2857934&group_id=187008&atid=919578)

For command line usage, I mis-worded it, sorry. I think it would be best if command line parameters did not change user settings. They currently do, with the exception of /autoclose, which is a special case.

If I've understood your concerns for REACT correctly, you need to ensure that the local source is searched, and would ideally like it to be searched first, ahead of all other sources. You would, however, like other sources the user has selected to remain selected for that search.

So, if I make a /sourcesFirst parameter which, when specified, means that just the sources listed for it are searched first, and all other sources searched second (regardless of existing user settings), but without affecting the users settings (so if they then start another search, it would use their normal settings), would that meet your needs for REACT?

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-13 08:46:33
I've been thinking some more about command line behaviour, and I'm no longer so convinced that they should always be temporary. Maybe I had the right idea when they were implemented the first time. So, some possible options for command line behaviour - opinions, anyone?

1. Command line settings are all always temporary. Any new searches performed by the user will use their existing settings, ignoring the command line parameters.
  1 a. In the search window launched by the command line, all settings are disabled, the user can't change them as they have been fixed by the command line parameter.
  1 b. Settings are enabled, but any changes made to them are discarded when the window is closed.
  1 c. Settings are enabled, and if the user makes any change to them, those changed settings are saved when the window is closed (replacing users existing settings).
2. Command line settings are always permanent. Settings specified by the command line are saved as settings when the user closes the search window.
  2 a. Certain documented command line settings do not affect settings. Currently, /autoclose has this behaviour, and the proposed /sourcesFirst would too.
  2 b. An additional parameter to specify setting permanence is added. /temporary or something, which would result in one of the behaviours in 1 when present.
  2 c. Each parameter can have permanence set for it. So /t:minSize would be a temporary setting of minimum size, /p:minSize would save it in the settings. For the ones set as temporary, one of the  behaviours in 1 would apply.

Bear in mind that the more complex or difficult the chosen option, the lower the chance of it actually ever getting implemented, and the greater the time before it does! For example, 2. a. is almost exactly the current behaviour, just with some additional documentation in the command args documentation.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-14 08:25:40
I've been thinking some more about command line behaviour, and I'm no longer so convinced that they should always be temporary. Maybe I had the right idea when they were implemented the first time. So, some possible options for command line behaviour - opinions, anyone?

I always thought of command line options as switches for the advanced user.

Something in the lines of "those commands are either too advanced, or secondary, or, ultimately, they would clutter the interface, so I'm giving them to power-users"; or to allow the program to be launched from other applications".

Being like that, I think the best way to get your program to act with those switches is always to create a shortcut that incorporates those switches; or have another application call the program with the right switches by programming this other app to do so. I can't really believe anyone would type the command line over and over again. So, long story short, I personally think the settings should be temporary, because they're probably being passed on each time the program is started (either in the shortcut or in the programmed call being made by the other app).

I believe that anything permanent should always be accessible, i.e. written somewhere, either in some tab inside the program (and probably the registry) or in some .ini file in the folder, or something like that. This way it can always be checked and changed (or, even better, made backup and restored). If someone want to make any of those permanent changes temporary, the best way would be to backup the .ini file, write another one and restore the original at the end.

Specifically for this program, I think like this:
- you either consider the command line calling as "a session" with its own specific settings (and all windows will use those settings, until the program is closed); The problem is (as you already have considered in 1b & 1c), if the user wants to change something in the middle of the session, should you consider that a permanent change or not? Should you change permanently only this changed option or all of the session's settings? That is a dilemma and both ways have their pros and cons. Ultimately, it's a personal choice of the programmer.
- or you think of it as an "automatic way to change settings", which is fine, as long as those are clear rules, i.e. when you start with comm.line your old settings are gone (but you can always have another shortcut with the old settings to restore them the next time, if you want to).

Both ways are OK, but I like the first (a session) a bit more. What I would really like though, is to have access to a settings (.cfg or .ini) file to make direct changes and backups of settings. It would also be nice (obviously in the future, as it would take a lot of extra work) to have groups of different settings selectable inside the program (maybe a pulldown menu), so you don't have to keep restarting the program or making a whole bunch of manual changes from time to time.

1. ...always temporary. Any new searches will use existing settings
--> ok, but I think this would generate confusion, as the user doesn't know that the settings he used to call the program are not valid anymore.
  1a ...all settings are disabled
--> don't like it at all. The user might (and probably will) want to change settings to accommodate for different types of results.
  1b ...enabled, but changes are discarded
--> ok, but I think this might generate confusion, especially if the user always starts the program using command line switches.
  1c ...enabled ...any change ...settings are saved (replacing existing)
--> the best option so far. In my opinion, the user never gets to choose if his change is temporary, unless you want to add another switch that deliberately says so or if you want to incorporate this kind of settings in the program (like 2b & 2c), both adding to the complexity of the program, like you said yourself. (personally, I don't think this is the best option, I would go with 1b, but for the general user, 1c/2c yes)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-14 10:15:57
What I would really like though, is to have access to a settings (.cfg or .ini) file to make direct changes and backups of settings

Thank you for your long and considered post, it certainly gives me points to think about. In answer to your specific issue about access to settings in a file, the settings are stored in the file:

\Documents and Settings (in XP, or in Vista:) \Users\<user name>\Local Settings\Application Data\AlbumArtDownloader\AlbumArt.exe_Url_<random junk>\0.30.0.0(or version number of AAD that you are using)\user.config

This is an XML file, which can be user-edited, copied, backed up or whatever. AAD stores no user settings in the registry.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-14 18:04:59
The info-bar thing is not a bad idea, but I'm thinking it might be better to put it inside the results list, at the bottom, rather than floating above it. That way, if you scroll through all your results and still haven't found what you're looking for, a link with "Continue search with other selected sources..." (or similar, not dead set on the wording yet) would be there.

Inside? Yes. Floating? That wasn't my idea, and the picture shows that it's not floating, i.e. covering anything. Remember that a large monitor, maximized AAD window & only few results, user might not glance to the bottom part at all. Try it at the top at least and see if that's good or bad. EDIT: Did you mean that you'd put it as a "source" in the end of the list? That sounds ok but what about if a user has e.g. sorting on which puts high resolution pictures at the top and there's so much results that your "infobar" would not be visible without scrolling? The user might not scroll down if the best results are at the top part. Just a thought.

A link in it? So the user would only click that infobar (link) and it would execute the 2nd search? Hmm, could be good, something is bothering me with that but can't pinpoint what.. so I guess the idea is good then.

...would that meet your needs for REACT?

I'll try to vote on the command line behavior thing thinking about it in general and with REACT in my mind.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-14 18:41:29
there's so much results that your "infobar" would not be visible without scrolling? The user might not scroll down if the best results are at the top part.
That's kind of the point. If they have results so good they don't even need to scroll to see the others returned by the first search, then they certainly don't need to do the second search! If they don't find anything they like, when they reach the bottom of their results, the link will be there allowing them to find some more.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-14 19:33:00
2. Command line settings are always permanent. Settings specified by the command line are saved as settings when the user closes the search window.
I think that this is the only reasonable option. /sourcesFirst would be permanent (consistent with the other switches/settings that can be changed and they are permanent).. and one could use it to turn ON and OFF "sourcefirst" options (I guess it needs /sourcesFirstOn and /sourcesFirstOff switches). Also make the /autoclose permanent. And with the modification that "Settings specified by the command line are saved as settings when the user closes the search window". I.e. if the user changes the settings, those are NOT reverted to the command line settings that were used.

Some of the 1x options would be too confusing for the user (1c especially) and all of them would require notifications in the GUI.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-14 19:54:31
If they have results so good they don't even need to scroll to see the others returned by the first search, then they certainly don't need to do the second search! If they don't find anything they like, when they reach the bottom of their results, the link will be there allowing them to find some more.
That's not what I meant. Let me rephrase that. If a user has e.g. sorting on which puts high resolution pictures at the top and there's so much results that your "infobar" would not be visible without scrolling? The user might not scroll down if the best results images with sizes that the user is interested in are at the top part. I.e. user don't accept under 600px images and the first visible result page shows images under that limit e.g. from the halfway down. One could argue that why doesn't that user use "minsize" option then.. well, everybody uses the program their own way and devs should think about every possible situation. The point is that IMHO you should have the info always visible! And with your suggested idea, I see that it could be missed by some users.. I wouldn't leave that possibility, but you're the dev here, you do what you think is the best. I don't get any pleasure arguing stuff over here, usually the users who engage in these kind of conversations are truly interested to help making the app better.. just saying in case I'm misunderstood (wouldn't be the first time.. sadly.. this depresses me a lot in general.. and it makes me always question if I got the message across).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-14 20:12:48
I think that [all command line settings are permanent] is the only reasonable option.
OK, thanks for your opinion. I agree, in general, but I know that having autoclose not affect the user settings was a requirement when autoclose was originally implemented. There's a similar case now for /sourcesFirst. The two options I'm now considering are either having just those two non-permanent (2a), or having a general purpose system to specify whether a parameter is permanent or not (2c).

And with your suggested idea [for where to put the "continue searching" link], I see that it could be missed by some users...
I think I see what you're saying, that there are plenty of results returned by the first search, but that due to their sorting preferences, the user will assume that if they can't see good results in the top few, then it isn't worth even scrolling down to see what other results are available? I'll have a think about that, but I'm also not convinced it's worth taking up a whole non-scrolling horizontal line of space all the time for this.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-14 20:42:11
Thank you for your long and considered post, it certainly gives me points to think about.
You're wellcome. I think it's the least we can do for you. 

Quote
In answer to your specific issue about access to settings in a file, the settings are stored in the file
[font= "Courier New"]\Documents and Settings [font= "Arial"](in XP, or in Vista:)[/font] \Users\<user name>\Local Settings\Application Data\AlbumArtDownloader\AlbumArt.exe_Url_<random junk>\0.30.0.0[font= "Arial"](or version number of AAD that you are using)[/font]\user.config[/font]
This is an XML file, which can be user-edited, copied, backed up or whatever. AAD stores no user settings in the registry.

That's a great thing to know, indeed. Thank you very much for this information.

I know it's not your fault at all, it's MS's fault to design such a flawed system as windows, where you have to bury the settings file so deep that a regular user won't find it unless he goes "on a hunt" for it. I also realize that I might have given you enough "trouble" already, but you might consider (in the future) including an option in the installer a lot of some great apps like yours do:

When running the installer for windows, give the user a "Portable" option, where he will choose a path that is outside the windows default path for programs (and therefore without write permission problems) and store the settings file inside the actual program folder (they just check each run if there is a settings file in the program folder and use that instead of that deep-buried one).

(http://i28.tinypic.com/2gsg3es.png)

The major advantage of it is not, as it might seam at first, to have the settings file inside the program folder. The beauty of it is that the user can actually copy and more the program folder around multiple times and the program still works consistently with all the settings he established before. It's also nice to be able to run the program from a USB stick and modify and keep the settings there.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-14 21:34:41
just check each run if there is a settings file in the program folder and use that instead of that deep-buried one
If you put a file called AlbumArt.exe.config in the program folder, settings within that will be read from that. It does not override the user settings file, though, the user settings file overrides, and is what the changed settings are written to. This is because there will typically not be write permissions to the program folder.

This is clearly not the Portable Mode you requested, but you might find it helpful. It is just the standard behaviour for .net configuration settings.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-14 22:06:02
If you put a file called AlbumArt.exe.config in the program folder, settings within that will be read from that.
That is also very good to know! It will allow us to have a USB stick with AAD and one fixed preconfigured settings. (It's not ideal, but already great, Thanks a lot!  )


Quote
This is because there will typically not be write permissions to the program folder.
I knew that, but I thought that was only valid if the program folder was actually inside "%PROGRAM_FILES%"; outside that path you would have normal write permissions.

Quote
This is clearly not the Portable Mode you requested, but you might find it helpful. It is just the standard behaviour for .net configuration settings.
Indeed. It is helpful. I have no experience whatsoever with .NET, so I can only hope you'll find out the write permission issue is only valid for the default program files path and not outside of it as it is in other cases for other languages. That way you still might have the portable option in future versions. Otherwise, I'm very happy with what I've already got right now. 
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-14 22:20:38
2. Command line settings are always permanent. Settings specified by the command line are saved as settings when the user closes the search window.

I think that this is the only reasonable option.

Hi, Akkurat,
I'm sorry to say this, but really? Are you thinking about users in general or are you more concerned with users that call AAD from another program?

What if I personally want to have different settings set up at different shortcuts for the program? (and I don't want to mess up my "standard" settings everytime I exit the program, after one of those calls). Isn't that reasonable?

Quote
Some of the 1x options would be too confusing for the user (1c especially) and all of them would require notifications in the GUI.

An interface with too many warnings is a cluttered interface... A user that calls a program with command line options isn't a user that get confused that easily also.

...that there are plenty of results returned by the first search...not convinced it's worth taking up a whole non-scrolling horizontal line of space all the time for this.

I agree with that point of view. Not every user have a huge LCD screen... There is a good possiblity that a lot of users will be using the program in a 15" monitor and a single line is indeed precious space. I also think that this whole warning to the user, for the first time user is a good thing. But very soon, it will be interpreted as an annoyance, because after only a very few seaches (1 or 2) the user will already know that, uless he presses the search button again he won't get more results after the "Search First" sources are done. I'm not for it at all, unless it can be turned off. A more elegant solution would be to change the focus to the search button, or change it's color to indicate there are more possible results. Something in those lines.

Quote
Quote
I think that [all command line settings are permanent] is the only reasonable option.
...I agree, in general... The two options I'm now considering are either having just those two non-permanent (2a), or having a general purpose system to specify whether a parameter is permanent or not (2c).
In that case, would you possibly consider having multiple sets of settings inside the program (as an option)? (the user could modify and save a limited number of settings that could be handled by a pulldown menu in the "...options" panel)
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-14 23:03:01
I'm also not convinced it's worth taking up a whole non-scrolling horizontal line of space all the time for this.

Maybe were are thinking different things here again. Is that small yellow bar really taking too much space in my mock up?

(http://img182.imageshack.us/img182/1293/aadexample.jpg) (http://img182.imageshack.us/i/aadexample.jpg/)
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-14 23:33:12
Are you thinking about users in general or are you more concerned with users that call AAD from another program?

I think I've expressed very recently where I'm coming from.. and I don't have to justify my opinion just because you don't happen to like it.

What if I personally want to have different settings set up at different shortcuts for the program? (and I don't want to mess up my "standard" settings everytime I exit the program, after one of those calls).

You can now. Just set up shortcuts for every possible need you have. There you go, problem solved. Just because you (or somebody else) could benefit from a more robust settings system, it doesn't necessarily mean that it would be good for the whole userbase, e.g. the feature could bring too much complexity and clutter.. what I'm saying is that there's a fine line of how much developers should develop the app, bring too many options and kitchen sinks.. errm, I mean features, pow, bloatware.

An interface with too many warnings is a cluttered interface...

Very true, that's the very reason I don't like the 1x options at all.. and those really require some info in GUI to users. Without info the what would be saved and what not etc. situations could be very hard to understand.

A user that calls a program with command line options isn't a user that get confused that easily also.

We could argue with that. I've seen very confused people who use cmd line options, (usually) it's not very hard to put cmd lines switches in to action, understanding what they do is.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-09-15 00:35:47
Quote
Is that small yellow bar really taking too much space in my mock up?
Not really, no. But try at lower resolutions, maybe it will. I think it's an unnecessary annoyance for anybody else's other than the first time user. (That is only one of the reasons why Internet Explorer is loosing so much market share for quite some time now: bad programming behaviors.) I'm not against it, specially if we could turn it off, but I'm really trying to see is this: Would it be worth all the programming time this would take if a good percentage of the users are bound to turn it off? If the developer thinks this will help first-time users try and stay faithful to the program, then "yes, it is", go for it. Otherwise, why not concentrate on more important tasks...

Quote from:  link=msg=657405 date=0
I think I've expressed very recently where I'm coming from.. and I don't have to justify my opinion just because you don't happen to like it.
I completely agree with you on that. I just think you should be more clear about what are you advocating. I don't think you have the average user in mind - at all. I didn't mean to be rude, as I'm guessing you didn't either when you dissed everybody else's choices, instead of just pointing out the virtues in your choice.
Quote
...Just set up shortcuts for every possible need you have.
I don't think that is a very elegant solution, but you're right, it could work.
Quote
Just because you (or somebody else) could benefit...
I decline to respond that. Let's just not go down that way.
Quote
...I'm saying is that there's a fine line of how much developers should develop the app, bring too many options and kitchen sinks.. errm, I mean features, pow, bloatware.
Agreed and agreed.      As Mies van der Rohe used to say, "less is more".
Quote
...that's the very reason I don't like the 1x options at all.. and those really require some info in GUI to users.
Ok, I respect your opinion, but I don't see the need for those infos. The user is very likely to enter the program already knowing that his new changes will or won't be saved at the end. We must consider the 1x as valid options, especially if they are/were/might be so much easier to implement. If you, as an external programmer, want definitive changes, you might very well manipulate directly the config file as shown by Alex earlier.
Quote
...I've seen very confused people who use cmd line options... not very hard to put cmd lines switches in to action, understanding what they do is.
I'm not fully in agreement here, but there's a whole lot of margin for error there. Let's call it a draw.

Finally, I think I fully understand what you are so passionately advocating here, that is an extremely welcome, desired and convenient change in AAD that will allow you to have more control of it, and your own users to have a more pleasant and consistent experience with the program. That's perfectly fine. What I don't like, and I hope you respect my opinion on that, is that you have to go all the way around it to primarily dismiss a great option that all "the other users" (the ones that don't call from an external program) would have: the option to have (at least while there is no option for different settings inside the program) a couple of temporary settings they could alternate once in a while. It's no big deal, really. But first we should discuss respectfully, and only then we come to a verdict.
Title: Album Art Downloader XUI
Post by: durch on 2009-09-15 01:07:06
Just a small feedback from a first-time user: I'm using Windows XP and have disabled ClearType font rendering. However, Album Art Downloader XUI uses ClearType without having an option to disable it. I think this should be disabled by default for future versions of this program. It may be a nice program, but the first impression could have been better when ClearType wouldn't have been forced.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-15 01:31:39
I just think you should be more clear about what are you advocating. I don't think you have the average user in mind - at all.

"I'll try to vote on the command line behavior thing thinking about it in general and with REACT in my mind." Post #979 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=657286). That was the last time I wasn't clear.

I didn't mean to be rude, as I'm guessing you didn't either when you dissed everybody else's choices, instead of just pointing out the virtues in your choice.

LOL. Alex ASKED opinions, I gave mine. I guess you're a bit self-centered if you thought that I dissed your choices (everybody elses? there's only 2 opinions so far, yours and mine). Did I comment on your opinions?

We must consider the 1x as valid options, especially if they are/were/might be so much easier to implement.

Here's an interesting point, I was thinking also from Alex's POV (he stated that: "Bear in mind that the more complex or difficult the chosen option, the lower the chance of it actually ever getting implemented..."), as well as in general dev POV, those 1x options need work. That combined with thinking about this from users POV, and my POV.. and from REACT users & dev POV. All these made me choose option 2. Now then, was I really thinking about from my situation only? I don't understand where you got that from.

If you, as an external programmer, want definitive changes, you might very well manipulate directly the config file as shown by Alex earlier.

Who said that as an "external programmer" I would like definitive changes? Again, you're drawing your own conclusion from thin air. In fact, if you'd have paid attention, it's quite the opposite. Also manipulating the config file means that I would have to code a parser for that huuuuge settings file, a parser which might get broken with every new AAD release. No thanks. Also I don't like the idea of messing with files that could have who knows what user rights.

What I don't like, and I hope you respect my opinion on that, is that you have to go all the way around it to primarily dismiss a great option..

Great and great, who decides that? And like I said, Alex wanted opinions, I gave my opinion about the options he provided.

But first we should discuss respectfully, and only then we come to a verdict.

LOL. Verdict? I'm not here discussing and thinking that I'm part of the decision group. LOL. Seriously. Alex has the magic wand here, we don't have to agree and come to a consensus.. we just whine and hope that our opinions count when Alex makes a decision.

EDIT: ytpos
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-15 01:46:41
Album Art Downloader XUI uses ClearType without having an option to disable it.

This has been discussed in this topic, a "ClearType" topic search yielded a straight answer:

I suppose that album art downloader now is a WPF application and that causes this effect. I haven't developed with WPF yet, but I think that there is a possibility to fix that.

It's called anti-aliasing, is part of how the WPF framework draws itself, and as far as I can tell, there is no way to turn it off (http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=319013&SiteID=1), sorry. The best I can offer is that it doesn't look so bad if you have ClearType turned on for the system, which isn't really a solution, I know.

Anti-aliasing and clear-type seems to be in fashion at the moment, although I've got to say I'm more in agreement with you that font-fuzzing is not the great step forwards it is made out to be.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-15 09:10:08
Akkurat and audio20, I have read the (spirited) discussion, and am paying attention. Here's my current thinking:

1. Portable Mode. Nice to have. This would, however, currently involve replacing the standard .net configuration settings system with something custom written, which is not something I'm particularly interested in doing. I'm not saying it will never happen, but I wouldn't hold your breath. Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2859112&group_id=187008&atid=919578)

2. Multiple settings sets. Not going to happen. Sorry, but I first encountered such a system in an application called frhed, and it completely confused me then. If it confused me, it will confuse others, and I'm not confident I could present that functionality in a non-confusing way. I'm afraid Akkurat's suggestion to use multiple command lines is your best bet.

3. Command line argument settings persistence. Having reviewed the arguments on both sides, command line arguments will continue to effect persistent changes to user settings. /autoclose will be documented to indicate it's exceptional status.

4. Command line support for Search First. This will happen, but I'm not set on the form it will take yet. I'm thinking at the moment instead of a /sourcesFirst parameter, to extend the existing /sources and /include parameters so they can specify first. For example, /sources "F:Local Files,GoogleImage" would result in only two sources being selected, and Local Files being marked Search First. /include "F:Local Files,GoogleImage", on the other hand, would add the Local Files and GoogleImage sources to the selected sources, without unselecting other already selected sources, and mark Local Files as Search First (if not already so marked), and unmark GoogleImage. These changes would persist in user settings.

5. Indication of Continue Search. In a maximized 1280x1024 screen, yes, an Info Bar like you suggest would take up negligible space. AAD is designed to work well at much smaller sizes than that, even non-maximized on a smaller screen. Please consider a window size of 640x480 when evaluating UI. I'm still of the opinion that scrolling down is a fairly natural behaviour when no acceptable results are visible, but I have taken your point about the sort order, and am still considering alternatives. Any alternative must not be irritating to experienced users, and must absolutely not feel like it is getting in the way. Flashing lights and popup balloons won't do! A non-scrolling bar might be OK, but it would be at the bottom, and not the top, at least.

Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-15 23:06:28
I have read the (spirited) discussion

Mildly put.

1. IMHO, .NET apps portable? Not so good idea. Anyhow, I always advocate portable software.

4. The extended switch system sounds good.

5. I disagree slightly with some of the points but there's no need for me to repeat myself.  The 640x480 is so 90s (reminds me of an early web design case in the late 90s where the boss was using 640x480 and wanted their company website to fit to that  He almost had a heart-attack when I showed him 800x600.. "put it back, put it back.." LOL), a ~20px high infobar is taking very little space versus all the search fields, etc. AND the source list. I know I know, why add some more. Anyways, I do hope that you'll find a good solution easily.

Thanks for listening.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-16 08:24:11
I'm glad you're happy with the extended switch system for Search First. As long as that does what you need for REACT, it's the one I'm going to go with. Updated Feature Request (https://sourceforge.net/tracker/index.php?func=detail&aid=2857383&group_id=187008&atid=919578)

For continuation of search, I've had another idea. How about if the search button changes text from "Search" to "Extend Search" (on two lines, probably). If I'm feeling artistic, or more realistically if I can find a suitable free icon, I'll have the icon change too. The nice thing is, this would happen if they manually selected any additional sources too, and would revert to just "Search" if they changed the Artist or Album fields. That way they'll have immediate visual feedback on what the button will do when they press it, under all circumstances.

I don't see any reason .net apps shouldn't be portable. Other than having to write your own custom settings mechanism rather than use the standard one, I don't think there would be any other difficulties. It's not like COM where components need to be registered to work! Of course, the Foobar COM Automation thing wouldn't be portable, AAD will work just fine without it. How well it works in practice would really depend on how widespread the .net framework is, really. It's pushed out by Windows Update, and should be part of Vista and 7, but I just don't know.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-16 10:10:36
Alex, I was mainly thinking about it generally, but it suits REACT just fine too. Just making sure that people understand that I was thinking about it in general.. some of your posts could have given other ideas (e.g. "would that meet your needs for REACT?" and "As long as that does what you need for REACT, it's the one I'm going to go with").

The search button thing actually sounds great. If it changes appearance enough for the user to notice it always and it doesn't irritate "exp. users", I'd try that. Good idea.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-16 10:35:31
Just making sure that people understand that I was thinking about it in general...
Sorry, that's fine, yes. Of course I want to make sure that the command line is as generally useful as possible, and your opinions on that are most welcome. However, information on whether it will meet the known requirements for a known usage is also very useful to me! If it wasn't going to do the job for REACT, then the design would need re-thinking.

Alex
Title: Album Art Downloader XUI
Post by: kpom on 2009-09-16 22:40:21
"No matching images found." What does it mean? Network problem? How to test?
Title: Album Art Downloader XUI
Post by: antman on 2009-09-17 02:02:22
Here's a random question that might be answered in this 40-page thread.  Haha.  But why do so many images in the search results return unknown image size?  And two, how about an option to prefetch the unknowns and save me 30 clicks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-17 08:02:38
"No matching images found." What does it mean? Network problem? How to test?
This means, when using the command line version (aad.exe), that it could not find any results matching the album and artist you specified, conforming to any restrictions you specified, in the sources you specified. You could try performing the same search using the GUI version (AlbumArt.exe), or if you tell me what your command line was, I'll try it here and see if I get any results.


Here's a random question that might be answered in this 40-page thread.  Haha.  But why do so many images in the search results return unknown image size?  And two, how about an option to prefetch the unknowns and save me 30 clicks.
Yeah, it is a bit long, isn't it. Still, at least it has a search function.

Anyway, to answer your question, many images in the search results return unknown size because it is not common for a website to say what size the image is before you download it. Some do, and where they do, the script for them should extract that information - but if it isn't there, it can't be done. The option to prefetch the unknowns is hidden under the "Options" link in the main window. Click that, then select the option to download full size images only when size is unknown.

Alex
Title: Album Art Downloader XUI
Post by: antman on 2009-09-17 11:24:46
Of course it's right there in front of me... right next to the options I change as soon as I install a new version of aad. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-20 09:56:01
Album Art Downloader XUI v0.31 Released

I've implemented a few more requested features in this release. I'd appreciate it if those who requested the features could give them a quick try and make sure they're doing the job properly before I push this version out through the Updates mechanism.


Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.31.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.31.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: antman on 2009-09-20 16:35:10
I kinda like the group by size option but what's odd, to me at least, if one dimension of an image towers over the other it still gets grouped in the smaller group.  Like I searched Converge - No Heroes, and I get an image 1000x667 put in the medium (over 540x540) group.  1000p is not medium.  Maybe it should sort by the larger dimension and not the smaller?

Which brings me to my feature request:  an option to hide images that are not perfectly square.  I only look for front covers and they are usually even at 600x600, etc.  Images that are 1000x667 are no doubt going to be arist images or other what not.
Title: Album Art Downloader XUI
Post by: Zarggg on 2009-09-22 04:00:20
Not necessarily. Covers aren't always perfectly square; I've seen some scans that are slightly wider than tall.
Title: Album Art Downloader XUI
Post by: antman on 2009-09-22 04:51:08
Of course, they're homemade.  I really try to find the digital version before grabbing a scan.  And if I really need to resort to a scan, I'll do it myself.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-22 08:06:17
Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2864068&group_id=187008&atid=919578) added for square image filter. I'm not sure where I can find any room on the UI for it, but I'll think about it.

For the group by size, I think it makes more sense to categorise images based on their smallest dimension, not their largest. If it's only 300px wide, then it's not a high resolution image, regardless of how tall it happens to be.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-25 16:01:48
if those who requested the features could give them a quick try and make sure they're doing the job properly

Sorry about the late reply. Features working ok. Just put the info about the search first F: prefix feature to the command line reference help.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-25 16:32:48
Just put the info about the search first F: prefix feature to the command line reference help.
Huh, could have sworn I'd done that. I know I wrote it somewhere... Oh well, I'll make sure that's added for 0.31.1, which also includes a bug fix for a Various Artists detection crash that can occur under rare circumstances, then release this weekend.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-26 08:34:11
Album Art Downloader XUI v0.31.1 Released

Just a couple of minor bug fixes here, with Various Artists detection, and to add documentation on the F: prefix to the command line documentation. This one will go out through the Updates mechanism.

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.31.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.31.1.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required)
Title: Album Art Downloader XUI
Post by: Valery_Kondakoff on 2009-09-26 13:05:40
Thank you for such a useful tool. There are two questions and a suggestion.

Question 1: it seems the latest AAD build uses a wrong place to store the user.config file and the scripts. Right now it is stored in c:\Users\%USER%\AppData\Local\AlbumArtDownloader\AlbumArt.exe_Url_ab4blq4r5vajyecsjktugtsqgadfd4lg\0.31.1.0\ . This seems wrong to me, because the c:\Users\%USER%\AppData\Local\ directory is usually used for storing the temporary data, and the ini-files (and scripts) should be stored in c:\Users\%USER%\AppData\Roaming\ directory (in WinVista and Win7). Don't you think it is a good idea to move the ini-data to c:\Users\%USER%\AppData\Roaming\ ?

Question 2: I can't understand how to use the presets in AAD. I'm using folder.jpg, back.jpg and disc.jpg as my artwork filename and the files are usually located in %artist%/(%year%) %album/ directories. How should I set the presets and 'Path to find images' to save covers in that way?
By default AAB is set to search artwork like this: "Folder%preset%.%extension%|Cover%preset%.%extension%", thus saving covers add 'Folder' to every image: Folder-back.jpg, folder-disc.jpg etc. This is not what I want.
When I change the 'Path to find images' to 'folder.jpg' or 'folder.jpg|back.jpg|disc.jpg' the suggested filename for artwork is folder.jpg, but the 'Save As' drop-down menu (located near the Save button) which allows to choose the artwork type disappears completely.
When I change the 'Path to find images' to '%preset%.%extension%' AAB stops to find artwork in specified folders and founds the first available mp3 file instead: there is 'Found: 01-titlename.mp3' in File Browser Artwork status column. In addition the default suggested image name becomes '.jpg' even when Default preset is set to 'folder'.

So, there is a question: how should I set the 'Path to find images' and presets to save artwork as folder.jpg, back.jpg, disc.jpg and still be able to auto-find the artwork in File Browser and have a 'Save As' option?

Suggestion: I'm pretty sure it is a good idea to set the suggested (default) artwork file name to the respective preset when the type of the image is known. Right now the suggested file name for all the found images is set to folder.jpg regardless of the type (unknown, front, back, inside). I think the default preset should be used only for images, which type is unknown. For all images with known type (front, back, inside) respective preset should be used as default value.

Thank you!
Title: Album Art Downloader XUI
Post by: bsleeth on 2009-09-26 17:22:36
3. Command line argument settings persistence. Having reviewed the arguments on both sides, command line arguments will continue to effect persistent changes to user settings. /autoclose will be documented to indicate it's exceptional status.
Sorry to jump in on this so late, but this issue is my only "wish it didn't do that" for AlbumArt.exe.  I have a rather large collection of music for which I already have album art.  As such, I mainly use AlbumArt.exe from the Start Menu when preparing to rip new CDs.  I will save the album art images into a common folder from which they will be pulled when I actually rip the given CD.  So, 90% of the time, I always want the "/path" parameter to be something like "[root]\%artist% - %album%.%extension%".

The problem is that once in awhile I will launch AlbumArt.exe from mp3Tag, foobar200, or REACT (in REACT, this occurs generally when I have saved the image with a slightly different name than what is generated in EAC due to translation of special characters \/:*?"<>|).  Of course when one of these other utilities launches AlbumArt.exe, they must specify the parameter options, including the "/path"; which then overwrites my desired setting.

As a result, the next time I use AlbumArt.exe (from the Start Menu), I will inevitably save the first image using the previous command line "/path" setting (thank you for providing a warning on overwriting existing files).

If at all possible would you be able to add a switch that would indicate that the user wants the command line switches to be saved or that the command line switches are just temporary.  As the current behavior is to save, I would guess that it would make more since to add a "temporary settings only" switch rather than a "save settings" switch.

Again, sorry for the delayed (and long) post, but perhaps with some insight into how some (at least one) user is using your tool it will help guide your design decisions.

Thank you for such a great and invaluable tool,
Brian
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-09-26 18:26:31
So, 90% of the time, I always want the "/path" parameter to be something like "[root]\%artist% - %album%.%extension%".

Change your AAD shortcut in Start Menu. I know that it's not exactly what you're after, but at least this way you can fix it for now.

in REACT, this occurs generally when I have saved the image with a slightly different name than what is generated in EAC due to translation of special characters \/:*?"<>|).

I use the CoverDownloaderLocalPath setting in INI file. Like this: CoverDownloaderLocalPath=D:\WHATEVER\folder.jpg ... that way I only have to remember to a) put the cover in that folder & b) with that folder.jpg filename. Easypeasy. This works nicely for me because I always (~99%) have to edit cover images (I'm a perfectionist.. unfortunately) before ripping a CD.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-26 18:37:41
Don't you think it is a good idea to move the ini-data to c:\Users\%USER%\AppData\Roaming\ ?
The Roaming folder is used for files and settings that should be automatically copied on to a PC whenever a roaming user logs on to a different machine on the network. I don't (and can't) test under those conditions, so can't say for certain whether AAD would support roaming or not. It is safest just to say no, it does not support roaming. Settings are stored per-user, per-machine. If anyone does actually use AAD under roaming conditions, feel free to speak up here!

I can't understand how to use the presets in AAD.
The question here is, how can AAD find a local cover file in a known folder? Bear in mind that wildcards are allowed, but regular expressions are not (for file finding). So, %preset%.%extension% becomes "*.*", which is why the first available mp3 file is found. If you know that all your cover files are .jpg, you could use %preset%.jpg, which becomes "*.jpg", and should work.

I'm pretty sure it is a good idea to set the suggested (default) artwork file name to the respective preset when the type of the image is known.
There's a separate system for that. If you want the known type name to be included in the filename (rather than a preset you pick manually), include the %type% parameter. You can also specify exactly what types should be called, for example: %type(unknown,folder,back,inside,disc)% to match your scheme.

Thanks for your opinion on this. I do see where you are coming from here. Perhaps a workaround could be to change the shortcut on your start menu so that it specifies the /path parameter you want to use when not launching from another tool? That way you wont get any nasty surprises!

Thank you both for your comments, it's good to know when my work is appreciated!

Alex
Title: Album Art Downloader XUI
Post by: Valery_Kondakoff on 2009-09-26 19:05:58
If you want the known type name to be included in the filename (rather than a preset you pick manually), include the %type% parameter. You can also specify exactly what types should be called, for example: %type(unknown,folder,back,inside,disc)% to match your scheme


Alex, thank you for your explanations - there were really useful.

One additional question: setting  'Path to find images' to smth like '%type(unknown,folder,back,inside,disc)%' disables the 'Save As' button. If there is a way to bring this button back, say, for 'unknown' type images?

Thank you again!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-09-26 19:36:41
setting  'Path to find images' to smth like '%type(unknown,folder,back,inside,disc)%' disables the 'Save As' button. If there is a way to bring this button back, say, for 'unknown' type images?
I assume you mean the presets dropdown? Save As still very much exists, either right click and choose Save As, or just click the filename itself to edit it before saving.

To use presets for unknown type images, use: %type(%preset%,folder,back,inside,disc)%, that way, when it's unknown, the selected preset will be used.

Alex
Title: Album Art Downloader XUI
Post by: Valery_Kondakoff on 2009-09-26 20:31:36
use: %type(%preset%,folder,back,inside,disc)%


That is it!.. Thank you for pointing me!
Title: Album Art Downloader XUI
Post by: electricprophet on 2009-09-27 22:13:39
I'm sure people have requested this before, but here goes: i use the Metal-Archives script (for example) that i know always gives the perfect match for the cover art. It would be nice if there would be an option which would silently download the covers without me having to choose each and every one of them and confirm the choice. The Metal-Archives script in combination with the option would make downloading the cover arts possible for my entire metal folder with just one click and the matches  would be very accurate, since the script is a reliable one.
Title: Album Art Downloader XUI
Post by: Lonan on 2009-10-02 11:29:45
Don't know if it is possible but i would like to have a .bat that i start and then Album Art Downloader automatically scans a folder and searches for missing covers.
Is this possible?

Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-03 08:31:59
It would be nice if there would be an option which would silently download the covers without me having to choose each and every one of them and confirm the choice.
This has come up before. There's a tracker here, if you want to follow or comment on it: Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2780329&group_id=187008&atid=919578)

Don't know if it is possible but i would like to have a .bat that i start and then Album Art Downloader automatically scans a folder and searches for missing covers.
If you mean, scan a folder and automatically downloads a best guess for each missing cover without user interaction, then no, that doesn't exist (see above).

If you want to scan a folder and find albums with missing covers, then do a normal search for each missing cover in turn, then the File Browser is what you are looking for. Click File, New, File Browser.

If it has to be a batch file, you can run albumart.exe /fileBrowser (optionally then specifying the path of the folder to search), and it will go straight to the file browser.

If you want to search and download a best guess for a single search from a batch file without user interaction, then call the command line version (aad.exe) from the batch file. This can't extract artist and album information from tags or path pattern, you have to pass it the album and artist to search for as parameters, though, and it doesn't detect already existing album art.

Alex
Title: Album Art Downloader XUI
Post by: Zarggg on 2009-10-04 23:37:35
Alex, I don't recall if you ever touched on this before, but are images downloaded to memory discarded when starting a new search, or only when closing the application?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-05 07:45:49
are images downloaded to memory discarded when starting a new search, or only when closing the application?

Images are discarded either when the search window they are contained within is closed, or when they are removed from the results of the current window. That can happen by unchecking sources and clicking the Search button again (results from the unchecked sources will be removed, and the in-memory images for them discarded). It will also happen if you don't have the "Open search results in new window" option checked, and do a new search. The results from the old search will be removed and the memory discarded.

Filtering does not actually remove results, just hides them, so that will not discard the memory for the results not currently visible.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-10-05 23:11:36
Alex, would it be possible to implement a triple-click select all text for all input fields?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-06 07:40:41
Alex, would it be possible to implement a triple-click select all text for all input fields?

Possibly, but I'm not sure I understand what you mean. Could you describe where you would triple-click, what you would want to happen when you do so, and why you would want it to be in that state - what would you do next?
Title: Album Art Downloader XUI
Post by: Zarggg on 2009-10-06 16:02:01
He means triple-clicking in the Artist or Album search input fields to select all text in that field.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-10-06 16:11:24
Yes, selecting all text in any input field. Isn't this how almost all programs work nowadays?
Title: Album Art Downloader XUI
Post by: skimj on 2009-10-07 05:12:40
The "Save images to" field is read only when the search window is spawned from the file browser but not otherwise. I find this read only behavior difficult to work with. I read another post to same effect. I know you said that you thought it was better this way and don't want to change it; I disagree but if that's still the case, I wonder if it could be made a little more user-friendly. Two ideas:
1.  It could be read-only by default, but have a small check box to make it editable. (This is already in the "minimized" options window).
2.  Alternatively, could you put something in the File browser window that helps set up how the "save images to" string will be formed? It took me a long time to figure out that if I searched my music for %source%.jpg, that would put the %source% in the "save to" string. Could it be separated so that there's a search string and then below that a "default save to" string with the cool auto insert drop down box like exists in the search window? (it could even be greyed out and require a checkbox selection to activate)

Another idea: I've read that people would like to solve the "unknown" file size. One way to quickly fake this manually is to click on the image but immediately release the mouse button without waiting for it to download. I believe the first part of the file contains the frame with size information; this information is downloaded without actually downloading the whole image. Could this be automated by only downloading the first 500 bytes (or whatever) of every image with unknown size?

Thanks for your continued work here. It a great app that I use all the time.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-07 08:21:19
Yes, selecting all text in any input field. Isn't this how almost all programs work nowadays?
Not as far as I can tell. Double click to select a word is standard, and AAD does that. I haven't seen triple click to select all in any other program. Word processors usually use it for select line, but that's not really the same thing. Anyway, just because no-one else doesn't doesn't mean we can't. I'll see what would be involved in doing it, and whether it would have any adverse effects, but if not then it could probably be done.

It could be read-only by default, but have a small check box to make it editable
Would you really want to be editing this every time? The reason it is read only is that changes made here would not affect the file browser search path. I think option 2 is better, I'll see if I can think of a good way of letting you customise the location to save images to from the file browser.

The partial downloading idea for full size images is interesting. I'm not sure if it is practical or not, but I'll look into it. What you are doing with clicking on the image is not partial downloading, though. It doesn't matter how quickly you release the mouse, the full image will still be downloaded, and the dimensions measured once the download is complete. There are a couple of existing options for dealing with unknown image sizes - in the Options you can choose to automatically download full size images when the dimensions are unknown. This is the equivalent of your manual method, but for all unknown images, and automatically. The second, newly introduced option, is for specific sources you can tell them to always download full size images straight away, instead of bothering with a thumbnail first.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-10-07 13:56:38
Not as far as I can tell.

You're right. I didn't test it enough.. and the fact that this was (probably) the first time I really missed this functionality in an app clouded my view on the matter.

Not a high priority enhancement.. if you easily get it to work and without no problems, implementing it would be nice. The triple-click select all is easier and more "dependable" than "click+hold+drag to select" method (sometimes you don't get all text selected this way). Ctrl+A is useful too.. but old mouse usage habits die hard.

Thanks again.
Title: Album Art Downloader XUI
Post by: skullmonkey on 2009-10-13 15:49:24
Is there possibility for Auto Save of the cover?
Title: Album Art Downloader XUI
Post by: Capricorn on 2009-10-15 15:20:24
Cans someone help me make this %type% param work?

this is what i have:
"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" -ar "$if2(%album artist%,%artist%)" -al "%album%" -p "$replace(%_path%,%_filename_ext%,%type(%preset%folder,back,cd,inside)%,) .jpg"

what i'm expecting is to have folder.jpg or cd.jpg and so on, according the known cover type.

thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-15 18:28:27
Is there possibility for Auto Save of the cover?
I'm not sure what you mean by this. Could you describe how you think this would work?

Can someone help me make this %type% param work?
I think the problem here is that you need to escape the % marks for titleformatting, as %%:
"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" -ar "$if2(%album artist%,%artist%)" -al "%album%" -p "$replace(%_path%,%_filename_ext%,%%type(%%preset%%folder,back,cd,inside)%%,) .jpg"

Note that you've got a space before .jpg, which would give you something like "cd .jpg", not "cd.jpg". I'm not sure what the last comma is for in the $replace function? I think you also have the type parameter slightly off, you probably meant to have a comma between %preset% and folder - and are you sure you want CD and Inside reversed like that? Assuming that you want to use a preset for when the cover type is unknown, and no space before .jpg, then you would want:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" -ar "$if2(%album artist%,%artist%)" -al "%album%" -p "$replace(%_path%,%_filename_ext%,%%type(%%preset%%,folder,back,inside,cd)%%).jpg"

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: Capricorn on 2009-10-15 19:49:38
Is there possibility for Auto Save of the cover?
I'm not sure what you mean by this. Could you describe how you think this would work?

Can someone help me make this %type% param work?
I think the problem here is that you need to escape the % marks for titleformatting, as %%:
"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" -ar "$if2(%album artist%,%artist%)" -al "%album%" -p "$replace(%_path%,%_filename_ext%,%%type(%%preset%%folder,back,cd,inside)%%,) .jpg"

Note that you've got a space before .jpg, which would give you something like "cd .jpg", not "cd.jpg". I'm not sure what the last comma is for in the $replace function? I think you also have the type parameter slightly off, you probably meant to have a comma between %preset% and folder - and are you sure you want CD and Inside reversed like that? Assuming that you want to use a preset for when the cover type is unknown, and no space before .jpg, then you would want:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" -ar "$if2(%album artist%,%artist%)" -al "%album%" -p "$replace(%_path%,%_filename_ext%,%%type(%%preset%%,folder,back,inside,cd)%%).jpg"

I hope this helps,

Alex



Thanks Alex this works great now....
Title: Album Art Downloader XUI
Post by: swexru on 2009-10-18 19:35:48
perfect software, can you add ability to put album picture directly to mp3 file, thx
Title: Album Art Downloader XUI
Post by: BakedBeans on 2009-10-19 00:58:22
Is there a way to add more formats?
Title: Album Art Downloader XUI
Post by: Zarggg on 2009-10-19 04:19:14
What other formats would be relevant? PNG, GIF, and JPEG are pretty much the standards.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-19 21:41:24
Hi, Alex,
it's been a long time since I've visited this forum. I was kind of ashamed for going on a rant with Akkurat...  For this reason, I have not been able to comment on the new version (0.31.1.0).

First of all, I really like the new "Extend Search" button, very clever! (I don't see anyone possibly getting confused with this any more)

The Group by size banding is great! It's helping a lot (and I must personally thank you for meeting this request so fast). It's much easier now to locate the cover I want to keep. The banding-scheme that you used is also very good (as well as the naming conventions). I only think that covers that are like 600x530 should be in the Medium band instead of the Small.

Maybe you could consider lowering the Medium band limit to something like 520, just because there are covers that well belong to that category but happen to have a larger than usual width, resulting in a "small" height. I don't think this change would shift too many (if any) undesirable covers to the upper category. (I might have sugested 540 as a limit before, but I was thinking about the greater dimention, rather than the smaller one.)

Another great thing about the image banding is that it is so much easier now to spot all the similar or identical images sorted side by side. I'm lovin' it!

I've been reorganizing my entire music colection (Lp's, CD's, Cassetes), digitalizing stuff, getting new covers, re-tagging, etc. I am so happy to be able to use AAD. It saves a HUGE amount of time. I am pleased to say that I could get, so far, more than 96% of the covers I searched through AAD (without the need to go on a separate, more deep search through the WEB). I don't think it is really needed, but if you're even considering adding more sources to the program, allow me to suggest the various "7digital.com" stores ( http://us.7digital.com/ (http://us.7digital.com/) http://es.7digital.com/ (http://es.7digital.com/) etc).

Since I've been using AAD (a lot!) lately, I've come to meet some tiny issues:
When doing a queue search (from an MP3 folder containing some albums properly divided into their own folders), I noticed that the characters "&" and ":" always lessen the chances of finding the right album on most sources. When I manually removed these characters from the search input and did a new search, the results were always better (much better actually). Most times when I also removed the "Various Artists" string from the artist field I found even more accurate results from the sources.

My question is:
Is there any way you could strip those characters ( & and : ) from the search strings you get from the queue? (I tried to figure out a reason why it wouldn't be benefitial doing this but couldn't get any reason so far... Perhaps you saw something I didn't...)

Another thing with those kind of searches (from the queue) is that whenever I have albums with multiple CD's (in separate folders), AAD will always put the covers on the 2nd (or 3rd) one (not to mention that the "Local Files" source won't display the files that are already on the 1st folder). Is there any way to configure the program to search and put the images on the 1st folder?

And, at last, I would like to offer my sincere appologies to Akkurat for goin' on and on against him. I was having a really bad week. I was completely wrong. I should really have kept quiet, that was not my place to go. Again, I'm terribly sorry.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-10-19 22:36:18
audio20, it was a bit heated conversation but I don't think that it would warrant an apology, not that I don't appreciate the gesture, thanks. I'm really sorry that I didn't act like a "mature adult" there, I was a bit angry then. No harm done, it's in the past (I even had to check it out what it was all about.. I had forgotten it already), now is now, welcome back.

Sorry for this OT. I wanted to answer in public.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-20 13:19:18
...appreciate the gesture, thanks...No harm done, it's in the past
Thanks, Akkurat, good to know, I am really pleased to hear that. 

I was talking to a doctor today about BMI (Body Mass Index), about how diffent factors can affect it and, strangely enough, I remembered how the covers were sorted in AAD.

As it is now, I think AAD use the pure numbers from width and height to sort the covers, and even an image with 600x300px will get sorted before one with 598x600px.

So, I correlated it, thinking that the program could use the area of the image insted of the "width first, height second" approach to sorting. By using the numbers derived from the area calculation, all the "almost equal" results will get sorted right next to it's similar image (e.g. a 600x600px image will be followed by a 598x600, instead of being followed by a number of other images with 600px width, like 600x534, 600x545, etc).

I really think this sorting method would be better. I would really like to hear Alex's and anybody else's thoughts on that.
Title: Album Art Downloader XUI
Post by: sle118 on 2009-10-22 16:04:49
Hello all,

I live in the Quebec province, in Canada, and often buy CDs from artists that are well known here. I created a script that gets cover art from the Archambault online store, which typically finds the best matches for me (I buy from their brick and mortar shops).

There is a single problem that I am unsure how to fix.  Results sometimes include "accents" and for some reason the downloader does not seem to use the correct code page to display them.

This is my first attempt at a script, feel free to comment.

Code: [Select]
import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util

class Archambault(AlbumArtDownloader.Scripts.IScript):
Name as string:
get: return "Archambault"
Version as string:
get: return "0.1"
Author as string:
get: return "Sebastien Leclerc"

def Search(artist as string, album as string, results as IScriptResults):


resultsPage = GetPage(GetPageStream("http://www.archambault.ca/qmi/search/SearchResults.jsp?hierarchicalCategoryId=ACH&search=${EncodeUrl(artist)}&searchSubmit.x=0&searchSubmit.y=0", null, true))

resultsRegex = Regex("div\\s[^>]*class=\"browseListItem\"[^>]*>.*?\\ssrc\\s*=\\s*\"(?<image>http://storage[^=]*=?)(?<picsize>[1-9]*x[^&]+)(?<imageparm>[^\"]*?)\".*?<div\\s[^>]*class\\s*=\\s*\"description[^=]*<a\\s*href\\s*=\\s*\"(?<url>[^\"]+)[^>]*>(?<title>[^<]+)", RegexOptions.Singleline | RegexOptions.IgnoreCase)
resultsMatches = resultsRegex.Matches(resultsPage)

results.EstimatedCount = resultsMatches.Count;

for resultsMatch as Match in resultsMatches:
  image = resultsMatch.Groups["image"].Value;
  picsize = resultsMatch.Groups["picsize"].Value;
  imageparm = resultsMatch.Groups["imageparm"].Value;
  url = "http://www.archambault.ca"+resultsMatch.Groups["url"].Value;
  title = resultsMatch.Groups["title"].Value;
  results.Add(image+"1500x1500"+imageparm, "${title}", url, -1, -1, image , CoverType.Front);

def RetrieveFullSizeImage(fullSizeCallbackParameter):
return fullSizeCallbackParameter

Title: Album Art Downloader XUI
Post by: sle118 on 2009-10-23 14:37:31
Hello again,

Below is a script for a popular music store in Canada.  I tried my best to make it work but I can't find the error. The search string is correct, and I did validate the regex in a test tool using the search result page.

Can anyone please help?

Code: [Select]
import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util

class HMVCanada(AlbumArtDownloader.Scripts.IScript):
Name as string:
get: return "HMV Canada"
Version as string:
get: return "0.1"
Author as string:
get: return "Sebastien Leclerc"

def Search(artist as string, album as string, results as IScriptResults):

searchParameter as string = "${artist}".Trim()+" ${album}".Trim().Replace(" ","+")
resultsPage = GetPage(GetPageStream("http://www.hmv.ca/Search.aspx?keyword=${searchParameter}", null, true))
resultsRegex = Regex("div\\s*[^>]*class='chartItemImage'[^>]*>.*?\\ssrc\\s*=\\s*'(?<path>(/(?!sm)\\w+)+/)small/(?<filename>[^']*)(?:[^>]*>){1,5}[^\\s]*\\s*href\\s*='(?<url>/Products/Detail/[^']*)[^>]+>(?<title>[^<]*)[^?]+[^>]+>(?<artist>[^<]*)", RegexOptions.Singleline | RegexOptions.IgnoreCase)
resultsMatches = resultsRegex.Matches(resultsPage)

results.EstimatedCount = resultsMatches.Count;

for resultsMatch as Match in resultsMatches:
  loc= "http://www.hmv.ca"+resultsMatch.Groups["path"].Value;
  filename = resultsMatch.Groups["filename"].Value;
  title = resultsMatch.Groups["title"].Value;
  url = "http://www.hmv.ca"+resultsMatch.Groups["url"].Value;
  artistname = resultsMatch.Groups["artist"].Value;
 
  results.Add("${loc}large/${filename}", "${artistname} - ${title}", url, -1, -1, "${loc}large/${filename}" , CoverType.Front);

def RetrieveFullSizeImage(fullSizeCallbackParameter):
return fullSizeCallbackParameter

Title: Album Art Downloader XUI
Post by: uZi on 2009-10-24 11:42:36
I got AAD constantly crashing when I does File Browser (CTRL+B)

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.31.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Reflection.TargetInvocationException: Une exception a été levée par la cible d'un appel. ---> System.InvalidOperationException: Impossible de trouver l'élément supprimé.
  à System.Windows.Controls.ItemContainerGenerator.GetBlockAndPosition(Object item, Boolean deletedFromItems, GeneratorPosition& position, ItemBlock& block, Int32& offsetFromBlockStart, Int32& correctIndex)
  à System.Windows.Controls.ItemContainerGenerator.GetBlockAndPosition(Object item, Int32 itemIndex, Boolean deletedFromItems, GeneratorPosition& position, ItemBlock& block, Int32& offsetFromBlockStart, Int32& correctIndex)
  à System.Windows.Controls.ItemContainerGenerator.OnItemRemoved(Object item, Int32 itemIndex)
  à System.Windows.Controls.ItemContainerGenerator.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
  à System.Windows.Controls.ItemContainerGenerator.System.Windows.IWeakEventListener.ReceiveWeakEvent(Ty
pe managerType, Object sender, EventArgs e)
  à System.Windows.WeakEventManager.DeliverEventToList(Object sender, EventArgs args, ListenerList list)
  à System.Windows.WeakEventManager.DeliverEvent(Object sender, EventArgs args)
  à System.Collections.Specialized.CollectionChangedEventManager.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
  à System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
  à System.Windows.Data.CollectionView.OnCollectionChanged(NotifyCollectionChangedEventArgs args)
  à System.Windows.Controls.ItemCollection.System.Windows.IWeakEventListener.ReceiveWeakEvent(Type managerType, Object sender, EventArgs e)
  à System.Windows.WeakEventManager.DeliverEventToList(Object sender, EventArgs args, ListenerList list)
  à System.Windows.WeakEventManager.DeliverEvent(Object sender, EventArgs args)
  à System.Collections.Specialized.CollectionChangedEventManager.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
  à System.Windows.Data.CollectionView.OnCollectionChanged(NotifyCollectionChangedEventArgs args)
  à System.Windows.Data.ListCollectionView.ProcessCollectionChangedWithAdjustedIndex(NotifyCollectionCha
ngedEventArgs args, Int32 adjustedOldIndex, Int32 adjustedNewIndex)
  à System.Windows.Data.ListCollectionView.ProcessCollectionChanged(NotifyCollectionChangedEventArgs args)
  à System.Windows.Data.CollectionView.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
  à System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
  à AlbumArtDownloader.ObservableAlbumCollection.RaiseCollectionChanged(NotifyCollectionChangedEventArgs e)
  à AlbumArtDownloader.ObservableAlbumCollection.Remove(Album album)
  à AlbumArtDownloader.FileBrowser.<>c__DisplayClass12.<DetectVariousArtistsAlbums>b__e()
  --- Fin de la trace de la pile d'exception interne ---
  à System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  à System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  à System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  à System.Delegate.DynamicInvokeImpl(Object[] args)
  à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.DispatcherOperation.InvokeImpl()
  à System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  à System.Threading.ExecutionContext.runTryCode(Object userData)
  à System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  à System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  à System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  à System.Windows.Threading.DispatcherOperation.Invoke()
  à System.Windows.Threading.Dispatcher.ProcessQueue()
  à System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  à MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  à MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  à System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  à MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  à MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  à System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  à System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  à System.Windows.Threading.Dispatcher.Run()
  à System.Windows.Application.RunDispatcher(Object ignore)
  à System.Windows.Application.RunInternal(Window window)
  à System.Windows.Application.Run(Window window)
  à System.Windows.Application.Run()
  à AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  à AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  à AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-26 12:22:51
Hello all, sorry it's been a long time since I've posted. Let me answer some posts here:

Maybe you could consider lowering the Medium band limit to something like 520

520 instead of 540? Will that really make a big difference?

Is there any way you could strip those characters ( & and : ) from the search strings you get from the queue?
The only problem I have with this is that if a source did make good use of those, they would then not be available any more. I'd really rather not throw away data if I don't have to. A better idea would be to modify the scripts of sources which work better without those characters to strip them before sending the query to the server. To do that, I'd have to do a survey of each site, testing which one works better with the characters removed, and which with them left in.

Is there any way to configure the program to search and put the images on the 1st folder?
Tricky, as it would have to know which the 'first' folder is. Alphabetically would probably be best, but it would then have to find every folder to check which was the first, rather than just taking the first matching result. I'll think about it, see if there is any good way of handling it. Otherwise, there's already a feature request to save multiple copies of the result in all sub folders. I haven't come up with a good idea for that either yet.

the program could use the area of the image insted of the "width first, height second" approach to sorting.
The problem with this is that the area isn't obvious, you probably won't be able to tell why an image was sorted or grouped where it was, and it will just look wrong. It's important that things appear to be sorted in the correct order. I could, of course, add an "Area" label somewhere, but that would just be weird. Most covers are at least reasonably square, so I don't think this is a big issue.


This is my first attempt at a script, feel free to comment.
Thank you for the script, sle118! Can I suggest you add the album title to the search string too? To fix the accent thing, encode the Url as IsoLatin1 (as archambault uses this encoding).

How about:
Code: [Select]
resultsPage = GetPage("http://www.archambault.ca/qmi/search/SearchResults.jsp?hierarchicalCategoryId=ACH400000000000&search=" + EncodeUrlIsoLatin1(artist + " " + album))


For the HMV Canada one, it seems to me that the search functionality on that website only seems to allow searching by either artist or album, but if I put in both artist and album, it never returns any results for me. I suppose the script could search for just album name, but it's not ideal. Also, your regex seems slightly off, try adding
Code: [Select]
[^']*?
before
Code: [Select]
(?<url>/Products/Detail/


One trick I use to help debug this stuff is to write out the page as actually downloaded, using:
Code: [Select]
System.IO.File.WriteAllText("hmvcanada.log", resultsPage)
just after the GetPage line.

Once you have them working, may I add your scripts to the Online Updates service, so they appear automatically when Get More Scripts is clicked?

I got AAD constantly crashing when I does File Browser
Thanks for reporting this. Could you please see if you can track it down to a specific album or folder causing the problem? It is something to do with the various artists detection, but I don't see exactly why it is occurring.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: sle118 on 2009-10-26 13:34:48
This is my first attempt at a script, feel free to comment.
Thank you for the script, sle118! Can I suggest you add the album title to the search string too? To fix the accent thing, encode the Url as IsoLatin1 (as archambault uses this encoding).

How about:
Code: [Select]
resultsPage = GetPage("http://www.archambault.ca/qmi/search/SearchResults.jsp?hierarchicalCategoryId=ACH400000000000&search=" + EncodeUrlIsoLatin1(artist + " " + album))



This fixed the search part. So searching for "12 hommes rapaillés" returns the same as "12 hommes rapailles". Now the problem is that the result page returns "12 hommes rapaill&eacutes", with encoded accents. This is just an annoyance and does not prevent the album art to be downloaded, but I would like to understand how to decode these accents in the final string.

For the HMV Canada one, it seems to me that the search functionality on that website only seems to allow searching by either artist or album, but if I put in both artist and album, it never returns any results for me. I suppose the script could search for just album name, but it's not ideal. Also, your regex seems slightly off, try adding
Code: [Select]
[^']*?
before
Code: [Select]
(?<url>/Products/Detail/


You rock! This fixed the issue right away. I am surprised though that my regex was actually working in tests.

One trick I use to help debug this stuff is to write out the page as actually downloaded, using:
Code: [Select]
System.IO.File.WriteAllText("hmvcanada.log", resultsPage)
just after the GetPage line.


Very helpful indeed.

Once you have them working, may I add your scripts to the Online Updates service, so they appear automatically when Get More Scripts is clicked?


Please do so.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-26 14:04:03
the problem is that the result page returns "12 hommes rapaill&eacutes", with encoded accents.
Have you tried running the title through System.Web.HttpUtility.HtmlDecode (http://msdn.microsoft.com/en-us/library/7c5fyk1k.aspx)? that will probably do the trick.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-26 18:36:42
Hi, Alex,
thank you for all the replies. It is very much appreciated. 

520 instead of 540? Will that really make a big difference?

Oh, yes, most definitely. All the 600px wide covers will probably be bumped into the Medium Band (were they actually belong).

Quote
...strip those characters ( & and : ) from the search strings...
The only problem I have with this is that if a source did make good use of those...rather not throw away data...

I completely undestand...
Only thing I can say is that I tested this on all the sources that I use (all minus 8 or 9) for almost 200 albums. I can say with confidence that whenever these characters don't actually prevent the source from giving good results, stripping them from the input string does not affect the outcome (they still give the same results as before). Resuming, I was pretty convinced that they could be considered "unnecessary".

Quote
A better idea would be to modify the scripts of sources which work better without those characters to strip them before sending the query to the server. To do that, I'd have to do a survey of each site, testing which one works better with the characters removed, and which with them left in.

That is a great idea! I will try to do that (one source at a time).
(I think you might have already too much work on your hands as it is, this seams too much extra work for you to do it)

Quote
...configure the program to search and put the images on the 1st folder...
Tricky, as it would have to know which the 'first' folder is.

I see.. Indeed.

Quote
Alphabetically would probably be best, but it would then have to find every folder to check which was the first, rather than just taking the first matching result.

May I ask how is it done today? (if it is not too much trouble)
It seams to me that the program takes the last folder result from the "File Browser", whenever it encounters albums with the exact same name (which is the case with multiple-CDs albums), as if it just goes with the last parameter it encounters for that album.
If that was the case, I was just wandering if the program could stick to the first parameter it encounters (the first folder) instead. If it will give the program too much trouble to inspect and figure out which is the first folder, maybe it's not worth it...

Quote
I'll think about it, see if there is any good way of handling it. Otherwise, there's already a feature request to save multiple copies of the result in all sub folders. I haven't come up with a good idea for that either yet.

You're absolutely right. It won't be easy to figure this out, specially because each person will adopt their own organizing and naming scheme for their folders (there won't be a universal logic to it, probably).
I agree that storing in all folders would be a good idea, though.

Quote
...the program could use the area of the image insted...
The problem with this is that the area isn't obvious, you probably won't be able to tell why an image was sorted or grouped where it was, and it will just look wrong. It's important that things appear to be sorted in the correct order.

I get it... You're absolutely right (gotta think about the average user first). It could never be the default configuration, it would indeed confuse a lot of people.

Although I agree with the not obvious part and not with the look wrong part...

You could make an experiment and sort a set of images by area (or "combined dimentions"  ), you'll see it looks completely logical and natural, specially if you look only at the 'size' of the image and don't get caught in the pure numbers of width and height.

(It's just like telling someone is obese considering only their weight - pure numbers won't do the trick. If you want 'bigger' images you should consider both parameters simultaneously)

I should point out that I am only thinking about correcting one annoying side effect of the current "sort by: Size" scheme:
Images that are almost identical (but sometimes have better jpeg quality, or sothing else) and lack only 1 or 2 pixels in their width from their counterparts are always sorted "far away", making it more difficult to compare and sometimes even to realize they are similar images as further appart they are sorted.

That's why I wish we had this extra sorting option.

Quote
I could, of course, add an "Area" label somewhere, but that would just be weird. Most covers are at least reasonably square, so I don't think this is a big issue.

I got it now. I might not have made myself very clear then... I don't really need to know the area value (ever! it would be weird indeed), it would only serve for sorting purposes. Images with more area are, literally, bigger, and should be sorted first.

Maybe you could add a Sort by: 'Area' option for 'weirdoes' (like me  ) that think it's more logical to have the images sorted that way (because size is always relative and more directly connected with the area - an image with 598x600 is bigger than one with 600x300).
Title: Album Art Downloader XUI
Post by: mobyduck on 2009-10-27 07:55:08
Maybe you could add a Sort by: 'Area' option for 'weirdoes' (like me  ) that think it's more logical to have the images sorted that way (because size is always relative and more directly connected with the area - an image with 598x600 is bigger than one with 600x300).
Add me to the weirdoes group.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-27 08:07:59
Quote
May I ask how is it done today? (if it is not too much trouble)
First, albums are added in the order that their files are returned by FindNextFile (http://msdn.microsoft.com/en-us/library/aa364428%28VS.85%29.aspx). For NTFS this is usually, but not guaranteed to be, alphabetical. The first file (or folder, if path matching against a folder pattern) found has an Album entry created for it, whose path points to where it was found. Subsequent files or folders which have the same Artist and Album information are ignored.

Once all albums have been added (but not necessarily had existing art searched for yet, that's slower and runs in the background), then a second pass is done to find Various Artists albums. A list is produced of all albums which share the same folder and album name, but different artist names. For each folder like this, all album entries are removed and a new Various Artists album is added with the Album name and path of the first one. Incidentally, this is where uZi's crash is occurring, but I haven't been able to reproduce the problem or figure out why it happened yet.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-27 08:13:09
Maybe you could add a Sort by: 'Area' option for 'weirdoes' (like me  ) that think it's more logical to have the images sorted that way (because size is always relative and more directly connected with the area - an image with 598x600 is bigger than one with 600x300).
Add me to the weirdoes group.

Alessandro

Fine, I've put it up as a Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2886966&group_id=187008&atid=919578). Hopefully no-one will be too confused by seeing "Area" in the sort-by list, if they don't understand what it means.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-27 15:40:19
Hi, Alex,
thank you so much for detailing the process for us. I fully understand it now. I promise I will stop bothering you with this particular issue.
First, albums are added in the order that their files are returned by FindNextFile (http://msdn.microsoft.com/en-us/library/aa364428%28VS.85%29.aspx). For NTFS this is usually, but not guaranteed to be, alphabetical. The first file (or folder, if path matching against a folder pattern) found has an Album entry created for it, whose path points to where it was found. Subsequent files or folders which have the same Artist and Album information are ignored.

Once all albums have been added (but not necessarily had existing art searched for yet, that's slower and runs in the background), then a second pass is done to find Various Artists albums. A list is produced of all albums which share the same folder and album name, but different artist names. For each folder like this, all album entries are removed and a new Various Artists album is added with the Album name and path of the first one.

Very interesting! It's more complex than I thought it would be...

I wouldn't figure out that part about the Various Artists albums in a million years...
I thought the program was getting it from the "Album Artist" field from the iD3v2 tag.
(I always tidy my tags before scanning the folders - and it shows Various Artists there)

Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-27 15:41:26
...sort by: 'Area' option...
Fine, I've put it up as a Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2886966&group_id=187008&atid=919578). Hopefully no-one will be too confused by seeing "Area" in the sort-by list, if they don't understand what it means.

  I know what you mean... 
Maybe you could use the same convention Cerious Thumbs Plus (http://www.cerious.com/) uses: sort by "dimentions".
And you can always remove that feature later if you find out it causes too much confusion. (I hope it doesn't, though...)

And thank you so much for putting up with our "wierdness"... 
You definitely didn't had to, but it is very nice of you to do so.  Thanks again.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-10-27 16:06:14
cover-paradies.boo:
Code: [Select]
System.IO.File.WriteAllText("cover-paradies.log", searchResults)


Hopefully no-one will be too confused by seeing "Area" in the sort-by list, if they don't understand what it means.

Ideally a software is self-explanatory but that's really hard to achieve. Manual is the answer.  I haven't put much thought to the "area" idea but it sounds like a good idea.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-27 17:07:46
I've just (finally) followed the "feature request" feature to SourceForge. Nice system!

There is one specific open request there that also interest me very much:
Quote
Add ability to remove results from the list manually = Ability to delete results by pressing an x icon or something. -
minor issue (This is useful when there vast amounts are obviously incorrect matches as well as a lot of possibly correct ones)

I completely agree and would love this one.
Not only for this reason stated, but also because it would allow us to "refine" the displayed results until we reach the best image intended, by eliminating from the view those images we have alredy compared and don't intend to keep (or compare again against the other results). This could prevent the oh-so-common confusion "did I check (zoom in on) this one already?".

On the same subject (refining and inspecting the results), I've been using the new version of Foxit PDF Reader and they have a relatively new "Magnifier" Tool that I think would be absolutely wonderful to have in AAD, maybe in the future (I know this would be a lot of work).
(http://i35.tinypic.com/65s55h.png) + (http://i35.tinypic.com/1s1hyq.png)
Simple Magnifying + Left Click Extra magnifying (with decay)

I'm very very picky about the images that I would like to choose, specially when there are many similar results. I always like to compare the image size, jpeg compression quality (for as few as possible artifacts in the image), etc, etc.

I usually use the preview option (which is great to have) in AAD for the first round of eliminations. I wonder if (also sometime in the future) it would be possible to specify the zoom level of the preview and the maximum window size for this preview 'window'.

I would like to have the zoom level option because it is very hard to compare and actually see all the image defects and artifacts at 100% zoom, and the maximum size option would be because sometimes the image is so large it fills the whole screen and it's kind of overwhelming (it would be nice to limit that "in you face" effect).

P.S.: I figured that images (specially from Google) that you try to preview and they do not exist anymore already "vanish" from the program interface, so maybe the small "x" icon (just like the "i" icon for page information) that wold have the same effect might not be a huge jump to implement.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-27 17:36:06
Have you tried the persistent preview window? It sounds like it would do most of what you are asking for. Right click on a result and choose Preview. OK, so it doesn't have a fancy picture of a magnifying glass like Foxit, but should be functional enough.

Akkurat, thanks for the heads-up on the cover-paradies script, I'll make sure that's gone the next time it's updated, oops!

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-10-27 18:07:30
I figured that images (specially from Google) that you try to preview and they do not exist anymore already "vanish" from the program interface

I think that that happens because the initial fetched/reported size isn't right. The actual image size is smaller and your filter makes it "vanish". I've seen this too.

I'll make sure that's gone the next time it's updated, oops!

Hmm, so you're not going to fix it until there are other updates to that script? Now it's crapping, if you allow the expression , text files all over users directories.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-27 18:28:02
Have you tried the persistent preview window?

I did not know of this window yet...   
That is great! It will serve me really well.

Quote
It sounds like it would do most of what you are asking for....doesn't have a fancy picture of a magnifying glass like Foxit, but should be functional enough.

Indeed it does!!  (I have no need for the fancy magnifying glass either, I was just exemplifying)

Still, the simple preview (left click on image) is the way to go when the number of images to check is high (more than 10 or so). It is very well designed - fast, slick and simple.
I guess there is no chance to specify the zoom level on this simple preview (to 200% for example), not even in the future? (I understand this feature is already covered by the persistent window, but I'm talking about the case when there is too many images to check)

Or maybe the behaviour of this "persistent window" could be modified in a way that it would be really "persistent" (retain size, position and zoom level) and show whichever image we click on the main interface window (is that even possible??).
(I'm guessing that's not really the disirable behaviour because this way it would prevent a "side by side" comparison of 2 images...)
(...but maybe then there could be a "stick pin" icon option on the top bar or something to make the window 'reusable' and use the very same persistent window with it's settings for all image previews)

Please bear in mind that I'm not complaining (at all!). I did love discovering this "persistent" window. Thank you for that!   
Title: Album Art Downloader XUI
Post by: mobyduck on 2009-10-27 18:31:47
And thank you so much for putting up with our "wierdness"... 
You definitely didn't had to, but it is very nice of you to do so.  Thanks again.
Many thanks from me as well... I wish more products had a comparable customer service!

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-27 18:41:13
Now it's crapping, if you allow the expression , text files all over users directories.
Well, one small text file, in the Album Art Downloader program folder. Something which it's probably been doing for a long time - I don't know when that line crept in. On balance, I figured it was less annoying to leave it than to trigger an unnecessary script update for everyone.

I can't see how zoom would work for the pop-up previews. As soon as you take your finger off the mouse button, it closes, so you can't click any sort of zooming control. I suppose you could (if dexterous enough) use the scroll wheel, but I'm not sure that would ever get used! In any case, it still wouldn't cover side-by-side comparison, as you can only ever have one pop-up open at a time.

For detailed side by side comparison, the persistent preview window is definitely the way to go. I think the stick pin option is too complicated, but if I think of any good simple ideas to match the workflow you're describing, I'll get back to you.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-10-27 19:28:52
Well, one small text file, in the Album Art Downloader program folder.
Nope! In my "save images to" folder too. That's why I spotted this. Never seen that happen before. Tried to reproduce, can't. But AFAIK, the user can't decide where the log file is saved. So, there must be a code path in your code which made AAD suddenly save the log file to "save images to" setting folder. "Current working directory" thing?

There's actually an older cover-paradies.log file in the program folder created on 16th day, updated today (searched something today).

EDIT: steps to reproduce:

1) open AAD and search something

= a log file is created in the program folder

2) save an image
3) save the same image again, don't replace the existing (this happens when saving more than one same size file from same source.. not enough distinguishing "tags" to use.. e.g. I've "path"\%name%%preset%___%type%___%size%___%source%.%extension%)
4) alter the filename and save
5) search something else

= a log file is created in the folder where the you saved the image in step 3.

So it was "Current working directory" what made this. Corrected by making sure that every file write has a folder path as well..?
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-27 19:30:48
Quote
...how zoom would work for the pop-up previews...can't click any sort of zooming control...
Absolutely. And, more than that, any icon or something else present in that window would "kill" it's marvellows simplicity.

Quote
...you could (if dexterous enough) use the scroll wheel...

Can I? Can I? Please?!!       
I wold absolutely love that! (just hold the left click and use the middle finger to zoom in with the mouse wheel - that would be incredible!)

Quote
but I'm not sure that would ever get used!
Oh...    You got me on that one. 
Anyway, if I can count myself in that one, it wold get used yeah (in absolute terms), at least once a week...

Quote
...still wouldn't cover side-by-side comparison, as you can only ever have one pop-up open at a time.
Indeed, but I really don't do much side by side (but I'm guessing other people do, so that couldn't be taken away from the current program features).
I prefer to just inspect one image at a time; I usually find out that some of the bigger images tend to lack quality when closely inspected.

Quote
...the stick pin option is too complicated, but if I think of any good simple ideas to match the workflow you're describing, I'll get back to you.

Thank you for even considering it. 
I agree. It's too complicated. Definitely not the way to go.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-27 21:38:45
Nope! In my "save images to" folder too.
Oh dear, in that case yes, it is more serious. I've pushed out an update now.

(just hold the left click and use the middle finger to zoom in with the mouse wheel - that would be incredible!)
It's a possibility. It shouldn't get in the way of people who don't want to use it, so I don't have any strong objection to it. The only concern I have is how to pan. Zooming would be fine, but zooming only into the middle of the image might be a bit limiting. I could have it grow the preview window size (within limits of the screen) as you zoomed in, but you can't drag the mouse to the point on the image you want to zoom to, as dragging starts a drag out of the image file to be able to drop it into explorer...
Title: Album Art Downloader XUI
Post by: Ev!L-aLphA on 2009-10-27 22:22:23
Hey guys, sorry to sway this a little off topic, but i just recently did the jump from itunes/winamp to foobar (which i should of done years ago, but it was too complex at the time)...
anyways i got a great theme going, and when album art is present it makes it much more pleasant to the eyes....

now i read a few things about getting foobar to automatically download album art to the albums folder without the need to go find the folder each time i want to download specific art for it... i tried searching how to get AAD to work through foobar, but came out unsuccessful..

what i did,
downloaded latest foo_run and AAD
added - C:\Program Files (x86)\AlbumArtDownloader\AlbumArt.exe "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)cover.jpg   to my run services, and i tried running it but nothing happens, aad doesnt open and when it is open it doesn't respond to my requests!

i would appreciate if i can get some input on this!
thanks a ton
Title: Album Art Downloader XUI
Post by: wolfsong on 2009-10-28 00:27:24
Are presets and group by not available as command line options?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-28 07:52:16
i would appreciate if i can get some input on this!
For foo_run you need to escape the ( and ) characters, so you should use: "C:\Program Files '('x86')'\AlbumArtDownloader\AlbumArt.exe"

Are presets and group by not available as command line options?
Group by isn't currently available from the command line. It should be, and I'll add that in a future version. For presets, I'm not sure what you are after, could you describe what you're trying to achieve?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-29 13:55:09
Image Zooming

It occurs to me, from what audio20 has been saying, that zooming in to the images is probably mostly done to check for blemishes or other small imperfections. To that end, I suspect it will be more helpful to zoom in using a pixel-perfect scaling algorithm, rather than one that attempts to make a non-blocky enlarged image. The current zoom (in the Preview window) uses the Fant scaling algorithm, like the Windows Preview window. This produces a nice enlarged image, but is probably less useful for checking for blemishes. To illustrate the difference:

(http://www.byalexv.co.uk/temp/example-fant.jpg) (http://www.byalexv.co.uk/temp/example-pixel.jpg)

These two images are the same 80*80 bit of a cover, zoomed in 500%. On the left is how it is currently displayed, and on the right is the pixel-perfect scaling (discounting any jpg artefacts). Obviously the one on the left looks much better, but if what you want is not to look at a pretty picture, but to check the image for flaws, it might be more useful.

Any thoughts, anyone? Do you use zooming in for anything other than checking for image blemishes? Do you prefer the current Fant scaling for any other reason?

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-30 01:51:30
Image Zooming
...zooming...to check for blemishes...small imperfections...more helpful...using a pixel-perfect scaling algorithm, rather than one that attempts to make a non-blocky enlarged image.

Hi, Alex,
I'm really excited about this feature and I think it would really help me and I'll try to illustrate it:
(http://i33.tinypic.com/2ld96dy.png)

As you can see, at 100% zoom you can't really see the image artifacts that form around the letters (for instance); and most image defects could go unnoticed. Images with jpeg quality factor of 100 or 85 or 70 seam to be virtually equal at this zoom.

At 200% you already see the artifacts and that kind of zoom could be quite enough, specially taking into consideration that AAD main purpose isn't really to help you edit your images, but select them. This zoom should be enough for us to be able to distinguish one image from another when there are many similar results from various sources.

At 300% it is definitely easy to spot any kind of defects and the zooming does not need to go beyond that (in my opinion - feel free to disagree with me).

Quote
...current zoom uses the Fant scaling...produces a nice enlarged image...less useful for checking for blemishes...the one on the left looks much better, but if what you want is not to look at a pretty picture, but to check the image for flaws, it might be more useful.

Absolutely. The pixel-scaling ("nearest neighbour"-like/preserve hard edges) seams a lot more useful for this kind of job, in my opinion.

Quote
Do you use zooming in for anything other than checking for image blemishes?

Is it possible that we could keep the one (Fant) being used in the 'preview window' and use the new (Pixel) for zooming in the main window previews? (or the controls are the same and must be equal in both kinds of window?)
I must point out that I would be very happy with either one of the algorithms, and just being able to use zoom capabilities in the preview from the main window will be terrific!

I was also thinking about the usability of the zoom in the preview from main window, and the wheel is quite fine for me, but it could be awkward for some people. I noticed that you get the regular context menu in this window [Preview/Copy/Save/Save as]. My opinion is that this is kind of pointless, since this is a fast-engaging preview (quick on/quick off) and it is very unlikely that you want to do anything else other than "preview" the image when you're in this window.

I also noticed that the wheel behaviour probably will have to be modified to be exclusive to this window, as today the wheel still controls the up/down scrolling of the main window, even in "preview mode". So, I though it could be very useful (and quite easier to engage) to also modify the right click in this specific window (which would actually be a simultaneous left+right click) to zoom in by a fixed value (I was thinking about 200%), instead of havind the regular context menu.

(http://i36.tinypic.com/2zefr5e.jpg)
Title: Album Art Downloader XUI
Post by: extrabigmehdi on 2009-10-30 02:55:25
@AlexVallat
Quote
The current zoom (in the Preview window) uses the Fant scaling algorithm, like the Windows Preview window. This produces a nice enlarged image, but is probably less useful for checking for blemishes.


I've never heard about "fant scaling" . Anyways, if your scaling algorithm is a bit blurry, it is normal that you don't see "imperfections" when zooming.
Try with catmull-rom (one kind of bicubic) or lanczos.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-30 08:13:04
zooming does not need to go beyond [300%]
I agree, but don't think there's much point in restricting it. If you keep on pressing zoom in, or keep using the scroll wheel, presumably for some reason you do want to keep zooming in.

The pixel-scaling ("nearest neighbour"-like/preserve hard edges) seams a lot more useful for this kind of job, in my opinion.
Thanks, that's what I figured, but I want to get as much feedback as possible before implementing a potentially unwanted change like that.

Is it possible that we could keep the one (Fant) being used in the 'preview window' and use the new (Pixel) for zooming in the main window previews?
Possible, but I don't want to. There should be no functionality that can only be accessed through the popup preview, it's for convenience only.

I though it could be very useful [to] simultaneous left+right click) to zoom in by a fixed value
I don't like this. A chorded Left+Right click, even when not reassigned to middle click (as is usually the case in two button mice or trackpads), is just not something anyone would associate with zoom. At least the scroll wheel is sometimes used for that.

Anyways, if your scaling algorithm is a bit blurry, it is normal that you don't see "imperfections" when zooming. Try with catmull-rom (one kind of bicubic) or lanczos.
No, I'd never heard of it either, but it's what Microsoft call it. Anyway, you'd see similar issues with lanczos or bicubic, the question really is do we want a scaling algorithm that tries to make the enlarged image smooth and pretty (Fant, lanczos, bicubic, or similar), or one which leaves the pixels exactly as they are, for inspection (nearest-neighbour).

So far, it's looking like nearest-neighbour is more useful in this case, but I'm still open to opposing arguments.

Alex
Title: Album Art Downloader XUI
Post by: extrabigmehdi on 2009-10-30 13:00:53
@AlexVallat
Quote
the question really is do we want a scaling algorithm that tries to make the enlarged image smooth and pretty (Fant, lanczos, bicubic, or similar), or one which leaves the pixels exactly as they are, for inspection (nearest-neighbour).

It's not more smooth or pretty, but more accurate than your fant scaling .  Both lanczos, and catmull-rom could be considered as an "approximation" , of the ideal case of sinc function (http://en.wikipedia.org/wiki/Sinc_function).
Anyway I've done lot of experiments with scaling algorithms,  and I can just tell, that you can make  a better compromise between the "fant scaling",
and just plain nearest-neighbour .  Now if it's not supported by Microsoft, or it requires time to implement that, then that's an other question.



Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-30 13:26:05
It's not more smooth or pretty, but more accurate than your fant scaling.
I'm no sure what you mean by accurate, here. There are really only two classes of algorithm for enlarging (reducing is a different matter, and not under discussion here). You can either just draw bigger pixels (nearest neighbour), which gives you a blocky image, but does let you see exactly what the pixels in the image are. Or, you can try and produce an enlargement that looks like the original picture, but bigger (and not blocky). From what I've tried, Fant, lanczos, bicubic and bilinear all fall into this category. I wasn't able to try Catmull-rom, but I assume it does something similar. Arguments can certainly be made about which produces the nicer looking enlargement, but it's not really what I'm concerned about at the moment - it's a more fundamental thing of should it even be trying to make it look good, as opposed to showing exactly the pixels that are present in the image.
Title: Album Art Downloader XUI
Post by: extrabigmehdi on 2009-10-30 14:31:06
@AlexVallat
Quote
I'm no sure what you mean by accurate, here.

Well, my knowledge regarding  Fourier theory is limited , but the sinc function (and
approximations of it)  are inspired by  it. The word "accurate" can vary depending of the  criteria you use
, however in my case this would mean better preservation of details, or "better frequency response".

They are lot of study/theory , regarding reconstruction filters (http://en.wikipedia.org/wiki/Reconstruction_filter) ,
but I'm talking from the point of view of my experiments.
Without complicating things, lanczos3 would provide more interesting results, I think than what you currently use.
The algorithm is fairly simple / open / documented. However it requires more cpu calculations.

I invite you to compare different results with different scaling algorithm ,
at this page, especially example of the clown:
http://www.general-cathexis.com/interpolation/index.html (http://www.general-cathexis.com/interpolation/index.html)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-30 15:08:45
I invite you to compare different results with different scaling algorithm ,
at this page, especially example of the clown:
http://www.general-cathexis.com/interpolation/index.html (http://www.general-cathexis.com/interpolation/index.html)
Thank you for that page, it is very interesting!

The two options I'm considering are either A) using an interpolation algorithm to produce a better enlarged picture, or B) using Box (nearest neighbour) to produce an enlarged view of the actual pixels comprising the picture.

The difference is, if you consider a very simple picture of a circle, when you use the Zoom functionality, are you looking for a bigger picture of that circle, or are you looking to inspect the picture of the circle *at that size* more closely. If you want a bigger picture of the circle, it should be smooth, and needs a good interpolation algorithm to achieve that. If you want a closer view of the picture itself, rather than of the circle, then you wouldn't want it interpolating new pixels, just drawing the original pixels bigger.

Separately to this, if we keep option A of producing a quality enlarged picture, there's the question of which would be the best interpolation algorithm to produce the best looking picture. I take your point that there may be better choices than the current Fant one, but given that the results aren't saved, and that this isn't the primary application used for viewing them, I don't think it's worth implementing one where it isn't normally available with the current imaging library.
Title: Album Art Downloader XUI
Post by: extrabigmehdi on 2009-10-30 15:58:30
@AlexVallat
Quote
If you want a closer view of the picture itself, rather than of the circle, then you wouldn't want it interpolating new pixels, just drawing the original pixels bigger.

I find personally easier to make a closer look to a picture using a good algorithm , rather than using plain nearest neighbor.
Unless of course , you just want to look  at each pixels.

Quote
I don't think it's worth implementing one where it isn't normally available with the current imaging library.

Perhaps. I've suggested lanczos or catmull-rom, because they are less complicated than other alternatives.
In fact they are two kind of scaling algorithm:  adaptive and non-adaptive.
The non-adaptive solutions use a fixed kernel;  and usually a "windowed sinc" solution, like lanczos is considered the best.
Then they are the adaptive solutions, that parse the image and try to reproduce sharper/more regular edges.
These lasts one are beyond the scope of what you are looking for.


Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-30 16:49:10
I find personally easier to make a closer look to a picture using a good algorithm, rather than using plain nearest neighbor.
OK, so for determining the quality of the image, in order to choose which result to use, you find it easier to use an interpolated enlargement rather than a nearest-neighbour blown-up pixel view.

So, that's one in favour of changing, and one against, so far. Anyone else? (see [a href='index.php?act=findpost&pid=664967']original post[/a] for details, if you haven't been following).
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-30 16:49:45
...beyond 300%...
I agree, but don't think there's much point in restricting it. If you keep on pressing zoom in, or keep using the scroll wheel, presumably for some reason you do want to keep zooming in.

Ok. I agree, but I think it kind of depends on the zoom stepping (how much more zoom will you get with each turn of the wheel - 5%? 10%? 50%?).

If it's too little stepping, it might take us too long to get to 200% or 300% zoom (and loose the whole "fast" concept associated with this preview).
Suppose that we wanted to reach 300% on a single wheel roll (aprox. 5 turns); If the stepping is 50%, we would go to 350%, which is more than enough for inspection, but if the stepping is 10%, we would go to 150%, which isn't quite enough, and it would require 3 more complete wheel rolls to get to the desired zooming factor of 300% (not as much fast and convenient).

Quote
...The pixel-scaling...
Thanks, that's what I figured, but I want to get as much feedback as possible before implementing a potentially unwanted change like that.

Yes, absolutely. I get it.
I didn't get it before that I was stating the obvious  (that my personal concern resides with inpecting the image rather than enlarging it). 

Quote
...Is it possible that we could keep the one...
Possible, but I don't want to. There should be no functionality that can only be accessed through the popup preview, it's for convenience only.
Ok. Fair enough. Makes perfect sense.

Quote
...simultaneous left+right click to zoom in...
I don't like this. A chorded Left+Right click, even when not reassigned to middle click (as is usually the case in two button mice or trackpads), is just not something anyone would associate with zoom. At least the scroll wheel is sometimes used for that.

Oh... You got me there. I wasn't even remembering the possibility of buttons reassignment... That functionality would be cool and very easy to use, but if it can't be universal, it just can't be. I get it.

Thanks again for even discussing all that with us, Alex. I appreciate it. 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-30 17:04:15
how much more zoom will you get with each turn of the wheel - 5%? 10%? 50%?
The plan is to use the same speed as the Preview window uses (if you hold down the Ctrl key, the wheel zooms it), so you can try it out now. If you want numbers, though, it's 1.3x / turn. So if you are at 100%, and scroll the wheel by one click, it should become 130%. The next click would be 1.3*130% = 169%.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-30 19:59:17
...how much more zoom will you get with each turn of the wheel...
The plan is to use the same speed as the Preview window uses (if you hold down the Ctrl key, the wheel zooms it), so you can try it out now. If you want numbers, though, it's 1.3x / turn. So if you are at 100%, and scroll the wheel by one click, it should become 130%. The next click would be 1.3*130% = 169%.

Oh, I see... Thanks for the information! It's very clear now.
(I had already used it, but the zooming values were a little bit confusing for me, I hadn't figured out it was a "geometric" progression)

I don't mean to be disrespectuful in any way, and please forgive me for saying this, but don't you think a more "arithmetic" progression would be better?
(instead of going from 100% to 130%,169%,220%,286%,371%,483% we could go to 125%,150%,175%,200%,225%,250%)

Although in the "geometric" progression you reach a higher zooming factor much faster, in my experience those "round" (integer, 50% multiples) zooming factors are always better to work with (probably because they are easier to interpolate, they always result in a more precise, better image).

Another point (that I mentioned earlier) is that there isn't really much probability that people will need to reach those higher zooming factors (above 400%, etc) so often. So, I don't think there is much need to climb so fast in the zooming scale (not to mention that you might loose the oportunity of reaching much more useful lower-values zooming factors this way - by stepping over them).

I think that a fixed progression of 25% could be ideal; It is not too slow to reach higher zooming factors, but not too fast either. You pass a lot of 'good-looking' zooming factors in your way up and it is easier to mentally associate those fixed steps with each wheel turn.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-10-30 22:42:25
don't you think a more "arithmetic" progression would be better?
No, I'm pretty sure a geometric progression is better. That way, the amount you zoom in or out is not dependent on your current zoom level. Consider it with a factor of 2, for example (too high, but makes the maths easier). If the image is at 100% and you zoom in one step, it expands to twice it's size. If the image is already at, say 150%, and you zoom in one step, it still expands to twice its size.

Using an arithmetic progression would feel all wrong, as you would be zooming slower and slower the larger you made the image, and faster as you zoomed out, until presumably you hit 0% and it just wouldn't show any more.

For a simple example, consider that there is a large difference between 10% zoom and 20% zoom, a small difference between 100% zoom and 110% zoom, and almost no difference at all between 500% zoom and 510% zoom.

What I'd suggest is to try ignoring the numerical zoom value, and just zoom in and out a bit with the wheel looking at the image. If you still think it's too fast, I could drop it to 1.2x instead (100%, 120%, 144%, 173%, etc.)

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-31 20:10:44
No, I'm pretty sure a geometric progression is better. That way, the amount you zoom in or out is not dependent on your current zoom level.
Your explanation was really good! I got it now. I also made an analogy with the zooming scheme the graphics programs use (irfan view, photoshop, thumbs plus, etc) and the steps are much more close to a geometric progression indeed (or is it logarithmic?). The main difference is that they tend to use aproximation steps (multiples of 25% and 33.33%).

Quote
...try ignoring the numerical zoom value, and just zoom in and out a bit with the wheel looking at the image.
Asolutely. You're wright. I did this and I must say that with the current scaling algorithm all zooming scales seam pretty equal in quality to me (even the most odd numbers). And the stepping felt pretty natural also.

Quote
If you still think it's too fast, I could drop it to 1.2x instead (100%, 120%, 144%, 173%, etc.)
Not really. I'm quite convinced the 1.3x currently being used in the program is indeed quite adequate (for me, at least).

Thanks again for the thorough explanation. 
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-31 22:28:18
Hi, Alex,
I had another idea, but I really don't know if it would be hard to implement or not (or maybe you simply won't like it, and that's perfectly fine):
(http://i36.tinypic.com/w1a0jr.gif)

How about color-coding the "Size-Banding" scheme (Group by: Size), making them even more distinct from each other?

It seams to me that since you know there are always at most 5 bands you can assign a specific color to them. This way, the presentation is not only more visually actrative, but also more cognitive. In time, you will instantly recognize the images you want. Another good thing is that whenever you have tooo many images in one band you know "where you are", even away from the Band header.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-10-31 22:51:16
...and one small request (if it is possible to implement at all):

I know that for most of the images found in the various sources the file size is completely unknown.

But, whenever you mark your option to "automatically download full size images" (either for unkown sizes, or directly on the source options), there are now many images in the results that you could know the file size (in kb).

I wish, if possible at all, that these file sizes were presented to us on the interface, maybe creating one more line for it on each image that has been fully downloaded.

(http://i37.tinypic.com/v445qv.jpg)
For these Amazon images, for instance, you
might not notice at first that some are very
different from the others, unless you have the
file size information.
Title: Album Art Downloader XUI
Post by: mobyduck on 2009-11-01 07:37:22
Hi all.

First off, I'd like to thank Alex for his dedication and all the partecipants for the interesting ideas that will help improve this already amazing program.

I'd like to voice a little concern I have about the zooming method proposed: I'm not an expert in graphics and imaging and I'm wondering if people like me could really benefit from it or would only be more confused...

IOW, will it be obvious also for inexperienced users which image is the best? Or is it an experts-only feature?

Alessandro
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-01 09:14:29
...a little concern...about the zooming method proposed...people like me could really benefit...or...be more confused...will it be obvious...which image is the best...experts-only feature...

Hi! 
I'm not really sure if I am the best person to respond this, but I'll try. (I'm not an expert also. Consider the possibility that I might be wrong in all that I'm saying)

There's currently 2 things being recently discussed that involve zooming:

1) The program could incorporate a new zooming possibility in the quick preview window (the one you get when you do a simple left-click on the image thumbnail in the main window).

2) Alex was considering replacing the zooming algorithm (the way the program calculates and draws the image whenever you use any sort of zoom in it)

The 1st one isn't an obvious feature (but that does not mean it's an "expert" exclusivity either). Anyone that isn't aware (or does not try, or doesn't look for it) won't even know of that possibility (zooming on the quick preview). I don't think this could particularly confuse anyone, since most people won't try to use the mouse wheel while they're in the quick preview (unless they're trying to zoom, in which case they'll be probably happy it actually works).
In other words, "what you don't know doesn't bother you" and "those who seek, shall find it". 

The 2nd one concerns every user that will make use of the popup preview window (the one you call from the context menu - right-click on the image thumbnail and choose "Preview...") or even the quick preview (when it incorporates zooming possibilities).

It seams to me that everytime you use the zoom the program actually makes a larger (or smaller) copy of the image to present you with a "closer" (or "farther") view. The method it will use to make this new image (only for vieweing purposes - not for saving) can be more accurate (the image will display the pixel blocks if you zoom close enough - e.g. 500% or more) or more smooth (the image could look a bit more blurry, but it tends to look better overall).

The discussion we were having was if most people use the zoom for image inspection (in which case the more accurate view is preferred) or if enough people had another good use for the zoom that would require (or favor) a better looking image on the zoom. The fact is that if you don't zoom too much (let's say more than 300% or 400%) or too often, this probably won't affect you in a considerable manner. Anyway, Alex was asking anyone if they had any reason to keep the current (better looking, less accurate) zooming.
If you do use the zooming for inspecting the image, some of us think that there is a good possibility that you will benefit from the new algorithm. But it also might be something that you won't even notice.

Both changes, in the end, would have one thing in common: they're targeted towards making it even easier for any user to select the absolute best from the images that are being presented from the various sources.

I hope this helps you make sense if it will affect you somehow or not. And if it does, please speak up. This is precisely the right time to do so. 
Title: Album Art Downloader XUI
Post by: mobyduck on 2009-11-01 15:55:49
Thanks for your reply, audio20.
The discussion we were having was if most people use the zoom for image inspection (in which case the more accurate view is preferred) or if enough people had another good use for the zoom that would require (or favor) a better looking image on the zoom.
I was aware of both zooming methods and I use them (mostly the left-click on the thumbnail) for image inspection.
Alex was asking anyone if they had any reason to keep the current (better looking, less accurate) zooming.
This is exactly what my doubt is all about: if the current method is better looking, less accurate, I infer the proposed method will be worse looking, more accurate. Being, as I said, no expert (add to that also not so good in English ), I don't understand how a more precise way to render an image can result in a worse looking picture (less accurate=remove imperfections?) and, if so, how can it help make a better decision quality wise.

Alessandro

[Edit]Reading my post after a good cup of coffee, I'm perhaps understanding now: if the image looks ok with the more accurate method you can be confident it is a quality image, which isn't so sure now. So I guess my next question is: which rendering method is implemented by the programs commonly used to display it? I ask because if no good images are found you'll have to pick a bad looking image and, in this case, you'll want one that looks ok in your player rather than in AAD... or maybe I need something stronger than a coffee.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-01 16:36:02
This is exactly what my doubt is all about: if the current method is better looking, less accurate, I infer the proposed method will be worse looking, more accurate. Being, as I said, no expert (add to that also not so good in English ), I don't understand how a more precise way to render an image can result in a worse looking picture (less accurate=remove imperfections?) and, if so, how can it help make a better decision quality wise.
Take a look at [a href='index.php?act=findpost&pid=664967']this post[/a], where I show a couple of example images. The one on the right is more accurate, and worse looking. If it helps, think that it accurately reproduces the imperfections in the image! In any case, all of this only applies to the image when zoomed in. At 1:1 zoom, or below (for thumbnails, or when manually zoomed out), the existing scaling algorithm will continue to be used.

As audio20 has mentioned, I'm hoping these changes will be completely unobtrusive for anyone who doesn't actually want to use them, I do try to avoid adding confusion wherever possible.

In answer to a couple more proposals:
File Size: I don't know why you think this information would be easily available. In general, it isn't (or not until the image is downloaded, in any case). It may be possible to do an HTTP HEAD request and ask the server for the size of the file without downloading it, which it may then tell us - but this would still be a new HTTP request to send to the server for every result. I'll do some experiments, but I suspect that for many sources, the overhead of making the server request will mean that you might as well then download the image data too.

Coloured Bands: I don't really like the look of that, to be honest. Maybe I'm just boring with my mostly grey interface, but that's my preference. If you really want, stick it in as a feature request and it might go in someday (so long as it was optional).

Experimental Release
Now, good news, I've had some time this weekend to work on the stuff we've been discussing, so here's a 0.32 experimental version: AlbumArtDownloaderXUI-0.32-experimental.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.32-experimental.zip). New UI things to try out:

The icon for the Show Pixels button is a bit rubbish; if someone with more artistic talent than me wants to knock together something better (16x16, png with transparency) then I'd be more than happy to replace it. Also note that this doesn't work (has no effect) without the SP1 for .net 3.5 installed.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-01 20:23:39
File Size: I don't know why you think this information would be easily available. In general, it isn't (or not until the image is downloaded, in any case). It may be possible to do an HTTP HEAD request and ask the server for the size of the file without downloading it, which it may then tell us - but this would still be a new HTTP request to send to the server for every result. I'll do some experiments, but I suspect that for many sources, the overhead of making the server request will mean that you might as well then download the image data too.
I'm sorry.    I assumed you kept all the images that were downloaded (whenever the "Automatically download full size images" was marked) in some temp files on disk. That way I thought the program could have means of "knowing" the file size (only for these images that were already download - which happens to all Amazon sources, in my case).
I guess it's just like the old saying that says something about "assuming" (I can't quite rembember it, but I know it's not good).
Anyway, that request is not that "critical". Thank you for looking into it.

Quote
Coloured Bands: I don't really like the look of that, to be honest. Maybe I'm just boring with my mostly grey interface, but that's my preference. If you really want, stick it in as a feature request and it might go in someday (so long as it was optional).
Never mind... It was meant more like a sugestion and it has no relevance whatsoever. The program interface is a very personal thing and even the slightest change could ruin it for the creator. Anyway, it's not even boring at all. It's actually very good with the gradient shading and all. I don't disaprove at all, I was just seeking more "contrast" specifically in the size banding scheme, but it's kind of foolish indeed.

Quote
Experimental Release
Now, good news,

You call this good? I call it great!!   

* Sorting by area
Feels so absolutely incredibly natural to me! I love it! Thaaaaaanks! 

* Medium band extended to 520px
I must also say that a lot of good images are back to the Medium band - 600x534/600x528/etc - it's great! Both grouping and sorting are now a perfect 10 in my book!

* "Remove" command on results context menu
I like it (very much). Makes it easier to refine the results (specially when there are too many). Although I would personally prefer to have an icon for direct dismissal of the image (single click, isntead of two), I think it was very clever to put it on the context menu. This way, no one is expected to remove an image involuntarily and the command won't get "in the way" of anyone who doesn't specifically wants to use it.

* Zoom by mouse wheel in popup preview window
I was alredy impressed, but now it's official. You ask for something and you get another thing twice as good...
Here's what I loved:
- the possibility of quickly inspecting the images;
- the fact that the image will hold it's zooming factor until you dismis it (zoom out) even after you release the right-click (makes it so easy to compare a set of images, specially now with the removal option);
- the panning scheme; I thought the panning capabilities is perfectly set up; it's very easy now to quickly inspect even a very small image (e.g. 170x170);
- the fact that the preview window doesn't grow and "jump in your face" when you zoom in;
- the fact that you don't zoom out less than 100% (I like that limitation and it makes perfect sense to me);
- the fact that the image will also hold the panning that you did before, making it so easy to compare some sets of images;

* Show Pixels button in the top right of the preview window to toggle between scaling algorithms.
Very easy, very intuitive and it's sure to please everybody now.    Great work!

Quote
The icon for the Show Pixels button is a bit rubbish; if someone with more artistic talent than me wants to knock together something better (16x16, png with transparency) then I'd be more than happy to replace it.
I think this is an almost impossible job. You would surely need a bigger image to portrait with fair accuracy what this button is supposed to do. My guess is that it is good enough now, specially if you already knew what's the button assigned function. But if you don't really know what we've been talking about, you're most likely to find out in practice what this button is supposed to do. The icon is actually good, but it's too small for anyone to figure out what it's representing.
I will think hard  about it and try to see if I can come out with any better ideas for this icon. If I do (which I'm not quite convinced I will), I'll post it here later.

A side note that took me a couple of seconds to figure out, is that whichever zooming scheme/algorithm you choose to have on the popup preview window will also be the one it's used on the quick preview window. I think this makes perfect sense, but it's not "straight-forward" logic. Anyway, I'm just saying, in case anyone else doesn't figure this out at first.

I used to think this program was great, but now I'm out of words...
Thanks again, Alex, for such a great application! 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-01 21:23:19
I thought the program could have means of "knowing" the file size
Oh, I thought you meant for results for which full size images had not yet been downloaded, so you could make a judgement about whether it was worth downloading them or not. If they've already been downloaded, then yes, it should be possible to determine their size. Sadly not as easy as you assumed, as they aren't actually saved as temp files at all, just held in memory as images - but still technically possible. I'm not sure I see the value in it, though, given that you'll already have the full size image and accurate dimensions by this point. It won't go in to 0.32, but could be added as a feature request for possible future inclusion.

You would surely need a bigger image to portrait with fair accuracy what this button is supposed to do.
Given that with a paragraph of text and two 400x400 images I still wasn't able to explain it clearly enough, I don't think any size of icon is going to do that job! I'd still like one that fits in and looks nice, though, and once you know what it does, makes at least some sort of sense.

Thanks a lot for all your comments, it's always good to know when my work is appreciated.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-01 22:07:51
...If they've already been downloaded, then yes...Sadly not as easy as you assumed...technically possible...see the value in it...won't go in to 0.32...feature request for possible future inclusion.
Ok, it's very nice to hear that. Maybe in the future indeed, there is no rush whatsoever.
Let me just try to explain the reason why I wanted it in the first place:
I was thinking specifically about Amazon images, although it may apply to every other source. It is very, very common to see Amazon come up with a whole set of images (from the various Amazon sources - .jp,.uk,.de,etc) that look exactly the same and have the exact same dimentions. But when you start inspecting them one by one, sometimes you realise that a few of them are in fact different and have better quality than the others (probably from coming from a digital source, instead of a scanned cover). What will happen though, is that most of the times you don't catch that difference, mainly because when you will have a set of something like 20 identical-looking images with the same dimentions, you do not want to inspect each one of them, one by one, because most of the time you'll end up just loosing your time. So, the whole idea of having the file size displayed in this case was to be able to look at a fairly large set of identical-looking images and figure out at first sight if they're really identical or not. This way you can inspect only the different ones and quickly decide what's best.

Quote
...I'd still like one that fits in and looks nice, though, and once you know what it does, makes at least some sort of sense.
That's good enough specs. I'll look into it to see if I can come up with anything at all.

Quote
Thanks a lot for all your comments, it's always good to know when my work is appreciated.
No, really. Thank you. This program is just incredible! (even more now, it seams to me)

One quick question:
Can I copy my old settings to this new version?
(should I just copy the old user.config to the new folder?)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-02 07:56:12
So, the whole idea of having the file size displayed in this case was to be able to look at a fairly large set of identical-looking images and figure out at first sight if they're really identical or not.
Fair enough. Feature Request (https://sourceforge.net/tracker/?func=detail&aid=2890572&group_id=187008&atid=919578)

Quote
Can I copy my old settings to this new version? (should I just copy the old user.config to the new folder?)
Settings should be automatically upgraded from the previous version. If that's not happening, I might have screwed something up, but it was working fine when I tried it here.

Alex
Title: Album Art Downloader XUI
Post by: lowfi on 2009-11-03 06:19:48
I've just read through the 40+ pages (!) of this thread and I understand your position on embedded art, but I'll ask anyway...

Actually I have a watered-down request: would you consider only *reading* tags to find embedded art?

Much of my collection has its art embedded, and I'm trying to find a tool to download cover art for the rest... my problem with AAD is that when I do a search it can't tell me which files already have art embedded. And with 40k+ music files, it's not an option to just download art for all of them.

FooBar reads embedded cover art, so I thought that the FooBar integration might do it, but AAD still reports the files as not having any cover art.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-03 09:29:27
Actually I have a watered-down request: would you consider only *reading* tags to find embedded art?
Yes, that makes sense. I'll add that as soon as I get a chance.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-03 10:55:39
Settings should be automatically upgraded from the previous version. If that's not happening, I might have screwed something up, but it was working fine when I tried it here.
Well, I did copy the settings file after all and it worked fine then. I'm gessing that what happened was that I was 'afraid' of writing the 'experimental version' on top of the 'oficial release' so I've put it in another folder. The program then created a different directory to put the settings file. I've been using the program intensively since then and it's working very well. No problems whatsoever so far. 

...Much of my collection has...art embedded...download...for the rest...AAD...can't tell me which...have art embedded...40k+ music files...not an option...download...for all...
Hi, lowfi,
I'm sorry to get in the middle of your conversation here  , but if you allow me, I could suggest a good solution that I've been using myself (with great success).

I also have a huge music collection (I inherited my uncle's CD collection with more than 5,000 CDs).

With such a collection, you're bound to have a personal favorite tagger already. Mine is "Tag & Rename (http://www.softpointer.com/tr.htm)".

In your specific case, one of the advantages of Tag&Rename is that you can either:

[1] Read your entire digital music collection files, Export (http://www.softpointer.com/tr_help/02.07_Export_wizard.htm) all the information to a CSV file and open in Excel to isolate all the albums that do not have cover art embedded yet. Then go loading folder by folder (from the path field in Excel) to the queue in AAD to have it download your covers for you (or even read the entire collection in the file browser and start marking only the ones that were filtered in Excel).

[2] Read your entire digital music collection files, then use T&R sorting capabilities to sort by cover art field (column) and see all the albums that do not have the cover art embedded yet.  Then go loading folder by folder to the queue in AAD to have it download your covers for you.

From what I could understand by your post, you wanted AAD to filter out the albums that already have cover art, but I'm guessing you could still end up with some albums that do have cover art in their folders but cover art that is not embedded yet (this situation happens to me often).

I believe a good tagger could do a much better (and precise) job of filtering those albums for you and AAD would still be invaluable on what it's really good at: getting those covers for you.

P.S.: I realize that you very well might say "now tell me something that I don't know..."  , but that was just in case you haven't yet tried filtering with a tagger. I saves me a lot of time when processing old album folders.
P.S. 2: I also believe that a lot of people will be very pleased when AAD gets to be able to read those iD3v2 embedded art. I'm not against it at all.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-05 19:12:35
v0.32 experimental, again
I've just upgraded to Windows 7 x64, and noticed a few inconsistencies with AAD. I've therefore updated 0.32 experimental to include various tweaks to the UI to bring it more into line with what it was supposed to look like. I've tested under XP, and it still looks fine there too. The only thing I'm not happy about is the height of the menu separators, but unfortunately it looks like I might be stuck with those.

I don't have a copy of Vista to test on, so if anyone wants to let me know if this version looks better (or worse) than 0.31, then please do so.

I've also updated the installer to point to Program Files rather than Program Files (x86) when installing on a x64 system, as Album Art Downloader runs as a 64 bit process (100% managed code).

AlbumArtDownloaderXUI-0.32-experimental.exe (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.32-experimental.exe)

Alex
Title: Album Art Downloader XUI
Post by: maximus2 on 2009-11-06 03:29:27
Hi Alex

I'd like to add myself to the long list of people who nag you about the possibility of embedding album artwork directly into mp3 files.

Embedded picture are obviously the way it's gonna work in the future. Having one picture per folder really only makes sense for people who listen to music mostly by album. I for example have quite a large collection of mp3s. I have a computer which I use only for DJing, and an iPod. I ripped about 1500 CDs, but I also buy single tracks. Especially for the later, it makes no sense whatsoever to have one image file per mp3 file.

Your program is obviously great, but only does half the job for me. I only browsed this thread quickly, but as far as I can tell there still is no (third party) automated way to embed images to all the music files within a folder, or am I mistaken? Which means you still would have to do it manually for every album with mp3tag for example.

In an ideal world, I would be able to automatically download and embed images in the amazon.com thumbnail version (240x240 pixels, extremely small files size) and embed them to the files with your program.

I read all your arguments (I basically scanned the whole thread for postings involving the word 'embed') and to be perfectly honest they don't convince me. The only viable reason is not wanting to include such a function for technical reasons, those being like you said that this function should belong to a tagging program.

That being said, I beg you to reconsider. I really cannot see any benefits at all for having the image as a separate file. The way it stands now, using mp3tag to download AND embed the images is a much better solution, because you have to do it album by album anyway, but it at least does both at the same time.


Edit: Never mind, I'm a moron. I only now noticed that mp3tag (automatically) does what I want, and that you actually gave a link to the instructions of how to do it. Now I only have to figure out how to use AAD optimally :-)

Cheers from Switzerland!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-06 08:20:34
Revisiting Embedded Artwork
This seems to be coming up quite a bit again. I'm not going to re-hash all the arguments against them, but I still believe this is not the tool to be doing that job - it doesn't have the right UI or the right workflow for tag management. Sure, I could make it able to save the image result by embedding it into a tag in a (single) specified music file rather than saving it as an image file, but I just don't think that's going to be very helpful - you want the artwork available for the whole album, and without getting into tag management that means it's got to be an image file either in the album folder, or in a known folder elsewhere.

An interesting point that has recently been raised is that of reading existing embedded artwork. I've been thinking about that one. When using the File or Foobar browsers, the result is a list of albums. These have the following information: Album name, Artist name, and Folder path. The folder path may have been determined by the folder in which an mp3 was found, but this is not necessarily the case, it may have been matched by a pattern instead. All that can be relied on is that this is a folder which contains, in some form, an album of the specified name and artist (or potentially "Various Artists").

AAD will then search for one image, for each album, based on those 3 pieces of information, plus the specification of where to look for images. So, if you specify "Folder.jpg" as the image, then it will look for a file called Folder.jpg in the folder for that album. The only way I can think of to include embedded images would be to allow you to specify something like *.mp3 as the location to look for images - then it would try to find any mp3 file in the album folder, and when it found one, look for any image embedded within it. We end up bumping into the same problem that AAD expects a single image for an album, but embedding results in an image per file, rather than per album. Hopefully they would all be the same, of course.

Obviously there would have to be further customisation to the commands available from that point; rename wouldn't make any sense at all, but could be replaced by an Extract command to let you save it as an image file.

Alex
Title: Album Art Downloader XUI
Post by: maximus2 on 2009-11-06 12:12:24
Revisiting Embedded Artwork
This seems to be coming up quite a bit again. I'm not going to re-hash all the arguments against them, but I still believe this is not the tool to be doing that job - it doesn't have the right UI or the right workflow for tag management. Sure, I could make it able to save the image result by embedding it into a tag in a (single) specified music file rather than saving it as an image file, but I just don't think that's going to be very helpful - you want the artwork available for the whole album, and without getting into tag management that means it's got to be an image file either in the album folder, or in a known folder elsewhere.


Well, I guess thats your call. Obviously you want to make a coherent program, but I'm sure you're also interested in having as many people as possible using it.

I'm sure noone is opposed to having an image file in a folder where there's a complete album, but at the same time I'm absolutely convinced that embedded images are the future. For me an ideal solution would be to have a program which downloads real good quality art covers to place into the folder for albums, like for example iTunes does (covers are about 1 MB in size) and then also to download very small images, not more than 50k, to embed into the files themselves.

Btw, is there a manual somewhere for how to use Foobar? I'm not exactly great at learning by doing, and a step-by-step instruction guide on how to automate cover art download for a large collection of music would be of great use to me!

Cheers to you for developing a very helpful software 
Title: Album Art Downloader XUI
Post by: maximus2 on 2009-11-06 12:36:10
Hold up a minute, have I misunderstood something? Is it not possible to automate the program, such that for example you choose a folder, and for each subfolder which holds an album it automatically downloads the best image that meets certain criteria? Such as that you do not have to manually choose the image?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-06 14:10:02
For me an ideal solution would be to have a program which downloads real good quality art covers to place into the folder for albums, like for example iTunes does (covers are about 1 MB in size) and then also to download very small images, not more than 50k, to embed into the files themselves.
Having a high quality image file in the folder, and embedded thumbnails within the files themselves sounds like a very sensible scheme. I'd suggest that these thumbnails should be generated from the high quality ones, rather than downloaded separately, though. In my view, it is AAD's job to find and download the high quality image file. It is the job of a tag management program to take that image and generate smaller embedded ones for the files belonging to that album. For example, what if you got hold of the large image file from somewhere else, independently of AAD? You'd still want to generate the smaller embedded files, but there would be no natural 'way in' to get AAD to do it (if it was just done as some sort of automatic step when saving search results).

I don't think mp3tag currently supports resizing art as it's embedded, but it would definitely be worth a feature request.

Quote
is there a manual somewhere for how to use Foobar?
The Wiki (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Foobar2000) is about as good as it gets, I think.

Is it not possible to automate the program, such that for example you choose a folder, and for each subfolder which holds an album it automatically downloads the best image that meets certain criteria? Such as that you do not have to manually choose the image?
Not at present, no. You always have to choose which result you want to save.

There is a command line version which will download a single image without UI, but nothing that is just a fire and forget "download your best guess for everything in these folders" functionality.
Title: Album Art Downloader XUI
Post by: bsleeth on 2009-11-06 15:06:16
v0.32 experimental ... I've just upgraded to Windows 7 x64, ... I don't have a copy of Vista to test on, so if anyone wants to let me know
Alex,

As always, thank you for sharing your great tool and for providing such a high level of support.

I just tested v0.32-exp on Vista.  Frankly, I could not tell the difference between v0.32-exp and v0.31 (so much so, that I had to reinstall v0.31 and double check).  So, as you would have to tell me what changed for me to actually notice, I guess you could say v0.32-exp looks fine on Vista too.  Of course, I have been using v0.31 on Vista and never noticed a UI issue, so I may not be the best person to make this call.

Also, for those on x64 systems, you may want to let them know that they might want to uninstall their pre-v0.32 version prior to installing v0.32.  Otherwise, the install folder used by the v0.32 installer will be that of the previous install (which of course would be "Program Files (x86)".

Thank you again
Title: Album Art Downloader XUI
Post by: maximus2 on 2009-11-06 15:34:50
There is a command line version which will download a single image without UI, but nothing that is just a fire and forget "download your best guess for everything in these folders" functionality.


OK. Then I must have misinterpreted one of the descriptions of the functionality of your program somewhere on the internet.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-06 15:36:10
Thanks for the feedback! I think the major UI issue was that most of the clickable elements had borders round them. The sort/group controls were also misaligned vertically, and the "..." browse buttons were very narrow. The combo-boxes (like the path to save images to) were also not quite right, the drop button was shaded when it shouldn't be and the border didn't highlight when it should.

If Vista looked fine before, and hasn't changed now, then I'm happy.

I'm not sure it's worth anyone actually moving an existing installation from "Program Files (x86)" to "Program Files", I don't think it has any effect. If anyone wants to, for tidiness, then yes, uninstalling and re-installing would do the job.
Title: Album Art Downloader XUI
Post by: maximus2 on 2009-11-06 15:40:07
A related question: On this page (http://fileroad.com/details/alexvallat-album-art-downloader-xui/889) the first comment claims that you can add this to your tools (within mp3tag) using these simple parameters: "%artist%" "%album%" "%_folderpath%Folder.jpg. Can someone elaborate on this, I'm not quite sure I understand it...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-06 15:58:17
you can add this to your tools (within mp3tag) using these simple parameters: "%artist%" "%album%" "%_folderpath%Folder.jpg. Can someone elaborate on this, I'm not quite sure I understand it...
That would appear to be a suggestion that you add an mp3tag tool entry (http://help.mp3tag.de/en/options_tools.html) so that you can have a "Download Album Art" context menu command from within mp3tag. It suggests that for the "Parameter" setting for the tool, you use the string "%artist%" "%album%" "%_folderpath%Folder.jpg" (I added the missing final " mark). Personally, I'd use .'%'extension'%' instead of .jpg (note '%' escaping), in case the image found isn't in jpeg format - but then again most image displaying software will ignore the extension when determining format anyway.
Title: Album Art Downloader XUI
Post by: maximus2 on 2009-11-06 17:42:02
you can add this to your tools (within mp3tag) using these simple parameters: "%artist%" "%album%" "%_folderpath%Folder.jpg. Can someone elaborate on this, I'm not quite sure I understand it...
That would appear to be a suggestion that you add an mp3tag tool entry (http://help.mp3tag.de/en/options_tools.html) so that you can have a "Download Album Art" context menu command from within mp3tag. It suggests that for the "Parameter" setting for the tool, you use the string "%artist%" "%album%" "%_folderpath%Folder.jpg" (I added the missing final " mark). Personally, I'd use .'%'extension'%' instead of .jpg (note '%' escaping), in case the image found isn't in jpeg format - but then again most image displaying software will ignore the extension when determining format anyway.


OK, but that has nothing to do with embedding your program within mp3tag? Because that's the way I understood it...

In any case, thanks for your help, that is very kind of you!
Title: Album Art Downloader XUI
Post by: GHammer on 2009-11-06 19:54:53
v0.32-exp on Windows 7.
The results windows shows html code for some results, especially on items from Amazon.

Otherwise working fine, I do like the 'sort by area' option.
Title: Album Art Downloader XUI
Post by: pedr0 on 2009-11-06 21:13:13
Hi,

Just getting used to this application.  Sorry for the basic question, but I'm having trouble specifying the path where I want my images saved. I'm using the file browser to find my albums with missing art and follow these steps:

* Find the folder with my album(s) and click Search
* select an album in the list in the file browser and click "Get Artwork for Selection"
* a search window opens and finds all the art (all fine so far)
* ...but when I click 'Options', the 'Images will be saved to:' text box is greyed out and I can't change the location.  The instructions below this text box say: 'This path was set automatically from the browser. The location of images relative to album folders can be set in the options for that window.'

Unfortunately, I cannot see anywhere in the file browser window where I would set the path. Am I going about this the wrong way?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-06 21:34:26
The results windows shows html code for some results, especially on items from Amazon.
HTML code? Now that's weird. Must be a script problem, though. Can you tell me what you searched for that produced that result?

Unfortunately, I cannot see anywhere in the file browser window where I would set the path. Am I going about this the wrong way?
No, you're doing it right. In the File Browser, click the "Options" link. The path is set in the box labelled "Specify path to find images". If you put, for example, "Folder.jpg" into this box, then the results will be saved as Folder.jpg in the album folder. If you don't want it to go in the album folder, you can put a full path into that box - something like "C:\AlbumArt\%artist%\%album%.jpg" for example.

The box in the file browser controls where it looks to find existing art, but that is also where it tries to save newly found art to, so that after saving, it then appears in the list as art for that album.

Does that make sense?

Alex
Title: Album Art Downloader XUI
Post by: pedr0 on 2009-11-06 22:30:54
The box in the file browser controls where it looks to find existing art, but that is also where it tries to save newly found art to, so that after saving, it then appears in the list as art for that album.


Ah! I saw that box, but didn't realise it specified the save place too.  Thanks Alex I'll give that a go.

BTW. I've only played around with a handful of albums so far, but it seems that when the album name has a question mark at the end, the results are not so comprehensive. Deleting the question mark pulls up better results. E.g. So What? by 28 Days.  I only mention it in case it helps you in your development.
Title: Album Art Downloader XUI
Post by: Innuendo_ on 2009-11-07 00:00:47
OK, but that has nothing to do with embedding your program within mp3tag? Because that's the way I understood it...


Hello maximus2! Yes, you understood it correctly and here's how to set it up. In mp3tag go to Tools -> Options -> Tools. Once there hit the "New" icon which will bring up a dialog box:

Name - you can put anything in here.

Path - the file path to Album Art Downloader XUI.

Parameter - this is where you put the cryptic "%artist%" "%album%" "%_folderpath%Folder.jpg

Click OK and from then on you can pull up Album Art Downloader XUI in mp3tag by right-clicking on a track and selecting whatever you entered in the Name field from the Tools fly-out menu.

Have any questions just ask.
Title: Album Art Downloader XUI
Post by: bsleeth on 2009-11-07 04:49:50
...The sort/group controls were also misaligned vertically...
Now that you mention it, yeah, those did not ling up.

Another (new?) strange behavior with the group/sort controls ... When the application first starts, the sort/group labels are close to the corresponding values.  If you click on the value, the label is pushed left as the drop list is shown.  The values in the drop list are right-justified.  Once a value is selected, the label remains pushed over (to the left); thus leaving a gap between the label and the value.  For example, the following two lines represent a before/after:
Code: [Select]
  Group by: Size
Group by:   Type
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-07 06:55:27
...it seems that when the album name has a question mark at the end, the results are not so comprehensive. Deleting the question mark pulls up better results...
I think it's the same issue I was talking about in this post here (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=663373).

Here's Alex previous response:
Is there any way you could strip those characters ( & and : ) from the search strings you get from the queue?
The only problem I have with this is that if a source did make good use of those, they would then not be available any more. I'd really rather not throw away data if I don't have to. A better idea would be to modify the scripts of sources which work better without those characters to strip them before sending the query to the server. To do that, I'd have to do a survey of each site, testing which one works better with the characters removed, and which with them left in.
So, the way I understood that is that it is always possible for the user to remove those characters manually now, but if the program stripped the characters all by itself, the result might not be as good as expected and, not only the user will never figure out that the results are bad because of the stripping, but also he will never be able to enforce the search with those characters if he purposely wishes to do so. So, indeed, it's tricky like that...

I thought that was a very reasonable response and good enough reason for him not to adopt stripping those characters as default for the program. But the more I use the program, the more I am convinced that stripping certain characters from the search string is always good for the results. It may be so that I can't yet "mathematically" prove so, but still... I've been stripping a group of characters ( & . ; : ? ! ' " ) from the input string for quite some time now; And repeating the search without them. I must say that I have yet to come across any result that wasn't at least as good as before (most of the time the results are much better indeed). The only problem I have to offering this as proof is that I don't isolate the sources.

I think the way to go should really be like this: We gather a fairly large group of albums with those characters in the name, test and record all results, one source at a time, both with and without those characters. Then analyze it and offer at least a small statistical proof that what we "feel" (stripping those characters is always good) is in fact true. I was meant to do that a while ago, but as this is probably gonna take a looong time (and, let's face, will be very boring to do) I haven't yet "found the time" to do it (it's on my TODO list, though).

I thought about modifying myself each script to strip those characters before sending the search, but I am really a lousy programmer. So, between the time it will take me to study the boo language and figure out exactly how should I modify those scripts, I will be better off just doing the procedure above. 
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-07 07:14:25
...I do like the 'sort by area' option.
Me too!  Nice to know. I think Alex will be happy that more users are pleased with this option than otherwise.

The results windows shows html code for some results, especially on items from Amazon.
HTML code? Now that's weird. Must be a script problem, though. Can you tell me what you searched for that produced that result?
I believe this has happened to me also, once in a while, in the previous versions (0.30, 0.31). In the middle of the results you get some very large "cells" where the text that was supposed to go there is followed by a bunch of code. As a result, the next "line" of results is very "far away" down below. I always believed this was due to a malformation of the source page (some interruption or corruption on the flow of data) rather than a program fault (I might be wrong, though). What led me to believe this was the fact that if I repeat the same search, I might even get other "rather large cells", but not the same ones. I never mentioned this before because it is very rare that it happens and I can't purposely reproduce it (not even right after it happens).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-07 08:01:12
Another (new?) strange behavior with the group/sort controls ... When the application first starts, the sort/group labels are close to the corresponding values.  If you click on the value, the label is pushed left as the drop list is shown.
Yes, that's not new, it's always been the case. If you show the drop down, then the label has to move to make room for the widest option in the list. Until then, it only makes room for the option that is currently displayed. Not ideal, perhaps, but not a big deal either.

[Character Stripping]
I'll tell you what, I'll add code to every script to strip the characters & . ; : ? ! ' ". It will be right at the top, and easy to modify. I'd appreciate it if, whenever you get the time, you could test out for any given script whether re-including any of those characters would actually improve results, and I'll reinstate them as the information is gathered.

[HTML Codes]
This is a failure of the script to properly parse the HTML of the source that it is searching. Unfortunately, without knowing which script, or when it does it, it will be very hard to fix! It is possible that it will occur if the source changes their HTML pages, which would mean the script needs modification to match. I can usually make those sorts of changes pretty quickly, once notified.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-07 11:52:28
Hi, Alex,
thanks for such a fast response!
[Character Stripping]...I'll add code to every script to strip the characters [font= "Courier New"]& . ; : ? ! ' "[/font]. It will be right at the top, and easy to modify.
Wow! I can insert the code in each script if you point me in the right direction (you could PM me the sample code that would do the job), I mean, if that is easier for you. I really didn't mean before to give you even more trouble. Thank you so much for offering.

Quote
...whenever you get the time, you could test out for any given script whether re-including any of those characters would actually improve results, and I'll reinstate them as the information is gathered.
If you think it will help you, I can even do all of it by tomorrow. I can compile and post an excel sheet with the results on google-docs.
(I was postponing it mostly because I didn't think this would really interest you that much; and, ok, also because I was lazy...  )

I was thinking about getting a 50 random albums sample to insert in the queue and test them on each source, both with and without the characters. But now, I was just re-thinking the hole test procedure, and if you're giving me the code to build all the scripts that will automatically strip the characters for me, I guess it will all be much easier.

[1st] Create, in a separate folder, a copy of the program with all scripts modified to strip the characters;
[2nd] Separate 50 random albums with those "problematic" characters;
[3rd] Have those albums in a queue from the "file browser" on both versions of the program (with and without modified scripts), one version at a time;
[4th] Let the program automatically perform the searches and go on recording the number of results for each source, for each album.
[5th] Compare the number of results for each version and draw a conclusion.

Quote
[HTML Codes]This is a failure of the script to properly parse the HTML of the source that it is searching.
I thought so too (something like one field being captured way beyond what it's limit should really be). But I considered that the code the program was getting from the source at that specific time and on some very specific conditions was corrupt, therefore (by some conditions not being met) the program wasn't being able to parse that code correctly. I think that the fact that only very few cells (when more than one) did display the strange code and all the rest of the cells were just fine corroborates that thesis in a way.

Quote
Unfortunately, without knowing which script, or when it does it, it will be very hard to fix! It is possible that it will occur if the source changes their HTML pages, which would mean the script needs modification to match. I can usually make those sorts of changes pretty quickly, once notified.
Duly noted. So you'd rather have me report (and record the most accurate information I can get) whenever that happen again, even if that is not a big deal for me, right? (I didn't report before mostly because I thought that if I couldn't reproduce it, it shouldn't be a glitch - and also because I didn't want to bother you even more than I already do). I'm also not that much confident that you will be able to reproduce the problem yourself, even if I record and give you all the information I can get whenever (and if) that happens again (but I'll try anyway, that's a promise).

Again, thank you for being so much interested in helping us and for such fast responses. 
Title: Album Art Downloader XUI
Post by: maximus2 on 2009-11-07 16:12:10
OK, but that has nothing to do with embedding your program within mp3tag? Because that's the way I understood it...


Hello maximus2! Yes, you understood it correctly and here's how to set it up. In mp3tag go to Tools -> Options -> Tools. Once there hit the "New" icon which will bring up a dialog box:

Name - you can put anything in here.

Path - the file path to Album Art Downloader XUI.

Parameter - this is where you put the cryptic "%artist%" "%album%" "%_folderpath%Folder.jpg

Click OK and from then on you can pull up Album Art Downloader XUI in mp3tag by right-clicking on a track and selecting whatever you entered in the Name field from the Tools fly-out menu.

Have any questions just ask.


Thanks a lot, mate! Unfortunately, I'm not exactly a genius in figuring stuff out myself 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-07 16:17:15

I'm not sure it's going to be quite that easy - AAD compiles the scripts to form a cached copy, and then does not re-compile unless it detects that the scripts have changed. So, even if you had a copy of the program in another folder, it would still share the same cached copy and wouldn't know that it had to re-create it (as it's scripts would not have changed).

What I would suggest is to use a single copy of the program, and just replace its script files. If it starts getting confused and doesn't re-compile when it should, then you can always force the issue by deleting the "boo script cache.dll" file from the scripts folder in the local user settings.

Here are the character-stripping scripts: Scripts.zip (http://www.byalexv.co.uk/temp/Scripts.zip). You'll want to turn off (or ignore) update checking, as otherwise it will claim that they're all out of date and all need replacing! You can replace them all in one go, or one at a time, whichever is more convenient, but you must make sure that you replace util.boo first. Replacing it won't affect old scripts, but new ones won't work until the new util.boo is in place.

For the HTML thing, it's probably worth reporting the source and search terms if it happens more than once with a single source. Otherwise, chances are I'll never be able to reproduce it and any fix would be a complete guess.

Alex
Title: Album Art Downloader XUI
Post by: Innuendo_ on 2009-11-07 17:02:47
Thanks a lot, mate! Unfortunately, I'm not exactly a genius in figuring stuff out myself 


Nobody is an expert at figuring everything out. That's what internet forums are for...so we can fill in the gaps in our knowledge. Glad I was able to help you out.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-07 21:32:01
Hi, Alex.
Wow,  that was fast! 
I'm not sure it's going to be quite that easy - AAD compiles the scripts to form a cached copy...suggest is to use a single copy...just replace its script files...deleting the "boo script cache.dll"...
Got it! Foolproof explanation (very good!).  I'm doing exactly as you explained. It's going fine.

Quote
Here are the character-stripping script...turn off update...new ones won't work until the new util.boo is in place.
Great! I believe there was a problem with util.boo (at least here it showed up):
line 75 was missing a closing parenthesis:
[font= "Courier New"]    if(String.IsNullOrEmpty(stringToStrip)[font= "Arial Black"])[/font]:[/font]

It's all working now.

A quick question (just out of curiosity, I couldn't 100% sure just by reading the script code):
Does the Regex.Replace in StripCharacters on util.boo replaces any (and all) "problematic" characters with an empty string?
If it is so, this way "Vol.1" would turn out to be "Vol1", instead of "Vol 1". I usually do a very sloppy programming and replace all with a space character and (if I want to tidy up the result) do a final replacement of double-spaces for single-spaces (very much probably not what you want to do).

I was also thinking that the characters "(" and ")" could be stripped from the strings... What do you think?
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-08 00:29:14
...getting a 50 random albums sample to insert in the queue and test them on each source, both with and without the characters...

I've tested 10 albums so far and compared the results  :
and 46 to go...  (that is... if I don't get some more to extend the sample...) 
I'll post the results as soon as I'm done.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-08 03:09:25
I've been trying hard to remember which was the last album where that "HTML glich" last ocurred. The fact is memory is too weak... I couldn't remember which one it was. But instead I could reproduce a similar one with the folowing entries:
artist: Sophie Ellis Bextor
album: Read My Lips
souce: Amazon (.jp)
Only one cell presents the glitch.
Here's some screen caps (click to see full-size): Main window -->(http://i38.tinypic.com/adkwmv_th.png) (http://i38.tinypic.com/adkwmv.png) / tooltip -->(http://i33.tinypic.com/29djo9i_th.png) (http://i33.tinypic.com/29djo9i.png)

While we're still on this page, I've also noticed that this problem with AllCDCovers has been ocurring regularly; You click on the image to get a preview (or click on the button to try and save the image directly) and instead you get this CD image giving you this message:
"Download isntructions: Yes, we do have the cover you're looking for, but no, we can't show it to you. You've most likely clicked on some old link to this cover or something else has gone wrong. Please visit our homepage to download this cover."
(http://i34.tinypic.com/2gxoiuv_th.png) (http://i34.tinypic.com/2gxoiuv.png)
When you follow the link to the page and click on the download button there, everything goes fine (the image is available there - like you see below).
(http://i36.tinypic.com/14ljxco_th.png) (http://i36.tinypic.com/14ljxco.png)
I am not sure if this is some sort of protection (no hotlinking or something like that) implemented from AllCDCovers site or if they are in a process of changing the way some of the images are presented (or maybe something else completely different, probably).

P.S.: One more, almost identical, again from Amazon (.jp)...
artist: Snap
album: The Power (Best of Snap)
souce: Amazon (.jp)
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-08 06:35:09
Well, the board won't let me edit the message above (I don't know why, exactly... time limit?), so here's some more sources for the "HTML glitch":

artist: Paul van Dyk
album: 45 RPM
source: Amazon (.jp)

artist: Ian Van Dahl
album: A.C.E.
source: Amazon (.jp)

artist: (empty)
album: Cream Ibiza Arrivals
source: Amazon (.co.uk)
and some caps for this last one (the first I caught in Amazon.co.uk): main window -->[a href="http://i36.tinypic.com/16j29ud.png" target="_blank"] too much... These ocurrences are very very rare.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-08 08:24:03
line 75 was missing a closing parenthesis:
Oops, you're right of course, sorry.

Does the Regex.Replace in StripCharacters on util.boo replaces any (and all) "problematic" characters with an empty string?
Yes. If you want it to be a space instead, just change the "" in the line to " ". I doubt multiple spaces would have any effect on results, but space vs. no space probably would. Maybe even some characters should be spaces and some just removed? I was thinking of things like Alisha's Attic, which would almost certainly have better results as Alishas Attic than Alisha s Attic! On the other hand, as you say Vol 1 is probably better than Vol1.

I was also thinking that the characters "(" and ")" could be stripped from the strings... What do you think?
Easy enough to check, just add them to the list in the StripCharacters call. I can't think off hand of any artist or album names with those characters in, but I expect there are some.

I've tested 10 albums so far and compared the results
That's great work, thanks a lot! Some of the results are very surprising, though - from personal experience I know the Amazon search using a web browser works fine with &, so the Aly & AJ result was unexpected. Rather than stripping, that could probably be fixed to encode the & in the way it does in the web search - needs more investigation, but I'll look into it.

arkivmusic consistently gives only false positive results
Arkivmusik is a classical music site. I'm not surprised it does pretty poorly with those searches! If they collect statistics on what people search for on their site, I imagine "Agnes / Dance Love Pop : Love Love Love" is likely to have them scratching their heads a little. :-)

HTML glitch
All that information is really useful - I'll try and work up a fix to the Amazon scraper script to fix it.

For AllCDCovers, yes, I believe that's a protection device. I think it's triggered by rate of download of images, or ratio of image to html downloaded or something. It's pretty irritating, but I'm not going to spend too long trying to work around it and get into some sort of arms race.

Thanks again,

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-08 09:21:29
Right, I've looked into Amazon, and believe I have an update that should fix the HTML problem. It appears to occur on Amazon.co.jp (randomly, but reproducibly), and on other countries when there was no artist listed for a result, only an album title. The updated amazon-common.boo should take care of both of those cases.

Further, I've checked out why amazon wasn't working with the & character, and have fixed that too. I've removed the stripping from Amazon and Freecovers, the rest are undecided. With the updated util.boo, though, results for & and ? should be discarded and re-tested, as they may have been fixed.

Scripts-update.zip (http://www.byalexv.co.uk/temp/Scripts-update.zip)

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-11-08 16:58:51
For AllCDCovers, yes, I believe that's a protection device. I think it's triggered by rate of download of images, or ratio of image to html downloaded or something.

Just a reminder, I investigated this problem back in 2008 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=595782). It's a leech prevention system which seems to use session hashes (or similar) which expire after about 15 minutes.
Title: Album Art Downloader XUI
Post by: audio20 on 2009-11-10 11:30:06
Hi, Alex,
thank you for all your fast responses!

I've been trying to come up with a more efficient method for testing the album examples for the stripping/no stripping scripts.

My internet connection is not very good, and I was loosing a lot of time before, just downloading images that I wouldn't even keep in the end.

So I went on to read the command line reference again to see if there was a way to disable in batch (all at once) the "Search First" option for each source. I couldn't find it, so I just wrote a command line to enable "Search First" on all but ArkivMusik (as I intended) and then another to re-enable just the ones I usually use (for when I was finished testing).

I only found the command line reference on the help menu, which is fine for me, but it got me thinking:
Why not include a txt file with this reference in the program folder?
(maybe even a .rtf or .pdf file, like these --> rapidshare.com/files/304880632/Command_Line_Reference.zip )

I also thought it could be good to include the sources names in the reference, since the users will be using them quite often.

The other thing I was searching for was a way to disable all the "Always download full size" options I previously marked on some of the individual sources. I Couldn't find it, so I did it by opening (and closing) each source and unchecking the option there (quite a few clicks, I must say...). The positive side of this was that I also needed to reset the "Limit to xx results" option, so this was a good opportunity.

It seams to me it would make sense to have both a "08:" ("Limit to xx results") and a "A:" ("Always download full size") parameter, for those options for each source. (in the same fashion of the "F:" for the "Search First" option) e.g.
Code: [Select]
AlbumArt.exe /s "A:F:Album Art Exchange,08:F:Coveralia,20:GoogleImage"

It could be good also to have an abbreviation system for the various sources (it could even help prevent some errors due to misspelling on the command line). e.g.: Album Art Exchange = AAE | AllCdCover = ACD | Amazon (.ca) = ACA | Amazon (.co.uk) = AUK | Amazon (.com) = ACO | Amazon (.de) = ADE | Amazon (.fr) = AFR | Amazon (.jp) = AJP | Archambault = ARC | ArkivMusik = AMS | Buy.com = BUY | CD Baby = CBY | CD Universe = CUN | Cover-Paradies = CPA | Coveralia = COV | CoverIsland = CIS | Darktown = DTW | Discogs = DIS | Encyclopaedia Metallum = EME | Freecovers API = FRA | GoogleImage = GOO | hitparade.ch = HIT | HMV Canada = HCA | Juno Records = JUN | LastFM Artist = LAR | LastFM Cover = LCO | maniadb = MDB | Metal Library = MEL | MusicMight = MUM | Psyshop = PSY | RevHQ = RHQ | Yes24 = Y24 | YesAsia = YES

This way, we could have an absolutely complete (but not as much massive) command line:
Code: [Select]
AlbumArt.exe /ac off /mn 200 /mx 2100 /o s /o a- /s "12:A:F:AAE,15:F:ACD,12:A:F:ACA,12:A:F:AUK,12:A:F:ACO,12:A:F:ADE,12:A:F:AFR,12:A:F:AJP,4:ARC,4:AMS,4:BUY,12:A:F:CBY,12:A:F:CUN,12:CPA,8:F:COV,8:CIS,8:DTW,8:A:F:DIS,4:EME,8:FRA,20:F:GOO,4:A:F:HIT,4:HCA,12:A:F:JUN,6:F:LAR,4:A:F:LCO,4:MDB,4:MEL,4:MUM,4:PSY,4:RHQ,12:A:Y24,12:A:YES" /fileBrowser

instead of this (incomplete and more massive):
Code: [Select]
AlbumArt.exe /ac off /mn 200 /mx 2100 /o s /o a- /s "F:Album Art Exchange,F:AllCdCover,F:Amazon (.ca),F:Amazon (.co.uk),F:Amazon (.com),F:Amazon (.de),F:Amazon (.fr),F:Amazon (.jp),Archambault,Buy.com,F:CD Baby,F:CD Universe,Cover-Paradies,F:Coveralia,CoverIsland,Darktown,F:Discogs,Encyclopaedia Metallum,Freecovers API,F:GoogleImage,F:hitparade.ch,HMV Canada,F:Juno Records,F:LastFM Artist,F:LastFM Cover,maniadb,Metal Library,MusicMight,Psyshop,RevHQ,Yes24,YesAsia" /fileBrowser

I know it's very uncharacteristic to have such a complete command line, but when you start to fiddle and change your sources and the specifics of each source as often as I've been changing, you never know what kind of settings were left the last time. This way, it's always best to re-set everything again (just to be safe).

There's always the argument against all these changes I brought up above: very few people will probably make use of these (command line reference file on folder | abbreviation for sources | "limit result" and "always downl. full size" options for sources on Comd.Line). I just thought it was worth bringing it up anyway, just in case you might agree with any of those remarks.

...AllCDCovers... Just a reminder, I investigated this problem back in 2008 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=595782). It's a leech prevention system which seems to use session hashes (or similar) which expire after about 15 minutes.
Hi, Akkurat,
I must admit  that I did not think of searching the thread for this problem before I posted. Thanks for the remainder! 
It's nice knowing all that. It will be much easier to avoid this problem using the 15 minute rule now. 

...Maybe even some characters should be spaces and some just removed? I was thinking of things like Alisha's Attic, which would almost certainly have better results as Alishas Attic than Alisha s Attic! On the other hand, as you say Vol 1 is probably better than Vol1.
Indeed! I hadn't thought of that. Maybe we could execute the function 2 times then, one time replacing some of the characters by a single space and another just stripping the rest of them. (I thought it could be easier to pass on the replacement value in the function, rather than creating another function for different char replacements)

Quote
...arkivmusic consistently gives only false positive...
Arkivmusik is a classical music site. I'm not surprised it does pretty poorly with those searches! If they collect statistics on what people search for on their site, I imagine "Agnes / Dance Love Pop : Love Love Love" is likely to have them scratching their heads a little. :-)
That's very funny indeed! I didn't have the basic idea to go out and check ArkivMusik site... Now I get the reason for all those false positives! Still, I think it's advisable to always disable this source by default. It's usually (for most users, probably) a waste of bandwidth.

Quote
...HTML glitch...
All that information is really useful - I'll try and work up a fix to the Amazon scraper script to fix it...
...I've looked into Amazon, and believe I have an update that should fix the HTML problem...
Wow!  That was lightning-fast!

...I've checked out why amazon wasn't working with the & character, and have fixed that too. I've removed the stripping from Amazon and Freecovers, the rest are undecided. With the updated util.boo, though, results for & and ? should be discarded and re-tested, as they may have been fixed.
Ok, I started a whole new test battery (and included more albums to widen the sample, including also the characters "(" and ")").

I did a slight modification of the scripts you sent, just for testing purposes. It seams to me it would be more beneficial if we could compare the effects of stripping/no-stripping: (a) including the "(" and ")" characters and (b) testing the effects of stripping different characters on all sources.

Let me explain why I decided to reintroduce stripping to Amazon and Freecovers: I am still believing that Amazon will give equal results on both stripping and no-stripping and I would like very much to see if that's true. I also believe it would be beneficial to have Amazon tested for stripping against a much wider sample than those initial 10 albums I did. And regarding Freecovers, if you inspect carefully the results from before, you'll see that it give worst results for stripping for 3 cases, and better results for 2 cases. Being like that, I would like to see the results it would provide for a wider test sample.

Quote
...AllCDCovers...
...protection...irritating, but I'm not going to spend too long trying to work around it and get into some sort of arms race.
I completely agree with you. We (users) can still wait the 15 minute grace period (as Akkurat pointed out) or just follow the link and type the captcha if we can't wait at all to get the image. Trying to implement something to go around it could be pointless, mainly because it would be probably outdated very quickly, as you said.

I'm still testing  and as soon as I'm done, I'll post the results.

Thanks again for everything! 
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-11-10 12:20:04
Quote
...AllCDCovers...
...protection...irritating, but I'm not going to spend too long trying to work around it and get into some sort of arms race.
I completely agree with you. We (users) can still wait the 15 minute grace period (as Akkurat pointed out) or just follow the link and type the captcha if we can't wait at all to get the image.

Hmm, I may have phrased my previous answer a bit oddly (didn't remember the full story and I glanced the post I made in 2008 too quickly). The about 15 minutes is the time when you can see the images in the result list, after that EVERY search to AllCDCovers will yield the leech prevention images only (there seems to be an IP detection too, not just the "hash" I wrote about). At least that's how it was back then. Below is a quote from the post I linked to:

...So, it seems that this would happen in AAD if user searches some covers and doesn't touch the results for a while. After that "don't leech" image, all subsequent searches would yield only thumbnails (or possibly the "don't leech" image) for X amount time which has been set by AllCdCover in the server side. Yes, it's definitely an IP address leech prevention; right after the both above image URL's "failed/timeouted", all my AAD searches started to show only thumbnails.

I then waited about 20-30 minutes and ran AAD search again, still thumbnails. Then some browsing in their website, all full size images load up fine. Back to AAD, still thumbnails. Tried to close&reopen AAD, nope, still doesn't work.  Nasty leech prevention.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-10 14:17:03
Why not include a txt file with this reference in the program folder?
I'd rather have a proper documentation or help file in the program folder, the command line reference is just supposed to be the equivalent of the output you get for passing /? into a command line tool. If you want it as a file, though, just copy and paste it into Notepad and save it.

I also thought it could be good to include the sources names in the reference, since the users will be using them quite often.
Part of the point is that there should be no fixed set of sources (as anyone can write and distribute them - although I haven't really seen this happen), but I agree that when there's proper documentation it will probably contain a list of the most common ones. For now, you can get a list either by going to http://album-art.sourceforge.net/Updates.xml (http://album-art.sourceforge.net/Updates.xml), or using the command line tool: aad.exe /listSources

It could be good also to have an abbreviation system for the various sources
The names of the sources are specified by the sources. If you want, you can edit those in your local copy to be those abbreviations, or anything else you find convenient. I suppose I could add the capability for a source to define both a full and abbreviated name for itself, but I'm not sure it would be used much.

This way, it's always best to re-set everything again (just to be safe).
Just delete the user.config file, that will make sure everything is reset!

Still, I think it's advisable to always disable [ArkivMusik] by default. It's usually (for most users, probably) a waste of bandwidth.
It is listed in the installer under "Classical". If they've chosen to install it, then I'm not going to have it disabled by default. I expect that most scripts outside the "General" category in the installer will not be useful for most users, but some of them will be, and it's not up to me to decide which are and which aren't.

I'm still testing  and as soon as I'm done, I'll post the results.
I look forward to seeing the conclusions! 0.32 is ready to go apart from this, so once the scripts are updated in whatever way turns out to be best, I'll release it.

Alex
Title: Album Art Downloader XUI
Post by: randal1013 on 2009-11-11 01:49:53
0.32 is ready to go apart from this, so once the scripts are updated in whatever way turns out to be best, I'll release it.

Alex


probably a stupid question, but: will version 0.32 still require .NET framework 3.5 on windows 7 x64?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-11 08:04:17
will version 0.32 still require .NET framework 3.5 on windows 7 x64?
Windows 7 x64 includes the .NET Framework 3.5 already, so you don't need to download or install it yourself.
Title: Album Art Downloader XUI
Post by: randal1013 on 2009-11-11 13:15:52
good  that's what i wanted to hear.
Title: Album Art Downloader XUI
Post by: Benji99 on 2009-11-13 06:18:32
I've just found out about this amazing program today.
It's amazing!

I have a small question, I want to save artist pictures into a static folder, say M:\Pictures\%artist%.jpg
I'd like to know if it's possible to download multiple pictures for the same artist and have AAD save the files as %artist%-0.jpg, %artist%-1.jpg or something like that so I don't have to rename every additional picture I want to download.

NOTE: I'm using it with foo_run within Foobar

Is this possible?
Thanks!
Title: Album Art Downloader XUI
Post by: Benji99 on 2009-11-13 07:48:56
One more question:

- Using the LastFM Artist search, a lot of the pictures are exact duplicates. I'm pretty sure they don't show up as duplicates on the site... Is this normal? If it is, how about a feature request, can you filter identical or near identical pictures from the results?

NOTE: Am I crazy not to be able to edit my original post? I can't find the option anywhere...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-13 08:23:15
have AAD save the files as %artist%-0.jpg, %artist%-1.jpg or something like that so I don't have to rename
Sorry, no, there's no function for an auto-incrementing number in AAD.

- Using the LastFM Artist search, a lot of the pictures are exact duplicates. I'm pretty sure they don't show up as duplicates on the site... Is this normal?
Could you give me the artist name searched for? I'll check it out. If they aren't duplicates on the site, then I can probably fix it. If they are, then no, AAD will not be doing any intelligent image comparison to eliminate similar images.

Thanks for the comments!

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-15 10:02:16
Album Art Downloader XUI v0.32 Released

This version implements several requested features and bug fixes, and sorts out some cosmetic issues on Windows 7. Some changes to the way scripts handle special characters have been made - these are still under review, and updates to the scripts may be released separately later.

My development platform is now Windows 7 x64, but I aim to retain compatibility with Windows XP, so please let me know if anything doesn't work properly, or looks wrong on your OS.

Changes:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.32.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.32.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-11-15 12:59:24
Feature request:
The file browser should stop searching for covers for files which don't actually have an "album" tag in it.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-11-15 14:14:03
Thanks for the update.

One odd thing, how's this possible?
(http://www.imgdash.com/uploads/dfc41_AAD.jpg)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-11-15 14:17:25
A new script is not an update.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-11-15 14:36:32
*Doh* For some reason I thought that the "get more scripts" shows updates too. This is the very reason why I recommended not to use separate systems for updates (I consider new scripts as updates) a while ago.. it might confuse users (or is it just me? ).
Title: Album Art Downloader XUI
Post by: tuxman on 2009-11-15 14:47:07
"Get more" is a quite clear phrasing, isn't it?
Title: Album Art Downloader XUI
Post by: Benji99 on 2009-11-16 07:21:50
Sorry, no, there's no function for an auto-incrementing number in AAD.

Could you give me the artist name searched for? I'll check it out. If they aren't duplicates on the site, then I can probably fix it. If they are, then no, AAD will not be doing any intelligent image comparison to eliminate similar images.

Alex



Hi Alex, almost every search (~99%) for last.fm artists give me duplicates.
Here are a few examples:

Hi-Fi CAMP
AI
YOUR SONG IS GOOD
???
????
????

Btw, I tried 0.32, same problem.

About the lack of auto-incrementing number, how about these suggestions:
- a random number that can be added via a variable
- Even better, a unique number that is somehow unique to that picture (and identifies it), so that next time I run a search, I could theoretically only download new pictures that haven't been downloaded.

Thanks again for the great program!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-16 08:18:50
Feature request: The file browser should stop searching for covers for files which don't actually have an "album" tag in it.

Could you elaborate on that a little? I'm not sure exactly what you're asking for here.

Here are a few examples:[snip]
About the lack of auto-incrementing number, how about these suggestions:
- a random number that can be added via a variable
- Even better, a unique number that is somehow unique to that picture (and identifies it), so that next time I run a search, I could theoretically only download new pictures that haven't been downloaded.

Thanks for reporting those examples; I've updated the LastFM Artist script to 0.4, it should be available for download now.

I'm not sure that a random unique number would be very useful, they would have to be rather large. For example, Cover-b369e5a2-a15c-40d0-b968-a8f8f37b8f56.jpg wouldn't make for a very good name, in my opinion.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2009-11-16 16:13:30
Could you elaborate on that a little? I'm not sure exactly what you're asking for here.

The "Search for audio files" window also finds files without an actual album tag. I think these should not be listed at all, as it is quite useless...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-16 19:00:32
The "Search for audio files" window also finds files without an actual album tag. I think these should not be listed at all, as it is quite useless...
As it stands, files with either an album name or an artist name available (either through tags, or path pattern matching) will be listed. If it doesn't have either, then it won't be. I think this is the correct behaviour.

If you want to remove all results where an album name is not visible, then just click the album name column header to sort by it, then you can easily select and remove them from the list (hit the Delete key).

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2009-11-16 19:03:31
As it stands, files with either an album name or an artist name available (either through tags, or path pattern matching) will be listed.

What is the deeper sense of finding images of the artist for an unknown album via an application called Album Art Downloader?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-16 19:55:12
What is the deeper sense of finding images of the artist for an unknown album via an application called Album Art Downloader?
Off the top of my head, I'd say: Finding artist images, finding images for albums where the album name is missing (but known, and can be typed in), or finding albums whose path doesn't quite match the defined pattern. There may be others, or maybe no-one has ever wanted to see them in the list, but I certainly don't feel confident enough to say that they are always unwanted.
Title: Album Art Downloader XUI
Post by: tuxman on 2009-11-16 19:59:58
So maybe a simple check box would do. Like... no more manual sorting.
Title: Album Art Downloader XUI
Post by: Ross1 on 2009-11-17 12:34:21
dunno if its been mentioned, but it would be great if the search for id3 tags could use the album artist tag. At the moment, on any album which has different track artists but an overall album artist, it just lists that as 'various artists', so its search results arent very good.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-17 13:55:41
it would be great if the search for id3 tags could use the album artist tag.
It already does. For an ID3 tag it will, by preference, use the TPE2 frame (which is technically Band, but most media players use it for Album Artist). If that's not present, it will fall back on TPE1 (Artist). Unfortunately there is no standard Album Artist tag, but TPE2 is the closest there is to such a thing.
Title: Album Art Downloader XUI
Post by: Mar2zz on 2009-11-26 19:17:43
After installing last weeks Vista patches AAD stopped working. It doesn't start anymore and Vista proposes to search for an online solution (but finds nothing).

Here is the log Vista gives (sorry for Dutch language, if that is troubling I can try to translate for you):
Code: [Select]
  Probleemhandtekening:
  Gebeurtenisnaam van probleem:    APPCRASH
  Naam van de toepassing:    AlbumArt.exe
  Versie van toepassing:    0.30.0.0
  Tijdstempel van toepassing:    4aa37be7
  Naam van foutmodule:    StackHash_27f2
  Versie van foutmodule:    0.0.0.0
  Tijdstempel van foutmodule:    00000000
  Uitzonderingscode:    c0000005
  Uitzonderingsmarge:    00011535
  Versie van besturingssysteem:    6.0.6002.2.2.0.768.3
  Landinstelling-id:    1043
  Aanvullende informatie 1:    27f2
  Aanvullende informatie 2:    325055436168101a578479ab72a66d1a
  Aanvullende informatie 3:    21e2
  Aanvullende informatie 4:    c8b0deb27397de66dbbb0cb7ca788765

Lees onze privacyverklaring:
  http://go.microsoft.com/fwlink/?linkid=50163&clcid=0x0413
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-30 18:44:05
After installing last weeks Vista patches AAD stopped working.

Thanks for reporting this. Could you try updating to the latest version (0.32) (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) and see if the problem still occurs?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: fromsilenceandanything on 2009-11-30 19:12:30
Greetings,

I have a custom of marking release types in folder names and tags for anything else than full albums, e.g. (demo), (single). For example, I'd name the folder of my Windowlicker single by Aphex Twin like this:

1999 - Windowlicker (single)

And the album tag would be:

Windowlicker (single)

This is obviously problematic when searching for covers, because the "(single)" suffix messes up the search. Is there a way to get around this without having to rename everything, maybe via a script or something? I'm really bad at manually sorting stuff like this out myself, so I need your help.  I have so many small releases that getting all the covers manually would be quite a drag.

If this has been asked before I'm sorry, and I hope you can point me to that reply where it's addressed. I tried searching the thread to no avail.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-11-30 19:45:38
Is there a way to get around this without having to rename everything, maybe via a script or something?
Hello,

There's a couple of options here, I think. I'd suggest that the 'correct' solution would be to use the foobar Mass Tagger tool to strip off the suffix from the Album tag and place it in it's own custom tag, as it's a separate bit of data. However, I understand perfectly if you can't be bothered with that, or want to keep the suffix within the Album tag for compatibility with some other software or process.

Another option is for Album Art Downloader to use the folder name instead of the tag to determine the album name. This is done by clicking the Options link on the file browser window, and selecting the option to use a path pattern. You don't mention where the artist name appears in your path, though - if it doesn't appear anywhere (you have all your album folders in the same base folder rather than in artist sub-folders), then there could be a problem as AAD can't currently take the album name from the path and the artist name from the tags, it has to be both together.

If I assume the simplest case that your folders are in Artist folders, and that you always have a year separated by a - , and that there is always a suffix are enclosed in parenthesis and separated by a space, then you could use the path pattern:

\%artist%\* - %album% (*\.

That will take the artist name as everything that comes between the - and the ( in the folder name.

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: fromsilenceandanything on 2009-11-30 19:49:52
Thanks for the swift reply man. You're ace.

Yeah, my folder structure is like this for every release:
Aphex Twin\1999 - Windowlicker (single)\01 - Aphex Twin - Windowlicker.mp3, etc.

I'll try out what you wrote. Thanks again!

EDIT: Yes, the script you posted works perfectly. Now I'll have some fun time downloading dozens of covers, yay.
Title: Album Art Downloader XUI
Post by: Mar2zz on 2009-12-01 18:14:07
After installing last weeks Vista patches AAD stopped working.

Thanks for reporting this. Could you try updating to the latest version (0.32) (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) and see if the problem still occurs?

Thanks,

Alex


Sorry I was on a little vacation so I couldn't try earlier, the same happens (also, when updating album art doesn't recognize the folder it was early installed in correctly, it tries to install itself in a subfolder AlbumArtDownloader in the folder the program is initially installed in):
Code: [Select]
Probleemhandtekening:
  Gebeurtenisnaam van probleem:    APPCRASH
  Naam van de toepassing:    AlbumArt.exe
  Versie van toepassing:    0.32.0.0
  Tijdstempel van toepassing:    4affcd54
  Naam van foutmodule:    StackHash_27f2
  Versie van foutmodule:    0.0.0.0
  Tijdstempel van foutmodule:    00000000
  Uitzonderingscode:    c0000005
  Uitzonderingsmarge:    0001102e
  Versie van besturingssysteem:    6.0.6002.2.2.0.768.3
  Landinstelling-id:    1043
  Aanvullende informatie 1:    27f2
  Aanvullende informatie 2:    325055436168101a578479ab72a66d1a
  Aanvullende informatie 3:    21e2
  Aanvullende informatie 4:    c8b0deb27397de66dbbb0cb7ca788765

Lees onze privacyverklaring:
  http://go.microsoft.com/fwlink/?linkid=50163&clcid=0x0413


(i forgot to mention, I also reinstalled (repaired) .net framework)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-01 18:48:54
I've done some searching, and the only even vaguely helpful suggestion I could find for crashes of this sort was to turn off DEP for the application causing the crash. There's a reasonably good set of instructions here (http://www.updatexp.com/dep-exceptions.html) (for XP, but Vista should be the same).

As to why it would be crashing like this at all, I'm afraid I don't know. Album Art Downloader is written in 100% managed .net code, and this error occurs at a lower level - so something is going wrong in the .net framework itself, but I've got no way of finding out what it is.

Alex
Title: Album Art Downloader XUI
Post by: Mar2zz on 2009-12-01 19:32:16
Thank you for answering that fast. Vista won't let it add me to DEP. But I discovered another program that stopped working, Handbrake. I believe this one has also .net 3.5 dependency.

It's in there for sure, that nasty bug.

This really sucks. This asks for a reinstall and/or switch to win7 or xp. So far my Vista experience for 3 months...
Title: Album Art Downloader XUI
Post by: OrcaMarinha on 2009-12-04 22:14:07
Ok I have installed this and got it working by browsing foobar library I got all albums without album art on queue , it searched but now I have to click in 50 windows to save it.. Is there any way to order to save from every window automatically ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-05 08:05:40
Is there any way to order to save from every window automatically ?
No, you have to choose a result each time. With autoclose turned on, this can just be double-clicking on the one you want (which will save that image, then autoclose will close the window, and the search queue will open the next one). It isn't currently possible to have it automatically select the best result for you though.

Alex
Title: Album Art Downloader XUI
Post by: Mar2zz on 2009-12-07 09:02:00
I am on W7 now and don't experience any problems anymore! Working again, and now I got some covers to search
Title: Album Art Downloader XUI
Post by: Benji99 on 2009-12-07 12:01:51
Ok I have installed this and got it working by browsing foobar library I got all albums without album art on queue , it searched but now I have to click in 50 windows to save it.. Is there any way to order to save from every window automatically ?


Hey there, can I ask how you managed to queue all the tracks without album art?
I'm trying to do the same thing!

Thanks 
Title: Album Art Downloader XUI
Post by: Mar2zz on 2009-12-07 12:52:26
You need to open file browser or foobarbrowser in AAD. Start a window, go to File > New and choose a browser. (for it to work with foobar you need to install comserver component). In the window that opens define your path or playlist and click search.
Title: Album Art Downloader XUI
Post by: sylla on 2009-12-12 11:34:26
Does anyone have any idea about where my foo_run script is going wrong? Nothing happens when I run it... It used to work, but after I upgraded to windows 7 and the new version of this plugin, it doesn't

Code: [Select]
C:\Program Files\AlbumArtDownloader\AlbumArt.exe  /ar "%artist%" /al "%album%" /p "$replace(%path%,%filename_ext%,)folder.jpg


I got the path from foo_run "..." button so the path should be right, however, I can't even open the program with a script like

Code: [Select]
C:\Program Files\AlbumArtDownloader\AlbumArt.exe


The program runs fine when I start it through windows ("C:\Program Files\AlbumArtDownloader\AlbumArt.exe")

Possibly a foo_run issue, but thought I'd get more help here

Windows 7/9.6.9/0.32.0.0

Title: Album Art Downloader XUI
Post by: loft on 2009-12-13 00:07:58
One thing I'm trying and I don't seem to figure out how to do it.
I am using front.%extension% as the main source of AlbumArt. So this is the query that I'm giving File Browser to search for. If there's no front, I'll look for one. But...
Many times I find the back cover, inside, CD, etc. And if they're there why not download them too. So I want to use %type%.%extension% as the saving pattern. But, the saving pattern seems to be automatically taken from the search pattern in the browser. So if I search for front.%extension% that's what I have to save; and if I search for %type%.%extension% I get false covers (whatever file finds first).

My question is: can I search for front.%extension% and save as %preset%.%extension% or %type%.%extension%?

Thanks for the great tool!
Title: Album Art Downloader XUI
Post by: Benji99 on 2009-12-13 01:18:24
Quick question, I sometime have multiple %artist% tags.
Is it possible from within Foobar's foo_run to launch multiple Album Art Downloader XUI windows with the respective artists?
Title: Album Art Downloader XUI
Post by: tuxman on 2009-12-13 01:24:12
Quick question, I sometime have multiple %artist% tags.

How?
Title: Album Art Downloader XUI
Post by: Benji99 on 2009-12-13 01:35:02
Quick question, I sometime have multiple %artist% tags.

How?



What do you mean?
If multiple artists have contributed on a track, I have them tagged separately
Title: Album Art Downloader XUI
Post by: tuxman on 2009-12-13 01:39:48
I mean, literally how?
There is only one ARTIST tag AFAIK?
Title: Album Art Downloader XUI
Post by: Benji99 on 2009-12-13 02:08:51
I mean, literally how?
There is only one ARTIST tag AFAIK?


Well my files are FLAC, using Ogg Vorbis comments, I can add whatever tags I want using Foobar. Including multiple Artist tags. You can do that by adding a ';' between the different artists. You might need to add the artist tag to the list of MULTIPLEVALUE fields in the advanced options (I don't remember if it's there by default)
Title: Album Art Downloader XUI
Post by: tuxman on 2009-12-13 04:36:20
Ah, another thing that was new to me. Thank you.
Title: Album Art Downloader XUI
Post by: DArtagan on 2009-12-13 05:07:22
I'm always amazed at the integration features put into this program.  I have been doing some heavy use with foobar2000, foo_run, and the AAD command line and I consistently run into the same problem.  Any album or artist containing the characters "&.;:?!'" will search flawlessly, but will not automatically save the image, I must manually edit the save path.  Is there any way for me to instruct AAD how I want it to handle these invalid characters?  Thank you for help.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-13 08:32:32
Does anyone have any idea about where my foo_run script is going wrong?
Have you tried putting quotes around the path? "C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /ar "%artist%" /al "%album%" /p "$replace(%path%,%filename_ext%,)folder.jpg"
That's worth a go.

My question is: can I search for front.%extension% and save as %preset%.%extension% or %type%.%extension%?
Not at the moment, sorry! The only thing you can do is a Save As and type the name in like that. You could also try %preset%.jpg or %type%.jpg as the first image to search for (which is what's used for the save path), and have front.%extension% as an alternative image to search for: %preset%.jpg|front.%extension%

That would find any *.jpg and front.*, which might give some false covers, but probably won't (.jpgs in your folders are probably covers).

Quick question, I sometime have multiple %artist% tags.
Is it possible from within Foobar's foo_run to launch multiple Album Art Downloader XUI windows with the respective artists?
I don't think foo_run can do this. You could try asking in a foo_run thread, but as far as I know it can only launch one process per command. I'm not even sure how it handles tags with multiple values at all.

Any album or artist containing the characters "&.;:?!'" will search flawlessly, but will not automatically save the image, I must manually edit the save path.  Is there any way for me to instruct AAD how I want it to handle these invalid characters?
If you pass invalid characters directly to the path parameter, it will use them exactly as you passed them, and probably display an error if you try to save. If the invalid characters are part of the artist or album name and are substituted into the path, then invalid characters are automatically replaced by _. For example, the command line /artist "who:me?" /album "yes!" /path "c:\music\who:me?\yes!.jpg" would fail to save, but the command line /artist "who:me?" /album "yes!" /path "c:\music\%artist%\%album%.%extension%" would save as "c:\music\who_me_\yes_.jpg".

Note that to pass the % character through foo_run, it must be escaped as %%, so you write /path "c:\music\%%artist%%\%%album%%.%%extension%%"

Alex
Title: Album Art Downloader XUI
Post by: sylla on 2009-12-13 12:32:34
Does anyone have any idea about where my foo_run script is going wrong?
Have you tried putting quotes around the path? "C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /ar "%artist%" /al "%album%" /p "$replace(%path%,%filename_ext%,)folder.jpg"
That's worth a go.


That worked, thanks! And thanks for this wonderful program.
Title: Album Art Downloader XUI
Post by: Joe30 on 2009-12-15 16:22:52
I just found out about your program. It's very nice, it worked for many of my albums.
But for the rest of my albums, the "File Browser" finds "Artist = 1" or "Artist = .". I'm 100% sure my tags are correct, I use Tag&Rename. Thus, I have to manually change the artist.
What's wrong ?

Thank you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-15 17:49:08
the "File Browser" finds "Artist = 1" or "Artist = .".
If the artist and album are part of the file or folder name, you could use file path pattern matching instead of tags. Alternatively, would you be able to send me a sample track that shows the problem? I can analyse the tags on it and find out what's going wrong.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-17 09:36:08
AlbumArtExchange.com script removal
I've had a request to remove the AlbumArtExchange.com script, from the site owner (Scott (http://www.albumartexchange.com/forums/memberlist.php?mode=viewprofile&u=61)), as it's taking up too much of their bandwidth. That script will therefore not be included in v0.33. I'm sure he'd appreciate it if you were to stop using it (or even just scale back on it's usage, you can set it to download only one result, or to not be Search First so it's only searched if no other source finds anything).

If you want to provide feedback to me, post it here. If you would rather AlbumArtExchange read it, try their forums (http://www.albumartexchange.com/forums/viewforum.php?f=1).

Alex
Title: Album Art Downloader XUI
Post by: (Sly) on 2009-12-17 10:01:31
I'm using your program only for this script. I hate your program because it uses crappy dotNET. If AlbumArtExchange.com script leaves the package and it will be banned by future releases than i will mostly AlbumArtExchange.com for searching manually. And AAD XUI looses priority.
Title: Album Art Downloader XUI
Post by: Joe30 on 2009-12-17 11:29:27
the "File Browser" finds "Artist = 1" or "Artist = .".
If the artist and album are part of the file or folder name, you could use file path pattern matching instead of tags. Alternatively, would you be able to send me a sample track that shows the problem? I can analyse the tags on it and find out what's going wrong.

Alex


OK, thank you.

Another little annoying thing I found is this:
When I right-click on a folder, and "Browse for Album Art...", after the selection, I can select a picture and it is saved in the corresponding folder. Great.
But let's say there is a little problem with the tags found (too many words, ...), and in the found pictures there is'nt the correct folder image. Then I manually modify the artist or album name, then search again. But then when I save a picture, it is saved in C:\...pictures, instead of in the starting folder. Would it be possible to add this please ? If I right-click on a folder, and manually modify the tags to look for, retain the original information of the directory. ?
Title: Album Art Downloader XUI
Post by: mobyduck on 2009-12-17 12:16:33
I've had a request to remove the AlbumArtExchange.com script
Sad news cause, IMHO, AlbumArtExchange is one of the best sources (quality wise). I really hope an agreement can be reached that will avoid this drastic move.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-17 13:20:11
Then I manually modify the artist or album name, then search again. But then when I save a picture, it is saved in C:\...pictures, instead of in the starting folder.
Try unchecking "Open search results in new window" in the options pane of the search window. That way, after you modify the artist or album name, the search will take place in the same window, and the results saved to the same folder.

Alex
Title: Album Art Downloader XUI
Post by: drbeachboy on 2009-12-17 14:40:53
I'm using your program only for this script. I hate your program because it uses crappy dotNET. If AlbumArtExchange.com script leaves the package and it will be banned by future releases than i will mostly AlbumArtExchange.com for searching manually. And AAD XUI looses priority.
Who cares what you use? What an ingrate. This is not Alex's fault. Alex. great program, and thank you.
Title: Album Art Downloader XUI
Post by: richard123 on 2009-12-21 22:02:10
Who cares what you use? What an ingrate. This is not Alex's fault. Alex. great program, and thank you.
+1
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-24 10:14:58
Album Art Downloader XUI v0.33 Released

This version adds one of the most requested features: automatic batch downloading and saving. To use this, in the File or Foobar Browser window, click the Options link and select the "Automatically download and save the first result that meets set criteria" option. Then, as long as you have more than one album selected when you click the "Get Artwork for Selection" button, a new "Get Artwork Automatically" window will appear. The first time this is shown, a warning message is also displayed, as this will download and save art without further prompting, even when overwriting an existing file. You can check that the criteria for minimum and maximum size are set correctly, and that the sources you want to search are selected, including any you might have set to search first.

There is also a new criterion you can set, for cover type (which is also now available as a filter in the normal search window). Covers with types which don't match one of the checked options will not match as results.

When everything is set the way you want it, click the Start button. From that point on the process can be left unattended. Each album will be processed in turn, with a search being done on each selected source, one at a time, until a result matching the size and cover type required is found. Sources marked as Search First will be searched first, then any remaining selected sources. Once a matching result is found, it is downloaded and saved, then the next album is processed. Only one result per album is downloaded, which will be the first one that matches the criteria set.

Happy Christmas!

Other changes:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.33.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.33.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: Momotombo on 2009-12-24 10:32:06
I'm having a really strange problem. When I use the foobar browser, it detects album art in every single folder at a size of 0x0 for almost every folder. I can't tell which folders have art and which ones don't.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-24 10:56:30
I'm having a really strange problem. When I use the foobar browser, it detects album art in every single folder at a size of 0x0 for almost every folder. I can't tell which folders have art and which ones don't.
I suspect this is a problem with the "Specify path to find images" setting. This must be a filename (or path) which it can use to recognize an image. If your covers are called Folder.jpg, that makes it very easy, but if your covers could have various names (Front.jpg, Back.jpg, etc.) then it makes it harder. One option is to use ".jpg" instead of .%extension%, and just ignore non jpeg files. There are very few non jpeg covers anyway.

Alex
Title: Album Art Downloader XUI
Post by: LordWarlock on 2009-12-24 14:52:04
Is there someone capable enough to write new AlbumArtExchange script? They can force Alex to stop distributing it with the program, but they can do nothing if it's manually added by the user from an external source.
Title: Album Art Downloader XUI
Post by: gelat on 2009-12-26 10:01:39
Not sure what happened, but I used to drag and drop the images to my music folders. If I had an image there already named folder.jpg (my default filename to save as), I would get the standard windows overwrite dialog.

today, I can't drag and drop at all if there is already an image. For some reason, AAD offers the option to overwrite the file in C:\WINDOWS, even though that is not the folder I am in....

what happened?

I am using version .33 and Windows 7, 64bit
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-26 10:34:59
today, I can't drag and drop at all if there is already an image. For some reason, AAD offers the option to overwrite the file in C:\WINDOWS, even though that is not the folder I am in....
Could you send me a screenshot of the overwrite window? Are you sure that it is offering to overwrite the file in c:\windows, rather than claiming that the destination file is in c:\windows? The Windows 7 Copy File dialog has two options, the first one is "Copy and Replace", under which it lists the source file, and the source folder, and the second one is "Don't Copy", under which it lists the destination file and destination folder.

Confusion may arise because when dragging an image out of Album Art Downloader, there is no source folder. Windows erroneously then displays the c:\windows as the source folder. You can try this with other applications that drag virtual files out (like attachments from emails, or embedded objects from WordPad), it always displays the Windows folder if there is no actual source folder.

Alex
Title: Album Art Downloader XUI
Post by: gelat on 2009-12-26 20:30:14
Ok, I attached the dialog.jpg to show that it shows "C:\windows" destination when I drag and drop images.
(http://gelat.com/dialog.jpg)

I also attached the error.jpg to shwo what happens when I double click an entry to just save to the default folder. Only with album art exchange
(http://gelat.com/error.jpg)

Oddly, I can drag and drop from any source, and it works, regardless of the C:\windows issue, EXCEPT album art exchange. When I drag and drop, it fails. Noting happens, no error, just nothing.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-27 08:04:58
Ok, I attached the dialog.jpg to show that it shows "C:\windows" destination when I drag and drop images.
Yes, it's as I thought. In my earlier post I explained: where it says c:\windows in that screenshot, it is talking about the source of the copy not the destination. It's saying that the destination file will be replaced by the file Folder.jpg from the folder c:\windows, not that it's going to replace anything in the c:\windows folder.

In fact the source has no folder, the file doesn't exist yet. Windows mistakenly displays files with no source folder as coming from the Windows folder, and I haven't found any way to tell it not to display a source folder at all.

I also attached the error [...] with album art exchange
I'm afraid I can no longer provide support for the Album Art Exchange script, as I've agreed to remove it from Album Art Downloader. If the old script has stopped working, then it is probably due to AlbumArtExchange.com having made changes to their site specifically to block it, and as I'm no longer providing the script I won't be releasing an updated version to work around their changes.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-12-27 09:56:27
Album Art Exchange script still working like it used to. No problems at all with XP. "Double click save to default folder" works, and so does the "drag and drop". I find it hard to believe that a site admin could change the website so that a separate app fetching the pages would start to crash (error message).. I'd call it a security hole in the app. 

Alex, was there any discussion of possibly using the script in AAD? I understand the site owner on one hand, but then again, the site (+the new movie art exchange.. branching out?) is totally illegal.. I guess I find it a bit "funny" that an illegal site issues (well kind of) DMCA notice..

AAX admin:
Quote
I do not want AAX to be accessable through these programs. In fact, I asked three different vendors to remove us from their software. Why? Well, running this site is not cheap and direct access to the images means that nobody will be be buying music through the links here which of course, means that the expense will be all on me. We have grown so much and so quickly that we are going to have to move to a dedicated server by year end or January which will easily double the cost of running this site. I MIGHT talk to one of these vendors about an exclusive product that would allow adding images from AAX to your music but at this time, there are no firm plans for this.
(source) (http://www.albumartexchange.com/forums/viewtopic.php?f=1&t=1549)
Title: Album Art Downloader XUI
Post by: Der Internet on 2009-12-27 10:39:41
Hello, i found this great tool yesterday and spent 2 hours trying to figure the right filesyntax out.

My music is in this Folder Structure:

\Artist\Year - Album\Artist - Tracknumber - Title (Multidiskreleases are: \Artist\Year - Album\CDx\Artist - Tracknumber - Title), Various are in: Sampler\Albumname (Year)\ or in Soundtracks\Albumname (Year)\

Now i want the programm to save the artwork in the songfolder, using the Infos of the found Artwork as the filename (Cover, Back, Inside, Unknown). So i entered in the File Browser "Specify path to images" this:

%preset%.%extension%

I edited the Presets so  its fits with my structure. Now i had a list near the Floppy in the Download dialog where i could chang the type. if i choosed Back the cover the cover were saved to Back.jpg. But if i just klick the floppy, it always saves as the Default type, whether it has the Type: Unknown, Back, CD or Front and so on. How can i get this worked?

My second problem is, through the fileformat %preset%.%extension% i entered in the Options of the Filebrowser, that while scanning my files all albums were shown as if they had a coverm whether they do or not. What do i have to enter there that i still can save presets but scan my collection still correct?

thank you very much, sorry for my crappy english 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-27 10:49:17
Album Art Exchange script still working like it used to.
I haven't done anything myself that would disable it, just stopped including it in the installer and making it available for download. AAD does not have the capability to remotely delete a script through the online updates mechanism, and I don't believe in writing software that acts against the wishes of the owner of the PC it's running on.

On the other hand, it's quite easy for the site admin to stop the script working - it accessed AlbumArtExchange through an API, all they would need to do is close, change, or move that API, and the script could no longer access it.

I did ask whether there was a possibility for a compromise solution, but it doesn't look like anything's going to happen. I was not sent any sort of DMCA notice or legal threat, but a polite request from the site owner himself. As far as I'm concerned, that gets a much better response from me. If you want to lobby for reinstation of the script, I suggest you take it up directly with Scott or on their forums.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-27 10:55:28
it always saves as the Default type, whether it has the Type: Unknown, Back, CD or Front and so on. How can i get this worked?
The %preset% placeholder is used to provide a dropdown where you can choose an option to save as. I think what you are looking for is the %type% placeholder, which inserts the type (Unknown, Back, etc.) of the cover.

fileformat %preset%.%extension% i entered in the Options of the Filebrowser, that while scanning my files all albums were shown as if they had a coverm whether they do or not.
This problem has been raised a few times, so I'm thinking of ways to resolve it. The basic issue is that if the art filename is %preset%.%extension% then when looking for existing art, the files searched for is "*.*", as %preset% could be anything, and %extension% could be anything. A temporary fix is to assume that all your art files are .jpg, and use %preset%.jpg instead, so that it searches for "*.jpg" files. Of course this isn't ideal, but luckily there are not many covers that aren't .jpg's.
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-12-27 17:49:17
I haven't done anything myself that would disable it, just stopped including it in the installer and making it available for download.

Knew that. My point was: that GDI+ error doesn't (or shouldn't (security)) happen because of AAX site changes.. it could happen with other sources too.

If you want to lobby for reinstation of the script

No no, nothing like that. I'm smart enough  to understand that that would be fighting against windmills.  Also, like I wrote, I do understand every side of this situation, and I really like your attitude and actions, even if that means that I've to learn BOO at some point.

P.S. Would adding a DPI information to search results be useless/clutter? (after the full image was fetched)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-27 18:09:08
GDI+ error doesn't (or shouldn't (security)) happen because of AAX site changes.
It seems that AAX was returning partial or corrupted image data. Whether intentionally or not, this would cause a an error when GDI+ tries to parse it as an image. It doesn't crash or otherwise adversely affect AAD, except of course for not being able to save that image file. This would only be a security concern if there was an exploitable vulnerability within GDI+, which could be triggered by a maliciously formatted image file. It's not impossible, and has in fact happened before in GDI (not plus). When it does happen, though, it's a bigger concern than just AAD as anything that views images would be affected.

For DPI information, does that generally get correctly populated? I expect I can probably get at that metadata if necessary, but from what I can tell no-one bothers to set it anyway. You're better off just looking at resolution, as you already know what physical size a CD cover is.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-12-27 18:53:13
Quote
no-one bothers to set it anyway

It gets set when scanning.. and that's what I was thinking about. Just learned that amending it afterwards makes the DPI info in AAD kind of pointless.. if it's the original scanning value, then it would be useful. In the light of this new info about DPI, I say forget it. Just an idea that came to my mind when comparing several same album images in win explorer (or rather in "windows picture and fax viewer").. a 300dpi image was slightly better quality than other same size 72dpi image.
Title: Album Art Downloader XUI
Post by: AlbumArtExchange.com on 2009-12-28 06:47:02
I've had a request to remove the AlbumArtExchange.com script
Sad news cause, IMHO, AlbumArtExchange is one of the best sources (quality wise). I really hope an agreement can be reached that will avoid this drastic move.

Alessandro



Hello,

My name is Scott and I am the owner of AlbumArtExchange.com. I understand your disappointment at my request and I am sorry to have to make it. Last month, non site traffic was at about 20% which is totally ridiculous. As quoted elsewhere in this thread is the matter of the cost of running a site on a decent host isn't cheap and about to get more expensive. The site cannot continue on a shared server and we are moving to a dedicated one and are barely meeting expenses as is. I want to preserve the integrity of this artwork by not plastering my site with unrelated advertising and giving out iPods in exchange for junky contributions. I have no interest in making a profit and with this moral code in place, I doubt that I will. I just want the site to operate as well as possible and handle an increasing amount of traffic and survive without my wallet. This requires users coming into the site through the front door.

What was not quoted was my other concern that our contributers often work long and hard on these images (I am one of them). They deserve the view count, votes and kudos for their efforts. The only way to do this is through the site.

While I understand your disappointment at my request and future security changes, I don't understand WHY AAD and similar programs are necessary to access the site. Is the search interface that we have not useful enough? Listen, I REALLY know that this is gonna sound arrogant and is it NOT meant in that way: I played with AAD quite a bit to see if I could find images of better quality than on my own site and I am proud of that I did not. God that sounds smug but, I swear it's unbiased. In your opinion are we lacking in the way of content that you need to compare it to raw scans and Amazon images? Do you want more back covers? With Safari you can just double click the thumbnail and the save or drag the actual full sized image.

Cheers,
Scott
Title: Album Art Downloader XUI
Post by: mobyduck on 2009-12-28 08:39:22
Hi Scott and thanks for taking time to share your POV.
I don't understand WHY AAD and similar programs are necessary to access the site.
Speaking only for myself here, I can give you two reasons: first, who uses those kind of programs often has no idea where to search (poor excuse, I know, but I for one didn't even know your site existed before using AAD); second, while your site is great, it simply cannot cover (no pun intended ) every need: when searching for some obscure or exotic (read: any music that is not in the UK/US domain) album I need to widen my search scope as much as possible.
What was not quoted was my other concern that our contributers often work long and hard on these images (I am one of them). They deserve the view count, votes and kudos for their efforts. The only way to do this is through the site.
How about a link in AAD that opens a browser page instead of allowing direct download if a match is found on your site? I'm not a programmer so perhaps this is not something Alex is willing to do but I thought I'd try anyway.

Regards.

Alessandro

Edit: edited to tweak my poor English, sorry.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-28 09:40:10
How about a link in AAD that opens a browser page
This already exists - the little round (i) symbol on a result indicates that there is a web page with more information for the result available; clicking on it opens the link in your browser. Most sources have these links available.

I don't understand WHY AAD and similar programs are necessary
If you're actually serious here, I'll give you a quick set of points:

Convenience of searching
Starting from your album collection, either as files in a folder or tracks in your media player, AAD can search directly for that album across multiple sources. You don't have to copy and paste the artist and album name. You don't have to search for sites to use. You don't have to figure out how to use those sites - for example, there's no Search link or button on your front page. It's not immediately obvious that you have to go to Gallery, and the search box on that page is not exactly obvious - at a glance you could easily think that the page is just a gallery to browse through. I'm not picking on your site in particular, there are other sites used by AAD which are even harder to figure out how to actually do a search.

Multi-threaded operation and improved search results UI
Both searches, and the download of full size images, is carried out in the background. If there are a few images you'd like to compare at full size, then clicking each of them to start the download will set them all downloading simultaneously. They will simply replace the thumbnail with the full-size image when it's ready, allowing easy side-by-side comparison at any size, and instant zooming preview simply by holding the mouse button down on them.

Convenience of saving
AAD will generally know exactly where, and with what filename to save your artwork. This can be because it has been told directly by the application that launched it, because it knows the folder the album music files are in, or because you've told it your filing scheme so it can work it out from the album and artist names, and other information available to it. This means that to save the image, you just need to press Save. You don't need to navigate to the right folder. You don't need to type in the right name. Just press save. With the latest version, if you so choose, you don't even need to do that, it can save the first matching result for a whole set of albums automatically, populating missing album art in your collection without further interaction.

Breadth of availability
Having multiple sources over multiple nationalities and genres means that chances are that if what you are looking for exists, it will be found. Quality is important (and AAX does have excellent quality), but availability can be even more important. A low-res poor cover may still be better than no cover at all. As a quick test I had a look through the latest requests on your wish list forum, and multiple results at over 1000x1000 were available for all of them.

Other artwork
Personally, I just use front covers, but I know some people also want back covers, CD images and inside covers.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2009-12-28 11:15:05
How about a link in AAD that opens a browser page
This already exists - the little round (i) symbol on a result indicates that there is a web page with more information for the result available; clicking on it opens the link in your browser. Most sources have these links available.
Oh my... thanks for pointing that out and apologies for my ignorance.

So do you think it would be possibile to cripple AAX results only so that no images are returned and only that link is available? Or being AAD script-based this is just nonsense?

Alessandro
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-12-28 14:09:03
Alex, Scott, would it be possible to make an exclusive deal between AAD & AAX?

Mock up example:

(http://img706.imageshack.us/img706/4739/aadaax.jpg) (http://img706.imageshack.us/i/aadaax.jpg/)

If AAX source selected, AND it returns results, display advert from AAX. The above works nicely if "group by" is set as "source". If that setting is something else, FORCE AAX source to display like in "group by: source", others like the setting dictates. This way the AD would always be above AAX results. What do you say? Disclaimer: I've very poor knowledge of how online adverts work (is it load count, click count, etc.?).

And add text link ("vote here"?) per cover if that is really required.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-28 14:35:49
display advert from AAX.
Sorry, that's not going to happen.

On principle, I don't write adware. Even apart from the more general principle of not writing software that acts against the interests of the owner of the PC it's running on, I block ads in my browser, and it would be a touch hypocritical to then try to foist them on others.

In practical terms, it wouldn't work anyway as scripts are user-editable, so they could just edit out the ad-serving part of it.

In business terms, it wouldn't work as online ad providers are pretty fussy about where and how their adverts appear. There are ad providers specifically for client side applications (not websites), but those are generally even worse.

Alex
Title: Album Art Downloader XUI
Post by: AlbumArtExchange.com on 2009-12-28 17:39:45
Hello Alex,

My original statement was "I don't understand why AAD and similar programs are necessary to access the site[/u]." I understand the purpose of the program itself    I am with you on the front covers only, until a month ago, this has been our primary focus. As an experiment we have been adding select back covers (sans track lists) and sleeves because some are quite beautiful.

If there were some way to only call up the browser page while not allowing direct access, I would be alright with that. I would of course want it to call a detail or gallery page with the result(s) and not the page with the image itself . For example:

http://www.albumartexchange.com/covers.php?id=74171 (http://www.albumartexchange.com/covers.php?id=74171)
or
http://www.albumartexchange.com/covers.php...;bgc=&page= (http://www.albumartexchange.com/covers.php?sort=4&q=Ray+Brown+%26+Jimmy+Rowles+tasty&fltr=1&bgc=&page=) 

and never this: http://www.albumartexchange.com/gallery/im...wn-tasty_02.jpg (http://www.albumartexchange.com/gallery/images/public/jb/jbrown-tasty_02.jpg)

Cheers,
Scott
Title: Album Art Downloader XUI
Post by: AlbumArtExchange.com on 2009-12-28 17:48:39
Alex, Scott, would it be possible to make an exclusive deal between AAD & AAX?

Mock up example:

(http://img706.imageshack.us/img706/4739/aadaax.jpg) (http://img706.imageshack.us/i/aadaax.jpg/)

If AAX source selected, AND it returns results, display advert from AAX. The above works nicely if "group by" is set as "source". If that setting is something else, FORCE AAX source to display like in "group by: source", others like the setting dictates. This way the AD would always be above AAX results. What do you say? Disclaimer: I've very poor knowledge of how online adverts work (is it load count, click count, etc.?).

And add text link ("vote here"?) per cover if that is really required.


A resourceful approach and I like that idea however, most of what little funds come in are from Amazon. These are the ads that are on the LH side of the image on the detail pages and specific to each image. Sadly, my banners don't make me much at all. I have a new banner campaign which started a few days ago, we'll have to see about its performance.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-28 18:01:45
My original statement was "I don't understand why AAD and similar programs are necessary to access the site[/u]."
I'm not sure I see the distinction... there's not much point to the program if it can't access the site. The points I listed were what the program offers that using the site on its own does not.

As far as browser page access goes, the script already provided access to cover pages (from the <gallery-page> node in the xml file) through the (i) link. Personally, I wouldn't bother using the source if it meant I had to open the web page to save the image manually - but if people here would find it useful, and Scott would find it acceptable, I can provide a version of the script that gets thumbnails only from Album Art Exchange, and continues to provide the (i) link to open the gallery page.

Alex
Title: Album Art Downloader XUI
Post by: Zarggg on 2009-12-29 00:21:31
Scott, I just have a few comments to make and please don't take them personally; they're not directed against you, your site, or anything of the sort. They're just observations I have made:

The Internet is trending towards remote polling and aggregating of content. Information and content that were previously solely available on websites, FTP directories, Usenet articles, etc, are becoming more widely spread through aggregation with technologies like XML/RDF and RSS. Take podcasts for example: Originally, these were downloaded directly from the sites that provided them; now RSS feeds can be used by software to dowload various podcasts from various sources. iTunes is another meta-example: It can download podcasts, purchased music, and album art for use in a single device.

Users are going to want to start using these third-party programs to get this kind of information even more as time goes on. And as long as there are multiple sources for this information -- particularly when the quality between these sources varies so much -- programs like Album Art Downloader will be in the public demand.

That being said, I appreciate your position. I just wanted to give you some perspective from the other side of the line.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-30 09:17:54
New script: lala.com
I had a request for a script for lala.com, which looks like a pretty good source for mid-sized covers. I've knocked up a quick script for it here: lala.boo (http://album-art.sourceforge.net/scripts/lala.boo), if anyone would like to take it for a quick spin and let me know if there are any problems with it before I push it out through the Online Updates service.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-12-30 11:46:37
Seems to work ok. Fast source. Pretty good quality covers. Though it only really searches "artist" covers (like couple of other sources do), and it seems to report some wrong image sizes initially (again like couple of other sources do), previewing will reveal the true smaller sizes. Just try searching e.g. Muse / Showbiz.

EDIT:

Try Muse / Origin search, returns 3 covers, one proper with correct size, 1 other artist album (mark taylor - spectre) and 1 proper cover but wrong size (shows first 550x550px, then when clicked to preview: 170x170px). Just an example.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-30 12:16:48

Thanks for that. Some of the results it includes in searches are frankly baffling, I agree - but I can't find any sort of Advanced Search option or anything like that on the site.

For the size thing, the size is unreported, but from the site it appears that all the full size covers are supposed to be 550x550 - on those examples you mentioned it appears as a small cover in a large white space. I could just have it always report the size as unknown, but I think there's probably enough of them at that size for it to be a useful first guess?

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2009-12-30 12:40:13
Personally I'd like to have it set to unknown if you can't glean any proper info from them. E.g. search Muse / Showbiz returns 8 covers, 4 of those are smaller 170x170px sized (+3 wrong album covers).. too much for my taste.  Anyways, the "download unknown size images" setting is there and works very beautifully.. and in this example, gets rid of 3 wrong covers.

Another example: search Muse / black holes and revelations = 2 results, 1 odd 80x80px "blank" image of an "eighth note".
Title: Album Art Downloader XUI
Post by: AlexVallat on 2009-12-30 13:03:45
Personally I'd like to have it set to unknown if you can't glean any proper info from them.
Yeah, I guess you're right. This source seems quick enough with the full size images that it isn't a big hardship to have them download to find the size of them.
Title: Album Art Downloader XUI
Post by: Innuendo_ on 2009-12-30 18:34:05
Adding LaLa is great, but do keep in mind that Apple just bought them & it's up in the air what's going to happen to the site. Rumors are rampant that LaLa will be rolled into iTunes.

Oh well, it'll be a good source for covers while it lasts, I guess.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-01-02 09:19:36
Album Art Downloader XUI v0.34 Released

This is primarily a bug fixing release. I've also made the existing image pattern matching stricter in the file and foobar browsers, so if you have an image path of %type%.%extension% it will now match Front.jpg, but not Track1.mp3. %name%, %source% and %preset% still count as * for matching, but other placeholders are more strict. %size% must be in the "number x number" form. If you need looser matching, add it as an alternate. For example, if you want images saved as Cover(%size%).%extension%, but want to also match against existing covers named Cover(small).jpg, use a pattern of "Cover(%size%).%extension%|Cover(*).%extension%". That way, Album Art Downloader will save with the size placeholder, but will still find existing files matching the less restrictive pattern.

Other changes:


Edit: A nasty bug was pointed out to me with the automatic downloader, so I've rolled a fix for that into this release as 0.34.1

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.34.1.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.34.1.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: KarnEvil9 on 2010-01-02 18:09:45
Thanks for the update, and Happy New Year!
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-01-04 15:44:22
Not a biggie, can you show the whole AAD version in the "check for updates" dialog? Edit: Have I asked this before? Was it sourceforce that prevented this? Just had a short WTF moment with the 0.34.1 update.
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-01-04 16:47:40
One strange thing. Recently I've noticed that sometimes when I remove a cover, the whole AAD GUI seems to "freeze", can't select/push/etc. any fields/buttons/etc., I even can't scroll the source list anymore, and the mouse icon doesn't change on hover. After I move the mouse icon over window title bar (window maximized), the "freeze" seems to be gone. Any ideas? .NET fu.. fudging up, can I say, again?

P.S. Would a "remove whole source results" feature (right-clicking over the source name when group by source selected) be of any use to somebody else than me? (I've longed for a feature like that couple of times recently.. after the current remove feature appeared)
Title: Album Art Downloader XUI
Post by: helstegt on 2010-01-04 19:02:56
Does the program support ID3v2.4 fully? When I try to search for albums based on ID3 tags often only the artist or the album name is listed, even though both are filled out when I view the files in Foobar.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-01-04 19:35:25
sometimes when I remove a cover, the whole AAD GUI seems to "freeze"
[snip]
"remove whole source results" feature
That's a strange bug. I'll see if I can reproduce it, but it looks suspiciously like one I won't be able to do anything about.

To remove all the results from a source, simply uncheck it and hit the Search button again. Hitting Search the second time will add results from any newly selected sources, and remove results from unselected sources.

Does the program support ID3v2.4 fully? When I try to search for albums based on ID3 tags often only the artist or the album name is listed, even though both are filled out when I view the files in Foobar.
Should do. It uses TagLib# (http://developer.novell.com/wiki/index.php/TagLib_Sharp). If you can isolate a specific file that you think is being misread, and you can send it to me, then I can take a look at that file and see what's going on. Otherwise, you can get the tag information directly from Foobar by using the Foobar browser instead of the File browser.

Alex
Title: Album Art Downloader XUI
Post by: helstegt on 2010-01-04 20:58:26
Should do. It uses TagLib# (http://developer.novell.com/wiki/index.php/TagLib_Sharp). If you can isolate a specific file that you think is being misread, and you can send it to me, then I can take a look at that file and see what's going on. Otherwise, you can get the tag information directly from Foobar by using the Foobar browser instead of the File browser.

Sent you a PM.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-01-05 10:06:39
Sent you a PM.
Thanks for that. I've taken a look at the file. The problem isn't ID3v2.4, the problem is that the tag is slightly corrupt. Fortunately Foobar seems capable of ignoring the error, but TagLib# is not. If you use Foobar to re-write the tag information, it should clear up the problem. What software did you use to tag the file in the first place?

Alex



Technical details:The file sent has the first ID3 frame, TPE1, with a text encoding flag of $01 (UTF-16). That text encoding flag specifies that the string must terminate with $00 00 (ref (http://www.id3.org/id3v2.4.0-structure#line-366)), however it does not, it simply ends with no termination, and is immediately followed by the next frame (TIT2).

Code: [Select]
000000  49 44 33 04 00 80 00 00 11 1f 54 52 43 4b 00 00 00 04 00 00 00 30 33 00 54 50  ID3.......TRCK.......03.TP
00001a  45 31 00 00 00 20 00 03 00 00 00 1b 01 ff 00 fe 45 00 6c 00 6c 00 65 00 6e 00  E1... .......ÿ.þE.l.l.e.n.
000034  20 00 41 00 6c 00 6c 00 69 00 65 00 6e 00 54 49 54 32 00 00 00 28 00 03 00 00   .A.l.l.i.e.n.TIT2...(....
Title: Album Art Downloader XUI
Post by: helstegt on 2010-01-05 10:48:38
Sent you a PM.
Thanks for that. I've taken a look at the file. The problem isn't ID3v2.4, the problem is that the tag is slightly corrupt. Fortunately Foobar seems capable of ignoring the error, but TagLib# is not. If you use Foobar to re-write the tag information, it should clear up the problem. What software did you use to tag the file in the first place?


I am trying to isolate the problem which I have identified as coming from somewhere in my tagging procedure. I use Tag&Rename and Foobar for tagging.

Also, as this problem exists with a ton of my files, do you, (or anyone else), know of an easy way to let Foobar go through all of my files in order to fix this problem? Tagging > Re-write file tags does not seem to solve the problem, as Album Art Downloader is still not able to read all the info.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-01-05 11:34:26
I've checked out Tag&Rename, and that isn't the cause of the problem. It should be able to solve it, though. Select all your files, and use the Multi-File tag editor. Uncheck all the fields (so it won't make any changes), then click the Save Tags button. It will then re-write them.

Alex
Title: Album Art Downloader XUI
Post by: helstegt on 2010-01-05 11:51:18
I've checked out Tag&Rename, and that isn't the cause of the problem. It should be able to solve it, though. Select all your files, and use the Multi-File tag editor. Uncheck all the fields (so it won't make any changes), then click the Save Tags button. It will then re-write them.

It does indeed solve the problem, thanks a lot.

I am unable to reproduce the bug at the moment, but I am completely sure that the bug is introduced either in Foobar or Tag&Rename, as I have been able to compare the file I sent you with my original download of the file, which, prior to my tagging operations, does not exhibit the bug when viewed with Album Art Downloader. I have been using Foobar 0.9.6.9 and Tag&Rename 3.5.3 to tag the files.
Title: Album Art Downloader XUI
Post by: EagleScout1998 on 2010-01-07 03:32:46
I am disappointed to see Album Art Exchanged removed. It is, by far, the best resource for album art that I have discovered thus far. And to be frank, I would not have discovered it were it not for Album Art Downloader.

Anyway, for those that use the Firefox browser, there are three search engine plugins for albumartexchange.com allowing users to search directly from their Firefox search bar by Artist, Date, or Title.

Click the link below for more information:
http://www.albumartexchange.com/forums/vie...x+plugins#p2832 (http://www.albumartexchange.com/forums/viewtopic.php?f=1&t=591&p=2832&hilit=firefox+plugins#p2832)
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-01-10 22:56:51
To remove all the results from a source, simply uncheck it and hit the Search button again. Hitting Search the second time will add results from any newly selected sources, and remove results from unselected sources.

That's a different feature altogether. And after the search I'd have to remember to check all them back? Not very logical nor user friendly.

Let me try to show where I'd use it and how:

1) ~6 "search first" sources produce some results, sometimes a lot
2) not 100% happy with any of the covers
3) if lots of wrong/totally not suitable even for comparison covers, I'd like to remove most of them, if not all before extended search
4) extended search usually shows lots of new covers I'd like to compare to the covers shown with the "search first"
5) here too possibly removing some covers/sources for easier comparison

Additionally, when I've "group by source" and "sort size", the extended search many times "shuffles" the sources so that the source order is changed and if there's lots of wrong/totally not suitable even for comparison covers, it gets messy when the other sources pour lots of new covers. Maybe I can't properly explain this but, anyways, the remove covers feature made me realize that if I could remove source results completely, it would sometimes make the cover choosing procedure easier for me. Maybe not for everyone. I don't make feature reqs just for fun.  Thanks for reading.
Title: Album Art Downloader XUI
Post by: meDveD.spb on 2010-01-11 21:23:52
AlexVallat
What about support APEv2 tags of TAK files in 'File Browser'?
when I drag-and-drop TAK files in a File browser window - AAD does not read tags
but all is well with MP3/WAVPACK/MUSEPACK/APE (APEv2 tags) files.
In 'foobar browser' all ok.
Title: Album Art Downloader XUI
Post by: meDveD.spb on 2010-01-17 13:37:00
I have one more problem..

I have this track:11. Рубль - Обезьяна.mp3 (it is free track) (http://sites.google.com/site/medvedssss/Home/11.Рубль-Обезьяна.mp3?attredirects=0&d=1):
(http://img233.imageshack.us/img233/7969/60546983.th.png) (http://img233.imageshack.us/my.php?image=60546983.png)

preference page in foobar2000 v1.0:
(http://img233.imageshack.us/img233/9819/15673027.th.png) (http://img233.imageshack.us/my.php?image=15673027.png)

when I drag-and-drop this file in ADD File Browser (problem with tags?):
(http://img156.imageshack.us/img156/7061/16986773.th.png) (http://img156.imageshack.us/my.php?image=16986773.png)

then I open mp3tag (http://www.mp3tag.de/en/) and click save:
(http://img233.imageshack.us/img233/263/24885243.th.png) (http://img233.imageshack.us/my.php?image=24885243.png)

size unchanged
(http://img233.imageshack.us/img233/5804/97154543.th.png) (http://img233.imageshack.us/my.php?image=97154543.png)

but..
then I drag-and-drop this file in ADD File Browser and all is well:
(http://img233.imageshack.us/img233/10/50387983.th.png) (http://img233.imageshack.us/my.php?image=50387983.png)

where is the problem?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-01-17 14:27:20
What about support APEv2 tags of TAK files in 'File Browser'?
It doesn't look like TAK is one of the supported file types by TagLib, sorry.

I have one more problem..
That mp3 file, as downloaded, has slightly corrupted ID3 info. As with the previous case (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=677624), the artist name has not been null terminated. In this case, it is in UTF-8 (type $03), so only needs one null to terminate rather than two, but it doesn't have any! I don't know what piece of tagging software is missing off the tag terminators, but something is doing it.

Rewriting the tags with Mp3Tag fixes it because Mp3Tag writes them out properly. I'm guessing the file size doesn't change because tags involve padding to make sure they align on specific boundaries, and adding a single byte (the null terminator) to a tag isn't pushing it over the next boundary, it just has a little less padding.

The only thing I can suggest is the same as I suggested to helstegt, use Mp3Tag to rewrite all your tags (should just be a simple operation) and they'll be fine, or use the Foobar browser instead of the File browser, as Foobar seems to be more robust to slightly malformed tags.

Alex
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-01-18 17:53:49
Hi! The AllCDCover Plugin seems to be broken. Or disabled ACC their API?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-01-20 15:52:25
Hi! The AllCDCover Plugin seems to be broken. Or disabled ACC their API?

Seems to be working to me - what were you searching for?

Alex
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-01-20 16:12:39
i see.. some covers seems to be broken... but today i checked the one which doesn't worked ysterday and today it works. If i find another one which doesnt work i will post that album, so you can check that
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-01-20 18:08:00
sorry i cannot find the Edit Button O.O

nit happend again today...  the album was Borknagar - Epic.  It loads a dummy pic which says: "Ooops, so ething went wrong.. like you followed an old link "
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-01-20 19:11:17
hm..now the Edit Button appeared but i dont have the permission to edit my own posts 
This picture appears:


(http://img44.imageshack.us/img44/4391/insidegs.jpg)
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-01-20 19:15:15
It's always a good idea to search the topic first (field under the last post).

Quote
...AllCDCovers...
...protection...irritating, but I'm not going to spend too long trying to work around it and get into some sort of arms race.
I completely agree with you. We (users) can still wait the 15 minute grace period (as Akkurat pointed out) or just follow the link and type the captcha if we can't wait at all to get the image.

Hmm, I may have phrased my previous answer a bit oddly (didn't remember the full story and I glanced the post I made in 2008 too quickly). The about 15 minutes is the time when you can see the images in the result list, after that EVERY search to AllCDCovers will yield the leech prevention images only (there seems to be an IP detection too, not just the "hash" I wrote about). At least that's how it was back then. Below is a quote from the post I linked to:

...So, it seems that this would happen in AAD if user searches some covers and doesn't touch the results for a while. After that "don't leech" image, all subsequent searches would yield only thumbnails (or possibly the "don't leech" image) for X amount time which has been set by AllCdCover in the server side. Yes, it's definitely an IP address leech prevention; right after the both above image URL's "failed/timeouted", all my AAD searches started to show only thumbnails.

I then waited about 20-30 minutes and ran AAD search again, still thumbnails. Then some browsing in their website, all full size images load up fine. Back to AAD, still thumbnails. Tried to close&reopen AAD, nope, still doesn't work.  Nasty leech prevention.




This is the 3rd time already, Alex I think that you need a FAQ.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-01-20 19:39:55
It's always a good idea to search the topic first (field under the last post).

This is the 3rd time already, Alex I think that you need a FAQ.

Hah, I'd forgotten about that AllCdCovers thing myself!

You're right, of course, there should be an FAQ. And a manual. And a proper website. Any volunteers?
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-01-20 19:49:17
I'd love to help you out but I've my own problems of allocating time to do everything.  Doesn't sourceforce have a feature which you could use to house the FAQ? Though a proper website would be much better.
Title: Album Art Downloader XUI
Post by: n3x0n on 2010-01-26 12:47:47
When I'm using the Foobar2000 Browser it shows some albums don't have covers. It's incorrect because they do have covers, but they are inside the id3 tag. Is there a way to scan those as well to eliminate redundancy?

Thanks,

Dennis
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-02-01 00:14:13
Hi Alex, using the "stop all" feature while "search firsts" are searching (none results yet) just stops (=skips) the "search first" and continues with the "extended search", wouldn't it make more sense to stop everything? Not a biggie, just noticed this minor annoyance/inconsistency today.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-01 08:14:56
they do have covers, but they are inside the id3 tag. Is there a way to scan those as well to eliminate redundancy?
Not at present. Embedded image support (both reading and writing) is already on the feature request list, and may someday make it into a future version.

Hi Alex, using the "stop all" feature while "search firsts" are searching (none results yet) just stops (=skips) the "search first" and continues with the "extended search"
Yes, that's a bug, I've added an issue (https://sourceforge.net/tracker/?func=detail&aid=2943568&group_id=187008&atid=919575) for it. Thanks for reporting it.

Alex
Title: Album Art Downloader XUI
Post by: fromsilenceandanything on 2010-02-01 21:20:18
If I download PNG images using the program, they all get saved pitch black (fairly reduced gamma or something). Is this a common bug or is there a problem at my end?

Example, in case you'd like to try reproducing it: Gas - Zauberberg front cover from last.fm covers.

EDIT: Well, further examination shows that I can download last.fm artist PNG images without problems using the program. Maybe it's something about the last.fm cover image source code on their site?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-02 08:27:18
Gas - Zauberberg front cover from last.fm covers.
I tried searching for this, and got one result. It was a jpeg and looked fine to me. Can you give any other examples that show the problem for me to try?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: fromsilenceandanything on 2010-02-02 08:37:05
Gas - Zauberberg front cover from last.fm covers.
I tried searching for this, and got one result. It was a jpeg and looked fine to me. Can you give any other examples that show the problem for me to try?

Thanks,

Alex
It shows up as JPG file to you? That's odd. Here's a screenshot:

(http://img535.imageshack.us/img535/2306/aadl.jpg)

As you can see, it shows up as PNG for me. This is what I get when I download the file:

(http://img535.imageshack.us/img535/3935/folderg.png)

The cover is there, but it's barely visible.

But try Moonblood - Taste Our German Steel, also from last.fm covers. It shows up as PNG for me and gets saved pitch black just like that GAS cover does.

And in case you're wondering, I'm using the latest version of the program. I updated after finding out about this, but the problem persists.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-02 09:45:34
OK, I'm getting a .png now, but not the darkened effect, on either example. That's weird. I'll have a look around and see if I can find any info on png saving issues in .net (as it appears to at least be displaying correctly).

Alex
Title: Album Art Downloader XUI
Post by: fromsilenceandanything on 2010-02-02 13:54:32
Right, cheers.

I'm also digging into it. I'm running Windows XP SP2 with .NET 3.5 SP1 on this machine which gives me the pitch black PNGs, but I haven't been able to reproduce the error yet on my laptop which runs Windows 7 (not RTM).

It's quite odd saving artist PNGs works though.
Title: Album Art Downloader XUI
Post by: fromsilenceandanything on 2010-02-02 14:55:52
I tested it on a third machine which runs Windows XP SP3 with .NET 3.5 SP1 and it gave me those black PNGs as well. So to me it at least seems that the problem lies somewhere in Windows XP, but I'm no programmer so I have no actual knowledge on this matter.  You probably know better.
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-02-03 01:17:05
WinXP SP3 here and same thing with that png. Searched the cover with the api commands and saved it from Opera = correctly saved. So it's probably .NET in WinXP.


While I was searching the same cover from the last.fm site (couldn't find it first (from the webpage).. then used the api method), I stumbled onto something good: last.fm has (for some albums, tested only couple) 600x600px album covers too! They're just "hidden".

Found it when checking the source of the Zauberberg album webpage (http://www.last.fm/music/Gas/Zauberberg). The revealing bit:
Code: [Select]
"original":"http:\/\/userserve-ak.last.fm\/serve\/_\/41520903\/Zauberberg.png"
->
http://userserve-ak.last.fm/serve/_/41520903/Zauberberg.png

And when later checking/testing out the api (image) results (http://ws.audioscrobbler.com/2.0/?method=album.getinfo&api_key=2410a53db5c7490d0f50c100a020f359&artist=gas&album=zauberberg), discovered 2 alternative links:
Code: [Select]
http://userserve-ak.last.fm/serve/_/41520903/41520903.png
http://userserve-ak.last.fm/serve/_/41520903.png

Now, the api returns the following info (for this album):

Code: [Select]
<image size="small">
http://userserve-ak.last.fm/serve/34s/41520903.png
</image>
<image size="medium">
http://userserve-ak.last.fm/serve/64s/41520903.png
</image>
<image size="large">
http://userserve-ak.last.fm/serve/174s/41520903.png
</image>
<image size="extralarge">
http://userserve-ak.last.fm/serve/300x300/41520903.png
</image>

I guess it would be "relatively easy"  for a BOO expert to add a check if the "original"/biggest cover exist at all and choose that cover instead.

I seem to enjoy "detective work".. too much.


P.S. Compared "hidden" Zauberberg 600px last.fm cover to the 600px (jpg) Album Art Exchange cover and they seem to be identical, except gamma/brightness. Interesting.
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-02-03 01:37:15
Ahh, remembered another problem: Coveralia script doesn't work properly with "various" albums. It shows  " -  - Frontal/Back/etc." for the "title". And it of course affects the %name% variable. Parsing (regexp?) problems? Just try searching e.g. various / disco.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-03 13:12:39
WinXP SP3 here and same thing with that png.
I haven't had any luck finding any information about why .net (or GDI+, which is what it uses internally) would fail to save .png files correctly under XP SP3. I'll keep an eye out, though, and if I find anything I'll update.

For the hidden last.fm covers, the only thing I can think of would be to check if there was a file with the same name as the album name - but is that likely to always be the case? I suspect that there's no consistent naming scheme for them (just whatever filename they had when uploaded), which is why they aren't returned by the API. I could request the web page and parse the original out of that, but that's not a great solution. I'd much prefer to stick to the API where available.

Coveralia script doesn't work properly with "various" albums.
Thanks, I've fixed this and pushed out an update to v0.10 for that script.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-02-03 17:17:17
For the hidden last.fm covers, the only thing I can think of would be to check if there was a file with the same name as the album name - but is that likely to always be the case? I suspect that there's no consistent naming scheme for them (just whatever filename they had when uploaded)

I think you missed one thing:

API gives out an ID which could be used to fetch the "hidden" bigger* cover.

API: userserve-ak.last.fm/serve/[34s / 64s / 174s / 300x300]/41520903.png

Hidden (alternative 1): userserve-ak.last.fm/serve/_/41520903.png
Hidden (alternative 2): userserve-ak.last.fm/serve/_/41520903/41520903.png

And optionally checking with the (url-encoded?) album name:
Hidden (alternative 3): userserve-ak.last.fm/serve/_/41520903/Zauberberg.png

Last resort.. but I don't think that it's needed after checking the 2 alternatives above.. in fact, I really think that checking only 1 of these alternatives would suffice.

* Not always, couple of my tests showed that this was the same size as the 300px from API.. nevertheless, the "hidden" one would always return the biggest cover available, so it should be selected 1st if available.

Thanks for the super fast update, again! If only other devs could match your support..
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-07 09:55:34
Experimental LastFM Cover update
I've modified the LastFM script, as suggested, to check for a hidden larger image. It will try to find an image of the size '_' (HTTP HEAD request), and if it doesn't receive an HTTP error response, assumes that it's a better result than the named sizes available. Unfortunately it won't know what size that image might be, so the size will display as Unknown until the full size image is downloaded.

lastfm-cover.boo (http://www.byalexv.co.uk/foobar/lastfm-cover.boo)

I'd appreciate any feedback on this, in particular if you find albums where the hidden image is not available (you can tell because the size won't be Unknown), or is smaller than 300x300, or wrong in some other way.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-02-07 15:44:21
Tested with about 30 albums, all images (except check below) at least 300x300px.. be it hidden or taken from API links. Not as much bigger images as I hoped for but nice addition (and partially replacing AAX.. for new users that is ). 1 example where it beats even AAX: TSOOL - Communion (http://userserve-ak.last.fm/serve/_/40972671.png). Working fine. Thanks.

One example where users/testers might think that the modified script fails: searching for Bob James / Three (http://ws.audioscrobbler.com/2.0/?method=album.getinfo&api_key=2410a53db5c7490d0f50c100a020f359&artist=bob+james&album=three) AAD shows an image with 300x300px resolution but in fact is only 160x159px. Look at the API link, for some reason it has links to Amazon instead of the "normal" ones. This is not a failure of the new modified script, it's a failure (=wrong image size determined) of the old (+new) script. Found couple of these cases when testing.

Another example where users/testers might think that the modified script fails: searching for Bob James / H (http://ws.audioscrobbler.com/2.0/?method=album.getinfo&api_key=2410a53db5c7490d0f50c100a020f359&artist=bob+james&album=H) AAD shows an empty image of 300x300px (is in fact 1x1px). All of the API Amazon links are dead. So again, not the fault of the new script.

P.S. I found concrete evidence that some of the covers shown in last.fm are images taken from AAX (bigger image (+same size) in AAX with exactly the same defects).
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-02-08 21:58:09
Hi again!
i have 2 question:
1. sometimes i have to re-edit the search string for album or artist after a serch progress (eg. Albumname: Iron Maiden Live (CD1) - i need to remove the (CD1) to get proper results). But if i change the albumname and press enter or click search the filepath for saving won't fits anymore... it takes the last folder were i saved manually. the weird thing is - if i start a single search and hit the stop button fast enough and then edit the albumname and start the search the filepath is still the right!? Any way to fix this?

2. is it possibly to use AAD to fetch artist pics? cause the tool finds a lot of it while searching for covers. i have all my artist pictures in D:\Artist Pictures\Artistname.jpg
    is there a a search string to to check this folder ? cause then i would just google image search or last.fm artists and the tool would fetch all the artist pics

thanx for your work + help 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-09 08:10:19
Thanks for your investigation. It looks like it is worthwhile replacing the current last.fm cover script with this new one, then: it doesn't make things any worse, and occasionally makes them better. The only downside is the lack of size info, but it sounds like that was unreliable anyway. I've pushed up the new script through online updates

sometimes i have to re-edit the search string
Try clicking the Options link, then unchecking the "Open search results in new window" checkbox.

is it possibly to use AAD to fetch artist pics?
I'm not sure exactly what you are asking for. You already know that AAD can search for artist images using the last.fm artist search script. Do you mean you want to use the file browser to get artist pictures for all the artists you have albums for?

In that case, given the location of the artist pictures you specified, try going to the file browser and in the "Specify path to find images" box put "D:\Artist Pictures\%artist%.%extension%". I think last.fm artist search ignores the album name, so that shouldn't matter. If you really wanted to do a search without the album name, you'd have to use the File Path Pattern Matching instead of ID3 tag matching, and specify a pattern with only the %artist% placeholder and not the %album% one.

I hope that helps,

Alex
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-02-09 11:36:02
it was exactly what i meant thank you very much
by the way, are google image and last.fm artist pictures the only plugin that will fetch artists pics? perhaps a myspace plugin would be nice
Title: Album Art Downloader XUI
Post by: gsa999 on 2010-02-09 21:49:48
Not used this application before, but I want to attempt to get it to trawl through my entire MP3 collection to grab some higher resolution album art.
I have a folder.jpg in all my folders already though which are 200x200. I don't want to get rid of these yet though until I am happy with the larger files that are going to replace them, so is there a way to just get the program to search for all album cover art and ignore my existing folder.jpgs?

Also what exactly does the automatically download full-size images do. I have it marked as Always but it does not appear to do anything. I was rather hoping it would download the largest cover art image it found automatically (I can then do a batch resize to bring them down to 500x500 which is the size I want (I have set the minimum size to 500).

Thanks

Title: Album Art Downloader XUI
Post by: Akkurat on 2010-02-09 22:35:19
Also what exactly does the automatically download full-size images do.

It doesn't "save" anything. It downloads ALL full-size images "to" AAD GUI. If it's off, AAD gets only "thumbnails" and when you click on the image to preview it, AAD then downloads the full-size image. IMO, the best setting for that is the middle one, "get when unknown"; filter by size works best when all sizes are known and covers with already known* sizes are not downloaded automatically, which speeds up the search.

I was rather hoping it would download the largest cover art image it found automatically

Bad idea if you want to have quality covers. Almost always the biggest covers (over 1000px) are straight from the scanner without any editing.. and those look absolutely horrible most of the time.

* Some "known" sizes are sometimes wrong in some sources.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-10 08:01:24
is there a way to just get the program to search for all album cover art and ignore my existing folder.jpgs?
In the File (or Foobar) Browser, click the Options link and edit the box labelled "Specify path to find images:". Replace the existing text with "Folder-new.%extension%" (or anything else you like) so that it uses Folder-new.jpg instead of Folder.jpg. That way it will ignore your existing Folder.jpg files.

I was rather hoping it would download the largest cover art image it found automatically
Bad idea if you want to have quality covers. Almost always the biggest covers (over 1000px) are straight from the scanner without any editing.. and those look absolutely horrible most of the time.
I second that. The results are not usually great, but you can do automatic saving if you want. In the File (or Foobar) Browser, click the Options link and select "Automatically download and save the first result that meets set criteria". Select the albums you want to get art for, and click the "Get Artwork for Selection" button. Instead of the usual search windows, a window will appear which will let you set up the criteria (required size, cover type, sources to search and so on), then you can press the Start button and let it go.

Alex
Title: Album Art Downloader XUI
Post by: Pageygeeza on 2010-02-18 16:48:23
I've been using AAD for a short while now and find it really helpful.

But I have a problem of sorts:  I'm having trouble finding my local content.  All artwork is in a single folder.  As I'm scanning all my covers, probably near 1000, it's a bit of a nightmare.  Some covers filenames are either the artist or album.  I know there is a way to do it through the local content search, but I can't figure it out.  I've hunted through the forums, but can't find anything that works. 

Additional:

Just found that "%album%*" and "%artist%*" work, but is there a way of combining them?

Ok, another thing.  Is it possible to give name wildcards?  Say I have Album "Cars For Stars", could it find the artwork if it's called "Cars 4 Stars"?

Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-19 17:04:27
Just found that "%album%*" and "%artist%*" work, but is there a way of combining them?

Ok, another thing.  Is it possible to give name wildcards?  Say I have Album "Cars For Stars", could it find the artwork if it's called "Cars 4 Stars"?
I'm afraid not, sorry. You can only do a local search for one pattern at a time, there's no way of specifying multiple alternate patterns to search for like there is in the file or foobar browsers. That's something that could be done in the future, though.

I can't think of any way a simple search could find "Cars 4 Stars" given an album name of "Cars For Stars", though. It would have to do some sort of percentage-match based algorithm, and give a list of possible results. I don't think that's going to happen, I'm afraid.

Alex
Title: Album Art Downloader XUI
Post by: Pageygeeza on 2010-02-19 17:33:34
Quote
I'm afraid not, sorry. You can only do a local search for one pattern at a time, there's no way of specifying multiple alternate patterns to search for like there is in the file or foobar browsers. That's something that could be done in the future, though.

I can't think of any way a simple search could find "Cars 4 Stars" given an album name of "Cars For Stars", though. It would have to do some sort of percentage-match based algorithm, and give a list of possible results. I don't think that's going to happen, I'm afraid.

Alex


Cheers Alex, how about getting it to search for a file using the first word from the album title?  I've noticed it's searching for the album string, so could it trim all the words in the album title apart from the first word?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-19 18:34:50
how about getting it to search for a file using the first word from the album title?
That would still be a fuzzy search. The local file source isn't so much a search as a lookup at the moment - if your file is named in a predictable way it can be displayed, but it's not much use for producing a list of potential matches for search terms.

Alex
Title: Album Art Downloader XUI
Post by: stefanv on 2010-02-26 02:29:02
I've recently started using Album Art Downloaded interactively and love it. Now I'm trying to invoke it from a Perl script that I use in the process of transferring all my vinyl records to .MP3s, and am running into trouble. Every time the script invokes AlbumArt.exe, I get an error log containing:

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.34.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.ArgumentException: The property 'SearchPathPatternHistory' could not be created from it's default value. Error message: Item has already been added. Key in dictionary: 'libdir'  Key being added: 'libdir'
  at System.Configuration.SettingsPropertyValue.Deserialize()
  at System.Configuration.SettingsPropertyValue.get_PropertyValue()
  at System.Configuration.SettingsBase.GetPropertyValueByName(String propertyName)
  at System.Configuration.SettingsBase.get_Item(String propertyName)
  at System.Configuration.ApplicationSettingsBase.GetPropertyValue(String propertyName)
  at System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
  at AlbumArtDownloader.LocalFilesSource.Settings.get_SearchPathPatternHistory()
  at AlbumArtDownloader.LocalFilesSource.LoadPathPatternHistory(Settings localFilesSourceSettings)
  at AlbumArtDownloader.LocalFilesSource.LoadSettingsInternal(SourceSettings settings)
  at AlbumArtDownloader.ArtSearchWindow.LoadSourceSettings()
  at AlbumArtDownloader.ArtSearchWindow.LoadSettings()
  at AlbumArtDownloader.ArtSearchWindow..ctor()
  at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)


Even just invoking it from the shell (Cygwin) produces this output.

It doesn't matter what (if any) command line options I specify. Same thing.

I'm aware of AAD.exe, but I still want to interactively choose the downloaded art, hence I'm running AlbumArt.exe.

Is this a known problem? Is there a work-around?

Thanks,
Stefan Vorkoetter
http://www.stefanv.com (http://www.stefanv.com)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-26 10:39:30
Even just invoking it from the shell (Cygwin) produces this output.
This is not a known problem, no. Does invoking it from the Windows command line have the same effect? With perl, is that also via Cygwin, or are you using the Windows perl installation?

You could try deleting your Album Art Downloader settings (delete the folder "C:\Users\<username>\AppData\Local\AlbumArtDownloader", or uninstall and re-install), as the error log indicates that the problem is related to the settings.

Alex
Title: Album Art Downloader XUI
Post by: stefanv on 2010-02-26 15:07:22
Even just invoking it from the shell (Cygwin) produces this output.
This is not a known problem, no. Does invoking it from the Windows command line have the same effect? With perl, is that also via Cygwin, or are you using the Windows perl installation?

You could try deleting your Album Art Downloader settings (delete the folder "C:\Users\<username>\AppData\Local\AlbumArtDownloader", or uninstall and re-install), as the error log indicates that the problem is related to the settings.

Alex


Perl is also the cygwin version. I'll try it from a Windows command-line tonight.

Here's an additional piece of information I discovered late last night: If an Album Art Downloader window is already open (from having clicked on the shortcut), then opening another one from the command line works as expected. So, I have a work-around for now.

Stefan
Title: Album Art Downloader XUI
Post by: kheops on 2010-02-28 09:50:06
hi alex
i have the same "error" talking about the path or file name being too long (i use the file browser)
i've seen your help about a tiny config file in the same path of the program, but the created tracelog.txt gives no help, just stating that "Successfully read application version from settings"
is there a way to know which files i have to rename ?
thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-02-28 12:34:20
i have the same "error" talking about the path or file name being too long (i use the file browser)
If this error is occurring when you click the Search button in the File Browser, then the problem is probably that the path to some of your music is longer than 256 characters. This is a limit imposed by both the windows API and .net. The only solutions I know of are to move your music files to a folder directly off the root of the drive (which usually saves a good few characters), or to use a shorter naming scheme for the folders they are in.

Alex
Title: Album Art Downloader XUI
Post by: liamf on 2010-03-07 21:04:56
Hi,

I just came across this tool and I really like it: however to be of maximum use to me, I need it to be able to a) tell that albums already have embedded ID3 album art and b) be able to store art into the .MP3 files.

(For a start: once it can do those two things, there are several other things which would be amusing. Like flagging inconsistent album art where the embedded art does not match the folder.jpg, or where several tracks in the same album have different album art).

In the spirit of openness and such, I wanted to just modify the code to support this myself and contribute the modifications back for consideration for inclusion into the main version. I have come across in a forum someplace that Alex will not make any changes for ID3 art retrieval/storage which is his prerogative of course.

I am a very experienced S/W developer but I am new to the whole XAML thing. I speak fluent C, C++, Python, PHP, all manner of pseudo-languages (MS app macros etc) a variety of assembly languages, and I have dabbled in C# before so I am not afraid of it.

I downloaded the code from SVN and built it. It builds fine, I can modify it and rebuild and step through it in debug mode and so on, so all is well there.
(In fact in the first instance, just recognizing files which already have embedded ID3 images is quite trivial).
So I think that in principle adding the modifications to support the ID3 stuff will be entirely possible.

My problem is with the Designer in VC# Express 2008 (which I am using for build/debug) will not launch the designer for several of the .XAML files. For instance, FileBrowser.xaml. There are quite a few errors , for example things like "could not create an instance of type StaticExtension". And a few others too.

Could some of the existing developers comment on what toolchain they are using to build?
Any idea why VC# 2008 doesn't like the XAML files?

As I say, I really like this app, it is the best thing out there that I have found, and I also have a real problem to solve using it (pretty much a lifetime supply of MP3s which have no album art and which I want to start accessing via a HTPC setup, so they need art ...) so I am quite motivated to make the modifications for my own use and contribute these mods back.

Will accept hints as to what I might be missing ...

Ta
Liam
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-08 08:37:26
Hello, and welcome! It will be great to have another developer on the project, and I'm certainly interested to see what you come up with for ID3 embedded image handling. I posted somewhere earlier that I considered embedded image reading (for the file browser, and potentially the local files source) to be within scope, but frankly never got round to actually coding it. It was just embedded image writing that I said wouldn't happen, but if you've got a good idea on how this should work then I'd love to hear it.

To answer your question:

The XAML designers are rubbish. They can only open the very simplest of files, and even then produce limited code. Think of XAML like HTML, and the designer as MS Word. If it's a simple file, you could open it in the designer, and even make some simple changes, but for anything substantial it's not going to work - and what it does produce isn't likely to be optimal. For working with XAML, I find the most helpful process is to use something like XamlPadX to reflect live changes to xaml code snippets and produce small parts of UI like that, then copy and paste into the main file.

I hope you'll learn XAML and be able to contribute directly to it; but if it gets too frustrating and is going to put you off entirely, then I can help with producing code from mock-ups.

The toolchain I am using is just Visual Studio 2008, plus NSIS and 7-zip for redistribution. I don't see any reason it wouldn't work in Express - those XAML designer errors are the same as I see in VS2008.

At present I'm the only active developer on this project, so you can PM or email me directly if you have any code questions.

Alex
Title: Album Art Downloader XUI
Post by: liamf on 2010-03-08 09:44:22


Hi Alex,

ah, I see. I had been coming to the conclusion from reading around that the XAML designers were, let's say, immature at the moment.
Good to have it confirmed. It will save me wasting more time on it.

Thanks for the pointer. I will download the tool you mentioned this evening and see if it makes sense.

I'll have to be able to add new controls etc to the UI to control the ID3 image/retrieval thing, and anyway it will be nice to experiment with XAML.
My experiments with ID3 reading are so far confined to adding a few lines of code to the file browser, just to see if it's possible to tell if an image is present (it is) and if you can decide if it is valid (ditto) and if you can decode it to get width/height info from it (ditto again). All that is easy. The next steps will require some UI changes, and some decisions about handling of the tags.

I was thinking that this could be best approached/released in stages:

1. Just detect that an album has embedded art and highlight this in the search results so the user can choose not to download this again
  - which requires some modifications to the UI (to allow the user to enable this)
  - and a modification of the way that results are displayed / highlighted
    - ie folder.jpg found, embedded art found, both found etc
  - and probably to the notion of an "album" to include its tracks, since the "album" only has art in it's entirety if either a folder image exists, or all tracks have art
2. Detection of incomplete embedded art
  - only x out of y tracks tagged etc
3. Detection of inconsistent embedded art vs folder art
  - probably the only thing that is feasible is binary difference between art
  - display of the inconsistent images, selection which of these is the best match, or just re-fetch from clean
4. Optional storage of art into .MP3 files in addition/instead of storing to folder.jpg
  - which definitely requires the matching of tracks to albums in case users have multi-album per folder setups, a not-unlikely scenario
5. ... and possibly other things that I have not thought of yet.

I do have a day job, and my interest in AlbumArt Downloader is part of a larger project involving building HTPCs and wiring and such.
But I would definitely like to get involved. I have tried applying art to a large, fairly disorganised .MP3 collection using MediaMonkey and a plugin for it called Batch Art Finder, but batch art finder while a valiant effort is very unstable, practically impossible to install (and tends to break at random after installation due, I think, to Windows updates - my installation is broken again and apparently unfixable), unpredictable, limited in it's searches, extremely slow, and not stand-alone to not really a good candidate for modification.

I will email you to take this conversation off the forum. It will be quicker to ask some questions rather than figure out from first principles how some things work. When I figure out what your email address is.

Cheers
Liam
Title: Album Art Downloader XUI
Post by: liamf on 2010-03-08 10:59:50




By the way, in case anyone is wondering.

I tried VC# Express 2010 Beta 2 as well, just for the laugh.

The XAML designers for that don't load the XAML files either.
Different error message but they fail at the same statements.

So I will be consigning the 2010 version to the recycle bin for the moment.

Liam
Title: Album Art Downloader XUI
Post by: punkrockdude on 2010-03-08 14:38:36
This is an awesome program! Thank you! Regards.
Title: Album Art Downloader XUI
Post by: stefanv on 2010-03-08 15:58:46
Even just invoking it from the shell (Cygwin) produces this output.
This is not a known problem, no. Does invoking it from the Windows command line have the same effect?


I finally got around to trying it from the Windows command line, and it does work in that case. I wonder if there's some environment variable or other that it's failing to pick up when invoked from the Cygwin shell or perl?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-08 18:47:00
I wonder if there's some environment variable or other that it's failing to pick up when invoked from the Cygwin shell or perl?
I installed Cygwin myself, but couldn't reproduce the problem. I think you're right about it being an environment variable or setting, but most likely something additional that's set in your Cygwin environment, rather than something missing. Does "libdir" mean anything to you?

Alex
Title: Album Art Downloader XUI
Post by: ice.fire on 2010-03-09 07:54:56
how to save the cover in the music file directly
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-09 07:59:55
how to save the cover in the music file directly
This is not supported in the current version. Until very recently I'd have also said that it won't be, but liamf is now working in this area, so it might be possible in the future.

Alex
Title: Album Art Downloader XUI
Post by: stefanv on 2010-03-09 14:07:05
Does "libdir" mean anything to you?

Alex


Yes, I have an environment variable called LIBDIR set. It's used as part of my development environment. I guess I should try unsetting it to see if that solves the problem. I never clued into that in the error log because it says "libdir", not "LIBDIR" and I'm used to working in case-sensitive environments.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-09 14:28:17
Going out on a bit of a wild guess here, but could you check to see if you have it set twice, perhaps with different casing?
Title: Album Art Downloader XUI
Post by: silkcut on 2010-03-10 21:00:11
Hi. Can anyone help me to get this program working with foobar2000?  I've searched all over but can't find a simple set up guide or instructions.

i am running foobar2000 v1.0 on Win7 64-bit.  I downloaded the latest AlbumArtDownloaderXUI-0.34.1.exe and installed it.  I opened the program and selected New Foobar Browser.  The Foobar2000 status window says: Foobar2000 COM Automation Server must be installed before the Foobar library can be accessed.  So I clicked on the message which launched a link to http://www.hydrogenaudio.org/forums/index....showtopic=39946 (http://www.hydrogenaudio.org/forums/index.php?showtopic=39946)  I downloaded the installer - foo_comserver2-0.7-setup - and installed to C:\Program Files (x86)\foobar2000.  I closed and relaunched AlbumArtDownloader and opened a new foobar browser.  Again, the same message appears along with "Could not connect to foobar2000 automation server".  So I opened foobar2000 and looked in the Preferences.  Under COM Automation Server it says "Not running: Operation unavailable". 

Please help.  Thank you.
Title: Album Art Downloader XUI
Post by: stefanv on 2010-03-10 21:25:00
Going out on a bit of a wild guess here, but could you check to see if you have it set twice, perhaps with different casing?


I don't seem to have libdir set, but unsetting LIBDIR seems to solve the problem.

Thanks!

Stefan
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-11 07:45:10
So I opened foobar2000 and looked in the Preferences.  Under COM Automation Server it says "Not running: Operation unavailable".
I think the best place to ask would be in the Foobar2000 COM Automation Server thread. Hopefully someone there will be able to help you figure out why it isn't working. Once that's working, the foobar browser in AAD should work fine.

Alex
Title: Album Art Downloader XUI
Post by: fenningenarius on 2010-03-13 03:27:59
This is a fantastic program.  Many thanks to the developer.

Is aad.exe unable to look in local folders for existing images the way that albumart.exe can?  The help file for aad.exe mentions "Local Files" in one of the examples of how to use the /exclude command but mine doesn't have "Local Files" or anything similar in the list of sources that /listSources outputs. 

Thanks for the help. 

Title: Album Art Downloader XUI
Post by: GHammer on 2010-03-13 03:43:26
Suddenly, the COM server does not want to operate and foobar reports it as a component that causes crashes.
Any ideas on a better way of interfacing with foobar?


EDIT- Fix drunken spelling
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-13 08:03:38
I don't seem to have libdir set, but unsetting LIBDIR seems to solve the problem.
If it is only set once, then I can't figure out why it would cause a crash, sorry. As a workaround, as you are running AlbumArt.exe from a script, could you perhaps unset it before calling AlbumArt.exe and re-set it afterwards? I know it's not ideal.

Suddenly, the COM server does not want to operate and foobar reports it as a component that causes crashes.
That's a shame. Any idea what changed? I'd suggest posting in the [a href='index.php?showtopic=39946']COM Automation Server[/a] thread, maybe there will be a fix or a new version. If not, and the COM server has become unsupported and no longer works with the latest version of Foobar at all, then I'll have to remove the Foobar browser window and rely on just the File browser window.

Alex
Title: Album Art Downloader XUI
Post by: stefanv on 2010-03-13 13:36:06
I don't seem to have libdir set, but unsetting LIBDIR seems to solve the problem.
If it is only set once, then I can't figure out why it would cause a crash, sorry. As a workaround, as you are running AlbumArt.exe from a script, could you perhaps unset it before calling AlbumArt.exe and re-set it afterwards? I know it's not ideal.


I can just unset it in the script. The script runs in its own environment, so any changes made will be undone when the script exits.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-13 15:13:48
Is aad.exe unable to look in local folders for existing images the way that albumart.exe can?
Thanks for your comments. No, I'm afraid the Local Files source is not available in the command line version (aad.exe) - it's my mistake to have left it in the command args help, sorry. I'll correct that for the next version.

Alex
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-03-15 22:47:52
I have thousands of mp3 singles.  They are filenamed "Artist - Track Title" and all tags are removed except for "Artist" and "Track Title".  They are currently all in one folder but could easily be put in individual folders with the same naming system.

However, as the singles do not come from an album I have not found a way to be able to download artwork from Discogs etc.  Discogs does however have the vast majority of artwork for my singles.  Is there a solution please?  I don't see why a search by artist - track title cannot work 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-16 07:58:17
Is there a solution please?  I don't see why a search by artist - track title cannot work 
If you put in the artist and track title (in the album box) by hand, and search the discogs, do you get useful results? I would expect so, as there's nothing in the discogs script that restricts it to just albums, so if discogs returns results for singles they should show up too.

Assuming that works, then the only difficulty with what you are trying to do is that the track title tag won't be read as the 'album name' in the file browser. To get around this, click the options link (in the file browser), and select File Path Pattern Matching instead of ID3 tags. In the path pattern box, you can put the pattern "\%artist% - %album%.*" to match your naming scheme.

The only other issue is what naming scheme to use for the art. If they're all in one folder, you can't use just "Folder.jpg", but something like "%artist% - %album% cover.%extension%" or "covers\%artist% - %album%.%extension%" (to keep them in a subfolder called covers) would do the job. Put it in the "Specify path to find images" and it will be the default place to save images when searching from the file browser too.

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-03-17 21:01:41
For the record, I think this works thanks!  But, the functionality to actually write art to the tags is a big plus to me and so I'm probably going to end up using mp3tag anyway.  But you tool and support are great!
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-03-18 00:26:25
actually, on 2nd thoughts i will use a combination of both tools 
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-03-18 01:28:59
OK, another problem    when I call up AAD from mp3tag it the "file path to save to" in AAD keeps defaulting back to D:\blah    .I therefore have to enter D:\blah\%artist% - %album%.%extension%  everytime I call up AAD from mp3tag - a real pain!  Is there something I can do about this?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-18 08:12:05
when I call up AAD from mp3tag it the "file path to save to" in AAD keeps defaulting back to D:\blah
What is the command line you are using to call AAD from mp3tag? If it includes the path, then you can just remove that and AAD will default to whatever the last set path was. Or, you can include the path in the command line, but ensure it is just "D:\blah\%artist% - %album%.%extension%" rather than constructed by mp3tag.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-18 08:14:37
actually, on 2nd thoughts i will use a combination of both tools 
Oh, and for the record, in my opinion this is the correct approach. AAD is for finding and downloading cover art. mp3tag is for managing tags. Embedding album artwork in all its track files is a tagging task.
Title: Album Art Downloader XUI
Post by: Joe30 on 2010-03-19 16:04:17
Hello~
Let's say I have all my music in folders in the folders form of "%artist% - year - %album%".
Is there a way to automatically grab some artist.jpg (very high quality ones) files from some sites for my while library ?

Thank you~
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-03-20 11:25:18
AAD seems to forget some settings chosen to modify the scripts e.g. in the Juno search, I want to set it to "always download full images" and I don't want to limit it to 10 results.  But I often have to rest this manually.  I took a look in the script and could not see anything obvious to change the default.  How would I do this please?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-20 12:09:59
AAD seems to forget some settings chosen to modify the scripts
This isn't something that can be set in the script, it is a setting AAD stores for it. It is stored with all the other program settings, so if it is forgetting them then that's a bug. If you can tell me anything specific that you know makes it forget the settings, I'll see if I can figure out what's going wrong.

It shouldn't matter which script it is, unless you are modifying the script to change its name.

Alex
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-03-22 00:25:20
AAD seems to forget some settings chosen to modify the scripts
This isn't something that can be set in the script, it is a setting AAD stores for it. It is stored with all the other program settings, so if it is forgetting them then that's a bug. If you can tell me anything specific that you know makes it forget the settings, I'll see if I can figure out what's going wrong.

It shouldn't matter which script it is, unless you are modifying the script to change its name.

Alex


The google images script seems to only return 20 results even if I untick the limit box or put a number >20 in the limit box and leave it ticked.  Discogs and Juno work fine though.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-22 07:57:03
The google images script seems to only return 20 results even if I untick the limit box or put a number >20 in the limit box and leave it ticked.  Discogs and Juno work fine though.
Yeah, that's a limitation of the script. It only gets one page of results from google, so it won't return more results than google returns on one page.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2010-03-23 21:25:09
Hey Alex,

I'm trying to create a script for some users of a private image hosting site. Unfortunately I just realized that while I might stay logged in for years on Firefox, the AAD script has to do its own logging in. I'm pretty new to this sort of thing, so I'm wondering if there's a way to fill out forms and hit submit, without being able to build a "login.php?user=Mordred&pass=blah" type string, because I don't think that will work here sadly.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-24 07:51:33
I'm wondering if there's a way to fill out forms and hit submit

There are two ways in which forms can be submitted, POST or GET (if you look at the source, it's the "method" attribute on the <form> tag). If it's a GET form, then you construct the url string in the way you indicated in your post. Unfortunately, most forms are POST. In fact, even if it is a POST it's usually worth at least trying it as a GET as several server-side libraries abstract the obtaining of parameter values so that it doesn't matter which method is used, it works just the same.

If you do have to submit a POST form, then here's some boo code to do the job:

Code: [Select]
static def Post(url as String, content as String):
  request = System.Net.HttpWebRequest.Create(url)
  request.Method="POST"
  request.ContentType = "application/x-www-form-urlencoded"
  bytes = System.Text.UTF8Encoding().GetBytes(content)
  request.ContentLength = bytes.Length
  stream = request.GetRequestStream()
  stream.Write(bytes,0,bytes.Length)
  stream.Close()
  streamresponse = request.GetResponse().GetResponseStream()
  return System.IO.StreamReader(streamresponse).ReadToEnd()

To use it, the content parameter should be the field names and values in the form, the same as if you were constructing a url for a GET form, so something like: "user=Mordred&pass=blah".

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2010-03-24 18:56:19
Thanks Alex. Unfortunately I'm still having some issues, and I'm not sure what the problem is. The form is a POST. I attempted a GET, but no dice.

I'm now using the above code, and am passing it a correct login string (verified with firebug) and when I do I get an error page back (basically the page you'd get if you attempt to access index.php without logging in first). If I pass an incorrect login string I get the login page back with a "bad login/password please try again" message.

I'm wondering if the problem might somehow be related to cookies or something? There doesn't happen to be a script out there using form POSTs currently is there?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-25 07:57:07
I'm wondering if the problem might somehow be related to cookies or something?
It's possible. I haven't seen it used, but it's possible that it might use that as security (so accessing the login page sets a cookie, that must then be sent with the username and password). I have seen referrer checking, and user agent string checking. Without being able to access the site itself, I can only suggest you experiment with it.

Cover-paradies, coverisland and psyshop all use POST, in slightly different ways. Cover-paradies and coverisland also set the referer header, in a couple of different ways.

Alex
Title: Album Art Downloader XUI
Post by: TommyTopper on 2010-03-25 17:41:16
'Found' this app again from a looong while back.  I was having some teething problems with it at the time, but it now works flawlessly for me, thanks AlexVallat.

Has anybody ever worked out a solution for 'art' for various songs in a folder?  I have 3000 songs which are named <number> - <Artist> - <title> (with the numbers going from 0001 to 3000).  Is there any way of getting 'art' for these tracks the way they are kept at the moment?

Thanks,

T.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-26 07:40:45
Is there any way of getting 'art' for these tracks the way they are kept at the moment?

If you want to use AAD to do this, I answered a similar question a couple of posts back: here (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=693941).

The only difference for your situation is that the pattern would be "\* - %artist% - %title%.*" instead, to take account of the number part of your filename.

Alex

[reposted as my previous reply has vanished]
Title: Album Art Downloader XUI
Post by: MordredKLB on 2010-03-30 18:05:52
It's possible. I haven't seen it used, but it's possible that it might use that as security (so accessing the login page sets a cookie, that must then be sent with the username and password). I have seen referrer checking, and user agent string checking. Without being able to access the site itself, I can only suggest you experiment with it.

Cover-paradies, coverisland and psyshop all use POST, in slightly different ways. Cover-paradies and coverisland also set the referer header, in a couple of different ways.
I talked to a developer on the site who recommended I check out Live HTTP Headers to see exactly what was being passed through a normal web browser login. After the POST, this is received from the server:

Code: [Select]
HTTP/1.1 302 Moved Temporarily
Server: nginx/0.8.32
Date: Tue, 30 Mar 2010 17:01:02 GMT
Content-Type: text/html; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
Set-Cookie: session=LONG_SESSION_STRING_REMOVED; expires=Wed, 30-Mar-2011 17:01:02 GMT; path=/
Location: index.php

After which I'm redirected to index.php. So apparently the session cookie isn't being set/saved and when index.php checks for it, I'm greeted with an error message, which is what's returned by System.IO in the Post method you gave me. I've done some searching on my own and wasn't able to find anything about saving/retrieving cookies in Boo scripts so I'm not even sure this is possible. If you've got any ideas, I'd love to hear them

Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-30 18:36:55
If you've got any ideas, I'd love to hear them
You probably won't have much luck searching for boo samples, but C# or VB.Net code snippets can usually be easily be adapted to boo.

For cookies, try adding:

Code: [Select]
cookies = CookieContainer()
...
request.CookieContainer = cookies

You'll need to assign the same cookies object to every request (rather than creating a new one for each request), so they all share the same set of cookies.

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2010-03-30 21:44:11
I've been looking through Microsoft's CookieContainer documentation and I feel like I have an idea of what I need to do to make it work, but I'm running into this error now:

'CookieContainer' is not a member of 'System.Net.WebRequest'

when I try and use request.CookieContainer = cookies

BTW, here's some Python code that a developer sent me for the required login process on the website:
Code: [Select]
    def login(self):
            headers = self.request("GET", self._login, "", {}).headers
            cookie=dict(headers)['set-cookie']
            web_session=re.search("web_session=[a-f0-9]+", cookie).group(0)
            headers = { "Cookie": web_session, "Content-Type": "application/x-www-form-urlencoded"}

            loginform= {'username': self._props['username'], 'password': self._props['password'], 'keeplogged': '1', 'login': 'Login'}
            data = urllib.urlencode(loginform)
            headers = self.request("POST", self._login, data, headers).headers

            cookie=dict(headers)['set-cookie']
            session=re.search("session=[^;]+", cookie).group(0)
            self.headers = { "Cookie": web_session + "; " + session }
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-30 22:26:21
'CookieContainer' is not a member of 'System.Net.WebRequest'

Ah, yeah, it's on HttpWebRequest (a subclass of WebRequest). If the request variable is just of type WebRequest rather than HttpWebRequest then do:
Code: [Select]
(request as System.Net.HttpWebRequest)CookieContainer = cookies

Or cast request as HttpWebRequest on creation instead, if you prefer:
Code: [Select]
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)


Alex
Title: Album Art Downloader XUI
Post by: mundschuss on 2010-03-30 23:00:27
ehhm..still cant make it work properly with foo_run

i have made a button in foobar with a foo_run connection.

the foo_run script is:

C:\Programme\AlbumArtDownloader\albumart.exe -ar "%artist%" -al "%album%" -f "folder.jpg" -p "%path%"

the problem is, that the command %path% gives e.g. Z:\Musik\Beck\1999 - Midnite Vultures\01 - Sexx Laws.flac instead of the path/folder Z:\Musik\Beck\1999 - Midnite Vultures\

its not possible for me to handle it with -p "Z:\Musik\%ARTIST%\%YEAR% - %ALBUM\" because i have lareday started my 2nd TB HDD with music. so, any ideas?

seeya
Title: Album Art Downloader XUI
Post by: MordredKLB on 2010-03-30 23:01:53
Weird. I was using the code you originally gave me that had
Code: [Select]
request = System.Net.HttpWebRequest.Create(url)

and I can't really tell how that differs from
Code: [Select]
request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)

but the streamresponse now has me logged in using the second version. Just gotta alter the code so that the cookies are being set on each call and I think I'm good!

Thanks a bunch.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2010-03-30 23:03:47
mundschuss, use this:

Code: [Select]
-p "$directory_path(%path%)"
Title: Album Art Downloader XUI
Post by: mundschuss on 2010-03-30 23:29:37
mundschuss, use this:

Code: [Select]
-p "$directory_path(%path%)"


thank you very much for your quick response. seems to work

seeya
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-03-31 08:04:05
and I can't really tell how that differs from
Cool, glad you've got it working now! The difference, if you're interested, is that it tells boo that the variable "request" should be of type HttpWebRequest, rather than WebRequest. Most other statically typed languages would use the syntax "HttpWebRequest request = new..." (as distinct from the first, which is equivalent to "WebRequest request = new...".

Alex
Title: Album Art Downloader XUI
Post by: ThomasG on 2010-04-05 00:41:20
ehhm..still cant make it work properly with foo_run

i have made a button in foobar with a foo_run connection.

the foo_run script is:

C:\Programme\AlbumArtDownloader\albumart.exe -ar "%artist%" -al "%album%" -f "folder.jpg" -p "%path%"

the problem is, that the command %path% gives e.g. Z:\Musik\Beck\1999 - Midnite Vultures\01 - Sexx Laws.flac instead of the path/folder Z:\Musik\Beck\1999 - Midnite Vultures\

its not possible for me to handle it with -p "Z:\Musik\%ARTIST%\%YEAR% - %ALBUM\" because i have lareday started my 2nd TB HDD with music. so, any ideas?

seeya


I have a similar issue with MediaMonkey using "Eternal tools" : my parameters are  /artist "%a" /album "%l" /path "\%p\Folder.jpg", but "\%p\Folder.jpg" gives me the track path and not the folder path... I would really appreciate some help :-).

Thanks a lot by the way for this excellent software :thumbsup:
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-05 08:39:00
I have a similar issue with MediaMonkey using "External tools"
I had a quick look a the MediaMonkey External Tools thread, and it seems you're not the first to want this: This post (http://www.mediamonkey.com/forum/viewtopic.php?p=106696#p106696) is asking for the same thing, for the same purpose. There's a suggested fix in that thread, but it seems to involve editing the External Tools script file. Anyway, if you need further help with this, I'd suggest that is the thread to ask in.

Alternatively, although this is sort of cheating, you can use "%p\..\Folder.jpg". It won't look pretty, but should save to the correct location.

Alex
Title: Album Art Downloader XUI
Post by: ThomasG on 2010-04-05 12:55:54
I have a similar issue with MediaMonkey using "External tools"
I had a quick look a the MediaMonkey External Tools thread, and it seems you're not the first to want this: This post (http://www.mediamonkey.com/forum/viewtopic.php?p=106696#p106696) is asking for the same thing, for the same purpose. There's a suggested fix in that thread, but it seems to involve editing the External Tools script file. Anyway, if you need further help with this, I'd suggest that is the thread to ask in.

Alternatively, although this is sort of cheating, you can use "%p\..\Folder.jpg". It won't look pretty, but should save to the correct location.

Alex


Thanks a lot for pointing me to this thread : I edited the script, and this works perfectly now !
Title: Album Art Downloader XUI
Post by: kearneykd on 2010-04-10 02:59:20
I've been playing around with this wonderful piece of software for a couple of hours now and am amazed by how much easier it makes finding album artwork, however...

I've been trying to find instructions somewhere in this thread about how best to go about using this in conjunction with iTunes? I must confess I've not read all 53 pages (and those which I have read have mostly been at a level far above my basic understandings) but so far can't see many mention of iTunes at all.

Obviously other music management software may be the preferred choice for many users but I'm hoping someone can offer advice for someone like myself who is iTunes based. From what I can make out there is no direct integration between the AAD software and iTunes software so I have been copying and pasting in a laborious process (but still vastly quicker way than previously). I await any assistance your kind selves can provide and would like to once again say how impressed I am with how well the AAD works.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-10 08:03:20
how best to go about using this in conjunction with iTunes?
Thanks for your comments. AAD doesn't integrate directly with iTunes, but McoreD's [a href='index.php?showtopic=51708']iTunes Store file validator[/a] integrates with both iTunes and Album Art Downloader, so should hopefully do what you need.

Alex
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-04-13 19:20:30
Having downloaded art for around 3000 mp3s with your tool I have to say it is probably in the top three best pieces of freeware I have ever used. 

Something I have noticed however is that, when using D:\%artist% - %album%.%extension%  AAD only reads part of the album tag in a very small minority of cases (<1%).  For example, in the file

The Chemical Brothers - Get Yourself High (Switch Vs. Corradino Edit) AAD reports the tag as album tag as Get Yourself High (Switch Vs


It seems this happens mostly (but not always) with tags containing Vs. or Vs

I have double checked the tags are fully (i.e. not only partially) written in the mp3s.

Any ideas?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-13 22:40:00
Any ideas?
Are you sure you are using the ID3 tag option rather than the file path pattern matching option?

If it is definitely using tags, and if it reliably happens with specific files, would you be able to send me one by email or PM? I could then inspect it to see if I can figure out if anything is strange about the tags.

Alex
Title: Album Art Downloader XUI
Post by: AlphaWave on 2010-04-14 20:50:33
Any ideas?
Are you sure you are using the ID3 tag option rather than the file path pattern matching option?

If it is definitely using tags, and if it reliably happens with specific files, would you be able to send me one by email or PM? I could then inspect it to see if I can figure out if anything is strange about the tags.

Alex


Actually, yes I do have file path matching option selected as follows:  \%artist% - %album%.*

I think it is when there is a full stop / decimal point in the tag.  If you pm me your e-mail address I can contact you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-14 21:29:53
Actually, yes I do have file path matching option selected as follows:  \%artist% - %album%.*
That would explain it, then. It matches the first "." (after Vs), and the rest of the filename matches "*". You've got two choices - either replace  .* with .mp3 (if all your files are .mp3's), or with ."[^.]+" if you need it to match any extension. So you'd have either:

\%artist% - %album%.mp3
or
\%artist% - %album%."[^.]+"

I've sent you a PM with my email, but this ought to fix the issue.

Alex
Title: Album Art Downloader XUI
Post by: Benji99 on 2010-04-16 20:23:53
Hi Alex,

I'm having an issue with the Amazon.co.jp script when there's non-english characters (in my case Japanese)
AAD will never return any results from Amazon.co.jp while it worked for an artist/album that only had english characters.

Here's an example:
Album: ファンキーモンキーベイビーズ2
Artist: FUNKY MONKEY BABYS

It does exist on Amazon: here (http://www.amazon.co.jp/%E3%83%95%E3%82%A1%E3%83%B3%E3%82%AD%E3%83%BC%E3%83%A2%E3%83%B3%E3%82%AD%E3%83%BC%E3%83%99%E3%82%A4%E3%83%93%E3%83%BC%E3%82%BA-2-FUNKY-MONKEY-BABYS/dp/B000XCZC5I/ref=sr_1_1?ie=UTF8&s=music&qid=1271445516&sr=8-1)

EDIT:

Actually, it seems that Amazon.co.jp won't return anything (The other amazons do)
Here's an example:
Album: Crispy!
Artist: Spitz

and

Album: B-SIDE
Artist: Mr.Children

Also is it just me or is Coveralia completely borked? For the FUNKY MONKEY BABYS search, it's showing results like Madonna and Justin Bieber of which I see no link...

Thanks!
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-04-16 23:13:12
Quote
Also is it just me or is Coveralia completely borked?

Yes it is. But not Coveralia script in AAD! Coveralia search is stupidly an "OR" search. Also it doesn't separate artist & album in the search.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-17 09:37:05
I'm having an issue with the Amazon.co.jp script when there's non-english characters
Thanks for reporting this. It looks like Amazon.jp sometimes has a different form of displaying the results (tabular, rather than a list). I can't figure out when it chooses to do this, so I've just got the script to try to read both formats now. Also, I fixed up some of the encoding issues, so .jp should now use the ShiftJIS codepage properly, both accepting and returning characters in that encoding.

Unfortunately Sourceforge is down for the weekend, so I can't push out an update yet - but if you don't want to wait, you can get the updated script files here: amazon-jp.zip (http://www.byalexv.co.uk/foobar/amazon-jp.zip). Both files go in your scripts folder.

Alex
Title: Album Art Downloader XUI
Post by: Hank H. on 2010-04-18 21:24:30
Hi,

maybe I'm blind, but I can't figure out how to tell the program how to name the downloaded files. It used to save the files under "folder.jpg", now it only saves them under "folder", without extension, which causes several problems... Could anybody give me a clue?

Thanks!
Title: Album Art Downloader XUI
Post by: Benji99 on 2010-04-18 21:36:12
I'm having an issue with the Amazon.co.jp script when there's non-english characters
Thanks for reporting this. It looks like Amazon.jp sometimes has a different form of displaying the results (tabular, rather than a list). I can't figure out when it chooses to do this, so I've just got the script to try to read both formats now. Also, I fixed up some of the encoding issues, so .jp should now use the ShiftJIS codepage properly, both accepting and returning characters in that encoding.

Unfortunately Sourceforge is down for the weekend, so I can't push out an update yet - but if you don't want to wait, you can get the updated script files here: amazon-jp.zip (http://www.byalexv.co.uk/foobar/amazon-jp.zip). Both files go in your scripts folder.

Alex


Hi Alex, thanks for the quick update!

I've tested the new script and it sometimes work, but other times it does not.

Here's 3 more examples I tried:

Doesn't work:
Artist: ????
Album: ????

Artist: ?????????
Album: THUMP?

Works:
Artist: ????
Album: ?

Artist: ????
Album: ?? ???

Another thing is the buy.com is also acting really strange throwing results about all sorts of irrelevant gadgets.
Title: Album Art Downloader XUI
Post by: dadarkman on 2010-04-19 06:24:33
This program is amazing considering the amount of sources that it can pull. A lot of kudos goes to the developer.
Two little questions I had about the program:
1- Will there ever be an option to save the art directly inside of the mp3? I ask because I think adding that feature would be of great convenience for people (like me) who save art directly in the file instead of folder.jpg.
2- I'm using the Windows version. Whenever I do a search in the Search window, it would open the results in a new separate window instead of overriding the previous results in just one window. So, if I make 20 searches then I'd have 20 windows open. Is the software purposely writing like that or I have a defaulted install?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-19 07:53:45
I can't figure out how to tell the program how to name the downloaded files.
It depends on where you're starting from. If you're passing in the path as part of the command line (running AAD from Foobar using foo_run, for example), then the name is probably part of the command line. If you post the command line you're using, I can probably figure out what's wrong with it.

If you are starting from the AAD File or Foobar Browser, then the downloaded files are saved with the first name you put in the "Specify path to find images" box. By default this would be "Folder%preset%.%extension%", so would usually save as "Folder.jpg".

If you are searching directly from the main AAD window, then the "Save images to" box is the place to look.

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-19 08:02:43
I've tested the new script and it sometimes work, but other times it does not.
OK, I'll have another look at it when I get some time, see if I can figure out why. Thanks for the examples.

The buy.com thing is irritating, I agree - but they are actually returning those things as search results! I guess they figure trying to sell you anything is better than nothing.

Thanks! To answer your questions:

1- As far as I'm concerned, no. I don't think this is the right utility for that; ensuring that all track files in an album have the right image tag is a tag management task, and should be done using tag management software (it's the same class of task as ensuring that all the tracks have the same Album tag). This program is just for finding the artwork, not for managing your tags.

That said, a guy called Liam posted a while back that he was interested in developing this functionality himself. If it works out, I'll add his changes and post an update. I haven't heard from him for a while now, though.

2- Click the options link in the Search window, and uncheck the box labelled "Open search results in new window". Should do the trick.

Alex
Title: Album Art Downloader XUI
Post by: Hank H. on 2010-04-19 22:35:25
I can't figure out how to tell the program how to name the downloaded files.
It depends on where you're starting from. (...)

If you are starting from the AAD File or Foobar Browser, then the downloaded files are saved with the first name you put in the "Specify path to find images" box. By default this would be "Folder%preset%.%extension%", so would usually save as "Folder.jpg".



That's what I was doing. I still don't understand why it does what it does (i.e. leave out the extension), but I guess I'll have to find the time to check out other options like foo_run first and see if that's working better for me.

Thanks so far, AlexVallat!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-20 14:57:08
I've tested the new script and it sometimes work, but other times it does not.

Here's 3 more examples I tried:

Doesn't work:
Artist: ????
Album: ????

Artist: ?????????
Album: THUMP?

????????? / THUMP? works fine for me... ????/???? doesn't, but then I don't get any results for it when I search amazon.co.jp directly: amazon.co.jp music search (http://www.amazon.co.jp/%E3%83%9F%E3%83%A5%E3%83%BC%E3%82%B8%E3%83%83%E3%82%AF%E8%A9%B3%E7%B4%B0%E3%82%B5%E3%83%BC%E3%83%81/b/ref=sv_m_0?ie=UTF8&node=124286011)

It looks to me like the artist for that album ought to be: ????, not ????, though - and that works fine.

Alex
Title: Album Art Downloader XUI
Post by: Benji99 on 2010-04-20 18:29:20
I've tested the new script and it sometimes work, but other times it does not.

Here's 3 more examples I tried:

Doesn't work:
Artist: ????
Album: ????

Artist: ?????????
Album: THUMP?

????????? / THUMP? works fine for me... ????/???? doesn't, but then I don't get any results for it when I search amazon.co.jp directly: amazon.co.jp music search (http://www.amazon.co.jp/%E3%83%9F%E3%83%A5%E3%83%BC%E3%82%B8%E3%83%83%E3%82%AF%E8%A9%B3%E7%B4%B0%E3%82%B5%E3%83%BC%E3%83%81/b/ref=sv_m_0?ie=UTF8&node=124286011)

It looks to me like the artist for that album ought to be: ????, not ????, though - and that works fine.

Alex


Hi Alex,

Haha, I noticed later I made a mistake in the name and never connected with the error in getting the artwork!
Sorry about that

Sebastien
Title: Album Art Downloader XUI
Post by: _stranger_ on 2010-04-23 15:31:28
Why does it take so long to start?
My Photoshop CS4 is starting faster then this app.

It takes more then 20 sec on Win7 to start.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-23 15:47:23
Why does it take so long to start?
Do you mean just the first time it is run? Does it pop up the splashscreen with the progress bar? If so, then it takes so long because it's compiling the scripts into executable code. It only does this when they've been changed, though.

If you mean every time it's run, then there's probably something with your .net framework installation. I'm running Windows 7 myself and it takes between 1 and 2 seconds to load. Admittedly I've got a fast machine, but 20 seconds is way out. Even for the first run script compilation, 20s is pretty long.

Alex
Title: Album Art Downloader XUI
Post by: _stranger_ on 2010-04-23 16:02:34
If you mean every time it's run, then there's probably something with your .net framework installation. I'm running Windows 7 myself and it takes between 1 and 2 seconds to load. Admittedly I've got a fast machine, but 20 seconds is way out. Even for the first run script compilation, 20s is pretty long.

Alex
That was fast.
Thank you

Yes, every time i run it takes more then 20 sec. The thing is that i am using .NET framework that comes with win7.
I didn't install any other version or SPs.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-23 16:08:45
Yes, every time i run it takes more then 20 sec. The thing is that i am using .NET framework that comes with win7.
In that case I don't know why it's taking so long, sorry! If it isn't producing any error messages then it doesn't really give me anything to go on.
Title: Album Art Downloader XUI
Post by: bilbo on 2010-04-24 01:47:11
You could also try the ".NET Framework Setup Verification Tool" to check your system. It can be found at:

http://blogs.msdn.com/astebner/pages/8999004.aspx (http://blogs.msdn.com/astebner/pages/8999004.aspx)
Title: Album Art Downloader XUI
Post by: _stranger_ on 2010-04-24 15:50:33
It seems that everything is ok with my .NET Framework.
At least that .NET Framework Setup Verification Tool says so:

Code: [Select]
[04/24/10,16:37:18] Verification succeeded for product .NET Framework 3.5 SP1

[04/24/10,16:37:56] Verification succeeded for product .NET Framework 3.0 SP2

[04/24/10,16:38:22] Verification succeeded for product .NET Framework 2.0 SP2


Realy don't get it... what can be the problem... i am so confused...

But thanks anyway.
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-04-28 20:36:15
i have a question:
if a cover download is still in progress and i close the window - will the download finish or abortet? thank you very much!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-04-29 08:34:57
if a cover download is still in progress and i close the window - will the download finish or abortet? thank you very much!
As long as there are any windows open (so Album Art Downloader is still running), the download will finish. If all the windows are closed, then you have exited Album Art Downloader, and the download will be aborted.

Alex
Title: Album Art Downloader XUI
Post by: PabUK on 2010-04-29 10:56:48
Album Art Downloader has always been slow to start on my system as well. On a first run after a boot, I just timed it at 15 seconds. If I close it and then run it again, it only takes about 2 seconds. Some delay appears to be a common to running any .NET application for the first time after a restart, though it still seems AAD takes a fair bit longer than others. For reference, I'm running Windows 7 64-bit on an Athlon X2 6000+.
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-04-29 14:13:04
Quote
Some delay appears to be a common to running any .NET application for the first time after a restart, though it still seems AAD takes a fair bit longer than others.

Confirmed here too.. again (I remember posting something like this in the past).
Title: Album Art Downloader XUI
Post by: uZi on 2010-04-30 19:46:30
Album Art Exchange won't find anything anymore. Is there anything to do ?
It's my fav source
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-04-30 21:49:29
http://www.albumartexchange.com/ (http://www.albumartexchange.com/)
Quote
Not Found

The requested URL / was not found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.


AlbumArtExchange.com server move on Monday, April 26 (http://blog.albumartexchange.com/2010/04/albumartexchangecom-server-move-on-monday-april-26.html)
I guess something went wrong..
Title: Album Art Downloader XUI
Post by: uZi on 2010-05-01 17:28:52
Ah so at least there's an explanation and hopefully Alex can fix this
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-05-01 18:22:01
The site is not up, I don't think that Alex could fix that, he's amazing but I doubt that.  Besides, he won't fix the script because the AAX script is no longer a part of the AAD.

AlbumArtExchange.com script removal
I've had a request to remove the AlbumArtExchange.com script, from the site owner (Scott (http://www.albumartexchange.com/forums/memberlist.php?mode=viewprofile&u=61)), as it's taking up too much of their bandwidth. That script will therefore not be included in v0.33. I'm sure he'd appreciate it if you were to stop using it (or even just scale back on it's usage, you can set it to download only one result, or to not be Search First so it's only searched if no other source finds anything).

Title: Album Art Downloader XUI
Post by: uZi on 2010-05-01 22:31:05
Site works fine for me. But that's a very sad news

//and I guess it's not really that AAD is "taking up too much bandwith", but most likely because they seem to have a deal with TidySongs, a $40 shareware program...
Title: Album Art Downloader XUI
Post by: EagleScout1998 on 2010-05-01 23:15:27
Now that AAX has moved to a new server, I don't think the script will function anymore.

Although it's not too difficult to search the actual website (especially with the Firefox search plug-ins), I will concede that being able to download the artwork with the AAD program is much more convenient.
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-05-01 23:27:12
A mere server change won't break the script. I've trouble loading the site now, but an ~hour ago the "gallery" page gave lots of PHP errors, so the problems continue. If you like the script in AAD, start learning to code BOO, you'll be ready when the day comes that the old script doesn't work anymore.
Title: Album Art Downloader XUI
Post by: zilexa on 2010-05-07 18:00:25
Is there a guide about how to use your tool?
I'm new using it, have used in via REACT2 (Exact Audio Copy) a few times but I now have a different task:

add Album Art to 187 albums. I tried simply adding the root of my albums folder: D:\Music\Albums. That works: 187 albums identified. So I select all of them and press "Get Artwork for selection". Now I get 2 screens, one for album no1 with Album Art search results and one for album no2 (at least thats my assumption) with results.

But what to do next? When I press one of the Artworks, nothing happens, when I close one of those windows, another one for a different album opens... not sure what the correct process is..
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-07 18:32:12
Is there a guide about how to use your tool?
Unfortunately, no, there isn't. There should be, though.

In answer to your specific question, if you click the Save button on the artwork you want for an album, it will be saved (a green tick appears over the save button when it's done) and the search window will close. If it doesn't, then click the Options link and make sure the "Automatically close after saving" box is checked. Or just close the window after saving.

As each search window closes another opens until all the (187) queued searches have been done. You can see the queued searches in the Queue Manager window; if it isn't visible you can bring it up from the Window menu.

If what you want is to automatically download the first matching artwork for all 187 albums without choosing each one then before clicking "Get Artwork For Selection" in the File Browser, click the Options link in that window and select "Automatically download and save the first result that meets set criteria" there. Now, when you click the Get Artwork button, a different window will open. I'd recommend making a careful choice of which sources to use, and possibly setting maximum and minimum size criteria before hitting the Start button if you choose to use this feature.

Alex
Title: Album Art Downloader XUI
Post by: zilexa on 2010-05-07 18:36:48
Ok thanks for such a clear explanation! I was hoping for a "automatically pick first result" option. But I understand that might not satisfy me.
Googling around gives me a recommended size for album art is 300x300 pixels. The art will mainly be shown on my HTPC (XBMC for Windows) and I am planning to use an Android smartphone (X10 Mini Pro) as musicplayer. I think 300x300 is more than enough for a portable device..

EDIT:
Can't find an "Options" link anywhere  I am using 0.34.1.
I suppose setting criteria such as max/min size is also done in Options?

EDIT:
Immediately found a pretty annoying thing when trying to select multiple albums in File browser:
When I click just a pixel beside the checkbox, all previous boxes are unchecked and only the one lastly clicked is selected. I can start over again.
Also, when clicking not very carefully on the next checkbox, you might hit the first again, causing the program to think I did a double-click and it will start searching.

Perhaps this happens because my mouse is less accurate because I use Teamviewer on my laptop to make a remote connection to my HTPC to perform this task.. will try directly on the pc.. but with the laptop I can just do it laying on the bed
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-07 22:47:45
Can't find an "Options" link anywhere
Top left, just above the search results box (but under the search terms).

Immediately found a pretty annoying thing when trying to select multiple albums in File browser
How about ignoring the checkboxes and just using multi-select list semantics? Hold down Shift to select a continuous range, or Ctrl to toggle the selection of an individual item. This means, if you have Ctrl held down, clicking anywhere on the item is the same as clicking in the checkbox.

Alex
Title: Album Art Downloader XUI
Post by: cYmoZz on 2010-05-09 10:42:38
Sorry, if this has been discussed before:

Is there a component for foobar that downloads automatically album arts?

I'd prefer not having to start an external program each time, I want to download an album art.
Title: Album Art Downloader XUI
Post by: kieranmullen on 2010-05-11 10:36:04
Hi!  I have a couple of collections of mp3s in a single album folder Hits of 80s etc.. How could I get the program to create a folder for each song and download the artwork for each song in that folder?

Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-11 10:57:31
How could I get the program to create a folder for each song and download the artwork for each song in that folder?
In the File Browser, do all the different songs appear in the list? If not, then dragging and dropping just that folder on to the list so that it processes it individually, rather than as a potential single "various artists" album.

Once you have all the correct 'albums' listed in the file browser, the next step is to make it so that the art is stored in a separate folder for each one. To do this, in the Options area, change the "Specify path to find images" box to be: "%artist% - %album%\Folder%preset%.%extension%" (or similar - this example will result in sub folders like "Aerosmith - Big Ones" with an image file like "Folder.jpg" in them).

Then just use Get Artwork for Selection as normal.

Alex
Title: Album Art Downloader XUI
Post by: Narag on 2010-05-11 12:08:42
Hello,

thanks for great product first!

I'd like to open the proxy theme again - would it be possible to add proxy authentication? I'm behind proxy which requires authentication - therefore I press search and see in proxy logs many denied anonymous requests.

Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-11 12:32:41
would it be possible to add proxy authentication?
Album Art Downloader uses the system (or internet explorer) proxy settings. These can be accessed through Control Panel, Internet Options. If you've got authentication set up in there, it should just work.

Alex
Title: Album Art Downloader XUI
Post by: Narag on 2010-05-11 12:51:49
would it be possible to add proxy authentication?
Album Art Downloader uses the system (or internet explorer) proxy settings. These can be accessed through Control Panel, Internet Options. If you've got authentication set up in there, it should just work.

Alex


Hi Alex,

that's really quick reply :-)
in Internet Options it¨s possible to set up proxy server, but not the authentication ... :-(

Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-11 13:18:14
I don't use an authenticating proxy, so I don't know how one is usually set up for system-wide use, then.

I did put a nasty hack into AAD to let you force the proxy settings to use, though. You can download Proxy Configuration - AlbumArt.exe.config (http://www.byalexv.co.uk/foobar/Proxy%20Configuration%20-%20AlbumArt.exe.config) to use as a template. Edit that file to put your proxy information in the places marked, then save it as "AlbumArt.exe.config" in the same folder as AlbumArt.exe, and see if that helps at all.

Alex
Title: Album Art Downloader XUI
Post by: elite-rob on 2010-05-15 00:18:22
Hello All,

This program looks great!

I'm just running into one small problem that I can't sem to get around.

I use Sonos and they instructed me to name my artwork files "folder.jpg" not "Folder.jpg" (note the capital "F")

So, currently in my very large library, I have most things (except those missing artwork!) named "folder.jpg".

I figured out how to get it to search my library for 'folder.jpg' so that was good.

The problem is that I use the File Browser to find missing artwork. Then I select the albums I want to search for. For whatever reason, that search window always wants to save the file as "Folder.jpg".
No matter what I seem to try, I cannot get it to default to "folder.jpg".

I know I can manually edit the file name to change it to 'folder.jpg', but that makes the whole process take a lot longer and sort of makes this great program less useful (and less automated).

I assume there must be a way to fix this.

Can anyone help me out?

Many thanks in advance!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-15 08:05:58
The problem is that I use the File Browser to find missing artwork. Then I select the albums I want to search for. For whatever reason, that search window always wants to save the file as "Folder.jpg".
No matter what I seem to try, I cannot get it to default to "folder.jpg".

In the File Browser window, click the Options link, then edit the "Path to search for images" box to say folder instead of Folder.

Alex

Title: Album Art Downloader XUI
Post by: elite-rob on 2010-05-15 19:48:46
Hi Alex,

Thanks for the reply.

I had already tried that and sadly it doesn't work.

In the File Browser I have this as the 'specify path to find images':
Folder%preset%.%extension%|folder.jpg

But, after doing a search for images, it still defaults back to "Folder.jpg".

On the search results screen, if I go to options, I can see it says "Images will be saved to" and it has "Folder%preset%.%extension%". But, that field cannot be edited.

Any other ideas?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-15 20:07:06
In the File Browser I have this as the 'specify path to find images':
Folder%preset%.%extension%|folder.jpg
It defaults to the first option, so you're adding a (redundant) alternative rather than editing it. Just have "folder%preset%.%extension%", or just "folder.%extension%" if you know you won't be using presets. You could have "folder.jpg", but using %extension% instead means that if the image isn't a jpeg, it gets the correct extension assigned for it.

Alex
Title: Album Art Downloader XUI
Post by: tomthomson on 2010-05-16 22:50:18
Hi Alex,
a few weeks ago I ran into this problem when I'm trying to start AlbumArt.exe or aad.exe.
Well, the program crashes right after starting it and then Windows 7 tries to search for a solution.
After this I get a dump file from the crash. Actually I don't know what it means so perhaps you have an idea.
I think this problem appeared after installing MS Visual Studio 2010 and .Net Framework 4 but after deinstalling these two the problem still exists. I also verified my .net Framework 3.5 SP1 files with Aaron Stebner's Verification Tool and every test was successful.

content of WERE54F.tmp.WERInternalMetadata.xml
Code: [Select]
<?xml version="1.0" encoding="UTF-16"?>
<WERReportMetadata>
<OSVersionInformation>
<WindowsNTVersion>6.1</WindowsNTVersion>
<Build>7600 </Build>
<Product>(0x1): Windows 7 Ultimate</Product>
<Edition>Ultimate</Edition>
<BuildString>7600.16539.amd64fre.win7_gdr.100226-1909</BuildString>
<Revision>1</Revision>
<Flavor>Multiprocessor Free</Flavor>
<Architecture>X64</Architecture>
<LCID>1031</LCID>
</OSVersionInformation>
<ParentProcessInformation>
<ParentProcessId>1868</ParentProcessId>
<ParentProcessPath>C:\Windows\explorer.exe</ParentProcessPath>
<ParentProcessCmdLine>C:\Windows\Explorer.EXE</ParentProcessCmdLine>
</ParentProcessInformation>
<ProblemSignatures>
<EventType>APPCRASH</EventType>
<Parameter0>AlbumArt.exe</Parameter0>
<Parameter1>0.34.1.0</Parameter1>
<Parameter2>4b4051aa</Parameter2>
<Parameter3>KERNELBASE.dll</Parameter3>
<Parameter4>6.1.7600.16385</Parameter4>
<Parameter5>4a5bdfe0</Parameter5>
<Parameter6>e0434f4d</Parameter6>
<Parameter7>000000000000aa7d</Parameter7>
</ProblemSignatures>
<DynamicSignatures>
<Parameter1>6.1.7600.2.0.0.256.1</Parameter1>
<Parameter2>1031</Parameter2>
</DynamicSignatures>
<SystemInformation>
<MID>23875887-2401-44FF-AFF2-4FAC577BDAE8</MID>
<SystemManufacturer>MSI</SystemManufacturer>
<SystemProductName>MS-7520</SystemProductName>
<BIOSVersion>V1.10</BIOSVersion>
</SystemInformation>
</WERReportMetadata>

output of windbg for the file WER3F7.tmp.mdmp
Code: [Select]
Loading Dump File [C:\Users\Tom\Desktop\WER3F7.tmp.mdmp]
User Mini Dump File: Only registers, stack and portions of memory are available

Symbol search path is: SRV*c:\websymbols*http://msdl.microsoft.com/download/symbols
Executable search path is:
Windows 7 Version 7600 MP (8 procs) Free x64
Product: WinNt, suite: SingleUserTS
Machine Name:
Debug session time: Sun May 16 23:20:17.000 2010 (GMT+2)
System Uptime: 0 days 0:04:25.755
Process Uptime: 0 days 0:00:12.000
...........................
Loading unloaded module list
..
This dump file has an exception of interest stored in it.
The stored exception information can be accessed via .ecxr.
(cc0.aac): CLR exception - code e0434f4d (first/second chance not available)
ntdll!NtWaitForSingleObject+0xa:
00000000`77c6fefa c3              ret
0:000> .ecxr
rax=0000000077f494aa rbx=0000000002863a88 rcx=000000000022f3d0
rdx=00000000000000e0 rsi=00000000e0434f4d rdi=0000000000cf5470
rip=000007fefdc3aa7d rsp=000000000022f9e0 rbp=0000000000000000
 r8=0000000000000000  r9=0000000000000000 r10=0000000000000038
r11=000000000022fa20 r12=000000000022fb00 r13=ffffffff80070002
r14=0000000000000001 r15=0000000000000001
iopl=0        nv up ei pl nz na po nc
cs=0033  ss=002b  ds=002b  es=002b  fs=0053  gs=002b            efl=00000206
KERNELBASE!RaiseException+0x39:
000007fe`fdc3aa7d 4881c4c8000000  add    rsp,0C8h
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-17 08:09:19
the program crashes right after starting it
Could you check if it produced an errorlog.txt file in the Album Art Downloader program folder? If not, could you try either granting full permissions to the Album Art Downloader program folder for the account you will be running it under, or moving it to a folder outside Program Files (which should by default have full permissions). If you run it again, then it may still crash, but hopefully might produce the errorlog.txt which would allow me to determine what the problem with it is.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: tomthomson on 2010-05-17 10:29:23
ok, perhaps crashing is the wrong word. Right after executing AlbumArt.exe the Windows problem solving procedure starts saying that Album Art Downloader doesn't work anymore. So I don't get any errorlog.txt produced by your program and I also tried different starting locations.
By the way - the aad.exe works now after reinstalling Framework 3.5 SP1.
Paint.net 3.5 works, too, which has framework 3.5 sp1 as an requirement.

Actually I think there's no problem with your program but I messed up my computer somehow 
I hoped the minidump file would be of any help for the developer.
Title: Album Art Downloader XUI
Post by: spile on 2010-05-18 08:54:51
Quick question for a great application...
When I run the application, I have to do File > New File Browser > Search (or run the CTRL B shortcut and select Search).
This means the original window that opens is effectively redundant.
Is there some way I can store the option to perform a scan of a stored drive when I launch the application rather than having to go through the menus or use the shortcuts.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-05-18 09:05:45
I hoped the minidump file would be of any help for the developer.
Sorry, the only thing it tells me is that an error occurred somewhere within the internals of the .net framework - it doesn't give me a clue as to what the error was or what may have caused it.

Is there some way I can store the option to perform a scan of a stored drive when I launch the application rather than having to go through the menus or use the shortcuts.
Yes, change the command line of the shortcut you are using to open it to add the parameter /fileBrowser
If you want it to immediately start a scan of a specified folder, you can add that too, like: /fileBrowser "c:\music"

Alex
Title: Album Art Downloader XUI
Post by: tomthomson on 2010-05-18 20:50:26
I hoped the minidump file would be of any help for the developer.
Sorry, the only thing it tells me is that an error occurred somewhere within the internals of the .net framework - it doesn't give me a clue as to what the error was or what may have caused it.

ok, anyhow thanks for your help and keep up your work on this very helpful tool!
Title: Album Art Downloader XUI
Post by: spile on 2010-05-25 17:56:34
Thanks that works great!
Title: Album Art Downloader XUI
Post by: ErikK on 2010-05-30 23:36:49
I'd like to save the artwork to the folder the album is located, but I have my library sorted like this:

E:\Music\%band%\[%date%] - %album%\%artist% - %track% - %title%

I guess what I want to know is will AAD recognize the %band% tag so I can set it to search/save in those folders? or can I set it to just save in the same fold that the mp3 is located in?
Title: Album Art Downloader XUI
Post by: ErikK on 2010-05-31 07:36:39
Never mind, I found a solution to my problem.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-06-27 11:31:07
Album Art Downloader XUI v0.35 Released

Just a minor bug fixing release here, mostly to bring all the scripts up to date and remove the Lala and MusicMight scripts (as they no longer have working search services).

Other changes:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.35.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.35.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: loft on 2010-06-30 17:19:52
I like this tool a lot, been using it for quite some time now but... there's a "but":

Settings seem to be quite a mess.

1. This program looks more like three things in one: Search window, File browser and Foobar browser. You might say I'm slow thinking but I think these things stay in sync only if you restart everything (maybe keeping the settings put in the last window closed) and there are settings that seem to belong only to one of the components. Maybe putting everything in one window with three tabs and an extra tab for settings would make things a little bit more clear.

2. Why the patterns for the search matching in File browser have to be the same as those for file saving? I've used to only keep the front cover (cover.jpg) so I'm looking for this file. But lately I've started looking for the other covers and name them front, back, cd, etc. Now I seem not to be able to look for cover.jpg and use one of the presets to save into front, back, etc.

So if anyone has any idea how to deal with these please give me some hints. AlexVallat if you consider these worth looking into you might take them into consideration for future versions.

Thanks!

Later edit: Also, a nice addition would be search engines profiles: one profile for a few selected ones, one for others, one for all (if, for example, the cover can only be found on amazon or google).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-06-30 21:57:51
I'm not really sure what you mean by "stay in synch". Those three different windows do different things, and have their own independent settings. The only effect bunching them together as tabs would have would mean you could only see one of them at a time.

For point 2, this is for simplicity. If you are searching for cover.jpg, then it's a reasonable assumption that that's what you want your images saved as. For the situation you describe, try using "%preset%.jpg" as the file to search for, that match your existing cover.jpg files and save in the format you want.

The profiles idea is a good one. You might find that the Search First feature does what you need, but I'll keep the full profiles idea in mind for a future version.

Alex
Title: Album Art Downloader XUI
Post by: loft on 2010-07-01 06:12:18
So after all this is what you wanted: three programs in one, only that you always start one, then start one of the others if you need them. Maybe the fact that I'm almost exclusively using the browser and that I was expecting to have the same set of settings is what made me a little bit confused. Thanks for the explanations!

PS: A switch to specifically start one of the three would be great!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-01 07:56:38
Maybe the fact that I'm almost exclusively using the browser and that I was expecting to have the same set of settings is what made me a little bit confused.
What same settings? Same set of settings as what? I still don't understand this. The File Browser should keep any settings you set for it, if something isn't being saved, please tell me exactly what setting it is and I'll look into it.

To start the file browser directly, the switch is /fileBrowser
If you want it to immediately start a scan of a specified folder, you can add that too, like: /fileBrowser "c:\music"
All the switches are documented, check under the Help menu.

Alex
Title: Album Art Downloader XUI
Post by: the_miker on 2010-07-03 01:23:53
Can somebody with Regex experience see if they can create a VGMdb source script?  VGMdb is a database of video game music and it'd be really handy to have a working Album Art Downloader plugin that could utilize the site's search and artwork features.  I posted over on their forums but didn't get any responses.  I'd be willing to test if anybody is willing to give it a shot.

My original post over at VGMdb: http://vgmdb.net/forums/showthread.php?t=4845 (http://vgmdb.net/forums/showthread.php?t=4845)

Quote
I just downloaded a nifty little open source app for Windows called Album Art Downloader (http://sourceforge.net/projects/album-art/).  It's an easy-to-use program that lets you, yeah you guessed it, download album art for all your digital music files.  You can either search manually or it can scan a specific music folder or your foobar2000 library/playlists for albums that are missing artwork.  Not only that, but this thing lets you write custom search scripts so you can basically use any searchable web site as a source for the artwork.  Guess what I'm gonna ask next?  I need to know if it's possible for someone to write a script so we can use VGMdb as an artwork source within the program.

Here's a sample of one of the search scripts (for some site called MusicMight).  Can anyone decipher how it's getting the search results and displaying them within the program?  This would be so epic if someone got this to work.

Code: [Select]
import System
import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util

class MusicMight(AlbumArtDownloader.Scripts.IScript):
    Name as string:
        get: return "MusicMight"
    Version as string:
        get: return "0.3"
    Author as string:
        get: return "Alex Vallat"
    def Search(artist as string, album as string, results as IScriptResults):
        if String.IsNullOrEmpty(album):
            return //Only searching on album is supported

        album = StripCharacters("&.'\";:?!", album)
            
        //Retrieve the search results page
        searchResultsHtml as string = GetPage("http://www.musicmight.com/search?t=recording&q=" + EncodeUrl(album))
        
        matches = Regex("<a\\s[^>]*?href\\s*=\\s*'(?<url>[^']+)'[^>]*?>\\s*<img\\s[^>]+?src\\s*=\\s*'http://s3\\.amazonaws\\.com//mmimagesm/(?<img>[^']+)'[^>]*?>(?<title>.*?)</td>", RegexOptions.IgnoreCase | RegexOptions.Singleline).Matches(searchResultsHtml)
        
        if matches.Count == 0: //Try single page result
            matches = Regex("\"http://s3\\.amazonaws\\.com//mmimagelg/(?<img>[^\"]+)\"[^>]*?>.*?<h4><span id=\"artistTitle\">(?:(?:<[^>4]+>)(?<title>[^<]+)?)+</h4>", RegexOptions.IgnoreCase | RegexOptions.Singleline).Matches(searchResultsHtml)
        
        results.EstimatedCount = matches.Count
        
        for match as Match in matches:
            img = match.Groups["img"].Value
            title = ""
            for capture as Capture in match.Groups["title"].Captures:
                title += capture.Value
            title = title.Replace("<br />", "").Replace("</a>", "").Replace("&bull;", "-");

            url as string = null
            if match.Groups["url"].Success:
                url = "http://www.musicmight.com" + match.Groups["url"].Value
            
            results.Add("http://s3.amazonaws.com//mmimagesm/" + img, title, url, -1, -1, "http://s3.amazonaws.com//mmimagelg/" + img, CoverType.Front);

    def RetrieveFullSizeImage(fullSizeCallbackParameter):
        return fullSizeCallbackParameter;


Basically it looks like it goes to the search page http://vgmdb.net/search?q=blah (http://vgmdb.net/search?q=blah) and then parses out the results using Regex.  Once that Regex line kicks in, that's where I get lost, haha.  Maybe this is best for someone with Regex experience?

Here's an example of the search results within the program itself.  These results here are kinda questionable and pretty unorganized since I had every search site selected.  If we were to just use VGMdb for this same search, these results would be immaculate.  Note that you can either have the program show you these results and then you save each one manually OR it can just save the first result (for each type.. front, back, disc, etc) automatically in the folder you choose:

[a href="http://img204.imageshack.us/img204/8302/55875305.png" target="_blank"]


Thanks guys!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-03 09:27:28
Can somebody with Regex experience see if they can create a VGMdb source script?
Sure, we don't have anything specifically for game music at the moment, so it's a good addition. Unfortunately the artwork they have is all quite small, but it's better than nothing.

Please give this a try and let me know how you get on: vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo)

Alex
Title: Album Art Downloader XUI
Post by: Zarggg on 2010-07-03 19:17:44
All the images are user/editor-uploaded. Not all the images are small.
Title: Album Art Downloader XUI
Post by: the_miker on 2010-07-03 19:52:59
Sure, we don't have anything specifically for game music at the moment, so it's a good addition. Unfortunately the artwork they have is all quite small, but it's better than nothing.


Actually most of their scans are hi-res, but you need to be logged in to see them.  If you're not logged in then you'll only see the smaller images.  There's no way to get the script to log itself into VGMdb, is there?

Please give this a try and let me know how you get on: vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo)


Woah, that was fast!  Tested it out using the Foobar Browser and it does work, sorta.  For some albums, I've noticed that if the Artist field is populated, then there won't be any search results in the Search window.  Clearing the Artist field and manually pressing Search again yields actual search results.

Also, since video game music albums often have multiple artists, it would be awesome if there was a way to somehow condense each result (in the Foobar Browser and the File Browser) to only show one result per album, not a separate album for every different artist on that particular album.  Check out the "2197" album in this screenshot for what I mean:

Title: Album Art Downloader XUI
Post by: the_miker on 2010-07-03 20:08:34
Sorry for the double post but I found another potential bug.  Just came across an album that it can't find no matter what I type in for the search: Xenoblade Original Soundtrack (http://vgmdb.net/album/18946).

Only two images get displayed when searching for "xenoblade" and they're both from Xenoblade Special Sound Track (http://vgmdb.net/album/18669) (a completely different CD).

Both CDs have a properly-named "Front" cover on the site so I'm not sure what would cause the OST one to not show up.  I'll see if I can replicate this issue with a different album..
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-03 21:32:32
There's no way to get the script to log itself into VGMdb, is there?
Not really. What I could try to do is have marked spots in the script to easily add your own login details. Then, if you edit the script to provide those it will log itself in with those, otherwise it will just use the publicly available medium sized images. I'll look into that when I get a chance.

For some albums, I've noticed that if the Artist field is populated, then there won't be any search results in the Search window.  Clearing the Artist field and manually pressing Search again yields actual search results.
I was using the "composer" field of the advanced search for that, which I guess isn't right. Would "performer" make more sense here, do you think? Or should it be just ignored?

Also, since video game music albums often have multiple artists, it would be awesome if there was a way to somehow condense each result (in the Foobar Browser and the File Browser) to only show one result per album, not a separate album for every different artist on that particular album.
This should already happen. If there are multiple artists for a single album, it lists it as "Various Artists". For this to work, the album tracks must have identical Album tags, and be in the same folder. Looking at your screenshot, I can't see any obvious reason why 2197 shouldn't have been listed as a single "Various Artists" album - are all the tracks in the same folder?

The only other thing I've noticed is that the search results don't always display every scan for a certain album
If you give me specific albums to check, I'll see what I can do. I've already looked at Xenoblade Special Sound Track, and determined that the cause is that it doesn't have the "Covers" block on the right hand side (which is what I was scraping). Presumably this is because it has only a single cover - I can fix that: vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo) v0.2

Alex
Title: Album Art Downloader XUI
Post by: the_miker on 2010-07-03 22:22:58
What I could try to do is have marked spots in the script to easily add your own login details. Then, if you edit the script to provide those it will log itself in with those, otherwise it will just use the publicly available medium sized images. I'll look into that when I get a chance.


That would be perfect.  I'd love to test that out!  VGMdb uses vBulletin 3.7.3 as their login system, FYI.

I was using the "composer" field of the advanced search for that, which I guess isn't right. Would "performer" make more sense here, do you think? Or should it be just ignored?


Composer would make the most sense for VGM, but am I understanding that my artist tag must exactly match to at least one of the composers on VGMdb, or the entire composer list?  Either way, I definitely think artist info should be ignored.  VGM artists have a lot of variations of spelling, language (tons of Japanese composers), etc. and I highly doubt all of anyone's tags would match up to VGMdb.

This should already happen. If there are multiple artists for a single album, it lists it as "Various Artists". For this to work, the album tracks must have identical Album tags, and be in the same folder. Looking at your screenshot, I can't see any obvious reason why 2197 shouldn't have been listed as a single "Various Artists" album - are all the tracks in the same folder?


Yeah, you're right.  It's a bug in the Foobar Browser.  It works properly in the File Browser, just need to wait for it to find all your music before it merges all the Various Artists albums.  Guess I'll stop using the Foobar Browser and switch to File Browser exclusively.

If you give me specific albums to check, I'll see what I can do. I've already looked at Xenoblade Special Sound Track, and determined that the cause is that it doesn't have the "Covers" block on the right hand side (which is what I was scraping). Presumably this is because it has only a single cover - I can fix that: vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo) v0.2


I can confirm that the Xenoblade issue is fixed is v0.2, thanks!  I'll play around with more albums and searches to see what else I can find.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-03 22:38:31
am I understanding that my artist tag must exactly match to at least one of the composers on VGMdb, or the entire composer list?
Form (http://vgmdb.net/search) says "contains". I haven't done much testing myself, but you can check the behaviour for various search cases directly with the website.

It's a bug in the Foobar Browser.  It works properly in the File Browser
Ah, should have noticed you were using the Foobar browser. Foobar has a proper "Album Artist" tag, so it uses that rather than try and guess based on the folder structure. If you want to keep using the Foobar browser, just tag your albums with an appropriate Album Artist and it should pick it up.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-04 10:01:53
Login was trickier than I thought. Still, should be working now. vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo) v0.3 should work the same as before, but if you edit the script first and enter your login details at the top where it's marked, for example:
Code: [Select]
    VGMDB_UserName = "the_miker"
    VGMDB_Password = "12345"
then it will log in and get larger images where available.

Alex
Title: Album Art Downloader XUI
Post by: the_miker on 2010-07-04 17:05:57
Login was trickier than I thought. Still, should be working now. vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo) v0.3 should work the same as before, but if you edit the script first and enter your login details at the top where it's marked

It works perfectly!  I tested it out with about 20 albums and it got the hi-res images for every single one.  Awesome!

Here are some notes I made while testing:

- I'm only seeing a maximum of 10 search results even if there are more than 10 images for a particular album

- At least one Artist in the search must be exact to get good results

- If "Various Artists" is the Artist in a search, it will never get results.  Maybe ignore artist all together, or at the very least when it's Various Artists?

- Can you make it so any image on VGMdb with "front" in the name shows up as "Front" in the search results?  Booklet Front, for example, shows as "Inside"

- Sometimes it takes a long time (2-3 minutes) to save an image, but that could be an issue with their server?  Happened with about a handful of albums so far
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-04 17:30:09
I'm only seeing a maximum of 10 search results even if there are more than 10 images for a particular album
Click the little "..." on the bottom right of the source to expand the options for it. Uncheck the "Limit to 10 results" box, or just adjust it to whatever limit you feel most appropriate. I think the site itself only returns 30, though.

If "Various Artists" is the Artist in a search, it will never get results.  Maybe ignore artist all together, or at the very least when it's Various Artists?
I'll ignore Artist if it's Various Artists, then. I'd prefer not to ignore Artist otherwise, on general principles - it's better to remove it if unwanted than to be unable to specify it if required. Updated: vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo)

Can you make it so any image on VGMdb with "front" in the name shows up as "Front" in the search results?  Booklet <anything>, for example, shows as "Inside"
This was deliberate. If it's the front of the booklet, then it's Inside the case. The Front is what appears on the front of the case. If you want to customise your own copy of the script, look at the GetCoverType method at the bottomof the script. You can edit that to return whatever type for whatever string you want, so long as it is one of Front, Back, CD, Inside or Unknown.

Sometimes it takes a long time (2-3 minutes) to save an image
My guess would be server issue. Possibly deliberate throttling, but in any case, it's nothing that the script is doing. Once the full size image is retrieved (if you preview it, for example), saving should be instantaneous, though - if that's not the case then there's something going wrong with AAD.

Alex
Title: Album Art Downloader XUI
Post by: the_miker on 2010-07-05 04:05:51
Click the little "..." on the bottom right of the source to expand the options for it. Uncheck the "Limit to 10 results" box, or just adjust it to whatever limit you feel most appropriate. I think the site itself only returns 30, though.


Ah ha!  I haven't played around with AAD long enough to know about the secret dots.  The site definitely returns more than 30 btw.  Try searching for a popular game title (Castlevania or Final Fantasy for example) and prepare to be destroyed with results!

I'll ignore Artist if it's Various Artists, then. I'd prefer not to ignore Artist otherwise, on general principles - it's better to remove it if unwanted than to be unable to specify it if required. Updated: vgmdb.boo (http://www.byalexv.co.uk/foobar/vgmdb.boo)


I actually agree with you on that now that I've played with it a little more.  It's handy to have the VA ignored and actually helps in most cases to have the non-VA artist filled out.

This was deliberate. If it's the front of the booklet, then it's Inside the case. The Front is what appears on the front of the case. If you want to customise your own copy of the script, look at the GetCoverType method at the bottomof the script. You can edit that to return whatever type for whatever string you want, so long as it is one of Front, Back, CD, Inside or Unknown.


I left the script alone and just got used to where it places stuff like "Booklet Front" or "Box Front" in the results.  The covers are easy to spot amongst the sea of booklet scans after a while, heh.

My guess would be server issue. Possibly deliberate throttling, but in any case, it's nothing that the script is doing. Once the full size image is retrieved (if you preview it, for example), saving should be instantaneous, though - if that's not the case then there's something going wrong with AAD.


It stopped happening when saving, but happens very rarely if I close a search window while it's still searching, and then the queue starts another one right away.  I've learned to stop a search before closing the window now though, and it hasn't happened since.

Anyway yeah, I downloaded album art for a huge chunk of my collection today.  I can't thank you enough man.  The combination of your awesome program and this VGMdb script seriously made my week, possibly month.  Now where's the "Buy Alex a coffee" link?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-05 13:57:01
I'm glad it's working out; thanks for letting me know. I've uploaded it as an 'official' script now, so it will appear on the "Get more scripts" link for existing users, and it will get bundled into the installer of the next version.

It's new permanent home is http://album-art.sourceforge.net/scripts/vgmdb.boo (http://album-art.sourceforge.net/scripts/vgmdb.boo), if you want to share it with anyone directly. I'll probably do a post in the VGMdb forums later to let them know of its existence too.

Alex
Title: Album Art Downloader XUI
Post by: tomaso on 2010-07-10 20:01:19
First of all I want to thank the creator for this lovely application and wish him best of luck.

I've been reading this topic for half an hour, but I still cannot find a solution for my setup. Regardless if it was discussed before, I'm hereby asking for help

All my covers are stored in one folder, with the naming structure being %artist% - %album%.jpg

When using the file browser, it not only automatically and irreparably sets the save folder for the results, but also the presets seem to be useless for my goal of getting the above naming scheme. I have to do all the naming and saving-to manually, which doesn't seem to be the purpose of this program.

So, Is there a way to configure the settings for my file structure setup?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-10 21:14:41
Thanks! To answer your question - unless you use the common Folder.jpg or Cover.jpg naming scheme, you have to tell the File Browser what your scheme is. To do this, click the Options link in the file browser, then in the "Path to find images" box, clear out the existing text and replace it with your structure. (The path to find images is also used as the default path to save images.)

As all your covers are in one folder, that's what you put in there, so it would look something like: c:\artwork\%artist% - %album%.%extension% (you could use .jpg instead of .%extension%, but then even if the artwork isn't in jpeg format it will still be given the .jpg extension, which might confuse some viewing software). Obviously substitute in whatever the actual path to your artwork folder is.

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: frnk on 2010-07-11 00:05:25
Once again, thanks for this great GREAT app!

Just wanted to let you know the Juno.co.uk script seems to have stopped working.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-11 09:18:15
Just wanted to let you know the Juno.co.uk script seems to have stopped working.
Thanks for letting me know. I've updated the script and it should work again now.

Alex
Title: Album Art Downloader XUI
Post by: frnk on 2010-07-11 10:33:27
Confirmed!

Thanks a lot!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-25 12:34:45
Wiki and Reference Guide
I've started a wiki on SourceForge for this project: Album Art Downloader XUI Wiki (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Main_Page).

It's still a bit bare bones, but I've started to fill in a reference guide. Hopefully I'll get around to writing more some time, and even more hopefully if anyone else would like to contribute, that would be most welcome. Suggestions for the FAQ page (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=FAQ-General) would also be useful - just edit the page to add your suggested question and I'll edit in an answer (or remove the question and reply to you directly, if I don't think it's of general interest).

If the wiki ever does become complete or useful enough, I'll add a link to it on the Help menu of AAD.

Alex
Title: Album Art Downloader XUI
Post by: GHammer on 2010-07-25 20:30:41
Wiki and Reference Guide
I've started a wiki on SourceForge for this project: Album Art Downloader XUI Wiki (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Main_Page).

It's still a bit bare bones, but I've started to fill in a reference guide. Hopefully I'll get around to writing more some time, and even more hopefully if anyone else would like to contribute, that would be most welcome. Suggestions for the FAQ page (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=FAQ-General) would also be useful - just edit the page to add your suggested question and I'll edit in an answer (or remove the question and reply to you directly, if I don't think it's of general interest).

If the wiki ever does become complete or useful enough, I'll add a link to it on the Help menu of AAD.

Alex



This is a most welcome thing.

I'd be very interested in the script writing section.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-26 20:06:59
I'd be very interested in the script writing section.
In that case, when you get a minute, could you have a look at what I've written and see if it makes things clear enough, or if there's any area that needs more detail?

Writing Script Files (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Writing_Script_Files)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-07-27 15:21:06
It seems that the following scripts are not working correctly:

- Cd Baby
- Discogs
- Freecovers
- Encyclopaedia Metallum (gets only 1 result in AAD, using the same URL to search in web browser shows 4 results, 2 of them having covers... search vars used: metallica / master)
- Metal Library

Alex, do you test all sources regularly, or do you just wait for the users to report them? Detecting not working scripts might be hard sometimes.. especially if one only looks at the AAD window and not the sources websites. Maybe you could set up a "testbed" for all the scripts with search vars which would always find results? And then run it once a month? More work for you, but would increase the reliability of the scripts.

BTW. Is it possible to get/read cookies sent from the server with BOO when requesting a web page?

Thanks.
Title: Album Art Downloader XUI
Post by: GHammer on 2010-07-27 16:32:20
I'd be very interested in the script writing section.
In that case, when you get a minute, could you have a look at what I've written and see if it makes things clear enough, or if there's any area that needs more detail?

Writing Script Files (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Writing_Script_Files)

Thanks,

Alex



Thank you Alex, the section is quite clear.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-27 18:37:30
Thanks for reporting these, I'll take a look as soon as I can. I do rely on users reporting sources failing, but check them all myself when doing a new version release. If no-one notices or cares that a source isn't working, then it isn't a priority for me to fix it!

It is possible to do cookies, yes. You need to create a CookieContainer and assign it to all the HttpWebrequests - check out the vgmdb.boo (http://album-art.sourceforge.net/scripts/vgmdb.boo) for an example.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-28 19:26:43
It seems that the following scripts are not working correctly:

- Cd Baby
- Discogs
- Freecovers
- Encyclopaedia Metallum (gets only 1 result in AAD, using the same URL to search in web browser shows 4 results, 2 of them having covers... search vars used: metallica / master)
- Metal Library

CD Baby and Metal Library seem to be working fine for me. They're a bit specialist, though - what did you search for?

Freecovers are currently upgrading their site (http://community.freecovers.net/index.php?showtopic=13484). Although they don't specifically mention the API, they say various parts of the site are temporarily unavailable (and the API gives a 404 'not found' error). So I'll regard this as a temporary fault, at least until they complete their upgrades.

Encyclopaedia Metallum and Discogs are fixed now, they should be showing up in the online updates.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: tomaso on 2010-07-28 21:24:27
...

(The path to find images is also used as the default path to save images.)

I hope this helps,

Alex


Yes, that information helped me a lot

thank you very much
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-07-28 22:56:11
CD Baby and Metal Library seem to be working fine for me... what did you search for?

For Metal Library: metallica / master ... when browsing to the http://metallica.metallibrary.ru/ (http://metallica.metallibrary.ru/) page, the first occurrence of "master" has a link to http://www.metallibrary.ru/bands/discograp...of_puppets.html (http://www.metallibrary.ru/bands/discographies/m/metallica/86_master_of_puppets.html) where a 400x400px cover is shown. Also the 3rd occurrence of the search word has a link to http://www.metallibrary.ru/articles/review...of_puppets.html (http://www.metallibrary.ru/articles/reviews/albums/m/metallica.86_master_of_puppets.html) where a 100x100px cover is shown. AAD shows nothing.

As for the CD Baby, same search vars (tried others too, no change, AAD never seem to show any results at all from this source). If I go to the website and search for "master" (w/o quotes), then "Refine Your Results" with "album", I get 491 results. This search is exactly the same as searching from AAD (I checked the URLs used in browser and in your script). What search vars do you use when you get results? EDIT: just noticed progress bar tooltips for sources.. when searching, CD Baby shows "Retrieved 0 of 9 results..." text for a while but then always ends and shows nothing.


Thanks for the fixes.
Title: Album Art Downloader XUI
Post by: mondalaci on 2010-07-29 06:37:56
Hey Alex,

First of all congratulations for this nice application!  I'm a Linux user and wanted to use it on Linux with Mono and realized that WPF is not implemented in Mono, however the command line is well supported. 

Typing "xbuild" in the CommandLineInterface directory builds the application without any hassle with Mono on Linux.  The only improvement that you may want to make is to rename the Scripts directory to scripts (with lowercase) because it's written lowercase in the code and uppercase as the directory name and Linux filenames are case sensitive.  As for now, renaming Scripts to scripts solves the issue.

I wanted to save every cover images to the filesystems instead of just one image so I've implemented a command line option that made it possible.  Let me quote the added paragraph of CommandArgsHelp.txt

[blockquote] /fetchAll    Saves every results to the filesystem.  (/fetchAll)
              The %sequence% variable must be used in order for
              the filenames to be unique for every results,
              otherwise they will be overwritten by each other.
              May be abbreviated to /a              (/a)[/blockquote]

Please let me know whether you're willing to merge my patch which is located at http://monda.hu/releases/aad-fetchall.diff (http://monda.hu/releases/aad-fetchall.diff)

There is a small, unrelated change in my patch which sets the cursor visibility to true, instead of false.  The reason behind this change is that it was very inconvenient for me to loose the cursor every time when pressing control-c when Album Art Downloader was running and I think that making the cursor invisible is a bad practice on Linux.

Thanks,
Laci
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-07-29 19:01:58
The MetalLibrary script required an exact album name to work. I've updated it now so that it does a "contains" search for the album name (so it will find "puppets", in your example), but it still requires the exact artist name.

The CD Baby script does a search for the album name, refined by Album. From those results, it then checks to see if any of them have an artist name that contains the artist name searched for. This is why you get the estimated results count dropping effect, as it checks each result and determines that the artist isn't a match and discards it. Unfortunately CD Baby doesn't support searching for both artist and album simultaneously, which is why this two-pass method is used. If you search for "master", but leave the artist field blank, you should get some results. Not the album you are looking for, of course, but then CD Baby is for independently published music, there's no chance they'd have Metallica on there!


Hi Laci,

Thanks for that! It's great to know that at least the command line tool works with Mono under Linux. I can't really start officially supporting it as a platform, but if there are small changes that can be made to improve the Linux compatibility, that's fine. With regards to your specific concerns:

Scripts folder casing: It's easier to correct the source to refer to it with a capital letter! This shouldn't affect Windows at all.

FetchAll functionality: That's great, thanks for contributing! I've merged it in for inclusion in 0.37, but changed the abbreviation to /fa. I've avoided "/a" as there are many parameters for which it could be used, and it's less confusing to just make all the potential "a" parameters have two-letter abbreviations. I've also reworded your help text a bit, as using %sequence% is recommended, but not compulsory (for example, you could use reasonably use "%source%/%name%-%type%.%extension%" with fetch all). I've also made a small fix so that it doesn't always claim no images were found when using fetchAll

Cursor visibility: The cursor visibility should automatically be turned back on, but I take your point about Ctrl-C killing the app before it can turn the cursor back on. As a compromise, I'll change it so that the cursor is turned back on after script compilation finishes (as it only turned off for showing the compilation progress) rather than when the program exits.

Alex
Title: Album Art Downloader XUI
Post by: mondalaci on 2010-07-31 02:58:29
Thanks for merging my patch and improving upon it, Alex!  I'm very happy with your decisions.

Keep it up!

Laci
Title: Album Art Downloader XUI
Post by: mondalaci on 2010-08-05 00:00:42
Alex,

When I search for an album cover in the GUI application, get some results and press the left button on a cover for some seconds to see the full sized cover and I release the button then sometimes the relevant record disappears from the GUI.  (I'm using the GUI application on Windows.)

I can reproduce this bug many times, but not always.  Is it known?  Can you fix it?

Thanks,
Laci
Title: Album Art Downloader XUI
Post by: Zarggg on 2010-08-05 03:33:26
This happens to me on occasion (less often now, since I have started using the "Automatically download full-size images: Only when size is unknown" and closing the program when not actively using it) in the following conditions:

Neither of those conditions is a bug, strictly speaking.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-05 08:35:27
Zarggg is right, this is almost certainly because the full sized image doesn't meet the filter criteria you've set.

If the full size image is not available for some reason, then the correct behaviour is to simply use the thumbnail image instead - the result shouldn't be removed unless this thumbnail doesn't match the filter criteria.

If you are sure that your filters aren't set up to exclude anything, then I'll look into this further. It would help if you could let me know which source it occurs with, too.

Alex
Title: Album Art Downloader XUI
Post by: mondalaci on 2010-08-08 21:38:48
Thanks guys!  I'm pretty sure that you're right and it's a filter related behaviour and not a bug.
Title: Album Art Downloader XUI
Post by: saxofone on 2010-08-09 16:18:51
hi all...new to this forum so i hope that i'm in the right place: i have my cover art stored in a CATraxx data base (.mdb) as .jpg files following this file path : C:\documents and settings\all users\documents\catraxx\database\g's stuff.mdb. Rather than use the foobar browser function in Album Art Downloader and search the internet for aprox 500 album covers, i would rather search and/or import my existing database images using the File Browser function and bring the cover art into foobar that way. Is this possible, and if so can someone tell me how?

Many thanks in advance,
geo
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-09 18:41:48
Is this possible, and if so can someone tell me how?
It's not possible to search for images inside a proprietary database, but if you can get CATraxx to export the images as files somewhere then you could could get the file browser to use those.
Title: Album Art Downloader XUI
Post by: saxofone on 2010-08-09 20:11:28
Is this possible, and if so can someone tell me how?
It's not possible to search for images inside a proprietary database, but if you can get CATraxx to export the images as files somewhere then you could could get the file browser to use those.



Thanks alex for your prompt reply, i will try your suggestion.
geo
Title: Album Art Downloader XUI
Post by: saxofone on 2010-08-10 01:45:46
Is this possible, and if so can someone tell me how?
It's not possible to search for images inside a proprietary database, but if you can get CATraxx to export the images as files somewhere then you could could get the file browser to use those.



Thanks alex for your prompt reply, i will try your suggestion.
geo



OK, would appreciate some assistance - i have extracted the jpeg image files to its own folder (E:\cover art) where each file is held as last name, first name - album title.jpg, - in the absence of two names ie. B.B. King, Basia, etc. only one name is listed - opened AAD and selected local files as the only source, then from the file menu selected file browser, and then selected the proper file path in the search for window...and no matter how i configure the other options, either nothing happens or the search stops after looking at one or two items in the cover art folder...please tell me what i am doing wrong and what i have to do to correct this...many thanks,
geo
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-10 08:37:04
OK, would appreciate some assistance

In the file browser, click the options link then in the box marked "Path to search for images" you need to tell it where your cover art is. In your case, that would be: E:\cover art\%artist% - %album%.%extension%. Then, point the file browser at your music collection and hit search. For each album found, it will try to locate the album art with the filename constructed from the artist and album name.

The only issue I can see is that your image files are saved with artist as "lastname, firstname". If that isn't how your music files are tagged ("firstname lastname" is more common), then it wouldn't find them. To work around this, you could use E:\cover art\* - %album%.%extension% instead - the downside of this being that if you have albums with the same name but by different artists, it would find the same image file for both, you'd have to watch out for this.

Alex
Title: Album Art Downloader XUI
Post by: saxofone on 2010-08-11 04:19:31
OK, would appreciate some assistance

In the file browser, click the options link then in the box marked "Path to search for images" you need to tell it where your cover art is. In your case, that would be: E:\cover art\%artist% - %album%.%extension%. Then, point the file browser at your music collection and hit search. For each album found, it will try to locate the album art with the filename constructed from the artist and album name.

The only issue I can see is that your image files are saved with artist as "lastname, firstname". If that isn't how your music files are tagged ("firstname lastname" is more common), then it wouldn't find them. To work around this, you could use E:\cover art\* - %album%.%extension% instead - the downside of this being that if you have albums with the same name but by different artists, it would find the same image file for both, you'd have to watch out for this.

Alex


thanks again alex, this mod has done the trick...one further request: as things stand now, when the correct image file is located in e:\cover art, the default 'save to' is the same e:\cover art; is it possible to change the default to the folder containing the album tracks, in my case, e:\rips where they are filed by artist (firstname, lastname), then by album name where the individual album tracks (as .wav files) as well as a .cue sheet (album name.cue): ie. e:\rips\artist name\album name? This would be a great time saver avoiding the necessity of having to do a 'save as' for every album in the collection.

Once again, many thanks,
geo
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-11 08:20:27
is it possible to change the default to the folder containing the album tracks
The default place to save images is the same place that it looks for them, on the grounds that if that's where you save images, you want images there to be found.

In your case, you have two folders where images may be found, "e:\cover art" and "e:\rips". To cope with this, you can specify both paths in the file browser, separated by a "|":

E:\rips\%artist%\%album%\folder.%extension%|E:\cover art\%artist% - %album%.%extension%

When saving, it will use the first path specified (e:\rips...) as the default place to save to. Again, the only issue is likely to be whether artist is specified as "firstname lastname" or "lastname, firstname". AAD can't convert between the two, so if the artist searched for is "firstname lastname" then that's how it will appear in the %artist% substitution.

Alex
Title: Album Art Downloader XUI
Post by: saxofone on 2010-08-12 04:45:50
is it possible to change the default to the folder containing the album tracks
The default place to save images is the same place that it looks for them, on the grounds that if that's where you save images, you want images there to be found.

In your case, you have two folders where images may be found, "e:\cover art" and "e:\rips". To cope with this, you can specify both paths in the file browser, separated by a "|":

E:\rips\%artist%\%album%\folder.%extension%|E:\cover art\%artist% - %album%.%extension%

When saving, it will use the first path specified (e:\rips...) as the default place to save to. Again, the only issue is likely to be whether artist is specified as "firstname lastname" or "lastname, firstname". AAD can't convert between the two, so if the artist searched for is "firstname lastname" then that's how it will appear in the %artist% substitution.

Alex



hi alex...it appears that i am unable to return any images with 2 paths specified; actually, the proper images are returned only when the file browser is configured as follows: "use file path pattern matching" is "* - %album%" AND "specify path to find images" is "e:\cover art\* - %album%.%extension%"
any further suggestions to relieve the "save as" issue are greatly appreciated...thanks,
geo
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-12 08:16:30
hi alex...it appears that i am unable to return any images with 2 paths specified

"specify path to find images" should then be "e:\rips\%artist%\%album%\folder.%extension%|e:\cover art\* - %album%.%extension%", without " marks. If for some reason the | isn't copying correctly, then enter the two paths one at a time, and use the > button on the right of the box and choose "alternate" from the drop down menu to insert one.

Alex
Title: Album Art Downloader XUI
Post by: saxofone on 2010-08-12 22:11:58
hi alex...it appears that i am unable to return any images with 2 paths specified

"specify path to find images" should then be "e:\rips\%artist%\%album%\folder.%extension%|e:\cover art\* - %album%.%extension%", without " marks. If for some reason the | isn't copying correctly, then enter the two paths one at a time, and use the > button on the right of the box and choose "alternate" from the drop down menu to insert one.

Alex



unfortunately alex, it still does not respond if more than one file path is specified...looks like i'll have to do it the old fashion way...many thanks for your help,
geo
Title: Album Art Downloader XUI
Post by: frnk on 2010-08-17 15:43:11
Hey all!

Is anyone else having any problems with the discogs script? It seems like sometimes it works, sometimes it just gets stuck while running and never finishes. It might be something to do with my connection, so that's why I'm asking.

(Also, it would be great if the Juno script could also search the digital releases (or perhaps a seperate script for Juno Download?). I would love to get into it myself, but the scripting is a bit out of my league right now, I think.)


-frnk
Title: Album Art Downloader XUI
Post by: DRata on 2010-08-19 21:49:00
Hey all!

Is anyone else having any problems with the discogs script? It seems like sometimes it works, sometimes it just gets stuck while running and never finishes. It might be something to do with my connection, so that's why I'm asking.

-frnk


Yes, I am also having this problem with discogs occasionally hanging during searches. I usually notice it when the graph on my CPU monitor gets stuck at 100%. Stopping the discogs search brings the CPU usage down immediately.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-20 08:11:40
Does the Discogs problem happen with specific search terms, or is it completely random? If there are search terms that trigger it I can try and reproduce it here, and see if I can fix it.

The Discogs script doesn't provide thumbnails, so when you do a search it has to download the full sized image for each result. These can be fairly large, so if you've got a slow connection you might want to set Discogs to only return a few results. To do this, click the ... link in the bottom right of the Discogs entry in the list of sources, and change the limit on number of results to be less than the default of 10.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-28 10:29:53
Album Art Downloader XUI v0.36 Released

This release adds much requested support for reading tag-embedded images. It does not support saving results into embedded tags (and isn't likely to in the near future), but being able to show images already embedded in tags is useful functionality that has been requested. This is available in the File Browser, and in the Local Files source.

In the File Browser, if you have it set to read ID3 tags (the default) then when it reads the tags it will also read the embedded image tag, if present. This will show up in the Artwork Status column as "Present", and the path to the image 'file' will be the path to the music file it is embedded within, suffixed by <n>, where n is a number indicating which embedded image was found. This will usually be 0, the first embedded image, but if there are multiple images and one of them is tagged as the Front Cover image, then that's the one which will be used. For example, "music.mp3<0>" indicates the first embedded image in the file "music.mp3". To view the image, right click on the link and choose "Preview".

The Local Files source is also now embedded-image aware. The default search string for this is now: %folder%\%filename%|%folder%\*<*>
The first part is the same as before, but the second alternate (separated by a |) instructs it to look in the default folder the image will be saved to (usually the album folder, as it would be saved there as folder.jpg), then look for any file (the \* bit), then within each file found, look for any embedded images (the <*> bit). If you are upgrading from a previous version of AAD, then you might want to copy and paste the above string into your local files "Path to find images" box (click the ... button in the Local Files source box to get to it) to get the new default behaviour.

Of course, you don't have to use the default. If you want it to search for just mp3 files, and just the first embedded image within them, then you could use %folder%\*.mp3<0>, for example.

The other change you might notice in this release is that in the search results, the type of the cover (Unknown, Front, Back, Inside, CD) can now be clicked on to manually correct. This can be useful if your filename pattern includes the type, but the source has got it wrong or left it set as Unknown. You can now manually correct the type before saving so that it is saved with the right name, rather than needing to edit the filename directly.

Finally, a /fetchAll parameter has been added to the command line version (aad.exe). This comes from a [a href='index.php?act=findpost&pid=716037']contribution made by mondalaci[/a]. The idea is that if you use this parameter, and a %sequence% substitution in the filename, you can save every result found from a search, not just one of them.

Other minor changes:

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.36.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.36.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: LyricsLover on 2010-08-28 14:19:47
Thank you for this new version!
I still have a little problem with "unallowed" signs under Windows:
Just search for this cover:
Artist: BRAD
Album: Best Friends?
You will get an brown album with a dog on the cover in some 3D-Style

If you like to save this cover with a right-click and "Save" you get the error:
---------------------------
Album Art Downloader
---------------------------
Could not save image 'd:\temp\BRAD (Best Friends?).jpg':

Illegales Zeichen im Pfad. *
---------------------------
OK 
---------------------------
* translated something like 'Illegal char in the path" - the '?'-sign isn't a valid character in windows-file-name.

Could you please remove/replace such impossible windows file-name-characters by default?
Please have a look here: http://msdn.microsoft.com/en-us/library/aa...28VS.85%29.aspx (http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29.aspx)

Thanks again for you wonderful program!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-28 16:53:20
Could you please remove/replace such impossible windows file-name-characters by default?
These characters are supposed to be automatically replaced by _ marks whenever they are substituted into the filename. So, if you have the path to save images to as %album%, and the album name is "Best Friends?", the filename should appear as "Best Friends_".

If this isn't happening for you, please could you let me know what the path pattern you are using is? From your example, I would expect it to be "d:\temp\%artist% (%album%).%extension%", but I've tested this with the album you suggested and it works fine for me.

Alex
Title: Album Art Downloader XUI
Post by: LyricsLover on 2010-08-28 17:13:30
Thank you for your fast answer!
I use your AAD together with Mp3tag. In Mp3tag I have added your great tool with this parameters:
/artist "%artist%" /album "%album%" /path "d:\temp\%artist% (%album%).jpg"

It seems, that Mp3tag passes this parameter like in the above example like this:
Artist: BRAD
Album: Best Friends?
Save images to: d:\temp\BRAD (Best Friends?).jpg

After a few tests, I think, I have to replace the /path-Parameter with something like this:
/artist "%artist%" /album "%album%" /path "d:\temp\$validate(%artist%,) ($validate(%album%,)).jpg"

According to the help-file '$validate' should
"Remove invalid characters from file name/file paths

Command: $validate(filename,to)
Example: $validate(%artist% - %album% - %track% - %title%,-)
This example replaces all invalid characters (/?*"<>| to dashes. "

Maybe this could help other users too.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-28 17:18:34
It seems, that Mp3tag passes this parameter like in the above example like this:
Artist: BRAD
Album: Best Friends?
Save images to: d:\temp\BRAD (Best Friends?).jpg

After a few tests, I think, I have to replace the /path-Parameter with something like this:
/artist "%artist%" /album "%album%" /path "d:\temp\$validate(%artist%,) ($validate(%album%,)).jpg"

Yes, that does the job. Alternatively, you can get Album Art Downloader to perform the substitution instead by using:

/artist "%artist%" /album "%album%" /path "d:\temp\%%artist%% (%%album%%).jpg"

The double %% makes it pass literally "%artist%" to AAD, rather than substituting in the name of the artist before passing it. AAD will then replace that with the name of the artist, automatically removing invalid characters as it does so.

Either way works, so thanks for letting me know.

Alex
Title: Album Art Downloader XUI
Post by: GuitarBoy55 on 2010-08-28 18:22:24
(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Splashscreen.gif)
[blockquote]
(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/SavePathAndSort.gif) (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Tooltip.gif) (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/DownloadingFullSize.gif)

(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/Sources.gif) (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FullArtPanel.gif)

(http://www.byalexv.co.uk/foobar/AlbumArtDownloader/FileBrowserClip.gif)
[/blockquote]
AlbumArtDownloader XUI - You know you want it...

This project is a rewrite of the Album Art Downloader code, using .NET Framework 3.5.

Features:
  • Dynamically resizeable thumbnails
  • Thumbnail information
  • Sort by Name, Size or Source
  • Filter results under or over a specified size, or by maximum results for each source
  • Substitution syntax path to save images
  • Local files search that matches save pattern
  • Enable or disable scripts from the command line
  • New strongly typed interface-based script model; write compiled scripts in any .net language
  • Backwards compatible with existing scripts
  • Backwards compatible with existing command line parameters, including old CoverDownloader parameters.
  • Analyse files to find Artists and Albums from tags, and check if album art is already present.
  • Analyse folder and file names to find Artist and Album names based on a path pattern, and check for album art.
  • Read your foobar2000 media library or playlists to find Artists and Albums, and check for album art.
For the graphically-minded out there, although this app isn't skinnable, the UI is all created in XAML, so if you want to grab the source and start editing the UI, please feel free. It is under the XUI folder in the SVN Repository (https://sourceforge.net/svn/?group_id=187008)

Links:
SourceForge project page (http://sourceforge.net/projects/album-art/)
Wiki and reference guide (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Main_Page) (incomplete)

Download:
AlbumArtDownloaderXUI.exe (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://www.byalexv.co.uk/foobar/AlbumArtDownloaderXUI.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Looks like a nice software. Preferably I would rather just rip the cover art from itunes using bitmap rip. I can trust the quality more and the dimensions are 600X600 which is very nice for file viewing on a PS3 or any big screen file viewing device. If I re sized the images on your software they'd be a little blurry. Other than that I think it's nice!
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-08-29 07:01:56
Does the Discogs problem happen with specific search terms, or is it completely random? If there are search terms that trigger it I can try and reproduce it here, and see if I can fix it.

Just noticed for the 1st time the same problem. Just now I made a "von hertzen brothers / experience" (w/o quotes) search and the Discogs script hangs, it gets no results and it seems that it would take 100% CPU & spin the search ticker to the end of the world if not stopped manually. I tried the search about 5 times and same thing every time. Then I made a "von hertzen brothers / love remains" (w/o quotes) search and Discogs found 1 cover and didn't hung. Tried this 2 times. Then back to the 1st search, it hangs again, this time the search ticker doesn't even play the "animation", i.e. I can't see the green bars at all. HTH.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-29 08:33:10
Just noticed for the 1st time the same problem.
Yes, that absolutely helps, thanks. I've pushed up an updated discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) that should resolve the issue. I took the opportunity to add in thumbnails and info-url support for the script as well, don't know why it didn't have them before. I guess it's just a very old script.
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-08-29 09:15:04
Already!? Man you're fast.. again! Every time! Humble thanks again for the lightning fast support.

So it was related to search not finding anything from a source? If yes, maybe you should check the amazon scripts too for this; now when I do "von hertzen brothers / love remains" (w/o quotes) search, the amazon scripts take 100% CPU at some point for a while and makes using the PC choppy (even maximizing/minimizing a measly notepad window is very choppy during that time). It seems that when they do not find anything, they do something CPU intensive stuff, and when all of the amazon scripts are used*, the effect is multiplied resulting to a 100% CPU and choppy performance (at least in my "old" P4 2.80GHz PC). When I search for the "experience" album, I don't see any freezes/abnormal CPU usage. With this search, all amazon sources except .fr returns 1 image.

* Why use all? Well, I haven't noticed a problem before this.. and sometimes some of the amazon scripts do not return results while others do.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-29 09:53:54
So it was related to search not finding anything from a source? If yes, maybe you should check the amazon scripts too for this;
Yes, sort of. It's related to the regular expression that searches the results html failing to match (as there were no results), but failing to match in a catastrophic way that meant that it was backtracking excessively. In essence, it was trying too hard and ending up going round in circles desperately trying to complete a partial match that was never going to happen. I've modified the regex to avoid this.

For amazon, it's not so obvious. I *think* I've located the offending part of the regex, but it's not such a bad case as the discogs one. Could you give this updated amazon-common.boo (http://www.byalexv.co.uk/foobar/amazon-common.boo) a try on your old P4 and let me know if it helps at all? My PC is fast enough to just rip through even the original without measurable pause, so I've used a regex debugger to give an indication of expected performance - but it would be good to get real-world results too!
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-08-29 12:34:27
My real-world moped of a computer says that it is totally fixed and thanks you kindly for taking a load off of her.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-29 12:58:50
My real-world moped of a computer says that it is totally fixed and thanks you kindly for taking a load off of her.
Cool, thanks for letting me know, I've stuck it up on the auto-updater. If anyone has any trouble with the updated version, please let me know. I think it will match the exact same things the old one did, but it's always a risk.
Title: Album Art Downloader XUI
Post by: JohntheRevelator on 2010-08-30 15:18:21

Hi all,

First off let me say a big thanks to the people responsible for Album Art Downloader.  A brill little utility and free as well!!!!

Second I know zip about computers/techie stuff so in advance please forgive very basic and stupid questions.   

Ok so I've been using Album Art Downloader for a while.  When I first started one of the sources it used to retreive art from was Album Art Exchange.  The quality of the artwork there was generally fantastic.  For a little while I had no computer but when I recently got a new laptop I downloaded Album Art Downloader again.  Album Art Exchange is still listed as one of the source "stores",  but no matter what I search for there are never any returns from that source; even well known big selling artists never mind obscure stuff.  Just to check I went to the Album Art Exchange website and found particular pieces of artwork (that I had searched for in Album Art Downloader) there but when I do a search in Album Art Dowloader they don't turn up.  Anyone any idea as to why this is??

Also when I get an album cover from Album Art Downloader what I do is highlight the tracks in ITunes then copy the album art from Album Art Downloader into the little box in ITunes and the artwork attaches itself to the tracks. Am I doing it right or should I be also saving the artwork somewhere?

Real basic stuff I know compared to some of the high tech questions on here, and apologies again for that, but any help would be appreciated.

Cheers

Title: Album Art Downloader XUI
Post by: mobyduck on 2010-08-31 08:20:09
Anyone any idea as to why this is??
Site owner made some changes that prevent this (and I suppose others as well) tool to retrieve art from AAE. You'll have to manually search from their web page.
Am I doing it right or should I be also saving the artwork somewhere?
Not sure I understand this question, sorry. AAD does NOT embed the artwork in your audio files, but can save it in a folder of your choice; don't know what iTunes does (and what you're trying to achieve).

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-08-31 08:31:19
Also when I get an album cover from Album Art Downloader what I do is highlight the tracks in ITunes then copy the album art from Album Art Downloader into the little box in ITunes and the artwork attaches itself to the tracks. Am I doing it right or should I be also saving the artwork somewhere?

Mobyduck is correct, Album Art Exchange was disabled by the site owner, who no longer wanted Album Art Downloader to be able to access it. To answer your other question, your method of getting artwork into iTunes is fine. Whether you want to save the art as a file as well is up to you; if you're happy with what iTunes is doing with it then you can just leave it stored there.

You might also want to check out [a href='index.php?showtopic=51708']iTunes Store File Validator[/a] which can automate some of this stuff for you, but again, that's completely up to you.
Title: Album Art Downloader XUI
Post by: durch on 2010-08-31 09:25:42
Does this program download Amazon's very high quality covers? The ones you normally cannot download with a web browser but just zoom? The quality of the zooms is awesome.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-09-03 08:28:52
Does this program download Amazon's very high quality covers? The ones you normally cannot download with a web browser but just zoom? The quality of the zooms is awesome.
No, it doesn't. I haven't seen that feature on any albums I've recently looked at, I thought maybe they'd removed it. Anyway, I think they've put considerable effort into making sure that other software can't download them, so I don't think it's worth getting into an arms race for it.
Title: Album Art Downloader XUI
Post by: hymerman on 2010-09-13 01:19:07
Wow, just stumbled across this, I remember using the original way back when but I had no idea it'd have come this far. I've just given it a whirl and I love it; thanks!

A couple of points of feedback: first, it doesn't deal well with tags that contain invalid characters; if there's a track with say a '?' or '...' or ':' in its title, the program will try to guess the path, but always seems to get it wrong. Perhaps some setting to specify how these characters map to path characters would be useful? Or perhaps the search could replace these with wildcards, though I think that'll get expensive quickly.

Second, it doesn't seem to deal well with multiple disc albums, though I've a feeling I just need to set up the search filters a bit better. For example, some multi-disc albums have a separate cover for each disc (Eric Clapton's Crossroads for example), where I like to put the front cover's artwork inside the disc directory, but some albums share one cover, in which case I put the artwork up one directory, in the album directory. I've got the filter set up to check both of these like so:

"M:/music/%artist%/%album%/%preset%.%extension%|M:/music/%artist%/%album%/Disc %disc%/%preset%.%extension%"

... but that doesn't seem to work, sometimes.

Third, the foobar browser is fantastic, but one tiny thing that would make things clearer is instead of saying "found: inlay.jpg" (or whatever), for it to say which of the presets it has found. As it is, I think it'll accept each album if it has any of the presets at all, but I'd like to know if any albums are missing particular ones.

I appreciate how valuable your free time is so if you like you could point me in the right direction and I could have a look at these bugs/features, I've done a wee smidgen of C# in my time.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-09-13 08:30:58

Hello, glad you liked it, and thanks for your comments and feedback.

Invalid path characters in tags: At the moment any invalid characters are mapped to "_". There was a request to make this customisable, but it would still be a replacement of all invalid characters with some other replacement character. Are you talking about having a fully customisable map where you can specify which character every invalid character is replaced be? That sounds a bit like overkill to me...

For Multi-disc albums, your filter looks OK, except there's no %disc% placeholder; try replacing that with * instead. Alternatively, you could try searching for the image relative to the location of the album (defined as the folder in which it finds the music files), so just "%preset%.%extension%|../%preset%.%extension%".

For your comment about the browser, you are right, both the foobar and file browsers will only look for one existing image for each album, once it finds one, it stops looking. I would certainly want this to continue to be the default behaviour, but I'll see if I can come up with any good ideas for allowing a user to check for the presence of multiple existing images too. As a workaround, you could perform the search multiple times, once for each image you want to check (so instead of %preset%, put the actual preset you want to search for in the string)

It's great to hear you'd like to get involved in the code too. The sourceforge page is here (http://sourceforge.net/projects/album-art/), and the source is in SVN (http://sourceforge.net/scm/?type=svn&group_id=187008). Ignore anything except for the XUI subfolder (http://album-art.svn.sourceforge.net/viewvc/album-art/XUI/), the other stuff is the old version that's no longer maintained.

For the specific changes you've mentioned:
Invalid Path Characters: See AlbumArtDownloader/Common.cs/Common.MakeSafeForPath and CommandLineInterface/Program.cs/Program.MakeSafeForPath. Ideally, these two would perform the same operation so that aad.exe is consistent with the main GUI version.

Multiple Image Searching: Trickier, as I don't have a handle on a good design for this at the moment. The best place to start would probably be AlbumArtDownloader/BrowserResults.xaml.cs/ArtFileSearchWorker, BrowserResults is the common control for both file and foobar browser.

If you have any specific questions about the code, please feel free to PM me here, or email me through Sourceforge, or even break in the Developers Forum (https://sourceforge.net/projects/album-art/forums/forum/654590) if you like!

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: Alexander Ostuni on 2010-09-18 12:58:55
Hi,

Albumartdownloader wants to force me to download Net 3.5 although I have 4 alreday installed. Is there a way around it, or can it cause trouble installing the older version over the newer ?

Cheers
Alex
Title: Album Art Downloader XUI
Post by: GHammer on 2010-09-18 15:28:48
Hi,

Albumartdownloader wants to force me to download Net 3.5 although I have 4 alreday installed. Is there a way around it, or can it cause trouble installing the older version over the newer ?

Cheers
Alex


Is it holding a gun on you? Never seen software force folks to do something.

All .Net packages are separate. Just install 3.5 and the security updates for it.
Title: Album Art Downloader XUI
Post by: phunkydizco on 2010-09-20 09:11:43
Is there a way to make ADD portable? I download the ZIP file and installed it on my USB device. But when I start ADD the user.config is still saved under \AppData\Local\AlbumArtDownloader.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-09-20 09:27:18
Is there a way to make ADD portable?
First of all, it will always require .net 3.5, so it would only ever be portable to systems that already had that installed.

AAD uses the standard .net configuration settings mechanism, and I don't think it's possible (without abandoning that and writing a custom settings mechanism) to prevent it from writing those settings to AppData. What you can do is copy an already-created user.config to the AAD program folder and rename it as AlbumArt.exe.config; that will let you take your settings with you portably. Any new changes you make while running will be saved to AppData, though.
Title: Album Art Downloader XUI
Post by: gunrunner on 2010-10-04 12:58:51
Don't sure if I'm the right place, but Album Art Downloader doesn't work at all for me, on both Windows Seven 32bits & 64bit systems.

I tried every single version from 0.31 to 0.36, .exe and .zip, I also tried running it as administrator, but it still doesn't launch.

Here are some screenshots of what I've got when I start AAD :

(http://img707.imageshack.us/img707/2553/aad1.jpg) (http://img707.imageshack.us/i/aad1.jpg/)

(http://img824.imageshack.us/img824/608/aad2.jpg) (http://img824.imageshack.us/i/aad2.jpg/)

It's kind of weird since I remember having used it perfectly on Windows Seven about 1 year ago.
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-10-04 13:04:26
.NET Framework 3.5 SP1 (required, except for Windows 7)

Did you remember that
Title: Album Art Downloader XUI
Post by: gunrunner on 2010-10-04 13:10:11
.NET Framework 3.5 SP1 (required, except for Windows 7)

Did you remember that


I said I was running Windows 7, 32-bit and 64-bit editions, as you said, not required.
Title: Album Art Downloader XUI
Post by: gunrunner on 2010-10-04 13:58:22
Well, I've tried this : http://windows7forums.com/windows-7-progra...html#post116572 (http://windows7forums.com/windows-7-programming-scripting/8160-install-net-framework-3-5-sp1-windows-7-a-2.html#post116572)

I've reboot, launched AAD and even if there is some change, it still crashes :

(http://img840.imageshack.us/img840/4152/sanstitrentl.jpg) (http://img840.imageshack.us/i/sanstitrentl.jpg/)

I've also noticed that the CPU load is constantly at 50% until I kill the process.
Title: Album Art Downloader XUI
Post by: frnk on 2010-10-04 22:06:14
Hey there Alex!

First of all, many thanks for solving the issue with the discogs-script a few pages back!

Second, it seems the Juno-script has stopped working now.... (I really need to get into the scripting next time I have a week off ;-)



Regards,
Frnk
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-04 22:34:55
I've reboot, launched AAD and even if there is some change, it still crashes
I'm sorry that AAD is not working for you. I'm afraid I can only suggest uninstalling it, attempting to fix the .net framework (as you mentioned you'd already tried), then re-installing it. It might be useful to know if any other .net applications work for you, but frankly there's unlikely to be anything useful I can suggest to you in any case.

it seems the Juno-script has stopped working now...
Thanks for letting me know, I'll fix that script as soon as I get a chance.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-05 19:11:19
I've just uploaded a fixed Juno script, and a new Kalahari one, they should be available through the online updates system as usual. Kalahari is good for South African music.

Alex
Title: Album Art Downloader XUI
Post by: frnk on 2010-10-06 17:19:50
I've just uploaded a fixed Juno script, and a new Kalahari one, they should be available through the online updates system as usual. Kalahari is good for South African music.

Alex




Awesome! Thanks!
Title: Album Art Downloader XUI
Post by: sylla on 2010-10-10 23:48:21
First, thanks a lot for the program, I really appreciate it, and it has worked perfectly for me until today

But now, when I try to run the program it doesn't start, and I get this message

Code: [Select]
App version: 0.29.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.ArgumentOutOfRangeException: Parametervärdet måste vara mellan '0' och '3579139,40666667'.
Parameternamn: paragraphWidth
  vid MS.Internal.TextFormatting.TextFormatterImp.VerifyTextFormattingArguments(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextRunCache textRunCache)
  vid MS.Internal.TextFormatting.TextFormatterImp.PrepareFormatSettings(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache, Boolean useOptimalBreak, Boolean isSingleLineFormatting)
  vid MS.Internal.TextFormatting.TextFormatterImp.FormatLineInternal(TextSource textSource, Int32 firstCharIndex, Int32 lineLength, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache)
  vid MS.Internal.TextFormatting.TextFormatterImp.FormatLine(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache)
  vid System.Windows.Controls.TextBlock.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Control.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Grid.MeasureCell(Int32 cell, Boolean forceInfinityV)
  vid System.Windows.Controls.Grid.MeasureCellsGroup(Int32 cellsHead, Size referenceSize, Boolean ignoreDesiredSizeU, Boolean forceInfinityV)
  vid System.Windows.Controls.Grid.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Border.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid MS.Internal.Helper.MeasureElementWithSingleChild(UIElement element, Size constraint)
  vid System.Windows.Controls.ContentPresenter.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Decorator.MeasureOverride(Size constraint)
  vid System.Windows.Documents.AdornerDecorator.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Border.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Window.MeasureOverrideHelper(Size constraint)
  vid System.Windows.Window.MeasureOverride(Size availableSize)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Interop.HwndSource.SetLayoutSize()
  vid System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
  vid System.Windows.Interop.HwndSource.set_RootVisual(Visual value)
  vid System.Windows.Window.SetRootVisual()
  vid System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
  vid System.Windows.Window.CreateSourceWindowImpl()
  vid System.Windows.Window.SafeCreateWindow()
  vid System.Windows.Window.ShowHelper(Object booleanBox)
  vid System.Windows.Window.Show()
  vid System.Windows.Window.ShowDialog()
  vid AlbumArtDownloader.Splashscreen.ShowIfRequired()
  vid AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  vid System.Windows.Application.<.ctor>b__0(Object unused)
  vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.DispatcherOperation.InvokeImpl()
  vid System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  vid System.Threading.ExecutionContext.runTryCode(Object userData)
  vid System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  vid System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  vid System.Windows.Threading.DispatcherOperation.Invoke()
  vid System.Windows.Threading.Dispatcher.ProcessQueue()
  vid System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  vid MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  vid MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  vid MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  vid MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  vid System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  vid System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  vid System.Windows.Threading.Dispatcher.Run()
  vid System.Windows.Application.RunDispatcher(Object ignore)
  vid System.Windows.Application.RunInternal(Window window)
  vid System.Windows.Application.Run(Window window)
  vid System.Windows.Application.Run()
  vid AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  vid AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  vid AlbumArtDownloader.App.Main(String[] args)
I have encountered a similar problem now, however, the solution you gave me back then to delete the folder in application data doesn't help me anymore as I can't find the folder, has it moved?

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program\AlbumArtDownloader\errorlog.txt

App version: 0.36.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.ArgumentOutOfRangeException: Parametervärdet måste vara mellan '0' och '3579139,40666667'.
Parameternamn: paragraphWidth
  vid MS.Internal.TextFormatting.TextFormatterImp.VerifyTextFormattingArguments(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextRunCache textRunCache)
  vid MS.Internal.TextFormatting.TextFormatterImp.PrepareFormatSettings(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache, Boolean useOptimalBreak, Boolean isSingleLineFormatting)
  vid MS.Internal.TextFormatting.TextFormatterImp.FormatLineInternal(TextSource textSource, Int32 firstCharIndex, Int32 lineLength, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache)
  vid MS.Internal.TextFormatting.TextFormatterImp.FormatLine(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache)
  vid System.Windows.Controls.TextBlock.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Control.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Grid.MeasureCell(Int32 cell, Boolean forceInfinityV)
  vid System.Windows.Controls.Grid.MeasureCellsGroup(Int32 cellsHead, Size referenceSize, Boolean ignoreDesiredSizeU, Boolean forceInfinityV)
  vid System.Windows.Controls.Grid.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Border.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid MS.Internal.Helper.MeasureElementWithSingleChild(UIElement element, Size constraint)
  vid System.Windows.Controls.ContentPresenter.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Decorator.MeasureOverride(Size constraint)
  vid System.Windows.Documents.AdornerDecorator.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Controls.Border.MeasureOverride(Size constraint)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Window.MeasureOverrideHelper(Size constraint)
  vid System.Windows.Window.MeasureOverride(Size availableSize)
  vid System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  vid System.Windows.UIElement.Measure(Size availableSize)
  vid System.Windows.Interop.HwndSource.SetLayoutSize()
  vid System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
  vid System.Windows.Interop.HwndSource.set_RootVisual(Visual value)
  vid System.Windows.Window.SetRootVisual()
  vid System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
  vid System.Windows.Window.CreateSourceWindowImpl()
  vid System.Windows.Window.SafeCreateWindow()
  vid System.Windows.Window.ShowHelper(Object booleanBox)
  vid System.Windows.Window.Show()
  vid System.Windows.Window.ShowDialog()
  vid AlbumArtDownloader.Splashscreen.ShowIfRequired()
  vid AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  vid System.Windows.Application.<.ctor>b__0(Object unused)
  vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.DispatcherOperation.InvokeImpl()
  vid System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  vid System.Threading.ExecutionContext.runTryCode(Object userData)
  vid System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  vid System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  vid System.Windows.Threading.DispatcherOperation.Invoke()
  vid System.Windows.Threading.Dispatcher.ProcessQueue()
  vid System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  vid MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  vid MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  vid System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  vid System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  vid MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  vid MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  vid System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  vid System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  vid System.Windows.Threading.Dispatcher.Run()
  vid System.Windows.Application.RunDispatcher(Object ignore)
  vid System.Windows.Application.RunInternal(Window window)
  vid System.Windows.Application.Run(Window window)
  vid System.Windows.Application.Run()
  vid AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  vid AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  vid AlbumArtDownloader.App.Main(String[] args)
This shows up when I try to start the program, I tried reinstalling it, but as I said I can't find the folder in "documents and settings", I suppose it has already been deleted. Strange though that the settings still seems to remain.

Also, thanks again for this very useful program, and for your help when it doesn't work
Title: Album Art Downloader XUI
Post by: Cold-Phoenix on 2010-10-11 00:18:46
Request for a feature, been playing around with this great program.
While covers are mostly correct and a few need manually altering to pick nice ones out (for some reason people have massive white borders on some of them) the one thing that would be nice is to have a band/artist preset.
Manually going through downloading covers i found it detects plenty of artist profile pictures in addition, a preset to filter these separately and save them in a numbered form would be a nice addition:

Folder-Band 01
Folder-Band 02
Folder-Band 03

The only other gripe i would say from a user interface point of view is the lack of ability to switch modes/pick default. I tend to use the foobar browser as the starting point so i have to open a new window straight away.

Thanks for the work that has gone into this its incredibly useful
Aidan
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-11 08:09:40
I've just published another South African based script: Take2.boo (http://album-art.sourceforge.net/scripts/take2.boo). It should also show up in the online updates mechanism.

I have encountered a similar problem now, however, the solution you gave me back then to delete the folder in application data doesn't help me anymore as I can't find the folder, has it moved?
It has not been moved, no. On Vista or 7 the folder will be under C:\Users\<username>\AppData\Local\AlbumArtDownloader, though.

I think to do artist pictures properly, it should be a separate search window, with separate sources. There would be some overlap, of course, Google Images would appear in both lists. It's a possibility, for the future, but not one I'm that keen on as I like to keep the program fairly tightly focused on the single  task of obtaining album art images.

To use the foobar browser as the starting point, change the shortcut you use to start the program to add the command line parameter /foobarBrowser
If you want it to immediately start the search in the foobar browser window then use /foobarBrowser search

Hope this helps!

Alex
Title: Album Art Downloader XUI
Post by: sylla on 2010-10-11 10:33:12
I have encountered a similar problem now, however, the solution you gave me back then to delete the folder in application data doesn't help me anymore as I can't find the folder, has it moved?
It has not been moved, no. On Vista or 7 the folder will be under C:\Users\<username>\AppData\Local\AlbumArtDownloader, though.

Ok, I am using WinXP and the folder isn't there. I get that message whenever I try to start the program, do you have any other thought on what might be the problem? I have no idea what brought on the problem, one day it just stopped working.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-12 08:06:22
Ok, I am using WinXP and the folder isn't there. I get that message whenever I try to start the program, do you have any other thought on what might be the problem? I have no idea what brought on the problem, one day it just stopped working.
Sorry, I don't really know what might be causing the problem. The only thing I can suggest that might help is uninstalling then re-installing the .net 3.5 framework.

Alex
Title: Album Art Downloader XUI
Post by: Novalak on 2010-10-15 05:14:29
has anyone created an albumartexchange scraping script ?
if so can someone contact me? would really like it if possible
Title: Album Art Downloader XUI
Post by: Akkurat on 2010-10-15 07:43:45
Sometime ago I actually quite easily figured out how to get the AAX script working again (actually, not just 1 option to do it but at least 2), although the site owner has, if I understood correctly, declared that it is impossible now. But I won't do it, it's going to start a cat and mouse game that would require me (or maybe somebody else) to modify the script constantly, not worth my time. But it's doable, oh yes.
Title: Album Art Downloader XUI
Post by: Novalak on 2010-10-16 02:07:51
they have the best artwork
Title: Album Art Downloader XUI
Post by: satakeh on 2010-10-19 20:05:24
I'm really loving this APP!!
But won't return any result from Amazon.jp. (in Japanese and also English)
Is there any solutions?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-21 08:24:33
But won't return any result from Amazon.jp.
Thanks for reporting this. In fact, all Amazon scripts stopped working; Amazon changed their page a little. I've uploaded an updated amazon-common.boo (http://&quot;http://album-art.sourceforge.net/scripts/amazon-common.boo) which should mean that all Amazon scripts get updated through the online updates mechanism.

If you notice any problems with the updated script, please let me know what the album and artist you were searching for, and which country variation of Amazon you were searching, and hopefully I can make the updated script robust across all variations again.

Alex
Title: Album Art Downloader XUI
Post by: Brand on 2010-10-21 13:32:58
I tried running AAD XUI (non-installer version) and I get this:
(http://i51.tinypic.com/2dqfwz.jpg)

Win 7 64.

Didn't read the whole thread, is there a known solution?
Title: Album Art Downloader XUI
Post by: satakeh on 2010-10-21 16:57:20
Thanks for reporting this. In fact, all Amazon scripts stopped working; Amazon changed their page a little. I've uploaded an updated amazon-common.boo (http://&quot;http://album-art.sourceforge.net/scripts/amazon-common.boo) which should mean that all Amazon scripts get updated through the online updates mechanism.

If you notice any problems with the updated script, please let me know what the album and artist you were searching for, and which country variation of Amazon you were searching, and hopefully I can make the updated script robust across all variations again.

Alex

Thanks for great update.
New script works fine!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-21 19:47:46
I tried running AAD XUI (non-installer version) and I get this:
is there a known solution?
Sorry, but that error doesn't give me much to go on. It occurred at a lower level than AAD itself (the code represents a generic COM error within the CLR), so I'd normally suspect a problem with the .net framework 3.5, and suggest an uninstall and reinstall. However, as you are using Windows 7, it's already built in, which leaves me a bit out of ideas, to be honest.

Alex
Title: Album Art Downloader XUI
Post by: Der Internet on 2010-10-21 20:47:28
there is always the magic spell called "formaticus systemdriveicus"



thanx for your great Tool, i finished grabbing Artwork for almost 5000 albums ( catch me, RIAA !  ) and now i got  over 19.000 jpgs which results in about 7 GB.

And i searched all of 'em manually, cause i dont trust the auto-save feature plus i got many not so well known Bands ....that was a hell of a job. But totally worth it! Thanx again
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-22 08:20:00
thanx for your great Tool

Thanks for your comments, I'm glad you liked it!
Title: Album Art Downloader XUI
Post by: ton on 2010-10-23 22:13:00
What am I doing wrong ?
I did not use AAD for some time, but I remember it did work perfectly for me. But now, most of the times it does not return any result even when I search for very well known albums. AAD starts normally and begins searching but only finds local files. Only now and then (very rarely) it finds something.
FWIW I have Windows 7 Professional and have installed AAD 0.36.0.0.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-24 08:16:49
most of the times it does not return any result even when I search for very well known albums.
Have you got the latest updates to the scripts? If not, then try clicking the Help menu, and Check for Updates.

If you've already got the latest versions of the scripts, then please let me know the artist and album you were searching for, and which scripts were not returning any results, and I'll look into it for you.

Alex
Title: Album Art Downloader XUI
Post by: sylla on 2010-10-24 11:39:15
I've had some problems with crashes (see post 1460) and now I think I now what the problem is.

There seems to be some sort of conflict with IndieVolume (http://www.indievolume.com/), a program for program-specific sound management in XP (it's built in in Windows since Vista, I think). When I start Indie Volume some process seems to start (not visible in the process management window) in Windows that make AAD crash when it tries to start. It doesn't matter if I quit indievolume, I have to restart Windows to use AAD again, but after that it works fine again.

I realize this is a very minor problem, but I thought I'd share it with you anyway, maybe the information could be useful to you in some way...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-24 11:57:25
There seems to be some sort of conflict with IndieVolume (http://www.indievolume.com/)

Thanks for the information. I doubt there's much I can do from my end to resolve the conflict, as it is IndieVolume that is doing some low-level weird stuff, but if I do discover anything I'll let you know.
Title: Album Art Downloader XUI
Post by: ton on 2010-10-24 14:13:40
If you've already got the latest versions of the scripts, then please let me know the artist and album you were searching for, and which scripts were not returning any results, and I'll look into it for you.
Alex


Thanks for your reply.
I updated the scripts but that does not help. Btw, I said that I sometimes get results but on second thought I think that that probably were local files.
It doesn't matter what album or artist I search for. Even when I enter, for instance only, artist "Bob Dylan" (without quotes of course), nothing is found. I see the progress bar on all search engines for some time, then all stop and no covers are shown.
Because I saw that .NET Framework 4 is installed on my pc, I even uninstalled it and installed 3.5, but that doesnt help either.
Moreover I have this problem on my wife's pc and my laptop as well, both with Windows 7. (I also tried running AAD in Windows XP compatibility mode).

Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-24 17:00:35
I see the progress bar on all search engines for some time, then all stop and no covers are shown.
Because I saw that .NET Framework 4 is installed on my pc, I even uninstalled it and installed 3.5, but that doesnt help either.
Moreover I have this problem on my wife's pc and my laptop as well, both with Windows 7. (I also tried running AAD in Windows XP compatibility mode).

XP Compatibility mode should not be turned on, AAD is developed under Windows 7 and requires no compatibility flags. From what you are describing, it looks like AAD is not able to download data from the internet. Do you have firewall software which might be blocking it? Or do you use a proxy server to connect to the internet?
Title: Album Art Downloader XUI
Post by: ton on 2010-10-24 18:54:02
XP Compatibility mode should not be turned on, AAD is developed under Windows 7 and requires no compatibility flags. From what you are describing, it looks like AAD is not able to download data from the internet. Do you have firewall software which might be blocking it? Or do you use a proxy server to connect to the internet?


I don't use a proxy server and only have Windows Firewall. I tried it with Windows Firewall disabled, but that didn't make a difference.
But meanwhile I did get results sometimes but very randomly. Maybe 1 out of of 7 of 8 attempts I almost immediately get covers for a certain album, but the other times nothing is returned for the same album.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-24 20:33:29

Let's take this out of the thread - I've sent you a PM. If we come up with a solution of general interest I'll post it here too.
Title: Album Art Downloader XUI
Post by: Brand on 2010-10-26 17:06:40
Does .NET Framework 3.5.1 under "Windows features" in Win 7 need to be turned on for this to work?

I've never had problems with other programs that need .NET otherwise with that thing disabled.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-10-26 18:13:36
Does .NET Framework 3.5.1 under "Windows features" in Win 7 need to be turned on for this to work?
I would have thought so. It is a .net 3.5 application after all. Of course, if you've managed to get it to work without that feature turned on then I'm not going to argue the point!
Title: Album Art Downloader XUI
Post by: Brand on 2010-10-26 18:36:29
I've enabled that and it's working now!
Title: Album Art Downloader XUI
Post by: icon123 on 2010-10-31 03:08:47
Nevermind - This is a great program!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-07 11:52:54
Album Art Downloader XUI v0.37 Released

This release fixes up some scripts, and adds a couple of requested command line parameters:

/new ensures that a new window is opened by the command line. If this isn't specified, and you have "Open search results in new window" checked, and there is only one window open, then that window would be replaced by any new search initiated by the command line.

/minimized makes any window shown by the command line start minimized. It doesn't affect already open windows.

/config opens notepad showing your Album Art Downloader user.config file. This is just a shortcut to avoid having to search for the file under %LOCALAPPDATA%\AlbumArtDownloader manually. Generally, you shouldn't need to change anything in this file directly.

However, I have added a new hidden setting which can be enabled by editing the user.config file, called UseSystemCodepageForID3Tags. The ID3 specification states that tags must either be in Unicode, or Latin1 encoding. Unfortunately, some software produces incorrect tags, encoding them with the system codepage instead. This isn't a problem if your system codepage is Latin1, but if you're running a different locale version of Windows, then it's likely to be your locale-default codepage, not Latin1.

Basically, if you're running non-English Windows, and tags you've saved are showing up mangled or with invalid characters when read by the File Browser in Album Art Downloader (and you don't want to fix whatever software you are using to write these tags that's doing it wrong), then you can search for this property in the user.config file and change it from False to True. This will fix the display of those tags, but may mean that tags in files which have been written correctly in Latin1 may show up mangled or with invalid characters.

(Also: this is the first release since I moved to using Visual Studio 2010 for development, but it still targets .NET 3.5, not 4.0, so it shouldn't mean any changes for users.)

Download:
AlbumArtDownloaderXUI.exe (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.37.exe) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://downloads.sourceforge.net/album-art/AlbumArtDownloaderXUI-0.37.zip) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: iQwerty on 2010-11-07 14:06:32
Is it possible to let the program just download the first lastfm cover it finds?

Because with this run command:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /ar "%artist%" /al "%album%" /mn 300 /mx 1000 /s "LastFM Cover" /path "$replace(%_path%,%_filename_ext%,)cover.jpg" /t f /autoclose

I basically always find the correct cover. Would be nice if the process could be automated for my whole library, instead of having to run it for every album and hit save each time
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-07 14:23:48
Is it possible to let the program just download the first lastfm cover it finds?

Yes, if you're feeling lucky. Start the file browser, or foobar browser from within AAD, and make sure it can find all your albums. Once you've selected all the albums you want to automatically get the first lastfm cover for, check that the option "Automatically download and save the first result that meets set criteria" is selected (click the options link to show it). From your command line, you want the image to be called cover.jpg, so in the "Specify path to find images" box, remove the "Folder%preset%.%extension%|" so that just the "Cover%preset%.%extension%" part remains (you can put the Folder part after the Cover part, if you like, so it will also look for Folder.jpg when checking if there are existing images - the important thing is that the start of that string is the name you want the images to be automatically saved as, in this case "cover").

Then, click the Get Artwork for Selection button, and the automatic image downloader window will appear.

In this window you can set the minimum and maximum size for the image to 300 and 1000, like your command line, and make sure only the LastFM Cover source is checked on the list of sources on the right. Hit the Start button, and let it do its thing.

Alex
Title: Album Art Downloader XUI
Post by: iQwerty on 2010-11-07 14:50:32
Is it possible to let the program just download the first lastfm cover it finds?

Yes, if you're feeling lucky. Start the file browser, or foobar browser from within AAD, and make sure it can find all your albums. Once you've selected all the albums you want to automatically get the first lastfm cover for, check that the option "Automatically download and save the first result that meets set criteria" is selected (click the options link to show it). From your command line, you want the image to be called cover.jpg, so in the "Specify path to find images" box, remove the "Folder%preset%.%extension%|" so that just the "Cover%preset%.%extension%" part remains (you can put the Folder part after the Cover part, if you like, so it will also look for Folder.jpg when checking if there are existing images - the important thing is that the start of that string is the name you want the images to be automatically saved as, in this case "cover").

Then, click the Get Artwork for Selection button, and the automatic image downloader window will appear.

In this window you can set the minimum and maximum size for the image to 300 and 1000, like your command line, and make sure only the LastFM Cover source is checked on the list of sources on the right. Hit the Start button, and let it do its thing.

Alex


Amazing!!! Just downloaded about 300 covers with a single click!!!

Thanks for this program, really made my music library even better!
Title: Album Art Downloader XUI
Post by: Jedi82 on 2010-11-08 09:05:11
and what about mac users?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-08 09:21:04
and what about mac users?
Out of luck, I'm afraid. Mono might someday gain WPF libraries, and if it does, they might just run on Mac OS too, in which case it could potentially be possible to run it on a Mac. I wouldn't count on it, though. Certainly there won't be any official support for it on Mac OS from me - I won't ever own a Mac, or develop specifically for one.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2010-11-08 10:24:32
[pointless flame]
and what about mac users?
Out of luck, I'm afraid.

As always. That's what they chose.
[/pointless flame]

Thanks for your great work, I still like your continuous improvements.
Title: Album Art Downloader XUI
Post by: the_miker on 2010-11-08 19:39:38
Hey Alex,

Can you see if something changed on VGMdb's end?  I'm not getting any results from their site no matter what I search for.  I've tried it with and without login credentials in the vgmdb.boo file.  No errors or anything in AAD, the search just comes up empty every time.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-09 09:14:45
Can you see if something changed on VGMdb's end?
Argh, wish I'd spotted that before releasing 0.37. I've put up an updated script that should fix it. You'll have to re-enter your username and password into it after it updates, though.
Title: Album Art Downloader XUI
Post by: the_miker on 2010-11-10 03:54:57
Argh, wish I'd spotted that before releasing 0.37. I've put up an updated script that should fix it. You'll have to re-enter your username and password into it after it updates, though.

That fixed it.  Thanks man!
Title: Album Art Downloader XUI
Post by: sle118 on 2010-11-10 22:06:40
Album Art Downloader XUI v0.37 Released


Alex, I took the latest version which created a problem with the save location.  When launching the program from the context menu, images are no longer saved under the directory where music file was found.

Any hint on how to fix this?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-11 08:07:06
When launching the program from the context menu, images are no longer saved under the directory where music file was found.

Could you tell me what you have in the box "Specify path to find images" in the File Browser window? (click the Options link to show it). There was a small fix in the behaviour of paths with ".." in them when file path pattern matching was enabled, but this shouldn't have caused the issue you describe.

Alex
Title: Album Art Downloader XUI
Post by: sle118 on 2010-11-11 12:47:55
When launching the program from the context menu, images are no longer saved under the directory where music file was found.

Could you tell me what you have in the box "Specify path to find images" in the File Browser window? (click the Options link to show it).


This is odd. 

Here is what was the problem


I tried again this morning, and now in place of the default folder I see "This path was set automatically from the browser..."

So all is back to normal; false alarm.

thank you!

p.s. You should have a donation link somewhere. This would allow me to pay you a beer or something.



Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-11 12:56:57
p.s. You should have a donation link somewhere. This would allow me to pay you a beer or something.

Glad it's back to working again now. There's a Donations link under the Help menu; I don't want to be too pushy about it, but I think I'll put one on the first post of this thread too. Any beer money is gratefully received here: donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: sle118 on 2010-11-11 13:12:14
p.s. You should have a donation link somewhere. This would allow me to pay you a beer or something.

Glad it's back to working again now. There's a Donations link under the Help menu; I don't want to be too pushy about it, but I think I'll put one on the first post of this thread too. Any beer money is gratefully received here: donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)


You could just embed a paypal icon somewhere in the app. It's so useful I think it would encourage people to contribute.  I am a developer myself and have a sense of how many hours were spent on this.

You live in the UK? Life is expensive there (I lived in Beaconsfield for about 8 months) so I tried giving enough for a trip to the pub.

cheers
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-11 13:49:11
Thanks, I appreciate it!

I'd consider having a graphical paypal donation button in the installer, but not in the app itself. I think it looks awful, and dislike seeing it in other apps I use - so it would be hypocritical of me to include it in my own. Even the menu entry can be easily removed if it offends, just hover the mouse over it and press the delete key.

Alex
Title: Album Art Downloader XUI
Post by: SoulsCollective on 2010-11-11 17:51:42
Great app, have been using it since it first came out.

However, something seems to have broken with the latest 0.37 release - Foobar integration no longer works. I've made sure I have the latest version of the COM server files installed and the latest Foobar, and tried uninstalling and reinstalling both Foobar and AAD - 0.37 just gives me a fatal error, followed by the logs, when I click File -> New -> Foobar browser. Can post logs on request. 0.36 works fine.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-11 18:38:15
Foobar integration no longer works.
Oops. I've looked into this, and it appears to be a side effect of upgrading to VS2010 - you're running x64, I assume? If not, then there's some other problem, but I think that's unlikely.

If you try dropping this replacement Interop.Foobar2000.dll (http://www.byalexv.co.uk/temp/Interop.Foobar2000.dll) file into your Album Art Downloader folder it should, hopefully, just start working. Please let me know if it does, and I'll release a 37.1.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: SoulsCollective on 2010-11-12 08:45:43
Oops. I've looked into this, and it appears to be a side effect of upgrading to VS2010 - you're running x64, I assume? If not, then there's some other problem, but I think that's unlikely.
Yes, sorry, should have mentioned environment. Win7 Pro x64.

If you try dropping this replacement Interop.Foobar2000.dll (http://www.byalexv.co.uk/temp/Interop.Foobar2000.dll) file into your Album Art Downloader folder it should, hopefully, just start working. Please let me know if it does, and I'll release a 37.1.

Thanks,

Alex

That fixed it. Working fine now.

Edit:

WHOAH. Just downloaded the new Catalyst drivers that enable Morphological filtering for the 5xxx series of AMD/ATi cards, and they do funky things to AAD when MLAA is enabled:

(http://i165.photobucket.com/albums/u80/collectiveLAN/Misc/blur.jpg)

Everything is just fine when MLAA is disabled, no other apps exhibit this behaviour (that I've seen). Probably not your fault, but I thought you'd want to know.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-12 13:09:40
WHOAH. Just downloaded the new Catalyst drivers that enable Morphological filtering for the 5xxx series of AMD/ATi cards, and they do funky things to AAD when MLAA is enabled
Thanks for letting me know that the Foobar thing is fixed, I've put up 0.37.1 with that fix included now.

I'm not sure I'll be able to do anything about that MLAA thing, if it's happening at the driver level its beyond my control! I'll have a look around the web, and see if anyone else has any ideas, but it looks to me like MLAA is deciding that part of the AAD window really needs to be aliased. Unless there's some flag I can set to say don't alias this window (which seems unlikely as MLAA appears to be a post-process filter), then it's probably going to stay like that until AMD fix their drivers.

Alex
Title: Album Art Downloader XUI
Post by: johnhardyiv on 2010-11-12 16:31:09
Hi all, one of those 'just got your great app today' posts.  Looks really slick, I'm attempting to integrate it with MP3Tag, I've added it as an external tool but I'd like to be able to highlight an album of songs in MP3Tag, hit tools / Album Art Downloader and have it prepopulate the artist/album fields in AAD.  It's currently not getting the artist/album with just adding the .exe w/ no command arguments in the tool function of MP3Tag. 

Went through 10 or so pages of this 58 page thread and didn't see it and searched.  Please reference the post if this has been hashed over already.

I also embedd all my album art into my wma files .. are there plans for allowing highlighting of the album in MP3Tag, kicking off AAD choosing the appropriate art and having an option to embed back in the highlighted albums as 'Front Covers'?

Thanks again for the app!

John IV
www.mameui.info
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-12 17:13:00

Thanks for your comments, I'm glad you like it. To pass the artist and album fields, use the command line parameters:

/artist "%artist%" /album "%album%"

There's plenty more stuff you can do with command line arguments (example (http://www.hydrogenaudio.org/forums/index.php?act=findpost&hl=MP3Tag&pid=720359)), but those are the most basic ones to use. For all the parameters available, see the Command Line Reference, under the Help menu.

AAD doesn't embed artwork within files, it's just for getting art, not for managing tags. You can kick off AAD to download an image file, but you need some other tag management software to manage embedding it within all the files that belong to the album. MP3 tag can do this quite easily, I think - there's an Import Cover from File action that should do the job.
Title: Album Art Downloader XUI
Post by: sle118 on 2010-11-12 17:54:01
AAD doesn't embed artwork within files, it's just for getting art, not for managing tags. You can kick off AAD to download an image file, but you need some other tag management software to manage embedding it within all the files that belong to the album. MP3 tag can do this quite easily, I think - there's an Import Cover from File action that should do the job.


Alex,  The ability to automatically embed the artwork in song files would be a killer feature for AAD. I realize that this a change in philosophy.... perhaps this could be for V1.5 ? 

In the meantime, a temporary solution could be the addition of a custom action launched from AAD? This could be used to call a (yet to find) artwork embedding tool that supports command line...

Any thoughts on this?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-12 18:09:44

If you want to add your name to the embedded artwork feature request, there's a tracker for it here (https://sourceforge.net/tracker/?func=detail&aid=1858610&group_id=187008&atid=919578). I still don't think it's likely to happen, though.

Custom Actions is more likely to happen than that, it's something I've considered before, and might eventually get round to. It does, however, illustrate one of the major problems with having AAD embed artwork, and that is: how would the purported artwork embedding tool know which files to embed the artwork within? The only information available from AAD is the artist and album name searched for, and the path to the image file. The reason that embedding artwork is a tag-managment problem is that to do it properly you need to know which all the files that an album consists of are, and for that you need proper tag management software. It's the same class of problem as ensuring all your files in an album have the same Album, Genre, Date and Number of Discs tags.

AAD handles obtaining artwork. Tag Management software handles modifying the tags (including image tags) of files. Good Tag Management software should be able to use AAD for the artwork-obtaining step. If I were to write a tag management application myself, I'd certainly have it integrate with AAD, but I currently have no plans to write one.

Alex
Title: Album Art Downloader XUI
Post by: sle118 on 2010-11-12 18:46:54

If you want to add your name to the embedded artwork feature request, there's a tracker for it here (https://sourceforge.net/tracker/?func=detail&aid=1858610&group_id=187008&atid=919578). I still don't think it's likely to happen, though.

Custom Actions is more likely to happen than that, it's something I've considered before, and might eventually get round to. It does, however, illustrate one of the major problems with having AAD embed artwork, and that is: how would the purported artwork embedding tool know which files to embed the artwork within? The only information available from AAD is the artist and album name searched for, and the path to the image file. The reason that embedding artwork is a tag-managment problem is that to do it properly you need to know which all the files that an album consists of are, and for that you need proper tag management software. It's the same class of problem as ensuring all your files in an album have the same Album, Genre, Date and Number of Discs tags.

AAD handles obtaining artwork. Tag Management software handles modifying the tags (including image tags) of files. Good Tag Management software should be able to use AAD for the artwork-obtaining step. If I were to write a tag management application myself, I'd certainly have it integrate with AAD, but I currently have no plans to write one.

Alex


Good point,  you have the global view of the problem, whereas I am merely attempting to solve my own problem which is a single case figure.  I typically launch AAD from the context menu and 100% of the time song files are nicely split into their album folder. This is a very simple scenario.

Integrating from an MP3 tag management software would make sense, but it would still be somewhat complicated to track what cover art to use for which file. Maybe this could be solved if only one album is sent at a time and the resulting file(s) would be applied to all selected tracks.  But since AAD would likely send back multiple pictures, with each their own type (cover, back, CD, etc), some kind of manifest would have to be sent back...


Title: Album Art Downloader XUI
Post by: sle118 on 2010-11-12 19:59:36
When launching the program from the context menu, images are no longer saved under the directory where music file was found.

Could you tell me what you have in the box "Specify path to find images" in the File Browser window? (click the Options link to show it). There was a small fix in the behaviour of paths with ".." in them when file path pattern matching was enabled, but this shouldn't have caused the issue you describe.

Alex


Hey, I found out how the problem occurs:

Title: Album Art Downloader XUI
Post by: johnhardyiv on 2010-11-12 20:04:13
Thanks for the command line params for the tool addition in MP3Tag Alex.  Worked a treat.

The art embedding I was suggesting is not as 'full scope' as some of the use cases you're talking about, it would be manual process one album at a time sort of thing.

My use case would be:

1. highlight an album in MP3Tag, choose tool/AAD.
2. Choose the best looking cover from the list.
3. Press a button on the thumbnail to embed.
4. That would embed the image as Front Image into the highlighted songs from step 1.

The end.

It's not so bad now, just copy from AAD results and paste into the art box on MP3Tag and ctrl-s to save all the songs w/ the new image. Laugh.  Thanks again -
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-12 21:35:01
The path is not carried to the new search window where it defaults to the pictures location

That's intentional, as if it's a new window it assumes that you're searching for a new, different, album (which you would presumably not want saved in the folder of the old album).

To change this behaviour, click the Options link in the search window and uncheck "Open search results in new window". That way, when you modify the search terms, the new search will take place in the same window, and so will be saved to the same folder. If you do want to do a new search for a different album, you will have to open a new window manually (Ctrl+N, or File/New/Search Window) to do so.

@johnhardyiv: Thanks for the tip about Copy/Paste, I'll try and remember to mention that next time someone asks about MP3 tag and image embedding :-) As for your suggested workflow, I think there may be severe technical limitations involved between steps 3 and 4. Perhaps it could be done with some sort of plug-in to MP3 tag, but not, I think, with a generic stand-alone application.

Alex
Title: Album Art Downloader XUI
Post by: johnhardyiv on 2010-11-13 01:22:23
@johnhardyiv: Thanks for the tip about Copy/Paste, I'll try and remember to mention that next time someone asks about MP3 tag and image embedding :-) As for your suggested workflow, I think there may be severe technical limitations involved between steps 3 and 4. Perhaps it could be done with some sort of plug-in to MP3 tag, but not, I think, with a generic stand-alone application.

Alex
[/quote]

The other thing I tried to do w/ AAD as a new user w/ a fresh set of eyes was 'drag and drop' the image I wanted from AAD into the art area on MP3Tag.  You can do that with a freestanding jpg or png into MP3Tag .. but I imagine your decision to show the preview on mouse button hold may block that.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-13 07:48:33
The other thing I tried to do w/ AAD as a new user w/ a fresh set of eyes was 'drag and drop' the image I wanted from AAD into the art area on MP3Tag.  You can do that with a freestanding jpg or png into MP3Tag .. but I imagine your decision to show the preview on mouse button hold may block that.

Actually, AAD can do drag and drop. If you drop it onto an explorer window, it will produce an image file there. As it doesn't actually exist as a file until it's dropped, though, I suspect MP3Tag can't support it. I don't know if there's anything I can do from my end to help, but next time I get some time I'll grab a copy of MP3Tag and find out.
Title: Album Art Downloader XUI
Post by: brucegrr on 2010-11-15 20:46:51
I am getting the following error message when trying to use AAD. I am using AAD own a Win 7 32bit computer. Any help would be greatly appreciated.

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: D:\Program Files\AlbumArtDownloader\errorlog.txt
Code: [Select]
App version: 0.37.1.0, running on Microsoft Windows NT 6.1.7600.0 (32 bit)

System.ArgumentException: Width and Height must be non-negative.
  at System.Windows.Rect..ctor(Double x, Double y, Double width, Double height)
  at System.Windows.Window.GetNormalRectDeviceUnits(IntPtr hwndHandle)
  at System.Windows.Window.GetNormalRectLogicalUnits(IntPtr hwndHandle)
  at System.Windows.Window.get_RestoreBounds()
  at AlbumArtDownloader.Properties.WindowSettings.SaveWindowState()
  at AlbumArtDownloader.ArtSearchWindow.SaveSettings()
  at AlbumArtDownloader.Common.SetupNewWindow(IAppWindow newWindow, IAppWindow oldWindow)
  at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
  at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: johnhardyiv on 2010-11-20 00:52:32
Hi Alex, enjoying the use of AAD.  I have a substantial ~120K .wma song collection all with embedded art.  However when I started out I used a lot of *ugh* 150px covers and less than 500px.

With your new file browser is there a way to:
1. For speed optimization, limit it to searching perhaps the first song of an album and assume that embedded art size exists for the rest of the album.
2. Return hits for art under a certain dimension like <400px for example.

That way I could drag and drop a letters' worth of artists at a time (~4000 songs) into your window and sort of quickly see where I need to replace my art? Cheers -
Title: Album Art Downloader XUI
Post by: Habitats on 2010-11-23 22:35:26
Is it possible to prioritize sources? I know if I just uncheck one, it'll of course only use that, but what if I don't find anything there - then I want it to move to another source, in that order. Now it just seems to be using some top-to-bottom priority.

Sorry if this has been asked before, but I didn't find anything.

edit: I know about the "search first", but I want more prioritylevels.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-11-25 18:10:38
Hello all, sorry I haven't replied for so long, but I've been on holiday.

I am getting the following error message when trying to use AAD
Thanks for reporting this. I'm sorry, but that error message usually means something has gone wrong with the .net 3.5 installation. The only thing that can be done from the AAD end is to clear its settings - the easiest way to do this is to uninstall and reinstall it. This will only help by removing any possible corrupted settings, though, if the root cause that made Windows report incorrect information (negative window dimensions) is still there, it still won't work.

I'm interested to hear how AAD is performing with such a large collection. It's larger than I have available to test with, so I don't have any direct experience of it! AAD already stops searching for images for an album once it finds one, so if the song that it extracts the album info from already has embedded artwork, it won't look any further for any. It will still look at the tags of other songs to see if they belong to a different album, but if they belong to the same one, it won't look further for images.

For your second point, can I suggest clicking the column header to sort by the size, after it finishes searching? Then you can just shift-click to multi select a whole bunch of albums whose size is too small.


Is it possible to prioritize sources? ...  I know about the "search first", but I want more prioritylevels.
Sorry, no, there's no more granular control than "search first". It does not use a top to bottom priority - without Search First, all sources are searched simultaneously, and results are collated as they're returned. It will always return results for all selected sources.

Search First adds the ability to make two groups, so that if no results are found in the first, the second is tried - but within each group, all sources are searched simultaneously. There is no way to make further cascading groups, which are only searched if the first two both come up empty. I don't really see the need in complicating it further like that.

Alex
Title: Album Art Downloader XUI
Post by: Habitats on 2010-11-25 22:40:51
Thanks for the reply.

Reason I wanted this was because it's only searching one source at the time -- Looks like it's rather random which source it searches first, within it's group.

If it's supposed to do em all at once, maybe I've configured something wrong, though, I didn't find any options for this?

Anyway, I figured having last.fm covers in search first, and google as a 2. prio, with the rest disabled worked perfectly find, so it's not really a problem anyway
Title: Album Art Downloader XUI
Post by: eTaurus on 2010-12-02 19:12:46
Hi all,
I haven't used AAD for a while. Now, with the most actual version (at this time 0.37.1.0) the Foobar Browser tells me

"Could not connect to Foobar2000 automation server"

The COM automation server is installed, up and running. Since I haven't used AAD for quite a long time I really am not able to tell what I have done that it doesn't work now. I'm running Win XP SP 3 with .NET 3.5 SP 1 installed and Foobar2000 1.1.1.

Do you have any idea?

/EDIT: Forget it, I reinstalled the COM automation server and it works now.
Title: Album Art Downloader XUI
Post by: dbkb on 2010-12-05 19:55:42
I have been using AAD for quite some time without any problems.  Recently it stopped working.  I have tried removing the old installation and reinstalling the latest.  I get the following error message whenever I try to start the program.  I have not been able to figure out what has changed.  Does anyone have any ideas?
Thanks

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt
Code: [Select]
App version: 0.37.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Runtime.InteropServices.COMException (0x88980406): Exception from HRESULT: 0x88980406
  at System.Windows.Media.Composition.DUCE.Channel.SyncFlush()
  at System.Windows.Media.MediaContext.CompleteRender()
  at System.Windows.Interop.HwndTarget.OnResize()
  at System.Windows.Interop.HwndTarget.HandleMessage(Int32 msg, IntPtr wparam, IntPtr lparam)
  at System.Windows.Interop.HwndSource.HwndTargetFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.ShowWindow(HandleRef hWnd, Int32 nCmdShow)
  at System.Windows.Window.ShowHelper(Object booleanBox)
  at System.Windows.Window.Show()
  at System.Windows.Window.ShowDialog()
  at AlbumArtDownloader.Splashscreen.ShowIfRequired()
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: Zarggg on 2010-12-06 09:30:35
That would be a .NET exception. Try uninstalling and reinstalling the framework.
Title: Album Art Downloader XUI
Post by: dbkb on 2010-12-07 12:18:59
That would be a .NET exception. Try uninstalling and reinstalling the framework.


I have removed and reinstalled .net 3.5, but I am still getting the same error message.  Any other ideas?  Thanks
Title: Album Art Downloader XUI
Post by: bilbo on 2010-12-08 18:46:17
That would be a .NET exception. Try uninstalling and reinstalling the framework.


I have removed and reinstalled .net 3.5, but I am still getting the same error message.  Any other ideas?  Thanks

When I encounter .Net problems, I uninstall ALL dot net versions, and then reinstall them all again. This has always worked for me, and it seems that these issues come up frequently, especially after an upgrade.

If this doesn't work, Microsoft has a program on the .Net website that will remove every little pease of the programs. They recommend this as a last resort.
Title: Album Art Downloader XUI
Post by: bumsbomber on 2010-12-10 12:15:22
Hi

When I save covers I want to name them automatically with "front", "back" or "CD" in the name. At moment I use "%artist% - %album% - Cover.%extension%" - is there also a parameter for the type of images, so I don't have to rename them manually?

In the search window the type is displayed under the size of the image, so I think this could be possible.

Edit: Ah, got it by myself.

Quote
%type%: This can be one of: "Front", "Back", "Inside", "CD" or "Unknown", depending on the information provided by the online source. It is used to classify the result as a Front Cover, Back Cover, an image of the CD itself, or of the inside booklet or inlay. You can customise the labels used by this placeholder by including them in parenthesis, separated by commas: %type(Unknown,Front,Back,Inside,CD)%. The order must be exactly as shown, but the text to use for each type can be whatever you want.
Title: Album Art Downloader XUI
Post by: dano on 2010-12-11 00:50:37
The Amazon script is not working with umlauts/accents.
I think all encoding parts must be changed to Latin1/ISO-8859-1

I've made these changes:
http://pastebin.com/kmLDs9qh (http://pastebin.com/kmLDs9qh)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-12-11 08:11:53
The Amazon script is not working with umlauts/accents.
Thanks for that. I've updated the Amazon scripts with your suggested changes. I don't know whether this is something they've recently changed, or if it never worked properly, but in either case it should be working right now.

@dbkb: I'm afraid I don't have much to add to what's already been said. There is a small possibility that the issue you are seeing is graphics driver related - is there any chance it stopped working after you upgraded your drivers?

Alex
Title: Album Art Downloader XUI
Post by: dnx on 2010-12-26 02:00:08
How can i get the same name as the .mp3 file?

A sample:

Ben Klock, Dettmann - Dawning - Original Mix.mp3

Ben Klock, Dettmann - Dawning - Original Mix.jpg


I tried: %title%, %track% etc. Nothing works!

Who can help me?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-12-26 08:04:44
How can i get the same name as the .mp3 file?

Sorry, but there is no way of doing this. In general, an album may consist of multiple mp3 files, and the filenames may not even be known to AAD (all you need to do a search is the album and artist name).

Alex
Title: Album Art Downloader XUI
Post by: dnx on 2010-12-26 13:50:07
Thank you for the fast reply!

But how do you add covers to multiple mp3 files?

I'm trying to do this with mp3tag.


And what about album names with / ' ?  and other signs??
It changes to --> _
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-12-26 14:54:10
But how do you add covers to multiple mp3 files?
If you are talking about embedding artwork within mp3 files, AAD does not do that, it saves one cover file for one album. mp3tag can, though. A quick search threw up this: GeekTonic guide (http://www.geektonic.com/2008/02/automatically-embed-album-art-to-large.html), but I'm sure there are others.

And what about album names with / ' ?  and other signs??
It changes to --> _
Yes, yes it does. All characters that are not allowed in filenames are replaced by _ instead.

Alex
Title: Album Art Downloader XUI
Post by: dnx on 2010-12-26 14:59:22
Thank you!

Will different characters support later?

I will also thank you very much for this program!!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2010-12-26 19:30:41
Will different characters support later?

Thanks for your comments. There's a feature request for that here: #2022984 (https://sourceforge.net/tracker/?func=detail&aid=2022984&group_id=187008&atid=919578), if you want to track it. It hasn't been a priority for me, though. If you explain how you would want to use such a feature, it would help.
Title: Album Art Downloader XUI
Post by: blackspawn on 2011-01-01 19:12:43
Hello, It seems to me that "Include subfolders when searching for audio file" isn't working...

With the following filter: \%artist%\
  • %album%\*[/i][/b] and with the option mentioned checked files in \%artist%\
    • %album%\CD1\something.flac[/b] and \%artist%\
      • %album%\CD2\something.flac[/b] aren't found.

        However if I change the filter to \%artist%\
        • %album%\*\*[/i][/b] it finds them ok. Maybe I'm missing the meaning of the "Include subfolders when searching for audio file" option but shouldn't AAD find the files with the first filter? (using 0.37.1)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-01-01 19:43:09
It seems to me that "Include subfolders when searching for audio file" isn't working...

Perhaps this isn't as clear as it could be, I'll think if there is a better way it could be presented.

"Include subfolders" refers to the path specified in "Search for audio files in". Unless you only want to look for files directly in that folder, leave it checked.

The "Use file path pattern matching" box doesn't affect where files are searched for at all. It just affects how the album and artist name are determined from the path (as opposed to from tags within the music files themselves). Further, * in the pattern matches only within one level of folder or file name, %album%\* does not include album\cd1\something.flac. You can actually force a complete wildcard by using a regex fragment: ".*" (including " marks) so \%artist%\%album%\".*" would match anything at all, but probably not be what you want unless you prefixed it by the name of the parent folder, something like: \music\%artist%\%album%\".*"

If you don't need the name of the audio file to play any part in the matching process, you're probably better off matching just against folder names and not bothering with looking for files, it will be faster. You can do this by ending the pattern with a ., so \music\%artist%\%album%\. (where music is the name of the parent folder)

Easiest of all is to just use the tags from files option, but I suppose you've already tried that?

Alex
Title: Album Art Downloader XUI
Post by: blackspawn on 2011-01-07 15:03:41
Ahh ok know I understand the meaning of the "include subfolders when..."  option, and thanks for the tip :-) the dot operator was exactly what I wanted to match my albums (including ones with more that one CD).

Yes I've tried searching based on tags but it is much much slower that way than when matching based on file/folder structure by way of regex.
Title: Album Art Downloader XUI
Post by: einmus on 2011-01-10 01:24:42
Bravo, excellent work! Save me from a lot of labor!
Title: Album Art Downloader XUI
Post by: dbkb on 2011-01-18 12:15:16
The Amazon script is not working with umlauts/accents.
Thanks for that. I've updated the Amazon scripts with your suggested changes. I don't know whether this is something they've recently changed, or if it never worked properly, but in either case it should be working right now.

@dbkb: I'm afraid I don't have much to add to what's already been said. There is a small possibility that the issue you are seeing is graphics driver related - is there any chance it stopped working after you upgraded your drivers?

Alex


Thanks for the help.  FYI, it did turn out to be a graphics driver related issue.  I eventually found that something called SndTVideo had installed itself as a video device on my computer.  After removing that device, everything worked fine.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-01-18 20:07:09
Thanks for the help.  FYI, it did turn out to be a graphics driver related issue.
Thanks for letting me know, I'm glad you got it to work eventually!
Title: Album Art Downloader XUI
Post by: jobin007007 on 2011-01-23 16:45:53
Hi,

I would like to report a bug with Album Art Downloader.

I use the program to download Album art automatically.If more than one music file is in the folder, then the album art jpeg file Folder.jpg gets overwritten again and again by different album arts. So the jpeg for only one music gets stored. So only the last music file in the folder has its jpeg successfully saved.

Any Help on this?

Thanks for the software!
Title: Album Art Downloader XUI
Post by: g.p.m. on 2011-01-23 17:14:07
After working hours to find my almost perfect solution to pick up album art and include it into my mp3 files I decided to make up a little tutorial how I did it.
Because I'm really noob this maybe can be refined by others with more knowledge than me.

What you need:
Mp3Tag - latest version can be found here (http://www.mp3tag.de/download.html).
Album Art Downloader  - latest version can be found here (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Main_Page).


Install both progs. For Album Art Downloader it may be required also to install the MS .NET Framework 3.5 SP1 (except for Windows 7). During install choose your appropriate scripts for searching album art. Never mind to install all, you can choose later which of them you want to use.

Run AAD, leave all settings as is.
Open "File" -> "New" -> "Search Window..." click on Options.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-01-23 19:40:54
g.p.m.: Thank you for posting that detailed tutorial. I would like to include a copy of it on the Album Art Downloader Wiki (http://album-art.sourceforge.net/), if that's OK by you?

If more than one music file is in the folder, then the album art jpeg file Folder.jpg gets overwritten again and again by different album arts. So the jpeg for only one music gets stored.

Naturally, only one file called Folder.jpg may exist in any one folder. If you need to have multiple art files in the same folder, you will need a more complex naming scheme. You could, for example, choose to include the artist and album name in the art filename. To do this, if you are starting from the File Browser, click the Options link, then in the "Path to find images" box, replace the contents with, for example: %artist%-%album%-Folder.%extension%

That would give you art files named like: "Muse-Absolution-Folder.jpg".
Title: Album Art Downloader XUI
Post by: g.p.m. on 2011-01-23 21:19:42
g.p.m.: Thank you for posting that detailed tutorial. I would like to include a copy of it on the Album Art Downloader Wiki (http://album-art.sourceforge.net/), if that's OK by you?


Absolutely OK.

Glad to this!

Greetz
Title: Album Art Downloader XUI
Post by: ypcyc on 2011-01-25 19:05:04
Hello! Can you please add scipt to support coverlandia.net ? Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-01-29 12:40:28
Hello! Can you please add scipt to support coverlandia.net ? Thanks!

Coverlandia is an interesting one. As most of the results will be fan-made covers, which is probably not what an average AAD user will be expecting, I won't be including this source by default. I will, however, make this script available here for those who do want fan-made covers: coverlandia.boo (http://www.byalexv.co.uk/foobar/coverlandia.boo)

Alex
Title: Album Art Downloader XUI
Post by: mowo on 2011-02-21 20:30:07
When I search my mp3 library, using either AAD's Foobar Browser or AAD's File Browser, folders containing files named "AlbumArt*.jpg" are not recognized as containing artwork.  The result is always "Not Present" in the "Artwork Status" column.  Here's my search string:

Folder%preset%.%extension%|Cover%preset%.%extension%|AbumArt*%preset%.%extension%

I have lots of folders containing files with names like "AlbumArt_{4116F628-D72F-4CBB-8A26-B38C9C4340CF}_Large.jpg" that I've acquired through various means.  Only image files named "Folder.jpg" are successfully recognized by AAD, including in folders that contain "Folder.jpg" as well as "AlbumArt*.jpg".  I've also tested the case of renaming the file to just "AlbumArt.jpg" (stripping off the UID part), as well as changing the search string to just "AlbumArt.jpg"; doing either does not make any difference.

What am I doing wrong?  Everything I've read says that AAD should honor and correctly interpret the "*" wildcard character, as well as honor whatever filename pattern I specify, but it just doesn't seem to do so.  Any ideas on this problem?

Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-02-22 08:08:14
Here's my search string:

Folder%preset%.%extension%|Cover%preset%.%extension%|AbumArt*%preset%.%extension%

[...]
Any ideas on this problem?

If that's a copy and paste of your search string, then I think I see the problem. You've missed out the "l" in "AlbumArt". If that's not it, then I don't know why it isn't working. I've tested that search string here and it picks up the example filename you gave just fine.

Alex
Title: Album Art Downloader XUI
Post by: mowo on 2011-02-22 16:00:39
Here's my search string:

Folder%preset%.%extension%|Cover%preset%.%extension%|AbumArt*%preset%.%extension%

[...]
Any ideas on this problem?

If that's a copy and paste of your search string, then I think I see the problem. You've missed out the "l" in "AlbumArt". If that's not it, then I don't know why it isn't working. I've tested that search string here and it picks up the example filename you gave just fine.

Alex


Alex -- Well I feel completely foolish    -- yes, that is a copy/paste of my string and I can't believe I misspelled "AlbumArt".  I stared at that string for so long, and yet I couldn't see the missing "l"!  Well, I'm at work now, but will certainly try your "fix" this evening.  Thanks for your graciousness!

Title: Album Art Downloader XUI
Post by: mowo on 2011-02-23 02:32:16
Here's my search string:

Folder%preset%.%extension%|Cover%preset%.%extension%|AbumArt*%preset%.%extension%

[...]
Any ideas on this problem?

If that's a copy and paste of your search string, then I think I see the problem. You've missed out the "l" in "AlbumArt". If that's not it, then I don't know why it isn't working. I've tested that search string here and it picks up the example filename you gave just fine.

Alex


Alex -- Well I feel completely foolish    -- yes, that is a copy/paste of my string and I can't believe I misspelled "AlbumArt".  I stared at that string for so long, and yet I couldn't see the missing "l"!  Well, I'm at work now, but will certainly try your "fix" this evening.  Thanks for your graciousness!


Yep, just as you observed, AAD is not clever enough to work around my typos!
Title: Album Art Downloader XUI
Post by: groen on 2011-03-01 15:31:01
Great software and i have been using it for a while now with great results. One way that i think you could increase usability is if you could create an option and then enable a different way of saving images. For example, when i am saving front, back, cd and inside in to a specific folder where the music already is. I have to click save as then find the folder for each type of images. If i use the menu (front, back, cd, inside) it just saves it in to a c:\users directory. So if there was an option where you could click and then it changes the save preference so that each search it remembers the directory location of the first save after the search. That way i could make use of the front back inside right click context menu options.
Title: Album Art Downloader XUI
Post by: Der Internet on 2011-03-01 15:51:20
im not absolutely sure how to do that, but one small hint will be :

a doubleclick on the cover will save it the way you defined it in yor options.

my configuration:

Filebrowser: Use ID3 tags from file

path to image:  %type(Cover,Cover,Back,Inside,CD)%.jpg

the double Cover is for saving "unknown" artwork as default cover.jpg

Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-03-01 18:13:18
So if there was an option where you could click and then it changes the save preference so that each search it remembers the directory location of the first save after the search.
How about this: instead of clicking Save As for the first image, set the path to save images before saving any images. Click the Options link (if it isn't already open), then in the "Save images to" box, click the > arrow to the right of it and choose "Browse". After setting it, you can just use single clicks to save as many images as you want to there.

Of course, it's even easier if you can avoid having to specify the path at all. If your music is in a well-organised structure you might be able to use the Artist and Album placeholders in the path to save images to, so it automatically puts them in the right place. Or, if you're launching the search from some other application, you might be able to pass the folder as a command line parameter.
Title: Album Art Downloader XUI
Post by: groen on 2011-03-06 17:42:44
So if there was an option where you could click and then it changes the save preference so that each search it remembers the directory location of the first save after the search.
How about this: instead of clicking Save As for the first image, set the path to save images before saving any images. Click the Options link (if it isn't already open), then in the "Save images to" box, click the > arrow to the right of it and choose "Browse". After setting it, you can just use single clicks to save as many images as you want to there.

Of course, it's even easier if you can avoid having to specify the path at all. If your music is in a well-organised structure you might be able to use the Artist and Album placeholders in the path to save images to, so it automatically puts them in the right place. Or, if you're launching the search from some other application, you might be able to pass the folder as a command line parameter.



Sorry, I had not seen the options drop down. That is exactly what i wanted.
Title: Album Art Downloader XUI
Post by: Eli on 2011-03-07 13:05:42
GREAT PROGRAM!

How about an option to display any current album art, so that you know what image you already have and its size and quality, so that when searching you know if you want to replace any existing album art.

Also, when you change the search term the search goes to the back of the queue and looses its association with the correct folder. How about an instant re-search and keeping the association with the correct folder?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-03-07 13:17:21
How about an option to display any current album art

That would be the Local Files Source (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=The_Local_Files_Source). Or you can use the File Browser to search for albums and it will tell you which ones already have art and which do not.

Quote
How about an instant re-search and keeping the association with the correct folder?

Try clicking the Options link, and un-checking the "Open search results in new window". By default, it assumes that if you've changed the search terms, it's a new search. (details (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Extending_a_Search,_and_Performing_a_New_Search))

Thanks for your comments!

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2011-03-07 14:51:52
Alex, thanks for the fast feedback. Really an amazing tool. Just wish Album Art Exchange would allow the tool to use it... o well...
Title: Album Art Downloader XUI
Post by: Okapi on 2011-03-07 17:57:25
Fantastic program
2 things, is this possible to:
- if Artists = "VA" or "Various Artists", don't put that in the textBox, just leave it blank
- if Album ends with "(Disc 1)", "Disc 2", ... remove this from the Album title
all that before the search ?
Title: Album Art Downloader XUI
Post by: Eli on 2011-03-07 18:41:04
Fantastic program
2 things, is this possible to:
- if Artists = "VA" or "Various Artists", don't put that in the textBox, just leave it blank
- if Album ends with "(Disc 1)", "Disc 2", ... remove this from the Album title
all that before the search ?


These would be great! Exactly why I usually have to re-search.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-03-07 20:06:29
Fantastic program
2 things, is this possible to:
- if Artists = "VA" or "Various Artists", don't put that in the textBox, just leave it blank
- if Album ends with "(Disc 1)", "Disc 2", ... remove this from the Album title
all that before the search ?


Thanks for the comments. I'm afraid neither of those are possible right now. It could potentially be possible to get your album titles correct, depending on where they are coming from - if they are coming from the file browser it might be possible to use a path pattern matching that ended with "%album% (Disc *)\." so that the Disc part wouldn't be part of it, but that's about all I can suggest.

I don't want to leave out "Various Artists" by default, as it might be important for some sources, and it's easier to manually delete it than it would be to type it in. It's could be added as an optional feature, if I can think of a good way of presenting it.

For adjusting the album titles, I think looking for "Disc" is too specific. If I did add functionality to be able to do this, I'd want it to be configurable so you could choose how to process your album titles before searching for them - and that would end up being quite complicated. Fundamentally, "Disc 2" shouldn't be part of the album title at all, so I'm tempted to just consider the best solution to this as being to advise you to fix the album tags using software designed for that job, as unfriendly as that sounds...

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2011-03-07 21:03:26
Fundamentally, "Disc 2" shouldn't be part of the album title at all, so I'm tempted to just consider the best solution to this as being to advise you to fix the album tags using software designed for that job, as unfriendly as that sounds...


Agree, in my case these are old albums from back in my EAC days. Will indeed need to change these. Thank goodness for the tagging powers of dBpoweramp and this is no longer a problem with current rips.
Title: Album Art Downloader XUI
Post by: godrick on 2011-03-15 15:25:11
Sorry if this has been mentioned before and I missed it my search, but I consistently find that the "file browser" fails to find embedded art in the files of albums which have different artists for each of the tracks in the same album.  After I hit "search", I briefly see that AAD does detect the embedded album art, but then it quickly rolls up the album result to a single line, reports "various artists" as the artist, and shows that no album art was detected.

I have confimed in all such cases that all songs in the album had album art, and in all cases if I temporarily changed the album artist tags in the files to be the same for all files in the album, then AAD reported that it found album art.  I see this behavior on all of my compilation discs, which typically have different artists for each track.  I realize that if I deelte the actual artist information in the tag with just "various artists", this problem goes away, but I would like to keep the actual artist information intact.

All in all not a big deal, and I love your application!
Title: Album Art Downloader XUI
Post by: Eli on 2011-03-15 21:16:48
How about an option to display any current album art

That would be the Local Files Source (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=The_Local_Files_Source). Or you can use the File Browser to search for albums and it will tell you which ones already have art and which do not.

Alex


would be nice to have an option to always display the local results at the top. I like to group by size, but the local result, if there is one gets lost

thanks again!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-03-16 08:02:00
it quickly rolls up the album result to a single line, reports "various artists" as the artist, and shows that no album art was detected.

Thanks for reporting this bug, I'll have it fixed in the next version.

would be nice to have an option to always display the local results at the top

I know it's not exactly what you're asking for, but you could try setting the Local Files source as Search First (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Search_First). In that case, when you do a search the first set of results will be just those from the Local Files source. You can look at those and decide whether they are good enough or not, and only if they aren't hit the search button again to search your other selected sources. If there are no local files results, it will just search the other sources straight away.

Alex
Title: Album Art Downloader XUI
Post by: godrick on 2011-03-16 20:08:36
Thanks for the quick response.

Sorry for a noob question especially if I missed it in my forum search, but in using file browser to automatically download album art for multiple albums, I can't seem to control where the files are saved and how they are named.  The result is that all files are named the same and downloaded to the same spot (the same directory as my search location), and all results are overwritten and I only have the art for the last item in the selection.

The options other than save location that I defined in the AAD options area seem to come over to the file browser search window.

What am I missing?  Thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-03-16 21:16:43
...using file browser to automatically download album art for multiple albums, I can't seem to control where the files are saved and how they are named.

When using the file browser, art will be saved using the same pattern as is used to find existing art. For example, the default is to find Folder.jpg in the album folder, so when saving the art will be saved as Folder.jpg in the album folder.

To change this, click the Options link in the file browser window, and modify the "Specify path to find images" box (details (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=The_File_Browser#Finding_existing_images))

Alex
Title: Album Art Downloader XUI
Post by: godrick on 2011-03-17 01:55:58
Thanks for the explanation - I was afraid you were going to say that.  I have all of my songs in a single folder, and the automatic download feature does not seem to allow anything other than a file name of "folder.(extension)" saved in the same folder as the source files.

If I'm right, then in a future release it would be great if you could allow control of the file name and location so that it could be different than the source file location and "folder.(extension)".  You already have this ability in the normal search options, so hopefully adding this the the automatic download feature of File Browser is not a big deal.

thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-03-17 08:13:07

Sorry, I think you must have misunderstood me. This is absolutely possible already. What you need to do is go to the File Browser, click the Options link, and in the box labelled "Specify path to find images" clear out the text that's in there and put, for example %artist% - %album%.%extension% so that each album's artwork gets saved with a different filename. You can also put a path to a different folder in here, or whatever you want. If you really can't figure out what should go in the box, then give me a couple of examples of how you want the art saved and I can tell you.

Alex
Title: Album Art Downloader XUI
Post by: godrick on 2011-03-18 01:04:28
Changing anything in "specify path to find images" in File Browser seems to not have any impact on my problem of how to tell AAD where to save images it downloads.  I tried lots of combinations but there was not any change in AAD still just downloading all files to the same directory with the same name of "folder.jpg".

I'm using verion 0.37.1.0
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-03-18 08:33:32
I'm not sure how to make it any more clear. When the file browser launches the automatic file downloader to download art for the albums you have selected there, it will pass it the first alternate (everything up to the first | character, or everything if there is no | character) in the "Specify path to find images" box to the automatic downloader to use as the default save location. It will also do this to the normal search window, so you can check it's correct before trying the automatic downlading by launching a search for a single album, and checking that it's being saved to the right place.
Title: Album Art Downloader XUI
Post by: godrick on 2011-03-18 17:50:09
You've been clear - thanks for your patience.  Thanks for the  tip on running a normal search to check things.

Here's what never worked:  nothing I entered in "specify path to image files" was passed to the automatic downloader.

Here's what worked: whatever I had entered manually into the save location in the normal search window was used for automatic downloading, regardless of what was in the "specify path to find images" box for automatic downloading.

So I did get things to work.  thanks again
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-03-31 21:57:53
hello, sorry if it was mentioned anywhere already, but the AAD isn't receiving any results from Cover-Paradise anymore. also GoogleSearch is returning zero today, not sure if it's temporary.

thanks for attention in advance

wanted to say, you're doing a great job with this piece of software, really makes life easier for me. keep up the great work!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-01 10:09:54
AAD isn't receiving any results from Cover-Paradise anymore. also GoogleSearch is returning zero today, not sure if it's temporary.

Thanks for reporting these; I've put updated scripts for these two up now so they should show up in the online updates now.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-04-01 10:37:16
wow, thanks for such amazingly quick response!

since we're on the topic... I was wondering for a while now, why AllCdCover starts showing small covers after a few searches, and then it takes at least an hour for it to get back track. is that unsolvable?

thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-02 08:18:06
I was wondering for a while now, why AllCdCover starts showing small covers after a few searches, and then it takes at least an hour for it to get back track. is that unsolvable?

In a word, yes - it's their fault. See earlier discussions (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=681963)

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-04-02 08:31:22
thanks for the reply, sorry I couldn't possibly read all 63 pages of the discussion
ah well, I'm used to that stupid site and their protectiveness.

thanks again for all the hard work.

P.S. kinda waiting for sites like 45cat.com and chartstats.com to have their own scripts, sometimes they have the best covers around, but they only randomly pop up on google search from time to time. not a request, by any means, I'm not that greedy
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-02 08:49:01
kinda waiting for sites like 45cat.com and chartstats.com to have their own scripts

If nobody requests them, they're unlikely to get scripts! :-)

I'm not sure about 45cat, do people use AAD to get covers for Vinyl? Maybe they do, but it seems a bit odd. Chartstats looks worthwhile, though, I'll knock up a script for that one. Shame it doesn't have thumbnails, though.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-02 09:48:53
OK, chartstats.boo (http://album-art.sourceforge.net/scripts/chartstats.boo) is up. As it turns out, they can do thumbnails, it just isn't advertised. Of course, that might mean it gets turned off without notice, but that's the way it goes. Their search algorithm seems pretty loose, so I'd recommend setting the max results for this one quite low, otherwise you'll get a load of less relevant results too.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-04-02 09:55:03
wow, you're fast! amazing! thanks a lot  if I knew you're so eager to communicate, I'd write here months ago.

regarding 45cat.com, well, I, for one, don't just get covers for my mp3 collection. for example, I'm currently building a collection of covers for UK chart singles (hence the accent on chartstats as well). but, of course, given that there'll be little interest in it, I understand why you are reluctant to work with it.

thanks!
Title: Album Art Downloader XUI
Post by: leland on 2011-04-03 17:57:18
I have a fairly large library (few hundred GB) and am getting this error while using the foobar browser: "Error occurred while reading media library: Insufficient memory to continue execution of the program."

Additionally I'm only coming up with art named "folder", so it might be dying before it can do additional passes to check for alternate names (if that's the way it's coded). I have a lot named cover so I know it should be picking those up.

Any helpful hints so I can continue to use this for large batches?

Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-03 19:26:49
Any helpful hints so I can continue to use this for large batches?
OK, a few hundred GB is a little beyond the scope of my test data set! :-)

Firstly, the behaviour with the art finding isn't at issue. It only finds one art file for each album, once it's found one, it stops looking for that album. It does one album at a time, rather than first looking for all named Folder, then for all named Cover, so if you have albums which just have Cover and no Folder, it simply hadn't reached one before it died.

I'm actually quite surprised it ran out of memory when listing albums. Other than the UI, it should be storing very little information in memory at this point; just the album and artist name, and the folder path for each album. It's possible there's a leak, although I haven't been able to find one yet. With WPF, it's usually image handling that's at fault - in this case, it would be loading up the images to determine their dimensions. As an experiment, could you try clearing the "Specify path to find images" box, or setting it to something you know won't match? If you don't get the out of memory error then at least I'll know where the problem is, and might even be able to find a workaround to force WPF to release whatever it's hanging on to.

As far as helpful hints go, would you consider splitting it into smaller batches? If you use foobar to create playlists containing subsets of your albums (say A-M, N-Z for example) then use those rather than "Entire Library" in the foobar browser, it would help. I don't know what the limitations are, so I can't really give you any concrete information on how many subsets you'd need to split it into, though. I'd at least try the simple split into two halves, you might get lucky.

Alex
Title: Album Art Downloader XUI
Post by: skullmonkey on 2011-04-05 01:14:37
Can this process be little bit automated? I don't want to click download on every single album.

Thanks,
S@
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-05 08:39:43
Can this process be little bit automated?

Yes. Automatic Image Downloading (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Automatic_Image_Downloading)

Alex
Title: Album Art Downloader XUI
Post by: skullmonkey on 2011-04-05 09:27:26
*DELETE POST*
Title: Album Art Downloader XUI
Post by: skullmonkey on 2011-04-10 10:07:34
Search from FOLDER and not filename?
Lets say my folder is AAA - BBB. Any way to search the WEB searching fo AAA as Artist and BBB as Album?
I need this since there are various artist with different Artist names also some mp3s have empty tags.

Thanks,
S@
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-10 11:37:38
Search from FOLDER and not filename?

Yes, that's possible: File Browser (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=The_File_Browser#Searching_for_Albums). If your folder is "AAA - BBB" where AAA is the artist and BBB is the album, then the pattern you want is: "\%artist% - %album%\."

Alex
Title: Album Art Downloader XUI
Post by: godrick on 2011-04-13 15:35:31
Alex, regarding my efforts to automatically save images per posts 1564 though 1570, I finally also got your recommended method to work.  I found out I had to close the program after making the location change in "specifiy path to save images" in the search window to ensure that this new location was saved to the user.config file.  Even after reinstalling the application, I noticed that changes to the location I entered were not written to user.config until I closed the application.

If you can also see this behavior, I suggest either adding a "apply configuration" button to prevent the need to close and reopen for changes like this to stick.  I know other config changes have immediate effect without closing and reopening, but this save location does not seem to currently work that way.  thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-13 19:39:37

Thank you for your comments. Application settings are only persisted to the user.config file on exit, but unless the application crashes out, this won't ever be noticed. Settings are changed (in memory) when a window closes, or is opened. So, if you have a window open, make some changes, and open a new window, that new window will have the settings as set on the existing one. If you have two windows open, make changes in window A, then switch to window B (and possibly make other changes there), then opening a new window C from window B will mean that window B's settings are kept, and applied to C. A will remain unchanged.

The three simple rules are: 1) No existing window will have its settings changed by any other window. 2) Any new window will have the same settings as the one that launched it. 3) Closing a window also saves any changes made to its settings.

So, there is no need for an Apply Settings button. The settings of the current window are always applied to any windows opened from it.

Alex
Title: Album Art Downloader XUI
Post by: DRata on 2011-04-22 19:22:50
The Buy.com script stopped working recently. I fixed it by making minor changes to the regex in the script, and by adding a clause to omit "All Categories" results, which were causing duplicates to appear. I also had to edit the clause that eliminated "Similar Products in general" results. Here's the diff from version 0.5:

Code: [Select]
27a28,32
>              //Remove "Results ... in All Categories"
>              allCategories = searchResultsHtml.IndexOf("> in all categories <")
>              if(allCategories > -1):
>                      searchResultsHtml = searchResultsHtml.Substring(0, allCategories)
>
29c34
<              similar = searchResultsHtml.IndexOf(">Similar Products in general<")
---
>              similar = searchResultsHtml.IndexOf(">Similar Products in <span class=\"searchHeaderTerm\">general<")
34c39
<              itemsRegex = Regex("<tr><td valign=\"top\" class=\"(list|listTop)\"><a href=\"(?<productPageUrl>[^\"]*/(?<sku>[^\"]*)\\.html)\"[^>]*><img[^>]*title=\"(?<title>[^\"]*)\"[^>]*src=\"(?<thumbnailUrl>[^\"]*)\"[^>]")
---
>              itemsRegex = Regex("<tr><td valign=\"top\" class=\"searchList\"[^>]*><a href=\"(?<productPageUrl>[^\"]*/(?<sku>[^\"]*)\\.html)\"[^>]*><img[^>]*src=\"(?<thumbnailUrl>[^\"]*)\"[^>]*title=\"(?<title>[^\"]*)\"[^>]")

I suppose the version number should get bumped up to 0.6 or something, but I'll leave that up to the author.

(Note: edited to add fix for omitting "Similar Products in general" results.)
Title: Album Art Downloader XUI
Post by: DRata on 2011-04-23 15:49:13
The arkivmusik script also needed a minor tweak. Not that arkivmusik has great images to offer, but anyway...

Code: [Select]
18c18
<              searchResultsHtml as string = GetPage("http://www.arkivmusic.com/classical/NameList?searching=1&role_wanted=0&search_term="+EncodeUrl(artist + " " + album))
---
>              searchResultsHtml as string = GetPage("http://www.arkivmusic.com/classical/NameList?searching=1&searchingPage=ABC123&role_wanted=0&search_term=" + EncodeUrl(artist + " " + album))
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-23 17:14:11
Thanks for those script updates, that's great work! I've published the changes through the online updates system.

Arkivmusic does produce very small covers, it's true, but it's the only source I've got for classical music at the moment.

Alex
Title: Album Art Downloader XUI
Post by: Qest on 2011-04-24 22:34:47
Just wanted to say that I've found this program useful for finding one-off album covers.

The file browser would be very useful to me if %album artist% was used instead of %artist%. I understand from reading this thread that album artist is far from standard, but having it available as a non-default option would be nice for us foobar users.

Thanks for all the effort,
Qest
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-25 08:01:42
The file browser would be very useful to me if %album artist% was used instead of %artist%. I understand from reading this thread that album artist is far from standard, but having it available as a non-default option would be nice for us foobar users.

Thanks for the comments. If you are a foobar user, you can use the foobar browser, which does use the %album artist% field. Foobar already has an entire browser as a special case, I don't think it needs an additional special case option in the file browser too.

Alex
Title: Album Art Downloader XUI
Post by: foohat on 2011-04-26 21:17:42
Love this program! Great work!

I'm having one problem.  I'd like to be able to download artist art for my whole collection, using only last.fm artist server.  Ideally, I'd like to be able to save the file as %name%.%extension% in the respective artists main folder in my music library.  However, every time I run Album Art Downloader using foobar browser or file browser, it always wants to name it "folder.%extension%".  I can see where to change this in the main window of the program, but as soon as i switch to file browser or foobar browser these options disappear. once in foobar or file browser I could change the filenames manually, but that would take far too long.

anyone know how to fix this?

best,
Title: Album Art Downloader XUI
Post by: foohat on 2011-04-26 23:17:20
Love this program! Great work!

I'm having one problem.  I'd like to be able to download artist art for my whole collection, using only last.fm artist server.  Ideally, I'd like to be able to save the file as %name%.%extension% in the respective artists main folder in my music library.  However, every time I run Album Art Downloader using foobar browser or file browser, it always wants to name it "folder.%extension%".  I can see where to change this in the main window of the program, but as soon as i switch to file browser or foobar browser these options disappear. once in foobar or file browser I could change the filenames manually, but that would take far too long.

anyone know how to fix this?

best,



nevermind, think i got it!
Title: Album Art Downloader XUI
Post by: homebunny on 2011-04-28 06:37:07
Thanks for this wonderfull program!

How can i embed the downloaded the art in my MP3?
Is this something that 'Album Art Downloader XUI' could do?

Thanks
Title: Album Art Downloader XUI
Post by: Cokemonkey11 on 2011-04-28 06:57:55
Sorry I've not read through all 64 pages. Is there a version that works in Linux? Do you have plans to make one?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-04-28 08:15:16
Is there a version that works in Linux? Do you have plans to make one?

Not officially, although I believe the command line version (aad.exe) can be run using mono. The main application UI is written in WPF, and at the moment mono have no plans to implement support for WPF on Linux. I certainly have no plans to re-write the Album Art Downloader using a different UI library, so I'd say the chances of a Linux version appearing are quite slim.

Alex
Title: Album Art Downloader XUI
Post by: DRata on 2011-05-04 18:38:29
Thanks for this wonderfull program!

How can i embed the downloaded the art in my MP3?
Is this something that 'Album Art Downloader XUI' could do?

Thanks


AFAIK, Album Art Downloader can't embed images in MP3s yet, but there are several other programs that can do this. One of the better ones out there for Windows is MP3Tag (http://www.mp3tag.de/), which makes it fairly simple: you select the MP3 file, go to View > Extended Tags... (Alt+T), click "Add Cover..." and select the file(s) containing the artwork.

If you have a whole album of MP3s in a single folder, you can copy the artwork to the folder, and some players will recognize the artwork and display it while the songs in that folder are playing.
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-05-05 00:52:25
hey. sorry if this has been discussed before, but where does the AAD store the big preview images? I can't seem to find them anywhere and I believe they're starting to clog space.
thanks in advance.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-05 07:54:24
where does the AAD store the big preview images?
AAD only saves images if you tell it to, either by saving a specific result, or by using the automatic downloader to find and automatically save art for many albums.

The preview images which are displayed as search results are not saved to disk at all, and will not be clogging up space. They might clog up memory if you have enough of them, and not a lot of memory, but they are all discarded when you close the search window.

Alex
Title: Album Art Downloader XUI
Post by: Zarggg on 2011-05-06 14:40:36
Just to clarify Alex's post, they preview images are stored directly in RAM space.
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-05-06 15:31:28
I see! thanks a lot for your replies.
Title: Album Art Downloader XUI
Post by: AlphaWave on 2011-05-10 10:51:20
I'm using AAD to download art for singles.  I have quite a lot of files in the following format (or similar to it):

Artist Feat. Other Artist - Track (XYZ Mix)

On a lot of occassions, a much better match is found by AAD if I manually change the search in file browser to:

Artist - Track

But, this then means that, when I double-click the art, it downloads with a name which doesn't match the filename.  This means I then have to manually change the name of the art (becuase I want it to reflect the music file, except for the file extension).

Solution/Feature Request:  have a button in the file browser (called something like "Preserve naming & search again") which, when clicked, means that when the file search is manually amended in the file browser boxes, and art downloaded, the art is downloaded with the name that would have applied before the "Preserve naming & search again" button was pressed.

What do you think?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-10 11:52:33
Hello, thanks for your suggestion. I'm afraid I'm not quite clear on the process you are describing, though.

I think where you refer to the "file browser", you actually mean the search window? The file browser lists all your albums and indicates whether they already have art or not, the search window finds art for a single album.

If you mean the search window, can you tell me where the artist and album information comes from - are you launching it using the command line from Foobar or some other application? Or from the AAD file browser? If you give me some more details I might be able to come up with a solution.

Alex
Title: Album Art Downloader XUI
Post by: AlphaWave on 2011-05-10 12:50:16
Hi Alex,  yes you're correct, I should have referred to the search window.

The artist and album information comes from the AAD file browser.

Thanks for taking the time to consider this.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-10 13:06:53
OK, thanks for the clarification. The best I can suggest at the moment is that after the first search, you click on the filename of any of the results, and hit Ctrl+C to copy it. When you get results for the amended search, you can then click on the filename of the result you want to save, then hit Ctrl+V to paste the old name before clicking the save button. I appreciate it isn't ideal, but I think the functionality you suggest is likely to confuse more people than it helps, so I'd be reluctant to add it to the UI.

Alex
Title: Album Art Downloader XUI
Post by: AlphaWave on 2011-05-10 20:37:01
Alex,  I tried what you suggested but it doesn't work.  AAD seems to remember the last search term and ignores the pasted (Ctrl+V) info.

I'd imagine AAD is used by relatively sophisticated users (the types who come onto HA) so I imagine they could cope quite well with such a feature.  Perhaps even "hide" it in an "advanced" panel which has to be activated by pressing F1 or something ...
Title: Album Art Downloader XUI
Post by: homebunny on 2011-05-11 18:06:27
Thanks for this wonderfull program!

How can i embed the downloaded the art in my MP3?
Is this something that 'Album Art Downloader XUI' could do?

Thanks


AFAIK, Album Art Downloader can't embed images in MP3s yet, but there are several other programs that can do this. One of the better ones out there for Windows is MP3Tag (http://www.mp3tag.de/), which makes it fairly simple: you select the MP3 file, go to View > Extended Tags... (Alt+T), click "Add Cover..." and select the file(s) containing the artwork.

If you have a whole album of MP3s in a single folder, you can copy the artwork to the folder, and some players will recognize the artwork and display it while the songs in that folder are playing.


I got a large collection with good songs, all put togheter in one folder (all diferent artists and albums), but that makes it almost impossible to get the art attached to the songs
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-05-12 09:01:32
On a lot of occassions, a much better match is found by AAD if I manually change the search in file browser to:

Artist - Track

But, this then means that, when I double-click the art, it downloads with a name which doesn't match the filename. This means I then have to manually change the name of the art (becuase I want it to reflect the music file, except for the file extension).
I don't use AAD file browser but when I launch AAD from foobar and then change the parameters to make a different search, the results are always saved following the original pattern. You might want to try this route, if I understand your problem correctly.

HTH.

Alessandro
Title: Album Art Downloader XUI
Post by: dubwai on 2011-05-12 15:01:00
Exist any solutions to make fonts of this beautiful program sharp? Like in WinXP without ClearType or .NET Framework 3.5 doesn't allow this?

P.S. I love smooth fonts but if DPI > 300 :-)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-12 18:46:03
I got a large collection with good songs, all put togheter in one folder (all diferent artists and albums), but that makes it almost impossible to get the art attached to the songs
Album Art Downloader was really designed for searching for art for an album, rather than for individual songs, which is why using it this way is difficult. What I would suggest, in your case, would be to have the art saved with a known scheme (something like "%album%.%extension%", for example). MP3Tag could then be used for embedding the art in tags, if that's what you want to do with it. g.p.m. did a guide on how to do this (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&st=1525&p=740568&#entry740568).


when I launch AAD from foobar and then change the parameters to make a different search, the results are always saved following the original pattern
This is because you are passing the location to save the results to as a parameter from foobar. So foobar constructs the parameter from the artist and album name, and passes that to AAD (rather than passing placeholders and getting AAD to put in the artist and album name). That won't work from the File Browser, as that will always use placeholders.

I still think the copy and paste solution is the best way to go here - AlphaWave, if you want me to try and give more details on the steps you did so I can work out what you're doing differently to me, send me a PM and we'll take this out of the thread.

Exist any solutions to make fonts of this beautiful program sharp? Like in WinXP without ClearType or .NET Framework 3.5 doesn't allow this?

Sorry, anti-aliasing is built in to WPF, and can not be turned off. It does look better if you have ClearType turned on for Windows, but I agree it would have been nice to have the option to turn it off.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-14 10:23:03
Version 0.38
I've recently been working on trying to remove Album Art Downloader's dependency on GDI+. This will primarily be of interest to anyone getting the irritating "A generic error has occurred in GDI+ (http://sourceforge.net/tracker/?func=detail&aid=3066705&group_id=187008&atid=919575)" message, but using only the WPF image handling (rather than the previous mix of the two) is a generally neater system overall.

It is a fairly serious internal change, so I haven't pushed this out through online updates yet, but I'd appreciate it if anyone feeling adventurous would give it a try. Particularly if you've been receiving GDI+ error messages, but even if you haven't, any feedback on new errors would be very useful. Also, if you notice any changes to performance or memory usage, that would be good to know.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2011-05-14 14:04:24
Version 0.38


After unpacking and launching the initialization process went through. Than the window is shown and results are beeing shown. After all that this happen:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\___mp3\foobar2000\albumart\errorlog.txt

App version: 0.38.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Reflection.TargetInvocationException: The aim of causing an exception. ---> System.NotSupportedException: No suitable display components to complete this operation. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception to the HRESULT: 0x88982F50
   Stack trace --- End of inner exception ---
   in MS.Internal.HRESULT.Check (Int32 hr)
   in System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream (Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid & clsid, Boolean & isOriginalWritable, Stream & uriStream, UnmanagedMemoryStream & unmanagedMemoryStream, SafeFileHandle & safeFilehandle)
   in System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream (baseUri Uri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
   in System.Windows.Media.Imaging.BitmapDecoder.Create (Stream bitmapStream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption)
   in AlbumArtDownloader.AlbumArt.get_ImageDecoder ()
   in AlbumArtDownloader.AlbumArt.get_Image ()
   in AlbumArtDownloader.AlbumArt. <> c__DisplayClass6. <RetrieveFullSizeImageWorker> b__5 ()
   Stack trace --- End of inner exception ---
   in System.RuntimeMethodHandle._InvokeMethodFast (Object target, Object [] arguments, SignatureStruct & sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   in System.Reflection.RuntimeMethodInfo.Invoke (Object obj, BindingFlags invokeAttr, Binder binder, Object [] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   in System.Delegate.DynamicInvokeImpl (Object [] args)
   in System.Windows.Threading.ExceptionWrapper.InternalRealCall (Delegate callback, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.ExceptionWrapper.TryCatchWhen (Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   in System.Windows.Threading.DispatcherOperation.InvokeImpl ()
   in System.Threading.ExecutionContext.runTryCode (Object userdata)
   in System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup (TryCode code, CleanupCode backoutCode, Object userdata)
   in System.Threading.ExecutionContext.Run (ExecutionContext executionContext, ContextCallback callback, Object state)
   in System.Windows.Threading.DispatcherOperation.Invoke ()
   in System.Windows.Threading.Dispatcher.ProcessQueue ()
   in System.Windows.Threading.Dispatcher.WndProcHook (IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean & handled)
   in MS.Win32.HwndWrapper.WndProc (IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean & handled)
   in MS.Win32.HwndSubclass.DispatcherCallbackOperation (Object o)
   in System.Windows.Threading.ExceptionWrapper.InternalRealCall (Delegate callback, Object args, Boolean isSingleParameter)
   in System.Windows.Threading.ExceptionWrapper.TryCatchWhen (Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   in System.Windows.Threading.Dispatcher.InvokeImpl (DispatcherPriority priorities timespan timeout, Delegate method, Object args, Boolean isSingleParameter)
   in MS.Win32.HwndSubclass.SubclassWndProc (IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   in MS.Win32.UnsafeNativeMethods.DispatchMessage (MSG & msg)
   in System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage (MSG & msg)
   in System.Windows.Threading.Dispatcher.PushFrameImpl (DispatcherFrame frame)
   in System.Windows.Application.RunInternal (Window window)
   in AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run ()
   in AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost (IPriorInstance instance, String channelUri)
   in AlbumArtDownloader.App.Main (String [] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-14 14:17:56
Thanks for the report. It appears that it is trying and failing to display a particular image file - can you tell me what you searched for on which source? Obviously it shouldn't crash even if it can't display the image, I'll fix that, but I'd like to take a look at the image in question too. If it turns out that WPF image handling can't decode images that GDI+ can, it might be worth reverting and keeping the old GDI+ system anyway.

Alex
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2011-05-14 19:13:12
Thanks for the report. It appears that it is trying and failing to display a particular image file - can you tell me what you searched for on which source? Obviously it shouldn't crash even if it can't display the image, I'll fix that, but I'd like to take a look at the image in question too. If it turns out that WPF image handling can't decode images that GDI+ can, it might be worth reverting and keeping the old GDI+ system anyway.

Alex


Looks to me like it fails almost on anything. right now i've tried this:
artist: "ani difranco"
album: "canon"
sources: "all" (im using all sources included in zip file youve provided nothing more or less)

to me it looks like it could be a problem of some source only, because results starts to fill the window and than it crash

if i found more time ill try to pinpoint if its trouble of specific source

ps: my system if w7 sp1 64bit... not sure if 64bit could be the culprit
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-14 19:32:01
to me it looks like it could be a problem of some source only, because results starts to fill the window and than it crash

if i found more time ill try to pinpoint if its trouble of specific source

ps: my system if w7 sp1 64bit... not sure if 64bit could be the culprit

Thanks for that. Yes, it will be a problem with a specific image returned from a specific source. Shouldn't be anything to do with 64 bit, the error is basically just WPF saying it doesn't know how to open images of that format. What I need to do is figure out what the format it can't open is (which I'll do by pinpointing which image is triggering it), and whether that's a format that I don't want to live without.

Doing that search, the results I get are 7digital: 10, Amazon: 3 (for each domain), ArkivMusik: 10, Buy.com: 2, Discogs: 3, GoogleImage: 10, Kalahari: 1, LastFM Artist: 10, LastFM Cover: 1, maniadb: 1, Take 2: 10, Yes24: 4. Nothing else returns any results, and I don't get the crash.

Actually, just had an idea - do you have the Local Files source checked? Could it be finding files already on your hard disk?
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2011-05-14 20:09:55
Actually, just had an idea - do you have the Local Files source checked? Could it be finding files already on your hard disk?


Yes I do use this also...

but...

testing:
im trying to check one source after another and extending actual search
.
.
.
ok now i know that this is produced by GoogleImage source
.
.
.
i also know that the crash occur AFTER "Automatically download full size images" is checked
.
.
.
ok this is "for sure" triggered when "google image" returns some kind of "404" when asked for full size image

hope this will help
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-14 20:35:20
hope this will help
That's great, it does help, thanks! Google is returning an HTML error page as the image contents, and WPF is trying to construct an image out of that data. So it isn't an odd image format that WPF doesn't support, just a bug with the way it deals with servers returning non-image data from an image url. I'll fix that.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-15 09:07:03
Version 0.38.1
This version fixes the bug reported by cartman(2vd) where it would crash if given invalid image data when retrieving the full sized image.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.1.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.1.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: cartman(2vd) on 2011-05-15 16:44:15
Version 0.38.1


working perfectly. thx
Title: Album Art Downloader XUI
Post by: delusion on 2011-05-15 21:24:29
working perfectly. thx

sadly not for me...

i get a graphics error, but this may not have to do with the new version...
i got the following .net-packages installed: 1.1, 2.0SP2, 3.0SP2, 3.5SP1
it did work with the v37.1

and this is how it looks like, after starting it...

(http://i53.tinypic.com/11w7kpe.jpg)

another thing i noticed in v37.1 is, that the discogs-results were not displayed in the results window.
it does count in the search-window how much AAD finds, but they are not displayed.
i did not set any min-max-rates, and results of others like google or juno work fine.

hope, someone can give advice, this tool rocks!!!

fg, dls

Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-16 08:14:19
sadly not for me...
[...]
another thing i noticed in v37.1 is, that the discogs-results were not displayed in the results window.
it does count in the search-window how much AAD finds, but they are not displayed.

Wow, that's weird. From that screenshot, it looks like a graphics driver issue to me, and I'd usually recommend ensuring your graphics driver is up to date. I have no explanation as to why it might have worked in 37.1 and not 38.1, though.

If the source shows a count of results, but they are not visible, then it must be filtering them in some way. If you haven't got minimum or maximum size filters set, then maybe you have a cover types filter set? Check that the "Unknown" is ticked in the "Filter by cover types" box, as discogs always uses Unknown as the cover type.

Alex
Title: Album Art Downloader XUI
Post by: delusion on 2011-05-16 12:31:28
thx for your fast reply!

for me it also seems like a graphic/driver-issue.
but i can play around with any app on my pc for hours with no graphics-error like this.
i also assumed foobar (running with dui) could be the bad player on my pc.

so i tried with foobar running with cui this morning and it works atm.
as soon as i start foobar with dui again, the graphics issues return!
so i'm gonna tell in the foobar-section!

the problem with the discogs-results were selfmade!
i filter only for front-covers, but discogs displays any image as "unknown"... so this was my fault!

another question i came across is the desired path&filename-saving...
under "options" in the main window is displayed "images will be saved to:" in my case "C:\...\Folder%preset%.%extension%"
underneath is the advice: "This Path was set automatically ... The Location ... can be set in the options for that window"

now i want to store the files as "front.jpg" instead of "folder.jpg" but where to find this option, am i stupid or just blind?

fg, dls
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-17 07:50:03
now i want to store the files as "front.jpg" instead of "folder.jpg"

That's weird with the foobar dui showing graphical corruption too. I've no idea what's going on there.

To change where the results are stored when starting from the File Browser or the Foobar Browser, click the Options link in that browser window and modify the "Path to find images" box. If you want it to be literally "front.jpg" you can put that in, but you could also have "%type%.%extension%" if you want it to fill in the cover type automatically. Remember you can click on the cover type in the result to change it, if it's wrong, before saving.

Alex
Title: Album Art Downloader XUI
Post by: meDveD.spb on 2011-05-17 19:55:53
Images will be saved:
\folder%preset%.%extension% -> folder.jpeg (version 0.38.1)
\folder%preset%.%extension% -> folder.jpg (version 0.37.1:)

I have not found how to fix it.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-18 08:11:48
Well spotted! It seems that WIC and GDI+ have differing opinions on what the default extension for jpeg images should be. I'll put in a special-case workaround to use .jpg for jpeg files anyway, to keep consistency. Until then, if it's important, you could temporarily change ".%extension%" to ".jpg", as there are really very few images that aren't jpegs.

Alex
Title: Album Art Downloader XUI
Post by: skace on 2011-05-19 05:21:03
Hi Alex, I have a few things I'd like to say.

First off, I'd just like to tell you how much I appreciate Album Art Downloader. It's very minimal, fast and does exactly what it is supposed to. I used it to go from a point where I wasn't using any album art at all for my music collection of 10,000 files to a point where every file has a respectable and decent cover art. This is a task that I personally never thought would be worth accomplishing (but always wanted) and yet your tool made it very possible. I truly appreciate that.

As someone who has been using AlbumArtDownloader for awhile, I noticed some odd functionality in the auto updater that you should be aware of. According to the auto updater within the app I was at the latest version. However, I had noticed over time that my results back were becoming worse and worse, to the point where I wasn't finding anything except google image results. I started doing some research and found a button in the lower right that said update scripts and when I checked it (which I thought was weird because I clearly remember getting updates and my GIS script was clearly up to date) it found updates for nearly every script. So I restarted thinking everything would be better however the application crashed compiling scripts saying that the "util" import was not found. I thought this was odd, since the util import was in my archived old scripts and many of the scripts looked the same, but I gave up troubleshooting and decided to install the latest version from html download. This  version appeared to have more scripts and they were all updated so I thought everything would be good, but when I ran it, I got poor results, so I forced the auto update to run again. It told me it had script updates and restarted, ran the test again and still some poor results, so I ran the updater a 2nd time and it found even more updates. Also, something odd that I noticed at this point is that this "new" same version was missing the check box in the lower right to tell it whether i wanted new scripts or not. Weird since it was the same version. Anyhow, after the multiple updates, my results started looking a lot better and I was getting everything back. The only thing worth mentioning is that the take2 script is completely worthless, it always returns the same 10 matches.

Just to recap:
1. Auto update is clearly leaving some of us out-of-date. I'm not sure if it is because you released 2 versions under the same version rev, so our clients 'think' they are up to date or what.
2. Even when the correct version is there, the auto update still needs to run multiple times to get the most up to date scripts, this seems odd behavior.

I hope this helps, I was just worried there may be other people out there who might think the application has dipped in quality when in fact it is just that they are being unknowingly left behind by false positives on the auto updater.

I'd like to end this with a tangent. My scripts were so old that I still had one for AlbumArtExchange. I used AAX significantly when I started populating my collection and while I noticed when it stopped returning results, I didn't bother troubleshooting it because I had 90% of my artwork. However when I started researching these issues, I dug into the AAX debacle and I must say, what a disappointment. I won't go over everything that seemed flawed from what I read, but I will say that the world will move on without AAX and all of that beautiful artwork that many, many people created for free will ultimately go unused. A shame.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-19 08:47:34
Hi Skace, thank you for your comments. I will investigate the auto-updater issues you mention. This is certainly not intentional. My best guess at the moment is that you somehow managed to get it to update to the latest versions of the scripts without having the latest version of AAD itself, which meant that some of the newer scripts weren't compatible with the older AAD version. Why it wouldn't detect the newer AAD version though, I don't know yet. What I don't understand at all is how, after running an update bringing all the scripts up to date and restarting, those scripts were still not up to date. Older versions of scripts are not kept, so if it downloaded anything, it would have been an up-to-date script.

Are you sure it was the same scripts that needed updating twice, or could it have been that it updated some of the scripts the first time, and other scripts the second time? (that's still wrong behaviour that needs fixing, but it's a bit less weird)

The other thing that is really weird is that you say the "Automatically download new scripts when available" disappeared? I can't understand that at all, there isn't even any code for hiding that checkbox.

In case it's helpful, here's some details on how auto-update is supposed to work

There are three separate tasks that auto-update can perform: a check for updates to the application itself, a check for updates to the scripts you have installed, and a check for available scripts that you do not have installed.

When checking for updates (either automatically or triggered by the menu command) it will first check for a new version of the application itself. If there is one, then that is the only update offered; it won't show any updated scripts as they should be included with the updated application version, and scripts designed for newer application versions may fail to work properly on older versions.

If the application version is up to date, but installed scripts are not, then it will show the updates available to scripts. At this point, if it also detected that there were available scripts that were not installed, it will cause the "Get more scripts" link to be shown under the sources list. If you've previously checked the "Automatically download new scripts" checkbox, then rather than showing that link it will just download them all without notifying you of any changes.

Scripts are updated as problems with them are reported (so I'll take a look at take2 now and either fix or remove it), so they are updated more frequently than AAD is. If the latest version is quite old (as 37.1 is) then there will be an update to scripts available as soon as it is run for the first time.

Alex
Title: Album Art Downloader XUI
Post by: skace on 2011-05-19 23:27:16
Ok so, the checkbox...

Is probably missing because I previously checked it (which caused the old version to stop loading) and then I installed the html downloaded version on top of my previous version (with the scripts dir renamed). I didn't realize the checkbox vanishes once you check it?

I assume that is what you mean by "If you've previously checked the "Automatically download new scripts" checkbox, then rather than showing that link it will just download them all without notifying you of any changes."

The double updates...

May possibly be 1 update to get new scripts and 1 update to get updated scripts. I didn't take screenshots but I recall the second sweep have a large number of .5 -> .6 upgrades and an upgrade from .9 to .10 of google image which was the reason my google image wasn't returning anything. I guess the first update did completely new scripts. My suggestion would be to combine this functionality into 1 update or have it force updates until it can't find anything more to update. Either way, had I continued using it without manually forcing the second update, my results would have been consistently poor.

The outdated identical version...

Is it possible that your auto-update failed to update a file that was used by AAD (a dll or some such) but updated everything else including the version information the updater uses to check if you are up to date? This would make the most sense to me. However, just a stab in the dark. Either way, when i told scripts to update I could no longer even launch the application (failed in compiling phase) which means it failed to update something in the wrong order.

Sorry, that is the best info I can offer. I wish I had taken screen captures of the issue, but at the time I just assumed all the scripts had gone unsupported and I was SOL. I didn't actually except such a drastic difference after the manual update.

-------------

It'll be interesting to see the new version. My only feature request would be if AAD, called with no parameters, defaulted to some sort of main window that contained the queue list, foobar browser and other hidden functionality all sort of built into 1 app window. And then you could use the main window to launch your searches (maybe even have them launch as tabs). As it is, I tend to launch an empty search just to launch other windows and then launch my real searches, which launches more windows + the queue window. I'm guessing many other people probably launch the program via scripted commands and don't see this type of issue.

Thanks again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-20 08:10:01
I didn't realize the checkbox vanishes once you check it?

The "Automatically download new scripts" checkbox doesn't vanish, but rather than showing the "Get more scripts" link under the sources list in the main window, it just downloads the new scripts and shows a yellow "New scripts downloaded" note there instead. If you click that, it will show you a window listing the scripts it downloaded, and that has an "Automatically download new scripts" checkbox too, that you can uncheck to stop the behaviour.

My suggestion would be to combine this functionality into 1 update or have it force updates until it can't find anything more to update.

In the next version (which I'll upload this weekend), even if it has automatically downloaded new scripts, it will still show the updated scripts window if there are scripts to update too. Hopefully that should stop the double-update issue.

Is it possible that your auto-update failed to update a file that was used by AAD (a dll or some such) but updated everything else including the version information the updater uses to check if you are up to date?

I don't think so, the updater will download scripts automatically, however it doesn't automatically patch the main application. It only provides a link for you to download the normal installer from the normal place. The installer should overwrite everything, if you install to the same place as the existing version.

My only feature request would be if AAD, called with no parameters, defaulted to some sort of main window that contained the queue list, foobar browser and other hidden functionality all sort of built into 1 app window.

The main search window has all of those other windows available from the menu. I suppose having always-visible buttons for them would be one click shorter, but are they really that hard to find on the menu? The queue window automatically appears the first time an album becomes queued anyway - I don't think there's much point in drawing attention to it before then, really.

I tend to launch an empty search just to launch other windows

If you prefer to start with a browser window rather than a search window, then add "/fileBrowser" or "/fooobarBrowser" to the command line of the shortcut you use to launch AAD. I might a step to the installer to ask which of the three windows you want to see at startup, which would add the parameter automatically to the shortcut it creates in the start menu.

Thanks again for the details and suggestions,

Alex
Title: Album Art Downloader XUI
Post by: skace on 2011-05-20 18:33:51
Thanks for the /foobarbrowser tip. I'll start it that way. I still think a main window is just about the only thing missing from the app and would make it stronger, but I realize that it might be unnecessary work. I was thinking of something like this:

(http://img.photobucket.com/albums/v647/skacre/search01.png)

However, tie all the various browsers into 1 search window. File, Foobar, etc. This also shows how my sources doesn't have whatever link you are saying it should have. Windows 7 x64.

Anyhow, just a suggestion. Also, it would be cool if when you zoomed in on an image, if you had an image already for that album / artist, if it brought both up in some sort of comparison window. So you could do quick comparisons on whether it is an image upgrade.

Sorry, I know this all sounds like work, but its a great app and I can't help make suggestions. Take2 returned a valid result. Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-20 18:56:19

Thanks for the suggestion, but I prefer the multiple windows design. That way you can have them individually the size and shape you want. Your example might work for you, but personally I would find the browser too narrow, and the queue manager far too wide! I don't see any reason why the size of one should constrain the size of the other. Also, you might want several results windows open at once, and there's no good reason to disallow you from seeing more than one of those at a time either.

To answer your other points: The Get More Scripts link doesn't show because you already have them all. It only shows if on the last automatic update check it found new scripts for you, or if you have automatic update checking turned off (in which case there *might* be new scripts, it has no way of knowing, so shows the link just in case).

If you want to compare images in detail, right click on each image to compare and choose "Preview". This will open a preview window for that image which will let you zoom in and pan around to check detail. For your existing art, you should either see it in the results from the "Local Files Source", or in the file browser there should be a link to it in the Artwork Status column that you can also right click on to choose "Preview".

I'm glad Take2 is working again; I thought I'd fixed it, but it's good to get confirmation, thanks.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-21 09:31:14
Version 0.38.2
This version improves the behaviour of automatic updates when both new and updated scripts are available, and the "automatically download new scripts" option has been enabled. It also reverts the default filename extension for jpeg format images to ".jpg" instead of ".jpeg", to maintain consistency with the versions prior to 0.38.

If there are no further reports of issues with the move away from GDI+, I'll publish this version through online updates and make it the default download from the front page from next week.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.2.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.2.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: Jean Tourrilhes on 2011-05-27 00:31:26
Hi,

I have a request to make. I have a lot of Italian CDs in my collection. Amazon recently created a web site for Italy :

http://www.amazon.it/ (http://www.amazon.it/)

Would it be possible to add the italian web site to the amazon script ? Hopefully that should not be too difficult.

Thanks in advance...

Jean
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-28 08:32:51
Would it be possible to add the italian web site to the amazon script ?
Sure, that's no problem. I'm putting 0.38.2 onto online update today, so I'll include the new amazon.it script with that.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-28 10:52:37
I have now published 0.38.2 through online updates, along with updates for broken scripts (the installer is also updated, but if you've already got 0.38.2 installed you don't need to reinstall). I've fixed up all of them that can be fixed up, but the following scripts have been removed:
You should delete or disable these scripts if you have them installed, as they won't work, and can't be fixed.

I've also made a slight change to the installer so that the specialist scripts are no longer installed by default. You can still install all the scripts if you want just by checking the relevant boxes, but I think the smaller websites are getting annoyed by all the irrelevant queries, and they aren't providing benefit to most users. The general use scripts are:
Any other scripts should probably be disabled unless you know why you want to use them, otherwise you're just wasting your bandwidth and theirs.
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-05-29 13:15:22
hello, thanks for the update
I'd like to point out that something's quite wrong with big preview images, sometimes when you click to view them, they show up very thin instead of original-sized.

thanks for the hard work.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-05-29 14:10:57
I'd like to point out that something's quite wrong with big preview images, sometimes when you click to view them, they show up very thin instead of original-sized.
Oops, I can't believe I missed that. Of course, it only happens for some of the images, so I suppose all the ones I tested before just happened to be fine.

I've got a fix for it that I'm putting out immediately as 0.38.3:

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.3.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.38.3.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: Bernd on 2011-06-02 13:49:39
I wonder has anyone else got problems with covers from AllCDcover. For me they are very unreliable often returning a standard little image of theirs apologising about some error. I load the page in my browser and then often I can see it and seomtimes still not. In those cases I sometimes start another browser (say Chrome) and try and I can see it. Sometimes nothing helps and I just try again later or give up. I find CoverParedies is reliable and the second best in terms of quality and size and ability to find stuff after AllCDcover.

I'm left wondering if AllCDcover have some load control and return that simply when they won't serve me because say form my IP it's received a few requests already or even in parallel.

In any case I onwder if anyone else has seen it, and if so, if it's worth writing some work around which keeps trying when the dummy image is detected and gives up if one can't be got after a certain number of tries.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-02 19:28:03
I wonder has anyone else got problems with covers from AllCDcover
AllCDcover has some sort of leech protection on it (see earlier discussion (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=681963)). It seems to vary a bit, probably to deliberately frustrate attempts to work around it. Personally, I'd suggest just not using AllCDcover - but if you do want to, I think the best thing to do when it starts acting up is just leave it and come back to it another time.

Alex
Title: Album Art Downloader XUI
Post by: Bernd on 2011-06-03 04:47:01
Thanks Alex. I should have search, didn't see the box for that. Bummer. I do avoid AllCDCover wheenver I can, but like it or not often they ar ethe only ones with a cover or back image I want! usually coverparadies covers my bases, but sometimes it's AllCDcover.

All I can say is it's not IP based I think because I just had the problem and thried hidemyass.com and no luck there either for the image I wanted. It seems specific to the image perhaps. Who knows.

The do have an API it seems:

http://www.allcdcovers.com/api (http://www.allcdcovers.com/api)

and it would seem to me that this was a meaningless thing with such dud protection. Could it be that if you used the API that this problem diappears? Or are you already using it, of course?

I haven't looked at it closely I admit.

In any case given this has been asked a few rtimes already and your very patient with referring up and IMHO the linear nature of one forum trhead kind of sucks, I wanted to ad a note to wiki hee FAQ here:

https://sourceforge.net/apps/mediawiki/albu...tle=FAQ-General (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=FAQ-General)

but can't (it's not open). You might wnat to do that quickly Alex.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-03 08:24:31
The do have an API it seems:
Yes, I searched their forum too. As I see it, there are two obstacles to using the API: first, they are not accepting any new requests for access keys at this time (or at the time the other forum posts asking about it were made, anyway). Secondly, and this is even more of an obstacle, it is not a public API - it requires that you use a private key with each request. This makes it pretty much unusable for an open-source project as there is no way to keep the key secret, and I'm guessing not keeping the key secret would be a deal-breaker for using the API (otherwise why bother with a key at all).

Incidentally, that's the same reason we aren't using the Amazon API any more. APIs are great, and I'd love to be able to use more of them, but as long as sites think that APIs should be less public than HTML interfaces, chances are we'll have to stick with HTML interfaces.

The wiki should be editable by anyone with a sourceforge account - were you logged in to sourceforge when you tried to make an edit? If so, then let me know and I'll try and figure out why it's been protected. The reason I haven't added anything to the FAQ is that I don't really have a good handle on the problem; I can't say for certain if it's IP based, or specific image based, whether it's only affected by your actions or whether images could get locked down if lots of different people search for them, what relation their captcha has to any of this. I've put a very vague answer up there now, though.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-05 15:44:35
I just discovered this very handy utility. Thank you for developing it!

I noticed one thing: I use J. River Media Center to manually invoke searches in AAD ("Send to external program"). If I click to save cover art for one album and the downloads are so slow that they are not initiated/completed before I invoke the next search, the downloaded file is put in the folder indicated in the subsequent search, not the folder path I saw when I clicked download. Is this a known issue? I have the option to open search results in a new window unticked.

Would it be possible to identify also Inlay and Booklet, which are used at least on Cover-Paradise? If so, would it also be possible to introduce an option for downloaded booklet (and preferably also CD) files to be numbered sequentially, i.e. "Booklet-1", "Booklet-2" etc. starting with the first number not already existing in the download folder?

Would it be possible to add more types in the type drop down list (custom types or at least the additional types Preset, Inlay and Booklet) so that the file name for that file, if downloaded, can easily be changed this way? (I found that the presets are actually better for this.)

(Sorry if this has been asked before - It is a long thread.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-05 16:15:59
Thank you for your comments - I'm not sure I've understood them all correctly, so if not, please let me know.

1. If you click the Save button for a result which will take a while to download the full-size image, then immediately search for something different in the same window (causing the result which is being saved to disappear from the results list), then when the full-size image for the result has completed and it's saved, it will be saved with the wrong filename? That hasn't been reported before, but it certainly sounds like a bug. If I can reproduce it, I'll include a fix for it in the next version.

2. Sequential numbering is not currently supported, but is a good idea. I've added a feature request (https://sourceforge.net/tracker/?group_id=187008&atid=919578) for it to the tracker.

3. Support for additional or custom types can not easily be added. The types system as implemented relies on their being a single well defined list of types that doesn't change. You can change how they appear in the filename (so the Front type could appear as Cover, for example), but not what they mean or how many there are.

In contrast, the Presets feature was designed to allow you to define any number of custom strings that you can pick from to substitute into the filename. You can add as many of these as you like, and pick from them using the drop-down arrow next to the save button. For example, if you use the filename pattern "%preset%.jpg", then edit the presets so that the default is "%type%", and there are two other presets "Inlay" and Booklet" then you could use the dropdown next to the save button to save as Inlay.jpg or Booklet.jpg

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-05 16:51:42
Thanks for your immediate response! Excellent support as well! 

1. If you click the Save button for a result which will take a while to download the full-size image, then immediately search for something different in the same window (causing the result which is being saved to disappear from the results list), then when the full-size image for the result has completed and it's saved, it will be saved with the wrong filename? That hasn't been reported before, but it certainly sounds like a bug.

1. Yes, that is what I am seeing. But I invoke searches from J. River Media Center (with a new file path for each album/search), not by clicking the search button in AAD.

2. Sequential numbering is not currently supported, but is a good idea. I've added a feature request (https://sourceforge.net/tracker/?group_id=187008&atid=919578) for it to the tracker.

Great!

I saw this in the tracker.
Quote
Add a placeholder (such as "%n%") that is replaced by the smallest number greater than 0 required to make a unique filename. So if "cover %n%.jpg" was the filename, and "cover 1.jpg" already existed, the filename would be "cover 2.jpg".

But then the file name would be "cover .jpg" if there already is a "cover.jpg" file. This could be solved if you allowed the new placeholder to include also " " or "-", i.e. "% n% or %-n%, or %n%. Or have you considered implementing conditional placeholders like "%% %" that would put a space, or something else, in the file name only if there are some other character than a period following? They could come in handy.

In contrast, the Presets feature was designed to allow you to define any number of custom strings that you can pick from to substitute into the filename. You can add as many of these as you like, and pick from them using the drop-down arrow next to the save button. For example, if you use the filename pattern "%preset%.jpg", then edit the presets so that the default is "%type%", and there are two other presets "Inlay" and Booklet" then you could use the dropdown next to the save button to save as Inlay.jpg or Booklet.jpg

Yes, I figured that out, thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-05 17:07:56
I saw this in the tracker.
But then the file name would be "cover .jpg" if there already is a "cover.jpg" file.

No, it would be "cover 1.jpg" in all circumstances where there was no "cover 1.jpg" file already existing. If there's a %n%, then there's a number. I don't want to complicate the placeholder system by adding conditionals and logic to it - I can see where that leads with the foobar titleformatting syntax, and I'm not interested in going down that path. This means that there would be no way to name the first file as "cover.jpg" and the second as "cover 1.jpg"; you either have numbers as part of your filename or you do not.

If you want to add further comments or opinions on that proposal, would you mind making them on the tracker itself? That way, when someone (probably me, but you never know) comes to implement it, they won't be forgotten.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-05 18:18:59
Thanks for the reply!

If you want to add further comments or opinions on that proposal, would you mind making them on the tracker itself? That way, when someone (probably me, but you never know) comes to implement it, they won't be forgotten.

I have added a comment in the tracker. (Please forgive me, I am totally new to these forums and your "tracker").

As you might have guessed by now I am not a programmer, so I am afraid I cannot help out in that respect. But you are doing a great job!

Thanks for considering this enhancement!
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-05 18:31:54
For example, if you use the filename pattern "%preset%.jpg", then edit the presets so that the default is "%type%", and there are two other presets "Inlay" and Booklet" then you could use the dropdown next to the save button to save as Inlay.jpg or Booklet.jpg

Oh, and I just wanted to let you know that if you do this then the proposed file name displayed is [folder path].jpg, i.e. the preset value (%type%) is not displayed. This was a bit confusing at first.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-05 18:42:26
Oh, and I just wanted to let you know that if you do this then the proposed file name displayed is [folder path].jpg, i.e. the preset value (%type%) is not displayed. This was a bit confusing at first.

Hmm... that's a bug. The displayed filename should always be what you would get if you hit the save button (i.e., the default preset value if used). Thanks for reporting it.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-06 10:15:37
Oh, and I just wanted to let you know that if you do this then the proposed file name displayed is [folder path].jpg, i.e. the preset value (%type%) is not displayed. This was a bit confusing at first.

Hmm... that's a bug. The displayed filename should always be what you would get if you hit the save button (i.e., the default preset value if used). Thanks for reporting it.

And if you drag the file out of AAD you get a ".jpg" file.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-06 18:38:51
And if you drag the file out of AAD you get a ".jpg" file.

Yeah, that would be the same underlying cause. Unfortunately I can't do anything this week, but will fix over the weekend. The only question then is whether to try and also do something about numeric suffixes, or just release a purely bug-fixing point release.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-07 07:45:59
The only question then is whether to try and also do something about numeric suffixes, or just release a purely bug-fixing point release.


If you are asking me, I would like it if you gave priority to the issue I initially reported. Having only some of the downloaded cover art seemingly arbitrarily put in the wrong album folder can really mess things up in a way that is hard to spot and sort out afterwards. Even though I try to wait for the downloads to complete before issuing a new search, I still miss sometimes.

The ".jpg" issue is almost only cosmetic and easily spotted by the user and the numbering thing is, even though welcomed and anticipated by me, an enhancement.

But hey, it is your spare time we are talking about. I am very happy with what you have achieved so far!
Title: Album Art Downloader XUI
Post by: Dexter_prog on 2011-06-07 18:47:38
I thought this program would save me some time, but I found that the google images search is not good. I usually look for 700+ px covers but this keeps findind all the smaller ones (400x400 and similar) and if I do a manual google images search I can easily get the bigger ones. Any way to fix this?
Title: Album Art Downloader XUI
Post by: DRata on 2011-06-07 21:21:29
I thought this program would save me some time, but I found that the google images search is not good. I usually look for 700+ px covers but this keeps findind all the smaller ones (400x400 and similar) and if I do a manual google images search I can easily get the bigger ones. Any way to fix this?


Under the search fields, click on "Options..." to show the option to filter by image size, and change the minimum to 700 px.

Note to Alex: Maybe the appearance of the "Options..." button should be changed to make its function clearer to new users.
Title: Album Art Downloader XUI
Post by: performant on 2011-06-08 13:20:14
The proggy worked fine until I upgraded to 0.38.3, when it started to crash with a "fatal error."
Here's part of the error message:
Quote
App version: 0.38.3.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (32 bit)
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileFormatException: The image format is unrecognized. ---> System.Runtime.InteropServices.COMException (0x88982F07): Exception from HRESULT: 0x88982F07
  --- End of inner exception stack trace ---


I thought it was the new version, but after a few attempts to narrow down the cause, it turns out that one source plugin, or whatever else I'm supposed to call it, is the culprit.
AAD works superbly as usual only if I leave the source "Chartstats" unchecked.
Guess I could do without a single source, but I also figured someone might want to take a look.

BTW, this proggy has saved me a tremendous amount of time and work.
A BIG thanks to Alex, daju, Marc and david!!
Title: Album Art Downloader XUI
Post by: Dexter_prog on 2011-06-09 14:23:57
I thought this program would save me some time, but I found that the google images search is not good. I usually look for 700+ px covers but this keeps findind all the smaller ones (400x400 and similar) and if I do a manual google images search I can easily get the bigger ones. Any way to fix this?

Yeah, I figured later that if I set that option BEFORE doing the search it actually searches further

I would love an option to always show the options dialog when opening the program.
Title: Album Art Downloader XUI
Post by: Dexter_prog on 2011-06-09 18:46:55
Nah, it still doesn't give as much good results as google images does for some reason.

I think I found it: it keeps limiting the seach results on googleimages for 20, even if I untick it or set it to whatever, like 30, 40, 100, etc.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-12 12:50:34
AAD works superbly as usual only if I leave the source "Chartstats" unchecked

Thanks for reporting this. I've tried a couple of searches on Chartstats, but it seems to work fine for me - could you tell me what you searched for so I can try and reproduce the problem here? Or if you have the rest of the error report, it might help too.

it keeps limiting the seach results on googleimages for 20

The google image script fetches one page of results from google, so is limited to the number of images google returns on one page. Recently, google have added some javascript cleverness so that their image search site can automatically load more pages of results as you scroll down so that it looks like just one big page of results. That is not something the script would be able to do, sorry.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-12 17:36:30
Version 0.39
This is primarily a bug-fixing release, but I've also added an improvement to the way Album Art Downloader warns about overwriting existing files. The new warning message contains a link to the existing file about to be overwritten (so it can be shown in explorer, previewed, renamed, etc.), and as well as the option to overwrite or pick a new name, now offers a button to save it with an automatically generated unique name. This will typically be the filename with " (2)" added to the end. So if you already have "Folder.jpg", it would save as "Folder (2).jpg", then "Folder (3).jpg" for the next one and so on.

The bugs fixed are:
(I know the overwrite behaviour isn't exactly what was requested, but I hope it helps a bit anyway.)

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.39.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.39.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-12 18:52:56
Version 0.39
This is primarily a bug-fixing release, but I've also added an improvement to the way Album Art Downloader warns about overwriting existing files. The new warning message contains a link to the existing file about to be overwritten (so it can be shown in explorer, previewed, renamed, etc.), and as well as the option to overwrite or pick a new name, now offers a button to save it with an automatically generated unique name. This will typically be the filename with " (2)" added to the end. So if you already have "Folder.jpg", it would save as "Folder (2).jpg", then "Folder (3).jpg" for the next one and so on.

The bugs fixed are:
  • If a search window was reused for a new search while a full-sized image was being downloaded for saving, that image would be saved with the filename for the new search, not the old one.
  • When the default preset value is non-blank, it wasn't applied until the save button was clicked.
(I know the overwrite behaviour isn't exactly what was requested, but I hope it helps a bit anyway.)

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.39.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.39.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)


Thanks! Well done! You are both responsive and fast.

Any chance of having the automatic numbering option as the default option?
Arguments: It is more user friendly to have a non destructive option as default and it would speed up my work flow if I could save the file with a unique name by just pressing enter.

(Why is it not possible to download one file twice now with this new functionality? I used the default by accident and overwrote a file already downloaded and wanted to re-download it, but then I had to use the Save as option and manually rename it. Double clicking on the cover art would give me a file name of something like "Booklet (2) (2)" in this situation.)

Re: The " (n)" suffix: You do know that this will produce the following sort order in Windows Explorer (if "Booklet" is the preset):
Booklet (1)
Booklet (2)
Booklet

This will make the pages/files display in the wrong order (the file downloaded first will be displayed last) in a software I use for displaying cover art. That was why I used Booklet, Booklet-1 etc. If I just change my preset to "Booklet (1)" this will produce a file name of "booklet (1) (2)" for the next file I try to save. (Finding the correct order for booklet pages in reverse is not as easy as starting from the beginning.) Having to manually change the first downloaded file for stock types from "CD" to "CD (1)", for example, will also mean more work than would be necessary with another naming scheme which adhered to both the order in which the files were downloaded and the display order in Windows. Any chance you could reconsider the naming scheme?

(Please let me know if you would like the latter comments in the feature request tracker forum instead.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-12 19:51:19

Thanks for the feedback. In general, I would agree that a non-destructive option should be the default, however for this application I would consider that the most common usage is to have a specific filename for artwork, and that the default should be to use the filename exactly as specified. I think it's most common to want to always save the artwork as Folder.jpg, even if that means overwriting an existing one. Wanting to store multiple cover artworks per album is more of a niche use-case, in my opinion, so you'll have to hit Tab (or Down), Enter rather than just Enter.

The reason that re-saving a cover already saved will give you a double suffix is that once you save a cover with a non-default filename, the filename shown for it is set to what it was actually saved as (you can see it turns bold to indicate that it is now set to a specific value for that cover, and will no longer be automatically changed). This means that if you save that cover again, it will try and overwrite that same file, and consequently offer you the same choice of overwriting or adding a (further) suffix. If you want to reset the filename for a cover back to the default, click on the filename to edit it, and delete all the text in the box, so that there is no longer a specific filename set for that cover.

For the naming scheme, I'm following the automatic numeric naming pattern that Explorer uses. Personally, if I actually wanted multiple covers, I'd prefer folder.00.jpg, folder.01.jpg, etc. so that they'd always sort correctly, and could have the number easily removed or processed in a batch or script, but that's probably a bit of a programmer thing. The Microsoft Usability team think that "folder.jpg", "folder (2).jpg", etc. is what normal people like, so that's what I'll stick with, as far as the user-friendly no-config 'just don't overwrite my existing file' feature goes.

The more advanced functionality of letting you specify a number anywhere you like as part of the file name would still be the feature request in the tracker. This would let you have constant numeric values, so you could have booklet-1.jpg, booklet-2.jpg, etc. (but not booklet.jpg) which would sort correctly, but from your comments there it appeared that a scheme where the first filename was unchanged was what was requested. If I've misunderstood that then please clarify in the tracker.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-12 21:06:29


Thanks for the reply and your patience!

You have obviously thought this through, and I have already stated my best arguments. Fine. Thanks again for the update!

(I will add one more comment in the feature request tracker - let a new %n% placeholder add only a number (or a padded number), no preceding space or anything.)
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-13 11:39:46
Hi again,

If I click to download two files that would get the same file name and the downloading of the first file is not finished when I click to download the second file, only the second file will be saved without any warning (at least it seems that it is always the second file that is saved, but which file gets saved could have something to do with which file completes downloading first or last instead - the end result is, however, that I get only one instead of two uniquely named files). Seems like a bug.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-13 12:02:19
Hi again,

If I click to download two files that would get the same file name and the downloading of the first file is not finished when I click to download the second file, only the second file will be saved without any warning (at least it seems that it is always the second file that is saved, but which file gets saved could have something to do with which file completes downloading first or last instead - the end result is, however, that I get only one instead of two uniquely named files). Seems like a bug.


And the automatic numbering is not working if you save several files with the same name and they are not completely downloaded when you click save. The automatic numbering will kick in because the first file is saved, but the suggested number for the new file will be wrong (the same number is suggested again) if all previously saved files have not been completely downloaded. If you accept the suggested number in this situation, the new file will without any warning overwrite the previous file with that number.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-13 13:04:32
Yes, the file doesn't actually exist until it finishes downloading, so if you download multiple things at the same time then no overwrite warning will be shown as no file exists yet when the check is made.

I still want the check to be made when you click the save button, as popping up a warning a few seconds later once it finishes downloading would be irritating, but what I'll do is have it create an empty dummy file immediately. That will be replaced with the actual image when the download finishes, but until then it's presence should mean that overwrite warnings will be generated if you try and save something else with the same name.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-13 13:13:08
I still want the check to be made when you click the save button, as popping up a warning a few seconds later once it finishes downloading would be irritating, but what I'll do is have it create an empty dummy file immediately. That will be replaced with the actual image when the download finishes, but until then it's presence should mean that overwrite warnings will be generated if you try and save something else with the same name.


Sounds like a good solution. Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-13 18:44:01
Version 0.39.1
Just a quick bug-fix to resolve the undesirable overwrite behaviour when simultaneously downloading multiple results to the same file.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.39.1.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.39.1.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-13 18:58:59
Thanks! That was fast.
Title: Album Art Downloader XUI
Post by: Dexter_prog on 2011-06-14 01:51:02
it keeps limiting the seach results on googleimages for 20

The google image script fetches one page of results from google, so is limited to the number of images google returns on one page. Recently, google have added some javascript cleverness so that their image search site can automatically load more pages of results as you scroll down so that it looks like just one big page of results. That is not something the script would be able to do, sorry.

Alex

I don't know shit about programing, but couldn't it do this search (this is using google's option to search for images bigger than 640+480): http://www.google.com.ar/search?q=CAT&...ved=0CA8QpwUoBA (http://www.google.com.ar/search?q=CAT&hl=es&biw=1920&bih=897&gbv=2&sout=1&tbm=isch&source=lnt&tbs=isz:lt,islt:vga&sa=X&ei=8H7RTbW_EYHv0gGgoIWZDg&ved=0CA8QpwUoBA) ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-14 08:29:38
I don't know shit about programing, but couldn't it do this search (this is using google's option to search for images bigger than 640+480): http://www.google.com.ar/search?q=CAT&...ved=0CA8QpwUoBA (http://www.google.com.ar/search?q=CAT&hl=es&biw=1920&bih=897&gbv=2&sout=1&tbm=isch&source=lnt&tbs=isz:lt,islt:vga&sa=X&ei=8H7RTbW_EYHv0gGgoIWZDg&ved=0CA8QpwUoBA) ?
There aren't quite the same options available for the no-javascript search page (try http://images.google.com/images?q=Cat&gbv=1 (http://images.google.com/images?q=Cat&gbv=1) with javascript turned off in your browser), but there are options for "small" "medium" and "large". I don't know exactly what dimensions they correspond to, but if you want to change the google script to specify one of those, then open google.boo in notepad and where it has the url "http://images.google.com/images?gbv=1&q=" change it to be "http://images.google.com/images?gbv=1&tbs=isz:l&q=" (for large. Use &tbs=isz:m for medium.)

Alex
Title: Album Art Downloader XUI
Post by: MC Escher on 2011-06-14 14:19:00
I don't believe anything has changed on my pc, but suddenly the File browser keeps crashing whenever it's opened, whether it's from the context menu or from the search window.

This is the error log:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
  If you wish to report this error, please include this information, which
  has been written to the file: D:\Programma bestanden\AlbumArtDownloader\errorlog.txt
 
  App version: 0.39.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)
 
  System.Windows.Markup.XamlParseException: Kan geen exemplaar maken van in assembly AlbumArt, Version=0.39.1.0, Culture=neutral, PublicKeyToken=null gedefinieerde BrowserResults. Het doel van een aanroep heeft een uitzondering veroorzaakt.  Fout bij object System.Windows.Controls.Grid in opmaakbestand AlbumArt;component/filebrowser.xaml. ---> System.Reflection.TargetInvocationException: Het doel van een aanroep heeft een uitzondering veroorzaakt. ---> System.TypeInitializationException: De type-initialisatiefunctie voor AlbumArtDownloader.BrowserResults heeft een uitzondering veroorzaakt. ---> System.NotSupportedException: Er is geen beeldonderdeel gevonden dat geschikt is om deze bewerking te voltooien. ---> System.Runtime.InteropServices.COMException (0x88982F50): Uitzondering van HRESULT: 0x88982F50
    --- Einde van intern uitzonderingsstackpad ---
    bij System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
    bij System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
    bij AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
    bij System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
    bij System.Linq.Buffer`1..ctor(IEnumerable`1 source)
    bij System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
    bij AlbumArtDownloader.BrowserResults..cctor()
    --- Einde van intern uitzonderingsstackpad ---
    --- Einde van intern uitzonderingsstackpad ---
    bij System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
    bij System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
    bij System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
    bij System.Activator.CreateInstance(Type type, Boolean nonPublic)
    bij System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
    --- Einde van intern uitzonderingsstackpad ---
    bij System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
    bij System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
    bij System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
    bij System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
    bij System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
    bij System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
    bij System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
    bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
    bij System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
    bij System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
    bij System.Windows.Markup.TreeBuilder.Parse()
    bij System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
    bij System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
    bij AlbumArtDownloader.FileBrowser.InitializeComponent()
    bij AlbumArtDownloader.FileBrowser..ctor()
    bij AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
    bij AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
    bij System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
    bij System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
    bij System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
    bij System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
    bij System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
    bij System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
    bij System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
    bij System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
    bij System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
    bij System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
    bij System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
    bij System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
    bij System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
    bij System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
    bij System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
    bij System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
    bij System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
    bij System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
    bij System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
    bij System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
    bij System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
    bij System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
    bij System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
    bij System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
    bij System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
    bij MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
    bij System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
    bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bij System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bij System.Windows.Threading.DispatcherOperation.InvokeImpl()
    bij System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
    bij System.Threading.ExecutionContext.runTryCode(Object userData)
    bij System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
    bij System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
    bij System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
    bij System.Windows.Threading.DispatcherOperation.Invoke()
    bij System.Windows.Threading.Dispatcher.ProcessQueue()
    bij System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bij MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bij MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
    bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bij System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bij System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
    bij System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
    bij MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
    bij MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
    bij System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
    bij System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
    bij System.Windows.Threading.Dispatcher.Run()
    bij System.Windows.Application.RunDispatcher(Object ignore)
    bij System.Windows.Application.RunInternal(Window window)
    bij System.Windows.Application.Run(Window window)
    bij System.Windows.Application.Run()
    bij AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
    bij AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
    bij AlbumArtDownloader.App.Main(String[] args)
 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-14 17:58:15

It looks to me like there might be some problem with the Windows Imaging Component codecs on your system. Could you try downloading WICExplorer (http://archive.msdn.microsoft.com/wictools/Release/ProjectReleases.aspx?ReleaseId=2887) from Microsoft and running it (inside the zip file it's  WICExplorer\bin\x86\WICExplorer.exe). Try opening an image file in it, then saving it in a different format (jpg, png, bmp, etc.). If it doesn't work, it might at least give a helpful error message.

Alex
Title: Album Art Downloader XUI
Post by: MC Escher on 2011-06-15 00:28:55
Ok, here's the error message:
(http://img841.imageshack.us/img841/3702/testakd.th.png) (http://imageshack.us/photo/my-images/841/testakd.png/)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-15 08:06:44
The error there is "WINCODEC_ERR_COMPONENTNOTFOUND", which does support my guess that there's something wrong with the Windows Imaging Component codecs. Unfortunately, I haven't been able to google up any suggested fixes for this, so the only thing I can really offer is that if you install the older Album Art Downloader 0.37.1 (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.37.1.exe/download) it might work as it uses GDI+ rather than WIC for saving images.

Alex
Title: Album Art Downloader XUI
Post by: MC Escher on 2011-06-15 10:01:58
I see I have some serious problems with my computer in any case, since all videos I try to play turn up black all of a sudden. Thank you for your help.
Title: Album Art Downloader XUI
Post by: Leitmotif84 on 2011-06-15 18:37:25
I am sorry if this has been asked/answered before, I tried searching.

What would cause a script to work perfectly fine in a normal search window query, but when invoked via the File Browser or Foobar window, it causes it to stall and not return any searches?
Title: Album Art Downloader XUI
Post by: burakusa on 2011-06-15 22:05:26
Hi forum,

When I search for the covers there are some sites software connects to for results which provide almost always the wrong cover. I un-check these sites but when I go back to search for covers again they all get checked by default. Is there a way to avoid un-checking every single time I start the program?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-16 08:12:22
I see I have some serious problems with my computer in any case, since all videos I try to play turn up black all of a sudden. Thank you for your help.
Thanks for letting me know, good luck with fixing it!


What would cause a script to work perfectly fine in a normal search window query, but when invoked via the File Browser or Foobar window, it causes it to stall and not return any searches?
Nothing; the file browser launches a normal search window - it's exactly the same, just with the album, artist and path to save to already filled in. If you are having trouble with a script, please tell me which one, and what you were searching for, and I'll look into it.


Is there a way to avoid un-checking every single time I start the program?
Unless you are using the command line to specify sources, then it should be remembering which you have checked and unchecked. If you start the program, check and uncheck the sources you want, then exit the program and restart it, does it lose all those settings? Do any other settings get kept, such as window size and position, or anything you've set in the Options panel?

As a last resort, you can always go to the Scripts folder and simply delete those that you don't want to use, but the checking and unchecking should work.

Alex
Title: Album Art Downloader XUI
Post by: Bernd on 2011-06-16 09:45:36
I love the new dialog asking if I want to overwrite files. It would be even better though if it showed a thumbnail and the dimensions of the existing image and the new image side by side clearly labelled. As the main basis I have for deciding usually is whether it's the right image and/or bigger (better res) than the one I had.
Title: Album Art Downloader XUI
Post by: performant on 2011-06-16 11:06:39
AAD works superbly as usual only if I leave the source "Chartstats" unchecked

Thanks for reporting this. I've tried a couple of searches on Chartstats, but it seems to work fine for me - could you tell me what you searched for so I can try and reproduce the problem here? Or if you have the rest of the error report, it might help too.
...
Alex

The Chartstats plugin seems capable of managing to crash my AAD installation (both 0.38.3 and 0.39) no matter what search strings I happen to throw at it.

Here's a full error log generated using 'Louis Armstrong' and 'California Concerts' on AAD 0.39 on 32-bit Win 7:
Quote
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: F:\temp\AAD_errorlog.txt

App version: 0.39.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (32 bit)

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileFormatException: The image format is unrecognized. ---> System.Runtime.InteropServices.COMException (0x88982F07): Exception from HRESULT: 0x88982F07
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
  at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
  at System.Windows.Media.Imaging.BitmapDecoder.Create(Stream bitmapStream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption)
  at AlbumArtDownloader.AlbumArt.CreateImageDecoderForBitmapData(Stream bitmapDataStream)
  at AlbumArtDownloader.AlbumArt.get_ImageDecoder()
  at AlbumArtDownloader.AlbumArt.get_ImageFileExtensions()
  at AlbumArtDownloader.AlbumArt.get_ImageFileDefaultExtension()
  at AlbumArtDownloader.AlbumArt.CoerceFilePath(DependencyObject sender, Object value)
  at System.Windows.DependencyObject.ProcessCoerceValue(DependencyProperty dp, PropertyMetadata metadata, EntryIndex& entryIndex, Int32& targetIndex, EffectiveValueEntry& newEntry, EffectiveValueEntry& oldEntry, Object& oldValue, Object baseValue, CoerceValueCallback coerceValueCallback, Boolean coerceWithDeferredReference, Boolean skipBaseValueChecks)
  at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  at System.Windows.DependencyObject.CoerceValue(DependencyProperty dp)
  at AlbumArtDownloader.AlbumArt.set_ResultName(String value)
  at AlbumArtDownloader.AlbumArt..ctor(Source source, Byte[] thumbnailData, String name, String infoUri, Int32 width, Int32 height, Object fullSizeCallbackParameter, CoverType coverType)
  at AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass10.<Add>b__9()
  --- End of inner exception stack trace ---
  at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  at System.Delegate.DynamicInvokeImpl(Object[] args)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-16 13:59:57
Here's a full error log generated using 'Louis Armstrong' and 'California Concerts' on AAD 0.39 on 32-bit Win 7:

Thank you for the information. There are two errors I can determine here. The first is that the Chartstats script is returning results with invalid pictures, where Chartstats site has no artwork for the album (but does have a page for it). I've put up an updated Chartstats script that should fix that now.

The second error is that AAD should not crash when it receives invalid picture data from a script. I'm actually not sure why it's crashing for you, as when I try it I just get blank results and no crash. But, from the log, I can see where the crash occurs so I'll put in a guard against it for the next version of AAD.

Alex
Title: Album Art Downloader XUI
Post by: Dexter_prog on 2011-06-16 15:01:35
I don't know shit about programing, but couldn't it do this search (this is using google's option to search for images bigger than 640+480): http://www.google.com.ar/search?q=CAT&...ved=0CA8QpwUoBA (http://www.google.com.ar/search?q=CAT&hl=es&biw=1920&bih=897&gbv=2&sout=1&tbm=isch&source=lnt&tbs=isz:lt,islt:vga&sa=X&ei=8H7RTbW_EYHv0gGgoIWZDg&ved=0CA8QpwUoBA) ?
There aren't quite the same options available for the no-javascript search page (try http://images.google.com/images?q=Cat&gbv=1 (http://images.google.com/images?q=Cat&gbv=1) with javascript turned off in your browser), but there are options for "small" "medium" and "large". I don't know exactly what dimensions they correspond to, but if you want to change the google script to specify one of those, then open google.boo in notepad and where it has the url "http://images.google.com/images?gbv=1&q=" change it to be "http://images.google.com/images?gbv=1&tbs=isz:l&q=" (for large. Use &tbs=isz:m for medium.)

Alex

That works great, but how can I have 2 googleimages scrips, one for the regular search and one for the bigger size search?
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-16 17:09:54
If the automatic update window and one search window are open in ADD, a search command issued from an external program will open an additional search window (instead of performing the search in the already open search window). This seems like a bug.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-16 17:29:53
That works great, but how can I have 2 googleimages scrips, one for the regular search and one for the bigger size search?

Make a copy of the google.boo file, then as well as changing the URL, change the line starting class GoogleImage to class GoogleImageLarge (or something. Doesn't matter what, as long as it's all one word and different from "GoogleImage", it's just an internal identifier). Probably best to change the line get: return "GoogleImage" to get: return "GoogleImage (Large)" or similar, so you can tell them apart in the list. The text in the " marks on that line is what's shown in the list.


If the automatic update window and one search window are open in ADD, a search command issued from an external program will open an additional search window (instead of performing the search in the already open search window). This seems like a bug.

In fact, if any other windows are open, an additional search window will be opened. The behaviour, as designed, is that new searches coming in from the command line will only replace an existing search window if it is the only window open. I'll think about whether to exclude the update window from that check, though.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-16 18:36:22
I love the new dialog asking if I want to overwrite files. It would be even better though if it showed a thumbnail and the dimensions of the existing image and the new image side by side clearly labelled. As the main basis I have for deciding usually is whether it's the right image and/or bigger (better res) than the one I had.

(Sorry, missed this one earlier)

Thanks for the suggestion. I'd generally suggest using the Local Files source if you want to compare the results with the ones you've already got, but there's no reason not to improve the overwrite dialog too. In case you haven't already noticed, there is a link to the existing file already in the dialog - if you right click on that you can preview it in AAD, or you can show the file itself in windows explorer.

Sometime I'll see if I can come up with a better design for the overwrite dialog that shows you more details in the box itself, though.

Alex
Title: Album Art Downloader XUI
Post by: performant on 2011-06-17 13:23:45
Thank you for the information. There are two errors I can determine here. The first is that the Chartstats script is returning results with invalid pictures, where Chartstats site has no artwork for the album (but does have a page for it). I've put up an updated Chartstats script that should fix that now.

The second error is that AAD should not crash when it receives invalid picture data from a script. I'm actually not sure why it's crashing for you, as when I try it I just get blank results and no crash. But, from the log, I can see where the crash occurs so I'll put in a guard against it for the next version of AAD.

Alex


Thanks for the quick update, but FWIW, the supposedly updated (if I'm not mistaken) Chartstats script still manages to crash AAD 0.39.1.0.
FWIW again, the following are my option settings:
Quote
Automatically download full-size images: Always
Minimum: 40 px
Filter by cover types: Front, Unknown

Here's a new error log, if it is of any help :
Quote
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: F:\temp\AAD_errorlog.txt

App version: 0.39.1.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (32 bit)

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileFormatException: The image format is unrecognized. ---> System.Runtime.InteropServices.COMException (0x88982F07): Exception from HRESULT: 0x88982F07
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
  at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
  at System.Windows.Media.Imaging.BitmapDecoder.Create(Stream bitmapStream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption)
  at AlbumArtDownloader.AlbumArt.CreateImageDecoderForBitmapData(Stream bitmapDataStream)
  at AlbumArtDownloader.AlbumArt.get_ImageDecoder()
  at AlbumArtDownloader.AlbumArt.get_ImageFileExtensions()
  at AlbumArtDownloader.AlbumArt.get_ImageFileDefaultExtension()
  at AlbumArtDownloader.AlbumArt.CoerceFilePath(DependencyObject sender, Object value)
  at System.Windows.DependencyObject.ProcessCoerceValue(DependencyProperty dp, PropertyMetadata metadata, EntryIndex& entryIndex, Int32& targetIndex, EffectiveValueEntry& newEntry, EffectiveValueEntry& oldEntry, Object& oldValue, Object baseValue, CoerceValueCallback coerceValueCallback, Boolean coerceWithDeferredReference, Boolean skipBaseValueChecks)
  at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  at System.Windows.DependencyObject.CoerceValue(DependencyProperty dp)
  at AlbumArtDownloader.AlbumArt.set_ResultName(String value)
  at AlbumArtDownloader.AlbumArt..ctor(Source source, Byte[] thumbnailData, String name, String infoUri, Int32 width, Int32 height, Object fullSizeCallbackParameter, CoverType coverType)
  at AlbumArtDownloader.Source.ScriptResults.<>c__DisplayClass10.<Add>b__9()
  --- End of inner exception stack trace ---
  at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
  at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
  at System.Delegate.DynamicInvokeImpl(Object[] args)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)


Edit:
Oh well, I just found out that the latest version on sourceforge was uploaded a few days ago. 
Never mind what I just said above 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-17 13:54:29
Thanks for the quick update, but FWIW, the supposedly updated (if I'm not mistaken) Chartstats script still manages to crash AAD 0.39.1.0.
Could you check you are using version 0.2 of the chartstats script? If not, please download it directly from here: chartstats.boo (http://album-art.sourceforge.net/scripts/chartstats.boo) and put it in your scripts folder, overwriting the existing one.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-18 10:24:12
If you issue a search command from another program, the search first settings are respected in the sense that the search stops if it finds a file meeting the set criteria at the primary ("Search First") source and if not the search continues with the secondary sources. If one search has encompassed the secondary sources, the next search (for another album) issued from another program will not stop at the primary sources if there is a file meeting the set criteria - then the search always continues. Is this the intended behaviour?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-18 11:15:54

No, that's not intended behaviour. I haven't been able to reproduce it here, though. What I did was:

* Have just one search window open, with the "Open search results in new window" box unchecked
* Have two scripts enabled, one with search first, one without.
* Use the command line to search for something I knew the search first one would not find, but the second one would. Note that results returned are only from the second source.
* Use the command line to search for something I knew would be found in both sources. Note that the results returned are only from the first source.
* Click the Extend Search button. Note that results from the second source are added.

If that's not what you are seeing, could you try keeping the source options open so you can see the "Search First" checkboxes while you do the searches, and tell me if they remain checked or not? It would be useful to know whether the problem is that the search first setting is being incorrectly changed by something, or if the setting is correct, but it's being ignored for some reason.

If you are passing any parameters other than just artist and album name on the command line, that would be useful to know too.

Alex
Title: Album Art Downloader XUI
Post by: performant on 2011-06-18 11:53:37
Could you check you are using version 0.2 of the chartstats script? If not, please download it directly from here: chartstats.boo (http://album-art.sourceforge.net/scripts/chartstats.boo) and put it in your scripts folder, overwriting the existing one.

Alex

Didn't even know I could download individual scripts.
Turns out that Chartstats 0.2 does not crash AAD. 
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-18 12:09:45
* Have just one search window open, with the "Open search results in new window" box unchecked
* Have two scripts enabled, one with search first, one without.
* Use the command line to search for something I knew the search first one would not find, but the second one would. Note that results returned are only from the second source.
* Use the command line to search for something I knew would be found in both sources. Note that the results returned are only from the first source.
* Click the Extend Search button. Note that results from the second source are added.


What I saw was results returned from the first and second source in the last two indents above (without having to press the Extend Search button). I was able to reproduce this behaviour several times before reporting the issue, but like you I was now unable to reproduce the issue. I have seen it many times before but not investigated until today. Finally the issue reappeared, and I could reproduce it 3 times with the same albums. Strange. Here is how:
* Have ADD closed
* Issue from another program a search for
Artist: The Lodger
Album: Life Is Sweet
Path: F:\MP3\Min musik\Artister\Lodger\Life Is Sweet (2008)\%preset%.%extension%

No files are found in the first source, but several in the second. - The Search First checkboxes are still checked.
* Without closing the search window issue from another program a search for:
Artist: Lolas
Album: Ballerina Breakout
Path: F:\MP3\Min musik\Artister\Lolas\Ballerina Breakout (1999)\%preset%.%extension%

Files from both the first and second source are returned.  - The Search First checkboxes are still checked. The first source that found a file was Local Files.

Closing ADD would always fix the issue, i.e. the next search would only return results from the first source.

I have Search First checked for some sources and unchecked for most sources.

I issue the search commands from J. River Media Center with this expression (for albums):
-artist "[Album Artist]" -album "[Album]" -path "[Filename (path)]%preset%.%extension%"
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-18 17:31:02

Thank you for the additional information. I still haven't been able to get it to happen here, though. Does it only happen if you have lots of sources enabled? You have the local files source set as search first, I think, so could you try just having that and one other source (not set as search first) enabled. It's a bit of a guess, really, but trying to find the minimal case that still shows the bug usually turns up clues as to what the problem is.

Also - just to check - it is definitely results for the new search that are showing, it's not that the second source hasn't been cancelled properly and is still returning results from the first search?
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-18 17:48:58
Using the same albums as before I could reproduce the issue (tried it 2 times). In the second search new results from the second source are shown (and the result from the first source); the results from the first search (for The Lodger) are cleared.

I am unable to reproduce the issue if I have only Local Files (with Search First checked) and Google Images (with Search First unchecked) enabled. I tried it several times.

Then I enabled all scripts again and tried to reproduce the issue (2 times), but was unable to.

Strange.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-18 18:00:38
Strange.

Yes, that it is. It sounds suspiciously like a timing problem of some sort, starting a new search before the old one has been properly cleared out (so it still thinks it's already done the search first sources) or something similar. Unfortunately, those sorts of issues are a nightmare to track down as the timings when I run searches won't be the same as when you do!
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-18 18:22:30
Strange.

Yes, that it is. It sounds suspiciously like a timing problem of some sort, starting a new search before the old one has been properly cleared out (so it still thinks it's already done the search first sources) or something similar. Unfortunately, those sorts of issues are a nightmare to track down as the timings when I run searches won't be the same as when you do!


For both the first and second search the first source search is obviously completely finished. I have tried before to invoke the second search both before and after the first search had completed the second source search and it did not make any difference. I have the option to never automatically download full-size images checked. I will get back to you if I stumble upon any further clue.

Thank you for trying to reproduce!

An unrelated issue: Would it be possible to exclude all words with an apostrophe (', like in Let's [Get It On]) when issuing the search to the web sources? At least the most useful sources will often not turn up any results if there is a word with an apostrophe in the search query.

http://www.emusic.com (http://www.emusic.com) has some high quality (Front) artwork (1,400x1,400) for especially indie artists, but I guess they are not possible to retrieve by a script.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-18 18:45:01
Would it be possible to exclude all words with an apostrophe (', like in Let's [Get It On]) when issuing the search to the web sources?

Most (possibly all, I don't remember) scripts strip out apostrophes from searches, so "Let's Get It On" would be passed as "Lets Get It On". This is because, experimentally, most sources do badly if you include them. Doing a bit of archaeology on this thread turns up this post (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=666612) which wasn't the start, or the end of the discussion, but probably one of the more informative ones. audio20 was very involved in bringing the character issue to my attention and testing the stripping solution, then he disappeared.

http://www.emusic.com (http://www.emusic.com) has some high quality (Front) artwork (1,400x1,400) for especially indie artists, but I guess they are not possible to retrieve by a script.

There doesn't appear to be a search function, unless I'm missing something? Maybe you have to be a member to search, but I'm not prepared to pay to find out. If you do, then a script would only be of any use to members, who would have to edit it to add their login credentials.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-18 19:02:05
Most (possibly all, I don't remember) scripts strip out apostrophes from searches, so "Let's Get It On" would be passed as "Lets Get It On". This is because, experimentally, most sources do badly if you include them. Doing a bit of archaeology on this thread turns up this post (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=666612) which wasn't the start, or the end of the discussion, but probably one of the more informative ones. audio20 was very involved in bringing the character issue to my attention and testing the stripping solution, then he disappeared.

Oh sorry, I did not know that this had already been discussed in depth. I just noticed that I got far better results when deleting all words with an apostrophe, and deleting any ", Vol. n" in the album name. Deleting any "and" also improved the search result (because many sources use the ampersand - & - instead).

http://www.emusic.com (http://www.emusic.com) has some high quality (Front) artwork (1,400x1,400) for especially indie artists, but I guess they are not possible to retrieve by a script.

There doesn't appear to be a search function, unless I'm missing something? Maybe you have to be a member to search, but I'm not prepared to pay to find out. If you do, then a script would only be of any use to members, who would have to edit it to add their login credentials.

The images are available to non members as well. You can search for an album and when you find it you click on the image (or the View Larger button) and often you then find a Download Hi-Res button. But I guess the files are on purpose buried too deep to be accessible by a script. Thanks for looking into it.

(PS. When looking for cover art it is better to not be logged in, because when you are logged in the results are location based, i.e. only the results for albums available in Europe (= generally far less then for someone in the U.S.) are shown if you reside in Europe.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-18 20:13:37
You can search for an album and when you find it you click on the image (or the View Larger button) and often you then find a Download Hi-Res button.
No, still not seeing it. Can you give me a link to the search page? Also, when I look at an album page by just clicking one of the entries in the Browse page, there's no "View Larger" button, and clicking on the image itself does nothing. Maybe it's IP geo-located or something.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-19 07:11:07
You can search for an album and when you find it you click on the image (or the View Larger button) and often you then find a Download Hi-Res button.
No, still not seeing it. Can you give me a link to the search page? Also, when I look at an album page by just clicking one of the entries in the Browse page, there's no "View Larger" button, and clicking on the image itself does nothing. Maybe it's IP geo-located or something.


Here is a link which is the result of a search for the artist Bon Iver http://www.emusic.com/search.html?mode=a&QT=Bon+Iver (http://www.emusic.com/search.html?mode=a&QT=Bon+Iver)

And here is a direct link to a high res image http://images.emusic.com/music/images/albu...5/1400x1400.jpg (http://images.emusic.com/music/images/album/0/114/779/11477985/1400x1400.jpg)

There is a search box top right on every page.

It could be a persistent cookie thing perhaps because I am clearly logged out but can still search etc.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-19 07:53:58
It could be a persistent cookie thing perhaps because I am clearly logged out but can still search etc.
Possibly. Either that or geo-ip, as using your search link I can see the search, but if I then click on Bon Iver, I get the message "We're sorry. There are no albums available for download in your country at this time.". I see no reason someone couldn't do a script for the site (although only being able to search by artist or by album, not by both, makes it trickier), but I don't think it can be me while my IP is not coming from the right country.

Alex
Title: Album Art Downloader XUI
Post by: dubwai on 2011-06-20 07:36:05
Thank you for feature that if cover with the same name already exist we can choose what to do. But scheme to save duplicate filename (n) it's not good, first of all xp explorer doen't sort this number properly. I want option to choose this scheme, because i already have hundreds of cover with %album%_%type%_%number% scheme and still save manual :-(

Also would be very good if add this shop: http://www.ebreggae.com It have both front and back cover for many albums. It's biggest reggae shop with covers, on it i found covers (front+back) whom i can't find anywhere else.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-20 18:14:29
i already have hundreds of cover with %album%_%type%_%number% scheme

To help me with thinking about possible designs for this, could you let me know if you always include the number, even on the first cover, and what number you start with? For example, do you have Album_Front.jpg, Album_Front_2.jpg - or maybe Album_Front_00.jpg, Album_Front_01.jpg? Or something else?

Also would be very good if add this shop: http://www.ebreggae.com

Here's a script: ebreggae.boo (http://album-art.sourceforge.net/scripts/ebreggae.boo). Please give it a try and let me know if you encounter any problems with it. (for others - in case it isn't obvious from the name, this site only finds reggae music, so if you don't have a large collection of reggae, there's not much point using it)

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-20 19:05:38
i already have hundreds of cover with %album%_%type%_%number% scheme

To help me with thinking about possible designs for this, could you let me know if you always include the number, even on the first cover, and what number you start with? For example, do you have Album_Front.jpg, Album_Front_2.jpg - or maybe Album_Front_00.jpg, Album_Front_01.jpg? Or something else?


If you ask me: The most important thing is that the sorting in Windows Explorer reflects the order in which images of the same type (Booklet, Inside etc.) were downloaded (because, as stated before, a software I use rely on that order). Since I am still waiting for a software that will automatically display other cover art than the front based on "standard" file names (Back.jpg, Inside.jpg, Inlay.jpg, Booklet.jpg and CD.jpg), it would be best if the file downloaded first (i.e. normally the most important one) did not have any number. PS. And many programs use folder.jpg or cover.jpg (no number) as default for the cover art to display.

The most common case in which you would download multiple images of the same type is with Booklet. It would speed up my work flow considerably if you could introduce a Booklet type in AAD. As it is now I have to use the little arrow and choose my Booklet preset, then press down arrow to get to the new auto numbering feature and finally press enter.  Being able to just click the 20 or so booklet images for an album in the correct order and have them automatically numbered would be great.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-20 19:41:36
introduce a Booklet type in AAD
Are there any sources in which it is possible to automatically identify images as such? As in, if you do the search on their website, could you tell from the text which images are 'booklet'? Are they distinct from those that are already identified as "Inside" (previously "Inlay")? The current types are set so you have art on the front and back of the outside of the box, art on the inside of the box, and art printed on the CD itself. I would assume that booklet images would therefore be of Inside type, but if there are sites that provide further distinction, then a further distinction could be made, and the scripts for those sites updated.

I already know that your numbering scheme is different for the first and subsequent covers, starts numbering at 1, and has no leading zeroes. I was asking dubwai so I'd have another data point. I could, for example, add an Options link to the Overwrite dialog which would give you a formatting box to customise the suggested name format, something like "%filename% (%n2%).%extension%" for the current default. That wouldn't be much help if the first cover should also contain a number, though. If enough people agree on what the starting number should be, it could make the pattern simpler too as that wouldn't need to be included. If there's a requirement to be able to put numbers in the middle of the name, not just the start or end (so "album-01-front.jpg", for example), then a whole new design would be needed. I suspect there probably isn't, personally.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-20 21:30:34
Are there any sources in which it is possible to automatically identify images as such? As in, if you do the search on their website, could you tell from the text which images are 'booklet'? Are they distinct from those that are already identified as "Inside" (previously "Inlay")? The current types are set so you have art on the front and back of the outside of the box, art on the inside of the box, and art printed on the CD itself. I would assume that booklet images would therefore be of Inside type, but if there are sites that provide further distinction, then a further distinction could be made, and the scripts for those sites updated.


On Cover Paradise, which is usually the most useful source, Booklet is in the file name and displayed on the web page. I think it is the same on AllCDCover, but I am not sure.

In the case of a 40 page booklet at least an option to bulk change the type for selected images (20 of them) to Booklet would be useful.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-21 10:43:06
When the artist and the album names are the same (i.e. Paul Simon - Paul Simon or Paul Weller - Paul Weller) no results for the correct album turns up in ADD although the album exists on at least Cover Paradise.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-21 11:34:04
About emusic script; one could use google search:

1) search google e.g.: site:emusic.com/album/ "foo fighters" "the Colour and the Shape"

2) select the first search result link which starts with http://www.emusic.com/album/ (important as the first google result is an article of some sort)

3a) go to the link (http://www.emusic.com/album/Foo-Fighters-The-Colour-And-The-Shape-MP3-Download/12218346.html) -> show image (http://images.emusic.com/music/images/album/0/122/183/12218346/300x300.jpg) -> edit image link (http://images.emusic.com/music/images/album/0/122/183/12218346/1400x1400.jpg).

OR

3b) copy the link URL in step 2 from google search results page (http://www.emusic.com/album/Foo-Fighters-The-Colour-And-The-Shape-MP3-Download/12218346.html) -> make the final 1400px image link manually (http://images.emusic.com/music/images/album/0/122/183/12218346/1400x1400.jpg)

Works. Dunno how easily you can do this with BOO though.

EDITS in red.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-21 15:11:56
When the artist and the album names are the same (i.e. Paul Simon - Paul Simon or Paul Weller - Paul Weller) no results for the correct album turns up in ADD although the album exists on at least Cover Paradise.


At least this seems true when the artist and album name consists of two words. ADD managed to find the album Petter by Petter.

(Sorry for the extra post, but the edit button seems to have disappeared for my in the forums.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-21 18:28:25
On Cover Paradise, which is usually the most useful source, Booklet is in the file name and displayed on the web page. I think it is the same on AllCDCover, but I am not sure.
Fair enough, for Cover Paradies. AllCDCover seems to have "Inlay" and "Inside", but I'm not sure if either of those are booklet. Next version I'll add a Booklet type, and update the Cover Paradies site to match: tracker (https://sourceforge.net/tracker/?func=detail&aid=3324108&group_id=187008&atid=919578).

When the artist and the album names are the same (i.e. Paul Simon - Paul Simon or Paul Weller - Paul Weller) no results for the correct album turns up in ADD although the album exists on at least Cover Paradise.

At least this seems true when the artist and album name consists of two words. ADD managed to find the album Petter by Petter.
This isn't an AAD thing, it's a Cover-Paradies thing: Paul Simon Paul Simon (http://cover-paradies.to/?Module=ExtendedSearch&StartSearch=true&PagePos=0&SearchString=Paul%20Simon%20Paul%20Simon&StringMode=Wild&DisplayStyle=Text&HideDetails=Yes&PageLimit=1000&SektionID-2=Yes). Doing some experimentation with the search field it looks like you get better results with a query of "artist - album", so here's an experimental cover-paradies.boo (http://www.byalexv.co.uk/foobar/cover-paradies.boo) that uses that scheme. I'd appreciate it if you use it for a while and let me know if you encounter any cases where it fails or gives noticeably worse results than before.

About emusic script; one could use google search [...] Works. Dunno how easily you can do this with BOO though.
Interesting! A hybrid google/emusic search, and I can even get the large size images without geo-ip restriction. It won't show me links to them at all, but will let me download the image using the guessed URL. Nice. The whole scheme is a little fragile, but they are very nice covers so I think it's worth having a script while it works! Please give it a try: emusic.boo (http://album-art.sourceforge.net/scripts/emusic.boo). If everything seems OK after a couple of days, I'll include it in the online updates and bundle it with the next installer.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-21 18:59:59
Thanks, Alex!

You are very responsive, active and fast! I will prepare a list of other minor things and ideas in case you can find inspiration from them. 

The Booklet thing in the next version will make my life easier! And an automatic numbering preset will make life even better.

The new Cover Paradise script seems after a couple of searches to give more accurate results when searching for albums with the same name as the artist (irrespective of the artist/album name having only one or several words). I will have to test more to make sure that the results for "normal" albums have not deteriorated though.

@Akkurat Re: eMusic: Clever!

The eMusic (that is the way they like to write their name) script does not work for me. It does not find anything. Have you managed to find something?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-21 19:27:56
The eMusic (that is the way they like to write their name) script does not work for me. It does not find anything. Have you managed to find something?
Yes, it works for me. As I said, it's a bit of a fragile script, but if we can figure out what's different between what you get and what I do, I might be able to improve it.

Using a browser with no existing cookies for emusic or google, and with javascript turned off, visit: google query (http://www.google.com/search?q=site%3Aemusic.com%2Falbum%2F+%22foo+fighters%22+%22the+Colour+and+the+Shape%22), then do a View Source and search in the text for: href="http://www.emusic.com/album/Foo-Fighters-The-Colour-And-The-Shape-MP3-Download/12218346.html"
If that isn't present, then just search for href="http://www.emusic.com/album and see in what way it differs from the URL I'm looking for.

If it is present, then the google part is working OK, so time to check the eMusic part. Try visiting: thumbnail (http://images.emusic.com/music/images/album/0/122/183/12218346/300x300.jpg) and fullsize (http://images.emusic.com/music/images/album/0/122/183/12218346/1400x1400.jpg) and see if they show up OK.

If that all works, but it doesn't work for a different artist or album you're looking for, then let me know the search terms and I'll try it here.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-21 19:40:59
OK thanks, I will try to try that out, but I will be busy for a while and will report back tomorrow (Swedish time).

Below is the enhancement idea list message I was typing while I got your immediate response:

Alex,

I have used your excellent software extensively in the last couple of weeks and enjoyed it immensly. I have some 9,000 albums (many singles though) and still have a couple of thousand left to search complete cover art for. It is hard work, but someone with a compulsive obssesive disorder has to do it .

Here are a couple of enhancement ideas, in addition to what I have already said, in case you will find any inspiration from them. In no particular order:
a)   If at all possible to group and sort by web page found. This way the results from Cover Paradise could be grouped according to which album entry they belong to.
b)   Make it possible to highlight one or more source scripts to have only the results from that or those sources shown. This would be much easier than to temporarily group by source. This would of course also require some way of again showing the results from all sources.
c)   Make it possible to have presets of sources and make the presets accessibly via a command line switch.
d)   Make it possible (an option) to always show local files on top of a scrollable list with other results so that you always can compare your current files with what is available on the internet.
e)   Make it possible (an option) to automatically convert non .jpg files to .pg files upon download.
f)   Make it possible (a right click context menu perhaps) to issue a command to automatically download full-size images from one source and make it possible (an option perhaps) to group all Amazon sources into one source.
g)   Have all Amazon scripts grouped together in the right hand menu and make the head Amazon entry expand and show all the different Amazon scripts. That way the list of sources will not be cluttered. Make it possible to change the settings for all Amazon swcripts in one go (from the head AMazon entry perhaps).
h)   Make it easier to toggle the size filtering on and off.
i)   Have some visual indication showing if a script is set to be a Searsh First script or not. And perhaps have a visual indication of how many results will be returned from the source and if they will be downloaded automatically in full size or not.
j)   Why not sort the Sources list to the right according to how many results a script returned? That way you will see which scripts generated the results if you use many scripts.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-21 20:36:30

Thanks for your suggestions list. There's a lot there, and while they are good ideas, chances are I simply won't have the time to implement them any time soon, so I've made trackers for them so that they won't be forgotten.

A few specific answers:
c) A request for preset combinations of sources already exists (ref (https://sourceforge.net/tracker/?func=detail&aid=2796922&group_id=187008&atid=919578)), but if you are using the command line then you can already specify a list of sources to use with the /sources parameter, which does the same job as a preset.

d) I can see the benefit of this, and have added a tracker, but it would be a *lot* of work, and almost certainly won't happen.

e) A feature to allow the user to set custom image post processing steps to take place on save is something that I've wanted for a while; conversion of format would be one of the options available, along with resizing, saving additional copies, and possibly embedding. It's a big feature, but if I ever get a significant chunk of time to devote to development, it's one I'd like to see go in.

f) I don't really understand why you would need this. If a source doesn't produce acceptable thumbnails, then set that source to always download fullsize images (which also saves it having to bother with the thumbnails at all). Can you explain a bit more why a command to get all fullsize images for a just one source would be useful?

g) (and f part 2) Not going to happen. The amazon sources aren't really intended to all be used at the same time, the idea is you install the one that matches your region, and use that. There's so much overlap that doing the same search on multiple amazon sites is usually a waste of time.

For what it's worth, the most likely to be implemented any time in the near future are a) h) i) and possibly j) (although I'm not entirely convinced by j yet).

Alex
Title: Album Art Downloader XUI
Post by: dubwai on 2011-06-22 07:28:52
i already have hundreds of cover with %album%_%type%_%number% scheme

To help me with thinking about possible designs for this, could you let me know if you always include the number, even on the first cover, and what number you start with? For example, do you have Album_Front.jpg, Album_Front_2.jpg - or maybe Album_Front_00.jpg, Album_Front_01.jpg? Or something else?

My scheme is
Front1: %album%
Front2: %album%_2
FrontN: %album%_N
Back1: %album%_back
Back2: %album%_back_2
BackN: %album%_back_N
...
CDn: %album%_disc_n
...
InsideN: %album%_disc_N

So first without number then next with _%number% start from 2.

Here's a script: ebreggae.boo (http://album-art.sourceforge.net/scripts/ebreggae.boo). Please give it a try and let me know if you encounter any problems with it. (for others - in case it isn't obvious from the name, this site only finds reggae music, so if you don't have a large collection of reggae, there's not much point using it)

Ohh thanks seem all works fine. You save me a lot of time. And I agree with you that is good source only for reggae fans, but when you install albumartdownloader you can choose Asian, psy etc additional plugins, maybe create reggae dir and put this scripit to it :-)

Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-22 08:00:03
So first without number then next with _%number% start from 2.
[...]when you install albumartdownloader you can choose Asian, psy etc additional plugins, maybe create reggae dir and put this scripit to it :-)

Yes, I will do - and thanks for the info on your numbering system.

It looks like, for the next version, I'll put an Options link in the Overwrite dialog which would let you specify the pattern for the suggestion, and your pattern would be "%filename%_%n2%.%extension%". I'm hoping to do it this weekend.

Alex
Title: Album Art Downloader XUI
Post by: dubwai on 2011-06-22 09:42:54
So first without number then next with _%number% start from 2.
[...]when you install albumartdownloader you can choose Asian, psy etc additional plugins, maybe create reggae dir and put this scripit to it :-)

Yes, I will do - and thanks for the info on your numbering system.

It looks like, for the next version, I'll put an Options link in the Overwrite dialog which would let you specify the pattern for the suggestion, and your pattern would be "%filename%_%n2%.%extension%". I'm hoping to do it this weekend.

Alex

It's great thanks.
Also I'll want that if you can add this site to search covers: http://www.roots-archives.com (http://www.roots-archives.com) it contain's only reggae and no hi-res but it's very useful because it have back covers and covers of sides vinyl with tracklists.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 10:01:33
Thank you for your response!

f) I don't really understand why you would need this. If a source doesn't produce acceptable thumbnails, then set that source to always download fullsize images (which also saves it having to bother with the thumbnails at all). Can you explain a bit more why a command to get all fullsize images for a just one source would be useful?


I was thinking of the situation where I have only very small (say 200x200 or 350x350) Front cover art for an album. Then I would like to use all available sources to find at least a slightly larger file. I would then like to be able to download all images from Amazon (because they are mostly from only the correct album) to see the dimensions. I have found that the dimensions on Amazon sites can differ. Now I have to click on every hit from an Amazon site to see the dimensions.

But I guess I can just set all Amazon scripts, one by one (since there is no way now to change settings for several scripts at once) to always download the full size image.

Regarding d), would it be possible to at least make a clear visual indication of which results are local files (in addition to the group by sources option)?
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 10:19:10
The eMusic (that is the way they like to write their name) script does not work for me. It does not find anything. Have you managed to find something?
Yes, it works for me. As I said, it's a bit of a fragile script, but if we can figure out what's different between what you get and what I do, I might be able to improve it.

Using a browser with no existing cookies for emusic or google, and with javascript turned off, visit: google query (http://www.google.com/search?q=site%3Aemusic.com%2Falbum%2F+%22foo+fighters%22+%22the+Colour+and+the+Shape%22), then do a View Source and search in the text for: href="http://www.emusic.com/album/Foo-Fighters-The-Colour-And-The-Shape-MP3-Download/12218346.html"
If that isn't present, then just search for href="http://www.emusic.com/album and see in what way it differs from the URL I'm looking for.

If it is present, then the google part is working OK, so time to check the eMusic part. Try visiting: thumbnail (http://images.emusic.com/music/images/album/0/122/183/12218346/300x300.jpg) and fullsize (http://images.emusic.com/music/images/album/0/122/183/12218346/1400x1400.jpg) and see if they show up OK.

If that all works, but it doesn't work for a different artist or album you're looking for, then let me know the search terms and I'll try it here.

Alex


All tests passed both on my "normal" PC with Javascript enabled and cookies present and on another PC with Javacript disabled and no cookies at all. But the ADD script does not find anything. I tried to search for Foo Fighters - The Colour and the shape and EMILIANA TORRINI - Love in the Time of Science (http://www.emusic.com/album/Emiliana-Torri...d/10992472.html (http://www.emusic.com/album/Emiliana-Torrini-Love-in-the-Time-of-Science-MP3-Download/10992472.html)) among others.

PS. You do know that there is a 600x600 option as well on eMusic.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 10:24:53
It looks like, for the next version, I'll put an Options link in the Overwrite dialog which would let you specify the pattern for the suggestion, and your pattern would be "%filename%_%n2%.%extension%". I'm hoping to do it this weekend.


If you introduce options in the Overwrite dialog, then you could perhaps consider adding also an option to make autonumbering the default. This would save one mouse click for each Booklet downloaded (apart from the first one of course).
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 11:20:00
The new Cover Paradise script seems after a couple of searches to give more accurate results when searching for albums with the same name as the artist (irrespective of the artist/album name having only one or several words). I will have to test more to make sure that the results for "normal" albums have not deteriorated though.


The new Cover Paradise script returns no results when searching for "Rainbow - Long Live Rock Roll", but returns several results when searching for "Rainbow - Long Live Rock 'n' Roll". It is the same with "Randy Crawford - Naked True" and "Randy Crawford - Naked and True".

But "Ray Charles - Modern Sounds in Country and Western Music" finds nothing, while "Ray Charles - Modern Sounds in Country Western Music" does.

"The Red Hot Chili Peppers - By the Way" produces no results, but "Red Hot Chili Peppers - By the Way" does.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-22 13:22:37
I would then like to be able to download all images from Amazon (because they are mostly from only the correct album) to see the dimensions.
This is what the "only when size is unknown" option for automatically downloading images was intended for.

Regarding d), would it be possible to at least make a clear visual indication of which results are local files (in addition to the group by sources option)?
I thought the label on them saying "Source: Local files" was pretty clear.

PS. You do know that there is a 600x600 option as well on eMusic.
I've updated the emusic.boo (http://album-art.sourceforge.net/scripts/emusic.boo) script, could you try again with this one? I didn't know there was also a 600x600 option, no. But surely the 1400x1400 one would be the one to go for, though?

If you introduce options in the Overwrite dialog, then you could perhaps consider adding also an option to make autonumbering the default.
I considered a "Don't ask me again" checkbox, but the problem with that is that if you check it, how do you ever get back to the Overwrite dialog to change your mind, or change the numbering pattern?

Thanks for these results. It looks like using the "artist" - "album" scheme for searching cover-paradies makes it much stricter. On the one hand, this means that you can search for albums where the artist and album name are the same without it returning all the albums for that artist, but on the other it means that if your title doesn't exactly match theirs, you might not find anything at all. I'm not sure what the best way to go here would be.

Alex
Title: Album Art Downloader XUI
Post by: Ghostdivision on 2011-06-22 13:39:55
I really like this app, but only thing missing for me. Would their be any way to automate it easily so maybe through windows task scheduler every couple days it runs at a certain time. I know how to set up tasks but im unaware how i would make it update and automatically search my files, and download and save album art?
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 13:50:10
Thanks for the replies!

This is what the "only when size is unknown" option for automatically downloading images was intended for.

Aha!

I thought the label on them saying "Source: Local files" was pretty clear.

Yes clear but small and not so easy to spot among all the other results. I was thinking more along the lines of a different background colour for local files.

I've updated the emusic.boo (http://album-art.sourceforge.net/scripts/emusic.boo) script, could you try again with this one? I didn't know there was also a 600x600 option, no. But surely the 1400x1400 one would be the one to go for, though?

I will try it out. Yes, big is beautiful and hard drives and big screens are cheap.

I considered a "Don't ask me again" checkbox, but the problem with that is that if you check it, how do you ever get back to the Overwrite dialog to change your mind, or change the numbering pattern?

How about a tooltip when hovering over the save button instructing the user to ctrl click to see more options, i.e. change the default option or have the dialog shown each time?

I would however like to be able to see if a file with the same name already exists. I suggested before (in the feature tracker) that the save icon could turn red in this case. An alternative, if you do not want to check for file existence  for every result, would be to have a visual (a "blink") or audible indication upon saving when there is a already a file with the same name; the result would still be saved according to the option set, but then you would at least be notified after the fact and able to correct if necessary (unless you had the option to overwrite checked, of course).

Thanks for these results. It looks like using the "artist" - "album" scheme for searching cover-paradies makes it much stricter. On the one hand, this means that you can search for albums where the artist and album name are the same without it returning all the albums for that artist, but on the other it means that if your title doesn't exactly match theirs, you might not find anything at all. I'm not sure what the best way to go here would be.

Would it be possible to have two scripts for Cover Paradise? Is it possible to filter out duplicates in the result list?
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 14:00:08
I've updated the emusic.boo (http://album-art.sourceforge.net/scripts/emusic.boo) script, could you try again with this one? I didn't know there was also a 600x600 option, no. But surely the 1400x1400 one would be the one to go for, though?


I tested the new script and the two albums I tried before were not found by the script, nothing was found like before.

I think the version number (0.1) was the same for the old and the new script. I hope I did not make any mistake when installing.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-22 18:13:27
Would their be any way to automate it easily so maybe through windows task scheduler every couple days it [...] automatically search my files, and download and save album art?
You can certainly set it to automatically search your files; use the /fileBrowser command line parameter. Either on its own, or with the path you want it to search. You can't start the auto-downloader from the command line, though, sorry. There is no way to have Album Art Downloader download art files without any user interaction. There is the command line tool aad.exe which can do that, but you have to give it the specific album and artist to search for, it doesn't have any equivalent of the FileBrowser functionality.

How about a tooltip when hovering over the save button instructing the user to ctrl click to see more options, i.e. change the default option or have the dialog shown each time?
No, I don't like that. It's all a bit weird, no-one would think of that being the way to change the filename used to avoid overwrites, or to re-show the dialog.

I would however like to be able to see if a file with the same name already exists.
That wouldn't happen if an option to overwrite automatically was turned on. I just don't think that overwrite by default is going to work out. There needs to be a check made on saving, and that is the time to notify the user if the file already exists. The Overwrite warning dialog is the way to do it.

Would it be possible to have two scripts for Cover Paradise? Is it possible to filter out duplicates in the result list?
No, but what I can do is have the script search first with the strict query scheme, then if that returns no results, try it again with the original looser one. I think that works quite well. It still doesn't find Ray Charles - Modern Sounds in Country and Western Music, but then I can find that using any variation in the web page search either.

I think the version number (0.1) was the same for the old and the new script. I hope I did not make any mistake when installing.
Hmm. I didn't change the number, but the newer version is called eMusic instead of EMusic (as you pointed out), so you can check by that. If sourceforge is still giving you the old one, try viewing it then using Shift-F5 in your browser to force a refresh. Also, AAD should show the Compiling spashscreen the first time you run it after replacing the script - if it doesn't, it didn't notice the replacement.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 18:51:37
No, I don't like that. It's all a bit weird, no-one would think of that being the way to change the filename used to avoid overwrites, or to re-show the dialog.

How about a small gearwheel icon right under the save icon to bring up all options that has to do with saving files, i.e. the save images path (from the regular options part), the edit presets dialog (from the dropdown menu) and the default behaviour when a file already exists, including the announced custom numbering option? Or extend the existing options with a link to edit presets and a "What to do when a file already exists" option ("Overwrite", "Save under a different name", "Manually choose location and file name" and "Always ask") with the announced custom numbering option (indented) below ("File naming scheme for duplicates").

No, but what I can do is have the script search first with the strict query scheme, then if that returns no results, try it again with the original looser one. I think that works quite well. It still doesn't find Ray Charles - Modern Sounds in Country and Western Music, but then I can find that using any variation in the web page search either.

Great! Would removing all the words "the", "and", "a", "le", "la" and, for Swedish, "en" and "ett" work?

Hmm. I didn't change the number, but the newer version is called eMusic instead of EMusic (as you pointed out), so you can check by that. If sourceforge is still giving you the old one, try viewing it then using Shift-F5 in your browser to force a refresh. Also, AAD should show the Compiling spashscreen the first time you run it after replacing the script - if it doesn't, it didn't notice the replacement.

The web page had not refreshed. Now it works. Excellent! I will report any issues I encounter.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 19:08:03
The new eMusic script seems to generate too many hits. Try "Shaggy - Hot Shot", for example.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-22 19:34:07
Great! Would removing all the words "the", "and", "a", "le", "la" and, for Swedish, "en" and "ett" work?
I'm not going to have it automatically remove words. There's no way to be sure that they aren't important, and if the script removes them then there would be no way of searching for them. Can you imagine trying to search for albums by The The (http://en.wikipedia.org/wiki/The_The)?

The new eMusic script seems to generate too many hits. Try "Shaggy - Hot Shot", for example.
Looks about right to me. It matches what comes back from the google search (http://www.google.com/search?q=site%3Aemusic.com%2Falbum%2F+%22Shaggy%22%20%22Hot%20Shot%22), and the correct album is the first result. Set the max results to 1 or 2 and you should get less irrelevant one.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-22 19:45:28
Great! Would removing all the words "the", "and", "a", "le", "la" and, for Swedish, "en" and "ett" work?
I'm not going to have it automatically remove words. There's no way to be sure that they aren't important, and if the script removes them then there would be no way of searching for them. Can you imagine trying to search for albums by The The (http://en.wikipedia.org/wiki/The_The)?

OK, but how about a last resort search with the less strict search method and those words removed?

Looks about right to me. It matches what comes back from the google search (http://www.google.com/search?q=site%3Aemusic.com%2Falbum%2F+%22Shaggy%22%20%22Hot%20Shot%22), and the correct album is the first result. Set the max results to 1 or 2 and you should get less irrelevant one.

OK, will do. Thanks for this script!
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-23 09:17:44
Sometimes the eMusic script reports a 1400x1400 image, but when you click on that result it turns out to be only 300x300.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-23 13:09:44
Sometimes the eMusic script reports a 1400x1400 image, but when you click on that result it turns out to be only 300x300.
If the full size image is not available, it will fall back on the thumbnail. I don't know why the full size image wouldn't be available from eMusic for some albums, perhaps you could look at the album page and find out? I can't, as it doesn't show full size images for *any* of them for me!

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-23 13:15:18
Sometimes the eMusic script reports a 1400x1400 image, but when you click on that result it turns out to be only 300x300.
If the full size image is not available, it will fall back on the thumbnail. I don't know why the full size image wouldn't be available from eMusic for some albums, perhaps you could look at the album page and find out? I can't, as it doesn't show full size images for *any* of them for me!


eMusic does not have images, or 1400x1400 images, for all albums. I do not know why.

If the script cannot find a 1400x1400 image, you could perhaps change the size reported by the script to reflect the page/file (600x600 or 300x300) you retrieved it from.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-23 13:54:39
If the script cannot find a 1400x1400 image, you could perhaps change the size reported by the script to reflect the page/file (600x600 or 300x300) you retrieved it from.
It does. Of course it doesn't actually know that it can't find the image until it tries to download it (there's no other way to tell), but at that point if the image can't be downloaded it will update the reported size to be the actual size of the image that it has. The only thing I could do is remove the estimated 1400x1400 size altogether, and just leave it as 'unknown' until an attempt is made to download the full size image, but I think if there are only a very few that don't have full sizes available it's better to leave it as it is.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-23 14:00:00
If the script cannot find a 1400x1400 image, you could perhaps change the size reported by the script to reflect the page/file (600x600 or 300x300) you retrieved it from.
It does. Of course it doesn't actually know that it can't find the image until it tries to download it (there's no other way to tell), but at that point if the image can't be downloaded it will update the reported size to be the actual size of the image that it has. The only thing I could do is remove the estimated 1400x1400 size altogether, and just leave it as 'unknown' until an attempt is made to download the full size image, but I think if there are only a very few that don't have full sizes available it's better to leave it as it is.

Alex

OK, then it is probably best to leave it as it is. Is there a way to trigger the secondary search if the only file that met the search criteria was a 1400x1400 eMusic image that turned out to actually be below the threshold set?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-23 14:38:22
OK, then it is probably best to leave it as it is. Is there a way to trigger the secondary search if the only file that met the search criteria was a 1400x1400 eMusic image that turned out to actually be below the threshold set?
Automatically? Only by setting eMusic to download full size images only, that way the size will always be accurate for them. You can always do it manually by hitting the Search button a second time (it will be labelled "Extend Search"), if the results you thought were good enough turned out not to be.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-25 10:11:19
If the script cannot find a 1400x1400 image, you could perhaps change the size reported by the script to reflect the page/file (600x600 or 300x300) you retrieved it from.
It does. Of course it doesn't actually know that it can't find the image until it tries to download it (there's no other way to tell), but at that point if the image can't be downloaded it will update the reported size to be the actual size of the image that it has. The only thing I could do is remove the estimated 1400x1400 size altogether, and just leave it as 'unknown' until an attempt is made to download the full size image, but I think if there are only a very few that don't have full sizes available it's better to leave it as it is.

Hi Alex, sorry about the late reply, I had my main computer offline for few days.

The eMusic script seems to work ok for me.

Though when it doesn't find 1400px images, it falls back to 300px although there is 600px image available. Could you fix the script to get the 600px instead if it exists?

Example search: Shaggy - Hot Shot = there is this "Dino Brown & Hastyle - Gangland" (http://www.emusic.com/album/Dino-Brown-Hastyle-Gangland-MP3-Download/12442658.html) album result that hasn't got a 1400px image, but it has 600px image.

Example 2 search: foo fighters - the Colour and the Shape = Jeff Timmons - Whisper That Way (http://www.emusic.com/album/Jeff-Timmons-Whisper-That-Way-MP3-Download/11830210.html) album with 600px image only (in addition of the normal 300px).

Some of the big 1400px images seem to be "only" ~1400x1395px (EDIT: e.g. the "shaggy" search above has actual images ranging from 1400x1377 to 1400x1391).. maybe you should put the script to report image sizes as unknowns?

Thanks for the work. I have many other cover image sites in my browser bookmarks (I intended to write the scripts myself someday, but I've abandoned that idea (I'm heavily cutting down my "to-do" things one way or the other)), I'll try to wrap them up and present those to you soon.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 10:53:14
Could you fix the script to get the 600px instead if it exists? [...] maybe you should put the script to report image sizes as unknowns?
Thanks for the examples; using those I've updated emusic.boo (http://album-art.sourceforge.net/scripts/emusic.boo) v0.2 to fall back on 600x600 before 300x300. I suppose with such a range of sizes, it will have to report 'unknown' size, which is a shame.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 11:09:29
Thanks for the new eMusic script!

One small thing I noticed with the file browser: The "Select all albums with missing artwork" is triggered not only when clicking the text but also if you click in the lower part of the screen. I experienced strange "freezes" when switching to the file browser and finally found out that it was because I had clicked in the lower part of the window (far away from the text) and AAD tried for a minute or so to do that selection on my many folders.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 11:28:09
The "Select all albums with missing artwork" is triggered not only when clicking the text but also if you click in the lower part of the screen.

Good spot, that will be fixed (and in Foobar browser too) in this weekend's 0.40 release.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 11:43:06
Thanks!

I just noticed that there is a similar issue with the Select all option in the search window. That could explain why all sources would sometimes get deselected.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-25 13:22:06
Could you fix the script to get the 600px instead if it exists? [...] maybe you should put the script to report image sizes as unknowns?
Thanks for the examples; using those I've updated emusic.boo (http://album-art.sourceforge.net/scripts/emusic.boo) v0.2 to fall back on 600x600 before 300x300. I suppose with such a range of sizes, it will have to report 'unknown' size, which is a shame.

Doesn't work. I still get 1400x1400px info for all the images (e.g. in the "shaggy" search). Previewing the images changes the sizes for the images that aren't 1400px. So "unknown" isn't reported. Also I don't get 600px images at all for the 2 examples I wrote earlier.

I definitely have the 0.2 version of the script.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 16:21:14
Save a file using with the same name as an existing file and accept the autonumbering suggestion, say Back (2).jpg.
Save the same file again using a preset, say Inlay to get an Inlay.jpg file. This time you are informed that a file with the name Back (2).jpg exists and presented with the option to save the file as Back (2) (2).jpg.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 16:39:41
Doesn't work.
I have *got* to come up with a better system for uploading these experimental scripts. That's the second time that what's ended up on Sourceforge is an older version of the script than the one I intended. If you try it again (http://album-art.sourceforge.net/scripts/emusic.boo), making sure it's refreshed, it should work. Just in case, the md5 is e000f0335e83e30752ea8b3fc1ece6b4, but basically, if it isn't showing sizes as Unknown, then it isn't the right version.

Save a file using with the same name as an existing file and accept the autonumbering suggestion, say Back (2).jpg.
Save the same file again using a preset, say Inlay to get an Inlay.jpg file. This time you are informed that a file with the name Back (2).jpg exists and presented with the option to save the file as Back (2) (2).jpg.
That's an interesting case. If you save a file, and due to overwrite renaming (or using save as), you save it with a non-default name, then the filename for that result is set to the name you saved it as. I'm pretty sure that's the best behaviour here.

Using presets just replaces the %preset% placeholder in the name of the file before saving. As the name of the file (that you've already saved) doesn't have %preset% in it any more (it has no placeholders at all, it is a concrete filename), there's nowhere for the placeholder to go. So, it tries to save exactly "Back (2).jpg", finds that that file already exists, so offers you the automatic suggestion of appending " (2)" to the filename.

I think the best solution here would be that if you choose a preset from the menu, then it ignores the filename that's been assigned to the art, and just uses the default (with the %preset% placeholder substituted, of course). Either way someone's likely to get confused, but I think this would be the correct behaviour for what is probably the more common use case.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 16:49:32
I think the best solution here would be that if you choose a preset from the menu, then it ignores the filename that's been assigned to the art, and just uses the default (with the %preset% placeholder substituted, of course). Either way someone's likely to get confused, but I think this would be the correct behaviour for what is probably the more common use case.


Yes, that seems to be the correct behaviour in  my opinion. If you choose to save as [a preset name] then I would expect the file to be saved using that preset. If i double click on the thumbnail again I would expect the file to be saved with the presented name (and have the overwrite dialog opened).

Would it be possible to load a script even though a file browser window is open? I ask because it takes ages for AAD to scan all my folders.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 16:58:14
Would it be possible to load a script even though a file browser window is open? I ask because it takes ages for AAD to scan all my folders.

Sorry, no. The script compiling only happens at startup. The only thing I can suggest is maybe to open only some of your folders? You can just drag and drop a selection of them from Windows Explorer onto the filebrowser.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-25 17:52:54
Now it (eMusic) works like a dream! THANKS again Alex.

Here's quickly one new source: http://www.qobuz.com/ (http://www.qobuz.com/)

Example search (http://www.qobuz.com/recherche?q=foo+fighters+the+Colour+and+the+Shape&i=boutique), just get the 100px image source from the search result page (http://static.qobuz.com/images/jaquettes/0828/0828765549523_100.jpg) and change it to 600px (http://static.qobuz.com/images/jaquettes/0828/0828765549523_600.jpg). No bigger images.. I think. But, at least with this example, the other 600px image from the search is in very good quality, better than in eMusic.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 18:00:18
I tried to reload a large part of my music with the file browser. As I said it took a very long time to scan all folders, I seem to remember AAD reporting some 7,000 or 8,000 albums the last time the scan had completed. When all albums had been read the computer just stalled (became completely unresponsive, not even the mouse pointer moved) for say 5 minutes then the PC just crashed (like a blue screen, but without the blue screen, the PC just shut off). I am on Win 7 64 bit on an i7 2.80 GHz 8 GB PC. Many other programs/windows were open but they were not doing anything heavy.

Could anything be done about this?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 19:02:09
Now it (eMusic) works like a dream! THANKS again Alex.

Here's quickly one new source: http://www.qobuz.com/ (http://www.qobuz.com/)

Great, thanks for letting me know! qobuz looks pretty good, has a wide range of stuff (so I think can just be a general script installed by default, rather than one of the speciality ones) - I'll knock together a script for that as soon as I get a chance.

When all albums had been read the computer just stalled

Ouch, that's nasty. I don't actually have 7,000 real albums to test with, but have tested it with 10,000 simulated random albums and it didn't show any signs of stressing my system (CPU usage max 20% during art-finding, final memory usage 250Mb. I run a Core i5 750, Win 7 64, 8Gb ram). What is interesting is that you say it occurs only after the scan completes? Almost everything the file browser does, it does threaded so that albums are added to the list as they are discovered, and art status is set on items already in the list as they are found (or not found). The point is, if it was a case of running out of resources of some kind (most likely memory, but not necessarily), I'd expect it to happen at some arbitrary point during the scan.

The only thing that does happen only after all the music has been loaded is the step to automatically detect various artists albums. This has to categorise all the albums found into the folders they were found in. To get a better idea of what's going on, can you confirm that the stall does happen after the scan completes, not just a long way into it? If you're willing to help test, could you try letting it run until it nearly completes (say 6500 or so?), then hit Stop. This will prevent it from running the various artists detection, but if it still stalls at that point something else is going on. While it's running, if you could cast an eye on the AlbumArt.exe process using the Task Manager every so often and check it isn't using silly amounts of CPU or memory, that would be useful to know too.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 19:18:15
OK, will test. But it will take some time due to the long scan times.

I cannot say for sure that the crash occurred after the scan was completed. The last time I succeeded to complete a scan the PC was unresponsive for some minutes right before everything was completed but then I could regain control of the PC and everything was fine with ADD. I have not experienced any issues during the scan itself.

I was scanning the artist section of my collection. Since I separate VA albums and did not scan them, there should have been only some occasional VA albums in the artist folders. I also generally separate my flac albums and my mp3 albums. I scanned the mp3 artist section where there are only some flac albums interspersed.

I just started the scan again and it takes up some 90 MB of RAM and 4% CPU, which seems modest.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 19:36:49
I cannot say for sure that the crash occurred after the scan was completed.

In that case, there are a couple of other diagnostic checks that might be worth trying. One is to use file path pattern matching instead of ID3 tags. This will test to see if the problem is with reading tags from the files, including embedded image tags. It will also be a lot faster to run, particularly if you can use a pattern with an absolute root and ending in a \. (meaning that only the folder name is checked, no files within it), for example: S:\Music\%artist%\%album%\.

The other thing would be to change the "Specify path to find images" to something like invalid.name or anything that you know won't ever match. That will test to see if the problem is with loading image files to read their resolution.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 19:46:11
While scanning:

Re: The file browser I just started to use.
I would like to be able to check my music files and album art for consistency. I would like to check
a) if the size and dimensions of a specific file in one folder (folder.jpg in my case) differs from what is embedded in any of the mp3 files in that folder,
b) if any of the mp3 files in one folder has an image of different size or dimensions embedded than the other files in that folder,
c) if any mp3 file has more than one image embedded, and
d) if any mp3 file has metadata indicating that the embedded image is of any other type than Front.

Would anything like that be possible or do you, or someone else, know of a tool that already can do this? I realise that the scanning times could be very long.

An option to let you be able to see how many image files there are in one folder would also be useful. That way I could concentrate on adding album art to albums that have only the front cover.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 19:54:35
I cannot say for sure that the crash occurred after the scan was completed.

In that case, there are a couple of other diagnostic checks that might be worth trying. One is to use file path pattern matching instead of ID3 tags. This will test to see if the problem is with reading tags from the files, including embedded image tags. It will also be a lot faster to run, particularly if you can use a pattern with an absolute root and ending in a \. (meaning that only the folder name is checked, no files within it), for example: S:\Music\%artist%\%album%\.

The other thing would be to change the "Specify path to find images" to something like invalid.name or anything that you know won't ever match. That will test to see if the problem is with loading image files to read their resolution.

Alex


I am not sure what you want me to do.

Search for audio files is currently set to: F:\MP3\Min musik\Artister
Would you like me to search for just one album (like F:\MP3\Min musik\Artister\10,000 Maniacs\In My Tribe (1987), for example)?

The "Specify path to find images" is set to: %preset%.%extension%|Cover%preset%.%extension%
Would you like me to set that to Invalid.name?

Shall I do this in one go or start with only the Search for audio files option and then (with your suggested Search for audio files option) change the Specify path to find images option?

EDIT: PS. The scan is up to some 5,800 albums now after about 45 minutes and uses some 200 MB of RAM and only 2% of CPU.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 20:13:19
Would anything like that be possible or do you, or someone else, know of a tool that already can do this?

That sort of thing is really out of scope for AAD, I'm afraid. It's a library and tag management sort of task, for which you need library and tag management software. I don't use embedded art myself, so I can't really recommend any software to do that from personal experience. In general, foobar2000 and MP3Tag (http://www.mp3tag.de) would be my go-to tools, but I don't know if they have any consistency checking built in. Perhaps someone else can offer suggestions?

I am not sure what you want me to do.

I'd like you to try searching by path pattern, rather than ID3 tag. To do this, under Options in the file browser, select the option "Use file path pattern matching", and in the box put "F:\MP3\Min musik\Artister\%artist%\%album% (*)\." including the . but not the " marks. (I'm using your example to guess your naming scheme). Still do the search for all the albums though, I'm pretty sure that searching for just one wouldn't cause any problems!

Also, yes, please try setting "Specify path to find images" to Invalid.name.

If you make both changes at once, and it doesn't stall, then try putting the "Specify path to find images" back to normal again. Or, if you are feeling more optimistic, you could make just the path pattern change and only try the path to find images change if the first one still stalled, whichever you prefer :-)

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-25 20:13:24
After 6,585 albums into the complete scan I hit stop and everything is normal so far. 227 MB of RAM is used and 0% of CPU.

In the scan that completed I had the hits sorted by Dimensions (smallest first) and noticed that the first entry was a rather large "Found: folder.jpg" of about 1500x1500, which looked strange since the other hits all had an Artwork status of "Found: [filename]<0>. I am afraid I cannot remember which file that was, but I do remember checking it out with Windows Explorer and found nothing extraordinary about that file or the album.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-25 20:28:46
Here's quickly one new source: http://www.qobuz.com/ (http://www.qobuz.com/)

Qobuz is looking like a pretty good source - nice find! Here's the script: qobuz.boo (http://album-art.sourceforge.net/scripts/qobuz.boo). If you could give it a try, I'd like to include it in 0.40 tomorrow.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 09:16:05
OK, I am back. Thanks for the reply!

That sort of thing is really out of scope for AAD, I'm afraid. It's a library and tag management sort of task, for which you need library and tag management software. I don't use embedded art myself, so I can't really recommend any software to do that from personal experience. In general, foobar2000 and MP3Tag (http://www.mp3tag.de) would be my go-to tools, but I don't know if they have any consistency checking built in. Perhaps someone else can offer suggestions?

OK, I understand.

MP3Tag cannot do this for multiple albums. Perhaps there is a foobar plugin I do not know about.

I'd like you to try searching by path pattern, rather than ID3 tag. To do this, under Options in the file browser, select the option "Use file path pattern matching", and in the box put "F:\MP3\Min musik\Artister\%artist%\%album% (*)\." including the . but not the " marks. (I'm using your example to guess your naming scheme). Still do the search for all the albums though, I'm pretty sure that searching for just one wouldn't cause any problems!

Also, yes, please try setting "Specify path to find images" to Invalid.name.

If you make both changes at once, and it doesn't stall, then try putting the "Specify path to find images" back to normal again. Or, if you are feeling more optimistic, you could make just the path pattern change and only try the path to find images change if the first one still stalled, whichever you prefer :-)

I did both changes recommended and the search completed very fast and found no artwork. I then put the path to find images back and did another scan. This time artwork was found. No crashes or performance issues whatsoever.

I should mention that the path pattern does not always correctly reflect the artist or album name in the tags.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 09:37:39
I did both changes recommended and the search completed very fast and found no artwork. I then put the path to find images back and did another scan. This time artwork was found. No crashes or performance issues whatsoever.

I should mention that the path pattern does not always correctly reflect the artist or album name in the tags.
OK, so it's not a problem with simply having too many albums in memory, or showing too many in the list, as using the path pattern would produce roughly the same set of results. Given that it still works fine with searching for images too, I guess there must be some issue with the tag reading code. I'll investigate a bit and see if I can spot any problems.

The path pattern's accuracy depends entirely on the accuracy of your folder naming, and consistency with the pattern. With the pattern I gave you, it would be tripped up by album names with brackets in them (as it assumes that the brackets contain the date), or album names without the date in brackets at the end. Of course the pattern can be made more complex to cope with these variations, but given the restrictions on characters allowed in folder names, reading the tags will always be more accurate (unless you have badly tagged files!).

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 10:22:23
OK, I did a scan the normal way again. The PC stalled at the end when all 7,454 albums were scanned and AAD reported Searching Thumbs.db. AAD then used up all available memory (total usage 99%) but hardly any CPU. This went on for a couple of minutes when the C was unresponsive. Then the message Done appeared and I was able to control the PC again but with performance issues. Almost all available memory was still used by AAD (some 5 or 6 GB). This went on for a couple of minutes and then memory usage for AAD was back at normal (some 135 MB). No crash this time.

I know it is easy to fix the paths (tags are in order, paths not) and I realise that this can be useful. The downside of that for me would be that it will brake the listening statistics system I use since a couple of years (and it will trigger massive backup operations via LAN and via ftp over the Internet).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 11:39:08

Thanks for the details. Have you already tried the scan using tags, but with the path to find images set to invalid?

It's interesting that the last progress report is scanning Thumbs.db - it's probably a coincidence, but could you do a quick search for Thumbs.db and just make sure there isn't a gigabyte sized Thumbs.db file or anything screwy like that going on?

After Done appears, I think the performance issues would be due to .net garbage collecting all that memory. That's not a problem, it's what it should be doing. The question really is why it used up all that memory to start with! If you have the time, could you try this experimental version: AlbumArtDownloaderXUI-0.40.experimental.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.40.experimental.zip)?

It has a couple of tweaks to the various artists detection - firstly, it moves some stuff that it does into background priority which might help prevent unresponsiveness, and secondly, it reports on what it is doing. The status bar should say "Detecting Various Artists albums..." when it starts, then "Resolving Various Artists album... " for each album that it's detected as being Various Artists and processing. If it shows either of those while it is unresponsive and using excessive memory, then I'll know what needs fixing.

I can understand you not wanting to change your file paths, and you shouldn't have to - it should work properly using tags too. That is the default setting, after all, and was chosen as such for accuracy over speed.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 11:51:58
Windows Explorer did not find any Thumbs.db. It is a hidden file and I do not think I have another file browser installed (but you could perhaps recommend one).

I will try the experimental version with search by tags and Invalid.name. Could you just tell me if the Cover Paradise script in this version is the enhanced script that finds albums with the same name as the artist,
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 12:07:15

I use Windows Explorer, but I have Show Hidden Files and Folders turned on, and Hide protected operating system files turned off (View/Folder Options, View tab). I'm not sure which of those covers Thumbs.db, maybe both!

The cover-paradies script in the zip file is the very latest unreleased version, which does the accurate search then falls back on the old inaccurate one, and also marks booklet images as such. You can of course keep using the old script if you prefer, for the experiment the scripts are not involved at all anyway.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 12:15:41
OK, that sounds good. I want to get some more artwork while scanning. That was why I asked about the script. (The version is 0.39.1.0, not 0.40 as the zip file indicates, but I guess it is the correct version and not an old one).

I have all files visible in Windows.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 12:28:47
The version is 0.39.1.0, not 0.40 as the zip file indicates [...] I have all files visible in Windows.

That's not right, it should be 0.40. I've tried downloading it myself, and it looks like 0.40 to me...

Thumbs.db is automatically created by Windows Explorer in folders with images in them, and is marked with the hidden and system attributes. I'm not sure what else to tell you, but if AAD was scanning it, it must exist!
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 12:36:33
OK, I have the 0.40 version now. I do not know what happened. I downloaded the zip file and copied the contents to the AAD program folder. Probably some user error...

I do see the Thumbs.db files in Window Explorer. It is just that if I search for Thumbs.db or *.db Windows Explorer shows no hits.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-26 13:24:38
Here's the script: qobuz.boo (http://album-art.sourceforge.net/scripts/qobuz.boo). If you could give it a try, I'd like to include it in 0.40 tomorrow.

Seems to work ok.

P.S. Chartstats seems to freeze after one result (the source on the right just shows 1, progress bar freezed showing one "bar" in the left side and a stop link) for a long time, eventually it stops. Also the one result shown in the left side list is "unknown" type (I've "fetch image when unknown" set) and getting the real image takes really long time, but in the end it gets the image, though the size is only 100x84px. But when I open the image webpage (http://www.chartstats.com/release.php?release=244) (from the "i" button), the webpage and the image loads very fast. Also the size of the image on the webpage is 300x254px. Where did the 100x84px come from? (I don't use this script but I noticed this behavior while testing the qobuz script) I was searching for "radiohead - king of limbs". This seems to happen with every different search, really slow and the image is ~100x84px while the webpage has a bigger one.

And here's a new script idea:

hmvdigital (http://www.hmvdigital.com) - maybe you should replace the "HMV Canada" script with this? I searched for "Vesa-Matti Loiri - 4 + 20" and the "Canada" script didn't find anything. This "digital" site on the other hand has it (http://www.hmvdigital.com/artist/vesa-matti-loiri/4-plus-20).. in 800px (or 500px). This source seems to use the same image source as 7digital (and some others IIRC). Just remember that some of the images might not be found in 800px, only 500px! Unfortunately I don't have an example for this now (I've seen this couple of times in the past with 7digital, and since the image source seems to be the same, it's likely to happen with hmvdigital also).

While you're at it, make the 7digital too fall back on 500px in case 800px image is not found.  BTW. 7digital is doing some "essential work" on the site ATM (site is up and down intermittently).. might break script *wink wink*.

AND, it might be wise to change the 7digital to the "google site" search type since, as you might have noticed, 7digital has additional 15 sites for different countries (check the links at the bottom of the page) which might have slightly different results per country. E.g. for a Finnish band "Egotrippi" the main site (http://www.7digital.com/artists/egotrippi/#pnlAlbums) has 11 albums & 2 singles while the Finnish 7digital site (http://fi.7digital.com/artists/egotrippi/#pnlAlbums) has the same 11 albums but 6 singles.

The current script doesn't find the correct e.g. "Egotrippi - Asfaltin Pinta" cover image, even though I've set max results to 50 (search gives 24 results). But when I do search with google (http://www.google.com/search?q=site:7digital.com+egotrippi+Asfaltin+pinta), I get the correct album/single result from 7digital Ireland (1st google result) & Spain sites (4th result).. for some reason no Finnish site in the search though (maybe in the next google search result pages).. but still, better result than the current script. (check the end of the post about doing more than 10 results per page search in google)


And a maybe-not-so-great-but-worth-checking-at-least:

GigaCrate (http://www.gigacrate.com) (use JavaScript) - Here's an example search (http://www.gigacrate.com/Music/MusicSearchResults.php?quicksearch%5Bterms%5D=korpi+ensemble+for+a+new+day&do_quicksearch=1). Just take the album URL from the search results page (http://www.gigacrate.com/Albums/25853) and change it to find "large" image (295px) (http://www.gigacrate.com/images/album_art/25853Large.jpg) and/or "XL" image (500px) (http://www.gigacrate.com/images/album_art/25853XL.jpg).

Still 4 sites to go (had 6 but two were changed/restricted to only small images). Maybe it's better to drop these slowly and not all together.. easier to test and discuss here.


BTW. Did you have some scripts that use google search and therefore the scripts are limited to only 10 results? I vaguely remember couple of discussion/notes about it here. Or was it with google image search maxing to 20? At least you could use this for the eMusic and future scripts.  Well, here's a workaround; "Google Instant" has been turned on automatically now for everyone using google (AFAIK) and it disables the "num=X" switch which could be used to show X number of search results per page. Workaround is to use "as_qdr=all" switch with the "num" switch. Example search (http://www.google.com/search?num=46&as_qdr=all&q=site%3A7digital.com+egotrippi+Asfaltin+pinta) with 46 results per page.

And if you want to use old google image search (without JavaScript), just use the "gbv=1" switch.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 13:29:16
I will try the experimental version with search by tags and Invalid.name.

AAD reported Done when the computer stalled for a couple of minutes this time with AAD using up all available memory.

Looking forward to the final .40 release. It looks promising! (Let me know if you would like input now on the experimental version.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 15:55:26
[Chartstats problems]
I just tried a search for radiohead / king of limbs here and it worked fine, but you say it was of Unknown *type*? It's supposed to be of unknown size, but they should all be of type Front coming from chartstats. If it wasn't, then it can't have come from the Chartstats script. I've never seen the 100x84 image either - do you think it might be a flood protection thing? Weird, anyway.

[other scripts]
I think the point of the HMV Canada source was to get Canada specific releases, if I remember right. If it's the same underlying source as 7digital, though, is there any need for it too? 7digital currently falls back on 350x350 if the 800x800 one isn't found. If you know any examples where 800 isn't available, but 500 is, that would be helpful. I don't think I should make any changes to 7digital until we see the outcome of the "essential work", though - where do you see that posted? I had a look at their blog, but it wasn't mentioned.

I'm not convinced by doing hybrid google searches unless absolutely necessary, though. I'd rather not over-rely on any single site; one of the benefits of having lots of sources is that when one goes down, others can still be used - but if everything routes through google, and that stops working, then they all go down. Not that I'm suggesting google will actually stop working, but it might well change in such a way as to break the script, either through design changes or deliberately.

GigaCrate might be interesting - I get the impression that it specialises in music for DJ's, which is not an area I've ever looked at before. If it's under-served by the existing scripts, it could be worth adding. I might leave it until after 0.40 though as I really wanted to get that out this weekend. Also, I think you're right that it's better to concentrate on one at a time, until we're happy it's working fine before moving on to the next.

if you want to use old google image search (without JavaScript), just use the "gbv=1" switch.
That's what the google script currently uses. Boo doesn't execute javascript, which makes using the new google image search really tricky. If really necessary, more results could be obtained by requesting further search pages, but 20 seemed like enough that it wasn't worth making two requests for every search.

AAD reported Done when the computer stalled for a couple of minutes this time with AAD using up all available memory.

Looking forward to the final .40 release. It looks promising! (Let me know if you would like input now on the experimental version.)
OK, I'm going to try rewriting the Various Artists detection to optimise for memory efficiency (at the cost of some speed), and give you another experimental version to try. You are welcome to give feedback on the other features going into 0.40 that you've had a sneak preview of - I know not everything you requested has made it in, though!

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 16:17:06
AAD reported Done when the computer stalled for a couple of minutes this time with AAD using up all available memory.

OK, here's another experimental version, this time with a memory-usage optimised algorithm for finding various artists: AlbumArtDownloaderXUI-0.40.experimental.1.zip (http://www.byalexv.co.uk/temp/AlbumArtDownloaderXUI-0.40.experimental.1.zip). I've versioned it as 0.40.0.1, but that's just to make it easy for you to check you've got the right version running - when released it will just be 0.40.

If it still gives the memory-gobbling stalling behaviour, then I've guessed wrong and it's something else that is causing that. Which would be irritating.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 16:38:48
Re: The experimental version.

I am sure that you are aware of the fact that Inside is called Inlay in that version and that if you change the type to Inside the image groups with Inlay. Inlay is also missing in the general options and in the type changing drop down menu.

Darktown calls what is usually an Inside Inlay, so it would be correct more often to set Inlay images from Darktown to Inside. Cover Paradise has a type called Digipack, which should get its own type or sort under Booklet.

When pulling down the Group or Sort by drop down menu the legend ("Group by", for example) moves. (This may be intentional.)

Now that we can group by web page (Thank you!) an option to download all images from one group with just one mouse click (and the additional clicks required to make unique file names) could be useful.

The experimental version came with many scripts and I cannot sort them in the right hand list (to get the most essential scripts on top). Some indication of when all scripts are finished would be useful (maybe a progressbar like the download one).

What does the Sort by Area option do?

Thank you for all your hard work!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 17:06:21
I've just had a quick look inside GigaCrate, and it wasn't as hard to parse as their use of Javascript led me to first believe. I think this can be squeezed into the 0.40 release, if you'd like to give it a try: gigacrate.boo (http://album-art.sourceforge.net/scripts/gigacrate.boo)

RE: Inlay/Inside. This is not an intentional change. The term "Inlay" was renamed as "Inside" a long time ago, to reflect the fact that not all of the images from the inside of the case could rightly be termed Inlay. Inlay was too specific. Giving it a quick look now and I see that the group header is wrongly showing Inlay instead of Inside, but that's not something new in 0.40 is it? Have you spotted anywhere else that "Inlay" appears in the UI?

Could you point me at an example album with a Digipack cover, that should be assigned the Booklet type?

I'm aware that the Group and sort drop-downs resize the first time they are accessed - that's not new, but it's much more noticeable now. I think I might just have "Page" in there rather than "Web Page" so it isn't so much wider than the other entries.

An option to download all the albums in a group will not be part of 0.40. I'll consider it for future versions, but it's not going in this one, sorry.

I wouldn't generally recommend having every single script installed, just delete the boo files for the ones you aren't using! There isn't a global progress bar for all scripts, but as a handy indicator the "Stop All" link at the top right of the sources list will disappear once they've all finished.

Sort by Area sorts by (width * height). When the images aren't perfectly square, this can give a more reliable measure of which results are the 'biggest', at the cost of a potentially confusing sort order. As an extreme example, under the Size sort, the order might be 1000x800, 900x900, 800x900. Area sort would have: 900x900, 1000x800, 800x900. It was requested quite a while ago.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-26 17:26:35
I just tried a search for radiohead / king of limbs here and it worked fine, but you say it was of Unknown *type*? It's supposed to be of unknown size, but they should all be of type Front coming from chartstats. If it wasn't, then it can't have come from the Chartstats script. I've never seen the 100x84 image either - do you think it might be a flood protection thing? Weird, anyway.

Sorry, I meant that it's unknown size. And "front" type. But, it freezes like I described and it shows the 100x84px image after a while.. and after the image is fetched, the script is still freezed in the right scripts panel for a while and then it stops. Something is not right here. Dunno whether it is a flood protection or not. I'm not using that script like I wrote so I'm not so concerned, just reported this anomaly.

I think the point of the HMV Canada source was to get Canada specific releases, if I remember right. If it's the same underlying source as 7digital, though, is there any need for it too?

Ok. Just add HMVdigital script then? I think that it would be good to have alternatives/failbacks (I mean HMVdigital to 7digital). For example, today 7digital was intermittently down.. plus Coverlandia was down earlier today, they might have changed the site (I couldn't tell because I haven't visited the site for a while).

7digital currently falls back on 350x350px if the 800x800 one isn't found. If you know any examples where 800 isn't available, but 500 is, that would be helpful.

I don't have any right now unfortunately.. but would it be a big trouble to check for the 500px before falling back to 350 if 800px is not found first? Do we really need an example? I'm 100% sure that there are those cases where there's no 800px but 500px is available. I remember seeing it happen at least twice in the 7digital webpage (before you made the script) and once in AAD.

I don't think I should make any changes to 7digital until we see the outcome of the "essential work", though - where do you see that posted? I had a look at their blog, but it wasn't mentioned.

Just tried to load any page earlier today, sometimes there was a temporary "we are doing some essential work with the site" page, sometimes pages didn't load at all and sometimes the correct page loaded.

I'm not convinced by doing hybrid google searches unless absolutely necessary, though. I'd rather not over-rely on any single site; one of the benefits of having lots of sources is that when one goes down, others can still be used - but if everything routes through google, and that stops working, then they all go down. Not that I'm suggesting google will actually stop working, but it might well change in such a way as to break the script, either through design changes or deliberately.

I agree with you, not everything should use the same google search style. If you don't feel confident of changing the current script, what if you put an alternative 7digital script with the method I described? A "7digital International" script if you like.

GigaCrate might be interesting ... I might leave it until after 0.40 though as I really wanted to get that out this weekend. Also, I think you're right that it's better to concentrate on one at a time, until we're happy it's working fine before moving on to the next.

Ok, just put it to your notes or whatever.. I deleted it and I might forget it.

Let's test the HMVdigital (if you make it) first.. and perhaps the 7digital and "7digital International" if you change and/or make it. The rest of the 4 other sites I'm holding off for now are IMHO really great, either big big images and/or great quality. Stay tuned folks.. or just you Alex.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 17:30:57
Thank you for the reply!

RE: Inlay/Inside. This is not an intentional change. The term "Inlay" was renamed as "Inside" a long time ago, to reflect the fact that not all of the images from the inside of the case could rightly be termed Inlay. Inlay was too specific. Giving it a quick look now and I see that the group header is wrongly showing Inlay instead of Inside, but that's not something new in 0.40 is it? Have you spotted anywhere else that "Inlay" appears in the UI?


Oh, I thought you were going to add another type named Inlay.

The group header was Inside, not Inlay, before. This version saves the Inside images as Inlay.jpg, whereas the earlier versions savved them as Inside.jpg.

Could you point me at an example album with a Digipack cover, that should be assigned the Booklet type?

http://cover-paradies.to/?Module=ViewEntry&ID=392256 (http://cover-paradies.to/?Module=ViewEntry&ID=392256) It actually should be a category of its own.

I'm aware that the Group and sort drop-downs resize the first time they are accessed - that's not new, but it's much more noticeable now. I think I might just have "Page" in there rather than "Web Page" so it isn't so much wider than the other entries.

Or you could just realign according to the width of the actually selected option (not the width of the widest option in the drop down menu). This is of course just cosmetics, but it looked a bit odd to me.

An option to download all the albums in a group will not be part of 0.40. I'll consider it for future versions, but it's not going in this one, sorry.

I'll wait for that and an option to automatically number duplicates (without the overwrite dialog). Then a one click download of all images for one album would be possible!

There isn't a global progress bar for all scripts, but as a handy indicator the "Stop All" link at the top right of the sources list will disappear once they've all finished.

Aha, I had not noticed that.

Sort by Area sorts by (width * height). When the images aren't perfectly square, this can give a more reliable measure of which results are the 'biggest', at the cost of a potentially confusing sort order. As an extreme example, under the Size sort, the order might be 1000x800, 900x900, 800x900. Area sort would have: 900x900, 1000x800, 800x900. It was requested quite a while ago.

Aha, I thought it might have something to do with the regional Amazon stores or the Canada discussion you just had with Akkurat (i.e. area=region of the world). Thanks for explaining.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 17:35:30
Hi again,

I just wanted to report that a scan with my normal setting seems to have finished without me even noticing it or seeing any memory hogging. Whatever you did seems to have worked. Thanks!
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-26 17:39:39
GigaCrate

Seems to work ok. Great work.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 18:12:22
would it be a big trouble to check for the 500px before falling back to 350 if 800px is not found first? Do we really need an example?
Technically, no, but I'm not entirely comfortable releasing an updated script without testing that it actually works. Here's an updated version of it for you to try, but if I don't find a 500x500 and a 350x350 image to try it with before I release 0.40, I'm going to back out the changes: 7digital.boo (http://www.byalexv.co.uk/foobar/7digital.boo).

The group header was Inside, not Inlay, before. This version saves the Inside images as Inlay.jpg, whereas the earlier versions savved them as Inside.jpg.
Well that's weird. I can't think why it would have changed, but it clearly has. I think I've fixed it now.

[Digipack] actually should be a category of its own.
I don't think I want to add another category for this. From what I can tell, a digipack should really be scanned as separate images for front, back and inside. It isn't really a booklet, so I'm just going to leave it as Unknown for the moment.

a scan with my normal setting seems to have finished without me even noticing it or seeing any memory hogging.
Hooray! I'm glad that's sorted out now, thanks for helping me find and test it.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-26 18:43:37
Technically, no, but I'm not entirely comfortable releasing an updated script without testing that it actually works. Here's an updated version of it for you to try, but if I don't find a 500x500 and a 350x350 image to try it with before I release 0.40, I'm going to back out the changes: 7digital.boo (http://www.byalexv.co.uk/foobar/7digital.boo).

That was quick, I just started to search with artist names and found an example (http://www.7digital.com/artists/vesa-matti-loiri/4-plus-20-1/). If you try to load the 800px image (http://cdn.7static.com/static/img/sleeveart/00/011/867/0001186742_800.jpg), 7digital shows a default "not found" image (http://cdn.7static.com/static/img/sleeveart/00/000/000/0000000016_350.jpg) which is 350px. You should detect and discard this default image in the script.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-26 19:03:13
Would it be possible to, when time allows, make a script for this site http://progg.se/band.asp?ID=148&skiva=629&cover=629 (http://progg.se/band.asp?ID=148&skiva=629&cover=629). It has 500x500 Front album art for obscure old Swedish prog music that is not available elsewhere. They say that they have higher quality art and Back and Inside art as well upon request so there might be some hidden files on the web site.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 19:08:23
7digital shows a default "not found" image
Hah, I knew it was worth testing first! I've updated 7digital.boo (http://www.byalexv.co.uk/foobar/7digital.boo) so it treats a redirect to that "not found" image as if it didn't exist, and falls back on the next size down. In this case, 500x500. Have you spotted any that fall back on 300x300? I think the music I know isn't obscure enough, as everything I tried has an 800 image available :-/

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-06-26 19:59:32
Yeah yeah, testing is wise, enough with the gloating.  Works now.

No, I haven't found any 350px (that was what you meant?) only covers. Were you thinking of dropping the 350px away completely? Or what were you thinking about?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 20:18:19
No, I haven't found any 350px (that was what you meant?)
Yes, 350 was what I meant. According to their API docs (http://api.7digital.com/1.2/static/documentation/7digitalpublicapi.html#Image_sizes_of_cover_art_and_artist_pictures), about 10% of their catalogue don't have 500 or 800 sized images, so I assume they fall back to 350. Oh well, I guess I'll stick with what I've got and hope that if anyone does find a 350, and it doesn't work, they'll report it!

I'm going to start the release process for 0.40 now.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-26 20:29:54
Version 0.40
This version adds some requested features, most notably the ability to customise the pattern used to suggest new names for files that would otherwise be overwritten. To do this, click the Options link in the Overwrite warning dialog that appears when you try to overwrite an existing file by saving a result.

Other added features:Bugs fixed:New scripts:Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.40.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.40.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-27 08:12:58
Version 0.40

Thanks!

Great work!
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-27 18:38:50
I just got an idea (that will not benefit me though). I was talking with someone at another forum that I guess had only embedded album art (and, yes, I did recommend checking out AAD...).

Why not use the file browser capabilities to read embedded images in the search window like an "embedded local files" script? (Sorry if this has been suggested before.)

Another thing I wondered about after extensive use of AAD: AAD is much based on the use of many windows you have to close to get new ones to appear, so why is it not possible to close a window with Esc, or even Ctrl+W?

Thanks again for the new version!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-27 18:56:19
Why not use the file browser capabilities to read embedded images in the search window like an "embedded local files" script?
That already happens. The default setting for the local files source is to search for "%folder%\%filename%|%folder%\*<*>", which means look in the folder where results will be saved for, and look for either files which are named the same as the result will be saved to, or any images embedded within any files in that folder. (In AAD, embedded images are referenced in paths with <> syntax, so "track.mp3<0>" means the first embedded image within the file track.mp3, and here *<*> means any embedded image, in any file.)

why is it not possible to close a window with Esc, or even Ctrl+W?
Esc, because that is to close modal dialog boxes, or otherwise to cancel something. Ctrl+W is usually close tab, or close document in an MDI interface (like Ctrl+F4). Neither of which apply to AAD windows, which aren't tabs, or contained within an MDI frame. What's wrong with Alt+F4 for closing a window? It's pretty standard...

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-27 19:15:07
Thanks for the prompt reply!

Aha, the "or" part explains why I have never seen any embedded search results since here should also always be a folder.jpg file with the same content as the embedded image. I thought AAD was not doing this since you were so reluctant to consider implementing a consistency check regarding the image file in the folder and the image files embedded in the music files.

The image viewing program I use - Irfan View - which relies on multiple windows as well, closes on Esc which I find very handy. But this is probably just handy, not Windows standard.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-27 19:35:30
I think it ought to be finding both embedded images and folder.jpg (sorry, using 'or' in the programming sense, mathematically the union of the two - hard to remember that the English use can mean almost exactly the opposite). If it isn't finding embedded images for you there's probably some reason for that. The first thing to check would be to make sure that the path in the local files source does actually include the *<*> search pattern. If it does, then hover the mouse over the pattern to get a tooltip showing what it resolves to, and check that it is actually looking in the right place.

The reason behind my reluctance to implement a consistency check is not the finding of artwork, AAD is all about finding artwork, it's the 'consistency' aspect. I don't want to get into library management. To me, making sure the Image tag is the same for all tracks in an album, and matches the external image file, is the same class of task as making sure that the album name tag is the same for all the tracks, and matches the folder name that they are in. Both these tasks should be done by the same software, and that isn't going to be AAD.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-27 19:50:10
Thanks for the reply! I will reply tomorrow since I will be busy now.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-28 09:47:57
If it isn't finding embedded images for you there's probably some reason for that. The first thing to check would be to make sure that the path in the local files source does actually include the *<*> search pattern. If it does, then hover the mouse over the pattern to get a tooltip showing what it resolves to, and check that it is actually looking in the right place.

For an album with embedded images in each file and a folder.jpg of the same image in the same folder AAD reports only folder.jpg. The path in the Local files script is:
%folder%\%filename%|%folder%\*<*>

I do not think I have changed it. It seems to resolve nicely to the correct folder but the last item ends with: \*<*>
and the first one ends with: \*.*

I am happy with things as how they are now and would not want to find 20 identical images, one from each music file. I am, however, willing to help you test if you think what I am seeing could be a bug. Just let me know.

I was not at all questioning your prerogative to determine the scope of your own program, or demanding any explanation from you in this regard. Sorry if it came out that way.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-28 18:14:58
Version 0.40
  • When using a preset to save a result, the default path pattern to save to is now always used (rather than any specific filename already assigned to that result)

If you choose a preset that will overwrite a file and then cancel the overwrite dialog, the file path is changed to that preset and will not change even if you change image type. Is this the intended behaviour?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-28 18:41:14
If you choose a preset that will overwrite a file and then cancel the overwrite dialog, the file path is changed to that preset and will not change even if you change image type. Is this the intended behaviour?
If you choose a preset, it will clear any existing custom filename. It will also set the current %preset% value to whatever the value of the preset selected was. This all occurs before the overwrite dialog is shown.

Cancelling the overwrite dialog will prevent the file from being saved, and will not apply any custom filename, but nothing else. If you want to change to a different preset you'll still need to pick one from the list. Changing the image type will not affect which preset is selected, but should update any %type% placeholders.

(Note that if the text of the filename is black and bold then it is set as a custom filename, and will no longer be affected by changing the type, or any other variable, until cleared. It is cleared either by clicking on it and deleting all the text, or by applying any preset (which is the new behaviour just added in 0.40))

Oh yes, and as for the embedded art thing, if you're happy with it as it is then there's no need to start messing about with it on my account, I know the functionality works at least for me!

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-28 18:54:08
Thanks for the reply!

Changing the image type will not affect which preset is selected, but should update any %type% placeholders.

Aha, I have %preset%.%extension% set as the filename and the default preset set to %type% (which is then not updated).
Title: Album Art Downloader XUI
Post by: Darcorn on 2011-06-30 14:13:55
Hello!

I have a suggestion how the overwrite window can be improved in the next version of AAD. I like the option of saving the file as front2.jpg and I'd like to suggest doing the same choices for back, inside, cd and booklet. I will explain why that would be convenient.

To get my covers, I am using the command line parameter found here: http://eolindel.free.fr/foobar0.9/covers.php (http://eolindel.free.fr/foobar0.9/covers.php). With the overwrite window of the latest AAD I can save for example the back cover without overwriting the front AND my command line parameter. With the abovementioned improvement it would be much more comfortable and a lot faster to get all the necessary covers.

If there is another way to do what I'd suggested (without modifying the original command line parameter), could anyone tell me how to do it? Step by step please

I'm sorry if that has been suggested before.

Great work on AAD!! Keep it up. So far it's the best way to get covers for the entire music collection

Darcorn
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-30 15:20:03
Hello!

I have a suggestion how the overwrite window can be improved in the next version of AAD. I like the option of saving the file as front2.jpg and I'd like to suggest doing the same choices for back, inside, cd and booklet. I will explain why that would be convenient.

To get my covers, I am using the command line parameter found here: http://eolindel.free.fr/foobar0.9/covers.php (http://eolindel.free.fr/foobar0.9/covers.php). With the overwrite window of the latest AAD I can save for example the back cover without overwriting the front AND my command line parameter. With the abovementioned improvement it would be much more comfortable and a lot faster to get all the necessary covers.

If there is another way to do what I'd suggested (without modifying the original command line parameter), could anyone tell me how to do it? Step by step please

Have you tried this? Change the Cover.jpg part in the command line parameter in foobar to %type%.%extension%. In the new overwrite dialog choose options and type %filename%%n2%.%extension% as the pattern.
Title: Album Art Downloader XUI
Post by: Darcorn on 2011-06-30 15:32:46
Thanks for the suggestion vagskal. I'll try it now and post back

One more thing. I use foo_run to run AAD from within Foobar

I changed this: "C:\Program files\AlbumArtDownloader\albumart.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)cover.jpg"   

into this: "C:\Program files\AlbumArtDownloader\albumart.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%type%.%extension%"   

Is this what you wanted me to do exactly?

Edit 2: Doing what you suggested vagskal causes AAD to display an error about illegal characters in the path. Unless I'm doing it wrong
Title: Album Art Downloader XUI
Post by: DRata on 2011-06-30 16:23:19
Two separate items of note:

Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-30 17:23:47
Thanks for the suggestion vagskal. I'll try it now and post back

One more thing. I use foo_run to run AAD from within Foobar

I changed this: "C:\Program files\AlbumArtDownloader\albumart.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)cover.jpg"   

into this: "C:\Program files\AlbumArtDownloader\albumart.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%type%.%extension%"   

Is this what you wanted me to do exactly?

Edit 2: Doing what you suggested vagskal causes AAD to display an error about illegal characters in the path. Unless I'm doing it wrong

I do not use foobar with AAD, but I thought that the change in foobar would send [the folder path]\%type%.%extension% to AAD (like with the command line interface). If it does not, you had better wait for a reply from someone using foobar. Sorry if I mislead you.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-06-30 18:13:19
Edit 2: Doing what you suggested vagskal causes AAD to display an error about illegal characters in the path. Unless I'm doing it wrong
Vagskal had it almost right, but because you are using Foobar, you need to enter %% instead of % where you want the % to go to AAD, otherwise Foobar tries to replace it itself. So:

"C:\Program files\AlbumArtDownloader\albumart.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%%type%%.%%extension%%

ought to do the job. However, that will name results as "Front.jpg", "Back.jpg" and so on. If you would rather the Front or Unknown images were still called "cover.jpg", you can do that with:

"C:\Program files\AlbumArtDownloader\albumart.exe" "%artist%" "%album%" "$replace(%_path%,%_filename_ext%,)%%type(cover,cover)%%.%%extension%%

in the Art Preview window [...] all the preset items are grayed out
Oops, my fault, sorry. Thanks for reporting it, that will be fixed in the next version.

The Buy.com script is no longer working
I've updated the script, it should be available through online updates, or directly here: buy-com.boo (http://album-art.sourceforge.net/scripts/buy-com.boo)

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-06-30 19:58:45
Vagskal had it almost right,

I guess "almost" does not cut it when it comes to computers and their software...
Title: Album Art Downloader XUI
Post by: Darcorn on 2011-06-30 20:01:55
WORKS LIKE A CHARM!! AAD just got MUCH MORE awesome!!! THANK YOU ALEX!!! ))
Title: Album Art Downloader XUI
Post by: DRata on 2011-07-01 07:01:57
The Buy.com script is no longer working
I've updated the script, it should be available through online updates, or directly here: buy-com.boo (http://album-art.sourceforge.net/scripts/buy-com.boo)



Wow, that was a quick fix. The AJAX stumped me but it looks like you figured it out. Thanks.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-07-01 09:13:58
AAD crashed on startup. Here is the crash log:

Code: [Select]
App version: 0.40.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Reflection.TargetInvocationException: Ett undantagsfel har uppstått i målet för en aktivering. ---> System.InvalidOperationException: Must call LoadScripts() before using this property
   vid AlbumArtDownloader.App.get_Scripts()
   vid AlbumArtDownloader.ArtSearchWindow..ctor()
   vid AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
   vid AlbumArtDownloader.App.<>c__DisplayClass3.<Signal>b__2()
   --- Slut på stackspårning för interna undantag ---
   vid System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   vid System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   vid System.Delegate.DynamicInvokeImpl(Object[] args)
   vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   vid System.Windows.Threading.DispatcherOperation.InvokeImpl()
   vid System.Threading.ExecutionContext.runTryCode(Object userData)
   vid System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   vid System.Windows.Threading.DispatcherOperation.Invoke()
   vid System.Windows.Threading.Dispatcher.ProcessQueue()
   vid System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   vid MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   vid MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   vid System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   vid MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   vid MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   vid System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   vid System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   vid System.Windows.Window.ShowHelper(Object booleanBox)
   vid System.Windows.Window.Show()
   vid System.Windows.Window.ShowDialog()
   vid AlbumArtDownloader.Splashscreen.ShowIfRequired()
   vid AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   vid System.Windows.Application.<.ctor>b__0(Object unused)
   vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   vid System.Windows.Threading.DispatcherOperation.InvokeImpl()
   vid System.Threading.ExecutionContext.runTryCode(Object userData)
   vid System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   vid System.Windows.Threading.DispatcherOperation.Invoke()
   vid System.Windows.Threading.Dispatcher.ProcessQueue()
   vid System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   vid MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   vid MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   vid System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   vid System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   vid System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   vid MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   vid MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   vid System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   vid System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   vid System.Windows.Application.RunInternal(Window window)
   vid AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   vid AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   vid AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-01 13:52:21
AAD crashed on startup. Here is the crash log:

Thanks for reporting this. From the log, I'm going to guess that AAD was in the process of compiling scripts (showing the splashscreen) when you launched a second instance? If so, I'll have that fixed for next version. Otherwise, more detective work might be needed.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-07-01 13:58:21
From the log, I'm going to guess that AAD was in the process of compiling scripts (showing the splashscreen) when you launched a second instance? If so, I'll have that fixed for next version. Otherwise, more detective work might be needed.

I think so, but AAD was launched via the command line interface from J River Media Center and I had selected all files in one album before I sent the command. The command may have been repeated but it would have been the same command, same artist and album.

Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-03 08:38:15
Version 0.40.1
Just a quick bug-fixing release:Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.40.1.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.40.1.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)
Title: Album Art Downloader XUI
Post by: vagskal on 2011-07-03 18:37:47
Version 0.40.1
  • Fixed crash where multiple copies of AAD were launched simultaneously and scripts needed recompiling

Thanks!

Now when I send multiple command line requests to AAD it opens multiple windows, one for each request, more than three which was not the behaviour before. I do not mind, but I wanted to let you know in case this new behaviour is not intended.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-03 20:30:51
Now when I send multiple command line requests to AAD it opens multiple windows
I'm not sure I quite understand the issue here. Should it not be opening a window for each request? If you have "Open search results in new window" unchecked, and there is only one search window open, then subsequent command line searches should reuse that one - is that not happening for you? When I try it here, it is.

When AAD starts, it checks to see if it is already running. If it is, it sends the command line parameters to the running instance. If it isn't running yet, then it sets itself as the running instance, and starts listening for command line parameters that might be sent to it. This is the very first thing that it does, before it loads scripts, processes its own command line parameters, or shows any window. So, if you start two copies of AAD at the same time, one will 'win', and the other will send its parameters to that one.

The change I've made is that if the running instance of AAD has not finished starting yet (it might still be loading scripts, or processing its own command line), then it makes any other copies that are trying to send it their command line parameters wait until it's ready. Previously, it might crash (in the way you reported) as it would try and process the incoming command line parameters immediately, even if not ready for them.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-07-04 06:39:34

No issue really, just a change in behaviour I have noticed.

AAD closed.
Select say 10 tracks on the same album in J River Media Center and issue a command line request to AAD.
With the current version AAD opens at once 10 windows. With previous versions only max 3 windows were opened.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-04 09:05:59
Ah, OK, I understand now. This is likely to be because it is failing to communicate with a running instance, and is falling back on starting a separate instance. If you check the Window menu, you will probably notice that the other windows aren't listed on it, because they belong to different instances. Better than crashing, but still not ideal. I'll see if I can come up with something even more cunning for dealing with multiple simultaneous launches for the next version.

For the time being, any unpleasantness can be avoided by leaving one instance of AAD running, or running one first, then all the others. It's only when several are started at the same time and they are all competing to be the winning single instance that things get tricky.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-07-09 12:33:22
think a bit of heads up is due, I think that 7digital changed their search pattern or something cause it hardly ever gets the right release upon search
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-09 13:02:14
think a bit of heads up is due, I think that 7digital changed their search pattern or something cause it hardly ever gets the right release upon search
Thanks for reporting this. Looking at their website, I think they just broke their search engine - going to their website everything I search for returns irrelevant rubbish, so it isn't an issue specifically with the AAD script. Hopefully they'll fix that soon!

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-07-16 19:06:45
This is just to once again say thank you for this excellent program and your continuous development.

I have really made heavy use of your program when supplementing and upgrading cover art for some 8k albums (I skipped a thousand or so singles for the time being). Since you added the excellent eMusic script when I was about 1/3 through I even had to go back and do a couple of thousand albums twice. Your program has stood the test and made the task far easier than I had feared. With your very responsive and fast development the task got easier and easier (the auto number function) and the result better and better (the eMusic script and the ability to group by web page). I believe you will soon have a one click download of all cover art for an album (from Cover Paradise)...

Experience has taught me to do everything that has to do with maintaining my music collection proper just once. I consider the task of supplementing the cover art completed for now. This means I will only use your program occasionally for a while and be a lot less active on this thread, but I am sure I will have to revisit the cover art aspect of my music collection again in the future since the maintenance and upgrading of a music collection is never finished. I am, however, willing to try out (beta test) new versions or give you input on enhancements, if you think that will help your development of the program. Just let me know.

Again, Thanks! Have a nice summer!

PS. You should really find more prominent places to display the donate option than on the very first page in this long thread. I almost missed it. Why not repeat it every time you announce a new version?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-16 21:26:04
Congratulations on completing your task! That must have been a huge amount of work.

I didn't really want to push the donation link too heavily, I don't like it when software I use myself does so intrusively, so I choose to err on the side of caution. I might put a small link in as part of release announcements, but it would have to be done with care.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-17 13:55:24
think a bit of heads up is due, I think that 7digital changed their search pattern or something cause it hardly ever gets the right release upon search
Thanks for reporting this. Looking at their website, I think they just broke their search engine - going to their website everything I search for returns irrelevant rubbish, so it isn't an issue specifically with the AAD script. Hopefully they'll fix that soon!

I think the point of the HMV Canada source was to get Canada specific releases, if I remember right. If it's the same underlying source as 7digital, though, is there any need for it too?

Ok. Just add HMVdigital script then? I think that it would be good to have alternatives/failbacks (I mean HMVdigital to 7digital). For example, today 7digital was intermittently down..

Have you dropped the idea of HMVdigital as a script completely? It would act as an alternative, and perhaps an addition of the .ca script; just compare the covers for Foo Fighters from both sites: http://www.hmvdigital.com/artist/foo-fighters#albums (http://www.hmvdigital.com/artist/foo-fighters#albums) and http://www.hmvdigital.ca/artist/foo-fighters#albums (http://www.hmvdigital.ca/artist/foo-fighters#albums) ... both have something that the other doesn't have (compare the singles too).

You stated that "I'd rather not over-rely on any single site; one of the benefits of having lots of sources is that when one goes down, others can still be used" about the google site search trick used for many scripts.

Ok, enough pestering you about this HMVdigital.


Here's one new source I recently found, don't know if it's usable because of the site search system: search page (http://telecharger.musique.sfr.fr/recherche.action), album page example (http://telecharger.musique.sfr.fr/album/Slash-Slash/AL14836528.action), open the small image and change the "width=157&height=157" parameters to max 600.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-17 15:06:49
Have you dropped the idea of HMVdigital as a script completely?
I thought we'd decided it was effectively the same as 7digital? Having a quick look there now, it appears to have the exact same search problems as 7digital is having at the moment, which further suggests both sites are using a common back-end source. If that's the case, is there any point to having both? It doesn't search better, or produce better results.

Since the results quality went so bad recently I had another look at using Google site search to make a hybrid. Unfortunately, unlike for the eMusic case, the search results for albums on the 7digital/hmv digital platform do not contain enough information to obtain the art. This means that to do a search, it would have to download the album page for every result before it could get the URL for art from it, which means twice as much downloading and even more fragility. It's not out of the question, and if they can't sort out their search system it may well have to be done, but it's not nice.

I've had a quick look at telecharger.musique.sfr.fr - I think that could be worth a shot. It appears all the images come from img.music.realnetworks.com, and I don't think we already have a source for those (or if we do, it's probably well hidden). The ajax search makes figuring out the script difficult, but apart from that it does actually have proper separate artist and album search fields, which is great! I'll see what I can put together for that this afternoon.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-17 15:54:00
I thought we'd decided it was effectively the same as 7digital?

I thought that they just used same source for pics, and different site/search systems. I stand corrected now.

Since the results quality went so bad recently I had another look at using Google site search to make a hybrid.
...
It's not out of the question, and if they can't sort out their search system it may well have to be done, but it's not nice.

Just do it.tm  BTW are you spoofing an user agent string? Some sites might gather data and notice AAD (and do something about it) if it sends an unique user agent string.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-17 16:28:23
BTW are you spoofing an user agent string? Some sites might gather data and notice AAD (and do something about it) if it sends an unique user agent string.

Not as a general principle, no, I don't pass any user agent. If a site requires a specific user agent to work, then I'll pass that, but most of them don't. As long as they don't use the information to try and prevent access, I'm happy for AAD accesses to show up in their stats as "other" or "non-browser". Who knows, it might even encourage them to provide API access. Unfortunately it seems the only sites which offer API access all require you to sign up and use a private developer key with each request, which is obviously completely incompatible with an open source client side application. So it's a lose-lose, I have to parse HTML and fix scripts every time they redesign, and they have to render and serve a bunch of wasted html data with each search.

Here's the script for SFR Music: sfr-music.boo (http://album-art.sourceforge.net/scripts/sfr-music.boo), let me know how you get on with it.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-17 16:51:04
I'll test it after giving you a new source (the search is not ideal unfortunately): MioMusik (http://www.miomusik.com/search.php?q=metallica%20load), open images from the search results and change "small" text to "large" for 600px images. Notice that all images are not 600x600px, example (http://www.miomusik.com/metallica/king_nothing_aint_my_bitch_Single_large.jpg).


EDIT: All SFR images are not 600x600px. Example the Slash album cover which I posted is only 593x600px. Another example (http://img.music.realnetworks.com/img/app?path=album%2F600x600%2F001%2F216260337_412305969_20110428102036%2Ejpg&mimetype=jpg&width=600&height=600). Type unknown then? Otherwise seems to work ok.
Title: Album Art Downloader XUI
Post by: spile on 2011-07-17 18:15:03
Just installed the latest update but when I choose the Browse option I get the following....

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.40.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'BrowserResults' defined in assembly 'AlbumArt, Version=0.40.1.0, Culture=neutral, PublicKeyToken=null'. Exception has been thrown by the target of an invocation.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/filebrowser.xaml'. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'AlbumArtDownloader.BrowserResults' threw an exception. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
  at System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
  at AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
  at System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
  at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
  at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
  at AlbumArtDownloader.BrowserResults..cctor()
  --- End of inner exception stack trace ---
  --- End of inner exception stack trace ---
  at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
  at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
  at System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
  at System.Activator.CreateInstance(Type type, Boolean nonPublic)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
  at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.FileBrowser.InitializeComponent()
  at AlbumArtDownloader.FileBrowser..ctor()
  at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
  at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: spile on 2011-07-17 18:17:53
Further to the above, I reverted back to 0.37 and the browse option doesn't cause the app to crash,
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-17 18:28:46
Notice that all images are not 600x600px

Hmm... they aren't 600x600, but they are pretty close. I'm not sure if it wouldn't be more useful to report them as 600x600, so that they get correctly filtered and sorted without needing to download the full sized imaeg. Of course if some were closer to 300 then that would be a different matter, but for a couple of pixels off? Anyway, here's miomusik.boo (http://album-art.sourceforge.net/scripts/miomusik.boo) to try out. I've given that an unknown size, but I think the same applies as for SFR - they are all pretty close to 600, that I've seen...

Just installed the latest update but when I choose the Browse option I get the following....

Thanks for reporting this. It looks like there's a problem with the Windows Imaging Components installed on your PC. I think it's the same error as reported here: post by MC Escher (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=759326). Could you try the same suggestion I made in the next post, of downloading WICExplorer (http://archive.msdn.microsoft.com/wictools/Release/ProjectReleases.aspx?ReleaseId=2887)? Alternatively, you can always stick with v0.37.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-17 19:00:19
One problem with MioMusik; are you sure you want to use the "_CD" in the regex? That way e.g. "metallica / king nothing" search doesn't find the single cover (http://www.miomusik.com/metallica/king_nothing_aint_my_bitch_Single.php). Also notice that there are other links as well for cd's: http://www.miomusik.com/king_jammy/king_at...hits_CD_DVD.php (http://www.miomusik.com/king_jammy/king_at_the_controls_ultimate_hits_CD_DVD.php)

Here's the next one, and last for today (I'll try to post the rest next week): iTunes, with the google site trick, example search (http://www.google.com/search?q=site%3Aitunes.apple.com%2F+%22sahara+hotnights%22+%22Jennie+Bomb%22). You have to get the album page and change the small image URL to get the 600x600px images. Notice again that not all images are 600x600px, example (http://a1.mzstatic.com/us/r2000/004/Music/y2004/m06/d08/h08/s06.zyzyuduh.600x600-75.jpg).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-17 19:39:43
One problem with MioMusik; are you sure you want to use the "_CD" in the regex?

I did that to exclude DVDs, but you're right, there's more variety than that. I guess I'll just include them all and let the user choose the best result. I've updated the script (just deleted the _CD part), if you want to download it again.

I'm not sure about iTunes. In the past Apple have been pretty hostile about downloading cover art, going to the extent of actually encrypting the artwork, so if it's going to end up being an arms race I don't want to take part.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-17 20:00:00
I've a different approach: the images are available through google now, so why not enjoy the ride while it lasts? If they start to get nasty, then just drop the script.. like with albumartexchange a while back. iTunes seems to have pretty good quality 600px covers so it would be a nice addition. I'm off now, maybe more tomorrow.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-18 19:57:18
why not enjoy the ride while it lasts?

Fair enough. But I'm not going to take this one too far if they do start breaking it: itunes-google.boo (http://album-art.sourceforge.net/scripts/itunes-google.boo)

Alex
Title: Album Art Downloader XUI
Post by: Phixion on 2011-07-18 20:50:21
Thank you for making this application, it's really helped me over the last few days.
Title: Album Art Downloader XUI
Post by: seVen on 2011-07-19 00:19:04
Fair enough. But I'm not going to take this one too far if they do start breaking it: itunes-google.boo (http://album-art.sourceforge.net/scripts/itunes-google.boo)


Hi Alex, a small tip, by changing in your script "600x600-75.jpg" with just "jpg" you have the original iTunes album art which is for the vast majority really higher than 600x600, also up to 1500x1500...

Thanks for this cool app!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-19 08:15:06
Thank you for making this application, it's really helped me over the last few days.
Thanks for letting me know, that's always nice to hear :-)

by changing in your script "600x600-75.jpg" with just "jpg" you have the original iTunes album art
Oh, very good. Nice find! I've updated the itunes-google.boo (http://album-art.sourceforge.net/scripts/itunes-google.boo) script with that change.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-19 15:07:50
by changing in your script "600x600-75.jpg" with just "jpg" you have the original iTunes album art
Oh, very good. Nice find! I've updated the itunes-google.boo (http://album-art.sourceforge.net/scripts/itunes-google.boo) script with that change.
Excellent find! And thanks Alex for getting us on the ride.  Small enhancement tip:

searchResultsHtml as string = GetPage("http://www.google.com/search?filter=0&q=site%3Aitunes.apple.com%2F+" + EncodeUrl("\"" + artist + "\" \"download " + album + "\""))

Gets only exact album covers (remember the space after download word). Example (http://www.google.com/search?q=site:itunes.apple.com+%22bo+kaspers+orkester%22+%22download+8%22&filter=0) vs. how it's currently (http://www.google.com/search?q=site:itunes.apple.com+%22bo+kaspers+orkester%22+%228%22).

--------------------------------------------------

2 new script ideas, maybe not good sources (pics/search engine wise), you decide if these are worth a script:

1) CDON.com (http://cdon.eu/search?category=1&q=foo+fighters+wasting+light&x=0&y=0), there might not be very big images for all albums.

2) LyricWiki (http://lyrics.wikia.com/Main_Page), pics are in varying sizes (EDIT: 500 300 (http://images2.wikia.nocookie.net/lyricwiki/images/9/97/Arab_Strap_-_The_Week_Never_Starts_Round_Here.jpg)-~600px what I saw, example 1 (http://images2.wikia.nocookie.net/__cb20110405092215/lyricwiki/images/3/3c/Foo_Fighters_-_Wasting_Light.jpg) & example 2 (http://images2.wikia.nocookie.net/__cb20100803164747/lyricwiki/images/4/43/Metallica_-_ReLoad.jpg)), example search (http://lyrics.wikia.com/index.php?title=Special%3ASearch&redirs=1&search=foo+fighters+skin+and+bones&fulltext=Search&ns6=1&redirs=1&title=Special%3ASearch&advanced=1&fulltext=Advanced+search) (make sure that the only "namespaces" selected is "file").


After these I still have 4 sites, with big big images. More later.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-19 19:01:36
Small enhancement tip:

That does seem to help, yes: updated (http://album-art.sourceforge.net/scripts/itunes-google.boo).

LyricWiki would be a pain to do a script for, as it would need a separate page downloaded for each result. At the moment, I think that unless they are offering either a good selection of art unavailable elsewhere, or higher quality art than other sources, we don't need them. We've got loads of working 'general' sources in the ~600px region now.

What might be a good idea is to stick a Ideas for new scripts (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Ideas_for_new_scripts) page on the wiki just listing these as potential sites to do scripts for in the future, if we need them.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-07-23 13:23:10
Hi Alex and thank you for your excellent work on this tool.

I have a couple of problems with the new iTunes-google script:

1) Sometimes the search doesn't return any result; I think it might be caused by accented characters: try for example with artist: José Luis Perales and album: Tiempo de Otoño - A manual search reveals this (http://a5.mzstatic.com/us/r1000/024/Features/ec/15/ba/dj.sjivgkok.600x600-75.jpg).

2) When the search is successful, if I try a preview and use the zoom slider to, for example, view the image at its original size (hence at 100%) weird things happen: sometimes at 100% a 600px image looks like a 100px or so, other times seems wider, 800px perhaps. The saved image is of the correct size though. Try artist: Julio Iglesias and album: La Carretera to see both anomalies.

As I said, only the new script seems affected: other scripts work normally in both aspects.

Hope my English is comprehensible, if not just ask.

Regards.

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-23 17:21:20
I have a couple of problems with the new iTunes-google script:

Hi, thanks for reporting these. I think 1 is due to the addition of "download " to the google search query in the script, suggested a few days ago. While it does seem to improve accuracy in some cases, it turns out it also effectively excludes any non-English iTunes site - it wasn't the accented characters in your example, it was that the album wasn't available on the English iTunes site.

Here's an updated version of the script with the "download " bit removed, I think it's probably better, on balance, without: itunes-google.boo (http://byalexv.co.uk/foobar/itunes-google.boo). Do let me know if it doesn't find anything you were expecting to find, please.

About your second issue, this is due to the fact that some of the images have got weird DPI settings set for them in their metadata, which instructs WPF to display them at differing natural sizes. I don't know why they should be set like this, but for the next version of AAD I'll make sure the preview window completely ignores them and just shows them at the actual pixel size regardless of the metadata.

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-07-23 19:20:27
Super-efficient, as usual!
While it does seem to improve accuracy in some cases...
So it's expected that the above mentioned example only returns the thumbnail? I haven't tested extensively yet, but if that is the case then perhaps the sacrifice in accuracy isn't justified.

Thanks again.

Alessandro
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-23 19:25:56
by changing in your script "600x600-75.jpg" with just "jpg" you have the original iTunes album art
1) Sometimes the search doesn't return any result; I think it might be caused by accented characters: try for example with artist: José Luis Perales and album: Tiempo de Otoño - A manual search reveals this (http://a5.mzstatic.com/us/r1000/024/Features/ec/15/ba/dj.sjivgkok.600x600-75.jpg).

Alex, there's a problem too with removing the "170x170-75." from the URL with the above example album, the picture doesn't exist! Only the "600x600-75." is found. So you should first try to remove the part and then fall back to the "600x600-75.", and if that doesn't exist, the original 170px.

Ideas for new scripts (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Ideas_for_new_scripts)

Good idea. Maybe the HMVdigital should be added there as an alternative to 7digital and/or HMV Canada?

-------------------------------

Ok, I just tested a bit more this one good site I still hadn't posted here, Nuclear Blast (http://www.nuclearblast.de/en/shop/artikel/gruppen/51000.1.html?article_group_sort_type_handle=rank&custom_keywords=foo%20fighters%20wasting%20light), and it was a disappointment. I could find only few big images #1 (http://www.nuclearblast.de/shop/artikel/bilder/foo-fighters-wasting-light/180138.jpg?x=2500&y=2500) #2 (http://www.nuclearblast.de/shop/artikel/bilder/foo-fighters-the-colour-and-the-shape/152903.jpg?x=2500&y=2500), the rest seem to be only 400px #3 (http://www.nuclearblast.de/shop/artikel/bilder/muse-absolution/155156.jpg?x=2500&y=2500) #4 (http://www.nuclearblast.de/shop/artikel/bilder/coldplay-x-y/136522.jpg?x=2500&y=2500). You decide if it's worth it at all.

I hope the rest of the 3 sites do not disappoint too.

P.S. Have you thought about making an autoupdate system of the program itself? That would be nice.
Title: Album Art Downloader XUI
Post by: wisko on 2011-07-24 05:39:08
Hi guys

i'm having a bit of problem with AAD, and that is i cant see any search results for any artist/album i've tried to find other than what local files containing and not from the other sites.
i believe i did install the application correctly.. however im using AAD v0.40.1.0 & Win7

waiting for a reply
thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-24 09:14:53
Alex, there's a problem too with removing the "170x170-75." from the URL with the above example album, the picture doesn't exist! Only the "600x600-75." is found. So you should first try to remove the part and then fall back to the "600x600-75.", and if that doesn't exist, the original 170px.
That is irritating. I guess the theory that the version without the size suffix is the original doesn't work, then. Weird. Anyway, I've implemented the falling-back behaviour here: itunes-google.boo (http://byalexv.co.uk/foobar/itunes-google.boo).

HMVdigital should be added there as an alternative to 7digital
Sure, done that.

Nuclear Blast is a more heavy metal / rock focussed site, which is good, as we've only got a couple of those so far. In the next version I'm going to make more of an effort to show categories for scripts (at the moment, only the installer has them categorised), so you'll be able to tell that if you're trying to get artwork for your extensive collection of rare Justin Bieber singles, it's not going to be worth having Nuclear Blast selected.

It also turns out to be really nice to do a script for - the only thing that would make it better is if there was a way of knowing what size the full-size image was before downloading it. Here's the script: nuclearblast.boo (http://album-art.sourceforge.net/scripts/nuclearblast.boo)

Have you thought about making an autoupdate system of the program itself?
No, that's not going to happen, sorry. I appreciate that it would be slightly more convenient for users, but it doesn't sit particularly well with the sourceforge release system, and it's a whole lot more complex to code on the client side too.

i cant see any search results for any artist/album i've tried to find
This would be because AAD can't access the internet. Do you use a proxy server? Or maybe you have a software firewall installed? Those would be my best guesses, but in any case there is something on your computer, or network, preventing it from being able to connect to websites over HTTP.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-24 15:37:45
In the next version I'm going to make more of an effort to show categories for scripts (at the moment, only the installer has them categorised)
This is just my hunch but I think that almost all of the AAD users enable all scripts to maximize the chances to get the best artwork. I have only "lastFMartist" disabled. I of course use the "search first" to see the best sources first. For example, you categorized GigaCrate as "dj music" (though that's what the site itself says), but my example album/band (korpi ensemble) which I used to demonstrate the site search is Finnish folk/pop band/music. It's hard to categorize that only as "dj music", whatever that means. Maybe you should put up a poll to see how people use AAD/scripts?

7digital is still messed up and I don't think that they're going to change that soon. The main search box on top of the site uses a "predictive search helper after 4th inputted char" system which only predicts artist names. That might have been there before the site change, I can't remember. Still, it's been a while already and they seem to be happy with the change. If it's not too much trouble to change the script, I'd use the google method now. It would make the script work now + it gets more results (=gets results from all the ~16 country sites). And if that breaks and can't be fixed, then I'd look again the site search if it's working or not. My 2c's.


Next site: djshop.de (http://www.djshop.de/), this is a bit problematic site (as the rest of the sites I still have). If the search results (http://www.djshop.de/?param2=metallica+metallica&submit=&seite=searchresults) have items from the "Vinyl" section, these should be somehow excluded as the images have a "www.content-partner.com" (http://highresfront.vinylbynet.com/1587/1587259.jpg) texts in the right-bottom corner.

If a "CD search" (http://www.djshop.de/Searchresults-CD/ex/s~searchresults,u~cd,p2~metallica+metallica/xe/searchresultsCD.html) is selected, then for another artist/album CD search (http://www.djshop.de/Searchresults-CD/ex/s~searchresults,u~cd,p2~foo+fighters+wasting+light/xe/searchresultsCD.html) there's a problem; it only has results in the "downloads" section (http://www.djshop.de/?seite=searchresults&param2=foo+fighters+wasting+light&submit=).

Then there's the image sizes: only small image (http://www.djshop.de/CD-Metallica-Load/ex/s~details,u~728753,p1~cd/xe/details.html), big image opened from the "detail view" link (http://www.djshop.de/Download-Foo-Fighters-Wasting-Light/ex/s~details,u~8280041240,p1~mp3/xe/details.html) (it doesn't get bigger if image URL is amended) and the big image opened from the "detail view" link which gets bigger when URL changed (http://www.djshop.de/Download-The-James-Taylor-Quartet-The-Template/ex/s~details,u~1000007810,p1~mp3/xe/details.html) to e.g. http://download.feiyr.com/cover/65/3/1000007810_2000.jpg (http://download.feiyr.com/cover/65/3/1000007810_2000.jpg) (which gets a 1200x1200px image).

I hope this site can be used somehow without getting the "watermarked" vinyl section images.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-24 16:33:13
If everyone just installs and enables all scripts all the time, then there's even less point in just adding more and more scripts covering the same selection at the same size. It would be much better to end up with 5-10 good results than pages of very similar results from different sites.

I used DJ Music as the category for GigaCrate as that's how they style themselves. I can't really judge as to whether that's a helpful categorisation or not, really. I'm not going to get into making personal evaluations of the selection available from various sites - if they have a clear stated focus then I'll use that, otherwise I'll leave them uncategorised.

Djshop looks like another one that should go in the DJ Music category to me, but as you point out, it does seem to be a bit of a mess, and watermarks the Vinyl images. I'm not going to do a script for it in time for the 0.41 release, anyway.

Alex
Title: Album Art Downloader XUI
Post by: seVen on 2011-07-24 16:42:07
I guess the theory that the version without the size suffix is the original doesn't work, then.


At 99% it is but for some albums you can have mixed results depending on the various stores, and especially if the album has different labels distribution. For example, with eight results seven can be 170x170, so null, and one 1500x1500. In this case we can presume that only one store has the "original" and the rest can have only the one at 600x600, so with the suffix.
It's true that with some album you have all null results and the one with the suffix is the only "original" so your last revision si sure the better, thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-24 17:28:05
Version 0.41
In this release, the most visible change is that sources are now grouped by category. Previously, this was only done in the installer, but now the category headings can be seen in both the normal sources list, and in the window that lists new sources that are available, and online on the list of available sources (http://album-art.sourceforge.net/Updates.xml) page.

Apart from that, some reported bugs have been fixed:Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.41.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.41.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: spile on 2011-07-24 18:08:01
No this version also crashes when I select the browse option. Back to 0.37 unless anyone knows a fix?

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.41.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'BrowserResults' defined in assembly 'AlbumArt, Version=0.41.0.0, Culture=neutral, PublicKeyToken=null'. Exception has been thrown by the target of an invocation.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/filebrowser.xaml'. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'AlbumArtDownloader.BrowserResults' threw an exception. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
  at System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
  at AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
  at System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
  at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
  at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
  at AlbumArtDownloader.BrowserResults..cctor()
  --- End of inner exception stack trace ---
  --- End of inner exception stack trace ---
  at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
  at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
  at System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
  at System.Activator.CreateInstance(Type type, Boolean nonPublic)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
  at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.FileBrowser.InitializeComponent()
  at AlbumArtDownloader.FileBrowser..ctor()
  at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
  at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: vagskal on 2011-07-24 18:23:32
I am having an issue with the Allcdcovers script. Searching for this album returns only tiny (168x168) album art although much larger, newly added, album art is available: Link (http://www.allcdcovers.com/show/259142/wow_that_was_the_60s_cd2_1999_retail_cd/front)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-24 18:48:41
No this version also crashes when I select the browse option. Back to 0.37 unless anyone knows a fix?
Nothing has changed in this version that would make any difference, the reply (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=763368) I gave before still stands, sorry. Future versions are not likely to change matters for you either; unless you can sort out whatever is wrong with your installed imaging codecs, you can only stick with 0.37 and ignore newer releases.

I am having an issue with the Allcdcovers script.

It's working just fine for me - I put in "Wow That Was The 60s" as Album, leave Artist blank, and get many results. Picking the one for CD2, Front, gives me a 3176*3167 image. Could you check it again, maybe it was a temporary fault with the site?

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-07-24 19:00:50
It's working just fine for me - I put in "Wow That Was The 60s" as Album, leave Artist blank, and get many results. Picking the one for CD2, Front, gives me a 3176*3167 image. Could you check it again, maybe it was a temporary fault with the site?


The script worked when I first tried it on that album and found the large album art. Since the album is an 8 CD box set with a lot of album art the set limitation for the number of results (20) was to low to display all album art. I changed the limit to 30, closed AAD and launched it via an external program again. This time and several subsequent try outs it did not work (only the very low res results were shown/found).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-25 07:50:19
The script worked when I first tried it [...] This time and several subsequent try outs it did not work (only the very low res results were shown/found).

That sounds like the AllCdCovers flood/leech protection system (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=681963). I'd suggest waiting a while (15 minutes has been suggested) and trying again.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-07-25 21:45:27
hey Alex
the iTunes script is a fantastic addition, thanks for it

except that it somehow stopped finding anything, together with eMusic, even for images I did manage to find with those scripts earlier... any thoughts, maybe? did I just use it too much?
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-07-26 00:33:41
some time after it went back to life, and then died again after some heavy using. apparently it has some limitations, which is weird given they weren't they just yesterday.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-26 07:52:55
somehow stopped finding anything, together with eMusic
Both iTunes/Google and eMusic depend on Google for doing the initial search. So, if Google stops returning results for you, both of those stop working. It's possible that Google detected abnormal usage, if you use those scripts too much, or too quickly, or something. Obviously they aren't going to tell us what the criteria are! If it happens again, try doing a search on google.com in your browser and see what happens.

If people are finding that using Google to do the search is too limiting, let me know and I can try a Bing search based one instead. Although, they might have limitations too, of course!

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-30 15:10:35
If everyone just installs and enables all scripts all the time, then there's even less point in just adding more and more scripts covering the same selection at the same size. It would be much better to end up with 5-10 good results than pages of very similar results from different sites.

I think we see this thing very differently, so shortly: I don't see so much redundancy currently (if at all, excluding amazon scripts). Ideally 5-10 results is good, but since the nature of the sites/scripts (site down/changes/dies), I think it would be better to have at least some redundancy. And in the end, I think that the "search first" feature pretty much matches your 5-10 good results ideology.

..new sources that are available, and online on the list of available sources (http://album-art.sourceforge.net/Updates.xml) page.

That online list omits the following scripts: CD Universe, Cover-Paradies, Coveralia, Coverlandia & Discogs.

Also I found out that the "Nuclear Blast" script is shown in the "general" category in AAD, not in the "Punk, Metal, Rock" category as in the online list.

That sounds like the AllCdCovers flood/leech protection system (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=681963). I'd suggest waiting a while (15 minutes has been suggested) and trying again.

I again stress out that it's not 15 minutes of waiting, please read the linked post carefully. "The about 15 minutes is the time when you can see the images in the result list, after that EVERY search to AllCDCovers will yield the leech prevention images", at least that's how it was back then when I tested it.

somehow stopped finding anything, together with eMusic
It's possible that Google detected abnormal usage, if you use those scripts too much, or too quickly, or something. Obviously they aren't going to tell us what the criteria are! If it happens again, try doing a search on google.com in your browser and see what happens.

Most probably you'll see the following:


EDIT: Just to clarify why I posted this; now that you categorize scripts, the "fan-made" category might deter users even trying Coverlandia out though it has pretty good big original album covers as well.

EDIT2: After thinking about it, why not cater to the "fan-made" needs of the users with [a href="http://coverlandia.net/?s=muse+absolution+fanmade&submit=Search" target="_blank"]"Coverlandia - Fan-made" (http://imageshack.us/photo/my-images/684/googleih.png/) script, and use the "normal" Coverlandia script (with the "official" search word trick) in the general category?
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-07-30 15:29:24
Ok, next script idea: Glandigo Music (http://www.glandigomusic.com/). The site has a bad search system for our needs, and even itself has a "google site" search box. So another google search (http://www.google.com/search?filter=0&q=site:www.glandigomusic.com/info.php+%22turin+brakes%22+%22ether+song%22), album page (http://www.glandigomusic.com/info.php?bundle_id=161765), small image (http://download.aim4music.com/shopsupport/download_process/bundle%24artwork.aspx?media_partner_id=22&bundle_id=161765&height=150&width=150), big image (http://download.aim4music.com/shopsupport/download_process/bundle%24artwork.aspx?media_partner_id=22&bundle_id=161765&height=1500&width=1500) (notice the 1500 in the url but 1400 image size). I don't know if there's even bigger images available (the image is obviously created when URL with parameters is requested), but I guess that using 3000 as the max in the URL is enough.

After this, only one script idea left.. I saved the best (but a bit problematic) last.
Title: Album Art Downloader XUI
Post by: seVen on 2011-07-30 18:57:56
Nice Akkurat, thanks. Even if they are a bit too much compressed i have found some needed one.

After this, only one script idea left.. I saved the best (but a bit problematic) last.


When? Where? Tell!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-30 19:45:58
That online list omits the following scripts: CD Universe, Cover-Paradies, Coveralia, Coverlandia & Discogs.
Oops, well spotted! That file is supposed to be auto-generated at compile time, but my autogenerator had a bug in it :-/

I've fixed that now, and also uploaded a fixed CD Universe script. I think the idea of splitting Coverlandia into FanMade and Official versions is a good one, and have therefore uploaded a coverlandia-official.boo (http://album-art.sourceforge.net/scripts/coverlandia-official.boo) script using your suggested "Official" query addition, and modified the original fan made one to have "FanMade" in the query.

This is too fast for google sometimes. I don't have any experience launching AAD for many albums at the same time (I think that this is possible though from what I've read here), but I guess that that could "irritate" google the same way as my "speed browsing".
That sounds quite likely. It means that I should absolutely avoid doing any more scripts which depend on a google search - even having eMusic and iTunes running simultaneously seems to be enough to trigger it for some people, so if I had more scripts running simultaneous google searches it would make it even worse!

If anyone is experiencing the google problem often (symptoms are that the GoogleImage, eMusic and iTunes/Google scripts stop producing results after a few searches) then please try using this script instead, and see if it helps: itunes-bing.boo (http://album-art.sourceforge.net/scripts/itunes-bing.boo). If it does, then I'll retire iTunes/Google and replace it by this iTunes/Bing one instead.

Ok, next script idea: Glandigo Music (http://www.glandigomusic.com/). The site has a bad search system for our needs
You are right, their search is completely hopeless. Did you notice that all their images come from "aim4music.com", though? That site seems to be under maintenance of some sort, but if it comes back with a search of its own, it would make sense to go straight to the source and ignore Glandigo as a middle-man. Maybe worth giving it a week or two and see what it comes up with? If they are redoing it, then chances are they'd change the current image links at that time anyway...

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-07-31 09:13:57
Next site: djshop.de (http://www.djshop.de/)

Here's a script for the DJshop downloads: djshop.boo (http://album-art.sourceforge.net/scripts/djshop.boo). The way the site is organised, it would have to be a separate script for CD or Vinyl searches. As you pointed out, Vinyl has the watermark on the images, and the CD results I found were pretty poor - 300x300 at most. Unless they have covers for CDs that aren't available elsewhere, I don't think 300x300 CD images are worth having another script for.

Alex
Title: Album Art Downloader XUI
Post by: kosmarnik on 2011-08-01 19:51:47
noob question:
I have a few thousand albums to grab covers for, and on the first try it wanted to grab a cover for every song :/
Not good.
All the albums are saved in their own directories and 98% have 'artist - album' directory name.
How do I go about it?
Also, what is the best way to automate it as much as possible?

Should I first find/run a ID3 tag cleaner (tags on the mp3's are iffy at best)?

Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-01 21:12:31

If your tags are iffy, but the directory naming is 98% good, then use file path pattern matching in the File Browser (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=The_File_Browser) (click the Options link in the File Browser window to see this option). The pattern you want would probably be "\%artist% - %album%\." (no " marks). It's also a lot faster than using tags.

To automate as much as possible, you'd want to use Automatic Image Downloading (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Automatic_Image_Downloading), but I'd recommend you try a few one at a time first, to get a good idea of the sorts of results you want, so you can choose the right source(s) and filter criteria to use before kicking off a big automated job.

Good luck!

Alex

Title: Album Art Downloader XUI
Post by: dubwai on 2011-08-01 21:48:11
AlexVallat it's possible to make searche in ebreggae.com in the stock items. For example Trojan Roots Box Set AAD found good, but it can't find Trojan Reggae Duets Box Set because it out of stock. I can find it only in google with this string "Trojan Reggae Duets Box Set site:ebreggae.com"
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-02 08:01:55

I've had a good look around the ebreggae site and can't find any way of getting it to include out-of-stock items in the search results, sorry.

I am not going to have google do the searching for this site, as it looks like google prevents access if you use it too quickly or too much, so having multiple simultaneous searches (which would be the case if I had several scripts all using it for their searches) would likely trigger their protection mechanism.

Alex
Title: Album Art Downloader XUI
Post by: kosmarnik on 2011-08-02 11:59:16


To automate as much as possible, you'd want to use Automatic Image Downloading (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Automatic_Image_Downloading), but I'd recommend you try a few one at a time first, to get a good idea of the sorts of results you want, so you can choose the right source(s) and filter criteria to use before kicking off a big automated job.


Thank you! That set me off in the right direction.

Though my directories are messy, but not that bad (I have no idea why people cram that much stuff in a directory name anyway).
I guess a little perl regex will go a long way to clean it up.

I have a beef with the auto-downloader interface.
It's cumbersome to see at a glance what cover is for what album. I had to click on every album to see it's cover.

It would be much better to have the scanned album name close to the downloaded one. Ditto for correcting, I'd rather have to click/right click on the downloaded cover to have the search pop-up, then go through the list.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-02 13:37:20
I'd rather have to click/right click on the downloaded cover to have the search pop-up, then go through the list.

Unless I've misunderstood, this is already possible. If you right click on one of the results in the bottom area automatic image download window the bottom entry on the menu should be "Search in New Window", which is the same command as appears when you right click one of the results in the list area.

Alex
Title: Album Art Downloader XUI
Post by: kosmarnik on 2011-08-02 14:13:03
I'll try it, but it still doesn't deal with showing what album is that cover for :|
Title: Album Art Downloader XUI
Post by: spile on 2011-08-10 12:07:08
No this version also crashes when I select the browse option. Back to 0.37 unless anyone knows a fix?

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

Can anyone offer any help re this?
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-11 00:14:52
Alex, there's a problem too with removing the "170x170-75." from the URL with the above example album, the picture doesn't exist! Only the "600x600-75." is found. So you should first try to remove the part and then fall back to the "600x600-75.", and if that doesn't exist, the original 170px.


Hey Alex and Akkurat.
If removing the "170x170-75." part from the iTunes-URL does not work, try ".tif" instead of ".jpg". This should solve the problem.

some of the iTunes images are tifs others are jpgs. the rescaling function (i.e. 600x600-75 or 170x170-75) always returns jpgs.
yours thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-11 08:22:14
If removing the "170x170-75." part from the iTunes-URL does not work, try ".tif" instead of ".jpg". This should solve the problem.

Great find! I'll still leave the 600x600 rescaled image in as a last resort, but will try .tif first.

Here are the updated scripts:
itunes-google.boo (http://www.byalexv.co.uk/foobar/itunes-google.boo)
itunes-bing.boo (http://www.byalexv.co.uk/foobar/itunes-bing.boo)

I only know of one result which used to return a rescaled jpeg and now returns a (sadly still only 600x600) tiff, so if anyone knows of more examples to test them with, please let me know how they get on.

Also, has anyone been trying out the iTunes/Bing script? I've found a couple of cases where Bing hasn't been able to find an album that Google has, for some reason, but also Bing has never stopped working because I've done too many searches on it too quickly. I'm not sure which one to choose.

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-11 13:32:49
Hey Alex,
here is an example for a larger tif from the iTunes Store:
http://a4.mzstatic.com/us/r1000/048/Music/...zi.cyomhscs.tif (http://a4.mzstatic.com/us/r1000/048/Music/b6/b3/d3/mzi.cyomhscs.tif)

I had some cases where google didn't find an album from the iTunes store. You may help yourself going the "manual" way:
Use iTunes to search and browse in the iTunes store, instead of using the google search. If you've found the album you're looking for, right click on the image and select "copy link" and paste it into the adress field of your internetbrowser.

I have another suggestion:
Some Amazon images are zoomable and return really large Albumart compared to amazon's standard 500x500 pictures.
You may adress the Zooming pics using the "_SRCM_" extension as described here:
http://aaugh.com/imageabuse.html (http://aaugh.com/imageabuse.html)

Here are two examples from "amazon.de" (i.e country code is set to ".03."):
http://ec2.images-amazon.com/images/P/B004...A.03._SCRM_.jpg (http://ec2.images-amazon.com/images/P/B004HH1NNA.03._SCRM_.jpg)
http://ec2.images-amazon.com/images/P/B004...Y.03._SCRM_.jpg (http://ec2.images-amazon.com/images/P/B004KUEGRY.03._SCRM_.jpg)

Is it possible to adapt the Amazon scripts to adress also the zooming pictures?
yours thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-11 18:40:14
Use iTunes to search and browse in the iTunes store, instead of using the google search.
Hmm... I wonder if whatever web service iTunes uses for searching is exposed anywhere - it would certainly be nice to be able to search iTunes without getting a separate search engine exposed.

You may adress the Zooming pics using the "_SRCM_" extension as described here:
http://aaugh.com/imageabuse.html (http://aaugh.com/imageabuse.html)
That is a very interesting page. I have created an updated version of amazon-common.boo (http://www.byalexv.co.uk/foobar/amazon-common.boo) which tries to get an SRCM image, and if that fails, falls back to an SCL (large - usually 500x500ish) image. From a bit of quick testing, SRCM's aren't that common, but there are certainly a few around.

If you replace the existing amazon-common.boo with this one, then all amazon scripts will be using the new system. If you notice any problems with it, please let me know. Otherwise, I'll roll it out as an upgrade for the official amazon script in a few days.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-11 20:30:56
Hmm... I wonder if whatever web service iTunes uses for searching is exposed anywhere

Good news, it is! This means I can do a pure iTunes search without involving Google or Bing, and involving far less server round-tripping as it doesn't have to fetch the iTunes web page for each album to get the thumbnail. I'm not usually much of a fan of Apple's, but I've got to admit, this is the way an API ought to be done.

The downside is that it only searches the US store. You can choose to search a different one, but not to search across all stores, which is a shame.

Try it out here: itunes.boo (http://www.byalexv.co.uk/foobar/itunes.boo)

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-12 02:17:14
Hi Alex,

Good news, it is! This means I can do a pure iTunes search without involving Google or Bing, and involving far less server round-tripping as it doesn't have to fetch the iTunes web page for each album to get the thumbnail. I'm not usually much of a fan of Apple's, but I've got to admit, this is the way an API ought to be done.

Great work! The new iTunes script is much faster than the Google/Bing search! Moreover it finds more than one album in contrast to the old Google/Bing method (that tends to find a lot of duplicates). The new Amazon script also works fantastic.
From now on this program is definitely the best album art downloader of the world!

The downside is that it only searches the US store. You can choose to search a different one, but not to search across all stores, which is a shame.

This could explain why I still cannot find some covers from the german iTunes Store. May you please offer different iTunes scripts for different countries?

Thanks so much,
Thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-12 08:06:34
May you please offer different iTunes scripts for different countries?
That could be done, in a similar way to the way Amazon is handled now. The only difficulty is in knowing which countries to do. The only list I can find is the main apple site country chooser: http://www.apple.com/choose-your-country/ (http://www.apple.com/choose-your-country/), but I doubt they have different iTunes catalogues for every one of those. If they do, that would be a lot of scripts to make available!

I'm glad the new amazon script is working out so far, thanks for letting me know.

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-12 10:43:56
The only difficulty is in knowing which countries to do.

Hmmm. My iTunes gives me 123 different countries to choose. It would be nice to have a dropdown menu or a selection page, to choose the store(s). Or even better: The scripts beloging together may be grouped in the sources list (i.e. the Amazon/iTunes/Coverlandia/LastFM...)?
yours thomian
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-12 13:45:03
I have listed all iTunes countries with their country ISO codes. Hope that helps:

Code: [Select]
Algeria - DZ
Angola - AO
Anguilla - AI
Antigua and Barbuda - AG
Argentina - AR
Armenia - AM
Australia - AU
Azerbaijan - AZ
Bahamas - BS
Bahrain - BH
Barbados - BB
Belarus - BY
België/Belgique - BE
Belize - BZ
Bermuda - BM
Bolivia - BO
Botswana - BW
Brazil - BR
British Virgin Islands - VG
Brunei Darussalam - BN
Canada - CA
Cayman Islands - KY
Česká republika (Czech republic) - CZ
Chile - CL
Colombia - CO
Costa Rica - CR
Cyprus - CY
Denmark - DK
Deutschland (Germany) - DE
Dominica - DM
Ecuador - EC
Eesti - EE
Egypt - EG
El Salvador - SV
España (Spain) - ES
France - FR
Ghana - GH
Greece - GR
Grenada - GD
Guatemala - GT
Guyana - GY
Honduras - HN
Hong Kong - HK
Hrvatska (Croatia) - HR
Iceland - IS
India - IN
Indonesia - ID
Ireland - IE
Israel - IL
Italia - IT
Jamaica - JM
Jordan - JO
Kazakhstan - KZ
Kenya - KE
Kuwait - KW
Latvija (Latvia) - LV
Lebanon - LB
Lietuva (Lithuania) - LT
Luxembourg - LU
Macau - MO
Macedonia - MK
Madagascar - MG
Magyarország (Hungary) - HU
Malaysia - MY
Mali - ML
Malta - MT
Mauritius - MU
México - MX
Moldova - MD
Montserrat - MS
Nederland (Netherlands) - NL
New Zealand - NZ
Nicaragua - NI
Niger - NE
Nigeria - NG
Norge (Norway) - NO
Oman - OM
Österreich (Austria) - AT
Pakistan - PK
Panamá - PA
Paraguay - PY
Perú - PE
Philippines - PH
Polska (Poland) - PL
Portugal - PT
Qatar - QA
República Dominica - DM
Romania - RO
Saudi Arabia - SA
Schweiz/Suisse (Switzerland) - CH
Sénégal - SN
Singapore - SG
Slovakia - SK
Slovenia - SI
South Africa - ZA
Sri Lanka - LK
St. Kitts & Nevis - KN
St. Lucia - LC
St. Vincent & The Grenadines - VC
Suomi (Finland) - FI
Suriname - SR
Sverige (Sweden) - SE
Tanzania - TZ
Thailand - TH
Trinidad and Tobago - TT
Tunisie - TN
Türkiye (Turkey) - TR
Turks & Caicos - TC
Uganda - UG
United Kingdom - GB
United Arab Emirates - AE
United States - US
Uruguay - UY
Uzbekistan - UZ
Venezuela - VE
Vietnam - VN
Yemen - YE
България (Bulgaria) - BG
Россия (Russia) - RU
China - CN
Taiwan - TW
Japan - JP
South Korea - KR

If I had to choose, I would take the following:
US, CA, GB, DE, FR, IT, SE, JP, RU, AR, BR

I've found some interesting links about the search API:
http://www.apple.com/itunesaffiliates/API/...esSearch2.1.pdf (http://www.apple.com/itunesaffiliates/API/AffiliatesSearch2.1.pdf)
http://www.apple.com/itunes/affiliates/res...search-api.html (http://www.apple.com/itunes/affiliates/resources/blog/introduction---search-api.html)

yours Thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-12 14:07:46
Yes, that's the documentation I used for the API. It's a shame the API doesn't allow you to choose "any" as the country to search. The issue, as I see it, is not figuring out what the country codes are, but rather that I'm not going to ship 123 iTunes scripts with AAD. You just know people are going to install all of them and search the whole lot each time, swamping results from any other source.

Unfortunately the current script architecture doesn't support having custom UI for a script, so I can't put in a dropdown picker to let you choose the country you want to search. Even if it did, that system wouldn't allow you to search multiple countries - I imagine people might well want to search two or three countries, so I'd prefer a system that allows you to have a multiple choice of countries to search.

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-12 15:12:54
I agree... It's the same for the Amazon scripts. I have no Idea...
For first I've adapted your script for the german store by myself.
thanks
thomian
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-12 15:48:42
playing around I've just realized that not all country codes work. e.g. searching the argentinian (AR) store returns nothing! Same with the russian store. Later on I will figure out, which countries work.
yours
thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-12 17:10:56
playing around I've just realized that not all country codes work.
Where did you get that list from, originally? I've just knocked up a bit of code to run through an produce iTunes country-specific script overrides (like the Amazon ones), and found that too. So I put in a check to do a quick search (for "_") and see if anything came back at all. The ones which I found to work are:

Code: [Select]
Australia (AU)
België/Belgique (BE)
Canada (CA)
Denmark (DK)
Deutschland (Germany) (DE)
España (Spain) (ES)
France (FR)
Greece (GR)
Ireland (IE)
Italia (IT)
Luxembourg (LU)
México (MX)
Nederland (Netherlands) (NL)
New Zealand (NZ)
Norge (Norway) (NO)
Österreich (Austria) (AT)
Portugal (PT)
Schweiz/Suisse (Switzerland) (CH)
Suomi (Finland) (FI)
Sverige (Sweden) (SE)
UK (GB)
Japan (JP)
What I could do is not include them with AAD or through the normal online updates, but have a wiki page where you can download any of them you want. You would need the original itunes.boo (which searches the USA store), then as many of the country-specific overrides as you wanted. I don't want there to be any way for you to accidentally end up with all of them, though. If you really want every single one, you'll have to explicitly download them all.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-13 09:41:44
Script updates
I've just published through Online Updates the updated Amazon scripts (using thomian's info (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=765722)), DJShop, and iTunes (using iTunes search API).

Country-specific overrides to search stores other than the main USA one are available here: iTunes Country-Specific Searches (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches), but will not show up in the online updates "new scripts" notification, or be bundled with the installer. They depend on having the main itunes.boo (http://album-art.sourceforge.net/scripts/itunes.boo) script installed, and only that main script will need to be updated if future changes are required.

The iTunes/Google (http://album-art.sourceforge.net/scripts/itunes-google.boo) and iTunes/Bing (http://album-art.sourceforge.net/scripts/itunes-bing.boo) scripts are now deprecated. They are still available for download (including the latest changes to support full-sized tiff images), and will continue to work until either iTunes, Google or Bing change their site layout, but will not be included in online updates, or future installers.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-08-13 10:16:14
Hey Alex
it seems that discogs script has some problems as I don't get any results from it lately

thanks for the work, as usually
Title: Album Art Downloader XUI
Post by: spile on 2011-08-13 12:38:13
Have tried uninstalling version 0.37 and reinstalling latest version but it still crashes when I use the browse option...

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

Code: [Select]
App version: 0.41.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'BrowserResults' defined in assembly 'AlbumArt, Version=0.41.0.0, Culture=neutral, PublicKeyToken=null'. Exception has been thrown by the target of an invocation.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/filebrowser.xaml'. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'AlbumArtDownloader.BrowserResults' threw an exception. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
   --- End of inner exception stack trace ---
   at System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
   at System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
   at AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
   at System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at AlbumArtDownloader.BrowserResults..cctor()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
   at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
   at System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
   at System.Activator.CreateInstance(Type type, Boolean nonPublic)
   at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
   --- End of inner exception stack trace ---
   at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
   at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
   at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
   at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
   at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
   at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
   at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
   at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
   at System.Windows.Markup.TreeBuilder.Parse()
   at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
   at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
   at AlbumArtDownloader.FileBrowser.InitializeComponent()
   at AlbumArtDownloader.FileBrowser..ctor()
   at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
   at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
   at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: MC Escher on 2011-08-13 16:35:56
@Spile:
That looks like a problem I had some pages back. For me the problem appeared to be in Windows XP's environment variables. If you go to Control panel --> System --> Advanced --> Environment variables you'll see "Path" under system variables. Double click on it and check the line for anything put there by 3rd party programs. Delete those parts and try again.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-13 17:19:45
it seems that discogs script has some problems as I don't get any results from it lately
Ooh, it looks like Discogs has a shiny new API to play with. Here's an updated script that should work with it: discogs.boo (http://www.byalexv.co.uk/foobar/discogs.boo). It's a major change, though (pretty much a re-write), so if you could give it a go and let me know any problems with it before I publish it through online updates, I'd appreciate it.

Have tried uninstalling version 0.37 and reinstalling latest version but it still crashes when I use the browse option...
I'm sorry Album Art Downloader is not working for you, but I can't give you any other answer than the one I've already (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=763368) given. There is something wrong with the Windows Imaging Components installed on your PC. No new version of Album Art Downloader is going to fix that.

Quote from: MC Escher link=msg=0 date=
check the [system path] for anything put there by 3rd party programs. Delete those parts and try again.
I'd be very interested to know what the part of the Path that caused the issue was - I don't suppose there's any chance you recorded what it was before deleting it, is there?

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-13 18:00:34
Back, finally, I can't believe how fast time goes.. and it's summer too, don't want to miss that completely.

Ok, next script idea: Glandigo Music (http://www.glandigomusic.com/)
Did you notice that all their images come from "aim4music.com", though? That site seems to be under maintenance of some sort, but if it comes back with a search of its own, it would make sense to go straight to the source and ignore Glandigo as a middle-man. Maybe worth giving it a week or two and see what it comes up with?

IIRC the site has been like that for some time already (=months, could be many months). The site in 2007 (http://web.archive.org/web/20070404075505/http://www.aim4music.nl/a4m/text.php?id=65) and 2009 (http://web.archive.org/web/20090517204859/http://site.aim4music.nl/text.php?id=17) tells e.g. that: "Aim4Music offers a flexible solution which is fast and easy to implement. The result is a custom-made website that completely integrates with the platform using our tools, whilst maintaining your own identity and quality.".. I think that they're only providing content for other website stores.

I can do a pure iTunes search without involving Google or Bing, and involving far less server round-tripping as it doesn't have to fetch the iTunes web page for each album to get the thumbnail. I'm not usually much of a fan of Apple's, but I've got to admit, this is the way an API ought to be done.

The downside is that it only searches the US store. You can choose to search a different one, but not to search across all stores, which is a shame.

Hey, can't you write a loop where you try to get images from different itunes stores (starting from "big" countries going through all stores) until you get some results and then stop the loop? For example, now searching for "José Luis Perales / Tiempo de Otoño" doesn't get any results from the script. Why not just loop back and do the same search with the next country store? I don't see why it shouldn't work, just as long as there are not ~100 stores to go through. You have 22 alternative stores, so 23 stores all and all. If you arrange them wisely (e.g. first US, CA, GB, DE, ..., SE, FI, LU) on most cases the first stores gets the job done fast. If something obscure is searched, I'm sure the user won't mind the extra wait of script going through several stores, as long as the chances of getting an artwork increases.

API done right, really? It doesn't fetch exact album results at all. Which might make it harder to implement the "loop stores" method above.

Discogs has a shiny new API to play with. Here's an updated script that should work with it: discogs.boo (http://www.byalexv.co.uk/foobar/discogs.boo).

Seems to work.

--------

To Ideas for new scripts (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Ideas_for_new_scripts) page: WantItAll.co.za (http://www.wantitall.co.za/) ?
Title: Album Art Downloader XUI
Post by: Jlo7551 on 2011-08-13 18:04:09
Hi-Bit of a newbie here-downloaded AAD recently and was working fine until I updated my iTunes-Now I get a blank when I try to copy a cover into the iTunes window
Title: Album Art Downloader XUI
Post by: MC Escher on 2011-08-13 18:37:38
Quote from: MC Escher link=msg=0 date=
check the [system path] for anything put there by 3rd party programs. Delete those parts and try again.
I'd be very interested to know what the part of the Path that caused the issue was - I don't suppose there's any chance you recorded what it was before deleting it, is there?

Alex


If I remember correctly, there were two (or maybe three) additions made by third party programmes, one of which was The Gimp. I removed them all so I don't know which one was to blame.
Interesting side effect: if I called system programmes like chkdsk from cmd.exe, the command was not recognised unless I navigated to C:\Windows\system32\ first. There was nothing wrong with the path %SystemRoot%\system32 and even adding C:\Windows\system32\chkdsk.exe at the beginning of the line didn't work, until I removed all the crap.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-13 19:11:37
Welcome back!

I had a look to see if I could find anything else using aim4music that had a working search feature. http://www.mega-media.nl/ (http://www.mega-media.nl/) does reasonably well - I can search by album title and get useful results, but would then have to filter by artist within the script itself. Still, I don't have anything Netherlands-focussed sources yet, so it might be worth doing.

I don't really want to start performing multiple searches in a single script, and I don't think people would agree on the right order to search them in anyway. Thanks for the suggestion, but I'm going to stick with one script per country store. What I meant by the API done right was that it doesn't require any sort of sign-up or key, and it returns all the relevant information from a single http GET. Something I'd really like to see in other APIs.

I've added WantItAll to the wiki page. The results I saw were just some more ~500px covers, and the usual sort of selection in the catalogue - nothing outstanding about the site, but it doesn't look hard to work with if a reason to use it does come up.

Interesting side effect: if I called system programmes like chkdsk from cmd.exe, the command was not recognised unless I navigated to C:\Windows\system32\ first. There was nothing wrong with the path %SystemRoot%\system32 and even adding C:\Windows\system32\chkdsk.exe at the beginning of the line didn't work, until I removed all the crap.
That is interesting. I have no idea how adding extra stuff to the path can stop the standard "%SystemRoot%\system32;%SystemRoot%;" entries at the start from applying, but certainly not having those directories in the system path would cause all sorts of badness. @spile, if you wouldn't mind posting the contents of your path variable, I can try setting mine to the same value and seeing if I can reproduce the problem.

Alex
Title: Album Art Downloader XUI
Post by: db1989 on 2011-08-13 20:18:29
Alex, please note this newly merged-in post (previously its own topic but hardly seems to require that):
Hi-Bit of a newbie here-downloaded AAD recently and was working fine until I updated my iTunes-Now I get a blank when I try to copy a cover into the iTunes window
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-14 07:57:12
Thanks, db1989. @Jlo7551[a href="index.php?act=findpost&pid=765986"][{POST_SNAPBACK}][/a], I'm going to need a little more detail to be able to help. Can you paste into any other application: Paint, for example? Is it only certain covers that can't be pasted, or all of them? Do you get any error message appearing when you try to copy the cover? Have you already seen the full-size image, or did it have to download it before completing the copy operation? A little globe symbol appears in the top left of the cover while it is downloading.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-08-14 07:58:46
Hey Alex
it seems that discogs script has some problems as I don't get any results from it lately

thanks for the work, as usually

hey, I heat to repeat myself, but it seems that the discussion drifted too far away from my post. sorry.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-14 08:16:49
hey, I heat to repeat myself, but it seems that the discussion drifted too far away from my [discogs] post. sorry.
Guess you must have missed my reply (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=765983)!  Discogs have made a new API, and I've updated the Discogs script to access it: discogs.boo (http://www.byalexv.co.uk/foobar/discogs.boo)

Early indications are that it's working fine, so unless you report any problems with it, I'll probably publish it through online updates later today.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-14 09:40:42
As promised, a Mega Media (aim4music.nl back-end) script: megamedia.boo (http://album-art.sourceforge.net/scripts/megamedia.boo).

As ever, please let me know of any issues with it.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-14 13:26:26
I don't really want to start performing multiple searches in a single script, and I don't think people would agree on the right order to search them in anyway. Thanks for the suggestion, but I'm going to stick with one script per country store. What I meant by the API done right was that it doesn't require any sort of sign-up or key, and it returns all the relevant information from a single http GET.

Ok, now I understand the API part. I'm actually surprised that apple doesn't have any sign-up or key to their API.

About multiple searches: the best part is that people could choose the order & stores used. How? Just put an array variable with countrycodes to the script which can be easily edited. Or allow more than 1 additional scripts enabled simultaneously. Which brings me to; did I understand the additional country store scripts correctly: one can enable only 1 store search at the same time? That's a bit of a bummer.. especially for "batch searchers". Well, I guess you can't have everything.

As promised, a Mega Media (aim4music.nl back-end) script: megamedia.boo (http://album-art.sourceforge.net/scripts/megamedia.boo).

When searching "turin brakes / ether song" there's one "empty" result (no picture) which refers to this page (http://www.mega-media.nl/info.php?lid=415473). I guess you have to check that the picture is actually there, not just an album page.

And I'm curious, how/why did you categorize the script as "Netherlands"? Why not "general"? Does it have mainly Dutch artists? No, just checking the artists page (http://www.mega-media.nl/artiesten.php) (and doing some searches) tells me that it's really a general script, artists all over the world. It's the same thing as e.g. "Canadian" "HMV Canada" script, it's more of an general script IMHO. I always test new scripts so I'm not worried, but some other users may be confused and think that the script is only for Dutch artists (category Reggae means reggae music, right? And Dance/Trance means certain type of music, so what does Netherlands mean? I haven't seen any "Netherlands" music type yet, so it must mean Dutch artist, right? That's ok if the site/script has mostly that kind of artists.). What good does it do to categorize a script based on it's top-level domain? (IF that is what you've done) IIRC, I initially said that it might be hard to categorize scripts, and to me now it looks like that you're trying too hard to categorize scripts out of the general cat. I don't know, some of your categories baffle me a lot.  (phew, that was long, sorry! ) Anyways, a million thanks again for another script!

I still have one very good source (with seemingly unlimited sizes AND picture quality URL switch!), but do you want to hear about it at all since it's only usable with google?
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-14 14:47:16
Just tried it and they have yet again added more protection measures (this has happened twice already before this), this time "services are not yet available in your country" checking & redirecting.. now one has to use google AND its "Cached" feature to get the images. So it's still available but how long?

Ok, the site is Deezer (http://www.deezer.com). (I can only see a "Deezer's music services are not yet available in your country." page wherever I try to go.)

It has been a struggle to find a perfect google search method, but I think that the following is ok: example #1 (http://www.google.com/search?q=site%3Awww.deezer.com%2Fen%2Fmusic%2Fslash%2Fslash), example #2 (http://www.google.com/search?q=site%3Awww.deezer.com%2Fen%2Fmusic%2Fbo-kaspers-orkester%2Fhund), example #3 (http://www.google.com/search?q=site%3Awww.deezer.com%2Fen%2Fmusic%2Ffoo-fighters%2Fwasting-light).

Then use the "Cached" link to retrieve a page and find an image URL (http://cdn-images.deezer.com/images/cover/THISPARTCHANGES/120x120-000000-80-0-0.jpg) with regexp.

Next change the size (obviously the 120x120 part in the URL) to something you like. It seems that there's no limit at all! Though I haven't tested SICKLARGE  sizes in fear of crashing browser. EDIT: I got 9000x9000px with 80 quality (it takes a while) but 10000x10000px with the same quality was too much for the browser, it time-outed the page request (it takes too long for the site to make the image on-fly).

And finally the quality switch (the "80" in the URL) to 100, compare here: quality 80 (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/1000x1000-000000-80-0-0.jpg) Vs. quality 100 (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/1000x1000-000000-100-0-0.jpg) (compare the circles in the shirt for reduced artifacts in the quality 100 image).

There seems to be some kind of an API available (http://www.google.com/search?q=deezer+%22api%22) (I can't reach it).


That's it. That was my last source. All in all, I counted that my suggestions yielded almost 10 new scripts. I'm happy that I could share those with you.. and I'm happy that I can scratch off this task from my to-dos and move to the next in my never ending list.
Title: Album Art Downloader XUI
Post by: godrick on 2011-08-14 16:14:35
Is there an easy way (or different easy ways) to launch the Foobar Browser from within Foobar2000?  I recall (perhaps incorrectly) I was able to do this in the past, but can't remember how.

I do know how to launch Foobar Browser while I'm in AAD, and I know I have the COM automation component correctly installed and working in Foobar.  thanks.
Title: Album Art Downloader XUI
Post by: Jlo7551 on 2011-08-14 16:43:10
Thanks, db1989. @Jlo7551[a href="index.php?act=findpost&pid=765986"][{POST_SNAPBACK}][/a], I'm going to need a little more detail to be able to help. Can you paste into any other application: Paint, for example? Is it only certain covers that can't be pasted, or all of them? Do you get any error message appearing when you try to copy the cover? Have you already seen the full-size image, or did it have to download it before completing the copy operation? A little globe symbol appears in the top left of the cover while it is downloading.

Alex


Alex-It applys to all covers and I'm suddenly unable to paste the image anywhere-even my desktop(tried that as a test)-I'm not getting any error messages or warnings of any kind-The images just won't paste(or copy) properly-They didn't show up at all when I tries to paste to the desktop as a test and they show up as a blank square in iTunes-I am able to load and view the full size image properly-The issue only arises once I try to copy to iTunes-And as areminder, this only started with an iTunes update a few days ago-Hope that helps with the info you need
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-08-14 18:45:42
hey, I heat to repeat myself, but it seems that the discussion drifted too far away from my [discogs] post. sorry.
Guess you must have missed my reply (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&view=findpost&p=765983)!  Discogs have made a new API, and I've updated the Discogs script to access it: discogs.boo (http://www.byalexv.co.uk/foobar/discogs.boo)

Early indications are that it's working fine, so unless you report any problems with it, I'll probably publish it through online updates later today.

Alex

sorry, I'm amazed I managed to miss it
thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-14 19:31:44
did I understand the additional country store scripts correctly: one can enable only 1 store search at the same time?
No, you can have as many as you like, it should work fine. It's a bit redundant to install them all, but if you really must, then nothing is stopping you.

I guess you have to check that the picture is actually there, not just an album page.
Well that's a pain. I'll see what I can do.

And I'm curious, how/why did you categorize the script as "Netherlands"?
If you've got a better suggestion for a name for the category, I'm open to it. I chose Netherlands because it has albums like these (http://www.mega-media.nl/chart.php?type=nl) (which are hard to find on other General sources), and it does not have a lot of the artists I use on my standard test searches (for example: Muse, Ash, The Offspring). I think it's more helpful to suggest that if you are looking for Dutch music, this would be a good script to try.

I'm open to better category suggestions, but as you guess, I do want to avoid "General" as much as possible, as that gives you no information about why you might want to install that script or not.

the site is Deezer (http://www.deezer.com). (I can only see a "Deezer's music services are not yet available in your country." page wherever I try to go.)
Deezer looks interesting. I can't see anything other than 'not available yet' either, but strangely I can access their API: Example (http://api-v3.deezer.com/1.0/search/artist/?q=muse&index=0&nb_items=2&output=xml). Can you? If you can't, then chances are it isn't worth doing a script for as I can't rely on it working for anyone else, but if you can then all I need to do is figure out the API interface and it should be doable. The fact that you can get unlimited sizes of images suggests they are just being resized on the fly, so what I'll need is some way of figuring out what the native size of the image is. It's not really helpful to download a 9000x9000px image that was generated by the server resizing a 600x600 native one!

That's it. That was my last source. All in all, I counted that my suggestions yielded almost 10 new scripts. I'm happy that I could share those with you.. and I'm happy that I can scratch off this task from my to-dos and move to the next in my never ending list.
Nice work in finding them! I hope people find them useful, thank you.

Is there an easy way (or different easy ways) to launch the Foobar Browser from within Foobar2000?
I would suggest using foo_run, and giving it the command line "C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /foobarBrowser (adjusting for where you've installed it, if necessary). Or /foobarBrowser search if you prefer it to start searching immediately too.

Alex-It applys to all covers and I'm suddenly unable to paste the image anywhere-[...] this only started with an iTunes update a few days ago
Thanks for the additional info. If you exit iTunes completely (which can be tricky to do, it loves to keep itself running), can you then copy and paste elsewhere? Can you copy and paste images from other programs (like your web browser)? I found this thread (https://discussions.apple.com/message/15745419) which suggests it's an iTunes problem, but if it is still happening even if iTunes is not running (or even better, not installed!) then something else must be wrong...

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-14 20:19:58
Updated megamedia.boo (http://album-art.sourceforge.net/scripts/megamedia.boo) (now checks for and excludes blank images)

For testing: deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo)
If people could let me know if it works for them or not, and which country they are in, that would be helpful. Unless you are in a Deezer-supported country, the info Url (small (i) button) will probably just show you a "Deezer not available in your country" page, but at least for the moment the actual search and images seem to work.

I'm using "0x0-000000-0-0-0.jpg" as the suffix for Deezer, which (as I hoped) appears to give the native size and quality. They are all around 1400x1400, which is pretty good.

Alex
Title: Album Art Downloader XUI
Post by: GHammer on 2011-08-15 15:43:00
For testing: deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo)
If people could let me know if it works for them or not, and which country they are in, that would be helpful. Unless you are in a Deezer-supported country, the info Url (small (i) button) will probably just show you a "Deezer not available in your country" page, but at least for the moment the actual search and images seem to work.

Alex


The plugin work here in the USA, though it's 'not available in your country'

The two items I searched for returned 1417 x 1417 sized images.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-16 15:36:40
No, you can have as many as you like, it should work fine. It's a bit redundant to install them all, but if you really must, then nothing is stopping you.

Ok, thanks for correcting me.. ATM I'm going to use the google script, but if that fails at some point, I'll check the add. store stuff. Thanks.

I'm open to better category suggestions, but as you guess, I do want to avoid "General" as much as possible, as that gives you no information about why you might want to install that script or not.

Like I've said, I find it hard to categorize most of the scripts, so I don't have any suggestions other than not categorizing at all. Which leads to the actual reason why I think that we disagree so much with this; I think we have very different thoughts about how (new) users use AAD. I've a hard time thinking that (new) users wouldn't use almost all of the scripts (initial testing for which scripts might be good/maximizing the chances to get best artwork available), as opposed to your thinking that (new) users use only a limited set of scripts (a view I've from what you've posted here previously), which is actually sort of what I do; I use the "search first" feature first.

strangely I can access their API: Example (http://api-v3.deezer.com/1.0/search/artist/?q=muse&index=0&nb_items=2&output=xml). Can you?

Yes I can! (For now, hopefully they don't monitor where the new requests for artwork come from and restrict it somehow like they have done several times with their website.) Excellent excellent find!

The fact that you can get unlimited sizes of images suggests they are just being resized on the fly, so what I'll need is some way of figuring out what the native size of the image is. It's not really helpful to download a 9000x9000px image that was generated by the server resizing a 600x600 native one!

Never got to the part of checking out the image qualities (now I've and you're right, the source images are not as big as I dreamed/hoped).. and because I thought that it was accessible from google (cached) only, I thought that you would scrap the idea completely.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-16 15:49:55
Updated megamedia.boo (http://album-art.sourceforge.net/scripts/megamedia.boo) (now checks for and excludes blank images)

Works, thanks.

For testing: deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo)
If people could let me know if it works for them or not, and which country they are in, that would be helpful. Unless you are in a Deezer-supported country, the info Url (small (i) button) will probably just show you a "Deezer not available in your country" page, but at least for the moment the actual search and images seem to work.

I'm using "0x0-000000-0-0-0.jpg" as the suffix for Deezer, which (as I hoped) appears to give the native size and quality. They are all around 1400x1400, which is pretty good.

Script works too, website still says "not available in your country".

About the native quality: the quality URL trick I described earlier still produces less artifacts than the "native" URL. "Native" (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-0-0-0.jpg) (size: 146 KB) Vs. "best quality" (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-100-0-0.jpg) (345 KB). Again, compare the circles in the shirt for slightly reduced artifacts (looking the monitor from downward angle should reveal the artifacts better). The "best quality" is actually slightly better than an iTunes image (http://a5.mzstatic.com/us/r1000/002/Music/da/f4/d0/mzi.obrcqlvf.jpg) (google script search, the API script doesn't find this big image) (141 KB) of the same album (obviously the same source of images).
Title: Album Art Downloader XUI
Post by: Jlo7551 on 2011-08-16 17:55:01
Thanks for the additional info. If you exit iTunes completely (which can be tricky to do, it loves to keep itself running), can you then copy and paste elsewhere? Can you copy and paste images from other programs (like your web browser)? I found this thread (https://discussions.apple.com/message/15745419) which suggests it's an iTunes problem, but if it is still happening even if iTunes is not running (or even better, not installed!) then something else must be wrong...

Alex

OK-I've tried shutting off iTunes and I still can't copy and paste from AAD into any folder-I can still copy and paste normally within any other function on the computer whether iTunes is on or not, just not from AAD-I CAN save the covers to a document folder from AAD and then I can copy them to my desktop then into iTunes but that seems like a rather roundabout way to do get it done. I hope this will help with figuring this out because I definitely like the program. Thank Alex.

Jeff
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-16 18:35:33
About the native quality: the quality URL trick I described earlier still produces less artifacts than the "native" URL.
Sorry, I just don't see it! If the image returned with no specific quality requested comes back as about 85 (according to a jpeg quality estimator I found), but one requested at 100 is better quality (which I will have to trust you on), then it stands to reason that there is some other underlying native image that is being converted to jpeg on the server, and it is just using 85 as a default for some reason. Ideally I'd like to be able to get that native, unconverted image, but I suppose they just aren't exposing that.

You think Deezer and iTunes are getting images from the same underlying source?

I noticed one album cover with some quite nasty artefacts: iTunes (http://a1.mzstatic.com/us/r1000/012/Music/4e/63/94/mzi.icjsmboi.jpg), Deezer (http://cdn-images.deezer.com/images/cover/4e6394f8c9919933fe7f3feaf4ce47c0/0x0-000000-100-0-0.jpg), Deezer-100 (http://cdn-images.deezer.com/images/cover/4e6394f8c9919933fe7f3feaf4ce47c0/0x0-000000-100-0-0.jpg). To me, they are all as bad as each other.

I can still copy and paste normally within any other function on the computer [...] just not from AAD
I'm afraid I've got to admit I'm baffled here. The code for copying the image to the clipboard quite literally just calls the .net library function "Clipboard.SetImage", I'm not doing anything special or unusual there, I can't think of any good reason why other applications can put images on the clipboard, and AAD can't. As it isn't reporting any error messages, that doesn't give me anything to go on either.

Just one thing - you say you can't "paste from AAD into any folder" - you wouldn't normally be able to paste an image into a folder (you can only paste files into a folder); but you should be able to paste it into a document Write or Paint or similar.

Alex
Title: Album Art Downloader XUI
Post by: bilbo on 2011-08-17 00:55:40
FYI When you shut down iTunes, it still leaves 2 iTunes processes running in the background. You should kill those processes before testing.
Title: Album Art Downloader XUI
Post by: Hamilcar on 2011-08-17 11:18:49
Using windows 7 x64 (virtual machine in vmware fusion), I have this really annoying bug with the latest version, everything is RED:

http://imgur.com/htGkb (http://imgur.com/htGkb)

How can I solve this ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-17 13:12:32
Using windows 7 x64 (virtual machine in vmware fusion), I have this really annoying bug with the latest version, everything is RED

This appears to be a bug with VMWare Fusion on Mac OS: http://communities.vmware.com/message/1802084 (http://communities.vmware.com/message/1802084)

Alex
Title: Album Art Downloader XUI
Post by: Fandango on 2011-08-17 16:48:38
Where can I see the direct URL of the images? For when I want to directly link to the image and not save it.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-17 16:53:02
Sorry, I just don't see it! If the image returned with no specific quality requested comes back as about 85 (according to a jpeg quality estimator I found), but one requested at 100 is better quality (which I will have to trust you on), then it stands to reason that there is some other underlying native image that is being converted to jpeg on the server, and it is just using 85 as a default for some reason. Ideally I'd like to be able to get that native, unconverted image, but I suppose they just aren't exposing that.
This "underlying native image" is what I was thinking about when I falsely cheered about the limitless sizes.

Here's 800% zooms of the example pictures I posted earlier: "native" (http://postimage.org/image/2sgbxd8qs/) Vs. "100 quality" (http://postimage.org/image/2sgk71z7o/). Compare the slightly reduced artifacts + slightly "sharper" 100 quality image. Also notice the "brighter orange blocks" in the native/0 image.. the whole orange area seems to be a bit smoother in the 100 quality image.

Here's the full "native"/0 image (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-0-0-0.jpg) straight from the deezer site (149 864 bytes), then a quality 85 image (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-85-0-0.jpg) (149 864 bytes), same exact size. Then the full quality 100 image (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-100-0-0.jpg) (354 204 bytes). In most cases it's safe to assume that bigger KB images (coming from AAD scripts/sites) are better, and additionally in this case, I can clearly see less artifacts, which has convinced me totally.

Which brings us back to what you wrote; is the "native" size the best we could get?

And here it gets more hairy: a PNG of the same image (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-0-0-0.png) (1 417 307 bytes)! With the "100 quality" (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-100-0-0.png) switch (this time ONLY 994 666 bytes). I don't understand the size drop in PNG but size increase in JPG when using the, I must now say, "alleged quality switch". The "native/0" PNG is in some part (e.g. the yellow color shirt area has none of the artefacts the JPG has (VERY hard to spot)) much better than the "100" JPG. Still the PNG has the bigger artifacts, and those are a bit clearer (JPG compression seems to "blur" them a bit). Here's another PNG image (http://cdn-images.deezer.com/images/cover/e3a5911871ee5490d8c0ceb2db8525b5/0x0-000000-0-0-0.png) (3 236 075 bytes) Vs. JPG image (http://cdn-images.deezer.com/images/cover/e3a5911871ee5490d8c0ceb2db8525b5/0x0-000000-0-0-0.jpg) (271 750 bytes). The PNG is clearly a bit sharper than the JPG (->original artifacts (e.g. around the letters) show more clearly).

Interesting thing: TIF (http://cdn-images.deezer.com/images/cover/e3a5911871ee5490d8c0ceb2db8525b5/0x0-000000-0-0-0.tif) -> empty page, but NOT "HTTP_NOT_FOUND" page, like if you try some arbitrary extension (http://cdn-images.deezer.com/images/cover/e3a5911871ee5490d8c0ceb2db8525b5/0x0-000000-0-0-0.shit), or "wrong" URL parameters (http://cdn-images.deezer.com/images/cover/e3a5911871ee5490d8c0ceb2db8525b5/0x0-000000-0-10-0.jpg).

I'm done with this. I don't have more time to mess around with this. If you ask me, I'd choose the "native/0" PNG (very large sizes though could be expected, many MB's, which doesn't worry me because I always edit the images I find for my albums).

You think Deezer and iTunes are getting images from the same underlying source?
I believe, and it's has been strengthened while posting my suggestions for new scripts, that ultimately there seems to be just 1 big source (and maybe few small sources) where all the different sized/quality pictures are coming from. I can't prove this but looking at the pictures from various scripts, I get the feeling that these are from the same original picture, some are same size/quality, some has changed sizes/qualities, still almost identical (JPG compression/other) artifacts, e.g. cover "vesa-matti loiri / 4 + 20" from e.g. deezer/itunes (1214x1200px) is obviously the same picture as 7digital reduced size + reduced quality + squared (added missing px from height->black bar under the picture) picture (800x800px). This is just one example, I don't have the time nor interest to make a full empirical thesis.

I noticed one album cover with some quite nasty artefacts: iTunes (http://a1.mzstatic.com/us/r1000/012/Music/4e/63/94/mzi.icjsmboi.jpg), Deezer (http://cdn-images.deezer.com/images/cover/4e6394f8c9919933fe7f3feaf4ce47c0/0x0-000000-100-0-0.jpg), Deezer-100 (http://cdn-images.deezer.com/images/cover/4e6394f8c9919933fe7f3feaf4ce47c0/0x0-000000-100-0-0.jpg). To me, they are all as bad as each other.
One of the Deezer links is wrong, now you've two 100 quality image links. Anyways, I can see really really small differences in "native/0" and "100", but since the original/source picture is so bad, it would be stupid to try to say which one is better.. both are bad.


P.S. You haven't got the latest v0.10 Discogs script in your "update system" yet. I see an "update available" to downgrade to v0.9.
Title: Album Art Downloader XUI
Post by: Hamilcar on 2011-08-17 17:28:10
Using windows 7 x64 (virtual machine in vmware fusion), I have this really annoying bug with the latest version, everything is RED

This appears to be a bug with VMWare Fusion on Mac OS: http://communities.vmware.com/message/1802084 (http://communities.vmware.com/message/1802084)

Alex



Thanks for the quick answer !
Disabling 3D hardware acceleration in the VM settings did the trick !
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-17 18:11:48
Where can I see the direct URL of the images? For when I want to directly link to the image and not save it.
I'm afraid that's not currently possible. It's not something that AAD can provide, in the general case, as scripts do not actually have to supply it with URLs, they may download the image themselves first and just pass back that. In a couple of cases there is, in fact, no direct URL that could even theoretically be given as a specific header, cookie, or post data is required. The best I can offer is the info URL, accessed by clicking the (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/info.png) button. That should give you a web page on which you can find the image. Unfortunately, fr those scripts where the URL for the image is 'guessed' by altering the size part in the URL, it won't give you those directly.

And here it gets more hairy: a PNG of the same image (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-0-0-0.png) (1 417 307 bytes)! With the "100 quality" (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-100-0-0.png) switch (this time ONLY 994 666 bytes).
Heh, so their image server is automatically converting the format too. So now there's not only native size to consider, but native format too! The only thing I can assume about the quality switch is that it must be controlling the compression level of the PNG, but given that PNG is a lossless format I see no reason not to use the maximum possible compression level. My conclusion, then, is that I should be using 0x0-000000-100-0-0.png (which I've tested as being pixel-identical to the -0-0-0.png image).

Although there may be users who would rather have the smaller jpeg files, I'm going to go with png for this scripts as there are lots of other sources offering reasonable quality jpegs, but none offering large lossless pngs!

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-18 15:00:08
The only thing I can assume about the quality switch is that it must be controlling the compression level of the PNG

I couldn't let this mystery go away.  Here's some figures from testing the parameter (with this image (http://cdn-images.deezer.com/images/cover/daf4d0473bdf3e0211c0d1a559a7d2df/0x0-000000-0-0-0.png)):

0 = 1 417 307 bytes
10 = 1 516 981 bytes
20 = 1 516 981 bytes
30 = 1 516 981 bytes
40 = 1 516 981 bytes
41-49 = 2 881 887 bytes
50 = 2 881 851 bytes
60 = 1 511 166 bytes
61-70 = 1 599 269 bytes
71-80 = 1 679 228 bytes
81-84 = 1 716 940 bytes
85 = 1 716 904 bytes (this was first same as the 81-84 (1 716 940 bytes) but a page refresh changed it for some reason, and it stays that way even when resfreshed again and again..!)
86-90 = 1 716 940 bytes (back to "normal")
91-94 = 994 666 bytes
95 = 994 630 bytes (same anomaly again, this was first 994 666 bytes, refresh changed it. This seems to happen to images which were loaded some time ago (minutes) and then refreshed, but not to images which are loaded and almost instantly refreshed.. funny system.)
96-97 = 994 666 bytes (back to "normal" again)
98-100 = 994 630 bytes

It doesn't make sense at all. It can't be quality nor compression parameter.. at least not with PNG's. With JPG's it makes sense:

100 = 354 204 bytes
90 = 168 719 bytes
85 = 149 864 bytes
80 = 140 687 bytes
70 = 125 250 bytes
60 = 104 107 bytes
50 = 75 305 bytes
40 = 70 306 bytes
30 = 58 810 bytes
20 = 46 807 bytes
10 = 31 012 bytes
1 = 14 714 bytes
0 = 149 864 bytes

What do you think? Is it "safe" to use the parameter with PNG's?

...which I've tested as being pixel-identical to the -0-0-0.png image

I'm curious, how did you test it? Did you use a special tool? I might have use for that too.


Is the Discogs script (http://album-art.sourceforge.net/scripts/discogs.boo) really updated to 0.10 version in the server? I tried to load that with two browsers + different proxys (http://proxy.org/) and I could only get 0.9 version. The "updates page" (http://album-art.sourceforge.net/Updates.xml) shows it as 0.10 though.

Also I still have "Nuclear Blast" in general category because the 0.1 version I've differs from the server 0.1 version (my version doesn't have the "category" code stuff). In addition of that, Beatport, GigaCrate and Juno Records & Psyshop (same cat) are not in the new "Dance, Club, Electronic" cat. Some of the scripts might not get updated for a long time, so IMHO, you should bump the version up even when making cat. changes. This way the scripts in AAD and in the scripts update page would be identical.


I just had 1 update (Deezer) and 1 new script (Beatport) in AAD and I updated Deezer first, then declined to restart, and tried to "get more scripts" but the window just says that "the new scripts will be available once AAD has been restarted"! (False claim BTW) So I've to restart twice. Not very convenient. I probably have asked this couple of times already but, do you really need to separate the "updates" and "new scripts" download systems?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-18 17:48:09
It doesn't make sense at all. It can't be quality nor compression parameter.. at least not with PNG's. With JPG's it makes sense
With JPG it's quite clearly a direct quality parameter, but I don't think I know enough about PNGs to come up with a better answer. It will probably relate to colour depth and compression level, as they can directly affect the size of the PNG, but neither of them have anything similar to a 1-100 scale. 100 is still looking like the best choice, though.

To test for image similarity, I use the GIMP (http://www.gimp.org/), although I'm sure any reasonably powerful image editor would do. I put the two images to compare in two layers, then set the top layer to be "Difference" mode (or Subtract probably works just as well). That gives you what looks like just an all-black image, but to be sure I then use the Magic Wand (set to 0% tolerance) and click somewhere in the black. If there's any non-black pixels, they get highlighted by the selection boundaries, otherwise the selection is just the whole image. There are probably easier ways to do this, but that's the one I learned a long time ago.

As to script updates, it's my mistake that Discogs didn't get updated properly, sorry about that. It should be fixed now, though. I don't think it is worth making people re-download unchanged scripts just to change their category names, really, so I'm leaving those as they are.

I am keeping updates and new scripts as separate in the UI because I believe they should be treated differently. Everyone should keep the scripts they have installed updated, unless they have a specific reason not to. No-one should automatically download and install every available script unless they have a specific reason to do so. These two conflicting goals mean there should be two separate options.

I did put in a change a while back, though (at your request, if I remember right), that if you have it set to automatically download new scripts, it doesn't set the "restart required" flag after doing so.

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-18 22:18:28
Where did you get that list from, originally? ... The ones which I found to work are:

I got the country list from the iTunes Music Store ("choose country" option) using the latest iTunes version 10.4.0.80
I found the same countries to work.
yours
thomian
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-19 11:03:51
Hey Alex,
I noticed a bug in AlbumArtDownloader:
If you download a TIF or a PNG file directly (without downloading the fullsized preview), it will be falsely saved with the file extension JPG.
If you click on the fullsized preview first, it is saved correctly as TIF or PNG.
yours,
thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-19 12:17:24
If you download a TIF or a PNG file directly (without downloading the fullsized preview), it will be falsely saved with the file extension JPG.

This is a tricky one. The problem occurs if the thumbnail is a different format to the full sized image. The filename to use is fixed at the time you click the save button (or confirm the Overwrite dialog, or Save As dialog), so if after the download completes it turns out to be a different format, it isn't allowed to then change the filename.

I can't just unilaterally change the extension to match the file format after downloading as in some cases people do actually want to name their file Folder.jpg even if it isn't a jpeg, due to stupid media players hard-coded to look for that filename (but quite capable of reading other image formats). Also, there might already be an existing file of that name with the new extension.

I could enforce downloading of the full sized image before showing the Save As or Overwrite dialogs, but having UI pop up potentially several seconds after the command was initiated could get very irritating. If you hit Save As and no dialog appeared it would look like something had gone wrong. Also, you could easily click several save buttons quickly, then get hit by a cascade of Overwrite prompts!

Similarly, if I put in a prompt to alert you that the file type had changed after downloading, that could be an unexpected irritant. You hit Save, then several seconds later when you are working on something else, a dialog popping up to tell you that the art you downloaded as Folder.jpg is actually a png file, and would you like to save as Folder.png would be pretty unwelcome. Some users would be angry that it asked, when it should obviously have just saved as Folder.png and not bothered them. Others will be angry that it asked, when they've already told it to save it as Folder.jpg and don't like being second-guessed by software 'trying to be too clever'. Others won't understand or care, and just hit Yes or OK or whatever they think will make the popup disappear the fastest, and will just be irritated that 'this software has a lot of pointless popups'.

The only other thing I can think of would be to provide a way for scripts to inform AAD of the suggested extension to use for them. This isn't perfect, as scripts like iTunes would have to make at least HTTP HEAD requests for the large size image in order to determine the right extension, and some scripts simply wouldn't be able to tell at all without actually downloading the full size image (in which case you might as well not bother with thumbnails at all). In some cases, the suggested extension may also simply be wrong; should it always take precedence over the actual format of the image in those cases? There's no easy answer.

If anyone has any suggestions on the best way to handle this, please feel free to contribute an opinion.

Alex
Title: Album Art Downloader XUI
Post by: MC Escher on 2011-08-19 14:35:32
I can't just unilaterally change the extension to match the file format after downloading as in some cases people do actually want to name their file Folder.jpg even if it isn't a jpeg, due to stupid media players hard-coded to look for that filename (but quite capable of reading other image formats).

For real? Why build in support for other file formats and refuse to read them?
Quote
I could enforce downloading of the full sized image before showing the Save As or Overwrite dialogs, but having UI pop up potentially several seconds after the command was initiated could get very irritating. If you hit Save As and no dialog appeared it would look like something had gone wrong. Also, you could easily click several save buttons quickly, then get hit by a cascade of Overwrite prompts!

Perhaps you can make the dialogue pup up immediately, but make the safe button non-clickable until the image has been downloaded (with a progress bar showing something is going on). I assume it isn't possible to have the script take a look at the file header before downloading the file?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-19 16:02:01
For real? Why build in support for other file formats and refuse to read them?
Quite easily. You just use some standard or built-in library for image loading and display, which supports all sorts of image formats. It's not that you refuse to read other formats, just that the answer to the design question "Where do we get the image from?" is "A file named 'folder.jpg'", and that's as far as it gets.

Even the latest version of foobar2000 is a little bit guilty of this - the default filenames searched for album art all end in .jpg, but if you have a PNG format file and rename it to end in .jpg it will display just fine. In foobar2000's case, it's customisable enough that if you know what you're doing you can just add "folder.jpg" (or even "folder.*") to the lookup list and it will use it, but most players aren't quite as customisable as foobar2000 is!

Perhaps you can make the dialogue pup up immediately, but make the safe button non-clickable until the image has been downloaded (with a progress bar showing something is going on). I assume it isn't possible to have the script take a look at the file header before downloading the file?
If it's the Save As dialog, for example, then there would be no point in showing it but disabling the save button, as the dialog itself could depend on the result of the download (for example, should it be showing .jpg files, or .png files?). I could pop up a 'please wait' dialog that wouldn't let you do anything else until the image had been downloaded, but I suspect that would not be well received either.

I don't think I can have the script perform a partial download of the file to determine the format. As I suggested though, in many cases the script will be able to make a good guess without actually downloading the file (so Deezer would be able to say it's going to be a PNG without needing to download, for example), but for other scripts it might be less certain.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-20 10:33:25
Version 0.41.1
This is a fix to try and improve the behaviour of Album Art Downloader XUI with scripts that have full size images in different formats to the thumbnails. It allows scripts to suggest the most likely extension for the full size images, which is used in preference to the extension associated with the format of the thumbnail. This means a script can provide a jpeg thumbnail to a png image and have AAD use "png" as the substitution for %extension% before the full size image is downloaded.

The Deezer, iTunes and RevHQ scripts have been updated to take advantage of this facility. This does mean that the iTunes search is a little slower, as it has to query the server for the existence of the full size jpeg to determine whether it will be falling back to the tiff or not. It doesn't download the image, but even just doing a HEAD query can still takes almost a second per result.

The other recent script changes are all included in this release:Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.41.1.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.41.1.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-20 23:16:36
Hey Alex,

I can't just unilaterally change the extension to match the file format after downloading as in some cases people do actually want to name their file Folder.jpg even if it isn't a jpeg...

In my opinion it's just more irritating if a program doesn't follow common standards. JPGs should be named .jpg and TIFFs should be named .tiff !
In the case that some Media players only accept "folder.jpg" users could easily convert or rename their TIFFs or PNGs. Yes it's true that foobar reads all pics irrespective of their extension. But my graphics programs refuse to open the "corrupt" files and then I don't know what is happening and/or I have to try by trial and error which file extension matches the picture format. Perhaps you may implement a checkbox in the options menu to "force all image formats to be saved as .jpg".

Also, there might already be an existing file of that name with the new extension.

That's true. AlbumArtDownloader should first download the picture, check the format and then eventually open the Save As or Overwrite dialogs.

I could enforce downloading of the full sized image before showing the Save As or Overwrite dialogs, but having UI pop up potentially several seconds after the command was initiated could get very irritating. If you hit Save As and no dialog appeared it would look like something had gone wrong. Also, you could easily click several save buttons quickly, then get hit by a cascade of Overwrite prompts!

Not for me. I wait for the download anyway. And yes: During download, the thumbnail should be marked with the small globe icon and further download options should be grayed out for this picture.

The Deezer, iTunes and RevHQ scripts have been updated to take advantage of this facility. This does mean that the iTunes search is a little slower...

OK. This is the way you've chosen, but I regret your decision as my internet connection isn't very fast. It seriously slows down my searches. :-(

If anyone has any suggestions on the best way to handle this, please feel free to contribute an opinion.

You're welcome. 
I love your program!
thomian
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-08-20 23:17:45
hey, I hate to annoy anyone, but discogs search still doesn't work for me for some reason..
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-21 08:20:59
Perhaps you may implement a checkbox in the options menu to "force all image formats to be saved as .jpg".
There's no need, the way the "path to save image as" pattern works is already sufficient. If you set it to "folder.jpg" then it always saves as .jpg regardless of format. If you set it to "folder.%extension%" (which is the default) then it follows common standards and uses the correct extension for the file. The only problems arise when it gets that wrong as it doesn't know what the correct extension for the file is yet - which I acknowledge is irritating and a bug, but as I've explained, is difficult to deal with wholly satisfactorily.

OK. This is the way you've chosen, but I regret your decision as my internet connection isn't very fast. It seriously slows down my searches. :-(
I've uploaded the old version of the script for you here: itunes-old.boo (http://album-art.sourceforge.net/scripts/itunes-old.boo). You should delete itunes.boo if you use it, as they can't both coexist. (I've renamed it to add " old" so that it doesn't keep showing that updates are available to it)

hey, I hate to annoy anyone, but discogs search still doesn't work for me for some reason..
It's working when I try it here - could you let me know what you searched for? Also, check that the version number of the script says "v0.10".

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-08-21 08:34:27
It's working when I try it here - could you let me know what you searched for? Also, check that the version number of the script says "v0.10".

Alex

the version is correct
for example, I search for "Robbie Williams - Supreme" and get nothing. wonder what the problem could be cause the site itself works quite fine for me.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-21 08:46:34
I search for "Robbie Williams - Supreme" and get nothing.
I'm afraid I don't know, then. That search works fine when I try it. Are you sure the results aren't being filtered out according to your settings? Try clicking the Disable Filters button (just to the left of the "Group by" control above the results). When you search, try watching the Discogs source in the sources list - does it show a progress bar filling slowly, or does it just flash up and then immediately go back to normal without any results?

If anyone else could check if Discogs is working for them and let me know if it isn't, that would be helpful too.

Alex
Title: Album Art Downloader XUI
Post by: marc2003 on 2011-08-21 09:19:56
i just tried the robbie williams search on discogs only and it was fine (10 results).
Title: Album Art Downloader XUI
Post by: Marmetal on 2011-08-23 10:34:03
Hi there!  I love this program Alex and I'm using it for some time now, really helpful for perfectionists . Lately I can't use it though, I get this error:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.41.1.0, running on Microsoft Windows NT 5.1.2600 Dodatek Service Pack 3 (32 bit)

System.TypeInitializationException: Inicjator typów zgłosił wyjątek dla typu 'System.Windows.Window'. ---> System.TypeInitializationException: Inicjator typów zgłosił wyjątek dla typu 'System.Windows.FrameworkElement'. ---> System.TypeLoadException: Podpis jest niepoprawny.
  w System.Windows.Style.ProcessVisualTriggers(Style style)
  w System.Windows.Style.Seal()
  w System.Windows.FrameworkElement.get_DefaultFocusVisualStyle()
  w System.Windows.FrameworkElement..cctor()
  --- Koniec śladu stosu wyjątków wewnętrznych ---
  w System.Windows.Window..cctor()
  --- Koniec śladu stosu wyjątków wewnętrznych ---
  w System.Windows.Window..ctor()
  w AlbumArtDownloader.Splashscreen..ctor()
  w AlbumArtDownloader.Splashscreen.ShowIfRequired()
  w AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  w System.Windows.Application.<.ctor>b__0(Object unused)
  w System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  w System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  w System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  w System.Windows.Threading.DispatcherOperation.InvokeImpl()
  w System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  w System.Threading.ExecutionContext.runTryCode(Object userData)
  w System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  w System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  w System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  w System.Windows.Threading.DispatcherOperation.Invoke()
  w System.Windows.Threading.Dispatcher.ProcessQueue()
  w System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  w MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  w MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  w System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  w System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  w System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  w System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  w System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  w MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  w MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  w System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  w System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  w System.Windows.Threading.Dispatcher.Run()
  w System.Windows.Application.RunDispatcher(Object ignore)
  w System.Windows.Application.RunInternal(Window window)
  w System.Windows.Application.Run(Window window)
  w System.Windows.Application.Run()
  w AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  w AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  w AlbumArtDownloader.App.Main(String[] args)

I installed the program again but I get the same error over and over. What would you advise to me? Thanks for your work!

Best
// MK
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-23 11:24:48
I've uploaded the old version of the script for you

thanks 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-23 13:52:50
I get this error:
Hello, that looks to me like a problem with your .net framework installation (it can't display a window object). Could you try uninstalling and then re-installing the .NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) please?

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-08-23 15:59:32
I search for "Robbie Williams - Supreme" and get nothing.
I'm afraid I don't know, then. That search works fine when I try it. Are you sure the results aren't being filtered out according to your settings? Try clicking the Disable Filters button (just to the left of the "Group by" control above the results). When you search, try watching the Discogs source in the sources list - does it show a progress bar filling slowly, or does it just flash up and then immediately go back to normal without any results?

If anyone else could check if Discogs is working for them and let me know if it isn't, that would be helpful too.

Alex

thanks for trying to figure it out, it's so weird... I have no filters on so it can't be it. the progress bar just flashes and goes back without results, so that.
I also tried deleting the script and then having AAD re-add it itself, didn't help either. I'm stumped.
can it possibly be because of my location? I'm in Russia. but I never experienced any limitations from discogs, and, again, the site itself works fine for me.

thanks again.
Title: Album Art Downloader XUI
Post by: Marmetal on 2011-08-23 16:59:41
I get this error:
Hello, that looks to me like a problem with your .net framework installation (it can't display a window object). Could you try uninstalling and then re-installing the .NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) please?

Alex


I did that and I still get the same error .

Best
// MK
Title: Album Art Downloader XUI
Post by: godrick on 2011-08-23 17:05:47
Sorry if I missed it, but I can't seem to launch the Foobar Browser for AAD correctly from my portable install of Foobar.  I successfully installed foo_run, and I entered the following service:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /foobarBrowser

But what it does is first launch my standard install of Foobar that I also have on my PC, and then launch the Foobar Browser for AAD.  I think the issue is that this command line assumes a standard install location for Foobar, and I've failed to find a command line option to try to point at my portable install of Foobar.

Any suggestions?  thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-23 17:53:32
can it possibly be because of my location? I'm in Russia. but I never experienced any limitations from discogs, and, again, the site itself works fine for me.
I suppose it could be a location thing. I can't really test that from here, though! What I can do is offer you a debug version of discogs.boo (http://www.byalexv.co.uk/temp/discogs.boo) which will create a discogs.txt file in your temp folder and open it with notepad.exe every time you do a search. It's just the raw html that discogs sends back to the script, so if you PM me a copy of that I'll see if I can figure out why the script can't parse it.

I did that and I still get the same error .
That could be a problem, then. I'm not sure what else to suggest, really. If you try a different WPF application (blu (http://2010.thirteen23.com/experiences/desktop/blu/), for example) to see if that works then that might give some clues. I'm not very optimistic, though.

I can't seem to launch the Foobar Browser for AAD correctly from my portable install of Foobar
The foobar browser relies on the Foobar COM Automation Server (http://www.hydrogenaudio.org/forums/index.php?showtopic=39946), which is very much non-portable. As far as I know, there is no way even theoretically for an external program to get access to the Foobar media library in a portable way, sorry.

Alex
Title: Album Art Downloader XUI
Post by: Marmetal on 2011-08-25 12:37:09
I did that and I still get the same error .
That could be a problem, then. I'm not sure what else to suggest, really. If you try a different WPF application (blu (http://2010.thirteen23.com/experiences/desktop/blu/), for example) to see if that works then that might give some clues. I'm not very optimistic, though.


Still nothing unfortunately. Maybe you could release some new version that would get rid of that bug?

Best
// MK
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-25 13:15:09
Still nothing unfortunately.
What do you mean by 'nothing'? Did blu work or not? If blu did not work, then it is a problem some problem with your system. If blu does work, but AAD does not, then my best guess would be some configuration problem. In which case uninstalling it, making sure that the %LOCALAPPDATA%\AlbumArtDownloader folder is deleted, and reinstalling it might help.

Alex
Title: Album Art Downloader XUI
Post by: Marmetal on 2011-08-26 09:02:30
No no, I tried everything you said and it still doesn't work, sorry for not explaining. And it's quite weird 'cause few weeks ago everything was perfect and I don't have any problems with the computer. Maybe new version of the program could solve the problem?

Best
// MK
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-26 09:12:54
Maybe new version of the program could solve the problem?
So blu didn't work either, then? In that case, it's clearly a problem with your .NET Framework / WPF installation. If reinstalling the .net framework didn't work then I'm afraid I don't have any further suggestions. No new version of the program can possibly solve the problem, as it isn't a problem with Album Art Downloader.

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-26 12:37:00
Hey Alex,

for your interest: i found another site with exceptional album art. the download store eclassical.com has mainly classical music for download. They have especially better image quality for some record companys (e.g. BIS), where other databases often result lousy scans.
i didn't figure out the search API, yet. But here you have an example:

http://www.eclassical.com/orchestras/bach-...-volume-47.html (http://www.eclassical.com/orchestras/bach-collegium-japan/js-bach-cantatas-volume-47.html)

you may open it in your browser. right click on the image leads to the resized thumbnail:

http://ecstatic.textalk.se/shop/thumbnails...0_250_250_0.jpg (http://ecstatic.textalk.se/shop/thumbnails/shop/17115/art15/h9368/4459368-origpic-9a02f2.jpg_0_0_100_100_250_250_0.jpg)

if you remove the part "thumbnails/shop/" and the resizing part "_0_0_100_100_250_250_0.jpg" from the link, you'll get the original image (1418x1418):

http://ecstatic.textalk.se/shop/17115/art1...gpic-9a02f2.jpg (http://ecstatic.textalk.se/shop/17115/art15/h9368/4459368-origpic-9a02f2.jpg)

the picture size varies, but is mainly larger than 600px.
yours,
thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-26 19:01:49
i found another site with exceptional album art. the download store eclassical.com
Looks good, it's nice to have another Classical script. Please give eclassical.boo (http://album-art.sourceforge.net/scripts/eclassical.boo) a go and let me know if you find any problems with it.

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2011-08-26 22:13:52
let me know if you find any problems with it.

wow, you're really fast. the search engine of the website has problems with "points". for example searching for "J.S. Bach" returns only one album, whereas "J. S. Bach" returns 73 results. If you take a closer look you'll realize that most of these albums are named "J.S. Bach ..." and should therefore also be found on the first search.
Moreover the order of the returned items is absolutely unlogical, as the best fitting results sometimes occur at place 20+ and will not be shown in AAD unless you're setting the script to find more than 20 results. i think the results are sorted by popularity or something.

but these constraints have nothing to do with your script, as they also occur with the original website.
great work!

yours,
thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-27 07:59:59
but these constraints have nothing to do with your script, as they also occur with the original website.
Yeah, their search engine could use some work. Not something I can fix in the script, though, I'm afraid.

Thanks for the report.

Alex
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-28 12:21:45
To test for image similarity... I put the two images to compare in two layers, then set the top layer to be "Difference" mode (or Subtract probably works just as well). That gives you what looks like just an all-black image, but to be sure I then use the Magic Wand (set to 0% tolerance) and click somewhere in the black. If there's any non-black pixels, they get highlighted by the selection boundaries, otherwise the selection is just the whole image.

Tried that with GIMP and Paint.NET, doesn't work like you describe it. I placed the same picture in 2 layers and did the mode & wand stuff, still random pixels get selected, not whole image. Anyways, this topic is about AAD, not image editing.

I did put in a change a while back, though (at your request, if I remember right), that if you have it set to automatically download new scripts, it doesn't set the "restart required" flag after doing so.

I don't remember that. Anyways, two restarts it is then if I get both new & updated scripts available in the future.

here is an example for a larger tif from the iTunes Store:
http://a4.mzstatic.com/us/r1000/048/Music/...zi.cyomhscs.tif (http://a4.mzstatic.com/us/r1000/048/Music/b6/b3/d3/mzi.cyomhscs.tif)

I tried to load that above tif image and I was greeted with this page:
Code: [Select]
Forbidden

You don't have permission to access /Music/b6/b3/d3/mzi.cyomhscs.tif on this server.

I then immediately tried "metallica / load" search in AAD and iTunes API & iTunes Google worked just fine.

~10 minutes later, while writing this post, I'm able to download that tif image.    Just reporting this anomaly.

P.S. That Anibal Troilo guy in the cover totally looks like Ricky Gervais.

i just tried the robbie williams search on discogs only and it was fine (10 results).

Tried it too, 15 results for me.
Title: Album Art Downloader XUI
Post by: mutestorm on 2011-08-29 15:45:57
I don't know if it's been addressed, mostly because I cant figure out how to sure this particular post.

It seems when I auto download, it will find album art from album's it designated as "Not Found", and then stick it in other album's folders. Is this a common problem?

(Example)
Search for both Wish You Were Here and DSOTM

Wish you were here says 'not found'
An image for Wish You Were Here is saved as DSOTM's album art

I'm using the foobar loader if that matters
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-08-29 16:18:02
~10 minutes later, while writing this post, I'm able to download that tif image.    Just reporting this anomaly.

P.S. That Anibal Troilo guy in the cover totally looks like Ricky Gervais.
Weird, but I don't think it's anything to do with the script. If .tif images stop working permanently then I'll change the script not to bother with them, but if it's only a temporary fault it's not worth changing anything. And yes, he does look a lot like Gervais!

It seems when I auto download, it will find album art from album's it designated as "Not Found", and then stick it in other album's folders. Is this a common problem?
I've never heard it reported before. Could you try right clicking on one of the column headers in the foobar browser, and checking the "Folder" entry. That will give you a column which shows which folder it thinks each album is in, and it should be into that folder that it saves images for each album.

Alex
Title: Album Art Downloader XUI
Post by: mutestorm on 2011-08-29 16:23:33
Quote
It seems when I auto download, it will find album art from album's it designated as "Not Found", and then stick it in other album's folders. Is this a common problem?
I've never heard it reported before. Could you try right clicking on one of the column headers in the foobar browser, and checking the "Folder" entry. That will give you a column which shows which folder it thinks each album is in, and it should be into that folder that it saves images for each album.

Alex


This solved itself when I started using discogs for searching. Before I was only using Last.fm covers, which works when i go one by one, but somehow does this odd misplacing when i autodownload.
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-08-30 13:50:25
Weird, but I don't think it's anything to do with the script. If .tif images stop working permanently then I'll change the script not to bother with them, but if it's only a temporary fault it's not worth changing anything.

Nothing to do with the script, only the server. I just reported it in case some other user reports something wrong with the iTunes script.. might save some time bughunting. That's all.. just a "good to know" thing.
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-09-09 14:20:58
is it just me (again), or did discogs script stopped working again?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-09 20:14:25
is it just me (again), or did discogs script stopped working again?

It's working fine for me right now... Is it a specific search that's not working?

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-09-10 11:01:07
is it just me (again), or did discogs script stopped working again?

It's working fine for me right now... Is it a specific search that's not working?

Alex

ah, never mind, it fixed itself. been a temporary bug then
sorry about that
Title: Album Art Downloader XUI
Post by: alsaan on 2011-09-10 16:29:54
Hi, I've noticed that buy.com has changed the way they serve cover images in the product page. Now every picture is embedded in a 500x500 white canvas, even if it is smaller than that size:

(http://ak.buy.com/PI/0/350/60604455.jpg)

I've modified the script so that it detects this unwanted whitespace and trims it.
Unfortunately now it is necessary to download the full size images every time, so I've also added threading to improve responsiveness somewhat.

Here is the code: buy-com.boo v0.8 (http://pastebin.com/yqygp9ez)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-10 16:55:53
Now every picture is embedded in a 500x500 white canvas

Thanks, alsaan. It does mean that the buy.com images are now pretty tiny, most thumbnails are bigger than they are! Do you think it is even worth keeping the script any more?

If we are going to keep the script, I'm not entirely convinced by removing thumbnails support from it. There is already the facility in AAD to specify (even on a per-script basis) that only full-sized images should be downloaded, so it seems to me that leaving thumbnails in can only be a benefit. The downloading and cropping of the image can be done when (and if) a full size image is requested. The threading can then be left to AAD (which allocates one thread per script, and a separate thread for downloading full sized images).

Alex
Title: Album Art Downloader XUI
Post by: alsaan on 2011-09-10 17:37:47
Thanks, alsaan. It does mean that the buy.com images are now pretty tiny, most thumbnails are bigger than they are! Do you think it is even worth keeping the script any more?


Most images are really 500x500, it's just that those which are smaller than that show up with that annoying white border. This is how AAD looks with the current version of the script:

http://i.imgur.com/uoqPf.png (http://i.imgur.com/uoqPf.png)

If we are going to keep the script, I'm not entirely convinced by removing thumbnails support from it. There is already the facility in AAD to specify (even on a per-script basis) that only full-sized images should be downloaded, so it seems to me that leaving thumbnails in can only be a benefit. The downloading and cropping of the image can be done when (and if) a full size image is requested. The threading can then be left to AAD (which allocates one thread per script, and a separate thread for downloading full sized images).


The problem is that it's no longer possible to determine the size of the cover without downloading and processing the full image. Should I just specify -1 as the width/height? (Or 500, even if it's not always true?)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-10 18:43:07
Should I just specify -1 as the width/height? (Or 500, even if it's not always true?)

The ones I tried were all tiny images with huge white borders, but I could have just been unlucky. Anyway, yes, if the size can't be determined without downloading the full sized image, specify -1. There's an option in AAD specifically to download full size images only when the size is unknown which takes advantage of this.

edit: removed paragraph of stupidity.

Alex
Title: Album Art Downloader XUI
Post by: alsaan on 2011-09-11 16:38:16
OK, here is the revised version:

buy-com.boo v0.8.1 (http://pastebin.com/Djrg0bdE)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-11 16:55:08
OK, here is the revised version

Excellent, thank you very much. I've uploaded it to sourceforge and published it through the online updates system. The direct download link is: buy-com.boo (http://album-art.sourceforge.net/scripts/buy-com.boo).

Alex
Title: Album Art Downloader XUI
Post by: spile on 2011-09-11 17:19:41
@Spile:
That looks like a problem I had some pages back. For me the problem appeared to be in Windows XP's environment variables. If you go to Control panel --> System --> Advanced --> Environment variables you'll see "Path" under system variables. Double click on it and check the line for anything put there by 3rd party programs. Delete those parts and try again.
Thanks for the response and I deleted the system variable for path.
Installed version 0.41
Upgraded scripts
Chose browse option which resulted in...

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.41.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'BrowserResults' defined in assembly 'AlbumArt, Version=0.41.1.0, Culture=neutral, PublicKeyToken=null'. Exception has been thrown by the target of an invocation.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/filebrowser.xaml'. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'AlbumArtDownloader.BrowserResults' threw an exception. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
  at System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
  at AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
  at System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
  at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
  at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
  at AlbumArtDownloader.BrowserResults..cctor()
  --- End of inner exception stack trace ---
  --- End of inner exception stack trace ---
  at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
  at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
  at System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
  at System.Activator.CreateInstance(Type type, Boolean nonPublic)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
  at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.FileBrowser.InitializeComponent()
  at AlbumArtDownloader.FileBrowser..ctor()
  at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
  at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: alsaan on 2011-09-11 23:28:17
Spile, try reinstalling the Windows Imaging Component (http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=32)

I have a new script for one of the sites listed on the wiki: wantitall.boo (http://pastebin.com/LW1VkEgT)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-12 18:51:43
I have a new script

Nice one, thanks. I've added it to the "South African" category, if you don't object, and uploaded it: wantitall.boo (http://album-art.sourceforge.net/scripts/wantitall.boo)

Alex
Title: Album Art Downloader XUI
Post by: Marmetal on 2011-09-13 11:41:40
Maybe new version of the program could solve the problem?
So blu didn't work either, then? In that case, it's clearly a problem with your .NET Framework / WPF installation. If reinstalling the .net framework didn't work then I'm afraid I don't have any further suggestions. No new version of the program can possibly solve the problem, as it isn't a problem with Album Art Downloader.

Alex


Still have no idea what to do so I can use the program again. And I need it!  I'm definitely not an expert as for the system, configurations and that kind of stuff so I hope that someone will come up with anything please.

// MK
Title: Album Art Downloader XUI
Post by: bilbo on 2011-09-13 14:00:05
Still have no idea what to do so I can use the program again. And I need it!  I'm definitely not an expert as for the system, configurations and that kind of stuff so I hope that someone will come up with anything please.

// MK


Many people have had a problem with their install of .net . Completely unistall all versions, go to the microsoft website and get their program to uninstall any remnants and run it, and than reinstall. If that is beyond your capabilites, take your computer to a shop to be fixed.
Title: Album Art Downloader XUI
Post by: Marmetal on 2011-09-14 10:45:53
Holy crap, it works!  I uninstalled .NET Framework completely and did the same to Album Art Downloader. Reinstalled stuff - nothing happened. Few hours later miracle!  I don't know why and it doesn't interest me now, program works! Thanks for the help, if I ever have some troubles again (hopefully not!) I will come back . Cheers!

// MK
Title: Album Art Downloader XUI
Post by: spile on 2011-09-14 17:07:14
Spile, try reinstalling the Windows Imaging Component (http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=32)

Thanks for the reply - which one do I download?
There are ten of them eg wic_86.chs.exe, wic_86_deu.exe etc etc
Title: Album Art Downloader XUI
Post by: Zarggg on 2011-09-15 14:49:47
The "_XXX" portion refers to language. You would want to download the one that fits your installation of Windows.
Title: Album Art Downloader XUI
Post by: ZOOT on 2011-09-18 04:43:43
Cool--this does a better job at finding covers than most; needs more manual interaction, but that's better than the ones that try to be completely automatic but can't find anything...

Some feedback:

- The "none" sort still seems to attempt some kind of sorting: as results come in, they're inserted at seemingly randomly in the results.  I want to start looking through results as soon as they start appearing, and this makes the results flicker all over the place until all sources have completed.  It would be helpful if the "none" sort would display results in the order they arrive, so new results always appear at the end of the list.  (Having the list stay at the top instead of scrolling downwards at the start of a search would help streamline this, too, so I don't have to scroll back to the top every time.)
- Is there a way to change the filename when dragging images into file explorer?  It results in "Folder.jpg", which Android's media framework doesn't know about, so I have to rename to "cover.jpg" manually each time.
- Showing the file size next to the resolution, when known, would be useful.  Often the same image will be on several sites, but in a horrible q1 JPEG on several; this would help finding the one in ten that's a reasonable quality.

I've attached an amazon-common that scrapes customer images--this is where most of the useful images are.  Or I would attach it, but this forum seems to be missing the option, so: http://pastebin.com/n7gLAMsV (http://pastebin.com/n7gLAMsV)  This is tested primarily on amazon.co.jp, and should probably tolerate parse errors better than it does, but I've spent enough time on it for now...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-18 08:16:47

Thanks for your feedback. If you have both sorting and grouping set to none, results are just added to the bottom of the list as they come in. If the scroll position is not at the bottom of the list, then it won't automatically scroll to show newly added results either, so once you start scrolling manually it should not scroll away from where you put it.

If you have automatic download of full size images set to anything other than "never", though, you might still get behaviour where results appear to jump as when the full size image is downloaded. If you have any sort of filtering turned on then when the size of the image changes (due to it previously being unknown, then being determined when the full size image completes) then unfortunately the result must be removed and re-added to the list for filtering to take effect, which means that without any sort applied, it will move to the bottom. To avoid this, click the Options link and make sure that neither of the "Filter by image size" checkboxes are checked.

To set the filename, click the Options link and edit the box labelled "Save images to". For drag and drop, only the filename is used and the rest of the path ignored.

Unfortunately, the file size is pretty much never known in advance, but could be added once the full size image is obtained. (tracker: feature request (http://sourceforge.net/tracker/?func=detail&aid=2890572&group_id=187008&atid=919578))

Thank you for your Amazon customer images script, I'm taking a look at it now.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-18 10:13:17
I've attached an amazon-common that scrapes customer images

I've had a look through this, and have some suggestions.

Firstly, I think it would be better to have the customer images as a separate script to the main Amazon one. I find they often contain images of a poor quality (like photos of the jewel case (http://ecx.images-amazon.com/images/I/51eRCiFp9iL.jpg)), and are always limited to 500x500 maximum size - the _SCRM_ full size images (http://ecx.images-amazon.com/images/P/B002E2QHCW.01._SCRM_) that you sometimes get for the Amazon images don't seem to exist for them. The script will also necessarily be much slower as it will have to pull a separate page from Amazon for each search result. For these reasons I'd rather have a customer images script as a separate optional install, and leave the current Amazon scripts as they are.

For the code itself, I'd suggest removing the hard-coded limitation to 5 results pages. Album Art Downloader already includes a feature to limit the results returned (to 10, by default, but can be set on each source individually), and will stop the script running when that limit is hit. You've also got some hard-coded .co.jp suffixes. That's fine if you only want to do a .co.jp script, but not if you are doing a general one (like amazon-common).

I don't understand the result added if test.pageUrl is null - was this just a debugging aid? Also, it would be nice if the script used thumbnails. You can get thumbnails for any of the customer images by replacing the ending ".jpg" with "._SX120_.jpg", which gives you the same thumbnail images that the media gallery page uses.

Regards,

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-09-18 10:24:30
I have not used AAD for a while and when I tried it today I got this error message:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\Xx\AppData\Local\Temp\AAD_errorlog.txt

App version: 0.41.1.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Configuration.ConfigurationErrorsException: Det gick inte att initiera konfigurationssystemet ---> System.Configuration.ConfigurationErrorsException: Rotelementet saknas. (C:\Users\XX\AppData\Local\AlbumArtDownloader\AlbumArt.exe_Url_1zgksjkmmjcisnmrjqjtxoq5srobf12i\0.41.1.0\user.config) ---> System.Xml.XmlException: Rotelementet saknas.
   vid System.Xml.XmlTextReaderImpl.Throw(Exception e)
   vid System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   vid System.Configuration.XmlUtil..ctor(Stream stream, String name, Boolean readToFirstElement, ConfigurationSchemaErrors schemaErrors)
   vid System.Configuration.BaseConfigurationRecord.InitConfigFromFile()
   --- Slut på stackspårning för interna undantag ---
   vid System.Configuration.ConfigurationSchemaErrors.ThrowIfErrors(Boolean ignoreLocal)
   vid System.Configuration.BaseConfigurationRecord.ThrowIfInitErrors()
   vid System.Configuration.ClientConfigurationSystem.OnConfigRemoved(Object sender, InternalConfigEventArgs e)
   --- Slut på stackspårning för interna undantag ---
   vid System.Configuration.ConfigurationManager.GetSection(String sectionName)
   vid System.Configuration.PrivilegedConfigurationManager.GetSection(String sectionName)
   vid System.Diagnostics.DiagnosticsConfiguration.Initialize()
   vid System.Diagnostics.DiagnosticsConfiguration.get_IndentSize()
   vid System.Diagnostics.TraceInternal.InitializeSettings()
   vid System.Diagnostics.TraceInternal.TraceEvent(TraceEventType eventType, Int32 id, String format, Object[] args)
   vid AlbumArtDownloader.App.Main(String[] args)


Is there anything that can be done?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-18 11:26:08
Is there anything that can be done?

It looks like your settings config file has been corrupted somehow. Try deleting the folder "C:\Users\XX\AppData\Local\AlbumArtDownloader\AlbumArt.exe_Url_1zgksjkmmjcisnmrjqjtxoq5srobf12i\0.41.1.0" (which will reset your settings to the default). Or uninstalling and reinstalling AAD, which will have the same effect.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-09-18 11:33:16
Thanks for the quick reply!

I just replaced the user.config file in that location with the corresponding file for the 0.40 version and that did the trick. (I did not want to lose my settings.)
Title: Album Art Downloader XUI
Post by: ZOOT on 2011-09-18 17:12:46
If you have automatic download of full size images set to anything other than "never", though, you might still get behaviour where results appear to jump as when the full size image is downloaded. If you have any sort of filtering turned on then when the size of the image changes (due to it previously being unknown, then being determined when the full size image completes) then unfortunately the result must be removed and re-added to the list for filtering to take effect, which means that without any sort applied, it will move to the bottom. To avoid this, click the Options link and make sure that neither of the "Filter by image size" checkboxes are checked.

I have automatic download set to always.  It can't adjust the items in-place?  It does when downloading a full image as a result of the user clicking a result...

You could store a sequence number to each result in the order they're received, and have the None sort actually sort by that sequence number; it would appear unsorted initially but remain stable when items are reinserted.

Quote
To set the filename, click the Options link and edit the box labelled "Save images to". For drag and drop, only the filename is used and the rest of the path ignored.

My eyes skipped over that since it sounds like it's only relevant to automatic saving.  Not sure how to make it clearer without splitting it apart, though...

Quote
Unfortunately, the file size is pretty much never known in advance, but could be added once the full size image is obtained. (tracker: feature request (http://sourceforge.net/tracker/?func=detail&aid=2890572&group_id=187008&atid=919578))

That's what I'd expect; I'm always downloading full images (Amazon thumbnails are uselessly small.)  It could HEAD the image to find out the size when that's not enabled, but the scripts that download directly would make this more work to support, so that's probably not worth it.

Firstly, I think it would be better to have the customer images as a separate script to the main Amazon one. I find they often contain images of a poor quality (like photos of the jewel case (http://ecx.images-amazon.com/images/I/51eRCiFp9iL.jpg)), and are always limited to 500x500 maximum size - the _SCRM_ full size images (http://ecx.images-amazon.com/images/P/B002E2QHCW.01._SCRM_) that you sometimes get for the Amazon images don't seem to exist for them. The script will also necessarily be much slower as it will have to pull a separate page from Amazon for each search result. For these reasons I'd rather have a customer images script as a separate optional install, and leave the current Amazon scripts as they are.

I can have it add all of the main images first, and then do query customer images after.  This would make the scripts return the results they currently do without an extra delay.  I'm not sure why resolution matters--the primary results are also of widely varying quality, often giving useless images on the order of 130x130, but that's what filtering is for.  Adding 8 split-out scripts for this doesn't seem very great...

Quote
For the code itself, I'd suggest removing the hard-coded limitation to 5 results pages. Album Art Downloader already includes a feature to limit the results returned (to 10, by default, but can be set on each source individually), and will stop the script running when that limit is hit.

This is on the number of results output, however.  This script is making a request to the site per top-level result.  If the user is set to 20 results and each result has 5 user images, then that's not bad--it'll make about four /customer-media requests.  But if the results have no user images, it could make a full 20 requests.  I'm not comfortable with releasing a script that makes that many requests to someone else's site, but if you want to remove it at your discretion then that's up to you.  (It could be modified to limit the number of /customer-image requests but to continue adding top-level images, of course.)

Quote
I don't understand the result added if test.pageUrl is null - was this just a debugging aid?

The script is pulling JavaScript blocks out of the source, and it was hitting false positives with other code that had the same pattern but different data.  This test skips them.

Quote
Also, it would be nice if the script used thumbnails. You can get thumbnails for any of the customer images by replacing the ending ".jpg" with "._SX120_.jpg", which gives you the same thumbnail images that the media gallery page uses.

I can do that, though Amazon's thumbs seem excessively small (around 57x57).

Are there any debugging mechanisms available?  I couldn't even find a file-writing API for this scripting language; a way to open a console window and output text would make this less of a headache, and a way to see uncaught exceptions.  It'd also help a lot if scripts were automatically recompiled when modified, so the application doesn't need to be restarted all the time.  It doesn't matter much to me now (as I'm just about done), but FWIW...

By the way, I also changed field-title to field-keywords; that gives much more useful results, doing a smart keyword search instead of a strict title search, which is what you get when you search Amazon normally.  "/ref=sr_adv_m_pop" can also be removed; that's for their referral statistics, I think.  Finally, I adjusted EncodeUrlIsoLatin1 to EncodeUrl to line up the scripts; Latin-1 is another name for ISO-8859-1.

Updated at: http://pastebin.com/A8bHLJu6 (http://pastebin.com/A8bHLJu6).  Note that if you keep the field-keywords change, you'll want to change the -jp script as well.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-18 19:02:13
I have automatic download set to always.  It can't adjust the items in-place?  It does when downloading a full image as a result of the user clicking a result...
It adjust items in-place whenever possible. As I said, only if the image size changes, and an image size filter is present, it has to remove and re-add it. As a workaround, and given other comments you've made, you are probably best off checking the option "Always download full size" for the Amazon script you use. That way the thumbnail isn't even downloaded, and it just downloads the full size image immediately.

Adding 8 split-out scripts for this doesn't seem very great...
I'm still convinced that customer images are different enough from the official images that users will want a choice between them. In my case, I consider the official ones better and don't want to perform the additional queries for the customer pages. In your case, it sounds like you would prefer to have the customer pages over the official ones. I really don't want to impose customer pages on people who don't want them, but do appreciate that there are people who do.

I can do that, though Amazon's thumbs seem excessively small (around 57x57).
Should be 120x120, using the _SX120_ suffix... Anyway, the point of the thumbnail is just to quickly see whether it is the right album cover at all, and a small image is enough for that. Of course, to see whether it is a decent image of that cover you'd want to download the full thing.

Are there any debugging mechanisms available?
Can you compile AAD from source? If you compile a debug version of AAD then it compiles the scripts as debug too, which means that you can set breakpoints in them, and Visual Studio will break on them and let you inspect variables through the watch window.

If not, then I usually go with System.IO.File.WriteAllText("DebugLog.txt", someDebugDataHere). There are similar methods for Append, and so on. I don't think a console window can be done, though (or not without more pain than it would be worth).

By the way, I also changed field-title to field-keywords; that gives much more useful results, doing a smart keyword search instead of a strict title search, which is what you get when you search Amazon normally.  "/ref=sr_adv_m_pop" can also be removed; that's for their referral statistics, I think.
Thanks for the tip on the /ref=, I'll remove that. I'm not convinced about the change to keywords - if I'm looking for an album with a specified title, then I want to be searching the title field for it, not just any keywords. Can you give me an example of a search that works better with keywords than title?

Alex
Title: Album Art Downloader XUI
Post by: ZOOT on 2011-09-18 20:25:36
It adjust items in-place whenever possible. As I said, only if the image size changes, and an image size filter is present, it has to remove and re-add it. As a workaround, and given other comments you've made, you are probably best off checking the option "Always download full size" for the Amazon script you use. That way the thumbnail isn't even downloaded, and it just downloads the full size image immediately.

But it's able to update the image and fill in the resolution without changing the order when I click on results, so it seems odd that it can't when doing the same thing asynchronously.  (shrug)

Quote
I'm still convinced that customer images are different enough from the official images that users will want a choice between them. In my case, I consider the official ones better and don't want to perform the additional queries for the customer pages. In your case, it sounds like you would prefer to have the customer pages over the official ones. I really don't want to impose customer pages on people who don't want them, but do appreciate that there are people who do.

I don't really get this--you still have a choice between them, when they're shown in the results to choose from.  A bigger problem is that if you have two scripts for the same site, selecting all sources will cause every result from those sites to be shown twice; it doesn't remove duplicate results.  It'd also cause the top-level search to be performed twice per site.

Quote
Can you compile AAD from source? If you compile a debug version of AAD then it compiles the scripts as debug too, which means that you can set breakpoints in them, and Visual Studio will break on them and let you inspect variables through the watch window.

If not, then I usually go with System.IO.File.WriteAllText("DebugLog.txt", someDebugDataHere). There are similar methods for Append, and so on. I don't think a console window can be done, though (or not without more pain than it would be worth).

I'd hoped to avoid getting so deep into this as to build from source.  FYI, it's actually easy to set up a console window:

Code: [Select]
AllocConsole();
freopen("CONOUT$","wb", stdout);
freopen("CONOUT$","wb", stderr);


in C will open a console window and redirect stdout and stderr to it.

Not a big deal for me at this point, but it could be handy.

Quote
Thanks for the tip on the /ref=, I'll remove that. I'm not convinced about the change to keywords - if I'm looking for an album with a specified title, then I want to be searching the title field for it, not just any keywords. Can you give me an example of a search that works better with keywords than title?


http://www.amazon.co.jp/gp/search?search-a...t=relevancerank (http://www.amazon.co.jp/gp/search?search-alias=popular&__mk_ja_JP=%83J%83%5E%83J%83i&field-artist=&field-title=final+fantasy+4+piano&sort=relevancerank)
http://www.amazon.co.jp/gp/search?search-a...t=relevancerank (http://www.amazon.co.jp/gp/search?search-alias=popular&__mk_ja_JP=%83J%83%5E%83J%83i&field-artist=&field-keywords=final+fantasy+4+piano&sort=relevancerank)

Amazon has a lot of incentive to make the main keyword search find what you want.  Title search is a lot less forgiving.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-18 21:22:59
But it's able to update the image and fill in the resolution without changing the order when I click on results, so it seems odd that it can't when doing the same thing asynchronously.  (shrug)
Asynchronous doesn't make a difference (in fact, even if you click on it, the image itself is still downloaded asynchronously). If you have a size filter turned on, then click on the image for a result with an unknown size, once it finishes downloading it will be removed and (if it meets the filter criteria) re-added. This is the same whether you click on it or it happens because you have automatic full size image downloading turned on.

It'd also cause the top-level search to be performed twice per site.
That's a good point. Oh well, I suppose it's worth adding customer images to the main script, if it can be done so that all the official images for the search come back first, then the customer images after those. I'll stick an IncludeCustomerImages = true somewhere near the top of the script, not that I really expect anyone to use it, though. We'll see if there are any complaints or comments once people start using it.

I can't really understand enough of that Japanese to figure out why the title search has returned results that obviously don't contain the search term in the title... doesn't make much sense to me.

Alex
Title: Album Art Downloader XUI
Post by: ZOOT on 2011-09-19 01:16:25
Quote
Asynchronous doesn't make a difference (in fact, even if you click on it, the image itself is still downloaded asynchronously). If you have a size filter turned on, then click on the image for a result with an unknown size, once it finishes downloading it will be removed and (if it meets the filter criteria) re-added. This is the same whether you click on it or it happens because you have automatic full size image downloading turned on.

I see that now, after flipping a bunch of options.  That's badly broken: every time you look at an image, it jumps to some other random spot in the list and you can't even tell what you just looked at if you want to pick it.  Using less fickle sorts would help prevent this (eg. break ties with a sequence number).  The Size sort seems inherently broken, since size information materializes whenever you click an image; for that I'd suggest only sorting on size information that's available in the initial data, and ignoring size information discovered later for sorting purposes.

Quote
I can't really understand enough of that Japanese to figure out why the title search has returned results that obviously don't contain the search term in the title... doesn't make much sense to me.

The title search returned nothing--the first line in red is "no results found", the rest is Amazon's "spit bogus search results at you and hope you don't notice it's not what you asked for".  The keyword search returns "ファイナルファンタジー4 ピアノ・コレクションズ" ("Final Fantasy 4 Piano Collection").
Title: Album Art Downloader XUI
Post by: spile on 2011-09-20 17:49:08
The "_XXX" portion refers to language. You would want to download the one that fits your installation of Windows.

There isn't a download button for an English one!
http://www.microsoft.com/download/en/detai...ng=en&id=32 (http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=32)
Title: Album Art Downloader XUI
Post by: tpijag on 2011-09-20 18:04:21
The page you linked to is the english version. This is shown via the selection drop down list showing ENGLISH. Just hit the download now button
Title: Album Art Downloader XUI
Post by: Zarggg on 2011-09-20 20:37:28
@spile: wic_x86_enu.exe
Title: Album Art Downloader XUI
Post by: Joe30 on 2011-09-21 10:13:03
Can I please make a feature request ?
When it scans for new artwork, the main window refreshes itselfs and sorts itself by size (for me). I would like the window to NOT sort itself if my mouse cursor is on the "save" button.

Because sometimes when I want to click to save a folder.jpg, bam! the window updates itself and it saves another picture.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-21 19:20:20
I'd suggest only sorting on size information that's available in the initial data, and ignoring size information discovered later for sorting purposes.

When it scans for new artwork, the main window refreshes itselfs and sorts itself by size (for me). I would like the window to NOT sort itself if my mouse cursor is on the "save" button.

I'm going to count that as two votes for not having results re-order themselves when the size changes as a result of downloading the full size image. It will make sorting and grouping by size useless for a lot of sources, which return unknown-size results, but I can see the argument in favour of it too.

Anyone want to argue for the opposite, that a result should be moved to its correct location in the sort order if the size changes?

Alex
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-09-22 09:34:43
Anyone want to argue for the opposite, that a result should be moved to its correct location in the sort order if the size changes?
Hope I'm not misunderstanding the discussion, but I'd like to share my use case.

I always group by size: if the results contain Unknown size pics, I quickly single-click on each of the interesting ones to move them to the correct group. Only then I inspect the quality of each image, starting from the top group.

I find that workflow handy and would like to keep it this way, if possible.

Thanks.

Alessandro
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-09-22 17:12:40
Anyone want to argue for the opposite, that a result should be moved to its correct location in the sort order if the size changes?

If I understood correctly what this is about, then yes.

I use "group by: source", "sort by: size descending" and "automatically download full-size images: only when unknown" settings and I always wait for the search & "downloading full size images" bars to end before doing anything.
Title: Album Art Downloader XUI
Post by: spile on 2011-09-23 11:25:41
@spile: wic_x86_enu.exe

WIC Setup error:
Newer version of update is already on the system.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-24 09:18:04
Amazon scripts update
I've just uploaded an updated amazon-common.boo (http://album-art.sourceforge.net/scripts/amazon-common.boo) v0.9s, which means that all the Amazon scripts will show as updated in the online updates check. The new version includes contributions from ZOOT to download customer images as well as official images. (If you're curious, other than visiting the url for the result, you can also tell it's a customer image if it has size information available without downloading the full size image).

Finding customer images does take longer than official ones as it involves more page requests from the server, so official images will be downloaded first, followed by customer images if not enough official ones have been found to satisfy the "Limit to n results" setting for the source (10 by default). This behaviour can be changed by editing the  script, either amazon-common.boo to affect all Amazon sources, or by changing an individual country script to change the behaviour for just that one. To change the defaults, in amazon-common, change the values returned by IncludeCustomerImages and IncludeOfficalImages as required. To change a specific country script, add the lines:
Code: [Select]
    override IncludeCustomerImages:
        get: return true
    override IncludeOfficalImages:
        get: return true
and change true to false for whichever images you want to exclude.

@ZOOT: I've decided to keep it searching for the album name in title, rather than keywords, so just make the change from field-title to field-keywords in your local copy if you prefer that.

I'm going to work on making the auto-resorting when size changes optional, as it's clear that it's a source of irritation to some, but useful to others. This will likely take the form of a checkbox somewhere in the options area. If I can, I'll also try to fix it so that just having size filters on doesn't cause re-sorting when size changes in any case.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-25 19:35:04
Version 0.42
This version improves the re-sorting behaviour in a couple of ways. Firstly, I've reduced the occasions on which a result is re-positioned to a minimum - for example, if filtering by size is turned on, but sorting isn't, then a result won't be re-positioned when it's size changes. Further, there is now a checkbox in the Options section which allows you to disable re-sorting altogether.

When this box is checked, once an item appears in the results, it stays where it is there. Of course, changing the filters, sorting or grouping will still cause the results to be filtered and sorted, but changes to the items themselves will have no effect.

The default is still the same old behaviour, to re-sort and re-filter an item whenever it changes, but for those who found this irritating the option to disable it is now available.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.42.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.42.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: Akkurat on 2011-09-26 13:38:12
New version doesn't work like it should be.

http://oi55.tinypic.com/12542yp.jpg (http://oi55.tinypic.com/12542yp.jpg)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-26 18:53:15
Version 0.42.1
Unfortunately a bug with 0.42 has been reported to me where with certain combinations of filters and sorting, a crash would occur when automatically downloading full sized images. This should be fixed by 0.42.1.

@Akkurat: I can't see that image (won't connect, for some reason), but I'm hoping it is related to the same bug that was reported to me by PM, and that this fixes it. If not, I'll get back to you when I can see the image.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.42.1.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.42.1.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-09-26 19:54:36
hey Alex
not sure if it's a bug or meant this way, but Deezer images are back to jpg instead of png in the new version
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-09-27 08:25:14
Deezer images are back to jpg instead of png in the new version
I haven't changed Deezer at all,
could you check that the version you have is 0.3?
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-09-27 09:45:42
thanks, somehow I got most scripts in old versions. fixed now
Title: Album Art Downloader XUI
Post by: spile on 2011-09-28 17:32:53
Once again, this version crashes big time like all versions after 0.37.
I have tried repairing NET framework and uninstalling old versions but it still gives the same error when the browse option is selected from the File menu.
PLEASE DOES ANYONE HAVE ANY IDEAS?

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.42.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'BrowserResults' defined in assembly 'AlbumArt, Version=0.42.1.0, Culture=neutral, PublicKeyToken=null'. Exception has been thrown by the target of an invocation.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/filebrowser.xaml'. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'AlbumArtDownloader.BrowserResults' threw an exception. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
  at System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
  at AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
  at System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
  at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
  at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
  at AlbumArtDownloader.BrowserResults..cctor()
  --- End of inner exception stack trace ---
  --- End of inner exception stack trace ---
  at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
  at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
  at System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
  at System.Activator.CreateInstance(Type type, Boolean nonPublic)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
  at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.FileBrowser.InitializeComponent()
  at AlbumArtDownloader.FileBrowser..ctor()
  at AlbumArtDownloader.Common.NewFileBrowser(IAppWindow existingWindow)
  at AlbumArtDownloader.Menu.NewFileBrowserExec(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: lvqcl on 2011-09-28 17:47:47
The problem is still the same:
Code: [Select]
No imaging component suitable to complete this operation was found.
Title: Album Art Downloader XUI
Post by: erehwon on 2011-10-08 16:05:20
I'm having an issue where the program will come up as just a white screen.    Moving my cursor over the program window, the cursor will change  to the text cursor in the appropriate spot.  It's just not displaying anything.

I'm using the latest version of this software on Windows 7.  I have the latest version of .NET Framework 4 installed.
Title: Album Art Downloader XUI
Post by: erehwon on 2011-10-09 03:34:57
I'm having an issue where the program will come up as just a white screen.    Moving my cursor over the program window, the cursor will change  to the text cursor in the appropriate spot.  It's just not displaying anything.

I'm using the latest version of this software on Windows 7.  I have the latest version of .NET Framework 4 installed.

I fixed my problem.  I uninstalled and reinstalled my graphics drivers.  That appears to have fixed my issue.  I remembered that I didn't have a good install that last time that I updated.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-10-09 08:19:27
I fixed my problem.  I uninstalled and reinstalled my graphics drivers.

Thanks for letting us know!

Alex
Title: Album Art Downloader XUI
Post by: spile on 2011-10-10 18:25:59
Re Crash on browse...
The author has asked for bugs to be placed at http://sourceforge.net/tracker/?func=detai...amp;atid=919575 (http://sourceforge.net/tracker/?func=detail&aid=3415075&group_id=187008&atid=919575)
which I have done but to date no response so far. Interesting to note that others are having the same problem. It would appear that a change to the applicaiton was made (around 0.37) that has caused all the problems. I wonder why this change was done and if there is a way around it?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-10-10 19:00:10
Re Crash on browse...

I've actually answered you several times on this issue, and the answer has not changed since then, I've just stopped repeating it.

There is something wrong with your Windows Imaging Components (WIC) install. These are an integral part of Windows since Windows Vista, which makes it difficult to suggest any easy fixes; those which have been suggested to you by myself and others have apparently not helped.

Previous to version 0.38, AAD used GDI+ for image processing. This is a legacy API, and has various technical disadvantages compared to WIC. I appreciate that for you, any possible advantage of WIC over GDI+ is outweighed by the fact that WIC isn't working, so I recommend you stick with version 0.37.1.

As far as I'm aware, the only other person to report the same error was MC Escher. He did follow my recommendation to try WICExplorer (http://archive.msdn.microsoft.com/wictools/Release/ProjectReleases.aspx?ReleaseId=2887) to investigate the error, and later agreed that there was something amiss with his system as he couldn't play any videos either.

Thanks for pointing out the sourceforge issue you raised - for some reason I didn't get email notification from sourceforge of that, I'll have to figure out why that's broken.

Alex
Title: Album Art Downloader XUI
Post by: spile on 2011-10-12 16:50:25
Re Crash on browse...

I've actually answered you several times on this issue, and the answer has not changed since then, I've just stopped repeating it.

I also responded here to say that when I tried to install the Windows Imaging component, I was given a message that I had the latest version installed.
I would be happy to investigate and possible WIC issues I may have on my XP client , I just don't know how to do this.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-10-12 18:31:15
I would be happy to investigate and possible WIC issues I may have on my XP client , I just don't know how to do this.
As you are running Windows XP, then please try uninstalling WIC by running %windir%\$NtUninstallWIC$\spuninst\spuninst.exe, then reinstalling them using the wic_x86_enu.exe (http://www.microsoft.com/downloads/info.aspx?na=41&srcfamilyid=8e011506-6307-445b-b950-215def45ddd8&srcdisplaylang=en&u=http:/%2fdownload.microsoft.com%2fdownload%2ff%2ff%2f1%2fff178bb1-da91-48ed-89e5-478a99387d4f%2fwic_x86_enu.exe) installer I think you already downloaded.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-10-14 14:52:09
ok, I hope this is not another of stupid questions.
I stopped getting results from Deezer, despite the site being on and active. no idea why. the service itself wasn't and still isn't available in my country, but it was never a problem
Title: Album Art Downloader XUI
Post by: spile on 2011-10-14 16:26:33
I would be happy to investigate and possible WIC issues I may have on my XP client , I just don't know how to do this.
As you are running Windows XP, then please try uninstalling WIC by running %windir%\$NtUninstallWIC$\spuninst\spuninst.exe, then reinstalling them using the wic_x86_enu.exe (http://www.microsoft.com/downloads/info.aspx?na=41&srcfamilyid=8e011506-6307-445b-b950-215def45ddd8&srcdisplaylang=en&u=http:/%2fdownload.microsoft.com%2fdownload%2ff%2ff%2f1%2fff178bb1-da91-48ed-89e5-478a99387d4f%2fwic_x86_enu.exe) installer I think you already downloaded.

Alex


Attempting to run the file above results in a message that a newer version of WIC exists on my system.
No such folder ($NtUninstallWIC$) exists in my Windows folder.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-10-14 18:46:47
I stopped getting results from Deezer
It looks like Deezer have started doing geo-ip restriction on their API as well as their main site now. Shame, it was good while it lasted. If they ever do start accepting connections from my IP, I can update the script if it needs it. I'd be interested to know if anyone is successfully using it in a Deezer-supported country, though.

No such folder ($NtUninstallWIC$) exists in my Windows folder.
That's a shame. According to the documentation I found on the web, that's where it goes when it's properly installed. You may well just be out of luck, but here are some other things that just might be worth a shot:That's about all I can think of, so if none of those help then I'm out of ideas, and would class your installation as unrecoverable.

Alex
Title: Album Art Downloader XUI
Post by: alsaan on 2011-10-23 18:22:54
I've used a few times the .NET Framework Cleanup Tool (http://blogs.msdn.com/b/astebner/archive/2008/08/28/8904493.aspx) to repair corrupted .NET installations with success. I don't know if it will help with WIC problems but it's worth a try if everything else fails.
Title: Album Art Downloader XUI
Post by: max1234 on 2011-10-23 22:57:37
Hello,
my first message here.
I'm writing because I'm experiencing an annoying issue: here's what happens.

I'm using AlbumArt Downloader v 0.42.1 (but the problem was present in earlier versions too); If I enable several filters together (let's say 10-12 or so) then I run a search (i.e. "Pink Floyd" / "The Wall"), the program starts great but after a few seconds my ADSL router  (Dlink DSL-2542B) stops working and there's no way to connect to internet nor to the router itself; The only way to bring it back to life is to turn it off/on. :-(

I think that's because so many TCP requests at the same time have the same effect as a Denial Of Service attack on my poor router.
Maybe a firmware update could solve that but unfortunately, until now, i'm not been able to find any FW version which was recognized as "compatible" by the router... Most probably another bug in that buggy device :-/

OK, my opinion is that the router is guilty, and i'm planning to replace it in a short time; However, I think that would be useful for other users too having an option which allows to set the maximum number of requests that the scripts can issue to remote servers (or the maximum number of scripts that can be run at the same time).
Could it be implemented?

Thanks for your attention!

Max - Italy
Title: Album Art Downloader XUI
Post by: dano on 2011-10-26 14:51:17
Is it possible to display the file size of the covers somewhere?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-10-26 18:15:09
Hi Max, please see my reply to the tracker you raised for this issue: 3427693 (http://sourceforge.net/tracker/?func=detail&aid=3427693&group_id=187008&atid=919576)

Is it possible to display the file size of the covers somewhere?
If you mean the file size of the search results, then no, that isn't possible yet. It has been requested, though: 2890572 (http://sourceforge.net/tracker/?func=detail&aid=2890572&group_id=187008&atid=919578), so it may eventually happen. The file size of existing images is available in the File Browser.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-10-29 15:58:12
Would it be possible to add a script for this site?
http://audiopreservationfund.org/index.php (http://audiopreservationfund.org/index.php)

They have some really nice scans of old LPs and singles.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-10-29 16:22:06
Would it be possible to add a script for this site?
Hmm... could be a tricky one, I can't see any way of searching for a specific artist and album at the same time, which makes it harder. Once the page for the album is found, it wouldn't be hard to get the images for it though. I'm off on holiday for a week now, so won't be able to take a look at this until later.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-10-29 16:24:04
Have a nice holiday!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-19 10:30:33
Would it be possible to add a script for this site?
http://audiopreservationfund.org/index.php (http://audiopreservationfund.org/index.php)

They have some really nice scans of old LPs and singles.

I'm back! (Actually got back last week, but forgot about this). Please give audiopreservationfund.boo (http://album-art.sourceforge.net/scripts/audiopreservationfund.boo) and let me know how you get on with it.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-11-19 11:04:36
Thanks!

The script is not finding any art for singles. It works for LPs.

Could this site be added as well? http://www.45cat.com/ (http://www.45cat.com/)

(Yes, I am back upgrading cover art for singles and singles cover art for individual tracks in compilations.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-19 11:53:22
The script is not finding any art for singles. It works for LPs.
The script doesn't try and make any distinction - can you give me an example of a single with art that it should have found?

45cat should be possible, I'll have a go at that later today, or maybe tomorrow.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-11-19 11:57:43
I think I tried with:
Gene Austin   Without You Sweetheart
Clif Bruner   Born To Be Blue

and two others that I cannot remember now.

Via the "Preserved Recordings" page you can find singles that has cover art.

Thanks for trying to add 45cat!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-19 12:15:44
Which archive did you find them in? I'm searching University of Texas at Austin Historical Music Recordings (http://audiopreservationfund.org/archives.php?archive_id=7&table=overview) and Bowling Green State University (http://audiopreservationfund.org/archives.php?archive_id=8&table=overview), as those seem to be the only ones with cover art for LPs.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-11-19 12:19:13
Which archive did you find them in? I'm searching University of Texas at Austin Historical Music Recordings (http://audiopreservationfund.org/archives.php?archive_id=7&table=overview) and Bowling Green State University (http://audiopreservationfund.org/archives.php?archive_id=8&table=overview), as those seem to be the only ones with cover art for LPs.


I found them on the Audio Preservation Fund site itself, for example http://audiopreservationfund.org/acquisiti...gles&id=265 (http://audiopreservationfund.org/acquisitionsdetail.php?collection_id=COL_00012&table=Singles&id=265) (Click on one of the small images and you will get a very large image.)
Title: Album Art Downloader XUI
Post by: vagskal on 2011-11-19 13:30:31
And this one: http://www.45picturesleeves.com/ (http://www.45picturesleeves.com/)
Title: Album Art Downloader XUI
Post by: spile on 2011-11-19 16:25:26
I've used a few times the .NET Framework Cleanup Tool (http://blogs.msdn.com/b/astebner/archive/2008/08/28/8904493.aspx) to repair corrupted .NET installations with success. I don't know if it will help with WIC problems but it's worth a try if everything else fails.
Thanks for the suggestion but no joy.
I ran the clean up app which removed .Net from my system.
I then did a fresh install of .Net 3.5
This time AAD just crashed (error below).

Just to be sure I tried installing WIC again but the same error about me having a later version came back.

This is comfirmed by WIC.log (below).
I am guerssing that XP SP3 contains a non-uninstallable version of WIC 6.3.4.0 and this is incompatible with AAD

WIC error log...

0.219: ================================================================================
0.219: 2011/09/23 11:24:34.578 (local)
0.219: d:\ca95abc5e30f90d3f3348a\update\update.exe (version 6.3.4.0)
0.219: Hotfix started with following command line:
0.250: In Function GetBuildType, line 1170, RegOpenKeyEx failed with error 0x2
0.375:  C:\WINDOWS\system32\WindowsCodecs.dll is Present
0.422: FileVersion of C:\WINDOWS\system32\WindowsCodecs.dll is Greater Than 6.0.5840.16388
0.422: Condition Check for Line 1 of PreRequisite returned FALSE
0.454: WIC Setup encountered an error:  Newer version of update is already on the system.
0.500: Newer version of update is already on the system.
65.438: Message displayed to the user: Newer version of update is already on the system.
65.438: User Input: OK
65.438: Update.exe extended error code = 0xf0f4
65.438: Update.exe return code was masked to 0x643 for MSI custom action compliance.


AAD error:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.42.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'BrowserResults' defined in assembly 'AlbumArt, Version=0.42.1.0, Culture=neutral, PublicKeyToken=null'. Exception has been thrown by the target of an invocation.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/filebrowser.xaml'. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'AlbumArtDownloader.BrowserResults' threw an exception. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
  at System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
  at AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
  at System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
  at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
  at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
  at AlbumArtDownloader.BrowserResults..cctor()
  --- End of inner exception stack trace ---
  --- End of inner exception stack trace ---
  at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
  at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
  at System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
  at System.Activator.CreateInstance(Type type, Boolean nonPublic)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
  at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.FileBrowser.InitializeComponent()
  at AlbumArtDownloader.FileBrowser..ctor()
  at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-19 17:21:36
@spile:I can confirm that the AAD error log is indicating the same problem. Is anyone else running AAD successfully on XP SP3? If so, it would be really useful to know the version number of C:\WINDOWS\system32\WindowsCodecs.dll that you have!

@vagskal:Here's a script for 45cat to try out: 45cat.boo (http://album-art.sourceforge.net/scripts/45cat.boo). It doesn't look like 45picturesleeves.com has a search function, and I don't really fancy writing one for them. LP art is probably niche enough that two scripts are enough anyway :-)

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-11-19 17:47:37
@vagskal:Here's a script for 45cat to try out: 45cat.boo (http://album-art.sourceforge.net/scripts/45cat.boo).


Thanks! You are fast.

I think that the 45cat script finds too much. It is like it is not restricting the search to releases by the artist you search for. Perhaps it is a limitation of the search function on the site.

Is the Chartstat script working? It never finishes.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-19 18:31:06

The search I'm using for 45cat is just "artist name" "album name". According to the instructions on the advanced search page (http://www.45cat.com/45_search_adv.php), using quotes should make it search for the phrase, but I don't really see any evidence of that, unfortunately. I don't understand how some of the results it's returning are chosen at all!

Chartstats is working fine for me, maybe it was a temporary problem? Or the specific thing you were searching for?
Title: Album Art Downloader XUI
Post by: bilbo on 2011-11-20 01:33:22
Alex, Thank you for this wonderful program!

I am running on XP SP3 without any problems.

windowscodecs.dll v6.0.6001.17009
windowscodecsext.dll v6.0.6001.17009
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-11-20 14:21:18
Is anyone else running AAD successfully on XP SP3? If so, it would be really useful to know the version number of C:\WINDOWS\system32\WindowsCodecs.dll that you have!
Works fine here: XP Pro SP3 - WindowsCodecs.dll v6.0.6001.22211

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-20 16:22:34
windowscodecs.dll v6.0.6001.17009
windowscodecsext.dll v6.0.6001.17009

WindowsCodecs.dll v6.0.6001.22211

Thanks for these! I've got hold of a Win XP CD and tried it out on a fresh blank virtual machine. After installing SP3 and .Net 3.5 through Windows Updates, I have WindowsCodecs.dll v6.0.6001.17009 too. I don't know how mobyduck got a newer version, but can you check what version you have, Spile?
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-11-21 07:06:50
I don't know how mobyduck got a newer version
Neither do I, but it does exist: see here (http://support.microsoft.com/kb/954708/en-us).

Alessandro
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-21 07:58:14
see here (http://support.microsoft.com/kb/954708/en-us).

Oh, nice find! It's got to be worth having a go at downloading and installing that, Spile. If it's newer than the version you've got, it might overwrite your broken installation with a new one, which might then work. That's a lot of 'might', but not a lot of other ideas going around at the moment.

Alex
Title: Album Art Downloader XUI
Post by: bilbo on 2011-11-21 20:39:57
@mobyduck
Is there something that you need in the newer versiona or can you simpky go to the older version which seems to be the current standard.
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-11-22 07:55:02
Sorry, I'm not sure I understand... As I said, I don't know how I got that version but if it ain't broken why fix it?

Alessandro
Title: Album Art Downloader XUI
Post by: bilbo on 2011-11-22 14:19:12
Sorry, I'm not sure I understand... As I said, I don't know how I got that version but if it ain't broken why fix it?


But you are reporting that it is broke with AAD. Using the standard version may solve the problem!
Title: Album Art Downloader XUI
Post by: mobyduck on 2011-11-22 14:49:02
Nope, Spile is complaining: I have zero problems with AAD.

Alessandro
Title: Album Art Downloader XUI
Post by: spile on 2011-11-22 16:27:19
I downloaded and installed the hotfix above.
Have also updated my graphics card drivers to latest version.
Installed version 0.42 of the application.
Program launched and then immediately creashed (error below)
Checked Windows codecs and they are 6.0.6001.22211


Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.42.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'BrowserResults' defined in assembly 'AlbumArt, Version=0.42.1.0, Culture=neutral, PublicKeyToken=null'. Exception has been thrown by the target of an invocation.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/filebrowser.xaml'. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'AlbumArtDownloader.BrowserResults' threw an exception. ---> System.NotSupportedException: No imaging component suitable to complete this operation was found. ---> System.Runtime.InteropServices.COMException (0x88982F50): Exception from HRESULT: 0x88982F50
   --- End of inner exception stack trace ---
   at System.Windows.Media.Imaging.BitmapEncoder.EnsureUnmanagedEncoder()
   at System.Windows.Media.Imaging.BitmapEncoder.get_CodecInfo()
   at AlbumArtDownloader.BrowserResults.<GetSupportedCodecs>d__8.MoveNext()
   at System.Linq.Enumerable.<SelectManyIterator>d__31`3.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at AlbumArtDownloader.BrowserResults..cctor()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
   at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
   at System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
   at System.Activator.CreateInstance(Type type, Boolean nonPublic)
   at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
   --- End of inner exception stack trace ---
   at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
   at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
   at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
   at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
   at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
   at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
   at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
   at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
   at System.Windows.Markup.TreeBuilder.Parse()
   at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
   at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
   at AlbumArtDownloader.FileBrowser.InitializeComponent()
   at AlbumArtDownloader.FileBrowser..ctor()
   at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
   at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   at System.Windows.Application.<.ctor>b__0(Object unused)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-11-28 09:34:04
hi Alex
not sure if it's not just me again, but discogs doesn't find anything at all these days. maybe the script needs to be updated?
thanks in advance
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-11-29 13:47:47
also, I think all iTunes images are now restricted to 600x600? wonder what's that about and is there any way to fix it, cause it's VERY unpleasant
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-11-29 19:51:07
I downloaded and installed the hotfix above.
Have also updated my graphics card drivers to latest version.
Installed version 0.42 of the application.
Program launched and then immediately creashed (error below)
Checked Windows codecs and they are 6.0.6001.22211

That's a shame, it's still the same error. I'm afraid I don't have any further ideas here - you have the right version, but there's still something wrong with the installation.

not sure if it's not just me again, but discogs doesn't find anything at all these days. maybe the script needs to be updated?
...
also, I think all iTunes images are now restricted to 600x600? wonder what's that about and is there any way to fix it, cause it's VERY unpleasant

Discogs fix is up: discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo). It does look like iTunes has stopped serving any full-size images, which is a pity. It was nice while it lasted, though. If anyone discovers an alternative way to get the full size images, please do let me know, and I'll update the script for it.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-11-29 19:59:58
Discogs fix is up: discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo). It does look like iTunes has stopped serving any full-size images, which is a pity. It was nice while it lasted, though. If anyone discovers an alternative way to get the full size images, please do let me know, and I'll update the script for it.

Alex

thanks for the response! discogs work fine now.

as for iTunes, well, I do still get occasional big ones, but very far and between, mostly this goes for *.tif files. who knows, maybe it's just a temporary glitch.

thanks for all the work, as always
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-12-01 19:11:01
now that sucks even more - most of iTunes results are now 170x170! are they blocking the outsiders somehow?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-12-02 20:16:55
now that sucks even more - most of iTunes results are now 170x170! are they blocking the outsiders somehow?

Looks like it. I'm seeing 403 - Forbidden responses to larger size requests. This comment (http://www.mcelhearn.com/2011/11/26/how-to-get-itunes-album-art-without-using-itunes/#comment-13670) suggests one possible cause. I'll leave the iTunes script in for now, in case they change their mind, but if it doesn't start working again I'll have to remove it as 170x170 is not really a useful image size.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-12-02 20:41:50
well, it does bring some big ones occasionally, as it seems they reduced only the standard 1425x1425 images and few others. some still remain with unusual sizes, so don't rush into anything...

maybe there's another way though?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-12-04 09:28:35
Version 0.43
This version adds support for Windows 7 taskbar functionality, with JumpList entries to open a new search window or the file or foobar browser, and progress indication. The progress indication for the search window shows the number of sources still working (rather than the progress of individual sources, which you can still see in the sources list). As sources search in parallel, this usually means the progress won't move at all for a little while, then might suddenly start completing as the sources all finish searching at similar times, but at least it gives you some general overall indication of the search.

Progress indication is also shown for the Automatic Downloader and the Queue windows.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.43.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.43.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: godrick on 2011-12-05 01:38:44
Alex, sorry if this was requested before but I missed it - it would be great if the Foobar Browser had the same options under "Options..." as the File Browser.  Most important is the ability to detect embedded images.  Alternatively, perhaps you could add foobar-specific "search for media in" options to the File Browser - the ability to just look in Foobar playlists, filters and library viewer selections is quite handy.  Whatever works easiest for you of these two alternatives would be great.

Thanks for an outstanding application!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-12-05 08:07:49

Hi Godrick, the problem here is that Foobar doesn't provide the embedded image information through the COM interface. So while I can query the library or playlist for all the albums in it, I can't ask it for the artwork too. The only way to get the embedded artwork would be to actually read every file off disk, which would negate all the speed benefits of using the foobar browser, and make it just as slow as the file browser. I can see your point, though, that you might want to use the foobar browser for the playlist organisational functionality, rather than avoiding file metadata searches, but it would have to be an optional setting, off by default. Feature Request (https://sourceforge.net/tracker/?func=detail&aid=3451113&group_id=187008&atid=919578)

Alex

Title: Album Art Downloader XUI
Post by: DavidLeigh on 2011-12-08 17:27:58
Hello All,

This is my first time out here, and a very new user to Album Art Downloader am I -- only  a couple of weeks and only by hand.  I am running Windows XP SP2 (with all SP3 updates except the video driver which gives me the blue-screen-of-death) with .NET Framework v4.  All was well for the first week of use, so...

THANK YOU!  It is awesomely helpful.

What I noticed this week, even with the latest version, is that thumbnails sometimes disappear before the image can be saved.  I think this is related to a previous post about "iTunes limiting size to 170 px" in that I think the problem is not Album Art Downloader, but a site-blockage strategy.  Nevertheless, I wanted to share what was happening because I did not see it mentioned out here explicitly.

I have no filtering, no grouping, and have checked the box "Do not move or filter existing results."  I enter an Artist and Album, and request a search.  It populates wonderfully, but as you know, most of the album sizes are "unknown."  So typically I press and hold the mouse left mouse button over the thumbnail to get a full-size preview.  Often when I release the mouse button the preview and thumbnail disappear.  This mostly happens with iTunes and Amazon.  So, I began trying a no-preview direct save using the save button.  The thumbnails would simply disappear.  Recently, the last two nights, following a preview and left mouse button release, the thumbnail will remain but change to a graphic of a blank disk (black background with gray disc).

So, and here is where it gets interesting, since a mouse button press is one thing and mouse button release is another, I began left-pressing for a preview, then right-clicking the preview images while continuing to keep the left button pressed.  That keeps the preview in place and brings up the Windows Save pop-up menu with the default file name from Album Art Downloader.  I then release my left-press (and sometimes have to click somewhere neutral on the screen to get the preview to disappear), then do the save manually from the pop-up.  Though clever, this never works to save the album art; but it does provide an additional bit of information for you -- when it does the save (if it does the save) the image size is always (-1 x-1). 

Which is why I thought this might be like the image size limitations appearing from iTunes (170x170), less often Amazon (50x50), and now the occasional gray-disk graphic.  They are, perhaps, attempting to bypass robo-searching with tiny thumbnails, changing thumbnails, or "negative ones" (-1x-1).

I hope this helps.  Respectfully and gratefully, Dave...
Title: Album Art Downloader XUI
Post by: spile on 2011-12-09 17:48:07
Version 0.43

My thanks to the author for this version which doesn't crash on browse for me!
 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-12-09 18:57:22
What I noticed this week, even with the latest version, is that thumbnails sometimes disappear before the image can be saved.
That is not expected behaviour at all! If you don't have any filters turned on, then the results should never be removed from the list. If a full-sized image can't be downloaded, it falls back on the thumbnail that it's already got. The graphic of a black background with a grey disc is not part of Album Art Downloader itself, it must be being returned by the source itself - do you know which source it was that did this? It might be possible to fix the script to avoid it.

I wasn't able to reproduce the issue with iTunes or with Amazon.com, but would you mind trying the following - rather than left-clicking on the thumbnail, right click on it and choose "Preview". This will bring up a separate window that will stay open. It should show the (enlarged) thumbnail, then the full sized image when it finishes downloading. If something goes wrong, it might provide more information as to what. If you can, I'd also appreciate knowing an exact artist, album, and source to search that shows this problem for you.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-12-12 16:07:11
hey, Alex
just a thought on my side - maybe there's a sense in adding a script for searching the blogspot.com area? there are quite a lot of people who share their collections, and high quality results often come up when searching there.
Title: Album Art Downloader XUI
Post by: vagskal on 2011-12-18 11:41:26
Would it be possible to add this site?
http://covers.a-go.in (http://covers.a-go.in)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2011-12-18 11:53:14
searching the blogspot.com area?
As far as I can tell, there's no uniform way of presenting covers or searching for them - blogspot is far too general for that! The best bet for this is just to use the google images script, which will be indexing all of blogspot anyway.

Would it be possible to add this site?
http://covers.a-go.in (http://covers.a-go.in)
The problem with this one is a lack of a search facility. I suppose it might be possible to write a script that would work as long as you had the artist and album name exactly as they have it on the site, so I'd just go straight to the right page, but I doubt that would be very reliable.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2011-12-18 11:55:16
OK, I see. Thanks for the reply!
Title: Album Art Downloader XUI
Post by: pianoinbush on 2011-12-19 21:16:06
wow, seems like Deezer is back all of a sudden. good news.
Title: Album Art Downloader XUI
Post by: dubwai on 2011-12-23 12:42:01
Fucking apple with their practice to sell even air. 170 x 170 is bad news for everyone :-(

P.S. http://a1.phobos.apple.com/r10/Features/c2...dj.jvzokecp.jpg (http://a1.phobos.apple.com/r10/Features/c2/27/b7/dj.jvzokecp.jpg) why it work? I try to add various data to this link from 170x170 links, but no result.
Title: Album Art Downloader XUI
Post by: günter on 2012-01-02 16:59:25
I read a little through the thread but I couldnt figure out how I save the covers as cover.jpeg instead of folder.jpeg for my cowon j3.

I do the renaming right now with a batch file which is probably not the easiest method.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-02 17:56:04
how I save the covers as cover.jpeg instead of folder.jpeg

If you are starting directly from the main search window, then click the Options link in the search window, and in the "Save Images To" box replace the text Folder with Cover

If you are starting from the File Browser or Foobar Window, click the Options link in that window, and in the "Specify path to find images" box remove the text Folder%preset%.%extension%| so that it just says Cover%preset%.%extension% If you still want it to count albums with images called Folder.jpg as already having artwork, but to save as Cover.jpg instead of Folder.jpg, then the value to put in the box is Cover%preset%.%extension%|Folder%preset%.%extension% (the two options are separated by a |, and it takes the first option as the name to save any new images as).

If you are starting from foobar, or MP3Tag, or some other program, then check the command line that you are using to launch Album Art Downloader. It probably includes Folder somewhere, so just replace that with Cover keeping the rest of the command line the same.

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: booman on 2012-01-05 22:04:58
Can anyone explain to me which setting allows me to save scraped artwork to coinciding album directory?
Title: Album Art Downloader XUI
Post by: OrcaMarinha on 2012-01-25 05:43:54
I get an memory error when searching my foobar library when it reaches exactly 2234 albums, allways. Is there any way to around this ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-25 08:32:37
Can anyone explain to me which setting allows me to save scraped artwork to coinciding album directory?
Sorry, I never saw your post! If you give me a few more details, I can probably help you out. Where are you starting from, are you launching AAD from Foobar, or using the File Browser, or just typing in the artist and album name into the search fields directly?

I get an memory error when searching my foobar library when it reaches exactly 2234 albums, allways. Is there any way to around this ?
That's weird, I've tested it with many more albums than that. Does it produce an error log? It should open up notepad showing a text file called errorlog.txt when it crashes; if you can PM me that I'll see if it offers any clues.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2012-01-25 18:02:37
hi
7digital was completely redesigned and now doesn't bring any results in AAD... so I was wondering if maybe it's time for a new script?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-25 19:39:51
Hi, thanks for bringing that to my attention. New 7digital.boo (http://album-art.sourceforge.net/scripts/7digital.boo) now available.

Alex
Title: Album Art Downloader XUI
Post by: westgroveg on 2012-01-26 02:55:00
Thanks to Alex and all the contributors for this utility, works great!
Title: Album Art Downloader XUI
Post by: TGK on 2012-01-28 11:52:24
AlexVallat

Hi !

Script to load the image from the site www.discogs.com does not work. 

Program Version Album Art Downloader XUI - 0.43.0.0
Version script for www.discogs.com - 0.11

Settings program Album Art Downloader:
(http://ib2.keep4u.ru/s/2012/01/28/6a/6a397620dd072b6936323c7b262d0fe8.jpg) (http://keep4u.ru/full/6a397620dd072b6936323c7b262d0fe8.html)

I tried the corrected version of the script for discogs.com, here - http://album-art.sourceforge.net/scripts/discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) ,  still does not work
Title: Album Art Downloader XUI
Post by: maynak00 on 2012-01-28 12:12:16
Would it be possible to add this site? possible to preserve original filenames??
http://www.esenshop.com/ (http://www.esenshop.com/)

and Thanks to AlexVallat and all the contributors for this utility, works great!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-28 14:33:16
Script to load the image from the site www.discogs.com does not work.

It's working fine for me... I tried the search shown in the screenshot you posted, but as far as I can tell the problem is simply that discogs doesn't have that album: Nikolai Raivermeister Vol 1 on Discogs (http://www.discogs.com/advanced_search?artist=Nikolai&release_title=Raivermeister+Vol+1).

Would it be possible to add [esenshop]?

Sure, we don't have any Turkish sources yet. Try this: esenshop.boo (http://album-art.sourceforge.net/scripts/esenshop.boo) and let me know if it's working well for you. I'm afraid I don't understand what you mean by "possible to preserve original filenames", though - could you give me an example of the filename you want it to use?

Alex
Title: Album Art Downloader XUI
Post by: TGK on 2012-01-28 14:52:58
Script to load the image from the site www.discogs.com does not work.

It's working fine for me... I tried the search shown in the screenshot you posted, but as far as I can tell the problem is simply that discogs doesn't have that album: Nikolai Raivermeister Vol 1 on Discogs (http://www.discogs.com/advanced_search?artist=Nikolai&release_title=Raivermeister+Vol+1).

Alex


No, the album was listed in the search, still does not work
Title: Album Art Downloader XUI
Post by: dano on 2012-01-28 15:46:17
TGK You've spelled it wrong and you should remove the artist from the search (or use "Various"):
http://www.discogs.com/advanced_search?rel...Search+Releases (http://www.discogs.com/advanced_search?release_title=Ravermeister+Vol+1&btn=Search+Releases)
Title: Album Art Downloader XUI
Post by: TGK on 2012-01-28 16:12:27
TGK You've spelled it wrong and you should remove the artist from the search (or use "Various"):
http://www.discogs.com/advanced_search?rel...Search+Releases (http://www.discogs.com/advanced_search?release_title=Ravermeister+Vol+1&btn=Search+Releases)

Did you have written, it is still not working - not looking
Either the script does not work consistently, or the resource itself

Check it out - with my settings
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-28 16:55:09
Check it out - with my settings


(http://www.byalexv.co.uk/temp/aad_discogs_ravermeister.png)

Looks just fine to me. If your are doing the same search, with the same settings, and getting nothing, I can only assume that discogs doesn't like your IP address. They may be blocking either your address specifically, or have a wider block, I don't know and have no way to find out - sorry.

Alex
Title: Album Art Downloader XUI
Post by: TGK on 2012-01-28 17:52:03
I am from Russia.
Working - the image is loaded, but very, very slowly, but at the same page with these images on www.discogs.com Opera browser loads quickly - no problems. Internet channel is free to download and return - no downloads files or other application that can download the Internet channel and there is not running.

The only thing that confuses a ping to the site www.discogs.com:
Pinging www.discogs.com [70.103.226.22] with 32 bytes of data:

Reply from 70.103.226.22: bytes = 32 time = 230ms TTL = 56
Reply from 70.103.226.22: bytes = 32 time = 234ms TTL = 56
Reply from 70.103.226.22: bytes = 32 time = 234ms TTL = 56
Reply from 70.103.226.22: bytes = 32 time = 234ms TTL = 56
Ping statistics for 70.103.226.22:
    Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),
Estimated round-trip time in milliseconds:
    Minimum = 230msek, Maximum = 234 ms, Average = 233 ms

And what if they block my IP and / or a band, have any ideas?

May be related to IP blocking so that the program generates a large number of requests to a page / website and the server treats it as an attack and blocks IP?

a number of queries generated by the program in seconds and minutes and can be somewhere you can configure this option ?

It is possible that the problem with loading the image using Album Art Downloader associated with a firewall - I have installed Eset Smart Security 4.2, built-in firewall there? or not? - Although I put in the exclude AAD firewall - but it did not help 
May be related to slow download speeds image so that the program requires a large number of free space on drive C for the script (to parse the header html) - I have 6GB of free space on drive C.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-28 18:13:18

It's possible that rather than blocking your IP, they are throttling it, but that's only a guess. What I would suggest would be to uncheck the "always download full size" option for Discogs, and only download the full size images that you want to keep (it will do this automatically, if you save a result). It might also be worth reducing the number of results from 10, to reduce the number of requests made to the website.

I don't think a firewall would be the problem, either it would block AAD completely, or allow it. AAD only downloads using http (port 80), it doesn't do any special network traffic. It doesn't use any disk space until you actually choose to save the image. It can use quite a lot of memory, if you have a lot of full size images in the results, but it doesn't save them to disk unless requested.

Alex
Title: Album Art Downloader XUI
Post by: TGK on 2012-01-28 18:51:55

It's possible that rather than blocking your IP, they are throttling it, but that's only a guess. What I would suggest would be to uncheck the "always download full size" option for Discogs, and only download the full size images that you want to keep (it will do this automatically, if you save a result). It might also be worth reducing the number of results from 10, to reduce the number of requests made to the website.

Alex

No effect.

Before loading with discogs.com worked quickly.

Maybe you need to install a newer version of NET Framework or any particular version of the NET Framework. Maybe that's the problem ?
Title: Album Art Downloader XUI
Post by: TGK on 2012-01-28 18:55:36
AlexVallat
Perhaps this problem could be solved if the program saddle configuration:

" Username and password " used for logging on to www.discogs.com, which enters username and password you use for user authentication on the resource.

In another program to load the tags from an online resource for all discigs.com located and loaded quickly.

Can be slow work discogs script due to the fact that in the site database has changed and used the new API, and these changes are not reflected in the current version of the script ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-28 19:25:44

I don't think logging in will make a difference, as far as I can tell the image retrieval doesn't make use of any authentication at all. I've just checked the discogs documentation, and they state that requests are throttled to one per second per IP, and image requests are further throttled to a maximum of 1000 per day per IP (ref (http://www.discogs.com/developers/accessing.html#rate-limiting))

That seems quite a lot to me, but if you stop getting images at all, that might be why, particularly if your discogs-facing IP address might be shared for whatever reason (VPN, ISP reuse, or anything like that).

It is certainly not dependent on the version of the .NET Framework.

If you want to investigate further yourself, I'd suggest installing fiddler2 (http://fiddler2.com), which will allow you to monitor both the web requests made by AAD and the responses received.

Alex
Title: Album Art Downloader XUI
Post by: TGK on 2012-01-28 19:40:45
It is unlikely that I'm doing so many requests to dicogs.com unless the count of making a program that I use mp3tag
Title: Album Art Downloader XUI
Post by: maynak00 on 2012-01-29 11:23:20
Quote
Would it be possible to add [esenshop]?

Sure, we don't have any Turkish sources yet. Try this: esenshop.boo (http://album-art.sourceforge.net/scripts/esenshop.boo) and let me know if it's working well for you. I'm afraid I don't understand what you mean by "possible to preserve original filenames", though - could you give me an example of the filename you want it to use?

Alex


thanks for your quick reply.
plugin working,thanks  .but only working for front covers.

front+back covers incl. example link:
http://www.esenshop.com/detail.aspx?id=50211 (http://www.esenshop.com/detail.aspx?id=50211)
http://www.esenshop.com/photo.aspx?id=50211 (http://www.esenshop.com/photo.aspx?id=50211)
cover direct links:
http://www.esenshop.com/upload/big/62338697420611217.jpg (http://www.esenshop.com/upload/big/62338697420611217.jpg)
http://www.esenshop.com/upload/big/73738697420611217-1.jpg (http://www.esenshop.com/upload/big/73738697420611217-1.jpg)

only front cover incl. example link:
http://www.esenshop.com/detail.aspx?id=67741 (http://www.esenshop.com/detail.aspx?id=67741)
http://www.esenshop.com/productPhoto.aspx?...93219005564.jpg (http://www.esenshop.com/productPhoto.aspx?p=upload/big/86868693219005564.jpg)
cover direct link:http://www.esenshop.com/upload/big/86868693219005564.jpg (http://www.esenshop.com/upload/big/86868693219005564.jpg)

I mean for original filename(with ext.):86868693219005564.jpg .no front.jpg;folder.jpg;back.jpg...etc

I am sorry for my English.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-29 12:18:01

Hmm... unfortunately there doesn't seem to be any way of discovering the ID numbers for anything other than the front cover without having to download the photo.aspx page for each result. That's going to make the number of requests per search a lot higher!

There's no normal way of using part of the URL as the filename, but what I could do is add a line that you could change by editing the .boo file itself so that the name of the result would show up as the ID number, instead of the artist/album. Then you could use %name% to substitute it into the filename. I don't really understand why you would want that, though, surely those ID numbers are meaningless?

Alex
Title: Album Art Downloader XUI
Post by: OrcaMarinha on 2012-01-29 18:21:58
I get an memory error when searching my foobar library when it reaches exactly 2234 albums, allways. Is there any way to around this ?
That's weird, I've tested it with many more albums than that. Does it produce an error log? It should open up notepad showing a text file called errorlog.txt when it crashes; if you can PM me that I'll see if it offers any clues.

Alex

No it doesn't produce an error log because it doesn't crash. It just says: Error occurred while reading media library:Insufficient memory to continue the execution of this program.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-29 18:53:27
No it doesn't produce an error log because it doesn't crash. It just says: Error occurred while reading media library:Insufficient memory to continue the execution of this program.

Hmm... that's curious. You said it always happens after exactly 2234 albums, I wonder if you could have a look at the 2235th album in your library, and see if there is anything unusual about it? Also, please try creating playlists containing subsets of your library (say ~2000 albums in each?) and try importing each one individually (you can select the playlist to import rather than the entire library). That might give more clues as to what is going wrong - it may be a specific album or albums that causing a problem, or it may really be that there isn't enough memory available to hold more than 2234 albums in the browser list, but I doubt it.

Alex
Title: Album Art Downloader XUI
Post by: OrcaMarinha on 2012-01-29 23:04:30
Thanks it worked but it reached the limit at 4000 albums so I just did the playlists trick and worked. But when I go to the foobar he still doesn't show the cover it download why ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-30 07:57:45
when I go to the foobar he still doesn't show the cover it download why ?
Check to see if the cover file has been saved where you thought it should be. If it has, then check in foobar under Preferences/Display and make sure that under Album art it's set with the correct filename(s) to match.

Alex
Title: Album Art Downloader XUI
Post by: justsetmefree on 2012-01-31 12:06:18
Can you add multiple search.

For example program read the albums.txt

albums.txt like that

Code: [Select]
Iron Maiden - Fear Of The Dark
Apocalyptica - Bittersweet
... - ...
... - ...


That take Iron Maiden to artist text then fear of the dark part is album name. Search and save first album cover. (Usually the first cover is real (good) cover)

If this option already included the program, I'm sorry but I didn't found that
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-01-31 18:49:53
Can you add multiple search.

There's no capability for doing this based on the contents of a text file, no. I didn't think it was a very common scenario. It can do it for file and folder names, though - if you use the File Browser (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=The_File_Browser) you can get a to get a list of albums based off the path and filename of files and folders. You can then use the Automatic Image Downloading (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Automatic_Image_Downloading) feature to search for each album in turn, and save the first result found.

Would that do the job for you?

Alex
Title: Album Art Downloader XUI
Post by: justsetmefree on 2012-02-01 18:54:04
Can you add multiple search.

There's no capability for doing this based on the contents of a text file, no. I didn't think it was a very common scenario. It can do it for file and folder names, though - if you use the File Browser (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=The_File_Browser) you can get a to get a list of albums based off the path and filename of files and folders. You can then use the Automatic Image Downloading (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Automatic_Image_Downloading) feature to search for each album in turn, and save the first result found.

Would that do the job for you?

Alex


You are already do that. I could'nt found that. My mistake sorry. This is awesome. Thank you Alex.
Title: Album Art Downloader XUI
Post by: AnthonyM1229 on 2012-02-02 05:53:12
I've been a happy user of Album Art Downloader XUI for a while now, especially after I discovered the option for automatic image downloading. It has really helped me in the past few months, when I was adding or fixing album art to all of my music collection, and to music added thereafter. Amazon and iTunes would typically find most of the album art I'd need. I'm disappointed about iTunes' apparent recent restriction to small art sizes now, but Amazon has still been working enough for me, and then whatever comes up as not found or as incorrect (even after a manual search), I run another automatic search including Google. I hate Google, because I have a high frequency of getting wrong images from it, but it still helps me get a few more images I was looking for. Now, after I've exhausted Amazon, iTunes, and Google using the program, if I still have missing or incorrect results, I then manually locate images myself on the Web. Here's my frustrating part: Most of the album art I search for at this point, is available on Amazon.com, just by typing in [artist name] [album name] (same names as tagged in my music), but for whatever reason, the Amazon AAD script does not find them. I'd say I have to manually search for 10-20% of my album art, and most of that turns up on Amazon. It seems like more often than not, the script fails to find results for titles or artists including non-alphanumeric characters, like quote marks and ampersands. Also, I question whether the script completely if at all searches Amazon MP3--most of those missing results that I find manually, are Amazon MP3 albums.

I'm not sure if anything can be done...I'd love for AAD to be able to find all my album art, haha, without me having to resort to manual searches for those last 15% or whatever. The vast majority of music I acquire is now from a subscription service that serves content from MediaNet. Perhaps if there were a script for http://www.mndigital.com/content-experience/ (http://www.mndigital.com/content-experience/), I could then find at least 95% of my album art every time. Would that be possible? A couple times recently, I've navigated to webpages for the albums of art I'm looking for, and have saved high-quality art from there.

Thanks for this wonderful program that's helped me save so much time on managing my music  Now, if I could just save a little more time by being able to find more of the album art I'm looking for, that'd be great
Title: Album Art Downloader XUI
Post by: pianoinbush on 2012-02-03 13:36:02
hi... it has probably been discussed before, but is there ANY way to configure the Google search? i.e. so that it could return only big results or, at least, over 20?
thanks for the reply in advance
Title: Album Art Downloader XUI
Post by: AnthonyM1229 on 2012-02-05 05:51:29
@pianoinbush

As far as I know, increasing the number of results is possible. In your Sources sidebar, look for GoogleImage, and then look for a "..." link. This should bring up a little options menu, where you can configure the number of results.

@(myself above)

I did some playing around with the Amazon and Google script files, and even attempted to create a script for MediaNet. I don't believe MediaNet will be possible, because I realized that the site uses JavaScript to load its album images--unless I'm mistaken, there's no way of parsing pages via scripting with the required JavaScript.

As for Amazon, I really wanted to configure my copy to search the MP3 downloads. I figured out that I could change the search-alias to "digital-music", and that'll serve up pages from Amazon MP3. However, these pages have different structure than what the existing regex handles. I tried to modify it, but could not figure out how to get it correctly.

Finally, I was able to make an improvement to the Google script. I changed the existing imagesHTML to " GetPageIsoLatin1("http://images.google.com/images?gbv=1&q=%22"+artist+"%22 %22"+album+"%22") ". The %22 encodes quote marks around each search term, which results in far more accurate results. Testing it out in my latest batch of art I was searching for, I don't recall getting any junk results from Google when using the automatic download feature. That is a big help. I still would like to see an improvement to Amazon, however, but for now, this should suffice.
Title: Album Art Downloader XUI
Post by: pianoinbush on 2012-02-05 06:12:23
@pianoinbush

As far as I know, increasing the number of results is possible. In your Sources sidebar, look for GoogleImage, and then look for a "..." link. This should bring up a little options menu, where you can configure the number of results.


heh, I know that. it doesn't work, whatever 20+ number you put there, it still brings 20...
Title: Album Art Downloader XUI
Post by: JackD on 2012-02-05 19:22:31
I have windows 7 installed on my PC

Qestion one

I do not know if it is possible.

Is it possible to download multiple art in one search automatic in Album Art Downloader (Front, Back, Cd, Inlay, Booklet)

(It would be nice not to make the same search again, just for a different art)


Question two

When i open a music folder, how do I the get the cover shown, on the different files in windows 7?


There will come some questions for Foopar and cover, but not to get things mixed up. I take one qestion at a time.


Hope you can help

Cheers
Title: Album Art Downloader XUI
Post by: pianoinbush on 2012-02-10 17:52:25
also, not sure what's the problem is, but I'm not getting any results from Amazon UK today for some reason. French come in ok, but not UK... weird
Title: Album Art Downloader XUI
Post by: Sixth Street on 2012-02-11 20:02:46
Is emusic working for anyone?  I get results if the art is there, but the image is a just a generic stub image of a dark grey cd shape on a black background.
Title: Album Art Downloader XUI
Post by: DRata on 2012-02-12 13:33:00
Is emusic working for anyone?  I get results if the art is there, but the image is a just a generic stub image of a dark grey cd shape on a black background.


I was wondering about that too. For the past month or so I've been getting no eMusic results for a lot of my AAD searches. When I searched for the album directly on the eMusic site, however, more often than not the album was there.

I went ahead and debugged the eMusic.boo script. It seems that eMusic is transitioning to a slightly different URL naming scheme for its album pages. Example:

Old URL: http://www.emusic.com/album/Collective-Sou...d/10976238.html (http://www.emusic.com/album/Collective-Soul-Youth-MP3-Download/10976238.html)
New URL: http://www.emusic.com/album/collective-soul/youth/10976238/ (http://www.emusic.com/album/collective-soul/youth/10976238/)

Sometimes in Google search results the old URL scheme turns up on other eMusic servers such as origin-www.emusic.com, but not always, so my guess is that the old URLs are being phased out.

Old URL scheme on different eMusic server found in a Google search: http://origin-www.emusic.com/album/Collect...d/10976238.html (http://origin-www.emusic.com/album/Collective-Soul-Youth-MP3-Download/10976238.html)

Alex, I've made a fix for the eMusic script that searches for and handles both types of URLs in case one type doesn't appear in the search. I don't seem to have the ability to upload attachments to this thread, so I'll try to get it to you via PM or email.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-02-12 16:30:10
Sorry I haven't been around recently, let me try and answer some posts here:

It seems like more often than not, the script fails to find results for titles or artists including non-alphanumeric characters, like quote marks and ampersands.
If you have some specific examples that return good results on Amazon Advanced Music (http://www.amazon.com/gp/browse.html?node=241585011) but fail on AAD then I can take a look and see if anything can be done to improve it.

if there were a script for http://www.mndigital.com/content-experience/ (http://www.mndigital.com/content-experience/), I could then find at least 95% of my album art every time. Would that be possible?
Yes, that looks like a good site for 800x800 covers. Please give this script a try and let me know how you get on: medianet.boo (http://album-art.sourceforge.net/scripts/medianet.boo)

is there ANY way to configure the Google search? i.e. so that it could return only big results or, at least, over 20?
You might be able to edit the search URL in the script to change the parameters to the search, but I don't think you can get more than 20 results as that is one page worth. I'm not going to have the script download multiple pages of results for a single search.

Is it possible to download multiple art in one search automatic in Album Art Downloader (Front, Back, Cd, Inlay, Booklet)
Sorry, not at the moment. The automatic downloader currently only saves a single image per album.

When i open a music folder, how do I the get the cover shown, on the different files in windows 7?
Do you mean embedding the artwork within each individual mp3 file? If so, then you need some media management/tagging software that can handle embedded artwork tags. MP3 Tag (http://www.mp3tag.de/en/index.html) is quite popular for this sort of thing - someone wrote a tutorial for using it for this purpose here (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&st=1525&p=740568&#entry740568).

also, not sure what's the problem is, but I'm not getting any results from Amazon UK today
I've updated the Amazon script, hopefully that should sort out the recent issues: amazon-common.boo (http://album-art.sourceforge.net/scripts/amazon-common.boo)

Alex, I've made a fix for the eMusic script that searches for and handles both types of URLs in case one type doesn't appear in the search. I don't seem to have the ability to upload attachments to this thread, so I'll try to get it to you via PM or email.
Thanks, I appreciate it! I've uploaded your changes to both eMusic (http://album-art.sourceforge.net/scripts/emusic.boo) and buy.com (http://album-art.sourceforge.net/scripts/buy-com.boo).

Alex
Title: Album Art Downloader XUI
Post by: AnthonyM1229 on 2012-02-14 03:26:44
Thanks for the MediaNet script, Alex! I haven't tried it yet, but I hope to this week. I'll let you know when I do. I had actually figured out a basic script somehow (through a lot of trial and error, haha). At first, I thought it was gonna be possible at all, because of the site's JavaScript, but then I inspected the source more closely and found embedded in the JS, the URL for serving up the images. With that figured out, I then put together a script, using the Amazon script structure as a guide. I was so happy when I finally got something working, haha. Your script looks a lot better/more efficient than mine, though... but still, I think I did pretty well for being a novice at this type of script writing!

Well, since I now have MediaNet as a working source, Amazon has become more a secondary source to me, and so, I'm not concerned about trying to improve it anymore. I had never seen that Advanced Search page before...it should definitely be helpful--thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-02-14 08:04:33
Ah, sorry to stomp on your first script-writing attempt! If I'd known you were working on it, I would have waited, but from your other post I figured you weren't. If you do continue with any script development, the tool I find most helpful is Fiddler2 (http://fiddler2.com/), which shows exactly what urls are accessed when loading the page in the browser, and what data comes back from them.

Alex
Title: Album Art Downloader XUI
Post by: AnthonyM1229 on 2012-02-15 23:23:50
Fiddler is definitely an interesting tool--thanks for mentioning it, Alex! With it, I was able to modify the request headers of the album art that gets downloaded with the music I get from a MediaNet source (iMesh), so that I get the full-size 800x800 art instead of the standard 150x150. My goal was to reduce my need for AAD, haha. It was so tempting, since I know iMesh stores a folder of labeled album art for each downloaded album. But, I wasn't able to accomplish my goal...sure, I can download the full-size album art now with the music, but, those images merely go to my IE cache, retaining their useless "g.jpeg" filename, and with no way of easily associating them with the music, I guess my plan just doesn't work. I guess iMesh populates its artwork folder by copying the embedded art from my music's metadata (again, only 150x150 tops), not by directly downloading them...oh well.

Still, Fiddler is fun to play with, and I may find other uses for it eventually. How do you come up with the regex in your scripts, however? Do you have a tool for that too, or are you a regex guru, haha? Before I had MediaNet as a working source, I was trying to modify the Amazon script to pull images from the MP3 download store (since apparently, Amazon's and MediaNet's catalog are at least 90% similar), but the Amazon MP3 pages have a different structure than what the existing regex looks for, and that regex was quite complicated for me to try to modify. (I'm glad MediaNet proved to only require minimal regex...you actually defined a more detailed expression than I, but yours is likely more bullet-proof than mine.)

Well, speaking of the MediaNet script, yours is working very well--thanks again! I think my version downloads the full images outright (which is fine for my purposes), whereas yours gets a thumbnail first. I couldn't easily figure out how to do that, but figured I'd be fine without it
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-02-16 08:13:59
Do you have a tool for that too, or are you a regex guru, haha?
A bit of both? I use RegexBuddy (http://www.regexbuddy.com/), which is kind of like an IDE for regexes, and helps a lot with testing. It's not going to take input html and automagically make a working regular expression though, even less so one that's resilient to minor formatting changes. The same guy has another tool called RegexMagic (http://www.regexmagic.com/) that *is* supposed to magically produce Regexes for you, but I haven't tried it myself, so I can't comment on how well it manages to do so.

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2012-02-17 18:11:00
A (great and) free alternative would be Expresso (http://www.ultrapico.com/Expresso.htm).
Title: Album Art Downloader XUI
Post by: AnthonyM1229 on 2012-02-24 16:05:38
Thanks for the responses, Alex and tuxman. Somehow, I never knew about RegexBuddy or RegexMagic, even though I've been a fan of EditPad Lite from the same developer, for years now (and it's what I used to try to manipulate regex.) I'll definitely look into Expresso first sometime, though. Thanks again, guys!
Title: Album Art Downloader XUI
Post by: tuxman on 2012-02-24 16:18:41
Glad I could help.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-02-25 09:52:17
I've had deejay.de (http://www.deejay.de/) suggested to me as a good source for covers. This is mostly good for Vinyl covers, and has high res front and back images over a wide selection. It also has some CDs, but those aren't generally as good.

If anyone would like to try the script: deejay.boo (http://album-art.sourceforge.net/scripts/deejay.boo) please let me know how you get on with it.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2012-02-25 17:38:43
weird story: Deezer stopped working at some point, then came back and now it doesn't work again..
too bad, it's a great source
any chance of reviving it?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-02-26 09:16:58
Deezer stopped working

They've changed their API again, thanks for letting me know. I've updated the script: deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo), should be working again. Unfortunately they are no longer providing the link to the album page in the search results (it would require an additional http request per result just to determine what the link was!) so until that information is available again, the little (i) button to show the album page won't be available.

Images work just fine, though.

Alex
Title: Album Art Downloader XUI
Post by: mv54 on 2012-02-26 14:25:18
Hello i decided to join the forums today, I'm seeking help on trying to solve a problem I have encounter while using the Album Art Downloader XUI-0.43.

Every time I open the program it crashes and i get an error code. I was wondering if anyone could help me solve it. I also want to mention that i do not have any problems with older versions of the software except for the latest one. Thank you for the help and have a nice day.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files (x86)\AlbumArtDownloader\errorlog.txt

App version: 0.43.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.IO.DirectoryNotFoundException: The system cannot find the path specified. (Exception from HRESULT: 0x80070003)
  at Microsoft.WindowsAPICodePack.Taskbar.ICustomDestinationList.CommitList()
  at Microsoft.WindowsAPICodePack.Taskbar.JumpList.Refresh()
  at AlbumArtDownloader.TaskbarHelper.CreateApplicationJumpList()
  at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Application.RunInternal(Window window)
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-02-26 15:43:26
Every time I open the program it crashes and i get an error code.
That's a weird one. It's claiming not to be able to locate the Album Art Downloader executable when trying to add the jumplist shortcuts to the taskbar button. I don't really know what would cause that, but could you try moving the program folder out of c:\program files (x86) to somewhere else, just to see if that makes a difference? For example, create c:\test\AlbumArtDownloader or similar.

Alex
Title: Album Art Downloader XUI
Post by: mv54 on 2012-02-26 18:35:48
I did what you told me it didn't work.

[same error message as post #2091]
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-02-26 18:48:04
I did what you told me it didn't work.
OK, well thanks for trying it anyway. I'm afraid I haven't a clue why it can't add the jump list entries on your system, then. All I can do for the next version is have it ignore the problem and simply continue without jump list entries. Until then, please continue to use version 0.42.1 (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.42.1.zip/download) which does not contain the jumplist functionality. The only other feature you are missing by using 0.42.1 instead of 0.43 is progress indication in the taskbar; all the latest scripts will work just as well.

Alex
Title: Album Art Downloader XUI
Post by: ruebe on 2012-03-01 14:37:49
short question...
i searched the wiki as well as the command line help thingie but i didn't find an option to display "Options..." by default instead of hiding it
any way to do this?

btw: when searching "Local Files" AAD seems to perform a case-sensitive search...is this the desired behavior? if so, can this be tuned off?
my bad...it does not...files were not found because of resolution restrictions
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-03-01 18:18:20
i didn't find an option to display "Options..." by default instead of hiding it
any way to do this?

Sorry, no, I'm afraid that's not currently possible.

Alex
Title: Album Art Downloader XUI
Post by: ruebe on 2012-03-03 09:09:16
well, what a pity...

anyway, thanks for you great piece of software!
Title: Album Art Downloader XUI
Post by: pianoinbush on 2012-03-07 17:47:29
a piece of worrying news: DJshop started returning 80x80 images as of today. either it's a temporary glitch or they're doing the same thing iTunes annoyingly did.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-03-09 08:10:46
DJshop started returning 80x80 images as of today.

Thanks for letting me know. I've updated djshop.boo (http://album-art.sourceforge.net/scripts/djshop.boo); it now only gets back 1000x1000 sized covers, but that's better than just the 80x80 thumbnails!

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2012-03-13 12:27:00
DJshop started returning 80x80 images as of today.

Thanks for letting me know. I've updated djshop.boo (http://album-art.sourceforge.net/scripts/djshop.boo); it now only gets back 1000x1000 sized covers, but that's better than just the 80x80 thumbnails!

Alex

thanks for quick repairs, Alex!

in the meantime, interesting development: 70x70 iTunes covers apparently reverted back to 600x600... here's hoping they'll be back to 1425x1425 at some point as well
Title: Album Art Downloader XUI
Post by: Dr Johnson on 2012-04-03 12:46:56
Hi Alex, the lastFM Artist script hasn't been working for a while now. Any chance of an update?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-04-04 20:14:04
Hi Alex, the lastFM Artist script hasn't been working for a while now. Any chance of an update?

Thanks for pointing it out, I've uploaded an updated lastfm-artist.boo (http://album-art.sourceforge.net/scripts/lastfm-artist.boo) that should fix this up.

Alex
Title: Album Art Downloader XUI
Post by: Dr Johnson on 2012-04-05 18:47:39
Thanks, good as new! 
Title: Album Art Downloader XUI
Post by: dubwai on 2012-04-09 21:31:53
It's possible to change default replace symbol from "_" to "" or "-"?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-04-12 08:02:38
It's possible to change default replace symbol from "_" to "" or "-"?
Sorry, but no, this is not currently possible. There is a feature request (http://sourceforge.net/tracker/?func=detail&aid=2022984&group_id=187008&atid=919578) for it, so it might happen in a future version.

Alex
Title: Album Art Downloader XUI
Post by: dubwai on 2012-04-12 08:45:51
It's possible to change default replace symbol from "_" to "" or "-"?
Sorry, but no, this is not currently possible. There is a feature request (http://sourceforge.net/tracker/?func=detail&aid=2022984&group_id=187008&atid=919578) for it, so it might happen in a future version.

Alex

Ok, hope for another 4 year  Anyway I found how to replace to _ in Mp3tag. But what about fb2k. I use "C:\Users\dubwai\Pictures\Album Art\$replace(%album artist%\%album%,/,:,?,*,<,>,|,_,_,_,_,_,_,_)\Front.jpg" but it didn't work. I play with simple $replace but it also didn't work
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-04-14 10:57:54
I use "C:\Users\dubwai\Pictures\Album Art\$replace(%album artist%\%album%,/,:,?,*,<,>,|,_,_,_,_,_,_,_)\Front.jpg" but it didn't work. I play with simple $replace but it also didn't work
I think you've got the syntax of replace slightly wrong there, each substitution goes next to the character it is substituting, so try: $replace(%album artist%\%album%,/,_,:,_,?,_,*,_,<,_,>,_,|,_) instead. Might want to add \ in there too, if you could have those in the name.

Alex
Title: Album Art Downloader XUI
Post by: dubwai on 2012-04-19 19:30:18
I use "C:\Users\dubwai\Pictures\Album Art\$replace(%album artist%\%album%,/,:,?,*,<,>,|,_,_,_,_,_,_,_)\Front.jpg" but it didn't work. I play with simple $replace but it also didn't work
I think you've got the syntax of replace slightly wrong there, each substitution goes next to the character it is substituting, so try: $replace(%album artist%\%album%,/,_,:,_,?,_,*,_,<,_,>,_,|,_) instead. Might want to add \ in there too, if you could have those in the name.

Alex

Yes man, you are wright with formating, I try a lot variants, but problem is that fb2k automatic replace invalid characters to "-" in this (http://img15.imageshack.us/img15/2254/20120419222534.jpg)
and replace function don't work, because it's alread replaced to "-". I ask at irc, and i got answer that it's hardcoded and unchangeable. So may be add option to choose what to use "_" or "-". Because it's boring to manual rename every time. Thanx.
Title: Album Art Downloader XUI
Post by: dubwai on 2012-04-20 00:05:34
In ticket said that winamp also replace this symbols to "-". Seems that it "standart" for soft mp3 players
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-04-20 08:05:05
It's a bad idea to use a replacement character that often appears as a normal character too, but if foobar's album art viewer component requires it then that puts a different spin on the matter. I'll see what I can do this weekend.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-04-22 09:26:43
Version 0.44
This version adds support for setting the replacement character for invalid filename characters. I've made the default '-', for compatibility with the foobar2000 album art viewer component. If you want to go back to using '_' (or any other single character), then there's a box for it under Options in the main search window.

I've also added limited support for reading embedded images to the foobar browser. This was already available for the file browser, but I had not done so in the foobar browser. The reason was that the file browser has to read each file from disk anyway, but the foobar browser does not. Having to read every file from disk would mean losing the performance advantage of using the foobar browser. What I've done for this release is to have it read only the first file for each album in the foobar browser to find embedded art. In my testing, this appears to have minimal performance impact, but if anyone is finding the foobar browser to be significantly slower than before, please let me know and I can either revert the change, or make it optional.

Scripts have been brought up to date, and two have been removed. Darktown and MioMusic are no longer available - I'd recommend you delete those scripts if you have them installed.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.44.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.44.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: dubwai on 2012-04-22 12:55:42
Great AlexVallat, thank you very much.
Title: Album Art Downloader XUI
Post by: MillmoorRon on 2012-04-26 19:44:43
My Google Image script doesn't appear to be working now.

I get the searching animation but no results are returned.

Has something changed which has broken the script?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-04-27 08:22:42
Google Image script doesn't appear to be working

Thanks for pointing this out. I've updated the script: google.boo (http://album-art.sourceforge.net/scripts/google.boo), it should work fine now.

Alex
Title: Album Art Downloader XUI
Post by: MillmoorRon on 2012-04-27 08:32:56
That sorted it. Thanks!
Title: Album Art Downloader XUI
Post by: SoberWarlock on 2012-04-27 12:20:39
Everything I have been looking for is now all here since 2007! What have I been missing. I depeneding heavily on Google Images now I can completely rely on this and it's browsing goes by a long shot of different sources. Amazing program. Simple. 10/10.
Title: Album Art Downloader XUI
Post by: mundschuss on 2012-04-29 12:25:54
what do i have to do to get it work under windows 7 64 with comodo firewall and avast? turned both off, but still no results on any folder.
and the program does also crash when the folder is bigger then some GB (around 10GB)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-04-29 15:46:33
what do i have to do to get it work under windows 7 64 with comodo firewall and avast? turned both off, but still no results on any folder.
and the program does also crash when the folder is bigger then some GB (around 10GB)

Windows 7 x64 shouldn't be a problem at all, that's what I run. If Comodo or Avast are set to block unknown programs from accessing the internet, then that might stop it from finding any results when you do an album art search (but shouldn't result in a crash). If you add an exception for the AlbumArt.exe process to allow it to access the internet, that should be enough.

I haven't seen the 10GB folder crash, did it generate a crash log text file? If not, can you describe the crash message that did appear, or did the program just exit immediately without any message?

Alex
Title: Album Art Downloader XUI
Post by: meister on 2012-05-07 21:14:46
Yesterday, cover-paradies started returning no results. I have tried it with existing albums that have previously succeeded, plus I checked through the browser interface that these albums existed. I noticed they have changed the url from cover-paradies to ecover.to, so I tried changing the boo script to use that, still no results. The cover-paradies url still works in the browser, you just get redirected.
Title: Album Art Downloader XUI
Post by: meister on 2012-05-08 07:05:02
OK, found out the issue. I'd changed the url information in the script, but hadn't changed the code that gets the title for the album. Looking into the webpage source, they have changed the <title> tag. So after the <title> tag repalce Cover-Paradies to eCover.to and now I'm getting results.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-05-09 08:37:51

Thanks for that, I've updated the script to point to eCover.to as you suggested: cover-paradies.boo (http://album-art.sourceforge.net/scripts/cover-paradies.boo)

I kept the name of the script the same, though so that it would replace existing versions.

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-05-11 22:19:00
I like large album art, but often if it can't be found in the usual spots, so I'm stuck with google... whose results here aren't sorted by any size. So I rolled my own script, "Google Large Images" based off the regular google.boo, which will return images bigger than 800x600 (google doesn't let you be exact on width/height requirements). That means it'll return 700x700 and up which suits my purposes pretty well (because there's usually a fair amount of 600x600 artwork on google).

You can get it here (http://www.mediafire.com/?1wrk03gbyqw6kqm) if anyone is interested. I appreciate any feedback.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-05-11 23:41:09
You can get it here (http://www.mediafire.com/?1wrk03gbyqw6kqm) if anyone is interested. I appreciate any feedback.

You can't get it there anymore, but I can't edit that post sadly. Here's the new link (http://www.mediafire.com/?rithrm626jb6sh8). I'm now appending the file size to the start of the title for easier comparison of large images, plus I've disabled safe search because I'd found an image that was on some banned site even though it contained no objectionable content. Use at your own risk if you're easily offended.
Title: Album Art Downloader XUI
Post by: MC Escher on 2012-05-14 13:59:32
I've recently had a couple of crashes when I launched AAD from foobar2000. Here's a crash log:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: D:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.44.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Windows.Markup.XamlParseException:  Kan bestand of assembly PresentationFramework.Classic, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 of een van de afhankelijkheden hiervan niet laden. De parameter is onjuist. (Uitzondering van HRESULT: 0x80070057 (E_INVALIDARG))  Fout bij object System.Windows.Controls.ControlTemplate in opmaakbestand Controls/Xaml/ArtPanel.generic.xaml. ---> System.IO.FileLoadException: Kan bestand of assembly PresentationFramework.Classic, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 of een van de afhankelijkheden hiervan niet laden. De parameter is onjuist. (Uitzondering van HRESULT: 0x80070057 (E_INVALIDARG))
Bestandsnaam: PresentationFramework.Classic, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35
  bij System.Reflection.Assembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, Assembly locationHint, StackCrawlMark& stackMark, Boolean throwOnFileNotFound, Boolean forIntrospection)
  bij System.Reflection.Assembly.InternalLoad(AssemblyName assemblyRef, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection)
  bij System.Reflection.Assembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection)
  bij System.Reflection.Assembly.Load(String assemblyString)
  bij System.Windows.Markup.ReflectionHelper.LoadAssemblyHelper(String assemblyGivenName, String assemblyPath)
  bij System.Windows.Markup.BamlMapTable.GetAssemblyFromAssemblyInfo(BamlAssemblyInfoRecord assemblyInfoRecord)
  bij System.Windows.Markup.BamlMapTable.GetTypeFromTypeInfo(BamlTypeInfoRecord typeInfo)
  bij System.Windows.Markup.BamlMapTable.GetTypeFromId(Int16 id)
  bij System.Windows.Markup.OptimizedTemplateContent.CheckElementStartForOptimization(BamlRecord bamlRecord)
  bij System.Windows.Markup.OptimizedTemplateContent.ReadRecord(BamlRecord bamlRecord)
  bij System.Windows.Markup.TemplateBamlRecordReader.AddContentRecord(BamlRecord bamlRecord)
  bij System.Windows.Markup.TemplateBamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementStartRecord)
  bij System.Windows.Markup.TemplateBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  bij System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  bij System.Windows.Markup.TemplateTreeBuilderBamlTranslator.ParseFragment()
  bij System.Windows.Markup.TreeBuilder.Parse()
  bij System.Windows.Markup.XamlTemplateSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
  bij System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  bij System.Windows.Markup.StyleBamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)


  --- Einde van intern uitzonderingsstackpad ---
  bij System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  bij System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  bij System.Windows.Markup.StyleBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  bij System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  bij System.Windows.Markup.StyleTreeBuilderBamlTranslator.ParseFragment()
  bij System.Windows.Markup.TreeBuilder.Parse()
  bij System.Windows.Markup.XamlStyleSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
  bij System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  bij System.Windows.Markup.BamlRecordReader.ReadElement(Int64 startPosition, XamlObjectIds contextXamlObjectIds, Object dictionaryKey)
  bij System.Windows.ResourceDictionary.CreateObject(Int32 valuePosition, Object key)
  bij System.Windows.ResourceDictionary.RealizeDeferContent(Object key, Object& value, Boolean& canCache)
  bij System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
  bij System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
  bij System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
  bij System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
  bij System.Windows.SystemResources.LookupResourceInDictionary(ResourceDictionary dictionary, Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
  bij System.Windows.SystemResources.FindDictionaryResource(Object key, Type typeKey, ResourceKey resourceKey, Boolean isTraceEnabled, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
  bij System.Windows.SystemResources.FindResourceInternal(Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference)
  bij System.Windows.StyleHelper.GetThemeStyle(FrameworkElement fe, FrameworkContentElement fce)
  bij System.Windows.FrameworkElement.UpdateThemeStyleProperty()
  bij System.Windows.FrameworkElement.OnInitialized(EventArgs e)
  bij System.Windows.Markup.BamlRecordReader.ElementEndInit(Object& element)
  bij System.Windows.Markup.BamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
  bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  bij System.Windows.StyleHelper.LoadOptimizedTemplateContent(DependencyObject container, ParserContext parserContext, OptimizedTemplateContent optimizedTemplateContent, FrameworkTemplate frameworkTemplate, IComponentConnector componentConnector, IStyleConnector styleConnector, List`1 affectedChildren, UncommonField`1 templatedNonFeChildrenField)
  bij System.Windows.FrameworkTemplate.LoadContent(DependencyObject container, List`1 affectedChildren, UncommonField`1 templatedNonFeChildrenField)
  bij System.Windows.StyleHelper.ApplyTemplateContent(UncommonField`1 dataField, DependencyObject container, FrameworkElementFactory templateRoot, Int32 lastChildIndex, HybridDictionary childIndexFromChildID, FrameworkTemplate frameworkTemplate)
  bij System.Windows.FrameworkTemplate.ApplyTemplateContent(UncommonField`1 templateDataField, FrameworkElement container)
  bij System.Windows.FrameworkElement.ApplyTemplate()
  bij System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  bij System.Windows.UIElement.Measure(Size availableSize)
  bij System.Windows.Controls.WrapPanel.MeasureOverride(Size constraint)
  bij System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  bij System.Windows.UIElement.Measure(Size availableSize)
  bij System.Windows.ContextLayoutManager.UpdateLayout()
  bij System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
  bij System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
  bij System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
  bij System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
  bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bij System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bij System.Threading.ExecutionContext.runTryCode(Object userData)
  bij System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bij System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bij System.Windows.Threading.DispatcherOperation.Invoke()
  bij System.Windows.Threading.Dispatcher.ProcessQueue()
  bij System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bij MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bij MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bij System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bij MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bij MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bij System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  bij System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bij System.Windows.Application.RunInternal(Window window)
  bij AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bij AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bij AlbumArtDownloader.App.Main(String[] args)
I'm on Windows 7. For some reason it doesn't always crash, and I also don't always get a log.
Title: Album Art Downloader XUI
Post by: godrick on 2012-05-25 15:35:17
Alex, a belated thanks for adding the detection of embedded images and exposing playlists in the Foobar browser - the performance is great!  Looking for an image in just one file per album was a very good choice, since this focuses AAD on what it does best, and other applications are best suited to sort out tag inconsistencies across tracks in albums.  Thanks again!
Title: Album Art Downloader XUI
Post by: dudleyheinsbergen on 2012-06-04 20:31:08
I have a problem with this software. Every time I open it it just displays a blank screen, sometimes black 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-05 07:50:21
Every time I open it it just displays a blank screen, sometimes black

Hmm. Could be a graphics driver issue, I suppose - try updating to the latest version of the drivers for your graphics card. Other than that, there's not much I can suggest, it's outside the control of the AAD itself. Sorry,

Alex
Title: Album Art Downloader XUI
Post by: dudleyheinsbergen on 2012-06-05 19:56:36
It's working now for some reason!
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-12 19:53:30
Alex, is there any way to retrieve the n from "Limit to n Results" setting? I'm working on a script for a site that needs to log out whenever the script is finished running... however I realized that if my n is set to 10 and I get more than 10 results, when I attempt to call results.Add for #11 the script just terminates instantly and I have no ability to logout. All my future searches on that site fail until I close all AAD windows and restart. If I could keep a count and skip calling results.Add when count > n I wouldn't have this problem.

Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-12 20:22:16
Alex, is there any way to retrieve the n from "Limit to n Results" setting?
Sorry, I'm afraid there isn't. There probably should be, though, it would be useful for some sources where you can specify how many results you want when requesting them from the server.

For your situation, however, what I would recommend would be the try/finally pattern (try/ensure in boo), to ensure you log out not only if the limit number of results is reached, but also if the user hits Stop. Wrap your results loop something like:

Code: [Select]
try:
  for resultMatch in resultMatches:
    results.Add(...)  
ensure:
  DoLogout();

I hope this helps,

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-12 21:56:56
That helps a lot, thanks. I'm now logging out correctly no matter what.

Unfortunately there's still some weirdness that happens here. Whenever my search results are greater than the n limit, any future searches on that site fail (progress bar never ends). Apparently logging out didn't fix that problem like I thought it would. For reference this script logs in to a site, retrieves the cookies, and passes those along with the searches. Any ideas/suggestions as to maybe what's going wrong so I don't have to always close AAD and relaunch?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-13 07:54:33
Whenever my search results are greater than the n limit, any future searches on that site fail (progress bar never ends).
Well that's odd... I assume the same thing happens when the Stop command is used before it finishes?

The script class is only instantiated once (until AAD is restarted), so you could keep the login cookies in a member variable rather than needing to log in with each search; that might help.

Is it a public server? If you PM me the script I can give it a try and see if I notice any reason for that behaviour. Otherwise, the only thing I can suggest is to use Fiddler2 to monitor the http response of the server for search requests, and see if that gives any clues.

Alex
Title: Album Art Downloader XUI
Post by: MC Escher on 2012-06-13 11:05:00
Bump with a fresh crashlog:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
  If you wish to report this error, please include this information, which
  has been written to the file: D:\Program Files\AlbumArtDownloader\errorlog.txt
 
  App version: 0.44.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)
 
  System.Windows.Markup.XamlParseException:  Kan bestand of assembly PresentationFramework.Classic, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 of een van de afhankelijkheden hiervan niet laden. De parameter is onjuist. (Uitzondering van HRESULT: 0x80070057 (E_INVALIDARG))  Fout bij object System.Windows.Controls.ControlTemplate in opmaakbestand Controls/Xaml/ArtPanel.generic.xaml. ---> System.IO.FileLoadException: Kan bestand of assembly PresentationFramework.Classic, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 of een van de afhankelijkheden hiervan niet laden. De parameter is onjuist. (Uitzondering van HRESULT: 0x80070057 (E_INVALIDARG))
  Bestandsnaam: PresentationFramework.Classic, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35
    bij System.Reflection.Assembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, Assembly locationHint, StackCrawlMark& stackMark, Boolean throwOnFileNotFound, Boolean forIntrospection)
    bij System.Reflection.Assembly.InternalLoad(AssemblyName assemblyRef, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection)
    bij System.Reflection.Assembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection)
    bij System.Reflection.Assembly.Load(String assemblyString)
    bij System.Windows.Markup.ReflectionHelper.LoadAssemblyHelper(String assemblyGivenName, String assemblyPath)
    bij System.Windows.Markup.BamlMapTable.GetAssemblyFromAssemblyInfo(BamlAssemblyInfoRecord assemblyInfoRecord)
    bij System.Windows.Markup.BamlMapTable.GetTypeFromTypeInfo(BamlTypeInfoRecord typeInfo)
    bij System.Windows.Markup.BamlMapTable.GetTypeFromId(Int16 id)
    bij System.Windows.Markup.OptimizedTemplateContent.CheckElementStartForOptimization(BamlRecord bamlRecord)
    bij System.Windows.Markup.OptimizedTemplateContent.ReadRecord(BamlRecord bamlRecord)
    bij System.Windows.Markup.TemplateBamlRecordReader.AddContentRecord(BamlRecord bamlRecord)
    bij System.Windows.Markup.TemplateBamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementStartRecord)
    bij System.Windows.Markup.TemplateBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
    bij System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
    bij System.Windows.Markup.TemplateTreeBuilderBamlTranslator.ParseFragment()
    bij System.Windows.Markup.TreeBuilder.Parse()
    bij System.Windows.Markup.XamlTemplateSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
    bij System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
    bij System.Windows.Markup.StyleBamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
    bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
 
 
    --- Einde van intern uitzonderingsstackpad ---
    bij System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
    bij System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
    bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
    bij System.Windows.Markup.StyleBamlRecordReader.ReadRecord(BamlRecord bamlRecord)
    bij System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
    bij System.Windows.Markup.StyleTreeBuilderBamlTranslator.ParseFragment()
    bij System.Windows.Markup.TreeBuilder.Parse()
    bij System.Windows.Markup.XamlStyleSerializer.ConvertBamlToObject(BamlRecordReader reader, BamlRecord bamlRecord, ParserContext context)
    bij System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
    bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
    bij System.Windows.Markup.BamlRecordReader.ReadElement(Int64 startPosition, XamlObjectIds contextXamlObjectIds, Object dictionaryKey)
    bij System.Windows.ResourceDictionary.CreateObject(Int32 valuePosition, Object key)
    bij System.Windows.ResourceDictionary.RealizeDeferContent(Object key, Object& value, Boolean& canCache)
    bij System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
    bij System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
    bij System.Windows.ResourceDictionary.GetValueWithoutLock(Object key, Boolean& canCache)
    bij System.Windows.ResourceDictionary.GetValue(Object key, Boolean& canCache)
    bij System.Windows.SystemResources.LookupResourceInDictionary(ResourceDictionary dictionary, Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
    bij System.Windows.SystemResources.FindDictionaryResource(Object key, Type typeKey, ResourceKey resourceKey, Boolean isTraceEnabled, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference, Boolean& canCache)
    bij System.Windows.SystemResources.FindResourceInternal(Object key, Boolean allowDeferredResourceReference, Boolean mustReturnDeferredResourceReference)
    bij System.Windows.StyleHelper.GetThemeStyle(FrameworkElement fe, FrameworkContentElement fce)
    bij System.Windows.FrameworkElement.UpdateThemeStyleProperty()
    bij System.Windows.FrameworkElement.OnInitialized(EventArgs e)
    bij System.Windows.Markup.BamlRecordReader.ElementEndInit(Object& element)
    bij System.Windows.Markup.BamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
    bij System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
    bij System.Windows.StyleHelper.LoadOptimizedTemplateContent(DependencyObject container, ParserContext parserContext, OptimizedTemplateContent optimizedTemplateContent, FrameworkTemplate frameworkTemplate, IComponentConnector componentConnector, IStyleConnector styleConnector, List`1 affectedChildren, UncommonField`1 templatedNonFeChildrenField)
    bij System.Windows.FrameworkTemplate.LoadContent(DependencyObject container, List`1 affectedChildren, UncommonField`1 templatedNonFeChildrenField)
    bij System.Windows.StyleHelper.ApplyTemplateContent(UncommonField`1 dataField, DependencyObject container, FrameworkElementFactory templateRoot, Int32 lastChildIndex, HybridDictionary childIndexFromChildID, FrameworkTemplate frameworkTemplate)
    bij System.Windows.FrameworkTemplate.ApplyTemplateContent(UncommonField`1 templateDataField, FrameworkElement container)
    bij System.Windows.FrameworkElement.ApplyTemplate()
    bij System.Windows.FrameworkElement.MeasureCore(Size availableSize)
    bij System.Windows.UIElement.Measure(Size availableSize)
    bij System.Windows.Controls.WrapPanel.MeasureOverride(Size constraint)
    bij System.Windows.FrameworkElement.MeasureCore(Size availableSize)
    bij System.Windows.UIElement.Measure(Size availableSize)
    bij System.Windows.ContextLayoutManager.UpdateLayout()
    bij System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
    bij System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
    bij System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
    bij System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
    bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bij System.Windows.Threading.DispatcherOperation.InvokeImpl()
    bij System.Threading.ExecutionContext.runTryCode(Object userData)
    bij System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
    bij System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
    bij System.Windows.Threading.DispatcherOperation.Invoke()
    bij System.Windows.Threading.Dispatcher.ProcessQueue()
    bij System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bij MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
    bij MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
    bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
    bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
    bij System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
    bij MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
    bij MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
    bij System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
    bij System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
    bij System.Windows.Application.RunInternal(Window window)
    bij AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
    bij AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
    bij AlbumArtDownloader.App.Main(String[] args)
 
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-13 18:20:09
Well that's odd... I assume the same thing happens when the Stop command is used before it finishes?

The script class is only instantiated once (until AAD is restarted), so you could keep the login cookies in a member variable rather than needing to log in with each search; that might help.
Unfortunately, it's not a public server otherwise I'd share with you. I haven't tried stopping before the first search is finished, but I assume it's probably the same behavior.

When you say the script class is only instantiated once, I don't really know where should I put my login code. I assume I'm supposed to move it outside the Search function def, but I'm assuming I need to put it inside another function in the class, otherwise it'll never get called, right?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-13 19:11:19
Bump with a fresh crashlog
The error reported here is that it can not load the assembly PresentationFramework.Classic. This is an integral part of WPF in .net 3.5, so I don't know why it is unavailable on your system. Unfortunately, I don't really have any good suggestions as to what you can do to resolve this, other than the generic advice to uninstall and reinstall the .net framework.

When you say the script class is only instantiated once, I don't really know where should I put my login code.
Personally, I'd leave it in the login code, but add a check to see if the cookie variable has already been populated by a previous search or not. That way you log in the first time your search is called, and stay logged in until AAD exits. If your script search is never called, you don't need to log in at all.

Alex
Title: Album Art Downloader XUI
Post by: MC Escher on 2012-06-13 19:48:07
Hm, I'm on Windows 7 where .Net 3.5 is a system component, so there isn't any reinstalling to do I'm afraid. Luckily it doesn't crash every time.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-13 22:15:25
Personally, I'd leave it in the login code, but add a check to see if the cookie variable has already been populated by a previous search or not. That way you log in the first time your search is called, and stay logged in until AAD exits. If your script search is never called, you don't need to log in at all.


A little more investigation. I moved the declaration of my cookieContainer to be global to the class. I then check to see if cookie.Count == 0 and if so, then I attempt to login and retrieve the cookies, otherwise I just attempt the search request. This works perfectly... except for the fact that I can no longer logout at the end (because then the cookies are invalid and I get no response from my first Get call. Unfortunately I can't just not logout because a user complained about open sessions which are retained on the server that need to be closed. Soooo... is there a finalize method that gets called on the scripts when the program is shutting down and if so, what is it's definition? That's the only place the logout stuff really needs to go IMO.

Edit: I tried it out and there is a finalize method! I wonder if I'm the only one using it  Anyway, logging out in finalize works great. There's still some weirdness I think as I was able to get it to have the weird hang at least once since, but it's possible it was timeout on the server end or something else that wasn't handled right. It's working 90% of the time and that's good enough for me.

Thanks for all your help Alex. This program is really well done.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-14 16:28:42
I get a lot of my music from bandcamp which has somewhat recently started including really high-res artwork on their site. It comes up a lot for me in my LargeGoogleImage script I posted earlier, but I realized that I wanted a more targeted script for just bandcamp, so here it is:

https://www.dropbox.com/s/05br4is3834w5lx/bandcamp.boo (https://www.dropbox.com/s/05br4is3834w5lx/bandcamp.boo)

It's basically a modified google search restricted to site:bandcamp.com and using an exact artist match (i.e. quotes around the artist) to greatly restrict the results and only return images > 640x480. In playing around with it I've found that you can restrict the results to 4 or so and always get the cover you want. I wouldn't mind if it made it into the next AAD release either.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-14 18:11:59
Hm, I'm on Windows 7 where .Net 3.5 is a system component, so there isn't any reinstalling to do I'm afraid. Luckily it doesn't crash every time.

I think you can do this by going to Add/Remove, clicking Turn Windows Features On or Off, then checking or unchecking "Microsoft .NET Framework 3.5.1". Might not work anyway, but could be worth a shot. The fact that it doesn't crash every time is even more curious. If you can figure out anything different on your system (other software running? previously run?) between the times it does crash and the times it doesn't, that might also be a clue.


Thanks for the script. I'm afraid that from prior experience, I'm not going to include any scripts that are specialisations of google image search in AAD as I find that too often running multiple google image searches triggers their anti-robot protections. I'd recommend that if you use this one, you disable the plain google image search, or at least make one search-first. Or just take your chances, of course, but that's not good enough for including the script officially.

Bandcamp does look like a useful source though, so I'll probably do a custom script that searches it directly when I get a little time.

Alex

Title: Album Art Downloader XUI
Post by: MC Escher on 2012-06-14 18:43:31
The weird thing is that if I try it a couple of times in a row, sometimes it will fail, sometimes it will fail with a crash log (though rarely) and sometimes it will work as normal. All in the space of seconds. I don't think I'll ever see what's different on my computer when what happens. I'll try switching .net off and on.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-14 19:05:39
Thanks for the script. I'm afraid that from prior experience, I'm not going to include any scripts that are specialisations of google image search in AAD as I find that too often running multiple google image searches triggers their anti-robot protections. I'd recommend that if you use this one, you disable the plain google image search, or at least make one search-first. Or just take your chances, of course, but that's not good enough for including the script officially.

Bandcamp does look like a useful source though, so I'll probably do a custom script that searches it directly when I get a little time.

Alex
Interesting. I've never encountered their anti-robot stuff and I normally run my Google/LargeGoogle and I might still have the Google-Itunes script going as well on some computers here. I did setup the bandcamp to search first though.

I'm not a big fan of the results from the bandcamp search (which was why I used google), but I could probably whip something up as an alternative if you wanted me to.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-14 20:02:13
I'm not a big fan of the results from the bandcamp search (which was why I used google), but I could probably whip something up as an alternative if you wanted me to.
Sure, if you get a chance to put together a native bandcamp search, I'll include it with the rest of the bundled scripts.

I had a quick look at the site, and annoyingly it doesn't seem like the ID of the full size image has any relation to the thumbnail, or any other part of the results list, so it's going to be a case of loading the page for each album in the results to extract the full size image URL.

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-14 23:26:53
Sure, if you get a chance to put together a native bandcamp search, I'll include it with the rest of the bundled scripts.

I had a quick look at the site, and annoyingly it doesn't seem like the ID of the full size image has any relation to the thumbnail, or any other part of the results list, so it's going to be a case of loading the page for each album in the results to extract the full size image URL.

Yup. That's annoying and there's no way to get the dimensions of the cover without downloading the full size which always bugs me.
Title: Album Art Downloader XUI
Post by: r0k on 2012-06-17 21:15:45
Downloading Lyrics

Hi. I know the point of this application is cover art, but seeing how the lyrics downloaders i found here and through big "g" are either mp3 only, crashware or abandonware, do you think it would be possible to add a lyrics search feature?
I guess the modular, script driven nature of AAD would help implement this without complete recoding, isn't it?

This is definitely the best album art downloading application i tested. A lyrics downloader of equal quality would be great.

That being said, suggesting features is easier than coding them
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-18 08:15:18
Downloading Lyrics

Thanks for the suggestion - I'm not really sure how good a fit it is, a lot of AAD is designed around showing the artwork that it finds, and helping you choose the best one. I suppose you could do a script that would just give blank images and lyrics files instead of image files, it wouldn't be a great UI for it, but it would work.

Unfortunately I have no idea about the actual lyrics downloading; are they special files with embedded timing information, or just text? Are they even files for download, or are you talking about scraping text of html pages? Are there sites offering lyrics for download, and how friendly or otherwise are they to automated access? This just isn't my area of expertise, I'm afraid, but if anyone who is interested wants to work on it and wants some help, let me know.

Alex
Title: Album Art Downloader XUI
Post by: r0k on 2012-06-18 15:07:27
Thank you for considering the suggestion
Lyrics come in two format, synchronized and raw. Raw is just plain text, can be saved as txt or anything or embedded (but i don't care about embedding, this can be done with other applications). Synced is plain text with some time "tag" at the start of every line and are often saved as lrc files. Those are just plain text with a different extension. Here's the start of an lrc file i synced some time ago.
Code: [Select]
[ar: Kingfisher Sky]
  
   [ti: Rise From The Flames]
  
   [al: Skin of the Earth]
  
   [length: 03:37]
  
   [00:17.44]There you are, down on the ground
  
   [00:23.52]Curled up and weary
  
   [00:26.33]Buried your face inside your hands
  
   [00:31.96]So grey and dark

As for downloading, i think there are (or used to be at least) some sites offering file downloads, but most need to be parsed. And of course, parsing would be different for every site as they can't all use a standard format 
Quote
Are there sites offering lyrics for download, and how friendly or otherwise are they to automated access? This just isn't my area of expertise, I'm afraid, but if anyone who is interested wants to work on it and wants some help, let me know.

There are plenty of such sites out there  Their level of friendlyness is probably variable too. I guess it's not too different for images.

As for the parsing, i've found a python script that works with amarok and some other Linux players that can retreive lyrics for the playing song and parse the websites, but it uses a python module to parse automatically so it's not possible to copy-paste-translate some parsing code.[/size]
Title: Album Art Downloader XUI
Post by: borisag on 2012-06-19 20:31:47
Hello
First of all i want to thank the author for this program.
I don't know if someone has made this already but I'm gonna explain how i use AAD with Mediamonkey. I want to thank also g.p.m for his post in this forum (page 62) of how to use AAD with MP3tag.
First obviously you have to have installed Mediamonkey and its script ExternalTools by Steegy (download in here http://home.scarlet.be/ruben.castelein/MM/...alTools14.mmip) (http://home.scarlet.be/ruben.castelein/MM/ScriptsStorage/ExternalTools14.mmip)).
Now in Mediamonkey Tools menu choose Options, and ExternalTools in the General tab.
Fill the blanks as following:
Tool Name: Album Art
Description: Album Art Downloader
Shortcut: AlbumArt
Icon Path: C:\Program Files\AlbumArtDownloader\AlbumArtDownloader.ico (or the icon from the folder where you have installed AAD)
Program Path: C:\Program Files\AlbumArtDownloader\AlbumArt.exe (or the .exe from the folder where you have installed AAD)
Paramethers: /ar "%a" /al "%l" /p "%p"\%l".jpg""
Execute Tool: any option is fine in you have to search covers one by one or multiple tracks (i don't know if the program crashes with too many tracks at once)
Finally choose "Add as new" buttom at the top and OK
Now you can right clic on any track or tracks from the library and select Tools/ Album Art
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-20 07:51:54
The best of the best would be to display a sample of the text instead of images.

Certainly, that wouldn't be too hard to do in a script (rendering it into an image in the same way you mentioned). Image viewing tools would not be ideal to look at that, but better than nothing, I guess. Thanks for the additional information on the lyrics. If there's already a script which works, then that's quite interesting, it proves it's possible, at least.

i don't know if the program crashes with too many tracks at once

Thanks for your detailed instructions! If you don't mind, I'll post them to the wiki alongside the ones for MP3Tag? AAD should very much not crash with too many tracks at once! It will, by default, do up to three searches simultaneously and queue the rest up until those are closed: Queueing Searches (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Queueing_Searches).

Alex
Title: Album Art Downloader XUI
Post by: borisag on 2012-06-20 16:22:14
i don't know if the program crashes with too many tracks at once

Thanks for your detailed instructions! If you don't mind, I'll post them to the wiki alongside the ones for MP3Tag? AAD should very much not crash with too many tracks at once! It will, by default, do up to three searches simultaneously and queue the rest up until those are closed: Queueing Searches (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Queueing_Searches).

Alex


Of course I don't mind. But I have to make a make a correction in Paramethers you have to fill with
/ar "%a" /al "%l" /p %p\%l.jpg (if you want to save the cover in the same folder as the .mp3 with the name of the album.jpg) or
/ar "%a" /al "%l" /p %p\folder.jpg (if you want to save the cover as folder.jpg)
A suggestion to embedd the image to the mp3 file you can use the Mediamonkey script Album art Tagger created by Trixmoto or the program Mp3Tag
Title: Album Art Downloader XUI
Post by: borisag on 2012-06-20 16:51:53
Hi Alex
I think the GoogleImage script isn't working.
Is it possible a Bing script also?
Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-23 17:04:40
Hi Alex
I think the GoogleImage script isn't working.
Is it possible a Bing script also?
Thanks

Thanks for pointing this out. google.boo (http://album-art.sourceforge.net/scripts/google.boo) has been updated and should be working again now. A Bing script might be possible - are you finding it produces better results than Google Images for some searches?

Alex
Title: Album Art Downloader XUI
Post by: Mus on 2012-06-24 10:37:59
Hi,

Would love to get this to work.

For example I am searching on ABBA - ABBA Gold or The Beatles - Please Please Me in Amazon, Google, iTunes (or every website) and the program is obviously looking at the ticked websites but not finding anything.

Thanks for any pointers.

M
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-24 12:48:55
Hi, I'm not sure why you're having difficulty finding results for those searches. What I'd suggest is first, choose only a single source to search, Amazon (.com) for example. You can add more later if you like. When it's searching check to see if there is a progress bar, or if it just immediately stops. I assume there's no error messages or anything shown? After the search finishes, does it show a number in brackets on the right hand side of the source, like "(10)"? If so, and there are no results shown in the list, then they are being excluded by your filter settings. Click the Options link and check to see the minimum and maximum size settings, and which cover types you have selected. As a quick check, you can also click the Filter button to the left of the Group By control above the results list to toggle all filters off, so you can see any hidden results.

Alex
Title: Album Art Downloader XUI
Post by: Mus on 2012-06-24 13:40:22



Thanks for the reply Alex.

Yes there is a brief green Progress Bar and then Stop. No error and no results are shown. I have removed the size filter and have all of the cover type filters checked. Full size is set to Never but same results if I say always.

I have set a custom folder for the downloads and this is always empty.

This happens standalone and if I run via MP3Tag.

M
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-06-24 15:16:00
Hmm. That's a bit of a mystery, then. Its the same whichever single source you have selected, and it never shows a number in brackets after the search at all? I suppose it could be a firewall or something preventing AAD from accessing the internet, do you have a firewall or similar software installed that's set to deny access to the internet for un-whitelisted applications?

Alex
Title: Album Art Downloader XUI
Post by: Mus on 2012-06-24 18:45:13


OK, good call on the firewall. For some reason AVG had stopped prompting me to allow access to certain programs.

All seems to be working fine now :-) And thanks for a real time-saver of a program!

M
Title: Album Art Downloader XUI
Post by: MordredKLB on 2012-06-26 17:57:47
Thanks for pointing this out. google.boo (http://album-art.sourceforge.net/scripts/google.boo) has been updated and should be working again now. A Bing script might be possible - are you finding it produces better results than Google Images for some searches?

Alex

I updated my bandcamp.boo (https://www.dropbox.com/s/05br4is3834w5lx/bandcamp.boo) script and my googleLarge.boo (https://www.dropbox.com/s/sbca94hi1x8063r/googleLarge.boo&quot;) to reflect these changes. Unfortunately, google no longer returns file sizes so that information is no longer available in the google Large Image script. That really frustrates me because it was a nice time saver being able to see that a 1500x1500 image wasn't worth even browsing because it's only 84k or something.
Title: Album Art Downloader XUI
Post by: Aphotic on 2012-07-13 09:49:57
just registered 2 to say TNX 4 this mighty t8l and got a serious question 2 ask:

HOW CAN I ADD album covers automatically EMBEDDED in MP3 tags?
i mean i don't want to create folder.jpg files....i want EACH & every MP3 files have their own ALBUM cover EMBEDDED in themselves...automatically!!!

how can i!? ...someone guide me to the right PATH!
tnx!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-07-14 08:20:08
HOW CAN I ADD album covers automatically EMBEDDED in MP3 tags?

Album Art Downloader does not do tag management, it only does art downloading. You need some tag management software like MP3Tag to do this. There are some instructions on how to do this here: Using AAD with MP3Tag (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=57392&view=findpost&p=740568).

Alex
Title: Album Art Downloader XUI
Post by: Aphotic on 2012-07-14 15:31:37
thanks 4 the fast response from this ghost town...
x^D

i'll be reading and trying & hoping it works....i need the covers "in" the MP3 tags to make my Sony XPERIA P l8k wicked!
Title: Album Art Downloader XUI
Post by: vagskal on 2012-07-16 18:37:04
I am adding some singles cover art. The scripts for two of the best sites for this unfortunately do not work: 45Cat does not provide any hits and Chartstats produces no or wrong hits. Could this perhaps be fixed somehow?

Thanks.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-07-16 18:57:33
45Cat does not provide any hits and Chartstats produces no or wrong hits.

Thanks for letting me know, here's an updated 45cat.boo (http://album-art.sourceforge.net/scripts/45cat.boo).

Chartstats seems to be working correctly, but their search engine is, unfortunately, rubbish. If you are getting different results from using the search box on their site to AAD, then let me know what you searched for and I'll see if I can figure out the difference.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2012-07-16 19:08:25
Now that was fast! Thanks!

The new 45Cat script does not fill in the Name field in AAD (minor issue), but seems to work great!

The Chatrstats script has never provided correct results. I am not using the search engine on the site but Google search, which finds hits that the script does not. And the script often produces totally irrelevant hits. The site search provided is probably rubbish as you suggest.

I might get back with a few suggestions for singles cover art sites to possibly add, if you do not mind.

Thanks!

EDIT: PS. Sometimes the Stop All option is not available (although searches are being conducted).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-07-16 19:57:45
The new 45Cat script does not fill in the Name field in AAD

Oops, guess I was too quick, I didn't notice! Here it is again: 45cat.boo (http://album-art.sourceforge.net/scripts/45cat.boo). It uses the artist and the title of the A-Side as the title, which I think is accurate enough.

I don't want to add other specialist google searches, as multiple searches tend to trigger their anti-robot protection, so I'll only use site's built in search engines, sorry.

I'm not sure about the stop all issue, it seems to be fine here, but if you notice anything different about when it doesn't appear, or even better, any steps that can demonstrate it happening, let me know.

Alex
Title: Album Art Downloader XUI
Post by: Dirki on 2012-07-18 21:17:58
How can I make Album Art Downloader to automatically download the covers for each single album / single etc. on the hard disk and save the covers accordingly to the albums / singles etc. in the right folders?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-07-19 07:54:01
How can I make Album Art Downloader to automatically download the covers for each single album / single etc. on the hard disk and save the covers accordingly to the albums / singles etc. in the right folders?

Please see the wiki page here: Automatic Image Downloading (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Automatic_Image_Downloading)

Alex
Title: Album Art Downloader XUI
Post by: Dirki on 2012-07-19 10:10:32
Okay, many thanks, Alex.
Title: Album Art Downloader XUI
Post by: vagskal on 2012-07-20 12:31:26
45Cat does not provide any hits and Chartstats produces no or wrong hits.

Thanks for letting me know, here's an updated 45cat.boo (http://album-art.sourceforge.net/scripts/45cat.boo).


The 45Cat script does not like &. Try to search for Ike & Tina Turner, for example (http://www.45cat.com/45_search.php?sq=Ike+%26+Tina+Turner+A+Love+Like+Yours&sm=se).

Or ', try http://www.45cat.com/45_search.php?sq=The+...+Baby&sm=se (http://www.45cat.com/45_search.php?sq=The+Crystals+There%27s+No+Other+Like+My+Baby&sm=se)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-07-21 08:01:12
The 45Cat script does not like &.

Thanks for letting me know. I've updated the script 45cat.boo (http://album-art.sourceforge.net/scripts/45cat.boo) so it no longer strips out those characters from the query. It still won't find "Ike & Tina Turner", but that's because they have it as "Ike And Tina Turner" in their database.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2012-07-21 17:12:11
Thanks!

Strange that the AAD script for 45Cat produces no hits for Ike & Tina Turner although it works with the search engine for the 45Cat site, http://www.45cat.com/45_search.php?sq=Ike+...Yours&sm=se (http://www.45cat.com/45_search.php?sq=Ike+%26+Tina+Turner+A+Love+Like+Yours&sm=se).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-07-21 17:56:18
Strange that the AAD script for 45Cat produces no hits for Ike & Tina Turner although it works with the search engine for the 45Cat site

The search I use is with quotes, to separate artist and album: "Ike & Tina Turner" "A Love Like Yours" (http://www.45cat.com/45_search.php?sq=%22Ike+%26+Tina+Turner%22+%22A+Love+Like+Yours%22&sm=se) (no results), "Ike And Tina Turner" "A Love Like Yours" (http://www.45cat.com/45_search.php?sq=%22Ike+And+Tina+Turner%22+%22A+Love+Like+Yours%22&sm=se) (correct results)

I suppose it would be possible to auto-correct & to And, but then again there might be titles which do actually have & in them and not And, so it's probably not a good idea.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2012-07-21 18:14:28
Thanks for the explanation!

How about stripping & and the part before or after it ("Ike" or "Tina Turner" in this case)? That would produce hits instead of drawing a blanc, and I cannot think of a case where an artist or song/album begins or ends with &. Just a thought...
Title: Album Art Downloader XUI
Post by: vagskal on 2012-07-30 09:54:44
Would it be possible to add this site?
http://www.soundstation.dk (http://www.soundstation.dk)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-07-31 18:59:23
Would it be possible to add this site?
http://www.soundstation.dk (http://www.soundstation.dk)
Yep, sure, here you go: soundstation.boo (http://album-art.sourceforge.net/scripts/soundstation.boo). Let me know if there's any trouble with it.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2012-07-31 19:05:08
Thanks!
Title: Album Art Downloader XUI
Post by: vagskal on 2012-08-03 17:29:25
Would it be possible to add also this site?
http://www.iodalliance.com (http://www.iodalliance.com)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-05 09:23:59
Would it be possible to add also this site?
http://www.iodalliance.com (http://www.iodalliance.com)

Sure, give this one a try: ioda.boo (http://album-art.sourceforge.net/scripts/ioda.boo)

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2012-08-05 10:01:20
Thanks!

Sometimes it produces many irrelevant hits, like when I searched for Artist=Kelly Willis Album=Kelly Willis

I rather have irrelevant hits than having the script missing a real hit.
Title: Album Art Downloader XUI
Post by: vagskal on 2012-08-05 10:16:29
PS. Is it possible to strip accents if that gives better results. The DJ Shop for example does not find Diamanda Galás but finds Diamanda Galas.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-05 12:08:50
Sometimes it produces many irrelevant hits, like when I searched for Artist=Kelly Willis Album=Kelly Willis
Yeah, it looks like it's searching for any contributing artist or something. The basic problem with searching for the album "Kelly Willis", though, is that they don't have that album!

Stripping accents, in the general case, is tricky and not necessarily right. If there's a specific site which is dumbly always strips all accents, I suppose a special case could be made, but take your DJ Shop example. They do list "Diamanda Galas", but also both "Björk" and "Bjork", "Michel Teló" and "Michel Telo" (with different results), and "Grüner Samt" but nothing for "Gruner Samt". So you can't just rely on stripping accents for the search, what it should really do is make the search accent-insensitive, so results with or without accents would be returned. Unfortunately, that's something only they can do.

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2012-08-05 15:24:16
Sometimes it produces many irrelevant hits, like when I searched for Artist=Kelly Willis Album=Kelly Willis
Yeah, it looks like it's searching for any contributing artist or something. The basic problem with searching for the album "Kelly Willis", though, is that they don't have that album!

Stripping accents, in the general case, is tricky and not necessarily right. If there's a specific site which is dumbly always strips all accents, I suppose a special case could be made, but take your DJ Shop example. They do list "Diamanda Galas", but also both "Björk" and "Bjork", "Michel Teló" and "Michel Telo" (with different results), and "Grüner Samt" but nothing for "Gruner Samt". So you can't just rely on stripping accents for the search, what it should really do is make the search accent-insensitive, so results with or without accents would be returned. Unfortunately, that's something only they can do.

Alex


Thanks for the reply!

I know they do not have the album, but that was just to show that the script comes up with several hits anyway.

I see about the accents. If it is not possible to send a second request without accents if the first request does not result in any hits, I guess I will have to strip the accents manually and do a second search. I do this for ' (like in it's) and The in the beginning of the artist name.
Title: Album Art Downloader XUI
Post by: hlina on 2012-08-21 13:55:58
Hi, I just downloaded and installed Album Art Downloader on my windows 7 64 bits PC. When I try launching the program, a small infobox opens ("compiling scripts"), then it disappears and nothing happens. Task Manager reports, that Album Art Downloader is running, consuimng 25 % CPU power and 20-30 MB RAM, however, there is no program window.

Can somebody help me?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-22 08:22:54

Hi, that's really strange, I haven't come across that before. The fact that the "compiling scripts" window is shown correctly indicates that .net framework is correctly installed, and can display windows properly, but for some reason it isn't able to display the main window! As it doesn't actually crash, there is no error report to give me any other clues, so I have to admit I'm a bit mystified by this one, sorry. You could try running it with the parameter "?" to see if it can show the command args help window, or "/fileBrowser" to see if it can show the file browser window instead of the main one; that might possibly give a clue as to what's going on.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2012-08-27 06:45:36
[font= "Verdana"]Hi, Alex,
sorry to 'bug' you with this , but is there a way to "re-categorize" the scripts sources groups (on the "Sources:" grouping on the left side of the search window) and/or "re-assign" scripts to a different or new group?

Also, maybe in the future, it would be great if we could collapse/expand those groupings; since we can't sort them, it would be a great way to get back "in control": see the most important and "search first" sources all-at-once with their respective results, progress and individual stop links.

(e.g. Current Script Sources Groups are: "Dance, Club, Eletronic" / "Independent" / "Fan-Made Covers" / "Reggae" / "Canadian" / "South-African" / "Punk, Metal, Rock" / "Eastern" / plus a few others)

Many thanks in advance. [/font]
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-27 08:12:52

There isn't any easy way to recategorize sources, no. If you really need to do it, you could go to the scripts folder and open the .boo file for the script in notepad, then just change the category in there. It's a bit more tricky for scripts which don't have categories, but for those that already have them it should be simple to change the text. If you think there are any that are actually miscategorised, though, or any scripts that ought to be in a category but aren't, then do let me know!

Thanks for your suggestions on expanding and collapsing groupings, I'll look into what would be involved in adding support for that.

Alex
Title: Album Art Downloader XUI
Post by: hlina on 2012-08-27 11:00:29
Hi AlexVallat: Thanks for your answer. I tried /? option - but nothing happens, it starts, but doesn't display any window. Using /filebrowser opens the filebrowser without any problems. Today, AlbumArt.exe started the first try and offered to download some updates. I allowed to update, the program requested to restart, the next restart presented the "compiling scripts" window, and then it did't display a window as before (it doesn't even display the "compiling scripts" window at restart).
Title: Album Art Downloader XUI
Post by: audio20 on 2012-08-27 12:12:39
[font= "Verdana"]
There isn't any easy way...  scripts folder... boo file for the script in notepad, then just change the category in there.

I did just that, for all current scripts in the folder (although while I was doing that I really regret the fact that I would have to say goodbye to automatic updates to the scripts, meaning I would have to do all manually from now on...);

For Scripts that did not already have Categories assigned to them, I included the 2 extra lines, depending on the type of script, e.g.:
Code: [Select]
    Category as string:
        get: return "C - CD Covers"
or
Code: [Select]
    static SourceCategory as string:
        get: return "E - Other Sites"


Here's the partial result:    (feel free to postpone it as much as you need  )

P.S.: I guess I should mention that the whole "collapsing/expanding" of source groupings only really works/makes sense if there is either an easy way to assign a group to each script/source or if they all come "pre-loaded" with a reasonable grouping; I posted my "first try" into grouping the sources (for my own needs/liking, of course) here:
Google Docs: Spoiler (click to show/hide)
[/font]
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-27 14:17:56
Using /filebrowser opens the filebrowser without any problems.
Now that's weird. The compiling scripts window behaviour is normal - that only shows once, or after updates, it isn't supposed to show every time. I don't understand why the file browser window can open but the help window can't, though. If you try and open a new search window from the file browser window (Ctrl+N, or File, New, Search Window) does it report any error, or just give the same hanging behaviour?


For those scripts which didn't have a category before, if you want to add one, it depends on the sort of script. As you noticed, there are two sorts, the old style (which after the imports start with a declaration like "class Coveralia:") and the new style, whose declaration looks more like: "class eMusic(AlbumArtDownloader.Scripts.IScript):". If it's the second style, then in order for adding the category to work, you have to also add ", ICategorised" to the declaration, so it would become: "class eMusic(AlbumArtDownloader.Scripts.IScript, ICategorised):"

That is a *lot* of scripts you are using! I think the reason you are finding the sources list doesn't quite match your needs is because the design had in mind that people would be using only a few scripts, perhaps one or two search-first, then maybe 4 or 5 others! Anyway, I had a look at the weird sorting of categories. It turns out that, although the thing is set to sort the sources alphabetically, it doesn't do that for the group names. Not really sure why not, but I'll do some experimenting with the list control and figure out a way to make it happen for the next version. It appears that the way it's sorting it at the moment is by the first member of the group, alphabetically. So "G - Last Shops" comes before "C - CD Covers" because the first member of G starts with a B (Beatport) and the first member of C starts with a C (Cover-Paradies)!
Title: Album Art Downloader XUI
Post by: hlina on 2012-08-27 15:05:08
Alex: While the filebrowser window opens immediately and without problems, it tends to hang when I try to do something in it. Pressing Ctrl+N causes the program to hang and presents me an "album art downloader not responding window". Is there a way to create a log file to pinpoint the reason for my problem?



Using /filebrowser opens the filebrowser without any problems.
Now that's weird. The compiling scripts window behaviour is normal - that only shows once, or after updates, it isn't supposed to show every time. I don't understand why the file browser window can open but the help window can't, though. If you try and open a new search window from the file browser window (Ctrl+N, or File, New, Search Window) does it report any error, or just give the same hanging behaviour?


For those scripts which didn't have a category before, if you want to add one, it depends on the sort of script. As you noticed, there are two sorts, the old style (which after the imports start with a declaration like "class Coveralia:") and the new style, whose declaration looks more like: "class eMusic(AlbumArtDownloader.Scripts.IScript):". If it's the second style, then in order for adding the category to work, you have to also add ", ICategorised" to the declaration, so it would become: "class eMusic(AlbumArtDownloader.Scripts.IScript, ICategorised):"

That is a *lot* of scripts you are using! I think the reason you are finding the sources list doesn't quite match your needs is because the design had in mind that people would be using only a few scripts, perhaps one or two search-first, then maybe 4 or 5 others! Anyway, I had a look at the weird sorting of categories. It turns out that, although the thing is set to sort the sources alphabetically, it doesn't do that for the group names. Not really sure why not, but I'll do some experimenting with the list control and figure out a way to make it happen for the next version. It appears that the way it's sorting it at the moment is by the first member of the group, alphabetically. So "G - Last Shops" comes before "C - CD Covers" because the first member of G starts with a B (Beatport) and the first member of C starts with a C (Cover-Paradies)!
Title: Album Art Downloader XUI
Post by: audio20 on 2012-08-27 15:22:46
[font= "Verdana"]
For those scripts which didn't have a category...old style...new style...also add ", ICategorised" to the declaration

Many thanks for that! I'll add it where appropriate, that'll be great! Thanks for the information!

Quote
That is a *lot* of scripts you are using!...the design had in mind that people would be using only a few scripts, perhaps one or two search-first, then maybe 4 or 5 others!

Yes, I know...  :ashamed:

I think this started because I had a lot of albums that are not so popular / a bit "obscure"; then it got worse when the main sources that I used started changing the output/results (AAX was gone, then iTunes blocked bigger images, other sources also started blocking, etc, etc); I also started having problems with 'timeouts', due to the slow internet connection I was forced to use; to compensate, I graduately added more and more sources to the "search first" list, even if this seems counter-intuitive (it's easier to request a search on more sources at the same time and then forget about it for a few minutes instead of keep checking and adding new sources and hitting 'extend search');

I don't mind when there are many results, as I often spend a lot of time comparing and analysing all different covers obtained from different sources to determine wich one is best in terms of quality (and I'm gonna keep) and also wich ones are slightly different versions (also to keep).

As "extreme" as my use case may seem at first, and although I would recognize that I am indeed in a minority, I don't think I'm all alone in this (using many sources at the same time and having to scroll back and forth to see them all). I am 'offline' most of the time, so I use AAD to fetch good image sources to work on later, either eliminating blemishes (jpeg artifacts) in the image, cutting or including extra pixels in the image to make it perfectly square, etc, etc. I know that doesn't fully justify using so many sources, but it's an explanation...

Quote
Anyway, I had a look at the weird sorting of categories.

You meant the 'new' categories I assigned to the scripts? Yes, it was pretty weird indeed... 
(it was just a 'first draft', though, as I had no idea if it would work; but I bet you that some groups, like the "CD Covers", go pretty well together as they provide the same kind of results; I grant you that what I called "First Shops" would be better named "Top Digital Stores" or something like that  )


Quote
...set to sort the sources alphabetically, it doesn't do that for the group names...experimenting with the list control...make it happen for the next version...

That will be very very good! I'm looking forward to it (no hurry, though). Thanks!

Maybe, since I'm already editing all script files, I could try to experiment changing their filenames (yesasia.boo to 20_yesasia.boo, for example) and/or "Name" properties (YesAsia to 20_YesAsia)?

Again, many thanks for your patience and your very quick responses![/font]
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-27 17:25:27
Pressing Ctrl+N causes the program to hang and presents me an "album art downloader not responding window". Is there a way to create a log file to pinpoint the reason for my problem?
Unfortunately, no. It will produce a log if it crashes, but if it just goes into an infinite loop like this there's no way of getting any sort of log or report out of it.

Maybe, since I'm already editing all script files, I could try to experiment changing their filenames (yesasia.boo to 20_yesasia.boo, for example) and/or "Name" properties (YesAsia to 20_YesAsia)?

Checking the code, it should be file-system order at the moment, as it doesn't apply sorting. So changing the filenames ought to allow you to control the order...
Title: Album Art Downloader XUI
Post by: audio20 on 2012-08-28 06:13:52
Checking the code, it should be file-system order at the moment, as it doesn't apply sorting. So changing the filenames ought to allow you to control the order...

Dawn! It works! It totally works! Yay! 
(I'm singing "Look at me now! Look at me now! I'm grouping sources!"  - like that Chris Brown song)
All I had to do was add 3 simple chars to each files
Code: [Select]
01_7digital.boo
02_deezer.boo
03_djshop.boo
04_emusic.boo
05_itunes.boo
etc...

From now on, it's only manual editing to update the scripts for me, but it's totally worth it!

Once again, my most sincere gratitude for your work and your tips, Alex!

P.S.: The only script that gave me trouble for editing was "amazon-common.boo", I think it's because it has unicode in it (and my default editor apparently saves files in ANSI - but I might be wrong about that...). If anyone else is thinking about manually editing those files too, just be aware of this...
Title: Album Art Downloader XUI
Post by: audio20 on 2012-08-28 08:28:12
I keep forgeting to ask this, as it's really not that important...
(http://img513.imageshack.us/img513/8352/aadpresets002.png)
Is there a way to edit these 'presets' that show up next to the thumbnail (and let's you assign a preset for those 'unknown')? Furthermore, could I possible add a few extra presets (like CD1, CD2, etc)?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-28 18:34:42
Is there a way to edit these 'presets' that show up next to the thumbnail

Sorry, no. To change those, it would have to be a change to the main program code, and then most of the scripts would need to be updated to match.

There are things you can do, though, if what you want to do is change how they are inserted into the filename. If, instead of %type%, you use %type(Unknown,Front,Back,Inside,CD)% then just replace whichever word in there you don't like with the word that should be used to replace it (but make sure you keep them in the same order so it knows which is which).

For adding values, there's no way of doing that (and none of the current scripts would be able to return any additional values anyway!), however types can be combined with the actual preset system. Instead of including %type% in the filename, include %preset%. Then edit the presets dialog so that the default preset value is %type% (including custom names in parenthesis, if you want). Then add all your other custom values as other preset values. That way, when you choose to save, you can click the drop down and pick one of your custom choices, if you don't want it to use the type name itself.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2012-08-29 06:30:29
Sorry, no. To change those, it would have to be a change to the main program code, and then most of the scripts would need to be updated to match.

Completely makes sense. Many thanks for clarifying it!

Quote
There are things you can do...replace whichever word in there you don't like...adding values, there's no way of doing that...types can be combined with the actual preset system...include [font= "Courier New"]%preset%[/font]...default preset value is [font= "Courier New"]%type%[/font] (including custom names in parenthesis, if you want). Then add all your other custom values as other preset values.

I think I may have not expressed myself so well, I meant edit as in edit the 'list' of words included in that %type% category, to include a few that would most likely replace the 'unknown' values (mostly on results given by google and discogs); generally the other sites give pretty accurate results in that field that I usually don't want to change.

Quote
That way, when you choose to save, you can click the drop down and pick one of your custom choices, if you don't want it to use the type name itself.

I really like that option, it's pretty clever! The only problem is that it only works with 'manual searches'; when I'm doing searches derived from the 'File Browser' it seems it doesn't give me the option to save as a preset (the small downward arrow to the right)...

'Manual' Search: (http://img31.imageshack.us/img31/9628/aadpresetsmanual.png)  ---  'File Browser' Search: (http://img690.imageshack.us/img690/1280/aadpresetsfilebrowser.png)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-08-29 08:01:28
when I'm doing searches derived from the 'File Browser' it seems it doesn't give me the option to save as a preset (the small downward arrow to the right)...

When you start a search from the file browser, it assumes that you want to save the image in the location images are searched for in the file browser. So, to get the same behaviour there, make sure that you've added %preset% to the "Specify path to find images" box in the Options panel of the file browser.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2012-08-31 08:22:07
When you start a search from the file browser...to get the same behaviour there, make sure that you've added [font= "Courier New"]%preset%[/font] to the "Specify path to find images" box in the Options panel of the file browser.

My apologies... I not 100% sure but I think I might have "skipped" the re-starting of the application and maybe that's what was preventing it from showing the "small arrow downwards" on the search windows coming from the file browser; Now it is working perfectly! The system you proposed with %type% inside presets is just genious! Once again, many thanks for your work, tips and patience!
Title: Album Art Downloader XUI
Post by: iammike on 2012-09-01 12:37:43
Hi Alex,

thanks for your program I use it everyday in combination with Mp3tag (Brilliant Combination)

But I just had to register to post a very minor bug.

Every time I start AAD it notifies me that it downloaded New Scripts, (that's a good thing) but however the script is always the same one.

Amazon MP3 (.com) Version v0.1.

I uninstalled AAD and reinstalled already 2 times but it doesn't change things.

Regards
M

Edit: // I forgot to add that the downloaded file \Scripts\amazon-mp3-com.boo is always 0 ("Zero") Bytes
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-09-01 15:56:07

Thanks for letting me know - I checked it out, and it does seem like that script was missing from the server! I've uploaded it now so it should be available for you next time AAD tries to download it.

Alex
Title: Album Art Downloader XUI
Post by: iammike on 2012-09-02 04:35:57
@AlexVallat

Solved !!! Thanks for the quick action.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2012-09-04 01:30:46
I recently decided to give up on managing my audio books separately and just merged them into my main library.

So now when I try and find missing cover art it wants to include those. None of the sources available seem to have cover art (I thought at least Amazon might have some). Does anyone know of any good sources for square (or close) audio book cover art? Even better, does anyone have an actual boo script that will search that source?

Thanks!
Title: Album Art Downloader XUI
Post by: audio20 on 2012-09-04 17:41:57
[font= "Verdana"]Hello, Alex,
I've been using AAD a lot lately (with great results, I might add) and, so far, the only feature I keep wishing that the program had is more than 2 "waves" of search (and perhaps a bigger "timeout" for both searches and thumbnail/images responses, but this isn't as important).

I believe most of us (or perhaps almost all of us) love and use regularly the "Search first" feature available for all sources, to separate the most useful ones from the "not-so-useful-ones"; the only problem is that time and time again it has proven a bit "too little" for many types of use and left us wishing for more "waves", e.g. "Search first", then "Search Second", then "Search Third", etc.

- A very simple problem for people with low bandwidth and/or only wishing to "review" previously downloaded covers (for quality purposes, maybe - only re-download if the quality of the cover isn't good enough): if you want to check "Local files" and ONLY Local files BEFORE checking any other online sources, you immediately "loose" the "Search first" feature because all other sources will be forced to be grouped together.

- Another typical "problem" is quite easily seen with the various Amazon Stores: The occurrence (or absence) of certain albums doesn't vary too much between each country store, and when the album is found in one, it usually yelds the exact same result from most of the other stores (appart from customer images); In this case, the "Search first" scheme is extremely helpful, giving a "priority system" to one (or a few) store(s) more likely to have most albums (like .com .co.uk and .ca); the problem is that sometimes (and it's not so rare as we would like it to be), the album is not found on the "Search first" stores, and a "fallback order" that could be applied to the other stores would be most helpful, instead of having to search "all of them at once" in the "Extend search"; In this case, at least 3 or even as far as 7 "waves" could possibly be applied.

- But perhaps the most "annoying" problem we usually face is having to "tick on and off, on and off, on and off again" any extra sources we might want to include for albums that aren't that popular (and therefore don't get many results from most of the "Search first" or the "Extend search" selected sources); The "ideal solution" would be, without a doubt, having those "waves" of search: instead of marking (or unmarking) "Search first" for each source, we could have instead a "Search: 1st" and 1st, 2nd, 3rd, 4th, 5th, etc on a dropbox as a choice. So, with each click of the "Extend Search" button, we would "unleash" a deeper "wave" of search. Optionally, we could have an indication of this in the button text, e.g. "Extend Search (3)" to unleash the 4th wave. In my opinion, I can't see anyone wanting to use more than 9 "waves" for instance (a single-digit option would suffice).

Yes, I do realize most of AAD users will never need to use more than 2 waves of search (as it is now), but that absolutely doesn't mean that there isn't a great number of users that WILL benefit from it (and, of course, nothing changes for the ones that don't need more than 2 waves). I also realize that implementing it might not be as easy as it sounds, and all I'm asking is for this idea (or something similar to it) to maybe be considered for a future version.

instead of this --> (http://img16.imageshack.us/img16/2563/aadoptions001.png) ... this --> (http://img255.imageshack.us/img255/3758/aadoptions002.png)
[/font]
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-09-04 19:24:13
Here's a script for searching Amazon.com audiobooks: amazon-audiobooks-com.boo (http://album-art.sourceforge.net/scripts/amazon-audiobooks-com.boo), please give it a go and let me know if you have any trouble with it.

Thanks for your detailed post and suggestion, particularly the UI mockup to make it clear what you mean. I don't agree that it has no impact on normal users though, as I think it would be more than a little confusing to see a list of numbers like that, and Search First is already a confusing feature! If I was going to do anything to address this, it would have to be more visual, perhaps with dragging and dropping sources into orders, and opening up gaps in the order or inserting special boundary items or something to delineate waves. At least that way if you decided something ought to go between 2 and 3 you don't have to re-order 3 through 9 to fit it in! To be honest, I don't really want to go down this route though, I'm not going to work hard on supporting the case of using large numbers of scripts, and don't want to encourage it.

The Amazon stores illustrate the issue perfectly - the idea was that you would choose the amazon country that you use, and install that one, or else just use amazon.com. There's no point in installing all of them, as they have massive amounts of overlap (as you noticed).

What I have thought might be useful would be named lists of sources enabled, so if you had a very disparate collection you might want to check a few sources and name that as "Metal", then uncheck those and check some others and name that as "Jazz", then when it comes time to search you could pick from a previously saved list in a dropdown above the sources list. I'm not yet convinced whether it would really be useful or not, whether the hypothetical user would instead rather have both Jazz and Metal sources all selected all the time and not have to choose between them before searching.

Alex
Title: Album Art Downloader XUI
Post by: dubwai on 2012-09-14 18:33:48
Request option:  show cover file size (not resolution) in main window.

Sometimes, it’s not easy to choose what cover to save as main, because very often they have one resolution, but different sizes. So now I save them all, then go to folder and manual rename the most “quality” as “first” cover, which will be used by fb2k.


Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-09-14 19:33:54
Request option:  show cover file size

This is already in the feature request tracker: 2890572 (http://sourceforge.net/tracker/?func=detail&aid=2890572&group_id=187008&atid=919578). The main problem is that the file size is not known until the full size image has already been downloaded, so it's of limited usefulness.

Alex
Title: Album Art Downloader XUI
Post by: dano on 2012-09-14 20:22:57
I don't think that's really a problem.  I don't need the size of every cover, but once the  full  cover was downloaded, it would be really good if the size info was available.
Cover dimensions are also not immediately available at every source.
Title: Album Art Downloader XUI
Post by: dubwai on 2012-09-14 20:35:51
I don't need the size of every cover, but once the  full  cover was downloaded, it would be really good if the size info was available.

Fully agree. I think the best solution will be to add size if it available near resolution. Look at my mockup:
(http://img513.imageshack.us/img513/5310/20120914233258.jpg)
(http://img208.imageshack.us/img208/7314/20120914233507.jpg)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-09-15 07:47:29

Hmm... I could just add it as an extra bit of text tagged onto the end the Size field when known, rather than adding a whole new field (which would then need to be sortable and filterable, and probably need to be able to be included in the filename). That would certainly be simpler to do, and might be helpful.
Title: Album Art Downloader XUI
Post by: dano on 2012-09-21 13:41:07
The GoogleImage script shows a complete <cite title=" tag instead of just the host name.
A possible fix:
line 22: title = System.Web.HttpUtility.HtmlDecode(/<[^>]+>/.Replace(imageMatch.Groups["title"].Value, ""))
Title: Album Art Downloader XUI
Post by: Ardax on 2012-09-21 15:41:26
The problem is that file size isn't a good indicator of quality either.  Particularly with JPEG compression, an image with a lot of noise or a moiré pattern left over from a poor scan will end up being much larger than an image that's had some post-processing done to it.
Title: Album Art Downloader XUI
Post by: dubwai on 2012-09-22 06:15:04
The problem is that file size isn't a good indicator of quality either.

What problem, just don't see at size  As I understand, it will be just info, without ability to sort by this field. Main reason, witch motivate me to request this feature, have ability to quick choose best cover between different online music stores. Very often, they have one resolution, but different compression, witch can be seen either by zoom or by file size. The second one, has more usability for my mind.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-09-22 19:12:49
The GoogleImage script shows a complete <cite title=" tag instead of just the host name.
Thanks for letting me know, I've fixed it up now.

The problem is that file size isn't a good indicator of quality either.
Personally, I agree. But I think it won't do any harm to show it next to the pixel size, and some people do seem to want it.

New version out very shortly, I'm just doing the release process.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-09-22 19:18:31
Version 0.45
This version adds a display for the file size of images. It's shown next to the pixel size in the Image Size field, but is only available once the full sized image has been downloaded. The sources list is now sorted alphabetically, including the categories. I apologise if this means that it's changed from what you are used to, but I thought it better to give it a sensible category order anyway.

I've also added another requested feature, which is if you click on one of the sources in the list after performing a search, it will jump to any results that have come from that source, and highlight them.

Scripts have been brought up to date, and some have been removed that can't be made to work: CD Universe, GigaCrate, and Yes24. I'd recommend you delete those from your scripts folder, if you have them.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.45.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.45.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: Ardax on 2012-09-23 02:00:02
Very often, they have one resolution, but different compression, witch can be seen either by zoom or by file size. The second one, has more usability for my mind.

That's my point.  A bigger file might be saved at a higher quality level, or it might just be a bad image that doesn't compress well.  You can't tell without looking.

Either way, the developer's already found a way to add the info in, which is pretty cool of him.
Title: Album Art Downloader XUI
Post by: EagleScout1998 on 2012-09-23 15:30:19
Is there a reason why it wants to install to this folder:

C:\Program Files (x86)\Illustrate\PerfectTUNES\

and not here:

C:\Program Files\AlbumArtDownloader
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-09-23 15:44:51
Is there a reason why it wants to install to [perfect tunes folder]

Well, my guess would be that you've previously installed a product called PerfectTUNES, by Illustrate, and that that registered a file called AlbumArt.exe in the window registry (at HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\App Paths\AlbumArt.exe). The installer uses that registry key to set the install folder, so if you are doing an upgrade, it installs in the same place.

Alex
Title: Album Art Downloader XUI
Post by: Stone Free on 2012-09-24 14:59:36
Is there a reason why it wants to install to this folder:

C:\Program Files (x86)\Illustrate\PerfectTUNES\

and not here:

C:\Program Files\AlbumArtDownloader
Is AlbumArtDownloader a 64-bit app?  Only 64-bit apps (at least on 64bit Windows 7) go in "Program Files"
Title: Album Art Downloader XUI
Post by: MC Escher on 2012-09-24 16:57:02
Album Art Downloader is a .net program, it's installed in Program Files on my computer too.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2012-10-04 03:30:04
Up till now I've almost always used AAD to fill in missing artwork. Today I used it to try and find upgraded art to replace some small crappy stuff I have.

The process led to a few requests/observations.

1. (The only "bad" thing) I don't think Local should allow Saving, only Saving As. When you right click to save AAD complains about an existing file and prompts you to save as Folder (2).jpg even though the existing file is the file you are saving.

2. It would be nice if you could pin the Local file to the top of the list (maybe even change the color of the background to better indicate it is a local result). I know you can see the source when you hover over it but a nice visual representation would be cool.

3. It would be nice if #2 could happen even if the file doesn't match the minimum size. Using 800 as a minimum I found something but I can see by comparison that it is a blurry crappy probably resized image compared to this nice crisp 700x700 I already have. Conversely this 800x800 is WAY better than the 200x200 I have for this other album.

4. It would also be cool if in addition to the minimum size there was a "Decrease Minimum by X If No Results" option. Blank would behave the same as it does but if I set the decrease to 100 and I'm looking for 800x800 AAD would ratchet down to 700x700 if no 800x800 is found. (Even better if AAD could keep going... so next try 600x600, then 500x500, then 400x400, etc)

These are really minor things that I would love to see... but only because I'm lazy.

Thanks for making a great thing!

Matt
Title: Album Art Downloader XUI
Post by: sopparus on 2012-10-04 11:12:24
since I upgraded to 0.45 I get compile errors on launch, and there is only retry and exit option which means I cant start album art downloader!

earching for scripts...
Found 69 files: [45cat.boo, 7digital.boo, albumartexchange.boo, allcdcover.boo, amazon-audiobooks-com.boo, amazon-ca.boo, amazon-co-uk.boo, amazon-com.boo, amazon-common.boo, amazon-de.boo, amazon-fr.boo, amazon-it.boo, amazon-jp.boo, amazon-mp3-com.boo, archambault.boo, arkivmusic.boo, audiopreservationfund.boo, beatport.boo, buy-com.boo, cdbaby.boo, cduniverse.boo, chartstats.boo, cover-paradies.boo, coveralia.boo, coverisland.boo, coverlandia-official.boo, coverlandia.boo, darktown.boo, deejay.boo, deezer.boo, discogs.boo, djshop.boo, ebreggae.boo, eclassical.boo, emusic.boo, esenshop.boo, freecovers-api.boo, gigacrate.boo, google.boo, hitparade.boo, hmv-canada.boo, ioda.boo, itunes-google.boo, itunes.boo, juno-records.boo, kalahari.boo, lala.boo, lastfm-artist.boo, lastfm-cover.boo, maniadb.boo, medianet.boo, megamedia.boo, metal-archives.boo, metallibrary.boo, miomusik.boo, musicmight.boo, nuclearblast.boo, psyshop.boo, qobuz.boo, revhq.boo, sfr-music.boo, soundstation.boo, take2.boo, theorchard.boo, util.boo, vgmdb.boo, wantitall.boo, yes24.boo, yesasia.boo]...
Loading references: [System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web]...
Compiling scripts...
theorchard.boo(6,7): error BCE0132: The namespace '' already contains a definition for 'Ioda'.

never mind.. removed it and reinstalled. works now
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-10-06 08:12:26

Thank you for your suggestions. For number 2, what you can do is use the Group By drop down and choose "Local". That will show the local results in one group at the top of the list, and online results in a group below that. If there's a specific result you want to compare against all the others, then right click on it and choose Preview. That will open another window for that result that you can resize and move around so it is always available for comparing against.

With the sizes, what I'd suggest would be to use the minimum size filter as a stop on the minimum acceptable size, that if it was smaller than that, you simply wouldn't want even if there were no other results. Then use the Sort by drop down to choose Size, and you can easily see the largest size available.

Alex
Title: Album Art Downloader XUI
Post by: DRata on 2012-10-07 01:24:20
Alex, the Discogs script stopped working recently. It appears that they have overhauled their web search interface, so the script probably needs significant changes to work. Not an urgent priority for me because Discogs is a secondary source for cover art, but would be nice to have this script fixed.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-10-07 09:09:38
Alex, the Discogs script stopped working recently.

Thanks for letting me know. I've updated discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) and it should be working again now.

Alex
Title: Album Art Downloader XUI
Post by: mjm716 on 2012-10-08 14:47:52
Hi,

AAD is invaluable - thank you very much!

One feature request:

When local files are visible, how about an option to delete them? (rt-click or?)
It would be very useful when one is updating images to be able to remove some old ones without having to navigate to the local folder.

cheers,

.Mike
Title: Album Art Downloader XUI
Post by: iammike on 2012-10-13 11:47:12
since I upgraded to 0.45 I get compile errors on launch, and there is only retry and exit option which means I cant start album art downloader!

<snip> Compiling scripts...
theorchard.boo(6,7): error BCE0132: The namespace '' already contains a definition for 'Ioda'.

never mind.. removed it and reinstalled. works now


I had the same problem, I just edited the 'theorchard.boo' script and renamed Ioda to the Orchard and then it compiled fine.

Code: [Select]
import System
import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util

class Orchard AlbumArtDownloader.Scripts.IScript, ICategorised):
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-10-13 12:29:29
Quote
theorchard.boo(6,7): error BCE0132: The namespace '' already contains a definition for 'Ioda'.

Ioda changed their name to The Orchard, so you should really only have one of those scripts installed. theorchard.boo replaces ioda.boo, which no longer works. If you still have ioda.boo, then I'd recommend deleting it. Changing the name of the class from Ioda to Orchard as iammike did is harmless, but unnecessary if you've deleted ioda.boo.

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2012-11-05 15:03:06
Hi Alex,
Two more script suggestions for classical music lovers:

http://www.theclassicalshop.net (http://www.theclassicalshop.net)
has high resolution cover art for every album on their website. I'm not used to the search algotithm but maybe you can figure it out.

http://www.hyperion-records.co.uk (http://www.hyperion-records.co.uk)
is a large british record label for classical music. You'll find High Resolution Album Art for their whole catalogue on their website.

Once more, thanks for your great program. I don't want to miss it anymore.

Yours,
Thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-11-06 13:44:36
Two more script suggestions for classical music lovers:

Thanks, here's a couple of scripts for those: theclassicalshop.boo (http://album-art.sourceforge.net/scripts/theclassicalshop.boo), hyperionrecords.boo (http://album-art.sourceforge.net/scripts/hyperionrecords.boo).

Please give them a try and let me know if there's any problems with them.

On an entirely unrelated note, it appears that Album Art Downloader XUI has been nominated as a Sourceforge Project of the Month (http://sourceforge.net/blog/potm-201212-vote/) for December. If anyone fancies voting for it, and has a twitter account(!) the poll is here: vote (http://twtpoll.com/l2cil8)

Alex
Title: Album Art Downloader XUI
Post by: borisag on 2012-11-11 15:13:16
hi alex
I recently look the website of the program where it's explainded how to use it with MediaMonkey based in a previous post of mine, but you didn't put the correction that I made later:
Post #2149
"Of course I don't mind. But I have to make a make a correction in Paramethers you have to fill with
/ar "%a" /al "%l" /p %p\%l.jpg (if you want to save the cover in the same folder as the .mp3 with the name of the album.jpg) or
/ar "%a" /al "%l" /p %p\folder.jpg (if you want to save the cover as folder.jpg)
A suggestion to embedd the image to the mp3 file you can use the Mediamonkey script Album art Tagger created by Trixmoto or the program Mp3Tag"
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-11-11 16:28:50
I recently look the website of the program where it's explainded how to use it with MediaMonkey based in a previous post of mine, but you didn't put the correction that I made later

Sorry, I've updated the page (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Using_Album_Art_Downloader_XUI_with_MediaMonkey) now to reflect those corrections and additional information. I prefer to show the full (/artist) style parameter names than the abbreviated (/ar) ones for extra clarity.

Alex
Title: Album Art Downloader XUI
Post by: yeeeargh on 2012-11-13 11:09:36
hi,

i made a script for musicbrainz / coverartarchive. here you can get infos about this: http://musicbrainz.org/doc/Cover_Art_Archive/API (http://musicbrainz.org/doc/Cover_Art_Archive/API)

i have no clue how to append the .boo-file, so i post  the code if that's ok. please feel free to edit or comment on it. it's my first attempt so there might be room for optimisation. especially at the error handling.

Code: [Select]
# refs: System.Web.Extensions

import System
import System.Xml
import System.Web.Script.Serialization
import AlbumArtDownloader.Scripts
import util

class Musicbrainz(AlbumArtDownloader.Scripts.IScript):
Name as string:
get: return "Musicbrainz"
Author as string:
get: return "Sebastian Hauser"
Version as string:
get: return "0.1"

def Search(artist as string, album as string, results as IScriptResults):
artist = StripCharacters("&.'\";:?!", artist)
album = StripCharacters("&.'\";:?!", album)

if(artist!= null and album!=null):
encodedArtist = EncodeUrl(artist)
encodedAlbum = EncodeUrl(album)

mbidBaseUrl = "http://www.musicbrainz.org/ws/2/release"
mbidUrl = "${mbidBaseUrl}?query=${encodedAlbum}&artist=${encodedArtist}"
#mbidUrl = "${mbidBaseUrl}?query=dummy&artist=portishead"

picBaseUrl = "http://coverartarchive.org/release"
#picUrl = "${picBaseUrl}/76df3287-6cda-33eb-8e9a-044b5e15ffdd"

scoreThreshold = 70

mbidDoc = System.Xml.XmlDocument()
try:
mbidDoc.Load(mbidUrl)
mbidRoot = mbidDoc.DocumentElement
mbidResultNodes = mbidRoot.GetElementsByTagName("release")

results.EstimatedCount = mbidResultNodes.Count

for node in mbidResultNodes:
if Convert.ToInt32(node.Attributes["ext:score"].Value) > scoreThreshold:
try:
mbid = node.Attributes["id"].Value;
picUrl = "${picBaseUrl}/${mbid}"
#picUrl = "${picBaseUrl}/76df3287-6cda-33eb-8e9a-044b5e15ffdd"

json = JavaScriptSerializer()

jsonDoc = GetPage(picUrl)
jsonResultsRelease = json.Deserialize[of Release](jsonDoc)
infoUrl = jsonResultsRelease.release

jsonResultsNodes = json.Deserialize[of Image](jsonDoc)

for i in jsonResultsNodes.images:
thumbnailUrl = i.thumbnails.small
name = i.types[0]
pictureUrl = i.image
if i.front == true:
coverType = CoverType.Front
elif i.back == true:
coverType = CoverType.Back
else:
coverType = CoverType.Unknown
results.Add(thumbnailUrl, name, infoUrl, -1, -1, pictureUrl, coverType)
except e as System.Net.WebException:
results.EstimatedCount--
except e:
return
else:
#both Parameter album and artist are necessary
results.EstimatedCount = 0;


def RetrieveFullSizeImage(fullSizeCallbackParameter):
return fullSizeCallbackParameter;

class Image:
public images as (Images)

class Images:
public image as String
public thumbnails as Thumbnails
public types as List[String]
public front as bool
public back as bool

class Thumbnails:
public large as String
public small as String

class Release:
public release as String

Title: Album Art Downloader XUI
Post by: thomian on 2012-11-16 09:59:49
Thanks, here's a couple of scripts for those: theclassicalshop.boo (http://album-art.sourceforge.net/scripts/theclassicalshop.boo), hyperionrecords.boo (http://album-art.sourceforge.net/scripts/hyperionrecords.boo).

Please give them a try and let me know if there's any problems with them.


Hi Alex,
Both scripts seem to work.
During my tests they showed to be very slow, sometimes with timeout and no results on a single search. I couldn't find a special pattern for these timeouts. Today it worked fine.
Errors might be due to their servers or due to my internet connection.
Yours,
thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-11-25 17:39:53
i made a script for musicbrainz / coverartarchive.

Nice one, thanks! Sorry it's taken me so long to reply, I've been on holiday. I've uploaded your script as a boo file here: musicbrainz.boo (http://album-art.sourceforge.net/scripts/musicbrainz.boo), but having tried it out I wonder if it would be possible to have the name of the result be the artist and album as returned by the musicbrainz query for the release rather than the type of the image (front, back, etc.)? That often makes it quick and easy to see if it's a wrong result, or just a result with some odd alternative cover artwork. For example, if you search for "Muse - Absolution", one of the result that comes back is "AutumnTears - Absolution", but they are both named as "Front" by this script. You mentioned error handling specifically - I don't think there's any problem in that area. Yours is better than most scripts, in fact. AAD will trap unhandled exceptions arising from scripts and just stop the script at that point anyway, and there's rarely anything more useful than that which can be done for recovery by a script!

In any case, are you happy for me to include your script in the installer of future releases of AAD?

Quote from: thomian link=msg=0 date=
Thanks for letting me know. I *think* it was probably a temporary issue; it doesn't seem likely that it would be caused by the script itself. I'll keep an eye on it though.

Alex
Title: Album Art Downloader XUI
Post by: yeeeargh on 2012-11-26 16:13:33
but having tried it out I wonder if it would be possible to have the name of the result be the artist and album as returned by the musicbrainz query for the release
done.

For example, if you search for "Muse - Absolution", one of the result that comes back is "AutumnTears - Absolution", but they are both named as "Front" by this script.
Edited the query-syntax a bit. Now the search results should be a better and quite strict.

In any case, are you happy for me to include your script in the installer of future releases of AAD?
Feel free to include it
Here's the edited code:

Code: [Select]
# refs: System.Web.Extensions

import System
import System.Xml
import System.Web.Script.Serialization
import AlbumArtDownloader.Scripts
import util

class Musicbrainz(AlbumArtDownloader.Scripts.IScript):
Name as string:
get: return "Musicbrainz"
Author as string:
get: return "Sebastian Hauser"
Version as string:
get: return "0.2"

def Search(artist as string, album as string, results as IScriptResults):
artist = StripCharacters("&.'\";:?!", artist)
album = StripCharacters("&.'\";:?!", album)

if(artist!= null and album!=null):
encodedArtist = EncodeUrl(artist)
encodedAlbum = EncodeUrl(album)

mbidBaseUrl = "http://www.musicbrainz.org/ws/2/release"

# fuzzier search
#mbidUrl = "${mbidBaseUrl}?query=dummy&artist=portishead"
#mbidUrl = "${mbidBaseUrl}?query=${encodedAlbum}&artist=${encodedArtist}"

# stricter search
#mbidUrl = "${mbidBaseUrl}?query=%22dummy%22%20AND%20artist:%22portishead%22"
mbidUrl = "${mbidBaseUrl}?query=%22${encodedAlbum}%22%20AND%20artist:%22${encodedArtist}%22"

picBaseUrl = "http://coverartarchive.org/release"
#picUrl = "${picBaseUrl}/76df3287-6cda-33eb-8e9a-044b5e15ffdd"

scoreThreshold = 70

mbidDoc = System.Xml.XmlDocument()
try:
mbidDoc.Load(mbidUrl)
mbidRoot = mbidDoc.DocumentElement
mbidResultNodes = mbidRoot.GetElementsByTagName("release")

results.EstimatedCount = mbidResultNodes.Count

for node in mbidResultNodes:
if Convert.ToInt32(node.Attributes["ext:score"].Value) > scoreThreshold:
try:
mbid = node.Attributes["id"].Value;
mbidArtist = node.Item["artist-credit"]\
.Item["name-credit"]\
.Item["artist"]\
.Item["name"]\
.InnerText
mbidRelease = node.Item["title"].InnerText
picUrl = "${picBaseUrl}/${mbid}"
#picUrl = "${picBaseUrl}/76df3287-6cda-33eb-8e9a-044b5e15ffdd"

json = JavaScriptSerializer()

jsonDoc = GetPage(picUrl)
jsonResultsRelease = json.Deserialize[of Release](jsonDoc)
infoUrl = jsonResultsRelease.release

jsonResultsNodes = json.Deserialize[of Image](jsonDoc)

for i in jsonResultsNodes.images:
thumbnailUrl = i.thumbnails.small
#name = i.types[0]
name = mbidArtist + " - " + mbidRelease
pictureUrl = i.image
if i.front == true:
coverType = CoverType.Front
elif i.back == true:
coverType = CoverType.Back
else:
coverType = CoverType.Unknown
results.Add(thumbnailUrl, name, infoUrl, -1, -1, pictureUrl, coverType)
except e as System.Net.WebException:
results.EstimatedCount--
except e:
return
else:
#both Parameter album and artist are necessary
results.EstimatedCount = 0;


def RetrieveFullSizeImage(fullSizeCallbackParameter):
return fullSizeCallbackParameter;

class Image:
public images as (Images)

class Images:
public image as String
public thumbnails as Thumbnails
public types as List[String]
public front as bool
public back as bool

class Thumbnails:
public large as String
public small as String

class Release:
public release as String
Title: Album Art Downloader XUI
Post by: yeeeargh on 2012-11-26 21:35:21
Made the code a bit cleaner as I saw that I can get the respond from musicbrainz as json too. So there's no need for a json- and a xml-parser at the same time now.

Code: [Select]
# refs: System.Web.Extensions
import System.Collections.Generic
import System.Web.Script.Serialization
import AlbumArtDownloader.Scripts
import util

class Musicbrainz(AlbumArtDownloader.Scripts.IScript):
Name as string:
get: return "Musicbrainz"
Author as string:
get: return "Sebastian Hauser"
Version as string:
get: return "0.3"

def Search(artist as string, album as string, results as IScriptResults):
artist = StripCharacters("&.'\";:?!", artist)
album = StripCharacters("&.'\";:?!", album)

if(artist!= null and album!=null):
mbidBaseUrl = "http://search.musicbrainz.org/ws/2/release/"

#mbidUrl = "${mbidBaseUrl}?fmt=json&query=release:" + EncodeUrl("\"" + dummy + "\" AND artist:\"" + portishead + "\"")
mbidUrl = "${mbidBaseUrl}?fmt=json&query=release:" + EncodeUrl("\"" + album + "\" AND artist:\"" + artist + "\"")

picBaseUrl = "http://coverartarchive.org/release"

scoreThreshold = 70

json = JavaScriptSerializer()

try:
mbidDoc = GetPage(mbidUrl)
mbidResult = json.DeserializeObject(mbidDoc) as Dictionary[of string, object]

results.EstimatedCount = mbidResult["release-list"]["count"]

for release as Dictionary[of string, object] in mbidResult["release-list"]["release"]:
mbid = release["id"]
mbidArtist = release["artist-credit"]["name-credit"][0]["artist"]["name"]
mbidTitle = release["title"]
mbidScore = Convert.ToInt32(release["score"])

if mbidScore > scoreThreshold:
try:
#picUrl = "${picBaseUrl}/76df3287-6cda-33eb-8e9a-044b5e15ffdd"
picUrl = "${picBaseUrl}/${mbid}"

picDoc = GetPage(picUrl)
picResult = json.DeserializeObject(picDoc) as Dictionary[of string, object]

infoUrl = picResult["release"]

for image as Dictionary[of string, object] in picResult["images"]:
thumbnailUrl = image["thumbnails"]["small"]
name = mbidArtist + " - " + mbidTitle
pictureUrl = image["image"]
if image["front"] == true:
coverType = CoverType.Front
elif image["back"] == true:
coverType = CoverType.Back
else:
coverType = CoverType.Unknown
results.Add(thumbnailUrl, name, infoUrl, -1, -1, pictureUrl, coverType)

except e as System.Net.WebException:
results.EstimatedCount--

except e:
return
else:
#both Parameter album and artist are necessary
results.EstimatedCount = 0;


def RetrieveFullSizeImage(fullSizeCallbackParameter):
return fullSizeCallbackParameter;
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-11-27 08:29:42
Great, that does look nicer, and having the artist and title as the result name is a lot better. I've uploaded the updated script musicbrainz.boo (http://album-art.sourceforge.net/scripts/musicbrainz.boo), and it should show up in the "Get more scripts" list now. It will be included in the installer the next time one is built (for the next release).

Thanks again!

Alex
Title: Album Art Downloader XUI
Post by: 42Andreas on 2012-12-03 11:49:04
Hi Alex,

google.boo-script is not working (for me?) in Album Art Downloader XUI (current 0.45). Script version ist 0.13 and thre is no newer version.
Somehow the script seems to find matches (upcounting numbers at the script-tab) but no thumbs are displayed.

I would guess that google changed something, because when I look in the script there "imgrefurl" is after "imgurl" in the regex and in the http-source this is imho the other way around. I tried to build my own regex but I did not suceed. Too basis regex-knwoledge / no dev-environment....

A working google-scipt would be nice since it has the most matches for difficult covers...
Greeting from Germany
Andreas
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-12-03 19:46:39
google.boo-script is not working (for me?)
Hmm... I've just given it a try here and it seems to be still working fine. Are you sure you haven't got some filters applied that are hiding the results?

Alex
Title: Album Art Downloader XUI
Post by: 42Andreas on 2012-12-05 09:05:47
Hi Alex,

thanks for the really quick response and sorry, it was my fault. I installed album art half a year ago, tagged the first few folders and then first completed my htpc. And therefore forgot the filter settings in the application when resuming a few weeks ago. Cover were filtered as only "front" excluding "unknown". And all google-founds are "unkown"....

But know I know more aboutt boo-scipts, regex,.. ;-)

Again thanks for the support and good / best working cover-tool!
Andreas
Title: Album Art Downloader XUI
Post by: SigHunter on 2012-12-25 14:01:43
I don't know if this has been answered in the 90 pages before, if so I'm sorry.

When i scan folders with the file browser and it finds embedded album art,
the file browser just shows the first file in that directory (since its just a twodimensional list).

does it still look for all files in that directory or does it stop after it found embedded albumart in the first file?
what happens if the first 5 files have album art and the next 20 in the same directory don't?
(all belonging to the same album)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-12-26 08:35:51
does it still look for all files in that directory or does it stop after it found embedded albumart in the first file?
what happens if the first 5 files have album art and the next 20 in the same directory don't?
(all belonging to the same album)

The file browser doesn't search the directory for embedded album art, no. If you have it set to use ID3 tags to get album information then when it reads the tags in a file to get the artist and album title, it will also get the embedded art tag if present. Once an album has been added to the list, no further instances of that album will be added, there's only one entry per album in the list. So, it is only the first file belonging to any given album that matters whether it has album art or not, the others won't make any difference.

Album Art Downloader deals with artwork on a per-album basis. It is not a tool for tag-management; ensuring that all your embedded art tags are consistent with the cover art file for that album is a job for a tag-management or library software, such as Mp3Tag (http://www.mp3tag.de/download.html). g.p.m. wrote a nice guide about it earlier: [a href='index.php?act=findpost&pid=740568']Using Album Art Downloader XUI with MediaMonkey[/a]
Title: Album Art Downloader XUI
Post by: Kuangmk11 on 2012-12-27 06:07:17
I am having a problem with AAD all of a sudden.  I have been using AAD for years without a hitch and now when I start it up I get a blank "Album Art Downloader" window and a blank "check for updates window" that just sit there using 25% cpu (1 core pegged) and ~35 MB ram.  they can be closed normally.  I don't see anything in event viewer.  PC is win 7 ult 64,  amd phenom quad core 3.4 with 8 GB ram.  I have tried re-installing .45 .44 and .43 with the same results.  I am guessing this is a dot net problem of some kind.  I did a fresh install a couple weeks ago but I am pretty sure AAD was working after that.  I used the dot net verifier from here: http://blogs.msdn.com/b/astebner/archive/2...13/8999004.aspx (http://blogs.msdn.com/b/astebner/archive/2008/10/13/8999004.aspx)
It didn't find any problems.  Any Ideas?

EDIT:  After using AAD on my laptop I just wanted to note that it does not go through any of the splash screen and script compilation stages,  it just goes straight to the blank window.  I also did a "sfc /scannow" and it didn't find anything.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-12-27 09:44:12
I am having a problem with AAD all of a sudden.

That's a weird one, I'm not sure what's going on there. One thing that might be worth trying is resetting the AAD settings by deleting the folder: %LOCALAPPDATA%\AlbumArtDownloader

Alex
Title: Album Art Downloader XUI
Post by: Kuangmk11 on 2012-12-27 17:07:05
I am having a problem with AAD all of a sudden.

That's a weird one, I'm not sure what's going on there. One thing that might be worth trying is resetting the AAD settings by deleting the folder: %LOCALAPPDATA%\AlbumArtDownloader

Alex


Thanks for the reply Alex.  I have deleted the user folder a couple of times without much effect.  It does get recreated when I try to start AAD.  I also tried AAD under a fresh user and with windows services set back to default.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-12-27 19:12:17
Thanks for the reply Alex.  I have deleted the user folder a couple of times without much effect.  It does get recreated when I try to start AAD.  I also tried AAD under a fresh user and with windows services set back to default.

Hmm. After deleting that folder, it should show the splash screen as it recompiles all the scripts again - are you saying it goes straight to the blank search window and update window even with no user data folder? That shouldn't be possible as the code to show the main window only runs after the code to compile the scripts, so either it's looking for and finding its user data folder with the cached compiled scripts and settings somewhere else (no clue how, though!), or it is compiling the scripts, but the splash screen window is invisible. If you check in %LOCALAPPDATA%\AlbumArtDownloader\AlbumArt.exe_Url_<random string>\0.45.0.0\Scripts for a file called boo script cache.dll, that would indicate that it had successfully compiled the scripts.

One test you can do is to run "AlbumArt.exe /?" so that it pops up the command line help window instead of trying to show the main search window or anything. If it can't even show that (which is just a text box in a window), then we know that there isn't likely to be anything wrong with Album Art Downloader itself.

If it can show that window, then from your description it sounds like it may be stalling during the process of checking for updates (as that window was displayed). Interestingly, that window should only be shown at all at startup after it's downloaded and parsed the updates.xml, and only if there is a new version. So if you had v0.45 installed I don't really understand why that window would have been displayed, even blank...

It might be useful to see if other .net applications work, for example Paint .NET (http://getpaint.net) or blu (http://2010.thirteen23.com/experiences/desktop/blu/) (which is also uses WPF like Album Art Downloader does). If either of those don't work either, then something is definitely wrong with your .NET installation. Probably not much that can be done to fix that, although re-installing it might potentially help (On Windows 7: Add/Remove, Turn Windows Features On or Off, then checking or unchecking "Microsoft .NET Framework 3.5.1")

Alex
Title: Album Art Downloader XUI
Post by: Kuangmk11 on 2012-12-27 20:37:40
I do have "%LOCALAPPDATA%\AlbumArtDownloader\AlbumArt.exe_Url_<random string>\0.45.0.0\Scripts\boo script cache.dll"  it is 68k
If I delete the AlbumArtDownloader folder and restart AAD I get a pause and the folder and script is recreated.  I get no Splash/compiling popup.  the I get the blank "Album Art Downloader" window.  see here:
https://picasaweb.google.com/lh/photo/Q21OH...feat=directlink (https://picasaweb.google.com/lh/photo/Q21OHkO5JyYBO5nVH-ktMX_UEDqWZQkax9ItQPublX4?feat=directlink)

I only get the update window on the first run after I delete the AlbumArtDownloader AppData folder

Paint.net works fine (I used it to create that screenshot)
blu does not work.  The app starts and shows in the taskbar but there is no window
running "AlbumArt.exe /?" creates another blank window titled "Album Art Downloader Command Line Parameters"
I have unchecked/reboot/recheck/reboot the dot net 3.5 sp1 in windows features

I just searched for WPF apps not running and someone suggested video drivers.
http://social.msdn.microsoft.com/Forums/en...69-d8313ff30c35 (http://social.msdn.microsoft.com/Forums/en-US/wpf/thread/a9359bef-818e-45c4-9869-d8313ff30c35)
the latest ati drivers are broken for crossfire (dual video card setups) and cause windows explorer to crash over and over.  I have a workaround for this which is to use a different atiumd64.dll than is installed by ATI's dot net 4.0 installer.  see this thread:
http://forums.guru3d.com/showthread.php?t=370721 (http://forums.guru3d.com/showthread.php?t=370721)

I am going to try the older 12.7 drivers now
Title: Album Art Downloader XUI
Post by: Kuangmk11 on 2012-12-27 21:03:15
I do have "%LOCALAPPDATA%\AlbumArtDownloader\AlbumArt.exe_Url_<random string>\0.45.0.0\Scripts\boo script cache.dll"  it is 68k
If I delete the AlbumArtDownloader folder and restart AAD I get a pause and the folder and script is recreated.  I get no Splash/compiling popup.  the I get the blank "Album Art Downloader" window.  see here:
https://picasaweb.google.com/lh/photo/Q21OH...feat=directlink (https://picasaweb.google.com/lh/photo/Q21OHkO5JyYBO5nVH-ktMX_UEDqWZQkax9ItQPublX4?feat=directlink)

I only get the update window on the first run after I delete the AlbumArtDownloader AppData folder

Paint.net works fine (I used it to create that screenshot)
blu does not work.  The app starts and shows in the taskbar but there is no window
running "AlbumArt.exe /?" creates another blank window titled "Album Art Downloader Command Line Parameters"
I have unchecked/reboot/recheck/reboot the dot net 3.5 sp1 in windows features

I just searched for WPF apps not running and someone suggested video drivers.
http://social.msdn.microsoft.com/Forums/en...69-d8313ff30c35 (http://social.msdn.microsoft.com/Forums/en-US/wpf/thread/a9359bef-818e-45c4-9869-d8313ff30c35)
the latest ati drivers are broken for crossfire (dual video card setups) and cause windows explorer to crash over and over.  I have a workaround for this which is to use a different atiumd64.dll than is installed by ATI's dot net 4.0 installer.  see this thread:
http://forums.guru3d.com/showthread.php?t=370721 (http://forums.guru3d.com/showthread.php?t=370721)

I am going to try the older 12.7 drivers now


The older drivers fixed it!  Thanks Alex for putting me on the right track!  AAD is great!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2012-12-28 08:17:15
The older drivers fixed it!  Thanks Alex for putting me on the right track!  AAD is great!

Oh, well done figuring it out! And thanks for reporting back, it might help anyone else who has the same problem and finds these posts.

Alex
Title: Album Art Downloader XUI
Post by: bhome83 on 2013-01-01 09:32:35
Question for your guys:

I followed the directions on this page:

http://sourceforge.net/apps/mediawiki/a (http://sourceforge.net/apps/mediawiki/a) ... ediaMonkey

and all that happens when I right click on a song and go to tools->albumart is I get a popup textbox titled "Album Art Downloader Command Line Parameters'

Any idea what I'm doing wrong? I filled in all the blanks that were shown on that website but still having this problem.
If I leave the 'parameters' field empty, album art downloader will open but 'artist' and 'album' field aren't populated.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-01-01 13:02:32
Any idea what I'm doing wrong?
The parameters are wrong. I'm not sure exactly what you've got wrong about them, but if you look at the first line of the "Album Art Downloader Command Line Parameters" window that opens, it should say something like:

>albumart.exe  /artist "the artist name" /album "the album name" /path "a path to a .jpg file"

Of course, it will be a bit different from that, as that would be a valid set of parameters and would therefore just work without showing that window! By comparing what you see with what it ought to be, you can figure out what's not right about them, I hope. Just below that there will be a line giving the version number, then probably an error message surrounded by **** which might give you another clue.

Alex
Title: Album Art Downloader XUI
Post by: bhome83 on 2013-01-01 19:08:16
so I have this being shown, yet still not sure what exactly 'only the first three paramters may be un-named' means and what I'm supposed to put in  the 'paramters' box.

>"C:\Program Files\AlbumArtDownloader\AlbumArt.exe"  /artist "2mex" /album "Old World Chaos Feat Dilated Peoples EP" /path ""\\BMSERVER\MuZic\Artist Albums\VA-Old_World_Chaos_Feat_Dilated_Peoples-EP-1996-CMS\Old World Chaos Feat Dilated Peoples EP.jpg"

Album Art Downloader XUI version 0.45.0.0

**** Only the first three parameters may be un-named ****
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-01-01 19:30:39
so I have this being shown

Seems to me you've got an extra " where it doesn't belong, just after /path.

It looks like you have:
/artist "%a" /album "%l" /path ""%p\%l.jpg"

where it should be:
/artist "%a" /album "%l" /path "%p\%l.jpg"

Alex
Title: Album Art Downloader XUI
Post by: bhome83 on 2013-01-02 03:34:24
for it to work so album art downloader would open had to get rid of both " after /path so it looks like this:
/artist "%a" /album "%l" /path %p\%l.jpg"

The only problem now though is that when I save an image I find it doesn't show up as album art in mediamonkey.

For instance when I save an image it downloads it here:

\\BMSERVER\MuZic\Artist Various Songs\Duran Duran - Decade - FLAC\Decade.jpg

How would I get the image to a) show up in media monkey and b) be imbedded in the music file?

thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-01-02 08:45:21
had to get rid of both " after /path so it looks like this:
/artist "%a" /album "%l" /path %p\%l.jpg"

Wow, that's weird. I guess MediaMonkey is adding a " to the start of the path it uses for %p... but not one at the end? Strange. Oh well, if it works, it works.

I don't know MediaMonkey that well, but I believe that you would need to tell it where to look for the album art files, somewhere in the Options dialog? If not, then you could try asking on their forums. For embedding art, try the Album Art Tagger (http://trixmoto.net/mm/scripts.php?id=1) MediaMonkey script by Trixmoto.

Alex
Title: Album Art Downloader XUI
Post by: nikolai4ik on 2013-01-18 18:20:03
How do I make -ae parameter work? Also, is it possible to save two files at once (folder, front)?
My current script is \AlbumArt.exe /ar "%artist%" /al "%album%" /p "$replace(%path%,%filename_ext%,)front.%%extension%%

Is it possible to make filebrowser automatically close with AAD?
Title: Album Art Downloader XUI
Post by: BlackTornado on 2013-01-26 13:18:00
Hello everybody

I'm a happy user of album art downloader since a while, but I recently upgraded to Windows 8.
Everything is working more or less the same, except one thing: the startup time.

When I start AAD on Windows 8, it takes almost 10 seconds to start (on a computer with i7 and SSD), and this is much more that what it used to take under 7.

I guess the issue is related to the .NET framework (Windows is somehow starting stuff related to .NET 3.5 together with AAD and this takes a while).
Is someone else having the same problem? Can you suggest any workaround?
Title: Album Art Downloader XUI
Post by: SigHunter on 2013-01-26 13:19:39
Hello everybody

I'm a happy user of album art downloader since a while, but I recently upgraded to Windows 8.
Everything is working more or less the same, except one thing: the startup time.

When I start AAD on Windows 8, it takes almost 10 seconds to start (on a computer with i7 and SSD), and this is much more that what it used to take under 7.

I guess the issue is related to the .NET framework (Windows is somehow starting stuff related to .NET 3.5 together with AAD and this takes a while).
Is someone else having the same problem? Can you suggest any workaround?


i just can say that this is not a general issue, im using windows 8 + ssd (vertex 4) and AAD startup is about ~2-3 seconds
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-01-30 15:07:48

There isn't really an "-ae" parameter. For backwards compatibility with a previous album art downloading utility, you can use "/ae off" to mean the same thing as "/exclude Local Files", which is the command line equivalent of unchecking the "Local Files" source in the sources list using the UI.

I'm afraid it is not possible to automatically save two copies of the art at once with a single click, no. You might be able to use the Presets system so you could have two options in the drop down menu, one for front and one for folder, but you would still have to save it twice manually, once for each preset.

If you want to exit AAD, you can use the File/Exit menu command. This will close all windows (including the file browser) immediately.

When I start AAD on Windows 8, it takes almost 10 seconds to start (on a computer with i7 and SSD), and this is much more that what it used to take under 7.
That's weird. 10 seconds is a long time for an SSD, if it isn't compiling the scripts... are you seeing the splash screen while it's loading? Is it the same every time you start it, or only the first time since restarting the computer? Can you try starting it with the parameter "/?" and see whether it can display the command line parameters help window quickly, or if that also takes a long time before it is shown?

I don't have Windows 8, so I can't say for certain whether there is any difference in behaviour there, but from what I've read it shouldn't have any difficulty in running .net 3.5 applications, in Desktop mode.

Alex
Title: Album Art Downloader XUI
Post by: BlackTornado on 2013-01-30 18:24:07

There isn't really an "-ae" parameter. For backwards compatibility with a previous album art downloading utility, you can use "/ae off" to mean the same thing as "/exclude Local Files", which is the command line equivalent of unchecking the "Local Files" source in the sources list using the UI.

I'm afraid it is not possible to automatically save two copies of the art at once with a single click, no. You might be able to use the Presets system so you could have two options in the drop down menu, one for front and one for folder, but you would still have to save it twice manually, once for each preset.

If you want to exit AAD, you can use the File/Exit menu command. This will close all windows (including the file browser) immediately.

When I start AAD on Windows 8, it takes almost 10 seconds to start (on a computer with i7 and SSD), and this is much more that what it used to take under 7.
That's weird. 10 seconds is a long time for an SSD, if it isn't compiling the scripts... are you seeing the splash screen while it's loading? Is it the same every time you start it, or only the first time since restarting the computer? Can you try starting it with the parameter "/?" and see whether it can display the command line parameters help window quickly, or if that also takes a long time before it is shown?

I don't have Windows 8, so I can't say for certain whether there is any difference in behaviour there, but from what I've read it shouldn't have any difficulty in running .net 3.5 applications, in Desktop mode.

Alex


Ok, the situation seems improved quite a little now... Instead of almost 10 second, now they became about 3... I still have the feeling that it is a little bit slower than on 7, but 3 seconds are ok...
Anyway, no splash screen is shown, and the loading time looks to me about the same the first time I open AAD after a restart...
With the /? parameter, the help window is visualized after one second, more or less, so I guess it's ok...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-01-31 07:56:19
Ok, the situation seems improved quite a little now... Instead of almost 10 second, now they became about 3... I still have the feeling that it is a little bit slower than on 7, but 3 seconds are ok...
Anyway, no splash screen is shown, and the loading time looks to me about the same the first time I open AAD after a restart...
With the /? parameter, the help window is visualized after one second, more or less, so I guess it's ok...

Thanks for letting me know. I agree 3 seconds still sounds long for an SSD, but given that it isn't showing a splash screen, and that the help window is fast (so it can't be time spent by Windows initiating the .net CLR or anything), then I don't think anything is wrong with AAD or .net.

The only things I can think of that can potentially make a difference would be if you had a different virus scanner on 8 than you had on 7, and it's causing an impact. Or, different graphics drivers might also have an effect (as it's a WPF application, graphics drivers can actually make a significant difference, weirdly).

Alex
Title: Album Art Downloader XUI
Post by: mire777 on 2013-03-19 18:47:12
Really good program but there is no possibility to save cover in mp3.  So I set this program to download cover in folder, with extension %artist% , then i run Mp3tag program, and with one clik i put cover in mp3. It would be good to add this possibility there. I don't want to use another program for that, but i must?  Thank's
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-03-20 08:25:12
Really good program but there is no possibility to save cover in mp3.

It wouldn't be too hard to add the ability to save a cover embedded into an mp3 file, but the problem is that is not actually very useful. What you actually want is for the cover to be embedded in all the mp3 files in an album. That's a completely different sort of task. To do that, you need library management software suitable for organising your mp3s into albums and performing operations on them to ensure that all their tags are correct. Embedding the album artwork into all the mp3s in an album is the same class of task as making sure that they all have the same Artist and Album tag, for example.

I could probably write a library management application, and if I did, I would give it a button to have it execute Album Art Downloader to search for artwork for an album before then using that as the cover art for the mp3s in that album. I really don't see the need, though, there are already perfectly good library management applications around, like Mp3Tag that you mentioned, and they are quite capable of both executing Album Art Downloader to search for artwork, and of embedding the found artwork in mp3 files. There's even a helpful guide on how to do it in a post by g.p.m. ([a href='index.php?act=findpost&pid=740568']here[/a]).

Alex
Title: Album Art Downloader XUI
Post by: mire777 on 2013-03-20 12:55:58
Thanks. I'm just saying it would be good that everything be in one application. Your idea of ​​a library management would be great, then library can execute Album Art Downloader to search for artwork, and add the found artwork in mp3 files.  Of course this is not necessary if MP3Tag can do this,but it would be practically if you connect that two application in one. However, thank you for make this great app
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-04-11 05:10:18
Using the forum tools I can't figure out if I already asked this... if so I apologize (my search-foo is weak tonight)

Is there a way that we could get the ability to search for a dynamic minimum size instead of a static minimum size?

Right now I can filter on "Minimum Size: 800" but what I really want is to filter on "Minimum Size: Bigger Than What I Have Now". For example, if I have something local that is 100x100 then either 300x300 or 500x500 would be an improvement but if I already have 400x400 then only the 500x500 would be an improvement. (Nothing local should be treated as anything larger than 0x0 of course.)

Thanks!

Matt

P.S. I know size isn't always an indicator of quality but this would still make it easier for me. I also realize I can do this by running through multiple times changing the minimum size but that's tedious.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-04-13 09:41:21

Hello, thanks for your suggestion. No, I don't think it's been raised before, and I've added a feature request for it to the tracker: https://sourceforge.net/p/album-art/feature-requests/102/ (https://sourceforge.net/p/album-art/feature-requests/102/)

I didn't understand what you meant by "Nothing local should be treated as anything larger than 0x0 of course." though. Do you mean you wouldn't want to see any of the local results? I would have thought that it would be helpful to see them, so that you know which images it's taking as the basis for filtering against. That way if you see a large image there but that's of the wrong album (for whatever reason), or that's obviously low quality despite being large, you know that you need to turn off the filter for that search.

Alex
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-04-13 21:19:36
I didn't understand what you meant by "Nothing local should be treated as anything larger than 0x0 of course." though.


I simply meant that if there was no local file present that it would be the same as "Show covers larger than a 0x0 image"...

Or to put it another way, no local file would effectively disable any size based filter and everything would show.

Sorry for the confusion.

Matt
Title: Album Art Downloader XUI
Post by: MC Escher on 2013-04-18 13:46:25
I know I've reported random crashes on my system before, but the crash I got today seems to be different so hopefully this one can be solved.
This is the errorlog:
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: D:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.45.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.IO.FileFormatException: De beelddecoder kan de afbeelding niet decoderen. De afbeelding is mogelijk beschadigd. ---> System.Runtime.InteropServices.COMException (0x88982F60): Uitzondering van HRESULT: 0x88982F60
  --- Einde van intern uitzonderingsstackpad ---
  bij MS.Internal.HRESULT.Check(Int32 hr)
  bij System.Windows.Media.Imaging.BitmapSource.get_DUCECompatibleMILPtr()
  bij System.Windows.Media.Imaging.BitmapSource.UpdateBitmapSourceResource(Channel channel, Boolean skipOnChannelCheck)
  bij System.Windows.Media.Imaging.BitmapSource.AddRefOnChannelCore(Channel channel)
  bij System.Windows.Media.Imaging.BitmapSource.System.Windows.Media.Composition.DUCE.IResource.AddRefOnCh
annel(Channel channel)
  bij System.Windows.Media.RenderData.System.Windows.Media.Composition.DUCE.IResource.AddRefOnChannel(Chan
nel channel)
  bij System.Windows.UIElement.RenderContent(RenderContext ctx, Boolean isOnChannel)
  bij System.Windows.Media.Visual.UpdateContent(RenderContext ctx, VisualProxyFlags flags, Boolean isOnChannel)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  bij System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  bij System.Windows.Media.Visual.Render(RenderContext ctx, UInt32 childIndex)
  bij System.Windows.Media.CompositionTarget.Compile(Channel channel)
  bij System.Windows.Media.CompositionTarget.System.Windows.Media.ICompositionTarget.Render(Boolean inResize, Channel channel)
  bij System.Windows.Media.MediaContext.Render(ICompositionTarget resizedCompositionTarget)
  bij System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
  bij System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
  bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bij System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bij System.Threading.ExecutionContext.runTryCode(Object userData)
  bij System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bij System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bij System.Windows.Threading.DispatcherOperation.Invoke()
  bij System.Windows.Threading.Dispatcher.ProcessQueue()
  bij System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bij MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bij MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bij System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bij System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bij System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bij MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bij MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bij System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  bij System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bij System.Windows.Application.RunInternal(Window window)
  bij AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bij AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bij AlbumArtDownloader.App.Main(String[] args)
It complains that it can't decode one of the found images. I was searching for "Slow Motion" by "J Majik".
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-04-18 14:03:59
Hello, thanks for reporting that. Looking up the error, I find it is "WINCODEC_ERR_BADIMAGE", which means that the image Windows was trying to display was corrupt in some way. What I can try and do is put in some sort of code to check for bad images and not try and display them, so it won't crash (it will just not show that image), but I'm not sure in exactly what way the image was 'bad'. There is already code that checks that the data is actually image data, so it isn't enough to just check that it was a valid image file that was returned.

Can you tell me which source you searched that returned that result? I ran a search for "Slow Motion" by "J Majik" across the default set of sources, but it didn't reproduce the error. I assume it was on showing the thumbnail that the error occurred? Or do you have auto-download of full size images enabled?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: MC Escher on 2013-04-18 17:41:19
It seems to happen when downloading a full-size image from HMV Canada or Discogs (but only for this release). So in the Discogs case, it should be this one here (http://www.discogs.com/J-Majik-Slow-Motion/master/56280). The crash also happens when saving the image without loading the full preview first.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-04-18 20:02:43
it should be this one here (http://www.discogs.com/J-Majik-Slow-Motion/master/56280)

That's great, thanks. There's definitely something wrong with that image file, if I download it and try and view it just using Windows Image Viewer it can't load it either. I'll fix up something so that AAD at least doesn't crash when it encounters one, though.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-04-20 09:36:11
Version 0.46
This version adds a requested option to the Local Files source to automatically set the minimum image size filter equal to the largest image found by this source. To use it, click ... in the Local Files Source then check the box in the options there. With this option turned on, whenever the Local Files source finds results, it turns on the Minimum Size filter with the minimum size set to be that of the largest result that it found. This means that you will only see the largest local file result, and any online results that are equal to or larger than that one. It's off by default, so if you don't want this behaviour, then you don't need to do anything.

I've also added additional protection against the sorts of bad image files reported by MC Escher. It now tests to see if it can fully read the downloaded data as an image before attempting to display it, so it won't crash out trying to display a broken image file any more.

Scripts have been brought up to date, including those that have been created since the last release (The Classical Shop, Hyperion Records, MusicBrainz)

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.46.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-0.46.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: MC Escher on 2013-04-20 09:48:17
Thank you for the fast update. The crash no longer occurs.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-04-21 20:32:29
The minimum size filter works perfectly for me! Thanks!
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-04-21 22:15:07
For what I'm doing (looking for cover art "upgrades") the local minimum size filter actually makes it much faster and I've noticed something else... (and again, thanks for that! It really is wonderful!)

While waiting for responses from the various sources AAD does the "Windows 7 Taskbar Progress Meter" thing. (Not sure if that has a real name) BUT it doesn't look like the AAD Windows Taskbar Progress Meter doesn't take into account loading full size images. So when the taskbar progress meter is done there might still be a wait as things load. I would love it if the taskbar progress measured "total completeness".

That said, thanks again! I can't say enough how easy AAD makes it to improve my cover art collection!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-04-22 08:22:25
I would love it if the taskbar progress measured "total completeness".

Thanks for your comments! For the progress bar, I assume you mean if you have AAD set to always download full images? The reason this isn't in the main progress bar is that it happens in the background, while the search is still going on. I'll consider having some sort of combined progress when I next do an update, but I'm not entirely convinced - as it is, the progress bar tells you when it's finished searching which would usually be the point you want to start looking at the results.

Anyway, what you might want to try is using the "Always download full size" checkbox for the sources you use, rather than the background automatic full image downloading. That way the source won't bother with a thumbnail and just go straight for the full size image, so when the progress bar reports search completion, it will be the full size image that's available.

Alex
Title: Album Art Downloader XUI
Post by: lvqcl on 2013-04-22 09:24:14
AAD 0.46 wants to downgrade some scripts when I check for updates.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-04-22 10:10:34
AAD 0.46 wants to downgrade some scripts when I check for updates.

Oops! Forgot to update the Updates.xml (http://album-art.sourceforge.net/Updates.xml)... Should be fixed now, thanks for reporting!

Alex
Title: Album Art Downloader XUI
Post by: tuxman on 2013-04-22 22:34:30
Thanks for keeping AAD up-to-date!

@benjy31: Yes it is.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-04-22 23:00:00
Anyway, what you might want to try is using the "Always download full size" checkbox for the sources you use, rather than the background automatic full image downloading. That way the source won't bother with a thumbnail and just go straight for the full size image, so when the progress bar reports search completion, it will be the full size image that's available.


So... to make sure I understand.

If I check "Always" for "Automatically download full-size images" in the main options box that is when it will do it in the background AFTER it downloads the thumbnail from the source.

If however, I use the "Always download full size" on the source itself them it won't bother to download a thumbnail at all and will go straight to the full size image.

I assumed that doing the first was a shortcut for doing the second on all sources.

Can you confirm that I understand?  Thanks!

Matt
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-04-23 07:54:40
Can you confirm that I understand?  Thanks!

Yes, you've got it. Now that you put it like that, I can see why it could be confusing. I might see if I can come up with some better wording for the UI, or at least some explanatory tooltips...

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-06 17:50:24
Alex, great program and I haven't thank you for your hard work in some time. Just started using it again and have a couple of requests:

- Option to always display current artwork at the top: Helpful when trying to update low resolution artwork

- Fanart.tv search script

Thanks again!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-06 18:11:35
I had a look at fanart.tv, thanks for the suggestion. Unless I'm missing something, though, there doesn't actually appear to be any way of searching for an album on it... the only thing I can do is search for an artist or a label. I can't find an Advanced Search or anything like that, and even if I could use the API (which I can't, as it needs a key), the API doesn't have any search function either!

For your other request, if you want to keep existing artwork available for comparison, then the best way to do it is to right click on it and choose "Preview". This will open another window showing that artwork that you can leave open while you look at other results.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-06 20:05:13
Regarding fanart.tv, a modified google search would probably suffice, simply adding either fanart.tv or site:fanart.tv to the google search search. This is what I do manually.


For your other request, if you want to keep existing artwork available for comparison, then the best way to do it is to right click on it and choose "Preview". This will open another window showing that artwork that you can leave open while you look at other results.

Alex


Typically what I am trying to do is update art, that I have at lower resolution. Usually this doesn't show up because I have the limits set to not show results (including local search) below a certain level, and even if it did show it ends up buried with the other results at the bottom.

I would like to have it listed at the top as "Current Album Art" or something like that.


Also, is there a repository for older versions of AAD. I found back to .4 on SF but am looking for some older version.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-06 20:33:22

Hi, thanks for the further detail about your suggestion. I take your point about the filters ruling out your local sources, I can see why it might be useful to make those always show and ignore the filter settings. The best I can offer at the moment is if you set the Local Files Source as "Search First", then you can click Search once, click the button to toggle filters off, preview the image you want, then click Search a second time (it will now say Extend Search) to get all your other results. You can then toggle the filters back on. Not ideal, I know, but it might help.

You might also like to take a look at the system mneimeyer (http://www.hydrogenaudio.org/forums/index.php?act=findpost&pid=830817) suggested earlier, that was implemented for 0.46: To use it, click ... in the Local Files Source then check the box in the options there. With this option turned on, whenever the Local Files source finds results, it turns on the Minimum Size filter with the minimum size set to be that of the largest result that it found. This means that you will only see the largest local file result, and any online results that are equal to or larger than that one.

Regarding the custom Google search, I'm afraid I've found out the hard way that these don't work well. The problem is if you have multiple sources all searching Google then you trigger their bot-detection algorithms, and they all stop working. So far, with just a single source searching Google it works OK, so I'm sticking with the generic Google search and not producing any custom ones. I'm happy to write scripts for new and interesting sites, but they do have to have their own search engines producing useful results.

For older versions of AAD, take a look in /album-art-xui/Older/ (https://sourceforge.net/projects/album-art/files/album-art-xui/Older/) in the sourceforge page, pretty much all of them are there, back to about 0.7.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-07 00:57:21
Instead of doing a second custom Google search could you do a bing search?

Another feature suggestion. On the save menu, add an option to rename existing art to folder(x).jpg, and save new item as folder.jpg


Also, how is the album art categorized? I have lots of albums with embedded artwork and folder.jpg. Usually the embedded art is smaller then the folder.jpg. So as I go through and update, I think I am updating albums with small artwork, and when I go to save the folder.jpg file, I find out I already have a large artwork there.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-07 08:10:49
Also, how is the album art categorized?

I'm not sure what you mean by categorized here. By default, the Local Files Source will search the path specified for saving the image file to see if there's already one there, and then search the same folder for any embedded images in any files. You can change this behaviour by editing the "Path to find images" box in the Local Files Source options. The default is %folder%\%filename%|%folder%\*<*> . The first part %folder%\%filename% instructs it to search for the target filename an image file would be saved to, and the second part, %folder%\*<*> instructs it to search the target folder for any files, and then any embedded image within each of those files. The <*> syntax is used to denote any embedded image within a file - you can also use a 0-based number to represent a specific image, so <0> would only return the first embedded image.

Once the results are shown in the list, you can choose to group either by Local, or by Source. In both cases, this will result in all the results from the Local Files Source being shown together in a group in the results. There is no further sub-grouping between embedded and non-embedded artwork, but you can tell by looking at the name of the result whether it was embedded or not.

Alex
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-05-07 09:24:35
Also, how is the album art categorized?

I'm not sure what you mean by categorized here.


I think I've run into what I think he means.

When you do your initial scan the column "Artwork Status" has something like "Found: Folder.jpg" but when there is embedded art it says something like "Found: track.mp3<1>" and the Dimensions (and Size?) column reflects that embedded artwork. So you don't know you have "physical" artwork just the embedded.

If this is what he means, then I agree, I was also never sure which AAD looked at first/last etc. (I personally remove all embedded artwork though...)

Also, in testing this I remembered you can't sort by the Artwork Status column beyond the Found. For example my test files are sorted:

  Found: 01 - AAA Test Track A.mp3<0>
  Found: 03 - AAA Test Track C.flac<0>
  Found: Folder.jpg
  Found: 02 - AAA Test Track B.m4a<0>

And they stay that way no matter how I click the Artwork Status column header to change the sort ascending or descending. (I would use this personally to find the lone BMP, PNG or other odd file format.)

Thanks again! I can't speak highly enough of AAD! It makes my life SOOO much easier!

Matt

P.S. While I'm wishing... any chance of a plugin that would submit the largest local artwork to Google Image search for use with the Visually Similar search? Sometimes the results are clearly picking up words from the auther and title and yet have nothing to do with my album. But the 200x200 image I'm trying to find a bigger version of I can plug into Google Image search manually and what I'm looking for comes right up. Or would that run afoul of your multiple google plugins "rule"?
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-07 16:39:13



Alex, I thought that would be confusing, so let me try to explain better.

When launching File Browser, AAD searches by library and identifies which albums have art. It searches for folder.jpg as well as embedded art. Then it displays the results, I sort by small art and search to replace those with low resolution art.

However, often what happens is that AAD says the art is 250x250, since it has identified the album art, but when I go to replace the art with new art, I find that a higher resolution file already exists as folder.jpg.

Basically, when sorting, I want to always sort based on the highest resolution art available, so that I am not trying to update albums that already have high resolution artwork.


P.S. While I'm wishing... any chance of a plugin that would submit the largest local artwork to Google Image search for use with the Visually Similar search? Sometimes the results are clearly picking up words from the auther and title and yet have nothing to do with my album. But the 200x200 image I'm trying to find a bigger version of I can plug into Google Image search manually and what I'm looking for comes right up. Or would that run afoul of your multiple google plugins "rule"?


I think you could get around this by having the option to right click on any image and search by image using Google Image search


Album Art Exchange
On another note, I know you were asked to remove Album Art Exchange a few years ago. As a work around, would it be possible to launch a browser based search of AAE? They clearly have the best art work, and I would be happy to go to my browser to look, but if some of the process can be automated that would be fantastic!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-07 17:44:09
OK, I think I see where you both are coming from - I didn't get at first that you meant in the File Browser, Eli.

The way the File Browser works is that it will search for an image for the album, and as soon as it finds one, it stops looking. It was designed to find albums with no artwork, rather than to try and evaluate the quality of existing artwork. If you have it set to search using ID3 tags rather than a file path pattern, then as soon as it reads the tags of a file to determine artist and album, it will also read the image tag. If it finds one then that's it done for that album, it has artwork present, no more work required. If it didn't find one, or if you weren't using ID3 tag mode (so it won't have opened up the file to read tags at all - much quicker) then it queues up that album for searching for a matching external image file. That searching happens in a background thread while it continues to search for more albums. Once the search finds an image file matching the criteria for that album, then it stops looking too.

So, basically, the File browser isn't built to do what you want to do in providing a report on the best quality of artwork available for a given album. That's what the main search window is for, using the Local Files Source. That will keep searching and show you all the images available for the album, including all embedded artwork. You can then see what the highest resolution you have is, and check if there are any that are incorrect or poor quality for other reasons (bad scan, etc.). You could also use the Search First functionality to check out your local files before kicking off the internet search, as I described in a previous post.

At present, I don't intend to modify the File Browser to search all images for each result. If it ever were implemented, I would insist on it being an optional setting.

Google Visually Similar
This is interesting, but I'm struggling to see how it would fit in to AAD. Obviously it couldn't just be another Source, as those are searched by album and artist name. As, Eli suggests, you could have it as a right click command on an existing image that would launch a new search based just on that image, without searching other sources. It feels like a bit of a weird feature, though. In any case, given that Google seem to be quite protective of not offering an API for this, I'm not sure how practical the uploading of the existing image for searching would be. It be possible, I haven't tried it, but I wouldn't count on it!

I could add this as a feature request for the future.

Album Art Exchange
Sure, don't see why not. I can't think that they could object to having visitors pointed to their website in a browser. I won't be including it with the standard scripts as I don't think most AAD users would be happy with a browser window opening whenever they did a search, but if you are, have at it: album-art-exchange-browser-launcher.boo (http://album-art.sourceforge.net/scripts/album-art-exchange-browser-launcher.boo)

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-07 19:43:35
Google Visually Similar
This is interesting, but I'm struggling to see how it would fit in to AAD. Obviously it couldn't just be another Source, as those are searched by album and artist name. As, Eli suggests, you could have it as a right click command on an existing image that would launch a new search based just on that image, without searching other sources.
Alex


I think where this fits is on albums with vague names that give non-specific searches. If you have correct, but low resolution art, using google image search can be a very helpful way to see if you have find the same art at higher resolutions. I use it all the time.
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-07 22:50:13
I don't understand how I can use the regular search window to scan my entire library...

In the file broswer I would like to reformat the folder based search which is currently:

Code: [Select]
\%artist%\%album%\*


However, most of my library, while in the artist/album directory setup has additional unique identifiers after most, but not albums:

IE

Code: [Select]
Dinosaur Jr\You're Living All Over Me (10) (9A0BB60B)


where the first (XX) is the number of tracks, and the second (XXXXXXXX) is the CDDB ID. I do this so that if there are multiple versions of the same album they get unique folders. However, if i just use directory structure with the default code I get:

Artist:
Dinosaur Jr
Album:
You're Living All Over Me (10) (9A0BB60B)
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-08 01:16:00
Album Art Exchange
Sure, don't see why not. I can't think that they could object to having visitors pointed to their website in a browser. I won't be including it with the standard scripts as I don't think most AAD users would be happy with a browser window opening whenever they did a search, but if you are, have at it: album-art-exchange-browser-launcher.boo (http://album-art.sourceforge.net/scripts/album-art-exchange-browser-launcher.boo)

Alex


Alex, thanks for being so amazingly fast with this. Unfortunately, for me it doesn't seem to do anything. Is there something I can change on my system or in the script? Do I need to point it to my browser? When it works, any sense if there is a way to get it to do new tabs, or will it always launch a new window.

Thanks again!
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-08 01:51:12
Hello Alex,

My original statement was "I don't understand why AAD and similar programs are necessary to access the site[/u]." I understand the purpose of the program itself    I am with you on the front covers only, until a month ago, this has been our primary focus. As an experiment we have been adding select back covers (sans track lists) and sleeves because some are quite beautiful.

If there were some way to only call up the browser page while not allowing direct access, I would be alright with that. I would of course want it to call a detail or gallery page with the result(s) and not the page with the image itself . For example:

http://www.albumartexchange.com/covers.php?id=74171 (http://www.albumartexchange.com/covers.php?id=74171)
or
http://www.albumartexchange.com/covers.php...;bgc=&page= (http://www.albumartexchange.com/covers.php?sort=4&q=Ray+Brown+%26+Jimmy+Rowles+tasty&fltr=1&bgc=&page=) 

and never this: http://www.albumartexchange.com/gallery/im...wn-tasty_02.jpg (http://www.albumartexchange.com/gallery/images/public/jb/jbrown-tasty_02.jpg)

Cheers,
Scott


Alex, in regard to AAX script it looks like Scott did indeed give a go ahead for this very idea a few years back with the above request of returning gallery results and not the full size images.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-08 08:22:11
I think where this fits is on albums with vague names that give non-specific searches. If you have correct, but low resolution art, using google image search can be a very helpful way to see if you have find the same art at higher resolutions. I use it all the time.
I've added a feature request (https://sourceforge.net/p/album-art/feature-requests/103/) for this.

most of my library, while in the artist/album directory setup has additional unique identifiers after most, but not albums:
How about: \%artist%\%album%"(?: \(\d+\) \([\dA-F]+\))?"\*

That should ignore the bit at the end of the album folder so long as: it starts with a space, has a number in brackets, followed by a space, followed by a hex code (digits 0-9, A-F) in brackets.

[AAX browser launcher] doesn't seem to do anything. Is there something I can change on my system or in the script? Do I need to point it to my browser? When it works, any sense if there is a way to get it to do new tabs, or will it always launch a new window.
Hmm. Does it show any error message? Does the script show up in your list of sources? Can you launch a browser window through other links, for example by clicking on the (i) link in a search result? What the script does is simply tell windows to launch the given URL, the same as if you'd done Start, Run and pasted in the URL, or used a URL shortcut file. It should launch the default browser, and that browser will handle it however it is configured to do. I think Firefox can be configured to open new urls in tabs rather than windows, but I don't know about other browsers.

Alex, in regard to AAX script it looks like Scott did indeed give a go ahead for this very idea a few years back with the above request of returning gallery results and not the full size images.
Ah, nice find, some good thread archaeology there! That's good to know.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-08 12:40:00
[AAX browser launcher] doesn't seem to do anything. Is there something I can change on my system or in the script?
Hmm. Does it show any error message? Does the script show up in your list of sources? Can you launch a browser window through other links, for example by clicking on the (i) link in a search result? What the script does is simply tell windows to launch the given URL, the same as if you'd done Start, Run and pasted in the URL, or used a URL shortcut file. It should launch the default browser, and that browser will handle it however it is configured to do. I think Firefox can be configured to open new urls in tabs rather than windows, but I don't know about other browsers.

Alex


Yes, the script shows up in my sources list.

No, clicking on the little (i) icons doesn't do anything on my system either.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-08 20:01:54
No, clicking on the little (i) icons doesn't do anything on my system either.

In that case, for some reason, AAD is unable to launch your browser. There are two possible reasons I can think of for this. One is that you do not have a default browser registered. It's a bit weird, but certainly possible - perhaps you un-installed a browser that used to be the default, and an existing browser wasn't re-set as the default. If you go to "Default Programs" from your start menu or control panel, then choose "Associate a file type or protocol with a specific program", and look near the bottom of that list for "HTTP", then see if it says it's associated with any browser or not. You could probably also do "Set program access and computer defaults" and "Choose a default web browser", but I'm not sure exactly how that works, or what it would show if none were currently default.

Anyway, if you are sure that you do have a default browser (you could also try Start, Run, then enter "http://www.example.com" or similar and see if that brings up a browser window), then something is actively preventing AAD from launching it. That would probably be some over-zealous security or protection software, usually bundled with an antivirus suite, that thinks allowing programs to launch web browsers is too risky and should be prevented.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-08 21:39:35
OK, got it working! You rock Alex!

Now I have another feature request ;-)

The ability to drag and drop a picture into the AAD window. Since AAX is launched in the browser, I now need an efficient way to get the art to the correct folder. The easiest way to do that would be to be able to drag the art to AAD and save from there.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-05-09 10:31:58
OK, got it working! You rock Alex!


I know he's my favorite developer right now!

Now I have another feature request ;-)

The ability to drag and drop a picture into the AAD window. Since AAX is launched in the browser, I now need an efficient way to get the art to the correct folder. The easiest way to do that would be to be able to drag the art to AAD and save from there.


Actually... Do the boo scripts have a variable that contains the local path to the tracks?

IOW, looking at the Album Art Exchange boo you just made it looks like ${artist} contains artist and ${album} contains the album (duh?  ) Is there a similar ${path} or ${folder} or some other variable?

If so, I assume adding something like "System.Diagnostics.Process.Start(${path})" near the other call with the URL would also open the location of the local files. (Heck if you are opening one window why not two!)

Matt
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-09 18:37:08
The ability to drag and drop a picture into the AAD window.

Do the boo scripts have a variable that contains the local path to the tracks?

Thanks for the nice comments, both of you! I'm afraid the path to the tracks is not passed to the scripts, only search terms and the IScriptResults object for adding the results to.

What a script can do, though, is open a window as a drop target that you can drag and drop image files onto. It can then return each image dropped onto it as a search result from that source. This will only work if your browser actually drags and drops image files, of course. I've tried it with Firefox here, and it works. IE9 doesn't, it only drags the URL of the image (and in Protected Mode will refuse to drag and drop anything at all). I don't know about Chrome.

Anyway, here's the script if you want to give it a go: file-drop-target.boo (http://album-art.sourceforge.net/scripts/file-drop-target.boo)

Needless to say, this one is a bit specialist and isn't going to go in the standard collection either. Might try and put together a wiki page for it sometime, though.

Allowing you to drop onto the main AAD window itself would of course require an update to the program itself, not just a script. This has some subtleties about it, because there are several bits of AAD that work under the assumption that once the sources have all finished returning results, the results list can be regarded as complete. If you were able to add stuff to it whenever you liked by just dropping it, that would confuse things. Not saying it's impossible, of course, just that it would take a quite a lot more thought and design than just porting the code from the script drop target to the main window - and I'm not sure that it's that useful a feature.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-10 19:42:05
Alex, maybe a few of these things can be done at the same time and make some parts easier.

I would envision an optional/drop down window at the top (under options/above search results) that is basically the target folder. You could display current artwork, drag and drop images to this area, and possibly display artist/track info in that window as well.

This would be a work around so you wouldn't be dragging new images into the search results, and also a good place to display current artwork.
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-10 22:39:21
Anyway, here's the script if you want to give it a go: file-drop-target.boo (http://album-art.sourceforge.net/scripts/file-drop-target.boo)
Alex



Works, but I found that you can only drag 1 image. If you drag more then 1, the others don't show up and all the images "add up" and create a corrupted image. I tried to drag multiple images, only the first showed in the results, but the size climbed, and when save the image was corrupt.
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-11 00:11:59
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\CD DVD\AlbumArtDownloader\errorlog.txt

App version: 0.46.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown.
  at System.Threading.Thread.StartInternal(IPrincipal principal, StackCrawlMark& stackMark)
  at System.Threading.Thread.Start()
  at System.Threading.Thread.Start(Object parameter)
  at AlbumArtDownloader.Source.Search(String artist, String album)
  at AlbumArtDownloader.ArtSearchWindow.AlterSearch()
  at AlbumArtDownloader.ArtSearchWindow.FindExec(Object sender, RoutedEventArgs e)
  at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
  at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
  at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
  at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
  at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
  at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
  at System.Windows.Controls.Primitives.ButtonBase.OnClick()
  at System.Windows.Controls.Button.OnClick()
  at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
  at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
  at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
  at System.Windows.UIElement.CrackMouseButtonEventAndReRaiseEvent(DependencyObject sender, MouseButtonEventArgs e)
  at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
  at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.InputManager.ProcessStagingArea()
  at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
  at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
  at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
  at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-11 04:53:02
Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\CD DVD\AlbumArtDownloader\errorlog.txt

App version: 0.46.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.OutOfMemoryException: Insufficient memory to continue the execution of the program.
  at System.Windows.Media.MediaContext.NotifyPartitionIsZombie(Int32 failureCode)
  at System.Windows.Media.MediaContext.NotifyChannelMessage()
  at System.Windows.Interop.HwndTarget.HandleMessage(Int32 msg, IntPtr wparam, IntPtr lparam)
  at System.Windows.Interop.HwndSource.HwndTargetFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-11 08:01:23
I would envision an optional/drop down window at the top

Thanks for the suggestion, but this isn't going to work. There is no single "target folder", and I don't think automatically saving an image when it's dragged and dropped onto a search window is an appropriate default action anyway. Displaying track or album info is outside the scope of this application, I don't want it to be a library management application.

I found that you can only drag 1 image. If you drag more then 1, the others don't show up and all the images "add up" and create a corrupted image. I tried to drag multiple images, only the first showed in the results, but the size climbed, and when save the image was corrupt.
Strange. When I tried it, if I dragged and dropped an image before it finished loading in the browser, it would be 'corrupt' as in only the bit it had downloaded so far would show up, but apart from that it worked fine. When you say drag more than 1, do you mean a multiple selection, or dragging one, then separately dragging a second one, and so on? What browser are you using? Could you try just dragging image files from Windows Explorer and see if you see the same issue?

I see your error reports. Both of them are complaining about running out of memory, which means they don't point directly at the problem - to fix it I'd need to know why it ran out of memory, not just what happened after it did. The second one looks like it was out of memory as soon as it was launched, so I'm guessing that you tried to run that immediately after it crashed the first time, and you still had no memory available. That's particularly weird, as if the first one had grabbed all the memory, it should have become free again as soon as it crashed out. The first error report suggests that it crashed when trying to extend a search, but doesn't give me any clues as to why it should have been out of memory at that point. Did anything unusual happen just before then? Are there any steps you can take that reproduce the problem, that I can try here?

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-11 12:46:25
Alex,
Neither crash had anything to do with the drag and drop, and seemed to be random.

In regards to possibly displaying tracks I wasn't intending or suggesting that it be a library management tool. However, sometime when I get multiple results for a search, and some of them includes backs, which lists the tracks I can figure out what the correct art is for that album.

You don't need to automatically save if you drag and drop to that window, but I thought having a separate window may fix the problem you mentioned with drag and drop before.

I am using Firefox, and anytime I drag/drop an image to the drag/drop window it is becoming corrupt and reporting a size larger then it is, even if I drag only 1 image. I will try explorer and chrome.
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-12 18:38:53
After this crash AAD did not restart normally the first time, don't know if its a fluke or has to do with the crash:

Code: [Select]

App version: 0.46.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.OutOfMemoryException: Insufficient memory to continue the execution of the program.
  at System.Windows.Media.MediaContext.NotifyPartitionIsZombie(Int32 failureCode)
  at System.Windows.Media.MediaContext.NotifyChannelMessage()
  at System.Windows.Interop.HwndTarget.HandleMessage(Int32 msg, IntPtr wparam, IntPtr lparam)
  at System.Windows.Interop.HwndSource.HwndTargetFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-12 19:44:31
After this crash AAD did not restart normally the first time, don't know if its a fluke or has to do with the crash:
That's the same error as before: out of memory. Unfortunately, there's no way for it to report *why* you are out of memory. Perhaps you could check the Processes tab of Task Manager and see if any process is using massive amounts of memory? The AAD process is AlbumArt.exe, so if that's the thing that's using up all the memory, please check to see if there is only one of them, or several.

Did you have any success dragging and dropping files from Windows Explorer into the drop target script? I'm using Firefox 22 here and it's working fine, but there could be all sorts of different behaviours on different browsers and versions, that's why I thought using Windows Explorer instead of a browser would be a good basis to check that the script itself was working OK.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-14 16:59:38
Dragging from Windows Explorer works fine.

Also seems to work from IE 8.

My Firefox is 20.0.1, which corrupts any image I drag and drop to AAD
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-14 17:51:48
My Firefox is 20.0.1, which corrupts any image I drag and drop to AAD

Hmm... just tried a fresh install of Firefox 20.0.1 from Firefox Portable (http://portableapps.com/apps/internet/firefox_portable) so that it would be separate from my main browser, and it seems to work fine. I'm at a bit of a loss as to why it would be corrupting dragged images for you - is it with any image, or just specific ones or from a specific site? What happens if you drag and drop an image onto the windows desktop, does it corrupt it there too?

Alex
Title: Album Art Downloader XUI
Post by: Zarggg on 2013-05-14 17:52:45
I don't know if this has been reported yet, but the http://sourceforge.net/projects/album-art/...latest/download (http://sourceforge.net/projects/album-art/files/latest/download) link still points to the 0.45 installer.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-14 18:12:22
I don't know if this has been reported yet, but the http://sourceforge.net/projects/album-art/...latest/download (http://sourceforge.net/projects/album-art/files/latest/download) link still points to the 0.45 installer.
Thanks for pointing that out! Sourceforge is supposed to update that automatically, but I guess it needed a shove this time. I should have noticed, though.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-14 20:58:19
My Firefox is 20.0.1, which corrupts any image I drag and drop to AAD

I'm at a bit of a loss as to why it would be corrupting dragged images for you - is it with any image, or just specific ones or from a specific site? What happens if you drag and drop an image onto the windows desktop, does it corrupt it there too?

Alex


I can drag from FF just fine to anything else. I do it all the time to explorer and dBpoweramp. It only seems to be a problem with AAD.
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-14 21:14:38
Another site to try to add:

http://www.absolutepunk.net/gallery/search.php?c= (http://www.absolutepunk.net/gallery/search.php?c=)
Title: Album Art Downloader XUI
Post by: nikolai4ik on 2013-05-15 03:51:47
hey guys I have a big problem. Some time ago AAD started crashing instantly upon launch. I click on the .exe and in 0.2 seconds a window "album art downloader has stopped working" pops up. I've tried reinstalling and it didn't work. Any way to fix or maybe generate a log of error?
Title: Album Art Downloader XUI
Post by: Eli on 2013-05-15 12:51:30
And another site to search:

bandcamp.com
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-15 18:50:11
hey guys I have a big problem. Some time ago AAD started crashing instantly upon launch. I click on the .exe and in 0.2 seconds a window "album art downloader has stopped working" pops up. I've tried reinstalling and it didn't work. Any way to fix or maybe generate a log of error?
AAD automatically displays a log file when it crashes. The fact that it didn't in your case means that it couldn't even write out an error log before it crashed. There will probably be a log of the error in the Windows Event Viewer produced by the .net framework itself, but frankly if it can't even run enough of AAD to write a normal error log then chances are there won't be anything I can do about it.

Thanks for the site suggestions, a couple of good ones there (certainly if you have any music published by bandcamp!). Let me know if these work out OK, and I'll publish them through Online Updates: absolutepunk.boo (http://album-art.sourceforge.net/scripts/absolutepunk.boo), bandcamp.boo (http://album-art.sourceforge.net/scripts/bandcamp.boo)

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2013-05-17 10:21:25
Hey Alex,

I noticed, that the iTunes Store actually offers 1200x1200 pixels in addition to the 600x600 pix.
I guess that they adjusted their album art download function to the better resolution of iPads.
However, it is not the original image file that Apple offered before. (The 1200 picture seems to be rescaled.) But it is better than 600x600.

here are examples:
http://a3.mzstatic.com/us/r1000/057/Music/...200x1200-75.jpg (http://a3.mzstatic.com/us/r1000/057/Music/62/ac/cf/mzi.zeikfiov.1200x1200-75.jpg)
http://a4.mzstatic.com/us/r1000/041/Music/...200x1200-75.jpg (http://a4.mzstatic.com/us/r1000/041/Music/9c/44/34/mzi.lpwsaysm.1200x1200-75.jpg)

It seems to work for all albums I've tested so far. You may adjust your script.

Yours,
Thomian
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-17 18:51:14
I noticed, that the iTunes Store actually offers 1200x1200 pixels in addition to the 600x600 pix.

Nice one, thanks for letting me know. I've updated itunes.boo (http://album-art.sourceforge.net/scripts/itunes.boo) to try 1200x1200 before falling back to 600x600 now.

Alex
Title: Album Art Downloader XUI
Post by: kareha on 2013-05-17 19:40:53
Is it possible to search multiple countries with the iTunes cover option?  I have a lot of Japanese music and would like nice cover art for them.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-05-17 20:20:35
Is it possible to search multiple countries with the iTunes cover option?  I have a lot of Japanese music and would like nice cover art for them.

Yes, see here: iTunes_Country-Specific_Searches (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches). If you download the itunes-JP.boo (http://album-art.sourceforge.net/scripts/itunes/itunes-JP.boo) then you should be able to access iTunes Japan. If it's stopped working, let me know and I'll investigate.

Alex
Title: Album Art Downloader XUI
Post by: kareha on 2013-05-17 21:14:41
Is it possible to search multiple countries with the iTunes cover option?  I have a lot of Japanese music and would like nice cover art for them.

Yes, see here: iTunes_Country-Specific_Searches (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches). If you download the itunes-JP.boo (http://album-art.sourceforge.net/scripts/itunes/itunes-JP.boo) then you should be able to access iTunes Japan. If it's stopped working, let me know and I'll investigate.

Alex


Works perfectly

(http://i.imgur.com/9n51Dg9.jpg)
Title: Album Art Downloader XUI
Post by: marc2003 on 2013-05-17 21:39:29
I've updated itunes.boo (http://album-art.sourceforge.net/scripts/itunes.boo) to try 1200x1200 before falling back to 600x600 now.


thanks for this. i've found quite a few nice updates for my collection. it's just a shame not all of it can be trusted. some of the large images are worse quality than the 600x600 images i already have.

(merely an observation. i know you can't do anything about it.  thanks again.)
Title: Album Art Downloader XUI
Post by: marc2003 on 2013-05-18 01:01:56
if anybody here uses foobar2000 to play their files, you might be interested in some artwork display scripts i've made for it. full instructions can be found here: https://dl.dropboxusercontent.com/u/22801321/wsh/samples.zip (https://dl.dropboxusercontent.com/u/22801321/wsh/samples.zip)

i'm mentioning it here because i've just updated them with right click menu options to launch album art downloader with the current artist/album as search terms.

a few other advantages it has over the default artwork panel:

-it can crop images while maintaining aspect
-it shows the actual image size as tooltips
-has a Refresh option to instantly update the panel if the artwork is edited/replaced during playback

the zip above contains 2 scripts of interest. artreader is a straight up replacement for the built-in artwork panel. cd jewel case shouldn't need any explanation but i've included a screenshot below.

click (https://dl.dropboxusercontent.com/u/22801321/2013/may/cd%20aad.jpg)

any issues should be reported in this thread (http://www.hydrogenaudio.org/forums/index.php?showtopic=77883).
Title: Album Art Downloader XUI
Post by: SanMarc on 2013-05-22 20:10:41
Hello everybody
I'd like to get the script to 45worlds.com website (Magazines, 78s, 12" Singles and CD Singles). Is it possible?

Thanks in advance
Title: Album Art Downloader XUI
Post by: dwhizz on 2013-05-31 13:44:36
just edited alex's excellent google script to search for jpeg only. any comments?

Code: [Select]
import AlbumArtDownloader.Scripts
import util

class GoogleImageJpeg(AlbumArtDownloader.Scripts.IScript):
    Name as string:
        get: return "GoogleImageJpeg"
    Version as string:
        get: return "0.1"
    Author as string:
        get: return "Duncan Hampshire"
    def Search(artist as string, album as string, results as IScriptResults):
        artist = StripCharacters("&.'\";:?!", artist)
        album = StripCharacters("&.'\";:?!", album)

        imagesHtml = GetPageIsoLatin1("https://www.google.com/search?as_st=y&tbm=isch&hl=en&as_q=" + EncodeUrl(artist + " " + album) + "&as_epq=&as_oq=&as_eq=&cr=&as_sitesearch=&safe=images&tbs=ift:jpg&biw=1600&bih=775&sei=1ZCoUfvFNMPWPePggOgM")

        imageMatches = Regex("/imgres\\?imgurl=(?<fullSize>[^&]+)&amp;imgrefurl=(?<infoUri>[^&]+)[^>]+?&amp;h=(?<height>\\d+)&amp;w=(?<width>\\d+)[^>]+?&amp;tbnid=(?<tbnid>[^&]+).+?<\\/cite><br\\s*\\/?>(?<title>.+?)<br", RegexOptions.Singleline | RegexOptions.IgnoreCase).Matches(imagesHtml)
        
        results.EstimatedCount = imageMatches.Count
        
        for imageMatch as Match in imageMatches:
            title = System.Web.HttpUtility.HtmlDecode(/<\/?b>/.Replace(imageMatch.Groups["title"].Value, ""))
            fullSize = imageMatch.Groups["fullSize"].Value
            infoUri = imageMatch.Groups["infoUri"].Value
            height = System.Int32.Parse(imageMatch.Groups["height"].Value)
            width = System.Int32.Parse(imageMatch.Groups["width"].Value)
            tbnid = imageMatch.Groups["tbnid"].Value
            
            results.Add("http://tbn0.google.com/images?q=tbn:${tbnid}", title, infoUri, width, height, fullSize);


    def RetrieveFullSizeImage(fullSizeCallbackParameter):
        return fullSizeCallbackParameter


Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-06-01 09:45:35
Hello everybody
I'd like to get the script to 45worlds.com website (Magazines, 78s, 12" Singles and CD Singles). Is it possible?

Thanks in advance
Sorry, didn't spot your post earlier for some reason. Here is a script for 45worlds CD singles: 45worlds-cdsingles.boo (http://album-art.sourceforge.net/scripts/45worlds-cdsingles.boo), please let me know if its working OK for you, and I'll publish it through online updates.

just edited alex's excellent google script to search for jpeg only. any comments?
Thank you for your contribution. Personally, I prefer not to restrict to jpegs, but anyone who wants to will appreciate your script. One thing I'm not sure about, though, what does the "&sei=1ZCoUfvFNMPWPePggOgM" at the end of the search URL you are using do?

Alex
Title: Album Art Downloader XUI
Post by: dwhizz on 2013-06-07 12:42:54
Hello everybody
I'd like to get the script to 45worlds.com website (Magazines, 78s, 12" Singles and CD Singles). Is it possible?

Thanks in advance
Sorry, didn't spot your post earlier for some reason. Here is a script for 45worlds CD singles: 45worlds-cdsingles.boo (http://album-art.sourceforge.net/scripts/45worlds-cdsingles.boo), please let me know if its working OK for you, and I'll publish it through online updates.

just edited alex's excellent google script to search for jpeg only. any comments?
Thank you for your contribution. Personally, I prefer not to restrict to jpegs, but anyone who wants to will appreciate your script. One thing I'm not sure about, though, what does the "&sei=1ZCoUfvFNMPWPePggOgM" at the end of the search URL you are using do?

Alex

the reason i restrict to jpeg is sometimes the script returns .gif and other file types that no not work well when I try to embed them into the id3 tag, which i use another program to do. I does seem you are right about the bit at the end; it does nothing! I was using a browser and fiddling around with advanced search until i got good results, as i am no expert in the syntactical construction of google's urls. As soon as it worked i was happy.
Title: Album Art Downloader XUI
Post by: w00tw00t on 2013-06-14 16:49:10
Could you please make a Hong Kong or Taiwan version? Chinese album covers are lacking in main store too, especially new releases.  Thanks a lot!

EDIT: I think I figured it out somehow. Just replace CountryName with "Hong Kong" and CountryCode with "HK" and it works.

Is it possible to search multiple countries with the iTunes cover option?  I have a lot of Japanese music and would like nice cover art for them.

Yes, see here: iTunes_Country-Specific_Searches (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches). If you download the itunes-JP.boo (http://album-art.sourceforge.net/scripts/itunes/itunes-JP.boo) then you should be able to access iTunes Japan. If it's stopped working, let me know and I'll investigate.

Alex
Title: Album Art Downloader XUI
Post by: bkh on 2013-06-17 14:18:55
Hello Alex,

did i something wrong?

Since the last uptdate i could no longer find der presets. I also unzipped the program in a new folder. In both versions the presets doesn't work.

What was wrong?

bkh
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-06-18 07:46:00
Since the last uptdate i could no longer find der presets.

Hello, sorry to hear you are having difficulties with this. Please click the Options link and check that the "Save images to" box has the %preset% placeholder somewhere in it (the default would be to have it here: Folder%preset%.%extension%). If it does not, then the drop down for picking a preset will not appear, as it would have no effect.

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2013-06-19 19:56:03
Hi, thanks again for keeping up the good work. New itunes script is great. I was wondering if you could maybe add Russian iTunes to the mix? That'd be great for me  Thanks in advance.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-06-21 07:48:34
Hi, thanks again for keeping up the good work. New itunes script is great. I was wondering if you could maybe add Russian iTunes to the mix? That'd be great for me  Thanks in advance.

Sure, they are easy enough to edit and make yourself, but I've added Russia here: itunes-RU.boo (http://album-art.sourceforge.net/scripts/itunes/itunes-RU.boo), and added links to that and the Hong Kong one mentioned earlier to the wiki page: iTunes Country-Specific Searches (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches)

Alex
Title: Album Art Downloader XUI
Post by: Hydrogenous on 2013-06-23 20:03:48
Hey guys,
I just want to know, the album covert art is saved as Folder.jpg in the folder album, but I wonder if there is a way to save the downloaded cover directly in the album files, with the ID3 Tag api, cause I've seen that the software is capable of detecting album cover inside music file, why not an option to save into it ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-06-24 08:00:21
I wonder if there is a way to save the downloaded cover directly in the album files, with the ID3 Tag

AAD could be made to save a cover into a single mp3 file instead of a .jpg file, but that isn't really what anyone needs. You need a tag management or library software to do the job of ensuring all the files in your album have the correct cover embedded within them, and that's sort of mass tag management is out of scope for AAD.

I'd suggest Mp3Tag for doing the job. There was a post a while back by g.p.m. that I've linked from the wiki giving instructions on how to make them work nicely together: Mp3Tag with AAD (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392&st=1525&p=740568&#entry740568).

Alex
Title: Album Art Downloader XUI
Post by: pianoinbush on 2013-06-28 14:32:00
Hi, thanks again for keeping up the good work. New itunes script is great. I was wondering if you could maybe add Russian iTunes to the mix? That'd be great for me  Thanks in advance.

Sure, they are easy enough to edit and make yourself, but I've added Russia here: itunes-RU.boo (http://album-art.sourceforge.net/scripts/itunes/itunes-RU.boo), and added links to that and the Hong Kong one mentioned earlier to the wiki page: iTunes Country-Specific Searches (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches)

Alex

thanks for the script!
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-08 21:10:48
I had a look at fanart.tv, thanks for the suggestion. Unless I'm missing something, though, there doesn't actually appear to be any way of searching for an album on it... the only thing I can do is search for an artist or a label. I can't find an Advanced Search or anything like that, and even if I could use the API (which I can't, as it needs a key), the API doesn't have any search function either!

Hey guys, I'm a mod over at fanart.tv and finally decided that I ought to sit down and write a script for the site. I've found it's kind of hit and miss for google results, plus Alex said we weren't supposed to have multiple google searches going at the same time. While it's obviously not a problem to get an API key, as Alex said, the API doesn't have a search function. However, you can "search" for artists/albums if you have the musicbrainz ID's for either artist or release group. I tag that information from musicbrainz so I already have it (and I assume many others do as well), but there's no way to pass that information to AAD using the command line as far as I can tell.

What I'd like would be a command line field that would enable those values to be available in a fanartTV.boo script. Extensible would be perfect, so I envision something like this:

AlbumArt.exe /ar "%artist%" /al "%album%" /x MBArId="%MUSICBRAINZ_ARTISTID%" /x MBReId="%MUSICBRAINZ_RELEASEGROUPID%"

Then in my fanartTV.boo I could reference MBArId and MBReId just like we currently can with Artist and Album. If something like that is already possible through the command line, whether it's documented or not, I'd love to know, otherwise it'd be a great feature to have.
Title: Album Art Downloader XUI
Post by: KGriff on 2013-07-08 23:09:32
My first post ... Hi to everyone here!!

I was referred to Album Art Downloader XUI by people in the MP3Tag Forum and have the software working on my Windows 8 desktop PC, but I have difficulty getting the software to run on my other windows 7 PC.

Immediately after standard install on Windows 7 I launch Album Art Downloader XUI and get an error log appear. I have uninstalled and reinstalled the .Net Framework v4 and all service packs and updates etc. and uninstalled/reinstalled the software but still no joy... here is the error log details:

....................................................................................................
.......................................

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.46.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Windows.Markup.XamlParseException: Cannot create instance of 'TextBox' defined in assembly 'PresentationFramework, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Could not load file or assembly 'UIAutomationProvider, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.  Error at object 'System.Windows.Controls.Grid' in markup file 'AlbumArt;component/splashscreen.xaml'. ---> System.IO.FileNotFoundException: Could not load file or assembly 'UIAutomationProvider, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.
File name: 'UIAutomationProvider, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
  at System.Windows.Controls.TextBox.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
  at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  at MS.Internal.Documents.UndoManager.AttachUndoManager(DependencyObject scope, UndoManager undoManager)
  at System.Windows.Documents.TextEditor..ctor(ITextContainer textContainer, FrameworkElement uiScope, Boolean isUndoEnabled)
  at System.Windows.Controls.Primitives.TextBoxBase.InitializeTextContainer(TextContainer textContainer)
  at System.Windows.Controls.TextBox..ctor()
  at System.Windows.Markup.KnownTypes.CreateKnownElement(KnownElements knownElement)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].

  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.CreateInstanceFromType(Type type, Int16 typeId, Boolean throwOnFail)
  at System.Windows.Markup.BamlRecordReader.GetElementAndFlags(BamlElementStartRecord bamlElementStartRecord, Object& element, ReaderFlags& flags, Type& delayCreatedType, Int16& delayCreatedTypeId)
  at System.Windows.Markup.BamlRecordReader.BaseReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadElementStartRecord(BamlElementStartRecord bamlElementRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
  at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
  at System.Windows.Markup.TreeBuilder.Parse()
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.Splashscreen.InitializeComponent()
  at AlbumArtDownloader.Splashscreen..ctor()
  at AlbumArtDownloader.Splashscreen.ShowIfRequired()
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Application.RunInternal(Window window)
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)

....................................................................................................
................................................................

If anyone can suggest a fix or offer any advice I would be grateful.

Thanks

Ken Griffiths
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-09 08:14:33
What I'd like would be a command line field that would enable those values to be available in a fanartTV.boo script. Extensible would be perfect, so I envision something like this:

AlbumArt.exe /ar "%artist%" /al "%album%" /x MBArId="%MUSICBRAINZ_ARTISTID%" /x MBReId="%MUSICBRAINZ_RELEASEGROUPID%"

Then in my fanartTV.boo I could reference MBArId and MBReId just like we currently can with Artist and Album. If something like that is already possible through the command line, whether it's documented or not, I'd love to know, otherwise it'd be a great feature to have.

Hi, glad to hear you are working on a script for this. I'm afraid there's no way setting variables through the command line like in your example - the only thing that is passes through to the script is artist and album. Is there any reason you can't use those, though?

AlbumArt.exe /ar "%MUSICBRAINZ_ARTISTID%" /al "%MUSICBRAINZ_RELEASEGROUPID%" /sources "fanartTV"

If you really have to pass context information to a script separately to album and artist, then the best I can think of would be to have a batch script that wrote the information to a temporary file before calling AlbumArt.exe, then have the script check for the presence of that file and read the information from it.

Immediately after standard install on Windows 7 I launch Album Art Downloader XUI and get an error log appear. I have uninstalled and reinstalled the .Net Framework v4 and all service packs and updates etc. and uninstalled/reinstalled the software but still no joy... here is the error log details:

[...] System.IO.FileNotFoundException: Could not load file or assembly 'UIAutomationProvider, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified. [...]

Hello, and welcome. I'm sorry to hear that you are having difficulties getting it to run. As you must have guessed, this is an issue with a corrupt .net installation, however it's .NET Framework v3.5 that needs uninstalling and reinstalling, not version 4! That makes things trickier on Windows 7 as it's a built in part of Windows rather than a separate installer, but I think it can be done by going to the normal "Add or Remove Programs" window, then clicking the "Turn Windows features on or off" link on the left. From that you can uncheck the box next to Microsoft .NET Framework 3.5.1 and click OK to uninstall it, then go back to that same box and re-check it to re-install it.

Alex
Title: Album Art Downloader XUI
Post by: i_edgars on 2013-07-09 13:46:07
How Do I Get Album Art Downloader program to convince it searches only the Artist "David Essex" and only a Album "Silver Dream Racer"? Instead of the word in any combination and order.
Title: Album Art Downloader XUI
Post by: matt the cat on 2013-07-09 16:19:57
I have the following problem, I cant for some reason get AAD to work anymore.

First I got this error on the start saying that it cannot read a configuration file, and said I should reset it. (it was in c:windows and .net something) I did this with admin privileges and AAD deleted the file in question (something.config) but now when I try to start AAD it gives the same error window (encountered an error while attempting to read configuration settings, but now when I try to press reset all settings to default or view configuration file in windows explorer it gives me the following error: could not determine path to configuration file.

Here is the error log generated by pressing create error report:

Album Art Downloader encountered an error when attempting to read its
configuration settings, and could not start.
If you wish to report this error, please include this information, which
has been written to the file: K:\AlbumArtDownloader\errorlog.txt

App version: 0.46.0.0, running on Microsoft Windows NT 6.2.9200.0 (64 bit)

System.Configuration.ConfigurationErrorsException: The configuration section 'connectionStrings' has an unexpected declaration.
  at System.Configuration.ConfigurationManager.get_ConnectionStrings()
  at System.Configuration.PrivilegedConfigurationManager.get_ConnectionStrings()
  at System.Configuration.LocalFileSettingsProvider.GetPropertyValues(SettingsContext context, SettingsPropertyCollection properties)
  at System.Configuration.SettingsBase.GetPropertiesFromProvider(SettingsProvider provider)
  at System.Configuration.SettingsBase.GetPropertyValueByName(String propertyName)
  at System.Configuration.SettingsBase.get_Item(String propertyName)
  at System.Configuration.ApplicationSettingsBase.GetPropertyValue(String propertyName)
  at System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
  at AlbumArtDownloader.Properties.Settings.get_ApplicationVersion()
  at AlbumArtDownloader.App.Main(String[] args)



Any help much appreciated.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-09 16:46:04
Hi, glad to hear you are working on a script for this. I'm afraid there's no way setting variables through the command line like in your example - the only thing that is passes through to the script is artist and album. Is there any reason you can't use those, though?

AlbumArt.exe /ar "%MUSICBRAINZ_ARTISTID%" /al "%MUSICBRAINZ_RELEASEGROUPID%" /sources "fanartTV"

If you really have to pass context information to a script separately to album and artist, then the best I can think of would be to have a batch script that wrote the information to a temporary file before calling AlbumArt.exe, then have the script check for the presence of that file and read the information from it.
I did think about passing the information in the album/artist fields, but the problem is that because I don't batch things and actually check the artwork for each album and take the best available from my favorite sources I couldn't use all my sources at the same time. I'd have to have one for just fanart.tv and one for everything else.

The temporary file could work, but it'd be really hard to get other people to use it because it'd be a documentation nightmare.

The other option I've got would be to take the artist/album information and do an API request on musicbrainz first then take the highest matching result for each. It's pretty error prone, but it's also the simplest.

I could also bug the hell out of you until you added extra command line options, or maybe even do it myself if you don't mind.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-09 19:05:56
How Do I Get Album Art Downloader program to convince it searches only the Artist "David Essex" and only a Album "Silver Dream Racer"? Instead of the word in any combination and order.
That depends on the source being searched. Some are better than others, and unfortunately some seem to include results that can't possibly be relevant, perhaps on the off-chance that you might see something else you like? I don't know. If you are finding that Album Art Downloader is giving worse results for a specific source than you can get by going to the website of that source and doing a search using their site, then let me know the details and I can look into it.

I have the following problem, I cant for some reason get AAD to work anymore.
That's a weird one. Can you check if there is a file called AlbumArt.exe.config in the same folder as your AlbumArt.exe? If so, try deleting that. If not, or if it still doesn't work, then try resetting the settings by deleting the folder %localappdata%\AlbumArtDownloader

The temporary file could work, but it'd be really hard to get other people to use it because it'd be a documentation nightmare.

The other option I've got would be to take the artist/album information and do an API request on musicbrainz first then take the highest matching result for each. It's pretty error prone, but it's also the simplest.

I could also bug the hell out of you until you added extra command line options, or maybe even do it myself if you don't mind.

I can see how it would be a nightmare to document, you'd have to get people to put a .bat file in their AAD directory or something, which would be a pain. If you are interested in contributing code to do the command line options, I'd be open to that, but there's a fair bit of design that needs to go into the issues of scope and lifetime. That's the benefit of the file approach, the scope and lifetime of that file are under your control, and well understood.

For a command line argument, it's assumed it would be available to all scripts for the search that the command line kicks off. But what if the command line just opens a window without a search? Or if it does open a search, but then the user changes the maximum results setting, or adds or removes scripts, and hits Extend Search? Or corrects the album or artist information for a new search? Or starts a new search entirely? In a new window? What if the initial search went into the queue because searches other were already ongoing? The problem is, if this functionality were added, it wouldn't just be for your script, and people might reasonably expect that if they set a variable with the command line, that it would stay set (they could use it for login credentials for a script, for example), and apply to all windows - it is a variable after all. Others might instead expect that it would apply only to the immediate search they are performing, as in your use-case, and I don't see any good way to distinguish between the two.

That's why I'm reluctant to go with a command line approach, because however much of a nightmare documenting the batch-file approach might be, I still think it's less of a nightmare than designing and documenting command line variables in a generally useful way.

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-09 21:22:34
I can see how it would be a nightmare to document, you'd have to get people to put a .bat file in their AAD directory or something, which would be a pain. If you are interested in contributing code to do the command line options, I'd be open to that, but there's a fair bit of design that needs to go into the issues of scope and lifetime. That's the benefit of the file approach, the scope and lifetime of that file are under your control, and well understood.

For a command line argument, it's assumed it would be available to all scripts for the search that the command line kicks off. But what if the command line just opens a window without a search? Or if it does open a search, but then the user changes the maximum results setting, or adds or removes scripts, and hits Extend Search? Or corrects the album or artist information for a new search? Or starts a new search entirely? In a new window? What if the initial search went into the queue because searches other were already ongoing? The problem is, if this functionality were added, it wouldn't just be for your script, and people might reasonably expect that if they set a variable with the command line, that it would stay set (they could use it for login credentials for a script, for example), and apply to all windows - it is a variable after all. Others might instead expect that it would apply only to the immediate search they are performing, as in your use-case, and I don't see any good way to distinguish between the two.

That's why I'm reluctant to go with a command line approach, because however much of a nightmare documenting the batch-file approach might be, I still think it's less of a nightmare than designing and documenting command line variables in a generally useful way.

Alex

Well, there obviously were some issues I wasn't thinking of, but with passing variables to a batch file we run into many of those exact same issues. Essentially the script couldn't be used at all in batch mode. There'd be no notion of queuing, as you'd only have one file which was continually overwritten each time AAD was launched, changing the Album/Artist wouldn't update the MBIDs, etc. Even if you launched the AlbumArt.exe without passing any variables to the command line the fanart.tv script would still find the last used data file and all your fanart.tv results would be incorrect.

It sounds like the least bad solution is probably just to query musicbrainz and then query fanart.tv with those results. It's not going to be 100% accurate, but I don't really see any other viable options.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-09 22:11:56
you'd only have one file which was continually overwritten each time AAD was launched

I was rather thinking you'd name the file with the artist and album name, so it would only apply if searching for that album...

Doing the search would probably be easiest, yes, but it does feel a bit of a waste to be throwing away information that is already known.

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-10 00:14:46
I was rather thinking you'd name the file with the artist and album name, so it would only apply if searching for that album...

Doing the search would probably be easiest, yes, but it does feel a bit of a waste to be throwing away information that is already known.

Alex

I hadn't thought of saving as multiple files because then you'd need some way to clean them up, and I have no idea how to do that.

Anyway, starting with the musicbrainz.boo as a template, things were going along great until I hit a wall.

Code: [Select]
    fanartURL = "http://api.fanart.tv/webservice/album/${key}/${mbid}/json/albumcover/1/2/"
    //System.IO.File.WriteAllText("fanart1.log", fanartURL)
                                                        
    picDoc = GetPage(fanartURL)
    System.IO.File.WriteAllText("fanart2.log", picDoc)
    picResult = json.DeserializeObject(picDoc) as Dictionary[of string, object]

The mbid is correct, and when I write out the results of the picDoc JSON I get this:
Code: [Select]
{"AC/DC":{"mbid_id":"66c662b6-6e2f-4930-8610-912e24c63ed1","albums":{"d3bc1a64-7561-3787-b680-0003aa50f8f1":{"albumcover":[{"id":"3671","url":"http://assets.fanart.tv/fanart/music/66c662b6-6e2f-4930-8610-912e24c63ed1/albumcover/back-in-black-4de2c08a61a5b.jpg","likes":"1"},{"id":"67760","url":"http://assets.fanart.tv/fanart/music/66c662b6-6e2f-4930-8610-912e24c63ed1/albumcover/back-in-black-50fb8236b8530.jpg","likes":"1"}]}}}}

However, the problem is that when I try and to reference anything in picResult, the script just stops. All I want/need is the url values so I set up a "for image as Dictionary[of string, object] in picResult["url"]", but it never went inside. I tried different members of picResult, all with no dice. I tried to just write picResult["mbid_id"] to a file, but the line doesn't seem to execute. I don't understand why I can reference the mbidResults in exactly the same way with no problem, but it just chokes on picResult. Any ideas? What am I missing?
Title: Album Art Downloader XUI
Post by: KGriff on 2013-07-10 00:40:05
Immediately after standard install on Windows 7 I launch Album Art Downloader XUI and get an error log appear. I have uninstalled and reinstalled the .Net Framework v4 and all service packs and updates etc. and uninstalled/reinstalled the software but still no joy... here is the error log details:

[...] System.IO.FileNotFoundException: Could not load file or assembly 'UIAutomationProvider, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified. [...]
Hello, and welcome. I'm sorry to hear that you are having difficulties getting it to run. As you must have guessed, this is an issue with a corrupt .net installation, however it's .NET Framework v3.5 that needs uninstalling and reinstalling, not version 4! That makes things trickier on Windows 7 as it's a built in part of Windows rather than a separate installer, but I think it can be done by going to the normal "Add or Remove Programs" window, then clicking the "Turn Windows features on or off" link on the left. From that you can uncheck the box next to Microsoft .NET Framework 3.5.1 and click OK to uninstall it, then go back to that same box and re-check it to re-install it.

Alex



Alex...

Sadly it is the .Net framework v3.5 - files that are corrupted (built into Windows7). I have tried removing and adding it back in but windows 7 is not having it. I have tried sfc /scannow, the msdn verification/repair tool, a popular cleanup utility and numerous other things but it seems it doesn't want to play.. I guess I may have to consider using one of my older backups or even a reinstall if I can't find the answer in the coming days... Bit of a pain really as I have quite a bit of music on the drive that will need moving off (er... Just in case!!) . Oh well ... Thanks for the support.

Ken Griffiths
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-10 08:21:20
I hadn't thought of saving as multiple files because then you'd need some way to clean them up, and I have no idea how to do that.
You could have the script delete them after reading? Or just leave them in the temp folder, plenty of other software seems to have no problem with leaving junk in the temp folder indefinitely and it's never going to be large amounts of data. Messy, though.
I don't understand why I can reference the mbidResults in exactly the same way with no problem, but it just chokes on picResult. Any ideas? What am I missing?
I think it's the structure of the json results that you are missing. I don't think it can be deserialised as just a dictionary as it isn't a flat list of key/value pairs. Take a look with some indenting applied:

Code: [Select]
{"AC/DC":{
    "mbid_id":"66c662b6-6e2f-4930-8610-912e24c63ed1",
    "albums":{
        "d3bc1a64-7561-3787-b680-0003aa50f8f1":{
            "albumcover":[
                {"id":"3671",
                 "url":"http://assets.fanart.tv/fanart/music/66c662b6-6e2f-4930-8610-912e24c63ed1/albumcover/back-in-black-4de2c08a61a5b.jpg",
                 "likes":"1"},
                
                {"id":"67760",
                 "url":"http://assets.fanart.tv/fanart/music/66c662b6-6e2f-4930-8610-912e24c63ed1/albumcover/back-in-black-50fb8236b8530.jpg",
                 "likes":"1"}
            ]}
        }
    }
}
There are probably several ways of parsing json, but for an example of how I've done it using nested classes have a look at discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo).

Sadly it is the .Net framework v3.5 - files that are corrupted (built into Windows7). I have tried removing and adding it back in but windows 7 is not having it.
Sorry to hear that. I'm afraid you've already tried all the tricks that I'd suggest for repairing it, so I don't think there's anything further I can add - you clearly know what you're doing already. So I'll just wish you best of luck with the repair anyway!

Alex
Title: Album Art Downloader XUI
Post by: i_edgars on 2013-07-10 08:51:23
How Do I Get Album Art Downloader program to convince it searches only the Artist "David Essex" and only a Album "Silver Dream Racer"? Instead of the word in any combination and order.
That depends on the source being searched. Some are better than others, and unfortunately some seem to include results that can't possibly be relevant, perhaps on the off-chance that you might see something else you like? I don't know. If you are finding that Album Art Downloader is giving worse results for a specific source than you can get by going to the website of that source and doing a search using their site, then let me know the details and I can look into it.
Alex

Not exactly what I wanted!
Currently the program finds all the "David", the present is making all "Essex", the "Silver" ... "Dream", ... and "Racer". Bring together several hundred names. But how to write for viewing only by expression "David Essex" + "Silver Dream Racer" and not David OR Essex OR Silver OR Dream OR Racer? I.e. only for these Artist's Album and nothing else!
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-10 17:19:00
I figured out what I was doing wrong when I was using it as a dictionary. The problem is that the JSON is formatted terribly, with the artist name and the MBID being parent objects in the JSON. To access the images I had to do this:

Code: [Select]
    for image as Dictionary[of string, object] in fanartResult["${mbidArtist}"]["albums"]["${mbid}"]["albumcover"]:


And now everything is working properly. I'll clean the script up and then post it here later today for further testing by you guys.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-10 18:38:10
The problem is that the JSON is formatted terribly, with the artist name and the MBID being parent objects in the JSON.
Ah, yeah, I see the issue now. They haven't really understood JSON as a format, have they? Well done getting it working.

Just as a tip, since you say you were considering contributing code to AAD, that suggests to me that you have a development environment and the know-how to be able to build from source. If you build AAD under the Debug configuration, it also compiles the scripts with debug info turned on, and when running AAD under the debugger Visual Studio will quite happily let you set a breakpoint within the .boo script file. It's not quite as nicely integrated as C# debugging, but you can certainly set watches on variable values, which makes script debugging a lot more pleasant than having to write out test log files all the time.

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-10 20:01:02
Ah, yeah, I see the issue now. They haven't really understood JSON as a format, have they? Well done getting it working.
It's really odd because they format the XML pretty intelligently. I would have parsed that, but I was told it takes 10x as long to generate the XML compared to JSON and so they don't want it used if it can be avoided.

Quote
Just as a tip, since you say you were considering contributing code to AAD, that suggests to me that you have a development environment and the know-how to be able to build from source. If you build AAD under the Debug configuration, it also compiles the scripts with debug info turned on, and when running AAD under the debugger Visual Studio will quite happily let you set a breakpoint within the .boo script file. It's not quite as nicely integrated as C# debugging, but you can certainly set watches on variable values, which makes script debugging a lot more pleasant than having to write out test log files all the time.

I should have thought to try that on my own. I think it would have cut down on the time this took by half at least.

I'm actually pretty happy with how it works, since the musicbrainz search is pretty good. I can't get 100% targeted results like I wanted, but I think I'm okay with that. The only drawback is that the musicbrainz search is a little slow. For some reason it takes 3-5 seconds for the GetPage to return with the JSON, whereas in a browser it's essentially instantaneous. Only thing I can think of is they might delay results based off the user agent string, or lack thereof.

Edit: And a quick check with spoofed request Headers reveals that's exactly the case. So fast! This would probably be a good addition to the existing musicbrainz.org script:
At the top of the script I added a fanartConstants class:
Code: [Select]
static class fanartConstants:
    public UserAgentString    as string = "AlbumArtDownloader"
    public AcceptString        as string = "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8"
    public AcceptCharset    as string = "ISO-8859-1,utf-8;q=0.7,*;q=0.3"
    public AcceptLanguage    as string = "en-US,en;q=0.8"
    public AcceptEncoding    as string = "gzip,deflate,sdch"

and then I overloaded the Get function like so:
Code: [Select]
    static def Get(url as String, cookies as CookieContainer, referer as String):
        request as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
        request.Method="GET"
        request.ContentType = "application/x-www-form-urlencoded"
        request.UserAgent = fanartConstants.UserAgentString
        request.Accept = fanartConstants.AcceptString
        request.Headers.Add("Accept-Charset",fanartConstants.AcceptCharset)
        request.Headers.Add("Accept-Encoding",fanartConstants.AcceptEncoding)
        request.Headers.Add("Accept-Language",fanartConstants.AcceptLanguage)
        if not string.IsNullOrEmpty(referer):
            request.Referer = referer;
        if not cookies == null:
            request.CookieContainer = cookies
        response = request.GetResponse().GetResponseStream()
        return System.IO.StreamReader(response).ReadToEnd()

And just replaced all calls to GetPage with Get(url, null, null).

Second Edit: Appears I was wrong. Guess as soon as I tried to test it musicbrainz' load dropped incredibly. Musicbrainz is back to taking 3-5 seconds for a response.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-07-11 05:51:57
I'm afraid there's no way setting variables through the command line like in your example - the only thing that is passes through to the script is artist and album. Is there any reason you can't use those, though?


Would it be "easy" to pass in the location of the files? My thinking is that the local search knows where they are (even though that doesn't seem to be a "real" plugin).

Then in my fanartTV.boo I could reference MBArId and MBReId just like we currently can with Artist and Album.


Then maybe you could use the location, plus artist and album to locate the file and read the MBArId and MBReId from the files directly?

I know I have one or two ideas for scripts that would be a LOT easier if I had access to the location. (Basically somehow parsing the existing Folder.jpg and passing it to Google Image Search or Tineye to find a better image)

Matt
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-11 08:46:09
Second Edit: Appears I was wrong. Guess as soon as I tried to test it musicbrainz' load dropped incredibly. Musicbrainz is back to taking 3-5 seconds for a response.
Ah, that's a shame. It would have been nice if it was just a throttling issue!

Would it be "easy" to pass in the location of the files? My thinking is that the local search knows where they are (even though that doesn't seem to be a "real" plugin).
Local search uses the default save location (by default - you can change this in its settings) to search for files. That can be, and almost certainly already is, passed in using the /path parameter, but I don't think it's very relevant to fanartTV - it would be easier to simply use a well known location like %temp% and both write to and read from there. Anyway, MordredKLB has gone with the solution of querying Musicbrainz directly. This has the advantage that you can do a search just from artist and album name like other scripts, so it will work with the file and foobar browsers, and with manually entered queries.

Local files search gets special treatment, when the default save location is changed in the search window, it is also passed directly to the source as a special case. There's no way to do it in the other direction, starting from a source, even if you wrote a completely custom one as a dll because it would cause a circular reference.

Alex
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-07-11 19:40:49
Would it be "easy" to pass in the location of the files? My thinking is that the local search knows where they are (even though that doesn't seem to be a "real" plugin).
Local search uses the default save location (by default - you can change this in its settings) to search for files. That can be, and almost certainly already is, passed in using the /path parameter, but I don't think it's very relevant to fanartTV - it would be easier to simply use a well known location like %temp% and both write to and read from there.


I meant so that he could parse the files in that location not as a place to write temporary files. IOW: Read the tags directly from the MP3 (FLAC, AAC, whatever) instead of getting them from the command line. Sorry I wasn't clear.

Local files search gets special treatment, when the default save location is changed in the search window, it is also passed directly to the source as a special case. There's no way to do it in the other direction, starting from a source, even if you wrote a completely custom one as a dll because it would cause a circular reference.


Right... in the options there is the "Images will be saved to" For ME at least I would love to have access to that. Is that currently accessible like the Artist and Album tags are inside a script?

That said, I assumed, perhaps incorrectly, that the Local Search looked at where it found the files to do its search but either way I'd settle for having the path the images would be saved to made available if it already isn't.

Thanks!

Matt
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-11 22:47:33
Even if I could reliably find the mp3's (of which there's obviously no guarantee) I'd have to have a tag-reader built in too, and that seems like a crazy amount of work.

Here's my latest revision of the fanart script (https://www.dropbox.com/s/oe5inwcrterxfty/fanarttv.boo). Please test it out and let me know if you have any issues (particularly if you try and search for a popular artist and nothing shows up [check to see if images exist on fanart.tv first though!]). I left the logging stuff in (but disabled) in case people are having weird results, but I'll remove it when I think the script is perfect.

The script will return covers and cdArt. Because the cdArt is in the form of transparent PNGs, there are shadows where shadows don't need to be in the art display.  You can search for just an artist or an album and everything should work. There might be issues with special characters but I don't know. I already found one instance where a band (Loudness) was listed in all caps in the JSON fanart returned and then the parsing breaks down because the band name is a key value. *sigh* So if we don't find the band name, I try again with all caps. That probably won't fix much, but who knows.

BTW, Alex, running this in the debugger makes everything so much easier and faster. Took me about 20 minutes to get it building in VS2012 but after that it's been smooth sailing. Thank you so much for the tip.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-13 08:32:55
Here's my latest revision of the fanart script (https://www.dropbox.com/s/oe5inwcrterxfty/fanarttv.boo).
That's a nice script, thanks! Sorry about the shadows, I'll admit when I coded those I did not consider transparent art. Doesn't look too awful, though, and of course it's completely harmless, the actual saved image is exactly as provided by the source. Speed seemed fine to me too, but maybe it's just musicbrainz wasn't under load when I was trying it.

A couple of suggestions: First, I think you might need to add ( and ) to StriptCharacters, or escape them. Second, for the json returned by fanart.tv, do you actually need to match the name of the artist to the key value? Does it ever return multiple values? If it did return multiple values, would there be a reason to exclude the other results? You could just do a
Code: [Select]
for result in fanartResult.Values:
    fanartArtistResult = result["albums"]["${mbid}"]
and avoid all the hassle, couldn't you?

Once you are 100% happy with the script and removed any logging you want to remove, I'll publish it on the online updates list, and include it in the next version of the installer (assuming that's OK by you).

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-13 17:23:34
Thanks for the kind words. Can't believe I didn't think to just do that with the Artist names. It shouldn't be possible to ever have more than one, but that's definitely the smarter way to do it.

I added the parentheses to StripCharacters. It seemed to work okay without them, but I'm not sure what exactly would happen since I'm already wrapping the search strings in ( ) to get non-exact results back from MB. Good catch.
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-29 20:02:20
Here's the final version of the fanart.tv script (https://www.dropbox.com/s/oe5inwcrterxfty/fanarttv.boo). Would be awesome if you included this in the official release.

Also, I noticed that the bandcamp script you did a few months ago was broken. I took the liberty of fixing it and made a few minor changes to improve results (most notably allowing artist or album to be blank and not stripping the ampersand character because it messes up the results). You can get bandcamp.boo here (https://dl.dropboxusercontent.com/u/23987869/bandcamp.boo).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-30 07:53:28

Hi, thanks for those - just looking at the fanart script, I notice that it still isn't stripping ( or ). As you said you'd added those, could you check if the version you linked to really is the latest version? It is also still using ${mbidArtist} to look up the result from the json, or did you decide to go back to doing it that way after all?

Thanks for the update to bandcamp too, I've uploaded that to online updates.

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-07-30 17:18:32
Well, I'm an idiot. Made my final revisions to an out of date version and then blapped over the most recent changes you had suggested. Fortunately dropbox keeps older versions. The correct and true final fanart.tv script is here (https://www.dropbox.com/s/oe5inwcrterxfty/fanarttv.boo). I'm 90% sure of it.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-30 19:48:11
The correct and true final fanart.tv script is here (https://www.dropbox.com/s/oe5inwcrterxfty/fanarttv.boo). I'm 90% sure of it.
Thanks, I've posted that to Online Updates, and I'll include it next time an installer is built.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2013-07-31 03:02:42
It's been many, many months since I last used AAD (I was living in a place without any Internet Provider Options, except for the "milionaire-expensive" Satellite connections). Now that I'm "back to civilization"and I started using it again I'm really happy that the program is stronger than ever and with that many souces and good quality results. I even found out that something I once asked for has now been incorporated into the program (filesizes for images already downloaded); I couldn't been happier about it!    (Thank you, Alex!)

I had only one small doubt in my mind: iTunes source script (itunes.boo v0.4) was working OK for me, but it was only looking inside the US store. I'd created the "itunes-BR.boo" in the "iTunes Country Overrides" folder, and I'd deleted a few ones there that did not interest me. And I kept wondering what did I need to do to activate AAD looking for results inside other countries stores (other than just US)... Then I realized I needed to take a look at the CODE writen (and not just copy it)
Code: [Select]
class iTunesBR(iTunes):
    override protected CountryName as string:
        get: return "Brasil"
    override protected CountryCode as string:
        get: return "BR"
I know it might seem ridiculous to some, but it took me a few minutes to realize that I needed to MOVE each Country Override file (e.g. itunes-DK.boo) to the main script foder (one folder up) for it to get "seen" and then start working. I decided to post this experience here since someone else might also be confused as I was at first.

Once again, Alex, my most sincere gratitude and appreciation  for your software that allows me to do cover art searching and retrieving in a fraction of the time it would take to do it manually, album by album. I couldn't put into words how useful it is to me, but sufice it to say I really, really love it! 
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-31 08:10:37
Thanks for your kind words, and glad to have you back with us!

Yes, perhaps I should have put some more instructions about those iTunes scripts in the .zip file. The installer doesn't even include them, in fact, you have to go to the wiki (http://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches) and download the one you want.

Alex
Title: Album Art Downloader XUI
Post by: audio20 on 2013-07-31 15:16:19
Quote
Yes, perhaps I should have put some more instructions about those iTunes scripts in the .zip file. The installer doesn't even include them, in fact, you have to go to the wiki and download the one you want.
I can try to write down a readme.htm file for the ITunes country overides folder if you want... (and then you can modify it to your liking later) I still have a Command Line Reference that's old (and unfinished) but useful for you to see the style of the file = http://goo.gl/tCEPmF (http://goo.gl/tCEPmF) (Command Line Reference.htm, 96Kb) and maybe I could use some part of it to include in the wiki? ("Using the command line" page item)

I would like to add some new information to the post above, but I couldn't find the "Edit" button there, so I'm putting it down here; There are some improvements suggestions among those items below, but please don't get me wrong, they're just mild suggestions to be implemented in the future and only if easy/possible.

(:01:) It looks to me that it is incredibly useful to include at least 1 iTunes Override in the "Search Fist" options, along with the regular US iTunes (I recommend itunes-GB.boo); It almost always gives better results. (or maybe change the default store to UK? It's just a suggestion - I already know how to do it on my end here...  )

(:02:) I noticed that Play.com has some good artwork too (sometimes around 1600px), any plans on including it as a source in the future?
I've been trying to contribute and build the script myself, but for now, all I've got is a initial search string, I'm not really that good with programming...

[!--sizeo:4--][span style=\"font-size:14pt;line-height:100%\"][!--/sizeo--]•••>>› (:03:)[/size] I didn't understand the purpose/usage of the "new" (for me) Group by "Page" option, but I would LOVE  to have a Group by "Category"  option. Is it possible/easy to do?
(I can explain the reasoning for having it as an option, but I don't want to bore you with the long details for now...  )

(:04:) Is it possible to have for each source in the panel, among those "hidden options" (by clicking the ... symbol), besides the already existing "Always download full size", an aditional option "Download Full Size IF size is unknown" ?
(I'd like to keep my "Automatically download full size images" at the defauld "never" and allow only a few select sources to download full size, but only if the size is unknown
= EDIT: NEVER MIND, I realized that most sources have a "uniform behaviour", either always giving image size information or not; so, the existing option "always download full size" for each source is enough already.)

[!--sizeo:4--][span style=\"font-size:14pt;line-height:100%\"][!--/sizeo--]•••>>› (:05:)[/size] Is it possible to have the "Unknown" group on "Group by size" option be placed right at the top (instead of at the very bottom, as it is now), even before the "Extra-Large (over 1000 x 1000)" group?
(It is, almost always, very likely that many images among that group are some of the largest and, indeed, the most desired for downloading)

(:06:) Is it just me or Amazon MP3 source only gives 500px images?

(:07:) I just discovered that double-clicking the image will save it with the default path/name... Isn't this neat?  (lovin' it!!)

And since I really want to contribute, I'm tryin' to develop the [!--sizeo:4--][span style=\"font-size:14pt;line-height:100%\"][!--/sizeo--]play.com script[/size]

Here's my approach so far on trying to make this script:
(:A:) I mount a query the regular way, with artist and album: query = EncodeUrl(artist + " " + album)
(:B:) I get a page on the server with: "http://www.play.com/Search.html?searchstring=" + query + "&searchsource=0&searchtype=musicall"
(:C:) I get a few results on the generated HTML page and start analysing it:

The part we want to grab on the whole page (the results) only starts after this string: <div class="unit size1of3"><p>Results&nbsp;

(:C1:)  === IMAGE ===
First, for each item found, we have a "media" class <article class="media"> which has an image: p.playserver1.com/ProductImages/4/7/2/2/3/5/5/3/35532274_180x180_1.jpg The site has 4 image sizes: 700px plus ("zoom", often equal to 1600px, with the suffix "_700x700min_1.jpg"), 500px ("large", with the suffix "_500x500_1.jpg"), 300px ("normal"", with the suffix "_300x300_1.jpg") and 180px ("thumbnail"", with the suffix "_180x180_1.jpg"). It's important to notice that 1 or more sizes may not exist for a particular album, as you can see below... (300px does not exist)
http://p.playserver1.com/ProductImages/4/7...00x700min_1.jpg (http://p.playserver1.com/ProductImages/4/7/2/2/3/5/5/3/35532274_700x700min_1.jpg)  =  1st image to try and grab
http://p.playserver1.com/ProductImages/4/7...4_500x500_1.jpg (http://p.playserver1.com/ProductImages/4/7/2/2/3/5/5/3/35532274_500x500_1.jpg)  =  2nd image to try and grab (1st fallback)
http://p.playserver1.com/ProductImages/6/8...4_300x300_1.jpg (http://p.playserver1.com/ProductImages/6/8/6/6/7/8/8/3/35532274_300x300_1.jpg)  =  3rd image to try and grab (2nd fallback)
http://p.playserver1.com/ProductImages/4/7...4_180x180_1.jpg (http://p.playserver1.com/ProductImages/4/7/2/2/3/5/5/3/35532274_180x180_1.jpg)  =  thumbnail images

(:C2:)  === INFO ===
Then we have the "media-title" class <p class="media-title"> which usually is the name of the album;
it all points to the same URL throughout, which is the Album page: <a href="/Music/CD/4-/35532274/The-Female-Boss/Product.html?searchstring=tulisa+the+female+boss&searchsource=0&searchtype=musicall&urlrefer=search&strefer=musicall&searchfilters=s%7btulisa+the+female+boss%7d%2bc%7b34%7d%2b"> I think we only need this part of the text above "/Music/CD/4-/35532274/The-Female-Boss/Product.html", and we need to put "http://www.play.com" before it.

(:C3:)  === TITLE ===
Then, in the end of this section ("media-title"), we'll grab the information we need (the album name): >The Female Boss</a> </p>

Next, it's followed by the "sub-title" class <p class="sub-title"> which usually is the name of the artist and the media type: > Tulisa - CD </p>
and we'll also grab this info for the TITLE part.

And this is the initial "skeleton" of the script, in case you're still interested at this point...
Code: [Select]
import System
import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util
class Play(AlbumArtDownloader.Scripts.IScript, ICategorised):
Name as string:
get: return "play.com"
Version as string:
get: return "0.1"
Author as string:
get: return "audio"
Category as string:
get: return "A - Top Digital Stores"
//prepare query string with artist and album
def Search(artist as string, album as string, results as IScriptResults):
artist = StripCharacters("&.'\";:?!", artist)
album = StripCharacters("&.'\";:?!", album)
query = EncodeUrl(artist + " " + album)
//Retrieve the search results page
searchResultsHtml as string = GetPage("http://www.play.com/Search.html?searchstring=" + query + "&searchsource=0&searchtype=musicall")

//I know I should assemble a Regex to extract each group of information now, but I wasn't able to mount it correctly yet (I don't have much experience with regex)
matches = Regex(+++(?<info>[^\"]+)+++(?<img>[^.]+).jpg\"+++>(?<artist>.+?)+++(?<album>.+?)+++", RegexOptions.Singleline | RegexOptions.IgnoreCase).Matches(searchResultsHtml)

results.EstimatedCount = matches.Count

//try to retrieve each of the 4 image sizes from larger to smaller...

def RetrieveFullSizeImage(fullSizeCallbackParameter):
return fullSizeCallbackParameter

[/font]
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-07-31 18:28:45
maybe I could use some part of it to include in the wiki?
Absolutely - I'm pretty useless about doing documentation, so anything you want to contribute on that front is more than welcome. If you don't already have write-access to the wiki let me know your username and I'll fix permissions for you.

As far as the Command Line Reference goes, I need a plain-text version to include with AAD, but having a nicely formatted one like that too could be useful, I could either include it as an additional file in the installer and zip, or link to it from the wiki.

To answer your other points:
1: I don't see any good reason to make UK the default instead of US, really, and I don't want to have multiple iTunes scripts by default either, that's giving it more prominence than it deserves, really. I could add iTunes country overrides to the installer, unchecked by default, though, like I do with Amazon.

2: There actually was a reason for not doing a script for Play.com, I seem to remember. That was years ago now, though, so I doubt it's still relevant. I'd be happy to include your script once its finished, and if you need any help with it let me know.

3: Group by page was a requested feature. I think the idea is that when a source returns multiple artworks for the same album, it makes it easy to see which ones belong together (so which front goes with which back, for example). For group by Category, I assume you mean the category of the source? That shouldn't be hard to do if it would be useful.

5: I don't agree that Unknown images are generally more desirable than known Large images, so I'm going to leave Unknown at the bottom, sorry. You can always just scroll to the end to see them first, if you want to!

6: Sounds reasonable. Why, do you find larger images using the Amazon MP3 website?

Alex
Title: Album Art Downloader XUI
Post by: TomasPin on 2013-07-31 20:16:21
Why, do you find larger images using the Amazon MP3 website?

There are some way larger front covers for some albums in Amazon, but most are 500x500 I believe.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-08-17 09:37:46
Version 1.00

I have finally decided to mark this version as "1.00". This is mostly a statement of intent - that I now regard AAD as feature-complete. I haven't made significant changes in some time, and think the version number should reflect the current stability. I will still continue to fix any bugs reported, and keep the scripts up to date (particularly when a script that has stopped working is reported to me).

For this release, I've added the requested "Category" option to the group-by function, to group by the category of the script for which the result was found. Apart from that, I have also brought all the scripts up to date. SFR Music had to be removed, as the site no longer provides cover art.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.00.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.00.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: bilbo on 2013-08-17 14:53:30
Version 1.00

I have finally decided to mark this version as "1.00".


Thank you for all of your work!!!
Title: Album Art Downloader XUI
Post by: norc426 on 2013-08-17 22:58:39
Download link isn't working. Nevermind
Title: Album Art Downloader XUI
Post by: vagskal on 2013-08-19 17:48:06
Hi,

Thanks!

I noticed that with the new version all my Search first settings were gone so now ADD always searches every site. Is there any way to get my settings back to the way they were?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-08-19 18:03:41
Is there any way to get my settings back to the way they were?

Huh, that's odd. It's not something I've done on purpose, certainly - I haven't touched the settings or upgrading code at all. Anyway, to upgrade them manually, go to %localappdata%\AlbumArtDownloader\, then look through the folders there starting with AlbumArt.exe_Url_ for the subfolder "0.46.0.0" (or any previous version, of course, if 0.46 wasn't the one you were using before). I can't give you the path exactly because .net appends random characters to it.

Once you've found the subfolder, copy the file user.config from within it. Then find the subfolder "1.0.0.0". (It might not necessarily be in the same AlbumArt.exe_Url_ folder). Paste the user.config over the one that's in that folder, and it will replace the current settings with the one from the previous version.

Then, to prevent it from trying to auto-upgrade (and presumably ruining them again), before you run AAD edit the user.config file in Notepad or similar and search for "ApplicationVersion", and replace the bit which says <value>0.46.0.0</value> (or similar) with <value>1.0.0.0</value>

One thing to bear in mind is that I've renamed the script "Cover-Paradies" to "eCover.to (Cover-Paradies)", so if you had special settings for that you'll need to re-apply those to that source only - sorry.

I hope that gets your settings back for you!

Alex
Title: Album Art Downloader XUI
Post by: vagskal on 2013-08-19 18:13:37
Thanks! That worked perfectly. You are fast to reply, as always.

Another minor issue is that with every new build for quite a while now I get a compilation error for the Orchard script so I have to delete that script (in the program folder) to get AAD working. No biggie. I am used to doing that by now.
Title: Album Art Downloader XUI
Post by: Hydroballou on 2013-08-22 08:04:25
Hello Alex,
maybe I missed sth in my options, but since version 1.00 I do not get any results with searching, the Version 0.46 still works fine. I am using Window XP SP3. Has anything
changed with the new version?
Thanks for your help!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-08-22 08:42:20
since version 1.00 I do not get any results with searching, the Version 0.46 still works fine.

No, nothing should have changed... do you get any error messages? Do you have the same sources selected? I can't think of any good reason why this would be the case.

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2013-08-23 16:30:31
I don't know if this has been mentioned somewhere in the ~1000 other pages of this thread, if so, i'm sorry.

I seperate my albums by discnumber tag in seperate directories per disc,

meaning:

Artist A\Album A\CD 1\song.mp3
Artist A\Album A\CD 2\song.mp3

when I scan my directories for audio files with AAD it recognizes just the CD 1 directory and throws the fetched covers only in there.

any way I can make it recognize the second (or more) directory too? i dont want to throw all my files in one directory, i think this should be separated
i now have a lot of albums where just one disc has a cover :/


(i know its possible to specify the pattern matching to directories instead of id3 tags, but this isn't possible for me since the second Album directory also contains things like catalog number, if available)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-08-23 18:52:55
when I scan my directories for audio files with AAD it recognizes just the CD 1 directory and throws the fetched covers only in there.

AAD doesn't have functionality for automatically making multiple copies of covers, no. I would suggest that if you have:

Artist A\Album A\CD 1\song.mp3
Artist A\Album A\CD 2\song.mp3

then the artwork logically belongs in

Artist A\Album A\cover.jpg

Whether that's useful or not would depend on whether your player of choice can be configured to look there for one, of course.

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2013-08-24 00:22:19
when I scan my directories for audio files with AAD it recognizes just the CD 1 directory and throws the fetched covers only in there.

AAD doesn't have functionality for automatically making multiple copies of covers, no. I would suggest that if you have:

Artist A\Album A\CD 1\song.mp3
Artist A\Album A\CD 2\song.mp3

then the artwork logically belongs in

Artist A\Album A\cover.jpg

Whether that's useful or not would depend on whether your player of choice can be configured to look there for one, of course.

Alex

i use foobar and it could certainly do that, but i usually integrate the covers in the metatag :/
AAD doesnt need to make automatic copies to the other directories, treating the different directory as separate object to download would be enough (double the traffic but thats not the problem)
Title: Album Art Downloader XUI
Post by: Zarggg on 2013-08-24 06:15:59
Situations like that are precisely why I use a single directory for any given album, even multidisc ones. If there is an album or collection with a single title that is comprised of more than one physical medium, then I incorporate that into track numbering.

Of course, that's just personal preference.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-08-24 08:39:37
AAD doesnt need to make automatic copies to the other directories, treating the different directory as separate object to download would be enough (double the traffic but thats not the problem)

I can't think of any good way to do this. Albums are identified just by artist and album title, so if the two directories had to be listed twice (in the file browser) then they would have to have different artist names or different album titles - technically it could be done by including the CD folder name in the album title or something, but that wouldn't help much with the searching.

I think the best thing I can suggest to achieve this result is to do it in two passes. First, starting in your root music folder, use Windows Explorer to search for "CD 1" (or even "filename:cd1 kind:folder" if you are getting false positives). That will give you a list of all your CD 1 folders, so grab those, drag and drop them onto a fresh AAD File Browser window. Once you've dealt with all the albums in your CD 1 folders, you can then repeat the process with a new fresh file browser window, but in Windows Explorer search for "CD 2" instead.

Not ideal, I know, but then treating the directories separately and downloading twice is never going to be ideal!

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2013-08-24 11:02:25
thanks for all your replys!


Situations like that are precisely why I use a single directory for any given album, even multidisc ones. If there is an album or collection with a single title that is comprised of more than one physical medium, then I incorporate that into track numbering.

Of course, that's just personal preference.

i thought about changing my current style to this, unfortunately i have a large number of albums now where only 1 cd has a cover, when i throw them in 1 directory AAD will find the cover in the first file and ignore the whole album


I can't think of any good way to do this. Albums are identified just by artist and album title, so if the two directories had to be listed twice (in the file browser) then they would have to have different artist names or different album titles - technically it could be done by including the CD folder name in the album title or something, but that wouldn't help much with the searching.

i list the files by id3 tags in AAD, it would be enough to consider the DISCNUMBER-tag as grouping criteria, just like album name aswell as artist


I think the best thing I can suggest to achieve this result is to do it in two passes. First, starting in your root music folder, use Windows Explorer to search for "CD 1" (or even "filename:cd1 kind:folder" if you are getting false positives). That will give you a list of all your CD 1 folders, so grab those, drag and drop them onto a fresh AAD File Browser window. Once you've dealt with all the albums in your CD 1 folders, you can then repeat the process with a new fresh file browser window, but in Windows Explorer search for "CD 2" instead.

Not ideal, I know, but then treating the directories separately and downloading twice is never going to be ideal!

Alex

didn't know that i can just drag something from windows search window in AAD, thats probably the best way to first fix my current situation and then switch to "1 folder mode"

thanks everybody!
Title: Album Art Downloader XUI
Post by: Hamburger help us on 2013-08-25 14:09:49
Hello guys. What wrong in my foo_run config for Album Art Downloader ?
"F:\Программы\Установленные\AlbumArtDownloader\AlbumArt.exe" -ae on -pf on -ar "%album artist%" -al "%album%" -p "$replace(%_path%,'\'%_filename_ext%,)" -f "cover.'%'extension'%'"
errorlog:
Code: [Select]
>"F:\Программы\Установленные\AlbumArtDownloader\AlbumArt.exe" -ae on -pf on -ar "Bong" -al "Exhalation / Tonight We Pretend We Are Human Beings (12")" -p "D:\Музыка\#unsorted\Bong\2009 - Bong & Quttinirpaaq - Split EP" -f "cover.%extension%"

Album Art Downloader XUI version 1.0.0.0

**** Unexpected command line parameter:  ****

With other albums, everything is working fine. This first problem a few years of use this software. Sorry for bad english.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-08-25 15:48:46
Hello guys. What wrong in my foo_run config for Album Art Downloader ?

It looks like the problem here is that the album title has a " in it. So I guess a solution would be to use "$replace(%album%",'"','\"')" instead of "%album%"

I think ought to escape it so that " is replaced by \"

Alex
Title: Album Art Downloader XUI
Post by: Hamburger help us on 2013-08-25 16:50:46
Yes, everything works fine, but I think in the code "$replace(%album%", '"', '\"') " a red quotes is unnecessary. Alex thanks.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-08-28 21:52:05
I think I've said it before but because it is so true... Love this thing! Thanks for everything!

But... two minor quibbles?

1. The "Set default minimum size filter from largest result found" in Local Files (which I have to say I absolutely love!!!!) bleeds over into the other simultaneous searches. If have that set to 3 and it finds an 800px, a 700px and a 600px the results get filtered to either 800, 700 or 600 depending on what order those open in. Very minor, and since I generally sort by size before I "Get Artwork" I don't notice it often.

2. The Windows 7 taskbar icon does a progress bar "thing" as results load. However, it doesn't look like it includes the progress of loading full size images. Is it possible that the taskbar progress could be inclusive of all progresses?

Thanks again!

Matt
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-07 12:11:30

Thanks for your comments, and sorry for the delayed reply.

Unfortunately settings like the size filter are global application settings, so changing them is not going to play nicely with doing simultaneous searches. I appreciate that this does make the local sources auto-setting of that value less useful, but I don't want to change the whole settings model to provide individual filter settings per window.

If you have sources set to always download full size images (in the source settings) then that will be included in the task button progress indicator, as the result will only be included once the image is downloaded. If you are using the global "Automatically download full-size images" setting, though, then this runs in the background. The search is still complete once all sources have finished returning their results (with thumbnails), and that's what the progress indicator is showing. The background task to download full-size images will just keep going as long as there are more thumbnails that need replacing with full size images, but it doesn't mean that the results aren't already ready for viewing.

I think it's appropriate that the progress indicates completion when all the results are available, even if background work to download full-size images for those results continues.

Alex
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-09-07 23:10:23
Unfortunately settings like the size filter are global application settings, so changing them is not going to play nicely with doing simultaneous searches. I appreciate that this does make the local sources auto-setting of that value less useful, but I don't want to change the whole settings model to provide individual filter settings per window.


As I said, I sort by descending size first so I notice it rarely. Just wanted to make sure it was a known "thing".

I think it's appropriate that the progress indicates completion when all the results are available, even if background work to download full-size images for those results continues.


I would respectfully disagree. I think that a progress bar for Window X should indicate that Window X is still doing something (foreground or background) and that it is not yet a finished thing BUT since there is a work around... That works in the meantime.

All that said, I cannot say enough times how much help AAD has been in cleaning up the cover art I have in my collection. THANKS!

BTW: Have you seen the Firefox plugin azid (http://www.craue.de/azid/) that is able to reconstruct the multipart Zoom images from the Amazon MP3 store. When I used azid it was able to pull a 1400x1400 cover from behind the scenes at Amazon BUT of course I need to individually search for and find each album before I'm able to use that FF plugin.

Thanks again!

Matt
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-08 08:11:14
Have you seen the Firefox plugin azid (http://www.craue.de/azid/) that is able to reconstruct the multipart Zoom images from the Amazon MP3 store.

No, I hadn't seen that, thanks for the tip. In principle, if Firefox and a plugin can do it, it ought to be possible for an AAD script to do too. Whether that would just kick off an arms race of amazon adding further protection for their larger images or if they just wouldn't care, I don't know!
Title: Album Art Downloader XUI
Post by: marc2003 on 2013-09-08 08:26:55
i recently noticed some high quality images on amazon and AAD already fetches them. i've just pre-ordered Emilíana Torrini - Tookah and you can download 1500x1500px art just by clicking the image to expand and then right clicking>save as. no addons required.

UK: http://www.amazon.co.uk/Tookah-Emiliana-To...3764&sr=8-1 (http://www.amazon.co.uk/Tookah-Emiliana-Torrini/dp/B00DYZ80FK/ref=sr_1_1?ie=UTF8&qid=1378593764&sr=8-1)
US: http://www.amazon.com/Tookah-Emiliana-Torr...4655&sr=8-1 (http://www.amazon.com/Tookah-Emiliana-Torrini/dp/B00DYZ80FK/ref=sr_1_1?ie=UTF8&qid=1378594655&sr=8-1)

if you search for this album in AAD, it actually returns a 2560x2560 image. 
Title: Album Art Downloader XUI
Post by: Mister fresh 1234 on 2013-09-08 12:10:04
Is it possible to save the artwork in the folder where the music files are?

in foobar I typed $puts(cpath4,$replace(C:\Users\UserName\Pictures\Album Art\%artist%\%album%,%filename_ext%,folder.jpg))
to find the cover sources, but is does not work

so now I have the music on one hard drive and the cover art on another hard drive, and seems impossible to join them.

I'd like to tell Album Art Downloader to save the images in the location of the music files to avoid this.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-08 16:02:05
Is it possible to save the artwork in the folder where the music files are?

Yes, from foobar2000 this is generally done by using the parameter /p "$replace(%path%,%filename_ext%,)folder.%%extension%%" (rather than hard-coding the location as in your example)

Alex
Title: Album Art Downloader XUI
Post by: Mister fresh 1234 on 2013-09-08 17:34:40
Is it possible to save the artwork in the folder where the music files are?

Yes, from foobar2000 this is generally done by using the parameter /p "$replace(%path%,%filename_ext%,)folder.%%extension%%" (rather than hard-coding the location as in your example)

Alex


Thanks for your answer Alex, but I'm not sure I understand.

My music is on the hard drive E:.
In AAD I left the default settings which means it saves the pictures to C:\Users\UserName\Pictures\Album Art\%artist%\%album%\Folder%preset%.%extension%

And in foobar I have these 3 cover sources defined in Settings (using Slides 1.8 and foobar 1.29) :
$puts(cpath1,$replace(%path%,%filename_ext%,*folder*.*))
$puts(cpath2,$replace(%path%,%filename_ext%,*))
$puts(cpath3,$replace(%path%,%directory%\%filename_ext%,*))
I believe these 3 cover sources point to E: in the %path% variable.

so either I need to define a 4th cover source in foobar that points to C:\Users\UserName\Pictures\Album Art\%artist%\%album%,
or I need to be able to tell AAD to save pictures in E: in the same folder where the music files are, so that one of the 3 already existing cover sources can pick up the cover art.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-08 17:56:05

Ah, OK, I misunderstood where you were coming from. So you aren't launching AAD from Foobar2000, then? In that case, the question is, where are you starting from? - if you are just typing in an artist and album name then there's no way it can know where your music is, and therefore how to save to that location, unless you use a strict naming convention (like using E:\Music\%artist%\%album%\Folder%preset%.%extension% for example).

If you are starting from the File Browser then it should already be saving music to the folder in which it finds the album - just make sure that the "Specify path to find images" box in the File Browser options is a relative path, not an absolute one. The default is Folder%preset%.%extension%|Cover%preset%.%extension% Just Folder.jpg would do the job under most circumstances, though!
Title: Album Art Downloader XUI
Post by: Mister fresh 1234 on 2013-09-08 18:51:52

Ah, OK, I misunderstood where you were coming from. So you aren't launching AAD from Foobar2000, then? In that case, the question is, where are you starting from? - if you are just typing in an artist and album name then there's no way it can know where your music is, and therefore how to save to that location, unless you use a strict naming convention (like using E:\Music\%artist%\%album%\Folder%preset%.%extension% for example).

If you are starting from the File Browser then it should already be saving music to the folder in which it finds the album - just make sure that the "Specify path to find images" box in the File Browser options is a relative path, not an absolute one. The default is Folder%preset%.%extension%|Cover%preset%.%extension% Just Folder.jpg would do the job under most circumstances, though!


In foobar when I see an album without cover art I right click, then click on "Cover Search" in the context menu. This starts AAD and finds cover art that it saves to a default folder which is "C:\Users\UserName\Pictures\Album Art\%artist%\%album%\Folder%preset%.%extension%".

But I'm thinking to go the other way round. Instead of trying to put the pictures in same folders as the music, just tell foobar to search for the pictures in right place.

so this is the default in foobar : $puts(cpath1,$replace(%path%,%filename_ext%,*folder*.*)) . this tells foobar: "search for a file named folder in the same directory as the track played".

I want to tell foobar "go search in  C:\Users\UserName\Pictures\Album Art\%artist%\%album% and take any image file there

the thing is I'm not sure about how to tell the path in C++

I tried $puts(cpath1,$replace(C:\Users\UserName\Pictures\Album Art\%artist%\%album%,%filename_ext%,*)) but does not work. any idea what would be the correct syntax?

Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-09 08:10:42
I want to tell foobar "go search in  C:\Users\UserName\Pictures\Album Art\%artist%\%album% and take any image file there

the thing is I'm not sure about how to tell the path in C++

I tried $puts(cpath1,$replace(C:\Users\UserName\Pictures\Album Art\%artist%\%album%,%filename_ext%,*)) but does not work. any idea what would be the correct syntax?

Seems to me that you don't need $replace in there at all. Why not just: $puts(cpath1,C:\Users\UserName\Pictures\Album Art\%artist%\%album%\*.jpg) ? Or instead of *.jpg, perhaps folder.* or even folder.jpg, or whatever you know your image files will be named as. Just plain * might work, but it will be trying to load all files in that folder as images - it ought to be smart enough to keep trying until it finds one it can load, I guess.

Alex
Title: Album Art Downloader XUI
Post by: Mister fresh 1234 on 2013-09-09 22:13:16
I want to tell foobar "go search in  C:\Users\UserName\Pictures\Album Art\%artist%\%album% and take any image file there

the thing is I'm not sure about how to tell the path in C++

I tried $puts(cpath1,$replace(C:\Users\UserName\Pictures\Album Art\%artist%\%album%,%filename_ext%,*)) but does not work. any idea what would be the correct syntax?

Seems to me that you don't need $replace in there at all. Why not just: $puts(cpath1,C:\Users\UserName\Pictures\Album Art\%artist%\%album%\*.jpg) ? Or instead of *.jpg, perhaps folder.* or even folder.jpg, or whatever you know your image files will be named as. Just plain * might work, but it will be trying to load all files in that folder as images - it ought to be smart enough to keep trying until it finds one it can load, I guess.

Alex


hi,
well in the end this motivated me to reorganize all my folders using a strict structure (E:\Music\%artist%\%album%). It took a few hours but at least now AAD works as it should. I used MediaMonkey, it did a good job. it took me a bit of time to get the settings I wanted with AAD but now I think it works well and is very useful, so thanks for making it available.
Title: Album Art Downloader XUI
Post by: matt the cat on 2013-09-16 16:46:13
I have the following problem, I cant for some reason get AAD to work anymore.
That's a weird one. Can you check if there is a file called AlbumArt.exe.config in the same folder as your AlbumArt.exe? If so, try deleting that. If not, or if it still doesn't work, then try resetting the settings by deleting the folder %localappdata%\AlbumArtDownloader



Sorry for the really late reply. I have neither of the file/folder you mentioned. Also whats even more strange neither the ZIPped stand-alone version work, I get the same thing... I'd really like to get this working as its a lifesaver.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-16 19:30:21
I have neither of the file/folder you mentioned.

Huh. So you haven't got any .config file, either as AlbumArt.exe.config, or in %localappdata%, but it's throwing an error complaining about an invalid connectionStrings section in the config file. Not really sure where it's getting that config from! I suppose it's always possible something has gone wrong with your machine-level config file. Could you check C:\Windows\Microsoft.NET\Framework\v2.0.50727\CONFIG\machine.config and search for connectionStrings? It should look like this:

Code: [Select]
  <connectionStrings>
    <add name="LocalSqlServer" connectionString="data source=.\SQLEXPRESS;Integrated Security=SSPI;AttachDBFilename=|DataDirectory|aspnetdb.mdf;User Instance=true" providerName="System.Data.SqlClient" />
  </connectionStrings>

Alex
Title: Album Art Downloader XUI
Post by: MrMonkey on 2013-09-23 13:57:22
I'm getting this error no matter what I search on.  I tried uninstalling and re-installing.  Win 7 x64.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\Greg\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Windows.Markup.XamlParseException: Cannot convert the value in attribute 'Style' to object of type 'System.Windows.Style'. '65535' glyph index is not valid for the specified font.
Parameter name: glyphIndex  Error at object 'System.Windows.Controls.TextBlock' in markup file 'Controls/Xaml/ArtPanel.generic.xaml'. ---> System.ArgumentOutOfRangeException: '65535' glyph index is not valid for the specified font.
Parameter name: glyphIndex ---> System.ArgumentOutOfRangeException: '65535' glyph index is not valid for the specified font.
Parameter name: glyphIndex
  at MS.Internal.FontCache.FontFaceLayoutInfo.Metrics(UInt16 glyphIndex)
  at System.Windows.Media.GlyphTypeface.GetAdvanceWidth(UInt16 glyph)
  at System.Windows.Media.TextFormatting.TextShapeableCharacters.GetAdvanceWidthsUnshaped(Char* characterString, Int32 characterLength, Double scalingFactor, Int32* advanceWidthsUnshaped)
  at MS.Internal.TextFormatting.LineServicesCallbacks.GetRunCharWidths(IntPtr pols, Plsrun plsrun, LsDevice device, Char* charString, Int32 stringLength, Int32 maxWidth, LsTFlow textFlow, Int32* charWidths, Int32& totalWidth, Int32& stringLengthFitted)
  --- End of inner exception stack trace ---
  at MS.Internal.TextFormatting.TextMetrics.FullTextLine.FormatLine(FullTextState fullText, Int32 cpFirst, Int32 lineLength, Int32 formatWidth, Int32 finiteFormatWidth, Int32 paragraphWidth, LineFlags lineFlags, FormattedTextSymbols collapsingSymbol)
  at MS.Internal.TextFormatting.TextMetrics.FullTextLine..ctor(FormatSettings settings, Int32 cpFirst, Int32 lineLength, Int32 paragraphWidth, LineFlags lineFlags)
  at MS.Internal.TextFormatting.TextFormatterImp.FormatLineInternal(TextSource textSource, Int32 firstCharIndex, Int32 lineLength, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak, TextRunCache textRunCache)
  at MS.Internal.TextFormatting.TextFormatterImp.FormatLine(TextSource textSource, Int32 firstCharIndex, Double paragraphWidth, TextParagraphProperties paragraphProperties, TextLineBreak previousLineBreak)
  at System.Windows.Media.FormattedText.LineEnumerator.FormatLine(TextSource textSource, Int32 textSourcePosition, Double maxLineLength, TextParagraphProperties paraProps, TextLineBreak lineBreak)
  at System.Windows.Media.FormattedText.LineEnumerator.MoveNext()
  at System.Windows.Media.FormattedText.DrawAndCalculateMetrics(DrawingContext dc, Point drawingOffset, Boolean getBlackBoxMetrics)
  at System.Windows.Media.FormattedText.get_Metrics()
  at System.Windows.Media.FormattedText.get_Width()
  at AlbumArtDownloader.Controls.Utilities.FormattedTextInfo..ctor(String text, CultureInfo culture, TextBlock textBlock)
  at AlbumArtDownloader.Controls.Utilities.GetTextWidth(String text, TextBlock textBlock, CultureInfo culture)
  at AlbumArtDownloader.Controls.TooltipEnabledOnOverflowConverter.Convert(Object[] values, Type targetType, Object parameter, CultureInfo culture)
  at System.Windows.Data.MultiBindingExpression.TransferValue()
  at System.Windows.Data.MultiBindingExpression.UpdateTarget(Boolean includeInnerBindings)
  at System.Windows.Data.MultiBindingExpression.AttachOverride(DependencyObject d, DependencyProperty dp)
  at System.Windows.Data.BindingExpressionBase.Attach(DependencyObject target, DependencyProperty dp)
  at System.Windows.StyleHelper.GetInstanceValue(UncommonField`1 dataField, DependencyObject container, FrameworkElement feChild, FrameworkContentElement fceChild, Int32 childIndex, DependencyProperty dp, Int32 i, EffectiveValueEntry& entry)
  at System.Windows.StyleHelper.GetChildValueHelper(UncommonField`1 dataField, ItemStructList`1& valueLookupList, DependencyProperty dp, DependencyObject container, FrameworkObject child, Int32 childIndex, Boolean styleLookup, EffectiveValueEntry& entry, ValueLookupType& sourceType, FrameworkElementFactory templateRoot)
  at System.Windows.StyleHelper.GetChildValue(UncommonField`1 dataField, DependencyObject container, Int32 childIndex, FrameworkObject child, DependencyProperty dp, FrugalStructList`1& childRecordFromChildIndex, EffectiveValueEntry& entry, ValueLookupType& sourceType, FrameworkElementFactory templateRoot)
  at System.Windows.StyleHelper.GetValueFromStyleOrTemplate(FrameworkObject fo, DependencyProperty dp, EffectiveValueEntry& entry)
  at System.Windows.StyleHelper.ApplyStyleOrTemplateValue(FrameworkObject fo, DependencyProperty dp)
  at System.Windows.StyleHelper.InvalidateContainerDependents(DependencyObject container, FrugalStructList`1& exclusionContainerDependents, FrugalStructList`1& oldContainerDependents, FrugalStructList`1& newContainerDependents)
  at System.Windows.StyleHelper.DoStyleInvalidations(FrameworkElement fe, FrameworkContentElement fce, Style oldStyle, Style newStyle)
  at System.Windows.StyleHelper.UpdateStyleCache(FrameworkElement fe, FrameworkContentElement fce, Style oldStyle, Style newStyle, Style& styleCache)
  at System.Windows.FrameworkElement.OnStyleChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
  at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  at System.Windows.Controls.TextBlock.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
  at System.Windows.TemplateApplicationHelper.SetDependencyValueCore(DependencyObject dependencyObject, DependencyProperty dp, Object value)
  at System.Windows.Markup.BamlRecordReader.SetPropertyValue(Object o, PropertyDefinition propertyDefinition, Object value)
  at System.Windows.Markup.BamlRecordReader.BaseReadOptimizedMarkupExtension(Object element, Int16 attributeId, PropertyDefinition propertyDefinition, Object value)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
  at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
  at System.Windows.Markup.BamlRecordReader.BaseReadOptimizedMarkupExtension(Object element, Int16 attributeId, PropertyDefinition propertyDefinition, Object value)
  at System.Windows.Markup.BamlRecordReader.ReadPropertyWithStaticResourceIdRecord(BamlPropertyWithStatic
ResourceIdRecord bamlPropertyWithStaticResourceIdRecord)
  at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
  at System.Windows.StyleHelper.LoadOptimizedTemplateContent(DependencyObject container, ParserContext parserContext, OptimizedTemplateContent optimizedTemplateContent, FrameworkTemplate frameworkTemplate, IComponentConnector componentConnector, IStyleConnector styleConnector, List`1 affectedChildren, UncommonField`1 templatedNonFeChildrenField)
  at System.Windows.FrameworkTemplate.LoadContent(DependencyObject container, List`1 affectedChildren, UncommonField`1 templatedNonFeChildrenField)
  at System.Windows.StyleHelper.ApplyTemplateContent(UncommonField`1 dataField, DependencyObject container, FrameworkElementFactory templateRoot, Int32 lastChildIndex, HybridDictionary childIndexFromChildID, FrameworkTemplate frameworkTemplate)
  at System.Windows.FrameworkTemplate.ApplyTemplateContent(UncommonField`1 templateDataField, FrameworkElement container)
  at System.Windows.FrameworkElement.ApplyTemplate()
  at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  at System.Windows.UIElement.Measure(Size availableSize)
  at MS.Internal.Helper.MeasureElementWithSingleChild(UIElement element, Size constraint)
  at System.Windows.Controls.ContentPresenter.MeasureOverride(Size constraint)
  at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
  at System.Windows.UIElement.Measure(Size availableSize)
  at System.Windows.ContextLayoutManager.UpdateLayout()
  at System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
  at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
  at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
  at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Application.RunInternal(Window window)
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-24 07:55:58
I'm getting this error no matter what I search on.  I tried uninstalling and re-installing.  Win 7 x64.

Looks to me like your installation of WPF is broken or corrupt in some way. You could try uninstalling and re-installing the .NET Framework, but other than that, I don't really know what to suggest, sorry.

Alex
Title: Album Art Downloader XUI
Post by: MrMonkey on 2013-09-24 14:23:15
You could try uninstalling and re-installing the .NET Framework, but other than that, I don't really know what to suggest, sorry.

Before trying a complete re-install, I installed all pending Windows updates (other than driver updates) and the issue seems to have been resolved. 
Not sure how or why it broke but looks to me that it obviously wasn't an issue with AAD. Thank you.
Title: Album Art Downloader XUI
Post by: 정영석 on 2013-09-28 09:16:34
Why don't you add Microsoft Music Shop Site (Site : Microsoft Music Shop Site (http://shopformusic.microsoft.com/)) and Google Play Music Site?

(How about add Microsoft Music Shop Site (Site : Microsoft Music Shop Site (http://shopformusic.microsoft.com/)) and Google Play Music Site?)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-28 14:18:25
Why don't you add Microsoft Music Shop Site (Site : Microsoft Music Shop Site (http://shopformusic.microsoft.com/)) and Google Play Music Site?

The Microsoft site didn't seem to be anything other than a list of internet radio stations for me - no album search. Maybe it's an IP geolocation thing, I don't know, but in any case if I can't access it, I can't do a script for it.

Google Play Music, on the other hand, does look quite promising, with good quality high res images. Here's a script for it, if you'd like to try it out and give me any comments before I make it available through online updates: google-play.boo (http://album-art.sourceforge.net/scripts/google-play.boo). It would also be useful to know if you find any full-size images that are not 1448×1448 pixels - if I can be reasonably sure that they are all that size, I will have the script report them as such rather than "Unknown".

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-09-29 23:51:08
most of my library, while in the artist/album directory setup has additional unique identifiers after most, but not albums:
How about: \%artist%\%album%"(?: \(\d+\) \([\dA-F]+\))?"\*

That should ignore the bit at the end of the album folder so long as: it starts with a space, has a number in brackets, followed by a space, followed by a hex code (digits 0-9, A-F) in brackets.


Alex


Alex, thank you for the formatting above. How can I also get the search to ignore (Disc #)?
Is this correct:

Code: [Select]
\%artist%\%album%"(?: \(\d+\) \([\dA-F]+\) \(Disc \d+\))?"\*


Thanks as always!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-09-30 08:09:11
Alex, thank you for the formatting above. How can I also get the search to ignore (Disc #)?

The code you suggested would work just fine if the disc number bit was always on the end. If you want to make it optional, though, you need it in it's own optional group:
Code: [Select]
\%artist%\%album%"(?: \(\d+\) \([\dA-F]+\))?(?: \(Disc \d+\))?"\*


Açex
Title: Album Art Downloader XUI
Post by: LifeWOutMilk on 2013-09-30 18:03:15
It would also be useful to know if you find any full-size images that are not 1448×1448 pixels - if I can be reasonably sure that they are all that size, I will have the script report them as such rather than "Unknown".


First album I searched for is 1200x1200 (David Bowie - Earthling).

Edit: Also got 900x896 for another.
Title: Album Art Downloader XUI
Post by: thomasalbumartdownloader on 2013-10-12 14:22:51
Hello,

I installaed in a new SSD (Windows 7 Professional 64 bit) the Album Art Downloader, but after reboot I cannot start the app successfully.

I may read this text:


Searching for scripts...
Found 41 files: [45cat.boo, 7digital.boo, allcdcover.boo, amazon-ca.boo, amazon-co-uk.boo, amazon-com.boo, amazon-common.boo, amazon-de.boo, amazon-fr.boo, amazon-it.boo, amazon-jp.boo, amazon-mp3-com.boo, archambault.boo, arkivmusic.boo, audiopreservationfund.boo, buy-com.boo, chartstats.boo, cover-paradies.boo, coveralia.boo, coverlandia-official.boo, coverlandia.boo, deejay.boo, deezer.boo, discogs.boo, djshop.boo, eclassical.boo, emusic.boo, fanarttv.boo, google.boo, hitparade.boo, hyperionrecords.boo, itunes.boo, lastfm-artist.boo, lastfm-cover.boo, maniadb.boo, medianet.boo, musicbrainz.boo, qobuz.boo, soundstation.boo, theclassicalshop.boo, util.boo]...
Loading references: [System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web]...
Compiling scripts...
(-1,-1): error BCE0011: An error occurred during the execution of the step 'Boo.Lang.Compiler.Steps.SaveAssembly': 'Zugriff verweigert (Ausnahme von HRESULT: 0x80070005 (E_ACCESSDENIED))'.



The most important message of this text is:

(-1,-1): error BCE0011: An error occurred during the execution of the step 'Boo.Lang.Compiler.Steps.SaveAssembly': 'Access denied (Ausnahme exception from HRESULT: 0x80070005 (E_ACCESSDENIED))'.



I do not understand the reason and I cannot use the Album Art Downloader. How to install and use the Album Art Downloader correctly.

I made the installation at the first installation to C:\Program Files, without success. After uninstalling to C:\Program Files (x86), but again without success.

What is to do for getting solution?

Thanks for your clear, considered and thoughtful response.

Thomas
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-10-12 17:59:08
The most important message of this text is:

(-1,-1): error BCE0011: An error occurred during the execution of the step 'Boo.Lang.Compiler.Steps.SaveAssembly': 'Access denied (Ausnahme exception from HRESULT: 0x80070005 (E_ACCESSDENIED))'.

Hello,

The problem here is that Album Art Downloader no longer has permissions to write to the location where it saves the cached compiled scripts. This is probably because you are not running it as the same user account that created the folder initially. To fix this, please go to %LOCALAPPDATA% (you can paste that into windows explorer - it should take you to C:\Users\<username>\AppData\Local). Then find the folder called "AlbumArtDownloader" and delete it. This will reset your album art downloader settings, but will allow it to run again properly.

Of course, alternatively, you could reset the permissions for the folder so that the user that you run Album Art Downloader as has write permissions to it, but that's more complicated to explain, so simply deleting the folder is the easiest solution!

Regards,

Alex
Title: Album Art Downloader XUI
Post by: thomasalbumartdownloader on 2013-10-12 19:11:14
Thank you for this very good idea. I tried it as sser (named 'AndreaSchatz') with Admin-Rights and deleted the folder. Without reboot and again with reboot I started the application Album Art Downloader again and I got this following error-txt. As Admin I made the same and received the same result. Now I do not know, what to do.

error-txt:

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\AndreaSchatz\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.ArgumentException: Die SearchPathPatternHistory-Eigenschaft konnte nicht aus ihrem Standardwert erstellt werden. Fehlermeldung: Temporäre Klasse kann nicht generiert werden (result=1).
error CS0016: In die Ausgabedatei c:\Users\AndreaSchatz\AppData\Local\Temp\l914z1aw.dll konnte nicht geschrieben werden -- Zugriff verweigert .

  bei System.Configuration.SettingsPropertyValue.Deserialize()
  bei System.Configuration.SettingsPropertyValue.get_PropertyValue()
  bei System.Configuration.SettingsBase.get_Item(String propertyName)
  bei System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
  bei AlbumArtDownloader.LocalFilesSource.LoadPathPatternHistory(Settings localFilesSourceSettings)
  bei AlbumArtDownloader.ArtSearchWindow.LoadSourceSettings()
  bei AlbumArtDownloader.ArtSearchWindow.LoadSettings()
  bei AlbumArtDownloader.ArtSearchWindow..ctor()
  bei AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  bei System.Windows.Application.<.ctor>b__0(Object unused)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
  bei System.Threading.ExecutionContext.runTryCode(Object userData)
  bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  bei System.Windows.Threading.DispatcherOperation.Invoke()
  bei System.Windows.Threading.Dispatcher.ProcessQueue()
  bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  bei System.Windows.Application.RunInternal(Window window)
  bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  bei AlbumArtDownloader.App.Main(String[] args)

Note:

System.ArgumentException: Die SearchPathPatternHistory-Eigenschaft konnte nicht aus ihrem Standardwert erstellt werden. Fehlermeldung: Temporäre Klasse kann nicht generiert werden (result=1).
error CS0016: In die Ausgabedatei c:\Users\AndreaSchatz\AppData\Local\Temp\l914z1aw.dll konnte nicht geschrieben werden -- Zugriff verweigert .

Translated with Google:
System.ArgumentException: The SearchPathPatternHistory property could not be created from its default value. Error message: Unable to generate a temporary class (result=1).
error CS0016: In the output file c:\Users\AndreaSchatz\AppData\Local\Temp\l914z1aw.dll could not be written - Access is denied.


I think, that I need a very big help.
Thank you for your help.

Thomas
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-10-12 20:09:35
error CS0016: In die Ausgabedatei c:\Users\AndreaSchatz\AppData\Local\Temp\l914z1aw.dll konnte nicht geschrieben werden -- Zugriff verweigert .

That looks to me like your current user has no permissions to write to your temporary folder "c:\Users\AndreaSchatz\AppData\Local\Temp\" either! I am surprised not more programs on your computer are not working, if this is the case. I am not sure if you can just delete and recreate the "Temp" folder, but it is worth a try. If not, then try to give yourself full control permissions to that folder (and really, you should have it to all folders under c:\Users\AndreaSchatz) by right clicking on it, choosing Properties, then the Security tab, click Edit, Add then add your user (AndreaSchatz) to the list, and check the Allow box next to Full Control.

This is all a bit outside the scope of this thread - you should be able to find information on how to fix permissions through searching (probably even with the German names for the buttons and so on, that I don't know!), but if you are really stuck PM me and we can take this offline.

Alex
Title: Album Art Downloader XUI
Post by: thomasalbumartdownloader on 2013-10-13 15:08:45
error CS0016: In die Ausgabedatei c:\Users\AndreaSchatz\AppData\Local\Temp\l914z1aw.dll konnte nicht geschrieben werden -- Zugriff verweigert .

That looks to me like your current user has no permissions to write to your temporary folder "c:\Users\AndreaSchatz\AppData\Local\Temp\" either! I am surprised not more programs on your computer are not working, if this is the case. I am not sure if you can just delete and recreate the "Temp" folder, but it is worth a try. If not, then try to give yourself full control permissions to that folder (and really, you should have it to all folders under c:\Users\AndreaSchatz) by right clicking on it, choosing Properties, then the Security tab, click Edit, Add then add your user (AndreaSchatz) to the list, and check the Allow box next to Full Control.

This is all a bit outside the scope of this thread - you should be able to find information on how to fix permissions through searching (probably even with the German names for the buttons and so on, that I don't know!), but if you are really stuck PM me and we can take this offline.

Alex




Thank you, I will do my best and will try all. If this would be without success, I would come back to your kind offer of PM. Thank you for your PM-offer.

Kind regards

Thomas
Title: Album Art Downloader XUI
Post by: thomasalbumartdownloader on 2013-10-13 18:29:37
Now I can use the program. The reason was another owner of the explained temp-folder. Thank you again for your kind help.

Thomas
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-10-19 07:14:19
Alex,

I was wondering if it might be possible for you to change the file dialogs that are used inside the program (when you click the ... buttons to manually choose a save location) to use the current Windows IFileDialog's. Obviously not a huge issue, but I often do a lot of saving in different locations and I miss the "Favorites" and "Libraries" folder shortcuts that the IFileDialog's provide. If my 2012 install wasn't screwing up, I'd take a look at doing this myself, but it's crashing whenever I try and open a file from this (or any) solution.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-10-19 08:13:39
I was wondering if it might be possible for you to change the file dialogs that are used inside the program

I've done a bit of research into this. It seems that WPF under .NET 3.5 does not support the vista-style dialogs. There is support for them in .NET 4, however I'm not sure I really want to require users to install the .NET 4 runtime just to get these dialogs...

Alex
Title: Album Art Downloader XUI
Post by: MordredKLB on 2013-10-19 17:44:11
I was wondering if it might be possible for you to change the file dialogs that are used inside the program

I've done a bit of research into this. It seems that WPF under .NET 3.5 does not support the vista-style dialogs. There is support for them in .NET 4, however I'm not sure I really want to require users to install the .NET 4 runtime just to get these dialogs...

Alex

Didn't realize that was the case with WPF. Forcing 4.0 is kind of a hassle, but probably not the end of the world.

If you didn't want to force .NET 4 it looks like you can use the Ookii dialog classes (http://www.ookii.org/software/dialogs/) in WPF instead to provide the updated dialogs. Sounds like it's a pretty easy transition, so it might be worth looking into.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-10-20 08:11:56
Didn't realize that was the case with WPF. Forcing 4.0 is kind of a hassle, but probably not the end of the world.

If you didn't want to force .NET 4 it looks like you can use the Ookii dialog classes (http://www.ookii.org/software/dialogs/) in WPF instead to provide the updated dialogs. Sounds like it's a pretty easy transition, so it might be worth looking into.

Thanks for the tip, that Ookii library looks pretty good, I might include it in any next release. For the moment, if you have .NET 4 installed, you can make AAD use it with a config file like this one: AlbumArt.exe.config (http://album-art.sourceforge.net/Support%20CLR4%20-%20AlbumArt.exe.config). Save it as AlbumArt.exe.config in your AAD program folder (next to AlbumArt.exe) and it will instruct it to run under CL4 if available. If you already have an AlbumArt.exe.config file, then you can edit it so that it ends with:

Code: [Select]
    <startup>
        <supportedRuntime version="v4.5" />
        <supportedRuntime version="v4.0" />
        <supportedRuntime version="v2.0.50727" />
    </startup>    
</configuration>

If you decide to try this, let me know if you notice any adverse effects. If not, I might try shipping a config file like that as part of the installer.

Alex
Title: Album Art Downloader XUI
Post by: lvqcl on 2013-10-20 08:23:42
if you notice any adverse effects.

With this file AAD stores its settings in another folder. I have to manually copy user.config file.
Title: Album Art Downloader XUI
Post by: marc2003 on 2013-10-20 08:44:13
as i have an XP virtual machine without .net4, i tested AAD with this new config file and it still works as normal.

and it works as expected giving the new dialog on my windows 7 pc which has .net4.5
Title: Album Art Downloader XUI
Post by: GHammer on 2013-10-21 02:07:39
Using Windows 8.1 Pro, what do you think the problem is?

Code: [Select]
Loading references: [System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, System.Web]...
Error: Could not load file or assembly 'file:///D:\Program Files\AlbumArtDownloaderXUI\Boo.Lang.Parser.dll' or one of its dependencies. Operation is not supported. (Exception from HRESULT: 0x80131515)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-10-21 08:18:15
Using Windows 8.1 Pro, what do you think the problem is?
My best guess is that Windows thinks that dll is untrusted for some reason. This could be either because the folder its in is untrusted, or the dll itself is marked as untrusted. As it appears to be in Program Files\AlbumArtDownloaderXUI it's unlikely that the whole folder is untrusted, or AAD itself wouldn't be allowed to run. Try right clicking on the Boo.Lang.Parser.dll file in D:\Program Files\AlbumArtDownloaderXUI and choosing properties. If there is an "Unblock" button then you can click that and it should work next time you run AAD.

Alex
Title: Album Art Downloader XUI
Post by: GHammer on 2013-10-22 01:07:41
Thanks for the reply.
Actually, it has to do with the AlbumArt.exe.config file.
I have the one that you posted in the directory and get the failure.
If I move AlbumArt.exe.config out of the directory, AAD runs as usual.
Here's the contents of the config file
Code: [Select]
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
      <startup>
        <supportedRuntime version="v4.5" />
        <supportedRuntime version="v4.0" />
        <supportedRuntime version="v2.0.50727" />
    </startup>
</configuration>
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-10-22 08:31:17
Actually, it has to do with the AlbumArt.exe.config file.
In that case, I'm afraid I haven't a clue. Presumably you have .NET 4 runtime installed, so with the config file present it will be running AAD using that - but why .NET 4 should consider the Boo.Lang.Parser.dll to be blocked but .NET 3.5 does not, that's a mystery. I should just stick with .NET 3.5, not using the config file.

Alex
Title: Album Art Downloader XUI
Post by: GHammer on 2013-10-23 15:21:45
Actually, it has to do with the AlbumArt.exe.config file.
In that case, I'm afraid I haven't a clue. Presumably you have .NET 4 runtime installed, so with the config file present it will be running AAD using that - but why .NET 4 should consider the Boo.Lang.Parser.dll to be blocked but .NET 3.5 does not, that's a mystery. I should just stick with .NET 3.5, not using the config file.

Alex



I think Windows 8/8.1 does not have .NET 3.x and you must follow a procedure to install it.
In any event, the .config file will fail on Windows 8/8.1
This is from MSDN (http://msdn.microsoft.com/en-us/library/hh506443.aspx)

Code: [Select]
If you are using the Windows operating system, the .NET Framework may  already be installed on your computer. Specifically, the .NET Framework  4.5 is included with Windows 8 and installed on your computer with the  Windows 8 operating system. Similarly, the .NET Framework 4.5.1 is  included with Windows 8.1                                                                                           
Important
There is no download for the .NET Framework 3.5 for  Windows 8 or Windows 8.1. You must enable the .NET Framework 3.5 in  Control Panel by following the instructions provided in this article.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-10-23 18:47:34
I think Windows 8/8.1 does not have .NET 3.x and you must follow a procedure to install it.
Hmm... interesting, so without the config file it won't run at all, then? Or does Windows 8.1 somehow automatically run it under .NET 4 anyway (giving you the vista-style save dialogs)? Either way, probably safest not to include the config in the installer, I think.

Alex
Title: Album Art Downloader XUI
Post by: LifeWOutMilk on 2013-10-24 01:22:52
Windows 8.1 Pro 64-bit here, with the above mentioned config file, Album Art Downloader works fine.
Title: Album Art Downloader XUI
Post by: GHammer on 2013-10-24 15:23:27
I think Windows 8/8.1 does not have .NET 3.x and you must follow a procedure to install it.
Hmm... interesting, so without the config file it won't run at all, then? Or does Windows 8.1 somehow automatically run it under .NET 4 anyway (giving you the vista-style save dialogs)? Either way, probably safest not to include the config in the installer, I think.

Alex



No, with the config file, AAD does not launch. Without the file, runs as usual.
I see someone else reports success so I have no idea. This is a plain vanilla, fresh install of Windows 8.1 Pro x64.
But, as long as AAD works, I'm a happy camper.
Title: Album Art Downloader XUI
Post by: LifeWOutMilk on 2013-10-24 17:26:12
What does your .NET selections show in the Windows Features control panel?

Mine is:

(http://i.imgur.com/AeXFI0i.png)
Title: Album Art Downloader XUI
Post by: hib on 2013-11-26 05:15:35
Hello,
fist off I would like to point out how incredibly grateful I am for this little gem of software you developed. I does indeed save me countless hours that I would otherwise spend searching, saving, moving and renaming my covers. 

Now, I do run it in a separate folder and although I'm not quite capable of writing my own script, i did manage to copy and modify various versions of Google Image Search script tailored to search in a few specific sites, restricted to a few specific image constraints.

My question today is (and I really don't mean to be rude in any way here) :

Did the script for Google Image Search completely stopped working or was it just me here?? 

I'm using windows 7 x64 English and I've tried both AAD v.0.46 and v.1.0, and both versions of the program with only the Google Image Script isolated. None of them work anymore, unfortunately.

I'm still looking into it, but I'm really curious if Google changed something yet again and the script stoped working; not just for me, but for everybody...

Thanks!

P.S.: I'm not quite sure if my English is good enough (I do use a little bit of assistance from Google Translator) and I apologize for my mistakes...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-11-26 18:34:32
Did the script for Google Image Search completely stopped working or was it just me here??
Hi, thanks for your comments, and your English is just fine. Yes, Google images has stopped working, thanks for reporting it. I've uploaded a new version which should work with their latest changes: google.boo (http://album-art.sourceforge.net/scripts/google.boo)

Alex
Title: Album Art Downloader XUI
Post by: hib on 2013-11-26 20:49:21
Yes, Google images has stopped working, thanks for reporting it. I've uploaded a new version which should work with their latest changes...

Wow! What a really fast response time! Thank you so much!
I downloaded the script and looked at it and I could see that you probably had to put a lot of working into it to change and make it start working again. I sincerely appreciate the time you spent, my gratitudes to you!

I noticed that the gbv switch had to be moved to =2 and I had a feeling that without control of JavaScript being on and off Google was automatically giving back the "new" blank pages where the images and links are added afterwards (unfortunately, I had not skills to make it work again). I saw that you had to employ a really complicated (for me) scheme to receive google's search response now, I was very intrigued. Still, I was able to modify the script to keep on grabbing my movie posters from many different sources using various versions of this plugin script.

Once again, thank you so much! Good job indeed!

P.S.: I feel almost ashamed of bringing this up, because it's not really a big deal but Deezer script here only gives 120x120px images, I don't know if they're blocking it somehow, but when I click the little "i", I can go to Firefox and view the image and modify the given 500x500px 80quality jpeg to display a 1500x1500px 99quality jpeg image whithout being blocked. I don't know if it's a geolocation thing blocking maybe? still, I wonder why I still can load the image just fine in Firefox...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-11-27 08:18:43
Deezer script here only gives 120x120px images

Yeah, the gbv=1 (no-script) version of the results from google image search has stopped including the url to the full size image, which makes it useless now. I had to switch to the gbv=2 dynamic version, and redo the script to parse the information out of that.

Thanks for reporting the issue with Deezer. The Deezer script previously used to request an image at 0x0 size, which the server would interpret as meaning full size. However, that now simply returns the word "unauthorized", so I guess they blocked that. As you have found, you can still request a variety of sizes, but I haven't found a way to specify "full size" without knowing what that size should be. Experimentation has shown that sizes over 1400x1400 tend to return "unauthorized" too, so what I've done is upload a modified deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo) that requests a 1400x1400 image. It's not ideal, as if the native size is smaller than that, it's silly to have the server upscale it then send down the enlarged large image! Anyway, please let me know if you find images that don't work with that script, or examples of specific urls to images that are available larger (for experimentation), but at least it's an improvement on 120x120.

Alex
Title: Album Art Downloader XUI
Post by: hib on 2013-11-27 18:57:00
Yeah, the gbv=1 (no-script) version of the results from google image search has stopped including the url to the full size image, which makes it useless now. I had to switch to the gbv=2 dynamic version, and redo the script to parse the information out of that.
Very interesting! Thanks for the information.

The Deezer script previously used to request an image at 0x0 size, which the server would interpret as meaning full size. However, that now simply returns the word "unauthorized", so I guess they blocked that. As you have found, you can still request a variety of sizes, but I haven't found a way to specify "full size" without knowing what that size should be. Experimentation has shown that sizes over 1400x1400 tend to return "unauthorized" too, so what I've done is upload a modified deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo) that requests a 1400x1400 image. It's not ideal, as if the native size is smaller than that, it's silly to have the server upscale it then send down the enlarged large image! Anyway, please let me know if you find images that don't work with that script, or examples of specific urls to images that are available larger (for experimentation), but at least it's an improvement on 120x120.

Thank you once again! You are a very hard worker! You have every reason to be very proud of your Software; we all thank you for that.
Title: Album Art Downloader XUI
Post by: djbuzz on 2013-12-01 10:27:04
Deezer script here only gives 120x120px images

Yeah, the gbv=1 (no-script) version of the results from google image search has stopped including the url to the full size image, which makes it useless now. I had to switch to the gbv=2 dynamic version, and redo the script to parse the information out of that.

Thanks for reporting the issue with Deezer. The Deezer script previously used to request an image at 0x0 size, which the server would interpret as meaning full size. However, that now simply returns the word "unauthorized", so I guess they blocked that. As you have found, you can still request a variety of sizes, but I haven't found a way to specify "full size" without knowing what that size should be. Experimentation has shown that sizes over 1400x1400 tend to return "unauthorized" too, so what I've done is upload a modified deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo) that requests a 1400x1400 image. It's not ideal, as if the native size is smaller than that, it's silly to have the server upscale it then send down the enlarged large image! Anyway, please let me know if you find images that don't work with that script, or examples of specific urls to images that are available larger (for experimentation), but at least it's an improvement on 120x120.

Alex


Hi Alex!
Thank you 1.000 times for this software!
The GoogleImage script has not been replaced in the distribution, can we have it, please?
Many thanks
DJBuzz
Title: Album Art Downloader XUI
Post by: djbuzz on 2013-12-01 11:02:03
Deezer script here only gives 120x120px images

Yeah, the gbv=1 (no-script) version of the results from google image search has stopped including the url to the full size image, which makes it useless now. I had to switch to the gbv=2 dynamic version, and redo the script to parse the information out of that.

Thanks for reporting the issue with Deezer. The Deezer script previously used to request an image at 0x0 size, which the server would interpret as meaning full size. However, that now simply returns the word "unauthorized", so I guess they blocked that. As you have found, you can still request a variety of sizes, but I haven't found a way to specify "full size" without knowing what that size should be. Experimentation has shown that sizes over 1400x1400 tend to return "unauthorized" too, so what I've done is upload a modified deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo) that requests a 1400x1400 image. It's not ideal, as if the native size is smaller than that, it's silly to have the server upscale it then send down the enlarged large image! Anyway, please let me know if you find images that don't work with that script, or examples of specific urls to images that are available larger (for experimentation), but at least it's an improvement on 120x120.

Alex


Never mind I found it in the SourceForge page...
Thanks again.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2013-12-03 19:37:27
Spent some time over the Thanksgiving holiday weekend doing some music library maintenance...

Any chance we could get a feature that if ONLY local results are found to automatically close and continue to the next in the queue? (No reason to wait if I already have it)

And while I'm wishing, an option to beep or play a sound when done searching? (On each Album not the entire queue, for when I let it run but I'm not sitting in front of my PC)

Either way, I love AAD! Thanks for everything!

Matt
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-04 19:43:02

Hmm... those requests seem a bit specialist to me! It's the sort of thing that you might use some sort of automation or scripting system for, but I don't think I want to add them to the already cluttered set of options available, sorry.

Alex
Title: Album Art Downloader XUI
Post by: Siekmanski on 2013-12-05 00:05:27
Quote
Yeah, the gbv=1 (no-script) version of the results from google image search has stopped including the url to the full size image, which makes it useless now. I had to switch to the gbv=2 dynamic version, and redo the script to parse the information out of that.


You can still use google.com to search for album covers.
The urls to the images are in the html file.

example: https://google.com/search?q=rammstein (https://google.com/search?q=rammstein) sehnsucht album cover&tbm=isch
Title: Album Art Downloader XUI
Post by: orcamilk on 2013-12-07 04:55:01
My machine (Win 7 64) appears to have upgraded to .Net 4.5. Since that, Album Art Downloader will not work. I have tried uninstalling .Net 4.5 and reverting to 3.5 but still no luck. I get this when I click AlbumArt.exe:

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 1.0.0.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Windows.Markup.XamlParseException: Provide value on 'System.Windows.Baml2006.TypeConverterMarkupExtension' threw an exception. ---> System.InvalidOperationException: Operation caused an invalid state. ---> System.Runtime.InteropServices.COMException: Exception from HRESULT: 0x88982F04
  --- End of inner exception stack trace ---
  at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
  at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
  at System.Windows.Media.Imaging.BitmapFrame.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy)
  at System.Windows.Media.ImageSourceConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
  at MS.Internal.Xaml.Runtime.ClrObjectRuntime.CallProvideValue(MarkupExtension me, IServiceProvider serviceProvider)
  --- End of inner exception stack trace ---
  at System.Windows.Markup.WpfXamlLoader.Load(XamlReader xamlReader, IXamlObjectWriterFactory writerFactory, Boolean skipJournaledProperties, Object rootObject, XamlObjectWriterSettings settings, Uri baseUri)
  at System.Windows.Markup.WpfXamlLoader.LoadBaml(XamlReader xamlReader, Boolean skipJournaledProperties, Object rootObject, XamlAccessLevel accessLevel, Uri baseUri)
  at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
  at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
  at AlbumArtDownloader.ArtSearchWindow..ctor()
  at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__1(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
  at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
  at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)

I have no idea what any of this means, apart from the first line, which saddens me. I have tried the addition of the AlbumArt.exe.config file as posted elsewhere in this thread but still no change...

Can anybody enlighten me as to how I might get this thing up and running again?

Thanks very much.
Title: Album Art Downloader XUI
Post by: hib on 2013-12-07 05:39:44
Hello, Alex,
just came here to give you a little feedback about the Deezer plugin:

- to this day, most albums are giving good results (1400x1400 .png images), but a few are still giving 120x120;
- I made a copy of the Deezer plugin, adjusted for 1200x1200 99-quality jpeg images and when the 1400x1400 .png fails I have used this with great success.

An album example where the 1400 fails is: Ana Tijoux - La Bala.

It's not a big deal for me, but maybe it's a good information for you to have.

Cheers!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-07 08:44:01
My machine (Win 7 64) appears to have upgraded to .Net 4.5. Since that, Album Art Downloader will not work. I have tried uninstalling .Net 4.5 and reverting to 3.5 but still no luck.

Searching around a bit seems to indicate that this is likely due to a windows update: KB2670838 (http://support.microsoft.com/kb/2670838) which broke a lot of things for a lot of people. Some advise that updating video drivers can solve the issue, and others recommend simply uninstalling that update.

An album example where [Deezer] 1400 fails is: Ana Tijoux - La Bala.

Thanks, that is good to know. So, it seems there's no specific size that can be relied upon - I'll have to make the script fall back trying smaller sizes until it finds one, I suppose. I've uploaded an update which starts as 1400x1400 then drops the size by 200 each time the image isn't found, and checks again: deezer.boo (http://album-art.sourceforge.net/scripts/deezer.boo)

Alex
Title: Album Art Downloader XUI
Post by: orcamilk on 2013-12-07 14:47:20
Alex, awesome advice. Uninstalled the update, turned on >NET 3.5 and bam! We're off again. Thanks so much.
Title: Album Art Downloader XUI
Post by: billybag on 2013-12-10 01:31:07
Ran into a very bizarre problem today. Been using AAD with Foobar for years and never have had an issue until today and it is ONLY with this one album. No other albums, not even from the same band, has given me a problem. Anyway, when i click on a song and choose to get cover, i instead a Album Art Downloader Command Line Perimeters window filled with a bunch of text. It looks like Notepad. Anyway. The text is this:

Code: [Select]
>"C:\Program Files\AlbumArtDownloader\albumart.exe" "Converge" "Downpour / Serial Killer 5" (Single)" "J:\Music\Converge\Downpour & Serial Killer [EP]\cover.jpg"

Album Art Downloader XUI version 1.0.0.0

**** Only the first three parameters may be un-named ****

Usage: albumart.exe [options]

Option names may be preceded by a / or a -
Options:

/artist      Artist to search for            (/artist "Artist Name")
              May be abbreviated to /ar       (/ar "Artist Name")
              Parameter name may be omitted
              if this is the first parameter  ("Artist Name")

/album       Album to search for             (/album "Album Name")
              May be abbreviated to /al       (/al "Album Name")
              Parameter name may be omitted
              if this is the second parameter ("Artist Name" "Album Name")

/path        Default path to save art as     (/path "\Art\Folder.jpg")
              May be abbreviated to /p        (/p "\Art\Folder.jpg")
              Parameter name may be omitted
              if this is the third parameter  ("Artist Name" "Album Name" "\Art\Folder.jpg")

              The following variables can be used in paths:
               %artist%     Artist searched for
               %album%      Album searched for
               %name%       Name of the image found
               %extension%  Default file extension for the image
               %type%       Type of image (front, back, inside, etc.)
               %source%     Name of the source where image was found
               %size%       Dimensions of the image
               %preset%     A custom preset string, chosen from the save button menu

/f           Provided for backwards          (/p "\Art" /f "Folder.jpg")
              compatibility only. When
              specified, the value is
              appended to the path.

/localImagesPath
              Path to search for local image  (/localImagesPath "\Art\Unsorted\**\*.jpg")
              files in. If not specified, the
              path to save art in is used.
              
              The following variables can be used in paths:
               %artist%     Artist searched for
               %album%      Album searched for
               *            Wildcard, matches any characters
               \**\         Subfolder search. Any folders will match
                             at this point in the path. For example
                             "\Art\Unsorted\**\*.jpg" will match:
                              \Art\Unsorted\image.jpg
                              \Art\Unsorted\misc\image.jpg
                              \Art\Unsorted\misc\old\image.jpg
                            
                             "\Art\Unsorted\*\*.jpg" will match only:
                              \Art\Unsorted\misc\image.jpg

/autoclose   Closes the search window after  (/autoclose)
              saving. To avoid closing, use
              Save As.
              May be abbreviated to /ac
              
              Append "off" to disable closing (/autoclose off)
              the search window after saving,
              if this option is on by default.
              
              Note that this option affects
              only the window directly opened
              by the command line, not any
              existing or subsequent ones.

/sources     Searches only the specified     (/sources "Album Art Exchange,Coveralia")
              sources. Others are disabled.
              Separate sources with commas.
              
              Sources may be prefixed with F: (/sources "Album Art Exchange,F:Coveralia")
              to indicate it should have the
              Search First setting set for it.
              Other sources will have Search
              First unset.
              
              To search all available sources,
              specify "all" here.             (/sources all)
              
              May be abbreviated to /s

/exclude     Does not search the specified   (/exclude "Local Files,GoogleImage")
              sources. Separate sources with
              commas.
              May be abbreviated to /es
              For backwards compatibilty, the
              parameter "/ae off" can also be
              used to exclude "Local Files".

/include     Searches the specified sources. (/include "Local Files,Album Art Exchange")
              Does not disable sources that
              are not specified. Separate
              sources with commas.
              
              Sources may be prefixed with F: (/include "F:Local Files,Album Art Exchange")
              to indicate it should have the
              Search First setting set for it.
              Other sources will have their
              Search First setting remain unchanged.
              
              May be abbreviated to /i

/sort (name|size|area|source|type)[+|-]
              Sets the sorting to use for the (/sort size-)
              results.
              May be abbreviated to /o        (/o size-)
              
              The first character may be - to
              indicate descending search, or
              + to indicate ascending. If it
              is omitted, ascending is assumed.
              
              The field to sort by must be one
              of:
               name (may be abbreviated to n) (/o n+)
               size (may be abbreviated to s)
               area (may be abbreviated to a)
               source (may be abbreviated to o)
               category (may be abbreviated to c)
               type (may be abbreviated to t)
               page (may be abbreviated to p)

/group (none|local|source|type|size)
              Sets the grouping to use for    (/group source)
              the results.
              May be abbreviated to /o        (/o source)
              
              The avaialable grouping options
              are:
               none (may be abbreviated to n) (/o n)
               local (may be abbreviated to l)
               source (may be abbreviated to o)
               type (may be abbreviated to t)
               size (may be abbreviated to s)
               page (may be abbreviated to p)

/minSize     Specifies the minimum size of   (/minSize 300)
              image, in pixels, to filter the
              results by. Both horizontal and
              vertical dimensions must be over
              this value.
              May be abbreviated to /mn       (/mn 300)
              
/maxSize     Specifies the maximum size of   (/maxSize 1000)
              image, in pixels, to filter the
              results by. Either horizontal or
              vertical dimensions may be under
              this value.
              May be abbreviated to /mx       (/mx 1000)

/coverType   Specifies the type(s) of cover  (/coverType front)
              to find. Separate types with
              commas. Available types are:    (/coverType front,unknown)
              
               Front
               Back
               Inside
               CD
               Booklet
               Unknown
              
              As a shortcut to specifying all (/coverType any)
              types, the special type Any may
              be used.
              
              Types may be abbreviated to     (/coverType f,b,i,c,k,u)
              their first letter, or k for
              Booklet
              
              May be abbreviated to /t        (/t c,u)

/fileBrowser                                 (/fileBrowser "\Music")
              Opens a File Browser window. If
              a path is specified, starts
              searching that path immediately.
              If no path is specified, the
              browser window is just opened.  (/fileBrowser)
              
              If other parameters are not
              specified, then a search window
              will not be shown initially.

/foobarBrowser [search]                      (/foobarBrowser search)
              Opens a Foobar Browser window. If
              the search parameter is present,
              starts searching the foobar media
              library immediately. If the search
              parameter is omitted, the browser
              window is just opened.          (/foobarBrowser)
              
              If other parameters are not
              specified, then a search window
              will not be shown initially.

/update                                      (/update)
              Checks for updates to scripts and
              application.

/getScripts                                  (/getScripts)
              Checks for other search source
              scripts which may be available for
              download.

/minimized                                   (/minimized)
              Opens the new window minimized.
              Does not affect already opened
              windows.

/new                                         (/new)
              Ensures that a new window is
              opened for the search, rather
              than reusing an existing window.

/config                                      (/config)
              Opens the user settings xml file
              in notepad, for editing. For
              advanced use only.

/separateInstance                            (/separateInstance)
              Starts a new instance as a new
              process, which will neither re-use
              nor be re-used by any other
              instance of the application.
              
              (not recommended)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-10 07:56:31
Ran into a very bizarre problem today. Been using AAD with Foobar for years and never have had an issue until today and it is ONLY with this one album. No other albums, not even from the same band, has given me a problem. Anyway, when i click on a song and choose to get cover, i instead a Album Art Downloader Command Line Perimeters window filled with a bunch of text. It looks like Notepad. Anyway. The text is this:

Code: [Select]
>"C:\Program Files\AlbumArtDownloader\albumart.exe" "Converge" "Downpour / Serial Killer 5" (Single)" "J:\Music\Converge\Downpour & Serial Killer [EP]\cover.jpg"

Looks like the album title has a " in it. To pass that on the command line, it would need to be escaped as \"

If it's just the one album, it's probably not worth doing anything about and just searching manually for it, but if you do want to fix it then the command line from Foobar needs to be changed to use "$replace(%album%,'"','\"')" instead of "%album%"

Alex
Title: Album Art Downloader XUI
Post by: carloxp on 2013-12-17 16:04:58
Good morning
I have a small problem I'm unable to solve myself.
Sorry if this is not the right place, I not found another...

The problem is that some folders are listed, while other are missing.
For example, look at the picture below: the folder E:\M\Branduardi\Studio Collection\CD1 is missed from the list, while only E:\M\Branduardi\Studio Collection\CD2 is listed (red arrow); furthermore, some other "CD1"/"CD2" folders are listed regularly (green arrows).

(http://i245.photobucket.com/albums/gg49/jefferson69/ad2-1.png)


The folder exist! :
(http://i245.photobucket.com/albums/gg49/jefferson69/ad3-1.jpg)

What I'm doing wrong?
Than you
Carlo
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-17 20:18:34
the folder E:\M\Branduardi\Studio Collection\CD1 is missed from the list, while only E:\M\Branduardi\Studio Collection\CD2 is listed (red arrow); furthermore, some other "CD1"/"CD2" folders are listed regularly (green arrows).

Albums are only listed once, so if your album has the CD number in the title (like "Coldplay" "Greatest Hits (CD1)" and "Greatest Hits (CD2)") it appears twice (as AAD thinks it's two different albums). Where the album doesn't have the CD number in the title (like the "Studio Collection" you mention) then it's just one album, so it only appears once.

So you aren't doing anything wrong!

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-12-17 23:46:27
Alex, thank you for the formatting above. How can I also get the search to ignore (Disc #)?

The code you suggested would work just fine if the disc number bit was always on the end. If you want to make it optional, though, you need it in it's own optional group:
Code: [Select]
\%artist%\%album%"(?: \(\d+\) \([\dA-F]+\))?(?: \(Disc \d+\))?"\*


Açex


Alex,

the code I am currently using is:
Code: [Select]
\%artist%\%album%"(?: \(\d+\))?(?: \(\d+\) \([\dA-F]+\))?(?: \(Disc \d+\))?"\*


how would I get that to ignore "various artists" when searching for albums in the "various artists" folder?

Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-18 07:58:20
how would I get that to ignore "various artists" when searching for albums in the "various artists" folder?

I'm not sure what you are trying to achieve here. What should the artist name be if not "various artists", then?

Alex
Title: Album Art Downloader XUI
Post by: carloxp on 2013-12-18 08:08:18
Albums are only listed once, so if your album has the CD number in the title (like "Coldplay" "Greatest Hits (CD1)" and "Greatest Hits (CD2)") it appears twice (as AAD thinks it's two different albums). Where the album doesn't have the CD number in the title (like the "Studio Collection" you mention) then it's just one album, so it only appears once.
So you aren't doing anything wrong!
Alex


Hi Alex
thank you very much!
Now that I understand the underlying logic all become simpler!
Thank you 
Carlo
Title: Album Art Downloader XUI
Post by: Eli on 2013-12-19 15:18:23
how would I get that to ignore "various artists" when searching for albums in the "various artists" folder?

I'm not sure what you are trying to achieve here. What should the artist name be if not "various artists", then?

Alex


when searching, I would like to ignore the "artist" when searching for a various artists album, and just search for the album title.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-20 08:24:19
when searching, I would like to ignore the "artist" when searching for a various artists album, and just search for the album title.
Hmm. I suppose you could try:
Code: [Select]
\"(?:various artists|(?<artist>[^\\/]+?))"\%album%"(?: \(\d+\))?(?: \(\d+\) \([\dA-F]+\))?(?: \(Disc \d+\))?"\*

as long as your various artists folder was always named exactly that.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-12-20 19:53:47
when searching, I would like to ignore the "artist" when searching for a various artists album, and just search for the album title.
Hmm. I suppose you could try:
Code: [Select]
\"(?:various artists|(?<artist>[^\\/]+?))"\%album%"(?: \(\d+\))?(?: \(\d+\) \([\dA-F]+\))?(?: \(Disc \d+\))?"\*

as long as your various artists folder was always named exactly that.

Alex



Thanks, I'll give it a try.

Also, any reason the code does not seem to ignore (Disc X)?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-21 08:08:49
Also, any reason the code does not seem to ignore (Disc X)?
If you mean literally an "X" then it's because the regex is set to look for numbers (\d+ means any digits). You could replace "\d+" with "(\d+|X)" which means any digits, or a single X.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2013-12-21 12:26:54
no I mean "x" as in 1,2,3...(digits). For some reason, I am still getting (Disc 1)... in my searches
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-21 13:00:52
no I mean "x" as in 1,2,3...(digits). For some reason, I am still getting (Disc 1)... in my searches
Send me a PM with an example of a full path that isn't being ignored properly, and the current matching path pattern you are using, and I'll take a look.

Alex
Title: Album Art Downloader XUI
Post by: Pjosip on 2013-12-29 17:13:40
Hey, I was reading trough first 6 pages and don't really have the time to read trough all 99 of them to see if somebody had the same issue as I do.

So my music is located in Libraries\Music (the standard location) and majority of it (over 150 songs) is unorganized on 1 folder with couple of them being in separate folders.
When I used file browser it shows as if all songs already have covers, but in reality most of them (about 90%) eather don't work, or are consistent of low-quallity image that is almost unreadable.

Now what I wish to do is to replace art for all existing covers.

So I select everything and click "Get artwork for selection" but when I try to download the art that I like and click "Overwrite the existing file with the new one" I get an error saying "Could not save image 'C:\Users\Josip\Music\Folder.jpg': Acces to the path 'C:\Users\Josip\Music\Folder.jpg' is denied.

I have tried with a different folder on local disc D and unckecking "read only" and also when I try to search for it (with option show hidden files and folders on) it does not exist.

And if I try the 2nd option "Save the new file as Folder(2).jpg" and open the song it (again) does not show apropriate album art.

I realize I am most probably doing something wrong so any help would be nice.
I am mostly trying to download proper (HQ) album art for my phone and will try to download lyrics later.

With kind regards
-Josip Pejčinović
Title: Album Art Downloader XUI
Post by: AlexVallat on 2013-12-29 20:34:04
So my music is located in Libraries\Music (the standard location) and majority of it (over 150 songs) is unorganized on 1 folder with couple of them being in separate folders.

Hi, if all your albums are are in the same folder, then you need to define where to save the cover art files. The default of "Folder.jpg" in the same folder as the album clearly isn't going to work, as you can only have one file called "Folder.jpg" in the folder which has your music in it.

You could, for example, set the path to find images to be "C:\Users\Josip\Pictures\Album Art\%artist%\%album%.%extension%".

I don't know how your phone locates album art, though. Almost everything supports Folder.jpg in the same folder as the album, but if your phone supports some way of looking up the art files when there are multiple albums in the same folder, you will have to find out what it is.

If the phone require the art to be embedded inside the music file itself, then you will need library management software to take the art files downloaded by Album Art Downloader and go through all the music in your library and embed the correct file in each music file. I believe Mp3Tag can do this sort of thing.

Alex
Title: Album Art Downloader XUI
Post by: ChrisCTR on 2014-01-15 15:45:41
There's a bad flaw at times when I click on an album art result. Say, if there's an album art result that shows 300x300 and I click on it. It turns into a much less quality image. The 300x300 would turn into something, like a 130x130, for example. Can this be fixed?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-01-15 18:52:08
There's a bad flaw at times when I click on an album art result. Say, if there's an album art result that shows 300x300 and I click on it. It turns into a much less quality image. The 300x300 would turn into something, like a 130x130, for example. Can this be fixed?

Could you let me know which source, (and which album you searched for, if it only happens with a specific album) and I'll look into it.

Alex
Title: Album Art Downloader XUI
Post by: ChrisCTR on 2014-01-15 19:54:27
There's a bad flaw at times when I click on an album art result. Say, if there's an album art result that shows 300x300 and I click on it. It turns into a much less quality image. The 300x300 would turn into something, like a 130x130, for example. Can this be fixed?

Could you let me know which source, (and which album you searched for, if it only happens with a specific album) and I'll look into it.

Alex


Do an artist search for Tony Guerrero, and the album name "Now and Then".  There is a displayed 300x300 album art image. When I click on it, it changes on the screen into a 130x130 image and is saved that way.  If I kept giving you many results like this, it would be an ongoing issue and the list would be too numerous and lengthy to report more similar issues like this one.
Title: Album Art Downloader XUI
Post by: ChrisCTR on 2014-01-16 00:54:12
There's a bad flaw at times when I click on an album art result. Say, if there's an album art result that shows 300x300 and I click on it. It turns into a much less quality image. The 300x300 would turn into something, like a 130x130, for example. Can this be fixed?

Could you let me know which source, (and which album you searched for, if it only happens with a specific album) and I'll look into it.

Alex


Do an artist search for Tony Guerrero, and the album name "Now and Then".  There is a displayed 300x300 album art image. When I click on it, it changes on the screen into a 130x130 image and is saved that way.  If I kept giving you many results like this, it would be an ongoing issue and the list would be too numerous and lengthy to report more similar issues like this one. The image you are looking for is violet, yellow and green in color. There's a large green "G" in the album art.

Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-01-16 08:03:47
Do an artist search for Tony Guerrero, and the album name "Now and Then".

Thanks, but what I need to know is which source you are using - for example Google Images, or Amazon, or iTunes, etc. These scripts regularly break as the websites are changed, and I rely on people reporting when they don't work so I can fix them up with whatever changes have been made, or discontinue them if the website itself no longer works.

Alex
Title: Album Art Downloader XUI
Post by: ChrisCTR on 2014-01-16 14:51:11
Do an artist search for Tony Guerrero, and the album name "Now and Then".

Thanks, but what I need to know is which source you are using - for example Google Images, or Amazon, or iTunes, etc. These scripts regularly break as the websites are changed, and I rely on people reporting when they don't work so I can fix them up with whatever changes have been made, or discontinue them if the website itself no longer works.

Alex

I normally have ALL sources checked when I use the Album Art Downloader XUI program. Anyway I tried again and it is using an album cover result from LastFM.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-01-16 18:50:31
Do an artist search for Tony Guerrero, and the album name "Now and Then".
[...] using an album cover result from LastFM.

Thanks, that's helpful. If you click the little (i) in the top right of the result, it will open the web page for the result. In this case, that is: Now and Then - Tony Guerrero (http://www.last.fm/music/Tony+Guerrero/Now+and+Then). On that page you can see that the only image they have is the 130x130 thumbnail that they've grabbed off amazon, and if you check out the images page (http://www.last.fm/music/Tony+Guerrero/Now+and+Then/+images) they simply don't have any.

So AAD has done the best it can from this source, and given you the only artwork they've made available for that album.

When the size is displayed in grey, it's an estimate based on either the size reported by the website, or sometimes just a guess based on what it usually provides, depending on the script author. They aren't always right - in this case, the 300x300 image expected simply wasn't there.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2014-01-23 00:56:08
Alex, any know bugs when scanning large libraries?

My workflow:
Open File Browser in AAD
select my library folder and click "search"

the number of albums seems to reach a max even though it keeps searching

however, I am now realizing that the returned results of the search are different from time to time (some albums appear that didn't before and some don't)

My library is quite large, 8000-9000 discs and about 90,000 tracks and over 2TB
Title: Album Art Downloader XUI
Post by: Eli on 2014-01-23 16:01:28
Is there a way to filter by date or exclude albums from a search by date?

If the folder.jpg file has a certain date or newer, I would like to exclude it from search results
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-01-23 19:06:36
Alex, any know bugs when scanning large libraries?
I don't know of any, but I haven't got a library of that size to test it against! In fact, I don't even have a disk of that size to test it against...

Are you sure you are using the same settings for searching each time? If you are using ID3 tags or path matching, then you would get different results for the same files.

You might also consider using Foobar2000 to manage your library, and then the Foobar browser instead of the File browser.

I'm afraid there is no easy way of excluding albums which have folder.jpg of a given date. I can't even think of a good difficult way of doing it, to be honest, sorry - all the album management tools I know of only care about the existence and contents of folder.jpg, not it's date. Your best bet would probably be to use Windows Explorer to search for folder.jpg, sort the results by date, then delete all the ones *older* than the required date. Then, once you've done the search, (ignoring all those which have results), you can restore the deleted files from the recycle bin. Pretty horrible, I know, but I can't think of anything better. It's not going to be a feature added to AAD.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2014-01-23 21:06:28
Alex, any know bugs when scanning large libraries?
I don't know of any, but I haven't got a library of that size to test it against! In fact, I don't even have a disk of that size to test it against...

Are you sure you are using the same settings for searching each time? If you are using ID3 tags or path matching, then you would get different results for the same files.

You might also consider using Foobar2000 to manage your library, and then the Foobar browser instead of the File browser.

I'm afraid there is no easy way of excluding albums which have folder.jpg of a given date. I can't even think of a good difficult way of doing it, to be honest, sorry - all the album management tools I know of only care about the existence and contents of folder.jpg, not it's date. Your best bet would probably be to use Windows Explorer to search for folder.jpg, sort the results by date, then delete all the ones *older* than the required date. Then, once you've done the search, (ignoring all those which have results), you can restore the deleted files from the recycle bin. Pretty horrible, I know, but I can't think of anything better. It's not going to be a feature added to AAD.

Alex


Using path matching every time.

I tried with Foobar and Foobar browser in the past, but never quite got it to work right. I might try again.

My issue with the date is that I don't want to re-search for albums w/ AAD that I have recently updated the album art on. So a feature request would be to add a date filter to ignore results in the AAD search based on date stamps of folder.jpg
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-01-30 23:02:32
Hi there,

I don't know if this has been reported in any of the hundreds of pages in this thread but this bug (?) annoys me since some years now:

it happens to about 1 in 100 albums when using the batch download "get album art for selection".
it sort of "mixes things up", shows the path of album "A" but downloads the cover and shows artist & album name of album "B"
which is also one of those 100 albums i'm searching a cover for.

here are some pics:

(http://abload.de/img/aad_false_1i7jlq.png)


keep in mind that those are not false positives, AAD mixes something up here, although the albumtags are recognized correctly:

(http://abload.de/img/aad_false_2hsuvl.png)


also, this basically never happens a second time,
when i delete this obviously wrong cover and rescan the directory and download the missing covers it gets it right
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-01-31 08:39:56
it happens to about 1 in 100 albums when using the batch download "get album art for selection".
it sort of "mixes things up", shows the path of album "A" but downloads the cover and shows artist & album name of album "B"

Wow, that's really weird. No, I've not had that reported before.

So, let me see if I've got this straight: You use the File Browser to get a list of albums with missing artwork, then, with the "Automatically download and save the first result that meets set criteria" option selected, click "Get Artwork for Selection". That opens the "Get Artwork Automatically" window, where you have the sources and criteria set. One question - are you using only Discogs, or do you have multiple sources checked?

Then, after hitting Start, it does it's automatic downloading, but for some of the results it's used the wrong path for the wrong album despite being correct in the file browser window?

I'll have a go at reproducing that and see if I can come up with any fix.

Thanks for reporting it,

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-01-31 08:52:51
So, let me see if I've got this straight: You use the File Browser to get a list of albums with missing artwork, then, with the "Automatically download and save the first result that meets set criteria" option selected, click "Get Artwork for Selection". That opens the "Get Artwork Automatically" window, where you have the sources and criteria set.

Then, after hitting Start, it does it's automatic downloading, but for some of the results it's used the wrong path for the wrong album despite being correct in the file browser window?

Yes, that is exactly how it takes place

One question - are you using only Discogs, or do you have multiple sources checked?

discogs, encyclopaedia metallum and last.fm. discogs is set to "search first".
i'll screenshot every case that happens, maybe i'll find a pattern

Thanks for reporting it,

thanks for your work!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-01-31 19:08:54
Well, I couldn't reproduce it, but I've done some general hardening around the multi-threading in that area, it might help. Could you give: AlbumArtDownloaderXUI-1.01-experimental.zip (http://byalexv.co.uk/temp/AlbumArtDownloaderXUI-1.01-experimental.zip) a quick go and see if it makes any difference?

If not, please also let me know what the "Specify path to find images" box in the File Browser options has in it.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-01-31 19:54:29
Well, I couldn't reproduce it, but I've done some general hardening around the multi-threading in that area, it might help. Could you give: AlbumArtDownloaderXUI-1.01-experimental.zip (http://byalexv.co.uk/temp/AlbumArtDownloaderXUI-1.01-experimental.zip) a quick go and see if it makes any difference?

If not, please also let me know what the "Specify path to find images" box in the File Browser options has in it.

Thanks,

Alex

thanks alot, i will test it this weekend

my settings should be pretty much default, i don't think i changed anything here:

(http://abload.de/img/screenshot_140131-205rdzkr.png)

Title: Album Art Downloader XUI
Post by: SigHunter on 2014-02-01 01:11:06
seems to be a bit buggy:

(http://abload.de/img/screenshot_140201-020qksqt.png)
for every cover it downloads

and no pictures appear in the folders
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-01 07:57:14
no pictures appear in the folders
Sorry, I completely forgot to mention, I'd neutered the experimental version so it doesn't actually save them, it just adds them to the results list showing where they would have been saved. This is so that it's safe to run over the same results that produced the error, without worrying that it would overwrite your existing valid cover art!

If you'd rather test one which does save out the images, I've put one up here now: AlbumArtDownloaderXUI-1.01-experimental-2.zip (http://byalexv.co.uk/temp/AlbumArtDownloaderXUI-1.01-experimental-2.zip)

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-02-02 22:06:30
no pictures appear in the folders
Sorry, I completely forgot to mention, I'd neutered the experimental version so it doesn't actually save them, it just adds them to the results list showing where they would have been saved. This is so that it's safe to run over the same results that produced the error, without worrying that it would overwrite your existing valid cover art!

If you'd rather test one which does save out the images, I've put one up here now: AlbumArtDownloaderXUI-1.01-experimental-2.zip (http://byalexv.co.uk/temp/AlbumArtDownloaderXUI-1.01-experimental-2.zip)

Alex


thanks, that's more what i was expecting 

done 'bout 350 covers in total today and yesterday, no switched paths seen so far,
i'll keep using this one to further test it, but it looks very promising, thanks!


since you mentioned multithreading, wouldn't it be possible (in a not that difficult manner) to handle
two albums at once in the batch downloader? (two should be enough for speedup purposes)

i mean, it is basically working through that list of albums, just spawn a second worker for another album that does the same thing as the first one

regards
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-03 08:08:47
wouldn't it be possible (in a not that difficult manner) to handle
two albums at once in the batch downloader? (two should be enough for speedup purposes)

Great, thanks for letting me know. I'll give it a few more days in case anything does pop up, then consider it fixed and release 1.01 with this fix in it.

For doing multiple albums at once, yes it would be technically possible, although not simple to do and prone to subtle errors (like the one you found!). Your best bet, really, if you want to do this, is to launch two automatic downloader windows. Select half your albums for one to find, and half for the other. You do run a higher risk of encountering throttling and other protections against mass downloading from the source websites though, depending on which ones you use.

Alex
Title: Album Art Downloader XUI
Post by: NePaC on 2014-02-04 14:53:13
These scripts regularly break as the websites are changed, and I rely on people reporting when they don't work so I can fix them up with whatever changes have been made, or discontinue them if the website itself no longer works.

I want to report that the 'YesAsia' script isn't working anymore. When I select the 'yesasia'-script and search for "ayaka - Sing to the Sky" I don't get any results, when I search for the album on yesasia.com I get about 4 results showing the cover.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-06 19:22:10
I want to report that the 'YesAsia' script isn't working anymore. When I select the 'yesasia'-script and search for "ayaka - Sing to the Sky" I don't get any results, when I search for the album on yesasia.com I get about 4 results showing the cover.

Thanks for reporting that, I've fixed it now: yesasia.boo (http://album-art.sourceforge.net/scripts/yesasia.boo). Please let me know if you have any more problems with it.

Alex
Title: Album Art Downloader XUI
Post by: NePaC on 2014-02-06 23:12:23
Thanks for fixing it. So far I haven't found any problems.
Title: Album Art Downloader XUI
Post by: Eli on 2014-02-09 23:54:34
Alex,
With the next version would you consider adding a filter function to look at the date time stamp on folder.jpg?

This would make it way easier to only update older files.

Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-10 07:56:26
Version 1.01
This release fixes a nasty Auto Downloader bug reported where the wrong album art could end up saved in the wrong album folder. I have also added a "Modified" column to the file browser which lists the last modified datestamp for the image file (if one is found). It's hidden by default, so to show it right click on any column header and choose it in the menu. By sorting by this column, you can then easily select or unselect newer or older files.

I have also brought all the scripts up to date. MegaMedia and Hyperion Records have been removed, but everything else should work now.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.01.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.01.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7 and 8)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: EagleScout1998 on 2014-02-10 23:45:54
When I try to install, Norton deletes the file. Something about WS.Reputation.1.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-11 08:03:00
When I try to install, Norton deletes the file. Something about WS.Reputation.1.

The MD5s are

AlbumArtDownloaderXUI-1.01.exe: 0f052926d69ad15bbdec2906e252a328
AlbumArtDownloaderXUI-1.01.zip: 7f3ea68300dab0e5e41a0b1e8a3b85ce
AlbumArt.exe (v1.01): 37a30b40fac5776b8965561188764d8f

If you downloaded it directly from SourceForge, and it has that checksum, then it's fine, and must be a false-positive from Norton - if that's the case, then please use their reporting system https://submit.symantec.com/false_positive/ (https://submit.symantec.com/false_positive/) to let them know.

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: mea on 2014-02-20 15:26:08
Hi all,

I am new to this forum so let me please say hello to everyone ! 

I recently decided to grab all the missing covers of my collection and gave a try to AAD.
The problem is that I get the memory error that crashes the app every time I begin the covers grab proedure. (app crashes after grabbing some covers automatically then shows a notepad log with the momery error).
I have checked and at last run it crashed after having performed 443 cover fixes. (I use automatic import with only amazon, bandcamp and lastfm sources.)
then I get a beautifull notepad showing me the error message.
I've run it on two different computers and the problem persists... 

As aad is the ONLY app that seems to be able to connect multiple sources, and therefore the most efficient, could someone tell me if he found a solution to this memory problem ???
Why is the app crashing ? is it because it keeps all the covers shown in the app ? and saturates the memory ? (I can't figure out anything else as the files are directly written on the disk...only the image previews persists in the app).

If yes, Is it possible to give me the CLI options that would perform a simple scan of all recursive folders and files, and add a cover.jpg file in all folder that do not contain any folder? (and this for amazon sites, discogs, beatport, bandcamp and lastFM covers).
Would be great to get some help here!!!
(OR, maybe an option to not show the previews would fix the issue (in case of auto import)). ?

A CLI would be even better as I could schedule a scan and run in the background once a while.
Oh, If someone managed to port the app under osx, it would be really welcome too...I tried to pack it using winebottler but it is desesperately crashing. (butthis is just a "bonus" of course...just sayin'...because my hdds are hfs and I currently have to unplug them and plug them on a pc to run the process...)

Thanks a LOT for the great piece of software !!!!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-21 08:03:26
I have checked and at last run it crashed after having performed 443 cover fixes. (I use automatic import with only amazon, bandcamp and lastfm sources.)
then I get a beautifull notepad showing me the error message.
I've run it on two different computers and the problem persists...

Hello - sorry to hear Album Art Downloader is crashing for you. If you let me know a few details, I can look into it for you. Is it always crashing when trying to download the same cover? Or is it always after exactly 443 no matter which covers it's looking for? Could you post the actual error that you get, it might give me a clue. Are you running it on a PC with an unusually small amount of memory, like a netbook or something?

I'm afraid the CLI doesn't have any media file scanning functionality, it's only for searching and downloading album art. If you have some other library management software that can handle recursively analysing your media collection to find albums, you could probably then get it to call the CLI version for each album that it finds to search for and download a cover for it. The intention of the CLI version is really to provide an easy point of integration like this for other software; it isn't a direct replacement for the main UI version.

Alex
Title: Album Art Downloader XUI
Post by: mea on 2014-02-21 13:39:04
Hi Alex,

The two computer I used respectively have 3 and 4gb of RAM.
Nope it do not crash on the same directory (as I used two specific hdd's with different albums on each of them).
And yes I will make the app crash again tonight and send you the complete log !

Oh and, I do not think it's always crashing after 443 cover fetches...I can see the memory usage growing more and more, till the app crashes. I'm surprised this is not noticed by more users here as I can't imagine that no one already used the app to fix a large number of albums at once using the automatic procedure (that works veryn very well if you stick to main providers as amazon, discogs and lastfm).

I'll paste you the log tonight !

Thank you so much for helping me here !
Title: Album Art Downloader XUI
Post by: Eli on 2014-02-22 19:48:16
Version 1.01
I have also added a "Modified" column to the file browser which lists the last modified datestamp for the image file (if one is found). It's hidden by default, so to show it right click on any column header and choose it in the menu. By sorting by this column, you can then easily select or unselect newer or older files.


Alex,
You rock as always. The modified column works well. I would still prefer to see a filter option (ie exclude before date/ after date)
Title: Album Art Downloader XUI
Post by: mea on 2014-02-23 07:26:43
Hi Alex,

here is the errorlog :

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 1.0.1.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (32 bit)

System.OutOfMemoryException: Mémoire insuffisante pour continuer l'exécution du programme.
  à System.Windows.Media.Imaging.BitmapSource.get_DUCECompatibleMILPtr()
  à System.Windows.Media.Imaging.BitmapSource.UpdateBitmapSourceResource(Channel channel, Boolean skipOnChannelCheck)
  à System.Windows.Media.Imaging.BitmapSource.UpdateResource(Channel channel, Boolean skipOnChannelCheck)
  à System.Windows.Media.Imaging.BitmapSource.AddRefOnChannelCore(Channel channel)
  à System.Windows.Media.Imaging.BitmapSource.System.Windows.Media.Composition.DUCE.IResource.AddRefOnCh
annel(Channel channel)
  à System.Windows.Media.RenderData.System.Windows.Media.Composition.DUCE.IResource.AddRefOnChannel(Chan
nel channel)
  à System.Windows.UIElement.RenderContent(RenderContext ctx, Boolean isOnChannel)
  à System.Windows.Media.Visual.UpdateContent(RenderContext ctx, VisualProxyFlags flags, Boolean isOnChannel)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.UpdateChildren(RenderContext ctx, ResourceHandle handle)
  à System.Windows.Media.Visual.RenderRecursive(RenderContext ctx)
  à System.Windows.Media.Visual.Render(RenderContext ctx, UInt32 childIndex)
  à System.Windows.Media.CompositionTarget.Compile(Channel channel)
  à System.Windows.Media.CompositionTarget.System.Windows.Media.ICompositionTarget.Render(Boolean inResize, Channel channel)
  à System.Windows.Media.MediaContext.Render(ICompositionTarget resizedCompositionTarget)
  à System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
  à System.Windows.Media.MediaContext.AnimatedRenderMessageHandler(Object resizedCompositionTarget)
  à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.DispatcherOperation.InvokeImpl()
  à System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  à System.Threading.ExecutionContext.runTryCode(Object userData)
  à System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  à System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  à System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  à System.Windows.Threading.DispatcherOperation.Invoke()
  à System.Windows.Threading.Dispatcher.ProcessQueue()
  à System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  à MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  à MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  à System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  à System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  à MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  à MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  à System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  à System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  à System.Windows.Threading.Dispatcher.Run()
  à System.Windows.Application.RunDispatcher(Object ignore)
  à System.Windows.Application.RunInternal(Window window)
  à System.Windows.Application.Run(Window window)
  à System.Windows.Application.Run()
  à AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  à AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  à AlbumArtDownloader.App.Main(String[] args)

any idea ? I can't use the app atm...it crashes all the time
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-23 08:37:07
any idea ? I can't use the app atm...it crashes all the time

Hmm. Nothing in that I can really work off, it's all in the WPF rendering code, not under my direct control. I was hoping it might indicate somewhere there was a leak, or be trying to do something weird that made it request an infinitely sized bitmap or something, but it doesn't look like it.

So I guess my best suggestion would be to do your automatic downloading in smaller chunks. Rather than send all your albums to the automatic downloader in one go, just select a couple of hundred or so and see how it gets on. Unless there's a leak somewhere, closing the automatic downloader window ought to release the memory it was using, so you wouldn't need to exit and re-load AAD for the next batch, just close the automatic downloader window before starting the next lot.

Alex
Title: Album Art Downloader XUI
Post by: DarKHawK on 2014-02-23 15:22:08
Is there a problem with googleimage plugin?
Every other plugin finishes the search and the Google image progress bar keeps going.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-24 19:37:38
Is there a problem with googleimage plugin?

GoogleImage v0.15 is working fine for me. Perhaps you've been throttled by Google? They do try and detect automated usage, so if you're doing a lot of consecutive, or worse, simultaneous, searches with it, they might decide to throttle or temporarily block you.

Alex
Title: Album Art Downloader XUI
Post by: mea on 2014-02-28 08:17:13
Hi Alex,

Just one little question as I still encounter crashes.
Did anyone already manage to port the app to osx ? Using winebottler or anything ?
I tried to make an executable .app but it crashes without even showing the start screen...any idea how I could proceed ?
Seeing the app running under osx would be such a great thing with all people that uses osx nowadays.

Thanks for the great support !
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-28 08:29:42
Did anyone already manage to port the app to osx ? Using winebottler or anything ?
Not that I'm aware of. I know it won't run under Mono, because Mono doesn't support WPF. If anyone has or is working on a port, then they haven't mentioned it to me. I personally will not be going anywhere near OSX and have no interest in running that at all. I'd have more sympathy with porting it to Linux if it could be tweaked into running on Mono, but from what I can tell it would involve a re-write of the whole GUI, so I'm not going to do that.

Alex
Title: Album Art Downloader XUI
Post by: mea on 2014-02-28 10:16:40
Hi Alex,

As specified, Linux port would be dope...and especially a command line tool.
I really have too much albums to be able to select each cover one by one. I prefer to let the "most trustable" album services sort out what the cover is...then, if I play the album and see it is not the correct match, I can still change it manually from within my madsonic / subsonic player interface.
The perfect tools would in my point of view point to a folder, scan it recursively, check for all the folders that do not contain an artwork, and do the job that aad does, directly from the command line.
This would permit to run it using a cron job, like, lets say, every night at 2am...
Actually there is already a tool that works pretty well that does that (called cover grabber: http://sourceforge.net/projects/covergrabber/ (http://sourceforge.net/projects/covergrabber/)  ) but it seems the development of the tool is slow, and it only supports lastFM...I do not know if it would be easy to implement other artwork provider easily to this piece of software...

I will try to contact cover grabber dev...and let you know what comes out of it ! 
For now, I give up scanning my albums 400 per 400...I will never finish the task this way unfortunately. Very disapointed because to be honest aad is really the most reliable and complete artowrk downloader around (and I can tell you i've tried a LOT of softs running under osx, linux and win...)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-02-28 18:03:14
Yep, I think you're right, the best approach would probably be to start with something native that can already do cover downloading, then add support for executing AAD scripts to it. AAD scripts are all written in boo (http://boo.codehaus.org/), which will certainly run on Mono under Linux, and presumably OSX too. If anyone does decide to pick this up I'd be happy to provide any tips and information about how scripts are executed by AAD.

Alex
Title: Album Art Downloader XUI
Post by: mea on 2014-03-02 12:01:50
actually, cover grabber is a pure python application. The grabbing scripts seems to be pretty "standard" (I am not a developer but reading the code of the lastfm_plugin.py file seemed clear :

import urllib
try:
    import xml.etree.cElementTree as ETree
except:
    import xml.etree.ElementTree as ETree

from cover_grabber.logging.config import logger


class LastFMDownloader(object):
    def __init__(self, album_name, artist_name):
        """ Initializes LastFM Downloader """

        self.LASTFM_API_KEY = "XXXXXXXXXXXXXXXXXXXXXXXX" # Please use your OWN LastFM API key
        self.LASTFM_URL = "http://ws.audioscrobbler.com/2.0/?method=album.search&album={album_name}&api_key=" + self.LASTFM_API_KEY
        self.album_name = album_name
        self.artist_name = artist_name
        self.url = self.format_url()

    def format_url(self):
        """ Sanitize and format URL for Last FM search """
        return self.LASTFM_URL.format(album_name=self.album_name.encode('utf8'))


    def search_for_image(self):
        """ Use LastFM's API to obtain a URL for the album cover art """
       
        logger.info(u'LastFM: Searching for "{artist_name} - {album_name}"'.format(artist_name=self.artist_name, album_name=self.album_name))
        response = urllib.urlopen(self.url).read() # Send HTTP request to LastFM
        xml_data = ETree.fromstring(response) # Read in XML data

        for element in xml_data.getiterator("album"):
            if (element.find('artist').text.lower() == self.artist_name.lower().encode("utf-8")):
                for elmnt in element.findall('image'):
                    if (elmnt.attrib['size'] == 'extralarge'):
                        url = elmnt.text
                        if url:
                            return url
                        else:
                            return None

any chance to get your own plugins to work with this kind of structure ?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-03-02 16:15:45
any chance to get your own plugins to work with this kind of structure ?
Not automatically. Someone would need to re-write them in python, and that certainly won't be me. I think a better approach would be to try and get python to compile as they are (in boo) and load the resulting managed assembly from python. A cursory glance suggests http://pythonnet.sourceforge.net/ (http://pythonnet.sourceforge.net/) might be able to do this, but I don't know enough (well, any, really) python to know for sure.

Alex
Title: Album Art Downloader XUI
Post by: dutch109 on 2014-03-02 21:33:17
mea, I am a Linux user, and have developed a cover art downloader in pure Python that may interest you.

It's a bit different from AAD, in that it's not interactive at all (by design), it tries its best to find the relevant image for a query (album, artist, cover size) in a fully automated way.

Features :


It follows the Unix philosophy : "do one thing and do it well", so the script itself does not recurse on your music library. I am using another script (~100 lines of Bash) to parse my library, find albums without covers and call the album art downloader for each missing cover.

I am using it for my personal use for more than 2 years, it has evolved a lot and now it's pretty mature. They are still things that needs to be cleaned up (ie: dependency on GraphicsMagick executables, Python packaging), but that affects mainly portability.

I plan to release it on Github when I have fixed those issues (probably in a few weeks). PM me if you are interested for some testing.
Title: Album Art Downloader XUI
Post by: mea on 2014-03-03 19:09:07
Hey dutch !

You piece of software obviously interests me ! 
Can I give it a try ? Just have to re-port python and it will run ?
Do you have a man or integrated parameters help or can you provide me a way to run it the right way ?
And could you eventually tell me how I can make it work recursively ? (I have a shitload of subfolders, all contained on two hdds...I humanly can't scan every single folder one by one.)

Let me know!

anyway the features you listed sounds really promising. and I think we are missing such a cli unix tool !
Title: Album Art Downloader XUI
Post by: dutch109 on 2014-03-03 20:01:07
You piece of software obviously interests me ! 
Can I give it a try ? Just have to re-port python and it will run ?

The portability issues currently prevent a clean Python package install (with pip, setuptools or easy_install), but everything should work if you install manually the dependencies and put the needed files in the same directory.

Do you have a man or integrated parameters help or can you provide me a way to run it the right way ?

I use argparse (http://docs.python.org/3/library/argparse.html?highlight=argparse#module-argparse), so getting help is a matter of typing '-h' in a prompt.

And could you eventually tell me how I can make it work recursively ? (I have a shitload of subfolders, all contained on two hdds...I humanly can't scan every single folder one by one.)

Let me know!

anyway the features you listed sounds really promising. and I think we are missing such a cli unix tool !

It's cool if it can be useful to other people

Anyway let's avoid polluting this topic with stuff that is not about AAD (which is awesome by the way), and use private messages instead.
Title: Album Art Downloader XUI
Post by: skace on 2014-03-14 22:49:48
I'm seeing something odd w/ the google image search script. Up above someone stated it might be some sort of hammer protection on google's side. While a good guess, testing seems to dictate otherwise. Google Image script will continuously fail on the same song over and over again - despite the results existing from a regular google image search. And while it will consistently fail (in a timed out fashion) on these songs, it will turn around and find hits for other songs without any issue.

I should note, however, that google image is not instantly failing w/ 0 hits, but instead timing out as it sits there w/ a progress bar. Very odd.
Title: Album Art Downloader XUI
Post by: skace on 2014-03-14 22:53:53
I changed

From: url = "https://www.google.com/images?q=" + EncodeUrl(artist + " " + album) + "&gbv=2"
To: url = "https://www.google.com/images?q=" + EncodeUrl(artist + " " + album) + "&gbv=2&tbm=isch"

In the google.boo script. And now it works. Not sure if it will be 100%... hmm.
Title: Album Art Downloader XUI
Post by: skace on 2014-03-14 23:24:17
Nevermind... its broken on different files now.
Title: Album Art Downloader XUI
Post by: skace on 2014-03-14 23:29:24
Looks like I was also possibly hitting the flood protection. With the script change and queue manager turned down to only 1 search at a time, I'm getting results back every time now... will see if it continues to work.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-03-15 07:51:36
Google Image script will continuously fail on the same song over and over again

If it's a reproducible problem with searching for a specific song, then let me know exactly what album and artist triggers the problem and I'll look into it. If I can get it to happen here too, chances are I can fix it.
Title: Album Art Downloader XUI
Post by: LauraQ on 2014-03-22 22:04:17
great program
but there is a way the rename automatically?
I think that I must change the pattern "%filename% (%n2%).%extension%" with one that in automatic rename the file that have same name
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-03-23 08:35:39
great program
but there is a way the rename automatically?
I think that I must change the pattern "%filename% (%n2%).%extension%" with one that in automatic rename the file that have same name

Thanks. Album Art Downloader doesn't do library management tasks like renaming existing files and folders, is that what you were asking?
Title: Album Art Downloader XUI
Post by: LauraQ on 2014-03-23 09:52:21
great program
but there is a way the rename automatically?
I think that I must change the pattern "%filename% (%n2%).%extension%" with one that in automatic rename the file that have same name

Thanks. Album Art Downloader doesn't do library management tasks like renaming existing files and folders, is that what you were asking?


I did not understand what you mean.
When I find covers that have the same name, Album Art Downloader XUI asks me if I want to overwrite or rename the new cover and I have to answer
all the times that I want to rename this does not overwrite the file present, and it's a break
Sorry I use Google translate
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-03-23 18:39:52
When I find covers that have the same name, Album Art Downloader XUI asks me if I want to overwrite or rename the new cover and I have to answer all the times that I want to rename this does not overwrite the file present, and it's a break

Ah, OK, I understand now, you want an option to always overwrite, or to always save with another name, rather than asking for every file. Sorry, Album Art Downloader can't do that at present. I didn't think people would be overwriting existing files very often!

I'll consider adding a "Don't ask me again" checkbox to the Overwrite window for the next version. I don't really like the idea of overwriting files without warning, though, so I'd have to be careful about it. Perhaps it would only apply for the current session, and be forgotten next time you run AAD.
Title: Album Art Downloader XUI
Post by: LauraQ on 2014-03-23 20:04:34
When I find covers that have the same name, Album Art Downloader XUI asks me if I want to overwrite or rename the new cover and I have to answer all the times that I want to rename this does not overwrite the file present, and it's a break

Ah, OK, I understand now, you want an option to always overwrite, or to always save with another name, rather than asking for every file. Sorry, Album Art Downloader can't do that at present. I didn't think people would be overwriting existing files very often!

I'll consider adding a "Don't ask me again" checkbox to the Overwrite window for the next version. I don't really like the idea of overwriting files without warning, though, so I'd have to be careful about it. Perhaps it would only apply for the current session, and be forgotten next time you run AAD.



I hope you enter this function, which for me is very useful if you need to download thousands of covers as in my case.
Just add the function to autorename and there is no risk of deleting anything
Thanks
Title: Album Art Downloader XUI
Post by: KeithC on 2014-03-30 13:05:00
I got a fatal error, log as requested:

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\Keith\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.1.0, running on Microsoft Windows NT 6.2.9200.0 (32 bit)

System.NullReferenceException: Object reference not set to an instance of an object.
  at AlbumArtDownloader.ArtSearchWindow.OnSourceHighlightResults(Object sender, EventArgs e)
  at AlbumArtDownloader.Source.RaiseHighlightResults()
  at AlbumArtDownloader.Controls.SourcePanel.OnMouseLeftButtonUp(MouseButtonEventArgs e)
  at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
  at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
  at System.Windows.UIElement.CrackMouseButtonEventAndReRaiseEvent(DependencyObject sender, MouseButtonEventArgs e)
  at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
  at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
  at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
  at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
  at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
  at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
  at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
  at System.Windows.Input.InputManager.ProcessStagingArea()
  at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
  at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
  at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
  at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  at System.Windows.Threading.Dispatcher.Run()
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at System.Windows.Application.Run(Window window)
  at System.Windows.Application.Run()
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-04-01 11:35:13
I got a fatal error, log as requested

Thanks for reporting this. From the log, I can tell this happens when you click on a source to highlight results from it, but I haven't been able to reproduce it here. Does it happen consitently for you? Or did you notice anything unusual about the search you did or the source you clicked on?

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2014-04-05 16:58:19
Alex,
Amazon script seems to be struggling to get the full size image. I have found this frequently but thought you would like an example, so here is the last one I noticed:

http://www.amazon.com/Electric-Warrior-T-Rex/dp/B006HH5Y6K (http://www.amazon.com/Electric-Warrior-T-Rex/dp/B006HH5Y6K)

Eli
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-04-05 19:43:09
Alex,
Amazon script seems to be struggling to get the full size image. I have found this frequently but thought you would like an example, so here is the last one I noticed:

http://www.amazon.com/Electric-Warrior-T-Rex/dp/B006HH5Y6K (http://www.amazon.com/Electric-Warrior-T-Rex/dp/B006HH5Y6K)

Eli

Thanks for the report. When I do a search for that album with the Amazon (.com) v0.11s script, I get:

http://www.amazon.com/Electric-Warrior-Mar.../dp/B000002KP3/ (http://www.amazon.com/Electric-Warrior-Marc-Bolan/dp/B000002KP3/)
http://www.amazon.com/Electric-Warrior-Ses.../dp/B000001JKJ/ (http://www.amazon.com/Electric-Warrior-Sessions-Marc-Bolan/dp/B000001JKJ/)

Not the B006HH5Y6K one you mention. I notice on the page you posted that the image is only 300x300 and has an AutoRip stamp stuck on top of it, so I'm not too concerned about not getting that one...
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-04-08 21:33:15
wouldn't it be possible (in a not that difficult manner) to handle
two albums at once in the batch downloader? (two should be enough for speedup purposes)

Great, thanks for letting me know. I'll give it a few more days in case anything does pop up, then consider it fixed and release 1.01 with this fix in it.

For doing multiple albums at once, yes it would be technically possible, although not simple to do and prone to subtle errors (like the one you found!). Your best bet, really, if you want to do this, is to launch two automatic downloader windows. Select half your albums for one to find, and half for the other. You do run a higher risk of encountering throttling and other protections against mass downloading from the source websites though, depending on which ones you use.

Alex


Hi Alex,

when I run multiple searches at once and i change the minimum pixels in session 1 it also changes it immediately in the other,
is this the desired behavior?
i usually search for covers with min. 800 px, after that min. 500 px, after that 300, to get the best possible size,
however because of that i have to wait till all the jobs finish to change them to the other pixelvalue
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-04-09 08:20:03
when I run multiple searches at once and i change the minimum pixels in session 1 it also changes it immediately in the other, is this the desired behavior?
The minimum and maximum image sizes are cross-application settings, not per-window. However, I agree that if you have started an automatic download search then it should take the settings at the time you start the search and not allow them to be altered after the search has begun. I've added a feature request for that: https://sourceforge.net/p/album-art/feature-requests/105/ (https://sourceforge.net/p/album-art/feature-requests/105/)

When I next do a new version, I'll include this change with it.

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-04-09 08:27:26
when I run multiple searches at once and i change the minimum pixels in session 1 it also changes it immediately in the other, is this the desired behavior?
The minimum and maximum image sizes are cross-application settings, not per-window. However, I agree that if you have started an automatic download search then it should take the settings at the time you start the search and not allow them to be altered after the search has begun. I've added a feature request for that: https://sourceforge.net/p/album-art/feature-requests/105/ (https://sourceforge.net/p/album-art/feature-requests/105/)

When I next do a new version, I'll include this change with it.

Alex


you are awesome, thanks for caring and keeping this project maintained!
Title: Album Art Downloader XUI
Post by: nathan909 on 2014-04-22 08:01:32
Maybe I’m missing something??

But how do you embed the album art into the MP3s so I can use the art with my phone, Google music, iTunes…. I see it saves it only as a .jpg

Want to add cover art to over 80 top 100 play lists.

Thanks
Nathan
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-04-22 17:49:31
Maybe I’m missing something??

But how do you embed the album art into the MP3s so I can use the art with my phone, Google music, iTunes…. I see it saves it only as a .jpg

Want to add cover art to over 80 top 100 play lists.

Thanks
Nathan

use foobar2000's "batch attach pictures" feature
Title: Album Art Downloader XUI
Post by: nathan909 on 2014-04-22 22:03:17
Maybe I’m missing something??

But how do you embed the album art into the MP3s so I can use the art with my phone, Google music, iTunes…. I see it saves it only as a .jpg

Want to add cover art to over 80 top 100 play lists.

Thanks
Nathan

use foobar2000's "batch attach pictures" feature


Thanks for your quick reply!

SO I added foobar and put some MP3s there for a test, but it labels the artist as "Various artists"

Is there a fix for this?

Thanks again!
Nathan

(http://content.screencast.com/users/Nathan909/folders/Jing/media/caefb009-a4ac-4abf-843f-e76aff0964c4/2014-04-22_1359.png)
Title: Album Art Downloader XUI
Post by: nathan909 on 2014-04-23 00:10:09
Maybe I’m missing something??

But how do you embed the album art into the MP3s so I can use the art with my phone, Google music, iTunes…. I see it saves it only as a .jpg

Want to add cover art to over 80 top 100 play lists.

Thanks
Nathan

use foobar2000's "batch attach pictures" feature


Thanks for your quick reply!

SO I added foobar and put some MP3s there for a test, but it labels the artist as "Various artists"

Is there a fix for this?

Thanks again!
Nathan

(http://content.screencast.com/users/Nathan909/folders/Jing/media/caefb009-a4ac-4abf-843f-e76aff0964c4/2014-04-22_1359.png)


OK i fixed the "Various artists" issue by removing the "album artist" ID3v2 tag.

but now i still dont see a way to embed art into mp3, it still wants to save it as folder.jpg



(http://content.screencast.com/users/Nathan909/folders/Jing/media/1271ec07-80a0-4e74-9565-c1cb38a996f9/2014-04-22_1605.png)
Title: Album Art Downloader XUI
Post by: moonwrithe on 2014-04-24 03:08:47
Is the eCover.to (Cover-Paradies) script (v0.16) not working for anyone else? I'm getting 0 hits on it with every search, even though there are covers on the site when I check manually. I'm using the latest version of AAD.
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-04-24 10:15:11
but now i still dont see a way to embed art into mp3, it still wants to save it as folder.jpg

you save it to folder.jpg first, your albums should each be in a seperate folder,
then put all albums in a foobar playlist, select all songs and rightclick --> tagging --> batch attach pictures, next window should say folder.jpg or *.jpg

now foobar adds all the .jpg files it finds in the folder where the song is to the id3tag
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-04-24 20:04:34
Is the eCover.to (Cover-Paradies) script (v0.16) not working for anyone else? I'm getting 0 hits on it with every search, even though there are covers on the site when I check manually. I'm using the latest version of AAD.

Thanks for reporting this. I've just uploaded v0.17 which should be working again. Let me know if you have any trouble with it: cover-paradies.boo (http://album-art.sourceforge.net/scripts/cover-paradies.boo)

Alex
Title: Album Art Downloader XUI
Post by: moonwrithe on 2014-04-26 00:25:20
Is the eCover.to (Cover-Paradies) script (v0.16) not working for anyone else? I'm getting 0 hits on it with every search, even though there are covers on the site when I check manually. I'm using the latest version of AAD.

Thanks for reporting this. I've just uploaded v0.17 which should be working again. Let me know if you have any trouble with it: cover-paradies.boo (http://album-art.sourceforge.net/scripts/cover-paradies.boo)

Alex


Wow, thanks for the fast response!

The script is now working again for the most part. The only thing is I don't think I'm getting all the matches I should. I'm pretty sure it's only returning the first page of results from the website. One search I did and noticed this happening was "Motorhead - Ace of Spades". Doing the "extended search" manually on the website yields 4 pages of results, 6 albums per page, at least 2 pix per album. AAD is only showing 14 results from eCover.to, which is the exact number of images on the first page of the site's search results.

It's not that big a deal as it only happens with a small number of searches, but it did keep me from getting the biggest images using AAD versus searching manually on the website in a couple of cases. I tried looking at the script and the website to see if I could figure it out, but it seems to be juuuuuuust a skosh beyond my meager ability to massage someone else's code.

Again, thanks for the work and great program. It's the best one out there for cover art.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-04-26 09:04:45
AAD is only showing 14 results from eCover.to, which is the exact number of images on the first page of the site's search results.

Yes, that's right. The script is only written to fetch the first page of results - this is generally the case for all scripts.

Alex
Title: Album Art Downloader XUI
Post by: Eli on 2014-04-30 12:52:04
Alex,
Amazon script seems to be struggling to get the full size image. I have found this frequently but thought you would like an example, so here is the last one I noticed:

http://www.amazon.com/Electric-Warrior-T-Rex/dp/B006HH5Y6K (http://www.amazon.com/Electric-Warrior-T-Rex/dp/B006HH5Y6K)

Eli

Thanks for the report. When I do a search for that album with the Amazon (.com) v0.11s script, I get:

http://www.amazon.com/Electric-Warrior-Mar.../dp/B000002KP3/ (http://www.amazon.com/Electric-Warrior-Marc-Bolan/dp/B000002KP3/)
http://www.amazon.com/Electric-Warrior-Ses.../dp/B000001JKJ/ (http://www.amazon.com/Electric-Warrior-Sessions-Marc-Bolan/dp/B000001JKJ/)

Not the B006HH5Y6K one you mention. I notice on the page you posted that the image is only 300x300 and has an AutoRip stamp stuck on top of it, so I'm not too concerned about not getting that one...


The embedded image is 1425x1425 and the one that showed up in AAD. However AAD was never able to download the 1425x1425 image. If I go to the web page, show source and search for jpg I can find the source image (for when you scroll over the thumbnail with autorip, and you get

http://ecx.images-amazon.com/images/I/71El...hL._SL1425_.jpg (http://ecx.images-amazon.com/images/I/71ElbTeoChL._SL1425_.jpg)

I think the ones I am running into are these AutoRip images, where there is an embedded large image (hover your mouse over the image). Somehow AAD can see them, but doesn't manage to download them.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-05-04 17:30:17
The embedded image is 1425x1425 and the one that showed up in AAD. However AAD was never able to download the 1425x1425 image. If I go to the web page, show source and search for jpg I can find the source image (for when you scroll over the thumbnail with autorip, and you get

http://ecx.images-amazon.com/images/I/71El...hL._SL1425_.jpg (http://ecx.images-amazon.com/images/I/71ElbTeoChL._SL1425_.jpg)


Hmm. Seems to work OK for me. I search for "T Rex" / "Electric Warrior" with Amazon (.com) v0.11s, and the first result is B006HH5Y6K (http://www.amazon.com/Electric-Warrior-T-Rex/dp/B006HH5Y6K/). When I click the thumbnail, it resolves to 1425x1425 (150 KB). Clicking the save button saves it out as Folder.jpg with no problem.
Title: Album Art Downloader XUI
Post by: Jeroma on 2014-05-05 09:40:21
I'm trying to figure this out. Is it possible to search for album art based on ID3 tags? If so, how would I do that? In addition, I don't like adding Album names for my Singles (I just leave it blank). Therefore, iTunes can't find the album art for the songs, since it only searches for "Artist - Album". It would be nice if I could use the title of a song as the Album title to solve this problem.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-05-05 10:41:25
Is it possible to search for album art based on ID3 tags?

Yes, just use the File Browser, and make sure it is set in the options to "Use ID3 tags from files" rather than file path pattern matching.

It would be nice if I could use the title of a song as the Album title to solve this problem.

You can do this, but not if you are using tags! If you are using a file path pattern, and your files are named in a regular way so that it's easy to extract the artist name and the song title from the file name and folder, then you could do it. For example, if your files were in folders named for the artist, and the track was named as simply the song title.mp3, then the pattern to use would be \%artist%\%album%.mp3
Title: Album Art Downloader XUI
Post by: thorazine on 2014-05-24 10:48:13
Google Play Music, on the other hand, does look quite promising, with good quality high res images. Here's a script for it, if you'd like to try it out and give me any comments before I make it available through online updates: google-play.boo (http://album-art.sourceforge.net/scripts/google-play.boo). It would also be useful to know if you find any full-size images that are not 1448×1448 pixels - if I can be reasonably sure that they are all that size, I will have the script report them as such rather than "Unknown".


Hi, the script worked fine for me until a month ago or so, I guess Google changed something in their page?
BTW, I found this great google-play source just by accident, so I thought maybe I'm missing some other great scripts, maybe you should include a list of test, trial, beta scripts not included in the program in the first post of this thread for everybody to see and try?

Also, have you thought about adding an AllMusic script? They have lots of covers and some of them are in high resolution...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-05-25 10:38:25
Hi, the script worked fine for me until a month ago or so, I guess Google changed something in their page?
BTW, I found this great google-play source just by accident, so I thought maybe I'm missing some other great scripts, maybe you should include a list of test, trial, beta scripts not included in the program in the first post of this thread for everybody to see and try?

Also, have you thought about adding an AllMusic script? They have lots of covers and some of them are in high resolution...

Thanks for reporting this, I've uploaded an updated google-play.boo (http://album-art.sourceforge.net/scripts/google-play.boo).

There is a list of scripts (http://album-art.sourceforge.net/Updates.xml) that's kept up to date, and can be queried by Album Art Downloader itself. There should be a "Get more scripts" link which will give you a list of scripts from that URL that you haven't installed yet.

I guess it would be nice to have scripts classified as test, trial, beta, etc. but to be honest they never go through that rigorous a process. If someone requests one, and I think it's worth doing and write it, then I ask the person who requested it to test it out for a bit, then I publish it on the main list. All scripts break frequently as the source sites get updated, so none can really be regarded as mature and stable. I do try and fix any that are reported broken though.
Title: Album Art Downloader XUI
Post by: maynak00 on 2014-06-01 13:41:48
how to use original filename for albumarts?
this not help: Folder%preset%[%source%][%name%].%extension%

http://a5.mzstatic.com/us/r30/Music2/v4/34...200x1200-75.jpg (http://a5.mzstatic.com/us/r30/Music2/v4/34/08/f0/3408f00f-ee99-0e49-3398-6842f57217f8/UMG_cvrart_00602537402540_01_RGB72_1800x1800_13UMGIM59022.1200x1200-75.jpg)
I want: UMG_cvrart_00602537402540_01_RGB72_1800x1800_13UMGIM59022.1200x1200-75.jpg or iTunes_id646228740_UMG_cvrart_00602537402540_01_RGB72_1800x1800_13UMGIM59022.1200x1200-75.jpg

http://a5.mzstatic.com/us/r30/Music2/v4/df...200x1200-75.jpg (http://a5.mzstatic.com/us/r30/Music2/v4/df/d6/f8/dfd6f814-ba78-2f4c-4c98-1fd27451ae7d/UMG_cvrart_00602537409785_01_RGB72_1800x1800_13UMGIM59023.1200x1200-75.jpg)
I want: UMG_cvrart_00602537409785_01_RGB72_1800x1800_13UMGIM59023.1200x1200-75.jpg or iTunes_id646191408_UMG_cvrart_00602537409785_01_RGB72_1800x1800_13UMGIM59023.1200x1200-75.jpg
sorry for my English.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-06-01 14:38:41
how to use original filename for albumarts?

There's no general way to do this, as there is not necessarily anything that could be considered a "filename" for the art downloaded. Sometimes (but not always) there is a URL for the art downloaded, but to extract something useful as a filename out of this would need to be done individually by each script. If you wanted to modify a script to do so, then the best thing to do would be to use that as the name of the result, which could then be accessed as %name% in the pattern.
Title: Album Art Downloader XUI
Post by: mea on 2014-06-01 17:16:52
hi Alex,

I was wondering a few months ago if someone figured out how to make AAD usable in osx by using winebottler. do you have any idea of the parameters I should use to make it run under osx ?
By the way, is the memory allocation problem that makes the RAM be used more and more till the app crash now fixed ? I can't run the scan for more than, lets say, 500 albums, the RAM is used as cache and when totally used, the app crashes 


Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-06-01 22:20:33
I was wondering a few months ago if someone figured out how to make AAD usable in osx by using winebottler. do you have any idea of the parameters I should use to make it run under osx ?
Last time I checked WPF wasn't supported, so it simply wouldn't work. If they've got WPF working under wine now then it's entirely possible that AAD is usable, but I've no idea what special parameters it might need, sorry.

I can't run the scan for more than, lets say, 500 albums, the RAM is used as cache and when totally used, the app crashes
Do you mean in the file browser? There is a little memory consumed for each album in the list, to hold the details of it, and the UI objects of the list entry itself, but 500 isn't going to take up much. The only thing that takes up a lot of memory in AAD are images, and those should be released whenever you close the search window that is displaying them. If you are finding that you are running out of memory *without* a lot of images in an open window, then there may be a bug.

Alex
Title: Album Art Downloader XUI
Post by: rael71 on 2014-06-15 15:30:09
Hi,

I'm new here.
I recently passed from windows 7 to 8.1 pro and now when I launch AAD it shows the error screen.

When I click on "reset all settings to default and restart", I got this error "Could not determine path to configuration file"


Here's the log:
Album Art Downloader encountered an error when attempting to read its
configuration settings, and could not start.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\andrea\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.1.0, running on Microsoft Windows NT 6.2.9200.0 (64 bit)

System.Configuration.ConfigurationErrorsException: Dichiarazione imprevista nella sezione di configurazione 'connectionStrings'.
  in System.Configuration.ConfigurationManager.get_ConnectionStrings()
  in System.Configuration.PrivilegedConfigurationManager.get_ConnectionStrings()
  in System.Configuration.LocalFileSettingsProvider.GetPropertyValues(SettingsContext context, SettingsPropertyCollection properties)
  in System.Configuration.SettingsBase.GetPropertiesFromProvider(SettingsProvider provider)
  in System.Configuration.SettingsBase.GetPropertyValueByName(String propertyName)
  in System.Configuration.SettingsBase.get_Item(String propertyName)
  in System.Configuration.ApplicationSettingsBase.GetPropertyValue(String propertyName)
  in System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
  in AlbumArtDownloader.Properties.Settings.get_ApplicationVersion()
  in AlbumArtDownloader.App.Main(String[] args)

Can anyone help me?

Thanks in advance and bye

Andrea
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-06-15 17:12:17

Hi Andrea,

The solution would be to delete the configuration file, however I don't know why AAD has been unable to determine the path to it to delete it automatically, when you click the reset all settings button.

To do it manually, I'd recommend going to the "%localappdata%\AlbumArtDownloader" folder (should resolve to "C:\Users\andrea\AppData\Local\AlbumArtDownloader" for you)and deleting it. This will remove all album art downloader settings, which should hopefully let it start up successfully next time.

Alex
Title: Album Art Downloader XUI
Post by: rael71 on 2014-06-15 17:27:44

Hi Andrea,

The solution would be to delete the configuration file, however I don't know why AAD has been unable to determine the path to it to delete it automatically, when you click the reset all settings button.

To do it manually, I'd recommend going to the "%localappdata%\AlbumArtDownloader" folder (should resolve to "C:\Users\andrea\AppData\Local\AlbumArtDownloader" for you)and deleting it. This will remove all album art downloader settings, which should hopefully let it start up successfully next time.

Alex


Alex Thank you for your reply.

The strange thing is that I haven't any AlbumArtDownloader Folder in appdata!
I tried uninstalling and reinstalling aad but got no AlbumArtDownloader Folder in appdata....
I tried to create manually the folder in appdata but got the same message from AAD
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-06-15 17:41:46
The strange thing is that I haven't any AlbumArtDownloader Folder in appdata!

Huh, I guess that would explain why it couldn't determine the path to it, then. What it doesn't explain is how there can be config file errors if there aren't any config files. Could you check in the folder you installed it to (usually C:\Program Files\AlbumArtDownloader) and see if there is an AlbumArt.exe.config file there? Or any other .config files, for that matter, there shouldn't be any with a fresh install...

If there aren't, then there's a problem with the .NET Framework on your computer. I'd recommend going to the Programs and Features control panel, and clicking on the link to change installed windows features, then uncheck .NET Framework 3.5 to remove it. Once it's removed, go back and re-check the box to install it again. With a bit of luck, it might repair itself.

Alex
Title: Album Art Downloader XUI
Post by: rael71 on 2014-06-21 10:06:41
The strange thing is that I haven't any AlbumArtDownloader Folder in appdata!

Huh, I guess that would explain why it couldn't determine the path to it, then. What it doesn't explain is how there can be config file errors if there aren't any config files. Could you check in the folder you installed it to (usually C:\Program Files\AlbumArtDownloader) and see if there is an AlbumArt.exe.config file there? Or any other .config files, for that matter, there shouldn't be any with a fresh install...

If there aren't, then there's a problem with the .NET Framework on your computer. I'd recommend going to the Programs and Features control panel, and clicking on the link to change installed windows features, then uncheck .NET Framework 3.5 to remove it. Once it's removed, go back and re-check the box to install it again. With a bit of luck, it might repair itself.

Alex


First of all sorry for the late but I've been very busy in the last few days.

Anyway, Alex you're a genius!!!!!!
I unistalled AAD anf then disabled and enabled again .net 3.5, reinstalled AAD and now it works perfectly!!

Thanks so much!

Andrea
Title: Album Art Downloader XUI
Post by: k76 on 2014-06-24 04:25:05
Downloaded AAD yesterday, installed on my WIN7x64, on clicking AlbumArt.exe it opens for a few seconds and then automatically closes:

App version: 1.0.1.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Configuration.ConfigurationErrorsException: The 'system.serviceModel/services' configuration section cannot be created. The machine.config file is missing information. Verify that this configuration section is properly registered and that you have correctly spelled the section name. For Windows Communication Foundation sections, run ServiceModelReg.exe -i to fix this error.
  at System.ServiceModel.Configuration.ConfigurationHelpers.UnsafeGetAssociatedSection(ContextInformation evalContext, String sectionPath)
  at System.ServiceModel.Configuration.ServicesSection.UnsafeGetSection()
  at System.ServiceModel.Description.ConfigLoader.LookupService(String serviceConfigurationName)
  at System.ServiceModel.ServiceHostBase.ApplyConfiguration()
  at System.ServiceModel.ServiceHostBase.InitializeDescription(UriSchemeKeyedCollection baseAddresses)
  at System.ServiceModel.ServiceHost..ctor(Object singletonInstance, Uri[] baseAddresses)
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)

I cannot see a machine.config file anywhere, it sure is not at c:\Program Files (x86)\AlbumArtDownloader\ or c:\Users\xxx\AppData\Local\AlbumArtDownloader\ or any of its subfolders.

The installer went through without any errors.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-06-24 08:26:16
I cannot see a machine.config file anywhere, it sure is not at c:\Program Files (x86)\AlbumArtDownloader\ or c:\Users\xxx\AppData\Local\AlbumArtDownloader\ or any of its subfolders.

machine.config is not Album Art Downloader specific, it is for machine-wide configuration settings for .net. It can be found in "C:\Windows\Microsoft.NET\Framework64\v2.0.50727\CONFIG" (or Framework instead of Framework64 if not on a 64bit system).

I'm afraid I have no idea what's gone wrong with yours, though, this isn't something Album Art Downloader or its installer would touch.

Alex
Title: Album Art Downloader XUI
Post by: k76 on 2014-06-24 12:24:59
Ran Microsoft's NetFxRepairTool, it didn't claim to find anything wrong. Uninstalled .NET 3.0 from "Install/uninstall Windows Components" (that's the only selection available there, even if 2.0 is also installed here) and reinstalled it. Installed newest .NET 4.5.2. Ran NetFxRepairTool again, it won't find anything wrong.

The funny thing i don't have any issues with any other programs. The error is still the same.

Wait, there is a little improvement! I was so discouraged by the same error again, didn't even try to run it a second time. But this time there is a small screen giving 3 choices, reset, view config, create error report. Chose "Reset all settings to defaults and restart", there's a popup saying "Could not delete configuration file: Access to the path 'C:\Windows\Microsoft.NET\Framework64\V2.0.50727\Config\machine.config' is denied".

View configuration file shows it in the folder...can't claim to understand any of that.

Create error report produces this:

Album Art Downloader encountered an error when attempting to read its
configuration settings, and could not start.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\xxx\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.1.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Configuration.ConfigurationErrorsException: Configuration system failed to initialize ---> System.Configuration.ConfigurationErrorsException: Unrecognized configuration section system.serviceModel. (C:\Windows\Microsoft.NET\Framework64\v2.0.50727\Config\machine.config line 134)
  at System.Configuration.ConfigurationSchemaErrors.ThrowIfErrors(Boolean ignoreLocal)
  at System.Configuration.BaseConfigurationRecord.ThrowIfInitErrors()
  at System.Configuration.ClientConfigurationSystem.EnsureInit(String configKey)
  --- End of inner exception stack trace ---
  at System.Configuration.ClientConfigurationSystem.EnsureInit(String configKey)
  at System.Configuration.ClientConfigurationSystem.PrepareClientConfigSystem(String sectionName)
  at System.Configuration.ClientConfigurationSystem.System.Configuration.Internal.IInternalConfigSystem.R
efreshConfig(String sectionName)
  at System.Configuration.ConfigurationManager.RefreshSection(String sectionName)
  at System.Configuration.ClientSettingsStore.ReadSettings(String sectionName, Boolean isUserScoped)
  at System.Configuration.LocalFileSettingsProvider.GetPropertyValues(SettingsContext context, SettingsPropertyCollection properties)
  at System.Configuration.SettingsBase.GetPropertiesFromProvider(SettingsProvider provider)
  at System.Configuration.SettingsBase.GetPropertyValueByName(String propertyName)
  at System.Configuration.SettingsBase.get_Item(String propertyName)
  at System.Configuration.ApplicationSettingsBase.GetPropertyValue(String propertyName)
  at System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
  at AlbumArtDownloader.Properties.Settings.get_ApplicationVersion()
  at AlbumArtDownloader.App.Main(String[] args)

It doesn't recognize the section system.serviceModel? I dont know what it is, but it seems proper XML when viewing it in editor...

Starting at line 134:

  <system.serviceModel>
    <extensions>
      <behaviorExtensions>

Does this tell you anything? There's some PublicKeyTokens so i'm hesitant to post the entire section in public. The previous xml tag </system.web> seems also to be closed properly. Can't see any obvious syntactic errors in here. Then again i have no idea what i'm looking at.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-06-24 14:00:21

I've done some searching, and this looks like it might be a known bug with .net. Certainly lots of other people are reporting it, in various circumstances. The suggested fixes (from a Microsoft Connect issue) are to run:

"%windir%\Microsoft.NET\Framework\v3.0\Windows Communication Foundation\ServiceModelReg.exe" /r /x
%windir%\Microsoft.NET\Framework\v3.5\WFServicesReg.exe /c

Alex
Title: Album Art Downloader XUI
Post by: k76 on 2014-06-26 05:38:49
The suggested fixes failed (Microsoft quality software...not surprised), so i ended up doing a Windows 7 inplace upgrade to fix my installation.
Now AAD works, hurrah!
Title: Album Art Downloader XUI
Post by: javacat on 2014-07-14 18:33:28
there seems to be a bug in hitparade.boo

when "unknown" is checked in "filter by cover types", hitparade always returns 

the cover for Madeline Juno's "The Unknown".

------

Thanks for a well crafted piece of work!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-07-15 08:25:17
there seems to be a bug in hitparade.boo

when "unknown" is checked in "filter by cover types", hitparade always returns 

the cover for Madeline Juno's "The Unknown".

How strange, thanks for reporting it. It appears hitparade always include this album, but commented out in the html source (and the script doesn't check for comment markers). Anyway, I've updated the script to ignore it: hitparade.boo (http://album-art.sourceforge.net/scripts/hitparade.boo)

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-07-15 13:13:37
Hi Alex,
would you please consider the following two things:
(pictures say more than words)

Ability to resize the searchlist and the sources
(http://abload.de/img/1239xshd.png)

Add Artist and Albumtags that are being searched for
currently it only shows the found result. I always need to compare the image to what was searched.
Plus, a decent font size would be nice
(http://abload.de/img/screenshot_140715-140bssod.png)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-07-15 18:19:22
Hi Alex,
would you please consider the following two things:

Thanks for the suggestions. I've added feature requests for these (except the font size, I'm happy with the current size). If I ever do another version of AAD then I expect I'll at least get the artist and album searched for into the result tile, that shouldn't be too tricky.

For the moment, though, what you can do is select the album in the top area, and that will highlight it in the bottom area, that way you know what the result for that search was.

Alex
Title: Album Art Downloader XUI
Post by: SigHunter on 2014-07-15 18:35:22
Hi Alex,
would you please consider the following two things:

Thanks for the suggestions. I've added feature requests for these (except the font size, I'm happy with the current size). If I ever do another version of AAD then I expect I'll at least get the artist and album searched for into the result tile, that shouldn't be too tricky.

For the moment, though, what you can do is select the album in the top area, and that will highlight it in the bottom area, that way you know what the result for that search was.

Alex


my screen is 2560x1440 pixels, the fonts are pretty damn small :/
maybe you could make it scale with the size of the pictures or add some simple option "large fonts"-checkbox
Title: Album Art Downloader XUI
Post by: durch on 2014-07-28 15:35:26
Do you know why albumart.exe and aad.exe get different results? I tested it and while I'm satisfied with albumart.exe, aad.exe gets result that lie within the specified parameters but show wrong pictures. I use google and added "cover" to the album title. This makes albumart.exe find almost only the real covers, but aad.exe doesn't find the real covers.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-07-28 18:12:48
Do you know why albumart.exe and aad.exe get different results?
Could you post the command line that you are using for aad? It might be something to do with escaping " characters, if you are literally adding "cover" to the album title.

If they have been given the exact same terms and filter settings, albumart.exe and aad.exe will generally find the same covers - they use the same scripts. Of course, if the website being searched doesn't always return the same results for the same search, though, then AAD won't either!

Alex
Title: Album Art Downloader XUI
Post by: durch on 2014-08-09 12:37:50
"c:\program files\albumartdownloader\aad.exe" /artist "%artist%" /album "%title% cover" /path "c:\temp\covers\downloaded\%artist% - %title%.'%'extension'%'" /sources GoogleImage /minsize 300 /maxsize 1500 /minaspect 0,95 /covertype front,unknown

Even without minaspect, which I believe is not available in the GUI (not sure at the moment), I got different results between aad.exe and the GUI.

Edit: What I posted here is my final foobar2000 run command though. But I think my first manual command line tests also downloaded different pictures.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-08-10 09:28:42

Yes, minaspect is only available through aad.exe, there's no GUI for it. The command line certainly looks correct to me, but having tried it with a few queries I get the same results from both aad.exe and albumart.exe. Is there a specific search that isn't working for you? For testing, could you remove the minaspect parameter so we can eliminate it as a source of different behaviour. If you just replace aad.exe with albumart.exe in your command line, do you then get correct results?

Alex
Title: Album Art Downloader XUI
Post by: boorger on 2014-08-22 03:02:05
Hello every one!!!
How can i force the program to save the images inside the mp3's?
It found a lot of images for every mp3, BUT save it in same folder as a *.jpg files.
This is NOT convinient.
The album art Must be saved inside the mp3, is'n t in it?
Album Art XUI is GREAT !!! BUT !
this small detail KILLS all result of tons of programming years!
Title: Album Art Downloader XUI
Post by: tuxman on 2014-08-22 11:25:29
The album art Must be saved inside the mp3


No.
Title: Album Art Downloader XUI
Post by: Zarggg on 2014-08-22 17:06:19
By which tuxman means that it is not necessary to embed album art inside the file's metadata. Many (if not most) software media players look for album art as a separate file first before looking for embedded data.

If you are using a hardware media player that requires album art to be embedded, there are several programs that can do this for you.
Title: Album Art Downloader XUI
Post by: boorger on 2014-08-23 15:08:22
By which tuxman means that it is not necessary to embed album art inside the file's metadata. Many (if not most) software media players look for album art as a separate file first before looking for embedded data.

If you are using a hardware media player that requires album art to be embedded, there are several programs that can do this for you.

Which software for example?
I using itunes, ipod, iphone, n
Many times i copy cut paste my mp3 s between folders.
Thats worth to copy also the album art jpgs with mp3, thats so difficult and boring.
It must be inside of mp3's (embedded)
Title: Album Art Downloader XUI
Post by: Zarggg on 2014-08-29 20:35:26
The first one that comes to mind is Mp3tag (http://www.mp3tag.de/en/).

You can also use the iTunes interface to embed album art.
Title: Album Art Downloader XUI
Post by: marc2003 on 2014-08-30 14:04:07
^i'd definitely recommend using mp3tag over itunes. with mp3tag, you can do a batch job with a whole collection at once.
Title: Album Art Downloader XUI
Post by: malifact on 2014-09-01 20:41:24
Hi there, I have just started using Album Art Downloader and I think it is a fantastic programme. However, I had a question about using the Foobar Browser. Is there a limit to how many folders that the browser can search in at one time? If I search the entire library in the browser, it is not displaying all my albums but only some of them. There are definitely music files in the other folders. This happens even if I try to limit the number of folders by filtering in Foobar; it will always miss some folders. Thanks in advance for any suggestions.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-09-02 07:58:43
Is there a limit to how many folders that the [Foobar] browser can search in at one time?

The Foobar browser doesn't deal in folders, it deals in Playlists and Albums. There is no limit to the number albums enforced by Album Art Downloader, but I suppose it's possible that Foobar limits the number returned - I've never encountered this, though. Is it correctly displaying all your playlists? Does it happen if you use a specific playlist, or only the "Entire Library" list? Is it always specific albums that are not returned, or different ones each time you try?

Alex
Title: Album Art Downloader XUI
Post by: malifact on 2014-09-02 12:59:32
Is there a limit to how many folders that the [Foobar] browser can search in at one time?

The Foobar browser doesn't deal in folders, it deals in Playlists and Albums. There is no limit to the number albums enforced by Album Art Downloader, but I suppose it's possible that Foobar limits the number returned - I've never encountered this, though. Is it correctly displaying all your playlists? Does it happen if you use a specific playlist, or only the "Entire Library" list? Is it always specific albums that are not returned, or different ones each time you try?

Alex


Thanks for the response.  I actually don't use playlists in Foobar (I just switched from Mediamonkey).  So I have been using the "Entire Library" search option.  Yes, it is specific albums that are not returned.  The reason I thought it was related to the number of albums is because if I edit the Foobar library to remove some albums, some of the ones that would not be returned before will then be returned.  Perhaps I should try creating playlists and use that option to see if the same thing happens. Also, is there a specific folder structure I should be using. I currently have folders A-Z and then the individual albums in a separate folder within the corresponding letter.  So for example, T > 2Pac - Greatest Hits > FLAC files
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-09-02 19:31:00

That's odd. Maybe my library is just not big enough to notice the effect, but when I use Entire Library it's doesn't miss any out for me. If you discover any more information about this, please do let me know.

For folder structure, if you're using the Foobar browser, then it shouldn't matter what folder structure you are using as it will simply ask Foobar what folder the track is in, and use that as the album folder. If you don't want the images stored in that folder directly (in your example, you might want the image stored in "2Pac - Greatest Hits" rather than in "FLAC files") then you can use a relative path to save the image as, like "..\Folder.%extension%".

Alex
Title: Album Art Downloader XUI
Post by: edmscan on 2014-09-06 21:32:28
I am having a small issue with AAD .. my config is below.

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" /ar "%artist%" /al "%album%" /p "$replace(%_path%,%_filename_ext%,)Front.jpg"

It is that it will not replace a .png (also .jpeg files) file with the specified Front.jpg downloaded.

I have to go to "Manage Attached Pictures" and remove the old one .. and add the new one manually.

The new file is there .. but I have to do the above before it will display.

Wondering .. if I can use a better config to fix this issue.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-09-07 08:03:04
it will not replace a .png (also .jpeg files) file with the specified Front.jpg downloaded.

You can use "Front.%extension%" instead of "Front.jpg", which will save the image with the correct extension based on the file type. That way if you download a png file it will be saved as Front.png.

However, if your problem is that you have an existing Front.png file, and you want that to be automatically deleted when you download a new jpg file, then that's not going to happen, sorry.

Alex
Title: Album Art Downloader XUI
Post by: edmscan on 2014-09-07 17:15:53
Ok .. thank you.

I am going to delete all the .png and .jpeg files, that will simplify things. I will make the extension change too. However I know it will not fix the embedded ones. I am ok with it .. as really I have fixed most of them manually already.
Title: Album Art Downloader XUI
Post by: devoidzer0 on 2014-09-12 16:15:13
What's the best way to configure this program to download album artwork automatically and accurately?  I know that you can set it to automatically download from the Queue Manager, but I'm having a hard time getting it to do so accurately.  What it chooses to download all hinges on the settings you use under Options.  What are the best settings to use here?  I'm currently filtering by the image size (a minimum of 300px and a max of 900) and only have the front cover checked.

Also, what are the best sources to have checked?  If you check everything, I'm finding that it often comes up with tons of results but a higher percentage that are inaccurate.  If I only select one or two it doesn't always have the album I'm looking for.  I'm wondering if there are certain sources that are better to use.  I'm assuming it downloads the first result if set to automatically download?

One annoying thing I'm finding is that if you have any extraneous information in your album tags, it often doesn't come up with any search results.  For instance, if my album tag says "Rubber Soul [2009 Remaster]" I'm finding that there aren't many results.  If I remove the text in brackets I get a lot more results.  If I'm trying to download automatically, I don't want to have to manually edit the search terms (and I don't want to change my tags).

I don't have time to read the whole thread, so forgive me if any of this has been covered.
Title: Album Art Downloader XUI
Post by: soundman9999 on 2014-09-14 12:34:48
hy!
thx for the great program!

one thing i discovered:
when treating compilations from different artists with different tracks from different albums it downloads a front.jpg for each song, always overwriting the last one it downloaded.

for example:
\the eighties compilation\debbie harry - call me
\the eighties compilation\marc almond - tainted love

will result in loading front.jpg for blondie, and in the next step it downloads
front.jpg for marc almond.

is there a fix for that?
thx
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-09-14 17:03:03
What's the best way to configure this program to download album artwork automatically and accurately?
It's always going to be a trade-off between automatically and accurately. And quality, although you don't mention that as a requirement for you. The best sources depend on what sort of music is in your collection, and what size of image you want. For medium-sized images and a mainstream collection, Amazon is usually a good first bet.

When automatically downloading, yes, it will use the first result that matches the criteria you've set, and then move on to the next album.

Unfortunately what you deem to be extraneous is down to personal preference. It's entirely possible that the 2009 Remaster of Rubber Soul would have a different album cover to the original. Only you can decide that you don't, in fact, care, and would be happy with any album cover for Rubber Soul.

So, basically, if you want something that you can just point at your albums and say "fetch all the art for them" without further interaction, you are probably going to end up with some poor quality and outright wrong covers. If you want to do better, you're going to need to put some manual effort in.

when treating compilations from different artists with different tracks from different albums it downloads a front.jpg for each song, always overwriting the last one it downloaded.
There is some support for Various Artists albums. This only works with the file browser, and runs as a second pass after searching all your album folders. It looks through all the 'albums' (artist/title pairs) it's added then when there are several with the same title but different artists, that have all been found in the same folder, it will replace them all with a single "Various Artists" album of that title.

If you are using the Foobar browser then make sure you have an %album artist% (http://wiki.hydrogenaud.io/index.php?title=Foobar2000:Title_Formatting_Reference#.25album_artist.25) tag set, and it will use that.

Alex
Title: Album Art Downloader XUI
Post by: phanhan on 2014-09-16 06:05:49
Hello every body.
an addition to my/your last post:
i use foobar2000 on my portable usb stick to play some songs i like, if i'm not on my home computer.
now i see, that AAD will save data on every computer i visited and play songs (and download some covers)
do you mind to save data in the AAD-programs folder? (relative path, without a fixed harddrive-letter)?
Title: Album Art Downloader XUI
Post by: Hurlex on 2014-10-09 03:17:58
I have mostly electronic music and since most of those genres aren't album orientated I never really bothered to fill in the album tag (usually I'll only have a (few) song(s) from a single or EP, instead of complete albums).

So I'm looking for a way to download the album art of songs without an album tag? Using the artist & title, which will give a list of the albums/EPs/singles that have the song, from which the used can select the album art to download.

In case this isn't possible, do any of you know of an app/script that can find the album based on artist & track title? Than I'll run that program first & then the Album Art program afterwards.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-10-09 08:03:07
So I'm looking for a way to download the album art of songs without an album tag? Using the artist & title, which will give a list of the albums/EPs/singles that have the song, from which the used can select the album art to download.

Album Art Downloader will just pass the search terms on to the sites it searches, so if there is any source that would be able to find albums by track name and artist then it will work. Google Images is probably your best bet.

Alex
Title: Album Art Downloader XUI
Post by: Hurlex on 2014-10-10 18:26:26
So I'm looking for a way to download the album art of songs without an album tag? Using the artist & title, which will give a list of the albums/EPs/singles that have the song, from which the used can select the album art to download.

Album Art Downloader will just pass the search terms on to the sites it searches, so if there is any source that would be able to find albums by track name and artist then it will work. Google Images is probably your best bet.

Alex

Thanks, I can find stuff with Google Images but it's usually not the (right) album art. I mostly listen to underground house music from 1996-2002 and was able to find most releases on discogs from where I manually downloaded the album art. Any other ideas?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-10-11 07:57:02
Thanks, I can find stuff with Google Images but it's usually not the (right) album art. I mostly listen to underground house music from 1996-2002 and was able to find most releases on discogs from where I manually downloaded the album art. Any other ideas?

Sorry, no. Unless discogs can find the album based on the song name and artist, then you're probably out of luck for an automatic solution, or anyone else has any ideas?

Alex
Title: Album Art Downloader XUI
Post by: boorger on 2014-10-11 16:30:19
Its is soooooo annoying app ever used. omg/
At first sight i had intetntion to make a good donate for programmers. but. stopped just in time. (when started use this app)
So
I have a folder with lots of music( various artists in folder).
different artists different albums - mixed in one folder.
i tried a lot of configs in "Folder browser" ex. %album artist% EVEN %filename%
program  :\

  create Front.jpg, then resave a new front after search, each song changes this Folder.jpg file AHHAHAHA     
WHO wrote this app is normal one? he might be never use a apple products - it must be SIMPLE in use!!!!!
really , everytime after fighting with this app, I WANT KILL SOMEONE!! 
How to make proper settings in this crazy app??? oh sht im burning
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-10-11 17:25:01
I have a folder with lots of music( various artists in folder).
different artists different albums - mixed in one folder.
Yeah... OK. So I think what you might want to do first is decide how you want your art to be saved, then. Until you have it clear in your mind, you won't be able to tell Album Art Downloader where you want to save it. You might, for example, want to save all the artwork in your same jumbled music folder, named as "artist - album.jpg". In which case, you need to click Options and change the path to find images box to "%artist% - %album%.%extension%".

Unlike an Apple product, Album Art Downloader does not demand that you match your usage to Apple's opinion of the right way to do things, but is a flexible tool that can be made to behave the way you want it to.
Title: Album Art Downloader XUI
Post by: boorger on 2014-10-12 17:37:30
I have a folder with lots of music( various artists in folder).
different artists different albums - mixed in one folder.
Yeah... OK. So I think what you might want to do first is decide how you want your art to be saved, then. Until you have it clear in your mind, you won't be able to tell Album Art Downloader where you want to save it. You might, for example, want to save all the artwork in your same jumbled music folder, named as "artist - album.jpg". In which case, you need to click Options and change the path to find images box to "%artist% - %album%.%extension%".

Unlike an Apple product, Album Art Downloader does not demand that you match your usage to Apple's opinion of the right way to do things, but is a flexible tool that can be made to behave the way you want it to.

Okay, I realized some things:
The MP3 player like wm/winamp/itunes read the id3 tag info- "artist " and "album ", then look in the same folder for a file %artist%-%album%.%extension% or cover.jpg/folder.jpg as last chance.
So before using AAD i must check are the id3tags correct with Mp3tag for example
And after this. Run AAD and make search with options:
-take info from id3 tags
-pattern is just %artist% - %album%.%extension%
And everything will work?
...
Also i had an idea - i need a script to put every mp3 to a it own folder, then find folder.jpg then embded art with mp3tag/foobar2000 the move all mp3 from their own folders back to only one folder.
Thats crazy method. its just a odd idea. Really difficult. Better to use artist-album.jpg
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-10-12 17:52:57
That should work, yes. Of course, if your artist and album tags ID3 aren't accurate then it will make everything a lot more difficult! I don't know about wm/winamp/itunes, but foobar will certainly allow you to specify where the album art is based on the artist and album ID3 tags.

If you are using another player, then you'll have to find out what they support for looking up art files. If they really only support "Folder.jpg" then you would have to reorganize your collection so that each album is in it's own folder - that's the sort of thing foobar or Mp3Tag would be able to help you with.
Title: Album Art Downloader XUI
Post by: marc2003 on 2014-10-12 18:20:25
i was poking around in musicbrainz.boo and i pinched(!) a bit of regex that escapes the artist/album before it's sent to the search server. i'm just curious as to what the bit in red does??

Quote
/[+!(){}\[\]^"~*?:\\\/-]|&&|\|\|/g
Title: Album Art Downloader XUI
Post by: AlexVallat on 2014-10-12 19:01:34
i'm just curious as to what the bit in red does??

It's Sebastian's script, but just from reading the regex what the bit in red does is match "&&" or "||" in the artist or album name. The code then escapes it by prefixing a \ to it. So instead of "One + One && Two || Three" your would get "One \+ One \&& Two \|| Three". I'm really not sure whether that's a bug, and it ought to be \&\& and \|\|, or whether that really is what musicbrainz expects. Perhaps Sebastian can give a better answer.
Title: Album Art Downloader XUI
Post by: marc2003 on 2014-10-12 19:43:47
sorry, i didn't even notice the author part at the top. it seems to work fine as it is escaping a single & or | and that's good enough for me.

edit: upon checking the output, it's not actually escaping those characters at all but the search is still working. i've tested with the bit in red removed completely and i still get the same results i want.

anyway, thanks for replying.
Title: Album Art Downloader XUI
Post by: mobyduck on 2014-10-12 20:01:55
So instead of "One + One && Two || Three" your would get "One \+ One \&& Two \|| Three".
I'm not an expert, but doesn't it strip all occurences of the matched strings? IOW, you would get "One One Two Three".

Alessandro
Title: Album Art Downloader XUI
Post by: marc2003 on 2014-10-12 20:34:46
but doesn't it strip all occurences of the matched strings?


nope, here's the full bit of code to give it context. it actually adds a backslash to any match.

Code: [Select]
regexpArtist = /[+!(){}\[\]^"~*?:\\\/-]|&&|\|\|/g.Replace(artist) do (m as Match): return "\\${m}"
encodedArtist = EncodeUrl(regexpArtist)


the musicbrainz search server requires the (API) user to escape certain characters first. for example, AC/DC will give an error so that first line of code will translate it into AC\/DC.
Title: Album Art Downloader XUI
Post by: boorger on 2014-10-13 01:14:05
That should work, yes. Of course, if your artist and album tags ID3 aren't accurate then it will make everything a lot more difficult! I don't know about wm/winamp/itunes, but foobar will certainly allow you to specify where the album art is based on the artist and album ID3 tags.

If you are using another player, then you'll have to find out what they support for looking up art files. If they really only support "Folder.jpg" then you would have to reorganize your collection so that each album is in it's own folder - that's the sort of thing foobar or Mp3Tag would be able to help you with.


Ok, got it!can foobar embded artwork into MP3 file by using artist - album.jpg?
If so, it really makes everything easier! That mean i dont need to know what supported by each player, the artwork will be inside the MP3.
Title: Album Art Downloader XUI
Post by: boorger on 2014-10-13 15:30:37
Foobar extension to work with album art costs extra money.
Really disappointed.
Title: Album Art Downloader XUI
Post by: marc2003 on 2014-10-13 15:34:49
wut?    foobar itself can embed art and it's always been free. make sure you download it from the official website.

http://www.foobar2000.org/ (http://www.foobar2000.org/)

add some files to a playlist>right click>tagging>batch attach pictures and you can enter a pattern that it should look for in each folder.
Title: Album Art Downloader XUI
Post by: boorger on 2014-10-14 06:48:36
Can someone make a GOOD script to find in Google images without theese all difficults?
Just find the first image that is more looks like square album art.
BECAUSE
that what we have google scrip is working toooo slow. sometimes it takes 5 minuts, then "not found". sad.
cause i have some names are strange, some without album or artist in IDv3tag, tey named manually, sometimes like
SmartGrace.mp3 Dukenukemmenu.mp3 , doommusiAll.mp3 NFSporscheUnleashed - Menu theme.mp3
Thats SO funny covers in google, just any images is better then "NOT FOUND".
not only a TRUE square album art needed, sometimes any image that google found.
Title: Album Art Downloader XUI
Post by: MarkGL on 2014-10-18 00:05:53
I have just started using the album art downloader and I'm having trouble.

Could somebody guide me please?

I have one folder with all my music in, no subfolders. Just all the tracks together in the one folder. I used the automatic option on the downloader to find and save artwork for 150 odd albums which are all in the one folder. Unfortunately every album has the same picture saved as its artwork.

Do I need to change the options at all to make sure it saves all the right artwork for the right albums?
Title: Album Art Downloader XUI
Post by: boorger on 2014-10-18 17:20:23
I have just started using the album art downloader and I'm having trouble.

Could somebody guide me please?

I have one folder with all my music in, no subfolders. Just all the tracks together in the one folder. I used the automatic option on the downloader to find and save artwork for 150 odd albums which are all in the one folder. Unfortunately every album has the same picture saved as its artwork.

Do I need to change the options at all to make sure it saves all the right artwork for the right albums?


Read my posts, dude, it calls "various artists problem", shortly "VAP".
In options choose get info from IDv3tag, the in secound bar put %artist% - %album%.%extension%
Then download the covers then use foobar2000 or mp3tag app to embded art to mp3 file.
P.s.  All the idv3tags in mp3 must be correct, not empty.
AAD quite stupid, but this software is only one thing people have now.
Title: Album Art Downloader XUI
Post by: thomian on 2014-10-20 12:24:45
Hey Alex,
I found out that you might download the HighRes Images from Qobuz with the extension "_max.jpg". Your Script so far only supports 600px Images

Here is an example:

For this Album
http://www.qobuz.com/de-de/album/wolfgang-...-/0886443899575 (http://www.qobuz.com/de-de/album/wolfgang-amadeus-mozart-le-nozze-di-figaro-andrei-bondarenko-simone-kermes-christian-van-horn-fanie-antonelou-mary-ellen-nesi-maria-forsstrom-musicaeterna-teodor-currentzis-/0886443899575)

You'll find the 600px Image under
http://static.qobuz.com/images/covers/75/9...3899575_600.jpg (http://static.qobuz.com/images/covers/75/95/0886443899575_600.jpg)

And the HigHResolution Image under
http://static.qobuz.com/images/covers/75/9...3899575_max.jpg (http://static.qobuz.com/images/covers/75/95/0886443899575_max.jpg)

Perhaps you'll like to update the Qobuz Script.
Yours Thomian
Title: Album Art Downloader XUI
Post by: NFS_FM on 2015-01-03 13:04:28
Hello, can you add a script for trackitdown.net? It feautures many high-res artworks for electronic music.

For example, this a direct 'Show image' link: https://d33yltq05bdjmc.cloudfront.net/graph...000__normal.png (https://d33yltq05bdjmc.cloudfront.net/graphics/996/996000__normal.png)
After changing '__normal.png' with '_original.jpg', it reveals the full-sized image.

Thank you!
Title: Album Art Downloader XUI
Post by: devoidzer0 on 2015-01-03 13:16:07
I've found what I consider to be the holy grail: an album art downloader that is extremely simple to use, automatic and just works most of the time.  For anyone pulling their hair out with complex software I urge you to check out Bliss.  It is unique in that it is server-based and runs in the background scanning your music folders for changes, and is accessed via web browser.  The automation and accuracy of this program is something to behold. 

I'm ecstatic that I found this jewel and gladly purchased an unlimited license after trying it.  Sorry if this sounds like spam, but I'm just very enthusiastic about this software.  The developer is UK-based and keeps the program current with frequent updates.  I urge everyone to try it and see for yourself. 

http://www.blisshq.com/ (http://www.blisshq.com/)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-03 19:15:46
Hello, can you add a script for trackitdown.net?
Sure, thanks for the tip. I don't know how you discovered the _original.jpg image urls, but they do seem to work on the few I found!

Please give trackitdown.boo (http://album-art.sourceforge.net/scripts/trackitdown.boo) a go and let me know how you get on.

Alex
Title: Album Art Downloader XUI
Post by: NFS_FM on 2015-01-03 20:03:42
Yeap, it does work! Kinda.. It finds some tracks, but not ALL of them I think. Also, can you add a 'track' field for searching individual tracks? Thank you for the script!

P.S: I don't remember too how did I find it. I think I was playing around with Google Images!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-03 20:14:00
Yeap, it does work! Kinda.. It finds some tracks, but not ALL of them I think. Also, can you add a 'track' field for searching individual tracks? Thank you for the script!

You're welcome. Can you give me some examples which you can find with the website that you can't find using AAD?

I'd suggest using the Album field for searching for individual tracks. The query it passes to trackitdown.net specifies the artist explicitly, but the album just goes into the generic "keyword" search field, so you can put whatever you want in there.

Alex
Title: Album Art Downloader XUI
Post by: NFS_FM on 2015-01-03 20:22:40
No problem, nevermind. I just had to wait a little more... Everything is fine.

I wasn't talking specifically for track it down, I meant an overall 'track' search, but I'll see if 'album' works too.

Thank you, 'album' works, too.
Title: Album Art Downloader XUI
Post by: thomian on 2015-01-05 23:55:00
Hey Alex,
I found out that you might download the HighRes Images from Qobuz with the extension "_max.jpg". Your Script so far only supports 600px Images
...
Perhaps you'll like to update the Qobuz Script.
Yours Thomian


I udated the Qobuz script by my own, based on Alex iTunes script.
It works pretty fine for me.

I have no idea how to upload the qobuz.boo file directly to this forum, so here comes the code, for those of you who like High Resolution Images from Qobuz.
Alex you can use this code for an official update of the Qobuz script.

Code: [Select]
import System
import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util

class Qobuz(AlbumArtDownloader.Scripts.IScript):
    Name as string:
        get: return "Qobuz"
    Version as string:
        get: return "0.11"
    Author as string:
        get: return "Alex Vallat, thomian"
    def Search(artist as string, album as string, results as IScriptResults):
        artist = StripCharacters("&.'\";:?!", artist)
        album = StripCharacters("&.'\";:?!", album)

        //Retrieve the search results page
        searchResultsHtml as string = GetPage("http://www.qobuz.com/recherche?i=boutique&q=" + EncodeUrl(artist + " " + album))
        
        matches = Regex("<a href=\"(?<url>[^\"]+)\"[^>]+>\\s+<img alt=\"(?<title>[^\"]+)\"[^>]*rel=\"(?<id>(?<idPrefix>[^\"]{4})[^\"]*(?<idPrefix2>[^\"]{2})(?<idPrefix1>[^\"]{2}))\"", RegexOptions.Singleline | RegexOptions.IgnoreCase).Matches(searchResultsHtml)
        
        results.EstimatedCount = matches.Count

        for match as Match in matches:
            infoUrl = match.Groups["url"].Value
            title = match.Groups["title"].Value
            id = match.Groups["id"].Value
            idPrefix = match.Groups["idPrefix"].Value
            idPrefix1 = match.Groups["idPrefix1"].Value
            idPrefix2 = match.Groups["idPrefix2"].Value
            urlBase = "http://static.qobuz.com/images/covers/${idPrefix1}/${idPrefix2}/${id}"
            // in previous script versions the image was reached using URL-Base:
            // urlBase = "http://static.qobuz.com/images/jaquettes/${idPrefix}/${id}"
            // this link still works, but not for max size images, only for 600px images

            // See if max size jpg is available
            if CheckResponse(urlBase + "_max.jpg"):
                fullSizeImageUrl = urlBase + "_max.jpg"
            else:
                // fall back on 600x600
                fullSizeImageUrl = urlBase + "_600.jpg"
            
            results.Add(urlBase + "_100.jpg", title, "http://www.qobuz.com" + infoUrl, -1, -1, fullSizeImageUrl, CoverType.Front)

    def CheckResponse(url):
        checkRequest as System.Net.HttpWebRequest = System.Net.HttpWebRequest.Create(url)
        checkRequest.Method = "HEAD"
        checkRequest.AllowAutoRedirect = false
        try:
            response = checkRequest.GetResponse() as System.Net.HttpWebResponse
            return response.StatusCode == System.Net.HttpStatusCode.OK
        except e as System.Net.WebException:
            return false;
        ensure:
            if response != null:
                response.Close()

    def RetrieveFullSizeImage(fullSizeCallbackParameter):
        return fullSizeCallbackParameter
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-06 08:05:25
Hey Alex,
I found out that you might download the HighRes Images from Qobuz with the extension "_max.jpg". Your Script so far only supports 600px Images
...
Perhaps you'll like to update the Qobuz Script.
Yours Thomian


I udated the Qobuz script by my own, based on Alex iTunes script.
It works pretty fine for me.

Thanks thomian. Sorry, I don't know how I missed your first message. I've uploaded your modified version of Qobuz, but I changed the version number to 0.2 instead of jumping from 0.1 to 0.11 - unless there was some special reason you chose .11?

Alex
Title: Album Art Downloader XUI
Post by: thomian on 2015-01-06 14:31:39
No Problem. No special reason.
I were not sure how to set the "import" functions of the header properly.
So I chose "0.11" to leave space for an official version update.
Thanks for uploading...
yours thomian
Title: Album Art Downloader XUI
Post by: Elwood Blues on 2015-01-07 12:24:00
Hi,

I just saw that with the new Qobuz script only highres files get downloaded. While this might be a great thing for some, for me this is actually quite annoying (since I have to convert them manually to 600x600).
Is there a way so the user can decide which images get downloaded?

Thanks,
Elwood
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-07 13:04:13
Is there a way so the user can decide which images get downloaded?
No, but you can use the old Qobuz script instead, if you prefer: qobuz.boo (http://album-art.sourceforge.net/scripts/old/qobuz.boo)

Alex
Title: Album Art Downloader XUI
Post by: jarome on 2015-01-10 19:26:32
It dies after about 400 albums saying that the album name/path is too long without telling me which one it is. And it should not croak when this happens; it should just go to the next album!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-10 21:45:12
It dies after about 400 albums saying that the album name/path is too long without telling me which one it is. And it should not croak when this happens; it should just go to the next album!

I need a bit more detail to go on. Did it pop open notepad with an error log? Was it in the File Browser? When searching for music? With ID3 tags or file path matching?

I agree that it shouldn't crash out, but I need to be able to pin down exactly where the crash is occurring.
Title: Album Art Downloader XUI
Post by: jarome on 2015-01-11 00:01:58
It dies after about 400 albums saying that the album name/path is too long without telling me which one it is. And it should not croak when this happens; it should just go to the next album!

I need a bit more detail to go on. Did it pop open notepad with an error log? Was it in the File Browser? When searching for music? With ID3 tags or file path matching?

I agree that it shouldn't crash out, but I need to be able to pin down exactly where the crash is occurring.

It is a message in the bottom bar of the file browser as it scans my directory.
https://www.dropbox.com/s/b9he5mx0sqqk87y/f...rowser.png?dl=0 (https://www.dropbox.com/s/b9he5mx0sqqk87y/filebrowser.png?dl=0)

I have about 5000+ albums
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-11 09:22:00
It is a message in the bottom bar of the file browser as it scans my directory.

Thanks for the screenshot. Having paths which are longer than the windows maximum path length should not stop it from scanning other folders, just the ones that are too long. I've had a look through the area in question, and can only see one possible situation in which the error in your screenshot could result. Please give the attached test build a try and see if it resolves the issue for you:

[attachment=8132:AlbumArt...rimental.zip]
Alex


Title: Album Art Downloader XUI
Post by: audiophool on 2015-01-11 09:36:59
For the last few weeks, I've seen frequent crashes. They're usually reproducible. (When I restart AAD and do the same thing, I get a crash once again.) I search for an artist/album. When I click on one of the sources (right column of the GUI), AAD crashes.

Here's the error log:

Code: [Select]
App version: 1.0.1.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.NullReferenceException: Object reference not set to an instance of an object.
   at AlbumArtDownloader.ArtSearchWindow.OnSourceHighlightResults(Object sender, EventArgs e)
   at AlbumArtDownloader.Controls.SourcePanel.OnMouseLeftButtonUp(MouseButtonEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
   at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-11 10:04:37
For the last few weeks, I've seen frequent crashes. They're usually reproducible. (When I restart AAD and do the same thing, I get a crash once again.) I search for an artist/album. When I click on one of the sources (right column of the GUI), AAD crashes.

Thanks for reporting this. I'm trying to reproduce it here, but no luck yet. As you can reproduce it reliably, could you check: Are you clicking on a source which is selected or unselected for searching? If it's selected, does it have any results? Are there results from that source currently visible in the search area, or would they have to be scrolled into view? Is it a specific source, or does it happen for any source you click on? Are you using any filtering or grouping settings?

Thanks,

Alex
Title: Album Art Downloader XUI
Post by: audiophool on 2015-01-11 11:18:33
Thanks for reporting this. I'm trying to reproduce it here, but no luck yet.

Thanks for looking into this! Here's an example which should answer some of your questions.

The attached screenshot was taken shortly before I clicked on the GoogleImage source:

(http://i.imgur.com/qogC2wK.jpg) (http://imgur.com/qogC2wK)

When I clicked on the source, the crash resulted. The crash log is as follows:

Code: [Select]
App version: 1.0.1.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.ArgumentNullException: Value cannot be null.
Parameter name: adornedElement
   at System.Windows.Documents.Adorner..ctor(UIElement adornedElement)
   at AlbumArtDownloader.Controls.HighlightResultAdorner..ctor(UIElement adornedElement)
   at AlbumArtDownloader.ArtSearchWindow.OnSourceHighlightResults(Object sender, EventArgs e)
   at AlbumArtDownloader.Controls.SourcePanel.OnMouseLeftButtonUp(MouseButtonEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
   at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)



Quote
As you can reproduce it reliably, could you check: Are you clicking on a source which is selected or unselected for searching?

Selected.

Quote
If it's selected, does it have any results?

In the example above, yes. I just got the script to crash when clicking on the Discogs source. In that case, Discogs was selected for searching and there were results for it, too.

Quote
Are there results from that source currently visible in the search area, or would they have to be scrolled into view?

The results are currently visible. (In the case where I provoked a crash by clicking on the Discogs source, at least some of the results were currently visible.)

Quote
Is it a specific source, or does it happen for any source you click on?

It seems at least GoogleImage and Discogs are affected. There may be more. From now on, I'll pay attention to what click causes a crash. I'll report back.

Quote
Are you using any filtering or grouping settings?

I have a filter by image size enabled (minimum 300 px). No grouping settings.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-11 11:25:28
Thanks for looking into this! Here's an example which should answer some of your questions.
OK, thanks, I *think* I have this pinned down now. Could you give the attached a try and see if it resolves it for you?

[attachment=8133:AlbumArt...mental-2.zip]
Thanks,

Alex
Title: Album Art Downloader XUI
Post by: audiophool on 2015-01-11 11:38:23
Could you give the attached a try and see if it resolves it for you?

It appears the new version indeed resolves the issue. No more crashes.

Thanks a lot!
Title: Album Art Downloader XUI
Post by: jarome on 2015-01-11 14:20:04
It is a message in the bottom bar of the file browser as it scans my directory.

Thanks for the screenshot. Having paths which are longer than the windows maximum path length should not stop it from scanning other folders, just the ones that are too long. I've had a look through the area in question, and can only see one possible situation in which the error in your screenshot could result. Please give the attached test build a try and see if it resolves the issue for you:

[attachment=8132:AlbumArt...rimental.zip]
Alex

That fixed it!
Is there a way to put the album art inside each album folder?

I do get Album Art Downloader has stopped working messages when I look for art, then it crashes! No messages.
I have 5400 albums, and queue 50 at a time.

It does not work at all now. https://www.dropbox.com/s/075ukvnhpgguzsi/aad.png?dl=0 (https://www.dropbox.com/s/075ukvnhpgguzsi/aad.png?dl=0)
As soon is the first two search windows pop up, I get the non-responding message. Even as your program is still getting art. Then if I dismiss the error message, AADL stops and disappears!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-11 15:55:14
Is there a way to put the album art inside each album folder?
That's what it should be doing by default, as Folder.jpg... where are you finding it puts the art?

Unfortunately that error message is not very helpful! Windows ought to have logged more details, if you run the Event Viewer and check for an error with the source ".NET Runtime" for the time the crash occurred, there might be more useful information there.

Otherwise, I can offer general advice in that having all the sources checked can result in a lot of work, and a lot of memory usage (if they all return lots of results) - it might be worth trying it with just a few good sources instead. Another thing you can do to cut down resource usage is in the Queue Manager window set the number of simultaneous search windows to 1 or 2 instead of 3.

Of course if it's a specific album that's causing the crash, then that's a different matter! If that's the case, then let me know and we can try and figure out what's special about it.

Alex
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-17 09:22:59
Version 1.02
This release fixes the reported crash when clicking on a source with filtered out results, and improves the robustness of the folder browser when dealing with invalid paths (such as those that are too long).

I have also brought all the scripts up to date.

Download:
AlbumArtDownloaderXUI.exe (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.02.exe/download) (Installer. Recommended)
AlbumArtDownloaderXUI.zip (http://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.02.zip/download) (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (http://www.microsoft.com/downloads/details.aspx?FamilyId=AB99342F-5D1A-413D-8319-81DA479AB0D7) (required, except for Windows 7 and 8)Donations (http://www.byalexv.co.uk/foobar/AlbumArtDownloader/donate)
Title: Album Art Downloader XUI
Post by: bilbo on 2015-01-17 14:37:36
Version 1.02
This release fixes the reported crash when clicking on a source with filtered out results, and improves the robustness of the folder browser when dealing with invalid paths (such as those that are too long).


Thank you AlexVallat for all of your efforts. This is a great program thanks to you. I have been using it for years!
Title: Album Art Downloader XUI
Post by: psychoadept on 2015-01-18 05:23:09
I just downloaded and installed 1.0.2.0 on Windows 7 64-bit.  AADL has always been a little unstable for me, often crashing on startup, but after a few tries it would get over its hiccup and work fine.  With the new version, it won't start at all and I get this message every time:

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 1.0.2.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Users\HP\AppData\Local\AlbumArtDownloader\AlbumArt.exe_Url_ab4blq4r5vajyecsjktugtsqgadfd4lg\1.0.2.0\Scripts'.
  at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
  at System.IO.Directory.InternalGetFileDirectoryNames(String path, String userPathOriginal, String searchPattern, Boolean includeFiles, Boolean includeDirs, SearchOption searchOption)
  at System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)
  at AlbumArtDownloader.App.LoadScripts()
  at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  at System.Windows.Application.<.ctor>b__0(Object unused)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at System.Threading.ExecutionContext.runTryCode(Object userData)
  at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Application.RunInternal(Window window)
  at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  at AlbumArtDownloader.App.Main(String[] args)

Any help is appreciated!


Edit: For what it's worth, copying the "Scripts" folder from the 1.0.1.0 directory to the 1.0.2.0 directory allowed it to run, but when it opens the only thing listed under Sources is Local Files.

Further edit: Completely uninstalling, restarting, and reinstalling seems to have sorted it out.  I apologize for neglecting to try that in the first place; I know better!

Thanks for such a handy program!
Title: Album Art Downloader XUI
Post by: BruceFeuillette on 2015-01-24 11:14:30
Hello !
First, sorry if the question has already been asked, I can't find the answer
I'm using the Search Window from the File Browser (It's important !).
I want to download the cover as cover.jpg. I have a preset and default set to cover.
But AAD always add Folder before. So I have Foldercover.jpg
The "Images will be saved to" filed is greyed and set to "H:\Carcass\Swansong\Folder%preset%.%extension%".
(http://images.dabeuliou.Com/AAD.jpg)
If I use the Search Windows directly, this field is editable, so I can correct it.
(http://images.dabeuliou.Com/AAD01.jpg)
Title: Album Art Downloader XUI
Post by: BruceFeuillette on 2015-01-24 12:40:34
OK, I manage to get it right.
I edited the user.config file located in C:\Users\USERNAME\AppData\Local\AlbumArtDownloader\AlbumArt.exe_Url_ab4blq4r5vajyecsjktugtsqgadfd4lg\1.0.2.0
On lines 672 and 677.
Code: [Select]
<string>Folder%preset%.%extension%</string>

Just remove "Folder".
I think it's a bug because my "cover" preset was written
Code: [Select]
<string>Cover%preset%.%extension%</string>

which result in a Covercover.jpg file in the end.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-01-24 12:56:37
If you are coming from the file browser, then the image is saved in the same pattern as the file browser is searching for. So, to change this in the File Browser window, click the Options link and then in the Specify Path to Find Images change it to "Cover.%extension%". You don't need %preset% if you aren't using presets, and just want all your images to be called Cover.jpg. The preset system is there for doing things like "Cover-Alternative.jpg" or similar, when some covers need a slightly different name.

(For information, the default path in the file browser is: "Folder%preset%.%extension%|Cover%preset%.%extension%". The | separates alternatives, so it would first look for Folder.jpg, then Cover.jpg if Folder.jpg wasn't found. The search window uses the first alternative in the list - so Folder.jpg in this case)

Alex
Title: Album Art Downloader XUI
Post by: BruceFeuillette on 2015-01-24 13:01:01
Oh thanks ! 
I was looking in the top menu and I didn't see that options link ! 
Title: Album Art Downloader XUI
Post by: Matt714 on 2015-01-29 02:13:21
Possibly stupid question. How do you fix this: https://i.imgur.com/nG802m2.jpg (https://i.imgur.com/nG802m2.jpg)

Title: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2015-02-25 17:24:21
Hi, I've been using Album Art Downloader for a very long time, very good program!

But now I'm having a problem, I'm getting absolutely no covers from Discogs and Google anymore (although having the newest 1.02.0 version). Is there maybe something broken in the scripts?

Thanks in advance...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-02-25 20:00:59
I'm getting absolutely no covers from Discogs and Google anymore (although having the newest 1.02.0 version). Is there maybe something broken in the scripts?

Thanks for reporting this. I've updated Google Play Music (http://album-art.sourceforge.net/scripts/google-play.boo) and Discogs (http://album-art.sourceforge.net/scripts/discogs.boo), those should work again. Unfortunately Google Images has been broken beyond easy repair (they are no longer offering the &gbv=2 format and are encrypting image URLs). It might be possible to hack something together for google images, but I suspect not. Or not that would return any image larger than thumbnails, anyway. Google Images won't be included in future releases, and I'd recommend deleting or at least unchecking the google.boo script as it won't work any more)

Alex
Title: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2015-02-25 22:02:24
Thank you Alex for repairing Discogs!! But the loss of GoogleImages is very sad. For some older artists it is nearly the only source. Is there maybe a way to make a Bing or Yahoo script to replace Google?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-02-26 08:39:30
Is there maybe a way to make a Bing or Yahoo script to replace Google?

Seems reasonable. Please give bing.boo (http://album-art.sourceforge.net/scripts/bing.boo) a try and let me know how you get on with it.

Alex
Title: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2015-02-26 14:10:19
Awesome work, Alex! Bing script is working quite fine and seems to me a good replacement for GoogleImage. Thank you very very much!
Title: Album Art Downloader XUI
Post by: dutch109 on 2015-03-01 13:33:15
Unfortunately Google Images has been broken beyond easy repair (they are no longer offering the &gbv=2 format and are encrypting image URLs). It might be possible to hack something together for google images, but I suspect not.

What problem are you having exactly?

I maintain a command tool called SACAD (https://github.com/desbma/sacad) to scrape various cover sources (like AlbumArtDownloader, but command line, non interactive, and OS agnostic).
I have not noticed any recent change in Google page structure and all my automated tests are green (https://travis-ci.org/desbma/sacad/builds/52622352), which means Google still returns valid results.

The parsing code is here (https://github.com/desbma/sacad/blob/bd98a43d187bb7746308c0ac0c65aecee9ea2fe3/sacad/sources/google_images.py#L52), feel free to study or borrow it (MPLv2 license).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-03-02 07:53:59
What problem are you having exactly?
I don't know why your script is still working, to be honest. When I try any google image search with format gbv=2 (which you use too) it just returns an html page with a "click here if you are not redirected" link and no results. I'll do some poking around to see if it is headers or cookie related or something, thanks for letting me know.
Title: Album Art Downloader XUI
Post by: marc2003 on 2015-03-02 21:55:06
i think it has something to do with the user agent. if you try faking it as an older browser, it may work.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-03-04 07:53:55
i think it has something to do with the user agent. if you try faking it as an older browser, it may work.

Thanks, yep, that seems to have done the trick, along with a slight regex change for some reason. So google.boo (http://album-art.sourceforge.net/scripts/google.boo) is re-instated, and should be working now.

Alex
Title: Album Art Downloader XUI
Post by: FvB on 2015-03-04 13:31:09
Is it possible to add a request for a site?

If so, I'd like to request a search script for http://edmusic4change.blogspot.se/ (http://edmusic4change.blogspot.se/)


Tnx for a GREAT app!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-03-04 19:19:26
If so, I'd like to request a search script for http://edmusic4change.blogspot.se/ (http://edmusic4change.blogspot.se/)

I don't see any search facility on that site... if a site doesn't provide a search itself, then your best bet is to use google or bing image search which might include it in the results.
Title: Album Art Downloader XUI
Post by: edahS on 2015-03-05 18:39:47
Amazon(.jp) searching is broken.
Can't get any results from Amazon(.jp).
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-03-06 20:20:52
Amazon(.jp) searching is broken.
Can't get any results from Amazon(.jp).

Thanks for letting me know. I've updated the amazon scripts (they are all updated together, as they use a common base script), if you download both amazon-jp.boo (http://album-art.sourceforge.net/scripts/amazon-jp.boo) and amazon-common.boo (http://album-art.sourceforge.net/scripts/amazon-common.boo) then it should work again.

Alex
Title: Album Art Downloader XUI
Post by: Ngen-ko on 2015-03-25 04:57:34
Hey guys.

I'm having a problem where whenever i try to add the artwork through Foobar, it works most of the time, but when i get an album that has ':' in it. For example 'Grouper - A I A : Alien Observer' I get an error that says the given path's format is not supported.

It works for every other album except for those with ':' in it.

Anyone have any idea how i can fix this?
Title: Album Art Downloader XUI
Post by: marc2003 on 2015-03-25 05:32:51
: is one of several characters that are illegal in windows filenames. if you're using something like %artist% - %album%.jpg in the foobar artwork preferences, you actually need to replace the : in the filename with a -


Title: Album Art Downloader XUI
Post by: SlashEmUp on 2015-03-31 03:21:14
I don't know if this has been mentioned before or if it even is possible, but is there a way to have Album Art Downloader check that an actual image file.

For example, some of my albums have artwork embedded (I don't know if this is the correct phrase) in the mp3 files themselves, and artwork is detected. Instead, I would like if it detected actual jpg/image files.

Is this even possible. It isn't a big deal, but it would be nice.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-03-31 07:47:27
some of my albums have artwork embedded (I don't know if this is the correct phrase) in the mp3 files themselves, and artwork is detected. Instead, I would like if it detected actual jpg/image files.

Embedded artwork will only be found if using ID3 tags, so if you use file path pattern matching it wouldn't find any. That's not ideal, I know, but otherwise the only thing you can do is look in the Artwork Status column. If the filename ends in <0> (or any other number) then it's an embedded art that it found.
Title: Album Art Downloader XUI
Post by: will1565 on 2015-04-20 05:04:13
Alex you're an absolute hero for writing this software, its bloody awesome! It has very quickly become part of my music tagging routine.

Is there any chance of a Juno download (www.junodownload.com) script?  They're an amazing source for artwork. especially for singles.



Kind regards


will.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-04-20 18:23:59

Thanks, Will! There is a script for Juno Records (http://www.juno.co.uk) (juno-records.boo (http://album-art.sourceforge.net/scripts/juno-records.boo)), does that help?

Alex
Title: Album Art Downloader XUI
Post by: will1565 on 2015-04-22 01:01:03

Thanks, Will! There is a script for Juno Records (http://www.juno.co.uk) (juno-records.boo (http://album-art.sourceforge.net/scripts/juno-records.boo)), does that help?

Alex


Well kinda its Juno's sister website which deals with just digital downloads... I guess i could see if just changing all of the URLs will work in the juno one.... I have no idea about scripting so no laughing its thats a silly idea
Title: Album Art Downloader XUI
Post by: will1565 on 2015-04-22 01:11:40
Well that's not a huge shock, it didnt work  So yeah if you get time a junodownload script would be top banana
Title: Album Art Downloader XUI
Post by: audiophool on 2015-04-22 22:04:06
Alex,

Are you the developer of uBlock as well?

(Sorry for the off-topic, I admit this is nothing but curiosity.)
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-04-23 08:24:57
@will1565: OK, they do seem to have a different selection of albums, so please give juno-download.boo (http://album-art.sourceforge.net/scripts/juno-download.boo) a try and let me know how it works for you.

@audiophool: Not really, no. I have contributed some code to it, and I am the current maintainer of the Firefox port (which is why my name is on the AMO listing), but it's not my project.
Title: Album Art Downloader XUI
Post by: will1565 on 2015-05-13 20:06:32
Thank you very much Alex that works perfectly.  Well sometimes the results appear in a double sized result box but that isn't really an issue I guess.
Title: Album Art Downloader XUI
Post by: NFS_FM on 2015-06-08 22:56:23
Can you add support for soundcloud too?
You have to change the final part of the url (...-t500x500.jpg) to ...-original.jpg or ...-original.png. Is it possible? Thank you!
Title: Album Art Downloader XUI
Post by: slcc2c on 2015-06-09 00:52:34
I would like to have my art saved with the type of art in the filename so that I can have multiple pieces of art for one album, is this functionality possible when using the foobar browser or at all? I know the search window supports the type tags so I'd really take advantage of them in other places.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-06-09 08:00:11
Can you add support for soundcloud too?

It might be possible, but I can't find any good way to search soundcloud for albums. There doesn't seem to be any advanced search, and the standard search field returns a mixture of mostly user uploaded tracks and playlists, with pretty much any random image they chose to use.

I would like to have my art saved with the type of art in the filename so that I can have multiple pieces of art for one album, is this functionality possible when using the foobar browser or at all? I know the search window supports the type tags so I'd really take advantage of them in other places.

Yes, click the Options link and then in the "Specify path to find images" box you can put whatever you like, including the %type% placeholder. (It will be treated as * when searching, but populated when saving)
Title: Album Art Downloader XUI
Post by: NFS_FM on 2015-06-09 08:11:50
Can you add support for soundcloud too?

It might be possible, but I can't find any good way to search soundcloud for albums. There doesn't seem to be any advanced search, and the standard search field returns a mixture of mostly user uploaded tracks and playlists, with pretty much any random image they chose to use.


OK nice expalantion. If you find any solution, please implement it. Thank you for the useful program!
Title: Album Art Downloader XUI
Post by: domi1893 on 2015-06-10 16:09:44
Hi,

on my way through the internet i found the page "coverlib.com". it is a very good database. unfortunatelly there is no script inside the program for coverlib.
Is there a possibility to add a script for this page? this would be very nice and would be the perfect solution for me to complete my arts.


thank you

regards

domi
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-06-10 18:48:48
there is no script inside the program for coverlib. Is there a possibility to add a script for this page?

The eCover.to (http://album-art.sourceforge.net/scripts/cover-paradies.boo) script is the script for this site. They keep changing their name - before it was eCover.to it was cover-paradies, and now it is CoverLib, but it's the same database and the same art.
Title: Album Art Downloader XUI
Post by: domi1893 on 2015-06-10 19:53:15
there is no script inside the program for coverlib. Is there a possibility to add a script for this page?

The eCover.to (http://album-art.sourceforge.net/scripts/cover-paradies.boo) script is the script for this site. They keep changing their name - before it was eCover.to it was cover-paradies, and now it is CoverLib, but it's the same database and the same art.



Thank you
Title: Album Art Downloader XUI
Post by: domi1893 on 2015-06-10 20:00:18
i have tried to get some results with the search in ecover.to. But the program shows no results. Other scripts seems to work...
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-06-11 08:25:33
i have tried to get some results with the search in ecover.to. But the program shows no results. Other scripts seems to work...

Thanks for letting me know. I have updated the script, it should now work: cover-paradies.boo (http://album-art.sourceforge.net/scripts/cover-paradies.boo)
Title: Album Art Downloader XUI
Post by: domi1893 on 2015-06-11 10:52:45
i have tried to get some results with the search in ecover.to. But the program shows no results. Other scripts seems to work...

Thanks for letting me know. I have updated the script, it should now work: cover-paradies.boo (http://album-art.sourceforge.net/scripts/cover-paradies.boo)



it works perfect. Thank you so much. i´m happy :-)
Title: Album Art Downloader XUI
Post by: poisonborz on 2015-06-13 21:54:30
I've tried to use Google Image search (google.boo) script, and since it didn't worked, I looked up here in the forum, and used Alex's update with the old user agent hack - this worked, but: after two opened searches, the results stop coming. When I close and restart the app the search works again...for two windows. I know there were issues with Google Images before, but this one is rather strange, and I suspect the problem might be local.
Title: Album Art Downloader XUI
Post by: DaEddie on 2015-06-24 07:37:26
About the File Browser

The situation:
I got one folder containing hundreds of mp3 files of different artists and different albums as well. Some artworks are within the tag, other artworks are within the folder as jpg files - a nice cocktail with any possible combination. Therefore I use the option "Use ID3 tags from files".

Defining the path to find images:
I defined the absolut path including the format of the file name e.g. C:\Music\files to import\%artist% - %album%*.jpg (This would find a jpg file "Savage Garden - To The Moon And Back - Front.jpg" as long as the ID3 tag information is in propper shape. If the File Browser is used to get artwork for selection, this specified path and file name format will be used to save images found by AAD at the selected sources.

How the File Browser really works:
After countless hours of trial and error and reading the web it boils down to simple facts:
- If there is a "<0>" at the end of the line in the column "Artwork Status" an artwork saved within the tag was found
- AAD File Browser finds only ONE artwork (e.g. if there is an artwork saved in the tag it will not find any other files in the given location)
- If there are e.g. a "Front" and a "Back" artwork file within the search location only ONE will be found and showing up

It's kinda useless for this purpose and it would be really really nice to have a tiny little documentation about the syntax and restrictions of AAD.

Greetings
DaEddie
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-06-24 07:53:35

Hi DaEddie, thanks for your post.

I think the main restriction you have to bear in mind is that the file browser is only searching for albums that don't have art yet, so you can download it. It's not supposed to be a general purpose management tool for browsing or associating art with albums.

As you've discovered, filename<0> means an embedded image in that file. The syntax is simply the index number of the image embedded in the file, and as the file browser is just looking for any image, the first one found will be <0>.
Title: Album Art Downloader XUI
Post by: mneimeyer on 2015-06-25 16:10:14
As you've discovered, filename<0> means an embedded image in that file.


Relating to that... It would be nice if the Artwork Status column sorted by the full text (it looks like it only sorts by Found or Not) so that all the embedded files would be lumped together. Similarly, it would be nice if the Dimensions column sorted by the full text (it looks like that sorts by the first one only, so a random 800x600 might get lost in a sea of 800x800s).

BTW: I love AAD and thanks for all your hard work!
Title: Album Art Downloader XUI
Post by: moosefist on 2015-07-12 16:48:16
Is there a way to tell AAD to ignore embedded id3 artwork all together? I would like to use it to make sure I have folder images in each album for my collection.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-07-13 08:17:38
Is there a way to tell AAD to ignore embedded id3 artwork all together?

Only by using file pattern matching instead of ID3 tag matching - so only if your file and folder names are well organised. This can be set in the file browser "options" area.
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-07-16 01:38:49
I just started using this a few moment ago. What is AAD browser?

One thing I have tried:
I browse my music collection in both Windows Media Player and Foobar. If I am missing artwork in Foobar, I can find the same album in WMP. Next, I go to a Wikipedia page for that album. Now, you just right-click on the artwork image, right-click "Copy Image". Go back to WMP for the same album, right-click on that album and "Paste Album Art". Now, the artwork will be view-able in Foobar as well as well as WMP. I'm not sure how it works, but it is very handy.

EDIT: Sorry, I forgot to mention that I am using an iPod Classic and I have a plug-in in WMP that allows it to "see" the iPod.
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-07-17 17:31:55

Hi DaEddie, thanks for your post.

I think the main restriction you have to bear in mind is that the file browser is only searching for albums that don't have art yet, so you can download it. It's not supposed to be a general purpose management tool for browsing or associating art with albums.

As you've discovered, filename<0> means an embedded image in that file. The syntax is simply the index number of the image embedded in the file, and as the file browser is just looking for any image, the first one found will be <0>.

I am using Foobar. When the above happens to me, the file browser does confirm that there is artwork for an album. However, Foobar does not necessarily display artwork for that album. I think I tried ticking the box for that album and searching for artwork. But, this seems to fail. One thing that happens is the downloader displays an error when trying to copy over "folder. jpg"? I can work-a-around using Windows Explorer. Why can't the downloader do this directly?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-07-17 19:21:09

Hi DaEddie, thanks for your post.

I think the main restriction you have to bear in mind is that the file browser is only searching for albums that don't have art yet, so you can download it. It's not supposed to be a general purpose management tool for browsing or associating art with albums.

As you've discovered, filename<0> means an embedded image in that file. The syntax is simply the index number of the image embedded in the file, and as the file browser is just looking for any image, the first one found will be <0>.

I am using Foobar. When the above happens to me, the file browser does confirm that there is artwork for an album. However, Foobar does not necessarily display artwork for that album. I think I tried ticking the box for that album and searching for artwork. But, this seems to fail. One thing that happens is the downloader displays an error when trying to copy over "folder. jpg"? I can work-a-around using Windows Explorer. Why can't the downloader do this directly?

The downloader won't be able to overwrite folder.jpg if it is readonly, or if is is open in some other program, or if you require elevated (administrator) permissions to delete it. I don't know what your workaround is, so I can't comment on why the downloader can't do it. But I will say that I don't think it's appropriate for the downloader to remove a readonly flag, for example, if that's what the problem was.
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-07-17 19:43:49
I am using the built-in Administrator account. I checked a few of the "folder.jpg" and they are not read-only. I even closed Foobar and retried. No go. As I said, if can do this in Windows Explorer, I don't see why the downloader can't do it? Error message: "Access to the path bla bla bla is denied"
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-07-18 07:53:50
I am using the built-in Administrator account. I checked a few of the "folder.jpg" and they are not read-only. I even closed Foobar and retried. No go. As I said, if can do this in Windows Explorer, I don't see why the downloader can't do it? Error message: "Access to the path bla bla bla is denied"

I don't know then. If Explorer isn't giving you the "You'll need to provide administrator permission to delete this file / Continue" popup then it wouldn't be a UAC elevation problem. You've checked it isn't a read-only flag, so it isn't that. Any chance you are running Album Art Downloader as a different user than Explorer? Windows does funny things with admin accounts, so if you are running as admin then it's possible it still runs Album Art Downloader as User. You could try right clicking and Run As Administrator, which would tell you if it's a security permissions thing. If it is, then you could fix that by granting User permissions to modify your album folders. Or by always running Album Art Downloader as Administrator, I suppose.
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-07-18 17:15:08
I am using the built-in Administrator account. I checked a few of the "folder.jpg" and they are not read-only. I even closed Foobar and retried. No go. As I said, if can do this in Windows Explorer, I don't see why the downloader can't do it? Error message: "Access to the path bla bla bla is denied"

I don't know then. If Explorer isn't giving you the "You'll need to provide administrator permission to delete this file / Continue" popup then it wouldn't be a UAC elevation problem. You've checked it isn't a read-only flag, so it isn't that. Any chance you are running Album Art Downloader as a different user than Explorer? Windows does funny things with admin accounts, so if you are running as admin then it's possible it still runs Album Art Downloader as User. You could try right clicking and Run As Administrator, which would tell you if it's a security permissions thing. If it is, then you could fix that by granting User permissions to modify your album folders. Or by always running Album Art Downloader as Administrator, I suppose.

[I am just curious sometimes when something on the surface does not make sense]
I am definitely running the downloader as admin. I also browsed to "AlbumArtDownloader" and found "AlbumArt.exe". Next, I accessed the Properties sheet for this. I ticked the "Privilege Level" to "Run this program as an administrator". I also tried a right-click "Run this program as "Administrator". No go. So, as I said before, on the surface it does not make sense.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-07-18 19:25:54
No go. So, as I said before, on the surface it does not make sense.
Then I'm afraid I'm out of ideas. Album Art Downloader is just reporting the error that the Windows API reports when it tries to delete that file. If Windows says No, then Album Art Downloader can only say No. With Access Denied there aren't any more details to be had, it's simply that the user account that Album Art Downloader is running under is not allowed to delete it.
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-07-19 03:39:49
Well, we are both missing something. What that might be, who knows...
Title: Album Art Downloader XUI
Post by: A_Man_Eating_Duck on 2015-07-19 04:52:33
Could WMP be locking the file?
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-07-19 15:58:54
Could WMP be locking the file?

I've tried this with WMP running and not. Or did you mean that WMP might be running in the background somehow?
Title: Album Art Downloader XUI
Post by: Forseti on 2015-07-22 10:32:33
(http://nova-rl.de/pic-upload/images/22.png)
does not work with Windows 10 Build 10240!
Title: Album Art Downloader XUI
Post by: fbuser on 2015-07-22 11:04:34
According to the error message you need to enable .NET in Windows 10, see also here (http://answers.microsoft.com/en-us/insider/forum/insider_wintp-insider_install/how-to-instal-net-framework-35-on-windows-10/450b3ba6-4d19-45ae-840e-78519f36d7a4?auth=1).
Title: Album Art Downloader XUI
Post by: Forseti on 2015-07-22 17:18:32
old .NET Version!  better to create a new version! 
Title: Album Art Downloader XUI
Post by: wardakhin on 2015-08-19 23:33:29
Hi all,
I can't run AAD on Win 10 Pro. It throws this error (http://pastebin.com/qgXkbCgn) when trying to start the program. All .NET version are installed.
Any ideas?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-08-20 08:02:27
Hi all,
I can't run AAD on Win 10 Pro. It throws this error (http://pastebin.com/qgXkbCgn) when trying to start the program. All .NET version are installed.
Any ideas?

Huh, no, I've not seen that before, and I have checked that it works on Windows 10, so long as .net 3.5 is installed. According to the error report, it is related to the culture and language settings - what language is your version of Windows 10? Have you set up any special language or culture related settings? Unfortunately it looks like it's happening within the .net system code, all I'm doing is requesting the default settings store, so I don't know whether it will be possible for me to fix, but I can investigate the language angle a bit further.

Alex
Title: Album Art Downloader XUI
Post by: marc2003 on 2015-08-20 09:39:42
i've not tested AAD recently but IIRC it has a last.fm artist download script included. this will no longer function as before because the html layout/URLs have changed since they've launched a new website.
Title: Album Art Downloader XUI
Post by: wardakhin on 2015-08-22 13:11:08
Hi all,
I can't run AAD on Win 10 Pro. It throws this error (http://pastebin.com/qgXkbCgn) when trying to start the program. All .NET version are installed.
Any ideas?

Huh, no, I've not seen that before, and I have checked that it works on Windows 10, so long as .net 3.5 is installed. According to the error report, it is related to the culture and language settings - what language is your version of Windows 10? Have you set up any special language or culture related settings? Unfortunately it looks like it's happening within the .net system code, all I'm doing is requesting the default settings store, so I don't know whether it will be possible for me to fix, but I can investigate the language angle a bit further.

Alex


Hi Alex,
Yeah, my regional and location settings was mismatched after upgrade from Win 8.1 to Win 10... I sorted that, and now everything works fine.
Thanks for you input. 
Title: Album Art Downloader XUI
Post by: lasereye70 on 2015-10-03 21:00:17
Quick question, how do I stop it from labeling everything starting with Folder, as in Folder - Front, Folder -  Back, I just want Front, back ect without the folder in front of it, I've gone into the settings and set my string up like this C:\Users\User\Pictures\Album Art\%artist%\%album%\%preset%.%extension% but when I go to download it reverts to the Folder - front, ect, call me picky but I just want front.jpg, back.jpg, ect labeling, it works easier with Foobar.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-10-04 09:39:42
I've gone into the settings and set my string up like this C:\Users\User\Pictures\Album Art\%artist%\%album%\%preset%.%extension% but when I go to download it reverts to the Folder - front, ect

Are you using the file browser? If so, then you have to change the setting there (under Specify path to find images) to be just %preset%.%extension%
Title: Album Art Downloader XUI
Post by: lasereye70 on 2015-10-05 00:29:45
I've gone into the settings and set my string up like this C:\Users\User\Pictures\Album Art\%artist%\%album%\%preset%.%extension% but when I go to download it reverts to the Folder - front, ect

Are you using the file browser? If so, then you have to change the setting there (under Specify path to find images) to be just %preset%.%extension%



I finally used that method and got it to name the way I wanted to
Title: Album Art Downloader XUI
Post by: pochaboo on 2015-11-12 08:33:02
Hello, Alex!
I edited your itunes.boo script a little.

Note:
* artworkUrl100's size-info often seems to be "100x100bb.jpg", not "100x100-75.jpg".
* We can often get full size image by appending "5000x5000-100.jpg" to imageUrlBase.
Code: [Select]
def Search(artist as string, album as string, results as IScriptResults):
artist = StripCharacters("&.'\";:?!", artist)
album = StripCharacters("&.'\";:?!", album)

searchResultsJson as string = GetPage("http://itunes.apple.com/search?entity=album&country=${CountryCode}&term=" + EncodeUrl("\"" + artist + "\" \"" + album + "\""))

json = JavaScriptSerializer()
searchResults = json.DeserializeObject(searchResultsJson) as Dictionary[of string, object]

results.EstimatedCount = searchResults["resultCount"]

for result as Dictionary[of string, object] in searchResults["results"]:
title = result["artistName"] + " - " + result["collectionName"]
url = result["collectionViewUrl"]
imageUrlBase = result["artworkUrl100"]
// Remove size from image to get base
#SizeMatch = Regex("^.+(?<size>\\d{2,4}x\\d{2,4}.+\\.jpg)$", RegexOptions.IgnoreCase).Match(imageUrlBase)
SizeMatch = Regex("^.+(?<size>100x100.+\\.jpg)$", RegexOptions.IgnoreCase).Match(imageUrlBase) //example: "100x100-75.jpg" or "100x100bb.jpg"
if (SizeMatch.Success):
imageUrlBase = imageUrlBase.Substring(0, imageUrlBase.Length - SizeMatch.Groups["size"].Value.Length)
else:
imageUrlBase = imageUrlBase.Substring(0, imageUrlBase.Length - "100x100-75.jpg".Length)

// See if full size jpg is available
if CheckResponse(imageUrlBase + "jpg"):
fullSizeImageUrl = imageUrlBase + "jpg"
extension = "jpg"
elif CheckResponse(imageUrlBase + "5000x5000-100.jpg"): //we can often get full size image!
fullSizeImageUrl = imageUrlBase + "5000x5000-100.jpg"
extension = "jpg"
elif CheckResponse(imageUrlBase + "5000x5000-75.jpg"):
fullSizeImageUrl = imageUrlBase + "5000x5000-75.jpg"
extension = "jpg"
elif CheckResponse(imageUrlBase + "tif"): // Couldn't find full size .jpg, try .tif
fullSizeImageUrl = imageUrlBase + "tif"
extension = "tiff"
elif CheckResponse(imageUrlBase + "1200x1200-75.jpg"): // Couldn't find full size .jpg or .tif, fall back on 1200x1200
fullSizeImageUrl = imageUrlBase + "1200x1200-75.jpg"
extension = "jpg"
else:
// Final fall back on 600x600
fullSizeImageUrl = imageUrlBase + "600x600-75.jpg"
extension = "jpg"

results.Add(imageUrlBase + "170x170-75.jpg", title, url, -1, -1, fullSizeImageUrl, CoverType.Front, extension);
There may be a mistake because I'm not a C#(and English, haha) expert.
Thank you for your great work!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-11-13 18:25:54
Hello, Alex!
I edited your itunes.boo script a little.

Thanks, looks good to me. Could you give me an example of a "100x100bb.jpg" style artwork I can use for testing? I thought it would make more sense to use the regex directly to get the url base, so ^(?<imageUrlBase>.+)100x100.+\.jpg making the capture the part we want to keep rather than the part to throw away. Also, can you tell me what the purpose of the other (commented) version with \d{2,4} instead of 100 ? Had you found any examples where the size wasn't 100?

Alex
Title: Album Art Downloader XUI
Post by: pochaboo on 2015-11-14 03:09:00
Thanks for your reply.
Could you give me an example of a "100x100bb.jpg" style artwork I can use for testing?

Yes, I can give you the following examples:
[artist]                [album]
Evanescence      Fallen
Adele                21
Michael Jackson  Thriller
Also, can you tell me what the purpose of the other (commented) version with \d{2,4} instead of 100 ? Had you found any examples where the size wasn't 100?

Sorry, I forgot to delete the comment. I have never found any cases where the size wasn't 100.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-11-14 09:08:22

OK, I'll ignore the possibility of not 100x100 then. I've uploaded the updated script now, thanks again.

Alex
Title: Album Art Downloader XUI
Post by: pochaboo on 2015-11-15 03:29:41
Thanks for updating the script! It works very well.
Also, thanks for a great application
Title: Album Art Downloader XUI
Post by: vmcosco on 2015-11-17 15:48:39
I have been using AAD for years without issue.  A couple of months ago, whenever I open the program, the window is completely transparent.  I have the title bar and window border but that is it.  I have uninstalled AAD and reinstalled without benefit.  Any idea what could be causing this?  I am running AAD on a headless Windows 7 x64 box that processes and houses all of my media.  Outside of standard windows updates, I have not made any changes to my system in quite some time.

Thanks for the help.
Title: Album Art Downloader XUI
Post by: minterbrad on 2015-11-17 17:14:45
When I find covers that have the same name, Album Art Downloader XUI asks me if I want to overwrite or rename the new cover and I have to answer all the times that I want to rename this does not overwrite the file present, and it's a break

Ah, OK, I understand now, you want an option to always overwrite, or to always save with another name, rather than asking for every file. Sorry, Album Art Downloader can't do that at present. I didn't think people would be overwriting existing files very often!

I'll consider adding a "Don't ask me again" checkbox to the Overwrite window for the next version. I don't really like the idea of overwriting files without warning, though, so I'd have to be careful about it. Perhaps it would only apply for the current session, and be forgotten next time you run AAD.


In saving subsequent images for the same album, is there a way to change the default renaming scheme from "Album.jpg, Album.jpg (2)..." to "Album.jpg(01), Album.jpg(02)..."?
This would solve sorting issues I am having in Windows and on HDI Dune player for sequential playback of an image slideshow.
I understand that there is a button option to rename manually, but that is tedious when saving as many unique images as possible for the same album.
I am using AAD within MP3Tag.
Great program!  Thanks!
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-11-17 20:08:37
A couple of months ago, whenever I open the program, the window is completely transparent.  I have the title bar and window border but that is it.  I have uninstalled AAD and reinstalled without benefit.  Any idea what could be causing this?
Not a clue, sorry. Never heard of that one before! You could try uninstalling and reinstalling the .NET Framework, that might help. Or even your graphics card drivers, that's been known to affect WPF.

In saving subsequent images for the same album, is there a way to change the default renaming scheme from "Album.jpg, Album.jpg (2)..." to "Album.jpg(01), Album.jpg(02)..."?

When the prompt appears offering you the choice to overwrite or to save with a new name, click the "Options..." link (just above the buttons) and you get a box where you can put in the scheme that you want to use. Yours would be %filename%.%extension%(%nn%)

It isn't possible to have it exactly as you describe because the first image saved won't have any numeric suffix to it. It's only when you try and overwrite an image that already exists that a suffix is added, so you would get "Album.jpg, Album.jpg(01), Album.jpg(02)...".

I should also point out that it's pretty weird to put the suffix after the extension. You can do it if you really want to, but I'd recommend %filename%(%nn%).%extension% instead.
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-12-03 18:28:00
Where is the latest download?
Title: Album Art Downloader XUI
Post by: marc2003 on 2015-12-03 21:08:30
I think you should consider reading the first post.
Title: Album Art Downloader XUI
Post by: TheEmpathicEar on 2015-12-04 00:01:13
I think you should consider reading the first post.

Oops! I was thinking this was part of Foobar. 
Title: Album Art Downloader XUI
Post by: beesmyer on 2015-12-05 14:22:39
I use my library in kodi as well. AS such I have the following structure...

music\artist\album\booklet
music\artist\extrafanart
music\artist\album

I have figured out how to get AAD to check for certain art like folder.jpg, fanart.jpg etc...
But I can't figure out how to get it to stop searching at certain folder levels or to leave certain folders out of the search.
For example... if I search for missing fanart.jpg in the artist folder it shows this missing in all folders like the albums, extrafanart, etc.. showing them as artists.
Is it possible to tell AAD to search in a certain folder level and return the result with an accurate listing of artist or albums?
I hope that makes sense.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-12-05 19:15:39
Is it possible to tell AAD to search in a certain folder level and return the result with an accurate listing of artist or albums?

I would suggest using file path pattern matching, and including the parent folder as part of the pattern. So, in your case, to find C:\music\artist\fanart.jpg but not C:\music\artist\album\fanart.jpg, use a path pattern of "\music\%artist%\." and a path to find images of "fanart.jpg" (or fanart.%extension% if you might have non .jpg art files).

Alex
Title: Album Art Downloader XUI
Post by: beesmyer on 2015-12-05 20:34:36
Is it possible to tell AAD to search in a certain folder level and return the result with an accurate listing of artist or albums?

I would suggest using file path pattern matching, and including the parent folder as part of the pattern. So, in your case, to find C:\music\artist\fanart.jpg but not C:\music\artist\album\fanart.jpg, use a path pattern of "\music\%artist%\." and a path to find images of "fanart.jpg" (or fanart.%extension% if you might have non .jpg art files).

Alex


That's it. Thank you for your time. Was so close. Was missing the "." at the end.
Title: Album Art Downloader XUI
Post by: NFS_FM on 2015-12-09 15:29:07
Hello, is it possible to update the beatport script to act like this: YouTube (https://www.youtube.com/watch?v=MYvzxS1v3Ws). Also, check that method for iTunes, maybe it's possible to gain something more.

PS: I have already asked for SoundCloud, maybe you have came up with something?
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-12-09 17:57:22
Hello, is it possible to update the beatport script to act like this: YouTube (https://www.youtube.com/watch?v=MYvzxS1v3Ws). Also, check that method for iTunes, maybe it's possible to gain something more.

PS: I have already asked for SoundCloud, maybe you have came up with something?

I have updated beatport.boo (http://album-art.sourceforge.net/scripts/beatport.boo), thanks. Sadly they are no longer offering their API without a key, so it has to use scraping now. It does try the +1 increment in id for a larger size, too.

As far as I know, nothing has changed with SoundCloud; there is still no useful search.

Alex
Title: Album Art Downloader XUI
Post by: pochaboo on 2015-12-12 10:20:16
Hello, Alex!
I created Gracenote script 
Code: [Select]
import System
import System.Xml
import System.Xml.Linq
import AlbumArtDownloader.Scripts
import util

class Gracenote(AlbumArtDownloader.Scripts.IScript):
Name as string:
get: return "Gracenote"
Version as string:
get: return "0.1"
Author as string:
get: return "VKP"

protected gnClientID as string:
get: return "XXXXXXX-XXXXXXXXXXXXXXXXXXX" //Please replace this with yours.
protected gnUserID as string:
get: return "XXXXXXXXXX-XXXXXXXXXXXXXXXXXXXXX" //Please replace this with yours.
protected gnUrl as string:
get: return "https://c" + gnClientID.Substring(0, 7) + ".web.cddbp.net/webapi/xml/1.0/"
protected coverSizeSearchPattern as string:
get: return "XLARGE,LARGE,MEDIUM,SMALL,THUMBNAIL"

def Search(artist as string, album as string, results as IScriptResults):
resXml = System.Xml.XmlDocument()

//Search Artist Image
reqXml = CreateSearchAlbumXml(artist, album, "SINGLE_BEST_COVER", "ARTIST_IMAGE")
try:
resXml.Load(GetResultXmlStream(reqXml))
imageUrlNode = resXml.SelectSingleNode("/RESPONSES/RESPONSE[@STATUS='OK']/ALBUM/URL[@TYPE='ARTIST_IMAGE']")
imageUrl = imageUrlNode.InnerText
albumArtistNode = resXml.SelectSingleNode("/RESPONSES/RESPONSE[@STATUS='OK']/ALBUM/ARTIST")
try:
width = System.Int32.Parse(imageUrlNode.Attributes["WIDTH"].Value)
height = System.Int32.Parse(imageUrlNode.Attributes["HEIGHT"].Value)
except e:
width = -1
height = -1

results.Add(imageUrl, albumArtistNode.InnerText, imageUrl, width, height, imageUrl)
results.EstimatedCount = 1
except e:
results.EstimatedCount = 0

//Search Cover Art
reqXml = CreateSearchAlbumXml(artist, album, "", "COVER")
try:
resXml.Load(GetResultXmlStream(reqXml))
albumNodes as System.Xml.XmlNodeList = resXml.SelectNodes("/RESPONSES/RESPONSE[@STATUS='OK']/ALBUM")
results.EstimatedCount += System.Int32.Parse(resXml.SelectSingleNode("/RESPONSES/RESPONSE[@STATUS='OK']/RANGE/END").InnerText)
except e:
return

for albumNode as System.Xml.XmlNode in albumNodes:
try:
gnID = albumNode["GN_ID"].InnerText
reqXml = CreateFetchAlbumXml(gnID, "SINGLE_BEST_COVER", "COVER")
resXml.Load(GetResultXmlStream(reqXml))

imageUrlNode = resXml.SelectSingleNode("/RESPONSES/RESPONSE[@STATUS='OK']/ALBUM/URL[@TYPE='COVERART']")
imageUrl = imageUrlNode.InnerText
albumArtistNode = resXml.SelectSingleNode("/RESPONSES/RESPONSE[@STATUS='OK']/ALBUM/ARTIST")
albumTitleNode = resXml.SelectSingleNode("/RESPONSES/RESPONSE[@STATUS='OK']/ALBUM/TITLE")
title = albumArtistNode.InnerText + " - " + albumTitleNode.InnerText
try:
width = System.Int32.Parse(imageUrlNode.Attributes["WIDTH"].Value)
height = System.Int32.Parse(imageUrlNode.Attributes["HEIGHT"].Value)
except e:
width = -1
height = -1

results.Add(imageUrl, title , imageUrl, width, height, imageUrl, CoverType.Front)

except e:
continue

def RetrieveFullSizeImage(fullSizeCallbackParameter):
return fullSizeCallbackParameter

def CreateSearchAlbumXml(artist as string, album as string, mode as string, coverType as string):
xml = System.Xml.Linq.XElement("QUERIES",
      System.Xml.Linq.XElement("AUTH",
            System.Xml.Linq.XElement("CLIENT", gnClientID),
            System.Xml.Linq.XElement("USER", gnUserID)
            ),
        System.Xml.Linq.XElement("QUERY", System.Xml.Linq.XAttribute("CMD", "ALBUM_SEARCH"),
                System.Xml.Linq.XElement("MODE", mode),
                System.Xml.Linq.XElement("TEXT", System.Xml.Linq.XAttribute("TYPE", "ARTIST"), artist),
                System.Xml.Linq.XElement("TEXT", System.Xml.Linq.XAttribute("TYPE", "ALBUM_TITLE"), album),
                System.Xml.Linq.XElement("OPTION",
                    System.Xml.Linq.XElement("PARAMETER", "SELECT_EXTENDED"),
                    System.Xml.Linq.XElement("VALUE", coverType)
                    ),
                System.Xml.Linq.XElement("OPTION",
                    System.Xml.Linq.XElement("PARAMETER", "COVER_SIZE"),
                    System.Xml.Linq.XElement("VALUE", coverSizeSearchPattern)
                    )
            )
        )
return xml

def CreateFetchAlbumXml(gnID as string, mode as string, coverType as string):
xml = System.Xml.Linq.XElement("QUERIES",
      System.Xml.Linq.XElement("AUTH",
            System.Xml.Linq.XElement("CLIENT", gnClientID),
            System.Xml.Linq.XElement("USER", gnUserID)
            ),
        System.Xml.Linq.XElement("QUERY", System.Xml.Linq.XAttribute("CMD", "ALBUM_FETCH"),
                System.Xml.Linq.XElement("MODE", mode),
                System.Xml.Linq.XElement("GN_ID", gnID),
                System.Xml.Linq.XElement("OPTION",
                    System.Xml.Linq.XElement("PARAMETER", "SELECT_EXTENDED"),
                    System.Xml.Linq.XElement("VALUE", coverType)
                    ),
                System.Xml.Linq.XElement("OPTION",
                    System.Xml.Linq.XElement("PARAMETER", "COVER_SIZE"),
                    System.Xml.Linq.XElement("VALUE", coverSizeSearchPattern)
                    )
            )
        )
return xml

def GetResultXmlStream(reqXml as System.Xml.Linq.XElement):
postData = Encoding.UTF8.GetBytes(reqXml.ToString());
req = System.Net.HttpWebRequest.Create(gnUrl);
req.Method = "POST";
req.ContentType = "text/xml; encoding='utf-8'";
req.ContentLength = postData.Length;

reqStream = req.GetRequestStream();
reqStream.Write(postData, 0, postData.Length);
reqStream.Close();

res = req.GetResponse();
resStream = res.GetResponseStream();
return resStream

Please replace gnClientID and gnUserID with yours.
Thanks
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-12-12 10:50:36
Hello, Alex!
I created Gracenote script 

Please replace gnClientID and gnUserID with yours.
Thanks

Thank you for your effort, that is good work. Unfortunately I cannot distribute scripts which require API keys to use, as API keys are fundamentally incompatible with open source client software. It is not possible to use such keys without disclosing them to anyone who inspects the source. As all APIs that require accounts also require you to keep the keys secret (otherwise why even bother with them, I suppose), they can therefore not be used.

If anyone wants to make a private copy of the script and apply for their own developer account at gracenote (https://developer.gracenote.com/user/register) then they are welcome to do so, but I cannot distribute a public version.

Alex
Title: Album Art Downloader XUI
Post by: pochaboo on 2015-12-13 03:24:12
If anyone wants to make a private copy of the script and apply for their own developer account at gracenote (https://developer.gracenote.com/user/register) then they are welcome to do so, but I cannot distribute a public version.
I see.
I'm happy if this script helps anyone 

BTW, I edited your lastfm-artist.boo script a little.
Code: [Select]
def Search(artist as string, album as string, results as IScriptResults):
artist = StripCharacters("&.'\";:?!", artist)

encodedArtist = EncodeUrl(artist)
imagesHtml = GetPage("http://www.last.fm/music/${encodedArtist}/+images")

imageIdMatches = Regex("<a\\s+href=\"/music/[^/]+/\\+images/(?<id>[^\"]+)\"[^<]+<img src=\"(?<imageUrlBase>[^\"]+?)(?<thumbnail>\\d+x\\d+)/").Matches(imagesHtml)

results.EstimatedCount = imageIdMatches.Count

for imageIdMatch as Match in imageIdMatches:
id = imageIdMatch.Groups["id"].Value
imageUrlBase = imageIdMatch.Groups["imageUrlBase"].Value
thumbnail = imageIdMatch.Groups["thumbnail"].Value
results.Add(imageUrlBase + thumbnail + "/" + id, artist, "http://www.last.fm/music/${encodedArtist}/+images/${id}", -1, -1, imageUrlBase + "ar0/" + id);
I tested it by some artists. it seems to work properly.
Title: Album Art Downloader XUI
Post by: AlexVallat on 2015-12-13 09:08:15
BTW, I edited your lastfm-artist.boo script a little.

Nice one. I've updated lastfm-artist.boo (http://album-art.sourceforge.net/scripts/lastfm-artist.boo) with your changes, thanks.

Alex
Title: Album Art Downloader XUI
Post by: beesmyer on 2015-12-25 22:38:15
Hello, Alex!
I created Gracenote script 

Please replace gnClientID and gnUserID with yours.
Thanks


Sorry but would someone mind helping me a little here.. I registered and received an API key. I also created an app for AAD and reeived a "clientID", "client tag", and an "Client ID for Web API, Rhythm API and eyeQ". I'm not sure what to put in the gracenote script. ANything I try is returning an error when I try to start AAD.
Title: Album Art Downloader XUI
Post by: pochaboo on 2015-12-28 08:33:25
Hello, beesmyer.
You need to get Gracenote UserID, too. Please refer to this page (https://developer.gracenote.com/web-api).
I'm not sure what to put in the gracenote script.

Please chack the script's line 16 and line 18.
Title: Album Art Downloader XUI
Post by: beesmyer on 2015-12-28 15:56:12
Hello, beesmyer.
You need to get Gracenote UserID, too. Please refer to this page (https://developer.gracenote.com/web-api).
I'm not sure what to put in the gracenote script.

Please chack the script's line 16 and line 18.



Sorry about this... at risk of having everyone on here laughing and never taking me seriously again...
I read that page already. I figured I was getting stumped on the part that explains I need to make a request to the given URL to receive a userid. I understand how to put the request together with my id, and i understand what url it needs to go to... the problem im having right now then is how do i send this query... to the following URL... with my own data ofcourse. Is there some software i'm missing? something in AAD? is doing this going to be beyond my recources seing as how i'm not a programmer?

<QUERIES>
  <QUERY CMD="REGISTER">
    <CLIENT>XXXXXXX-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX</CLIENT>
  </QUERY>
</QUERIES>

https://cXXXXXXX.web.cddbp.net/webapi/xml/1.0/ (https://cXXXXXXX.web.cddbp.net/webapi/xml/1.0/)
Title: Album Art Downloader XUI
Post by: beesmyer on 2015-12-28 17:06:14
Hello, beesmyer.
You need to get Gracenote UserID, too. Please refer to this page (https://developer.gracenote.com/web-api).
I'm not sure what to put in the gracenote script.

Please chack the script's line 16 and line 18.


Thank you very much for taking the time to respond. I think I just need this one dumbed down a little more.
Title: Album Art Downloader XUI
Post by: pochaboo on 2015-12-29 04:31:34
the problem im having right now then is how do i send this query... to the following URL... with my own data ofcourse.
It's difficult for me to explain the way in detail because I'm not good at English.
However, I'll do my best.

If you are using FireFox, I'll recommend HttpRequester Add-on.
Please push Submit or POST button after you set parameters such as the following screen.
(http://imgur.com/QRaTCH6.jpg)
You'll get the following result If successful.
(http://imgur.com/4lCGtXp.jpg)

I think I just need this one dumbed down a little more.
Example:
(when your ClientID is 1234567-12345678912345678912345678912345678912345
and UserID is 98765432198765432-98765432198765432198765432198765)
Code: [Select]
protected gnClientID as string:
get: return "1234567-12345678912345678912345678912345678912345" //Please replace this with yours.
protected gnUserID as string:
get: return "98765432198765432-98765432198765432198765432198765" //Please replace this with yours.
Title: Album Art Downloader XUI
Post by: beesmyer on 2015-12-29 07:00:27
Pochaboo,

I searched for hours for something to submit query online. That was exactly what I needed. I use firefox and this was easy. I think I'm up and running.

Thank you
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2016-01-15 02:12:45
Alex, it came to my attention that the fanart.tv script I wrote stopped working a little while back. I've rewritten part of it and updated it for everybody.
Title: Re: Album Art Downloader XUI
Post by: sym7 on 2016-01-24 20:41:38
Alex, it came to my attention that the fanart.tv script I wrote stopped working a little while back. I've rewritten part of it and updated it for everybody.
Yesssssssss, I was hoping it wasn't just on my end.
Title: Re: Album Art Downloader XUI
Post by: pochaboo on 2016-01-30 06:17:00
Hi, I edited several scripts.
I hope they work properly.
Thanks :)
Title: Re: Album Art Downloader XUI
Post by: thomian on 2016-01-30 18:08:06
Any chance to get a script for Spotify?
Title: Re: Album Art Downloader XUI
Post by: pochaboo on 2016-02-07 07:58:34
Sorry, the above lastfm-artist.boo doesn't appear to work.
I've updated it.
Title: Re: Album Art Downloader XUI
Post by: DarKHawK on 2016-05-03 02:54:41
GoogleImage Script does not seem to be working. v0.18.
Any updates?

Thank you.
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2016-05-08 07:01:27
I got tired of constantly getting the update message for the fanart script and since AlexVallet appears to be MIA (hope he's okay!) and updates probably aren't forthcoming, I decided to make a version with a different name so that you don't get annoyed anylonger.
Title: Re: Album Art Downloader XUI
Post by: Zal on 2016-05-13 02:24:39
Hi, I edited several scripts.
I hope they work properly.
Thanks :)

Thank you!!

Would you please be able to take a look at the Google Image search v.0.18?

In my experience this has always been the best one, now it doesn't seem to be working...

I may have just hit google's robot blocker, how do you reset that?
Title: Re: Album Art Downloader XUI
Post by: Zal on 2016-05-13 02:58:00
Is there maybe a way to make a Bing or Yahoo script to replace Google?
Seems reasonable. Please give bing.boo (http://album-art.sourceforge.net/scripts/bing.boo) a try and let me know how you get on with it.

Alex
I know this a post from years ago, can you please look into making this work again instead of google?
Title: Re: Album Art Downloader XUI
Post by: dutch109 on 2016-05-14 12:36:18
Would you please be able to take a look at the Google Image search v.0.18?

In my experience this has always been the best one, now it doesn't seem to be working...
@AlexVallat if that helps, I also had Google Images broken last month in my SACAD (https://github.com/desbma/sacad) project due to a Google change.
I fixed it with the following change : https://github.com/desbma/sacad/commit/36de51210a870237fecab6b5e0e3881155ed90d5 (full parsing code here (https://github.com/desbma/sacad/blob/master/sacad/sources/google_images.py))
Title: Re: Album Art Downloader XUI
Post by: pochaboo on 2016-05-15 03:40:29
Hi, I have updated GoogleImage script.
I hope it works properly.
Thanks  ;)
Title: Re: Album Art Downloader XUI
Post by: DarKHawK on 2016-05-19 06:22:12
Thank you. It works.
Title: Re: Album Art Downloader XUI
Post by: k76 on 2016-05-25 14:17:28
In a multi cd release, with folder structure like Album\CDnnn where nnn=001-200 etc, is there any way to update a cover automatically only for the Album folder, not for each individual \CDnnn ?

Automatically as in not manually de/selecting any folders from the missing cover list, or doing manual file copy work (like moving disk 1 image to Album\).
Title: Re: Album Art Downloader XUI
Post by: fabiospark on 2016-06-12 08:23:55
Hi,

I've just installed the software (W7 64) but when I launch it I get a window
telling me what follows:

Quote
Searching for scripts...
Found 1 files: [util.boo]...
Loading references: [System.Web]...
Compiling scripts...
util.boo(76,12): error BCE0005: Unknown identifier: 'Regex'.

What shoul I do?

I went to the first post but the link to the wiki seems not working and I've never used the app before.

I'm aiming to use AAD with Foobar2000 to download album arts (fancy that!).

Thanks.
Title: Re: Album Art Downloader XUI
Post by: iscabis on 2016-08-10 12:53:51
Hello,

I updated to the Anniversary Update for Windows 10 yesterday.  Prior to this, Album Art Downloader launched without issues.  Now I get the following error:

Quote
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\Iscabis\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.2.0, running on Microsoft Windows NT 6.2.9200.0 (64 bit)

System.IO.FileNotFoundException: Could not load file or assembly 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. The system cannot find the file specified.
File name: 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'
   at AlbumArtDownloader.InstanceMutex.QueryPriorInstance(String[] args, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].

I tried to reinstall, but this did not fix the problem.  I installed a fresh copy on a different computer that recently got updated to the Anniversary Update, and it launched properly and initialized scripts.  I have tried uninstalling on the problematic computer, running CCleaner to clean up any registry items left behind, reinstalled, and the same error occurs.  Some other program that always ran normally prompted to have .NET 3.5 components reinstalled before it allowed to launch after the update.  My guess is some underlying component the software relies on got messed up with the update.

If need be, I can use the software on the computer it works on now, but I would really like to know how to get it working on my main computer again.  Any assistance is greatly appreciated.  Let me know if you need anything else from me.  Thanks.
Title: Re: Album Art Downloader XUI
Post by: iscabis on 2016-08-11 00:19:04
I ended up fixing the issue by removing the .NET 3.5 option from "Turn Windows features on or off" to remove that version of .NET, followed by enabling that again.  That fixed the issue immediately for me.
Title: Re: Album Art Downloader XUI
Post by: Matt714 on 2016-09-18 04:37:39
Greetings,

Any way for the program to only search for folder.jpeg, instead of also seeking id3 embedded art?

Or I'l have to remove all embedded art wih mp3 tag?
Title: Re: Album Art Downloader XUI
Post by: triangle on 2017-01-18 12:09:14
I am using AAD as a tool with Mp3Tag.
The parameters for the search of the album are submitted to AAD from Mp3Tag.
OS: Windows 10

Something strange happens working this way.
After saving a cover it is necessary to close AAD. Otherwise the MP3-files in the albumfolder are locked and cannot be changed by MP3Tag. That's understandable and not so curious.
But even if I close AAD  and the albumfolder contains 11 or more files, the eleventh file keeps to be locked most of the time from seconds up to a minute. I can watch in the process viewer, that AAD needs up to a minute before the process is shut down.

This behaviour interrupts my workflow because immediately after the cover-search I start other actions within MP3Tag for the album-folder and these actions get interrupted because the eleventh file in the folder cannot be written to. So I have to wait some time and repeat the action.

Why does AAD not shut down immediately and keeps the eleventh file of the folder locked?
Title: Re: Album Art Downloader XUI
Post by: Kogami on 2017-01-25 18:13:04
I'm sure this has come up before, but feature request:

Support for AlbumArtExchange (AAX)

http://www.albumartexchange.com/

These guys have a somewhat small, but very high quality stock of album art.
Title: Re: Album Art Downloader XUI
Post by: marc2003 on 2017-01-25 19:31:37
I'm pretty sure they take active measures to prevent their images being scraped.
Title: Re: Album Art Downloader XUI
Post by: akhlan on 2017-01-29 15:04:07
Hi,

i would like register cover (only 500px by 500px) in tag (mp3, flac, dsf,..) and not in the folder. It's possible with this appli ?

Rgds
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2017-02-13 07:58:18
I just started up AAD and got an update notice for a Google image script. Is AlexVallet back?
Title: Re: Album Art Downloader XUI
Post by: spongmiester on 2017-03-14 22:01:53
Has this stopped working tried scraping for a cover and it came back with zero results
Title: Re: Album Art Downloader XUI
Post by: Stone Free on 2017-03-15 11:51:39
Nope, just tried it now and I'm getting results back as usual
Title: Re: Album Art Downloader XUI
Post by: mookieproof on 2017-03-18 23:17:25
Mine has also stopped working -- right after a Windows update. The update doesn't seem to have involved .NET or anything else obviously related, though. Tried a reinstall to no avail.
Title: Re: Album Art Downloader XUI
Post by: mookieproof on 2017-04-08 23:05:33
Turns out the issue was that the user.config file/folder in AppData had been somehow corrupted. After deleting that folder (which required Unlocker) and reinstalling, everything's okay. I dunno if this happening at the same time as a Windows update was a coincidence or not.
Title: Re: Album Art Downloader XUI
Post by: xbon on 2017-05-05 08:37:42
Hi guys, only recently starting using this program, it is brilliant, anyway got a issue probably easy to sort but at the moment i can`t work it out, is there anyway of adjusting the size of the thumbnails, i have a eye condition and some days they are too small for me to see and other days i would like them smaller in size.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-05-06 10:23:07
is there anyway of adjusting the size of the thumbnails
Yes, in the bottom right corner of the thumbnail there is a little triangular gripper. Drag that to make the thumbnail bigger or smaller.
Title: Re: Album Art Downloader XUI
Post by: xbon on 2017-05-06 10:49:53
is there anyway of adjusting the size of the thumbnails
Yes, in the bottom right corner of the thumbnail there is a little triangular gripper. Drag that to make the thumbnail bigger or smaller.

Thankyou, i couldnt see that at first, much appreciated.
Title: Re: Album Art Downloader XUI
Post by: arcticfox on 2017-05-09 21:32:10
I really like AAD. Before I knew it I searched every single cover manually... Can't imagine how unefficient it was haha
Keep the work going guys and many thanks! :)
Title: Re: Album Art Downloader XUI
Post by: Pumps on 2017-05-11 14:40:01
This is a great program for downloading album art!
I just want to know why the art does not save to the music file exactly but instead saves as a picture.
When I open iTunes none of the art is there since the art is not saved onto the file directly as a tag.
Let me know if there is a way. Thanks!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-05-12 07:34:13
I just want to know why the art does not save to the music file exactly but instead saves as a picture.
Ensuring that all the tracks in the album have the correct artwork embedded is a library management task, similar to setting the album and artist name tags for them all. Album Art Downloader is not a library management tool. It will find and download the artwork for the album, but if you want to work with tags, that's out of scope. iTunes is library managenent software and ought to be able to do that sort of job, but I don't use it so I can't say for sure. If it doesn't automatically recognize a .jpg album art though, that's a bit poor and not a good sign!
Title: Re: Album Art Downloader XUI
Post by: enibra on 2017-05-14 17:50:22
Hi!

Long time user, love the program! Really nifty tool! Thanks for sharing it with the world!

Since recently, i.e. since one of the last Windows 10 Updates, I have an issue: AAD (1.02) is not starting anymore. I just get the Windows box "...has stopped working".
Unfortunately, I don't know where I can find an error log or debug file or anything alike.

Recently, the user mookieproof reported a similar problem, I think. However, I can't make use of his solution below, since I can't identify the "user.config file/folder in AppData". (I know where AppData is and what it is, but I can't find any file or folder named user.config or anything related to AAD there.)

Turns out the issue was that the user.config file/folder in AppData had been somehow corrupted. After deleting that folder (which required Unlocker) and reinstalling, everything's okay. I dunno if this happening at the same time as a Windows update was a coincidence or not.

Any help appreciated! Thanks!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-05-15 08:50:15
I can't identify the "user.config file/folder in AppData". (I know where AppData is and what it is, but I can't find any file or folder named user.config or anything related to AAD there.)
There should be a %localappdata%\AlbumArtDownloader folder which you can delete. That will reset all AAD settings, and will be recreated when you next run AAD.
Title: Re: Album Art Downloader XUI
Post by: enibra on 2017-05-17 13:07:08
There should be a %localappdata%\AlbumArtDownloader folder which you can delete. That will reset all AAD settings, and will be recreated when you next run AAD.

Thanks for your fast response, appreciate it a lot! Love the tool!

Unfortunately, there is no such folder:

(http://i.imgur.com/tat8FnQ.png)

Any hint or tips?

Here also the content of my installation folder:

(http://i.imgur.com/pTexVRF.png)

Like I said: I have a feeling that this problem correlates with a recent Windows or NVidia Update. It used to work perfectly fine until a few weeks ago. Then I didn't use AAD for a while and now it's not working anymore. Already tried reinstalling.
I'd love to look into an error log or anything, but I'm not sure if Windows stores something like that automatically for a program that gets "has stopped working". And if Windows does, I couldn't find out where, yet.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-05-18 08:03:40
AlbumArtDownloader will create an error log if it can, as errorlog.txt in the program folder, or %temp%\AAD_errorlog.txt if that fails. It looks to me like it's not even able to do that, that something is preventing it from running at all. Windows will log errors in the "Event Viewer" (look under Custom Views/Administritive Events for any error with the source ".NET Runtime"). It's unlikely that this information will prove helpful, though.

Uninstalling and re-installing the .net framework has been known to resolve this sort of issue in the past, but I'm not sure if that's possible under Windows 10.
Title: Re: Album Art Downloader XUI
Post by: enibra on 2017-05-19 15:17:20
AlbumArtDownloader will create an error log if it can, as errorlog.txt in the program folder, or %temp%\AAD_errorlog.txt if that fails. It looks to me like it's not even able to do that, that something is preventing it from running at all. Windows will log errors in the "Event Viewer" (look under Custom Views/Administritive Events for any error with the source ".NET Runtime"). It's unlikely that this information will prove helpful, though.

Uninstalling and re-installing the .net framework has been known to resolve this sort of issue in the past, but I'm not sure if that's possible under Windows 10.

You are right: there is no errorlog in the program folder, as can be seen in my screenshot. There is one errorlog.txt file in %temp%, but that one is a little older. And no new one is created whenever it stops working during start-up.
However, each start-up abort can be seen in the Windows Event Viewer. (Thanks for that hint!) The information there is indeed quite unhelpful, at least to me. Might you be able to identify a better root cause if I provide you that event viewer error? If you are willing to take a look, obviously!

And about the .NET framework: This sucks... Apparently, the .NET Framework 4.7 is part of the recent Windows 10 Creators Update, hence it cannot be uninstalled and reinstalled.
I tried to "repair" the probably broken .NET Framework installation by deactivating the .NET features, restarting, activating and updating again. But that didn't solve the AAD start-up issue.

No idea what else I could try to get AAD working again. I can only hope that the next .NET framework update comes soon and fixes the problem, I guess.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-05-20 08:53:50
Might you be able to identify a better root cause if I provide you that event viewer error? If you are willing to take a look, obviously!
Sure, I can take a look, no problem, but as I said before it's unlikely to provide an answer.
Title: Re: Album Art Downloader XUI
Post by: Pearate on 2017-06-30 12:20:19
Hey,  Album Art is great !
I have just a problem : I updated the scripts today, and they have all disappear.
The only one left is the "local files" script.
I can make an update in the option, and the result is always the same. No new script, just the "local files" left
Any clue ?
Thx
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-07-01 08:32:39
I updated the scripts today, and they have all disappear.
Weird, I've never heard of that before. Did it actually delete the script files, or they just don't show in the list when you run it? You can download any of them manually from http://album-art.sourceforge.net/Updates.xml if you need to.
Title: Re: Album Art Downloader XUI
Post by: enibra on 2017-07-27 17:04:46
Sure, I can take a look, no problem, but as I said before it's unlikely to provide an answer.

Hi again. So, I decided to not bother you with that log cause it really looked unpromising and since you already said yourself that it won't probably help much, I just lived without AAD for a while.

But searching on google for squared images is absolutely not yielding the same results as AAD did! I miss that little piece of software! :)

Meanwhile, I also installed AAD on my laptop, which is also running x64 Win10. There, AAD is running fine...

I really want to figure out why it's not running on my desktop anymore though. Do you have any idea why the log file is not written at all to the temp folder, even when I start AAD with administrator rights?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-07-27 22:04:19
Do you have any idea why the log file is not written at all to the temp folder, even when I start AAD with administrator rights?
The log is not written because AAD cannot start at all, there must be something seriously wrong with the .net framework on that pc. I'm afraid I don't have any better guesses for you since my original reply, sorry.
Title: Re: Album Art Downloader XUI
Post by: enibra on 2017-07-27 22:55:16
Hm, thanks for your feedback.

It's really stupid how the Windows Creators Update and .NET 4.7 are intervened such that it seems impossible to reinstall. I can pretty much chose between reinstalling Windows alltogether or waiting for the next .NET release. :(

I'll use AAD on my laptop then. It's just too good. :)
Title: Re: Album Art Downloader XUI
Post by: Zarggg on 2017-08-03 21:03:59
AlbumArtDownloader will create an error log if it can, as errorlog.txt in the program folder, or %temp%\AAD_errorlog.txt if that fails. It looks to me like it's not even able to do that, that something is preventing it from running at all. Windows will log errors in the "Event Viewer" (look under Custom Views/Administritive Events for any error with the source ".NET Runtime"). It's unlikely that this information will prove helpful, though.
The Application event I get seems to point not to .NET, but to DirectX:
Quote
Faulting application name: AlbumArt.exe, version: 1.0.2.0, time stamp: 0x54b25d03
Faulting module name: d3d9.dll, version: 6.2.15063.0, time stamp: 0x631de416
Exception code: 0xc0000005
Fault offset: 0x000000000000fd0c
Faulting process id: 0x%9
Faulting application start time: 0x%10
Faulting application path: %11
Faulting module path: %12
Report Id: %13
Faulting package full name: %14
Faulting package-relative application ID: %15
Title: Re: Album Art Downloader XUI
Post by: Zarggg on 2017-08-04 04:45:28
Clicking the Debug option on the crash window results in another application crash, with the following two events logged:
Quote
Fault bucket , type 0
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: AlbumArt.exe
P2: 1.0.2.0
P3: 54b25d03
P4: d3d9.dll
P5: 6.2.15063.0
P6: 631de416
P7: c0000005
P8: 000000000000fd0c
P9:
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERA43A.tmp.mdmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERA6EA.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERA6FF.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERA71F.tmp.txt

These files may be available here:


Analysis symbol:
Rechecking for solution: 0
Report Id: 4ac8ad92-dbe8-4820-8f25-618690c6d95e
Report Status: 134217728
Hashed bucket:
Quote
Faulting application name: AlbumArt.exe, version: 1.0.2.0, time stamp: 0x54b25d03
Faulting module name: d3d9.dll, version: 10.0.15063.0, time stamp: 0x631de416
Exception code: 0xc0000005
Fault offset: 0x000000000000fd0c
Faulting process id: 0x26dc
Faulting application start time: 0x01d30cd3ed83cd82
Faulting application path: C:\Program Files\AlbumArtDownloader\AlbumArt.exe
Faulting module path: C:\WINDOWS\SYSTEM32\d3d9.dll
Report Id: 2d6d8e9e-1fac-47a2-9b99-ad4461c56554
Faulting package full name:
Faulting package-relative application ID:
Not sure if any of this would be helpful for you.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-08-04 08:42:46
Yes, that is helpful. The fault is related to graphics (d3d9.dll) which usually means the graphics driver needs to be updated. However, I have recently had reported that a crash like this will occur on Windows 10 Creator's Edition if Riva Tuner Statistics Server is running. Could you check if you are running that application, or anything similar?
Title: Re: Album Art Downloader XUI
Post by: Zarggg on 2017-08-04 16:41:51
Yes, I do run that application (it's part of MSI Afterburner, which I use to manage my GPU's fan speed). I must have missed that post. AAD launches fine for me when I close it.
Title: Re: Album Art Downloader XUI
Post by: Mcelfresh on 2017-08-05 08:46:30
Yes, that is helpful. The fault is related to graphics (d3d9.dll) which usually means the graphics driver needs to be updated. However, I have recently had reported that a crash like this will occur on Windows 10 Creator's Edition if Riva Tuner Statistics Server is running. Could you check if you are running that application, or anything similar?

I've been getting a few crashes on Win 10 creators edition too. It never happened before.
Title: Re: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2017-08-14 00:49:44
Am I the only one having problems on discogs? Mine AAD doesn't find any cover art on discogs. Coult it be that the script is broken?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-08-14 19:11:56
Am I the only one having problems on discogs? Mine AAD doesn't find any cover art on discogs. Coult it be that the script is broken?
Yep, discogs was broken. I've fixed it now, thanks for letting me know: discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo)
Title: Re: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2017-08-14 23:06:39
Thank you really much for fixing!!!  :)
Title: Re: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2017-08-15 21:25:08
Sorry for bothering you again, but discogs has given up again. Maybe they have too much traffic from Album Art Downloader, or have they simply changed something in their code?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-08-16 18:05:10
Yeah, they had changed their json format, then after I updated the script, they changed it back again. Weird. Anyway, I've uploaded a script that should handle both forms now. Hopefully that should stop it breaking for a while.
Title: Re: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2017-08-16 19:15:06
As always, thank you once again!
Title: Re: Album Art Downloader XUI
Post by: Wallinder on 2017-08-19 09:34:22
I've grown really fond of this wonderful application.  :-*

However, I recently did a reinstall of Windows 10 (Creators Update) and cannot start Album Art Downloader. I found this thread and I do not have Riva Tuner installed. I've installed "dotnetfx35setup.exe". Please help me.

This is what I get in the Event Viewer.

Quote
Fault bucket 129536940031, type 5
Event Name: CLR20r3
Response: Not available
Cab Id: 0

Problem signature:
P1: albumart.exe
P2: 1.0.2.0
P3: 54b25d03
P4: mscorlib
P5: 2.0.0.0
P6: 594980a6
P7: 281f
P8: 41
P9: System.ArgumentException
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER5281.tmp.mdmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER53CA.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER53D8.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER53E9.tmp.txt

These files may be available here:
C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_albumart.exe_c596f3dcfc4bc814ba2588ffe8d8ad6cb760_00000000_11ae5a70

Analysis symbol:
Rechecking for solution: 0
Report ID: ac2dab93-c03d-40e1-a0cb-2c0cee9db4d7
Report Status: 268435456
Hashed bucket: 50c63deff49df174fc2a1819ee5db14b
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-08-19 09:47:17
I've grown really fond of this wonderful application.  :-*

However, I recently did a reinstall of Windows 10 (Creators Update) and cannot start Album Art Downloader. I found this thread and I do not have Riva Tuner installed. I've installed "dotnetfx35setup.exe". Please help me.
Did AlbumArtDownloader produce an errorlog.txt in the program folder, or in %temp%\AAD_errorlog.txt ?
Title: Re: Album Art Downloader XUI
Post by: Wallinder on 2017-08-19 09:55:35
I've grown really fond of this wonderful application.  :-*

However, I recently did a reinstall of Windows 10 (Creators Update) and cannot start Album Art Downloader. I found this thread and I do not have Riva Tuner installed. I've installed "dotnetfx35setup.exe". Please help me.
Did AlbumArtDownloader produce an errorlog.txt in the program folder, or in %temp%\AAD_errorlog.txt ?

No, I'm afraid there's no errorlog in the program folder or in %temp%.

If I delete %appdata%\Local\AlbumArtDownloader I see the splash screen going through the scripts, shortly after it crashes.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-08-19 11:04:25
No, I'm afraid there's no errorlog in the program folder or in %temp%.

If I delete %appdata%\Local\AlbumArtDownloader I see the splash screen going through the scripts, shortly after it crashes.
Strange, if it's capable of showing the splash screen and compiling scripts it certainly ought to be able to write the error log. You could try removing all but one script, just in case there is something there it doesn't like. Delete all the files in script except for util.boo and discogs.boo (for example) and see if it still crashes after compilation.
Title: Re: Album Art Downloader XUI
Post by: Wallinder on 2017-08-19 11:30:00
No, I'm afraid there's no errorlog in the program folder or in %temp%.

If I delete %appdata%\Local\AlbumArtDownloader I see the splash screen going through the scripts, shortly after it crashes.
Strange, if it's capable of showing the splash screen and compiling scripts it certainly ought to be able to write the error log. You could try removing all but one script, just in case there is something there it doesn't like. Delete all the files in script except for util.boo and discogs.boo (for example) and see if it still crashes after compilation.

Removed every script except util.boo and discogs.boo. Now I get an errorlog (attached).

Edit: Has it got to do with language in Windows? I'm using English (en-SE).
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-08-19 11:43:31
Something weird going on. It appears that your windows language/culture settings are set to a non-existent language (0x2000). Could you check in the "Clock, Language and Region" control panel setting that there is a sensible Language and Region set?
Title: Re: Album Art Downloader XUI
Post by: Wallinder on 2017-08-19 12:55:17
Something weird going on. It appears that your windows language/culture settings are set to a non-existent language (0x2000). Could you check in the "Clock, Language and Region" control panel setting that there is a sensible Language and Region set?

Language is set to English (en-SE) and region is set to Sweden.

Edit: I tried to install English (United States), but I still get the same error.

Thanks for taking the time to help me!
Title: Re: Album Art Downloader XUI
Post by: Wallinder on 2017-08-19 14:02:06
I got it working!  :) I installed English (United States) (again) and restarted Windows.
Thanks for your help @AlexVallat
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-08-19 16:29:35
I got it working!  :) I installed English (United States) (again) and restarted Windows.
Thanks for your help @AlexVallat
That's great news, thanks for letting me know!
Title: Re: Album Art Downloader XUI
Post by: jaredh on 2017-09-03 06:01:15
Nevermind. 

I got this tool and Album Cover Art Downloader mixed up.  

It's exactly what everyone who wants to embed wants.  If you want to directly embed without 2 steps, go to this tool and skip this one here.
Title: Re: Album Art Downloader XUI
Post by: enibra on 2017-09-04 15:01:48
Yes, that is helpful. The fault is related to graphics (d3d9.dll) which usually means the graphics driver needs to be updated. However, I have recently had reported that a crash like this will occur on Windows 10 Creator's Edition if Riva Tuner Statistics Server is running. Could you check if you are running that application, or anything similar?

Yes, I do run that application (it's part of MSI Afterburner, which I use to manage my GPU's fan speed). I must have missed that post. AAD launches fine for me when I close it.

Oh, wow! That might also be my exact problem.

I am also running MSI Afterburner with Riva Tuner Statistics Server. But it should be running on laptop as well as Desktop, and both run Win10 CU, where AAD runs fine on the Laptop but crashes 100% at start-up on the Desktop. That's somewhat surprising to me. I'll try turning of RTSS next time I use my Desktop.
Title: Re: Album Art Downloader XUI
Post by: BoltThrower on 2017-09-06 16:13:35
I registered to say that the fanart.tv script is again broken and I'd very much appreciate a look at it since it's one of the better ones in the bundle.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-09-07 08:16:12
I registered to say that the fanart.tv script is again broken and I'd very much appreciate a look at it since it's one of the better ones in the bundle.
@MordredKLB Any chance your fanart.tv script can be fixed? There seems to be problems accessing the fanart.tv API.
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2017-09-13 03:25:08
I registered to say that the fanart.tv script is again broken and I'd very much appreciate a look at it since it's one of the better ones in the bundle.
Were you using the version I posted here: https://hydrogenaud.io/index.php/topic,57392.msg914440.html#msg914440 (or the other one I posted a few messages below that)?

It's still working just fine for me as of today. I just re-sent @AlexVallat that version so he can post it on the official repo, but if you guys are having trouble with it, please let me know. (fanart.tv's API seems a little slow to respond today but that usually fixes itself in a day or two).
Title: Re: Album Art Downloader XUI
Post by: GnQm2 on 2017-09-17 22:17:11
Is Discogs script broken for anyone else? It stopped working for me around a week ago. Thank you for this wonderful tool.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-09-18 17:59:06
Is Discogs script broken for anyone else? It stopped working for me around a week ago. Thank you for this wonderful tool.
Thanks for letting me know, I've updated discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) and it should be working again now.
Title: Re: Album Art Downloader XUI
Post by: GnQm2 on 2017-09-19 10:44:18
Working great again, thanks!

edit: Maybe something is still little fishy? I tried using file browser and it got two result straight away from Discogs, but didn't find anything on next 20 or so. Tags should be right because I've tagged these from Discogs originally.

edit2: Installed it again and same happened. Two results then blanks.
Title: Re: Album Art Downloader XUI
Post by: BoltThrower on 2017-09-20 03:25:11
I registered to say that the fanart.tv script is again broken and I'd very much appreciate a look at it since it's one of the better ones in the bundle.
Were you using the version I posted here: https://hydrogenaud.io/index.php/topic,57392.msg914440.html#msg914440 (or the other one I posted a few messages below that)?

It's still working just fine for me as of today. I just re-sent @AlexVallat that version so he can post it on the official repo, but if you guys are having trouble with it, please let me know. (fanart.tv's API seems a little slow to respond today but that usually fixes itself in a day or two).
yes, I have been. I just tried both of them and can see nothing from Fanart, even though I double checked that they have the cover I need.
Title: Re: Album Art Downloader XUI
Post by: mobyduck on 2017-09-25 21:15:13
I have a PC running Windows 10 Pro 64bits with .NET Framework v4.7: do I have to install v3.5 or is Album Art Downloader installer supposed to work with the latest Framework?

I tried and it doesn't work, but I thought I'd ask before installing another .NET version.

Thanks.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-09-26 08:20:51
I have a PC running Windows 10 Pro 64bits with .NET Framework v4.7: do I have to install v3.5 or is Album Art Downloader installer supposed to work with the latest Framework?
Sorry, it does require v3.5 to be installed too.
Title: Re: Album Art Downloader XUI
Post by: xbon on 2017-09-29 07:51:39
Any chance of a ebay script for this?, i often find art on ebay
Title: Re: Album Art Downloader XUI
Post by: pianoinbush on 2017-11-26 12:54:02
Hey. Thanks again for continuing existence of this wonderful app.

Wanted to ask if there's any way to have an extra Qobuz script for UK releases or maybe include them in the existing one? There's lots of stuff on there that doesn't show in search results.

Thanks in advance.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-11-28 08:15:59
There's lots of stuff on there that doesn't show in search results.
Can you give me an example of a search with results which do not get shown? It seems to be working fine for me...
Title: Re: Album Art Downloader XUI
Post by: pianoinbush on 2017-11-30 11:10:16
There's lots of stuff on there that doesn't show in search results.
Can you give me an example of a search with results which do not get shown? It seems to be working fine for me...

For example, this page exists on qobuz, but the program doesn't show the artwork when searched.
http://www.qobuz.com/gb-en/album/fields-of-gold-official-bbc-children-in-need-single-2017-katie-melua/4050538346510
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-11-30 11:33:38
OK, Qobuz has several localised sites you can choose from. The default is French (fr-fr), but they have other choices including UK. I don't want to provide separate scripts for each one, but I have updated the qobuz.boo (http://album-art.sourceforge.net/scripts/qobuz.boo) script so that it's easy to customize. Just change the Locale="fr-fr" line near the top to be Locale="gb-en" if you prefer to use the UK localised site.
Title: Re: Album Art Downloader XUI
Post by: pianoinbush on 2017-11-30 14:11:57
OK, Qobuz has several localised sites you can choose from. The default is French (fr-fr), but they have other choices including UK. I don't want to provide separate scripts for each one, but I have updated the qobuz.boo (http://album-art.sourceforge.net/scripts/qobuz.boo) script so that it's easy to customize. Just change the Locale="fr-fr" line near the top to be Locale="gb-en" if you prefer to use the UK localised site.

Thanks! However... I don't know if I'm doing it wrong, but when I change the line to have "gb-en" instead of "fr-fr", nothing changes. the name of the script in the list stays the same (and I assume it should change), and the search results are still the same. tried with the same image search that I provided the example of and others.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-12-01 09:05:11
when I change the line to have "gb-en" instead of "fr-fr", nothing changes.
Strange - when you restarted Album Art Downloader, did it show the "Compiling Scripts" progress at the splash screen? You are right, the name of the script in the list should change to show the current locale in it.
Title: Re: Album Art Downloader XUI
Post by: pianoinbush on 2017-12-01 16:47:31
when I change the line to have "gb-en" instead of "fr-fr", nothing changes.
Strange - when you restarted Album Art Downloader, did it show the "Compiling Scripts" progress at the splash screen? You are right, the name of the script in the list should change to show the current locale in it.
Yeah, that was on me. I didn't realize new scripts are saved into AppData folder instead of Scripts folder.
Thank you very much!
Title: Re: Album Art Downloader XUI
Post by: dpr on 2017-12-28 20:58:21
Can I configure AAD to autosave artwork - and use the Presets without having to click on Save As?
Thanks
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-12-29 08:19:26
Can I configure AAD to autosave artwork - and use the Presets without having to click on Save As?
Sorry, I'm don't quite understand what you are asking. If you use Save As then you can give it whatever name you like. If you use Presets, then you don't use Save As, instead you pick the preset you want from the pop-up menu (just below Save As).

The only thing I can think of that might be "autosave" is from the file browser, you can have it automatically download the first result rather than showing the search window. In that case the default (first) preset value will be used - the same as if you had just clicked the Save button.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2017-12-29 16:42:59
Can I configure AAD to autosave artwork - and use the Presets without having to click on Save As?
Sorry, I'm don't quite understand what you are asking. If you use Save As then you can give it whatever name you like. If you use Presets, then you don't use Save As, instead you pick the preset you want from the pop-up menu (just below Save As).

The only thing I can think of that might be "autosave" is from the file browser, you can have it automatically download the first result rather than showing the search window. In that case the default (first) preset value will be used - the same as if you had just clicked the Save button.

Hello Alex, thanks for the prompt response and for the program.

To me, autosave, would save the images automatically and use the presets to save them as different files.  I got good matches with Musicbrainz yesterday. Only two sets of images appeared in the search results.  If I had worked at the serarch criteria, I might have to down to one set. The differences appeared to be different colour cds....

I would also like to save different size images into different sub-folders: one for small embedded (200x200) say, one for tablets and one for a big display.

By the way, on the latest version, the Default Preset is empty. I had to fill in it

Dpr
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-12-29 17:00:15
You can include the image size in the path (or filename) using the %size% placeholder, but there isn't any automatic categorization into small / medium / big. I would suggest the best workflow would be to use AAD to download the full size image that you want, and then some other library management software to produce resized versions at whatever sizes you need for different purposes.

The Default preset is empty deliberately, so that a %preset% placeholder can be included without it affecting the filename unless a preset is actually chosen. So if you just hit Save, you get "Folder.jpg", but if you choose the "CD" preset you get "Folder-CD.jpg". Presets are a flexible system, though, so how you use it depends on your own workflow.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2017-12-29 17:07:27
Thanks Alex, from an earlier post, I understood that the default preset was going to be be filled in.

Any thoughts on the autosave?

dpr
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-12-29 17:22:06
Any thoughts on the autosave?
If you are using the file or foobar browser, there's an option you can select to automatically download the first result for each selected album, rather than showing search windows. From the search window itself, no, there's nothing more 'auto' than clicking the save button, even if only one result comes back.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2017-12-29 17:30:46
Thanks,. I understand about auto-download. Auto Save is different. I want to refresh artwork for over 400 cds automatically in a larger size. Manually clicking save for each type of image (3 or 4) is not very attractive...
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-12-29 19:00:10
Seems to me that the file browser and auto-download is the right tool for refreshing artwork for 400 cds. Set it up with the right constraints on size and type, the right path/filename info and set it to auto-download. Then select all the albums, press the button and hope for the best! You would have to do this 3 or 4 times, though, one for each type of image, as it will generally only download one image per album. You would also need a source which accurately reports the type of image (front/back/cd/etc.) as otherwise there would be no way to filter based type and you couldn't download, for example, specifically back covers.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2017-12-29 23:29:12
How do I save the auto-downloaded files?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2017-12-30 08:07:25
How do I save the auto-downloaded files?
Downloaded is saved. They will be saved according to the "Specify path to find images" box in the Options for the browser. By default, this will save them as Folder.jpg, but you can change that to whatever you want. The path is relative to the path of the album the art is for.
Title: Re: Album Art Downloader XUI
Post by: mamyllyn on 2018-01-01 14:24:51
Hi,

I have one question that  I can not figure out:
How can I add a setting so that the album art will be downloaded straight to the folder that is missing the album art? Now it downloads it to my music folder and not to the specify folder like: Anthrax/Stomp folder.
Title: Re: Album Art Downloader XUI
Post by: mamyllyn on 2018-01-01 16:18:57
Hello,

Here is the answer to my own question:
Uninstall all and do it again.

Now all the covers are saved to the directory where they are missing from!

Hi,

I have one question that  I can not figure out:
How can I add a setting so that the album art will be downloaded straight to the folder that is missing the album art? Now it downloads it to my music folder and not to the specify folder like: Anthrax/Stomp folder.
Title: Re: Album Art Downloader XUI
Post by: mm511 on 2018-01-13 00:23:35
Been using Album Art Downloader for a while on my Windows 10 machine.

Suddenly it will not load. Spits out the following error code, something about fonts. I did install a new font recently, but can that really break a program this thoroughly? Help!

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\mm511\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.2.0, running on Microsoft Windows NT 6.2.9200.0 (64 bit)

System.TypeInitializationException: The type initializer for 'System.Windows.Media.FontFamily' threw an exception. ---> System.IO.IOException: More data is available.

   at Microsoft.Win32.RegistryKey.Win32Error(Int32 errorCode, String str)
   at Microsoft.Win32.RegistryKey.GetValueNames()
   at MS.Internal.FontCache.FontSourceCollection.SetFontSources()
   at MS.Internal.FontCache.FontSourceCollection.GetEnumerator()
   at MS.Internal.FontCache.FamilyCollection.BuildFamilyList(List`1& familyList, SortedDictionary`2& familyNameList, SortedList`2& frequentStrings)
   at MS.Internal.FontCache.FamilyCollection.MS.Internal.FontCache.IFontCacheElement.AddToCache(CheckedPointer newPointer, ElementCacher cacher)
   at MS.Internal.FontCache.HashTable.Lookup(IFontCacheElement e, Boolean add)
   at MS.Internal.FontCache.CacheManager.Lookup(IFontCacheElement e)
   at System.Windows.Media.FontFamily..cctor()
   --- End of inner exception stack trace ---
   at System.Windows.Media.Typeface..ctor(FontFamily fontFamily, FontStyle style, FontWeight weight, FontStretch stretch)
   at MS.Internal.Text.DynamicPropertyReader.GetTypeface(DependencyObject element)
   at MS.Internal.Text.TextProperties.InitCommon(DependencyObject target)
   at MS.Internal.Text.TextProperties..ctor(FrameworkElement target, Boolean isTypographyDefaultValue)
   at System.Windows.Controls.TextBlock.GetLineProperties()
   at System.Windows.Controls.TextBlock.EnsureTextBlockCache()
   at System.Windows.Controls.TextBlock.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.Controls.Control.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.Controls.Grid.MeasureCell(Int32 cell, Boolean forceInfinityV)
   at System.Windows.Controls.Grid.MeasureCellsGroup(Int32 cellsHead, Size referenceSize, Boolean ignoreDesiredSizeU, Boolean forceInfinityV)
   at System.Windows.Controls.Grid.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.Controls.Border.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at MS.Internal.Helper.MeasureElementWithSingleChild(UIElement element, Size constraint)
   at System.Windows.Controls.ContentPresenter.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.Controls.Decorator.MeasureOverride(Size constraint)
   at System.Windows.Documents.AdornerDecorator.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.Controls.Border.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.Window.MeasureOverrideHelper(Size constraint)
   at System.Windows.Window.MeasureOverride(Size availableSize)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.Interop.HwndSource.SetLayoutSize()
   at System.Windows.Interop.HwndSource.set_RootVisualInternal(Visual value)
   at System.Windows.Window.SetRootVisual()
   at System.Windows.Window.SetupInitialState(Double requestedTop, Double requestedLeft, Double requestedWidth, Double requestedHeight)
   at System.Windows.Window.CreateSourceWindowImpl()
   at System.Windows.Window.ShowHelper(Object booleanBox)
   at System.Windows.Window.Show()
   at System.Windows.Window.ShowDialog()
   at AlbumArtDownloader.Splashscreen.ShowIfRequired()
   at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   at System.Windows.Application.<.ctor>b__0(Object unused)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-01-13 10:24:49
Been using Album Art Downloader for a while on my Windows 10 machine.

Suddenly it will not load. Spits out the following error code, something about fonts. I did install a new font recently, but can that really break a program this thoroughly? Help!
Yes, unfortunately fonts can break all WPF programs, for example: http://faithlife.codes/blog/2009/11/how_to_crash_every_wpf_application/

You could try removing and re-registering the font, it might help.
Title: Re: Album Art Downloader XUI
Post by: JWiels on 2018-01-18 02:41:19
Getting repeated crash when trying to update/change presets:
Error log:
? is there a fix?

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Users\johnw\AppData\Local\Temp\AAD_errorlog.txt

App version: 1.0.2.0, running on Microsoft Windows NT 6.2.9200.0 (64 bit)

System.ArgumentNullException: Value cannot be null.
Parameter name: element
   at System.Windows.Media.VisualTreeHelper.GetChildrenCount(DependencyObject reference)
   at AlbumArtDownloader.Common.FindVisualChild[TChild](DependencyObject obj)
   at AlbumArtDownloader.EditPresets.OnNewItemContainerGenerated(Object sender, EventArgs e)
   at System.EventHandler.Invoke(Object sender, EventArgs e)
   at System.Windows.Controls.ItemContainerGenerator.SetStatus(GeneratorStatus value)
   at System.Windows.Controls.ItemContainerGenerator.Generator.System.IDisposable.Dispose()
   at System.Windows.Controls.VirtualizingStackPanel.MeasureOverride(Size constraint)
   at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
   at System.Windows.UIElement.Measure(Size availableSize)
   at System.Windows.ContextLayoutManager.UpdateLayout()
   at System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
   at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
   at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
   at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Window.ShowHelper(Object booleanBox)
   at System.Windows.Window.Show()
   at System.Windows.Window.ShowDialog()
   at AlbumArtDownloader.ArtSearchWindow.OnEditPresets(Object sender, RoutedEventArgs e)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.TranslateAndDispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunInternal(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)

Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-01-18 08:13:25
Getting repeated crash when trying to update/change presets:
Error log:
? is there a fix?
Thanks for reporting that. I haven't been able to reproduce the issue, can you give me the exact steps that cause it? On the popup menu you click "Edit Presets..." and then what, it crashes immediately? Or are you trying to add or delete a preset? Have you previously been able to add or delete any presets? You could try resetting your settings by deleting the %localappdata%\AlbumArtDownloader folder, that might help.
Title: Re: Album Art Downloader XUI
Post by: JWiels on 2018-01-18 18:57:38
Previously have successfully edited presets to make a list of about 8.  But have experienced many crashes in the edit preset process recently.
The above log was triggered by clicking 'Add' while in 'edit presets' dialog.
Crash trigger is inconsistent; sometimes when selecting 'edit presets', sometimes 'Add', sometimes after editing at 'close' after editing.  It will always crash once 'edit preset' is started.  At some step in the process. Even edit then immediately close -> crash.
Preset edits are  never saved. The list reverts to the previous list of presets.

Will check the app data folder.
Can this file or list be manually edited?

Thanks for quick reply
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-01-19 08:18:03
Can this file or list be manually edited?
Very strange. I can't guess what might be going on there, but yes, the file can be manually edited. In %localappdata%\AlbumArtDownloader look for the file: "AlbumArt.exe_Url_bunch of random characters\1.0.2.0\user.config". This is an XML file. You are looking for <setting name="Presets"
Title: Re: Album Art Downloader XUI
Post by: lisainil on 2018-01-29 16:01:05
Question about how Album Art Downloader works....
I gave it at try and was able to easily find and download the artwork I wanted.  Your software saved it as a folder.jpg file in the folder of the album.  What I wanted it to do was embed the artwork in the .m4a song files of the album, but it didn't seem to do that.
Can the software do that?  Or am I missing a step?
Thanks!
Lisa
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-01-29 19:46:50
What I wanted it to do was embed the artwork in the .m4a song files of the album, but it didn't seem to do that.
Sorry, no Album Art Downloader does not embed artwork in song files. This is a library/tag management task (ensuring that all songs in an album have the correct artwork embedded). By design, Album Art Downloader is only for finding and downloading image files; it leaves library management to library management software.
Title: Re: Album Art Downloader XUI
Post by: lisainil on 2018-01-29 19:59:50
OK, cool.  Thanks.  It works nicely by the way.  Do you have any recommendations for software that can embed the artwork I downloaded from your software into the song files?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-01-30 08:34:35
OK, cool.  Thanks.  It works nicely by the way.  Do you have any recommendations for software that can embed the artwork I downloaded from your software into the song files?
Foobar2000 itself can do it, and a few years ago Mp3Tag (https://www.mp3tag.de/en/index.html) was well regarded. I'm afraid I don't do embedding myself, so I can't give you a more personal recommendation.
Title: Re: Album Art Downloader XUI
Post by: SigHunter on 2018-02-17 18:26:47
Alex, do you know if this is possible with the current version of AAD or maybe can be included in a future one:
I have multiple versions of same albums (remastered, original, reissue, digipack, etc.) but when I use the file browser to search a folder by ID3 tag it matches all those folders to 1 album and only puts a cover in 1 of those folders. the album name tag does not differ in all versions, that is managed by other tags. can you maybe do an extra search per id3tag&folder combo? the folder names are not fitting since they include catalog number, diskid or stuff like that
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-02-17 18:45:04
...can you maybe do an extra search per id3tag&folder combo? the folder names are not fitting since they include catalog number, diskid or stuff like that
It is not possible to search by ID3 tag and folder, it has to be one or the other. But it is possible to specify the folder pattern quite precisely; as long as your folder names follow a regular scheme then you should be able to create a pattern to match them. If you post an example of your folder names, I can give you a hand.
Title: Re: Album Art Downloader XUI
Post by: SigHunter on 2018-02-17 18:49:45
...can you maybe do an extra search per id3tag&folder combo? the folder names are not fitting since they include catalog number, diskid or stuff like that
It is not possible to search by ID3 tag and folder, it has to be one or the other. But it is possible to specify the folder pattern quite precisely; as long as your folder names follow a regular scheme then you should be able to create a pattern to match them. If you post an example of your folder names, I can give you a hand.
problem is that those additional infos like catalog number are only there if the tag exists (when i have 'em), so its not possible to match it to a fixed pattern. is it possible to adjust the tags it uses to distinguish files from another?

my last resort is to rename all my album folders and set a unique splitter after album name. not that hard to do, i just wanted to avoid it because i dont want to reupload my stuff to cloud backup
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-02-17 19:03:22
Sorry, path pattern allows a lot of flexibility, but ID3 tags are hard-coded. It will search AlbumArtists, or fall back to Performers if AlbumArtists isn't present. For Album, it only uses Album.
Title: Re: Album Art Downloader XUI
Post by: SigHunter on 2018-02-17 22:04:36
so I renamed my folders in a distinguishable way:
%Artist%\%Album% [Catalog]\*.flac

which matches to
%artist%\%album% [*\*.flac

But it does add all those folders into 1 item, I don't think it works the way I wanted
Can you help?

Thanks for your help by the way and for keeping AAD alive over the years!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-02-18 08:06:19
But it does add all those folders into 1 item, I don't think it works the way I wanted
Can you help?
So if they should be treated as different albums, they are going to need different album names. I thought this would be including the remastered, original, reissue, digipack part you had mentioned - does that not appear anywhere in the path? If that is just information you happen to know about the album without it being accessible to AAD then it's going to be tricky. There is no support for searching for a single album image and downloading it into multiple folders, but it sounded to me like what you wanted was different art for each folder. So one would be a search for "Album Name - Original" and one "Album Name - Remastered", for example.
Title: Re: Album Art Downloader XUI
Post by: SigHunter on 2018-02-21 12:48:27
But it does add all those folders into 1 item, I don't think it works the way I wanted
Can you help?
So if they should be treated as different albums, they are going to need different album names. I thought this would be including the remastered, original, reissue, digipack part you had mentioned - does that not appear anywhere in the path? If that is just information you happen to know about the album without it being accessible to AAD then it's going to be tricky. There is no support for searching for a single album image and downloading it into multiple folders, but it sounded to me like what you wanted was different art for each folder. So one would be a search for "Album Name - Original" and one "Album Name - Remastered", for example.
that is basically correct, but searching for "Album Name - Remastered" does most of the time not work well since the title of the album simply is "Album Name"

And in reality the folders use catalog numbers rather than "remastered" and more or less look like this: Fear Of The Dark [7243 4 96925 0 3]

via File Path Pattern I can get it to match to this:
(https://i.imgur.com/CEFVpBb.png)

but I'd rather have it multiple times without the stuff in the brackets in the list like this:
(https://i.imgur.com/vlN61ai.png)

so I thought matching by tags but also creating a separate match per folder would be neat.

I know now this can not be done with AADXUI at the moment. but you know this is a use case  ;)


Oh, another little thing:
Is there a way to increase the font size in the "Get Artwork Automatically" Window?
The higher my resolution gets over the years, the smaller the font gets and my eyes also don't get better ;)
I mean this:
(https://i.imgur.com/ZeiQdvD.png)
You can scale the cover preview but the font size does not scale with it
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-02-21 16:57:52
Is there a way to increase the font size in the "Get Artwork Automatically" Window?
Thanks for your feedback. With regards to the font size, I'm afraid there is no skinning or UI customisation implemented, so the only way to change the size of the UI elements (other than the thumbnails) is to change the scaling setting for Windows. That would affect all applications, though, not just this one.
Title: Re: Album Art Downloader XUI
Post by: SigHunter on 2018-02-21 17:57:23
Is there a way to increase the font size in the "Get Artwork Automatically" Window?
Thanks for your feedback. With regards to the font size, I'm afraid there is no skinning or UI customisation implemented, so the only way to change the size of the UI elements (other than the thumbnails) is to change the scaling setting for Windows. That would affect all applications, though, not just this one.
I have scaling set to 150% in windows, the font is smaller than other fonts on the same window (Sources, Artist, Album, Artwork Status, Dimensions, etc.). Making it the same size as all the other fonts would be perfect
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-02-25 13:09:45
Hello.

My music is stored in a directory structure: <Artist>/[<year>]- <album> e.g. Beatles/[1969] - Abbey Road
I'm trying to use the folder browser to check the artwork, but the [year] is a problem. I'm trying to use regex to get around this. In the file browser window, I've selected the "Use file path pattern matching:" option and updated the expression to be:

\%artist%\"\[\d{4}\]\s-\s"%album%

but no search results appear.... Any ideas anyone?  (If I mock-up an artist/album folder structure that works with the default \%artist%\%album

Any thoughts?

Thanks
D
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-02-25 15:29:47
Hello.

My music is stored in a directory structure: <Artist>/[<year>]- <album> e.g. Beatles/[1969] - Abbey Road
I'm trying to use the folder browser to check the artwork, but the [year] is a problem. I'm trying to use regex to get around this. In the file browser window, I've selected the "Use file path pattern matching:" option and updated the expression to be:

\%artist%\"\[\d{4}\]\s-\s"%album%

but no search results appear.... Any ideas anyone?  (If I mock-up an artist/album folder structure that works with the default \%artist%\%album

Any thoughts?

Thanks
D


I was missing a \* at the end....

%artist%\"\[\d{4}\]\s-\s"%album%\* is working...
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-02-25 15:33:45
Looks good to me, just end it in \. to indicate you want to match the folder, not any files within it (or end in \* if you don't want it to match empty folders, or end in *.mp3 if you want it to match only folders with mp3's in them, etc.):

Code: [Select]
\%artist%\"\[\d{4}\]\s-\s"%album%\.

Edit: Ah, see you already figured it out, great!
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-02-25 16:47:44
A new question about the file browser....
is there a way to set the search for a specific preset such as -front, -back etc without editing manually the path for images?
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-02-25 18:41:44
A question about booklets.... I'm downloading from MusicBrainz. For Adele - 25, there are 7 cover art files of type booklet
(https://musicbrainz.org/release/3ce75ee5-4fb0-4209-9bde-8770d17f5fc4/cover-art)

Album Artdownloader only lists 3. There are 4  missing.  Any thoughts?

Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-02-25 21:53:11
A question about booklets.... I'm downloading from MusicBrainz. For Adele - 25, there are 7 cover art files of type booklet
(https://musicbrainz.org/release/3ce75ee5-4fb0-4209-9bde-8770d17f5fc4/cover-art)

Album Artdownloader only lists 3. There are 4  missing.  Any thoughts?

but not a problem with another Adele booklet - Adele 21
https://musicbrainz.org/release/57440dfc-191c-32bd-ada0-14ac366c2a12/cover-art
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-02-26 08:06:01
is there a way to set the search for a specific preset such as -front, -back etc without editing manually the path for images?
You can include %preset% in the path for images, but that will look for any preset. If you want it to only find a specific preset then you have to edit the path manually to include that.

For Adele - 25, there are 7 cover art files of type booklet ... There are 4  missing.
There is a limit to the number of results from any given source. By default, this is 10. If you click the little ... at the bottom right of the MusicBrainz source you can change this.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-02-27 21:19:05
Thanks for the clue on the limited number of results.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-03-02 22:16:46

Hi Alex

I was using the edit-presets UI to add more presets when AlbumArt crashed - see attached log.

Details:
1. I had edited the built-in ones to remove "Folder-" from each of the save names. So CDs are saved as cd.jpg etc
2. I added two more presets without issue. Booklet-1 and Booklet-2.
3. When I click on the Add button to add the third one, the program crashes.
4. I can reproduce this at will. Have rebooted several times. I'm using windows 10.

Hope this is enough for a fix.
David
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-03-03 09:08:41
Thanks for reporting this. It seems to be the same issue JWiels reported: #2803 (https://hydrogenaud.io/index.php/topic,57392.msg951357.html#msg951357)

Unfortunately I was unable to reproduce it, or to determine any likely reason it might happen. The best I was able to do was give some guidance on how to edit the AAD config file manually: #2806 (https://hydrogenaud.io/index.php/topic,57392.msg951446.html#msg951446). Not very satisfactory, really, but unless I can find a way to trigger this crash locally with a debugger I don't think I'll be able to fix it.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-03-03 11:26:56
Thanks for reporting this. It seems to be the same issue JWiels reported: #2803 (https://hydrogenaud.io/index.php/topic,57392.msg951357.html#msg951357)

Unfortunately I was unable to reproduce it, or to determine any likely reason it might happen. The best I was able to do was give some guidance on how to edit the AAD config file manually: #2806 (https://hydrogenaud.io/index.php/topic,57392.msg951446.html#msg951446). Not very satisfactory, really, but unless I can find a way to trigger this crash locally with a debugger I don't think I'll be able to fix it.

Thanks for the reference to the configuration file. I was able to use that and able to add 6 more presets. I was also able to use them with Save-As.

More info on Edit Presets.

1. I click on Edit Presets and the list of all presets is displayed.
2. If I use the vertical scroll bar and move the view to the bottom, and then click Add, it works.
3. If I do not use the vertical scroll bar and click Add, then AlbumArtDownloader crashes.

Hope this helps.
David
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-03-03 12:02:12

A seperate issue is that when i right click on save-as, the list is limited to 11 entries. I have 12 in the xml file. Please can you make it longer?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-03-03 12:37:36
Thanks, that vertical scrollbar clue is helpful, I'll investigate further.

The preset popup menu is not limited, unless it is somewhere else you were referring to?
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-03-03 13:33:34
You are right about the number of presets. I added more and it works. No idea why it didn't last time! Apologies.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-03-04 09:34:32
1. I click on Edit Presets and the list of all presets is displayed.
2. If I use the vertical scroll bar and move the view to the bottom, and then click Add, it works.
3. If I do not use the vertical scroll bar and click Add, then AlbumArtDownloader crashes.
Could you give the attached 1.03 a try and let me know if you see any more preset crashes? It should fix the crash when the newly added preset is not within the visible scroll area, but I don't know if that's the only cause. It wasn't mentioned by the previous person to report it.

Thanks,

Alex
Title: Re: Album Art Downloader XUI
Post by: dpr on 2018-03-06 16:37:30
Could you give the attached 1.03 a try and let me know if you see any more preset crashes? It should fix the crash when the newly added preset is not within the visible scroll area, but I don't know if that's the only cause. It wasn't mentioned by the previous person to report it.

Thanks,

Alex

That seems to have fixed it. Thanks!
Sorry for the delay in testing

David
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-03-07 13:04:05
That seems to have fixed it. Thanks!
Great, thanks for letting me know, I've released 1.03 with that fix in it now.
Title: Re: Album Art Downloader XUI
Post by: NetRanger on 2018-03-08 20:40:05
Just a minor thing....... the site URL under the Help-> 'About..... ' is faulty
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-03-09 08:30:19
Just a minor thing....... the site URL under the Help-> 'About..... ' is faulty
Thanks. Looks like Sourceforge has lost the wiki with the documentation in it. Oh well, I've fixed it at least to redirect to the main project page now. Better than a 404.
Title: Re: Album Art Downloader XUI
Post by: OldManMike on 2018-03-20 07:16:52
The great thing about Album Art Downloader is how well it works finding covers for a bunch of random songs (not in a album)

The most frustrating thing is seeing all those covers and having to manually give a unique name to each before saving.

I just don't do albums.  All my music is saved as individual mp3 files where I want to embed cover art (and no, I don't expect Art Downloader to do the embedding).  All I want is to point Art Downloader to a folder containing a large number of random songs with proper ID3 tagging and then save all the covers found by Art Downloader into another folder with each cover uniquely named with the associated song.   It seems so basic but I have yet to see how to do it.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-03-20 08:21:26
All I want is to point Art Downloader to a folder containing a large number of random songs with proper ID3 tagging and then save all the covers found by Art Downloader into another folder with each cover uniquely named with the associated song.
Is the problem that you have several songs with the same album tag, and you want to download covers for each song? If that's the case, then I think it would be possible by using file path pattern matching instead of ID3 tag matching, so you could define the track name as the 'album'. For example: "\%album%.mp3". It is not generally necessary to split out the artist and album - almost all search sources combine them for the search anyway.

The second part of your usage, to save the covers into another folder uniquely named, is not a problem. In the "Specify path to find images", just include the folder name where you want it to put the art. For example: "Art\%artist%-%album%.%extension%" would create a subfolder of your music folder called "Art", and save covers in that named by artist and album (where album is whatever has been defined in the search, it doesn't have to be the ID3 tag)
Title: Re: Album Art Downloader XUI
Post by: OldManMike on 2018-03-21 05:27:43
Is the problem that you have several songs with the same album tag, and you want to download covers for each song? If that's the case, then I think it would be possible by using file path pattern matching instead of ID3 tag matching, so you could define the track name as the 'album'. For example: "\%album%.mp3". It is not generally necessary to split out the artist and album - almost all search sources combine them for the search anyway.

Yes, sometimes in a list of random songs there are more than one songs which should have the same album cover embedded.   Anyway, I think ID3 tag matching was working since out of 100 songs, it found album covers for all.

The second part of your usage, to save the covers into another folder uniquely named, is not a problem. In the "Specify path to find images", just include the folder name where you want it to put the art. For example: "Art\%artist%-%album%.%extension%" would create a subfolder of your music folder called "Art", and save covers in that named by artist and album (where album is whatever has been defined in the search, it doesn't have to be the ID3 tag)

Ok, this was the key.  What is very confusing to me is the statement: "Specify path to find images".  It seems like it should say "Specify path to SAVE images".  Making your recommended entry for that option worked.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-03-21 07:51:17
Ok, this was the key.  What is very confusing to me is the statement: "Specify path to find images".  It seems like it should say "Specify path to SAVE images".  Making your recommended entry for that option worked.
Great, thanks for letting me know. I take your point about the confusing wording - the intention is to define the path where images belong. It will search there for image files, and of course save them there too (if there are multiple places to search defined, it saves them in the first one).
Title: Re: Album Art Downloader XUI
Post by: triangle on 2018-04-20 09:43:48
[I've released 1.03 with that fix in it now.
"Check for Updates" offers a new version v1.0.3 but Sourceforge still delivers v1.02.
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2018-04-22 07:31:37
I'm seeing the same thing. Can't tell if the version wasn't properly bumped, or the new file wasn't uploaded.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-04-22 08:18:10
Not really sure what is going on with sourceforge, then. It is available in the usual place at https://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.03.exe/download but if sourceforge is not showing that as the latest version I will investigate why.
Title: Re: Album Art Downloader XUI
Post by: triangle on 2018-04-22 10:54:46
It is available in the usual place at https://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.03.exe/download
Thanks.
I followed the link and downloaded it.
I get a compilation error which I did not get with version 1.02:
Quote
"Searching for scripts...
...
Compiling scripts...
amazon-audiobooks-com.boo(14,106): error BCE0005: Unknown identifier: 'PageEncoding'.
amazon-audiobooks-com.boo(14,152): error BCE0005: Unknown identifier: 'PageEncoding'.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-04-26 13:57:28
I don't understand why there should be a compilation error, particularly as the amazon-audiobooks-com.boo script doesn't have PageEncoding anywhere in it. The only script with a PageEncoding in it is amazon-mp3-com.boo. That one doesn't cause compilation errors for me either, but had stopped returning results, so I've uploaded a fixed version of it.
Title: Re: Album Art Downloader XUI
Post by: triangle on 2018-04-26 14:56:15
I don't understand why there should be a compilation error, particularly as the amazon-audiobooks-com.boo script doesn't have PageEncoding anywhere in it.
Thanks. I now had a look an the script and there was PageEcoding in it.
During install of 1.,03 I had not checked this script and there must been an older script with PageEcoding that remained in the folder.
After checking the scripts to install all is fine.
Title: Re: Album Art Downloader XUI
Post by: UksusoFF on 2018-06-04 18:01:22
Hi, AlexVallat!

Thanks for great software.

Is there way save two versions of image (original and thumbnail)?

Also please add Yandex.Music as source. Search results can return as json:
Code: [Select]
https://music.yandex.ru/handlers/music-search.jsx?text="thirty%20seconds%20to%20mars"&type=album
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-06-04 18:47:58
Sorry, there is no way to save thumbnails separately.

Yandex Music looks like a good source, please give the attached Yandex.boo script a try and let me know if you find any problems.
Title: Re: Album Art Downloader XUI
Post by: UksusoFF on 2018-06-04 19:20:48
Yandex Music looks like a good source, please give the attached Yandex.boo script a try and let me know if you find any problems.
Thanks! Works great.
Title: Re: Album Art Downloader XUI
Post by: dafterside97 on 2018-06-16 16:25:11
Hi, when I opening the program instantly crash. Here's the log
Spoiler (click to show/hide)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-06-16 16:41:47
Hi, when I opening the program instantly crash. Here's the log
Code: [Select]
... ejecute ServiceModelReg.exe -i para corregir este error ....

The error message appears to indicate that there's something wrong with your machine.config file. This is not installed or modified by Album Art Downloader.

Did you try running "ServiceModelReg.exe -i" as the .NET Framework suggested? For me, that file is in "C:\Windows\Microsoft.NET\Framework64\v3.0\Windows Communication Foundation\ServiceModelReg.exe"
Title: Re: Album Art Downloader XUI
Post by: dafterside97 on 2018-06-16 18:32:30
Hi, when I opening the program instantly crash. Here's the log
Code: [Select]
... ejecute ServiceModelReg.exe -i para corregir este error ....

The error message appears to indicate that there's something wrong with your machine.config file. This is not installed or modified by Album Art Downloader.

Did you try running "ServiceModelReg.exe -i" as the .NET Framework suggested? For me, that file is in "C:\Windows\Microsoft.NET\Framework64\v3.0\Windows Communication Foundation\ServiceModelReg.exe"
Sadly didn't work, still crashing
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-06-16 19:12:10
Sadly didn't work, still crashing
I don't know, then. I guess you could try re-installing .NET Framework. Or resetting the machine.config file by going to C:\Windows\Microsoft.NET\Framework64\v2.0.50727\CONFIG, deleting "machine.config", and copying "machine.config.default" to "machine.config". Of course, if you don't know what made the change to machine.config in the first place, that might risk breaking something else, I suppose. I've no idea why anything would want to be changing that file.
Title: Re: Album Art Downloader XUI
Post by: dafterside97 on 2018-06-16 20:07:58
Sadly didn't work, still crashing
I don't know, then. I guess you could try re-installing .NET Framework. Or resetting the machine.config file by going to C:\Windows\Microsoft.NET\Framework64\v2.0.50727\CONFIG, deleting "machine.config", and copying "machine.config.default" to "machine.config". Of course, if you don't know what made the change to machine.config in the first place, that might risk breaking something else, I suppose. I've no idea why anything would want to be changing that file.
I re-installed .NET Framework 3.5 and now is working fine!, thanks!. How I can filter the size of cover? I want a 1000x1000 cover from deezer or itunes exactly.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-06-17 08:10:55
I re-installed .NET Framework 3.5 and now is working fine!, thanks!. How I can filter the size of cover? I want a 1000x1000 cover from deezer or itunes exactly.
Great, thanks for letting me know. To filter the cover size, click the Options link in the search window, then set both min and max to 1000. You can uncheck all other sources than Deezer and iTunes if you want covers from them only.
Title: Re: Album Art Downloader XUI
Post by: dafterside97 on 2018-06-17 16:12:23
I re-installed .NET Framework 3.5 and now is working fine!, thanks!. How I can filter the size of cover? I want a 1000x1000 cover from deezer or itunes exactly.
Great, thanks for letting me know. To filter the cover size, click the Options link in the search window, then set both min and max to 1000. You can uncheck all other sources than Deezer and iTunes if you want covers from them only.
Nice, thanks for the help.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-23 10:24:28
Hi there. Thanks for this great app. It works great but the discogs script do'nt appear on the list on the left side.
When i clic on the "get more scripts" button, it still appears again and again (v0.19). But the boo file is inside the scripts folder with all the others.

To understand what is going wrong, i 've let only the discogs.boo file inside the folder. Here is the log:

Code: [Select]
Searching for scripts...
Found 1 files: [discogs.boo]...
Loading references: [System.Web.Extensions]...
Compiling scripts...
discogs.boo(7,8): error BCE0021: Namespace 'util' not found, maybe you forgot to add an assembly reference?

Error inside the script?

Thanks for help.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-23 11:40:14
Hi, if you've deleted everything except for discogs.boo, then please re-download util.boo (http://album-art.sourceforge.net/scripts/util.boo) and put that in the scripts folder too. discogs.boo (and most other scripts) depend on that one.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-23 11:48:37
Here is the log:

Code: [Select]
Searching for scripts...
Found 2 files: [discogs.boo, util.boo]...
Loading references: [System.Web.Extensions, System.Web]...
Compiling scripts...
discogs.boo(9,15): error BCE0018: The name 'AlbumArtDownloader.Scripts.IScript' does not denote a valid type ('not found'). Did you mean 'System.Web.UI.IScriptControl'?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-23 12:35:22
Hmm. That error would seem to suggest that AlbumArtDownloader.Scripts.dll is not present, but that should be in the main program folder, not in the scripts subfolder. At this point, I think your best bet is just to uninstall AAD and install it again.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-23 12:59:50
I made a clean uninstall via windows and reinstall the app. No luck. Still have the discogs script into the folder but unable to compile it.
same message.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-23 13:04:04
I've made a little modification into the script, i had at the top:

Code: [Select]
import AlbumArtDownloader.Scripts

Now the message is:
Code: [Select]
Searching for scripts...
Found 2 files: [discogs.boo, util.boo]...
Loading references: [System.Web.Extensions, System.Web]...
Compiling scripts...
discogs.boo(16,75): error BCE0005: Unknown identifier: 'SecurityProtocolType'.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-23 15:25:19
The discogs script should already have import AlbumArtDownloader.Scripts at the top, just above import util!

I don't know why you are getting the error about SecurityProtocolType. That's just part of the .net framework, in System.dll, so there's no chance that's not present (or nothing would work). I've tested with just discogs.boo and util.boo in the scripts folder, and it compiles fine for me, so there's something else weird going on with your setup.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-23 16:02:33
Look at http://album-art.sourceforge.net/scripts/discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) you'll see no import  ;)

I've got .net framework 4.5.2, i 'll try installing the newest version.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-23 16:25:43
Huh, you're right, the version there is incorrect. It's correct in the source (discogs.boo (https://sourceforge.net/p/album-art/code/HEAD/tree/XUI/Scripts/Scripts/discogs.boo)) and in the released installer/zip, but in the Updates.xml it's wrong. I've re-uploaded it now from the master copy, so once Sourceforge updates its caching it should work properly. Or you can download it directly attached to this post. Sorry about that.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-23 17:04:55
No problem, thank you for your help.

I've updated dotnet framework, now aad open fine (meaning, no compiling error with only the 2 scripts) but the source don't appears at the right side. There is only local files. The compiling is really fast, i don't have the time to see what's happening.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-23 17:59:23
Hmm. Could you try running the command line version with the listSources parameter:
Code: [Select]
aad.exe /listSources

Does it work with any other scripts - is it just Discogs that doesn't appear, or no scripts (other than local files)?
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-24 09:21:16
When i leave all the scripts into the folder, they appears at the right side of aad. I didn't check if they are all there. I saw discogs because i'm looking for vinyl gatefold images.

Here is ther result of the command with all scripts:
Code: [Select]
D:\TEMP\AlbumArtDownloader>aad.exe /listSources
Album Art Downloader XUI Command Line Interface version 1.0.1.0

Script cache out of date, rebuilding:

Searching for scripts...
Found 66 files: [45cat.boo, 45worlds-cdsingles.boo, 7digital.boo, absolutepunk.b
oo, allcdcover.boo, amazon-audiobooks-com.boo, amazon-ca.boo, amazon-co-uk.boo,
amazon-com.boo, amazon-common.boo, amazon-de.boo, amazon-fr.boo, amazon-it.boo,
amazon-jp.boo, amazon-mp3-com.boo, archambault.boo, arkivmusic.boo, audiopreserv
ationfund.boo, bandcamp.boo, beatport.boo, bing.boo, buy-com.boo, cdbaby.boo, ch
artstats.boo, cover-paradies.boo, coveralia.boo, coverlandia-official.boo, cover
landia.boo, deejay.boo, deezer.boo, discogs.boo, djshop.boo, ebreggae.boo, eclas
sical.boo, emusic.boo, esenshop.boo, fanarttv.boo, google-play.boo, google.boo,
hitparade.boo, hmv-canada.boo, itunes.boo, juno-download.boo, juno-records.boo,
kalahari.boo, lastfm-artist.boo, lastfm-cover.boo, maniadb.boo, medianet.boo, me
tal-archives.boo, metallibrary.boo, musicbrainz.boo, nuclearblast.boo, psyshop.b
oo, qobuz.boo, revhq.boo, saavn.boo, soundstation.boo, take2.boo, theclassicalsh
op.boo, theorchard.boo, trackitdown.boo, util.boo, vgmdb.boo, wantitall.boo, yes
asia.boo]...
Loading references: [System.Web.Extensions, System.Web.Extensions, System.Web.Ex
tensions, System.Web.Extensions, System.Web.Extensions, System.Web.Extensions, S
ystem.Web.Extensions, System.Web]...

Compiling scripts... done, but with warnings.
bing.boo(22,9): warning BCW0003: WARNING: Unused local variable 'json'.
vgmdb.boo(35,13): warning BCW0003: WARNING: Unused local variable 'loginResult'.

amazon-jp.boo(8,13): warning BCW0014: WARNING: Private property 'AmazonJp.ShiftJ
IS' is never used.
beatport.boo(2,8): warning BCW0016: WARNING: Namespace 'System.Xml' is never use
d.

Name                         Ver      Author
════════════════════════════════════════════════════════════════
45cat                        0.7      Alex Vallat
45world CD Singles           0.1      Alex Vallat
7digital                     0.4      Alex Vallat
absolutepunk.net             0.2      Alex Vallat
AllCdCover                   0.5      daju, Alex Vallat
Amazon Audiobooks (.com)     0.13s    Alex Vallat, ZOOT
Amazon (.ca)                 0.13s    Alex Vallat, ZOOT
Amazon (.co.uk)              0.13s    Alex Vallat, ZOOT
Amazon (.com)                0.13s    Alex Vallat, ZOOT
Amazon (.de)                 0.13s    Alex Vallat, ZOOT
Amazon (.fr)                 0.13s    Alex Vallat, ZOOT
Amazon (.it)                 0.13s    Alex Vallat, ZOOT
Amazon (.jp)                 0.13s    Alex Vallat, ZOOT
Amazon MP3 (.com)            0.3      Alex Vallat
Archambault                  0.6      Sebastien Leclerc
ArkivMusik                   0.8      Alex Vallat, DRata
Audio Preservation Fund      0.1      Alex Vallat
bandcamp                     0.4      Alex Vallat
Beatport                     0.2      Alex Vallat
Bing Images                  0.1      Alex Vallat
Buy.com                      0.8.5    alsaan, DRata, Alex Vallat
CD Baby                      0.4      Alex Vallat
Chartstats                   0.2      Alex Vallat
CoverLib (Cover-Paradies)    0.19     Alex Vallat
Coveralia                    0.11     Alex Vallat
Coverlandia (Official)       0.2      Alex Vallat
Coverlandia                  0.2      Alex Vallat
deejay.de                    0.5      Alex Vallat
Deezer                       0.6      Alex Vallat
DJshop                       0.4      Alex Vallat
EB Reggae                    0.2      Alex Vallat
eClassical                   0.2      Alex Vallat
eMusic                       0.5      Alex Vallat, DRata
esenshop                     0.1      Alex Vallat
fanart.tv                    0.5      Mordred
Google Play Music            0.3      Alex Vallat
GoogleImage                  0.21     Alex Vallat
hitparade.ch                 0.5      Alex Vallat
HMV Canada                   0.3      Alex Vallat
iTunes                       0.5      Alex Vallat
Juno Download                0.2      Alex Vallat
Juno Records                 0.8      Marc Landis, Alex Vallat
Kalahari                     0.7      Alex Vallat
LastFM Artist                0.7      Alex Vallat, pochaboo
LastFM Cover                 0.6      daju
maniadb                      0.3      Alex Vallat
medianet                     0.1      Alex Vallat
Encyclopaedia Metallum       0.6      Alex Vallat
Metal Library                0.3      Alex Vallat
MusicBrainz                  0.12     yeeeargh
Nuclear Blast                0.1      Alex Vallat
Psyshop                      0.7      Alex Vallat
Qobuz (fr-fr)                0.3      Alex Vallat, thomian
RevHQ                        0.6      Alex Vallat
Saavn                        0.1      Alex Vallat
Sound Station                0.1      Alex Vallat
Take2                        0.5      Alex Vallat
The Classical Shop           0.2      Alex Vallat
The Orchard                  0.2      Alex Vallat
trackitdown                  0.1      Alex Vallat
VGMdb                        0.7      Alex Vallat
WantItAll                    0.1      alsaan
YesAsia                      0.5      Alex Vallat



And with only discogs and util. I've ran the command twice, the second time, no compiling:
Code: [Select]
Windows PowerShell
Copyright (C) 2013 Microsoft Corporation. Tous droits réservés.

PS C:\Users\a981252> d:
PS D:\> cd .\TEMP\AlbumArtDownloader
PS D:\TEMP\AlbumArtDownloader> .\aad.exe listSources
Album Art Downloader XUI Command Line Interface version 1.0.1.0

Script cache out of date, rebuilding:

Searching for scripts...
Found 2 files: [discogs.boo, util.boo]...
Loading references: [System.Web.Extensions, System.Web]...

Compiling scripts... done.

No sources to search found. Use /listSources to show available sources.
PS D:\TEMP\AlbumArtDownloader> .\aad.exe listSources
Album Art Downloader XUI Command Line Interface version 1.0.1.0

No sources to search found. Use /listSources to show available sources.
PS D:\TEMP\AlbumArtDownloader>
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-24 17:33:33
That's weird, I can't guess what's going on there, why the discogs script should be the only one that doesn't show up. It's clearly being successfully compiled, so that shouldn't be a problem. Could you try installing .NET Framework 3.5 and see if that makes a difference?
Title: Re: Album Art Downloader XUI
Post by: dwmartin0906 on 2018-07-24 17:54:58
Hi. 
After updating to ver. 1.03 something weird started happening.  I usually just drag and drop from the results page to a folder and the file is always named Folder.jpg.  But now it always has the name of a Kylie Minogue album  even though the image is correct.  I tried re-installing but it didn't help.  So I re-installed ver. 1.02 and that solved the problem.  Any ideas?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-24 18:05:37
Click Options and have a look in the "Save images to" box. If that's got Kylie Minogue in it, that's where it's coming from. Or you can reset all settings for all versions by deleting the %localappdata%\AlbumArtDownloader folder, that should also resolve the issue.
Title: Re: Album Art Downloader XUI
Post by: dwmartin0906 on 2018-07-25 00:31:21
Deleting the folder seems to have taken care of it.  Ver. 1.03 is working again.  Thank you very much.  
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-25 09:38:30
I tried uninstalling dotnet 4.7.2 and installing 3.5 SP1, no luck, same problem.

I tried something else: i've deleted inside the script the TLS part:

Code: [Select]
class Discogs(AlbumArtDownloader.Scripts.IScript):


Name as string:
get: return "Discogs"
Now the source appears. But no results when i look for Nirvana/Nevermind or other classics that should find lots of images. Same thing reinstalling dotnet 4.7.2.

The listSources command is now fine:
Code: [Select]
PS D:\TEMP\AlbumArtDownloader> .\aad.exe /listSources
Album Art Downloader XUI Command Line Interface version 1.0.1.0

Name       Ver     Author
══════════════════════════════
Discogs    0.19    Alex Vallat

PS D:\TEMP\AlbumArtDownloader>
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-25 11:29:56
OK, that's useful information. There's something with your setup that doesn't like setting System.Net.ServicePointManager.SecurityProtocol, but I don't know why. The reason it doesn't find any results if you remove it is the Discogs requires TLS 1.1 or above to connect.

You could try specifying the protocol in an app.config file instead, try adding the attached file next to AlbumArt.exe and see if that works (leaving your doctored discogs script without the TLS bits.

Unfortunately I suspect that if there's a problem with setting the TLS version through code it would also fail to set using a config file, but I guess it's worth a try.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-25 12:26:04
I've put the file into the main folder, no results.

How can i check the TLS protocol is correctly configured in my setup? Maybe via registry? In IE i got this:

(http://i66.tinypic.com/ajuih0.png)

It's in french but you can see TLS 1.2 is ok.

I suppose there isn't any other script using TLS ?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-25 14:06:25
No, I don't think any other source requires specific versions of TLS. Your settings are for IE, I don't think they apply to .net. You can check what happens if you use PowerShell to run:
Code: [Select]
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12

If it gives some sort of error message it might indicate what the problem with setting it is, I suppose.
Title: Re: Album Art Downloader XUI
Post by: Fiatt on 2018-07-25 14:32:44
It does nothing:

Code: [Select]
PS C:\Users\a981252_a> [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12
PS C:\Users\a981252_a>

Ok, that's enough lost of time for you for a one guy problem. I'll do without Discogs! Thanks a lot for trying  :)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-25 14:45:44
Yeah, sorry about that, I'm pretty much out of ideas now too. I hope one of the other sources can give you the results you need.
Title: Re: Album Art Downloader XUI
Post by: Alfg on 2018-07-26 17:39:15
Any chance of a ebay script for this?, i often find art on ebay
I find very good artwork in ebay too. So I agree with xbon:  Any chance of a ebay script for this?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-07-27 10:06:47
I find very good artwork in ebay too. So I agree with xbon:  Any chance of a ebay script for this?
Please give this script a try, and let me know if it works well for you: ebay.boo (http://album-art.sourceforge.net/scripts/ebay.boo)

I've set it to search "Brand New CDs" only, as that seemed more likely to return cover art rather than photos of jewel cases.
Title: Re: Album Art Downloader XUI
Post by: vilsen on 2018-08-12 14:50:49
Hi,

I have just started to use this program and I like it. I have a feature suggestion that I think would be useful: A way to see if the jpeg's are baseline or progressive.

I've had problems with progressive jpeg's on some players, but baseline always works. So I'd like to download only the baseline type. With my own scans I always save as baseline, but when downloading album art I can't find an easy way to distinguish between the encoding types.

I'm no expert of the jpeg format, but here's my saving/format options in Photoshop:

Baseline ("Standard")
Baseline Optimized
Progressive

Written exactly like that. There's also a quality setting from 0 to 12, but that has never caused any problems.

I always save my own scans as Baseline ("Standard"), as this seems to be the most basic format and most widely supported by players, and I've never had a problem with this format. The sometimes unsupported format seems to be "progressive", and my impression from various support forums is that this is not an unusual problem.

I've also taken a glimpse here: https://en.wikipedia.org/wiki/JPEG and there seem to be "baseline sequential" and "baseline progressive" encoding, but this is beyond my understanding. But my guessing is that anything "progressive" is a format that some players don't support.

So, what do you think? Could a feature showing the encoding type be implemented in the program? Or maybe an option to show only the baseline type?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-08-13 08:19:54
Thanks for your suggestion. It would not be possible to determine the encoding used without first downloading the full-sized image, so I don't think this is something I will add to Album Art Downloader. It sounds like what you really need is a batch image converter (like XnConvert or similar), to convert all progressive-encoded JPEGs to baseline-encoded JPEGs.
Title: Re: Album Art Downloader XUI
Post by: vilsen on 2018-08-13 23:24:36
I did believe that the encoding type was written in the metadata, so it could be prefetched just like pixel dimension and file size. If that's not the case, and you'd have to decode the whole file, it would be more difficult of course.

Maybe it could be a user request, i.e. when you have decided for a suitable cover candidate, you right-click on it to request a full download for analysis of the encoding type?

Just a thought, but maybe there's too much work involved to implement this idea.
Title: Re: Album Art Downloader XUI
Post by: vilsen on 2018-08-15 19:17:23
I did believe that the encoding type was written in the metadata
Just to avoid any confusion:  "Header" is what I meant, not metadata.

(But maybe a header could be considered a kind of metadata;  I'm not entirely sure of the correct terminology)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-08-15 19:32:10
It would be data inside the JPEG file, in any case. Not in the HTTP Header, if that's what you were thinking. Doesn't really matter where inside it is, the file would still need to be downloaded. Analysing and converting image formats is out of scope for AAD, as I mentioned before, the right software for doing that is batch image conversion.
Title: Re: Album Art Downloader XUI
Post by: vilsen on 2018-08-16 11:02:01
Initially I was thinking that it's possible to preview only the header of the jpeg file - before downloading the whole file - and that AAD takes the pixel dimension and file size from there. That assumption led me to believe that the encoding type could be prefetched the same way.

Now I realize that AAD probably fetches the pixel & size info from the HTTP code. Is this the case?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-08-16 11:13:19
For some sources, the size information is available from the search results - either because it always provides a fixed size, or because the size is listed somewhere in the results page. Where it isn't available, it will just list it as unknown until the image is actually downloaded.
Title: Re: Album Art Downloader XUI
Post by: vilsen on 2018-08-16 11:28:30
I get the picture now, so to speak. Thanks for your support  :)
Title: Re: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2018-09-03 20:50:20
Hi, discogs seems to be broken again? I'm getting no results from that server...
Thanks for the effort in advance.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-09-08 10:39:55
Hi, discogs seems to be broken again? I'm getting no results from that server...
Thanks for the effort in advance.
Could you let me know what you're searching for? Seems to be working to me...
Title: Re: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2018-09-17 21:10:07
Hi, discogs seems to be broken again? I'm getting no results from that server...
Thanks for the effort in advance.
Could you let me know what you're searching for? Seems to be working to me...

Dear Alex, i beg you pardon...

I was using the wrong script, after updating everything works. Again, SORRY!!!
Title: Re: Album Art Downloader XUI
Post by: Mike_de on 2018-09-22 04:45:16
Hi Alex!
I'm using AAD for several months now and I'm very happy with it. However, the script for Fanart.tv constantly causes problems. The recent issue is that covers won't load in full resolution and often appear only in 200x200. It often takes forever for Fanart to respond at all.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-09-23 08:47:25
the script for Fanart.tv constantly causes problems.
It seems to be working OK for me, could you give an example of a search that is not returning full size results for you?
Title: Re: Album Art Downloader XUI
Post by: Mike_de on 2018-09-23 21:22:16
the script for Fanart.tv constantly causes problems.
It seems to be working OK for me, could you give an example of a search that is not returning full size results for you?
Any example. It's completely random. Right now, Fanart doesn't respond at all. All I get is this:

(https://abload.de/img/aadpaiy3.png)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-09-24 07:54:03
Either it's an intermittent problem on their end (you could check by trying to search the site itself when a problem occurs), or they are throttling or restricting access to it. The script itself seems to be working fine.
Title: Re: Album Art Downloader XUI
Post by: Mike_de on 2018-09-24 08:05:06
Either it's an intermittent problem on their end (you could check by trying to search the site itself when a problem occurs), or they are throttling or restricting access to it. The script itself seems to be working fine.
 Searching manually at Fanart.tv always works without any problems. However, I suppose their servers are somehow blocking access during certain times of the day. Most likely at times when it's evening in the US. I'm in Germany and currently everything works fine.

I've encountered another issue. The script does not always fetch all images from Fanart. I've just tried again searching for "Chinese Democracy" by Guns N'Roses and even though I've set the script to 5 images, all I get is two of them. The site has actually five different artworks: https://fanart.tv/artist/eeb1195b-f213-4ce1-b28c-8565211f8e43/guns-n-roses/

The script does not fetch the first image:

(https://abload.de/img/sd56fgb4s5f4bnbilh.png)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-09-24 08:29:21
I think what's happening here is you are limiting it to return only 5 results from fanart.tv, and then also filtering it to only show "Front" covers. So if the other Front covers aren't part of the first 5 returned, then they won't be available. Try increasing the limit to 10.
Title: Re: Album Art Downloader XUI
Post by: Mike_de on 2018-09-24 08:37:07
I think what's happening here is you are limiting it to return only 5 results from fanart.tv, and then also filtering it to only show "Front" covers. So if the other Front covers aren't part of the first 5 returned, then they won't be available. Try increasing the limit to 10.
 I never searched for anything else but front covers. I've now increased the number up to ten and now the rest appears. But that still makes no sense.
Title: Re: Album Art Downloader XUI
Post by: kode54 on 2018-09-26 03:40:06
The limit on result count is applied before it restricts it to specific image types.
Title: Re: Album Art Downloader XUI
Post by: lauris on 2018-09-29 16:01:05
Hey guys!

I'm trying to learn how to properly use AAD, but the wiki link is dead so I'll ask here.

a) I want to save every cover as albumart.jpg in the album folder, respecting the directory structure I use.
b) I want AAD to choose the best fitting image and save it automatically, so I don't have to click through hundreds of windows.

How can I properly do these things? If I can pull it off, I'll actually donate something :D.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-09-29 18:23:18
Yeah, the wiki got killed by sourceforge, unfortunately. To change the filename to save as, in the Folder Browser window click Options, then in the "Specify path to find images" box, put "albumart.jpg" (or "albumart.%extension%" if you want it to obey the correct filetype extension if the image isn't a jpg).

You can't get AAD to choose a "best" image, but you can have it choose the first one that meets the requirements. To do this, do one manual search first and make sure you have the sources that you want selected, along with any options for filtering by size or by cover type. Once you've closed that window those will be the defaults for subsequent searches.

Then, back in the File Browser window, under Options, select "Automatically download and save the first result that meets set criteria", select a bunch of albums (you can use the "Select all albums with missing artwork" if you like) and then hit the "Get Artwork for Selection" button.

Personally, I find "Automatic" works best with a very small set of reliable sources selected; I'd rather it simply left it as missing than put in an incorrect artwork, but you might have different priorities.
Title: Re: Album Art Downloader XUI
Post by: lauris on 2018-10-04 10:37:50
Thanks Alex, trying it now.

Does Discdogs search work? I tried selecting only Discdogs are source, and "limit search to one result", which I suppose would pick the first image, but I get "not found" for every album, even popular ones.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-10-04 18:55:47
Discogs v0.19 is working for me. Check that you can actually find the thing you are looking for on the discogs website directly. If so, please give me an example so I can investigate.
Title: Re: Album Art Downloader XUI
Post by: pochaboo on 2018-10-05 04:53:39
I updated my gracenote script.
Please replace gnClientID and gnUserID with yours before use.
Thanks.
Title: Re: Album Art Downloader XUI
Post by: lauris on 2018-10-05 09:40:51
Alex, here's an example: https://imgur.com/a/lBxv0z4. The moment I select last.fm, for example, the image is found immediately.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-10-05 18:47:40
Try checking the "Unknown" box in the "Filter by cover types" group in the options. Discogs doesn't tag the results with what type they are, so they all come back as unknown.
Title: Re: Album Art Downloader XUI
Post by: lauris on 2018-10-16 11:18:42
Thank yooouuu, finally managed to get it working! Sending a little something your way :).
Title: Re: Album Art Downloader XUI
Post by: Heinrich12 on 2018-11-10 11:00:58
Hello
I have tons of Albums on a network share. The goal is
1. Batch download covers (Filename cover.png or jpg), without interaction
2. Either with Mp3tag or Foobar
3. If I do so with File Browse in AAD it does not recognise the share
How should the syntax of commands do have to look like for Mp3tag or Foobar.
Thank you
Heinrich12
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-11-10 19:31:15
There's no reason it shouldn't work on a network share, the path should just be of the form "\\ServerName\Path". Or you can use the browse button to browse to the share and select it.

If it's really not working, consider temporarily creating a mapped network drive for the share and see if that helps.
Title: Re: Album Art Downloader XUI
Post by: Anakunda on 2018-12-18 12:42:11
I wonder if it's possible to copy source URL of selected cover from search results?
Title: Re: Album Art Downloader XUI
Post by: stavag on 2018-12-20 14:01:11
hello can I save the album art only with jpeg baseline format.because my player support only this format
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-12-20 17:20:24
hello can I save the album art only with jpeg baseline format.because my player support only this format
Album Art Downloader doesn't do any image processing, it just saves the file as it is provided by the source. If you want to re-encode (or resize, or anything else) you need some image processing software, sorry.
Title: Re: Album Art Downloader XUI
Post by: Mitch66 on 2018-12-20 18:10:24
I have the 'foo_comserver 2'  in my Components page, but when I try to use the Foobar browser in Album Art Downloader I am told that 'could not connect to foobar', and under 'foobar status' it says 'foobar200 COM Automation Server must be installed before the Foobar2000 library can be accessed' but I believe I have installed it.

Where have I gone wrong please?

Mitch
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2018-12-20 18:47:48
Hmm... is the foo_comserver even compatible with Foobar any more? I thought they abandoned it after 0.9... If it still works with current foobar, then running the installer should register it and allow AAD to access it. If not, probably easiest to just use the file browser.
Title: Re: Album Art Downloader XUI
Post by: Mitch66 on 2018-12-20 19:48:41
Alex,

thanks - the foo_conserver2 is definitely in my components page - but I cannot get ADD to recognise it so it looks like I will have to proceed as you suggest, unless anyone else has found a way round it

regards
Mitch
Title: Re: Album Art Downloader XUI
Post by: Waltz on 2018-12-24 23:07:47
Hello Alex, thanks for you amazing program. Could you please add OPUS files format? Is a new best lossy format. :)

https://www.videohelp.com/software/OpusTools
Title: Re: Album Art Downloader XUI
Post by: zpoison on 2019-01-31 16:50:35
Album Art Downloader is a great software, I have at least 20 hours of use with it...!!

I noticed that DEEZER images are not showing anymore
It was a great source for album covers

Any idea why ?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-02-01 17:02:52
I noticed that DEEZER images are not showing anymore
Seems to be working for me. What were you searching for? Does it work if you search on the Deezer website?
Title: Re: Album Art Downloader XUI
Post by: zpoison on 2019-02-01 17:12:52
@AlexVallat
I never go on the Deezer website
I don't like cell phones


I tried to test with album covers I previously took on Deezer (using Album Art Downloader)and there is no more Deezer results anymore
I tried if there is an update, no update
Title: Re: Album Art Downloader XUI
Post by: kode54 on 2019-02-02 02:04:48
I never go on the Deezer website
I don't like cell phones
What do those two things have to do with each other?
Title: Re: Album Art Downloader XUI
Post by: zpoison on 2019-02-02 03:06:11
@kode54

I thought it is a phone app., apparently it isn't.

Deezer still not working on Album Art Downloader
Title: Re: Album Art Downloader XUI
Post by: kode54 on 2019-02-02 03:46:40
It is a multi-platform service, and many of those just happen to have phone apps, but often also have web sites, and sometimes even desktop players, which are frequently built with Electron.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-02-02 08:08:41
Deezer still not working on Album Art Downloader
And it's still working for me. I still can't help you without answers to the questions I asked you.

If I search for the same album as isn't working for you, I can confirm if it's a problem with specific albums. If you search on the Deezer website (go to https://www.deezer.com/search/<album name>/album ) then that will show if you have a problem connecting to Deezer at all, and whether they have the album you are searching for available at all.
Title: Re: Album Art Downloader XUI
Post by: zpoison on 2019-02-02 15:47:14

I search for metallica master of puppets   

https://www.deezer.com/us/album/51188172

I get this =  (image attached)
Title: Re: Album Art Downloader XUI
Post by: zpoison on 2019-02-09 02:05:50
Ok It's I have Deezer back again, problem solved
Thank you for this great app
Title: Re: Album Art Downloader XUI
Post by: EnduringGuerila on 2019-03-19 09:44:25
I love this app, just really wish it had a dark theme.

If anyone else uses MusicBee, I recommend this:
https://getmusicbee.com/forum/index.php?topic=28212
Title: Re: Album Art Downloader XUI
Post by: katieinthecoconut on 2019-04-26 04:20:30
Google Play has stopped working for me, I haven't changed anything.
Title: Re: Album Art Downloader XUI
Post by: zpoison on 2019-04-26 07:59:52
Deezer is absent from the results too, I think
Title: Re: Album Art Downloader XUI
Post by: preservionist on 2019-04-26 11:06:44
Deezer is absent from the results too, I think
Works at the time.
Title: Re: Album Art Downloader XUI
Post by: preservionist on 2019-04-26 11:09:00
How to save the file as "albumtitle.extension"? I've tried, which should work as far as I can see:

Code: [Select]
C:\Users\user\Pictures\album art\%artist%\%album%.%extension%

The program doesn't pick the "%album%" parameter and names the images as .jpg or .png. "C:\Users\user\Pictures\album art\%artist%\" is the path I want to use.

EDIT: I use only Deezer as source at the time.
Title: Re: Album Art Downloader XUI
Post by: preservionist on 2019-04-26 11:14:07
I now see that "%album%" seems to only use the local search query and not the actual album title.

EDIT: solved:

Code: [Select]
C:\Users\user\Pictures\album art\%artist%\%name%.%extension%

I still don't know if downloading all is possible, however.
Title: Re: Album Art Downloader XUI
Post by: preservionist on 2019-04-26 11:46:27
Deezer only returns ten results — can this be increased?

Also, can the artist page URL be specified for accurate results? I want to archive covers for entire artist discographies (unfeasible to download manually for long-time bands such as Frank Zappa and Pink Floyd).
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-04-26 14:36:09
The number of results can be increased by clicking the ... button on the source, and then changing the limit in the options for the source.

Thanks for letting me know about Google Play, I've updated the script to v0.4 and it should work now.
Title: Re: Album Art Downloader XUI
Post by: Senior_DJ on 2019-07-04 15:46:04
Hello,

I installed the Album Art Downloader and I'm thrilled! But unfortunately, no covers are found at Discogs, but there is no error message   :(
Request for help.

Many Thanks
Senior_DJ
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-07-04 16:44:03
I've updated discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo), it should work again now.
Title: Re: Album Art Downloader XUI
Post by: Senior_DJ on 2019-07-05 10:14:38
It works! Many, many thanks for the super fast support!

Senior_DJ
Title: Re: Album Art Downloader XUI
Post by: cassel on 2019-07-09 14:22:12
Couple things.
1. Occasionally when launching AAD I get the error "There is no disk in the drive. Please insert a disk into drive D:." D: is mapped as my DVD RW drive. I have been using for AAD 6-8 months and this started in the last month or two. Should I try reinstalling or is there another solution in an ini file or something?
2.  iTunes has slowed down greatly.

Anyone else see these or do I have a conf problem?

thanks
Title: Re: Album Art Downloader XUI
Post by: loz on 2019-07-15 17:37:32
Juno records hasn't returned results for me in some time. I haven't had a chance to determine if it's on my end or if something on their site has changed.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-07-15 18:39:18
1. Occasionally when launching AAD I get the error "There is no disk in the drive. Please insert a disk into drive D:." D: is mapped as my DVD RW drive. I have been using for AAD 6-8 months and this started in the last month or two. Should I try reinstalling or is there another solution in an ini file or something?
2.  iTunes has slowed down greatly.
It's possible you have some folder set in AAD for D:\, check the file browser window and the default save path in the main search window. Change it to anything not on D:\ and it should be resolved. AAD will not be directly interacting with iTunes in any way.

Juno records hasn't returned results for me in some time. I haven't had a chance to determine if it's on my end or if something on their site has changed.
Their site has changed. I've updated juno-records.boo (http://album-art.sourceforge.net/scripts/juno-records.boo) and it should work now.
Title: Re: Album Art Downloader XUI
Post by: loz on 2019-07-15 18:59:59
Their site has changed. I've updated juno-records.boo (http://album-art.sourceforge.net/scripts/juno-records.boo) and it should work now.
Thanks. It's working now.
Title: Re: Album Art Downloader XUI
Post by: Zhiro90 on 2019-07-18 16:28:52
has last.fm artist changed? haven't been able to get artist pictures for a while.

congrats on such an amazing app
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-07-18 17:13:34
has last.fm artist changed? haven't been able to get artist pictures for a while.
Thanks, yes, last.fm artist was broken. Fixed it now: lastfm-artist.boo (http://album-art.sourceforge.net/scripts/lastfm-artist.boo)
Title: Re: Album Art Downloader XUI
Post by: Zhiro90 on 2019-07-18 17:43:06
Thanks, yes, last.fm artist was broken. Fixed it now: lastfm-artist.boo (http://album-art.sourceforge.net/scripts/lastfm-artist.boo)

It works again! thanks a lot!
Title: Re: Album Art Downloader XUI
Post by: Senior_DJ on 2019-07-23 11:54:55
Hello,
at Amazon.com no cover is found. Is this a temporary problem or does something have to be adjusted?

Many greetings
Senior_DJ


Title: Re: Album Art Downloader XUI
Post by: loz on 2019-07-23 17:21:00
Juno records hasn't returned results for me in some time. I haven't had a chance to determine if it's on my end or if something on their site has changed.
Their site has changed. I've updated juno-records.boo (http://album-art.sourceforge.net/scripts/juno-records.boo) and it should work now.
Somehow I managed to miss that juno-download was broken too. Thanks.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-07-25 18:14:55
Somehow I managed to miss that juno-download was broken too. Thanks.
Fixed: juno-download.boo (http://album-art.sourceforge.net/scripts/juno-download.boo)

at Amazon.com no cover is found. Is this a temporary problem or does something have to be adjusted?
I'm not having much luck with Amazon, it seems they've implemented some sort of bot detection and captcha. Might have to retire Amazon as a source, I'm afraid.
Title: Re: Album Art Downloader XUI
Post by: thomian on 2019-07-30 15:40:02
Script updates
[...]
Country-specific overrides to search stores other than the main USA one are available here: iTunes Country-Specific Searches (https://sourceforge.net/apps/mediawiki/album-art/index.php?title=Available_Scripts#iTunes_Country-Specific_Searches), but will not show up in the online updates "new scripts" notification, or be bundled with the installer. They depend on having the main itunes.boo (http://album-art.sourceforge.net/scripts/itunes.boo) script installed, and only that main script will need to be updated if future changes are required.
[...]
Alex

This Link does not work anymore.
Are the country specific script files anywhere else on the sourceforge website?
Thomian
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-07-30 17:04:36
This Link does not work anymore.
Are the country specific script files anywhere else on the sourceforge website?
Sourceforge nuked the wiki, but the files are still there at iTunes Country-Specific Searches (http://album-art.sourceforge.net/scripts/itunes/)
Title: Re: Album Art Downloader XUI
Post by: Anakunda on 2019-08-05 13:23:00
I have a wish for this useful tool: in the search result thumbnail view, could the context menu for every entry be extended by choice Copy source URL to clipboard? Furthermore, if using drag & drop and releasing the image not over a file container, butt text capable container, the source link could be pasted there.
Title: Re: Album Art Downloader XUI
Post by: Pak9999 on 2019-08-06 22:15:02
Hi

For some reason album artwork downloader does not work correctly. The first time I start it it shows me the start screen but nothing after. I can see it running in task manager for a couple of seconds and then stop. If start it after this it does not even even show the start screen. Same task manager results. I had it running with no problems before, but after a fresh install of Windows because my ssd died. It doesn't want to start anymore. Any help would be appreciated.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-08-07 08:17:21
Do you get any error reported in the Windows Event Viewer? Or in an errorlog.txt file in the AAD program folder? If not, I can only offer generic advice to try re-installing .net framework 3.5 and hope for the best.
Title: Re: Album Art Downloader XUI
Post by: Pak9999 on 2019-08-07 12:49:18
Hi Alex

Thanks for the quick response. There was no errorlog.txt file in the AAD program folder. But I did check windows event viewer and i do get an error when i try to start aad. (edit): I have now tried re-installing .net framework 3.5. It seems to have done nothing.
Here is the event viewer Log :

Log Name:      Application
Source:        Windows Error Reporting
Date:          07.08.2019 13:40:39
Event ID:      1001
Task Category: None
Level:         Information
Keywords:      Classic
User:          N/A
Computer:      DESKTOP-SOAKDO1
Description:
Fault bucket 2068282392258535810, type 5
Event Name: CLR20r3
Response: Not available
Cab Id: 0

Problem signature:
P1: albumart.exe
P2: 1.0.3.0
P3: 5a9aaeb0
P4: mscorlib
P5: 2.0.0.0
P6: 5c9ef717
P7: 284f
P8: 41
P9: System.ArgumentException
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D58.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D68.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D87.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D97.tmp.txt

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_albumart.exe_b36ea21ab8a9c6cdebba854f0a4495db253c8e2_00000000_d1181644-1153-45d5-80eb-a8549d004c25

Analysis symbol:
Rechecking for solution: 0
Report Id: d1181644-1153-45d5-80eb-a8549d004c25
Report Status: 268435456
Hashed bucket: b323ca8557ebc7284cb403e0a5c3e182
Cab Guid: 0
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Windows Error Reporting" />
    <EventID Qualifiers="0">1001</EventID>
    <Level>4</Level>
    <Task>0</Task>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2019-08-07T11:40:39.702851200Z" />
    <EventRecordID>2842</EventRecordID>
    <Channel>Application</Channel>
    <Computer>DESKTOP-SOAKDO1</Computer>
    <Security />
  </System>
  <EventData>
    <Data>2068282392258535810</Data>
    <Data>5</Data>
    <Data>CLR20r3</Data>
    <Data>Not available</Data>
    <Data>0</Data>
    <Data>albumart.exe</Data>
    <Data>1.0.3.0</Data>
    <Data>5a9aaeb0</Data>
    <Data>mscorlib</Data>
    <Data>2.0.0.0</Data>
    <Data>5c9ef717</Data>
    <Data>284f</Data>
    <Data>41</Data>
    <Data>System.ArgumentException</Data>
    <Data>
    </Data>
    <Data>
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D58.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D68.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D87.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8D97.tmp.txt</Data>
    <Data>\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_albumart.exe_b36ea21ab8a9c6cdebba854f0a4495db253c8e2_00000000_d1181644-1153-45d5-80eb-a8549d004c25</Data>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>d1181644-1153-45d5-80eb-a8549d004c25</Data>
    <Data>268435456</Data>
    <Data>b323ca8557ebc7284cb403e0a5c3e182</Data>
    <Data>0</Data>
  </EventData>
</Event>
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-08-07 13:50:45
I had it running with no problems before, but after a fresh install of Windows because my ssd died. It doesn't want to start anymore.
Any chance that this fresh install was using an "English International" iso installed by a tool? It sounds similar to https://sourceforge.net/p/album-art/bugs/66/
Title: Re: Album Art Downloader XUI
Post by: Pak9999 on 2019-08-07 14:18:15
I can't remember what language it was but, after the windows setup i changed it to English (United States).
(edit) Scrap the top part i checked my ISO and it is in en-us.
(edit2x) Well scrap the above again. Looked at the language as suggested and swapped my native language to windows display and back to English(US). Now it works again. Very weird bug.
Title: Re: Album Art Downloader XUI
Post by: katieinthecoconut on 2019-08-31 19:47:02
Hi Alex. I don't seem to be getting any results from Google Play anymore through the app. I know they've just made a change to the site, I guess it maybe needs an update?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-09-06 15:04:03
Sorry for the delay, update to Google Play script is now available at: google-play.boo (http://album-art.sourceforge.net/scripts/google-play.boo)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2019-09-14 17:27:56
Several people have reported recently an issue where Album Art Downloader XUI crashes out at startup. With assistance from some of those reporting the bug, and some research, I have determined that this is due to a bug in WPF on .NET Framework 3.5 on Windows 10, where it will crash out if the input language is anything in this list: MS-LCID (https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/a9eac961-e77d-41a6-90a5-ce1a8b0cdb9c) that has the non-specific Language ID of 0x1000. I think that's anything that was first introduced in Windows 10.

To try and work around this, I have re-compiled Album Art Downloader using .NET Framework 4.7.2, which I believe doesn't suffer from the same problem. Of course there may be other problems, so if the current version of AAD is working just fine for you then don't feel any pressure to install the recompiled version!

On the other hand, if you would like to try it, especially if you are running Windows 10, and doubly-especially if you are using some unusual input language locale, then I'd appreciate any reports of it working or not working.
Title: Re: Album Art Downloader XUI
Post by: dpr on 2019-12-06 11:18:51
Multiple Image Sizes

I play my music on a variety of devices with very different size screens and storage ranging from my iphone to my tv via apple tv.
On the phone, storage is at a premium and the display is small. On the tv, its the opposite.  Other devices can play flac. So my plan is to have multiple versions of the music each with different encodings of the music and with different artwork resolution.

It looks like I'll need artwork in 200 x 200, 600 x 400, and some bigger sizes say 3000 x 300.
So, how do i 'maintain' the ability to encode the music with multiple versions?  I can either

a) store multiple resolutions in my 'source' folder for each album/track
b) store the highest resolution available and resize it when creating the 'output' folder.

I am ruling out storing the biggest resolution image and using it everywhere due to the space concerns on small devices and also the cpu load to resize on the fly when displaying it.

Questions:
For a)  Is there any support for a) in Album Artwork downloader?
For b)  is there a command line resizer of artwork that can resize an existing jpg?

Thanks for any thoughts and ideas!
Dpr
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2020-01-26 20:57:12
Hi and thanks for the update! It works great for all the past years! Love the program!
Keep up the great tool! (and enjoy life!)
Title: Re: Album Art Downloader XUI
Post by: Anakunda on 2020-01-27 10:00:40
Thanks for the quick mirrors

SF repo is still offering 1.03, update it

In addition to it, could please be added a context menu entry, to copy original source URL to clipboard? (or to disclose it other way)

One more request: please add checkbox to File with same name already exists... dialog, to remember choice and not show this dialog in the future (that could reset somewhere in options)
Title: Re: Album Art Downloader XUI
Post by: katieinthecoconut on 2020-02-03 13:18:19
The Google Play script isn't working again. No results, even for common albums.
Title: Re: Album Art Downloader XUI
Post by: tpapas on 2020-02-09 22:12:16
Hi guys.
First of all, totally new to this forum. Can't seem to find how to post a new message, so I'm just using REPLY. Forgive me if I shouldn't have.
Anyway, I've been using MuvUnder Cover for many years now and I'm so used to it and it works great and it does exactly what I want an MP3 cover downloader to do and much more... But, the company that supports it, are really terrible in supporting it... So now all of the sudden it doesn't download any covers, so... I was searching for an alternative and found this which does look really promising.
I'm not sure if anyone has seen the MuvUnder Cover app and how it works!? The magic of it is that you have it on the Windows explorer so just a right click on a single MP3 or a list of as many as you want and select Send To -> MoveUnder Cover and boom, the app starts searching and downloading the covers...
What I really need to have is to be able to embed the cover in the MP3 which it does, and also save the cover file in the same folder as the track itself with the same name as the track and also set a limit of how many pixels do you want your artwork to be, I can only have 480 by 480 so it does that as well automatically...
Can this app do all that? I'm trying to play around with it and I can't seem to get the grasp of it, although, it does look promising!
Title: Re: Album Art Downloader XUI
Post by: TheEmpathicEar on 2020-02-09 23:00:08
I have not used this in quite a long time. Is this a stand-alone install? or, is it a plug-in?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-02-12 08:18:04
I have not seen MuvUnder Cover, no. For Album Art Downloader XUI (AAD), the installer has an option to "Add to Explorer context menu" which will add a "Browse for Album Art..." entry to folders. That should serve a similar workflow to your Send To, but bear in mind it's for searching for albums (which is why it's on a folder), not individual mp3 files.

AAD is just for downloading artwork, it does not handle tagging and embedding tasks. That's a job for library management software. It will download the cover in the same folder as the album. Usually called folder.jpg, but you can customise this naming by using artist and album name, and some other presets. The name of the track is not an option, as AAD works on albums, not tracks.

You can filter the size of the artwork to 480x480. It will not resize art, but it can filter out any results which are larger than that (some sources do return large images, though, so this may prevent all of their results). I would suggest a better approach would be to download the image at any size and then have your library management or image processing software resize it, but that's up to you.

This is a stand-alone install, not a plug-in
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2020-02-19 06:58:38
A couple issues.

1) The version on Source Forge is 1.0.3 which is annoying because everytime you start up AAD it tells you to update to 1.0.4. Came here to see what was going on and found the 1.0.4 version was released here.
2) The google image search has stopped returning results.
Title: Re: Album Art Downloader XUI
Post by: mville on 2020-03-09 16:48:09
I have re-compiled Album Art Downloader using .NET Framework 4.7.2, which I believe doesn't suffer from the same problem. Of course there may be other problems, so if the current version of AAD is working just fine for you then don't feel any pressure to install the recompiled version!

I have downloaded and installed AlbumArtDownloaderXUI-1.04. On launch I get this:

(https://i.imgur.com/1rwwLW1.jpg)

As I understand it, version 1.0.4 is now using .NET Framework 4.7.2.

 Please can you advise? TIA
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-03-09 17:54:28
As I understand it, version 1.0.4 is now using .NET Framework 4.7.2.

Please can you advise? TIA
Yes, that message is out of date. It is Framework 4.7 that should be installed, not 3.5. Could you give the attached a go and check it installs correctly and doesn't complain about framework issues for you, please?
Title: Re: Album Art Downloader XUI
Post by: mville on 2020-03-09 18:01:50
As I understand it, version 1.0.4 is now using .NET Framework 4.7.2.

Please can you advise? TIA
Could you give the attached a go and check it installs correctly and doesn't complain about framework issues for you, please?

Thanks, version 1.0.5 now installed and running on my Windows 10 Pro 64-bit PC.
Title: Re: Album Art Downloader XUI
Post by: Sea Monkey on 2020-03-26 19:51:47
Yes, that message is out of date. It is Framework 4.7 that should be installed, not 3.5. Could you give the attached a go and check it installs correctly and doesn't complain about framework issues for you, please?

I don't anticipate that you'd want to support or troubleshoot use of AAD via wine in Linux, but for what it's worth, this is what I get when using the attached version under a 64-bit prefix of wine with .NET 7.2 installed.

Code: [Select]
App version: 1.0.5.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.Runtime.InteropServices.COMException (0x88980406): Exception from HRESULT: 0x88980406
   at System.Windows.Media.Composition.DUCE.Channel.SyncFlush()
   at System.Windows.Interop.HwndTarget.UpdateWindowSettings(Boolean enableRenderTarget, Nullable`1 channelSet)
   at System.Windows.Interop.HwndTarget.UpdateWindowPos(IntPtr lParam)
   at System.Windows.Interop.HwndTarget.HandleMessage(WindowMessage msg, IntPtr wparam, IntPtr lparam)
   at System.Windows.Interop.HwndSource.HwndTargetFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.IntMsgWaitForMultipleObjectsEx(Int32 nCount, IntPtr[] pHandles, Int32 dwMilliseconds, Int32 dwWakeMask, Int32 dwFlags)
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-03-26 20:49:01
I don't anticipate that you'd want to support or troubleshoot use of AAD via wine in Linux, but for what it's worth, this is what I get when using the attached version under a 64-bit prefix of wine with .NET 7.2 installed.
Thanks for reporting this, it's always good to have more information. I wonder, do any WPF based applications run on your setup? The stack trace indicates that it's coming from deep in the internals of WPF so I doubt there is anything I can do to affect it one way or another, but if there's an working example I can compare with then maybe I can figure something out.

Alex
Title: Re: Album Art Downloader XUI
Post by: Sea Monkey on 2020-03-26 21:34:36
I don't anticipate that you'd want to support or troubleshoot use of AAD via wine in Linux, but for what it's worth, this is what I get when using the attached version under a 64-bit prefix of wine with .NET 7.2 installed.
Thanks for reporting this, it's always good to have more information. I wonder, do any WPF based applications run on your setup? The stack trace indicates that it's coming from deep in the internals of WPF so I doubt there is anything I can do to affect it one way or another, but if there's an working example I can compare with then maybe I can figure something out.

Alex

I got it working!  I used the following link to do so, though I didn't follow it verbatim:

https://www.reddit.com/r/linux4noobs/comments/firqs9/getting_windows_wpf_applications_to_run_with_wine/

For anyone else attempting to do the same thing, here's the gist of it:

- Run winetricks
   - Install .NET 4.7.2 (This will work backwards through previous versions that need to be installed first and likely throw up a lot of warning messages.  Don't worry.)
   - Install dxvk (latest)
   - Install d3dcompiler_47
- From the terminal,
  
Code: [Select]
wine reg add "HKCU\\SOFTWARE\\Microsoft\\Avalon.Graphics" /v DisableHWAcceleration /t REG_DWORD /d 1 /f

Not all of that may be necessary, but I figured I will probably want to tackle other D3D applications at some point.
Title: Re: Album Art Downloader XUI
Post by: kode54 on 2020-03-27 01:48:51
Why 4.7.2 and not 4.8? Installing 4.7.2 requires 4.0 -> 4.7 -> 4.7.2, while 4.8 requires 4.0 -> 4.8.
Title: Re: Album Art Downloader XUI
Post by: Sea Monkey on 2020-03-27 03:13:50
Why 4.7.2 and not 4.8? Installing 4.7.2 requires 4.0 -> 4.7 -> 4.7.2, while 4.8 requires 4.0 -> 4.8.

Yes, that message is out of date. It is Framework 4.7 that should be installed, not 3.5.

4.8 might work just fine, but given that running things in wine can be quite finicky, I figured I would have the best chance using the version specified. My closest options within winetricks were 4.7.1 or 4.7.2. I tried the latter.
Title: Re: Album Art Downloader XUI
Post by: kode54 on 2020-03-27 22:55:50
Installing 4.8 in Wine is a lot less troublesome at this point than 4.7.2. And if you have esync or fsync enabled, it goes pretty quickly, too. Or maybe my current system is just that much faster than my previous one.
Title: Re: Album Art Downloader XUI
Post by: Wazari on 2020-03-28 21:09:05
Hello,

I really love your program you made Alex, but right now I have a problem that happened just out of nowhere.
When I try to download a cover, it just gives me an error message that the file cannot be saved because the "file cannot be found"
The error only occurs at v1.04 and above. v1.03 works perfectly fine but It's outdated.

Do you know why it's causing this error message? Will be much appreciated!

Edit: Never mind, fixed it. It was just Windows Security that prevented it.
Title: Re: Album Art Downloader XUI
Post by: realJFK on 2020-03-29 12:17:49
I'm taking some seconds to post an acknowledgement message. I've used this wonderful tool for years, it was about time to do so :)
THANKS !
Title: Re: Album Art Downloader XUI
Post by: katieinthecoconut on 2020-04-20 07:35:13
Hey, is there any prospect of fixing the Google Play Music connector? It's been broken for a while. :)
Title: Re: Album Art Downloader XUI
Post by: Dr. Roboculous on 2020-05-05 17:52:12
The sources scripts database isn't updating. I can see the .boo files in the Scripts folder in AAD but the newer sources don't show up in the actual program. Any help?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-05-06 19:30:06
Hey, is there any prospect of fixing the Google Play Music connector? It's been broken for a while. :)
Seems to be working for me. Maybe it's just blacklisted your IP? Or if you give me the album you are searching for, I can try that.

The sources scripts database isn't updating. I can see the .boo files in the Scripts folder in AAD but the newer sources don't show up in the actual program. Any help?
Sorry, I don't understand the question. Are you getting an error message at startup, when it tries to compile the scripts? Is it a specific script that can't be loaded? Or you've added a script .boo file and AAD isn't trying to compile it at startup at all?
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2020-05-18 01:46:07
Is the GoogleImage script just completely dead now or what?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-05-20 08:14:21
Is the GoogleImage script just completely dead now or what?
Pretty much, unless they change again to make something less scraper unfriendly. Sorry.
https://sourceforge.net/p/album-art/support-requests/35/
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2020-05-20 18:45:13
Is the GoogleImage script just completely dead now or what?
Pretty much, unless they change again to make something less scraper unfriendly. Sorry.
https://sourceforge.net/p/album-art/support-requests/35/
I figured that was the case. I was trying to use google for another scraper and all calls were rejected too.
Title: Re: Album Art Downloader XUI
Post by: Dr. Roboculous on 2020-05-23 01:27:32
The sources scripts database isn't updating. I can see the .boo files in the Scripts folder in AAD but the newer sources don't show up in the actual program. Any help?
Sorry, I don't understand the question. Are you getting an error message at startup, when it tries to compile the scripts? Is it a specific script that can't be loaded? Or you've added a script .boo file and AAD isn't trying to compile it at startup at all?

It's the Allmusic.boo and Yandex.boo . When i start up Album Art Downloader there is a link at the bottom of the right-side panel that "new scripts downloaded". These are the two mentioned: allmusic.boo and yandex.boo. I click OK & restart the app and in my directory [C:\Program Files\AlbumArtDownloader\Scripts] both the .boo files are there but, they are not there in the side panel of the AAD app itself and i again have a message at the very bottom of the right-side panel that says New Scripts Downloaded... There is no error message. I hope  this post makes more sense to you.  I don't know the difference between "compiling" and "loading" them but, i just know that the two files are in the directory i mentioned above but not in the side panel of the app itself where you have the option to choose the Sources AAD uses and change the settings of them. Yandex and Allmusic are just not in that panel at all. And i always have that link to click on and it always has a pop-up window that shows the 2 .boo files it downloaded and when i click Restart they are still not in the Sources right-side panel.
Thanks. Love the app. I had been looking for something exactly like this for years now!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-05-23 09:07:51
It's the Allmusic.boo and Yandex.boo.
Sorry, it looks like those scripts are no longer available, the links are 404. They should not have been listed as New Scripts Downloaded, but for some reason the update check file wasn't properly updated - I think I've fixed that now.
Title: Re: Album Art Downloader XUI
Post by: audiophool on 2020-06-01 12:48:57
I'm on 1.0.3. During each program start, the software advises me that an update is available. (Until a few days ago, the info was that 1.0.4 is available--now it says 1.0.5 is available).

But on the sourceforge page, all I find is a 1.0.3 installer...
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-06-01 17:20:13
Hmm, 1.05 is available on Sourceforge, not sure why it isn't being offered as the default. I'll look into it. Meanwhile, you can grab it directly from https://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.05.exe/download
Title: Re: Album Art Downloader XUI
Post by: Blather on 2020-06-18 02:01:36
Hi, I had the problem where I would start your awesome program and it would check for updates, tell me there was a new version (first 1.0.4 then 1.0.5). I would download and install. I would start the program and it would tell me it was still v1.0.3 and ask me to download the new update. The update would always SAY it was the new update, but after reinstalling several times I would always launch the program and it was the older 1.0.3 version. It made it look like the update was mislabeled as new but was really old.

I finally figured it out.

I used the excellent "Search Everything" at https://www.voidtools.com/ and searched for "AlbumArt.exe". I found TWO of them!

Somehow the older version (in C:\Program Files\AlbumArtDownloader) was not getting updated. AAD was also in C:\Program Files\PerfectTUNES. THAT one was getting updated instead. I uninstalled AAD using the normal Windows uninstall tool. The PerfectTUNES version went away, but the C:\Program Files\AlbumArtDownloader version still stayed. I had been reusing an old shortcut to the older program.

Somehow, the older 1.0.3 program got "disassociated(?)" from the installation, but my shortcut still pointed at it. I manually deleted the old 1.0.3 one (OK, I first renamed it to be safe). I have now reinstalled the new one from Sourceforge and all is great. Of course I am using a new shortcut as well.

I wanted to post this 'cause it has been driving me insane. My guess is some of the other questions here have had this problem, too, even though they haven't used a million words like I did. Hopefully this is useful! I made an account here to pay it forward.

Thank you for your great program and the time you put into maintaining it!
Title: Re: Album Art Downloader XUI
Post by: Steve Grant on 2020-06-18 08:19:29
@Blather, the AlbumArt.exe you found in PerfectTunes belongs to PerfectTunes. Whilst it seems you did have some sort of mix up in your File Table, PerfectTUNES still requires its version of AlbumArt.exe. On my machine there are huge differences in file sizes between the two. 473KB for AAD vs 2284KB for PerfectTunes.
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2020-06-23 11:48:58
Hello AlexVallat!

Thanks (again) for this superb and multi-useful tool!

I get reproducable crashes with 1.0.5.0 under win7-64bit and those autofilled (via foo_run v0.3.8) values for:

Quote from: ARTIST
Johann Sebastian Bach - Ian Bostridge, Franz-Josef Selig, Sibylla Rubens, Andreas Scholl, Werner Güra, Dietrich Henschel, Collegium Vocale, Philippe Herreweghe

Quote from: ALBUM
Matthäus-Passion . St Matthew Passion . Passion Selon Saint Matthieu

just in case, my foo_run command:
Code: [Select]
".\user-components\AlbumArtDownloaderXUI\AlbumArt.exe" /ar "[%artist%]" /al "[%album%]" /p "$replace(%_path%,%_filename_ext%,)%%artist%%%%album%%'~'%%type%%%%size%%%%source%%.%%extension%%"

Except that, your great tool runs fine and smooth, since years!

cheers!


EDIT:
funny, another crash, maybe the same cause :)

Quote
Johann Sebastian Bach, Karl Richter, Rudolf Baumgartner

Cantatas II: Actus Tragicus / Ich Will Den Kreuzstab Gerne Tragen / Herz Und Mund Und Tat Und Leben
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-06-24 18:13:06
I get reproducable crashes with 1.0.5.0 under win7-64bit and those autofilled (via foo_run v0.3.8) values for:

Thanks for reporting this. I haven't been able to reproduce this, but perhaps it depends on which source you are using? I tried it with ArkivMusic, if you are using something else please let me know. Also, if you can see in the Windows Event Log what error get reported (there should be one from .NET Framework at the time of the crash), that might help.
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2020-06-24 20:26:34
which source you are using?
Also, if you can see in the Windows Event Log
I'm using ALL sources that come with the program
...and have disabled windows event logging since years... I really can't remember how to enable and where to look for those errors.
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2020-06-24 22:03:55
which source you are using?
Also, if you can see in the Windows Event Log
I'm using ALL sources that come with the program
...and have disabled windows event logging since years... I really can't remember how to enable and where to look for those errors.
Run services.msc and re-start "Windows Event Log". Not sure why you'd ever want to disable this though. It's a pretty important part of the OS, and I'd think it would cause problems if it were disabled.

Then you can see the events by running Event Viewer.
Title: Re: Album Art Downloader XUI
Post by: Sea Monkey on 2020-06-25 01:12:43
I don't anticipate that you'd want to support or troubleshoot use of AAD via wine in Linux, but for what it's worth, this is what I get when using the attached version under a 64-bit prefix of wine with .NET 7.2 installed.
Thanks for reporting this, it's always good to have more information. I wonder, do any WPF based applications run on your setup? The stack trace indicates that it's coming from deep in the internals of WPF so I doubt there is anything I can do to affect it one way or another, but if there's an working example I can compare with then maybe I can figure something out.

Alex

I got it working!  I used the following link to do so, though I didn't follow it verbatim:

https://www.reddit.com/r/linux4noobs/comments/firqs9/getting_windows_wpf_applications_to_run_with_wine/

For anyone else attempting to do the same thing, here's the gist of it:

- Run winetricks
   - Install .NET 4.7.2 (This will work backwards through previous versions that need to be installed first and likely throw up a lot of warning messages.  Don't worry.)
   - Install dxvk (latest)
   - Install d3dcompiler_47
- From the terminal,
   wine reg add "HKCU\\SOFTWARE\\Microsoft\\Avalon.Graphics" /v DisableHWAcceleration /t REG_DWORD /d 1 /f


Not all of that may be necessary, but I figured I will probably want to tackle other D3D applications at some point.

Probably best to just give AAD its own prefix.  This makes things simpler.  When prompted, DON'T install Mono.

Code: [Select]
export WINEPREFIX=$HOME/.wineAAD
winetricks -q dotnet48
wine reg ADD 'HKCU\Software\Wine\DllOverrides' '/f' '/v' 'd3d9' '/t' 'REG_SZ' '/d' 'native'
wine AlbumArtDownloaderXUI-1.05.exe

For the automatically generated menu icon to work, I had to modify it.

Code: [Select]
[Desktop Entry]
Name=Album Art Downloader
Exec=env WINEPREFIX="/home/seamonkey/.wineAAD" wine C:\\\\windows\\\\command\\\\start.exe /Unix /home/seamonkey/.wineAAD/dosdevices/c:/users/seamonkey/Start\\ Menu/Programs/Album\\ Art\\ Downloader/Album\\ Art\\ Downloader.lnk
Type=Application
StartupNotify=true
Path=/home/seamonkey/.wineAAD/dosdevices/c:/Program Files/AlbumArtDownloader
Icon=50B1_AlbumArt.0
StartupWMClass=albumart.exe
Title: Re: Album Art Downloader XUI
Post by: Roendi on 2020-06-26 11:26:07
HI

I love your Album Art Downloader very much. For me it’s very useful. I have a Feature Request.

Under Sources: You can only Select all or individually. A secondary was very helpful. Preferred Sources.

On the Settings you can say witch your preferred Sources you have. Normally I have only 2 Downloader.

If you can implement this you make me very happy.

Thanks a lot and sorry for my bad English

Kind Regards

René
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-06-26 19:26:49
Click the ... button on the source and check the "Search first", this will then be a preferred source. The first time you click search, all the "Search first" sources will be searched, then if you click it again any other selected sources will be searched.
Title: Re: Album Art Downloader XUI
Post by: Mikko_H on 2020-07-03 14:22:01
Code: [Select]
export WINEPREFIX=$HOME/.wineAAD
winetricks -q dotnet48
wine reg ADD 'HKCU\Software\Wine\DllOverrides' '/f' '/v' 'd3d9' '/t' 'REG_SZ' '/d' 'native'
wine AlbumArtDownloaderXUI-1.05.exe
Thanks, AADL is one of the last programs I boot Win7 VM for.

Do the source scripts work for you though? I tried adding every script but getting search results only from Deezer, 45cat and ArkivMusic. Most sources stop searching after a second. AllCdCover, CoverLib and HMV Canada keep searching but don't find anything.
Title: Re: Album Art Downloader XUI
Post by: marc2k3 on 2020-07-03 15:51:35
I suspect a lack of modern https support in WINE will be the issue there. It's stuck in the dark ages and any applications that use windows APIs are going to fail. Only applications using 3rd party SSL libraries will work.
Title: Re: Album Art Downloader XUI
Post by: kode54 on 2020-07-04 05:06:42
Please don't set d3d9.dll to native. Please do install DXVK instead. If there's a bug with DXVK, better report it.
Title: Re: Album Art Downloader XUI
Post by: Mikko_H on 2020-07-05 11:53:49
Do the source scripts work for you though? I tried adding every script but getting search results only from Deezer, 45cat and ArkivMusic. Most sources stop searching after a second. AllCdCover, CoverLib and HMV Canada keep searching but don't find anything.
In case someone else is having the same problem, I was able to resolve it by installing this package:
https://www.archlinux.org/packages/multilib/x86_64/lib32-gtk3/
Title: Re: Album Art Downloader XUI
Post by: Sea Monkey on 2020-07-10 23:00:57
Please don't set d3d9.dll to native. Please do install DXVK instead. If there's a bug with DXVK, better report it.

Using dxvk-1.7 with NVIDIA-Linux-x86_64-450.57, I get

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 1.0.5.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (32 bit)

System.Runtime.InteropServices.COMException (0x88980406): Exception from HRESULT: 0x88980406
   at System.Windows.Media.Composition.DUCE.Channel.SyncFlush()
   at System.Windows.Interop.HwndTarget.UpdateWindowSettings(Boolean enableRenderTarget, Nullable`1 channelSet)
   at System.Windows.Interop.HwndTarget.UpdateWindowPos(IntPtr lParam)
   at System.Windows.Interop.HwndTarget.HandleMessage(WindowMessage msg, IntPtr wparam, IntPtr lparam)
   at System.Windows.Interop.HwndSource.HwndTargetFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.IntGetMessageW(MSG& msg, HandleRef hWnd, Int32 uMsgFilterMin, Int32 uMsgFilterMax)
   at MS.Win32.UnsafeNativeMethods.GetMessageW(MSG& msg, HandleRef hWnd, Int32 uMsgFilterMin, Int32 uMsgFilterMax)
   at System.Windows.Threading.Dispatcher.GetMessage(MSG& msg, IntPtr hwnd, Int32 minMessage, Int32 maxMessage)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)

After running

Code: [Select]
winetricks -q d3dcompiler_47


it runs, but displays mostly black and occasionally flashes the proper display or parts of it. It's not usable in this state, so I did

Code: [Select]
wine reg add "HKCU\\SOFTWARE\\Microsoft\\Avalon.Graphics" /v DisableHWAcceleration /t REG_DWORD /d 1 /f

Which returns it to a usable state.  Native d3d works just fine.
Title: Re: Album Art Downloader XUI
Post by: BoltThrower on 2020-07-20 20:24:07
The Fanart.tv script still appeals to be broken, which is very odd because I used to be able to make it work if I set it to search first and then clicked on the individual albums in the browser. But I'm on a new install and neither the original script or the fixed one seems to be working.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-07-26 09:01:42
The Fanart.tv script still appeals to be broken
Fanart.tv have made changes to their api, I've patched up Mordred's script to work again: fanarttv.boo (http://album-art.sourceforge.net/scripts/fanarttv.boo)
Title: Re: Album Art Downloader XUI
Post by: BoltThrower on 2020-07-29 22:21:23
The Fanart.tv script still appeals to be broken
Fanart.tv have made changes to their api, I've patched up Mordred's script to work again: fanarttv.boo (http://album-art.sourceforge.net/scripts/fanarttv.boo)
thanks so much for your continued support.
Title: Re: Album Art Downloader XUI
Post by: thyristor44 on 2020-08-23 18:23:34
Hello
Is there a version of Album Art Downloader that will work with xp 32 bit that has net framework 3.5 on. I am having no luck with the latest and net framework 4.7.2.
Any help appreciated.
Thanks
thyristor44
Title: Re: Album Art Downloader XUI
Post by: includemeout on 2020-08-23 18:53:25
AFAIK you gonna have to go for much earlier releases - prrhaps from the late noughties, if memory serves me well.

I don't know if, due to it still being an "aliveware", it doesn't meet any criteria at Roberto's rarewares.org, but there's definitely nothing in there.

Github sourceforge, perhaps?




Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-08-23 19:07:20
Hello
Is there a version of Album Art Downloader that will work with xp 32 bit that has net framework 3.5 on. I am having no luck with the latest and net framework 4.7.2.
Any help appreciated.
Thanks
thyristor44
The last version for .net framework 3.5 was 1.03. I can't say whether it will work with Windows XP, but it might. If not, you'll just have to try earlier versions until you find one that works, I haven't used or tested with XP in a very long time.

1.03 is at https://sourceforge.net/projects/album-art/files/album-art-xui/AlbumArtDownloaderXUI-1.01.exe/download

All previous versions can be found at https://sourceforge.net/projects/album-art/files/album-art-xui/
Title: Re: Album Art Downloader XUI
Post by: thyristor44 on 2020-08-23 20:17:16
Thanks Alex, 103 worked perfectly on xp.
At least I am back in business.

Title: Re: Album Art Downloader XUI
Post by: Anakunda on 2020-09-04 15:03:38
There are app crushes when enabled Bandcamp script, verified it on ON/OFF states.

Also an update for qobuz.boo:

Code: [Select]
			// See if max size jpg is available
if CheckResponse(urlBase + "_org.jpg"):
fullSizeImageUrl = urlBase + "_org.jpg"
elif CheckResponse(urlBase + "_max.jpg"):
fullSizeImageUrl = urlBase + "_max.jpg"
else:
..........

Where can I submit the crushdumps?
Title: Re: Album Art Downloader XUI
Post by: luezuve on 2020-09-29 04:06:28
It seems fanart has stopped working again. Is anybody else having that problem?
Title: Re: Album Art Downloader XUI
Post by: luezuve on 2020-10-04 00:38:41
It seems fanart has stopped working again. Is anybody else having that problem?

Nobody is having problems downloading from fanart.tv right now? Is there somewhere I can see where fanart is failing? Like a log or something?

I am using the latest fanart script provided here and I believe implemented in v 1.05
Title: Re: Album Art Downloader XUI
Post by: Zhiro90 on 2020-10-08 03:06:23
Hello. I can't get results from the last fm ARTIST script. Is it working for anyone?
Title: Re: Album Art Downloader XUI
Post by: DRata on 2020-10-10 11:41:16
luezuve, I get fanart.tv results sporadically -- i think availability depends on the album.

Google Play Music (which was one of my favored sources) is no longer returning results for me, so we might need a new script for its pseudo-replacement, YouTube Music. Alex, if I find time I'll give that a shot this weekend.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-10-11 09:34:59
Hello. I can't get results from the last fm ARTIST script. Is it working for anyone?
Hi, I've updated lastfm-artist.boo (http://album-art.sourceforge.net/scripts/lastfm-artist.boo), should be working now.
Title: Re: Album Art Downloader XUI
Post by: sockeye on 2020-10-29 13:44:12
Hi, new user here. Thanks for the great project.

I can't get Discogs to work. It churns and comes back with nothing for every single album. Doesn't Discogs require an authentication key? I know that I have to create one when I do this in the program Mp3Tag.

Amazon isn't working either, but that appears to be a known issue.

Thanks in advance for any tips!

John
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-10-31 08:34:29
Discogs 0.20 is working for me. If you give me the name of the album you were searching for I can try that. It does not require an authentication key.

Amazon I think are still doing the bot protection and captcha thing, so it won't work for the moment. Unless anyone else thinks they can get a script working for it.
Title: Re: Album Art Downloader XUI
Post by: Lynx_TWO on 2020-10-31 14:55:58
Hey!  I've been using this for a while now and it's been amazing especially for albums that are a bit rarer.  I do have a question though...

I have a process where I download the album covers to a folder, in this case, "C:\_Album Covers_" which is then sorted by file dimension as a folder name, then the image is saved by the "%artist% - %album%". 

The minimum dimension in options is set to 1000 px.

Example of the downloaded file:
Code: [Select]
C:\_Album Covers_\1200x1200\3 Doors Down - The Better Life (Deluxe Edition).jpg

After I get enough albums downloaded, I then batch process each image with Topaz Labs GigaPixel to denoise, clean, remove JPEG artifacts, and upscale the image using Ai (if you haven't tried it, do it - the results are impressive) to a 4000x4000 16-bit TIF.

I then batch process these large 16-bit TIF files using RIOT (Radical Image Compressor Tool) to downsize and compress each image to the following sizes:

1500 px JPG, Chroma Subsampling = 4:4:4, 5MB maximum - saved to "C:\_CD Collection_\_COVERS_\1500px"
1400 px JPG, Chroma Subsampling = 4:4:4, 500KB maximum - saved to "C:\_CD Collection_\_COVERS_\1400px"
600 px JPG, Chroma Subsampling = 4:4:4, 200KB maximum - saved to "C:\_CD Collection_\_COVERS_\600px"

Finally, I batch all those results using lossless JPG optimization using FileOptimizer (https://sourceforge.net/projects/nikkhokkho/files/FileOptimizer/)

Is it a bit OCD?  Probably, but it's not bad when you're able to batch-process.  The steps I'm missing are below:

Now, what I'd like to do is tell Album Art Downloader to automatically search a pre-set local folder first, and if there is a matching file already, stop searching altogether and copy (not move) that file to the matching album folder, prompting to overwrite if a file with the same name already exists.  So, for example, in this case:

The finished album art is in the following pre-set local folder:

Code: [Select]
C:\_CD Collection_\_COVERS_\1400px\3 Doors Down - The Better Life (Deluxe Edition).jpg

Album Art Downloader sees there is a folder here:

Code: [Select]
C:\_CD Collection_\3 Doors Down - The Better Life (Deluxe Edition)\

Album Art Downloader copies the file:

Code: [Select]
C:\_CD Collection_\_COVERS_\1400px\3 Doors Down - The Better Life (Deluxe Edition).jpg

to:

Code: [Select]
C:\_CD Collection_\3 Doors Down - The Better Life (Deluxe Edition)\3 Doors Down - The Better Life (Deluxe Edition).jpg

NOW!  What would be ideal is if there was an option to copy the 1500px large image as the same filename, the 1400px optimized image as "cover.jpg", and the 600px image as "folder.jpg"

So:

Code: [Select]
C:\_CD Collection_\_COVERS_\1500px\3 Doors Down - The Better Life (Deluxe Edition).jpg

is copied to:

Code: [Select]
C:\_CD Collection_\3 Doors Down - The Better Life (Deluxe Edition)\3 Doors Down - The Better Life (Deluxe Edition).jpg

then,

Code: [Select]
C:\_CD Collection_\_COVERS_\1400px\3 Doors Down - The Better Life (Deluxe Edition).jpg

is copied to:

Code: [Select]
C:\_CD Collection_\3 Doors Down - The Better Life (Deluxe Edition)\cover.jpg

and finally,

Code: [Select]
C:\_CD Collection_\_COVERS_\1400px\3 Doors Down - The Better Life (Deluxe Edition).jpg

is copied to:

Code: [Select]
C:\_CD Collection_\3 Doors Down - The Better Life (Deluxe Edition)\folder.jpg

Of course, if there is already a tool that can do this, please let me know :)

Thanks as always for this incredibly helpful piece of software!

-Dan
Title: Re: Album Art Downloader XUI
Post by: sockeye on 2020-11-05 14:35:41
Aha! I found the issue with my Discogs searches. In search Options > Filter by Cover Types, I had only "Front" checked. Adding a check on "Unknown" fixes the issue: it seems that all Discogs art is characterized this way.

Thanks again for this great tool! Kind of amazing how much time this is saving me yet how much time it still takes across ~65k audio files, some fraction of which lack covers.

Discogs 0.20 is working for me. If you give me the name of the album you were searching for I can try that. It does not require an authentication key.

Amazon I think are still doing the bot protection and captcha thing, so it won't work for the moment. Unless anyone else thinks they can get a script working for it.

Aha! I founf the
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2020-11-05 17:18:52
Now, what I'd like to do is tell Album Art Downloader to automatically search a pre-set local folder first, and if there is a matching file already, stop searching altogether and copy (not move) that file to the matching album folder, prompting to overwrite if a file with the same name already exists.
That might be possible. In the Sources list, find "Local Files", and click the ... button to expand the settings for it. In the Path to find images, you will want something like
Code: [Select]
C:\_CD Collection_\_COVERS_\1400px\%artist% - %album%.jpg
Also check "Search First" so that if there are any results from this source, it won't search other sources unless you click the Search button a second time.

You will still have to click the Save button in the search results to actually copy it to the correct destination, the same as you do for any other source.

For your additional behaviour of copying multiple files at different resolutions, I don't see any easy way to make that happen, sorry! For that sort of complexity you are probably looking at writing some sort of batch script yourself, I doubt there's any tool that happens to support exactly that workflow.
Title: Re: Album Art Downloader XUI
Post by: jonm on 2020-12-02 01:32:30
I am unable to find any instructions on how to use AAD. I would much appreciate if you can point me to where they can be found.
Title: Re: Album Art Downloader XUI
Post by: cassel on 2021-01-24 13:40:42
Discogs .20 is searching very slowly. Started about Jan 2, 2020. I though it was a temporary issue so held off asking if anybody else was experiencing any problems.
Title: Re: Album Art Downloader XUI
Post by: Hutchinson Hatch on 2021-02-09 07:10:24
Fanart and Discogs seem both not be working anymore. Maybe Fanart did some changes to the API again?
Title: Re: Album Art Downloader XUI
Post by: jod773 on 2021-02-15 11:20:11
I confirm that fanart.tv script is broken again. I can't figure out why though, I tried to update the script myself, I removed the "search" prefix from musicbrainz because that one seems not to work, but even that didn't fix it.

Either there's a problem with the script while searching for the musicbrainz ID or I just don't know what I'm doing. Even tried the update in this thread from last July but still no dice. Changing the settings all over doesn't help either.

Testing the API itself it seems to work so I don't know why the results aren't showing up in AAD. Hoping someone here could help. Thanks!

Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-02-15 19:40:23
I've updated discogs (v0.21) and Mordred's fanarttv (0.7), they should work again now. @jod773 the problem with fanarttv wasn't just the removal of search (although that was the correct first step), it was also that Musicbrainz was forbidding access without providing a meaningful identifying useragent.
Title: Re: Album Art Downloader XUI
Post by: jod773 on 2021-02-16 14:43:49
it was also that Musicbrainz was forbidding access without providing a meaningful identifying useragent.
Hey! Thanks for clearing that up :) I really thought I did everything but I couldn't think of a way to test the script and see where the error happens.

Thank you for the fix!
Title: Re: Album Art Downloader XUI
Post by: mookieproof on 2021-02-17 23:24:01
Thanks, Alex!
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2021-03-08 04:55:16
Hey Alex, I just discovered today that discogs actually stores images greater than 600x600. For example, this is what discogs returns:
https://img.discogs.com/cTvdhiSkSuFI2Xq_oMJjzwTFLp4=/fit-in/600x609/filters:strip_icc():format(jpeg):mode_rgb():quality(90)/discogs-images/R-629210-1495380053-6160.jpeg.jpg

And this is the full size image:
https://www.discogs.com/image/R-629210-1495380053-6160.jpeg

You'll notice all you need to do from the original image string is:
Code: [Select]
for image in images:
fullImageMatch = Regex("discogs-images/(?<filename>.*jpeg).jpg", RegexOptions.IgnoreCase).Match(image.full)
if fullImageMatch.Success:
imageName = "https://discogs.com/image/" + fullImageMatch.Groups["filename"].Value

However, when I updated discogs.boo to actually implement this, when attempting to retrieve the fullsize image, everything it returns is max 300x300. I can't figure out what's actually going wrong here and was hoping maybe you had some ideas. Being able to get images larger than 600x600 from discogs would be huge.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-03-08 17:24:59
Try https://www.discogs.com instead of just https://discogs.com

I've attached a quick test which works for me, but discogs does server-side analytics of useragent and headers and stuff, and if they think you aren't a browser, will serve you the small image size.
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2021-03-08 19:09:07
Try https://www.discogs.com instead of just https://discogs.com

I've attached a quick test which works for me, but discogs does server-side analytics of useragent and headers and stuff, and if they think you aren't a browser, will serve you the small image size.
That worked! I had tried changing the UA to resemble a browser and no dice, but hadn't thought about adding www.

BTW, some images are actually smaller than the 600x600 default that discogs serves, them so if you plan to add this to the official version, a better check might be:
Code: [Select]
if (fullImageMatch.Success and (image.width >= 599 or image.height >= 599)):
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-03-08 19:29:13
BTW, some images are actually smaller than the 600x600 default that discogs serves, them so if you plan to add this to the official version, a better check might be:
Code: [Select]
if (fullImageMatch.Success and (image.width >= 599 or image.height >= 599)):
Hmm, I'm wondering if that might be because the originals are smaller than 600x600, and they just get resized to serve at 600x600? If that's the case, I'd rather have the original at whatever size it is.
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2021-03-08 19:49:34
Hmm, I'm wondering if that might be because the originals are smaller than 600x600, and they just get resized to serve at 600x600? If that's the case, I'd rather have the original at whatever size it is.
That's exactly what it is, and you have a fair point. It's a decent resizing algo they're using (as in, I've never noticed that something was OBVIOUSLY upscaled) but certainly photoshop could do a better job.
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2021-03-10 16:00:25
Okay, so I did a little more playing around. If you use curl's UA, discogs starts to return 300x300 max size images. With a browser UA they don't appear to ever stop sending fullsize if they exist. I also realized that if the image is less than 600 in width, it's never scaled up to 600. So I added the width/height >600 check back in. No since hitting a non-public end point if it's going to return the same image as before.

Try this out and let me know if you encounter any issues.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-03-10 18:39:57
Thanks for that. I've just changed the UA to match the one used for downloading the full sized images (from util.boo GetPageStream with useFirefoxHeaders) - probably best if all the requests have the same UA.

I've uploaded this now as v0.22, if anyone notices any issues then please do report them as usual.
Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-11 18:46:04
11 MAR 21

Win 7 x64,  just did the March updates as offered by WU [w7x64 rollup and .net 4.8 update]

Now Album Art DL does not diaplay any art, the "frames" are just grey.  If I click the disk icon to save the file it saves fine and can be displayed in irfanview fine, so the files are fine, AA-DL is having issues displaying them on screen.

I assumed it was the .net updates.  did a complete uninstall of  dotNet and then a clean reinstall of 4.8 - same issue.

then took WU offered update [again] and still same issue.  WU says I am up to date.

So maybe just the W7 update did it, not dotNet?  not sure, and didn't roll back [no restore pt - dumb]

Anyway, thought I'd put this out there, anyome else see this issue today???

Thanks...


Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-11 19:14:57
11 MAR 21   

    Part 2:    I did figure out how to uninstall  the March W7 Rollup, KB5000841, and it backed my system to around JAN 2021  time frame.  [it was fully up to date thru Feb].

   AA-DL  is now working just fine again  -- it is the W7 Rollup and NOT dotNet update. 

   SO BE  FORE-WARNED!!!    W7 update for March is not ready for public consumption!!!    Never be a pioneer !
Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-11 20:26:05
11 MAR 21

now Part 3...

applied the Feb W7 Rollup, my system is now back to where it was prior to  this morning, with the addition of March dotNet 4.8 update,  and AA-DL is working just fine.  Confirmation that W7x64 March 2021 Rollup was the culprit.

Thanks for listening.... 

I hope someone learns from this experience, I know I did - never install updates without waiting several weeks !!

-=Paul=-
Title: Re: Album Art Downloader XUI
Post by: sveakul on 2021-03-12 20:42:06
javacat:  you might try changing the DPI settings in the Properties/Compatibility/Change High DPI Settings tab of AlbumArt.exe to "Scaling performed by System" and see if that fixes your problem.
Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-13 16:37:11
Thanks, but on my W7 setup the compatability tab doesn't have that BUTTON,  just the older check box to "disable display scaling on high dpi settings".   And as I've reverted things I can't test that now.  I will not be trying the March Rollup again for many weeks and hope it will eventually be resolved. 
Title: Re: Album Art Downloader XUI
Post by: kode54 on 2021-03-13 22:41:14
Nope, sorry. That feature requires Windows 10.
Title: Re: Album Art Downloader XUI
Post by: boogiepopfred on 2021-03-21 19:47:30
Help?
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2021-03-21 21:16:53
Help?
You probably don't have permission to write to that directory because your user account isn't the "owner".
Title: Re: Album Art Downloader XUI
Post by: MordredKLB on 2021-03-22 07:29:03
Thanks for that. I've just changed the UA to match the one used for downloading the full sized images (from util.boo GetPageStream with useFirefoxHeaders) - probably best if all the requests have the same UA.

I've uploaded this now as v0.22, if anyone notices any issues then please do report them as usual.
Apparently 5 days ago discogs pulled the plug on the ability to get high-res artwork through this method (wondering if it was due to increased bandwidth from this script? Timing seems suspect). It seems unlikely to come back in the near future so probably need to roll back the source to what it was for 0.21.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-03-22 08:00:32
That's a shame. I've put 0.21 back again, thanks for the heads-up
Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-22 17:12:22
Alex,
  I posted 10 days ago about an issue with the Win 7x64 March 2021 Rollup causing a problem with AADL displaying images.  Only grey boxes were displayed in their place.  

   Out of curiosity, has anyone else reported this issue to you?  I've looked around the web and I seem to be alone in having this problem, which is weird.  uninstalling the rollup definately brought image display back, I'm confident it was something in the rollup that the dotNet framework was built upon, my guess is ieframe.dll dated 12feb21, or another dll with that date.

  [FWIW I did an uninstall of the rollup itself, not a restore point recover, so I think it was the rollup and not something else].

Thanks...  -=PAUL=-
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-03-22 18:45:12
No, no one else has reported the issue. It's quite possible you are the only person using AAD on Windows 7, though! To be honest I didn't think they were still putting out updates for that.

As Windows 7 is EOL, support for it can best be described as "probably works". If anyone else reports grey boxes on Win7, though, I shall direct them to your post and advise uninstalling the rollup.
Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-22 21:53:08
ok, thanks Alex.

FWIW, as of Jan 2021 there are at least 100 million PCs still running Windows 7, surely some of them use Album Art Downloader, it's just too good at what it does....

  https://www.theverge.com/2021/1/6/22217052/microsoft-windows-7-109-million-pcs-usage-stats-analytics

Title: Re: Album Art Downloader XUI
Post by: kode54 on 2021-03-22 23:42:11
Good, good. You volunteer to test and develop on Windows 7, then.
Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-23 13:32:26
it looks like MS has noticed this and has a fix now:

  https://support.microsoft.com/en-us/topic/kb5001639-march-9-2021-update-causes-windows-7-sp1-and-server-2008-r2-sp1-to-not-print-graphical-content-986cf8a1-7da8-43c2-b7e6-314b4e0a6e5b

Title: Re: Album Art Downloader XUI
Post by: javacat on 2021-03-23 14:24:29
Well, no joy here. 

I did confirm again that KB5000841 DOES cause the issue [jpg will not display, tho png will],

but  KB5001639 DOES NOT fix it.

wating on MS to get it together....
Title: Re: Album Art Downloader XUI
Post by: iammike on 2021-04-23 05:23:52
Discogs seems to have stopped working with AAD

Is there a new script available?

TiA
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-04-25 12:04:05
Discogs seems to have stopped working with AAD
Seems they are blocking by user agent. I've uploaded a v0.23 which identifies itself appending your machine name to the UA string, so hopefully Discogs will treat each user as an individual and block or allow them based on their own usage rather than as the application in general.

If it fails again, try changing the line starting request.UserAgent to, well, anything else. Your guess is as good as mine!
Title: Re: Album Art Downloader XUI
Post by: iammike on 2021-04-26 02:55:21
Discogs seems to have stopped working with AAD
Seems they are blocking by user agent. I've uploaded a v0.23 which identifies itself appending your machine name to the UA string, so hopefully Discogs will treat each user as an individual and block or allow them based on their own usage rather than as the application in general.

If it fails again, try changing the line starting request.UserAgent to, well, anything else. Your guess is as good as mine!

Just tested it and it works. Really appreciated!
Title: Re: Album Art Downloader XUI
Post by: mookieproof on 2021-04-28 01:31:03
awesome, thanks Alex!
Title: Re: Album Art Downloader XUI
Post by: Mataglap on 2021-05-12 00:32:49
Hi everyone, I have been using older versions of all my audio tools for years now and have reached a point where I need to upgrade everything.

How does the current version of AAD integrate with fb2k?  (I've been using the COM automation server, and I seem to recall this was deprecated even way long ago but "it worked for me".)
Title: Re: Album Art Downloader XUI
Post by: I.M. on 2021-06-04 00:29:54
Hi, "coveralia" plugin is not longer working
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-06-05 19:02:42
Hi, "coveralia" plugin is not longer working
Thanks for reporting this. Should be fixed now: coveralia.boo (http://album-art.sourceforge.net/scripts/coveralia.boo)
Title: Re: Album Art Downloader XUI
Post by: I.M. on 2021-06-06 16:22:09
Thanks for reporting this. Should be fixed now: coveralia.boo (http://album-art.sourceforge.net/scripts/coveralia.boo)

Working again! Thanks
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2021-06-15 17:54:31
Hi,

just want to mention, that the bandcamp.boo fails to do its work finding matching covers from the site.

check the screenshots. happens to almost all runs I do.




no covers, present on the webpages are shown.

can this be fixed? or is it just me?

and a big thank you for this very useful piece of code! helped us all the years! easy to use, speedy and no useless clutter!



Title: Re: Album Art Downloader XUI
Post by: fuffi on 2021-06-15 18:00:45
How does the current version of AAD integrate with fb2k?
nicely!
I use it with the foo_run component. no fancy stuff needed.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-06-15 19:18:04
bandcamp.boo fails to do its work finding matching covers from the site.
Unfortunately it looks like Bandcamp's search is just not very good. Album Art Downloader XUI will do a search on the site like: https://bandcamp.com/search?q=%22Night+Driver%22+%22Spectravision%22 and the results that I see there match your screenshot fairly well. As to why a search for "Night Driver" "Spectravision" doesn't return the album Spectravision by Night Driver as the first result, that's something you will have to take up with Bandcamp! I do note that it is better at searching album titles than artist names, so you might try just omitting the artist when you search?
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2021-06-16 18:11:05
Unfortunately it looks like Bandcamp's search is just not very good.
U're right, I could have checked the bandcamp search myself before, which I did not, because I assumed it will work. How wrong I was! Sorry! The bandcamp search is underwhelming.
 I try my luck and write a mail to them....
you might try just omitting the artist when you search?
That worked much better, thanks for the hint!
Title: Re: Album Art Downloader XUI
Post by: Sea Monkey on 2021-08-22 02:29:21
This is just a problem caused by a regression in wine, but I'll share here just in case it's useful.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 1.0.5.0, running on Microsoft Windows NT 6.1.7601 Service Pack 1 (64 bit)

System.DivideByZeroException: Attempted to divide by zero.
   at MS.Internal.AppModel.IFileDialog.Show(IntPtr parent)
   at Microsoft.Win32.FileDialog.RunVistaDialog(IntPtr hwndOwner)
   at Microsoft.Win32.CommonDialog.ShowDialog(Window owner)
   at AlbumArtDownloader.AlbumArt.SaveAs(Window dialogOwner)
   at AlbumArtDownloader.ArtSearchWindow.SaveAsExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-08-22 08:54:18
Thanks, but it looks like it's coming from inside the Windows common file "Save" window, not something under my control. You can probably work around it by setting the path to save as (just click on it to edit) without using Save As, and then just clicking Save.
Title: Re: Album Art Downloader XUI
Post by: Sea Monkey on 2021-08-22 09:06:29
Thanks, but it looks like it's coming from inside the Windows common file "Save" window, not something under my control. You can probably work around it by setting the path to save as (just click on it to edit) without using Save As, and then just clicking Save.

Perfect!  Thank you!
Title: Re: Album Art Downloader XUI
Post by: privatesir on 2021-11-21 05:42:48
Is there any chance you could add PNG as the filetype to download from iTunes and Deezer?
Thanks.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-11-21 08:51:47
Is there any chance you could add PNG as the filetype to download from iTunes and Deezer?
I don't see any option on Deezer or iTunes for downloading png files instead of jpg. iTunes is tricky in many ways, so lets start with Deezer; can you construct a URL for an album of your choice that downloads a png rather than a jpg?
Title: Re: Album Art Downloader XUI
Post by: privatesir on 2021-11-22 01:12:25
Is there any chance you could add PNG as the filetype to download from iTunes and Deezer?
I don't see any option on Deezer or iTunes for downloading png files instead of jpg. iTunes is tricky in many ways, so lets start with Deezer; can you construct a URL for an album of your choice that downloads a png rather than a jpg?

For Deezer the app itself already downloads PNG files I didn't realized when I wrote the comment, for iTunes just replacing the JPG extension for PNG works.
For example:
https://is2-ssl.mzstatic.com/image/thumb/Music124/v4/b2/d4/d3/b2d4d377-849e-3ed1-d72c-14c90fc962d8/source/9999x9999-100.jpg
https://is2-ssl.mzstatic.com/image/thumb/Music124/v4/b2/d4/d3/b2d4d377-849e-3ed1-d72c-14c90fc962d8/source/9999x9999-100.png

https://is5-ssl.mzstatic.com/image/thumb/Music115/v4/0b/51/38/0b5138cf-80b6-6a3b-b760-1779f1ff7398/source/9999x9999-100.jpg
https://is5-ssl.mzstatic.com/image/thumb/Music115/v4/0b/51/38/0b5138cf-80b6-6a3b-b760-1779f1ff7398/source/9999x9999-100.png

And the downloaded PNG files aren't just renamed JPG files, they are real PNG files.

Thanks.

Title: Re: Album Art Downloader XUI
Post by: kode54 on 2021-11-22 06:53:06
And both of the examples you provided appear to have all the same JPEG artifacts as the JPEG versions, which would indicate that they were converted from JPEGs.
Title: Re: Album Art Downloader XUI
Post by: privatesir on 2021-11-22 20:02:40
That's something we can't be certain about. That could be for the two examples I gave above but not necessarily apply to every release. As far as getting the PNG file, it can be done.
The same can be said for Deezer, yet the app downloads the PNG versions of the artworks. The same can also be said for resolutions, there are LOTs of albums on iTunes (and Deezer) that have high res front covers but they are just re-sized low quality ones, and that doesn't apply to every album.
I'm not (trying to) discussing the quality of the PNG files, I was only asking for an option to download them.

Thanks.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2021-11-22 21:00:12
As kode54 points out, where a png file is simply an auto-converted jpg file then I don't want Album Art Downloader to request png specifically, there's no benefit to it. It's a bigger file size of the exact same image. But, if that's something you really want, you can just edit the iTunes.boo file and replace where it says "jpg" with "png".

If you do happen across an example where the png file is not identical to the jpg then do let me know, I can see if there's any way to automatically detect that case. Otherwise, I prefer to keep it as the original jpg.
Title: Re: Album Art Downloader XUI
Post by: privatesir on 2021-11-23 02:27:51
Thanks, I didn't know I just had to edit the boo file.
Title: Re: Album Art Downloader XUI
Post by: Mikko_H on 2021-12-12 09:24:52
Anyone else getting black screen with wine 6.23? Downgraded to 6.22 for now which works.

Title: Re: Album Art Downloader XUI
Post by: Sukari on 2021-12-25 16:32:26
Anyone else not getting any search results from fanart.tv. It seems not finding anything even it worked well some time ago.
Any help? Thanks
Title: Re: Album Art Downloader XUI
Post by: mookieproof on 2021-12-25 19:54:52
yeah, there appear to have been some changes to the fanart.tv site
Title: Re: Album Art Downloader XUI
Post by: c0der on 2022-01-28 07:38:13
Hello guys.

I would like to use the command line to automatically download cover arts.
I am able to get a couple correct results but I have to save it manually as the UI window opens up and wants me to select and save one of the images found. As far as I have tested it manually, I would be fine picking the first one of the list.

Is there any way to do this?

Best regards

EDIT:
Nevermind, found a solution. Here's an example call I make to do this:
"C:\Program Files\AlbumArtDownloader\aad.exe" /ar "Skindred" /al "Babylon" /p "XYZ:\MyMusicPath\Skindred\Babylon\folder.%extension%" /s "iTunes,Deezer" /mn 500 /mx 1400 /ma 1 /seq 1 /t f
Title: Re: Album Art Downloader XUI
Post by: dpr on 2022-02-17 09:22:57
How do I save the auto-downloaded files?
Downloaded is saved. They will be saved according to the "Specify path to find images" box in the Options for the browser. By default, this will save them as Folder.jpg, but you can change that to whatever you want. The path is relative to the path of the album the art is for.

the problem is that I want to save multiple files - the folder / cover, the back of the cd, the medium etc, all automatically using the 'type' of the image as the name - for example https://musicbrainz.org/release/58d54b37-e37d-3b53-87dd-09cc1590ed79/cover-art
Title: Re: Album Art Downloader XUI
Post by: billyjk on 2022-02-18 14:10:04
Hi,
New to this app.  I figured out how to get new artwork individually - but I'd like to have the app go through my entire collection with the same basic settings:

- Grab the first result, and just put it in the folder
- Use "Folder" as the file name
- Use jpg as the file format

I find that this works for me for my FLACS and mp3's, using FooBar as my media app.

Any help, guidance, direction with this would be appreciated!
Thanks,
-bjk
Title: Re: Album Art Downloader XUI
Post by: billyjk on 2022-02-18 16:01:00
Hi,
New to this app.  I figured out how to get new artwork individually - but I'd like to have the app go through my entire collection with the same basic settings:

- Grab the first result, and just put it in the folder
- Use "Folder" as the file name
- Use jpg as the file format

I find that this works for me for my FLACS and mp3's, using FooBar as my media app.

Any help, guidance, direction with this would be appreciated!
Thanks,
-bjk

Never mind.  Figured it out!
Title: Re: Album Art Downloader XUI
Post by: RAJCChi on 2022-02-27 13:14:54
Hey all. New to the program and it's great. Really. Makes my ADHD/Obsessive brain happy to find a tool that makes fixing my album art easier.

Anyway, I was wondering if there was syntax for the "Save images to:" line that would move the word "the" in a band's name to after the name with a comma? Ex: "The Gossip" would become "Gossip, The". I did look in the forum and was not successful or if I did see it, I didn't recognize it. Thanks for the help in advance.
Title: Re: Album Art Downloader XUI
Post by: DRata on 2022-03-08 19:44:58
Anyway, I was wondering if there was syntax for the "Save images to:" line that would move the word "the" in a band's name to after the name with a comma? Ex: "The Gossip" would become "Gossip, The". I did look in the forum and was not successful or if I did see it, I didn't recognize it. Thanks for the help in advance.

I don't know of any option to do that within the AAD program itself. I usually just search for the band name without "The" and avoid that problem entirely. Then again I'm only semi-obsessive and don't bother with whether the artist's proper name contains "The", at least for album art searching purposes. When it comes to tagging the tracks, I do try to use the artist, album, and track names as they are printed on the album.
Title: Re: Album Art Downloader XUI
Post by: DRata on 2022-03-08 19:53:06
Alex, the Discogs script is no longer working for me. I tried debugging, and it looks like the format of the JSON for images in the release pages changed. The image info needed is no longer in the "release_schema" element, but rather in a "dsdata" element. If you need more detail or want me to attempt a fix, then send me a DM.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2022-03-08 20:17:20
Yeah, looks like discogs is completely changed again. I'll have a go at it when I get some time, probably at the weekend. Or if you fancy it yourself, feel free to have a go! I can get the json block from the release page using Regex("id=\"dsdata\"[^>]+>(?<json>{.+?})</script>", RegexOptions.IgnoreCase | RegexOptions.Singleline)

But the json inside is totally different now too, and will need a lot more time to investigate.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2022-03-12 19:33:12
Wow, discogs is getting complicated. I'm beginning to think they're doing it on purpose. I've uploaded discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) v0.25 which should work again until they come up with something even more baroque.
Title: Re: Album Art Downloader XUI
Post by: DRata on 2022-03-14 16:54:57
Alex, thanks for the Discogs fix. I have been somewhat busy myself but could be enlisted in the future if needed.

It looks like Discogs is developing a new version of their release pages. If you visit a master release page on the site you'll see a "Master Release Beta Version" section with an input to toggle between the old and beta versions. Perhaps the JSON change was part of that, although it appears the same JSON is used on the old and beta pages.

Using their API would avoid having to play whack-a-mole like this but could lead to other problems such as rate limits.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2022-03-14 18:03:59
I agree, it would be nice to use the API instead of scraping it out of the html. Rate limiting isn't an issue, or isn't more of an issue, as it already applies to this access too, but the killer issue is that downloading images requires authentication (https://www.discogs.com/developers#page:images). Unless I require everyone to create an account on Discogs, generate a user token, and paste it into the script before it works, this will not work. Their intended solution is to register the app and obtain a consumer key and secret, but an open-source desktop application is not even in principle compatible with a secret that cannot be disclosed.

So, as they don't offer API access on the same terms as web access, we have to stick with web access.
Title: Re: Album Art Downloader XUI
Post by: kitchenstaff on 2022-03-16 18:07:41
Managed to get this installed with wine 7.0 stable using some of the hints in this thread - but the %extension% substitutions are not working properly. My existing folder.jpg files are not identified unless I specifically put `folder.jpg` in the path to find images, which would be fine except that all album covers downloaded are forced to have that extension (right or wrong). Any ideas on what might be happening here? If I leave %extension% in the output filename ends up being `folder.jpg;.jpeg;.jfif`, if that gives any clues.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2022-03-16 19:59:34
Looks like a bug in Wine. Documentation for IWICBitmapCodecInfo::GetFileExtensions (https://docs.microsoft.com/en-us/windows/win32/api/wincodec/nf-wincodec-iwicbitmapcodecinfo-getfileextensions) says "Receives a comma delimited list of file name extensions associated with the codec", but what you've apparently got there is a semicolon delimited list of extensions.

I'm not set up for verifying this under wine, but if anyone else is and can confirm that this function is returning ; separated instead of , separated strings then I'm sure the Wine team would appreciate a bug report.
Title: Re: Album Art Downloader XUI
Post by: chova on 2022-03-28 21:12:36
Did anyone manage to get the fanart.tv script working again?

It seems to be broken again, I've tried fixing it to no avail. Not sure how to debug the script so I'm going at it blind :)
Title: Re: Album Art Downloader XUI
Post by: mneimeyer on 2022-04-01 02:06:50
Unless I require everyone to create an account on Discogs, generate a user token, and paste it into the script before it works

At least on this front, instead of requiring editing the boo script could you treat it like the "Path to find images" option from the Local Files script and expose the option in the sources pane? Then if the option is not populated, return from the script.

Mind you, I've never written a boo script for a new source... so I defer to wiser minds. I just know that, for me at least, pasting something into the UI would NOT be a hindrance.

P.S. thank you thank you thank you thank you thank you for this tool! It has helped me clean up my collection SOOO much!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2022-04-02 12:45:32
Did anyone manage to get the fanart.tv script working again?

It seems to be broken again, I've tried fixing it to no avail. Not sure how to debug the script so I'm going at it blind :)
This is Mordred's script, but I took a look and it's a very small tweak to get it working again. Try fanarttv.boo (http://album-art.sourceforge.net/scripts/fanarttv.boo) v0.8
Title: Re: Album Art Downloader XUI
Post by: mjm716 on 2022-06-06 06:32:57
I'm not sure if sources have gotten worse, the scripts stopped being upgraded or if it's the app itself at this point?

I only ever get front covers, no other images (other than occasionally discogs), and usually only a few accurate front covers in a sea of irrelevant results.

For example, recent image searches have included front covers from MB, but following links to the MB pages show supplemental images which are not displayed in AAD.

I use the latest app with updated scripts (as far as the app reports them).

It seems there are many script tweaks in this forum, however I do not have time for manual peacemeal maintainence - isn't that what the app is supposed to keep track of? If scripts become garbage, would be great if the app pruned them for me.

Is this the current state of AAD or is my experience way off?
Title: Re: Album Art Downloader XUI
Post by: DRata on 2022-06-18 06:14:09
The number of working scripts has gone down, but most of the time I can find what I'm looking for from Deezer, iTunes/Apple,  Discogs, and MusicBrainz (the latter two mainly for out-of-print albums and non-cover art).

Of the scripts that no longer work, the one I miss the most is Google Play, which usually provided a decent-quality 1200x1200 image at a reasonable file size. At one point I tried to write a script for YouTube Music, which replaced Google Play, but something on the site changed and my script broke. I may revisit that sometime if Deezer or Apple goes away. Another script I wish were functional again is Amazon, which was a good source of large user-uploaded images. When I can't find what I'm looking for via AAD, I sometimes search those sites and download images manually via a browser.
Title: Re: Album Art Downloader XUI
Post by: whitepuzzle on 2022-09-21 04:11:47
https://bendodson.com/projects/itunes-artwork-finder/

As of quite recently, this website can download .pngs from iTunes now. And I confirmed via ICAT that they are indeed higher quality source files, and not just up-converted from the already existing .jpgs. Can this functionality be added to Album Art Downloader?
Title: Re: Album Art Downloader XUI
Post by: whitepuzzle on 2022-09-21 09:57:50
Upon further investigation it seems to be an entirely different path. That website used to fetch the same exact files as AAD, but now it fetches either PNGs or TIFFs if they exist (very few albums have their cover art in this format, I spent quite a while today perusing), or, if it does fetch a JPEG, it's a different file to the one AAD currently fetches: same resolution, smaller size, and very marginally higher quality (although sometimes lower quality). Usually the files are obviously from the same source, while sometimes they seem to be a different source (different colour grading etc). Perhaps this website is instead fetching from Apple Music or something?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2022-09-24 09:29:17
Nice find, Ben Dodson has made his source available too, so I can use the same logic to get the original file when available. It will then fall back on all the existing fall-backs if that isn't there. Please give the attached itunes.boo 0.6 a try to compare with the results you had noticed were different, and see if the quality now matches? Or more importantly if there are any where it gives a worse result!
Title: Re: Album Art Downloader XUI
Post by: eracer on 2022-10-25 16:49:21
Hello Friends...
i use the latest version XUI 1.05 the problem is Discogs search is not working 0 results
Can any one help me

sorry for my bad english
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2022-10-29 09:43:06
discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) v0.26 should be working again now.
Title: Re: Album Art Downloader XUI
Post by: eracer on 2022-10-29 10:39:14
Hello Alex, thank you and have a nice day

greetings eracer
Title: Re: Album Art Downloader XUI
Post by: whitepuzzle on 2022-10-30 11:25:57
Nice find, Ben Dodson has made his source available too, so I can use the same logic to get the original file when available. It will then fall back on all the existing fall-backs if that isn't there. Please give the attached itunes.boo 0.6 a try to compare with the results you had noticed were different, and see if the quality now matches? Or more importantly if there are any where it gives a worse result!

Yep, it works.

I must say, after much deliberation, I did decide to stick to using the old source, as I think the JPG files sourced from there are ever so slightly higher quality -- other than the albums that have PNG files uploaded on the new/alternate source (vanishingly few; Radiohead's discography is one such example). I suspect the new source uses a newer, more efficient JPEG encoder like mozjpeg, so they lowered the file size accordingly, but didn't do exhaustive pixel peeping like I do, so they didn't match the quality precisely between the old and new encodes.
Title: Re: Album Art Downloader XUI
Post by: triangle on 2022-11-16 08:26:30
If there is albumart available for booklets in good quality I like to download and add them to my album-folder.
Musicbrainz is often a source for these booklets (as pictures) and AAD seems to show up to 7 pictures. But when there are more covers available beacause the booklet is bigger they are not shown and I have to grab them from the website, which is not so comfortable and needs more time.

Is this a limitation of Musicbrainz, that AAD can not grab more pictures or dows AAD limit them and this could be changed?
Title: Re: Album Art Downloader XUI
Post by: tbonoc12 on 2023-03-21 02:29:17
Hi, firstly I love this app. -thanks! Has Qobuz script stopped working?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-03-21 08:05:25
Thanks for reporting this, qobuz.boo (http://album-art.sourceforge.net/scripts/qobuz.boo) v0.4 should now be working again.
Title: Re: Album Art Downloader XUI
Post by: nohart on 2023-04-20 03:49:05
In the results window all of a sudden I get really big pictures of the cover art. Does anyone know how to make the result icons smaller? I don't know what I did to make them so huge. The results used to be smaller in size.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-04-20 08:23:51
Sounds like probably toggling between wide and square results using the little arrow button (⤶/⤴) at the bottom right of the results. That changes whether the text goes below or to the right of the art. If that's not it, then just grab the bottom right corner of the art and drag it to resize to whatever size you like.
Title: Re: Album Art Downloader XUI
Post by: PaciPag on 2023-05-29 00:50:57
This is such an incredibly useful and helpful program... ...when it works. And then sometimes it doesn't work, and it makes me wonder if I'm just doing something completely wrong.

Take this, for example:

(https://i.imgur.com/YjaBRHX.png)

I'm searching for cover art that I know exists on Discogs. How do I know it exists on Discogs? Well, when I type "Sun Jamming" into the Discogs search bar, I get:

(https://i.imgur.com/eUoCYWe.png)

But Album Art Downloader just finds some bizarrely-irrelevant album by a band called Happy Flowers, which doesn't even include a song called "Sun Jamming" or anything like that. I mean, the theme of the words themselves is on-point - sun jamming, flowers, surf music, happy hippies, sure, all fits in the same spray-painted VW Bus. But as a Boolean search, maybe not so much.

It also fails to return images on eBay or Amazon that both exist (though to be fair, the Amazon one only pops up on a Google Images search, not a direct Amazon.com search). See here (https://i.imgur.com/8l1DFKq.png) and here (https://i.imgur.com/dEOZIKK.png) for screenshots, if necessary. Neither of these show up in Album Art Downloader.

Is there something I can tweak on my end to either return more than one result from Discogs, or, failing that, to at least ensure that when I'm searching for "Sun Jamming", AAD actually sends the words "Sun" and "Jamming" to Discogs and returns the first result?
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-05-29 08:56:39
I've checked out the example of Sun Jamming on Discogs, and this isn't showing up because it doesn't have a Master Release (for some reason). The Discogs script searches for Master releases so as not to return a lot of duplicates. You could change that by editing discogs.boo in notepad and on line 28 replacing searchType=master with searchType=release, but you may find a lot of duplicates in your results.

Secondly, there was a bug with the discogs script that would stop it from working on pages where there was not a "More images" link beneath the album artwork. I've fixed that here: discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) v0.27.

As far as the relevance of the search, there's not really much I can do about that. Album Art Downloader sends the search query "" "Sun Jamming" to Discogs (first "" because there is no artist), and those are the results it returns.

I expect better results could be obtained using the API, but they have gated this behind requiring an API key, which is not suitable for an open source application.
Title: Re: Album Art Downloader XUI
Post by: PaciPag on 2023-05-31 13:01:13
I've checked out the example of Sun Jamming on Discogs, and this isn't showing up because it doesn't have a Master Release (for some reason). The Discogs script searches for Master releases so as not to return a lot of duplicates. You could change that by editing discogs.boo in notepad and on line 28 replacing searchType=master with searchType=release, but you may find a lot of duplicates in your results.

Secondly, there was a bug with the discogs script that would stop it from working on pages where there was not a "More images" link beneath the album artwork. I've fixed that here: discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo) v0.27.

As far as the relevance of the search, there's not really much I can do about that. Album Art Downloader sends the search query "" "Sun Jamming" to Discogs (first "" because there is no artist), and those are the results it returns.

I expect better results could be obtained using the API, but they have gated this behind requiring an API key, which is not suitable for an open source application.

Thanks for the super-rapid response, Alex! I'll consider what you said about line 28.

I believe (though I'm not a Discogs expert by any means) that albums only get a "master release" once Discogs indexes a second pressing/edition of a release. So if all that's known is a single issue with a single pressing, no alternate media or regional releases, there's no need for a "master release" page, since the only release is itself the "master", and a separate "master release" page would be redundant.

I expect better results could be obtained using the API, but they have gated this behind requiring an API key, which is not suitable for an open source application.

For what it's worth, it seems they dropped the need for an API key when they went from 1.0 to 2.0. See https://www.discogs.com/developers/ for the Dev overview, and here (https://www.discogs.com/forum/thread/336458#3150292), here (https://www.discogs.com/forum/thread/342902#3216876), for a site dev mentioning that API keys are no longer required.

They're on OAuth now, which does require a consumer key. If AAD were my baby (and it's not, obviously - not trying to backseat drive, I'm just aimlessly burbling away like an uncle at a family reunion), I'd probably navigate this by initially setting the consumer key to a placeholder (either in source or in a .cfg file, whatever), then on runtime checking to see if the placeholder is still being used - if not, then we assume the clever user from the future saw the placeholder and generated their own consumer key and stuck it in there. If it is still the placeholder, then grab the "official" AAD consumer key from a text file hosted on Github or wherever.

But anyway, that's tangential - thanks again for the lightning-quick response!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-05-31 13:38:29
they dropped the need for an API key when they went from 1.0 to 2.0
For access to image URLs it still requires a "consumer" key (as you mention). Whatever they call it, it's still a key I need in order to access the API, which has to be kept secret. Looks like an API key to me! Keeping a key secret is not an option for AAD, so I'm not going to write a script that requires it. I do take your point that users with registered discogs accounts could generate their own keys and then supply them in some sort of config file, or by editing the script, but that's not really a model I'm interested in putting much work into.

If anyone else wants to write a discogs-api script based on this principle, I'd be happy to include it in the list of scripts, though,
Title: Re: Album Art Downloader XUI
Post by: PaciPag on 2023-06-01 03:18:45
they dropped the need for an API key when they went from 1.0 to 2.0
For access to image URLs it still requires a "consumer" key (as you mention). Whatever they call it, it's still a key I need in order to access the API, which has to be kept secret. Looks like an API key to me! Keeping a key secret is not an option for AAD, so I'm not going to write a script that requires it. I do take your point that users with registered discogs accounts could generate their own keys and then supply them in some sort of config file, or by editing the script, but that's not really a model I'm interested in putting much work into.
Like Shakespeare said, "an API key by any other name..." ;)

If anyone else wants to write a discogs-api script based on this principle, I'd be happy to include it in the list of scripts, though,

Tempting, but might be a bit beyond my meager skills.

I did, however, edit Discogs.boo to be better at finding various-artist compilations. Discogs considers the artist for various-artist compilations to be "Various" and I personally index my collection as "Various Artists" (and others truncate it to "VA"). So this (crude) hack will feed Discogs "various" even if the "actual" artist per the file tags is "Various Artists" or "VA".

The edits are on lines 25-29; I could probably have just done an OR but, eh, why write two lines when you can write four. :)

Code: [Select]
# refs: System.Web.Extensions

import System
import System.Text.RegularExpressions
import System.Web.Script.Serialization
import AlbumArtDownloader.Scripts
import util

class Discogs(AlbumArtDownloader.Scripts.IScript):
def constructor():
// Discogs requires TLS 1.1 or greater
Tls12 = Enum.ToObject(typeof(System.Net.SecurityProtocolType), 3072);
Tls11 = Enum.ToObject(typeof(System.Net.SecurityProtocolType), 768);

System.Net.ServicePointManager.SecurityProtocol = Tls12 | Tls11 | System.Net.SecurityProtocolType.Tls
Name as string:
get: return "Discogs"
Author as string:
get: return "Alex Vallat"
Version as string:
get: return "0.27"
def Search(artist as string, album as string, results as IScriptResults):
//artist = StripCharacters("&.'\";:?!", artist)
//album = StripCharacters("&.'\";:?!", album)
//Discogs lists Various Artists compilations under "Various", many collections term these "Various Artists" or "VA"
if (artist = "Various Artists"):
artist="Various"
if (artist = "VA"):
artist="Various"
json = JavaScriptSerializer()

resultsInfoJson = GetDiscogsPage("https://www.discogs.com/search/ac?searchType=release&q=" + EncodeUrl("\"${artist}\" \"${album}\""))
resultsInfo = json.Deserialize[of (Result)](resultsInfoJson)

results.EstimatedCount = resultsInfo.Length;

for result in resultsInfo:
// Get the release info from api
title = result.GetString(result.artist) + " - " + result.GetString(result.title);
url = result.GetString(result.uri);
//id = url.Substring(url.LastIndexOf('/'));

releasePage = GetDiscogsPage("https://www.discogs.com" + url)

releasePageImagesMatches = Regex("\"Image:{[^{]+}\":(?<json>{.+?}})", RegexOptions.IgnoreCase | RegexOptions.Singleline).Matches(releasePage)
for match as Match in releasePageImagesMatches:
imageInfo = json.Deserialize[of ImageInfo](match.Groups["json"].Value)
if (imageInfo.fullsize != null and imageInfo.thumbnail != null):
fullInfo = json.Deserialize[of ImageRef](imageInfo.fullsize.__ref.Substring(10))
thumbInfo = json.Deserialize[of ImageRef](imageInfo.thumbnail.__ref.Substring(10))

results.Add(thumbInfo.sourceUrl, title, "https://www.discogs.com" + url + "/image/" + imageInfo.id, -1, -1, fullInfo.sourceUrl, CoverType.Unknown)

def RetrieveFullSizeImage(fullSizeCallbackParameter):
return GetPageStream(fullSizeCallbackParameter, null, true);

def GetDiscogsPage(url) as string:
request = System.Net.HttpWebRequest.Create(url) as System.Net.HttpWebRequest

request.Accept = "*/*"
request.UserAgent = "Mozilla/5.0 (AAD on " + System.Environment.MachineName + ")"

try:
response = request.GetResponse()
except ex as WebException:
exResponse = ex.Response as System.Net.HttpWebResponse
if (exResponse != null and exResponse.StatusCode == 308):
return GetDiscogsPage(exResponse.GetResponseHeader("Location"))
raise

stream = response.GetResponseStream()
try:
return GetPage(stream)
ensure:
stream.Close()

class Result:
public artist as object
public title as object
public uri as object

def GetString(value):
result = value as string;
if result is null:
result = (value as (object))[0] as string;
return result;

class ImageInfo:
public id as string
public thumbnail as ImageRefJson
public fullsize as ImageRefJson

class ImageRefJson:
public __ref as string

class ImageRef:
public sourceUrl as string
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-06-01 08:25:39
Thanks, I will include the "Various Artists" => "Various" thing in the next release. I'm not convinced about "VA", though, I've not encountered that before and it unlike "Various Artists" it isn't unambiguous enough that I could be certain that you would never want to search for "VA" itself.
Title: Re: Album Art Downloader XUI
Post by: PaciPag on 2023-06-01 14:09:21
Thanks, I will include the "Various Artists" => "Various" thing in the next release.

It needs one quick bit of polish - change the single-equals to double-equals, otherwise it just sets the artist to "Various" regardless of any puny human conditional:

Code: [Select]
def Search(artist as string, album as string, results as IScriptResults):
//artist = StripCharacters("&.'\";:?!", artist)
//album = StripCharacters("&.'\";:?!", album)
//Discogs lists Various Artists compilations under "Various", many collections term these "Various Artists" or "VA"
if (artist == "Various Artists"):
artist="Various"
if (artist == "VA"):
artist="Various"
json = JavaScriptSerializer()
(that's line 22-30, everything else is as-was).

I'm not convinced about "VA", though, I've not encountered that before and it unlike "Various Artists" it isn't unambiguous enough that I could be certain that you would never want to search for "VA" itself.

VA is a bit of a holdover from the Napster days. The "scene" still uses "VA" as the official standard for Various Artists (see here (https://scenerules.org/t.html?id=2016_FLAC.nfo), section 4.2). This has resulted in a fair amount of spillover into FreeDB listings over the years. I agree that it's less common than Various Artists and Various, but it still shows up from time to time, and, imo, definitely shows up frequently enough to merit the substitution.

Also, and maybe more importantly: According to Discogs, this (https://www.discogs.com/search/?q=va&type=artist&strict=true) is the exhaustive list of artists named "VA". One of these - the primary "VA" artist, in fact (https://www.discogs.com/artist/194-Various) - is actually a placeholder so people won't use "VA" for "Various Artists". Only two of those are actual groups named "VA", and neither one is particularly notable - one had a promo album in 2001 that apparently never got a full release, the other released a single EP on Bandcamp in 2019. The rest are either individuals who've never released a solo album (just members of bands, producers, etc) or, in at least one case (see here (https://www.discogs.com/artist/13002624-VA-13), are actually incorrect transcriptions for "Various".

It'd be different if this was replacing all instances of "VA" everywhere with "Various" ("ca va bien" = "ca Various bien"), but as best I can tell, it's well-behaved and only replaces the artist "VA" with "Various" - "va" can still be used in album titles and band names as Spanish or French for "goes" or an abbreviation for the state of Virginia, etc, and it won't be affected by this switch.

Also, because whoever coded AAD took a brilliantly modular approach (make sure to shake this guy's hand if you ever meet him! :D), this will only affect Discogs, and not other sites where "VA" may actually be a valid artist search term.
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-06-01 18:39:00
Thanks for the scenerules link, in that case I'm happy to do the VA substitution too. For VA I've made it case-sensitive so that if anyone does need to really search for an artist called "Va" that will work too. Updated discogs.boo (http://album-art.sourceforge.net/scripts/discogs.boo)
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2023-10-09 14:52:06
Hi,
I'm using AAD 1.05 with fb2k 64bit latest preview via run_services on Windows 11 and get crashes IF artist or album is longer than 34 chars. Dunno, if I mentioned this before, but those crashes are here for a long time.


This test-one runs nice:

Code: [Select]
".\user-components\AlbumArtDownloaderXUI\AlbumArt.exe"
 /ar "$cut(12345678901234567890123456789012345,34)"
 /al "$cut(12345678901234567890123456789012345,34)"
 /p "$replace(%_path%,%_filename_ext%,)%%artist%%%%album%%'~'%%type%%%%size%%%%source%%.%%extension%%"

When I change the cut to 35 (to send 1 more char to AAD), AAD crashes.

Code: [Select]
".\user-components\AlbumArtDownloaderXUI\AlbumArt.exe"
 /ar "$cut(12345678901234567890123456789012345,35)"
 /al "$cut(12345678901234567890123456789012345,35)"
 /p "$replace(%_path%,%_filename_ext%,)%%artist%%%%album%%'~'%%type%%%%size%%%%source%%.%%extension%%"
I'm not sure if this is a limitation of any of the above mentioned softwares, but I'm be glad to help out to get AAD work with longer artist/album as 34 chars.

Cheers!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-10-09 19:13:57
Hi,
I'm using AAD 1.05 with fb2k 64bit latest preview via run_services on Windows 11 and get crashes IF artist or album is longer than 34 chars
I'm not seeing any crash when I pass parameters of more than 34 characters. What is the error message you get? Is an ".\user-components\AlbumArtDownloaderXUI\errorlog.txt" file created? Or an "%temp%\AAD_Errorlog.txt" file?

Is it possible that the full path including artist and album name ends up being more than 256 characters long? That's a windows limitation.
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2023-10-12 08:38:17
I'm not seeing any crash when I pass parameters of more than 34 characters. What is the error message you get? Is an ".\user-components\AlbumArtDownloaderXUI\errorlog.txt" file created? Or an "%temp%\AAD_Errorlog.txt" file?

Is it possible that the full path including artist and album name ends up being more than 256 characters long? That's a windows limitation.

No, there is no errorlog.txt created, but thanks for the hint,
it seems, my build path exceeds the 256 limit of windows, althouth, I think, AAD should not crash in that case, but either give a warning or just do anything intelligent ;-D
With a sortened path it seems to work nicely!
So thank you again for that hint!






Title: Re: Album Art Downloader XUI
Post by: fuffi on 2023-10-12 08:45:13
I'd like to ask, if it would be possible to add some functionality to remove illegal chars automaticly before saving an image.
Sometimes, AAD can not save images, because windows can't handle special chars:

X
X
X

It would be nice if AAD would handle such chars and not the user has to create rules/scripts for each char which would be illegale.

Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-10-13 08:00:05
AAD already replaces invalid characters in placeholders (like %artist% and %album%). If you expand the Options area, there's a box to say which character to replace them by ("-" by default).

Perhaps there is an invalid character in part of the path you are specifying directly? Try leaving placeholders in the path instead of having them resolved before they are sent to AAD.
Title: Re: Album Art Downloader XUI
Post by: fuffi on 2023-10-16 09:06:27
AAD already replaces invalid characters in placeholders (like %artist% and %album%). If you expand the Options area, there's a box to say which character to replace them by ("-" by default).

That is on the default here too ("-"), so it must be this, I guess:
Perhaps there is an invalid character in part of the path you are specifying directly? Try leaving placeholders in the path instead of having them resolved before they are sent to AAD.

Unfortunately, I'm unable to understand how to do this ;-)

This is my code and
Code: [Select]
".\user-components\AlbumArtDownloaderXUI\AlbumArt.exe" 
$puts(AR,$cut($replace(%ARTIST%,' - ',+, ,+,'_',+,'&',+,'(',+,')',+,'[',+,']',+,':',+,';',+,',',+,'.',+),70))

$puts(AL,$cut($replace(%ALBUM%,' - ',+, ,+,'_',+,'&',+,'(',+,')',+,'[',+,']',+,':',+,';',+,',',+,'.',+),70))

 /ar "$replace($get(AR),++, ,+, )"

 /al "$replace($get(AL),++, ,+, )"

 /p "$replace(%_path%,%_filename_ext%,)%%type%%%%source%%%%size%%.%%extension%%"

I understand, I have to remove all my replacements and put %%album%% and %%artist%% to /al and /ar ?

If so, how would I replace all the [ ; : ... which some sites have problems with? (At least, they had before some years when I initially did the repleacements because the unrepleaced searches broke those search engines)

Atm, I can't see how to benefit from the replacement for illegal chars by AAD and get mine as well.

It is not possible I guess? I have to do all the replaces by myself, or let AAD do it?

Thank you, your help is very much appreciated!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2023-10-16 09:27:29
You should not do any substitution in the /ar and /al parameters, but the /p one should have no invalid characters in it. Looking at your code, though, I can't see where they would be coming from, unless they are already in %path%, because you do not have album or artist in there.
Title: Re: Album Art Downloader XUI
Post by: mykeyz on 2023-11-10 06:10:06
Anyone noticing Qobuz cover art, especially newer releases, is only showing up as 600x600? I've been noticing it more and more.
Title: Re: Album Art Downloader XUI
Post by: HeliumAddict on 2023-11-27 18:58:00
Please add the following script for following host for finding more obscure albums ASAP

Allmusic
Bandcamp
Junodownload
Metal-Archives
Title: Re: Album Art Downloader XUI
Post by: mneimeyer on 2023-11-28 17:08:44
When grouped by Local it would be great if Local was always shown first/at top because this is when I'm trying to improve crappy artwork with better so I'd like to know what I'm comparing against.

Thanks! Love this thing it has helped me SO much!
Title: Re: Album Art Downloader XUI
Post by: AlexVallat on 2024-01-20 10:01:51
It looks like Discogs has killed public access again (getting 403 forbidden for the discogs script), so I've written a Discogs API alternative script: discogsAPI.boo (http://album-art.sourceforge.net/scripts/discogsAPI.boo). This will require an API key, referred to by Discogs as a Personal Access Token, which you can easily generate from https://www.discogs.com/settings/developers if you have a discogs account. Once you have one, edit the script in notepad or similar and replace YOUR_PERSONAL_ACCESS_TOKEN_HERE with the token generated, and it should work.

It only fetches what Discogs terms as being "full size" images of about 600x600; if anyone figures out how to get a proper full size original image out of Discogs do let me know, but I wasn't able to.