Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: WSH Panel Mod script discussion/help (Read 1400148 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

WSH Panel Mod script discussion/help

Reply #3950
so you're now avoiding the issue you initially reported. is that because you fucked up? i seriously feel like i'm wasting my time here.

console doesn't provide any feedback regarding automatic download.


that's because you didn't report anything wrong with it. 

WSH Panel Mod script discussion/help

Reply #3951
so you're now avoiding the issue you initially reported. is that because you fucked up? i seriously feel like i'm wasting my time here.

console doesn't provide any feedback regarding automatic download.

that's because you didn't report anything wrong with it. 

easy killer.

my original issue was sorted - existing images are now displaying because I'm an idiot and had a special character in my path.

Separate (ongoing) issue: automatic download does not seem to be doing anything.

My Foobar is running from C:\Program Files (x86)\foobar NAS2

Images are located here and referenced via prefs>display>album art>artist:
C:\Program Files (x86)\foobar NAS2\wsh_lastfm\$crc32(%artist%)\*.jpg
C:\Program Files (x86)\foobar NAS2\wsh_data\artists\%artist%\*.jpg
Z:\usb1-disk1\'~'incoming\'~'apps\foobar2000\wsh_lastfm\$crc32(%artist%)\*.jpg
Z:\usb1-disk1\'~'incoming\'~'apps\foobar2000\wsh_data\artists\%artist%\*.jpg

Code: [Select]
Opening track for playback: "Z:\usb1-disk1\IJ\Jay Dee aka J Dilla (1976-2006)\2003 +Madlib]Champion Sound [R2K7]\207 The Mission (Stringed Out Remix) (2003).mp3"
Audioscrobbler: Submitting track...
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Jaylib" "Champion Sound" bio
Audioscrobbler: Submission succeeded.
Wave cache: finished analysis of "Z:\usb1-disk1\IJ\Jay Dee aka J Dilla (1976-2006)\2003 +Madlib]Champion Sound [R2K7]\207 The Mission (Stringed Out Remix) (2003).mp3"
Now Playing: Playlist selection/playback event triggered.
Now Playing: Artist has changed. Updating.
[color=#FF0000]Now Playing: C:\Program Files (x86)\foobar NAS2\wsh_data\artists\Jaylib\ contains 0 images. [/color]
Now Playing: Playlist selection/playback event triggered.
Now Playing: Artist has not changed. Doing nothing.
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Jaylib" "Champion Sound" review
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Jaylib" "Champion Sound" review
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Jaylib" "Champion Sound" bio
Now Playing: Playlist selection/playback event triggered.
Now Playing: Artist has not changed. Doing nothing.
Now Playing: Playlist selection/playback event triggered.
Now Playing: Artist has not changed. Doing nothing.
init groups delay = 1147 ms /handleList count=91896
Now Playing: Playlist selection/playback event triggered.
Now Playing: Artist has not changed. Doing nothing.

Jaylib doesn't have existing images, but none are downloaded automatically even though I have set automatic download to 'all tracks' in your script setting.
 
If I use the manual option from your script (Download artist art from last.fm) it will then download Jaylib images (and save them in the red path above).

My issue is getting automatic download to work. [and bonus points: would be very cool if the script could use prefs>display>album art>artist to check for existing artist images]

WSH Panel Mod script discussion/help

Reply #3952
Separate (ongoing) issue: automatic download does not seem to be doing anything.


Notice this same problem on recent portable installs used for testing.

 

WSH Panel Mod script discussion/help

Reply #3953
since automatic downloads still work exactly as intended for me, there is nothing i can do to help. i suggest you find alternate methods to download your images.

WSH Panel Mod script discussion/help

Reply #3954
since automatic downloads still work exactly as intended for me, there is nothing i can do to help. i suggest you find alternate methods to download your images.

Well something changed in between versions if I can swap in an older one and have it work as expected. I can send you the older version I have for comparison if necessary.

WSH Panel Mod script discussion/help

Reply #3955
yeah go on then.

WSH Panel Mod script discussion/help

Reply #3956
yeah go on then.


http://1drv.ms/1MnOdAM

That one is dated from late Dec. and seems to work in the test configs I've placed it in.


EDIT: Marc - would it be possible to have your update script do a rename of the older version (common8.js.bak/old) or some such instead of a straight up replace? In case there's a need to rollback. Just a thought.

WSH Panel Mod script discussion/help

Reply #3957
as i expected, the relevant part of code is identical.

for backups, take a look at foo_jesus. if serious bugs are introduced with a new version i can rollback using the previous versions feature on dropbox - it contains all revisions for a month.

WSH Panel Mod script discussion/help

Reply #3958
as i expected, the relevant part of code is identical.


Try latest and the one I linked in separate portable installs once. Something is amiss.

I can reproduce every single time I do that.

WSH Panel Mod script discussion/help

Reply #3959
as i expected, the relevant part of code is identical.


sorry if i wasn't clear before. this is the end of it as far as i am concerned. if you don't know what the words relevant and identical mean, i suggest you go and look them up.

WSH Panel Mod script discussion/help

Reply #3960
You can play the dick card all you want. Or you could perform a simple comparison in two installs and try to verify what two people have found to be true.

I'm reporting a bug, not calling you out for being some fucking lackey in your scripting abilities.

Yeah, I'm done now.

WSH Panel Mod script discussion/help

Reply #3961
fuck me sideways. i've already said i tested my own version and it works. you really think i'd have this attitude if it didn't? how is me testing the old script which i wrote and contains identical code to the new one going to help anyone?

for bug reports to be useful, you have to provide relevant information. you've provided none. the fact that one of my old files works is simply a coincidence given the relevant code is identical.

this is very similar to arguing that a flac generated from a wav is not bit perfect compared to the source because it is compressed. if you want to be on the wrong end of that conversation then there is no helping you.

edit: just to put a real end to this, right click your panel, configure. replace this function....

Code: [Select]
function on_playback_time(time) {
    th.playback_time(time);
}


with

Code: [Select]
function on_playback_time(time) {
    if (time != 1) return;
    p.console("This is the time to determine if images should be automatically downloaded.");
    if (th.source != 0) return p.console("Panel is in custom folder mode. Not downloading.");
    if (p.metadb.RawPath != fb.GetNowPlaying().RawPath) return p.console("Panel is not focused on the playing track. Not downloading.");
    if (th.files.length > 0) return p.console("Folder contains at least one image. Not downloading.");
    if (th.auto_download == 0) return p.console("Automatic downloads are switched off. Not downloading");
    if (th.auto_download == 1 && !fb.IsMetadbInMediaLibrary(p.metadb)) return p.console("Automatic downloads are enabled for library tracks only and this track is not in the library. Not downloading.");
    p.console("All conditions for downloading images have been met. Downloading now...");
    th.download();
}


and here is the original function which you'll find inside common8.js. it does exactly the same as the above without the console messages. it's the same in all versions of my common8 scripts even if some people don't believe me. luckily it's all in plain text so you can check it out yourselves.

Code: [Select]
this.playback_time = function(t) {
    if (this.source == 0 && t == 1 && this.files.length == 0 && p.metadb.RawPath == fb.GetNowPlaying().RawPath && ((this.auto_download == 1 && fb.IsMetadbInMediaLibrary(p.metadb)) || this.auto_download == 2)) this.download();
}

WSH Panel Mod script discussion/help

Reply #3962
The author of this post requested its deletion. In order to preserve at least some of the causality of the discussion I deleted only the content. -- foosion

WSH Panel Mod script discussion/help

Reply #3963
that has to be the most retarded edit i've ever seen. thanks to you i'm no longer providing my scripts or support for anyone.

i do not want to see anyone sharing my files on these forums.

there's little i can do stop you doing it elsewhere so you go away and have your fun.

WSH Panel Mod script discussion/help

Reply #3964
@mjm716, because it seems you have no idea of the consequences of your actions, try adding this at the end of your panel.

Code: [Select]
th.download = function() {
    p.browser("http://www.last.fm/music/" + encodeURIComponent(th.artist));
}


it's a more visual representation of what you're trying to do. 

WSH Panel Mod script discussion/help

Reply #3965
it's a more visual representation of what you're trying to do. 


Well nice to see you've calmed down some.

Firstly, I did grasp the risk of looping requests (as seen in the console when I first took all conditionals away thank you), which is why I then left the time conditional in there (primarily for testing).

I'm certainly not the expert here, but that time == 1 setting adjusted (to 10 seems to work) on both my common7+8 has automatic downloads working for the first time in ages, so I'm still of the mind that at least on my system, the script never was given time to execute.

I'm open to your more seasoned directions, if you aren't going to just stomp away from the sandbox?

otherwise, I'll respect your wishes not to share what works for me here.

(Can an admin delete post 3963 above please as my edit rights are expired?)

WSH Panel Mod script discussion/help

Reply #3966
i kindly detailed the sanity checks i put in place to stop unnecessary automatic download attempts. did you report the exact console message that was preventing it working for you? no you didn't.

also, you made up some bullshit about how having loads of scripts active is affecting timers. what evidence have to provided to support this claim? again the answer is none.

instead you took it upon yourself to make a change that fires off 100 requests to the same web page for every track over 100 seconds long regardless of any settings/images already saved. it does one request per second until 100 seconds have passed. you're still failing to acknowledge how much of a stupid clueless cunt you are for doing this. please report my foul language/insults and hopefully my account will be banned.

WSH Panel Mod script discussion/help

Reply #3967
Calm down. Not everyone can be expert from the beginning. Your reaction is surprising as your fans are only trying to learn.

WSH Panel Mod script discussion/help

Reply #3968
exact console message that was preventing it working for you? no you didn't.

post 3952 above is exactly your requested console message. If autodownload is supposed to be firing in the console, it clearly isn't for me.

Currently with the same verbose common8.js version the only reporting on track change I get (with timer=10) is:

Code: [Select]
init groups delay = 1158 ms /handleList count=91743 
Opening track for playback: "Z:\usb1-disk1\B\Bantam Rooster _3A\2000 Fuck all Y'all\11 It Girl (2000).mp3"
Audioscrobbler: Submitting track...
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Bantam Rooster" "Fuck all Y'all" bio
Audioscrobbler: Submission succeeded.
Wave cache: finished analysis of "Z:\usb1-disk1\B\Bantam Rooster _3A\2000 Fuck all Y'all\11 It Girl (2000).mp3"
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Bantam Rooster" "Fuck all Y'all" review
init groups delay = 1171 ms /handleList count=91742
Opening track for playback: "Z:\usb1-disk1\various\F-L\JAZZMAN++\Texas Funk-Black Gold 68-75 _57\12 Super Funk-Vern Blair Debate (2005).mp3"
Audioscrobbler: Submitting track...
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Vern Blair Debate" "Texas Funk" bio
Audioscrobbler: Submission succeeded.
Wave cache: finished analysis of "Z:\usb1-disk1\various\F-L\JAZZMAN++\Texas Funk-Black Gold 68-75 _57\12 Super Funk-Vern Blair Debate (2005).mp3"
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Vern Blair Debate" "Texas Funk" review
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Vern Blair Debate" "Texas Funk" review
Biography : execute command -> cscript //nologo scripts\allmusic0913.vbs "Vern Blair Debate" "Texas Funk" bio

also, you made up some bullshit about how having loads of scripts active is affecting timers. what evidence have to provided to support this claim? again the answer is none.

instead you took it upon yourself to make a change that fires off 100 requests to the same web page for every track over 100 seconds long regardless of any settings/images already saved

I already mentioned below I was aware of the looping issue, and I only did it (at 100) once as a test.

I've also already said simply increasing the time to 10 has common7+8 working on my setup (for the first time ever!) - and that the timing issue is a hypothesis. What proof would you like - before and after screenshots of no artist images (timer 1) / artist images (timer 10)?

Geezus dude, this is a hobby forum - does your attitude make you feel better? If I wanted that, I'd go back to work. Nobody is trying to steal your pony.

Two people have said things didn't work, no one is blaming you - it could be a million different things - I'm only trying to debug my setup. If my hypothesis is shit, fine, but why else would that change make a difference for me over two separate versions of your script?


WSH Panel Mod script discussion/help

Reply #3969
post 3952 above is exactly your requested console message. If autodownload is supposed to be firing in the console, it clearly isn't for me.


i'm pretty sure you didn't invent time travel. i posted this code snippet some time AFTER #3952...

edit: just to put a real end to this, right click your panel, configure. replace this function....

Code: [Select]
function on_playback_time(time) {
    th.playback_time(time);
}


with

Code: [Select]
function on_playback_time(time) {
    if (time != 1) return;
    p.console("This is the time to determine if images should be automatically downloaded.");
    if (th.source != 0) return p.console("Panel is in custom folder mode. Not downloading.");
    if (p.metadb.RawPath != fb.GetNowPlaying().RawPath) return p.console("Panel is not focused on the playing track. Not downloading.");
    if (th.files.length > 0) return p.console("Folder contains at least one image. Not downloading.");
    if (th.auto_download == 0) return p.console("Automatic downloads are switched off. Not downloading");
    if (th.auto_download == 1 && !fb.IsMetadbInMediaLibrary(p.metadb)) return p.console("Automatic downloads are enabled for library tracks only and this track is not in the library. Not downloading.");
    p.console("All conditions for downloading images have been met. Downloading now...");
    th.download();
}


so again i ask...which one of these console messages prevented it working for you? or are you going to lie and say this never triggered once after one second of playback of every track? and it's not like you can say you missed this post because it's your brain dead edit of this code which caused all this in the first place.

edit: also, why did you omit the most important part of my previous post. you only quoted this...

Quote
exact console message that was preventing it working for you? no you didn't.


it makes much more sense when you quote it all.

Quote
i kindly detailed the sanity checks i put in place to stop unnecessary automatic download attempts. did you report the exact console message that was preventing it working for you? no you didn't.


anyway, i'm done now. i thought the mods would have banned me but it doesn't matter. i have enough willpower to stay away by myself.

WSH Panel Mod script discussion/help

Reply #3970
i have enough willpower to stay away by myself.


I doubt it.

But just to humour you.

Fresh thumbs script with your requested mod code. No images downloaded; nothing fires in console.




Same thing with timing mod. Images download and still nothing fires in console.




Yet a third test, this time removing (time != 1) from your requested mod code. Images download and finally console messages fire.



You're welcome for your stupid script debugging.

WSH Panel Mod script discussion/help

Reply #3971
I doubt it.


well given you've finally posted some relevant information, i couldn't not reply. 

on_playback_time is built into the component and it's something i don't have any control over. there are 2 possible reasons for my code not triggering...

you're seeking or using foo_skip to bypass it hitting one second.
the component is broken in your usage scenario. if this is the case, you're more than welcome to download the source code and fix it: https://code.google.com/p/foo-wsh-panel-mod/source/browse/

btw, i love your image names. hilarious.

WSH Panel Mod script discussion/help

Reply #3972
Thanks, Marc. For the five+ years this thread has been running it has helped hundreds, if not thousands, of users to make their foobar2000 bespoke for their use. A better user experience. With all due sincerity, your scripts and help over time has made my foobar2000 exactly what I want it to be.

That said...

The past several days are also a prime example of why this (or similar) functionality should be rolled into fb2k from the onset. Being an official option would remove the chance of someone having a bad day. With zero options for third parties to obliterate necessary files and snub the same hundreds, if not thousands, of users by pulling the plug on a truly useful project in what can be summed up as an infantile temper tantrum. Unless something changes in the interim, this thread will be a reminder of why third party components can be risky items to employ. Users are at the mercy of individuals that could, for no reason other than spite, ruin what has become a longstanding tradition of community interaction.

My issue with artist art has been resolved by finding a recent working version of the scripts in my considerable stash of configurations and systematically replacing the ones that were giving me troubles. I'm still at a loss as to why it started in the first place. Most likely something I did but I don't care to dig further now given how the tone in this thread soured over such a short time span. It works again. That's all that matters.

Hopefully this thread doesn't become a relic of 'what could have been'. It would be a genuine shame if that where to happen.

WSH Panel Mod script discussion/help

Reply #3973
What happen here?
Original script works perfectly for 99.9% users, and there is no need to continue this discussion because 0.01% users have a problem, and this is because something is wrong in their setup(windows,foobar), or they edit script by self, and they don't understood how exactly script works..
Marc scripts are esential for foobar, works perfectly , and i am very grateful for his support and time he spend even to help us with our own script..
Thanks Marc, and just calm down.

WSH Panel Mod script discussion/help

Reply #3974
What happen here?
Original script works perfectly for 99.9% users, and there is no need to continue this discussion because 0.01% users have a problem, and this is because something is wrong in their setup(windows,foobar), or they edit script by self, and they don't understood how exactly script works..
Marc scripts are esential for foobar, works perfectly , and i am very grateful for his support and time he spend even to help us with our own script..
Thanks Marc, and just calm down.


Marc, thank you for your support, it was and still is, appreciated!.
I hope this will blow over and that you will return soon again. You will be missed.