Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1280390 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

REACT 2 Released

Reply #1350 –
$q is ONLY used by ACDIR. It doesn't work anywhere else in batch scripts. The problem here again is not using quotes to wrap strings. DOS expects a DOS command after ampersand if it's not wrapped in quotes. Small example:

Code: [Select]
C:\>ECHO rock & ECHO roll
rock
roll

C:\>ECHO "rock & ECHO roll"
"rock & ECHO roll"

First command echoes 1st rock and then roll separately, the 2nd command echoes a string containing an ampersand.

So, do the following:
Code: [Select]
SET cover="I:\TODO\$cdartist$\$cdartist$ - $year$ - $album$.jpg"
SET cover_small="I:\TODO\1AlbumArtSmall\$cdartist$ - $year$ - $album$.jpg"

AND then use %cover% and %cover_small% variables WITHOUT quotes! There should be no problems but let me know if you ABSOLUTELY need the "SET" values without quotes.. I've a solution to that also..

REACT 2 Released

Reply #1351 –
I’m unsure if there is a way to do RegExp's? If so, you might want to replace/escape the characters otherwise problematic for DOS batch files.

I use Mp3tag for lots of batch-related stuff, and I usually escape the »problematic« characters with a ^:
()<|>"&^ --> put a ^ as escape character before those

% --> replace with %% in batch files

So, for the example above:
Code: [Select]
ECHO Rock ^& Roll
Rock & Roll
ECHO A 100%% Test
A 100% Test
works beautifully.

REACT 2 Released

Reply #1352 –
OK I have done that and now I don't get the error message but nothing is encoding now - images or tracks.

This is what I have now
Code: [Select]
REM :I_drive
SET cover="I:\TODO\$cdartist$\$cdartist$ - $year$ - $album$.jpg"
SET cover_small="I:\TODO\1AlbumArtSmall\$cdartist$ - $year$ - $album$.jpg"
IF NOT EXIST %cover% goto X_drive 
    SET have_cover=1
    SET embed_cover=@EmbedCover@
    goto end_cover_art

:X_drive
SET cover="X:\$cdartist$\$year$ - $album$\Folder.jpg"
SET cover_small="X:\$cdartist$\$year$ - $album$\AlbumArtSmall.jpg"
IF EXIST %cover% (
    ATTRIB %cover% -s -h
    ATTRIB %cover_small% -s -h
    SET have_cover=1
    SET embed_cover=@EmbedCover@
) ELSE (
  ECHO.
  ECHO *** ERROR MISSING COVER ART ***
  ECHO.
  ECHO: Cover art for "@basename@" does not exist!
  ECHO.
  PAUSE
  GOTO :EOF
)
:end_cover_art

I am guessing its something to so with the following lines which feature %cover%

FLAC Image
Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||%cover%"

FLAC Track
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.flac" --extra-opt "|image/jpeg|||%cover%"

MP3 Track
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.mp3" --extra-opt "APIC{3}:%cover%"

I know I should not have any quotes round %cover% when it is on its own but in these cases it features as part of another command. Is there something wrong with these lines. As I said previously this all worked fine until I came across the album with the & in it.

REACT 2 Released

Reply #1353 –
Quote from: gsa999 on
I know I should not have any quotes round %cover% when it is on its own but in these cases it features as part of another command. Is there something wrong with these lines. As I said previously this all worked fine until I came across the album with the & in it.

Yes, the extra quotes mess up the 3 lines you posted (maybe more where the %cover% and %cover_small% vars are). I should have thought that you'd use the vars like that, sorry.. but no fear, Akkurat is back here, with a new ugly trick, put on some lipstick, open your eyes and smile, you'll be alright for a while.  (I've been writing poems lately.. not that lame though.. I'm better with my native language.. really)

Here's again an example of the solution:
Code: [Select]
SET test="rock & roll"

SETLOCAL ENABLEDELAYEDEXPANSION
REM ** Remove double quotes from the variable.
SET test=!test:"=!
SETLOCAL DISABLEDELAYEDEXPANSION

ECHO "%test%"

That will output "rock & roll" in the end. This works because when the "delayed expansion" is enabled, the var (!test!, not %test%) value is NOT outputted to the console (screen *doh*) and thus the ampersand works without it being between quotes. Weird huh?

Ok, so you should do the following (for the first part, just copycat this to the other part also):
Code: [Select]
SET cover="I:\TODO\$cdartist$\$cdartist$ - $year$ - $album$.jpg"
SET cover_small="I:\TODO\1AlbumArtSmall\$cdartist$ - $year$ - $album$.jpg"
SETLOCAL ENABLEDELAYEDEXPANSION
SET cover=!cover:"=!
SET cover_small=!cover_small:"=!
SETLOCAL DISABLEDELAYEDEXPANSION

AND, then make sure that the %cover% and %cover_small% variables are between quotes anywhere in the code. In example the 3 lines you posted will work without changing them.. but, in example, the IF EXIST %cover% won't work without quotes.

REACT 2 Released

Reply #1354 –
Brilliant. that has worked perfectly. I would never have got to that solution on my own

Thanks Akkurat

REACT 2 Released

Reply #1355 –
Another problem now.

Ripping and encoding an AC/DC album. The FLAC Image gets AC-DC in the name becuase of the substitution of the / with a - in the react.ini file, but this is not happening with either flac tracks or mp3 tracks - instead I get AC DC (a space in between). I can't figure out why these are not substituting a - rather than a space.

REACT 2 Released

Reply #1356 –
If my memory serves me right, it's because ACDIR uses its own special char substitution system. And there's no easy way to change that since the values are read from the cue file. This is one of the reasons I advertise using the track mode. Are you really storing both FLAC image and tracks? Any particular reason to do so? Why don't you just rip to FLAC & Mp3 tracks?

REACT 2 Released

Reply #1357 –
Quote from: Akkurat on
Are you really storing both FLAC image and tracks? Any particular reason to do so? Why don't you just rip to FLAC & Mp3 tracks?
Becuase I play MP3 tracks on my iPod and FLAC tracks on my SONOS system at home for better quality.

Maybe I will change the name in EAC to AC-DC and rip all their albums and then change the tag back using mp3tag to get round the problem. Thanks

REACT 2 Released

Reply #1358 –
Quote from: gsa999 on
Becuase I play MP3 tracks on my iPod and FLAC tracks on my SONOS system at home for better quality.

Yes, but what do you do with the FLAC image? That's what I was asking; do you really need BOTH FLAC image and tracks?

Quote from: gsa999 on
Maybe I will change the name in EAC to AC-DC and rip all their albums and then change the tag back using mp3tag to get round the problem. Thanks

No no, you misunderstood, only the filename is affected, not tags.

REACT 2 Released

Reply #1359 –
Used it before, and its awesome. Thanks for informing us and the update!
 

REACT 2 Released

Reply #1360 –
Quote from: Synthetic Soul on
[…] I'm not sure whether this is standard practise or not.  […]
[…] I guess it mainly comes down to whether most users always use both fields […]

It’s a little unfortunate that »Album Artist« has apparently been overlooked when creating the ID3v2 standard, so almost everyone came up with their own »pseudo standards«:
  • The foobar2000 community apparently tends to use a frame TXXX:ALBUM ARTIST. (Is it actually all uppercase?)
  • iTunes, Winamp and Windows Media Player use TPE2 (called BAND in Mp3tag) as Album Artist, which is definitely far away from the specs. SqueezeCenter (ex SlimServer) can also be taught to use TPE2 as Album Artist.
  • iTunes also introduced the (non-standard) frame TCMP (called ITUNESCOMPILATION in Mp3tag) to state whether a track belongs to/an album is a compilation: If an album is a compilation in the sense of having various artists, it is set to 1, else missing (may also be set and contain a zero). SqueezeCenter introduced a new meaning to the flag being set to a zero: Show every track as separate album.
  • MusicBrainz and their Picard Tagger (also Jaikos I believe) currently set both TCMP and a frame TXXX:MusicBrainz Album Type (called MUSICBRAINZ ALBUM TYPE in Mp3tag) for MP3s and MUSICBRAINZ_ALBUMTYPE in other file types that contains a text string like »album« or »compilation«. Beware: A MusicBrainz type Compilation is not only a »Various Artists« album, but also a compilation by one artist, i.e. a collection of previously released songs. (VA albums should actually be called »Samplers« to differentiate, I think.)
  • SqueezeCenter checks for the frame TXXX:ALBUMARTIST. (Plus TCMP, plus TPE2 if so set. Fortunately.)
  • Some other applications just check for the string »Various Artists« in either TPE2, TXXX:ALBUM ARTIST or TXXX:ALBUMARTIST.
  • I myself like things sorted, so I usually rely on TXXX:ALBUMARTISTSORT which gets set by MusicBrainz' Picard for me. (I have one strict rule: If a release is not defined in MusicBrainz, it doesn’t exist for me. Meaning, I have to enter it in MB first.)
So what’s the consequences from all this?

To be compatible with a wide variety of applications, one should probably (in MP3s) set TCMP (or COMPILATION in other tag formats) since it’s in wide use, TXXX:ALBUM ARTIST since it has a wide use in the foobar community (though I’d still recommend using tags with no Spaces and only uppercase, for best tagging compatibility using other tag formats). I’d avise against using TPE2 for Album Artist except if you really, really need iTunes/Winamp/WMP compatibility since it clearly violates the spec and some people really put Band information there. Only because large companies use it, it must not be correct.

Usage of TXXX:ALBUMARTISTSORT and TXXX:MusicBrainz … tags is of course purely optional, but of course I’d like to see more people using ALBUMARTISTSORT (my folders are even named after this tag and I like to be able to reconstruct all info from only the tags).

And yes, I like the idea of getting all info as early as possible, so REACT is a good place to start and also set the »Album Artist«.

For checking whether an album is a »compilation« (a »sampler« really), I’d rely on some logic like this:
  • Is TCMP or COMPILATION set and = 1? --> compilation
  • Is ALBUM ARTIST or ALBUMARTIST set and not equal to ARTIST? --> compilation
  • Is some kind of »use TPE2 as Album Artist« flag set? If so and TPE2 not equal ARTIST --> compilation
  • Is any of ALBUM ARTIST, ALBUMARTIST or TPE2—if enabled by flag—equal to »Various Artists« or a user-defined string (for localization, i.e. »Verschiedene Interpreten«), do a case-insensitive comparison? --> compilation
  • If we have a list of tracks belonging to the same album, are
    • all ARTIST the same? No --> compilation
    • all ARTIST = ALBUM ARTIST (if set)? No --> compilation
The only inconsistency in this whole scheme is that we need to store album/release information within tracks which is not too elegant but can’t be helped. Since all tracks need to be »in snyc« regarding the »album information« at all times, this is another reason to have things like REACT do it in the first place.

REACT 2 Released

Reply #1361 –
Thanks for the input, your post clearly underlines the situation with Mp3 tags at the moment; rather silly mess.. IMHO.. and throw in 1.1/2.3/2.4/whatever version tags difference and support.. sad, really. FLAC FTW.

Quote from: Moonbase on
VA albums should actually be called »Samplers« to differentiate, I think.

I disagree, samplers are promos (promotional compilations).

Quote from: Moonbase on
To be compatible with a wide variety of applications, one should probably (in MP3s) set TCMP (or COMPILATION in other tag formats) since it’s in wide use, TXXX:ALBUM ARTIST since it has a wide use in the foobar community (though I’d still recommend using tags with no Spaces and only uppercase, for best tagging compatibility using other tag formats). I’d avise against using TPE2 for Album Artist except if you really, really need iTunes/Winamp/WMP compatibility since it clearly violates the spec and some people really put Band information there. Only because large companies use it, it must not be correct.

Well, REACT currently tags TXXX[album artist] and TPE2, and with those tags, from your list, following programs detect VA albums: foobar2000, iTunes, Winamp, Windows Media Player, SqueezeCenter, Mp3tag & "Some other applications". Not bad? I'll put using the TCMP into consideration.. though it's not needed with TPE2 and I'm hesitant to remove it.

REACT 2 Released

Reply #1362 –
Hi again
I am hitting another rather frustrating issue with the new feature that was added a while back to tell REACT whether the CD is part of a double CD - ie disknumber1/2 and totaldiscs 2 metadata.

I am finding that if I have say ripped two single CD's and left the defaults for disknumber at 1 and totaldiscs at 1, and I then put in a 3rd CD which is CD1 of a double CD set and I therefore change totaldiscs to 2, the folder structure of the 2 CD's that are still encoding in background gets set to CD1 - ie the system thinks they are the first CD of a double set. Its annoying becuase as well as manually having to change the folder structure (3 times) I am having to manually edit the cue sheet, the embedded cuesheet in the flac image and also the flac and mp3 tracks to remove the incorrect tags.

I am systematically working through my collection bv artist so the only way I can get round this at the moment is by ensuring that all single CD's have finished encoding before attempting a double CD and then have to wait until that has finished before going back to single CDs. I like to get as many ripped and queued for encoding as possible during the day so they continue encoding overnight, so this slows things up somewhat.

Is this something anyone else has come across?

REACT 2 Released

Reply #1363 –
EAC Compression Queue and REACT doesn't work together. And I've no plans at the moment to change that, it requires a lot of code inspection and most probably re-designing some parts. Sorry. I still have a long ToDo list but sadly I've been "distracted" away from the development.. I'll try to start it again soon.. and probably I'm soon forced to do that if the coming new EAC version changes things a lot (no proper changelog(s) so far ).

REACT 2 Released

Reply #1364 –
In the react.ini file is it possible to change the replacement character for a question mark in the file name to null rather than a space.
So for instance if I had a track called "Who Will You Run To?" I want the file name to be

"Who Will You Run To.mp3" and not "Who Will You Run To .mp3"

REACT 2 Released

Reply #1365 –
Of course, here's my setting: Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||-|'|-|[|]

Though this won't work with the tracks ripped in image mode, as I said earlier, ACDIR uses its own char substitution system.

REACT 2 Released

Reply #1366 –
Quote from: Akkurat on
Not bad?

NOT BAD!

»Hyvää Joulua ja Onnellista Uutta Vuotta« to Finland! (I hope this is correct …)

REACT 2 Released

Reply #1367 –
Quote from: Moonbase on
Quote from: Akkurat on
Not bad?

NOT BAD!

Jeez, made me scratch my head, then I remembered what that was, I forgot what I wrote about two weeks ago, I'm getting old.  or should it be 

Quote from: Moonbase on
»Hyvää Joulua ja Onnellista Uutta Vuotta« to Finland! (I hope this is correct …)

Spot on! Though we don't capitalize our holiday words. Fröhliche Weihnachten und ein schönes neues Jahr to you too! 

REACT 2 Released

Reply #1368 –
Quote from: Akkurat on
Though this won't work with the tracks ripped in image mode, as I said earlier, ACDIR uses its own char substitution system.
Ahh that explains it - I am using image mode and then ripping to tracks. How annoying! Thanks

REACT 2 Released

Reply #1369 –
Quote from: gsa999 on
Ahh that explains it - I am using image mode and then ripping to tracks. How annoying! Thanks

Yes, it is annoying... below is my old question which you never answered..

Quote from: Akkurat on
Quote from: gsa999 on
Becuase I play MP3 tracks on my iPod and FLAC tracks on my SONOS system at home for better quality.

Yes, but what do you do with the FLAC image? That's what I was asking; do you really need BOTH FLAC image and tracks?

You know that FLAC tracks are fine also for archiving? Are you using the FLAC image for that now? If you don't have a "special" use for the image, you could switch to track mode ripping in EAC. Just a hint.. you can do what you want.. I just wanted to make sure that you understood what I was after.

REACT 2 Released

Reply #1370 –
Quote from: Akkurat on
You know that FLAC tracks are fine also for archiving? Are you using the FLAC image for that now? If you don't have a "special" use for the image, you could switch to track mode ripping in EAC. Just a hint.. you can do what you want.. I just wanted to make sure that you understood what I was after.
Yes I did know that but there are a couple of reasons I thought the image would be useful

1. I want to store all the images (as backups) on a seperate hard disk to all my tracks just in case I have a HD failure. I figured it is better having one large image +cue as my backup rather than the seperate tracks. I know I have the CD's themselves, but they are getting stored in the loft once all ripping is completed and having the images available on a HD just seems easier to me.

2. If I want to re-encode using a newer version of Lame,  I thought this would be easier if I already had a single image (I do not want to get the CD's out again) with embedded cuesheet. I did think of leaving them as WAVs but since FLAC images take up less space I went with this option. I have not actually investigated how I would do this though - any thoughts?

REACT 2 Released

Reply #1371 –
Sorry for the late response, my ISP has been dropping me off the interwebs lately.. + I finally upgraded to Win SP3 and it broke my custom REACT track config.  Thanks a lot MS!

Quote from: gsa999 on
Quote from: Akkurat on
You know that FLAC tracks are fine also for archiving? Are you using the FLAC image for that now? If you don't have a "special" use for the image, you could switch to track mode ripping in EAC. Just a hint.. you can do what you want.. I just wanted to make sure that you understood what I was after.
Yes I did know that but there are a couple of reasons I thought the image would be useful

1. I want to store all the images (as backups) on a seperate hard disk to all my tracks just in case I have a HD failure. I figured it is better having one large image +cue as my backup rather than the seperate tracks. I know I have the CD's themselves, but they are getting stored in the loft once all ripping is completed and having the images available on a HD just seems easier to me.

2. If I want to re-encode using a newer version of Lame,  I thought this would be easier if I already had a single image (I do not want to get the CD's out again) with embedded cuesheet. I did think of leaving them as WAVs but since FLAC images take up less space I went with this option. I have not actually investigated how I would do this though - any thoughts?

Now, I'm not an expert on backups and with the re-encode stuff but, I would choose only FLAC tracks (+Mp3's), I can't see why that wouldn't work with what you want. But, because I see it as a preference question, maybe you shouldn't change (or start over) your process. I guess there are plenty of software around to re-encode from flac tracks to mp3 tracks (or you could write your own batch script for it), dunno about image to tracks though.

Happy New Year! 

REACT 2 Released

Reply #1372 –
Yes I think I will stick with my current setup - it seems to be working fine, although having said that I have just noticed a very odd problem with the flac images. For some reason some of them are not being generated in the format that I have set in the react.ini file which is:
Code: [Select]
ImageNaming=$artist$ - $year$ - $album$
I keep losing the year and have had to go back manually to correct them which is a complete pain  . It seems to be defaulting to EACs standard naming convention for images which is "artist - album".
Have you come across this problem before?

REACT 2 Released

Reply #1373 –
Something similar yes. You're the 3rd one to report something like this. I was able to reproduce the problem in VPC Vista image and made the fix (included in the latest version of my mod). That also seemed to fix it for the 2nd user that reported it.. never got any feedback from the 1st user. Are you using Vista? And which version of my(?) mod?

REACT 2 Released

Reply #1374 –
Quote from: Akkurat on
Are you using Vista? And which version of my(?) mod?
No I am using XP (latest service pack) and also the latest version of your mod.

I reset EAC to work with REACT (Ctrl-F2) and it seemes OK again for now. I will have to keep an eye on it and see if I can spot a pattern. I only noticed it by accident yesterday and then went back through the 150 albums I have ripped already and found about 20 that were wrong. It was not just a case of changing the file name but also the cue sheet and reference in the cue sheet. Becuase I had embedded the cue sheet in the flac image as well I also had to update that which was the bit that took ages.