Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1280117 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

REACT 2 Released

Reply #1325 –
The title of the command window is indeed nn/nn when doing image mode. I am not saving the images, no - I just hit F10 because I was told to. I see from the REACT.INI that if you hit F4 it's track mode, so I've tried that. Same result though, I'm afraid. In that mode the command window is actually n/nn, though.

Looking in the CMD window output the command is being passed, but is just not going through I guess:

TITLE 07/12 mp3 "Guess How Much I Love You - Classical Keepsakes" & C:\PROGRA~1\REACT2\tools\lame.exe -b 320  - "07 - Guess How Much I Love You - Classical Keepsakes - Sunrise From Daphine et Cloé.mp3" & C:\PROGRA~1\REACT2\tools\metamp3.exe --pict "{3}C:\Documents and Settings\UberNewf\My Documents\Guess How Much I Love You - Classical Keepsakes.jpg" --user-text "[album artist]Various Artists" --frame "TPE2:Various Artists"  --artist "Ravel" --album "Guess How Much I Love You - Classical Keepsakes
" --title "Sunrise From Daphine et Cloé" --track 07 --year "2003" --genre "Children Songs" --comment "Created with EAC/REACT v2.0.akku.b03, 2008-10-30" --frame TSSE:"LAME 3.97 -b 320" "07 - Guess How Much I Love You - Classical Keepsakes - Sunrise From Daphine et Cloé.mp3"

It's not in quotes though, like all the other parameters. That the cause?

REACT 2 Released

Reply #1326 –
You should read this: REACT.

And yes, you're right, the current stock track.cfg is set up to use the non-zero-padded track numbers.. sorry, I forgot. At the moment the configs and some other things are not consistent in REACT, I've plans to rectify this and also bring out more settings to INI (e.g. UseZeroPaddedTrackNumbers=1/0, create playlists, filenames of playlist/etc.).

Regarding the image mode problem with track numbers; where or what software do you use to check that the resulting Mp3's have not got zero-padded track numbers? Could you try the method Synthetic Soul used? (metamp3 test.mp3) @Synthetic Soul: sorry about the test thing, I misunderstood and that's why I didn't test.

If you are not saving images, you're much better off using the track mode. And here's the way to put zeros in your track numbers:

1) Open the REACT-track.cfg file
2) Replace all (text editors "should" have this feature) @track@ strings to $track$ strings (or just the one in the Mp3 section)
3) Replace all @numtracks@ strings to $numtracks$ strings (or again, just the one in the Mp3 section)
4) Happy REACTing!

REACT 2 Released

Reply #1327 –
Quote from: Akkurat on
Regarding the image mode problem with track numbers; where or what software do you use to check that the resulting Mp3's have not got zero-padded track numbers?


MP3Tag (http://www.mp3tag.de/en/index.html)

Quote from: Akkurat on
Could you try the method Synthetic Soul used? (metamp3 test.mp3)

I tried that and it works directly like that, yes. It is STILL not working though the whole automation process though. I even did what you said below:

Quote from: Akkurat on
If you are not saving images, you're much better off using the track mode. And here's the way to put zeros in your track numbers:
1) Open the REACT-track.cfg file
2) Replace all (text editors "should" have this feature) @track@ strings to $track$ strings (or just the one in the Mp3 section)
3) Replace all @numtracks@ strings to $numtracks$ strings (or again, just the one in the Mp3 section)



Here's the relevant portion of my REACT-track.cfg


Code: [Select]
IF NOT @LameMP3@==1 GOTO end_lame_tracks
    IF NOT EXIST %TrackDir_MP3% MKDIR %TrackDir_MP3%
    PUSHD %TrackDir_MP3%
        IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"
        IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"
        ECHO ON
        @tools@\lame.exe @Opt_LameMP3@ "@source@" "%TrackName%.mp3"
        @tools@\metamp3.exe %Cover_tag% %VA_tag% %Disc_MP3% --artist "@artist@" --album "@album@" --track $track$ --title "@title@" --year "@year@" --genre "@genre@" "%TrackName%.mp3"
        @ECHO OFF
        IF @Debug@==1 ECHO ON
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_lame_tracks

REACT 2 Released

Reply #1328 –
Just found something else. I had an older version of metamp3.exe than SS was showing in his output, so I got the newer one ("metamp3.exe"). My last run through REACT\EAC added NO TAGS to my MP3s except for the gain info.

REACT 2 Released

Reply #1329 –
Quote from: UberNewf on
It is STILL not working though the whole automation process though. I even did what you said below:

I tested and found out that the 0.91 version does seem to handle "--track $track$" as an integer and thus it strips the leading zero away. Using "--track $track$/$numtracks$" would work since it's a string, not integer. Anyways, I tested also the 0.92b5 and I can confirm that the "--track $track$" works with that version, it leaves the zero-pads there.

Quote from: UberNewf on
I got the newer one ("metamp3.exe"). My last run through REACT\EAC added NO TAGS to my MP3s except for the gain info.

The command line options did change between those versions. A quote from a line below the "Latest beta:" download link: "(note that some command line options has changed, and are not backward compatible)".. missed that? The metamp3.exe command fails and tags are not saved, RG gets tagged as that tagging is run separately without failing options.

So, you have to change the following line:
Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"

to:
Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--frame "APIC{3}:@cover@"

Now all should work. Happy REACTing.. hopefully this time.

REACT 2 Released

Reply #1330 –
Yep, looks like we've covered it all. Thanks VERY much!

I am looking for a way to poke "AlbumArtist" into the MP3s now....

REACT 2 Released

Reply #1331 –
Quote from: UberNewf on
Yep, looks like we've covered it all. Thanks VERY much!

I am looking for a way to poke "AlbumArtist" into the MP3s now....

Shit, I missed this:
Code: [Select]
IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"

The "--user-text" option doesn't work with 0.92b5. It's used in couple of other places too in image.cfg and it should be changed.

Would changing all of them to "TXXX" frames work?? (e.g. --frame "TXXX[album artist]:@VA@") Could someone confirm this? Thanks.

REACT 2 Released

Reply #1332 –
Various Artists VDs don't seem to work at all (I gues that may be what you are saying). I just treid one and there are no tags at all in the files.

I am not sure how to test your fix, sorry.

REACT 2 Released

Reply #1333 –
Quote from: UberNewf on
I am not sure how to test your fix, sorry.

I was asking for others to help us in this matter since I'm not an expert with Mp3 tags/whatever mess.. I'm a FLAC man myself, tagging those are much easier.

You could try changing the:
Code: [Select]
IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"

to:
Code: [Select]
IF @various@==1 SET VA_tag=--frame "TXXX[album artist]:@VA@" --frame "TPE2:@VA@"

And see if that works out (it shouldn't error out, but does it work as intended in various players (soft/hardware)? I don't know, sorry). So, I really would like someone to confirm this, until that, use it with caution.

REACT 2 Released

Reply #1334 –
That worked for my Various Artist CD -> MP3s, yes. Good call. I'd like to have the "Album Artist" tag populated for single artist CDs as well though - with the same value poked in for "Artist" I guess. I tried adding it to the command line like so:

Code: [Select]
@tools@\metamp3.exe %Cover_tag% %VA_tag% %Disc_MP3% --artist "@artist@" --album "@album@" --track "$track$" --album artist "@artist@"...



But it did not work. 

REACT 2 Released

Reply #1335 –
Quote from: UberNewf on
I'd like to have the "Album Artist" tag populated for single artist CDs as well though - with the same value poked in for "Artist" I guess.
I don't see the benefit of doing so but here's a way to do it:
Code: [Select]
IF @various@==0 SET VA_tag=--frame "TXXX[album artist]:@artist@" --frame "TPE2:@artist@"
Add this line after the "IF @various@==1..." line in the Mp3 section.[/s]

Edit: Synthetic Soul's solve is much better, use it.

@Synthetic Soul: (EDIT2: I saw your edit too late) can you confirm that I think that the change from --user-text "[album artist]@VA@" to --frame "TXXX[album artist]:@VA@" is a working solution.. I guess it is because "TXXX = User defined text information frame" and what have we got in the 0.91 version? --user-text option.

REACT 2 Released

Reply #1336 –
Use @cdartist@ in place of @va@, i.e.:

Code: [Select]
--frame "TXXX[album artist]:@cdartist@" --frame "TPE2:@cdartist@"

Edit: Easily beaten to the punch by Akkurat.  I was checking the ID3v2 spec as I'm surprised that there is no proper T frame for album artist. I couldn't find one though.
I'm on a horse.

REACT 2 Released

Reply #1337 –
The value (or need, in my case) of adding Album Artist to all my MP3 is that I use Winodws Media Center extensivly and that UI uses that tag to list albums for a particular artist when in artist view. Without the Albumn Artist tag in all my MP3s, that sort is broken.

My LAME section in REACT-track.cfg now looks like this and seems to be working for both SA and VA CDs:

Code: [Select]
IF NOT @LameMP3@==1 GOTO end_lame_tracks
    IF NOT EXIST %TrackDir_MP3% MKDIR %TrackDir_MP3%
    PUSHD %TrackDir_MP3%
        IF @various@==1 SET VA_tag=--frame "TXXX[album artist]:@VA@" --frame "TPE2:@VA@"
    IF %embed_cover%==1 SET Cover_tag=--frame "APIC{3}:@cover@"
        ECHO ON
        @tools@\lame.exe @Opt_LameMP3@ "@source@" "%TrackName%.mp3"
        @tools@\metamp3.exe %Cover_tag% %VA_tag% %Disc_MP3% --artist "@artist@" --album "@album@" --track "$track$" --title "@title@" --year "@year@" --genre "@genre@" --frame "TXXX[album artist]:@cdartist@" --frame "TPE2:@cdartist@" "%TrackName%.mp3"
        @ECHO OFF
        IF @Debug@==1 ECHO ON
        IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
    POPD
:end_lame_tracks


Thanks for all the help guys!!

REACT 2 Released

Reply #1338 –
Quote from: Akkurat on
@Synthetic Soul: (EDIT2: I saw your edit too late) can you confirm that I think that the change from --user-text "[album artist]@VA@" to --frame "TXXX[album artist]:@VA@" is a working solution.. I guess it is because "TXXX = User defined text information frame" and what have we got in the 0.91 version? --user-text option.
I'm sorry Akkurat, the reason that I did not get involved in this before is that I really don't know.  Your assumption/conclusion seems right to me though.
I'm on a horse.

REACT 2 Released

Reply #1339 –
Quote from: UberNewf on
The value (or need, in my case) of adding Album Artist to all my MP3 is that I use Winodws Media Center extensivly and that UI uses that tag to list albums for a particular artist when in artist view. Without the Albumn Artist tag in all my MP3s, that sort is broken.

Thanks for letting me know. I wonder if the stock configs should be changed to include the single artist in the "album artist" tag.. can't see why that would be harmful, only useful. Comments are welcome. If there's no objection to this, I'm going to add it into my ToDo list.

Quote from: UberNewf on
My LAME section in REACT-track.cfg now looks like this and seems to be working for both SA and VA CDs:

There's a little problem with your config at the moment: you're tagging "TXXX[album artist]" and "TPE2" twice when ripping VA albums. Sorry for confusing you, our previous answers were a bit vague.

Remove the IF @various@==1 SET VA_tag=--frame "TXXX[album artist]:@VA@" --frame "TPE2:@VA@" line completely and remove the %VA_tag% from the metamp3.exe line.

REACT 2 Released

Reply #1340 –
No worries at all - glad for all the help. I have updated my .cfg.

I imagine another forum / thread is the better place for this new issue, but I figured I'd bring it up. EAC does not seem to like *all* my CDs. I have some CDs that are archives of CDs that I lost in a fire and EAC does not rip them. Well, let me be more specific... EAC makes .WAVs out of them, but the cmd window for the .cfg file never spawns. I never get MP3s. Other CDs like this only produce a few MP3. If I look at the EAC window the ones that were fully processed into MP3s have values in the "Read CRC" column while the "skipped" ones don't. The one definitive difference between the CDs that fully process and the ones that don't is that the *bad* ones are archives.

I bet it's some config in EAC but I can't see it. Any ideas (or suggestion for a better thread)?

REACT 2 Released

Reply #1341 –
Quote from: UberNewf on
I bet it's some config in EAC but I can't see it. Any ideas (or suggestion for a better thread)?

Maybe "EAC Options -> Extraction -> Skip track on read or sync errors"?
 

REACT 2 Released

Reply #1342 –
Quote from: Akkurat on
I wonder if the stock configs should be changed to include the single artist in the "album artist" tag.. can't see why that would be harmful, only useful. Comments are welcome. If there's no objection to this, I'm going to add it into my ToDo list.
I use the ARTIST and ALBUM ARTIST fields in foobar to determine whether is file is VA when renaming (only my VA tracks have an ALBUM ARTIST field).

I'm not sure whether this is standard practise or not.  It appears from testing that the "Title / Track Artist" column in the DUI checks whether ARTIST = ALBUM ARTIST and renders the track artist as well as the title if the values are inequal.  This would continue to work if you made the change, so maybe it's no big deal.

I guess it mainly comes down to whether most users always use both fields, or most work like me.  I have a feeling I chose my standard for a reason, but I can't be sure.
I'm on a horse.

REACT 2 Released

Reply #1343 –
Thanks for the feedback. I tried to think of a situation where that amend would pose a problem but can't think of any. Tough call. Your last line made me also unsure of this. Maybe the status quo is good enough. And I can't remember a flood of messages concerning this topic (and I've read this whole topic.. 1343 posts btw currently, that's a lot).

REACT 2 Released

Reply #1344 –
Hi, I have just noticed that the username that is set in the react.ini file does not get fully added to my flac and mp3 files in the "Encoded by" tag. My username is set to christianname surname - WITH a space in between, but all I am getting in my flac and mp3 files in the "Encoded by" tag is my christianname. It does not seem to like the space or anything after it. I am sure this used to work OK when I first tested REACT2. Has something changed in the latest build - I am using akku.B03 build.

My name is not in quotes in the react.ini file and never has been. I can't see that it relates to this since Opt_LameMP3_tag=-b 320 and this gets populated into the "Encoder settings" tag OK and there is a space between the b and the 3

Any ideas

REACT 2 Released

Reply #1345 –
There's no "username/encoded-by" setting in INI file. Have you modified the INI and config files? The username is only put to tags in stock config files; FLAC: -T encoded-by="%USERNAME%" ... MP3: --frame TENC:"%USERNAME%". Notice how that username variable is wrapped between quotes?

REACT 2 Released

Reply #1346 –
Quote from: Akkurat on
There's no "username/encoded-by" setting in INI file. Have you modified the INI and config files? The username is only put to tags in stock config files; FLAC: -T encoded-by="%USERNAME%" ... MP3: --frame TENC:"%USERNAME%". Notice how that username variable is wrapped between quotes?
Ah yes its coming back to me now. I was trying to get a different "encoded-by" name to come out about 18 months ago, without success and I must have left the code in the ini file!
What has happened here is I recently had to have a new hard disk and when it was setup my username was setup differently in XP (ie without my surname). I am assuming this is where the USERNAME comes from.
Having said this I have now managed to get the full name to come out by putting a SET USERNAME command into the top of the cfg file.
Thanks

REACT 2 Released

Reply #1347 –
Just hit another problem with an album title that has an & in it. REACT does not seem to like this and fails to complete the encoding process. Other than changing the album title to "and" is there another way to get REACT to work with & characters in either the artist, album or track title fields. I am using the react-image.cfg

Thanks

REACT 2 Released

Reply #1348 –
Ampersands work ok in REACT. In example I've ripped "Coldplay - X&Y" and "Earth, Wind & Fire" without any problems. Have you amended the react-image.cfg file? Please try with the stock .cfg files.

REACT 2 Released

Reply #1349 –
Yes I have amended the react-image.cfg file. I am trying to point to existing cover art as follows:

SET cover=I:\TODO\$cdartist$\$cdartist$ - $year$ - $album$.jpg
SET cover_small=I:\TODO\1AlbumArtSmall\$cdartist$ - $year$ - $album$.jpg

I have put the above at the top of the react-image.cfg file

This has worked fine until I get an album with an & in it (ie in $album$). I have an album called Rock & Roll Strategy and I get an error "'Roll' is not recognised as an internal or external command"

I have tried putting $q round this to simulate double quotes but it does not help