Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1280359 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

REACT 2 Released

Reply #1150
I am using replaygain (set to 1 in the ini file) with eac/react. Is it possible to get the album and track RG info added to the cue sheet that is created as well as embedded in the flac image.

Thx

REACT 2 Released

Reply #1151
I am using replaygain (set to 1 in the ini file) with eac/react. Is it possible to get the album and track RG info added to the cue sheet that is created as well as embedded in the flac image.

Thx


AddCuesheetAG     Add Album gain/Album peak values to the cuesheet as REM lines. This implies that WaveGain is ran.

http://wiki.hydrogenaudio.org/index.php?ti...ettings_Section

REACT 2 Released

Reply #1152
AddCuesheetAG Add Album gain/Album peak values to the cuesheet as REM lines. This implies that WaveGain is ran.
http://wiki.hydrogenaudio.org/index.php?ti...ettings_Section
Thanks
I am slightly confused about the difference between Replaygain=1 and UseWaveGain=1. Do they conflict - ie do I have to turn off Replaygain=1. If I do will UseWaveGain give me the same result as RG?

Since I currently have Replaygain=1 set, I assume EAC is calculating the RG values somehow. Does UseWaveGain=1 bypass this and some other application calculates the RG values?

Sorry for the questions, but I am just trying to understand how these RG tags are being calculated

Thx

REACT 2 Released

Reply #1153
Hi everyone

Been using REACT for a long time now and am very happy with it until now. I hadn't used it in several months and when I ran it today I got error on some files but not others. Somehow when the Temporary file name is getting fed to flac for processing the weird characters in the filename are being dropped so FLAC cant find this temporary wav file. (See red highlighted filenames below from DEBUG output )
The file that is actually on the hard drive waiting to be processed is named with the funny characters (  !(>)  for example )  but some how FLAC goes looking for L:\Ripped\Dtmp0-55.wav  Notice that the ! has been stripped out thus FLAC cannot find the file

I have not updated EAC or anything in the REACT folder tree.

Anyone have an idea what may be causing this?
I will give you more information from DEBUG Scripts etc if necessary to solve this


Pertinent DEBUG output below:

L:\Ripped\FLAC\Dave Matthews Band\Dave Matthews Band - 1999 - Listener Supported CD2>E:\PUBLIS~1\AutoFlac\REACT\tools\flac.exe -8 -f  -T artist="Dave Matthews Band" -T a
lbum="Listener Supported CD2" -T tracknumber="3/10" -T title="Two Step" -T date="1999" -T genre="Rock" -T comment="" -T encoded-by="That Guy There ... In Canada Eh" -T en
coding="Flac 1.2.0 -8 -f" "L:\Ripped\Dtmp0-!55.wav" -o "Dave Matthews Band - 1999 - Listener Supported CD2 - 03 - Two Step.flac"

flac 1.2.0, Copyright © 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

ERROR: can't open input file L:\Ripped\Dtmp0-55.wav: No such file or directory
Could Not Find L:\Ripped\Dtmp0-55.wav
Press any key to continue . . .


Thanks for all the great work u folks

REACT 2 Released

Reply #1154
Anyone have an idea what may be causing this?

"L:\Ripped\Dtmp0-!55.wav"

ERROR: can't open input file L:\Ripped\Dtmp0-55.wav: No such file or directory
Could Not Find L:\Ripped\Dtmp0-55.wav

To me this is clearly a problem with FLAC, not REACT. Have you tried with the latest FLAC 1.2.1b?

EDIT: Is the L: drive a network drive? Have you tried to change the target drive to normal local drive?

REACT 2 Released

Reply #1155
Anyone have an idea what may be causing this?

"L:\Ripped\Dtmp0-!55.wav"

ERROR: can't open input file L:\Ripped\Dtmp0-55.wav: No such file or directory
Could Not Find L:\Ripped\Dtmp0-55.wav

To me this is clearly a problem with FLAC, not REACT. Have you tried with the latest FLAC 1.2.1b?



Hi Akkhurst and any others who could chime in here ... Please!?

I have tried Flac 1.2.1b and various others. The killer problem that is confounding me is the fact that this has worked for me since Flac 1.1.2.

Synthetic Soul ? Are you out there? Maybe you can shed some light on this for me? What determines whether the TEMPORARY file generated contains funny characters in the filename? (Sometimes the odd characters are not generated and it is always the same TEMPORARY filename for each file processed no matter how many times the script is run)  On the files where the odd characters are not present all works according to plan.

More to the point why could this suddenly cause me problems after having worked so well for so long. Would there be something I could do to force the TEMPORARY generated file to not contain those characters perhaps?

Sorry to keep hammering at this but I had such a perfect setup going ...

Thanks again folks

REACT 2 Released

Reply #1156
EDIT: Is the L: drive a network drive? Have you tried to change the target drive to normal local drive?


Try the above. If it's a network drive try mapping the drive.

REACT 2 Released

Reply #1157
The temporary file is named by EAC; REACT has no control over it.

Here's what confuses me about your report:  Your FLAC command line, which (presumably) uses @source@, reportedly contains the exclamation mark; however the call to DEL the source file, which results in the line "Could Not Find L:\Ripped\Dtmp0-55.wav"  - which also uses @source@ - does not.

Have you doctored the debug text posted?  We need to know whether @source@ contains the exclamation or not.  It must be one or the other surely?  If you haven't doctored it then there is something extremely weird going on.  Maybe a codepage issue?

I'd like to see the batch file that is run I think.  When debugging I copy the temporary batch file so that I can see the code being run at my leisure.
I'm on a horse.

REACT 2 Released

Reply #1158
Anyone have an idea what may be causing this?

"L:\Ripped\Dtmp0-!55.wav"

ERROR: can't open input file L:\Ripped\Dtmp0-55.wav: No such file or directory
Could Not Find L:\Ripped\Dtmp0-55.wav

To me this is clearly a problem with FLAC, not REACT. Have you tried with the latest FLAC 1.2.1b?

EDIT: Is the L: drive a network drive? Have you tried to change the target drive to normal local drive?

@kami: Please answer here in public forum, not PM's. Thanks. For everybody else: this is not the case here, the drive in question is a local drive.

Next shot in the dark until you post your config files: Are you by any chance using "SETLOCAL ENABLEDELAYEDEXPANSION" in your cfg file? But this is far fetched if your configs are not changed after you had a perfectly working setup. Although we don't know if your previous rips didn't produce temp files with ! chars..

I just ripped a cd which produced a temp file with ! char and everything went smooth as a baby's bum.

REACT 2 Released

Reply #1159
I just ripped a cd which produced a temp file with ! char and everything went smooth as a baby's bum.
I just checked my debugging.txt file and every temp file listed in there has an exclamation mark in it.  As far as I remember mine normally do.  My filenames seem to follow the format: "<first letter of artist>tmp<5 random chars using 0-9/!/->".

Not that this helps really...

The discrepancy with @source@ is a weird one.
I'm on a horse.

REACT 2 Released

Reply #1160
I just ripped a cd which produced a temp file with ! char and everything went smooth as a baby's bum.
I just checked my debugging.txt file and every temp file listed in there has an exclamation mark in it.  As far as I remember mine normally do.  My filenames seem to follow the format: "<first letter of artist>tmp<5 random chars using 0-9/!/->".

Not that this helps really...

The discrepancy with @source@ is a weird one.


Hi folks ... got busy for last coupla days. Anyhow here are my React.ini  and  React-track.cfg.

I have heavily modified the .cfg  but like I said it was working until one day a week ago after not using it for several months. In the config I make calls to several outside programs. One is a very handy tool I bought years ago for search and replace I use it to modify some text in the .cue files

The other is Par to create PARs for archival purposes

My code attempts are probably amateurish but did acheive the results I was after and never generated any type of error until now.
All of the ripping action is taking place on local drives NOT network. This is all on Windows XP Service Pack 2 plus some, but not all updates since Service Pack 2 came out.

Codepage suggestion you made sorta kinda seems to make sense. I did not set that variable you asked about in an earlier post (SETLOCAL ENABLEDELAYEDEXPANSION)

Here is the .ini

Code: [Select]
[Settings]
Version=2.0
ImageExt=wav
ImageNaming=$artist$ - $year$ - $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F6}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=1
CoverDownloader=E:\Publishing\AutoFlac\REACT\coverdownloader\albumart.exe
EAC=E:\Publishing\AutoFlac\Exact Audio\EAC.EXE
Tools=E:\Publishing\AutoFlac\REACT\tools
MinimizeCompressionWindow=0
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=0
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
PlaybackRoot=F:\Lossless
TrackDir_Playback=@PlaybackRoot@\$cdartist$\$cdartist$ - $year$ - $album$
OutRoot=L:\Ripped
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\$cdartist$ - $year$ - $album$
TrackName_SA=$cdartist$ - $year$ - $album$ - $track$ - $title$
TrackName_VA=$album$ - $track$ - $artist$ - $title$
TrackName_SA_acdir=$A - $r - $T - $n - $~t
TrackName_VA_acdir=$~a - $~n - $~T - $~t
CueSheet=@OutRoot@\$album$.cue


[UserSettings]
Debug=1
Comment=
EmbedCover=0
ReplayGain=1
ApplyAlbumGain=1
AdjustAlbumGain_dB=+3.0
AddCuesheetAG=1
UseWaveGainAG=1

Opt_Flac=-8 -f
Opt_Wavpack=-hmy
Opt_LameMP3=-V4 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.2.0
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5
USERNAME=That Guy There ... In Canada Eh
CUE_use_FLAC=1
InfoDocsDir=L:\
InfoDocs=InfoDocs.zip
createinfodocs=0
createlocalcopies=1


and here is the .cfg


Code: [Select]
@ECHO OFF
CHCP 1252
TITLE @track@/@numtracks@ - "@album@"

REM Copyright © Tycho, 2006
REM
REM ** Create compressed audio tracks from ripped .wav tracks.
REM **
REM ** You may consider using image mode (F10)
REM ** as it supports creating tracks via acdir.exe,
REM ** and post-processing will always work (see below).
REM **
REM ** Flac requires flac.exe/metaflac.exe (v1.1.3)
REM ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
REM ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.
REM **
REM ** I prefer applying album gain 92dB to get a reasonable
REM ** volume for my DAP. The RG tags are still relative
REM ** to 89dB SPL, i.e. album gain will be about -3.0dB.



IF @Debug@==1 ECHO ON

SET TrackDir_Flac="@TrackDir_Flac@"
SET TrackDir_Playback="@TrackDir_Playback@"


IF @various@==0 SET TrackName=@TrackName_SA@


IF @various@==1 GOTO various_artist_script





REM ============== Begin Single Artist Script ==================



SET have_cover=0
SET embed_cover=0

IF EXIST "@cover@" (
SET have_cover=1
SET embed_cover=@EmbedCover@
)







REM ---- Track ----


IF NOT @Flac@==1 GOTO single_end_flac_tracks
IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
PUSHD %TrackDir_Flac%
IF @various@==1 SET VA_tag=-T "album artist=@VA@"
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
ECHO ON
@tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="@USERNAME@" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" "@source@" -o "%TrackName%.flac"
@ECHO OFF


POPD

:single_end_flac_tracks


REM ** Delete the source .wav

DEL "@source@"


REM ---- Post-processing ----


rem ** Scan and compute ReplayGain and add cover picture for supported formats.
rem ** NB: The following will only work if at least the last track is selected,
rem ** and it is a regular audio track.

IF NOT @track@==@numtracks@ GOTO single_end_post_process

SET add_rg=@ReplayGain@
SET aac_enc=@NeroAac@
IF @iTunesAac@==1 SET aac_enc=1

IF NOT @ReplayGain@==1 GOTO single_end_RG
SET RG_MetaMP3=--replay-gain
SET RG_MetaFlac=--add-replay-gain
:single_end_RG

IF NOT @ApplyAlbumGain@==1 GOTO single_end_apply_AG
SET RG_MetaMP3=--apply-gain album@AdjustAlbumGain_dB@
SET RG_AacGain=/a /o /c /d @AdjustAlbumGain_dB@
SET add_rg=1

:single_end_apply_AG





REM ** Audio Formats:




IF @Flac@==1 (
PUSHD %TrackDir_Flac%
IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac% "*.flac"
REM COPY /Y "@eaclog@" "@artist@ - @year@ - @album@".log
POPD
)



:single_end_post_process








REM --- :single_CheckForEACwavfiles

IF NOT @track@==@numtracks@ GOTO single_Continue ELSE GOTO single_FinishEncoding



:single_FinishEncoding




PUSHD %TrackDir_Flac%




REM  ---  Grab the EAC Logfile copy to Album directory and rename it
 

  COPY /Y @Outroot@\*.log "@artist@ - @year@ - @album@".log






REM  ---  Insert a zipped informational Document to the tracks Directory if createinfodocs=1 in .ini file


IF NOT @createinfodocs@==1 GOTO single_skip_infodocs



REM  ---  IF NOT EXIST %TrackDir_Flac%\@InfoDocs@ COPY /Y @InfoDocsDir@\@InfoDocs@ "@artist@ - @year@ - @album@ - @InfoDocs@"



:single_skip_infodocs





REM ---  Copy Album Cover to Album Directory and rename it

IF %have_cover%==1 COPY /y "@cover@" "@artist@ - @year@ - @album@".jpg





REM ---  Copy m3u playlist to Album Directory and rename it

REM ---  COPY /Y "@Outroot@\*.m3u" "@artist@ - @year@ - @album@".m3u






REM ---  Duplicate Cue File to Album Directory and use 2nd one to hold paths to the .flac files NOT the now missing .WAV files from EAC's extraction process
REM ---  if set in INI file to do so (using external search and replacer)


COPY /Y "@CueSheet@" "@artist@ - @year@ - @album@.cue"

POPD


IF NOT @CUE_use_FLAC@==1 GOTO single_end_CUE_use_FLAC


COPY /Y "@CueSheet@" "@TrackDir_Flac@\@artist@ - @year@ - @album@ - FLAC.cue"


"E:\Program Files\Search Replace\SR32.EXE" /p"@TrackDir_Flac@\*FLAC.cue" /s.wav /r.flac /q

:single_end_CUE_use_FLAC





REM ---  Fix paths in m3u file and change cue sheets to point to .flac instead of wave
REM ---  The following playlist path fix is REM because I generate after using external program.

REM ---  "E:\Program Files\Search Replace\SR32.EXE" /p"@TrackDir_Flac@\*.m3u" /s.eac /r.flac /q






REM  ---  Copy flacs jpg and logfile to Users normal Playback directory if createlocalcopies=1 in .ini file



IF NOT @createlocalcopies@==1 GOTO single_create_pars


IF NOT EXIST %TrackDir_Playback% MKDIR %TrackDir_Playback%


COPY /Y "@TrackDir_Flac@\*.flac" "@TrackDir_Playback@\*.flac"
COPY /Y "@TrackDir_Flac@\*.jpg" "@TrackDir_Playback@\*.jpg"
COPY /Y "@TrackDir_Flac@\*.log" "@TrackDir_Playback@\*.log"



:single_create_pars





REM  ---  Create PAR recovery files for all the .flac files


par2 create -s307200 -r10 "@TrackDir_Flac@\@artist@ - @year@ - @album@".par2 "@TrackDir_Flac@"\*.flac


REM  ---  Cleanup the working Directory


del /Q @Outroot@\*.*
REM  ---  del /Q @Outroot@\*.jpg
REM  ---  del /Q @Outroot@\*.cue
REM  ---  del /Q @Outroot@"\*.m3u
REM  ---  del /Q @Outroot@"\*.log
RMDIR /S/Q @Outroot@\Temp



:single_Continue





IF @Debug@==1 (
PAUSE
EXIT
)




REM ** Delete this .bat file:
DEL %0




REM  ---  This loop will pause the creation of the PAR files in case EAC extraction falls behind.
REM  ---  PARS get created when the last wav file has been processed from the @Outroot@ directory


:single_Pause


REM  ---  ECHO Waiting for EAC to catch up ...
REM  ---  PING 1.1.1.1 -n 1 -w 10000 >NUL



REM  ---  GOTO single_sourcecheck







REM ================ End Single Artist Script ===================









REM ============== Begin Various Artist Script ==================


:various_artist_script


IF @various@==1 SET TrackName=@TrackName_VA@






SET have_cover=0
SET embed_cover=0

IF EXIST "@cover@" (
SET have_cover=1
SET embed_cover=@EmbedCover@
)



ECHO Waiting for file to be written ...
PING 1.1.1.1 -n 1 -w 10000 >NUL



REM ---- Track ----


IF NOT @Flac@==1 GOTO various_end_flac_tracks
IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
PUSHD %TrackDir_Flac%
IF @various@==1 SET VA_tag=-T "album artist=@VA@"
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
ECHO ON
@tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T genre="@genre@" -T comment="@comment@" -T encoded-by="@USERNAME@" -T encoding="Flac @Ver_Flac@ @Opt_Flac@" "@source@" -o "%TrackName%".flac







POPD
@ECHO OFF


:various_end_flac_tracks


REM ** Delete the source .wav

DEL "@source@"


REM ---- Post-processing ----


rem ** Scan and compute ReplayGain and add cover picture for supported formats.
rem ** NB: The following will only work if at least the last track is selected,
rem ** and it is a regular audio track.

IF NOT @track@==@numtracks@ GOTO various_end_post_process

SET add_rg=@ReplayGain@
SET aac_enc=@NeroAac@
IF @iTunesAac@==1 SET aac_enc=1

IF NOT @ReplayGain@==1 GOTO various_end_RG
SET RG_MetaMP3=--replay-gain
SET RG_MetaFlac=--add-replay-gain
:various_end_RG

IF NOT @ApplyAlbumGain@==1 GOTO various_end_apply_AG
SET RG_MetaMP3=--apply-gain album@AdjustAlbumGain_dB@
SET RG_AacGain=/a /o /c /d @AdjustAlbumGain_dB@
SET add_rg=1

:various_end_apply_AG





REM ** Audio Formats:




IF @Flac@==1 (
PUSHD %TrackDir_Flac%
IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac% "*.flac"
REM COPY /Y "@eaclog@" "@artist@ - @year@ - @album@".log
POPD
)



:various_end_post_process








REM ---  :various_CheckForEACwavfiles

IF NOT @track@==@numtracks@ GOTO various_Continue ELSE GOTO various_FinishEncoding



:various_FinishEncoding




PUSHD %TrackDir_Flac%




REM  ---  Grab the EAC Logfile copy to Album directory and rename it
 

  COPY /Y @Outroot@\*.log "@artist@ - @year@ - @album@".log






REM  ---  Insert a zipped informational Document to the tracks Directory if createinfodocs=1 in .ini file


IF NOT @createinfodocs@==1 GOTO various_skip_infodocs



IF NOT EXIST %TrackDir_Flac%\@InfoDocs@ COPY /Y @InfoDocsDir@\@InfoDocs@ "@artist@ - @year@ - @album@ - @InfoDocs@"



:various_skip_infodocs





REM ---  Copy Album Cover to Album Directory and rename it

IF %have_cover%==1 COPY /y "@cover@" "@artist@ - @year@ - @album@".jpg



REM ---  Copy m3u playlist to Album Directory and rename it

REM ---  COPY /Y "@Outroot@\*.m3u" "@artist@ - @year@ - @album@".m3u






REM ---  Duplicate Cue File to Album Directory and use 2nd one to hold paths to the .flac files NOT the now missing .WAV files from EAC's extraction process
REM ---  if set in INI file to do so (using external search and replacer)



COPY /Y "@CueSheet@" "@artist@ - @year@ - @album@.cue"

POPD


IF NOT @CUE_use_FLAC@==1 GOTO various_end_CUE_use_FLAC



COPY /Y "@CueSheet@" "@TrackDir_Flac@\@artist@ - @year@ - @album@ - FLAC.cue"


"E:\Program Files\Search Replace\SR32.EXE" /p"@TrackDir_Flac@\*FLAC.cue" /s.wav /r.flac /q




:various_end_CUE_use_FLAC



REM ---  Fix paths in m3u file and change cue sheets to point to .flac instead of wave
REM ---  The following playlist path fix is REM because I generate after using external program.

REM ---  "E:\Program Files\Search Replace\SR32.EXE" /p"@TrackDir_Flac@\*.m3u" /s.eac /r.flac /q



REM  ---  Copy flacs jpg and logfile to Users normal Playback directory if createlocalcopies=1 in .ini file



IF NOT @createlocalcopies@==1 GOTO various_create_pars




IF NOT EXIST %TrackDir_Playback% MKDIR %TrackDir_Playback%


COPY /Y "@TrackDir_Flac@\*.flac" "@TrackDir_Playback@\*.flac"
COPY /Y "@TrackDir_Flac@\*.jpg" "@TrackDir_Playback@\*.jpg"
COPY /Y "@TrackDir_Flac@\*.log" "@TrackDir_Playback@\*.log"



:various_create_pars





REM  ---  Create PAR recovery files for all the .flac files


par2 create -s307200 -r10 "@TrackDir_Flac@\@artist@ - @year@ - @album@".par2 "@TrackDir_Flac@"\*.flac


REM  ---  Cleanup the working Directory


del /Q @Outroot@\*.*
REM  ---  del /Q @Outroot@\*.jpg
REM  ---  del /Q @Outroot@\*.cue
REM  ---  del /Q @Outroot@"\*.m3u
REM  ---  del /Q @Outroot@"\*.log
RMDIR /S/Q @Outroot@\Temp



:various_Continue





IF @Debug@==1 (
PAUSE
EXIT
)




REM ** Delete this .bat file:
DEL %0




REM  ---  This loop will pause the creation of the PAR files in case EAC extraction falls behind.
REM  ---  PARS get created when the last wav file has been processed from the @Outroot@ directory


:various_Pause


REM  ---  ECHO Waiting for EAC to catch up ...
REM  ---  PING 1.1.1.1 -n 1 -w 10000 >NUL



REM  ---  GOTO various_sourcecheck







REM ================ End various Artist Script ===================


Thanks again for all of your efforts. Hope you may get a little laugh at all the wacky code I threw in there. :-)

Kami

REACT 2 Released

Reply #1161
My code attempts are probably amateurish but did acheive the results I was after and never generated any type of error until now.
No matter in what shape the code is as long as it's working. Preferences & opinions are like assholes, everyone's got one (at least)... and I know that I'm a big asshole.. *doh* no, I meant to say that I got my own preferences as to what code should look like.. moving on.. here's my notes/questions:

1. Which version are you using? Tycho's original REACT? Synthetic Soul mod (version)?
2. Can you test ripping with the original Tycho/Synthetic Soul cfg file?
3. Can you test your own cfg in another computer?
4. Try changing this command: "CHCP 1252" to "CHCP 1252 | PROMPT" (far fetched but IIRC somebody solved some problem with this)
5. Other problematic lines I found (some are REM lines but still.. + all these lines are found twice in your setup):
Code: [Select]
REM COPY /Y "@eaclog@" "@artist@ - @year@ - @album@".log
COPY /Y @Outroot@\*.log "@artist@ - @year@ - @album@".log
REM  ---  IF NOT EXIST %TrackDir_Flac%\@InfoDocs@ COPY /Y @InfoDocsDir@\@InfoDocs@ "@artist@ - @year@ - @album@ - @InfoDocs@"
IF %have_cover%==1 COPY /y "@cover@" "@artist@ - @year@ - @album@".jpg
REM ---          COPY /Y "@Outroot@\*.m3u" "@artist@ - @year@ - @album@".m3u
COPY /Y "@CueSheet@" "@artist@ - @year@ - @album@.cue"
COPY /Y "@CueSheet@" "@TrackDir_Flac@\@artist@ - @year@ - @album@ - FLAC.cue"
par2 create -s307200 -r10 "@TrackDir_Flac@\@artist@ - @year@ - @album@".par2 "@TrackDir_Flac@"\*.flac
What's problematic? I would use $artist$ - $year$ - $album$ tokens to be safe. (the year token is not really a problem but anyways, it doesn't hurt either)
(any instance of @artist@ in the script will be replaced by the freedb artist name, while $artist$ will be replaced with a filename-friendly version of the artist name (with illegal characters replaced according to your requirements))

Otherwise your cfg seems ok (a bit messy, sorry, but ok). I can't see what's causing your tempfile ! problem. In light of this evidence I've to say that it's not REACT.

EDIT: I'm really puzzled by this problem. Would you like to try this out: make a new test.bat file and put the following into it:
Code: [Select]
ECHO ON

ECHO test > test!file!!name.txt
PAUSE
DEL test!file!!name.txt
PAUSE

CHCP 1252

ECHO test > test!file!!name222.txt
PAUSE
DEL test!file!!name222.txt
PAUSE
Then run it and watch what happens. Does the created files have !-char in them, do they get deleted.. and so on.

REACT 2 Released

Reply #1162
here's my notes/questions:
1. Which version are you using? Tycho's original REACT? Synthetic Soul mod (version)?
Using Tycos Version with EAC V 0.95 Beta 4 (But ... I did install the latest EAC and tried Synthetic Souls Mod .... Same result so I've restored everything to exactly the way it was)
2. Can you test ripping with the original Tycho/Synthetic Soul cfg file?
I tried going back to the original config that came with the download (no modifications). I still set the same directories etc. in the ini file
Code: [Select]
TracksHotVal=+{F6}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=1
CoverDownloader=E:\Publishing\AutoFlac\REACT\coverdownloader\albumart.exe
EAC=E:\Publishing\AutoFlac\Exact Audio\EAC.EXE
Tools=E:\Publishing\AutoFlac\REACT\tools
MinimizeCompressionWindow=0
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=0
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
PlaybackRoot=F:\Lossless
TrackDir_Playback=@PlaybackRoot@\$cdartist$\$cdartist$ - $year$ - $album$
OutRoot=L:\Ripped
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\FLAC\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_Wavpack=@OutRoot@\WV\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\$cdartist$ - $year$ - $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\$cdartist$ - $year$ - $album$
TrackName_SA=$cdartist$ - $year$ - $album$ - $track$ - $title$
TrackName_VA=$album$ - $track$ - $artist$ - $title$
TrackName_SA_acdir=$A - $r - $T - $n - $~t
TrackName_VA_acdir=$~a - $~n - $~T - $~t
CueSheet=@OutRoot@\$album$.cue


[UserSettings]
Debug=1
Comment=
EmbedCover=0
ReplayGain=1
ApplyAlbumGain=1
AdjustAlbumGain_dB=+3.0
AddCuesheetAG=1
UseWaveGainAG=1

Opt_Flac=-8 -f
Opt_Wavpack=-hmy
Opt_LameMP3=-V4 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.2.0
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5
USERNAME=
CUE_use_FLAC=0
InfoDocsDir=L:\
InfoDocs=InfoDocs.zip
createinfodocs=0
createlocalcopies=0

but still got bad result as shown here ...

L:\Ripped\FLAC\Aerosmith\Aerosmith - 1994 - Big Ones>E:\PUBLIS~1\AutoFlac\REACT\tools\flac.exe -8 -f  -T artist="Aerosmith" -T album="Big Ones" -T tracknumber="2/15" -T
title="Love In An Elevator" -T date="1994" -T genre="Rock" -T comment="" -T encoded-by="lloyd" -T encoding="Flac 1.2.0 -8 -f" "L:\Ripped\Atmp0-!55.wav" -o "Aerosmith - 19
94 - Big Ones - 02 - Love In An Elevator.flac"

flac 1.2.0, Copyright © 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

ERROR: can't open input file L:\Ripped\Atmp0-55.wav: No such file or directory
Could Not Find L:\Ripped\Atmp0-55.wav
Press any key to continue . . .

3. Can you test your own cfg in another computer?
Well ... wouldn't ya know it .... tried on my wifes old clunker of a machine  AMD processor not Intel like mine Same XP Pro SP2 etc.  and BANG !  Worked fine. Thats with all of my script mods intact the only things I changed were the directory paths. I also turned of the generation of par files and creation of a archive copy of the files. Upon this success I went back to my machine and turned that stuff off re-ran but still got same ! error.
DAMN !!!
4. Try changing this command: "CHCP 1252" to "CHCP 1252 | PROMPT" (far fetched but IIRC somebody solved some problem with this)
Didn't try this yet ... early day tomorrow and now its bedtime. (I will re-run with this in next coupla days)
EDIT: I'm really puzzled by this problem. Would you like to try this out: make a new test.bat file and put the following into it:
Code: [Select]
ECHO ON

ECHO test > test!file!!name.txt
PAUSE
DEL test!file!!name.txt
PAUSE

CHCP 1252

ECHO test > test!file!!name222.txt
PAUSE
DEL test!file!!name222.txt
PAUSE
Then run it and watch what happens. Does the created files have !-char in them, do they get deleted.. and so on.
Tried this .bat test and it created and deleted the files BUT and I repeat ... BUT  The files were created without the ! in the filename. They were however also successfully searched for and deleted by the script even though the ! had been somehow stripped out of the name

Is this all just some freakass joke by Billy Boy Gates? Some update to XP that my Wife doesn't have that is messing with file naming etc?
SHEESH ... I dunno. Feel really dumb .... So close to working, yet so far.

In a streak of brilliant genius I realized that I had added some "environment variables" to Windows itself, pointing to my REACT directories etc. so some other scripts I run could easily find things .... I removed them and tried REACT again thinking YEAH ... this'll fix it.

NO GO

Well ... Thanks again folks I hope you don't get tired of hearing from me quite yet. I have a coupla more ideas but am busy on/off for next few days. I'll try to take some time tomorrow to do a little more on this.

I have to assume I am the only one to EVER have such a weird thing goin' on ??

REACT 2 Released

Reply #1163
3. Can you test your own cfg in another computer?

Well ... wouldn't ya know it .... tried on my wifes old clunker of a machine  AMD processor not Intel like mine Same XP Pro SP2 etc.  and BANG !  Worked fine.

I knew it. It's definitely not REACT.

4. Try changing this command: "CHCP 1252" to "CHCP 1252 | PROMPT" (far fetched but IIRC somebody solved some problem with this)

Didn't try this yet ... early day tomorrow and now its bedtime. (I will re-run with this in next coupla days)

You can try but I bet that it doesn't change anything.

Tried this .bat test and it created and deleted the files BUT and I repeat ... BUT  The files were created without the ! in the filename. They were however also successfully searched for and deleted by the script even though the ! had been somehow stripped out of the name

Just as I expected. Back to my earlier hunch about "SETLOCAL ENABLEDELAYEDEXPANSION". Try this test.bat:
Code: [Select]
ECHO ON
SETLOCAL DISABLEDELAYEDEXPANSION

ECHO test > test!file!!name.txt
PAUSE
DEL test!file!!name.txt
PAUSE

I'm willing to bet my slippers that this works.  I suggest that you take a closer look in your "environment variables". PROMPT is a good starting point (type SET in dos prompt).

REACT 2 Released

Reply #1164
It looks like Akkurat hit the nail on the head previously.

I can only assume that EnableDelayedExpansion has been set.  I know that you can set it by calling CMD with /v; perhaps there is a way to set this by default?

Try adding:

Code: [Select]
SETLOCAL DisableDelayedExpansion

... to the top of your config.

You should try adding it to the top of that batch file as your initial test.

Edit: Oops, too slow!
I'm on a horse.

REACT 2 Released

Reply #1165
@kami:

I can only assume that EnableDelayedExpansion has been set.  I know that you can set it by calling CMD with /v; perhaps there is a way to set this by default?

Check this: goto Control Panel -> System -> Advanced (tab) -> Environment Variables. Find the "ComSpec" system variable and see if that has a "%SystemRoot%\system32\cmd.exe" value WITH /v switch.

Try adding:

Code: [Select]
SETLOCAL DisableDelayedExpansion

... to the top of your config.

You should try adding it to the top of that batch file as your initial test.

Yes absolutely.. but only to test it! You really should find a way to set this behaviour off by default since this could affect many other things.

REACT 2 Released

Reply #1166
Yes absolutely.. but only to test it! You really should find a way to set this behaviour off by default since this could affect many other things.
... as may removing it!
I'm on a horse.

REACT 2 Released

Reply #1167
I can only assume that EnableDelayedExpansion has been set.  I know that you can set it by calling CMD with /v; perhaps there is a way to set this by default?

Check this: goto Control Panel -> System -> Advanced (tab) -> Environment Variables. Find the "ComSpec" system variable and see if that has a "%SystemRoot%\system32\cmd.exe" value WITH /v switch.

The COMSPEC was set as normal without the /v switch nowhere else in there did I see anything related.
Any thoughts on this? Can this be set in the Windows Registry? I did install Perl for Windows recently. Any chance that may have set something somewhere?
Try adding:

Code: [Select]
SETLOCAL DisableDelayedExpansion

... to the top of your config.

You should try adding it to the top of that batch file as your initial test.

Yes absolutely.. but only to test it! You really should find a way to set this behaviour off by default since this could affect many other things.

BANG ! Adding
Code: [Select]
SETLOCAL DisableDelayedExpansion
to the top of my .cfg worked like a charm
Well well ... Sure is nice of you to take YOUR time to solve MY problem. I just ripped a couple of CD's 1 Single artist and 1 various Artist. Ripped like a charm as it always used to.
I would by you a drink or somesuch but you are there and I am here. so what are the alternatives? Is there a Paypal way; or similar, for me to send a small (I'm not rich) pittance to both of you as a token of appreciation?

Thank you again from Vancouver Canada

REACT 2 Released

Reply #1168
The COMSPEC was set as normal without the /v switch nowhere else in there did I see anything related.
Any thoughts on this? Can this be set in the Windows Registry? I did install Perl for Windows recently. Any chance that may have set something somewhere?

I don't know. This is where my knowledge ends.. and I didn't find anything googling quickly. Sorry. I hope you find a better forum to resolve this... or install your OS again.

BANG ! Adding SETLOCAL DisableDelayedExpansion to the top of my .cfg worked like a charm
Well well ... Sure is nice of you to take YOUR time to solve MY problem. I just ripped a couple of CD's 1 Single artist and 1 various Artist. Ripped like a charm as it always used to.
I would by you a drink or somesuch but you are there and I am here. so what are the alternatives? Is there a Paypal way; or similar, for me to send a small (I'm not rich) pittance to both of you as a token of appreciation?

Thank you again from Vancouver Canada

Great that we found the problem. Thank you is enough for me.. thanks.  It's nice to feel & see that my presence on this wonderful earth is sometimes filled with altruistic intentions. I find new strength to continue my journey to save the earth & humankind (quite a difficult feat).  We can afford to be more altruistic than nature's other animals.. and we should use that advantage more often.. AND direct that to nature itself.

REACT 2 Released

Reply #1169
My beloved fellow REACT users: Has the album art retriever stopped working for you? It seems the amazon scripts enabled by default have been turning up 503 errors lately. Is there a remedy? I'd rather not update to the latest cover downloader, since it takes up so much ram and has such a long startup time...

REACT 2 Released

Reply #1170
My beloved fellow REACT users: Has the album art retriever stopped working for you? It seems the amazon scripts enabled by default have been turning up 503 errors lately. Is there a remedy? I'd rather not update to the latest cover downloader, since it takes up so much ram and has such a long startup time...


I have no problems with V12 or 15. Version 15 starts quicker for me.

REACT 2 Released

Reply #1171
Personally I still use version 0.5, which (only) requires .NET 2.0. I've packaged this with updated boo scripts that all works well, including amazon. I've also included a wrapper : AlbumArtX.exe which calls AlbumArt.exe v0.5, but it accepts command line switches /artist, /album, /path, /ar, /al, /p, and switches with -. It also accepts command line: AlbumArtX.exe <artist> <album> <path>. Set the AlbumArt path in REACT to point to <path>\AlbumArtX.exe, and it should work.

Edit: I've reuploaded the package, and renamed the original AlbumArt.exe to AlbumArt_05.exe, and the wrapper is now called AlbumArt.exe, so it will work as a drop-in replacement.

Get it here.

 

REACT 2 Released

Reply #1172
Personally I still use version 0.5, which (only) requires .NET 2.0. I've packaged this with updated boo scripts that all works well, including amazon. I've also included a wrapper : AlbumArtX.exe which calls AlbumArt.exe v0.5, but it accepts command line switches /artist, /album, /path, /ar, /al, /p, and switches with -. It also accepts command line: AlbumArtX.exe <artist> <album> <path>.

Set the AlbumArt path in REACT to point to <path>\AlbumArtX.exe, and it should work.

Get it here.


Very excellent tycho, thanks. I'll make good use of it
Is this on the wiki anywhere? It seems like a glove-fit for react users for which the slower startup times of XUI are unacceptable.

REACT 2 Released

Reply #1173
Very excellent tycho, thanks. I'll make good use of it
Is this on the wiki anywhere? It seems like a glove-fit for react users for which the slower startup times of XUI are unacceptable.

You're welcome. I have uploaded a small modification to make it a little simpler. See the edit in my previous post. It's not on the wiki yet.

REACT 2 Released

Reply #1174
Got another question (been awhile!);

I had been using "$album$.[MG].cue" to reference cuesheets, but I realize this is not always accurate as the $album$ token will do character replacements according to react preferences and not necessarily match 1:1 with EAC's replacements.

Which variable would be best to use in this instance?

does EAC, for cuefiles (created automatically) replace all illegal characters with spaces, or does it use the conversion table it uses for tracknames?

I see a few functions in the code that may help, but I am not sure if there is an existing token that may already do precisely what I need. I'm getting a little caught up between $album, $gui_albumfile, $gui_albumfile2, etc.


EDIT: I think I am asking if there is already a token which basically equals fSubstIllegalCharsWithSpaces(StringReplace($gui_album, '"', "'")) or if I have to add such a token myself.