Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1280415 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

REACT 2 Released

Reply #1075 –
How do I setup REACT to rip a flac image and aac tracks correctly, also having a copy of the eaclog in the aac folder? And adding replaying to both. I'm using nero to encode to aac, version 1.0.7.0

I did manage to move the eaclog to the flac-image, copying the eaclog would not work. This the code I used:

Code: [Select]
MOVE /Y "@eaclog@" %dest%
EDIT: This only worked a couple of times, then I would get an error:Wating for EAClog. Is there a way to copy over the log file??

I've managed through trial an error (lots of errors ) To have flac image and aac tracks. But they are not getting tagged with replaygain. Even tho I have ReplayGain=1 in the ini.  I have aacgain in the tools folder and metaflac, recent versions of both.

The aac tracks they get tagged, but the tags don't show in foobar except for the title and cover. I tried the tracks in itunes and all the tags show in itunes. How is this possible? I tried it with mp3's, they get tagged correctly with replaygain and the rest of the tags.

EDIT found the solution to part of these issues HERE.

But now I get no cover art and still no replaygain for both formats.

TIA

REACT 2 Released

Reply #1076 –
Quote from: Akkurat on
It just occurred to me that where would we actually use that in GSAR? The limitation is: "...length of search or replace buffer must not exceed 128 chars". And of course we can't truncate the search or replace strings. Am I missing something?
No, I am.  I initially meant to push the SUBST solution, but when I realised that your root path was so short  I deferred to the other "solution" in the article.  As you rightly say though: in this instance it is completely useless!

Quote from: Akkurat on
As  for the other points, your suggestion to embed this feature to REACT  sounds good to me... but I'm still waiting for the GSAR authors to  reply.. shouldn't take too long since they responded very quickly to my  last query.

EDIT: Just in, a response from GSAR author. You need to recompile gsar to get longer buffer support. And a very short and easy instructions to change the code. So, what should we do?
If it's easy I would probably say that we adapt GSAR.  Rewriting the functionality into REACT, when GSAR is already there and almost working, doesn't make as much sense to me.
I'm on a horse.

REACT 2 Released

Reply #1077 –
Quote from: m_l on
But now I get no cover art and still no replaygain for both formats.

After reading through a lot of this thread, I can now have a flac image and aac tracks (using nero). The aac tracks getting tagged correctly and with cover art. Below if my is my working code:

Code: [Select]
IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
    SET dest="@TrackDir_AAC@%trackDir%"
    IF NOT EXIST %dest% MKDIR %dest%
    PUSHD %dest%
        IF @various@==1 SET VA_tag=-meta-user:$qalbum artist$q=$q@VA@$q -meta-user:compilation=true
        IF %embed_cover%==1 SET Cover_tag=--artwork $#x
        @tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --extra-opt "@cover@" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\neroAacTag.exe $#o %VA_tag% -meta:artist=$#a -meta:album=$#T -meta:track=$n -meta:totaltracks=$N -meta:title=$#t -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$q@comment@$q & @tools@\AtomicParsley.exe $#o -o REACT_tmp.m4a %Cover_tag% --encodingTool $qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q & MOVE /Y REACT_tmp.m4a $#o" "@sourcecuesheet@"
        IF @ApplyAlbumGain@==1 @tools@\aacgain.exe %ApplyAG_AacGain% *.m4a > gainlog.txt
        REM COPY /Y "@eaclog@" "EAClog.txt"
        IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
    POPD
:end_nero_aac_tracks
 
All of that code is  from drbeachboy's, I just modified a bit to get cover art working. Thank You drbeachboy

I still haven't figuered out why they are not getting tagged with replaygain. Or how I can copy over the eaclog file. Any suggestions?

REACT 2 Released

Reply #1078 –
Oooh. Right. I forgot to mention that tagging issue. Glad you found beachboy's fix...


As for copying EAClog over: It should really be as simple as
Code: [Select]
if "@eaclog@" copy /y "@eaclog@" "$cdartist$ - $album$.log"
somewhere within the code section. you can do it at the end, you can put it inside the tracks section--- whatever gets ya goin

as for ReplayGain...that's not my department. I defer you to Neil's capable, loving hands.

REACT 2 Released

Reply #1079 –
Quote from: nago on
Oooh. Right. I forgot to mention that tagging issue. Glad you found beachboy's fix...


As for copying EAClog over: It should really be as simple as
Code: [Select]
if "@eaclog@" copy /y "@eaclog@" "$cdartist$ - $album$.log"
somewhere within the code section. you can do it at the end, you can put it inside the tracks section--- whatever gets ya goin

as for ReplayGain...that's not my department. I defer you to Neil's capable, loving hands.



Just tried and does not work for me. This is what happens:

The ripping begins fine, I select the cover art, then I get the temp wav file. After that nothing else works I get an error: Waiting for EAC log file....


I added your line in the nero track section as the last line. Now even after I comment out that line, I get the same error message. I've being the same problem when I try to copy the log file. Too fix this now, I delete the .dat files from the eac programs folder. And if that doesn't work I have too unistall eac and delete REACT and start fresh.

REACT 2 Released

Reply #1080 –
Well, if it's waiting for a log to be produced...

...I guess it hasn't created a logfile yet. Maybe it's not autosaving the log? There is an option under the F9 menu (I think in the second tab) that says to automatically create a status report after ripping. Make sure this is checked.

REACT 2 Released

Reply #1081 –
Quote from: Synthetic Soul on
Quote from: Akkurat on
EDIT: Just in, a response from GSAR author. You need to recompile gsar to get longer buffer support. And a very short and easy instructions to change the code. So, what should we do?
If it's easy I would probably say that we adapt GSAR.  Rewriting the functionality into REACT, when GSAR is already there and almost working, doesn't make as much sense to me.
I have recompiled using MinGW, after simply updating the constant PAT_BUFSIZ, and it all appears fine.  I'm using MAX_PATH as the new limit, as IIRC paths longer than this (260 characters) are likely to cause problems elsewhere (LAME for example) in any case.

Anyone have any better ideas?

I don't mind hosting the amended EXE, or we could upload it somewhere here (this thread, the uploads forum, or perhaps even the wiki (not sure)).

Edit: FYI, according to this KB article the maximum length for a command line on Windows is 8191 for XP, or 2047 for Win2K.  So, we could bump it up some if we saw the need.
I'm on a horse.

REACT 2 Released

Reply #1082 –
Quote from: nago on
Well, if it's waiting for a log to be produced...

...I guess it hasn't created a logfile yet. Maybe it's not autosaving the log? There is an option under the F9 menu (I think in the second tab) that says to automatically create a status report after ripping. Make sure this is checked.



Yes I had made sure it was checked off. I just deleted eac and let react alone rebooted, installed eac again like the 10th time today. Made sure it was checked off again, started a rip to test and I get the same error. The only way I have found to fix it is by deleting everything and starting fresh. I want to sort this out it's becoming a pain to delete everything. Thank You for you help!



EDIT: Ok I deleted all the .dat files from eac and deleted the line I added to copy the log file too.It's now working again. The wierd thing is that right after this final rip theres the log file in the temp folder.

REACT 2 Released

Reply #1083 –
After that one rip, the error came back 

REACT 2 Released

Reply #1084 –
Quote from: Synthetic Soul on
I have recompiled using MinGW, after simply updating the constant PAT_BUFSIZ, and it all appears fine.  I'm using MAX_PATH as the new limit, as IIRC paths longer than this (260 characters) are likely to cause problems elsewhere (LAME for example) in any case.

Anyone have any better ideas?

That was it, #define PAT_BUFSIZ  128. Sorry for my late response and not including this in my first post.

Well if you ask me, make it as big as you can, it can be used in whatever situation (think out of our need for filename changing).. IF there's no caveats doing so.. I could ask the author if you can't say for sure that it doesn't matter what size it is set. Let me know, ok?

Quote from: Synthetic Soul on
I don't mind hosting the amended EXE, or we could upload it somewhere here (this thread, the uploads forum, or perhaps even the wiki (not sure)).

I think that it doesn't matter. As long as it downloadable.

REACT 2 Released

Reply #1085 –
I had a look at a few cuesheets amended using SED.  I found a track with an &.  This had an incorrect filename (the amended filename was inserted in the old one where the ampersand was I believe).  I do not have an album with an & or any other problems.  Also I forgot to pick my HD up this morning so I have nothing to hand

Good luck with GSAR.  I am keeping a close eye on the thread.  I can see why you want a solution but in the meantime errors are easily corrected.

REACT 2 Released

Reply #1086 –
Quote from: Akkurat on
Well if you ask me, make it as big as you can, it can be used in whatever situation (think out of our need for filename changing).. IF there's no caveats doing so.. I could ask the author if you can't say for sure that it doesn't matter what size it is set. Let me know, ok?
OK, for now I have updated the buffer size to 1024 (1KiB), and uploaded the source and exe to my website.

If people are happy with it we can put links into the wiki article.
I'm on a horse.

REACT 2 Released

Reply #1087 –
Quote from: pholzmann on
I have a strange one:

* creating flac image and mp3 files
* flac is NOT created, MP3's ARE
* debug run shows the problem but I don't know how to fix it:

- the flac run fails because the eac log file does not exist
- yet the file DOES exist by the time I look

Sounds like a race condition of some kind?

Have others seen this?



I being trying all day still have the same problem as the person above. Except nothing gets created for me. I'm trying to get flac image and aac tracks. Does anybody know how he resolved it?

Here is a link to original post.

Thank You

REACT 2 Released

Reply #1088 –
Sorry to bother everyone here with a very basic question. I've been using REACT for about a week now and it's working brilliantly. Just curious, I am archiving my CDs in FLAC format using one large disc image (no individual tracks) and playing them back in Foobar2000 using cuesheets that are generated when the FLAC is created. Everything is fine, I was just wondering if I can stop REACT from making a separate cuesheet (do I need one if the cuesheets are embedded in the FLAC file?).

Again, I'm sure this is extremely basic, but I can't see the necessity of a separate cuesheet if I have it embedded in the FLAC itself. Am I missing something important? Thanks very much in advance!

SD

REACT 2 Released

Reply #1089 –
I managed to get REACT working on another computer with everything being the same. I have no idea why it will not run on the other PC. Oh well, anyway to add replaygain for both the flac image and aac tracks? I have aacgain and metaflac in tools folder. Do I have to make any changes to the image.cfg?

REACT 2 Released

Reply #1090 –
Quote from: Six Degrees on
Sorry to bother everyone here with a very basic question. I've been using REACT for about a week now and it's working brilliantly. Just curious, I am archiving my CDs in FLAC format using one large disc image (no individual tracks) and playing them back in Foobar2000 using cuesheets that are generated when the FLAC is created. Everything is fine, I was just wondering if I can stop REACT from making a separate cuesheet (do I need one if the cuesheets are embedded in the FLAC file?).

Again, I'm sure this is extremely basic, but I can't see the necessity of a separate cuesheet if I have it embedded in the FLAC itself. Am I missing something important? Thanks very much in advance!

SD


You can use that cuesheet for burning a cd from the flac file. I use BURRRN to accomplish that. After you have burrrn or a burning software that supports cuesheets installed, all you do is double click on the cuesheet and you are ready to make a copy from the flac files.

The cuesheet and the flac image have to be in the same folder in order to work. You can also extract the embedded cuesheet using metaflac. But it's much easier to have it there already. Another is for players that don't read the embedded cuesheet but will read the cuesheet that's in the same folder. For use with Rockbox for instance. Their might be other uses but those are that ones I know.

I would just have their in case I would need it.

REACT 2 Released

Reply #1091 –
Quote from: Six Degrees on
Everything is fine, I was just wondering if I can stop REACT from making a separate cuesheet (do I need one if the cuesheets are embedded in the FLAC file?).
You do not need the external cuesheet if you have it embedded.  To stop it being moved into your folder just remove the line:

Code: [Select]
MOVE /Y "@cuesheet@" %dest%

... in the relevant section - which begins "IF NOT @ImageExt@==flac GOTO end_flac_image" - in your config, or, more preferably, prefix the line with REM to comment it out.

Most people keep it, as it is only a few KiB, and it saves you having to extract it if you need to burn the album to disc in EAC.  Pure laziness I guess.

Quote from: m_l on
I managed to get REACT working on another computer with everything being the same. I have no idea why it will not run on the other PC. Oh well, anyway to add replaygain for both the flac image and aac tracks? I have aacgain and metaflac in tools folder. Do I have to make any changes to the image.cfg?
I'm not actually that up on RG et all.  As far as I can see setting ReplayGain to 1 should calculated RG for your FLAC image.  It looks like you may need ApplyAlbumGain set to 1 to run AacGain.  You may get some more info from the REACT wiki article.
I'm on a horse.

REACT 2 Released

Reply #1092 –
Quote
I'm not actually that up on RG et all. As far as I can see setting ReplayGain to 1 should calculated RG for your FLAC image. It looks like you may need ApplyAlbumGain set to 1 to run AacGain. You may get some more info from the REACT wiki article.
 


I had set up just like that, read the Wiki again but see anything else about RG. No biggie I'll just use foobar.

Thank You

REACT 2 Released

Reply #1093 –
Quote from: Synthetic Soul on
OK, for now I have updated the buffer size to 1024 (1KiB), and uploaded the source and exe to my website.

If people are happy with it we can put links into the wiki article.

Great job. Sorry for my late reaction. I just tested that with a 2147 char length dos command (1024 per search & replace) and it works perfectly.

The author of the GSAR emailed me to inform that he had updated GSAR to 1.21 version with 256 buffer length. He also answered the following to my query about why only 256:
"Double the amount of 128 and half the amount of PATH_MAX on my system.
gsar can use any buffer size as long as the pattern buffer is smaller than the search buffer.
The buffer size should ideally be the size of the system page size.

Anyways, your version with 1024 buffer length is fine by me.

REACT 2 Released

Reply #1094 –
Hi, I am ripping my CD's to flac using REACT 2 modified by Synthetic Soul. using F10 and saving both image and tracks.  I am still up in the air which one I going to save in the long run.  I'm using Foobar for playback.

I save the IMAGE file as Artist - Album.flac & .cue & .log & .jpg.  The IMAGE file broke into tracks is saved as Artist\Album\Song.flac & Artist - Album.jpg & .log.  I did finally figure out how to get album art embedded into my files.

Now my question is about EAC.  I was using v0.95 and when I open Foobar and loaded my image flac I could see all of the songs.  Then I upgraded to v0.99 and  loaded my image flac I only see that one large file, not the tracks like before.  I was thinking I liked the way it was displayed using v0.95, I would like to stay with v0.99 due to added feature such as accuraterip.

I would appreciate any ideal or comments on this.

REACT 2 Released

Reply #1095 –
Quote from: Golfer on
Now my question is about EAC.  I was using v0.95 and when I open Foobar and loaded my image flac I could see all of the songs.  Then I upgraded to v0.99 and  loaded my image flac I only see that one large file, not the tracks like before.
It sounds like the cuesheet is not being embedded in your FLAC file.  Perhaps you can confirm or deny this?

It may be worth setting Debug=1 in your REACT.ini, and then examining the output in the console where your FLAC image is encoded.
I'm on a horse.

REACT 2 Released

Reply #1096 –
Hi,

I'm trying to use React2 with mod to create a flac image and rip to mp3. Problem is when I set "CreateAllCuesheets=1" I get multiple dialog boxes entitled "REACT: Missing Cuesheet" with the message "Unable to move cuesheet. File does not exist". The .cue file is created in the static extraction directory that I define but no other cuesheets. Any suggestions on what I'm doing wrong or how to debug further?

Thanks,
David

REACT 2 Released

Reply #1097 –
Do you want a cuesheet for your MP3s, or are you setting CreateAllCuesheets for the FLAC image?

If you are running in image mode/pressing F10 (which you should be) you do not need to set CreateAllCuesheets to get a cuesheet for the FLAC file - it's created automatically.

If you are actually after a cuesheet for the MP3 tracks then I guess we need to investigate further.  I fail to see why you'd need one though, if you have your FLAC image and cuesheet from which you can burn CDs.
I'm on a horse.

REACT 2 Released

Reply #1098 –
I'll confess that I don't really know whether I want a cuesheet for the mp3s or not but, yes, that is what I was trying to create! I'm using EAC V0.99 prebeta 3 and REACT v2.0.ssb16n. Initially I see a cuesheet with the slightly suspicious name "album..cue" created in the extraction directory. (I say suspicious only because I have no idea what the "" means.) Then I get the error dialogs and if I let it continue then the cuesheet gets copied to the flac image directory with the name "artist - [year] album.cue". Nothing gets created for the mp3s.

Thanks,
David
 

REACT 2 Released

Reply #1099 –
Quote from: Synthetic Soul on
Quote from: Golfer on
Now my question is about EAC.  I was using v0.95 and when I open Foobar and loaded my image flac I could see all of the songs.  Then I upgraded to v0.99 and  loaded my image flac I only see that one large file, not the tracks like before.
It sounds like the cuesheet is not being embedded in your FLAC file.  Perhaps you can confirm or deny this?

It may be worth setting Debug=1 in your REACT.ini, and then examining the output in the console where your FLAC image is encoded.


Thanks for the response Synthetic Soul.  I ran debug per your recommendation and it started working correctly now for some reason.  I did figure out that a cue was being made by using MP3tag to view the tags, here they are listed below, the first is working right in foobar second is not.  It seems that the INDEX 00 are wrong in the 2nd cuesheet.  I don't know what happened to cause this?  I didn't change anything when I ran REACT.

I also have a question about Albumart being embedded, I have no problem with it when I go on the internet.    It get download into the temp dir and REACT does it thing.  What I looking to do is use some of my pics I have on my computer,my pics are saved as "Artist - Album.jpg" but when Albumart put their pic into the temp dir they are called "Album.jpg".  Can I edit REACT to use "Artist - Album.jpg"?

Code: [Select]
FILE "Steve Miller Band - Greatest Hits 1974-78.flac" WAVE
  TRACK 01 AUDIO
    TITLE "Swingtown"
    PERFORMER "Steve Miller Band"
    INDEX 01 00:00:00
  TRACK 02 AUDIO
    TITLE "Jungle Love"
    PERFORMER "Steve Miller Band"
    INDEX 00 03:27:57
    INDEX 01 03:29:10
  TRACK 03 AUDIO
    TITLE "Take The Money And Run"
    PERFORMER "Steve Miller Band"
    INDEX 00 06:37:52
    INDEX 01 06:38:35

FILE "Steve Miller Band - Greatest Hits 1974-78.flac" WAVE
  TRACK 01 AUDIO
    TITLE "Swingtown"
    PERFORMER "Steve Miller Band"
    INDEX 01 00:00:00
  TRACK 02 AUDIO
    TITLE "Jungle Love"
    PERFORMER "Steve Miller Band"
    INDEX 00 05:19:24
    INDEX 01 03:29:10
  TRACK 03 AUDIO
    TITLE "Take The Money And Run"
    PERFORMER "Steve Miller Band"
    INDEX 00 08:29:19
    INDEX 01 06:38:35