Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1280423 times) previous topic - next topic
0 Members and 4 Guests are viewing this topic.

REACT 2 Released

Reply #950
1) I didn't know they weren't tokenized, thanks for correcting me. They are likely not tokenized because Tycho had no need to use any of those settings in the .cfg file. Sorry if you're pining to use them...

2) The REACT.CUE you're seeing is a file that synthetic soul's mod adds to "glean information from", it's not actually @cuesheet@, it's just a supplemental file that react uses to find data. It should clean it up on its own, I think. @cuesheet@ resolves to nothing in tracks mode because by default, no cuesheet is produced (in a usable form) to be copied to the track directories, whereas in image mode, a cuesheet is certainly required to make any use of the image.

3) If you want to copy a cuesheet to your track directories, you can always enable CreateAllCuesheets and then use $album$[m|mc|mg|s].cue to keep track of it.

REACT 2 Released

Reply #951
1) I didn't know they weren't tokenized, thanks for correcting me. They are likely not tokenized because Tycho had no need to use any of those settings in the .cfg file. Sorry if you're pining to use them...

I am definitely pining for them...

2) The REACT.CUE you're seeing is a file that synthetic soul's mod adds to "glean information from", it's not actually @cuesheet@, it's just a supplemental file that react uses to find data. It should clean it up on its own, I think. @cuesheet@ resolves to nothing in tracks mode because by default, no cuesheet is produced (in a usable form) to be copied to the track directories, whereas in image mode, a cuesheet is certainly required to make any use of the image.

Hmm, I don't think it's ever cleaned up in track mode.  I'll try a full track set rip again to be sure, but I think I've been deleting it manually in track mode. The last track does the replay gain stuff, but I don't believe it cleans up REACT.cue.  My track.cfg has some debug code in it that slows it down, so I think I'll get some sleep and check tomorrow.  It is cleaned up in image mode, though.

Thanks nago,
dd_wizard

REACT 2 Released

Reply #952
Album Art XUI is great, thanks for the help setting it up. After switching to that I've only found a couple of albums were I've had to access local album art. All the extra sites that can be successfully accessed by its up to date scripts, particularly Rate Your Music, have made it much less necessary. Have you considered bundling XUI with REACT and making it the default?

I've noticed a minor problem with file naming now that I'm actually getting down to ripping my collection:

Sometimes the album date isn't being added to image filenames. I have "ImageNaming=$artist$ - ($year$) - $album$" in my REACT.ini and most of the time it works, but intermittently it's missed out. In all cases the date is correctly added to "REM DATE" in the cue sheet, and it's correctly displayed when the files are open in Foobar. In fact that's why I didn't notice that it was happening for a while, I just rescanned the media library in Foobar to refresh the Album List, then checked the tags/cue sheet there.

I can't work out why this is handled correctly with some yet not with others. For example I ripped several albums by the same artist, all with the date entered correctly in EAC, and without closing REACT/EAC or changing any settings between rips, yet one of the rips lacks a date in the filename.

Of course it's not a major issue since I use Foobar to organise and play the files and they're displayed correctly there. Correcting it completely is just a matter of changing the file names and updating the external cue sheet. Still, I'm curious whether this is a known problem or a weird issue with my configuration?

REACT 2 Released

Reply #953
I did get in touch with Jan S for wiki access, but I'm waiting to roll together a few things before I bother editing the wiki. When my edits are complete (or complete enough) I'll post them to this thread first and a few of my friends, do some bug testing, and then I'll post it to the wiki as a beta.
Are you going to update the Synthetic Soul's Mod with your new edits in http://wiki.hydrogenaudio.org/index.php?title=REACT:Mods page or are you planning to release a completely new mod?

1) I didn't know they weren't tokenized, thanks for correcting me. They are likely not tokenized because Tycho had no need to use any of those settings in the .cfg file. Sorry if you're pining to use them...
I am definitely pining for them...
Album Art XUI is great,... Have you considered bundling XUI with REACT and making it the default?
I'm following Synthetic Soul on this; current Synthetic Soul's Mod will only be modified if there's a bug/"problem" in there. A wishlist for completely new mod would be a good idea, let's see if we get a better forum for REACT and it's mods (I've taken first steps to do this).

2) The REACT.CUE you're seeing is a file that synthetic soul's mod adds to "glean information from", ... It should clean it up on its own, I think.
Hmm, I don't think it's ever cleaned up in track mode.  I'll try a full track set rip again to be sure, but I think I've been deleting it manually in track mode. The last track does the replay gain stuff, but I don't believe it cleans up REACT.cue.  My track.cfg has some debug code in it that slows it down, so I think I'll get some sleep and check tomorrow.  It is cleaned up in image mode, though.
REACT.CUE file is created in latest mod because it's the only way to defeat EAC's "last track number wrong when CD has a data track" bug. Currently creating the cuefile fixes at least two problems; EACLog move doesn't work in certain situations AND post-processing doesn't work if there's a data track in CD. As you can see, it was necessary to implement this change.

The REACT.CUE file in track mode ripping is deleted before the last bat file is created. So you have to rip all tracks or only the last track. Remember this: REACT/Synthetic Soul's Mod is created to only work properly when you're ripping an image or all tracks in track mode!

I've noticed a minor problem with file naming now that I'm actually getting down to ripping my collection:

Sometimes the album date isn't being added to image filenames. I have "ImageNaming=$artist$ - ($year$) - $album$" in my REACT.ini and most of the time it works, but intermittently it's missed out.

I'm curious whether this is a known problem or a weird issue with my configuration?
I don't know about this problem. And I don't even use image mode.. but let's see if I can help out.

Kind of hard to think where the problem is without more information.

- What is the filename when the year is not added to it?

- Can you produce this problem everytime with just one CD?
   1. Put DebugMode=1 and Debug=1 in INI file under [UserSettings]
   2. Rip it many times & save all rips ... + copy debugging.txt file from REACT folder to rip folder EVERYTIME you do one rip.
   3. When year is not added to filename:
      3.1 Compare bat file (I recommend WinMerge) from good rip to the bat file of bad rip
      3.2 Compare "good" and "bad" debugging logs

That's it. A good start I think.

EDIT:
The "REM DATE" in the cue sheet is added by EAC.. so that's why it's correct everytime.

EDIT2: I think I've found the culprit: REACT tries to read the year from EAC window and it fails sometimes. (the same problems could arise with album, artist, year, genre & freedb values read from the EAC window)

Dave_K, do you have AutoIt installed? I could try to fix this and send you the modified .au3 file for you to test. (PM me your email) Or I could build (haven't done this yet) new test version if you don't have AutoIt.

REACT 2 Released

Reply #954
I'm following Synthetic Soul on this; current Synthetic Soul's Mod will only be modified if there's a bug/"problem" in there. A wishlist for completely new mod would be a good idea, let's see if we get a better forum for REACT and it's mods (I've taken first steps to do this).


Understood. Although maybe it would be a good idea to make it clear how much better Album Art XUI is on the wiki page. I was unclear what the advantages were until I tried it; whether it was just an improved UI, rather than offering access to many more cover art sources. If I'd stuck with the default I'd have wasted a lot of time manually downloading art unnecessarily.

I don't know about this problem. And I don't even use image mode.. but let's see if I can help out.

Kind of hard to think where the problem is without more information.

- What is the filename when the year is not added to it?


Simply "$artist$ - $album$" rather than "$artist$ - ($year$) - $album$". For example "The Fall - Dragnet" rather than "The Fall - (1979) - Dragnet"

- Can you produce this problem everytime with just one CD?


It doesn't seem to depend on the particular CD. I can rerip the same CD imediately after it failed to add the date and it'll create the filename correctly.

1. Put DebugMode=1 and Debug=1 in INI file under [UserSettings]
   2. Rip it many times & save all rips ... + copy debugging.txt file from REACT folder to rip folder EVERYTIME you do one rip.
   3. When year is not added to filename:
      3.1 Compare bat file (I recommend WinMerge) from good rip to the bat file of bad rip
      3.2 Compare "good" and "bad" debugging logs


I've compared the bat files and debugging logs, but apart from things like temporary file naming in the bat file, and the file name itself, there doesn't seem to be a difference.

I think I've found the culprit: REACT tries to read the year from EAC window and it fails sometimes. (the same problems could arise with album, artist, year, genre & freedb values read from the EAC window)


I haven't seen it miss the artist/album from the filename...

Dave_K, do you have AutoIt installed? I could try to fix this and send you the modified .au3 file for you to test. (PM me your email) Or I could build (haven't done this yet) new test version if you don't have AutoIt.


I haven't used AutoIt, but I could download a copy and have a play with it easily enough.

I've sent you my email address.

REACT 2 Released

Reply #955
Simply "$artist$ - $album$" rather than "$artist$ - ($year$) - $album$". For example "The Fall - Dragnet" rather than "The Fall - (1979) - Dragnet"

Ok. This changes things a lot, forget my previous thoughts of what might be the culprit. I thought that you have bad filenames like: "The Fall - () - Dragnet". The problem is most likely that the iniread fails and defaults to "$artist$ - $album$". I'll have to look into this... might take a while.. I'll send you email when I'm ready. But if this is the case... and the iniread can't be trusted in REACT... let's not think about it now.

I haven't used AutoIt, but I could download a copy and have a play with it easily enough.

Not required, but if you like to do that, be my guest. Anyways, I'll build you a test version.

REACT 2 Released

Reply #956
I'm having some weird problems. REACT was working fine for me, I'm not aware of having changed anything, but now it no longer copies the output files at the end of processing. They are all created correctly, but just end up hanging around in the EAC working directory.

I put it in debug mode, and have had a look at both the config and the generated script, but can't see where this copy is even supposed to happen!

Not sure if this has anything to do with it, but I'm running on Vista, and my final destination directory is on a network drive, but yes, I can access it just fine.

Any ideas? I had a search through this thread, but couldn't find anything relevent. Of course, that doesn't mean that it isn't there!!!


Thanks for the help on this issue. Believe it or not, I've not had time to look at it since the 29th (the joys of fatherhood  ), but I've since solved the issue.

I turned on debug, looked at the output, looked at the cfg and ini files and tried to figure out what the problem was, and I saw this:

Code: [Select]
D:\Users\Leon\Music>PUSHD "Z:\Music\FLAC\Nirvana\[1991] Smells Like Teen Spirit (Single)"
The system cannot find the drive specified.


I opened another command prompt, and I could change to z:, I could mkdir's on it and everything. As a bit of a stab I looked at REACT, and saw I had it set to run as an adminstrator. I can't remember why I did that now (29/11 was a while ago now, and I'd already had the problems for a while), but when I unchecked that box, it started working again. I guess this is some aspect of Vista 'security'?

Anyway, it works now, but I wanted to post this solution so when the next person searches for this, they can find the answer!

REACT 2 Released

Reply #957

1) I didn't know they weren't tokenized, thanks for correcting me. They are likely not tokenized because Tycho had no need to use any of those settings in the .cfg file. Sorry if you're pining to use them...

I am definitely pining for them...

I discovered that at least VA in the [Settings] section is tokenized, it's needed to set up TPE2 for compilation discs. I added various to MetaData instead of putting it in the [UserSettings] section.  @various@ is needed in the .cfg files to set up TPE2 for compilation discs, so it's being defined somewhere but I can't find it being defined in the .ini or .cfg files.

1. Where is @various@ initialized? It's 0 when the .cfg files access it. More importantly, where should it be set to 1?

2. Since VA is tokenized, any chance of tokenizing Test? 

EDIT: From perusing REACT.au3, it looks like all I need to do is set VA="Various Artists -" or "Various -" without the quotes to make a compilation disc.  Is that the intended behavior?

Thanks,
dd_wizard

REACT 2 Released

Reply #958
I discovered that at least VA in the [Settings] section is tokenized, it's needed to set up TPE2 for compilation discs. I added various to MetaData instead of putting it in the [UserSettings] section.  @various@ is needed in the .cfg files to set up TPE2 for compilation discs, so it's being defined somewhere but I can't find it being defined in the .ini or .cfg files.

1. Where is @various@ initialized? It's 0 when the .cfg files access it. More importantly, where should it be set to 1?

2. Since VA is tokenized, any chance of tokenizing Test? 

1. It's set by REACT. You don't need to set it. You just check the "Various Artists" checkbox in EAC window and REACT does the rest. I don't understand why you want to set it? Just use the @various@ variable wherever you want to.

2. If you ask me, no. I'll not add any new features.. just bugfixes.

Download AutoIt and mess with the REACT source code if you're so eager to implement this, and other(?), features. Build your own mod with kitchen sink.  Knowing Visual Basic helps but the code is fairly difficult, so you have to be ready to use some time to understand it. Good luck.

Seriously speaking, I don't understand why you want to do this. Shouldn't you be interested in the end result, not the fact that how elegantly you could achieve your goal (which I guess is ripping your cd's with REACT)?

EDIT:
EDIT: From perusing REACT.au3, it looks like all I need to do is set VA="Various Artists -" or "Various -" without the quotes to make a compilation disc. Is that the intended behavior?

Almost correct. Use "VA=Various Artists" or "VA=Various" without the quotes.

REACT 2 Released

Reply #959
Ah, REACT knows about the EAC check box, so @various@ reflects the settings in EAC.  Thanks! I've been a C/C++ programmer for years, so I may play around with AutoIt. It looks interesting.

dd_wizard

REACT 2 Released

Reply #960
Ah, REACT knows about the EAC check box, so @various@ reflects the settings in EAC.  Thanks! I've been a C/C++ programmer for years, so I may play around with AutoIt. It looks interesting.

Have you seen this REACT wiki page? It would have given you the answer to this thing (the "Editing the CFG files (advanced)" section at the end).

REACT 2 Released

Reply #961

Ah, REACT knows about the EAC check box, so @various@ reflects the settings in EAC.  Thanks! I've been a C/C++ programmer for years, so I may play around with AutoIt. It looks interesting.

Have you seen this REACT wiki page? It would have given you the answer to this thing (the "Editing the CFG files (advanced)" section at the end).


Several times, I guess I missed that.  Sorry for wasting bandwidth.

dd_wizard

REACT 2 Released

Reply #962
EDIT: From perusing REACT.au3, it looks like all I need to do is set VA="Various Artists -" or "Various -" without the quotes to make a compilation disc. Is that the intended behavior?
Almost correct. Use "VA=Various Artists" or "VA=Various" without the quotes.
I think that this has probably been resolved, but the above looks confusing for others.  To clarify: REACT will set @various@ to 1 if the CD Artist begins "Various" - essentially linked to the Various Artists checkbox.  The VA variable in the REACT ini detirmines the value that is used for the Album Artist tag when @various@ is set.  This will also detirmine folder naming.  Setting the VA variable does not make REACT treat the disc as a VA disc.

</anal mode>
I'm on a horse.

 

REACT 2 Released

Reply #963
Hi there

Just recently started to use EAC/REACT to extract my musiclibrary and I must say, it is a really neat tool... I just have one question concerning the image mode: Is it possible to encode 2 images at the same go (i.e. *.wv and *.mp3) without having to rip the same CD a second time to achieve this? I usually wouldn't need this for my regular albums (single track), but I prefer a image-mp3 for my (re)mixed albums.

Regards and thanks for your reply.

-R

REACT 2 Released

Reply #964
Is it possible to encode 2 images at the same go (i.e. *.wv and *.mp3) without having to rip the same CD a second time to achieve this?

Yes it it's, but you have to modify the REACT-image.cfg file contents by hand.

The easiest way would be to comment out (REM) following lines:

IF NOT @ImageExt@==wv GOTO end_wavpack_image

IF NOT @ImageExt@==mp3 GOTO end_lame_image

But remember that after doing this, the INI ImageExt= setting doesn't work properly until you uncomment above lines.

REACT 2 Released

Reply #965
Just a heads up. AutoIt v3.2.10.0 requires #include <Misc.au3> to find _SendMessage() in "REACT Additonal Meta Data.au3". Without the extra include, the syntax checker generates an undefined function error.

I love the pseudo array processing of Meta Data by REACT 2. EAC is very weak when it comes to adding both Title and Artist tags to tracks from compilation type CDs.  It's a breeze with Meta Data. If you speak diff, here are the changes to move Test into the [DefaultMetaData] section of REACT.ini.  It's a convenient way to turn Test and Copy on and off, and make it available to the .cfg scripts. Any brave souls who understand diff output and don't mind maintaining their own branch are welcome to use them.

Code: [Select]
diff /program files/react2/src/REACT 2.0.ssb16n.au3 react2/src/REACT 2.0.ssb16n.au3
268d267
<         "Test=0" & @crlf & _
325a325,326
>         
>     fCreateMetaDataDefaults()
713c714
<     If Int(IniRead($g_iniFile, "Settings", "Test", 0)) Or $g_tracksHotVal = '+{F6}' Then
---
>     If Int(IniRead($g_metaIniFile, "Current", "Test", 0)) Or $g_tracksHotVal = '+{F6}' Then
752c753
<     If Int(IniRead($g_iniFile, "Settings", "Test", 0)) Then
---
>     If Int(IniRead($g_metaIniFile, "Current", "Test", 0)) Then


diff /program files/react2/src/REACT Additonal Meta Data.au3 react2/src/REACT Additonal Meta Data.au3
282,286c282,286
<     Dim $arrDefault[4][2]
<     $arrDefault[0][0] = 3
<     $arrDefault[1][0] = "discnumber"
<     $arrDefault[1][1] = "1"
<     $arrDefault[2][0] = "totaldiscs"
---
>     Dim $arrDefault[5][2]
>     $arrDefault[0][0] = 4
>     $arrDefault[1][0] = "Test"
>     $arrDefault[1][1] = "0"
>     $arrDefault[2][0] = "discnumber"
288,289c288,291
<     $arrDefault[3][0] = "discname"
<     $arrDefault[3][1] = ""
---
>     $arrDefault[3][0] = "totaldiscs"
>     $arrDefault[3][1] = "1"
>     $arrDefault[4][0] = "discname"
>     $arrDefault[4][1] = ""


The changes for getting read mode out of the registry were straight forward. I only have one drive though, so they aren't general enough to post. Oh, it sucks to run your own version of REACT and forget to change the EAC external encoder path! You get a really strange feeling when your main loop code executes perfectly, but you're encode code never executes.  LOL

Thanks for an awesome add on to EAC,
dd_wizard

REACT 2 Released

Reply #966
Maybe a bug.  If the user changes a key value in the [DefaultMetaData] section of REACT.ini, the values aren't changed in the default meta data array. So when a new disc is inserted, the default values loaded when REACT was started are used instead of the new values in REACT.ini.

Suggested fix: Add a call to  fReadMetaDataDefaults() in fShowIni().

EDIT: It's probably a good idea to add fCreateMetaDataDefaults() to fWriteIni() as well.

dd_wizard

REACT 2 Released

Reply #967
That is so not a bug.

REACT sensibly caches the values so that repeated reads of the INI are not required.  The values in the INI are supposed to be the standard default values; you amend those values for a specific disc using the Additional Meta Data (AMD) dialogue.  If you want to change the defaults do it while REACT is closed.

There was brief discussion about an option, or options, in the AMD dialogue to decide whether the values were reset when a new disc was inserted (e.g. a "Don't reset on disc change" checkbox).  Perhaps this could be considered for a future version.

Repeat after me: a working feature that does not work as one expects is not a bug; it is simply a difference of opinion.
I'm on a horse.

REACT 2 Released

Reply #968
I'm not sure if I've changed something in source that is giving me this error, but I seem to be having issues with the discname metadata and MP3 tagging. I could have sworn this was working for me before, but maybe I made a change I can't think of now that is affecting this...

Error is: error: --frame: bad argument: TXXX[setsubtitle]:Teeheehee


(Where Teeheehee was the discname I was testing with.)

REACT 2 Released

Reply #969
Are you using metamp3 0.91 or 0.92b5?

I think you may need 0.92.

That should probably be documented.
I'm on a horse.

REACT 2 Released

Reply #970
Are you using metamp3 0.91 or 0.92b5?

I think you may need 0.92.

That should probably be documented.



Hrm... I didn't think I had updated metamp3. Or, I guess that's the problem? I've got "0.91 by tycho". I was afraid to update the tool because I thought it was tycho's custom build and didn't want to break things.

Soooo. 0.92b5, eh

Edit: Good call, as always  Sooo, what happened to that notes file of interesting points you were talking about? I'd like to give it a good read
Edit: Not out of the woods yet! It's tagging as "SetSubtitle" now, instead of "DiscName" .. Is this the right tag?

REACT 2 Released

Reply #971
Can someone tell me what the advantages, of the alternate software that is being used with REACT are?

REACT 2 Released

Reply #972
Can someone tell me what the advantages, of the alternate software that is being used with REACT are?


Can you clarify what you mean? What alternate software?

REACT 2 Released

Reply #973
Edit: Not out of the woods yet! It's tagging as "SetSubtitle" now, instead of "DiscName" .. Is this the right tag?
Can't remember the ins and outs, but yes, I believe that is the correct tag for ID3v2.  I may have misinterpreted the docs.

Actually, after a little checking, I think this refers to the proper name in ID3v2.4 - this musicbrainz page seems to bear me out. If metamp3 could write ID3v2.4 it would use TSST rather than a TXXX frame called "SetSubTitle".
I'm on a horse.

REACT 2 Released

Reply #974
Edit: Not out of the woods yet! It's tagging as "SetSubtitle" now, instead of "DiscName" .. Is this the right tag?
Can't remember the ins and outs, but yes, I believe that is the correct tag for ID3v2.  I may have misinterpreted the docs.

Actually, after a little checking, I think this refers to the proper name in ID3v2.4 - this musicbrainz page seems to bear me out. If metamp3 could write ID3v2.4 it would use TSST rather than a TXXX frame called "SetSubTitle".


I'll trust you and leave it as-is for now. Boy, I sure wish all of the major formats would get together and agree on a common tagging standard. It would sure make things like this a whole lot easier


Edit(s) (As I seem to be incapable of writing everything I need to at once): I have a new question, Synthetic Soul! I tried adding a user-configurable setting for the "Encoded-By" setting, by adding a value "Name=" in the UserSettings section, with the value defaultly set to %UserName%. I tried calling this from the .cfg, but found that the Percentages were escaped (%%UserName%%), I thought that after j we were no longer escaping things like that from the .ini?

2) It seems as though only the UserSettings section is getting replaced with the fStringReplaceForDOS() command. Is there any reason why UserSettings is treated differently? It seems like an easy enough 'fix' to revert it to a regular string replace, but I don't want to accidentally circumvent something you've taken your time to fix, so I need to ask your help again. Sorry :C

3) One more edit. I hope this is the last-- when I upgraded metamp3 to the latest beta, it broke support for VA in react, so I changed that --user-text line to this instead-- I probably wouldn't write home about this one except for the fact that the disc/set stuff seemed to need the latest beta, so this might be 'mismatched', where the current cfg might not fully work with either version as-is.
Code: [Select]
--frame "TXXX[album artist]:@VA@" --frame "TPE2:@VA@"

I've also noticed that I don't actually see an "Encoded-by" field from within foobar using the TENC frame, though using metamp3 --info shows the TENC frame is certainly present. --Foobar's fault, or is there an extra mile we can go to "fix" this?