Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1362303 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

foo_discogs

Reply #250 –
Quote
1)
Not in the immediate future as it is a real pain to parse, and quite frankly I'm a bit fed up with parsing generated HTML. If/When discogs has an API that expose this data then surely. An API is planned from their side but there's no sign of it yet, so it's just wait and see

2) see 1). Long answer: I've started think of it and it's not easy to o properly and to present the info the user in a generic way.

3) Sure it would be nice

4) I could do it but probably won't since If you have a doubt you can double click the release in the find list to display it and check that it's the good release.

5) This will be in the next version I hope

6) Why would you want custom tagz string ?

7) I don't see much usefulness for this as in 99% of cases you want to tag everything with the same tags, so you rarely change tag mappings...



Thx for your answer. I agree when looking at the site, that including more extra information could not be done so easily.

Just a quick reply to the open points.

6) customization would be mostly helpful in the file display to avoid that long filenames hide important information.

7) Actually this is not true for me. Most of the time my tags are already quite ok, quality-wise. Two major issues where I this feature would be helpful are: 1) when you retag a multi-disc album. Usually I switch off update on album and on tracknumbers/totaltracks. 2) When there is reason to keep the existing tags, e.g. additional information like remix by exists, and where I won't like to see this to be overwriten. The same issue appears when e.g. remix albums are filed under "Various" where I'd like to see the original album artist preserved.
Going into the mappings menu just takes a lot of time.

Greets and thx for ur work,

Chris

foo_discogs

Reply #251 –
Wow, this is highly useful! Thanks a lot!

foo_discogs

Reply #252 –


See how the tracks in the discogs box are all out of order? It goes 1, 4, 3, 2, 5, 6... Is there a reason for this?

foo_discogs

Reply #253 –
Quote from: nbv4 on
See how the tracks in the discogs box are all out of order? It goes 1, 4, 3, 2, 5, 6... Is there a reason for this?


Yes the track matching based on track length is buggy and don't work. Disable it until I release the next version hopefully this week end

foo_discogs

Reply #254 –
Quote from: bubbleguuum on
Quote from: nbv4 on

See how the tracks in the discogs box are all out of order? It goes 1, 4, 3, 2, 5, 6... Is there a reason for this?


Yes the track matching based on track length is buggy and don't work. Disable it until I release the next version hopefully this week end

ok no problem.

Also, I have a lot of albums that are tagged fine, but have no album art. It would be nice if there was a way to just right click -> discogs -> get album art. Then a dedicated box comes up designed around retrieving album art. Even awesomer would be a way to do this in bulk, so you don't have to do them all one by one.

I have a huge collection that needs album art, but there are no real good automated ways to get the art. There are a few apps out there, but they either suck, or are hardcoded to save as "folder.jpg" or some other nonsense.

foo_discogs

Reply #255 –
Quote from: nbv4 on
I have a huge collection that needs album art, but there are no real good automated ways to get the art. There are a few apps out there, but they either suck, or are hardcoded to save as "folder.jpg" or some other nonsense.

Well, folder.jpg makes sense for windows users who want to see a picture preview when they browse their folders in 'thumbnail' view.
Nevertheless I also dont know a tool that can batch-fetch album art. Selecting all files that have the discogs_release_id and making foo_discogs fetch all the album art in one go would be super-cool of course. works like a charme and is super-cool  . For the regular tags I wouldnt use this because just sometimes the tracks i have dont match the discogs info 100%. For tags there has to be a second level of checking everything is correct.

foo_discogs

Reply #256 –
Quote from: Ydope on
Quote from: nbv4 on

I have a huge collection that needs album art, but there are no real good automated ways to get the art. There are a few apps out there, but they either suck, or are hardcoded to save as "folder.jpg" or some other nonsense.


Nevertheless I also dont know a tool that can batch-fetch album art. Selecting all files that have the discogs_release_id


This is already possible : Discogs/update album art.
You can select you whole collection if you wish and it will fetch / update art for files that have %discogs_release_id% set.

To nbv4: there's no program that can automatically and reliably get album art without a minimum of user intervention. If you have files with no %discogs_release_id% you could set it manually or with the plugin then use "update album art"

foo_discogs

Reply #258 –
How does this plugin work? How do I get it to download album art? How do I disable tag writing? Are the any "getting started" help somewhere?

foo_discogs

Reply #259 –
put the component in your components folder, I don't think it's possible to download album art without the discogs release id. and why would you disable tag writing? just select the songs you want to tag and right click

foo_discogs

Reply #260 –
This is very useful, thanks a lot.

foo_discogs

Reply #261 –
Having problems.  Clicking search or entering the discogs id manually crashes foobar every time.  Doesn't matter which particular mp3 I do a discog search for; it crashes.  Any help?
log:
Code: [Select]
Illegal operation:
Code: C0000005h, flags: 00000000h, address: 00033908h
Access violation, operation: write, address: 00000000h
Call path:
entry=>app_mainloop=>contextmenu_item_node::execute
This is the first crash logged by this instance.
Code bytes (00033908h):
000338C8h:  8E 06 02 00 48 E0 80 7C E8 01 00 00 E4 46 15 00
000338D8h:  DC 01 00 00 94 38 03 00 88 32 91 7C 84 39 03 00
000338E8h:  A8 9A 83 7C 78 E3 80 7C FF FF FF FF DC E3 80 7C
000338F8h:  00 00 15 00 38 E0 80 7C 74 06 02 00 00 00 00 00
00033908h:  00 00 00 00 F0 CA 38 00 4C A2 01 00 3D 00 00 00
00033918h:  74 38 03 00 44 3A 5C 66 6F 6F 62 61 72 32 30 30
00033928h:  30 5C 66 6F 6F 62 61 72 32 30 30 30 2E 65 78 65
00033938h:  00 00 15 00 00 00 00 00 F6 1B 80 7C DC 3A 03 00
Stack (00033888h):
00033868h:  00000000 00000000 00000000 00000000
00033878h:  00000000 00000000 00000000 00000000
00033888h:  00383432 00033908 00000001 00033A34
00033898h:  0003392A 00000000 003828E3 000338BC
000338A8h:  00033908 00000190 00E820D0 01720048
000338B8h:  00000000 7FFDF000 001543A0 00154508
000338C8h:  0002068E 7C80E048 000001E8 001546E4
000338D8h:  000001DC 00033894 7C913288 00033984
000338E8h:  7C839AA8 7C80E378 FFFFFFFF 7C80E3DC
000338F8h:  00150000 7C80E038 00020674 00000000
00033908h:  00000000 0038CAF0 0001A24C 0000003D
00033918h:  00033874 665C3A44 61626F6F 30303272
00033928h:  6F665C30 7261626F 30303032 6578652E
00033938h:  00150000 00000000 7C801BF6 00033ADC
00033948h:  0038CAF0 00000000 01DC01DA 00154508
00033958h:  001A0018 7FFDFC00 00000018 77DD2BE4
00033968h:  00033A36 77DD16A4 0000022F 000339C4
00033978h:  7C919BD3 00033A36 000002A3 77DD0000
00033988h:  77DD2158 77DD2BE4 00000000 00000001
00033998h:  00033A34 00000000 00000001 77DD0000
Registers:
EAX: 00000000, EBX: 00033908, ECX: 0038C8FC, EDX: 00036172
ESI: 00033908, EDI: 00033908, EBP: 00E84460, ESP: 00033888

foo_discogs

Reply #262 –
http://www.discogs.com/release/1350

this release crush my foobar
...
there is no answers here for a long time... bubbleguuum v0.92 is a final version? u dont interested in upgrades no more?

foo_discogs

Reply #263 –
i think i understand
[DC01, 1996] Adam Beyer & Lenk - Drumcode 01
[DC02, 1996] Adam Beyer - Compressed
[DC15A, 1998] Adam Beyer _ Cari Lekebusch - Split EP
[DC16, 1998.12] Marco Carola & Adam Beyer - Drumcode 16

this releases are good!
but this

drumcode 01.5 - Adam Beyer & Lenk (luke slater) - Drumcode #1 (1996)
drumcode 20.5
drumcode 21.5 - Adam Beyer - The Time Ltd (2001)
drumcode 22.5 - Henrik B. - Recollections Ltd (2001)
drumcode 23.5 - Safety Session - Maru Part 1 Ltd (2001)
drumcode 25.5A - Adam Beyer & Henrik B. - Sound Identification Ltd (2002)
...e.t.c

not good...  because of catalog# !!!
DC01 - good
DC01.5 - not good
DC20 - good
DC20.5 - not good

"." - not good
wtf?

check or debug this releases plz:
http://www.discogs.com/release/1350
http://www.discogs.com/release/5839
http://www.discogs.com/release/6373
http://www.discogs.com/release/21292
http://www.discogs.com/release/33702
http://www.discogs.com/release/102023
http://www.discogs.com/release/79230
http://www.discogs.com/release/164566
http://www.discogs.com/release/282847
http://www.discogs.com/release/479128
 

foo_discogs

Reply #264 –
I noticed when updating a lot of tags and downloading cover art afterwards that some release pages of discogs have been moved or deleted, so would it be handy that the foo_discogs plugin just ignores that album and goes further with the other albums because it just stops and this is quite annoying if your updating a large portion of the library. Also is it possible that the albums for which the plugin doesn't find the release id anymore that these are saved in a txt file or something like that so they can be retagged.

Quote from: Dave_Scream on
i think i understand
[DC01, 1996] Adam Beyer & Lenk - Drumcode 01
[DC02, 1996] Adam Beyer - Compressed
[DC15A, 1998] Adam Beyer _ Cari Lekebusch - Split EP
[DC16, 1998.12] Marco Carola & Adam Beyer - Drumcode 16

this releases are good!
but this

drumcode 01.5 - Adam Beyer & Lenk (luke slater) - Drumcode #1 (1996)
drumcode 20.5
drumcode 21.5 - Adam Beyer - The Time Ltd (2001)
drumcode 22.5 - Henrik B. - Recollections Ltd (2001)
drumcode 23.5 - Safety Session - Maru Part 1 Ltd (2001)
drumcode 25.5A - Adam Beyer & Henrik B. - Sound Identification Ltd (2002)
...e.t.c

not good...  because of catalog# !!!
DC01 - good
DC01.5 - not good
DC20 - good
DC20.5 - not good

"." - not good
wtf?

check or debug this releases plz:
http://www.discogs.com/release/1350
http://www.discogs.com/release/5839
http://www.discogs.com/release/6373
http://www.discogs.com/release/21292
http://www.discogs.com/release/33702
http://www.discogs.com/release/102023
http://www.discogs.com/release/79230
http://www.discogs.com/release/164566
http://www.discogs.com/release/282847
http://www.discogs.com/release/479128


Ooh and this is because the info on discogs isn't correct if bubblegum has to correct al the mistakes on discogs it would be crazy. So if you want those things correct edit your mp3 tags or edit the info on discogs.

foo_discogs

Reply #265 –
Quote from: stampgevaar on
Quote

check or debug this releases plz:
http://www.discogs.com/release/1350
http://www.discogs.com/release/5839
http://www.discogs.com/release/6373
http://www.discogs.com/release/21292
http://www.discogs.com/release/33702
http://www.discogs.com/release/102023
http://www.discogs.com/release/79230
http://www.discogs.com/release/164566
http://www.discogs.com/release/282847
http://www.discogs.com/release/479128

Ooh and this is because the info on discogs isn't correct if bubblegum has to correct al the mistakes on discogs it would be crazy. So if you want those things correct edit your mp3 tags or edit the info on discogs.


so you mean than this is correct then foobar chushing if catalog# consist ","?? i dont think so...  any error situation must be predicted.

Quote
Ooh and this is because the info on discogs isn't correct

and i dont think that this string: "Catalog#:   DC20,5" --- "isn't correct"   

foo_discogs

Reply #266 –
aaah sorry I didn't quite understand your problem then

foo_discogs

Reply #267 –
I must admit I've not worked on the plugin for a long time.
There will be a new version though but I don't know when, need to find a week-end
to work on it. Need to finish artist art fetching.

I also need to clean up the code before releasing the source.

For the cat# problem the crash comes from the "," in the cat# which usually
separate several cat#, i'll look into that

foo_discogs

Reply #268 –
Finally a new version with new features and bug fixes! I didn't test fully so it might have some glitches but I think it should be pretty solid. When it has been tested some more I'll release the source.
Artist art is kind of cool, it allow to put faces on all those anonyms

This version will reset all you tag mappings and configuration

See first post for download link

v 0.98
-------

- chg: big refactoring of the code
- chg: all dialogs are now non-modal and feching discogs info properly use threads, so no more UI slugishness.
- chg: use standard foobar dialog for task progress display
- chg: redone configuration panel, using tabs and moving album art options previously in release dialog

- add: fetch/update artist art support
- add: new entry in context menu: "display artist art page" (need %discogs_artist_id%)
- add: tag mapppings: added "Original Track number", used to point to the discogs track number,
to be later able to find those track for updating track specific tags. Enabled by default and recommended to let it enabled
- add: tag mapppings: added "Artist id", "Artist aliases", "Artist groups", "Artist members" and "Artists ANVs".  This information is fetched from discogs artist pages, so it takes a bit longer
- add: support of dragging of single items in discogs track list.

- fix: auto matching based on track length was incorrect. Now it's enabled by default and should work 99% of the time
- fix: html parser: fixed crash when cat# contained "," such as release 1350 (thanks Dave Scream)
- fix: when fetching art ignore not found image instead of just aborting (thanks Ydope)
- fix: find release dialog: in some cases old previously searched artist list could appear
- fix: find release dialog: "exact matches" state was not correctly restored to user's setting next time if automatically checked on search when there are no exact matches
- fix: release dialog: "save art" check box was always disabled if "display art" was not checked
- fix: update tags: TOTALTRACKS was not written

Artist art
==========

If you want to retrieve artist art on releases already tagged with foo_discogs, it's easy:
check fetch artist art in the configuration panel and indicate a directory where all artist art
will be downloaded. Artists have a unique numeric identifier associated to them and stored as
tag DISCOGS_ARTIST_ID. It is automatically written when retrieving / fetching artist art, so you
can use this source for foo_uie_albumart:

<path_to_artist_art>\[%discogs_artist_id%]_?.jpg

Files are stored as <artist_id>_<numeric suffix>.jpg. This scheme won't be parametrable as it has severe complications

Artist aliases
========

Fetching artist aliases allow interesting queries such as displaying all music of an artist and its aliases.
By default in foo_uie_quicksearch if you enter an artist name, it will also find all it's aliases
Some useful queries can probably be done with "Artist members" and "Artist groups".

Updating tags for track specific tags
=======================

When updating tags there's the need to map the local track being updated to it's corresponding discog track,
when filling track-specific tags (Artist, title, track number, vinyl track, Artist aliases, Artist Groups, Artist members, Artists ANV, artist id)

To find the discogs track, it works like this:

if %DISCOGS_ORIGINAL_TRACK_NUMBER% exist (only with files tagged from this version)
use this as the discogs track number
else if %DISCNUMBER% > 1 do nothing as we can't know discogs corresponding track (mainly for CD > 1 of multi-cd releases)
else if %DISCNUMBER% do not exist or is equal to 1, then use the mapping of %TRACKNUMBER% if it exist or it's remapped equivalent

In theory it's possible to delete and regenerate all tags, provided that %DISCOGS_RELEASE_ID%
exist and the track can be mapped to the discog track with the system above.

Know limitations
================

Dragging items in discogs track list works for single items only. You can select
several items by clicking on them but that works for the "remove" button only.
win32 list programming sux0r...

foo_discogs

Reply #269 –
I'm still getting the crashes when clicking 'search' -- could it have something to do with my gdi dll version?

foo_discogs

Reply #270 –
I'm going to orgasm if this component ever gets broadened to parse any web source via custom scripts. And thanks for the recent update.

foo_discogs

Reply #271 –
Thank you very much for your continued development of this plugin!

foo_discogs

Reply #272 –
Nice upgrade, if you can also make it possible to download label pictures and info you are my god haha but it's just and idea...
Also can you possibly make it that the release id which isn't correct any more because a page has moved or someone had deleted it that the album name is stored somewhere or that you can see with a popup which albums aren't correct anymore so they can be retagged.

and BTW great work

foo_discogs

Reply #273 –
Quote from: kcay on
I'm still getting the crashes when clicking 'search' -- could it have something to do with my gdi dll version?


Very strange! does it crashes all the time ? It has nothing to do with GDI. I'll do a version that you can tes with some traces in a file to have a clue where it crashes

Quote from: metal_termite on
I'm going to orgasm if this component ever gets broadened to parse any web source via custom scripts. And thanks for the recent update.


I'm not interested in writing myself a generic component that would fetch data from several web sources. When I release the source code if anyone want to adapt it to handle other sources I'm all for it!
The html parser code is quite isolated and other parsers implementing the interface could be added. The parser would have to be written in C++ (using libhtmlcxx) which is not the most straightforward thing to do or a bridge could be done to import data from mp3tag scripts for example. There's also quite a bit of discogsism in the UI which would need some rework because all web sources do not support the same data and this would have to be abstracted. Doing win32 UI work using old API is just slow, clunky, error prone and limited compared to what you can do in Java or .net


Quote from: stampgevaar on
Nice upgrade, if you can also make it possible to download label pictures and info you are my god haha but it's just and idea...
Also can you possibly make it that the release id which isn't correct any more because a page has moved or someone had deleted it that the album name is stored somewhere or that you can see with a popup which albums aren't correct anymore so they can be retagged.

and BTW great work


having a feature that detect invalid release id in selection could be useful yes

foo_discogs

Reply #274 –
Great! Thanks for the update!!!
... have a little problem though. It doesn't fetch album art anymore. I set all the option correct i.e. show/fetch the album and it started to show in in its dialog but do not fetch any images. Any other option I missed?

Any change of skipping tracks which marked as Video?

Thanks again!