Yes, selecting all text in any input field. Isn't this how almost all programs work nowadays?

It could be read-only by default, but have a small check box to make it editable

Not as far as I can tell.

Is there possibility for Auto Save of the cover?

Can someone help me make this %type% param work?

Quote from: skullmonkey on 2009-10-13 15:49:24

Is there possibility for Auto Save of the cover?

I'm not sure what you mean by this. Could you describe how you think this would work?

Quote from: Capricorn on 2009-10-15 15:20:24

Can someone help me make this %type% param work?

I think the problem here is that you need to escape the % marks for titleformatting, as %%:
"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" -ar "$if2(%album artist%,%artist%)" -al "%album%" -p "$replace(%_path%,%_filename_ext%,%%type(%%preset%%folder,back,cd,inside)%%,) .jpg"

Note that you've got a space before .jpg, which would give you something like "cd .jpg", not "cd.jpg". I'm not sure what the last comma is for in the $replace function? I think you also have the type parameter slightly off, you probably meant to have a comma between %preset% and folder - and are you sure you want CD and Inside reversed like that? Assuming that you want to use a preset for when the cover type is unknown, and no space before .jpg, then you would want:

"C:\Program Files\AlbumArtDownloader\AlbumArt.exe" -ar "$if2(%album artist%,%artist%)" -al "%album%" -p "$replace(%_path%,%_filename_ext%,%%type(%%preset%%,folder,back,inside,cd)%%).jpg"

I hope this helps,

Alex

...appreciate the gesture, thanks...No harm done, it's in the past

import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util

class Archambault(AlbumArtDownloader.Scripts.IScript):
	Name as string:
		get: return "Archambault"
	Version as string:
		get: return "0.1"
	Author as string:
		get: return "Sebastien Leclerc"

	def Search(artist as string, album as string, results as IScriptResults):

		
		resultsPage = GetPage(GetPageStream("http://www.archambault.ca/qmi/search/SearchResults.jsp?hierarchicalCategoryId=ACH&search=${EncodeUrl(artist)}&searchSubmit.x=0&searchSubmit.y=0", null, true))
		
		resultsRegex = Regex("div\\s[^>]*class=\"browseListItem\"[^>]*>.*?\\ssrc\\s*=\\s*\"(?<image>http://storage[^=]*=?)(?<picsize>[1-9]*x[^&]+)(?<imageparm>[^\"]*?)\".*?<div\\s[^>]*class\\s*=\\s*\"description[^=]*<a\\s*href\\s*=\\s*\"(?<url>[^\"]+)[^>]*>(?<title>[^<]+)", RegexOptions.Singleline | RegexOptions.IgnoreCase)
		resultsMatches = resultsRegex.Matches(resultsPage)
	
		results.EstimatedCount = resultsMatches.Count;
		
		for resultsMatch as Match in resultsMatches:
  			image = resultsMatch.Groups["image"].Value;
  			picsize = resultsMatch.Groups["picsize"].Value;
  			imageparm = resultsMatch.Groups["imageparm"].Value;
  			url = "http://www.archambault.ca"+resultsMatch.Groups["url"].Value;
  			title = resultsMatch.Groups["title"].Value;
  			results.Add(image+"1500x1500"+imageparm, "${title}", url, -1, -1, image , CoverType.Front);

	def RetrieveFullSizeImage(fullSizeCallbackParameter):
		return fullSizeCallbackParameter

import System.Text.RegularExpressions
import AlbumArtDownloader.Scripts
import util

class HMVCanada(AlbumArtDownloader.Scripts.IScript):
	Name as string:
		get: return "HMV Canada"
	Version as string:
		get: return "0.1"
	Author as string:
		get: return "Sebastien Leclerc"

	def Search(artist as string, album as string, results as IScriptResults):

		searchParameter as string = "${artist}".Trim()+" ${album}".Trim().Replace(" ","+")
		resultsPage = GetPage(GetPageStream("http://www.hmv.ca/Search.aspx?keyword=${searchParameter}", null, true))
		resultsRegex = Regex("div\\s*[^>]*class='chartItemImage'[^>]*>.*?\\ssrc\\s*=\\s*'(?<path>(/(?!sm)\\w+)+/)small/(?<filename>[^']*)(?:[^>]*>){1,5}[^\\s]*\\s*href\\s*='(?<url>/Products/Detail/[^']*)[^>]+>(?<title>[^<]*)[^?]+[^>]+>(?<artist>[^<]*)", RegexOptions.Singleline | RegexOptions.IgnoreCase)
		resultsMatches = resultsRegex.Matches(resultsPage)
	
		results.EstimatedCount = resultsMatches.Count;

		for resultsMatch as Match in resultsMatches:
  			loc= "http://www.hmv.ca"+resultsMatch.Groups["path"].Value;
  			filename = resultsMatch.Groups["filename"].Value;
  			title = resultsMatch.Groups["title"].Value;
  			url = "http://www.hmv.ca"+resultsMatch.Groups["url"].Value;
  			artistname = resultsMatch.Groups["artist"].Value;
  			
  			results.Add("${loc}large/${filename}", "${artistname} - ${title}", url, -1, -1, "${loc}large/${filename}" , CoverType.Front);

	def RetrieveFullSizeImage(fullSizeCallbackParameter):
		return fullSizeCallbackParameter

Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\Program Files\AlbumArtDownloader\errorlog.txt

App version: 0.31.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 3 (32 bit)

System.Reflection.TargetInvocationException: Une exception a été levée par la cible d'un appel. ---> System.InvalidOperationException: Impossible de trouver l'élément supprimé.
   à System.Windows.Controls.ItemContainerGenerator.GetBlockAndPosition(Object item, Boolean deletedFromItems, GeneratorPosition& position, ItemBlock& block, Int32& offsetFromBlockStart, Int32& correctIndex)
   à System.Windows.Controls.ItemContainerGenerator.GetBlockAndPosition(Object item, Int32 itemIndex, Boolean deletedFromItems, GeneratorPosition& position, ItemBlock& block, Int32& offsetFromBlockStart, Int32& correctIndex)
   à System.Windows.Controls.ItemContainerGenerator.OnItemRemoved(Object item, Int32 itemIndex)
   à System.Windows.Controls.ItemContainerGenerator.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
   à System.Windows.Controls.ItemContainerGenerator.System.Windows.IWeakEventListener.ReceiveWeakEvent(Ty
pe managerType, Object sender, EventArgs e)
   à System.Windows.WeakEventManager.DeliverEventToList(Object sender, EventArgs args, ListenerList list)
   à System.Windows.WeakEventManager.DeliverEvent(Object sender, EventArgs args)
   à System.Collections.Specialized.CollectionChangedEventManager.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
   à System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   à System.Windows.Data.CollectionView.OnCollectionChanged(NotifyCollectionChangedEventArgs args)
   à System.Windows.Controls.ItemCollection.System.Windows.IWeakEventListener.ReceiveWeakEvent(Type managerType, Object sender, EventArgs e)
   à System.Windows.WeakEventManager.DeliverEventToList(Object sender, EventArgs args, ListenerList list)
   à System.Windows.WeakEventManager.DeliverEvent(Object sender, EventArgs args)
   à System.Collections.Specialized.CollectionChangedEventManager.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
   à System.Windows.Data.CollectionView.OnCollectionChanged(NotifyCollectionChangedEventArgs args)
   à System.Windows.Data.ListCollectionView.ProcessCollectionChangedWithAdjustedIndex(NotifyCollectionCha
ngedEventArgs args, Int32 adjustedOldIndex, Int32 adjustedNewIndex)
   à System.Windows.Data.ListCollectionView.ProcessCollectionChanged(NotifyCollectionChangedEventArgs args)
   à System.Windows.Data.CollectionView.OnCollectionChanged(Object sender, NotifyCollectionChangedEventArgs args)
   à System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object sender, NotifyCollectionChangedEventArgs e)
   à AlbumArtDownloader.ObservableAlbumCollection.RaiseCollectionChanged(NotifyCollectionChangedEventArgs e)
   à AlbumArtDownloader.ObservableAlbumCollection.Remove(Album album)
   à AlbumArtDownloader.FileBrowser.<>c__DisplayClass12.<DetectVariousArtistsAlbums>b__e()
   --- Fin de la trace de la pile d'exception interne ---
   à System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   à System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)
   à System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   à System.Delegate.DynamicInvokeImpl(Object[] args)
   à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   à System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   à System.Windows.Threading.DispatcherOperation.InvokeImpl()
   à System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   à System.Threading.ExecutionContext.runTryCode(Object userData)
   à System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   à System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   à System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   à System.Windows.Threading.DispatcherOperation.Invoke()
   à System.Windows.Threading.Dispatcher.ProcessQueue()
   à System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   à MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   à MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   à System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   à System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   à System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   à MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   à MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   à System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   à System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   à System.Windows.Threading.Dispatcher.Run()
   à System.Windows.Application.RunDispatcher(Object ignore)
   à System.Windows.Application.RunInternal(Window window)
   à System.Windows.Application.Run(Window window)
   à System.Windows.Application.Run()
   à AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   à AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   à AlbumArtDownloader.App.Main(String[] args)

Maybe you could consider lowering the Medium band limit to something like 520

Is there any way you could strip those characters ( & and : ) from the search strings you get from the queue?

Is there any way to configure the program to search and put the images on the 1st folder?

the program could use the area of the image insted of the "width first, height second" approach to sorting.

This is my first attempt at a script, feel free to comment.

resultsPage = GetPage("http://www.archambault.ca/qmi/search/SearchResults.jsp?hierarchicalCategoryId=ACH400000000000&search=" + EncodeUrlIsoLatin1(artist + " " + album))

[^']*?

(?<url>/Products/Detail/

System.IO.File.WriteAllText("hmvcanada.log", resultsPage)

I got AAD constantly crashing when I does File Browser

Quote from: sle118 on 2009-10-22 16:04:49

This is my first attempt at a script, feel free to comment.

Thank you for the script, sle118! Can I suggest you add the album title to the search string too? To fix the accent thing, encode the Url as IsoLatin1 (as archambault uses this encoding).

How about:

Code: [Select]

resultsPage = GetPage("http://www.archambault.ca/qmi/search/SearchResults.jsp?hierarchicalCategoryId=ACH400000000000&search=" + EncodeUrlIsoLatin1(artist + " " + album))

For the HMV Canada one, it seems to me that the search functionality on that website only seems to allow searching by either artist or album, but if I put in both artist and album, it never returns any results for me. I suppose the script could search for just album name, but it's not ideal. Also, your regex seems slightly off, try adding

Code: [Select]

[^']*?

before

Code: [Select]

(?<url>/Products/Detail/

One trick I use to help debug this stuff is to write out the page as actually downloaded, using:

Code: [Select]

System.IO.File.WriteAllText("hmvcanada.log", resultsPage)

just after the GetPage line.

Once you have them working, may I add your scripts to the Online Updates service, so they appear automatically when Get More Scripts is clicked?

the problem is that the result page returns "12 hommes rapaill&eacutes", with encoded accents.

520 instead of 540? Will that really make a big difference?

...strip those characters ( & and : ) from the search strings...
The only problem I have with this is that if a source did make good use of those...rather not throw away data...

A better idea would be to modify the scripts of sources which work better without those characters to strip them before sending the query to the server. To do that, I'd have to do a survey of each site, testing which one works better with the characters removed, and which with them left in.

...configure the program to search and put the images on the 1st folder...
Tricky, as it would have to know which the 'first' folder is.

Alphabetically would probably be best, but it would then have to find every folder to check which was the first, rather than just taking the first matching result.

I'll think about it, see if there is any good way of handling it. Otherwise, there's already a feature request to save multiple copies of the result in all sub folders. I haven't come up with a good idea for that either yet.

...the program could use the area of the image insted...
The problem with this is that the area isn't obvious, you probably won't be able to tell why an image was sorted or grouped where it was, and it will just look wrong. It's important that things appear to be sorted in the correct order.

I could, of course, add an "Area" label somewhere, but that would just be weird. Most covers are at least reasonably square, so I don't think this is a big issue.

Maybe you could add a Sort by: 'Area' option for 'weirdoes' (like me  ) that think it's more logical to have the images sorted that way (because size is always relative and more directly connected with the area - an image with 598x600 is bigger than one with 600x300).

May I ask how is it done today? (if it is not too much trouble)

Quote from: audio20 on 2009-10-26 18:36:42

Maybe you could add a Sort by: 'Area' option for 'weirdoes' (like me  ) that think it's more logical to have the images sorted that way (because size is always relative and more directly connected with the area - an image with 598x600 is bigger than one with 600x300).

Add me to the weirdoes group.

Alessandro

First, albums are added in the order that their files are returned by FindNextFile. For NTFS this is usually, but not guaranteed to be, alphabetical. The first file (or folder, if path matching against a folder pattern) found has an Album entry created for it, whose path points to where it was found. Subsequent files or folders which have the same Artist and Album information are ignored.

Once all albums have been added (but not necessarily had existing art searched for yet, that's slower and runs in the background), then a second pass is done to find Various Artists albums. A list is produced of all albums which share the same folder and album name, but different artist names. For each folder like this, all album entries are removed and a new Various Artists album is added with the Album name and path of the first one.