Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Album Art Downloader XUI (Read 2066544 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Album Art Downloader XUI

Reply #850 –
OK, I've been through my changes since v0.27, and the only thing I can see that would impact search performance is one additional Regex evaluation per result, with a simple pattern. That wouldn't make a noticeable difference, so I'm going to need some more details. Could you tell me the last version you used that didn't exhibit the problem? Please also let me know whether the problem occurs when performing a search by entering the artist name and album directly, then hitting the Search button, or if it is only when launched from the File Browser. Finally, if you could give me the artist and album you searched for, and the sources searched, I'll see if I can reproduce the problem here.

About memory usage, this app can easily eat up large amounts of RAM depending on settings. If you want to reduce RAM consumption, make sure that Automatically Download Full Size Images is set to Never (under the Options link in the search window), uncheck any sources you don't find useful, and avoid having multiple search windows open at the same time. You may also like to limit the number of results certain sources return. To do this, click the "..." in the bottom left of the source in the list, and enter a smaller limit (10 is the default).

For example, if you have 3 search windows, each with 30 sources providing 10 results, that's 900 results. With Automatically Download Full Size Images set to Always, that could easily be over 1Mb per image, resulting in very large RAM requirements! In practice, you probably don't use every possible source, and for most searches there will be fewer than the maximum 10 results returned by most sources, but this gives you an idea of where the memory is going - I'm not just using it up for the fun of it. Memory is released as soon as a search window is closed, or the results cleared to make way for a new search.

Alex

Album Art Downloader XUI

Reply #851 –
Quote from: frnk on
The auto-updater only works when run as administrator, but that's probably know already.

It's supposed to work as a limited user too. Of course, it can't actually update the scripts in the program files folder, as it doesn't have write access to there; so what it does instead is to download the updated script file to \Documents and Settings\<user>\Local Settings\Application Data\AlbumArtDownloader\AlbumArt.exe_Url_<junk>\0.28.1.0\scripts where it overrides the older versions left in the \Program Files\AlbumArtDownloader\Scripts.

I've tested it as a limted user under Windows XP SP3, so if you're finding it doesn't work, could you let me know what OS you are using, and exactly how it doesn't work. (Does it not report an updated version available? Report it available, but fail to download it? Download it, but still show as the old version after restart? Display any error messages of any kind?)

Thanks,

Alex

Album Art Downloader XUI

Reply #852 –
Hm, yeah, I think it actually used to work.

I have Vista Home Premium SP1.

The updater reports that a new version of the script is available, then when I update and it restarts it hasn't updated. I'll see if I can reproduce it tomorrow to provide you with mopre info.

Album Art Downloader XUI

Reply #853 –
Now I wonder... as a template I set G:\%artist%\%album%.%extension% in the main window. Why does the File Browser still try to save images as folder.jpg?
audiophile // flac & wavpack, mostly // using too many audio players

Album Art Downloader XUI

Reply #854 –
Quote from: tuxman on
Why does the File Browser still try to save images as folder.jpg?

Because the File Browser's Path to Find Images doesn't get set automatically from the Search Window's Path to Save Images To. So, chances are, you've still got the Path to Find Images set to Folder.jpg. Change that in the File Browser window, and it should then find them OK. Searches launched directly from the file browser automatically save to the path set there, so that should work too.

Alex

Album Art Downloader XUI

Reply #855 –
OK I changed the Folder%preset%.%extension%|Cover%preset%.%extension%|%album%.%extension% there to %album%.%extension now. Should fix it, I presume?
audiophile // flac & wavpack, mostly // using too many audio players

Album Art Downloader XUI

Reply #856 –
Quote from: tuxman on
OK I changed the Folder%preset%.%extension%|Cover%preset%.%extension%|%album%.%extension% there to %album%.%extension now. Should fix it, I presume?

You should probably have G:\%artist%\%album%.%extension% instead, otherwise it will look for a file named %album%.%extension% in the folder the music track is found in.

Album Art Downloader XUI

Reply #857 –
I usually search covers for files in G: anyway... but OK I thought this would only be the file name, not the full path. Thank you for the hint.
audiophile // flac & wavpack, mostly // using too many audio players

Album Art Downloader XUI

Reply #859 –
Works fine here, tested with "metallica / ride the lightning" search, one result 300x300px.

Maybe it's a "leech prevention" again? Check this post that I made in 2008.. and read the next 2 also. The beef: "So, it seems that this would happen in AAD if user searches some covers and doesn't touch the results for a while.", the posts are about "AllCdCover" source but something similar could be happening with LastFM source too.

EDIT: Oh, it works when using VPN.. then a different IP address was reported to the LastFM source, which makes the "leech prevention" case even more probable.

Album Art Downloader XUI

Reply #860 –
Quote from: MC Escher on
This latest version is using 98% of CPU and 470 MB of RAM when searching album art. I only have three searches going on at the same time, and with earlier versions I had no trouble with that.

I am happy that I am not the only who sees his machine come to a grinding hold when using this version.
I love the program, and use it a lot, but at the moment with only 20 or so albums queued, I can have a cigarette and two coffees before any results are displayed.
I am using 0.28.10 on a Windows7 machine. 3GB of RAM, and a 3.2 ghz P4. A few selected script are being used (for instance, I do not need last.fm artists when looking for albumart )

Even after all the searches are done, the program is sluggish and I need a lot of attention just to scroll. This infects other windows as well, until the moment I close Album Art Downloader...

Album Art Downloader XUI

Reply #861 –
Quote from: Jester-NL on
sees his machine come to a grinding hold when using this version.

Thanks for reporting this, it's very useful to know it isn't specific to just one user.

To help me track down the cause, could you tell me:

What version were you using previously, that didn't exhibit the problem?

Does it also happen when performing a search by entering the artist name and album directly, then hitting the Search button, or is it only when launched from the File Browser?

Does it only happen when windows are queued? For example, open 3 blank search windows (File, New, Search Window), then use the File Browser to queue up another 2 or 3 windows - does everything slow down?

You mentioned that CPU usage remained spiked even after the search finishes - does it stay high after you close the search window too? (leave the File Browser open so Album Art Downloader doesn't exit).

I will do my best to come up with an resolution for this.

Album Art Downloader XUI

Reply #862 –
Quote from: AlexVallat on
(...)

I upgrade from (as far as I recall) 0.27.something, and that version was a lot faster.
A test with just the download-window, and a manually entered search was fast, allowed me to scroll (even during search) and does not slow down my PC. Opening the file-browser doesn't change the working speed of my PC. However, the moment the queue-manager contains more than 3 albums (and I have set it to do my albums one by one, I do not search for multiple albums at the time) the thing slows down.
Once I close all windows again, until just the search-window or filebrowser is open, my machine is back to normal again. So it seems there is an issue (at least on my machine) with the queue-window.

Album Art Downloader XUI

Reply #863 –
Quote from: Jester-NL on
So it seems there is an issue (at least on my machine) with the queue-window.

That's very helpful, thank you. Could you try this experimental version, and let me know whether it still behaves the same way for you?

AlbumArtDownloaderXUI-0.28.2-experimental.zip
(just unzip in your album art downloader program folder)

Thanks,

Alex

Album Art Downloader XUI

Reply #864 –
This experimental version caused the Metal Library, Buy.com, & Yes scripts to crash.
It does seem to fix the CPU issue here though.

Album Art Downloader XUI

Reply #865 –
Am I still alone in instant crashes? I still can't get the program to run at all on Vista Business 64bit SP2. No errorlog is generated, and I've had absolutely no luck with compatibility settings. Here's the only remotely relevant information I can provide  . This is from the .28.2 .zip above, but every version back has had the exact same behavior. I do have .Net installed.

From the Vista crash dialogue:
Code: [Select]
Description:
  Stopped working

Problem signature:
  Problem Event Name:	APPCRASH
  Application Name:	AlbumArt.exe
  Application Version:	0.28.2.0
  Application Timestamp:	4a5e02d5
  Fault Module Name:	unknown
  Fault Module Version:	0.0.0.0
  Fault Module Timestamp:	00000000
  Exception Code:	c0000005
  Exception Offset:	0000000000000000
  OS Version:	6.0.6002.2.2.0.256.6
  Locale ID:	1033

Am I just sorely out of luck? 

Album Art Downloader XUI

Reply #866 –
Quote from: zim2411 on
I still can't get the program to run at all on Vista Business 64bit SP2.

Unfortunately, that error doesn't give me much to go on. There's no reason I can think of why it shouldn't work on Vista Business 64bit SP2. As no errorlog is created, I suspect the problem lies with the .net framework. Are you able to run other .net applications? Try NoteScraps, for example.

The only suggestion I can make, really, is to try uninstalling and reinstalling .NET Framework 3.5 SP1

Album Art Downloader XUI

Reply #867 –
This experimental one seems to do the trick, but I experienced the 'metal library' crash as well (don't use buy or yes)

Album Art Downloader XUI

Reply #868 –
Quote from: Jester-NL on
This experimental one seems to do the trick

Excellent, I'll use that as the basis for a 0.28.2 release this weekend, then. Don't worry about the messages for Metal Library, Buy.com, & Yes, you can safely ignore those. They won't be present in the release version.

Alex
 

Album Art Downloader XUI

Reply #869 –
Hi Alex,

I'm getting this error upon installing the v0.28.1.0 overtop of v0.28 in compatibility mode.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.

If you wish to report this error, please include this information, which

has been written to the file: C:\Documents and Settings\WesterfD\AlbumArtDownloader\errorlog.txt



App version: 0.28.1.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2 (32 bit)



System.MissingMethodException: Method not found: 'Void System.Windows.Window.set_ShowActivated(Boolean)'.

at AlbumArtDownloader.SearchQueue.DequeueNextSearchWindow()

at AlbumArtDownloader.SearchQueue.set_SimulataneousWindowsAllowed(Int32 value)

at AlbumArtDownloader.SearchQueue..ctor()

at AlbumArtDownloader.App.ProcessCommandArgs(String[] args)

at AlbumArtDownloader.App.OnStartup(StartupEventArgs e)

at System.Windows.Application.<.ctor>b__0(Object unused)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)

at System.Windows.Threading.DispatcherOperation.InvokeImpl()

at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)

at System.Threading.ExecutionContext.runTryCode(Object userData)

at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)

at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)

at System.Windows.Threading.DispatcherOperation.Invoke()

at System.Windows.Threading.Dispatcher.ProcessQueue()

at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)

at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)

at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)

at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)

at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)

at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)

at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)

at System.Windows.Threading.Dispatcher.Run()

at System.Windows.Application.RunInternal(Window window)

at System.Windows.Application.Run(Window window)

at System.Windows.Application.Run()

at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()

at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)

at AlbumArtDownloader.App.Main(String[] args)
Surf's Up!
"Columnated Ruins Domino"

Album Art Downloader XUI

Reply #870 –
Quote from: drbeachboy on
I'm getting this error upon installing the v0.28.1.0 overtop of v0.28 in compatibility mode.

Thanks for reporting this. I'll make sure it's fixed for 0.28.2, although it will probably mean that you can't have de-queued windows opening behind other search windows in compatibility mode, I'm afraid.

Album Art Downloader XUI

Reply #871 –
Got it solved! It wasn't a .Net error, but some other processes causing it to crash. I have a thing called amBX: http://www.ambx.com/ which annoyingly loads nearly 10 separate processes upon startup. I killed a bunch of them, and now Album Art Downloader works 

As for why the two things don't play nice... no clue. The only other application that doesn't work with amBX running is Media Player Classic Home Cinema. (Regular MPC works fine though.)

Album Art Downloader XUI

Reply #872 –
Album Art Downloader XUI v0.28.3 Released

This is a bug-fixing release. It should address the performance concerns raised since 0.28, as well as other reported minor issues.

Full list of changes since 0.28.1:
  • Updated discogs script
  • Fixed crash when manually updating after automatically getting new scripts.
  • Fixed bug with command line parameters ending in \"
  • Improved reliability of queued windows showing behind existing ones
  • Restored compatibilty with pre-SP1 .net 3.5 when dequeing windows
  • Fixed potential CPU over-usage scenario when dequeing windows
  • Fixed memory leak introduced in 0.28

Download:
AlbumArtDownloaderXUI.exe (Installer. Recommended)
AlbumArtDownloaderXUI.zip (zip archive for those who don't like installers)
.NET Framework 3.5 SP1 (required)

Album Art Downloader XUI

Reply #873 –
Installed 0.28.2 over 0.28.1 (as Admin) under Windows 7RC.
Previous versions were running fine.

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\TOOLS\Sound\AlbumArtDownloader\errorlog.txt

App version: 0.28.2.0, running on Microsoft Windows NT 6.1.7100.0 (32 bit)

System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei AlbumArtDownloader.ArtSearchWindow.OnAutoDownloadFullSizeImagesChanged(Object sender, RoutedEventArgs e)
   bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   bei System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
   bei System.Windows.Controls.RadioButton.OnChecked(RoutedEventArgs e)
   bei System.Windows.Controls.Primitives.ToggleButton.OnIsCheckedChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
   bei System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   bei System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   bei System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
   bei System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, OperationType operationType)
   bei System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, OperationType operationType, Boolean isInternal)
   bei System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
   bei System.Windows.Markup.BamlRecordReader.SetDependencyValueCore(DependencyObject dependencyObject, DependencyProperty dependencyProperty, Object value)
   bei System.Windows.Markup.BamlRecordReader.SetDependencyValue(DependencyObject dependencyObject, DependencyProperty dependencyProperty, Object value)
   bei System.Windows.Markup.BamlRecordReader.SetDependencyComplexProperty(Object currentTarget, BamlAttributeInfoRecord attribInfo, Object o)
   bei System.Windows.Markup.BamlRecordReader.SetPropertyValueToParent(Boolean fromStartTag, Boolean& isMarkupExtension)
   bei System.Windows.Markup.BamlRecordReader.ReadElementEndRecord(Boolean fromNestedBamlRecordReader)
   bei System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
   bei System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
   bei System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
   bei System.Windows.Markup.TreeBuilder.Parse()
   bei System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
   bei System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
   bei AlbumArtDownloader.ArtSearchWindow.InitializeComponent()
   bei AlbumArtDownloader.ArtSearchWindow..ctor()
   bei AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
   bei AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
   bei System.Windows.Application.<.ctor>b__0(Object unused)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.DispatcherOperation.InvokeImpl()
   bei System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   bei System.Threading.ExecutionContext.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   bei System.Windows.Threading.DispatcherOperation.Invoke()
   bei System.Windows.Threading.Dispatcher.ProcessQueue()
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.WrappedInvoke(Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   bei System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   bei System.Windows.Threading.Dispatcher.Run()
   bei System.Windows.Application.RunDispatcher(Object ignore)
   bei System.Windows.Application.RunInternal(Window window)
   bei System.Windows.Application.Run(Window window)
   bei System.Windows.Application.Run()
   bei AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   bei AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   bei AlbumArtDownloader.App.Main(String[] args)

Album Art Downloader XUI

Reply #874 –
Quote from: Adagio on
Installed 0.28.2 over 0.28.1 (as Admin) under Windows 7RC.
Previous versions were running fine.

Argh! How irritating. Someday I'll get this right first time.

Here's 0.28.3 which should fix it. I'm also editing the above release post to point to 0.28.3 too, no sense in pointing to the broken version.

AlbumArtDownloaderXUI.exe

Alex