Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_musicbrainz (Read 281002 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: foo_musicbrainz

Reply #275 –
Dremora might find my requirements are too restrictive and depending on how the components site/update mechanism works, it may break for people running older versions of foobar2000 or are on windows XP.

I did mention before that Vista or later and foobar2000 v1.3 or later are required but I didn't explain why. Here is my reasoning...

Quote from: https://github.com/19379/foo_musicbrainz/blob/master/README.md
Remove deprecated metadb lock/unlock methods and use get_info_ref() from the
current SDK (2015-08-03). Now requires foobar2000 v1.3 or above.

Updated for Visual Studio 2015. I tried building to support Windows XP but failed
therefore Windows Vista or later is required.

I'm sure someone competent could make it work on XP but I'm a total noob whose main area of expertise is copy/paste!!

Re: foo_musicbrainz

Reply #276 –
Compiling for XP is supposed to be as easy as changing the SDK from v120 to v120_xp, but there's no guarantee that it will work. And even then, I had problems getting foo_midi to even build a crash-free binary, so I switched back to using 2010.

Re: foo_musicbrainz

Reply #277 –
Yep, I did try that and while the component loaded fine, not everything would display properly in the main dialog. I did take a screenshot but the link appears to have been lost in the forum upgrade.

https://hydrogenaud.io/index.php/topic,70623.msg912619.html#msg912619

edit: Being the buffoon I am, I didn't even check if the values were populated. If not, that would be a more serious underlying issue that I would have even less chance of fixing. Anyway, isn't it about time foobar itself dropped support for XP?  :D

Re: foo_musicbrainz

Reply #278 –
Just a little more confirmation of my incompetence!

Quote
0.3.3.1
Fix bug where the "Apply" button in the "Preferences" didn't become active when the
"Custom server" checkbox state had changed.

https://github.com/19379/foo_musicbrainz/releases

Re: foo_musicbrainz

Reply #279 –
Quote from: marc2003 on
Dremora might find my requirements are too restrictive and depending on how the components site/update mechanism works, it may break for people running older versions of foobar2000 or are on windows XP.

Oh yes, sure, indeed.
As a matter of fact, I do use XP. :)

Re: foo_musicbrainz

Reply #280 –
I'll try setting up an XP virtual machine and see if I get anywhere but I highly doubt it.

Also, I have yet another update.....and this time, it's not my fault. This bug is present in the original component.

Quote
0.3.3.2
Fix bug where "Reset page" button in the "Preferences" didn't work on all fields.

https://github.com/19379/foo_musicbrainz/releases

Specifically, if you disable the album type/status checkboxes, the text boxes remain disabled when you reset.

Re: foo_musicbrainz

Reply #281 –
Right, the problem I'm having with XP seems directly linked to using this static_cast thingy...

Code: [Select]
static_cast<pfc::string8>(release->get_date())

It works with VS2010 and any OS.
It works with VS2015 and Vista or later
With VS2015 and XP, the value gets nuked.

All other fields which don't need it show up correctly.

http://i.imgur.com/PmNxTcs.jpg

I have no idea how to fix that so if anyone has any ideas??

Re: foo_musicbrainz

Reply #282 –
Maybe this will help?
http://forum.doom9.org/showthread.php?p=1763240#post1763240
Quote
Unfortunately, XP support is partialy broken in VS2015, and it's still the case with Update 2.
 For having a proper support of XP, as it's explained here, you have to compile with the /Zc:threadSafeInit- option, otherwise it will not work.
also:
https://msdn.microsoft.com/en-us/library/y5f6w579.aspx
http://stackoverflow.com/questions/32517234/access-violation-on-static-initialization

but seriously, just let WinXP die.

Re: foo_musicbrainz

Reply #283 –
That has done the trick, thanks.

I've already kicked XP to the kerb with my own component but I thought I'd give this one last try.


Re: foo_musicbrainz

Reply #285 –
Thanks for all the hard work, marc2003. Much appreciated.

Re: foo_musicbrainz

Reply #287 –
Thanks, marc2003! Is it possible to force http somehow? I work behind corporate http-proxy, it doesn't allow https traffic from unknown  sources (I if understand correctly, anyway https-version of plugin doesn't work for me anymore)

Re: foo_musicbrainz

Reply #288 –
Sure. Just use the custom server option in the preferences...

Re: foo_musicbrainz

Reply #289 –
When trying to retrieve tags by TOC for Opus files, this comes up: "Track length in samples must be divisible by 588."

Can support for Opus files (sample rate at 48000Hz) be implemented for retrieving tags by TOC?

Re: foo_musicbrainz

Reply #290 –
What version are you using?

In the last official component and source for my mod, I see the code for popup dialog in the source but I don't see how it gets triggered because there are other checks in place that won't even show the TOC menu items when any track length in samples isn't divisible by 588.

Re: foo_musicbrainz

Reply #291 –
The most recent one from you, 0.3.5. And 0.3.1 before that.

The only thing I can surmise is that this plugin is incompatible with files at sample rates of 48,000Hz, and any other files at sample rates not divisible by 588. And AFAIK, Opus is 48,000Hz by default.

Re: foo_musicbrainz

Reply #292 –
I can attempt to make it work but I don't understand how you were getting the error you reported because when I right click any tracks with a 48000 sampling rate, the TOC menu items are hidden...

Re: foo_musicbrainz

Reply #293 –
Oh sorry, I see what you mean now. I've always been using a custom keyboard shortcut for the action "Get tags from MusicBrainz (by TOC).

I just noticed that getting tags by TOC seems to only work for Vorbis and FLAC. MP3 or AAC trigger "Track length in samples must be divisible by 588", regardless of sample rate.

Thanks for the effort you're putting in!

Re: foo_musicbrainz

Reply #294 –
Ah yes, that explains it. I should be able to fix this but it won't be immediately. I'm spending a lot of my spare time watching the Rio Olympics on TV!!

Re: foo_musicbrainz

Reply #295 –
Quote from: noiselab on
MP3 or AAC trigger "Track length in samples must be divisible by 588", regardless of sample rate.

This should not happen if they are sourced from CD rips. I'm not able to test any AAC at the moment but I have mp3 albums which work fine. You can search your collection to find lossy files that would allow TOC lookups with this query

Code: [Select]
%__encoding% IS lossy AND "$mod(%length_samples%,588)" IS 0

If I use this query to find tracks that I can't lookup, most of mine are from amazon/itunes.

Code: [Select]
%__encoding% IS lossy AND NOT "$mod(%length_samples%,588)" IS 0

These shouldn't be on musicbrainz because it is for CD sourced discids only. In fact, the next version will only allow TOC submissions from lossless files.

Re: foo_musicbrainz

Reply #296 –
Well I did it quicker than expected.

Code: [Select]
0.3.6

Allow TOC lookups from files with a sample rate of 48000 Hz such as Opus. Track sample
count must still match CD frame boundaries.

Enforce stricter checks for TOC submissions so only lossless files are supported. This
affects MusicBrainz editors only.

Prevent background lookups if above TOC checks fail.

https://github.com/19379/foo_musicbrainz/releases

Re: foo_musicbrainz

Reply #297 –
Thanks so much! This update is very helpful and saves me so much time

Quote from: marc2003 on
Quote from: noiselab on
MP3 or AAC trigger "Track length in samples must be divisible by 588", regardless of sample rate.

This should not happen if they are sourced from CD rips. I'm not able to test any AAC at the moment but I have mp3 albums which work fine. You can search your collection to find lossy files that would allow TOC lookups with this query
You're right; the files need be sourced from CDs. That makes sense.

Re: foo_musicbrainz

Reply #299 –
Somehow Musicbrainz context menu doesn't show up for releases with more than 99 tracks